1d7588d81f288dccd9cc6aea15f7ae40179bc177
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-17  Gustavo Noronha Silva  <gns@gnome.org>
2
3         [GTK] Make the 32 bits bot only build and run API tests
4         https://bugs.webkit.org/show_bug.cgi?id=113532
5
6         Reviewed by Martin Robinson.
7
8         * BuildSlaveSupport/build.webkit.org-config/config.json: make the 32 bits bot use the new BuildAndAPITest type
9         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10         (BuildAndAPITestFactory): new factory that builds and runs API tests, only used by the GTK+ 32 bits bot at the
11         moment;
12         (BuildAndAPITestFactory.__init__): add API tests step for platforms that have it.
13
14 2013-04-19  Andras Becsi  <andras.becsi@digia.com>
15
16         [Qt] Only use thin archives on Linux
17
18         Rubber-stamped by Jocelyn Turcotte.
19
20         Since "thin archive" is a feature of GNU's ar
21         we limit the usage to Linux to avoid problems
22         with other configurations (eg. macx-g++).
23
24         * qmake/mkspecs/features/default_pre.prf:
25
26 2013-04-19  Krzysztof Czech  <k.czech@samsung.com>
27
28         [GTK][WK2] accessibility/language-attribute.html is failing
29         https://bugs.webkit.org/show_bug.cgi?id=106342
30
31         Reviewed by Gyuyoung Kim.
32
33         Adds support for getting language information.
34
35         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
36         (WTR::AccessibilityUIElement::language):
37
38 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
39
40         [Dashboard] Remove the isToTWebKit member variable from the BuilderGroup interface
41         https://bugs.webkit.org/show_bug.cgi?id=114805
42
43         Reviewed by Benjamin Poulain.
44
45         Remove the isToTWebKit member variable from the BuilderGroup and all its usages as it now defaults to true for every
46         builder group. The isTipOfTreeWebKitBuilder method now returns true by default but should be removed in a follow-up patch.
47         The BuilderGroup constructor does not accept the isToTWebKit parameter anymore so all the callsites are adjusted accordingly.
48
49         * TestResultServer/static-dashboards/builders.js:
50         (BuilderGroup):
51         (loadBuildersList):
52         * TestResultServer/static-dashboards/dashboard_base.js:
53         (isTipOfTreeWebKitBuilder):
54         (expectationsMap):
55         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
56         (test):
57
58 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
59
60         [Dashboard] htmlForIndividualTests unit test should include its dummy builder under the webkit.org builder master
61         https://bugs.webkit.org/show_bug.cgi?id=114804
62
63         Reviewed by Benjamin Poulain.
64
65         The htmlForIndividualTests unit test should include its dummy builder under the sole supported webkit.org builder master
66         just so the unit tests properly functions.
67
68         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
69
70 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
71
72         [Dashboard] Remove Chromium-specific helper functions that were used in the builder-loading code
73         https://bugs.webkit.org/show_bug.cgi?id=114803
74
75         Reviewed by Benjamin Poulain.
76
77         Remove three Chromium-specific helper functions that were used to determine Chromium DEPS, Content Shell and WebKit ToT
78         test runners. These are not required anymore and thus removed along with a couple of unit tests that were testing these
79         methods' correct behavior.
80
81         * TestResultServer/static-dashboards/builders.js:
82         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
83
84 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
85
86         [Dashboard] Remove the Chromium-specific builder masters
87         https://bugs.webkit.org/show_bug.cgi?id=114802
88
89         Reviewed by Benjamin Poulain.
90
91         Remove all the Chromium-specific builder masters, the webkit.org builder master is the only one currently supported.
92
93         * TestResultServer/static-dashboards/builders.js:
94
95 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
96
97         [Dashboard] Remove all the Chromium-specific builder groups
98         https://bugs.webkit.org/show_bug.cgi?id=114801
99
100         Reviewed by Benjamin Poulain.
101
102         Remove all the Chromium-specific builder groups, all of these are not supported anymore.
103
104         * TestResultServer/static-dashboards/builders.js:
105
106 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
107
108         [Dashboard] Only accept the 'group' parameter if present in the layout tests builders group
109         https://bugs.webkit.org/show_bug.cgi?id=114799
110
111         Reviewed by Benjamin Poulain.
112
113         The layout tests builder group is the only one supported, all the other Chromium-specific builder groups are
114         bound to be removed.
115
116         * TestResultServer/static-dashboards/history.js:
117         (.):
118
119 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
120
121         [Dashboard] Remove Chromium-specific builder loading code from loadBuildersList
122         https://bugs.webkit.org/show_bug.cgi?id=114797
123
124         Reviewed by Benjamin Poulain.
125
126         Remove anything Chromium-specific from the builder-loading code, specifically removing support for loading builder data
127         for anything other that the layout-tests type and removing support for loading builder data from builders connected
128         to the Chromium-specific builder groups which are no longer supported.
129
130         * TestResultServer/static-dashboards/builders.js:
131
132 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
133
134         [Dashboard] The currentBuilderGroupCategory method should return the layout tests builder groups by default
135         https://bugs.webkit.org/show_bug.cgi?id=114796
136
137         Reviewed by Benjamin Poulain.
138
139         With the Chromium builders no longer uploading results and the layout-tests test type the only one supported by the
140         WebKit's dashboard, the currentBuilderGroupCategory can now return LAYOUT_TESTS_BUILDER_GROUPS as the default builder
141         group category.
142
143         * TestResultServer/static-dashboards/dashboard_base.js:
144         (currentBuilderGroupCategory):
145
146 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
147
148         [Dashboard] Narrow down the test types list to only layout-tests
149         https://bugs.webkit.org/show_bug.cgi?id=114795
150
151         Reviewed by Ryosuke Niwa.
152
153         Remove all the redundant test types that the webkit.org builders do not upload results for. All of the removed
154         test types were specific to the Chromium builders.
155
156         * TestResultServer/static-dashboards/dashboard_base.js:
157
158 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
159
160         [Dashboard] The revision rows for aggregate results should no longer include Chromium revisions
161         https://bugs.webkit.org/show_bug.cgi?id=114760
162
163         Reviewed by Benjamin Poulain.
164
165         With the Chromium builders no longer present there's no need to display the Chromium revision range under the
166         aggregate results. Only the first half of the htmlForRevisionRows method (the one returning the table row listing the
167         WebKit revisions) is now relevant - the method is therefor removed and its callsites updated to directly call the
168         htmlForTableRow method that returns the table row containing all the relevant WebKit revisions.
169
170         * TestResultServer/static-dashboards/aggregate_results.js:
171         (htmlForSummaryTable):
172         (htmlForTestType):
173
174 2013-04-19  Zan Dobersek  <zdobersek@igalia.com>
175
176         [Dashboard] Remove Chromium-specific cases from the construction of the chart HTML for aggregate results
177         https://bugs.webkit.org/show_bug.cgi?id=114759
178
179         Reviewed by Benjamin Poulain.
180
181         Aggregate results are not viewable for Chromium builders anymore, meaning the WebKit revisions are shown by default.
182         This means the code in the chartHTML method can be simplified, defaulting the revision key to WEBKIT_REVISIONS_KEY
183         and the revision label to 'WebKit Revision'.
184
185         * TestResultServer/static-dashboards/aggregate_results.js:
186         (chartHTML):
187
188 2013-04-18  Xuefei Ren  <xren@blackberry.com>
189
190         remove build warning(unused parameter)
191         https://bugs.webkit.org/show_bug.cgi?id=114670
192
193         Reviewed by Rob Buis.
194
195         remove builde warning (unused parameter) in
196         Tools/DumpRenderTree/blackberry
197
198         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
199         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
200         (AccessibilityUIElement::scrollToGlobalPoint):
201         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
202         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
203         (BlackBerry::WebKit::DumpRenderTree::didReceiveResponseForFrame):
204         * DumpRenderTree/blackberry/EventSender.cpp:
205         (getDragModeCallback):
206         (setDragModeCallback):
207         (mouseWheelToCallback):
208         (contextClickCallback):
209         (mouseDownCallback):
210         (mouseUpCallback):
211         (mouseMoveToCallback):
212         (beginDragWithFilesCallback):
213         (leapForwardCallback):
214         (keyDownCallback):
215         (textZoomInCallback):
216         (textZoomOutCallback):
217         (zoomPageInCallback):
218         (zoomPageOutCallback):
219         (addTouchPointCallback):
220         (updateTouchPointCallback):
221         (setTouchModifierCallback):
222         (touchStartCallback):
223         (touchCancelCallback):
224         (touchMoveCallback):
225         (touchEndCallback):
226         (clearTouchPointsCallback):
227         (cancelTouchPointCallback):
228         (releaseTouchPointCallback):
229         (scalePageByCallback):
230         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
231         (TestRunner::authenticateSession):
232         (TestRunner::setSpatialNavigationEnabled):
233         (TestRunner::apiTestNewWindowDataLoadBaseURL):
234         (TestRunner::setPluginsEnabled):
235         (TestRunner::setApplicationCacheOriginQuota):
236         (TestRunner::addMockSpeechInputResult):
237         (TestRunner::setViewModeMediaFeature):
238         (TestRunner::deleteLocalStorageForOrigin):
239         (TestRunner::applicationCacheDiskUsageForOrigin):
240         (TestRunner::grantWebNotificationPermission):
241         (TestRunner::denyWebNotificationPermission):
242         (TestRunner::simulateWebNotificationClick):
243         (TestRunner::simulateLegacyWebNotificationClick):
244
245 2013-04-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
246
247         [WK2][EFL] Text Checker's settings refactor
248         https://bugs.webkit.org/show_bug.cgi?id=111713
249
250         Reviewed by Andreas Kling.
251
252         * MiniBrowser/efl/main.c:
253         (window_create):
254         Use a new text checker API to enable spell checking.
255
256 2013-04-18  Seokju Kwon  <seokju.kwon@gmail.com>
257
258         [EFL] Add a newline to the end of log message
259         https://bugs.webkit.org/show_bug.cgi?id=114659
260
261         Reviewed by Gyuyoung Kim.
262
263         Move a newline to info() definition.
264
265         * EWebLauncher/main.c:
266         (on_load_finished):
267         (on_tooltip_text_set):
268         (on_tooltip_text_unset):
269         (on_inputmethod_changed):
270         (on_focus_out):
271         (on_focus_in):
272         (on_key_down):
273         (windowCreate):
274         * MiniBrowser/efl/main.c:
275         (on_key_down):
276         (on_download_request):
277         (on_download_finished):
278         (on_download_failed):
279         (on_refresh_button_clicked):
280         (on_popup_menu_discarded):
281         (on_popup_menu_item_clicked):
282         (popup_menu_populate):
283         (on_popup_menu_show):
284         (on_window_create):
285         (context_popup_item_selected_cb):
286         (on_context_menu_show):
287         (on_context_menu_hide):
288         (window_create):
289
290 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
291
292         [Dashboard] Remove code for showing 'WebKit roll' annotations in timelines for Chromium builders
293         https://bugs.webkit.org/show_bug.cgi?id=114755
294
295         Reviewed by Ryosuke Niwa.
296
297         The Chromium builders are no longer available to inspect so there's no need for the code that used to show
298         the 'WebKit roll' annotations in the Chromium builders' timeline.
299
300         * TestResultServer/static-dashboards/timeline_explorer.js:
301
302 2013-04-17  Zan Dobersek  <zandobersek@gmail.com>
303
304         [Dashboard] Clean up the timeline updating code, removing Chromium-specific cases
305         https://bugs.webkit.org/show_bug.cgi?id=114756
306
307         Reviewed by Ryosuke Niwa.
308
309         Clean up the updating of the timeline in the timeline explorer, defaulting to the webkit.org build master when
310         constructing the results URL and removing the possible row addition containing the Chromium commit range that
311         only applied to Chromium builders in the first place. Also removes the now-redundant shouldShowWebKitRevisionsOnly
312         method.
313
314         * TestResultServer/static-dashboards/timeline_explorer.js:
315
316 2013-04-17  Alberto Garcia  <agarcia@igalia.com>
317
318         media-stream and xslt are no longer configurable options in the GTK+ port
319         https://bugs.webkit.org/show_bug.cgi?id=114736
320
321         Reviewed by Martin Robinson.
322
323         media-stream support was removed in r145199 and XSLT is a hard
324         requirement since r145859. Attempting to pass those options to the
325         configure script, only results in a warning.
326
327         * Scripts/webkitdirs.pm:
328         (buildAutotoolsProject):
329
330 2013-04-17  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
331
332         [EFL][WK2] Implement context menu in MiniBrowser
333         https://bugs.webkit.org/show_bug.cgi?id=102932
334
335         Reviewed by Gyuyoung Kim.
336
337         Added context menu support for EFL port using Elementary context popup.
338
339         * MiniBrowser/efl/main.c:
340         (_Browser_Window):
341         (context_popup_item_selected_cb):
342         (context_popup_populate):
343         (on_context_menu_show):
344         (on_context_menu_hide):
345         (window_create):
346
347 2013-04-17  Csaba Osztrogonác  <ossy@webkit.org>
348
349         REGRESSION(r148588): It broke the Qt WK2 EWS
350         https://bugs.webkit.org/show_bug.cgi?id=114737
351
352         Reviewed by Jocelyn Turcotte.
353
354         * Scripts/webkitpy/common/config/ews.json: "Qt WK2 EWS" should use qt-wk2 port.
355         * Scripts/webkitpy/common/config/ports.py:
356         (DeprecatedPort.port):
357         (QtPort.build_webkit_command): qt port shouldn't build WebKit2.
358         (QtPort.run_webkit_tests_command): qt port runs WK1 tests.
359         (QtWK2Port): Added.
360         (QtWK2Port.build_webkit_command): qt-wk2 port builds WK1 and WK2 too.
361         (QtWK2Port.run_webkit_tests_command): qt-wk2 port runs WK2 tests.
362         * Scripts/webkitpy/common/config/ports_unittest.py:
363         (DeprecatedPortTest.test_qt_port):
364         (DeprecatedPortTest):
365         (DeprecatedPortTest.test_qt_wk2_port):
366
367 2013-04-17  Zan Dobersek  <zdobersek@igalia.com>
368
369         Unreviewed.
370
371         * Scripts/webkitpy/common/config/ports_unittest.py:
372         (DeprecatedPortTest.test_efl_port): Adjusting the expected outcome of the EFL build-webkit command after r148589.
373
374 2013-04-17  Allan Sandfeld Jensen  <allan.jensen@digia.com>
375
376         [Qt] Enable sub-pixel layout.
377         https://bugs.webkit.org/show_bug.cgi?id=113199
378
379         Reviewed by Jocelyn Turcotte.
380
381         * qmake/mkspecs/features/features.pri:
382
383 2013-04-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
384
385         Add Efl WebKit2 EWS bot
386         https://bugs.webkit.org/show_bug.cgi?id=114564
387
388         Reviewed by Ryosuke Niwa.
389
390         Added EflWK2EWS, and add myself a watcher for EflWK2EWS.
391         Also add a deprecated EflWK2Port class.
392
393         Besides clean up eflews watchers.
394
395         * QueueStatusServer/config/queues.py:
396         * Scripts/webkitpy/common/config/ews.json:
397         * Scripts/webkitpy/common/config/ports.py:
398         (DeprecatedPort.port):
399         (EflPort.build_webkit_command):
400         (EflWK2Port):
401         (EflWK2Port.build_webkit_command):
402
403 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
404
405         Isolate Early Warning System definitions into a JSON
406         https://bugs.webkit.org/show_bug.cgi?id=114558
407
408         Reviewed by Benjamin Poulain.
409
410         Added ews.json to common/config, and made tool/commands/__init__.py call
411         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
412
413         Reland the patch since the EWS failure was a false positive.
414
415         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
416         * Scripts/webkitpy/tool/commands/__init__.py:
417         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
418         (AbstractEarlyWarningSystem):
419         (AbstractEarlyWarningSystem.__init__):
420         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
421         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
422         (EarlyWarningSystemTest._default_expected_logs):
423         (_test_ews):
424         (test_ewses):
425
426 2013-04-16  Sam Weinig  <sam@webkit.org>
427
428         Fix fallout after r148545.
429
430         * WebKitTestRunner/TestController.cpp:
431         (WTR::TestController::resetStateToConsistentValues):
432         Remove calls to non-existent API functions.
433
434 2013-04-13  Roger Fong  <roger_fong@apple.com>
435
436         Unreviewed. Disable WinEWS tests, simply not enough bots.
437
438         All bots are running consistently now but the queue still keeps growing.
439         Until we get more bots or make the tests faster, it doesn't seem wise to keep running tests.
440
441         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
442         (WinEWS):
443
444 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
445
446         The list of contributors in committers.py should be a separate JSON
447         https://bugs.webkit.org/show_bug.cgi?id=114673
448
449         Reviewed by Anders Carlsson.
450
451         Added webkitpy/common/config/contributors.json, made CommitterList load it.
452
453         * EWSTools/start-queue-mac.sh:
454         * EWSTools/start-queue.sh:
455         * Scripts/webkitpy/common/checkout/commitinfo.py:
456         (CommitInfo.committer):
457         * Scripts/webkitpy/common/config/contributors.json: Added.
458         * Scripts/webkitpy/common/config/committers.py:
459         (Reviewer.__init__):
460         (CommitterList.__init__):
461         (CommitterList.load_json): Added.
462         (CommitterList.load_json.emails):
463         (CommitterList.load_json.nicks):
464         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
465         (MockCommitInfo.author):
466
467 2013-04-16  Manuel Rego Casasnovas  <rego@igalia.com>
468
469         [EFL] Bump libsoup dependency to 2.42.0
470         https://bugs.webkit.org/show_bug.cgi?id=113927
471
472         Reviewed by Gyuyoung Kim.
473
474         Update libsoup required version to v2.42.0 and GLib to v2.36.0 as
475         required by libsoup for EFL port.
476
477         * efl/jhbuild.modules:
478         * efl/patches/libsoup-2.40-auth-fix.patch: Removed as it's already
479         included in v2.42.0.
480
481 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
482
483         Remove Account class from committers.py
484         https://bugs.webkit.org/show_bug.cgi?id=114671
485
486         Reviewed by Csaba Osztrogonác.
487
488         Account class was added to support watch list email addresses that are not associated with
489         a particular contributor but nobody uses these email address since Chromium port forked.
490
491         Remove it.
492
493         Also removed account_by_login from CommitterList since it was never called except its unittests.
494
495         * Scripts/webkitpy/common/checkout/changelog.py:
496         * Scripts/webkitpy/common/config/committers.py:
497         (Contributor):
498         (Contributor.matches_glob):
499         (Reviewer.__init__):
500         (CommitterList.__init__):
501         (CommitterList._email_to_account_map):
502         (CommitterList._login_to_account_map):
503         (CommitterList.contributors_by_fuzzy_match):
504         (CommitterList.contributor_by_email):
505         (CommitterList.contributor_by_name):
506         (CommitterList.committer_by_email):
507         (CommitterList.reviewer_by_email):
508         * Scripts/webkitpy/common/config/committers_unittest.py:
509         (CommittersTest.test_committer_lookup):
510         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
511         (Bugzilla._commit_queue_flag):
512         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
513         (test_commit_queue_flag):
514         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
515         (WatchListParser._validate):
516
517 2013-04-16  Mike West  <mkwst@chromium.org>
518
519         Unreviewed update to the watchlist.
520
521         Removing 'mkwst+watchlist@chromium.org' from committers.py and the
522         watchist file; moving to 'mkwst@chromium.org' instead.
523
524         * Scripts/webkitpy/common/config/committers.py:
525         * Scripts/webkitpy/common/config/watchlist:
526
527 2013-04-16  Ryosuke Niwa  <rniwa@webkit.org>
528
529         Move webkitpy.layout_tests.port to webkitpy.port
530         https://bugs.webkit.org/show_bug.cgi?id=114668
531
532         Reviewed by Maciej Stachowiak.
533
534         Moved. Port objects knows a lot more than just layout_tests. They doesn't belong down in layout_tests.
535
536         * Scripts/webkitpy/common/host.py:
537         * Scripts/webkitpy/common/host_mock.py:
538         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
539         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
540         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
541         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
542         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
543         * Scripts/webkitpy/layout_tests/port: Removed.
544         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
545         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
546         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
547         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
548         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
549         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
550         * Scripts/webkitpy/performance_tests/perftest.py:
551         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
552         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
553         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
554         * Scripts/webkitpy/port: Copied from Tools/Scripts/webkitpy/layout_tests/port.
555         * Scripts/webkitpy/port/apple.py:
556         * Scripts/webkitpy/port/base.py:
557         * Scripts/webkitpy/port/base_unittest.py:
558         * Scripts/webkitpy/port/config_unittest.py:
559         (ConfigTest.test_default_configuration__standalone):
560         * Scripts/webkitpy/port/driver_unittest.py:
561         * Scripts/webkitpy/port/efl.py:
562         * Scripts/webkitpy/port/efl_unittest.py:
563         * Scripts/webkitpy/port/factory.py:
564         * Scripts/webkitpy/port/factory_unittest.py:
565         * Scripts/webkitpy/port/gtk.py:
566         * Scripts/webkitpy/port/gtk_unittest.py:
567         * Scripts/webkitpy/port/image_diff.py:
568         * Scripts/webkitpy/port/image_diff_unittest.py:
569         * Scripts/webkitpy/port/leakdetector_unittest.py:
570         * Scripts/webkitpy/port/mac.py:
571         * Scripts/webkitpy/port/mac_unittest.py:
572         * Scripts/webkitpy/port/mock_drt.py:
573         * Scripts/webkitpy/port/mock_drt_unittest.py:
574         * Scripts/webkitpy/port/port_testcase.py:
575         * Scripts/webkitpy/port/qt.py:
576         * Scripts/webkitpy/port/qt_unittest.py:
577         * Scripts/webkitpy/port/server_process_unittest.py:
578         * Scripts/webkitpy/port/test.py:
579         * Scripts/webkitpy/port/win.py:
580         * Scripts/webkitpy/port/win_unittest.py:
581         * Scripts/webkitpy/port/xvfbdriver.py:
582         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
583         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
584         * Scripts/webkitpy/tool/commands/gardenomatic.py:
585         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
586         * Scripts/webkitpy/tool/commands/queries.py:
587         * Scripts/webkitpy/tool/commands/queries_unittest.py:
588         * Scripts/webkitpy/tool/commands/rebaseline.py:
589         * Scripts/webkitpy/tool/servers/gardeningserver.py:
590         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
591         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
592         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
593
594 2013-04-16  Commit Queue  <rniwa@webkit.org>
595
596         Unreviewed, rolling out r148498.
597         http://trac.webkit.org/changeset/148498
598         https://bugs.webkit.org/show_bug.cgi?id=114669
599
600         Appears to have broken EWS (Requested by rniwa on #webkit).
601
602         * Scripts/webkitpy/common/config/ews.json: Removed.
603         * Scripts/webkitpy/tool/commands/__init__.py:
604         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
605         (AbstractEarlyWarningSystem):
606         (AbstractEarlyWarningSystem.__init__):
607         (AbstractEarlyWarningSystem.handle_script_error.does):
608         (GtkEWS):
609         (GtkWK2EWS):
610         (EflEWS):
611         (QtEWS):
612         (QtWK2EWS):
613         (WinEWS):
614         (MacEWS):
615         (MacWK2EWS):
616         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
617         (EarlyWarningSystemTest._default_expected_logs):
618         (_test_ews):
619         (test_ewses):
620
621 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
622
623         Isolate Early Warning System definitions into a JSON
624         https://bugs.webkit.org/show_bug.cgi?id=114558
625
626         Reviewed by Benjamin Poulain.
627
628         Added ews.json to common/config, and made tool/commands/__init__.py call
629         AbstractEarlyWarningSystem.load_ews_classes to instantiate classes based on ews.json.
630
631         * Scripts/webkitpy/common/config/ews.json: Extracted from earlywarningsystem.py.
632         * Scripts/webkitpy/tool/commands/__init__.py:
633         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
634         (AbstractEarlyWarningSystem):
635         (AbstractEarlyWarningSystem.__init__):
636         (AbstractEarlyWarningSystem.load_ews_classes): Added. Loads ews.json.
637         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
638         (EarlyWarningSystemTest._default_expected_logs):
639         (_test_ews):
640         (test_ewses):
641
642 2013-04-15  Ryosuke Niwa  <rniwa@webkit.org>
643
644         WKR gets stuck when there are many merges
645         https://bugs.webkit.org/show_bug.cgi?id=114632
646
647         Reviewed by Andreas Kling.
648
649         Move the last revision forward when it exists in a branch.
650         Otherwise, we'll be stuck looping over revisions made to merge patches.
651
652         * Scripts/webkitpy/tool/commands/newcommitbot.py:
653         (NewCommitBot.next_work_item):
654
655 2013-04-15  Gustavo Noronha Silva  <gns@gnome.org>
656
657         [GTK] Missing a few packages for building on stock Fedora
658         https://bugs.webkit.org/show_bug.cgi?id=113916
659
660         Reviewed by Philippe Normand.
661
662         * gtk/install-dependencies: add packages that are missing.
663
664 2013-04-15  Zan Dobersek  <zdobersek@igalia.com>
665
666         REGRESSION (r148360): Failure in webkitpy.tool.multicommandtool_unittest.MultiCommandToolTest.test_command_help
667         https://bugs.webkit.org/show_bug.cgi?id=114602
668
669         Reviewed by Ryosuke Niwa.
670
671         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
672         (CommandTest.test_required_arguments): Reset the static argument_names variable on the TrivialCommand
673         interface so its value doesn't leak into the following tests.
674
675 2013-04-15  Zan Dobersek  <zandobersek@gmail.com>
676
677         Deprecate land-cowboy in favor of land-cowhand
678         https://bugs.webkit.org/show_bug.cgi?id=104470
679
680         Reviewed by Darin Adler.
681
682         Move the LandCowboy command implementation under the LandCowhand command and deprecate the former.
683
684         * Scripts/webkitpy/tool/commands/download.py:
685         (LandCowhand):
686         (LandCowboy):
687         (LandCowboy._prepare_state):
688         * Scripts/webkitpy/tool/commands/download_unittest.py:
689         (test_land_cowhand): Adjust the unit tests by testing both LandCowhand and LandCowboy,
690         also checking the deprecation message in the output of the latter.
691
692 2013-04-15  Jonathan Liu  <net147@gmail.com>
693
694         Improve Windows cmd.exe detection
695         https://bugs.webkit.org/show_bug.cgi?id=114620
696
697         Reviewed by Jocelyn Turcotte.
698
699         The current detection code handles Windows cmd.exe and Cygwin shell
700         but not does not handle MSYS shell correctly. Simplify and improve the
701         detection by checking MINGW_IN_SHELL instead as used in other places
702         (e.g. qt_functions.prf).
703
704         * qmake/mkspecs/features/default_pre.prf:
705
706 2013-04-15  Manuel Rego Casasnovas  <rego@igalia.com>
707
708         [webkitpy] Use $NUMBER_OF_PROCESSORS in Executive.cpu_count()
709         https://bugs.webkit.org/show_bug.cgi?id=114506
710
711         Reviewed by Philippe Normand.
712
713         * Scripts/webkitpy/common/system/executive.py:
714         (Executive.cpu_count): Modify function in order to use the environment
715         variable $NUMBER_OF_PROCESSORS if it is defined and it is an integer
716         greater than 0.
717
718 2013-04-15  Xan Lopez  <xlopez@igalia.com>
719
720         [BlackBerry] ASSERT in StyleResolver::ensureScopeResolver()
721         https://bugs.webkit.org/show_bug.cgi?id=114615
722
723         Reviewed by Carlos Garcia Campos.
724
725         Enable the style scoped feature if we have support for it.
726
727         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
728         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
729
730 2013-04-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
731
732         [Qt] QtMultimedia not used when GStreamer is not found
733         https://bugs.webkit.org/show_bug.cgi?id=111842
734
735         Reviewed by Philippe Normand.
736
737         Fallback to using QtMultimedia when native libraries are not found.
738
739         * qmake/mkspecs/features/features.prf:
740
741 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
742
743         Build fix attempt for webkitbot. Unicodify everything.
744
745         * Scripts/webkitpy/tool/bot/irc_command.py:
746         (Whois.execute):
747
748 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
749
750         webkitbot should provide full name, email address, and IRC nicknames on whois
751         https://bugs.webkit.org/show_bug.cgi?id=114494
752
753         Reviewed by Benjamin Poulain.
754
755         A response like the one below is useless. Improve it:
756         webkitbot: rniwa: zdobersek is zdobersek (zandobersek@gmail.com). Why do you ask?
757
758         We now report full name, email address, committer/reviewer status, and IRC nickname.
759
760         Also teach webkitbot how to respond to ping.
761
762         * Scripts/webkitpy/tool/bot/irc_command.py:
763         (PingPong): Moved 
764         (PingPong.execute):
765         (Whois._full_record_and_nick): Renamed and rewritten.
766         (Whois.execute):
767
768         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
769         (IRCCommandTest.test_whois): Updated test cases as needed.
770
771         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
772         (IRCBotTest.test_help): Added ping.
773
774         * Scripts/webkitpy/tool/commands/newcommitbot.py:
775         (NewCommitBot): Teached WKR how to respond to hi.
776
777 2013-04-13  Anders Carlsson  <andersca@apple.com>
778
779         Add form delegate method that's invoked right before sending a submit event to a form element
780         https://bugs.webkit.org/show_bug.cgi?id=114575
781
782         Reviewed by Dan Bernstein.
783
784         Add a test.
785
786         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
787         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm: Added.
788         (-[FormDelegate willSendSubmitEventToForm:inFrame:withValues:]):
789         (TestWebKitAPI):
790         (TestWebKitAPI::TEST):
791         
792         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
793         (TestWebKitAPI::Util::toSTD):
794         Don't crash when a null NSString is passed to toSTD.
795
796 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
797
798         Python test fix attempt after r148360.
799
800         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
801         (test_command_help):
802
803 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
804
805         Merge AbstractDeclarativeCommand into Command as a comment suggests
806         https://bugs.webkit.org/show_bug.cgi?id=114559
807
808         Reviewed by Antti Koivisto.
809
810         Merged two classes as the comment right above AbstractDeclarativeCommand suggested.
811         We need to merge a lot more classes to make webkitpy hackable.
812
813         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
814         (AbstractLocalServerCommand):
815         (AbstractLocalServerCommand.__init__):
816         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
817         (AbstractSequencedCommand):
818         (AbstractSequencedCommand.__init__):
819         * Scripts/webkitpy/tool/commands/adduserstogroups.py:
820         (AddUsersToGroups):
821         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
822         (AnalyzeChangeLog):
823         (AnalyzeChangeLog.__init__):
824         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
825         * Scripts/webkitpy/tool/commands/bugfortest.py:
826         (BugForTest):
827         * Scripts/webkitpy/tool/commands/bugsearch.py:
828         (BugSearch):
829         * Scripts/webkitpy/tool/commands/chromechannels.py:
830         (ChromeChannels):
831         (__init__):
832         * Scripts/webkitpy/tool/commands/download.py:
833         (AbstractPatchProcessingCommand):
834         * Scripts/webkitpy/tool/commands/findusers.py:
835         (FindUsers):
836         * Scripts/webkitpy/tool/commands/openbugs.py:
837         (OpenBugs):
838         * Scripts/webkitpy/tool/commands/queries.py:
839         (BugsToCommit):
840         (PatchesInCommitQueue):
841         (PatchesToCommitQueue):
842         (PatchesToCommitQueue.__init__):
843         (PatchesToReview):
844         (PatchesToReview.__init__):
845         (PatchesToReview.execute):
846         (WhatBroke):
847         (ResultsFor):
848         (FailureReason):
849         (FindFlakyTests):
850         (TreeStatus):
851         (CrashLog):
852         (PrintExpectations):
853         (PrintExpectations.__init__):
854         (PrintBaselines):
855         (PrintBaselines.__init__):
856         * Scripts/webkitpy/tool/commands/queues.py:
857         (AbstractQueue.__init__):
858         * Scripts/webkitpy/tool/commands/rebaseline.py:
859         (AbstractRebaseliningCommand):
860         * Scripts/webkitpy/tool/commands/suggestnominations.py:
861         (SuggestNominations):
862         (SuggestNominations.__init__):
863         * Scripts/webkitpy/tool/commands/upload.py:
864         (CommitMessageForCurrentDiff):
865         (CommitMessageForCurrentDiff.__init__):
866         (CleanPendingCommit):
867         (CleanReviewQueue):
868         (AssignToCommitter):
869         (PostCommits):
870         (PostCommits.__init__):
871         (MarkBugFixed):
872         (MarkBugFixed.__init__):
873         (CreateBug):
874         (CreateBug.__init__):
875         * Scripts/webkitpy/tool/multicommandtool.py:
876         (Command):
877         (Command.__init__):
878         (Command.main):
879         (HelpCommand):
880         (HelpCommand.__init__):
881         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
882         (TrivialCommand):
883         (TrivialCommand.__init__):
884         (LikesToRetry):
885         (LikesToRetry.__init__):
886         (CommandTest.test_name_with_arguments):
887         (CommandTest.test_required_arguments):
888         (test_command_help):
889
890 2013-04-13  Ed Bartosh  <bartosh@gmail.com>
891
892         [EFL] --minimal build fails with error: 'ViewModeInvalid' is not a member of 'WebCore::Page'
893         https://bugs.webkit.org/show_bug.cgi?id=114048
894
895         Reviewed by Gyuyoung Kim.
896
897         Wrapped view media related code in #if ENABLE(VIEW_MODE_CSS_MEDIA)
898
899         * DumpRenderTree/efl/TestRunnerEfl.cpp:
900         (TestRunner::setViewModeMediaFeature):
901
902 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
903
904         Merge watchlistloader into host since it's an unnecessary indirection
905         https://bugs.webkit.org/show_bug.cgi?id=114555
906
907         Reviewed by Antti Koivisto.
908
909         We don't need a class to load a file.
910
911         * Scripts/webkitpy/common/host.py:
912         (Host.watch_list):
913         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Removed.
914         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Removed.
915
916 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
917
918         Rename JSONResultsGeneratorBase to JSONResultsGenerator
919         https://bugs.webkit.org/show_bug.cgi?id=114553
920
921         Reviewed by Philippe Normand.
922
923         Renamed now that we've got rid of the old JSONResultsGenerator in r148352.
924
925         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
926         (JSONLayoutResultsGenerator):
927         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
928         (JSONResultsGenerator):
929         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
930         (JSONGeneratorTest._test_json_generation):
931         (JSONGeneratorTest._verify_json_results):
932
933 2013-04-13  Ryosuke Niwa  <rniwa@webkit.org>
934
935         Remove more Chromium specific code from webkitpy
936         https://bugs.webkit.org/show_bug.cgi?id=114552
937
938         Reviewed by Philippe Normand.
939
940         * Scripts/webkitpy/common/host.py:
941         (Host.checkout):
942         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
943         (JSONResultsGeneratorBase):
944         (JSONResultsGeneratorBase.__init__):
945         (JSONResultsGeneratorBase._is_results_all_of_type):
946         * Scripts/webkitpy/layout_tests/port/base.py:
947         (Port):
948         (Port.expected_filename):
949         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
950         (PerfTestsRunner._parse_args):
951         * Scripts/webkitpy/tool/commands/queues.py:
952         (PatchProcessingQueue._new_port_name_from_old):
953         (CommitQueue.did_pass_testing_ews):
954         * Scripts/webkitpy/tool/commands/rebaseline.py:
955         (RebaselineTest._results_url):
956         (Rebaseline._builder_with_name):
957         * Scripts/webkitpy/tool/mocktool.py:
958         (MockTool.irc):
959
960 2013-04-13  Zan Dobersek  <zdobersek@igalia.com>
961
962         Fix flakiness dashboard unit test failures
963         https://bugs.webkit.org/show_bug.cgi?id=114518
964
965         Reviewed by Ryosuke Niwa.
966
967         Fix the current failures in unit tests for the flakiness dashboard by adjusting failing
968         test cases to simulate loading the builders list from the webkit.org build master, replacing
969         the Chromium builders and platforms that are used in tests with builders and platforms for the
970         Apple Mac Lion WebKit2 port, and removing two test cases that were testing Chromium-specific
971         functionality of the dashboard.
972
973         This is sort of an interlude to the flakiness dashboard cleanup, with the removal of Chromium-specific
974         code and hopefully general simplification of the dashboard codebase coming in near future.
975
976         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
977         (resetGlobals):
978         (test):
979         * TestResultServer/static-dashboards/loader_unittests.js:
980
981 2013-04-12  David Kilzer  <ddkilzer@apple.com>
982
983         BUILD FIX: Make AccessibilityUIElementIOS.mm build on iOS
984
985         Reviewed by Chris Fleizach.
986
987         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Declare
988         -_accessibilityPath from the WebAccessibilityObjectWrapper
989         class.
990         (_CGPathEnumerationIteration): Remove unused CGPoint* variable.
991
992 2013-04-12  Jeffrey Pfau  <jpfau@apple.com>
993
994         Unreviewed, remove an old email address for myself.
995
996         * Scripts/webkitpy/common/config/committers.py:
997
998 2013-04-12  Adenilson Cavalcanti  <cavalcantii@gmail.com>
999
1000         [WK2] WebPageProxy loadURL() won't work when called just after terminateProcess()
1001         https://bugs.webkit.org/show_bug.cgi?id=110743
1002
1003         Reviewed by Benjamin Poulain.
1004
1005         Adding a new test file to check if loading a page just after WebProcess
1006         has crashed (or was terminated) works. The test executes the
1007         following steps (Load, Crash, Load), thus stressing WebProcess
1008         reattach and process termination code path.
1009
1010         * TestWebKitAPI/GNUmakefile.am:
1011         * TestWebKitAPI/PlatformEfl.cmake:
1012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1013         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1014         (TestWebKitAPI::setPageLoaderClient):
1015         (TestWebKitAPI::TEST):
1016         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp: Added.
1017         (TestWebKitAPI):
1018         (WebKit2CrashLoader):
1019         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1020         (TestWebKitAPI::WebKit2CrashLoader::loadUrl):
1021         (TestWebKitAPI::WebKit2CrashLoader::crashWebProcess):
1022         (TestWebKitAPI::didFinishLoad):
1023         (TestWebKitAPI::TEST):
1024         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
1025
1026 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1027
1028         [Mac] REGRESSION: Auto substitution strips new lines
1029         https://bugs.webkit.org/show_bug.cgi?id=114537
1030
1031         Reviewed by Enrica Casucci.
1032
1033         Add a rule to replace "helloleworld" by "hello\nworld" for testing purpose.
1034
1035         * DumpRenderTree/mac/DumpRenderTree.mm:
1036         (resetDefaultsToConsistentValues):
1037
1038 2013-04-09  Roger Fong  <roger_fong@apple.com>
1039
1040         Re-enable WinEWS tests.
1041
1042         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1043         (WinEWS):
1044
1045 2013-04-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1046
1047         [GTK] Split GtkAuthenticationDialog in two widgets
1048         https://bugs.webkit.org/show_bug.cgi?id=103644
1049
1050         Reviewed by Xan Lopez.
1051
1052         * gtk/generate-gtkdoc:
1053         (get_webkit2_options): Do not generate api docs for
1054         WebKitAuthenticationDialog which is private in WebKit2.
1055         (get_webkit1_options): Do not generate api docs for
1056         webkitauthenticationdialog which is private in WebKit1.
1057
1058 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1059
1060         WebKit Queues should capitalize K in Wk2
1061         https://bugs.webkit.org/show_bug.cgi?id=114524
1062
1063         Reviewed by Philippe Normand.
1064
1065         * QueueStatusServer/model/queues.py:
1066         (Queue.display_name):
1067
1068 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1069
1070         [Mac] Enable spellchecking tests added in r141471
1071         https://bugs.webkit.org/show_bug.cgi?id=108525
1072
1073         Reviewed by Darin Adler.
1074
1075         * DumpRenderTree/mac/DumpRenderTree.mm:
1076         (createWebViewAndOffscreenWindow):
1077         (resetDefaultsToConsistentValues):
1078         * WebKitTestRunner/TestController.cpp:
1079         (WTR::TestController::resetStateToConsistentValues):
1080
1081 2013-04-12  Manuel Rego Casasnovas  <rego@igalia.com>
1082
1083         [GTK] Enable WebKit2 building on GTK EWSs
1084         https://bugs.webkit.org/show_bug.cgi?id=114500
1085
1086         Reviewed by Philippe Normand.
1087
1088         Add configuration in order to be able to setup GTK EWSs building
1089         WebKit2. A new queue gtk-wk2-ews is added.
1090
1091         * QueueStatusServer/config/queues.py:
1092         * Scripts/webkitpy/common/config/ports.py:
1093         (DeprecatedPort.port):
1094         (GtkWK2Port):
1095         (GtkWK2Port.build_webkit_command):
1096         (GtkWK2Port.run_webkit_tests_command):
1097         * Scripts/webkitpy/common/config/ports_unittest.py:
1098         (DeprecatedPortTest.test_gtk_port):
1099         (DeprecatedPortTest):
1100         (DeprecatedPortTest.test_gtk_wk2_port):
1101         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1102         (GtkWK2EWS):
1103
1104 2013-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1105
1106         Remove Chromium scripts
1107         https://bugs.webkit.org/show_bug.cgi?id=114492
1108
1109         Reviewed by Benjamin Poulain.
1110
1111         * Scripts/run-chromium-webkit-unit-tests: Removed.
1112         * Scripts/update-webkit-chromium: Removed.
1113
1114 2013-04-12  Commit Queue  <rniwa@webkit.org>
1115
1116         Unreviewed, rolling out r148262.
1117         http://trac.webkit.org/changeset/148262
1118         https://bugs.webkit.org/show_bug.cgi?id=114493
1119
1120         Cairo dep should now build, rolling r148247 back in (Requested
1121         by zdobersek on #webkit).
1122
1123         * Scripts/webkitdirs.pm:
1124         (buildAutotoolsProject):
1125         * gtk/jhbuild.modules:
1126
1127 2013-04-11  Commit Queue  <rniwa@webkit.org>
1128
1129         Unreviewed, rolling out r148247.
1130         http://trac.webkit.org/changeset/148247
1131         https://bugs.webkit.org/show_bug.cgi?id=114490
1132
1133         Cairo dep fails to build on builders due to missing EGL
1134         headers (Requested by zdobersek on #webkit).
1135
1136         * Scripts/webkitdirs.pm:
1137         (buildAutotoolsProject):
1138         * gtk/jhbuild.modules:
1139
1140 2013-04-11  Martin Robinson  <mrobinson@igalia.com>
1141
1142         [GTK] Add accelerated 2D canvas support using cairo-gl
1143         https://bugs.webkit.org/show_bug.cgi?id=104672
1144
1145         Reviewed by Alejandro G. Castro.
1146
1147         Since the value of ACCELERATED_2D_CANVAS relies on some somewhat unusual
1148         dependencies, don't override value of the setting determined by configure.
1149         This will make it easier for people using build-webkit, but not the
1150         WebKit JHBuild.
1151
1152         * Scripts/webkitdirs.pm:
1153         (buildAutotoolsProject): Add a blacklist for settings to never override.
1154         * gtk/jhbuild.modules: Build CairoGL.
1155
1156 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1157
1158         build.webkit.org should link to webkit-queues instead of webkit-commit-queue
1159         https://bugs.webkit.org/show_bug.cgi?id=114477
1160
1161         Reviewed by Benjamin Poulain.
1162
1163         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1164
1165 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1166
1167         Leaks builder should not be triggered upon new commits
1168         https://bugs.webkit.org/show_bug.cgi?id=114475
1169
1170         Reviewed by Jessie Berlin.
1171
1172         Don't trigger them on new checkins. Wait for Mountain Lion (Build), which already triggers
1173         the leak builder when builds are done.
1174
1175         * BuildSlaveSupport/build.webkit.org-config/config.json:
1176
1177 2013-04-11  Kalev Lember  <kalevlember@gmail.com>
1178
1179         [GTK] Windows build failure after r136056
1180         https://bugs.webkit.org/show_bug.cgi?id=114121
1181
1182         Reviewed by Martin Robinson.
1183
1184         * TestWebKitAPI/config.h: Make sure defines are correct for other
1185         Windows ports than apple-win.
1186
1187 2013-04-11  Ojan Vafai  <ojan@chromium.org>
1188
1189         Remove myself from watchlists.
1190         * Scripts/webkitpy/common/config/watchlist:
1191
1192 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1193
1194         Build fix. Don't hard-code queues.webkit.org at least during the transition.
1195
1196         * QueueStatusServer/templates/statusbubble.html:
1197
1198 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1199
1200         Use webkit-queues.appspot.com instead of webkit-commit-queue.appspot.com
1201         https://bugs.webkit.org/show_bug.cgi?id=114397
1202
1203         Reviewed by Benjamin Poulain.
1204
1205         Reland the patch since Alan appears to have finished the migration.
1206
1207         * Scripts/webkitpy/common/net/statusserver.py:
1208         (StatusServer):
1209
1210 2013-04-11  Brian Holt  <brian.holt@samsung.com>
1211
1212         [Gtk] Combo boxes should be arrow-out-of-able similar to list boxes when caret-browsing is enabled.
1213         https://bugs.webkit.org/show_bug.cgi?id=76796
1214
1215         Reviewed by Chris Fleizach.
1216
1217         Make the Gtk window for the DRT a toplevel so that it gets the
1218         focus from the window manager when the test starts.
1219
1220         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1221         (main):
1222
1223 2013-04-04  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1224
1225         Use CSS4 image-rendering to determing image scaling quality
1226         https://bugs.webkit.org/show_bug.cgi?id=113405
1227
1228         Reviewed by Simon Fraser.
1229
1230         Introduce new flag to enable experimental support for CSS4 Images.
1231
1232         * Scripts/webkitperl/FeatureList.pm:
1233
1234 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1235
1236         Remove code for Chromium from wkbuild.py
1237         https://bugs.webkit.org/show_bug.cgi?id=114423
1238
1239         Reviewed by Benjamin Poulain.
1240
1241         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1242         (_should_file_trigger_build):
1243         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1244         (ShouldBuildTest):
1245
1246 2013-04-11  Philippe Normand  <pnormand@igalia.com>
1247
1248         Unreviewed, update my IRC nickname.
1249
1250         * Scripts/webkitpy/common/config/committers.py: I no longer use philn-tp.
1251
1252 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1253
1254         Remove the rest of Chromium code from webkitpy
1255         https://bugs.webkit.org/show_bug.cgi?id=114420
1256
1257         Reviewed by Benjamin Poulain.
1258
1259         * Scripts/webkitpy/common/config/urls.py:
1260         (view_revision_url):
1261         * Scripts/webkitpy/common/host.py:
1262         (Host._engage_awesome_locale_hacks):
1263         (Host.initialize_scm):
1264         (Host):
1265         * Scripts/webkitpy/common/host_mock.py:
1266         (MockHost.__init__):
1267         (MockHost.checkout):
1268         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py: Removed.
1269         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1270         (JSONResultsGeneratorBase._insert_generic_metadata):
1271         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1272         (TestExpectationParser._tokenize_line):
1273         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1274         (ExpectationSyntaxTests.test_bare_name_and_bugs):
1275         (ExpectationSyntaxTests.test_warnings):
1276         * Scripts/webkitpy/layout_tests/port/base.py:
1277         (Port.skips_perf_test):
1278         (Port.path_to_test_expectations_file):
1279         (Port._port_flag_for_scripts):
1280         * Scripts/webkitpy/style/checkers/cpp.py:
1281         (check_function_definition):
1282         (check_include_line):
1283         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1284         (OrderOfIncludesTest.test_check_wtf_includes):
1285         (WebKitStyleTest.test_webkit_export_check):
1286         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1287         (TestExpectationsTestCase.test_valid_expectations):
1288         * Scripts/webkitpy/tool/bot/irc_command.py:
1289         (Rollout.execute):
1290         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1291         (IRCCommandTest.test_whois):
1292         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1293         (IRCBotTest.test_help):
1294         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1295         (SheriffBotTest.test_command_aliases):
1296
1297 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1298
1299         roll-chromium-deps doesn't roll DEPS
1300         https://bugs.webkit.org/show_bug.cgi?id=114421
1301
1302         Reviewed by Antti Koivisto.
1303
1304         Roll DEPS. Rolling DEPS. Rolled DEPS.
1305
1306         * Scripts/webkitpy/tool/bot/irc_command.py:
1307         (RollChromiumDEPS.execute):
1308
1309 2013-04-11  Glenn Adams  <glenn@skynav.com>
1310
1311         [webkitpy] Remove lingering return_exit_code usage in scm_mock and rebaselineserver.
1312         https://bugs.webkit.org/show_bug.cgi?id=114418
1313
1314         Reviewed by Ryosuke Niwa.
1315
1316         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1317         (MockSCM.add): Remove optional remove_exit_code argument.
1318         (MockSCM.add_list): Remove optional remove_exit_code argument and return value.
1319         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1320         (_rebaseline_test): Use ScriptError to capture SCM.add() failure and exit code.
1321         (_move_test_baselines): Use ScriptError to capture SCM.add() failure and exit code.
1322
1323 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1324
1325         Fix roll-chromium-deps and hi.
1326
1327         * Scripts/webkitpy/tool/bot/irc_command.py:
1328         (Hi.execute):
1329         (RollChromiumDEPS.execute):
1330
1331 2013-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1332
1333         Remove webkitpy code to roll Chromium DEPS
1334         https://bugs.webkit.org/show_bug.cgi?id=114415
1335
1336         Reviewed by Benjamin Poulain.
1337
1338         Removed the code to roll Chromium DEPS in WebKit.
1339
1340         * Scripts/webkitpy/common/checkout/checkout.py:
1341         (Checkout.bug_id_for_this_commit):
1342         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1343         (MockCheckout.commit_message_for_this_commit):
1344         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1345         (CheckoutTest.test_suggested_reviewers):
1346         * Scripts/webkitpy/common/checkout/deps.py: Removed.
1347         * Scripts/webkitpy/common/checkout/deps_mock.py: Removed.
1348         * Scripts/webkitpy/tool/bot/irc_command.py:
1349         (RollChromiumDEPS): Teach webkitbot a sense of humor.
1350         (RollChromiumDEPS.execute):
1351         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1352         (IRCCommandTest.test_create_bug):
1353         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1354         (IRCBotTest.test_revert):
1355         * Scripts/webkitpy/tool/bot/sheriff.py:
1356         (Sheriff.post_rollout_patch):
1357         * Scripts/webkitpy/tool/commands/__init__.py:
1358         * Scripts/webkitpy/tool/commands/roll.py: Removed.
1359         * Scripts/webkitpy/tool/commands/roll_unittest.py: Removed.
1360         * Scripts/webkitpy/tool/steps/__init__.py:
1361         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Removed.
1362         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Removed.
1363         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Removed.
1364
1365 2013-04-11  Glenn Adams  <glenn@skynav.com>
1366
1367         [webkitpy] SVNTest fails four tests when using subversion client 1.7 or later
1368         https://bugs.webkit.org/show_bug.cgi?id=114386
1369
1370         Reviewed by Benjamin Poulain.
1371
1372         Subversion client 1.7 uses a new locking scheme that invalidates the technique used
1373         in test_svn_lock(), so skip that test for 1.7 (or later) until a new technique
1374         can be implemented. Further, 1.7 changed svn add to not add intermediate directories
1375         by default and to return exit code 1 if a file/dir had already been added.
1376
1377         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1378         (test_svn_lock): Skip body of test if subversion client 1.7 or later.
1379         * Scripts/webkitpy/common/checkout/scm/svn.py:
1380         (SVN.add_list): Use --parents option and handle exit code 1 if subversion client 1.7 or later.
1381
1382 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1383
1384         Unreviewed.
1385
1386         * GNUmakefile.am: Removing extra whitespace that's producing warnings.
1387
1388 2013-04-10  Glenn Adams  <glenn@skynav.com>
1389
1390         [webkitpy] Remove unused return_exit_code argument and returned values from SCM.{add,add_list}
1391         https://bugs.webkit.org/show_bug.cgi?id=114410
1392
1393         Reviewed by Ryosuke Niwa.
1394
1395         * Scripts/webkitpy/common/checkout/scm/git.py:
1396         (Git.add_list): Remove optional return_exit_code argument. Remove return value.
1397         * Scripts/webkitpy/common/checkout/scm/scm.py:
1398         (SCM.add): Remove optional return_exit_code argument.
1399         (SCM.add_list): Remove optional return_exit_code argument.
1400         * Scripts/webkitpy/common/checkout/scm/svn.py:
1401         (SVN.add_list): Remove optional return_exit_code argument. Remove return value.
1402
1403 2013-04-10  Eric Seidel  <eric@webkit.org>
1404
1405         Remove myself from the watchlists, I'm getting too much bug mail. :)
1406
1407         * Scripts/webkitpy/common/config/watchlist:
1408
1409 2013-04-10  Commit Queue  <rniwa@webkit.org>
1410
1411         Unreviewed, rolling out r148158.
1412         http://trac.webkit.org/changeset/148158
1413         https://bugs.webkit.org/show_bug.cgi?id=114405
1414
1415         We need to migrate status data (Requested by rniwa on
1416         #webkit).
1417
1418         * Scripts/webkitpy/common/net/statusserver.py:
1419         (StatusServer):
1420
1421 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
1422
1423         Mass remove all the empty directories
1424
1425         Rubberstamped by Ryosuke Niwa.
1426
1427         * BuildSlaveSupport/gtk/crashmon/log: Removed.
1428         * BuildSlaveSupport/gtk/xvfb/log: Removed.
1429         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
1430         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
1431         * MiniBrowser/gtk/WebBundle: Removed.
1432         * MiniBrowser/win: Removed.
1433         * QtTestPlatformPlugin/mac: Removed.
1434         * Scripts/webkitpy/tool/bot/testdata: Removed.
1435         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
1436         * efl/ImageDiff: Removed.
1437         * iExploder/htdocs: Removed.
1438         * iExploder/iexploder-1.7.2/output: Removed.
1439         * iExploder/tools: Removed.
1440         * qmake/config.tests/libexecdir: Removed.
1441         * qmake/config.tests/libjpeg: Removed.
1442         * qmake/config.tests/libpng: Removed.
1443
1444 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1445
1446         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
1447         https://bugs.webkit.org/show_bug.cgi?id=114397
1448
1449         Reviewed by Benjamin Poulain.
1450
1451         * Scripts/webkitpy/common/net/statusserver.py:
1452         (StatusServer):
1453
1454 2013-04-10  Adam Barth  <abarth@webkit.org>
1455
1456         Remove abarth from watchlists
1457         https://bugs.webkit.org/show_bug.cgi?id=114390
1458
1459         Reviewed by Ryosuke Niwa.
1460
1461         I'm trying to cut down on the amount of bugmail I get so that I'll have
1462         more of a chance to notice a piece of bugmail directed at me.
1463
1464         * Scripts/webkitpy/common/config/watchlist:
1465
1466 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1467
1468         webkit-test-results.appspot.com loads the dashboard for Chromium by default
1469         https://bugs.webkit.org/show_bug.cgi?id=114381
1470
1471         Reviewed by Benjamin Poulain.
1472
1473         Changed the defaults.
1474
1475         * TestResultServer/static-dashboards/builders.js:
1476         * TestResultServer/static-dashboards/dashboard_base.js:
1477         (currentBuilderGroupCategory):
1478
1479 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
1480
1481         Remove Chromium EWS bots from the queue status server
1482         https://bugs.webkit.org/show_bug.cgi?id=113988
1483
1484         Reviewed by Benjamin Poulain.
1485
1486         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
1487
1488         * QueueStatusServer/app.yaml:
1489         * QueueStatusServer/config/queues.py:
1490         * QueueStatusServer/model/queues.py:
1491         (Queue.short_name):
1492         (Queue.display_name):
1493         * QueueStatusServer/model/queues_unittest.py:
1494         (QueueTest.test_short_name):
1495         (QueueTest.test_display_name):
1496         (QueueTest.test_name_with_underscores):
1497         * QueueStatusServer/templates/activebots.html:
1498
1499 2013-04-10  Ojan Vafai  <ojan@chromium.org>
1500
1501         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
1502         https://bugs.webkit.org/show_bug.cgi?id=114370
1503
1504         Reviewed by Ryosuke Niwa.
1505
1506         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
1507         Unfortunately, there's no way to test this until this is committed and there is
1508         a master restart.
1509
1510         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1516         * TestResultServer/generate_builders_json.py:
1517         * TestResultServer/static-dashboards/dashboard_base.js:
1518         * TestResultServer/static-dashboards/loader.js:
1519
1520 2013-04-10  Glenn Adams  <glenn@skynav.com>
1521
1522         [Qt] Fix regression to test-webkitpy.
1523         https://bugs.webkit.org/show_bug.cgi?id=114368
1524
1525         Reviewed by Ryosuke Niwa.
1526
1527         * Scripts/webkitpy/layout_tests/port/factory.py:
1528         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
1529         (PortFactory.get): Remove obsolete chromium port related code.
1530         * Scripts/webkitpy/layout_tests/port/mac.py:
1531         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
1532
1533 2013-04-10  Anders Carlsson  <andersca@apple.com>
1534
1535         Remove unneeded headers from FrameLoader.h
1536         https://bugs.webkit.org/show_bug.cgi?id=114223
1537
1538         Reviewed by Geoffrey Garen.
1539
1540         Add back headers implicitly included by other headers.
1541
1542         * WebKitTestRunner/WorkQueueManager.cpp:
1543
1544 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1545
1546         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
1547         https://bugs.webkit.org/show_bug.cgi?id=114365
1548
1549         Reviewed by Martin Robinson.
1550
1551         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
1552         The patch addresses crashes in the tally_event_reply method. It is already committed into the
1553         at-spi2-atk source tree and will be available with the next stable release, after which the
1554         patch should be removed and the dependency version bumped.
1555
1556         * gtk/jhbuild.modules:
1557         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
1558
1559 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
1560
1561         [WinCairo] Unreviewed build fix. Correct DropBox download link.
1562
1563         * Scripts/update-webkit-wincairo-libs: Revise download URL to
1564         match change in DropBox server behavior.
1565
1566 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
1567
1568         Removed an annoying message from svn-create-patch
1569         https://bugs.webkit.org/show_bug.cgi?id=114332
1570
1571         Reviewed by Alexey Proskuryakov.
1572
1573         I see this message basically every time I write a patch, so it must not
1574         be true.
1575
1576         * Scripts/svn-create-patch:
1577         (generateDiff):
1578
1579 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
1580
1581         [GTK] Add support for Page Visibility
1582         https://bugs.webkit.org/show_bug.cgi?id=97324
1583
1584         Reviewed by Sam Weinig.
1585
1586         Implemented test runner API for page visibility layout tests.
1587
1588         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1589         (TestRunner::resetPageVisibility):
1590         (TestRunner::setPageVisibility):
1591         * Scripts/webkitperl/FeatureList.pm:
1592
1593 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1594
1595         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
1596         https://bugs.webkit.org/show_bug.cgi?id=114342
1597
1598         Reviewed by Gyuyoung Kim.
1599
1600         Commit 148033 only added an implementation for the Mac port, which made
1601         other ports fail most tests since loading the injected bundle failed
1602         with a missing symbol.
1603
1604         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1605         (WTR::AccessibilityUIElement::pathDescription):
1606
1607 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
1608
1609         [EFL] Add spell checking option to MiniBrowser
1610         https://bugs.webkit.org/show_bug.cgi?id=114282
1611
1612         Reviewed by Ryosuke Niwa.
1613
1614         Spell checking is enabled by adding a flag (t/text-checking)
1615         with launching MiniBrowser.
1616
1617         * MiniBrowser/efl/main.c:
1618         (window_create):
1619         (elm_main):
1620
1621 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
1622
1623         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
1624         https://bugs.webkit.org/show_bug.cgi?id=113281
1625
1626         Reviewed by Darin Adler.
1627
1628         * Scripts/run-gtk-tests:
1629         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
1630
1631 2013-04-09  Glenn Adams  <glenn@skynav.com>
1632
1633         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
1634
1635         Unreviewed.
1636
1637         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1638         (RunTest.test_build_check):
1639
1640 2013-04-09  Glenn Adams  <glenn@skynav.com>
1641
1642         [webkitpy] Remove chromium ports.
1643         https://bugs.webkit.org/show_bug.cgi?id=114326
1644
1645         Reviewed by Dirk Pranke.
1646
1647         As a side effect, also:
1648
1649         - remove chromium builders from webkitpy.layout_tests.port.builders
1650         - remove chromium builders from rebaseline
1651         - rewrite chromium dependent tests in rebaseline_unittest
1652         - remove chromium platform from garden-o-matic
1653         - select apple platform as default platform in garden-o-matic
1654         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
1655
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1658         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1659         (BaselineOptimizerTest.test_move_baselines):
1660         (BaselineOptimizerTest.test_efl):
1661         (BaselineOptimizerTest.test_no_add_mac_future):
1662         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1663         (BaselineOptimizerTest.test_common_directory_includes_root):
1664         (BaselineOptimizerTest.test_complex_shadowing):
1665         (BaselineOptimizerTest.test_virtual_ports_filtered):
1666         * Scripts/webkitpy/layout_tests/port/builders.py:
1667         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
1668         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
1669         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
1670         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
1671         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
1672         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
1673         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
1674         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
1675         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
1676         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
1677         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
1678         * Scripts/webkitpy/layout_tests/port/factory.py:
1679         (platform_options):
1680         (PortFactory):
1681         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1682         (FactoryTest.test_qt):
1683         (FactoryTest.test_get_from_builder_name):
1684         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1685         (RunTest.test_build_check):
1686         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1687         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1688         * Scripts/webkitpy/tool/commands/rebaseline.py:
1689         (Rebaseline._builders_to_pull_from):
1690         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1691         (_BaseTestCase):
1692         (_BaseTestCase.setUp):
1693         (TestRebaselineTest.setUp):
1694         (TestRebaselineTest.test_baseline_directory):
1695         (test_rebaseline_updates_expectations_file):
1696         (test_rebaseline_does_not_include_overrides):
1697         (test_rebaseline_test):
1698         (test_rebaseline_test_and_print_scm_changes):
1699         (test_rebaseline_and_copy_test):
1700         (test_rebaseline_and_copy_test_no_existing_result):
1701         (test_rebaseline_and_copy_test_with_lion_result):
1702         (test_rebaseline_and_copy_no_overwrite_test):
1703         (TestRebaselineExpectations.test_rebaseline_expectations):
1704
1705 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1706
1707         newcommitbot (WKR) requires a subversion checkout
1708         https://bugs.webkit.org/show_bug.cgi?id=114309
1709
1710         Reviewed by Benjamin Poulain.
1711
1712         Directly talk to the subversion server instead of relying on a local checkout.
1713         This allows us to run WKR off of a git clone.
1714
1715         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1716         (NewCommitBot.next_work_item):
1717         (NewCommitBot.process_work_item):
1718
1719 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1720
1721         webkitbot refers to sheriffbot in help
1722         https://bugs.webkit.org/show_bug.cgi?id=114307
1723
1724         Reviewed by Benjamin Poulain.
1725
1726         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
1727
1728         * Scripts/webkitpy/tool/bot/irc_command.py:
1729         (Help):
1730         (Help.execute):
1731         (RollChromiumDEPS.execute):
1732         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1733         (IRCBotTest.test_help):
1734         * Scripts/webkitpy/tool/bot/sheriff.py:
1735         (Sheriff.name):
1736
1737 2013-04-06  Roger Fong  <roger_fong@apple.com>
1738
1739         Kill old processes between runs on WinEWS bots.
1740         Temporarily disable tests to let bots catch up again.
1741
1742         * EWSTools/start-queue-win.sh:
1743         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1744         (WinEWS):
1745
1746 2013-04-09  Glenn Adams  <glenn@skynav.com>
1747
1748         [webkitpy] Remove chromium deprecated port support.
1749         https://bugs.webkit.org/show_bug.cgi?id=114228
1750
1751         Reviewed by Ryosuke Niwa.
1752
1753         * Scripts/webkitpy/common/config/ports.py:
1754         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
1755         (ChromiumPort): Removed.
1756         (ChromiumAndroidPort): Removed.
1757         (ChromiumXVFBPort): Removed.
1758         * Scripts/webkitpy/common/config/ports_unittest.py:
1759         (DeprecatedPortTest.test_chromium_port): Removed.
1760         (DeprecatedPortTest.test_chromium_android_port): Removed.
1761         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
1762         * Scripts/webkitpy/tool/steps/update_unittest.py:
1763         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
1764         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
1765
1766 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
1767
1768         AX: The bounding paths should be made available through accessibility
1769         https://bugs.webkit.org/show_bug.cgi?id=113817
1770
1771         Reviewed by David Kilzer.
1772
1773         Add a pathDescription property for testing so that it's possible
1774         to verify that a path is being returned correctly.
1775
1776         * DumpRenderTree/AccessibilityUIElement.cpp:
1777         (getPathDescriptionCallback):
1778         (AccessibilityUIElement::pathDescription):
1779         (AccessibilityUIElement::getJSClass):
1780         * DumpRenderTree/AccessibilityUIElement.h:
1781         (AccessibilityUIElement):
1782         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1783         (_CGPathEnumerationIteration):
1784         (AccessibilityUIElement::pathDescription):
1785         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1786         (AccessibilityUIElement::pathDescription):
1787         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1788         (WTR::AccessibilityUIElement::pathDescription):
1789         (WTR):
1790         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1791         (AccessibilityUIElement):
1792         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1793         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1794         (WTR::AccessibilityUIElement::pathDescription):
1795         (WTR):
1796
1797 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1798
1799         [EFL] Declare TEST_THEME_DIR in a single place.
1800         https://bugs.webkit.org/show_bug.cgi?id=114285
1801
1802         Reviewed by Anders Carlsson.
1803
1804         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
1805
1806         * DumpRenderTree/efl/CMakeLists.txt:
1807         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1808         (DumpRenderTreeChrome::createView):
1809         (DumpRenderTreeChrome::createInspectorView):
1810         (DumpRenderTreeChrome::initialize):
1811         (DumpRenderTreeChrome::onDownloadRequest):
1812         * EWebLauncher/CMakeLists.txt:
1813         * EWebLauncher/main.c:
1814         (findThemePath):
1815         * EWebLauncher/url_bar.c:
1816         (url_bar_add):
1817         * MiniBrowser/efl/CMakeLists.txt:
1818         * MiniBrowser/efl/main.c:
1819         (window_create):
1820         * TestWebKitAPI/PlatformEfl.cmake:
1821         * TestWebKitAPI/efl/PlatformWebView.cpp:
1822         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1823         * WebKitTestRunner/PlatformEfl.cmake:
1824         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1825         (WTR::PlatformWebView::PlatformWebView):
1826
1827 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
1828
1829         [GTK][AC] upversion of clutter and its dependecy
1830         https://bugs.webkit.org/show_bug.cgi?id=114016
1831
1832         Reviewed by Gustavo Noronha Silva.
1833
1834         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
1835
1836         * gtk/jhbuild-optional.modules:
1837
1838 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1839
1840         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
1841         https://bugs.webkit.org/show_bug.cgi?id=89875
1842
1843         Reviewed by Maciej Stachowiak.
1844
1845         Add unit tests to verify if the handling of the open, openat, creat syscall
1846         is being done right. We check if the Read/Write/ReadAndWrite permissions
1847         are respected, if the canonical path is being resolved and if
1848         the permissions are falling back to the topmost parent directory with a
1849         policy set when the directory being opened has no policy.
1850
1851         We also test if any attempt of blocking SIGSYS is silently ignored.
1852         SIGSYS cannot be blocked because in it's handler is where we hook
1853         syscalls to the broker process.
1854
1855         Also added libseccomp to EFL's jhbuild to make the life of developers
1856         willing to help easier.
1857
1858         * Scripts/webkitperl/FeatureList.pm:
1859         * TestWebKitAPI/PlatformEfl.cmake:
1860         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
1861         (TestWebKitAPI):
1862         (SeccompEnvironment):
1863         (TestWebKitAPI::SeccompEnvironment::SetUp):
1864         (TestWebKitAPI::SeccompEnvironment::TearDown):
1865         (TestWebKitAPI::dummyHandler):
1866         (TestWebKitAPI::TEST):
1867         (TestWebKitAPI::stressTest):
1868         * efl/jhbuild.modules:
1869         * qmake/mkspecs/features/features.pri:
1870
1871 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
1872
1873         REGRESSION: Autocorrection doesn't work in DumpRenderTree
1874         https://bugs.webkit.org/show_bug.cgi?id=113846
1875
1876         Reviewed by Alexey Proskuryakov.
1877
1878         The problem was that we were replacing NSSpellCheck's dictionary with our own
1879         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
1880
1881         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
1882         and "would" respectively in DumpRenderTree.
1883
1884         * DumpRenderTree/mac/DumpRenderTree.mm:
1885         (resetDefaultsToConsistentValues):
1886
1887 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
1888
1889         Remove the gyp files for Tools
1890         https://bugs.webkit.org/show_bug.cgi?id=114248
1891
1892         Reviewed by Ryosuke Niwa.
1893
1894         * DumpRenderTree/DumpRenderTree.gyp: Removed.
1895         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
1896         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
1897         * DumpRenderTree/DumpRenderTree.gypi: Removed.
1898         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
1899         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
1900         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
1901         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
1902
1903 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1904
1905         WKR (new-commit-bot) is too slow
1906         https://bugs.webkit.org/show_bug.cgi?id=110087
1907
1908         Reviewed by Geoffrey Garen.
1909
1910         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
1911         Just run "svn log -r <revision>" instead to cut down the delay.
1912
1913         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
1914
1915         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1916         (NewCommitBot):
1917         (NewCommitBot.next_work_item):
1918         (NewCommitBot._is_empty_log):
1919         (NewCommitBot._update_checkout):
1920
1921 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1922
1923         Build fix. Can't remove appendCustomBuildFlags.
1924
1925         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1926         (appendCustomBuildFlags):
1927
1928 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
1929
1930         Remove Chromium builders from build.webkit.org
1931         https://bugs.webkit.org/show_bug.cgi?id=113990
1932
1933         Reviewed by Benjamin Poulain.
1934
1935         Removed.
1936
1937         * BuildSlaveSupport/build.webkit.org-config/config.json:
1938         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1939         (InstallGtkDependencies):
1940         (RunUnitTests.start):
1941         (RunWebKit2Tests.start):
1942         (Factory.__init__):
1943         (unitTestsSupported):
1944         (TestFactory.__init__):
1945         (BuildAndTestFactory.__init__):
1946         (BuildAndPerfTestFactory.__init__):
1947         (BuildAndPerfTestWebKit2Factory.__init__):
1948         (DownloadAndPerfTestFactory.__init__):
1949         (loadBuilderConfig):
1950         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1951
1952 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
1953
1954         Remove HTML Notification
1955         https://bugs.webkit.org/show_bug.cgi?id=114231
1956
1957         Reviewed by Ryosuke Niwa.
1958
1959         * qmake/mkspecs/features/features.pri:
1960
1961 2013-04-08  Glenn Adams  <glenn@skynav.com>
1962
1963         Remove chromium EWS support, and fix broken test.
1964         https://bugs.webkit.org/show_bug.cgi?id=114221
1965
1966         Reviewed by Ryosuke Niwa.
1967
1968         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1969         (AbstractChromiumEWS): Removed.
1970         (ChromiumLinuxEWS): Removed.
1971         (ChromiumLinuxDebugEWS): Removed.
1972         (ChromiumWindowsEWS): Removed.
1973         (ChromiumAndroidEWS): Removed.
1974         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1975         (EarlyWarningSystemTest): Fix misspelled class name.
1976         (test_ewses): Fix entry point name to ensure test is run.
1977
1978 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
1979
1980         [WIN] Remove WebKit2 source code
1981         https://bugs.webkit.org/show_bug.cgi?id=114096
1982
1983         Reviewed by Anders Carlsson.
1984
1985         Remove the windows specific parts of the MiniBrowser.
1986
1987         * MiniBrowser/MiniBrowser.vcproj: Removed.
1988         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
1989         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
1990         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
1991         * MiniBrowser/win/BrowserView.cpp: Removed.
1992         * MiniBrowser/win/BrowserView.h: Removed.
1993         * MiniBrowser/win/BrowserWindow.cpp: Removed.
1994         * MiniBrowser/win/BrowserWindow.h: Removed.
1995         * MiniBrowser/win/MiniBrowser.cpp: Removed.
1996         * MiniBrowser/win/MiniBrowser.h: Removed.
1997         * MiniBrowser/win/MiniBrowser.rc: Removed.
1998         * MiniBrowser/win/main.cpp: Removed.
1999         * MiniBrowser/win/resource.h: Removed.
2000         * MiniBrowser/win/stdafx.cpp: Removed.
2001         * MiniBrowser/win/stdafx.h: Removed.
2002
2003 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
2004
2005         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
2006
2007         * Scripts/webkitpy/common/config/irc.py:
2008
2009 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
2010
2011         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
2012         https://bugs.webkit.org/show_bug.cgi?id=113139
2013
2014         Reviewed by Anders Carlsson.
2015
2016         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2017         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
2018         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2019         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
2020         (ToStringAndValueOfObject):
2021         (ToStringAndValueOfObject::ToStringAndValueOfObject):
2022         (ScriptableObject):
2023         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
2024         (ToStringAndValueOfObject::ScriptableObject::invoke):
2025         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
2026         (ToStringAndValueOfObject::NPP_GetValue):
2027         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2028         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2029         * GNUmakefile.am:
2030
2031 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
2032
2033         [GTK] Bump gnome-themes-standard to 3.6.0
2034         https://bugs.webkit.org/show_bug.cgi?id=114155
2035
2036         Reviewed by Martin Robinson.
2037
2038         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
2039         dependency of gnome-themes-standard accordingly.
2040
2041 2013-04-08  David Levin  <levin@chromium.org>
2042
2043         Remove my watchlist entries.
2044         https://bugs.webkit.org/show_bug.cgi?id=114180
2045
2046         Reviewed by Adam Barth.
2047
2048         * Scripts/webkitpy/common/config/committers.py:
2049         * Scripts/webkitpy/common/config/watchlist:
2050
2051 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2052
2053         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
2054         https://bugs.webkit.org/show_bug.cgi?id=114161
2055
2056         Reviewed by Gyuyoung Kim.
2057
2058         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
2059         as it is crashing due to Bug 111074.
2060
2061         * TestWebKitAPI/PlatformEfl.cmake:
2062
2063 2013-04-07  David Kilzer  <ddkilzer@apple.com>
2064
2065         Remove the rest of SVG_DOM_OBJC_BINDINGS
2066         <http://webkit.org/b/114112>
2067
2068         Reviewed by Geoffrey Garen.
2069
2070         * Scripts/webkitperl/FeatureList.pm:
2071         - Remove --svg-dom-objc-bindings switch.
2072         * qmake/mkspecs/features/features.pri:
2073         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
2074
2075 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
2076
2077         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
2078         https://bugs.webkit.org/show_bug.cgi?id=114089
2079
2080         Reviewed by Chris Fleizach.
2081
2082         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
2083         * DumpRenderTree/AccessibilityController.cpp:
2084         * DumpRenderTree/AccessibilityUIElement.cpp:
2085         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2086         (DumpRenderTreeChrome::DumpRenderTreeChrome):
2087         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2088         (DumpRenderTreeChrome):
2089
2090 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
2091
2092         Build fix after r147857, remove remaining USE(JSC) guards.
2093
2094         Unreviewed.
2095
2096         * DumpRenderTree/config.h:
2097         * TestWebKitAPI/config.h:
2098         * WebKitTestRunner/config.h:
2099
2100 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2101
2102         Rename sheriffbot to webkitbot
2103         https://bugs.webkit.org/show_bug.cgi?id=114109
2104
2105         Reviewed by Benjamin Poulain.
2106
2107         Renamed since sheriffbot will be used in Blink.
2108
2109         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2110         (SheriffBot):
2111         (SheriffBot.begin_work_queue):
2112
2113 2013-04-06  Oliver Hunt  <oliver@apple.com>
2114
2115         Unify the many and varied stack trace mechanisms, and make the result sane.
2116         https://bugs.webkit.org/show_bug.cgi?id=114072
2117
2118         Reviewed by Filip Pizlo.
2119
2120         The commandline jsc executable no longer requires arguments, so
2121         I've made run-jsc work without them.
2122
2123         * Scripts/run-jsc:
2124
2125 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
2126
2127         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
2128         https://bugs.webkit.org/show_bug.cgi?id=114086
2129
2130         Reviewed by Tim Horton.
2131
2132         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
2133
2134 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
2135
2136         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
2137         https://bugs.webkit.org/show_bug.cgi?id=114083
2138
2139         Reviewed by Ryosuke Niwa.
2140
2141         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
2142         in TestWebKitAPI and WebKitTestRunner.
2143
2144         * TestWebKitAPI/config.h:
2145         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2146         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2147         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2148         (WTR::InjectedBundle::platformInitialize):
2149
2150 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
2151
2152         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
2153         https://bugs.webkit.org/show_bug.cgi?id=114094
2154
2155         Reviewed by Anders Carlsson.
2156
2157         * Scripts/run-jsc:
2158
2159 2013-04-05  Ojan Vafai  <ojan@chromium.org>
2160
2161         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
2162         https://bugs.webkit.org/show_bug.cgi?id=114080
2163
2164         Reviewed by Ryosuke Niwa.
2165
2166         This way, the WebKit and Blink dashboard code can change as appropriate without
2167         needing to consider the other project's needs. This still doesn't update the
2168         buildbots to upload to the new location, or the dashboard code to pull the
2169         results.json files from the new location, but it at least allows for changing the
2170         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
2171
2172         * TestResultServer/app.yaml:
2173
2174 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2175
2176         Re-enable testing on the commit queue
2177         https://bugs.webkit.org/show_bug.cgi?id=114078
2178
2179         Reviewed by Darin Adler.
2180
2181         Re-enabled the feature and the associated tests.
2182
2183         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2184         (CommitQueueTask.run):
2185         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2186         (CommitQueueTaskTest._run_through_task):
2187         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2188         (CommitQueueTest._mock_test_result):
2189
2190 2013-04-05  Oliver Hunt  <oliver@apple.com>
2191
2192         Unify the many and varied stack trace mechanisms, and make the result sane.
2193         https://bugs.webkit.org/show_bug.cgi?id=114072
2194
2195         Reviewed by Filip Pizlo.
2196
2197         The commandline jsc executable no longer requires arguments, so
2198         I've made run-jsc work without them.
2199
2200         * Scripts/run-jsc:
2201
2202 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2203
2204         AX: Make SVG Group containers accessible elements
2205         https://bugs.webkit.org/show_bug.cgi?id=113939
2206
2207         Reviewed by Simon Fraser.
2208
2209         Implement axController.elementAtPoint for iOS.
2210         Implement a correct version of clickPoint for iOS.
2211
2212         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2213         (AccessibilityController::elementAtPoint):
2214         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2215         (AccessibilityUIElement::clickPointX):
2216         (AccessibilityUIElement::clickPointY):
2217
2218 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2219
2220         Unreviewed, rolling out r147773 and r147774.
2221         http://trac.webkit.org/changeset/147773
2222         http://trac.webkit.org/changeset/147774
2223         https://bugs.webkit.org/show_bug.cgi?id=114056
2224
2225         Causing some exceptions on AppEngine I don't understand
2226         (Requested by rniwa on #webkit).
2227
2228         * QueueStatusServer/config/queues.py:
2229         * QueueStatusServer/model/queues.py:
2230         (Queue.short_name):
2231         (Queue.display_name):
2232         * QueueStatusServer/model/queues_unittest.py:
2233         (QueueTest.test_short_name):
2234         (QueueTest.test_display_name):
2235         (QueueTest.test_name_with_underscores):
2236
2237 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
2238
2239         Fixed run-bindings-tests by removing V8
2240         https://bugs.webkit.org/show_bug.cgi?id=114053
2241
2242         Reviewed by Benjamin Poulain.
2243
2244         * Scripts/run-bindings-tests:
2245         (main):
2246
2247 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2248
2249         Build fix.
2250
2251         * QueueStatusServer/model/queues.py:
2252         (Queue.short_name):
2253         (Queue.display_name):
2254
2255 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
2256
2257         Remove Chromium EWS bots from the queue status server
2258         https://bugs.webkit.org/show_bug.cgi?id=113988
2259
2260         Reviewed by Benjamin Poulain.
2261
2262         Removed Chromium EWS bots.
2263
2264         * QueueStatusServer/config/queues.py:
2265         * QueueStatusServer/model/queues.py:
2266         (Queue.short_name):
2267         (Queue.display_name):
2268         * QueueStatusServer/model/queues_unittest.py:
2269         (QueueTest.test_short_name):
2270         (QueueTest.test_display_name):
2271         (QueueTest.test_name_with_underscores):
2272
2273 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
2274
2275         [EFL] Enable indexed database
2276         https://bugs.webkit.org/show_bug.cgi?id=107248
2277
2278         Reviewed by Alexis Menard.
2279
2280         * Scripts/webkitperl/FeatureList.pm:
2281
2282 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
2283
2284         Remove vestiges of Chromium bits from watchlists.
2285         https://bugs.webkit.org/show_bug.cgi?id=114047
2286
2287         Reviewed by Ryosuke Niwa.
2288
2289         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
2290
2291 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
2292
2293         Add James Craig to the contributors list.
2294
2295         * Scripts/webkitpy/common/config/committers.py:
2296
2297 2013-04-04  Kent Tamura  <tkent@chromium.org>
2298
2299         Remove ChromiumPublicApi pattern, and cc/message rules for it.
2300
2301         * Scripts/webkitpy/common/config/watchlist:
2302
2303 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2304
2305         Temporarily disable the Python unittests broken by the commit queue not running layout tests
2306         https://bugs.webkit.org/show_bug.cgi?id=113997
2307
2308         Reviewed by Ryosuke Niwa.
2309
2310         Disable the tests until Ryosuke gets the time and hardware to have
2311         a testing commit-queue.
2312
2313         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2314         (CommitQueueTaskTest):
2315         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2316         (CommitQueueTest):
2317
2318 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2319
2320         Remove Chromium builders from build.webkit.org
2321         https://bugs.webkit.org/show_bug.cgi?id=113990
2322
2323         Reviewed by Benjamin Poulain.
2324
2325         Land the part to disable triggering of Chromium builders first so that we may start
2326         deleting more Chromium code that breaks the update step.
2327
2328         * BuildSlaveSupport/build.webkit.org-config/config.json:
2329
2330 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
2331
2332         Remove Chromium's DumpRenderTree
2333         https://bugs.webkit.org/show_bug.cgi?id=113989
2334
2335         Reviewed by Kent Tamura.
2336
2337         On second thought, let's not go to Camelot. It is a silly place.
2338
2339         * DumpRenderTree/mac/DumpRenderTree.mm:
2340         (resetDefaultsToConsistentValues):
2341
2342 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
2343
2344         Nixed the defunct chromium folder from DumpRenderTree
2345         https://bugs.webkit.org/show_bug.cgi?id=113993
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         * DumpRenderTree/chromium: Removed.
2350         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
2351         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
2352         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
2353         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
2354         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
2355         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
2356         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
2357         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
2358         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
2359         * DumpRenderTree/chromium/MockPlatform.h: Removed.
2360         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
2361         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
2362         * DumpRenderTree/chromium/Task.cpp: Removed.
2363         * DumpRenderTree/chromium/Task.h: Removed.
2364         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
2365         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
2366         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
2367         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
2368         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
2369         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
2370         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
2371         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
2372         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
2373         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
2374         * DumpRenderTree/chromium/TestRunner: Removed.
2375         * DumpRenderTree/chromium/TestRunner/public: Removed.
2376         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
2377         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
2378         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
2379         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
2380         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
2381         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
2382         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
2383         * DumpRenderTree/chromium/TestRunner/src: Removed.
2384         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
2385         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
2386         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
2387         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
2388         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
2389         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
2390         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
2391         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
2392         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
2393         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
2394         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
2395         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
2396         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2397         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2398         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
2399         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
2400         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
2401         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
2402         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
2403         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
2404         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
2405         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
2406         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
2407         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
2408         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
2409         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
2410         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
2411         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
2412         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
2413         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
2414         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
2415         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
2416         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
2417         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
2418         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
2419         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
2420         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
2421         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
2422         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
2423         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
2424         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
2425         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
2426         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
2427         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
2428         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
2429         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
2430         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
2431         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
2432         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
2433         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
2434         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
2435         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
2436         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
2437         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
2438         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
2439         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
2440         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2441         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
2442         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
2443         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2444         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
2445         * DumpRenderTree/chromium/TestShell.cpp: Removed.
2446         * DumpRenderTree/chromium/TestShell.h: Removed.
2447         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
2448         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
2449         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
2450         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
2451         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
2452         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
2453         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
2454         * DumpRenderTree/chromium/WebViewHost.h: Removed.
2455         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
2456         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
2457         * DumpRenderTree/chromium/config.h: Removed.
2458         * DumpRenderTree/chromium/fonts.conf: Removed.
2459
2460 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
2463
2464         Rubber stamped by Benjamin Poulain.
2465
2466         * RebaselineQueueServer: Removed.
2467         * RebaselineQueueServer/app.yaml: Removed.
2468         * RebaselineQueueServer/handlers: Removed.
2469         * RebaselineQueueServer/handlers/__init__.py: Removed.
2470         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
2471         * RebaselineQueueServer/handlers/pages.py: Removed.
2472         * RebaselineQueueServer/index.yaml: Removed.
2473         * RebaselineQueueServer/main.py: Removed.
2474         * RebaselineQueueServer/model: Removed.
2475         * RebaselineQueueServer/model/__init__.py: Removed.
2476         * RebaselineQueueServer/model/queueentry.py: Removed.
2477         * RebaselineQueueServer/static: Removed.
2478         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
2479         * RebaselineQueueServer/static/styles.css: Removed.
2480         * RebaselineQueueServer/templates: Removed.
2481         * RebaselineQueueServer/templates/builder-picker.html: Removed.
2482         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
2483         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
2484         * RebaselineQueueServer/templates/home.html: Removed.
2485
2486 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2487
2488         Fix setup-commit-queue and temporarily disable testing on commit-queue
2489         https://bugs.webkit.org/show_bug.cgi?id=113979
2490
2491         Reviewed by Benjamin Poulain.
2492
2493         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
2494         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
2495
2496         * EWSTools/setup-commit-queue.sh:
2497         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2498         (CommitQueueTask.run):
2499
2500 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2501
2502         temporarily make flakiness dashboard work again webkit.org bots
2503         https://bugs.webkit.org/show_bug.cgi?id=113972
2504
2505         Reviewed by Ojan Vafai.
2506
2507         This patch disables the chromium.org layout test bots TestExpectations
2508         parsing temporarily until we can work out the right way to split into
2509         two instances for webkit.org and chromium.org and figure out which
2510         code to delete where :).
2511
2512         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2513
2514 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2515
2516         Fix webkitpy tests after r147678.
2517
2518         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2519         (CommitQueueTest.test_commit_queue):
2520         (test_manual_reject_during_processing):
2521
2522 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
2523
2524         The commit queue should use Mac MountainLion port
2525         https://bugs.webkit.org/show_bug.cgi?id=113971
2526
2527         Reviewed by Lucas Forschler.
2528
2529         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
2530         * Scripts/webkitpy/tool/commands/queues.py:
2531         (CommitQueue):
2532
2533 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
2534
2535         turn off running tests on chromium linux EWS bots
2536         https://bugs.webkit.org/show_bug.cgi?id=113959
2537
2538         Reviewed by Geoffrey Garen.
2539
2540         Now that the Chromium port is no longer being maintained
2541         there's little point in running the tests. Soon we should
2542         just shut this bot off altogether.
2543
2544         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2545         (ChromiumLinuxEWS):
2546
2547 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
2548
2549         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
2550
2551         * Scripts/webkitpy/common/config/watchlist:
2552
2553 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
2554
2555         Indentation fix to get webkit-patch working again after r147625
2556
2557         Unreviewed.
2558
2559         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2560         (MacEWS):
2561         (MacWK2EWS):
2562
2563 2013-04-04  Lucas Forschler  <lforschler@apple.com>
2564
2565         Turn tests back on for Mac WK1/WK2 EWS.
2566         
2567         Unreviewed.
2568         
2569         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2570         (MacEWS):
2571         (MacWK2EWS):
2572
2573 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
2574
2575         [GTK][WK2] MiniBrowser custom URI scheme support
2576         https://bugs.webkit.org/show_bug.cgi?id=112419
2577
2578         Reviewed by Carlos Garcia Campos.
2579
2580         Add support for about URIs in MiniBrowser. An example about page is show
2581         with URI "about:minibrowser", the rest of the cases it will show a
2582         proper message explaining that the about page didn't exist.
2583
2584         Internally it uses "minibrowser-about" prefix instead of "about", but
2585         from the user point of view it works with "about" prefix.
2586
2587         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
2588         (getInternalURI): Method to convert URIs from "about" prefix to
2589         "minibrowser-about".
2590         (getExternalURI): Opposite method.
2591         (webViewURIChanged): Use "about" prefix to show the URI to users.
2592         (webViewEnterFullScreen): Ditto.
2593         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
2594         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
2595         (aboutURISchemeRequestCallback): Callback to manage about calls.
2596         (main): Register the URI scheme to manage about URIs.
2597
2598 2013-04-03  Roger Fong  <roger_fong@apple.com>
2599
2600         Re-enable WinEWS tests.
2601
2602         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2603         (WinEWS):
2604
2605 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
2606
2607         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
2608         https://bugs.webkit.org/show_bug.cgi?id=113883
2609
2610         Reviewed by Martin Robinson.
2611
2612         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
2613         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
2614         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
2615
2616 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2617
2618         [GTK] Include Pango in jhbuild-optional.modules
2619         https://bugs.webkit.org/show_bug.cgi?id=113878
2620
2621         Reviewed by Martin Robinson.
2622
2623         Since r147547 Pango 1.32.0 is required. Including the module in the
2624         JHBuild optional moduleset.
2625
2626         * gtk/jhbuild-optional.modules: Add Pango module.
2627
2628 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2629
2630         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
2631         https://bugs.webkit.org/show_bug.cgi?id=113864
2632
2633         Moving setDefersLoading from TestRunnerQt to TestRunner
2634         requires access to the non-Qt TestRunner.
2635         As long as we instantiate both TestRunner and TestRunnerQt,
2636         we need a separate getter for the non-Qt TestRunner instance.
2637
2638         Reviewed by Simon Hausmann.
2639
2640         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2641         (WebPage::resetSettings):
2642         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2643         (DumpRenderTree::jscTestRunner):
2644         * DumpRenderTree/qt/TestRunnerQt.cpp:
2645         (TestRunner::setDefersLoading):
2646             Moving setDefersLoading from TestRunnerQt
2647             to TestRunner.
2648         * DumpRenderTree/qt/TestRunnerQt.h:
2649         (TestRunnerQt):
2650
2651 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
2652
2653         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2654         https://bugs.webkit.org/show_bug.cgi?id=104779
2655
2656         Reviewed by Carlos Garcia Campos.
2657
2658         * Scripts/run-gtk-tests:
2659         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2660         passing in current trunk.
2661
2662 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
2663
2664         Fix HAVE(QTTESTSUPPORT) logic
2665
2666         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
2667         resulting in HAVE(QTTESTSUPPORT) never being true.
2668         Move that logic down in sanitizeFeatures.
2669
2670         Rubber-stamped by Tor Arne Vestbø.
2671
2672         * qmake/mkspecs/features/features.prf:
2673
2674 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2675
2676         [GTK] Bump required versions of some dependencies
2677         https://bugs.webkit.org/show_bug.cgi?id=113282
2678
2679         Reviewed by Martin Robinson.
2680
2681         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2682
2683 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2684
2685         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
2686         https://bugs.webkit.org/show_bug.cgi?id=113809
2687
2688         Reviewed by Philippe Normand.
2689
2690         Newer Linux kernels have removed some deprecated macros from v4l2
2691         headers, causing gst-plugins-good's build to break. We don't need it
2692         right now, so just disable it.
2693
2694         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
2695
2696 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2697
2698         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
2699         https://bugs.webkit.org/show_bug.cgi?id=113535
2700
2701         Reviewed by Simon Hausmann.
2702
2703         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
2704
2705         * qmake/mkspecs/features/features.prf:
2706
2707 2013-04-03  Zeno Albisser  <zeno@webkit.org>
2708
2709         [Qt] Move logic of simple forwarding functions to TestRunner.
2710         https://bugs.webkit.org/show_bug.cgi?id=113863
2711
2712         Reviewed by Simon Hausmann.
2713
2714         * DumpRenderTree/qt/TestRunnerQt.cpp:
2715         (TestRunner::setTextDirection):
2716         (TestRunner::goBack):
2717         (TestRunner::evaluateScriptInIsolatedWorld):
2718         (TestRunner::addUserStyleSheet):
2719         * DumpRenderTree/qt/TestRunnerQt.h:
2720         (TestRunnerQt):
2721
2722 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2723
2724         [Qt] Disable media support using QuickTime if deployment target != SDK
2725
2726         We link to a single libWebKitSystemInterface static lib, so unless the
2727         deployment target matches the SDK let's not pretend like we'll be able
2728         to run on anything lower than the SDK version.
2729
2730         Reviewed by Simon Hausmann.
2731
2732         * qmake/mkspecs/features/features.prf:
2733
2734 2013-04-02  James Craig  <james@cookiecrook.com>
2735
2736         AXRoleDescripton for DL is "list"; should be "description list"
2737         https://bugs.webkit.org/show_bug.cgi?id=111665
2738
2739         Reviewed by Chris Fleizach.
2740
2741         Defining the role and description strings.
2742
2743         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2744
2745 2013-04-02  Roger Fong  <roger_fong@apple.com>
2746
2747         Unreviewed. Disable running tests on Win EWS queue.
2748
2749         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2750         (WinEWS):
2751
2752 2013-04-02  Lucas Forschler  <lforschler@apple.com>
2753
2754         Disable running tests on the MAC WK2 EWS queue.
2755         
2756         Unreviewed.
2757         
2758         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2759         (MacWK2EWS):
2760
2761 2013-04-02  Julie Parent  <jparent@chromium.org>
2762
2763         Dashboard refactor: Move dashboard specific history related features to History.
2764         https://bugs.webkit.org/show_bug.cgi?id=113717
2765
2766         Reviewed by Ojan Vafai.
2767         
2768         Each dashboard now creates its own History object, with a custom
2769         configuration. This changes from just overriding global functions
2770         to passing in callbacks for generatePage, handleValidHashParameter,
2771         and handleQueryParameterChange. Same with passing in defaultStateValues
2772         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
2773         variables.
2774         
2775         All functions related to these features are now (mostly) private
2776         function on History. 
2777         
2778         Loader no longer needs a loadingComplete callback, since it can just
2779         initialize the history object itself.
2780
2781         * TestResultServer/static-dashboards/aggregate_results.js:
2782         (handleValidHashParameter):
2783         * TestResultServer/static-dashboards/dashboard_base.js:
2784         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2785         (generatePage):
2786         (.switch.return):
2787         (handleQueryParameterChange):
2788         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2789         (resetGlobals):
2790         * TestResultServer/static-dashboards/history.js:
2791         (.):
2792         * TestResultServer/static-dashboards/loader.js:
2793         (.):
2794         * TestResultServer/static-dashboards/loader_unittests.js:
2795         * TestResultServer/static-dashboards/timeline_explorer.js:
2796         (generatePage):
2797         (initCurrentBuilderTestResults):
2798         * TestResultServer/static-dashboards/treemap.js:
2799         (generatePage):
2800         (.switch.return):
2801         (handleQueryParameterChange):
2802
2803 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2804
2805         Unreviewed, rolling out r147401.
2806         http://trac.webkit.org/changeset/147401
2807         https://bugs.webkit.org/show_bug.cgi?id=113767
2808
2809         The patch makes it extremely hard to set up the dependencies
2810         properly on the GTK builders (Requested by zdobersek on
2811         #webkit).
2812
2813         * gtk/jhbuild.modules:
2814
2815 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2816
2817         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
2818         https://bugs.webkit.org/show_bug.cgi?id=113382
2819
2820         Reviewed by Gyuyoung Kim.
2821
2822         Do not show the empty tooltip box if the text is null.
2823
2824         * MiniBrowser/efl/main.c:
2825         (popup_menu_populate):
2826
2827 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2828
2829         [GTK] Bump required versions of some dependencies
2830         https://bugs.webkit.org/show_bug.cgi?id=113282
2831
2832         Reviewed by Martin Robinson.
2833
2834         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
2835
2836 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2837
2838         Unreviewed, rolling out r147319.
2839         http://trac.webkit.org/changeset/147319
2840         https://bugs.webkit.org/show_bug.cgi?id=113707
2841
2842         The unit test is still failing on the buildbot (Requested by
2843         zdobersek on #webkit).
2844
2845         * Scripts/run-gtk-tests:
2846         (TestRunner):
2847
2848 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
2849
2850         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
2851         https://bugs.webkit.org/show_bug.cgi?id=104779
2852
2853         Reviewed by Carlos Garcia Campos.
2854
2855         * Scripts/run-gtk-tests:
2856         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
2857         passing in current trunk.
2858
2859 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
2860
2861         Unreviewed, rolling out r147289.
2862         http://trac.webkit.org/changeset/147289
2863         https://bugs.webkit.org/show_bug.cgi?id=113678
2864
2865         broke Win7 (dbg) build (Requested by shinyak|gardener on
2866         #webkit).
2867
2868         * DumpRenderTree/DumpRenderTree.gypi:
2869         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
2870         (WebTestRunner):
2871         (WebUserMediaClientMock):
2872         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
2873         (WebTestRunner::WebUserMediaClientMock::taskList):
2874         * Scripts/webkitpy/style/checkers/cpp.py:
2875         (check_function_definition):
2876
2877 2013-03-31  Adam Barth  <abarth@webkit.org>
2878
2879         configure-svn-config.sh fails
2880         https://codereview.chromium.org/13392007/
2881
2882         Reviewed by Eric Seidel.
2883
2884         This script was trying to use "svn checkout" to dowload a file from
2885         svn.webkit.org, but "svn checkout" only works with directories.
2886         Instead, we should use "svn export".
2887
2888         * EWSTools/configure-svn-config.sh:
2889
2890 2013-03-31  Wei Jia  <wjia@chromium.org>
2891
2892         Allow WebUserMediaClientMock to be used by client
2893         https://bugs.webkit.org/show_bug.cgi?id=113633
2894
2895         Reviewed by Adam Barth.
2896
2897         Export WebUserMediaClientMock.
2898         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
2899
2900         * DumpRenderTree/DumpRenderTree.gypi:
2901         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
2902         (WebUserMediaClientMock):
2903         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
2904         * Scripts/webkitpy/style/checkers/cpp.py:
2905         (check_function_definition):
2906
2907 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
2908
2909         Expose FeatureObserver data to WebKit clients
2910         https://bugs.webkit.org/show_bug.cgi?id=113613
2911
2912         Reviewed by Sam Weinig.
2913
2914         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2915         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
2916
2917 2013-03-29  Greg Hughes  <ghughes@apple.com>
2918
2919         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
2920         https://bugs.webkit.org/show_bug.cgi?id=112276
2921
2922         Reviewed by Chris Fleizach.
2923
2924         Added support to test accessibility search predicates with multiple keys.  
2925
2926         * DumpRenderTree/AccessibilityUIElement.cpp:
2927         (uiElementForSearchPredicateCallback):
2928         * DumpRenderTree/AccessibilityUIElement.h:
2929         (AccessibilityUIElement):
2930         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2931         (AccessibilityUIElement::uiElementForSearchPredicate):
2932         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2933         (AccessibilityUIElement::uiElementForSearchPredicate):
2934         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2935         (AccessibilityUIElement::uiElementForSearchPredicate):
2936         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2937         (AccessibilityUIElement::uiElementForSearchPredicate):
2938         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2939         (AccessibilityUIElement::uiElementForSearchPredicate):
2940         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2941         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2942         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2943         (AccessibilityUIElement):
2944         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2945         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2946         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2947         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2948         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2949
2950 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
2951
2952         Fix a typo in r147147 to fix Mac EWS.
2953
2954         * Scripts/webkitpy/tool/commands/queues.py:
2955         (PatchProcessingQueue._new_port_name_from_old):
2956
2957 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
2958
2959         [EFL] Build break with latest EFL libraries after r146265
2960         https://bugs.webkit.org/show_bug.cgi?id=113558
2961
2962         Unreviewed build fix.
2963
2964         * TestWebKitAPI/PlatformWebView.h:
2965         * WebKitTestRunner/PlatformWebView.h:
2966
2967 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2968
2969         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
2970
2971         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
2972         in libgcrypt build.
2973
2974 2013-03-28  Lucas Forschler  <lforschler@apple.com>
2975
2976         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
2977
2978         Unreviewed.
2979
2980         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2981         (MacEWS):
2982
2983 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
2984
2985         Use the right OS name on Mac EWS instead of mac-future.
2986
2987         Rubber-stamped by Dirk Pranke.
2988
2989         * Scripts/webkitpy/tool/commands/queues.py:
2990         (PatchProcessingQueue._new_port_name_from_old):
2991         (PatchProcessingQueue.begin_work_queue):
2992         (PatchProcessingQueue._upload_results_archive_for_patch):
2993
2994 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
2995
2996         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
2997         https://bugs.webkit.org/show_bug.cgi?id=112546
2998
2999         Reviewed by Martin Robinson.
3000
3001         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
3002         moved back to Source/WebCore/platform. Fix an indentation issue as well.
3003
3004 2013-03-28  Ming Xie  <mxie@blackberry.com>
3005
3006         [BlackBerry] Committer Email Updates
3007         https://bugs.webkit.org/show_bug.cgi?id=113435
3008
3009         Reviewed by Rob Buis.
3010
3011         Add the @blackberry.com email address for all our BlackBerry
3012         WebKit committers. This is the first step for our email address
3013         migration.
3014
3015         * Scripts/webkitpy/common/config/committers.py:
3016
3017 2013-03-28  Philippe Normand  <pnormand@igalia.com>
3018
3019         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
3020         https://bugs.webkit.org/show_bug.cgi?id=113508
3021
3022         Reviewed by Martin Robinson.
3023
3024         Prevent the GStreamer plugin scanner to load system-wide
3025         plugins. Only the ones built in JHBuild should be loaded and used
3026         at runtime.
3027
3028         * efl/jhbuildrc:
3029         * gtk/jhbuildrc:
3030
3031 2013-03-27  Philippe Normand  <pnormand@igalia.com>
3032
3033         [GTK] run-launcher --gtk -2 fails on a WK2-only build
3034         https://bugs.webkit.org/show_bug.cgi?id=113386
3035
3036         Reviewed by Carlos Garcia Campos.
3037
3038         * Scripts/webkitdirs.pm:
3039         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
3040         version to 3.0. Reflect this change so the builtDylibPathForName
3041         function doesn't fail to report the library as found.
3042
3043 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
3044
3045         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
3046         https://bugs.webkit.org/show_bug.cgi?id=113484
3047
3048         Unreviewed build fix.
3049
3050         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
3051
3052         * TestWebKitAPI/CMakeLists.txt:
3053         * WebKitTestRunner/CMakeLists.txt:
3054
3055 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
3056
3057         Revision for the internal jhbuild is too old
3058         https://bugs.webkit.org/show_bug.cgi?id=113324
3059
3060         Reviewed by Martin Robinson.
3061
3062         Update the minimum required version to a point where jhbuild won't
3063         fail installing packages when trying to remove a symlink to a directory.
3064
3065         * jhbuild/jhbuild-wrapper: Updated revision.
3066
3067 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3068
3069         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
3070         https://bugs.webkit.org/show_bug.cgi?id=113203
3071
3072         Reviewed by Philippe Normand.
3073
3074         We build our libsoup without GNOME support. gst-plugins-good does separate
3075         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
3076         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
3077         build failures as the headers of those diverge. We do not use souphttpsrc, so
3078         disable it when building gst-plugins-good.
3079
3080         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
3081
3082 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
3083
3084         Build fix after r146852. Please another reference to the Lion leaks builder.
3085
3086         * BuildSlaveSupport/build.webkit.org-config/config.json:
3087
3088 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
3089
3090         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
3091         https://bugs.webkit.org/show_bug.cgi?id=113421
3092
3093         Reviewed by Dirk Pranke.
3094
3095         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
3096         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
3097         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
3098         in the GTK-specific TestExpectations files.
3099
3100         To avoid this only enable the warnings only when not using WKTR.
3101
3102         * Scripts/webkitpy/layout_tests/port/gtk.py:
3103         (GtkPort.warn_if_bug_missing_in_test_expectations):
3104
3105 2013-03-27  Antti Koivisto  <antti@apple.com>
3106
3107         Fix Zalan's email.
3108
3109         * Scripts/webkitpy/common/config/committers.py:
3110
3111 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3112
3113         master.cfg cleanup
3114         https://bugs.webkit.org/show_bug.cgi?id=113195
3115
3116         Reviewed by Ryosuke Niwa.
3117
3118         * BuildSlaveSupport/build.webkit.org-config/config.json:
3119         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3120
3121 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3122
3123         master.cfg fine-tuning for Qt Mountain Lion Release bot
3124         https://bugs.webkit.org/show_bug.cgi?id=113191
3125
3126         Reviewed by Ryosuke Niwa.
3127
3128         * BuildSlaveSupport/build.webkit.org-config/config.json:
3129           - Rename the slave due to its location change.
3130           - Update the platform of the slave.
3131         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3132         (RunQtAPITests): Enable running WK2 API tests on Qt.
3133         (RunQtAPITests.start):
3134         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
3135         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
3136
3137 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3138
3139         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
3140         https://bugs.webkit.org/show_bug.cgi?id=113403
3141
3142         Reviewed by Kenneth Rohde Christiansen.
3143
3144         As of Evas 1.7.5, when Wayland is detected on the system, support for
3145         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
3146         The code, however, seems to depend on a few other flags which must be
3147         explicitly enabled.
3148
3149         If those additional GL-related options are passed, we end up
3150         having issues on the WebKit side, so disable Wayland support for
3151         now.
3152
3153         * efl/jhbuild.modules:
3154
3155 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3156
3157         Unreviewed, rolling out r146864.
3158         http://trac.webkit.org/changeset/146864
3159         https://bugs.webkit.org/show_bug.cgi?id=113391
3160
3161         causes crashes on Wk2 EFL release bot (Requested by drott on
3162         #webkit).
3163
3164         * Scripts/webkitperl/FeatureList.pm:
3165
3166 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3167
3168         [jhbuild] Correctly specify an alternate number of make jobs.
3169         https://bugs.webkit.org/show_bug.cgi?id=113396
3170
3171         Reviewed by Philippe Normand.
3172
3173         So far, we were using the `MAKEFLAGS' environment variable to pass the
3174         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
3175         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
3176
3177         We now behave more closely to the rest of the WebKit tools by first
3178         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
3179         not set, just letting jhbuild itself figure out how many jobs to use.
3180
3181         * efl/jhbuildrc:
3182         * gtk/jhbuildrc:
3183
3184 2013-03-27  Zeno Albisser  <zeno@webkit.org>
3185
3186         [Qt] Remove Qt specific WorkQueueItem definitions.
3187         https://bugs.webkit.org/show_bug.cgi?id=112891
3188
3189         This patch is preparation work for removing
3190         WorkQueue related code from TestRunnerQt and
3191         replacing it with generic TestRunner code.
3192
3193         Reviewed by Benjamin Poulain.
3194
3195         * DumpRenderTree/qt/TestRunnerQt.cpp:
3196         (TestRunnerQt::queueBackNavigation):
3197         (TestRunnerQt::queueForwardNavigation):
3198         (TestRunnerQt::queueLoadHTMLString):
3199         (TestRunnerQt::queueReload):
3200         (TestRunnerQt::queueLoadingScript):
3201         (TestRunnerQt::queueNonLoadingScript):
3202         (TestRunner::queueLoad):
3203         * DumpRenderTree/qt/TestRunnerQt.h:
3204         (TestRunnerQt):
3205         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3206         (LoadItem::invoke):
3207         (LoadHTMLStringItem::invoke):
3208         (LoadAlternateHTMLStringItem::invoke):
3209         (ReloadItem::invoke):
3210         (ScriptItem::invoke):
3211         (BackForwardItem::invoke):
3212         * DumpRenderTree/qt/WorkQueueItemQt.h:
3213         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
3214         (LoadAlternateHTMLStringItem):
3215
3216 2013-03-26  Julie Parent  <jparent@chromium.org>
3217
3218         Flakiness dashboard: simplify logic around which tests to show.
3219         https://bugs.webkit.org/show_bug.cgi?id=113250
3220
3221         Reviewed by Ojan Vafai.
3222         
3223         The different filters for showing results are only used for layout
3224         tests, otherwise, we show everything.
3225         
3226         Change the defaults to false (what layout tests used), and only
3227         look at the values when viewing layout tests.
3228
3229         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3230         (htmlForTestsWithExpectationsButNoFailures):
3231         (shouldHideTest):
3232
3233 2013-03-26  Isaac Levy  <ilevy@google.com>
3234
3235         Update bots on test-results.appspot
3236         https://bugs.webkit.org/show_bug.cgi?id=113333
3237
3238         Reviewed by Ojan Vafai.
3239
3240         * TestResultServer/static-dashboards/builders.jsonp:
3241
3242 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3243
3244         Unreviewed GTK gardening.
3245
3246         * Scripts/run-gtk-tests:
3247         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
3248
3249 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
3250
3251         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
3252         https://bugs.webkit.org/show_bug.cgi?id=113287
3253
3254         Reviewed by Jocelyn Turcotte.
3255
3256         * Scripts/run-qtwebkit-tests:
3257         (Options.__init__):
3258
3259 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
3260
3261         [EFL] Enable IndexedDB by default
3262         https://bugs.webkit.org/show_bug.cgi?id=107248
3263
3264         Reviewed by Laszlo Gombos.
3265
3266         * Scripts/webkitperl/FeatureList.pm:
3267         Enable IndexedDB by default on EFL.
3268
3269 2013-03-26  Alan Cutter  <alancutter@chromium.org>
3270
3271         Sheriffbot should explain rollout failures in a human readable form.
3272         https://bugs.webkit.org/show_bug.cgi?id=107092
3273
3274         Reviewed by Ryosuke Niwa.
3275
3276         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
3277
3278         * Scripts/webkitpy/tool/bot/irc_command.py:
3279         (Rollout._check_diff_failure):
3280         (Rollout.execute):
3281         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3282         (IRCCommandTest.test_rollout):
3283
3284 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
3285
3286         Unreviewed GTK gardening.
3287
3288         * Scripts/run-gtk-tests:
3289         (TestRunner): Skipping a failing unit test after r146518.
3290
3291 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3292
3293         Remove Lion leaks builder
3294         https://bugs.webkit.org/show_bug.cgi?id=113252
3295
3296         Reviewed by Andreas Kling.
3297
3298         Removed.
3299
3300         * BuildSlaveSupport/build.webkit.org-config/config.json:
3301
3302 2013-03-25  Kent Tamura  <tkent@chromium.org>
3303
3304         Rename ENABLE_INPUT_TYPE_DATETIME
3305         https://bugs.webkit.org/show_bug.cgi?id=113254
3306
3307         Reviewed by Kentaro Hara.
3308
3309         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
3310         Actually I'd like to remove the code, but we shouldn't remove it yet
3311         because we shipped products with it on some platforms.
3312
3313         * Scripts/webkitperl/FeatureList.pm:
3314         * qmake/mkspecs/features/features.pri:
3315
3316 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3317
3318         Remove one more line that was intended to be removed in r146657.
3319
3320         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3321         (summarize_results):
3322
3323 2013-03-25  Roger Fong  <roger_fong@apple.com>
3324
3325         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
3326         Re-enable WinEWS tests.
3327
3328         * Scripts/webkitpy/common/config/ports.py:
3329         (WinPort.run_bindings_tests_command):
3330         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3331         (WinEWS):
3332
3333 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3334
3335         Unreviewed, rolling out r146793.
3336         http://trac.webkit.org/changeset/146793
3337         https://bugs.webkit.org/show_bug.cgi?id=113248
3338
3339         Fix did not work (Requested by rfong on #webkit).
3340
3341         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3342         (WinEWS):
3343
3344 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
3345
3346         REGRESSION(r146657): Test failures reported incorrectly
3347         https://bugs.webkit.org/show_bug.cgi?id=113223
3348
3349         Reviewed by Dirk Pranke.
3350
3351         The bug was caused by BuildBotPrinter not taking the new behavior into account.
3352
3353         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
3354         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
3355
3356         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3357         (Manager.run):
3358
3359         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3360         (RunDetails.__init__):
3361         (summarize_results): Remove the line I intended to remove in r146657.
3362
3363         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3364         (logging_run): Return details instead of the exit code.
3365         (run_and_capture): Ditto.
3366
3367         (RunTest.test_full_results_html):
3368         (RunTest.test_hung_thread):
3369         (RunTest.test_no_tests_found):
3370         (RunTest.test_no_tests_found_2):
3371         (RunTest.test_repeat_each_iterations_num_tests):
3372         (RunTest.test_run_singly_actually_runs_tests):
3373         (RunTest.test_test_list):
3374         (RunTest.test_missing_and_unexpected_results):
3375         (RunTest.test_pixel_test_directories):
3376         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
3377         (RunTest.test_crash_with_stderr):
3378         (RunTest.test_no_image_failure_with_image_diff):
3379         (RunTest.test_crash_log):
3380         (RunTest.test_exit_after_n_failures_upload):
3381         (RunTest.test_results_directory_absolute):
3382         (RunTest.test_results_directory_relative):
3383         (RunTest.test_retrying_and_flaky_tests):
3384         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
3385         (RunTest.test_retrying_uses_retries_directory):
3386         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
3387         (RunTest.test_output_diffs):
3388         (EndToEndTest.test_reftest_with_two_notrefs):
3389         (RebaselineTest.test_reset_results):
3390         (RebaselineTest.test_missing_results):
3391         (RebaselineTest.test_new_baseline):
3392
3393         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3394         (BuildBotPrinter.print_results):
3395         (BuildBotPrinter.print_unexpected_results):
3396         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
3397         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
3398
3399 2013-03-25  Julie Parent  <jparent@chromium.org>
3400
3401         Dashboard refactor: Move cross dashboard history related code into history.js.
3402         https://bugs.webkit.org/show_bug.cgi?id=113104
3403
3404         Reviewed by Ojan Vafai.
3405
3406         All functions relating to cross dashboard behavior move from being
3407         globals to methods on the history.History object. Names stay the same,
3408         except many are made private, ones that should have been constants now
3409         are, and the long standing TODO to change "currentState" to 
3410         dashboardSpecificState is done.
3411         
3412         We now create a global history object in dashboard_base, as an 
3413         intermediate measure.  Once the dashboard specific code is
3414         added to history, each DB will need to create its own, and this
3415         global will be eliminated.
3416         
3417         * TestResultServer/static-dashboards/aggregate_results.js:
3418         (handleValidHashParameter):
3419         (htmlForBuilder):
3420         (rawValuesHTML):
3421         * TestResultServer/static-dashboards/dashboard_base.js:
3422         (parseDashboardSpecificParameters):
3423         (defaultValue):
3424         (currentBuilderGroupCategory):
3425         (currentBuilderGroupName):
3426         (handleLocationChange):
3427         (expectationsMap):
3428         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3429         (generatePage):
3430         (.switch.return):
3431         (platformAndBuildType):
3432         (individualTests):
3433         (substringList):
3434         (processMissingAndExtraExpectations):
3435         (pathToFailureLog):
3436         (showPopupForBuild):
3437         (htmlForTestsWithExpectationsButNoFailures):
3438         (shouldHideTest):
3439         (isCrossBuilderView):
3440         (tableHeaders):
3441         (htmlForSingleTestRow):
3442         (htmlForTableColumnHeader):
3443         (generatePageForExpectationsUpdate):
3444         (handleUpdate):
3445         (nextUpdate):
3446         (setUpdateIndex):
3447         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3448         (.appendExpectationsItem):
3449         (loadExpectations):
3450         (.dummyNode.onload):
3451         (loadExpectationsLayoutTests):
3452         (appendExpectations):
3453         (htmlForNavBar):
3454         (checkBoxToToggleState):
3455         (linkHTMLToToggleState):
3456         (generatePageForBuilder):
3457         (isInvalidKeyForCrossBuilderView):
3458         (handleQueryParameterChange):
3459         (showLegend):
3460         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3461         (resetGlobals):
3462         (test):
3463         * TestResultServer/static-dashboards/history.js:
3464         (.):
3465         * TestResultServer/static-dashboards/history_unittests.js:
3466         * TestResultServer/static-dashboards/loader.js:
3467         (.):
3468         * TestResultServer/static-dashboards/loader_unittests.js:
3469         * TestResultServer/static-dashboards/timeline_explorer.js:
3470         (generatePage):
3471         (initCurrentBuilderTestResults):
3472         (selectBuild):
3473         (showResultsDelta):
3474         * TestResultServer/static-dashboards/treemap.js:
3475         (generatePage):
3476         (.switch.return):
3477         (handleFocus):
3478         * TestResultServer/static-dashboards/ui.js:
3479
3480 2013-03-25  Roger Fong  <roger_fong@apple.com>
3481
3482         Unreviewed. Enable WinEWS tests again.
3483
3484         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3485         (WinEWS):
3486
3487 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
3488
3489         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
3490         https://bugs.webkit.org/show_bug.cgi?id=112166
3491
3492         HarfBuzz 0.9.14 merged my patch for icu detection without
3493         pkg-config files, as needed by for example Ubuntu 12.04.
3494         This obsoletes our local workaround. Removed it for GTK and EFL.
3495
3496         Reviewed by Martin Robinson.
3497
3498         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3499         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
3500         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
3501         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
3502
3503 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
3504
3505         Unreviewed.  Move self from contributor to committer list.
3506
3507         * Scripts/webkitpy/common/config/committers.py:
3508
3509 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3510
3511         EWS should use a human readable port name when uploading layout test archives
3512         https://bugs.webkit.org/show_bug.cgi?id=113099
3513
3514         Reviewed by Dirk Pranke.
3515
3516         Use new port's object's name() method to report human readable port names.
3517         This will also help us resolving the bug to apply layout test results posted by EWS.
3518
3519         * Scripts/webkitpy/tool/bot/botinfo.py:
3520         (BotInfo.__init__): Take port's name.
3521         (BotInfo.summary_text):
3522
3523         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3524         (BotInfoTest.test_summary_text):
3525
3526         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3527         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
3528
3529         * Scripts/webkitpy/tool/commands/queues.py:
3530         (PatchProcessingQueue.__init__): Initialize self._port.
3531         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
3532         and use that for the attachment filename and the comment posted.
3533
3534         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3535         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
3536         "mac-snowleopard" as expected for TestPort.
3537
3538 2013-03-22  Roger Fong  <roger_fong@apple.com>
3539
3540         Unreviewed. Turn off EWS test on Win again.
3541         The battle continues.
3542
3543         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3544         (WinEWS):
3545
3546 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
3547
3548         NRWT: Enable pixel tests when retrying tests
3549         https://bugs.webkit.org/show_bug.cgi?id=112898
3550
3551         Reviewed by Dirk Pranke.
3552
3553         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3554         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
3555         if we've forced pixel tests in the retry.
3556         (Manager._run_tests):
3557         (Manager._clean_up_run): Fixed the capitalizations.
3558         (Manager._force_pixel_tests_if_needed): Added.
3559
3560         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3561         (_interpret_test_failures): Now that this function maybe called multiple times, only set
3562         'image_diff_percent' if it doesn't already exist.
3563
3564         (summarize_results): When the first attempt resulted in a text failure and the second attempt
3565         resulted in image and text failures and we've forced to run pixel tests in the retry run,
3566         treat this as a regular regression instead of a flakiness.
3567
3568         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
3569         run had image diffs.
3570
3571         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3572         (summarized_results):
3573
3574         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3575         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
3576         Also removed some dead code.
3577
3578         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
3579         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
3580         is set and pixel_tests_enabled is set to false.
3581         (EndToEndTest.test_reftest_with_two_notrefs):
3582
3583 2013-03-22  Tim Horton  <timothy_horton@apple.com>
3584
3585         Make it possible to run layout tests on Retina MBP
3586         https://bugs.webkit.org/show_bug.cgi?id=93673
3587
3588         Reviewed by Ryosuke Niwa.
3589
3590         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
3591         windows on 2x machines still run at 1x.
3592
3593         * DumpRenderTree/mac/DumpRenderTree.mm:
3594         (createWebViewAndOffscreenWindow):
3595         Reset the window resolution to 1x on creation.
3596         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
3597         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3598         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
3599         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3600         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
3601         (WTR::PlatformWebView::PlatformWebView):
3602         Add NSWindow details, reset the window resolution to 1x on creation.
3603
3604 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3605
3606         Leak bots shouldn't build
3607         https://bugs.webkit.org/show_bug.cgi?id=112774
3608
3609         Reviewed by Simon Fraser.
3610
3611         Since leak bots use regular debug builds, there is no need to build on these bots.
3612         Simply downloading builds will dramatically improve the cycle time of these bots.
3613
3614         * BuildSlaveSupport/build.webkit.org-config/config.json:
3615         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3616         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
3617         TestFactory instead of BuildAndTestFactory.
3618
3619 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
3620
3621         [Qt] Fix the TestWebKitAPI build
3622         https://bugs.webkit.org/show_bug.cgi?id=113044
3623
3624         Reviewed by Tor Arne Vestbø.
3625
3626         The generate-forwarding-headers script would only be run
3627         after the targets in InjectedBundle.pri since the second
3628         addStrictSubdirOrderBetween call in
3629         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
3630         the derived_sources -> injected_bundle order in SUBDIRS.
3631
3632         Fix it by only moving the dependent target at the end of
3633         SUBDIRS, don't touch its dependency.
3634
3635         * qmake/mkspecs/features/functions.prf:
3636
3637 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3638
3639         [EFL][WK2] View is not focused when fullscreen mode toggled
3640         https://bugs.webkit.org/show_bug.cgi?id=113009
3641
3642         Reviewed by Laszlo Gombos.
3643
3644         Set focus on view when fullscreen mode enabled/disabled
3645         by FullScreen API.
3646
3647         * MiniBrowser/efl/main.c:
3648         (on_fullscreen_accept):
3649         (on_fullscreen_deny):
3650
3651 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3652
3653         nrwt is no longer saving retry results in the retries/ subdirectory
3654         https://bugs.webkit.org/show_bug.cgi?id=112995
3655
3656         Reviewed by Ojan Vafai.
3657
3658         I think this has been broken a long time, unfortunately. This
3659         patch should fix that.
3660
3661         In order to do so, I had to pass the directory to use from
3662         the Worker object through the SingleTestWriter to the
3663         TestResultWriter. While I was plumbing that through, I rationalized
3664         the order of the parameter arguments a bit ...
3665
3666         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3667         (Worker._run_single_test):
3668         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3669         (run_single_test):
3670         (SingleTestRunner.__init__):
3671         (SingleTestRunner._run_compare_test):
3672         (SingleTestRunner._run_rebaseline):
3673         (SingleTestRunner._run_reftest):
3674         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3675         (write_test_result):
3676         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3677         (TestResultWriterTest.test_reftest_diff_image):
3678         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3679         (RunTest.test_retrying_uses_retries_directory):
3680
3681 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
3682
3683         JSC profiler should have an at-a-glance report of the success of DFG optimization
3684         https://bugs.webkit.org/show_bug.cgi?id=112988
3685
3686         Reviewed by Geoffrey Garen.
3687
3688         * Scripts/display-profiler-output:
3689
3690 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3691
3692         [chromium] Linux ASAN WebKit canary is running out of memory
3693         https://bugs.webkit.org/show_bug.cgi?id=112978
3694
3695         Reviewed by Tony Chang.
3696
3697         Running the AddressSanitizer on a crash takes a lot of
3698         memory, so we should serialize access to it to avoid running
3699         out of memory on a machine.
3700
3701         * Scripts/webkitpy/layout_tests/port/chromium.py:
3702         (ChromiumPort._get_crash_log):
3703         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3704         (HttpLock.__init__):
3705         (HttpLock.wait_for_httpd_lock):
3706
3707 2013-03-21  Min Qin  <qinmin@chromium.org>
3708
3709         Cleanup android media layout test code
3710         https://bugs.webkit.org/show_bug.cgi?id=112944
3711
3712         Reviewed by Adam Barth.
3713
3714         Chromium change: https://codereview.chromium.org/12892010/
3715         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
3716         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
3717         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
3718         Instead, we should switch to use content shell for layout tests.
3719
3720         * DumpRenderTree/chromium/TestShell.cpp:
3721         (TestShell::resetTestController):
3722
3723 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
3724
3725         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
3726         https://bugs.webkit.org/show_bug.cgi?id=112953
3727
3728         Reviewed by Tony Chang.
3729
3730         When I created the DumpRenderTree_resources target in r144863 I
3731         forgot to declare the needed dependencies on the other resource
3732         targets. Due to a quirk of ordering, this appears to have been fine
3733         w/ ninja but not w/ Xcode (which is still being used on the chromium
3734         mac valgrind bots). Declaring the dependencies fixes the build
3735         failures.
3736
3737         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3738
3739 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
3740
3741         [WinCairo] Correct assert in Empty BitmapImage Test.
3742         https://bugs.webkit.org/show_bug.cgi?id=112934
3743
3744         Reviewed by Tim Horton.
3745
3746         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3747         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
3748         to avoid ref counting assertion when leaving test scope.
3749
3750 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
3751
3752         [GTK] generate-feature-defines-files is incompatible with Python3
3753         https://bugs.webkit.org/show_bug.cgi?id=112956
3754
3755         Reviewed by Martin Robinson.
3756
3757         Make the generate-feature-defines-files compatible with Python3 by calling the items()
3758         method on the dictionary objects when iterating through said dictionaries.
3759
3760         * gtk/generate-feature-defines-files:
3761         (write_feature_defines_header):
3762         (write_flattened_feature_defines_file):
3763
3764 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3765
3766         kill-old-processes spits out error messages on Mac
3767         https://bugs.webkit.org/show_bug.cgi?id=112878
3768
3769         Reviewed by Jessie Berlin.
3770
3771         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
3772         included in the list of options grep --help shows.
3773
3774         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
3775
3776         * BuildSlaveSupport/kill-old-processes:
3777         (main):
3778
3779 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
3780
3781         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
3782         https://bugs.webkit.org/show_bug.cgi?id=112597
3783
3784         Reviewed by Xan Lopez.
3785
3786         These were introduced for the Chromium port in r105295. We need
3787         dummy implementations in order to compile the BlackBerry port.
3788
3789         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3790         (AccessibilityUIElement::scrollToMakeVisible):
3791         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3792         (AccessibilityUIElement::scrollToGlobalPoint):
3793
3794 2013-03-21  Roger Fong  <roger_fong@apple.com>
3795
3796         Re-enable WinEWS tests following r146376.
3797
3798         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3799         (WinEWS):
3800
3801 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
3802
3803         Unreviewed. Add Bem Jones-Bey to the list of contributors.
3804
3805         * Scripts/webkitpy/common/config/committers.py:
3806
3807 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3808
3809         [GTK] Missing atk in install-dependencies script
3810         https://bugs.webkit.org/show_bug.cgi?id=112272
3811
3812         Reviewed by Gustavo Noronha Silva.
3813
3814         * gtk/install-dependencies: Add missing atk dependency.
3815
3816 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
3817
3818         [GTK] Missing backslash in install-dependencies script
3819         https://bugs.webkit.org/show_bug.cgi?id=112907
3820
3821         Reviewed by Philippe Normand.
3822
3823         * gtk/install-dependencies: Add missing backslash to dependencies
3824         list.
3825
3826 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
3827
3828         EWS bots have stopped uploading results to bugzilla
3829         https://bugs.webkit.org/show_bug.cgi?id=101091
3830
3831         Reviewed by Adam Barth.
3832
3833         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
3834         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
3835         this relative file path resoled to a file inside a non-existent directory for "zip".
3836
3837         Fixed the bug by resolving both test results directory and zip archive paths in
3838         LayoutTestResultsReader.archive.
3839
3840         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
3841         in the future.
3842
3843         * Scripts/webkitpy/common/system/filesystem_mock.py:
3844         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
3845
3846         * Scripts/webkitpy/common/system/workspace.py:
3847         (Workspace.create_zip): Log the source path when "zip" failed.
3848
3849         * Scripts/webkitpy/common/system/workspace_mock.py:
3850         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
3851
3852         * Scripts/webkitpy/common/system/workspace_unittest.py:
3853         (WorkspaceTest.test_create_zip_exception): Test that.
3854
3855         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3856         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
3857         This is the actual bug fix.
3858
3859         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3860         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
3861
3862 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
3863
3864         [chromium] move WebThemeEngine implementations to TestRunner library
3865         https://bugs.webkit.org/show_bug.cgi?id=112751
3866
3867         Reviewed by Adam Barth.
3868
3869         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3870         * DumpRenderTree/DumpRenderTree.gypi:
3871         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3872         (WebKit):
3873         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3874         (WebTestRunner::TestInterfaces::themeEngine):
3875         (WebTestRunner):
3876         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3877         (WebKit):
3878         (TestInterfaces):
3879         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3880         (WebTestRunner::WebTestInterfaces::themeEngine):
3881         (WebTestRunner):
3882         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3883         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3884         (WebTestRunner):
3885         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3886         (WebTestRunner::WebTestThemeControlWin::box):
3887         (WebTestRunner::WebTestThemeControlWin::line):
3888         (WebTestRunner::WebTestThemeControlWin::triangle):
3889         (WebTestRunner::WebTestThemeControlWin::roundRect):
3890         (WebTestRunner::WebTestThemeControlWin::oval):
3891         (WebTestRunner::WebTestThemeControlWin::circle):
3892         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3893         (WebTestRunner::WebTestThemeControlWin::markState):
3894         (WebTestRunner::WebTestThemeControlWin::draw):
3895         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3896         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3897         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3898         (WebTestRunner):
3899         (WebTestThemeControlWin):
3900         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3901         (WebTestRunner):
3902         (WebTestThemeEngineMac):
3903         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3904         (+[FakeActiveWindow alwaysActiveWindow]):
3905         (+[FakeActiveWindow alwaysInactiveWindow]):
3906         (-[FakeActiveWindow initWithActiveControls:]):
3907         (-[FakeActiveWindow _hasActiveControls]):
3908         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3909         (WebTestRunner):
3910         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3911         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3912         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3913         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3914         (WebTestRunner):
3915         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3916         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3917         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3918         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3919         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3920         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3921         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3922         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3923         (WebTestRunner::WebTestThemeEngineWin::getSize):
3924         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3925         (WebTestRunner):
3926         (WebTestThemeEngineWin):
3927         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3928         * DumpRenderTree/chromium/TestShell.cpp:
3929         (TestShell::initialize):
3930         * DumpRenderTree/chromium/TestShell.h:
3931         (WebKit):
3932         * DumpRenderTree/chromium/TestShellMac.mm:
3933         (platformInit):
3934         * DumpRenderTree/chromium/TestShellWin.cpp:
3935         (platformInit):
3936         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3937
3938 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3939
3940         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
3941
3942         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
3943         New property sheet that does not link against CoreFoundation and
3944         CFNetwork.
3945         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3946         Use new TestWebKitAPICommonWinCairo property sheet.
3947         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3948         Ditto.
3949
3950 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3951
3952         [WinCairo] Unreviewed build fix for VS2010.
3953
3954         Had to add WinCairo-specific property sheets to deal with some
3955         library and path differences with the main Apple port.
3956
3957         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3958         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3959         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3960         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
3961         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
3962         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
3963
3964 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
3965
3966         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
3967         https://bugs.webkit.org/show_bug.cgi?id=112849
3968
3969         Reviewed by Sam Weinig.
3970
3971         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3972         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3973         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3974
3975 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
3976
3977         [WinCairo] Build WebKit Tools under VS2010
3978         https://bugs.webkit.org/show_bug.cgi?id=112821
3979
3980         Reviewed by Tim Horton.
3981
3982         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3983         Add WinCairo-specific build target.
3984         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
3985         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
3986         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
3987         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
3988         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3989         Add WinCairo-specific build target.
3990         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3991         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3992         Add WinCairo-specific build target.
3993         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
3994         WinCairo-specific build target.
3995         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
3996         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
3997         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
3998         specific build target.
3999         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
4000         WinCairo-specific build target.
4001         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
4002         * win/record-memory/record-memoryDebugWinCairo.props: Added.
4003         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
4004
4005 2013-03-20  Roger Fong  <roger_fong@apple.com>
4006
4007         API test gardening AppleWin port.
4008
4009         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
4010
4011         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
4012         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4013
4014 2013-03-20  Roger Fong  <roger_fong@apple.com>
4015
4016         Test fix for Win EWS bots, catch various errors and restart script if necessary.
4017
4018         * EWSTools/start-queue-win.sh:
4019
4020 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
4021
4022         Unreviewed, add myself to committers.py.
4023
4024 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
4025
4026         Unreviewed. Adding another email for me.
4027
4028         * Scripts/webkitpy/common/config/committers.py:
4029
4030 2013-03-20  Justin Novosad  <junov@google.com>
4031
4032         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
4033         https://bugs.webkit.org/show_bug.cgi?id=112605
4034
4035         Reviewed by James Robinson.
4036
4037         Deleting all the code that was used for propagating and supporting
4038         the Chromium setting for disabling deferred 2d canvas rendering.
4039
4040         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4041         (main):
4042         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
4043         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4044         (WebTestRunner::WebPreferences::reset):
4045         (WebTestRunner::WebPreferences::applyTo):
4046         * DumpRenderTree/chromium/TestShell.cpp:
4047         (TestShell::TestShell):
4048         (TestShell::resetWebSettings):
4049         (TestShell::runFileTest):
4050         * DumpRenderTree/chromium/TestShell.h:
4051         (TestShell):
4052
4053 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
4054
4055         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
4056         https://bugs.webkit.org/show_bug.cgi?id=112699.
4057
4058         Reviewed by Adam Barth.
4059
4060         * Scripts/webkitpy/layout_tests/port/qt.py:
4061         (QtPort._search_paths):
4062         (QtPort._port_specific_expectations_files):
4063         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4064         (QtPortTest):
4065         (QtPortTest._assert_search_path):
4066         (QtPortTest._assert_expectations_files):
4067
4068 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4069
4070         [Qt] Enable kerning by default
4071         https://bugs.webkit.org/show_bug.cgi?id=112704
4072
4073         Reviewed by Jocelyn Turcotte.
4074
4075         Disable kerning by default, since some reference test expectations
4076         expect kerning to be default off.
4077
4078         * DumpRenderTree/qt/TestRunnerQt.cpp:
4079         (TestRunnerQt::reset):
4080         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4081         (WTR::activateFonts):
4082
4083 2013-03-20  Zeno Albisser  <zeno@webkit.org>
4084
4085         [Qt] Remove empty function stubs from TestRunnerQt.
4086         https://bugs.webkit.org/show_bug.cgi?id=112799
4087
4088         We are reducing the code in TestRunnerQt step by step,
4089         in order to finally replace all of it with the generic
4090         TestRunner implementation.
4091         This patch removes several simple function stubs that
4092         currently do not implement any actual functionality.
4093
4094         Reviewed by Kenneth Rohde Christiansen.
4095
4096         * DumpRenderTree/qt/TestRunnerQt.cpp:
4097         * DumpRenderTree/qt/TestRunnerQt.h:
4098         (TestRunnerQt):
4099
4100 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
4101
4102         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
4103         https://bugs.webkit.org/show_bug.cgi?id=112687
4104
4105         Reviewed by Kenneth Rohde Christiansen.
4106
4107         Hide the SearchBar by default on window creation.
4108
4109         * MiniBrowser/efl/main.c:
4110         (window_create):
4111
4112 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
4113
4114         Unreviewed, rolling out r146304.
4115         http://trac.webkit.org/changeset/146304
4116         https://bugs.webkit.org/show_bug.cgi?id=112788
4117
4118         to many expectations to update (Requested by antonm on
4119         #webkit).
4120
4121         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4122         * DumpRenderTree/DumpRenderTree.gypi:
4123         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4124         (WebKit):
4125         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4126         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4127         (TestInterfaces):
4128         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4129         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
4130         * DumpRenderTree/chromium/TestShell.cpp:
4131         (TestShell::initialize):
4132         * DumpRenderTree/chromium/TestShell.h:
4133         (WebKit):
4134         * DumpRenderTree/chromium/TestShellMac.mm:
4135         (platformInit):
4136         * DumpRenderTree/chromium/TestShellWin.cpp:
4137         (platformInit):
4138         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
4139         (WebThemeControlDRTWin::WebThemeControlDRTWin):
4140         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
4141         (WebThemeControlDRTWin::box):
4142         (WebThemeControlDRTWin::line):
4143         (WebThemeControlDRTWin::triangle):
4144         (WebThemeControlDRTWin::roundRect):
4145         (WebThemeControlDRTWin::oval):
4146         (WebThemeControlDRTWin::circle):
4147         (WebThemeControlDRTWin::nestedBoxes):
4148         (WebThemeControlDRTWin::markState):
4149         (WebThemeControlDRTWin::draw):
4150         (WebThemeControlDRTWin::drawTextField):
4151         (WebThemeControlDRTWin::drawProgressBar):
4152         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
4153         (WebThemeControlDRTWin):
4154         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
4155         (WebThemeEngineDRTMac):
4156         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
4157         (+[FakeActiveWindow alwaysActiveWindow]):
4158         (+[FakeActiveWindow alwaysInactiveWindow]):
4159         (-[FakeActiveWindow initWithActiveControls:]):
4160         (-[FakeActiveWindow _hasActiveControls]):
4161         (WebThemeEngineDRTMac::paintScrollbarThumb):
4162         (stateToHIEnableState):
4163         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4164         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4165         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
4166         (webRectToSkIRect):
4167         (drawControl):
4168         (drawTextField):
4169         (drawProgressBar):
4170         (WebThemeEngineDRTWin::paintButton):
4171         (WebThemeEngineDRTWin::paintMenuList):
4172         (WebThemeEngineDRTWin::paintScrollbarArrow):
4173         (WebThemeEngineDRTWin::paintScrollbarThumb):
4174         (WebThemeEngineDRTWin::paintScrollbarTrack):
4175         (WebThemeEngineDRTWin::paintSpinButton):
4176         (WebThemeEngineDRTWin::paintTextField):
4177         (WebThemeEngineDRTWin::paintTrackbar):
4178         (WebThemeEngineDRTWin::paintProgressBar):
4179         (WebThemeEngineDRTWin::getSize):
4180         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
4181         (WebThemeEngineDRTWin):
4182         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
4183
4184 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4185
4186         [Qt] Support -webkit-font-smoothing
4187         https://bugs.webkit.org/show_bug.cgi?id=106009
4188
4189         Reviewed by Jocelyn Turcotte.
4190
4191         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
4192
4193         * DumpRenderTree/qt/TestRunnerQt.cpp:
4194         (TestRunnerQt::reset):
4195
4196 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
4197
4198         [GTK] accessibility/aria-scrollbar-role.html is failing
4199         https://bugs.webkit.org/show_bug.cgi?id=98358
4200
4201         Reviewed by Martin Robinson.
4202
4203         Adds support for checking accessibility object's orientation.
4204         Orientation is checked by retrieving proper state of accessibility object.
4205
4206         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4207         (checkElementState):
4208         (AccessibilityUIElement::orientation):
4209         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4210         (WTR::AccessibilityUIElement::orientation):
4211
4212 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
4213
4214         [chromium] move WebThemeEngine implementations to TestRunner library
4215         https://bugs.webkit.org/show_bug.cgi?id=112751
4216
4217         Reviewed by Adam Barth.
4218
4219         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4220         * DumpRenderTree/DumpRenderTree.gypi:
4221         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4222         (WebKit):
4223         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4224         (WebTestRunner::TestInterfaces::themeEngine):
4225         (WebTestRunner):
4226         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4227         (WebKit):
4228         (TestInterfaces):
4229         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4230         (WebTestRunner::WebTestInterfaces::themeEngine):
4231         (WebTestRunner):
4232         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
4233         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
4234         (WebTestRunner):
4235         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
4236         (WebTestRunner::WebTestThemeControlWin::box):
4237         (WebTestRunner::WebTestThemeControlWin::line):
4238         (WebTestRunner::WebTestThemeControlWin::triangle):
4239         (WebTestRunner::WebTestThemeControlWin::roundRect):
4240         (WebTestRunner::WebTestThemeControlWin::oval):
4241         (WebTestRunner::WebTestThemeControlWin::circle):
4242         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
4243         (WebTestRunner::WebTestThemeControlWin::markState):
4244         (WebTestRunner::WebTestThemeControlWin::draw):
4245         (WebTestRunner::WebTestThemeControlWin::drawTextField):
4246         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
4247         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
4248         (WebTestRunner):
4249         (WebTestThemeControlWin):
4250         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
4251         (WebTestRunner):
4252         (WebTestThemeEngineMac):
4253         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
4254         (+[FakeActiveWindow alwaysActiveWindow]):
4255         (+[FakeActiveWindow alwaysInactiveWindow]):
4256         (-[FakeActiveWindow initWithActiveControls:]):
4257         (-[FakeActiveWindow _hasActiveControls]):
4258         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
4259         (WebTestRunner):
4260         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
4261         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
4262         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
4263         (WebTestRunner::WebTestThemeEngineWin::paintButton):
4264         (WebTestRunner):
4265         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
4266         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
4267         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
4268         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
4269         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
4270         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
4271         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
4272         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
4273         (WebTestRunner::WebTestThemeEngineWin::getSize):
4274         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
4275         (WebTestRunner):
4276         (WebTestThemeEngineWin):
4277         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
4278         * DumpRenderTree/chromium/TestShell.cpp:
4279         (TestShell::initialize):
4280         * DumpRenderTree/chromium/TestShell.h:
4281         (WebKit):
4282         * DumpRenderTree/chromium/TestShellMac.mm:
4283         (platformInit):
4284         * DumpRenderTree/chromium/TestShellWin.cpp:
4285         (platformInit):
4286         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
4287
4288 2013-03-19  Tony Chang  <tony@chromium.org>
4289
4290         Move testRunner.setTouchDragDropEnabled to internals.settings
4291         https://bugs.webkit.org/show_bug.cgi?id=112739
4292
4293         Reviewed by Adam Barth.
4294
4295         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
4296         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
4297         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
4298         (TestRunner): Remove unnecessary code.
4299         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
4300         (WebTestRunner::WebPreferences::reset):
4301         (WebTestRunner::WebPreferences::applyTo): Always set to false.
4302
4303 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
4304
4305         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
4306         https://bugs.webkit.org/show_bug.cgi?id=112754
4307
4308         Reviewed by Darin Fisher.
4309
4310         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
4311         now that it's always defined.
4312
4313         * DumpRenderTree/chromium/WebViewHost.cpp:
4314         * DumpRenderTree/chromium/WebViewHost.h:
4315         (WebViewHost):
4316
4317 2013-03-19  Kenneth Russell  <kbr@google.com>
4318
4319         Unreviewed, rolling out r146290.
4320         http://trac.webkit.org/changeset/146290
4321         https://bugs.webkit.org/show_bug.cgi?id=112751
4322
4323         Broke Chromium Mac build.
4324
4325         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4326         * DumpRenderTree/DumpRenderTree.gypi:
4327         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
4328         (WebKit):
4329         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
4330         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
4331         (TestInterfaces):
4332         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
4333         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
4334         * DumpRenderTree/chromium/TestShell.cpp:
4335         (TestShell::initialize):
4336         * DumpRenderTree/chromium/TestShell.h:
4337         (WebKit):
4338         * DumpRenderTree/chromium/TestShellMac.mm:
4339         (platformInit):
4340         * DumpRenderTree/chromium/TestShellWin.cpp:
4341         (platformInit):
4342         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
4343         (WebThemeControlDRTWin::WebThemeControlDRTWin):
4344         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
4345         (WebThemeControlDRTWin::box):
4346         (WebThemeControlDRTWin::line):
4347         (WebThemeControlDRTWin::triangle):
4348         (WebThemeControlDRTWin::roundRect):
4349         (WebThemeControlDRTWin::oval):
4350         (WebThemeControlDRTWin::circle):