1c76920bfdfb2b1eb42210a0887bbe1fbcd14a93
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
2
3         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
4         https://bugs.webkit.org/show_bug.cgi?id=73328
5
6         Reviewed by Kent Tamura.
7
8         * DumpRenderTree/chromium/LayoutTestController.cpp:
9         (LayoutTestController::enableFixedLayoutMode):
10         (LayoutTestController::setFixedLayoutSize):
11
12 2011-11-29  Hayato Ito  <hayato@chromium.org>
13
14         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
15         https://bugs.webkit.org/show_bug.cgi?id=73381
16
17         Reviewed by Ryosuke Niwa.
18
19         This is a quick fix for the breakage of tests on non-chromium port.
20         We should implement diff_image later on non-chromium ports.
21
22         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
23         (write_test_result):
24
25 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
26
27         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
28         https://bugs.webkit.org/show_bug.cgi?id=72489
29
30         Reviewed by Eric Seidel.
31
32         Before the this fix always added "qt" option for the option list
33         * Scripts/run-webkit-tests:
34         * Scripts/webkitpy/layout_tests/port/qt.py:
35
36 2011-11-29  David Levin  <levin@chromium.org>
37
38         Add a way to revert a variable to its previous value after leaving a scope.
39         https://bugs.webkit.org/show_bug.cgi?id=73371
40
41         Reviewed by Adam Barth.
42
43         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
44         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
46         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
47         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
48         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
49
50 2011-11-28  Kentaro Hara  <haraken@chromium.org>
51
52         Implement [Supplemental] IDL and support it in run-bindings-tests
53         https://bugs.webkit.org/show_bug.cgi?id=73162
54
55         Reviewed by Adam Barth.
56
57         run-bindings-tests supports the [Supplemental] IDL in the following way.
58             (1) It creates a file |x| listing all IDL files.
59             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
60             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
61                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
62                 including all attributes in IDL files that are supplementing the IDL file |z|.
63
64         * Scripts/run-bindings-tests:
65         (generate_from_idl):
66         (generate_supplemental_dependency):
67         (detect_changes):
68         (run_tests):
69         (main):
70
71 2011-11-18  Nat Duca  <nduca@chromium.org>
72
73         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
74         https://bugs.webkit.org/show_bug.cgi?id=70838
75
76         Reviewed by James Robinson.
77
78         * DumpRenderTree/chromium/TestShell.cpp:
79         (TestShell::resetWebSettings):
80         * DumpRenderTree/chromium/TestShell.h:
81         (TestShell::threadedCompositingEnabled):
82         * DumpRenderTree/chromium/WebPreferences.cpp:
83         (WebPreferences::reset):
84         (WebPreferences::applyTo):
85         * DumpRenderTree/chromium/WebPreferences.h:
86         * DumpRenderTree/chromium/WebViewHost.cpp:
87         (WebViewHost::WebViewHost):
88         (WebViewHost::~WebViewHost):
89
90 2011-11-29  Ojan Vafai  <ojan@chromium.org>
91
92         List of builders in the flakiness dashboard is out of date
93         https://bugs.webkit.org/show_bug.cgi?id=73347
94
95         Reviewed by Adam Barth.
96
97         The chromium gpu bots no longer run layout tests, so kill that
98         group entirely.
99
100         * TestResultServer/static-dashboards/builders.js:
101         * TestResultServer/static-dashboards/dashboard_base.js:
102
103 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
104
105         [Qt] Don't hard-code the list of WebKit2 generated sources
106
107         The generated sources are... wait for it... generated. So
108         use the generator itself to figure out which sources we need
109         to compile.
110
111         Reviewed by Simon Hausmann.
112
113         * qmake/mkspecs/features/default_post.prf:
114
115 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
116
117         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
118         https://bugs.webkit.org/show_bug.cgi?id=73216
119
120         Reviewed by Philippe Normand.
121
122         Add a script that tries to sniff out 'make dist' problems without running
123         'make dist.' 'make distcheck' takes a very long time to run and this should
124         reduce the amount of times it needs to be run consecutively.
125
126         * gtk/common.py:
127         (get_build_path.is_valid_build_directory): Guess the source directory
128         by the existence of the GNUmakefile instead of the .libs directory. This
129         allows one to run the script after running autogen.sh but before fully
130         building.
131         * gtk/find-make-dist-errors: Added.
132
133 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
134
135         [Qt] Remove use of internal headers in the MiniBrowser
136
137         Reviewed by Simon Hausmann.
138
139         * MiniBrowser/qt/MiniBrowser.pro:
140
141 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
142
143         [Qt] Fix debug-shlib build without webkit2
144
145         Reviewed by Tor Arne Vestbø.
146
147         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
148
149 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
150
151         [Qt][WK2] Unreviewed buildfix after r101307.
152
153         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
154
155 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
156
157         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
158         https://bugs.webkit.org/show_bug.cgi?id=72848
159
160         Add option to build-webkit.
161
162         Reviewed by Dimitri Glazkov.
163
164         * Scripts/build-webkit:
165
166 2011-11-28  Ojan Vafai  <ojan@chromium.org>
167
168         gtest normalization in the test results server is sometimes wrong
169         https://bugs.webkit.org/show_bug.cgi?id=73262
170
171         Reviewed by Tony Chang.
172
173         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
174         entries in the incremental JSON, one of the entries will have the correct data
175         from the run and the other will have dummy no-data values. Make sure to
176         always pick the one with real data.
177
178         * TestResultServer/model/jsonresults.py:
179         (JsonResults._remove_gtest_modifiers):
180         * TestResultServer/model/jsonresults_unittest.py:
181         (JsonResultsTest.test_remove_gtest_modifiers):
182
183 2011-11-28  Ojan Vafai  <ojan@chromium.org>
184
185         Some of the results.json files have results/times entries at the directory level
186         https://bugs.webkit.org/show_bug.cgi?id=73261
187
188         Reviewed by Tony Chang.
189
190         This is just a bug that got introduced in a temporary push of the results server.
191         This patch repairs the broken files. After all the bots have cycled, we can simplify
192         this code to just assert that results/times are not at the directory level.
193
194         Also, when catching exceptions, log the full stacktrace.
195
196         * TestResultServer/model/jsonresults.py:
197         (_is_directory):
198         (JsonResults._load_json):
199         (JsonResults._merge_tests):
200         (JsonResults.merge):
201         * TestResultServer/model/jsonresults_unittest.py:
202         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
203
204 2011-11-28  Tony Chang  <tony@chromium.org>
205
206         ews bots should pass --force to update-webkit-chromium
207         https://bugs.webkit.org/show_bug.cgi?id=73230
208
209         Reviewed by Adam Barth.
210
211         This makes it less likely for gclient changes to break the bots (e.g.,
212         if a DEPS repository moves or is switched to a branch).
213
214         Also pass --force when using |build-webkit --update-chromium| since this
215         appears to only be used by the bots.
216
217         Take 2: Add Options.non_interactive to update.py's options() method.
218
219         * Scripts/update-webkit:
220         * Scripts/webkitdirs.pm:
221         (determineIsChromium): Add --force-update to update-webkit --chromium.
222         (forceChromiumUpdate):
223         (buildChromium): Pass --force to update-webkit-chromium.
224         * Scripts/webkitpy/tool/steps/update.py:
225         (Update.run): Add --force-update if non-interactive (i.e., bots).
226         * Scripts/webkitpy/tool/steps/update_unittest.py:
227
228 2011-11-28  Tony Chang  <tony@chromium.org>
229
230         Revert r101279, broke the ews and cq bots.
231
232         * Scripts/update-webkit:
233         * Scripts/webkitdirs.pm:
234         (determineIsChromium):
235         (buildChromium):
236         * Scripts/webkitpy/common/config/ports.py:
237         (WebKitPort.update_webkit_command):
238         (ChromiumPort.update_webkit_command):
239         * Scripts/webkitpy/common/config/ports_mock.py:
240         (MockPort.update_webkit_command):
241         * Scripts/webkitpy/tool/steps/update.py:
242         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
243
244 2011-11-28  Ojan Vafai  <ojan@chromium.org>
245
246         testlistjson on the test results server doesn't understand hierarchical results format
247         https://bugs.webkit.org/show_bug.cgi?id=73246
248
249         Reviewed by Tony Chang.
250
251         * TestResultServer/model/jsonresults.py:
252         (JsonResults._delete_results_and_times):
253         Instead of just getting the top-level keys, we now walk the tests tree and
254         delete the results and times values.
255
256         * TestResultServer/model/jsonresults_unittest.py:
257         Simplify the test harness to take in the same JSON format for the tests
258         that the actual results.json uses instead of something very similar but
259         needlessly different. This also allows for testing the broken case of
260         results and times values being at non-leaf level.
261
262 2011-11-28  Tony Chang  <tony@chromium.org>
263
264         ews bots should pass --force to update-webkit-chromium
265         https://bugs.webkit.org/show_bug.cgi?id=73230
266
267         Reviewed by Adam Barth.
268
269         This makes it less likely for gclient changes to break the bots (e.g.,
270         if a DEPS repository moves or is switched to a branch).
271
272         Also pass --force when using |build-webkit --update-chromium| since this
273         appears to only be used by the bots.
274
275         * Scripts/update-webkit:
276         * Scripts/webkitdirs.pm:
277         (determineIsChromium): Add --force-update to update-webkit --chromium.
278         (forceChromiumUpdate):
279         (buildChromium): Pass --force to update-webkit-chromium.
280         * Scripts/webkitpy/tool/steps/update.py:
281         (Update.run): Add --force-update if non-interactive (i.e., bots).
282         * Scripts/webkitpy/tool/steps/update_unittest.py:
283
284 2011-11-28  Michael Saboff  <msaboff@apple.com>
285
286         Fixed help message for --exclude-kraken to say that
287         it excludes Kraken and not SunSpider.
288
289         Rubber-stamped by Filip Pizlo.
290
291         * Scripts/bencher:
292
293 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
294
295         Unreviewed, rolling out r101273.
296         http://trac.webkit.org/changeset/101273
297         https://bugs.webkit.org/show_bug.cgi?id=73244
298
299         multiple test failures and timeouts (Requested by tony^work on
300         #webkit).
301
302         * DumpRenderTree/DumpRenderTree.gypi:
303         * DumpRenderTree/chromium/EventSender.cpp:
304         (EventSender::keyDown):
305         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
306         (AlarmHandler):
307         (TestShell::waitTestFinished):
308         (platformInit):
309         (openStartupDialog):
310         (checkLayoutTestSystemDependencies):
311         * DumpRenderTree/chromium/TestShellGtk.cpp:
312         (AlarmHandler):
313         (setupFontconfig):
314         (TestShell::waitTestFinished):
315         (platformInit):
316         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
317         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
318
319 2011-11-28  John Yani  <vanuan@gmail.com>
320
321         new-run-webkit-tests is locale dependent
322         https://bugs.webkit.org/show_bug.cgi?id=68691
323
324         Reviewed and modified by Eric Seidel.
325
326         This is a simpler version of John's patch which I'm landing.
327         This just engages the hacks from the Host constructor on a global
328         basis.
329
330         * Scripts/webkitpy/common/host.py:
331         (Host.__init__):
332         (Host._engage_awesome_locale_hacks):
333
334 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
335
336         [Chromium] Fix broken DRT build for Aura Linux
337         https://bugs.webkit.org/show_bug.cgi?id=72667
338
339         Reviewed by Tony Chang.
340
341         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
342
343         The following changes have been made:
344
345           1. Renamed TestShellAndroid to TestShellLinux.
346           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
347           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
348
349         * DumpRenderTree/DumpRenderTree.gypi:
350         * DumpRenderTree/chromium/EventSender.cpp:
351         (EventSender::keyDown):
352         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
353         * DumpRenderTree/chromium/TestShellGtk.cpp:
354         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
355         (AlarmHandler):
356         (TestShell::waitTestFinished):
357         (setupFontconfig):
358         (platformInit):
359         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
360         (checkLayoutTestSystemDependencies):
361         (openStartupDialog):
362
363 2011-11-28  Eric Seidel  <eric@webkit.org>
364
365         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
366         https://bugs.webkit.org/show_bug.cgi?id=71983
367
368         Reviewed by Adam Barth.
369
370         We'll add more code to Environment overtime,
371         allowing us to mock out more of our direct interactions with os.environ.
372
373         This patch also makes run_command print the passed in environment.
374
375         * Scripts/webkitpy/common/host_mock.py:
376         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
377         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
378         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
379         * Scripts/webkitpy/common/system/executive.py:
380         * Scripts/webkitpy/common/system/executive_mock.py:
381         * Scripts/webkitpy/layout_tests/port/webkit.py:
382         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
383         * Scripts/webkitpy/tool/commands/download_unittest.py:
384         * Scripts/webkitpy/tool/steps/build.py:
385
386 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
387
388         [Qt] Build system fixes against V8.
389
390         Reviewed by Tor Arne Vestbø.
391
392         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
393         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
394         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
395
396 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
397
398         Make sure the useFixedLayout feature is consistently handled
399         https://bugs.webkit.org/show_bug.cgi?id=73212
400
401         Reviewed by Simon Hausmann.
402
403         The web page parameters are set to our Qt defaults and are now altered
404         in the WebKitTestRunner.
405
406         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
407         (WTR::WrapperWindow::WrapperWindow):
408
409 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
410
411         [Qt] WTF should be built as separate static library
412         https://bugs.webkit.org/show_bug.cgi?id=73201
413
414         Reviewed by Tor Arne Vestbø.
415
416         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
417         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
418         thus wtf dependency.
419         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
420         * WebKitTestRunner/Target.pri: Ditto.
421         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
422         consider wtf, too.
423         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
424         moved into wtf.prf.
425         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
426         link in libwtf.
427         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
428
429 2011-11-28  Kentaro Hara  <haraken@chromium.org>
430
431         run-bindings-tests shows diff error for a newly added binding test
432         https://bugs.webkit.org/show_bug.cgi?id=73179
433
434         Reviewed by Adam Barth.
435
436         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
437         run-bindings-tests just shows diff error because reference files
438         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
439
440             FAIL: (V8) V8TestSupplemental.h
441             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
442
443         Instead, this patch treats a non-existent reference file as an empty file and
444         shows the result of the newly added binding test, like this:
445
446             FAIL: (V8) V8TestSupplemental.h
447             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
448             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
449             @@ -0,0 +1,84 @@
450             +/*
451             +    This file is part of the WebKit open source project.
452             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
453             +
454             (omitted)
455
456         * Scripts/run-bindings-tests:
457         (detect_changes): Just added an -N option to the diff command.
458
459 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
460
461         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
462         https://bugs.webkit.org/show_bug.cgi?id=73165
463
464         Reviewed by Philippe Normand.
465
466         Fix some syntax errors in this script and remove an unused variable.
467
468         * gtk/generate-gtkdoc:
469         (get_webkit2_options.src_path): 
470         (get_webkit2_options):
471         (get_webkit1_options.src_path):
472
473 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
474
475         [wx] Unreviewed build fix. Enable the inspector.
476         
477         * waf/build/settings.py:
478
479 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
480
481         Try to fix the build after r101174.
482
483         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
484
485 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
486
487         [GTK] Integrate build-gtkdoc into build-webkit and make
488         https://bugs.webkit.org/show_bug.cgi?id=72626
489
490         Reviewed by Philippe Normand.
491
492         * GNUmakefile.am: Added support for new scripts and "make docs".
493         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
494         (buildAutotoolsProject):
495         * gtk/generate-gtkdoc: Added.
496         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
497
498 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
499
500         [Qt] Add support for using OWRT with Qt5
501         https://bugs.webkit.org/show_bug.cgi?id=72947
502
503         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
504
505         Reviewed by Csaba Osztrogonác.
506
507         * Scripts/old-run-webkit-tests:
508
509 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
510
511         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
512         https://bugs.webkit.org/show_bug.cgi?id=73126
513
514         No need to have a separate client call for this. The front-end can store messages
515         which arrive before front-end loaded and dispatch them later. This happens in layout
516         tests only by the way as all other messages should be initiated by the front-end code.
517
518         Reviewed by Pavel Feldman.
519
520         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
521         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
522         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
523         * DumpRenderTree/chromium/DRTDevToolsClient.h:
524
525 2011-11-24  Kentaro Hara  <haraken@chromium.org>
526
527         Replace subprocess.call() with subprocess.Popen()
528         https://bugs.webkit.org/show_bug.cgi?id=73105
529
530         Reviewed by Adam Barth.
531
532         Currently, the stdout and stderr of the child processes of run-bindings-tests
533         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
534         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
535         between a parent process and a child process. This patch replaces subprocess.call() with
536         subprocess.Popen() and synchronizes the stdout and stderr between them.
537         This patch also makes output messages of run-bindings-tests more readable.
538
539         With this patch, the output messages of run-bindings-tests look like as follows:
540
541             PASS: (CPP) WebDOMTestObj.h
542             PASS: (CPP) WebDOMTestObj.cpp
543             FAIL: (CPP) WebDOMTestInterface.h
544             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
545             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
546             @@ -23,7 +23,7 @@
547              #ifndef WebDOMTestInterface_h
548              #define WebDOMTestInterface_h
549
550             -#if ENABLE(Condition1) || ENABLE(Condition2)
551             +#if ENABLE(Condition1) || ENABLE(Condition3)
552
553              #include <WebDOMObject.h>
554              #include <WebDOMString.h>
555              @@ -53,5 +53,5 @@
556              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
557
558              #endif
559             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
560             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
561             PASS: (CPP) WebDOMFloat64Array.cpp
562             PASS: (CPP) WebDOMFloat64Array.h
563
564             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
565
566         * Scripts/run-bindings-tests:
567         (generate_from_idl):
568         (detect_changes):
569         (run_tests):
570         (main):
571
572 2011-11-24  Kentaro Hara  <haraken@chromium.org>
573
574         Fix the current working directory of run-bindings-tests
575         https://bugs.webkit.org/show_bug.cgi?id=73106
576
577         Reviewed by Adam Barth.
578
579         Currently, run-bindings-tests outputs the following error
580         (although it outputs "all tests passed!" in the end):
581
582             Testing the ObjC generator on TestObj.idl
583             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
584             gcc: warning: '-x objective-c' after last input file has no effect
585             gcc: no input files
586
587         This is because CodeGeneratorObjC.pm assumes that the current working directory
588         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
589         Thus, this patch changes it to WebKit/Source/.
590
591         * Scripts/run-bindings-tests:
592         (generate_from_idl):
593         (main):
594
595 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
596
597         [Qt] Get rid of the buildDirForSource() function in the build system
598
599         At some point the plan was to allow for running qmake on sub-trees
600         of the sources, into the top level build directory, but this is no
601         longer possible, so no reason to keep the convenience function around.
602
603         Reviewed by Simon Hausmann.
604
605         * WebKitTestRunner/DerivedSources.pri:
606         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
607         * qmake/mkspecs/features/default_post.prf:
608         * qmake/mkspecs/features/default_pre.prf:
609         * qmake/mkspecs/features/functions.prf:
610         * qmake/mkspecs/features/javascriptcore.prf:
611         * qmake/mkspecs/features/webcore.prf:
612         * qmake/mkspecs/features/webkit2.prf:
613
614 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
615
616         Unreviewed, rolling out r101107.
617         http://trac.webkit.org/changeset/101107
618         https://bugs.webkit.org/show_bug.cgi?id=73062
619
620         Breaks the commit-queue (Requested by abarth on #webkit).
621
622         * Scripts/webkitpy/common/host.py:
623         (Host._engage_awesome_windows_hacks):
624         * Scripts/webkitpy/common/host_mock.py:
625         (MockHost.__init__):
626         * Scripts/webkitpy/common/system/environment.py: Removed.
627         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
628         * Scripts/webkitpy/common/system/executive.py:
629         (Executive._run_command_with_teed_output):
630         (Executive.run_and_throw_if_fail):
631         * Scripts/webkitpy/common/system/executive_mock.py:
632         (MockExecutive.run_and_throw_if_fail):
633         (MockExecutive.run_command):
634         * Scripts/webkitpy/layout_tests/port/webkit.py:
635         (WebKitPort._driver_build_script_name):
636         (WebKitPort._run_script):
637         (WebKitPort._build_driver):
638         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
639         (test_build_driver):
640         * Scripts/webkitpy/tool/commands/download_unittest.py:
641         * Scripts/webkitpy/tool/steps/build.py:
642         (Build.build):
643
644 2011-11-23  Ojan Vafai  <ojan@chromium.org>
645
646         Unreviewed, rolling out r101110.
647         http://trac.webkit.org/changeset/101110
648         https://bugs.webkit.org/show_bug.cgi?id=73057
649
650         The bots have now cycled and this patch is no longer needed.
651
652         * Scripts/webkitpy/layout_tests/controllers/manager.py:
653         (Manager._upload_json_files):
654
655 2011-11-23  Ojan Vafai  <ojan@chromium.org>
656
657         Temporarily save the incremental results json in order to identify bug
658         https://bugs.webkit.org/show_bug.cgi?id=73057
659
660         Reviewed by Dean Jackson.
661
662         The test results server needed to be rolled back from tip of tree
663         due to a JSON merging bug. It's hard to identify what the bug is without
664         the raw data.
665
666         * Scripts/webkitpy/layout_tests/controllers/manager.py:
667         (Manager._upload_json_files):
668
669 2011-11-23  Ojan Vafai  <ojan@chromium.org>
670
671         Merging two version 4 results hits an error in the test results server
672         https://bugs.webkit.org/show_bug.cgi?id=73042
673
674         Reviewed by Adam Barth.
675
676         The old code assumed that if the aggregate results value was not a leaf
677         value that the incremental results would exist, which is just totally
678         wrong. Added a test for that case as well.
679
680         * TestResultServer/model/jsonresults.py:
681         (JsonResults._merge_tests):
682         * TestResultServer/model/jsonresults_unittest.py:
683         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
684         (JsonResultsTest.test_merge_build_directory_hierarchy):
685
686 2011-11-23  Eric Seidel  <eric@webkit.org>
687
688         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
689         https://bugs.webkit.org/show_bug.cgi?id=71983
690
691         Reviewed by Adam Barth.
692
693         We'll add more code to Environment overtime,
694         allowing us to mock out more of our direct interactions with os.environ.
695
696         This patch also makes run_command print the passed in environment.
697
698         * Scripts/webkitpy/common/host_mock.py:
699         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
700         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
701         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
702         * Scripts/webkitpy/common/system/executive.py:
703         * Scripts/webkitpy/common/system/executive_mock.py:
704         * Scripts/webkitpy/layout_tests/port/webkit.py:
705         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
706         * Scripts/webkitpy/tool/commands/download_unittest.py:
707         * Scripts/webkitpy/tool/steps/build.py:
708
709 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
710
711         [Qt] Re-generate QtWebKit API forwarding headers when API changes
712
713         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
714         so we need sync.profile to live in the same directory as the project file
715         that will be touched when adding/removing API (api.pri in our case).
716
717         Since the WebKit2 APIs live in a separate static library, we have to
718         add the project file for WebKit2 as a dependency of the api.pri file
719         as well, so that any changes to the WebKit2 API will still trigger a
720         run of qmake (and then syncqt).
721
722         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
723         that the forwarding headers are still generated in the root build dir,
724         not in the Source dir along with the internal forwarding headers.
725
726         Reviewed by Andreas Kling.
727
728         * qmake/mkspecs/features/default_pre.prf:
729         * qmake/mkspecs/features/functions.prf:
730
731 2011-11-23  Johnny Ding  <jnd@chromium.org>
732
733         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
734         https://bugs.webkit.org/show_bug.cgi?id=72950
735
736         Reviewed by Tony Chang.
737
738         * DumpRenderTree/chromium/LayoutTestController.cpp:
739         (LayoutTestController::queueLoadHTMLString):
740
741 2011-11-23  Adam Barth  <abarth@webkit.org>
742
743         garden-o-matic should display a message if it can't find results to display
744         https://bugs.webkit.org/show_bug.cgi?id=72991
745
746         Reviewed by Dimitri Glazkov.
747
748         Not all failures (e.g., TIMEOUT) have results that we can display.
749         This patch adds a short message so that the user can see that we're
750         done trying to load the results.
751
752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
755
756 2011-11-23  Adam Barth  <abarth@webkit.org>
757
758         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
759         https://bugs.webkit.org/show_bug.cgi?id=72992
760
761         Reviewed by Dimitri Glazkov.
762
763         This patch also prepares us to list other sorts of failures, like
764         performance and unit test.
765
766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
769         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
770
771 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
772
773         Add new Chromium tests to the flakiness dashboard
774         https://bugs.webkit.org/show_bug.cgi?id=72997
775
776         Reviewed by Ojan Vafai.
777
778         * TestResultServer/static-dashboards/dashboard_base.js:
779         ():
780
781 2011-11-23  Adam Barth  <abarth@webkit.org>
782
783         garden-o-matic should support AUDIO failures
784         https://bugs.webkit.org/show_bug.cgi?id=69477
785
786         Reviewed by Dimitri Glazkov.
787
788         This is a first iteration at supporting AUDIO failures in
789         garden-o-matic.  We'll probably need to iterate a bit when we have a
790         real audio failure in the tree to play with.  For example, we'll
791         probably want to add and <audio> element to the "Examine" view to hear
792         the differences, but that all can be done in a subsequent patch.
793
794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
795
796 2011-11-23  Scott Graham  <scottmg@chromium.org>
797
798         Adding gamepad support
799         https://bugs.webkit.org/show_bug.cgi?id=69451
800
801         Reviewed by Darin Fisher.
802
803         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
804         gamepad data that will be retrieved when JS code pulls via API access.
805
806         * DumpRenderTree/DumpRenderTree.gypi:
807         * DumpRenderTree/chromium/GamepadController.cpp: Added.
808         (GamepadController::GamepadController):
809         (GamepadController::bindToJavascript):
810         (GamepadController::reset):
811         (GamepadController::connect):
812         (GamepadController::disconnect):
813         (GamepadController::setId):
814         (GamepadController::setButtonCount):
815         (GamepadController::setButtonData):
816         (GamepadController::setAxisCount):
817         (GamepadController::setAxisData):
818         (GamepadController::fallbackCallback):
819         * DumpRenderTree/chromium/GamepadController.h: Added.
820         * DumpRenderTree/chromium/TestShell.cpp:
821         (TestShell::TestShell):
822         (TestShell::resetTestController):
823         (TestShell::bindJSObjectsToWindow):
824         * DumpRenderTree/chromium/TestShell.h:
825         (TestShell::gamepadController):
826
827 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
828
829         [CMake] Move the top-level logic to the top-level directory.
830         https://bugs.webkit.org/show_bug.cgi?id=72685
831
832         Reviewed by Brent Fulgham.
833
834         * CMakeLists.txt: Added.
835         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
836         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
837         * Scripts/webkitdirs.pm:
838         (generateBuildSystemFromCMakeProject):
839         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
840
841 2011-11-17  Vincent Scheib  <scheib@chromium.org>
842
843         Pointer Lock: Initial Tests for navigator.webkitPonter
844         https://bugs.webkit.org/show_bug.cgi?id=72659
845
846         Reviewed by Darin Fisher.
847
848         * DumpRenderTree/chromium/TestShell.cpp:
849         (TestShell::TestShell):
850             Enabling PointerLock in TestShell
851
852 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
853
854         Update flakiness dashboard for new Chromium builders and tests
855         https://bugs.webkit.org/show_bug.cgi?id=72931
856
857         Reviewed by Ojan Vafai.
858
859         * TestResultServer/static-dashboards/builders.js:
860         * TestResultServer/static-dashboards/dashboard_base.js:
861
862 2011-11-22  Adam Roben  <aroben@apple.com>
863
864         Remove some debugging code I accidentally left in r101005
865
866         * Scripts/prepare-ChangeLog:
867         (get_function_line_ranges_for_python):
868
869 2011-11-22  Adam Roben  <aroben@apple.com>
870
871         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
872
873         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
874         classes/methods in Python source files
875
876         Reviewed by Dan Bates.
877
878         * Scripts/prepare-ChangeLog:
879         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
880         or that use python as their interpreter. Modified the code that extracts the interpreter to
881         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
882         scripts.
883         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
884         for class/def lines and generate ranges based on them.
885
886 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
887
888         [GTK] Enable WebSocket hybi tests
889         https://bugs.webkit.org/show_bug.cgi?id=72870
890
891         Reviewed by Xan Lopez.
892
893         * DumpRenderTree/gtk/DumpRenderTree.cpp:
894         (resetDefaultsToConsistentValues):
895         Reset the setting value to the default value (true).
896         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
897         (LayoutTestController::overridePreference):
898         Change the setting value through a function in DumpRenderTreeSupportGtk.
899
900 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
901
902         ChangeLogEntry should be able to parse entries with multiple authors
903         https://bugs.webkit.org/show_bug.cgi?id=72690
904
905         Reviewed by Eric Seidel.
906
907         Support multi-author change log entries in ChangeLogEntry. Split author names using
908         the same logic as splitting reviewer names. _authors now stores list of dictionaries
909         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
910         accounts because some contributors are never listed in committers.py. 
911
912         * Scripts/webkitpy/common/checkout/changelog.py:
913         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
914         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
915         throws an exception when the argument is None.
916
917 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
918
919         [Qt] Speed up debug builds.
920         https://bugs.webkit.org/show_bug.cgi?id=72882
921
922         Reviewed by Tor Arne Vestbø.
923
924         Introduce a special type of build that replaces the static jsc/wc/wk2
925         static libraries with shared libraries, that individually are much faster
926         to link and don't require relinking into the big library when changing just
927         one file in one module. It can be enabled with
928         --qmakearg="CONFIG+=force_static_libs_as_shared"
929
930         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
931         disable symbol visibility, static linkage and enable rpath.
932         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
933         we need to link the convenience libraries together or not and renamed linkStaticLibrary
934         to just linkLibrary (because linkage is not necessarily static).
935         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
936         link against jsc/wc/wk2 when linking app code against QtWebKit.
937         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
938         function.
939         * qmake/mkspecs/features/webcore.prf: Ditto.
940         * qmake/mkspecs/features/webkit2.prf: Ditto.
941
942 2011-11-21  Adam Klein  <adamk@chromium.org>
943
944         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
945         https://bugs.webkit.org/show_bug.cgi?id=72898
946
947         Reviewed by Ojan Vafai.
948
949         Also removed a comment that was going to be more trouble to keep up to
950         date than seemed worthwhile (the code is now the documentation).
951
952         * TestResultServer/static-dashboards/flakiness_dashboard.html:
953
954 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
955
956         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
957         https://bugs.webkit.org/show_bug.cgi?id=72895
958
959         Reviewed by Chris Fleizach.
960
961         * DumpRenderTree/chromium/WebViewHost.cpp:
962         (WebViewHost::postAccessibilityNotification):
963
964 2011-11-21  Philippe Normand  <pnormand@igalia.com>
965
966         Unreviewed, run-gtk-tests temporary workaround after r98500.
967
968         * Scripts/run-gtk-tests: Try to find the build directory like in
969         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
970
971 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
972
973         [GTK] Add a way to skip unit tests in the bots
974         https://bugs.webkit.org/show_bug.cgi?id=72879
975
976         Reviewed by Philippe Normand.
977
978         Rewrite the script in python to make it easier for everybody to
979         change it and add support for skipping tests.
980
981         * Scripts/run-gtk-tests:
982
983 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
984
985         [EFL] Add more appcache functions to ewk_settings.
986         https://bugs.webkit.org/show_bug.cgi?id=72143
987
988         Reviewed by Kenneth Rohde Christiansen.
989
990         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
991         (LayoutTestController::clearAllApplicationCaches):
992         (LayoutTestController::setAppCacheMaximumSize): Use the right
993         function, this is not related to the memory cache, but rather to the
994         appcache.
995
996 2011-11-18  Adam Roben  <aroben@apple.com>
997
998         Make NRWT consider all lines of output from parse-malloc-history, not just the first
999
1000         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
1001         found" even when there are more than 1 unique leaks
1002
1003         Reviewed by Darin Adler.
1004
1005         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1006         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
1007         "^" will be considered to match the beginning of any line, not only the beginning of the
1008         string.
1009
1010         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1011         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
1012         fake output and updated expectations to match.
1013
1014 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
1015
1016         [Qt] Clean up MiniBrowser project file after recent changes
1017         https://bugs.webkit.org/show_bug.cgi?id=72869
1018
1019         Reviewed by Simon Hausmann.
1020
1021         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
1022
1023         * MiniBrowser/qt/MiniBrowser.pro:
1024
1025 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1026
1027         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
1028         https://bugs.webkit.org/show_bug.cgi?id=72479
1029
1030         Reviewed by Chris Fleizach.
1031
1032         * DumpRenderTree/AccessibilityUIElement.cpp:
1033         (getIsSelectedOptionActiveCallback):
1034         (AccessibilityUIElement::getJSClass):
1035         * DumpRenderTree/AccessibilityUIElement.h:
1036         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1037         (AccessibilityUIElement::AccessibilityUIElement):
1038         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
1039         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1040         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1041         (AccessibilityUIElement::isSelectedOptionActive):
1042         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1043         (AccessibilityUIElement::isSelectedOptionActive):
1044         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1045         (AccessibilityUIElement::isSelectedOptionActive):
1046
1047 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
1048
1049         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
1050         https://bugs.webkit.org/show_bug.cgi?id=72859
1051
1052         Reviewed by Eric Seidel.
1053         
1054         * Scripts/new-run-webkit-websocketserver:
1055
1056 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
1057
1058         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
1059         https://bugs.webkit.org/show_bug.cgi?id=72655
1060
1061         Reviewed by Hajime Morita.
1062
1063         Fixed the calculation of offset.
1064
1065         * DumpRenderTree/chromium/WebViewHost.cpp:
1066         (WebViewHost::finishLastTextCheck):
1067
1068 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1069
1070         Change the final place where we use version 3 of the results json output
1071         https://bugs.webkit.org/show_bug.cgi?id=72838
1072
1073         Reviewed by Adam Barth.
1074
1075         This converts the json from being a flat map of test name --> results
1076         to being hierarchical by directory. This will make the json files 
1077         considerably smaller.
1078
1079         Also cleaned up some functions that were returning/checking boolean values
1080         that were always True.
1081
1082         * TestResultServer/model/jsonresults.py:
1083         * TestResultServer/model/jsonresults_unittest.py:
1084
1085 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1086
1087         Include the master name when querying the test results server.
1088         This will soon be required since leaving the master name out mean
1089         that multiple files could match the query.
1090
1091         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1092
1093 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1094
1095         Fix jsonp callback code to add the callback if json content
1096         is not jsonp.
1097         * TestResultServer/handlers/testfilehandler.py:
1098
1099 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
1100
1101         Modify dashboard_base.js to optionally accept version 4 results json.
1102
1103         Reviewed by Ojan Vafai.
1104
1105         * TestResultServer/static-dashboards/dashboard_base.js:
1106         (ADD_RESULTS):
1107         (flattenTrie):
1108         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1109         (testFlattenTrie):
1110
1111 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1112
1113         Stop storing results files as jsonp in the test results server
1114         https://bugs.webkit.org/show_bug.cgi?id=72814
1115
1116         Reviewed by Adam Barth.
1117
1118         * TestResultServer/model/jsonresults.py:
1119         * TestResultServer/model/jsonresults_unittest.py:
1120
1121 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1122
1123         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
1124         https://bugs.webkit.org/show_bug.cgi?id=72813
1125
1126         Reviewed by Adam Barth.
1127
1128         Once this lands, we can start storing pure json in the test results server and then
1129         we can delete the code with all the FIXMEs added here.
1130
1131         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1132         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1133         Only add jsonp for full_results.json.
1134         * TestResultServer/model/jsonresults.py:
1135         * TestResultServer/model/jsonresults_unittest.py:
1136         Accept pure json uploads.
1137         * TestResultServer/static-dashboards/dashboard_base.js:
1138         (appendJSONScriptElementFor):
1139         Use the callback parameter so that the server can start returning pure json if it's left out.
1140
1141 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1142
1143         Allow json NRWT downloads to be pure json and not jsonp
1144         https://bugs.webkit.org/show_bug.cgi?id=72809
1145
1146         Reviewed by Adam Barth.
1147
1148         I'm moving the server to storing and serving up raw json instead of jsonp.
1149         You can still get the jsonp by passing a "callback" parameter, but there's no
1150         need for run-webkit-tests to get jsonp when all it wants is the raw json.
1151
1152         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1153         Make the wrapper stripping only happen if the json is actually wrapped.
1154         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1155
1156 2011-11-18  Daniel Bates  <dbates@rim.com>
1157
1158         Add CMake build infrastructure for the BlackBerry port
1159         https://bugs.webkit.org/show_bug.cgi?id=72768
1160
1161         Reviewed by Antonio Gomes.
1162
1163         Add optional --blackberry command line argument to build-webkit to build the
1164         BlackBerry port.
1165
1166         * Scripts/build-webkit:
1167         * Scripts/webkitdirs.pm:
1168         (determineBaseProductDir):
1169         (argumentsForConfiguration):
1170         (builtDylibPathForName):
1171         (determineIsQt):
1172         (isBlackBerry): Added.
1173         (determineIsBlackBerry): Added.
1174         (blackberryTargetArchitecture): Added.
1175         (isAppleWebKit):
1176
1177 2011-11-18  James Robinson  <jamesr@chromium.org>
1178
1179         Unreviewed, rolling out r100835.
1180         http://trac.webkit.org/changeset/100835
1181         https://bugs.webkit.org/show_bug.cgi?id=72778
1182
1183         Broke some page scale tests
1184
1185         * DumpRenderTree/chromium/EventSender.cpp:
1186         (EventSender::scalePageBy):
1187
1188 2011-11-18  Adam Barth  <abarth@webkit.org>
1189
1190         Prepare to move manual-tests out of WebCore
1191         https://bugs.webkit.org/show_bug.cgi?id=72782
1192
1193         Reviewed by Eric Seidel.
1194
1195         Update this file to refer to the new location of ManualTests.
1196
1197         * Scripts/webkitpy/common/config/build.py:
1198
1199 2011-11-18  James Robinson  <jamesr@chromium.org>
1200
1201         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
1202         https://bugs.webkit.org/show_bug.cgi?id=72778
1203
1204         Reviewed by Kenneth Russell.
1205
1206         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
1207
1208         * DumpRenderTree/chromium/EventSender.cpp:
1209         (EventSender::scalePageBy):
1210
1211 2011-11-18  Scott Graham  <scottmg@chromium.org>
1212
1213         IDL changes for gamepad support
1214         https://bugs.webkit.org/show_bug.cgi?id=71753
1215
1216         Reviewed by Adam Barth.
1217
1218         Runtime enable gamepad in chromium test shell.
1219
1220         * DumpRenderTree/chromium/TestShell.cpp:
1221         (TestShell::TestShell):
1222
1223 2011-10-27  Darin Fisher  <darin@chromium.org>
1224
1225         [chromium] Improve fullscreen API
1226         https://bugs.webkit.org/show_bug.cgi?id=70477
1227
1228         Reviewed by Adam Barth.
1229
1230         Implement enter/exitFullScreen.  The implementation is asynchronous,
1231         via postDelayedTask, to simulate how the browser actually behaves.
1232
1233         * DumpRenderTree/chromium/WebViewHost.cpp:
1234         (WebViewHost::enterFullScreen):
1235         (WebViewHost::exitFullScreen):
1236         (WebViewHost::setAddressBarURL):
1237         (WebViewHost::enterFullScreenNow):
1238         (WebViewHost::exitFullScreenNow):
1239         * DumpRenderTree/chromium/WebViewHost.h:
1240
1241 2011-11-18  Adam Roben  <aroben@apple.com>
1242
1243         Ignore an ANGLE leak that is not WebKit's fault
1244
1245         * Scripts/old-run-webkit-tests:
1246         (countAndPrintLeaks):
1247         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1248         (LeakDetector._callstacks_to_exclude_from_leaks):
1249         Added ScanFromString to the call stacks to exclude on all OS versions.
1250
1251 2011-11-18  Adam Roben  <aroben@apple.com>
1252
1253         Ignore another Lion-specific leak that is not WebKit's fault
1254
1255         * Scripts/old-run-webkit-tests:
1256         (countAndPrintLeaks):
1257         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1258         (LeakDetector._callstacks_to_exclude_from_leaks):
1259         Added SecTransformExecute to the call stacks to exclude.
1260
1261 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
1262
1263         [Qt] Enable WebSocket hybi tests
1264         https://bugs.webkit.org/show_bug.cgi?id=72687
1265
1266         Reviewed by Simon Hausmann.
1267
1268         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
1269
1270         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1271         (WebCore::WebPage::resetSettings):
1272         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1273         (LayoutTestController::overridePreference):
1274
1275 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
1276
1277         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
1278         https://bugs.webkit.org/show_bug.cgi?id=72707
1279
1280         Reviewed by Philippe Normand.
1281
1282         Make new-run-webkit-tests use the right path to locate the test
1283         plugin used by WebKitTestRunner.
1284
1285         * Scripts/webkitpy/layout_tests/port/gtk.py:
1286
1287 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
1288
1289         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
1290         https://bugs.webkit.org/show_bug.cgi?id=72697
1291
1292         Reviewed by Kenneth Rohde Christiansen.
1293
1294         * Tools.pro: Make WTR linux only for the moment.
1295         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
1296         * WebKitTestRunner/Target.pri: Ditto.
1297         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
1298         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
1299
1300 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1301
1302         [Qt] Change default size of the MiniBrowser
1303
1304         Reviewed by Simon Hausmann.
1305
1306         As we lay out desktop pages using the width of 980, change our default
1307         size to 980x735 so that we are not scaling down by default.
1308
1309         * MiniBrowser/qt/MiniBrowserApplication.h:
1310         (WindowOptions::WindowOptions):
1311
1312 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1313
1314         [EFL] Clean up the use of DATA_DIR in the buildsystem
1315         https://bugs.webkit.org/show_bug.cgi?id=72681
1316
1317         Reviewed by Daniel Bates.
1318
1319         Instead of adding -DDATA_DIR in all scopes, only define it in
1320         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
1321         it.
1322
1323         We can then define DATA_DIR to the generated theme directory for
1324         EWebLauncher, since it's what we want here.
1325
1326         * CMakeListsEfl.txt:
1327
1328 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1329
1330         [EFL] Move platform includes last in DRT's include directories.
1331         https://bugs.webkit.org/show_bug.cgi?id=72684
1332
1333         Reviewed by Daniel Bates.
1334
1335         This is the first step in fixing the build when a platform include (in
1336         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
1337         is included instead of WebKit's.
1338
1339         * DumpRenderTree/efl/CMakeLists.txt:
1340
1341 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1342
1343         fuzzy_match doesn't recognize "Dan B" or "hyatt"
1344         https://bugs.webkit.org/show_bug.cgi?id=72636
1345
1346         Reviewed by Eric Seidel.
1347
1348         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
1349         and user names of email addreses such as rniwa in rniwa@webkit.org.
1350
1351         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
1352
1353         * Scripts/webkitpy/common/config/committers.py:
1354         * Scripts/webkitpy/common/config/committers_unittest.py:
1355
1356 2011-11-17  Eric Seidel  <eric@webkit.org>
1357
1358         Remove support for running check-webkit-style w/o a webkit checkout
1359         https://bugs.webkit.org/show_bug.cgi?id=72678
1360
1361         Reviewed by Adam Barth.
1362
1363         After talking to Dave Levin we've decided to remove this
1364         code.  I know of no users of check-webkit-style w/o a webkit checkout
1365         and this needlessly adds complexity.
1366
1367         * Scripts/webkitpy/style/main.py:
1368
1369 2011-11-17  Eric Seidel  <eric@webkit.org>
1370
1371         Remove more direct uses of os.path
1372         https://bugs.webkit.org/show_bug.cgi?id=72677
1373
1374         Reviewed by Adam Barth.
1375
1376         Remove more uses of os.path, including refactoring
1377         CommitterValidator to use a Host object instead of
1378         manual hacks to emulate what SCM and FileSystem provide.
1379
1380         * Scripts/webkitpy/common/checkout/changelog.py:
1381         * Scripts/webkitpy/common/config/committervalidator.py:
1382         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1383         * Scripts/webkitpy/common/system/filesystem_mock.py:
1384          - Turns out none of our unittests actually looked at this path.
1385            now I've made it be a valid path.
1386         * Scripts/webkitpy/tool/bot/feeders.py:
1387         * Scripts/webkitpy/tool/commands/queues.py:
1388
1389 2011-11-17  Eric Seidel  <eric@webkit.org>
1390
1391         Teach TextFileReader about FileSystem
1392         https://bugs.webkit.org/show_bug.cgi?id=72673
1393
1394         Reviewed by Adam Barth.
1395
1396         Unfortunately TextFileReader doesn't use FileSystem
1397         everywhere yet, so we can't move the unittests to
1398         using MockFileSystem, but we're close.
1399
1400         * Scripts/webkitpy/style/filereader.py:
1401         * Scripts/webkitpy/style/filereader_unittest.py:
1402         * Scripts/webkitpy/style/main.py:
1403
1404 2011-11-17  Eric Seidel  <eric@webkit.org>
1405
1406         Give check-webkit-style a Host
1407         https://bugs.webkit.org/show_bug.cgi?id=72670
1408
1409         Reviewed by Adam Barth.
1410
1411         * Scripts/webkitpy/common/checkout/scm/detection.py:
1412         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1413          - We don't run these unittests, but this one was looking for the wrong exception.
1414         * Scripts/webkitpy/style/main.py:
1415         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1416          - This was create a new scm object even though it already had one?
1417
1418 2011-11-17  Eric Seidel  <eric@webkit.org>
1419
1420         Move check-webkit-style change_directory code to more modern mocks
1421         https://bugs.webkit.org/show_bug.cgi?id=72664
1422
1423         Reviewed by Adam Barth.
1424
1425         * Scripts/check-webkit-style:
1426         * Scripts/webkitpy/style/main.py:
1427         * Scripts/webkitpy/style/main_unittest.py:
1428
1429 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
1430
1431         [GTK] enable ref tests
1432         https://bugs.webkit.org/show_bug.cgi?id=72601
1433
1434         Re-enable ref tests. Run the driver under evenly numbered display if performing
1435         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
1436         being run in an already used Xvfb instance if pixel tests are disabled.
1437
1438         Reviewed by Tony Chang.
1439
1440         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
1441         after the process is killed
1442
1443 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1444
1445         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
1446         https://bugs.webkit.org/show_bug.cgi?id=72620
1447
1448         Reviewed by David Levin.
1449
1450         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
1451         adding the suffix the cpp file. One example of false positive
1452         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
1453
1454         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
1455         basename contains the cpp's basename.
1456         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1457
1458 2011-11-17  Eric Seidel  <eric@webkit.org>
1459
1460         Move check-webkit-style's guts into webkitpy/style/main.py
1461         https://bugs.webkit.org/show_bug.cgi?id=72657
1462
1463         Reviewed by Adam Barth.
1464
1465         * Scripts/check-webkit-style:
1466         * Scripts/webkitpy/style/main.py:
1467
1468 2011-11-17  Eric Seidel  <eric@webkit.org>
1469
1470         new-run-webkit-tests is locale dependent
1471         https://bugs.webkit.org/show_bug.cgi?id=68691
1472
1473         Reviewed by Adam Barth.
1474
1475         Make NRWT use a clean environment, just like ORWT did.
1476
1477         * Scripts/webkitpy/layout_tests/port/base.py:
1478         * Scripts/webkitpy/layout_tests/port/chromium.py:
1479         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1480         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1481         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1482         * Scripts/webkitpy/layout_tests/port/efl.py:
1483         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1484         * Scripts/webkitpy/layout_tests/port/mac.py:
1485         * Scripts/webkitpy/layout_tests/port/qt.py:
1486         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1487         * Scripts/webkitpy/layout_tests/port/webkit.py:
1488         * Scripts/webkitpy/layout_tests/port/win.py:
1489
1490 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
1491
1492         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
1493         https://bugs.webkit.org/show_bug.cgi?id=72615
1494
1495         Reviewed by James Robinson.
1496
1497         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1498
1499 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
1500
1501         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
1502         https://bugs.webkit.org/show_bug.cgi?id=72595
1503
1504         Reviewed by Noam Rosenthal.
1505
1506         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1507         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
1508         ensure the registration of the DRTNode JS bindings.
1509         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1510         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
1511         registration of QWebElement (now done implicitly through QWebPage ->
1512         QtWebElementRunTime::initialize code path)
1513
1514 2011-11-17  Adam Roben  <aroben@apple.com>
1515
1516         Fix a crash-inducing typo I introduced in r100648
1517
1518         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
1519         handling a crashing test
1520
1521         Reviewed by Adam Barth.
1522
1523         * Scripts/webkitpy/layout_tests/port/chromium.py:
1524         (ChromiumDriver.run_test): Get the driver name from the port.
1525
1526         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1527         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
1528         right crashed process name.
1529
1530 2011-11-17  Adam Roben  <aroben@apple.com>
1531
1532         Fix NRWT's parsing of the number of excluded leaks
1533
1534         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
1535         leaks were excluded
1536
1537         Reviewed by Adam Barth.
1538
1539         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1540         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
1541         regular expression match, not the entire matched string.
1542
1543         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1544         (LeakDetectorTest): Added some example output that shows how things look when leaks are
1545         excluded.
1546         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
1547         correctly.
1548
1549 2011-11-17  Adam Roben  <aroben@apple.com>
1550
1551         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
1552
1553         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
1554         when web process crashes, but WebProcess crash log should get saved instead
1555
1556         Reviewed by Eric Seidel.
1557
1558         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1559         (write_test_result): Simplified a little to share more code between the case where we
1560         crashed when running the test and where we crashed when checking the expected rendering for
1561         a reftest. Changed to pass the crashed process name down to write_crash_report.
1562         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
1563         along to CrashLogs.find_newest_log rather than always using the driver name.
1564
1565         * Scripts/webkitpy/layout_tests/port/chromium.py:
1566         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
1567         crashed.
1568
1569         * Scripts/webkitpy/layout_tests/port/test.py:
1570         (TestInstance.__init__): Initialize new web_process_crash attribute.
1571         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
1572         test this patch adds.
1573         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
1574         specifies that the driver crashed or the web process crashed.
1575
1576         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1577         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
1578         which we pretend the web process crashed rather than the driver process.
1579
1580         (MainTest.test_run_singly_actually_runs_tests):
1581         (MainTest.test_unexpected_failures):
1582         (EndToEndTest.test_end_to_end):
1583         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
1584
1585 2011-11-17  Tony Chang  <tony@chromium.org>
1586
1587         [chromium] stop spamming features warning on every build
1588         https://bugs.webkit.org/show_bug.cgi?id=72629
1589
1590         Reviewed by Ojan Vafai.
1591
1592         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
1593         $mediaStreamSupport is on by default for chromium, make the default
1594         for $blobSupport also on.
1595
1596         * Scripts/build-webkit:
1597
1598 2011-11-17  Adam Roben  <aroben@apple.com>
1599
1600         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
1601
1602         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
1603         that are supposed to be ignored
1604
1605         Reviewed by Adam Barth.
1606
1607         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1608         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
1609         required when passing arguments via the shell (which we aren't doing here). It is not
1610         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
1611
1612         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1613         (LeakDetectorTest.test_leaks_args): Updated expectations.
1614
1615 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1616
1617         Unreviewed, run-bindings-tests fix after r91028.
1618
1619         * Scripts/run-bindings-tests: Use scm.detection module.
1620
1621 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
1622
1623         Silence a warning about control reaching the end of a non-void function
1624         https://bugs.webkit.org/show_bug.cgi?id=72616
1625
1626         Reviewed by Tony Gentilcore.
1627
1628         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1629         (AccessibilityUIElement::verticalScrollbar):
1630
1631 2011-11-17  Adam Roben  <aroben@apple.com>
1632
1633         Ignore some leaks in frameworks we link against on Lion
1634
1635         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
1636         aren't WebKit's fault
1637
1638         Reviewed by Antti Koivisto.
1639
1640         * Scripts/old-run-webkit-tests:
1641         (countAndPrintLeaks):
1642         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1643         (LeakDetector._callstacks_to_exclude_from_leaks):
1644         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
1645
1646         * Scripts/webkitpy/layout_tests/port/mac.py:
1647         (MacPort.is_lion): Added.
1648
1649         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1650         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
1651         methods.
1652
1653 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1654
1655         [GTK] Disable ref tests
1656         https://bugs.webkit.org/show_bug.cgi?id=72599
1657
1658         Reviewed by Xan Lopez.
1659
1660         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
1661         tests to avoid massive flakiness.
1662
1663 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1664
1665         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
1666
1667         A new extension object has been added to QQuickWebView (the same approach should be used
1668         for other API classes that need experimental APIs). The QML extension mechanism is then
1669         built on top of the experimental object.
1670
1671         https://bugs.webkit.org/show_bug.cgi?id=72522
1672
1673         Reviewed by Simon Hausmann.
1674
1675         * MiniBrowser/qt/BrowserWindow.cpp:
1676         (BrowserWindow::BrowserWindow):
1677         (BrowserWindow::webView):
1678         * MiniBrowser/qt/BrowserWindow.h:
1679         * MiniBrowser/qt/UrlLoader.cpp:
1680         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1681         * qmake/mkspecs/features/default_post.prf:
1682         * qmake/mkspecs/features/default_pre.prf:
1683         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
1684         * qmake/mkspecs/features/qtwebkit.prf:
1685
1686 2011-11-17  Adam Barth  <abarth@webkit.org>
1687
1688         Move test_results_uploader.py out of layout_package
1689         https://bugs.webkit.org/show_bug.cgi?id=72590
1690
1691         Reviewed by Eric Seidel.
1692
1693         Most of the lines of code in this file are wrong, but I've restrained
1694         myself and only changed a few of them to generalized this class to the
1695         common package.
1696
1697         This is part of a series of patches to remove layout_package.
1698
1699         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
1700         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1701         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
1702
1703 2011-11-17  Adam Barth  <abarth@webkit.org>
1704
1705         Unreviewed. Fix style nits in printing.py.
1706
1707         * Scripts/webkitpy/layout_tests/views/printing.py:
1708
1709 2011-11-17  Adam Barth  <abarth@webkit.org>
1710
1711         Minor style nits in run_webkit_tests.py
1712         https://bugs.webkit.org/show_bug.cgi?id=72583
1713
1714         Reviewed by Eric Seidel.
1715
1716         This patch just fixes some minor style issues as I work my way back
1717         into this code.
1718
1719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1720
1721 2011-11-17  Adam Barth  <abarth@webkit.org>
1722
1723         Move test_result_writer out of layout_package
1724         https://bugs.webkit.org/show_bug.cgi?id=72586
1725
1726         Rubber-stamped by Eric Seidel.
1727
1728         This is part of a series of patches to remove layout_package.
1729
1730         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1731         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1732         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1733         * Scripts/webkitpy/tool/commands/rebaseline.py:
1734
1735 2011-11-17  Adam Barth  <abarth@webkit.org>
1736
1737         svn-apply shouldn't magically move files into Source anymore
1738         https://bugs.webkit.org/show_bug.cgi?id=72579
1739
1740         Reviewed by Eric Seidel.
1741
1742         The Source directory has existed for long enough that we don't need
1743         svn-apply to magically re-write old-style patches anymore.
1744
1745         * Scripts/VCSUtils.pm:
1746         (parseGitDiffHeader):
1747         (parseSvnDiffHeader):
1748
1749 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1750
1751         Add a list of contribution areas
1752         https://bugs.webkit.org/show_bug.cgi?id=72566
1753
1754         Reviewed by Eric Seidel.
1755
1756         Added ContributionAreas class.
1757
1758         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1759         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1760
1761 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1762
1763         Refactor ChangeLogTest.test_parse_reviewer_text
1764         https://bugs.webkit.org/show_bug.cgi?id=72572
1765
1766         Reviewed by Eric Seidel.
1767
1768         Refactored the test code by introduing two helper functions.
1769
1770         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1771
1772 2011-11-16  Eric Seidel  <eric@webkit.org>
1773
1774         Add SCMDetector object to make scm detection mockable
1775         https://bugs.webkit.org/show_bug.cgi?id=72247
1776
1777         Reviewed by Adam Barth.
1778
1779         I think SCM detection may eventually be rolled into Checkout,
1780         but this patch at least makes it possible to mock code-paths
1781         which rely on scm detection.
1782         In the process of replacing callers of these free-functions
1783         I found that one of the functions was no longer used,
1784         and that one of the callers could instead just use the SCM
1785         object it already had access to through port.host.scm().
1786         I also discovered that I was not calling Host._initialize_scm()
1787         and thus host.scm() was always returning None!
1788
1789         * Scripts/check-webkit-style:
1790         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1791         * Scripts/webkitpy/common/checkout/deps.py:
1792         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1793         * Scripts/webkitpy/common/checkout/scm/detection.py:
1794         * Scripts/webkitpy/common/checkout/scm/git.py:
1795         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1796         * Scripts/webkitpy/common/checkout/scm/svn.py:
1797         * Scripts/webkitpy/common/host.py:
1798         * Scripts/webkitpy/common/host_mock.py:
1799         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1800         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1801         * Scripts/webkitpy/layout_tests/port/base.py:
1802         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1803         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1804         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1805         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1806
1807 2011-11-16  Mark Rowe  <mrowe@apple.com>
1808
1809         Fix the build.
1810
1811         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1812         Apply the workaround that we use in other projects to WebKitTestRunner.
1813
1814         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1815         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1816         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1817
1818 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1819
1820         [Qt] Fix build after WTR AX support
1821         https://bugs.webkit.org/show_bug.cgi?id=72560
1822
1823         Reviewed by Geoffrey Garen.
1824
1825         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1826         * WebKitTestRunner/InjectedBundle/Target.pri:
1827
1828 2011-11-16  Tony Chang  <tony@chromium.org>
1829
1830         repurpose the flexbox bot for grid layout
1831         https://bugs.webkit.org/show_bug.cgi?id=72557
1832
1833         Reviewed by Ryosuke Niwa.
1834
1835         Since new flexbox is enabled everywhere, we don't need this bot
1836         anymore.  However, work on grid layout has begun, so we can use this
1837         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1838
1839         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1840         the bot on the waterfall, I will change the slave config to enable
1841         the compile flag and tests.
1842
1843 2011-11-11  Adrienne Walker  <enne@google.com>
1844
1845         [chromium] Expose mock scrollbars to window.internals
1846         https://bugs.webkit.org/show_bug.cgi?id=72195
1847
1848         Reviewed by James Robinson.
1849
1850         Because mock scrollbars are a global setting, reset between runs.
1851
1852         * DumpRenderTree/chromium/WebPreferences.cpp:
1853         (WebPreferences::applyTo):
1854
1855 2011-11-16  James Robinson  <jamesr@chromium.org>
1856
1857         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1858         https://bugs.webkit.org/show_bug.cgi?id=72562
1859
1860         Reviewed by Dirk Pranke.
1861
1862         * DumpRenderTree/chromium/TestShell.cpp:
1863         (TestShell::runFileTest):
1864
1865 2011-11-16  Tony Chang  <tony@chromium.org>
1866
1867         [NRWT] speculative fix for multiple subprocess test on cygwin
1868         https://bugs.webkit.org/show_bug.cgi?id=72518
1869
1870         Reviewed by Adam Barth.
1871
1872         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1873             tries to emulate posix fd behavior.
1874         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1875
1876 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1877
1878         Revert r100509; change was committed twice (first time as r100491).
1879         Unreviewed, build fix.
1880
1881         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1882
1883 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1884
1885         Run a dummy test in the gpu configurations if there's nothing to do.
1886         https://bugs.webkit.org/show_bug.cgi?id=72498
1887
1888         Reviewed by James Robinson.
1889
1890         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1891
1892 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1893
1894         contributors_by_fuzzy_match is super slow
1895         https://bugs.webkit.org/show_bug.cgi?id=72540
1896
1897         Reviewed by Eric Seidel.
1898
1899         Make contributors_by_name do case insensitive search using a dictionary.
1900
1901         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1902         because that's the most common case.
1903
1904         * Scripts/webkitpy/common/config/committers.py:
1905         * Scripts/webkitpy/common/config/committers_unittest.py:
1906
1907 2011-11-16  David Levin  <levin@chromium.org>
1908
1909         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1910         https://bugs.webkit.org/show_bug.cgi?id=72515
1911
1912         Reviewed by Adam Barth.
1913
1914         * Scripts/webkitpy/style/checkers/cpp.py:
1915         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1916
1917 2011-11-16  Tony Chang  <tony@chromium.org>
1918
1919         [NRWT] refactor drivers to require pixel_tests param
1920         https://bugs.webkit.org/show_bug.cgi?id=72517
1921
1922         Reviewed by Ojan Vafai.
1923
1924         No tests, just a refactoring.
1925
1926         * Scripts/webkitpy/layout_tests/port/chromium.py:
1927         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1928         * Scripts/webkitpy/layout_tests/port/webkit.py:
1929         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1930
1931 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1932
1933         Run a dummy test in the gpu configurations if there's nothing to do.
1934         https://bugs.webkit.org/show_bug.cgi?id=72498
1935
1936         Reviewed by James Robinson.
1937
1938         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1939
1940 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1941
1942         WebKitTestRunner needs to support accessibility-related DRT APIs
1943         https://bugs.webkit.org/show_bug.cgi?id=42131
1944
1945         Reviewed by Beth Dakin.
1946
1947         Port the AX code in DRT to WKTestRunner by using IDL.
1948
1949         * DumpRenderTree/AccessibilityUIElement.cpp:
1950         (horizontalScrollbarCallback):
1951         (verticalScrollbarCallback):
1952         (AccessibilityUIElement::horizontalScrollbar):
1953         (AccessibilityUIElement::verticalScrollbar):
1954         (AccessibilityUIElement::getJSClass):
1955         * DumpRenderTree/AccessibilityUIElement.h:
1956         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1957         (AccessibilityUIElement::horizontalScrollbar):
1958         (AccessibilityUIElement::verticalScrollbar):
1959         * WebKitTestRunner/DerivedSources.make:
1960         * WebKitTestRunner/GNUmakefile.am:
1961         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1962         (WTR::AccessibilityController::create):
1963         (WTR::AccessibilityController::AccessibilityController):
1964         (WTR::AccessibilityController::~AccessibilityController):
1965         (WTR::AccessibilityController::makeWindowObject):
1966         (WTR::AccessibilityController::wrapperClass):
1967         (WTR::AccessibilityController::rootElement):
1968         (WTR::AccessibilityController::focusedElement):
1969         (WTR::AccessibilityController::elementAtPoint):
1970         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
1971         (WTR::AccessibilityController::logFocusEvents):
1972         (WTR::AccessibilityController::logValueChangeEvents):
1973         (WTR::AccessibilityController::logScrollingStartEvents):
1974         (WTR::AccessibilityController::logAccessibilityEvents):
1975         (WTR::AccessibilityController::addNotificationListener):
1976         (WTR::AccessibilityController::notificationReceived):
1977         (WTR::AccessibilityController::resetToConsistentState):
1978         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
1979         (WTR::AccessibilityTextMarker::create):
1980         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1981         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
1982         (WTR::AccessibilityTextMarker::platformTextMarker):
1983         (WTR::AccessibilityTextMarker::wrapperClass):
1984         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
1985         (WTR::AccessibilityTextMarker::isEqual):
1986         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
1987         (WTR::AccessibilityTextMarkerRange::create):
1988         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1989         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1990         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
1991         (WTR::AccessibilityTextMarkerRange::wrapperClass):
1992         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
1993         (WTR::AccessibilityTextMarkerRange::isEqual):
1994         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
1995         (WTR::AccessibilityUIElement::create):
1996         (WTR::AccessibilityUIElement::wrapperClass):
1997         (WTR::AccessibilityUIElement::isValid):
1998         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1999         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2000         (WTR::AccessibilityUIElement::isEqual):
2001         (WTR::AccessibilityUIElement::elementAtPoint):
2002         (WTR::AccessibilityUIElement::childAtIndex):
2003         (WTR::AccessibilityUIElement::indexOfChild):
2004         (WTR::AccessibilityUIElement::childrenCount):
2005         (WTR::AccessibilityUIElement::titleUIElement):
2006         (WTR::AccessibilityUIElement::parentElement):
2007         (WTR::AccessibilityUIElement::takeFocus):
2008         (WTR::AccessibilityUIElement::takeSelection):
2009         (WTR::AccessibilityUIElement::addSelection):
2010         (WTR::AccessibilityUIElement::removeSelection):
2011         (WTR::AccessibilityUIElement::allAttributes):
2012         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2013         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2014         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2015         (WTR::AccessibilityUIElement::attributesOfChildren):
2016         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2017         (WTR::AccessibilityUIElement::increment):
2018         (WTR::AccessibilityUIElement::decrement):
2019         (WTR::AccessibilityUIElement::showMenu):
2020         (WTR::AccessibilityUIElement::press):
2021         (WTR::AccessibilityUIElement::stringAttributeValue):
2022         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2023         (WTR::AccessibilityUIElement::numberAttributeValue):
2024         (WTR::AccessibilityUIElement::boolAttributeValue):
2025         (WTR::AccessibilityUIElement::isAttributeSupported):
2026         (WTR::AccessibilityUIElement::isAttributeSettable):
2027         (WTR::AccessibilityUIElement::isActionSupported):
2028         (WTR::AccessibilityUIElement::role):
2029         (WTR::AccessibilityUIElement::subrole):
2030         (WTR::AccessibilityUIElement::roleDescription):
2031         (WTR::AccessibilityUIElement::title):
2032         (WTR::AccessibilityUIElement::description):
2033         (WTR::AccessibilityUIElement::language):
2034         (WTR::AccessibilityUIElement::stringValue):
2035         (WTR::AccessibilityUIElement::accessibilityValue):
2036         (WTR::AccessibilityUIElement::helpText):
2037         (WTR::AccessibilityUIElement::orientation):
2038         (WTR::AccessibilityUIElement::x):
2039         (WTR::AccessibilityUIElement::y):
2040         (WTR::AccessibilityUIElement::width):
2041         (WTR::AccessibilityUIElement::height):
2042         (WTR::AccessibilityUIElement::intValue):
2043         (WTR::AccessibilityUIElement::minValue):
2044         (WTR::AccessibilityUIElement::maxValue):
2045         (WTR::AccessibilityUIElement::valueDescription):
2046         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2047         (WTR::AccessibilityUIElement::selectedTextRange):
2048         (WTR::AccessibilityUIElement::isEnabled):
2049         (WTR::AccessibilityUIElement::isRequired):
2050         (WTR::AccessibilityUIElement::isFocused):
2051         (WTR::AccessibilityUIElement::isFocusable):
2052         (WTR::AccessibilityUIElement::isSelected):
2053         (WTR::AccessibilityUIElement::isSelectable):
2054         (WTR::AccessibilityUIElement::isMultiSelectable):
2055         (WTR::AccessibilityUIElement::setSelectedChild):
2056         (WTR::AccessibilityUIElement::selectedChildrenCount):
2057         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2058         (WTR::AccessibilityUIElement::isExpanded):
2059         (WTR::AccessibilityUIElement::isChecked):
2060         (WTR::AccessibilityUIElement::isVisible):
2061         (WTR::AccessibilityUIElement::isOffScreen):
2062         (WTR::AccessibilityUIElement::isCollapsed):
2063         (WTR::AccessibilityUIElement::isIgnored):
2064         (WTR::AccessibilityUIElement::hasPopup):
2065         (WTR::AccessibilityUIElement::hierarchicalLevel):
2066         (WTR::AccessibilityUIElement::clickPointX):
2067         (WTR::AccessibilityUIElement::clickPointY):
2068         (WTR::AccessibilityUIElement::documentEncoding):
2069         (WTR::AccessibilityUIElement::documentURI):
2070         (WTR::AccessibilityUIElement::url):
2071         (WTR::AccessibilityUIElement::speak):
2072         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2073         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2074         (WTR::AccessibilityUIElement::attributesOfColumns):
2075         (WTR::AccessibilityUIElement::attributesOfRows):
2076         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2077         (WTR::AccessibilityUIElement::attributesOfHeader):
2078         (WTR::AccessibilityUIElement::indexInTable):
2079         (WTR::AccessibilityUIElement::rowIndexRange):
2080         (WTR::AccessibilityUIElement::columnIndexRange):
2081         (WTR::AccessibilityUIElement::rowCount):
2082         (WTR::AccessibilityUIElement::columnCount):
2083         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2084         (WTR::AccessibilityUIElement::disclosedByRow):
2085         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2086         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2087         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2088         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2089         (WTR::AccessibilityUIElement::ariaDropEffects):
2090         (WTR::AccessibilityUIElement::lineForIndex):
2091         (WTR::AccessibilityUIElement::rangeForLine):
2092         (WTR::AccessibilityUIElement::boundsForRange):
2093         (WTR::AccessibilityUIElement::setSelectedTextRange):
2094         (WTR::AccessibilityUIElement::stringForRange):
2095         (WTR::AccessibilityUIElement::attributedStringForRange):
2096         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2097         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2098         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2099         (WTR::AccessibilityUIElement::horizontalScrollbar):
2100         (WTR::AccessibilityUIElement::verticalScrollbar):
2101         (WTR::AccessibilityUIElement::addNotificationListener):
2102         (WTR::AccessibilityUIElement::removeNotificationListener):
2103         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2104         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2105         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2106         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2107         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2108         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2109         (WTR::AccessibilityUIElement::textMarkerForPoint):
2110         (WTR::AccessibilityUIElement::previousTextMarker):
2111         (WTR::AccessibilityUIElement::nextTextMarker):
2112         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2113         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
2114         (WTR::AccessibilityUIElement::platformUIElement):
2115         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
2116         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
2117         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
2118         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
2119         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2120         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2121         (WTR::InjectedBundle::beginTesting):
2122         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2123         (WTR::InjectedBundle::accessibilityController):
2124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2125         (WTR::InjectedBundlePage::didClearWindowForFrame):
2126         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2127         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
2128         (WTR::LayoutTestController::platformName):
2129         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
2130         (WTR::AccessibilityTextMarker::isEqual):
2131         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
2132         (WTR::AccessibilityTextMarkerRange::isEqual):
2133         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
2134         (+[NSString stringWithJSStringRef:]):
2135         (-[NSString createJSStringRef]):
2136         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
2137         (-[AccessibilityNotificationHandler dealloc]):
2138         (-[AccessibilityNotificationHandler _notificationReceived:]):
2139         (-[AccessibilityNotificationHandler setCallback:]):
2140         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2141         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2142         (WTR::AccessibilityUIElement::isEqual):
2143         (WTR::descriptionOfValue):
2144         (WTR::attributesOfElement):
2145         (WTR::concatenateAttributeAndValue):
2146         (WTR::convertNSArrayToVector):
2147         (WTR::descriptionOfElements):
2148         (WTR::AccessibilityUIElement::getLinkedUIElements):
2149         (WTR::AccessibilityUIElement::getDocumentLinks):
2150         (WTR::AccessibilityUIElement::getChildren):
2151         (WTR::AccessibilityUIElement::getChildrenWithRange):
2152         (WTR::AccessibilityUIElement::childrenCount):
2153         (WTR::AccessibilityUIElement::elementAtPoint):
2154         (WTR::AccessibilityUIElement::indexOfChild):
2155         (WTR::AccessibilityUIElement::childAtIndex):
2156         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2157         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2158         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2159         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2160         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2161         (WTR::AccessibilityUIElement::selectedChildrenCount):
2162         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2163         (WTR::AccessibilityUIElement::titleUIElement):
2164         (WTR::AccessibilityUIElement::parentElement):
2165         (WTR::AccessibilityUIElement::disclosedByRow):
2166         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2167         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2168         (WTR::AccessibilityUIElement::attributesOfChildren):
2169         (WTR::AccessibilityUIElement::allAttributes):
2170         (WTR::AccessibilityUIElement::stringAttributeValue):
2171         (WTR::AccessibilityUIElement::numberAttributeValue):
2172         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2173         (WTR::AccessibilityUIElement::boolAttributeValue):
2174         (WTR::AccessibilityUIElement::isAttributeSettable):
2175         (WTR::AccessibilityUIElement::isAttributeSupported):
2176         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2177         (WTR::AccessibilityUIElement::role):
2178         (WTR::AccessibilityUIElement::subrole):
2179         (WTR::AccessibilityUIElement::roleDescription):
2180         (WTR::AccessibilityUIElement::title):
2181         (WTR::AccessibilityUIElement::description):
2182         (WTR::AccessibilityUIElement::orientation):
2183         (WTR::AccessibilityUIElement::stringValue):
2184         (WTR::AccessibilityUIElement::language):
2185         (WTR::AccessibilityUIElement::helpText):
2186         (WTR::AccessibilityUIElement::x):
2187         (WTR::AccessibilityUIElement::y):
2188         (WTR::AccessibilityUIElement::width):
2189         (WTR::AccessibilityUIElement::height):
2190         (WTR::AccessibilityUIElement::clickPointX):
2191         (WTR::AccessibilityUIElement::clickPointY):
2192         (WTR::AccessibilityUIElement::intValue):
2193         (WTR::AccessibilityUIElement::minValue):
2194         (WTR::AccessibilityUIElement::maxValue):
2195         (WTR::AccessibilityUIElement::valueDescription):
2196         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2197         (WTR::AccessibilityUIElement::isActionSupported):
2198         (WTR::AccessibilityUIElement::isEnabled):
2199         (WTR::AccessibilityUIElement::isRequired):
2200         (WTR::AccessibilityUIElement::isFocused):
2201         (WTR::AccessibilityUIElement::isSelected):
2202         (WTR::AccessibilityUIElement::isExpanded):
2203         (WTR::AccessibilityUIElement::isChecked):
2204         (WTR::AccessibilityUIElement::hierarchicalLevel):
2205         (WTR::AccessibilityUIElement::speak):
2206         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2207         (WTR::AccessibilityUIElement::ariaDropEffects):
2208         (WTR::AccessibilityUIElement::lineForIndex):
2209         (WTR::AccessibilityUIElement::rangeForLine):
2210         (WTR::AccessibilityUIElement::boundsForRange):
2211         (WTR::AccessibilityUIElement::stringForRange):
2212         (WTR::AccessibilityUIElement::attributedStringForRange):
2213         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2214         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2215         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2216         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2217         (WTR::AccessibilityUIElement::attributesOfColumns):
2218         (WTR::AccessibilityUIElement::attributesOfRows):
2219         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2220         (WTR::AccessibilityUIElement::attributesOfHeader):
2221         (WTR::AccessibilityUIElement::rowCount):
2222         (WTR::AccessibilityUIElement::columnCount):
2223         (WTR::AccessibilityUIElement::indexInTable):
2224         (WTR::AccessibilityUIElement::rowIndexRange):
2225         (WTR::AccessibilityUIElement::columnIndexRange):
2226         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2227         (WTR::AccessibilityUIElement::horizontalScrollbar):
2228         (WTR::AccessibilityUIElement::verticalScrollbar):
2229         (WTR::AccessibilityUIElement::selectedTextRange):
2230         (WTR::AccessibilityUIElement::setSelectedTextRange):
2231         (WTR::AccessibilityUIElement::increment):
2232         (WTR::AccessibilityUIElement::decrement):
2233         (WTR::AccessibilityUIElement::showMenu):
2234         (WTR::AccessibilityUIElement::press):
2235         (WTR::AccessibilityUIElement::setSelectedChild):
2236         (WTR::AccessibilityUIElement::accessibilityValue):
2237         (WTR::AccessibilityUIElement::documentEncoding):
2238         (WTR::AccessibilityUIElement::documentURI):
2239         (WTR::AccessibilityUIElement::url):
2240         (WTR::AccessibilityUIElement::addNotificationListener):
2241         (WTR::AccessibilityUIElement::removeNotificationListener):
2242         (WTR::AccessibilityUIElement::isFocusable):
2243         (WTR::AccessibilityUIElement::isSelectable):
2244         (WTR::AccessibilityUIElement::isMultiSelectable):
2245         (WTR::AccessibilityUIElement::isVisible):
2246         (WTR::AccessibilityUIElement::isOffScreen):
2247         (WTR::AccessibilityUIElement::isCollapsed):
2248         (WTR::AccessibilityUIElement::isIgnored):
2249         (WTR::AccessibilityUIElement::hasPopup):
2250         (WTR::AccessibilityUIElement::takeFocus):
2251         (WTR::AccessibilityUIElement::takeSelection):
2252         (WTR::AccessibilityUIElement::addSelection):
2253         (WTR::AccessibilityUIElement::removeSelection):
2254         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2255         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2256         (WTR::AccessibilityUIElement::previousTextMarker):
2257         (WTR::AccessibilityUIElement::nextTextMarker):
2258         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2259         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2260         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2261         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2262         (WTR::AccessibilityUIElement::textMarkerForPoint):
2263         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2264         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2265         (WTR::LayoutTestController::platformName):
2266         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2267         (WTR::LayoutTestController::platformName):
2268         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2269         (WTR::LayoutTestController::platformName):
2270         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2271         * WebKitTestRunner/win/InjectedBundle.vcproj:
2272
2273 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2274
2275         [Qt] Fix use of config.tests
2276
2277         We were checking @buildArgs to determine if the optional argument was
2278         passed or not, but this is not the right way to do that in Perl. The
2279         right way is to not use a prototype for the function, and to pass
2280         the list as a reference (to avoid list expansion). That way we can
2281         check the number of arguments, and choose the right code path based
2282         on that.
2283
2284         We were also missing a default-value of 0 for any feature that's not
2285         set in features.prf.
2286
2287         Reviewed by Kenneth Rohde Christiansen.
2288
2289         * Scripts/build-webkit:
2290         * Scripts/webkitdirs.pm:
2291         (qtFeatureDefaults):
2292         (buildQMakeProject):
2293
2294 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2295
2296         [Qt] Prospective fix for broken plugin tests
2297
2298         Don't hide symbols for the NPAPI test plugin
2299
2300         Rubber-stamped by Andreas Kling.
2301
2302         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2303
2304 2011-11-16  Adam Roben  <aroben@apple.com>
2305
2306         Move filenames/line numbers off to the right edge in Leaks Viewer
2307
2308         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
2309         because filenames/line numbers are right next to function names
2310
2311         Reviewed by Andreas Kling.
2312
2313         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
2314         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
2315         function name. Use the filename as the profile node's URL (we don't have enough info to
2316         compute a real URL currently) and the line number as the profile node's line number so the
2317         Inspector code will put them on the right side of the callstack graph.
2318
2319         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2320         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
2321         passed here, just filenames.
2322
2323         (WebInspector.linkifyURLAsNode):
2324         (WebInspector.linkifyResourceAsNode):
2325         Copied and slightly modified from inspector.js.
2326
2327 2011-11-16  Adam Roben  <aroben@apple.com>
2328
2329         Make Leaks Viewer load builds from the new Lion Leaks bot
2330
2331         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
2332
2333         Reviewed by Andreas Kling.
2334
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2336         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
2337         SnowLeopard one.
2338
2339 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
2340
2341         [EFL] Clean up the offline apps-related functions in ewk_settings.
2342         https://bugs.webkit.org/show_bug.cgi?id=72132
2343
2344         Reviewed by Kenneth Rohde Christiansen.
2345
2346         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
2347         prefixes for code that is related only to the HTML5 app cache
2348         features.
2349
2350         Use `ewk_settings_application_cache' and
2351         `ewk_view_setting_application_cache' instead.
2352
2353         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2354         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2355
2356 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2357
2358         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2359
2360         Reviewed by Tor Arne Vestbø.
2361
2362         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2363         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
2364         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
2365         removes the .so.0.0.0 and just produces .so.
2366
2367 2011-11-16  Peter Beverloo  <peter@chromium.org>
2368
2369         Explicitly include unistd.h in TestNetscapePlugIn
2370         https://bugs.webkit.org/show_bug.cgi?id=72385
2371
2372         This is needed for the sleep() call in the indicateTestFailure method,
2373         which seems to be implicitly available for other platforms. This is not
2374         the case on Android.
2375
2376         Reviewed by Steve Block.
2377
2378         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2379
2380 2011-11-16  Peter Beverloo  <peter@chromium.org>
2381
2382         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
2383         https://bugs.webkit.org/show_bug.cgi?id=72384
2384
2385         Update to Android NDK r7, which was released last Friday. This adds
2386         support for RTTI and the -mimplicit-it gcc flag, which are required to
2387         respectively build ICU and Skia.
2388
2389         Reviewed by Steve Block.
2390
2391         * Scripts/update-webkit-chromium:
2392         * Scripts/webkitdirs.pm:
2393         (buildChromiumMakefile):
2394
2395 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2396
2397         Unreviewed, rolling out r100266.
2398         http://trac.webkit.org/changeset/100266
2399
2400         Broke WTR.
2401
2402         * qmake/mkspecs/features/default_post.prf:
2403
2404 2011-11-16  Eric Seidel  <eric@webkit.org>
2405
2406         check-webkit-style broken by r99773: "Could not determine the port"
2407         https://bugs.webkit.org/show_bug.cgi?id=72275
2408
2409         Reviewed by Adam Barth.
2410
2411         I will continue engaging hacks, until windows improves.
2412
2413         * Scripts/webkitpy/common/host.py:
2414          - Host uses self.executive instead of self._executive like Port does.
2415          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
2416
2417 2011-11-16  Eric Seidel  <eric@webkit.org>
2418
2419         check-webkit-style broken by r99773: "Could not determine the port"
2420         https://bugs.webkit.org/show_bug.cgi?id=72275
2421
2422         Reviewed by Adam Barth.
2423
2424         Engage windows hacks harder.
2425
2426         This is a speculative fix for ChromiumWin.  We're now
2427         creating an SCM object much earlier, so we need to
2428         engage our "awesome" windows hacks earlier.
2429
2430         * Scripts/webkitpy/common/host.py:
2431         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2432
2433 2011-11-15  Darin Adler  <darin@apple.com>
2434
2435         DRT's uiElementAttributeValueCallback function is leaky
2436         https://bugs.webkit.org/show_bug.cgi?id=72453
2437
2438         Reviewed by Dan Bernstein.
2439
2440         * DumpRenderTree/AccessibilityUIElement.cpp:
2441         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
2442
2443 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2444
2445         Implement edit-distance based reviewer recognition algorithm
2446         https://bugs.webkit.org/show_bug.cgi?id=72351
2447
2448         Reviewed by Eric Seidel.
2449
2450         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
2451         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
2452         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
2453         "build fix" to a reviewer's name (e.g. with with edit distance 9).
2454
2455         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
2456         the edit distance is implemented in edit_distance.py.
2457
2458         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
2459         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
2460
2461         * Scripts/webkitpy/common/checkout/changelog.py:
2462         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2463         * Scripts/webkitpy/common/config/committers.py:
2464         * Scripts/webkitpy/common/config/committers_unittest.py:
2465         * Scripts/webkitpy/common/editdistance.py: Added.
2466         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
2467         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2468         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
2469
2470 2011-11-15  Tony Chang  <tony@chromium.org>
2471
2472         Skip a failing webkitpy test on cygwin.
2473
2474         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2475
2476 2011-11-15  Sam Weinig  <sam@webkit.org>
2477
2478         TestWebKitAPI should not put its resources in the root products directory
2479         https://bugs.webkit.org/show_bug.cgi?id=72446
2480
2481         Reviewed by Anders Carlsson.
2482
2483         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2484         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
2485         directory.
2486
2487         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2488         (TEST_F):
2489         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2490         (TestWebKitAPI::TEST):
2491         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2492         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2493         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2494         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
2495         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2496         (TestWebKitAPI::Util::createURLForResource):
2497         Update calls to retrieve files from the bundle to look in the newly
2498         created subdirectory.
2499
2500 2011-11-15  Tony Chang  <tony@chromium.org>
2501
2502         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
2503
2504         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2505
2506 2011-11-15  Tony Chang  <tony@chromium.org>
2507
2508         Unreviewed, fix test-webkitpy tests.  Move the check for image results
2509         earlier.
2510
2511         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2512         * Scripts/webkitpy/layout_tests/port/webkit.py:
2513
2514 2011-11-15  James Robinson  <jamesr@chromium.org>
2515
2516         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
2517         https://bugs.webkit.org/show_bug.cgi?id=72444
2518
2519         Reviewed by Adam Barth.
2520
2521         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2522
2523 2011-11-15  Tony Chang  <tony@chromium.org>
2524
2525         Unreviewed, better fix for ref tests failures on SL Intel bot.
2526         Revert the previous change and return None if pixel results from
2527         either the test page or the expected page is missing.
2528
2529         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2530         * Scripts/webkitpy/layout_tests/port/webkit.py:
2531
2532 2011-11-15  James Robinson  <jamesr@chromium.org>
2533
2534         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
2535         https://bugs.webkit.org/show_bug.cgi?id=72402
2536
2537         Reviewed by Dirk Pranke.
2538
2539         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
2540         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
2541         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
2542         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
2543         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
2544         compositing enabled.
2545
2546         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
2547         patch should not impact any tests.
2548
2549         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2550         (main):
2551         * DumpRenderTree/chromium/TestShell.cpp:
2552         (TestShell::TestShell):
2553         (TestShell::resetWebSettings):
2554         * DumpRenderTree/chromium/TestShell.h:
2555         (TestShell::setAcceleratedCompositingForVideoEnabled):
2556         * DumpRenderTree/chromium/WebPreferences.cpp:
2557         (WebPreferences::reset):
2558         (WebPreferences::applyTo):
2559         * DumpRenderTree/chromium/WebPreferences.h:
2560         * Scripts/webkitpy/layout_tests/port/chromium.py:
2561         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2562         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2563
2564 2011-11-15  Tony Chang  <tony@chromium.org>
2565
2566         Unreviewed, try to fix ref tests failures on SL Intel bot.
2567         It looks like ImageDiff isn't returning an image diff.
2568
2569         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2570
2571 2011-11-15  Tony Chang  <tony@chromium.org>
2572
2573         Unreviewed fix of ref-tests on GTK+.
2574         If a driver is never started, _xvfb_process is never set.
2575
2576         * Scripts/webkitpy/layout_tests/port/gtk.py:
2577
2578 2011-11-14  Tony Chang  <tony@chromium.org>
2579
2580         [NRWT] Reftests should run even when pixel tests are disabled.
2581         https://bugs.webkit.org/show_bug.cgi?id=60605
2582
2583         Reviewed by Dirk Pranke.
2584
2585         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
2586             Also add an assert to make sure we get image hashes back when running ref tests.
2587         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
2588         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2589         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
2590         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
2591             of starting a pixel driver if needed.  It handles the logic of sending the test
2592             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
2593         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2594         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
2595         * Scripts/webkitpy/layout_tests/port/webkit.py:
2596         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
2597         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2598
2599 2011-11-15  David Kilzer  <ddkilzer@apple.com>
2600
2601         Don't use File::Slurp for run-leaks unit tests
2602         <http://webkit.org/b/72356>
2603
2604         Reviewed by Daniel Bates.
2605
2606         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
2607         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2608         Extracted common package logic into RunLeaks.pm.  Fixed call to
2609         RunLeaks::parseLeaksOutput().
2610         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
2611         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
2612
2613 2011-11-15  Peter Kasting  <pkasting@google.com>
2614
2615         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
2616         https://bugs.webkit.org/show_bug.cgi?id=72349
2617
2618         Reviewed by Adam Roben.
2619
2620         * Scripts/VCSUtils.pm:
2621         (isSVNDirectory):
2622
2623 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2624
2625         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2626
2627         Reviewed by Tor Arne Vestbø.
2628
2629         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2630         magic here where we handle all TEMPLATE = lib .pro files.
2631
2632 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2633
2634         [Qt] Unreviewed prospective --minimal build fix.
2635
2636         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
2637         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
2638
2639 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2640
2641         [Qt] Unreviewed --minimal build fix.
2642
2643         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
2644         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
2645         to make moc's preprocessor abort.
2646
2647 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2648
2649         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
2650         https://bugs.webkit.org/show_bug.cgi?id=72156
2651
2652         Reviewed by Daniel Bates.
2653
2654         Similar to --makearg and --qmakearg, --cmakearg lets one pass
2655         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
2656
2657         * Scripts/build-webkit:
2658         * Scripts/webkitdirs.pm:
2659         (generateBuildSystemFromCMakeProject):
2660
2661 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2662
2663         Improve ChangeLogEntry's reviewer parsing algorithm part 2
2664         https://bugs.webkit.org/show_bug.cgi?id=72340
2665
2666         Reviewed by Eric Seidel.
2667
2668         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
2669         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
2670
2671         * Scripts/webkitpy/common/checkout/changelog.py:
2672         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2673
2674 2011-11-14  Eric Seidel  <eric@webkit.org>
2675
2676         check-webkit-style broken by r99773: "Could not determine the port"
2677         https://bugs.webkit.org/show_bug.cgi?id=72275
2678
2679         Reviewed by Adam Barth.
2680
2681         The TestExpectationsChecker was using a generic try/except block
2682         which caught all exceptions, so we didn't notice that failing
2683         to pass a Host to PortFactory was causing an exception in port instantiation.
2684         I've factored out the "lookup the port" logic into a separate function
2685         which I've now unittested.  This should fix the bug and prevent
2686         others like it from occuring the the future.
2687
2688         * Scripts/webkitpy/style/checkers/test_expectations.py:
2689         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2690
2691 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2692
2693         Add --css-grid-layout to build-webkit and the build systems
2694         https://bugs.webkit.org/show_bug.cgi?id=72320
2695
2696         Reviewed by Ojan Vafai.
2697
2698         * Scripts/build-webkit:
2699         Added the option.
2700
2701 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2702
2703         Unreviewed, rolling out r100192.
2704         http://trac.webkit.org/changeset/100192
2705         https://bugs.webkit.org/show_bug.cgi?id=72328
2706
2707         Caused infinite tests to fail (Requested by abarth on
2708         #webkit).
2709
2710         * Scripts/webkitpy/layout_tests/port/base.py:
2711         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2712
2713 2011-11-14  Tony Chang  <tony@chromium.org>
2714
2715         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2716         https://bugs.webkit.org/show_bug.cgi?id=72196
2717
2718         Reviewed by Ojan Vafai.
2719
2720         * Scripts/build-webkit:
2721
2722 2011-11-14  John Yani  <vanuan@gmail.com>
2723
2724         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
2725         Override LOCALE to en_US.
2726
2727         Reviewed by Eric Seidel.
2728
2729         * Scripts/webkitpy/layout_tests/port/base.py:
2730
2731 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2732
2733         [Chromium] build-webkit silently drops the features flags
2734         https://bugs.webkit.org/show_bug.cgi?id=72293
2735
2736         Reviewed by Tony Chang.
2737
2738         Chromium still ignores @features but now we give a warning!
2739
2740         * Scripts/build-webkit: Check if one of the features is different
2741         from the default and print a warning in this case.
2742
2743 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2744
2745         run-leaks does not work on Lion?
2746         <http://webkit.org/b/71059>
2747         <rdar://problem/10428527>
2748
2749         Reviewed by Adam Roben.
2750
2751         The output of leaks(1) changed again in Lion to move the
2752         "leaks Report Version: 2.0" line from the first line of the
2753         output to just above the "Process " lines that run-leaks is
2754         interested in parsing.  This required using a more generic
2755         algorithm to find the start of the "Process " lines.
2756
2757         * Scripts/run-leaks:
2758         (parseLeaksOutput): Make the code to skip headers more generic.
2759         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2760         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2761         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2762
2763 2011-11-14  Lei Zhang  <thestig@chromium.org>
2764
2765         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2766         https://bugs.webkit.org/show_bug.cgi?id=72088
2767
2768         Reviewed by Tony Chang.
2769
2770         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2771
2772 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2773
2774         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2775         https://bugs.webkit.org/show_bug.cgi?id=72147
2776
2777         Reviewed by Adam Barth.
2778
2779         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2780
2781 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2782
2783         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2784
2785         Reviewed by Simon Hausmann.
2786
2787         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2788
2789 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2790
2791         [Qt] Disable plugins on X11 for WK2
2792
2793         Reviewed by Kenneth Rohde Christiansen.
2794
2795         Currently plugins are in-process and they crash in the likely case of
2796         a plugin installation that uses Qt 4, which beautifully clashes with the
2797         Qt 5 based QtWebProcess.
2798
2799         * qmake/mkspecs/features/features.prf:
2800
2801 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2802
2803         [Qt] Add support for config tests for Qt 5
2804
2805         This allows us to build and run configure-tests at build
2806         time to determine if a given platform feature is available.
2807
2808         Reviewed by Simon Hausmann.
2809
2810         * Scripts/build-webkit:
2811         * Scripts/webkitdirs.pm:
2812         (qtFeatureDefaults):
2813         * qmake/configure.pro: Added.
2814         * qmake/mkspecs/features/features.prf:
2815         * qmake/sync.profile: Added.
2816
2817 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2818
2819         [Qt] Remove the QStyle dependency in Qt's mobile theme
2820         https://bugs.webkit.org/show_bug.cgi?id=67773
2821
2822         This refactoring splits up RenderThemeQt with two
2823         subclasses, a QStyle-backed one, and a Mobile version
2824         that uses the old mobile theme for now.
2825
2826         QStyle availability is detected at compile time, and
2827         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2828         environment variable.
2829
2830         Reviewed by Simon Hausmann.
2831
2832         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2833         (WTR::activateFonts):
2834         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2835         based on availability of QtWidgets.
2836         * qmake/mkspecs/features/webcore.prf: cleanup.
2837
2838 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2839
2840         Unreviewed, rolling out r100116.
2841         http://trac.webkit.org/changeset/100116
2842
2843         r100104 was rolled out, so no longer needed
2844
2845         * Scripts/run-bindings-tests:
2846
2847 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2848
2849         Unreviewed, rolling out r100104.
2850         http://trac.webkit.org/changeset/100104
2851         https://bugs.webkit.org/show_bug.cgi?id=72247
2852
2853         broke windows builds
2854
2855         * Scripts/check-webkit-style:
2856         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2857         * Scripts/webkitpy/common/checkout/deps.py:
2858         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2859         * Scripts/webkitpy/common/checkout/scm/detection.py:
2860         * Scripts/webkitpy/common/checkout/scm/git.py:
2861         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2862         * Scripts/webkitpy/common/checkout/scm/svn.py:
2863         * Scripts/webkitpy/common/host.py:
2864         * Scripts/webkitpy/common/host_mock.py:
2865         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2866         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2867         * Scripts/webkitpy/layout_tests/port/base.py:
2868         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2869         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2870         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2871         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2872
2873 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2874
2875         Unreviewed, build fix after r100104. run-binding-tests broke.
2876
2877         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2878
2879 2011-11-13  Eric Seidel  <eric@webkit.org>
2880
2881         Add SCMDetector object to make scm detection mockable
2882         https://bugs.webkit.org/show_bug.cgi?id=72247
2883
2884         Reviewed by Adam Barth.
2885
2886         I think SCM detection may eventually be rolled into Checkout,
2887         but this patch at least makes it possible to mock code-paths
2888         which rely on scm detection.
2889         In the process of replacing callers of these free-functions
2890         I found that one of the functions was no longer used,
2891         and that one of the callers could instead just use the SCM
2892         object it already had access to through port.host.scm().
2893         I also discovered that I was not calling Host._initialize_scm()
2894         and thus host.scm() was always returning None!
2895
2896         * Scripts/check-webkit-style:
2897         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2898         * Scripts/webkitpy/common/checkout/deps.py:
2899         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2900         * Scripts/webkitpy/common/checkout/scm/detection.py:
2901         * Scripts/webkitpy/common/checkout/scm/git.py:
2902         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2903         * Scripts/webkitpy/common/checkout/scm/svn.py:
2904         * Scripts/webkitpy/common/host.py:
2905         * Scripts/webkitpy/common/host_mock.py:
2906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2907         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2908         * Scripts/webkitpy/layout_tests/port/base.py:
2909         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2910         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2911         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2912         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2913
2914 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2915
2916         command line control of webcore log channels in chromium DumpRenderTree
2917         https://bugs.webkit.org/show_bug.cgi?id=72126
2918         
2919         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2920         what chromium takes.
2921
2922         Reviewed by Kent Tamura.
2923
2924         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2925         (main):
2926
2927 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2928
2929         [Qt] Fix minor config typo in the build tool documentation
2930         https://bugs.webkit.org/show_bug.cgi?id=72194
2931
2932         Reviewed by Andreas Kling.
2933
2934         * qmake/README:
2935
2936 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2937
2938         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2939         https://bugs.webkit.org/show_bug.cgi?id=49257
2940
2941         Adds the remaining missing layout test functionality for printing.
2942
2943         Reviewed by Darin Fisher.
2944
2945         * DumpRenderTree/chromium/LayoutTestController.cpp:
2946         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2947         (parsePageNumber): Method to parse JS arguments for a page number
2948         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2949         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2950         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2951         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2952         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2953
2954 2011-11-11  Darin Adler  <darin@apple.com>
2955
2956         Remove all releaseRef implementations except for RetainPtr
2957         https://bugs.webkit.org/show_bug.cgi?id=71423
2958
2959         Reviewed by Julien Chaffraix.
2960
2961         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2962         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2963
2964 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2965
2966         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2967         https://bugs.webkit.org/show_bug.cgi?id=72090
2968
2969         Reviewed by Eric Seidel.
2970
2971         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
2972         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
2973
2974         yay! r100002.
2975
2976         * Scripts/webkitpy/common/checkout/changelog.py:
2977         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2978
2979 2011-11-11  Tony Chang  <tony@chromium.org>
2980
2981         Remove --force from gclient sync.  The bots seem to have made it past
2982         the update step.
2983
2984         * Scripts/update-webkit:
2985
2986 2011-11-11  Tony Chang  <tony@chromium.org>
2987
2988         Add --force to gclient sync. Once the cq bots cycle, we can remove
2989         this since it slows down the normal sync.
2990
2991         * Scripts/update-webkit:
2992
2993 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
2994
2995         When --force is used, also use --reset
2996         https://bugs.webkit.org/show_bug.cgi?id=72129
2997
2998         Reviewed by Dimitri Glazkov.
2999
3000         * Scripts/update-webkit-chromium:
3001
3002 2011-11-11  Tony Chang  <tony@chromium.org>
3003
3004         allow two chromium drivers to run at the same time in NRWT
3005         https://bugs.webkit.org/show_bug.cgi?id=72067
3006
3007         Reviewed by Dirk Pranke.
3008
3009         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
3010             posix prevents the subprocesses from sharing the same fd for stdin.
3011             Sharing the same fd prevents us from closing the files unless all references
3012             to the fd are closed.
3013         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
3014             to adding a test for this, speed up a test (from 3sec to 0) by fixing
3015             the timeout override. It looks like it regressed in r95875.
3016
3017 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3018
3019         Unreviewed, rolling out r99964.
3020         http://trac.webkit.org/changeset/99964
3021         https://bugs.webkit.org/show_bug.cgi?id=72124
3022
3023         Broke too many Qt tests (Requested by tronical_ on #webkit).
3024
3025         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3026         (WTR::activateFonts):
3027         * qmake/mkspecs/features/features.prf:
3028         * qmake/mkspecs/features/webcore.prf:
3029
3030 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
3031
3032         [Qt] Remove the QStyle dependency in Qt's mobile theme
3033         https://bugs.webkit.org/show_bug.cgi?id=67773
3034
3035         This refactoring splits up RenderThemeQt with two
3036         subclasses, a QStyle-backed one, and a Mobile version
3037         that uses the old mobile theme for now.
3038
3039         QStyle availability is detected at compile time, and
3040         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
3041         environment variable.
3042
3043         Reviewed by Simon Hausmann.
3044
3045         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3046         (WTR::activateFonts):
3047         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
3048         based on availability of QtWidgets.
3049         * qmake/mkspecs/features/webcore.prf: cleanup.
3050
3051 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3052
3053         [Qt] Add missing include to PlatformWebViewQt
3054
3055         Reviewed by Simon Hausmann.
3056
3057         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3058
3059 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3060
3061         [Qt] Fix incremental builds on Windows after buildsystem refactor
3062
3063         The qmake rules to ensure that we run make on the derived sources
3064         before running qmake on the target were inside a unix-scope, which
3065         resulted in flakey builds on Windows.
3066
3067         We now generate a rule on all platforms that ensures that "make qmake"
3068         will always run make on the derived sources. In addition, on platforms
3069         that have GNU make (where "make incremental" does not run "make qmake",
3070         but only "make"), we add a similar rule that ensures that any time the
3071         target makefile is regenerated we first run qmake and make on the derived
3072         sources. This rule relies on GNU make's order-only-prerequisites to
3073         not trigger a qmake-run of the target every time we run make.
3074
3075         https://bugs.webkit.org/show_bug.cgi?id=71778
3076
3077         Reviewed by Simon Hausmann.
3078
3079         * qmake/mkspecs/features/functions.prf:
3080
3081 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3082
3083         [Qt][WK2] Remove QWebNavigationController
3084         https://bugs.webkit.org/show_bug.cgi?id=72113
3085
3086         Reviewed by Andreas Kling.
3087
3088         Adapt to the move of the QWebNavigationController functions/properties to
3089         QQuickWebView.
3090
3091         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3092         * MiniBrowser/qt/qml/BrowserWindow.qml:
3093
3094 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3095
3096         [Qt] Build system tweak
3097
3098         Reviewed by Tor Arne Vestbø.
3099
3100         Be a good qmake citizen, return true from our linkStaticLibrary
3101         "test" function.
3102
3103         * qmake/mkspecs/features/functions.prf:
3104
3105 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3106
3107         [Qt] Add support for QT += webkit-private
3108
3109         Reviewed by Tor Arne Vestbø.
3110
3111         * qmake/qt_webkit.pri: Declare private headers.
3112
3113 2011-11-11  Philippe Normand  <pnormand@igalia.com>
3114
3115         Unreviewed, build fix attempt after r99907. Since that revision
3116         GTK layout tests were not running at all...
3117
3118         * Scripts/webkitpy/layout_tests/port/gtk.py:
3119
3120 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
3121
3122         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
3123         https://bugs.webkit.org/show_bug.cgi?id=72001
3124
3125         Reviewed by Dirk Pranke.
3126
3127         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3128
3129 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
3130
3131         bencher script should support remote benchmarking
3132         https://bugs.webkit.org/show_bug.cgi?id=71618
3133
3134         Rubber-stamped by Geoff Garen.
3135         
3136         Added the following features:
3137         
3138         - Benchmark report tells you the hostname and machine model (according to
3139           'sysctl hw.model') of the machine you did the run on, and svn revision number
3140           (according to 'svn info') of the VMs you're testing.
3141         
3142         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
3143           acceptable, in addition to just host, in which case your username is used)
3144           and it automatically packages the build directories of the VMs you're testing,
3145           sends them to the remote machine along with your copy of the bencher script
3146           and all of the options you passed.  This pretty much seamlessly allows you
3147           to run a set of benchmarks on any machine that is sufficiently compatible with
3148           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
3149           must now include a tempPath setting that tells bencher where to put files
3150           when that machine is used as a slave in a remote benchmarking run.
3151           
3152         - Added yet another way of specifying which benchmarks to run. This was sort of
3153           necessary for --remote to work as expected. Previously, you either said what
3154           suites to exclude (for example --exclude-sunspider) or that you only wanted
3155           to run one suite to the exclusion of others (--sunspider-only). But it's
3156           often better to just be able to specify the list of suites you want. This is
3157           now supported. You can say, for example, --v8 --sunspider, which means, just
3158           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
3159           still supported.
3160
3161         * Scripts/bencher:
3162
3163 2011-11-10  Tony Chang  <tony@chromium.org>
3164
3165         Lazily start DRT instances in NRWT
3166         https://bugs.webkit.org/show_bug.cgi?id=72038
3167
3168         Reviewed by Eric Seidel.
3169
3170         Just a refactoring, no new tests.
3171
3172         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3173         * Scripts/webkitpy/layout_tests/port/chromium.py:
3174         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3175         * Scripts/webkitpy/layout_tests/port/test.py:
3176         * Scripts/webkitpy/layout_tests/port/webkit.py:
3177
3178 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
3179
3180         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
3181         https://bugs.webkit.org/show_bug.cgi?id=72057
3182
3183         Reviewed by Eric Seidel.
3184
3185         Make the regular expression more explicit.
3186
3187         * Scripts/webkitpy/common/checkout/changelog.py:
3188         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3189
3190 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
3191
3192         [Qt] X11 plugins need to be reworked for Qt5
3193         https://bugs.webkit.org/show_bug.cgi?id=70023
3194
3195         Reviewed by Simon Hausmann.
3196
3197         Rework our basic plugin support in a way that does
3198         not need a bridge between Qt and X. The solution is
3199         based on getting the content drawed by the plugin
3200         from the server as an image and creating a QImage
3201         from it.
3202
3203         * qmake/mkspecs/features/features.prf: Enable X11
3204         plugins if Qt is built with the xcb-xlib backend.
3205
3206 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
3207
3208         [Qt] Fix keyboard related layout tests after API refactoring
3209
3210         Reviewed by Tor Arne Vestbø.
3211
3212         Send key events to the handling page item, not the view.
3213
3214         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3215         (WTR::PlatformWebView::sendEvent):
3216         (WTR::PlatformWebView::postEvent):
3217
3218 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
3219
3220         [GTK] Make the ENABLE(FEATURE) macro work in DRT
3221         https://bugs.webkit.org/show_bug.cgi?id=71940
3222
3223         Reviewed by Philippe Normand.
3224
3225         * GNUmakefile.am:
3226         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
3227         ENABLE_* variables are part of the environment.
3228
3229 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
3230
3231         [Qt] Fix focus related layout tests after API refactoring
3232
3233         Reviewed by Tor Arne Vestbø.
3234
3235         Make sure the focus is set on the page now, not on the view
3236         (which doesn't actually handle the focus).
3237
3238         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3239         (WTR::WrapperWindow::WrapperWindow):
3240         (WTR::WrapperWindow::handleStatusChanged):
3241
3242 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
3243
3244         [Qt] Merge QTouchWebView and QDesktopWebView into one class
3245         https://bugs.webkit.org/show_bug.cgi?id=71355
3246
3247         Reviewed by Kenneth Rohde Christiansen.
3248
3249         Make MiniBrowser and WebKitTestRunner work again after the
3250         merge.
3251
3252         * MiniBrowser/qt/BrowserWindow.cpp:
3253         (BrowserWindow::BrowserWindow):
3254         (BrowserWindow::webView):
3255         * MiniBrowser/qt/MiniBrowser.pro:
3256         * MiniBrowser/qt/MiniBrowser.qrc:
3257         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3258         * MiniBrowser/qt/main.cpp:
3259         * MiniBrowser/qt/qml/BrowserWindow.qml:
3260         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
3261         * MiniBrowser/qt/qml/TouchView.qml: Removed.
3262         * WebKitTestRunner/PlatformWebView.h:
3263         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3264         (WTR::PlatformWebView::PlatformWebView):
3265
3266 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3267
3268         [Qt] Change semantics of the haveQt() function to match API promises
3269
3270         Having Qt 5 does not imply that we have Qt 4, from an API point of
3271         view, as a major version can in theory break BC/SC. Our minimum
3272         version of Qt 4 will always be the latest released version of Qt 4,
3273         so the only place we should use haveQt(4, x) is when checking for
3274         the minimum requirements.
3275
3276         Reviewed by Simon Hausmann.
3277
3278         * qmake/mkspecs/features/default_pre.prf:
3279         * qmake/mkspecs/features/features.prf:
3280         * qmake/mkspecs/features/functions.prf:
3281
3282 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
3283
3284         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
3285         https://bugs.webkit.org/show_bug.cgi?id=69411
3286
3287         Reviewed by Martin Robinson.
3288
3289         * WebKitTestRunner/EventSenderProxy.h:
3290         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3291         * WebKitTestRunner/TestController.cpp:
3292         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3293         use the EventSender instead of WebProcess Event Simulation.
3294         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3295         (WTR::WTREventQueueItem::WTREventQueueItem):
3296         (WTR::EventSenderProxy::EventSenderProxy):
3297         (WTR::getMouseButtonModifiers):
3298         (WTR::eventSenderButtonToGDKButton):
3299         (WTR::EventSenderProxy::createMouseButtonEvent):
3300         (WTR::EventSenderProxy::updateClickCountForButton):
3301         (WTR::EventSenderProxy::replaySavedEvents):
3302         (WTR::EventSenderProxy::sendOrQueueEvent):
3303         (WTR::webkitModifiersToGDKModifiers):
3304         (WTR::getGDKKeySymForKeyRef):
3305         (WTR::EventSenderProxy::keyDown):
3306         (WTR::EventSenderProxy::mouseDown):
3307         (WTR::EventSenderProxy::mouseUp):
3308         (WTR::EventSenderProxy::mouseMoveTo):
3309         (WTR::EventSenderProxy::mouseScrollBy):
3310         (WTR::EventSenderProxy::leapForward):
3311
3312 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3313
3314         [Qt] Enable exports and constructor functions in static libs
3315
3316         Reviewed by Tor Arne Vestbø.
3317
3318         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3319         mac/win32-msvc equivalents when linking static libraries into a shared
3320         library or executable.
3321
3322 2011-11-09  Hayato Ito  <hayato@chromium.org>
3323
3324         [NRWT] Make results.html aware of reference filename in reftests.
3325         https://bugs.webkit.org/show_bug.cgi?id=71574
3326
3327         Reviewed by Ryosuke Niwa.
3328
3329         If a reference filename is different from the default one, include that in result summary
3330         so results.html can link to the correct reference file.
3331
3332         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3333         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3334
3335 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3336
3337         [wx] Unreviewed build fix. Update project files and
3338         add LTC stubs for new methods.
3339
3340         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3341         (LayoutTestController::addChromeInputField):
3342         (LayoutTestController::removeChromeInputField):
3343         (LayoutTestController::focusWebView):
3344         (LayoutTestController::setBackingScaleFactor):
3345         * waf/build/settings.py:
3346
3347 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3348
3349         [wx] Unreviewed build fix. Support XCode 4 when building deps.
3350
3351         * wx/install-unix-extras:
3352
3353 2011-11-09  Eric Seidel  <eric@webkit.org>
3354
3355         Remove the concept of platform-dependent unittests
3356         https://bugs.webkit.org/show_bug.cgi?id=71963
3357
3358         Unreviewed.  Fix test-webkitpy on cygwin.
3359
3360         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3361
3362 2011-11-09  Dana Jansens  <danakj@chromium.org>
3363
3364         Add cc-bugs group to watch changes in chromium graphics
3365         https://bugs.webkit.org/show_bug.cgi?id=71690
3366
3367         Reviewed by David Levin.
3368
3369         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
3370         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
3371         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
3372         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
3373
3374 2011-11-09  Eric Seidel  <eric@webkit.org>
3375
3376         Remove more platform-dependent unittests
3377         https://bugs.webkit.org/show_bug.cgi?id=71971
3378
3379         Reviewed by Adam Barth.
3380
3381         Tests which only run on a couple platforms will break.
3382         All tests should run on all platforms where possible.
3383
3384         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3385         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3386         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3387         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3388
3389 2011-11-09  Ojan Vafai  <ojan@chromium.org>
3390
3391         Merge in results to the test results server even if build numbers conflict
3392         https://bugs.webkit.org/show_bug.cgi?id=71967
3393
3394         Reviewed by Tony Chang.
3395
3396         This was initially meant to be a sanity check that we don't
3397         enter duplicate runs, but it turns out that we can reasonably get
3398         in these situations when a builder is clobbered (e.g. the build
3399         numbers start over again from 0).
3400
3401         * TestResultServer/model/jsonresults.py:
3402         * TestResultServer/model/jsonresults_unittest.py:
3403
3404 2011-11-09  Eric Seidel  <eric@webkit.org>
3405
3406         Remove the concept of platform-dependent unittests
3407         https://bugs.webkit.org/show_bug.cgi?id=71963
3408
3409         Reviewed by Adam Barth.
3410
3411         These have been the source of never-ending sadness.
3412         We'd change behavior and forget to update results in
3413         some unittests because they were only run on certain platforms.
3414         This change removes a large source of these platform-dependent
3415         unittests, which was caused by the port_maker stuff.
3416
3417         It's possible that this change will break test-webkitpy
3418         on some platforms, but that will be a one-time cost.
3419         I will fix the breakage by removing the platform-dependantness
3420         of any such broken tests.
3421
3422         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3423         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3424         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3425         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3426         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3427         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3428         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3429         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3430         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3431         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3432         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3433         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3434         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3435
3436 2011-11-09  Eric Seidel  <eric@webkit.org>
3437
3438         Make the Port object have a Host
3439         https://bugs.webkit.org/show_bug.cgi?id=71961
3440
3441         Reviewed by Adam Barth.
3442
3443         This has been a long time coming.
3444         Now that Port has a Host object, it's very easy
3445         to write unittests which use a properly mocked Port.
3446         Soon we will remove the executive, filesystem and user
3447         members of Port and get everything through the Host.
3448
3449         Note how in many callsites we're actually removing
3450         explicit mocks, since we're now always going to get the
3451         correct Executive/User/FileSystem from the
3452         Host and callsites don't need to be careful to pass each one.
3453
3454         This is prep-work for adding a new Environment member to
3455         Host and needing to be able to access the Environment
3456         member from Port functions w/o needing to pass an Environment
3457         object (or appropriate Mock) every place we create a Port object.
3458         Now that we have a single Host object to reach out through, its
3459         simple to add additional functionality (like Environment) while
3460         keeping our unittests properly mocked.
3461
3462         * Scripts/webkitpy/common/host.py:
3463         * Scripts/webkitpy/common/net/credentials_unittest.py:
3464         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3465         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3466         * Scripts/webkitpy/layout_tests/port/apple.py:
3467         * Scripts/webkitpy/layout_tests/port/base.py:
3468         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3469         * Scripts/webkitpy/layout_tests/port/chromium.py:
3470         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3471         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3472         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3473         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3474         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3475         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3476         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3477         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3478         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3479         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3480         * Scripts/webkitpy/layout_tests/port/efl.py:
3481         * Scripts/webkitpy/layout_tests/port/factory.py:
3482         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3483         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3484         * Scripts/webkitpy/layout_tests/port/gtk.py:
3485         * Scripts/webkitpy/layout_tests/port/mac.py:
3486         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3487         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3488         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3489         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3490         * Scripts/webkitpy/layout_tests/port/qt.py:
3491         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3492         * Scripts/webkitpy/layout_tests/port/test.py:
3493         * Scripts/webkitpy/layout_tests/port/webkit.py:
3494         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3495         * Scripts/webkitpy/layout_tests/port/win.py:
3496         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3497         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3498         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3499         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3500         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3501
3502 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
3503
3504         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
3505         https://bugs.webkit.org/show_bug.cgi?id=71561
3506
3507         Reviewed by Dimitri Glazkov.
3508
3509         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3510         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3511
3512 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
3513
3514         Implement dumpProgressFinishedCallback() for Mac layoutTestController
3515         https://bugs.webkit.org/show_bug.cgi?id=66772
3516
3517         Reviewed by Simon Fraser.
3518
3519         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
3520         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
3521
3522         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
3523         in the FrameLoadDelegate and print the output in response to the notification.
3524
3525         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3526         (-[FrameLoadDelegate init]):
3527         (-[FrameLoadDelegate dealloc]):
3528         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
3529
3530 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3531
3532         [GTK][DRT] window internals object is not reset after each test
3533         https://bugs.webkit.org/show_bug.cgi?id=71890
3534
3535         Reviewed by Martin Robinson.
3536
3537         Call WebCoreTestSupport::resetInternalsObject without going
3538         through DumpRenderTreeSupport.
3539
3540         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3541         (runTest):
3542
3543 2011-11-09  Beth Dakin  <bdakin@apple.com>
3544
3545         Build fix.
3546
3547         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3548         (AccessibilityUIElement::uiElementAttributeValue):
3549
3550 2011-11-09  Beth Dakin  <bdakin@apple.com>
3551
3552         Speculative build fix.
3553
3554         * DumpRenderTree/AccessibilityUIElement.h:
3555
3556 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
3557
3558         Unreviewed build fix.
3559
3560         * DumpRenderTree/AccessibilityUIElement.cpp:
3561         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3562         A bad merge added this check that is making the bots sad.
3563
3564 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
3565
3566         AX: crash when accessing selectedTab in a tab list
3567         https://bugs.webkit.org/show_bug.cgi?id=70938
3568
3569         Reviewed by Beth Dakin.
3570
3571         Add the ability to retrieve an element through an arbitrary attribute.
3572
3573         * DumpRenderTree/AccessibilityUIElement.cpp:
3574         (uiElementAttributeValueCallback):
3575         (AccessibilityUIElement::uiElementAttributeValue):
3576         (AccessibilityUIElement::getJSClass):
3577         * DumpRenderTree/AccessibilityUIElement.h:
3578         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3579         (AccessibilityUIElement::uiElementAttributeValue):
3580
3581 2011-11-09  Andy Wingo  <wingo@igalia.com>
3582
3583         Add webkitdirs.pm:getArchitecture implementation for GTK
3584         https://bugs.webkit.org/show_bug.cgi?id=71370
3585
3586         Reviewed by Xan Lopez.
3587
3588         * Scripts/webkitdirs.pm (determineArchitecture): Add an
3589         implementation for ports using autotools, so that a vanilla
3590         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
3591         to build-jsc on x86-64 machines.
3592
3593 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3594
3595         Unreviewed, rolling out r99707.
3596         http://trac.webkit.org/changeset/99707
3597
3598         Re-enable until we can disable it together with tests in one
3599         shot.
3600
3601         * qmake/mkspecs/features/features.prf:
3602
3603 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3604
3605         [Qt] Disable use of QtUiTools if the library/module is not found
3606
3607         We rely on the lookup order of prf files to inject our own uitools.prf
3608         that will verify that QtUiTools is in fact present before allowing the
3609         CONFIG += uitools to have any effect.
3610
3611         Reviewed by Simon Hausmann.
3612
3613         * DumpRenderTree/qt/DumpRenderTree.pro:
3614         * QtTestBrowser/QtTestBrowser.pro:
3615         * qmake/mkspecs/features/uitools.prf: Added.
3616
3617 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3618
3619         Unreviewed, rolling out r99701.
3620         http://trac.webkit.org/changeset/99701
3621
3622         Breaks Qt mac build
3623
3624         * qmake/mkspecs/features/functions.prf:
3625
3626 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3627
3628         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
3629
3630         Reviewed by Tor Arne Vestbø.
3631
3632         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
3633         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
3634         is not up to the task of full XSLT support, so we should disable it.
3635
3636 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3637
3638         [Qt] Enable exports and constructor functions in static libs
3639
3640         Reviewed by Tor Arne Vestbø.
3641
3642         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3643         mac/win32-msvc equivalents when linking static libraries into a shared
3644         library or executable.
3645
3646 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3647
3648         [GTK][DRT] window internals object is not reset after each test
3649         https://bugs.webkit.org/show_bug.cgi?id=71890
3650
3651         Reviewed by Xan Lopez.
3652
3653         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3654         (runTest): reset the Internals object after each test.
3655
3656 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3657
3658         [Qt] Detect presence of QtUiTools and enable it only when available
3659
3660         The disable_uitools option was a workaround for missing detection.
3661
3662         Reviewed by Simon Hausmann.
3663
3664         * QtTestBrowser/QtTestBrowser.pro:
3665         * qmake/mkspecs/features/default_post.prf:
3666         * qmake/mkspecs/features/default_pre.prf:
3667
3668 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3669
3670         [Qt] Don't override config for the build_pass of debug_and_release
3671
3672         Qmake will parse the profile once for each configuration (debug and
3673         release), with the build_pass option set. In that situation we don't
3674         want to override what qmake is setting explicitly, otherwise the
3675         debug-step will end up hitting all the release-scopes.
3676
3677         Reviewed by Simon Hausmann.
3678
3679         * qmake/mkspecs/features/default_pre.prf:
3680
3681 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3682
3683         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
3684
3685         * qmake/mkspecs/features/functions.prf:
3686
3687 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3688
3689         [Qt] Centralize duplicated code for linking the static libs
3690
3691         Reviewed by Tor Arne Vestbø.
3692
3693         * qmake/mkspecs/features/functions.prf:
3694         * qmake/mkspecs/features/javascriptcore.prf:
3695         * qmake/mkspecs/features/webcore.prf:
3696         * qmake/mkspecs/features/webkit2.prf:
3697
3698 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3699
3700         [Qt] Build system cleanup
3701         https://bugs.webkit.org/show_bug.cgi?id=71815
3702
3703         Reviewed by Kenneth Rohde Christiansen.
3704
3705         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
3706         static library.
3707         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
3708         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
3709
3710 2011-11-08  Hayato Ito  <hayato@chromium.org>
3711
3712         [NRWT] Make single_test_runner aware of reference filename of test_input.
3713         https://bugs.webkit.org/show_bug.cgi?id=71567
3714
3715         Reviewed by Ryosuke Niwa.
3716
3717         Make single_test_runner honor a reference filename of given test_input so that
3718         we can use any file as reference html, instead of depending on implicit naming convention.
3719         The typical use case is to support w3c reftests.
3720
3721         No tests since no functional changes until there is a client.
3722         Test should be easily written with future clients.
3723
3724         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3725         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3726         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3727         * Scripts/webkitpy/layout_tests/models/test_input.py:
3728
3729 2011-11-08  Lucas Forschler  <lforschler@apple.com>
3730
3731         https://bugs.webkit.org/show_bug.cgi?id=71839
3732         Update the leaks bot OS to Lion.
3733         Update the config.json to reflect the update.
3734
3735         Reviewed by Stephanie Lewis.
3736
3737         * BuildSlaveSupport/build.webkit.org-config/config.json:
3738
3739 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3740
3741         Unreviewed, rolling out r99626.
3742         http://trac.webkit.org/changeset/99626
3743         https://bugs.webkit.org/show_bug.cgi?id=71866
3744
3745         "C++ exceptions cannot be disabled without influencing the
3746         Objective-C exceptions" (Requested by benjaminp on #webkit).
3747
3748         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3749
3750 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
3751
3752         [Mac] Disable C++ exceptions from DumpRenderTree
3753         https://bugs.webkit.org/show_bug.cgi?id=71834
3754
3755         Reviewed by Darin Adler.
3756
3757         DumpRenderTree Mac does not handle C++ exceptions. When such exception
3758         happens, it tends to cause the AutoReleasePool stack to be corrupted,
3759         which leads to crashes long after the exception was raised.
3760
3761         This patch disabled C++ exceptions in order to catch the problems where
3762         they happen when a C++ exception is raised.
3763
3764         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3765
3766 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
3767
3768         Moved myself to the reviewer list (yay!).
3769
3770         * Scripts/webkitpy/common/config/committers.py:
3771
3772 2011-11-08  Zeno Albisser  <zeno@webkit.org>
3773
3774         Added myself as a committer.
3775
3776         * Scripts/webkitpy/common/config/committers.py:
3777
3778 2011-11-08  Andy Wingo  <wingo@igalia.com>
3779
3780         Skip some ECMAScript tests that fail on Linux in some time zones.
3781         https://bugs.webkit.org/show_bug.cgi?id=71371
3782
3783         Reviewed by Martin Robinson.
3784
3785         * Scripts/run-javascriptcore-tests: Skip some more tests.
3786
3787 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3788
3789         [Qt] Unreviewed trivial fix after build system refactoring.
3790
3791         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
3792
3793 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3794
3795         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
3796
3797         If a pro file needs to access the OBJECTS_DIR it should use the
3798         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
3799         after defaults_post has been processed.
3800
3801         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
3802         the command line will override whatever we set in defaults_pre.
3803
3804         Reviewed by Simon Hausmann.
3805
3806         * qmake/mkspecs/features/default_post.prf:
3807         * qmake/mkspecs/features/default_pre.prf:
3808
3809 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3810
3811         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
3812
3813         Reviewed by Simon Hausmann.
3814
3815         * qmake/mkspecs/features/default_post.prf:
3816
3817 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
3818
3819         [Qt][WK2] MiniBrowser should use urlFromUserInput()
3820         https://bugs.webkit.org/show_bug.cgi?id=71680
3821
3822         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
3823         complete urls in MiniBrowser.
3824
3825         Reviewed by Tor Arne Vestbø.
3826
3827         * MiniBrowser/qt/BrowserWindow.cpp:
3828         (BrowserWindow::BrowserWindow):
3829         (BrowserWindow::load):
3830         * MiniBrowser/qt/qml/BrowserWindow.qml:
3831         * MiniBrowser/qt/utils.cpp:
3832         (Utils::urlFromUserInput):
3833         * MiniBrowser/qt/utils.h:
3834         (Utils::Utils):
3835
3836 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
3837
3838         Added myself as a committer.
3839
3840         * Scripts/webkitpy/common/config/committers.py:
3841
3842 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3843
3844         Unreviewed webkitpy test fix after r99512.
3845
3846         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3847         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
3848
3849 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3850
3851         Added myself as a committer.
3852
3853         * Scripts/webkitpy/common/config/committers.py:
3854
3855 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3856
3857         Unreviewed, rolling out r99470.
3858         http://trac.webkit.org/changeset/99470
3859         https://bugs.webkit.org/show_bug.cgi?id=71740
3860
3861         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
3862
3863         * Scripts/webkitpy/common/config/watchlist:
3864
3865 2011-11-07  Tony Chang  <tony@chromium.org>
3866
3867         [chromium] update flakiness dashboard to reflect current bots
3868
3869         Reviewed by Ojan Vafai.
3870
3871         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
3872             bots and merged linux debug bots into a single bot.
3873         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3874         (setupExpectationsTest):
3875
3876 2011-11-07  Dana Jansens  <danakj@chromium.org>
3877
3878         Add cc-bugs group to watch changes in chromium graphics
3879         https://bugs.webkit.org/show_bug.cgi?id=71690
3880
3881         Reviewed by James Robinson.
3882
3883         * Scripts/webkitpy/common/config/watchlist:
3884
3885 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3886
3887         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
3888         https://bugs.webkit.org/show_bug.cgi?id=70912
3889
3890         Reviewed by Ojan Vafai.
3891
3892         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
3893         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
3894
3895 2011-11-07  Eric Seidel  <eric@webkit.org>
3896
3897         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
3898         https://bugs.webkit.org/show_bug.cgi?id=62199
3899
3900         Reviewed by Dirk Pranke.
3901
3902         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3903         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3904         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3905
3906 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
3907
3908         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
3909         https://bugs.webkit.org/show_bug.cgi?id=71485
3910
3911         Reviewed by Darin Fisher.
3912
3913         * DumpRenderTree/chromium/EventSender.cpp:
3914         (EventSender::scalePageBy):
3915         * DumpRenderTree/chromium/TestShell.cpp:
3916         (TestShell::resetTestController):
3917
3918 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3919
3920         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
3921
3922         Allows us to not package up the whole Source/JavaScriptCore directory for the
3923         buildbots.
3924
3925         Reviewed-by Simon Hausmann.
3926
3927         * BuildSlaveSupport/built-product-archive:
3928         * Scripts/webkitdirs.pm:
3929         (jscProductDir):
3930
3931 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3932
3933         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
3934
3935         Reviewed-by Simon Hausmann.
3936
3937         * qmake/mkspecs/features/default_post.prf:
3938
3939 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3940
3941         [Qt] Sanitize qmake paths correctly before comparing
3942
3943         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
3944         which caused us to always generate derived webcore sources, but never build
3945         them. The bug has been fixed, and we now also sanitize paths for the injected
3946         bundle derived sources.
3947
3948         Reviewed by Simon Hausmann.
3949
3950         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3951         * qmake/mkspecs/features/functions.prf:
3952
3953 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3954
3955         [Qt] Print right order for changing feature defines
3956
3957         Reviewed by Simon Hausmann.
3958
3959         * Scripts/webkitdirs.pm:
3960         (buildQMakeProject):
3961
3962 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
3963
3964         [Qt] Unreviewed trivial fix after build system refactoring.
3965
3966         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
3967
3968 2011-11-06  Eric Seidel  <eric@webkit.org>
3969
3970         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3971         https://bugs.webkit.org/show_bug.cgi?id=66078
3972
3973         Unreviewed.  Add an assert about the type of "args"
3974         to our Executive Mocks and fix a piece of code
3975         from this patch which was hitting that assert
3976         when executing for real.
3977
3978         * Scripts/webkitpy/common/system/executive_mock.py:
3979         * Scripts/webkitpy/layout_tests/port/webkit.py:
3980
3981 2011-11-06  Eric Seidel  <eric@webkit.org>
3982
3983         Split chunk handling out of prepare_lists_and_print_output to make it more readable
3984         https://bugs.webkit.org/show_bug.cgi?id=71629
3985
3986         Reviewed by Adam Barth.
3987
3988         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3989
3990 2011-11-06  Eric Seidel  <eric@webkit.org>
3991
3992         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3993         https://bugs.webkit.org/show_bug.cgi?id=66078
3994
3995         Reviewed by Adam Barth.
3996
3997         The runtime feature detection was fixed to work in bug 64472.
3998         In this bug I moved the symbol-based feature detection from
3999         popen() to Executive.run_command and cleaned up the callers
4000         and unittests to make sure that we're correctly parsing the
4001         nm output correctly.  The old code happened to work even though
4002         the runtime-features path was using "str in list" and the
4003         symbol features path was using "str in str" and it just happened
4004         to do what we wanted to.  Now runtime features and symbol feature
4005         blacklists are computed separately (and with better documentation).
4006
4007         This system remains confusing, partially because these are black-lists
4008         which are amended to whatever static blacklist may exist for the
4009         port as part of a Skipped list file.
4010
4011         For example, notice how the runtime feature list only has directory
4012         blacklists for a couple features.  If all features are off,
4013         how do we skip enough tests with only 2 entries in the blacklist map?
4014         The answer is that Windows is the only port to use runtime feature
4015         detection, and the win/Skipped file turns off all the other features
4016         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
4017         which use symbol-based feature detection turn of mathml, wcss, etc
4018         using the blacklists found in _missing_symbol_to_skipped_tests.
4019
4020         I also noticed a couple places where we still referenced xhtmlmp
4021         even though support for such has been removed from WebKit.  Removed those.
4022
4023         This should result in no functional change.
4024
4025         * Scripts/webkitpy/layout_tests/port/gtk.py:
4026          - Use self._filesystem instead of os.path
4027         * Scripts/webkitpy/layout_tests/port/webkit.py:
4028         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4029
4030 2011-11-06  Dan Bernstein  <mitz@apple.com>
4031
4032         Made show-pretty-diff work when the input path contains spaces.
4033
4034         Reviewed by Anders Carlsson.
4035
4036         * Scripts/show-pretty-diff:
4037
4038 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
4039
4040         [chromium] Use the security origin instead of the URL when checking notification permissions
4041         https://bugs.webkit.org/show_bug.cgi?id=71590
4042
4043         Reviewed by Adam Barth.
4044
4045         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4046         (NotificationPresenter::checkPermission):
4047         * DumpRenderTree/chromium/NotificationPresenter.h:
4048
4049 2011-11-05  Darin Adler  <darin@apple.com>
4050
4051         Fix a small leak in Mac version of LayoutTestController
4052         https://bugs.webkit.org/show_bug.cgi?id=71615
4053
4054         Reviewed by Mark Rowe.
4055
4056         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4057         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
4058         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
4059
4060 2011-11-04  Eric Seidel  <eric@webkit.org>
4061
4062         Upgrade to the latest Mechanize
4063         https://bugs.webkit.org/show_bug.cgi?id=71594
4064
4065         Reviewed by Adam Barth.
4066
4067         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
4068         Mechanize is no longer two separate libraries, so importing it is much simpler.
4069
4070         * Scripts/webkitpy/thirdparty/__init__.py:
4071
4072 2011-11-04  Stephen Chenney  <schenney@chromium.org>
4073
4074         Crash in ScrollAnimator.cpp
4075         https://bugs.webkit.org/show_bug.cgi?id=69865
4076
4077         The code in ScrollAnimator assumes that horizontal per-page mouse
4078         wheel events cannot happen, which is not true. This patch adds layout
4079         tests for all paging wheel event situations and fixes the broken
4080         horizontal case.
4081
4082         Reviewed by Anders Carlsson
4083
4084         * DumpRenderTree/chromium/EventSender.cpp:
4085         (EventSender::handleMouseWheel): Added the ability to specify that a
4086         mouse wheel event should be paging.
4087
4088 2011-11-04  Eric Seidel  <eric@webkit.org>
4089
4090         Remove deprecated free functions in port.factory
4091         https://bugs.webkit.org/show_bug.cgi?id=71494
4092
4093         Unreviewed.  Fix exception when running new-run-webkit-httpd.
4094
4095         * Scripts/new-run-webkit-httpd:
4096
4097 2011-11-04  Adam Roben  <aroben@apple.com>
4098
4099         Remove Leopard-specific code from build.webkit.org
4100
4101         We don't have any Leopard bots anymore.
4102
4103         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
4104
4105         Reviewed by Mark Rowe.
4106
4107         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
4108         and StopATSServer steps.
4109         (unitTestsSupported): Removed check for mac-leopard.
4110         (TestFactory.__init__): Removed Leopard-specific steps.
4111
4112 2011-11-04  Eric Seidel  <eric@webkit.org>
4113
4114         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
4115         https://bugs.webkit.org/show_bug.cgi?id=71549
4116
4117         Reviewed by Adam Barth.
4118
4119         Several members of Host didn't really belong there
4120         and were instead specific to WebKitPatch, so I've moved
4121         them up onto that class.
4122
4123         * Scripts/webkitpy/common/host.py:
4124         * Scripts/webkitpy/common/host_mock.py:
4125         * Scripts/webkitpy/tool/main.py:
4126         * Scripts/webkitpy/tool/mocktool.py:
4127         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4128
4129 2011-11-04  Tony Chang  <tony@chromium.org>
4130
4131         garden-o-matic: bring back party time!
4132         https://bugs.webkit.org/show_bug.cgi?id=71582
4133
4134         Reviewed by Adam Barth.
4135
4136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
4137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
4138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
4139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
4140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
4141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
4142
4143 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
4144
4145         [EFL] DRT: Fix the order of the items in the dumped history list.
4146         https://bugs.webkit.org/show_bug.cgi?id=71562
4147
4148         It did not make much sense to hold the history list in a map, as we do not need
4149         the keys. And the printed items must be sorted by target, which is more easily
4150         done with a vector.
4151
4152         Should make tests such as http/tests/navigation/error404-frames.html pass.
4153
4154         Reviewed by Antonio Gomes.
4155
4156         * DumpRenderTree/efl/DumpHistoryItem.cpp:
4157         (compareHistoryItemsByTarget):
4158         (dumpHistoryItem):
4159
4160 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
4161
4162         [Qt] Remove ENABLE_SQLITE from qmake files
4163         https://bugs.webkit.org/show_bug.cgi?id=71546
4164
4165         Reviewed by Simon Hausmann.
4166
4167         * qmake/mkspecs/features/features.prf:
4168         * qmake/mkspecs/features/webcore.prf:
4169
4170 2011-11-04  Adam Barth  <abarth@webkit.org>
4171
4172         watchlist for WebIDL shouldn't trigger on Internals.idl
4173         https://bugs.webkit.org/show_bug.cgi?id=70657
4174
4175         Reviewed by David Levin.
4176
4177         Internals.idl isn't part of the Web-facing IDL in the project.
4178
4179         * Scripts/webkitpy/common/config/watchlist:
4180
4181 2011-11-04  Anders Carlsson  <andersca@apple.com>
4182
4183         Fix WKTR crash when running NPN_ConvertPoint test.
4184
4185         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
4186
4187         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
4188         (ConvertPoint::NPP_SetWindow):
4189
4190 2011-11-04  Anders Carlsson  <andersca@apple.com>
4191
4192         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
4193         https://bugs.webkit.org/show_bug.cgi?id=71570
4194
4195         Reviewed by Simon Fraser.
4196
4197         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4198         (PluginTest::NPP_SetWindow):
4199         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4200         Remove the NPP parameter from NPP_SetWindow.
4201
4202         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
4203         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
4204         Remove the NPP parameter from NPP_SetWindow.
4205
4206         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
4207         (PassDifferentNPPStruct::NPP_SetWindow):
4208         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
4209
4210         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
4211         (ConvertPoint::NPP_SetWindow):
4212         Run the test from NPP_SetWindow and call notifyDone() when done.
4213
4214         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4215         (NPP_SetWindow):
4216         Remove unnecessary parameter.
4217
4218 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4219
4220         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
4221
4222         Rubber-stamped by Tor Arne Vestbø.
4223
4224         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
4225         changed slightly after the refactoring.
4226
4227 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4228
4229         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
4230
4231         Reviewed by Simon Hausmann.
4232
4233         * qmake/mkspecs/features/default_pre.prf:
4234
4235 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4236
4237         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
4238
4239         Reviewed by Simmon Hausmann.
4240
4241         * qmake/mkspecs/features/default_pre.prf:
4242
4243 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4244
4245         [Qt] Disable STDIN check before cleaning build dir
4246
4247         It didn't work on the bots.
4248
4249         Reviewed by Ossy.
4250
4251         * Scripts/webkitdirs.pm:
4252
4253 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4254
4255         [Qt] Don't build all of webkit when running build-jsc
4256
4257         In case the whole webkit project was built, but we then subsequently
4258         want to build only JSC, we need to run make in the proper subdirectory.
4259
4260         This also means the incremental target needs to be added to all
4261         makefiles.
4262
4263         Reviewed by Simmon Hausmann.
4264
4265         * Scripts/webkitdirs.pm:
4266         (buildQMakeProject):
4267         * qmake/mkspecs/features/default_post.prf:
4268
4269 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4270
4271         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
4272
4273         Reviewed by Tor Arne Vestbø.
4274
4275         * Scripts/webkitdirs.pm:
4276         (jscProductDir): jsc path changed.
4277
4278 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4279
4280         [Qt] Error out early if trying to build against Qt < 4.8
4281
4282         Reviewed by Simon Hausmann.
4283
4284         * qmake/mkspecs/features/default_pre.prf:
4285
4286 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4287
4288         Fix run-launcher for Qt and Gtk.
4289
4290         Rubber-stamped by Tor Arne Vestbø.
4291
4292         * Scripts/webkitdirs.pm:
4293         (isWK2): Re-add isWK2(), as it's used in run-launcher.
4294
4295 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4296
4297         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
4298
4299         Reviewed by Simon Hausmann.
4300
4301         * Scripts/build-webkit:
4302
4303 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4304
4305         [GTK] Use web view title as window title in MiniBrowser
4306         https://bugs.webkit.org/show_bug.cgi?id=71544
4307
4308         Reviewed by Philippe Normand.
4309
4310         * MiniBrowser/gtk/BrowserWindow.c:
4311         (webViewURIChanged): Removed extra space.
4312         (webViewTitleChanged): Set window title using
4313         webkit_web_view_get_title().
4314         (browser_window_init): Set initial default window title.
4315         (browserWindowConstructed): Connect to WebView notify::title
4316         signal.
4317
4318 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@