[chromium] stop spamming features warning on every build
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-17  Tony Chang  <tony@chromium.org>
2
3         [chromium] stop spamming features warning on every build
4         https://bugs.webkit.org/show_bug.cgi?id=72629
5
6         Reviewed by Ojan Vafai.
7
8         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
9         $mediaStreamSupport is on by default for chromium, make the default
10         for $blobSupport also on.
11
12         * Scripts/build-webkit:
13
14 2011-11-17  Adam Roben  <aroben@apple.com>
15
16         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
17
18         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
19         that are supposed to be ignored
20
21         Reviewed by Adam Barth.
22
23         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
24         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
25         required when passing arguments via the shell (which we aren't doing here). It is not
26         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
27
28         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
29         (LeakDetectorTest.test_leaks_args): Updated expectations.
30
31 2011-11-17  Philippe Normand  <pnormand@igalia.com>
32
33         Unreviewed, run-bindings-tests fix after r91028.
34
35         * Scripts/run-bindings-tests: Use scm.detection module.
36
37 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
38
39         Silence a warning about control reaching the end of a non-void function
40         https://bugs.webkit.org/show_bug.cgi?id=72616
41
42         Reviewed by Tony Gentilcore.
43
44         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
45         (AccessibilityUIElement::verticalScrollbar):
46
47 2011-11-17  Adam Roben  <aroben@apple.com>
48
49         Ignore some leaks in frameworks we link against on Lion
50
51         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
52         aren't WebKit's fault
53
54         Reviewed by Antti Koivisto.
55
56         * Scripts/old-run-webkit-tests:
57         (countAndPrintLeaks):
58         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
59         (LeakDetector._callstacks_to_exclude_from_leaks):
60         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
61
62         * Scripts/webkitpy/layout_tests/port/mac.py:
63         (MacPort.is_lion): Added.
64
65         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
66         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
67         methods.
68
69 2011-11-17  Philippe Normand  <pnormand@igalia.com>
70
71         [GTK] Disable ref tests
72         https://bugs.webkit.org/show_bug.cgi?id=72599
73
74         Reviewed by Xan Lopez.
75
76         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
77         tests to avoid massive flakiness.
78
79 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
80
81         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
82
83         A new extension object has been added to QQuickWebView (the same approach should be used
84         for other API classes that need experimental APIs). The QML extension mechanism is then
85         built on top of the experimental object.
86
87         https://bugs.webkit.org/show_bug.cgi?id=72522
88
89         Reviewed by Simon Hausmann.
90
91         * MiniBrowser/qt/BrowserWindow.cpp:
92         (BrowserWindow::BrowserWindow):
93         (BrowserWindow::webView):
94         * MiniBrowser/qt/BrowserWindow.h:
95         * MiniBrowser/qt/UrlLoader.cpp:
96         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
97         * qmake/mkspecs/features/default_post.prf:
98         * qmake/mkspecs/features/default_pre.prf:
99         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
100         * qmake/mkspecs/features/qtwebkit.prf:
101
102 2011-11-17  Adam Barth  <abarth@webkit.org>
103
104         Move test_results_uploader.py out of layout_package
105         https://bugs.webkit.org/show_bug.cgi?id=72590
106
107         Reviewed by Eric Seidel.
108
109         Most of the lines of code in this file are wrong, but I've restrained
110         myself and only changed a few of them to generalized this class to the
111         common package.
112
113         This is part of a series of patches to remove layout_package.
114
115         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
116         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
117         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
118
119 2011-11-17  Adam Barth  <abarth@webkit.org>
120
121         Unreviewed. Fix style nits in printing.py.
122
123         * Scripts/webkitpy/layout_tests/views/printing.py:
124
125 2011-11-17  Adam Barth  <abarth@webkit.org>
126
127         Minor style nits in run_webkit_tests.py
128         https://bugs.webkit.org/show_bug.cgi?id=72583
129
130         Reviewed by Eric Seidel.
131
132         This patch just fixes some minor style issues as I work my way back
133         into this code.
134
135         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
136
137 2011-11-17  Adam Barth  <abarth@webkit.org>
138
139         Move test_result_writer out of layout_package
140         https://bugs.webkit.org/show_bug.cgi?id=72586
141
142         Rubber-stamped by Eric Seidel.
143
144         This is part of a series of patches to remove layout_package.
145
146         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
147         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
148         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
149         * Scripts/webkitpy/tool/commands/rebaseline.py:
150
151 2011-11-17  Adam Barth  <abarth@webkit.org>
152
153         svn-apply shouldn't magically move files into Source anymore
154         https://bugs.webkit.org/show_bug.cgi?id=72579
155
156         Reviewed by Eric Seidel.
157
158         The Source directory has existed for long enough that we don't need
159         svn-apply to magically re-write old-style patches anymore.
160
161         * Scripts/VCSUtils.pm:
162         (parseGitDiffHeader):
163         (parseSvnDiffHeader):
164
165 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
166
167         Add a list of contribution areas
168         https://bugs.webkit.org/show_bug.cgi?id=72566
169
170         Reviewed by Eric Seidel.
171
172         Added ContributionAreas class.
173
174         * Scripts/webkitpy/common/config/contributionareas.py: Added.
175         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
176
177 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
178
179         Refactor ChangeLogTest.test_parse_reviewer_text
180         https://bugs.webkit.org/show_bug.cgi?id=72572
181
182         Reviewed by Eric Seidel.
183
184         Refactored the test code by introduing two helper functions.
185
186         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
187
188 2011-11-16  Eric Seidel  <eric@webkit.org>
189
190         Add SCMDetector object to make scm detection mockable
191         https://bugs.webkit.org/show_bug.cgi?id=72247
192
193         Reviewed by Adam Barth.
194
195         I think SCM detection may eventually be rolled into Checkout,
196         but this patch at least makes it possible to mock code-paths
197         which rely on scm detection.
198         In the process of replacing callers of these free-functions
199         I found that one of the functions was no longer used,
200         and that one of the callers could instead just use the SCM
201         object it already had access to through port.host.scm().
202         I also discovered that I was not calling Host._initialize_scm()
203         and thus host.scm() was always returning None!
204
205         * Scripts/check-webkit-style:
206         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
207         * Scripts/webkitpy/common/checkout/deps.py:
208         * Scripts/webkitpy/common/checkout/scm/__init__.py:
209         * Scripts/webkitpy/common/checkout/scm/detection.py:
210         * Scripts/webkitpy/common/checkout/scm/git.py:
211         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
212         * Scripts/webkitpy/common/checkout/scm/svn.py:
213         * Scripts/webkitpy/common/host.py:
214         * Scripts/webkitpy/common/host_mock.py:
215         * Scripts/webkitpy/layout_tests/controllers/manager.py:
216         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
217         * Scripts/webkitpy/layout_tests/port/base.py:
218         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
219         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
220         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
221         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
222
223 2011-11-16  Mark Rowe  <mrowe@apple.com>
224
225         Fix the build.
226
227         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
228         Apply the workaround that we use in other projects to WebKitTestRunner.
229
230         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
231         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
232         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
233
234 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
235
236         [Qt] Fix build after WTR AX support
237         https://bugs.webkit.org/show_bug.cgi?id=72560
238
239         Reviewed by Geoffrey Garen.
240
241         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
242         * WebKitTestRunner/InjectedBundle/Target.pri:
243
244 2011-11-16  Tony Chang  <tony@chromium.org>
245
246         repurpose the flexbox bot for grid layout
247         https://bugs.webkit.org/show_bug.cgi?id=72557
248
249         Reviewed by Ryosuke Niwa.
250
251         Since new flexbox is enabled everywhere, we don't need this bot
252         anymore.  However, work on grid layout has begun, so we can use this
253         bot to compile with ENABLE_CSS_GRID_LAYOUT.
254
255         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
256         the bot on the waterfall, I will change the slave config to enable
257         the compile flag and tests.
258
259 2011-11-11  Adrienne Walker  <enne@google.com>
260
261         [chromium] Expose mock scrollbars to window.internals
262         https://bugs.webkit.org/show_bug.cgi?id=72195
263
264         Reviewed by James Robinson.
265
266         Because mock scrollbars are a global setting, reset between runs.
267
268         * DumpRenderTree/chromium/WebPreferences.cpp:
269         (WebPreferences::applyTo):
270
271 2011-11-16  James Robinson  <jamesr@chromium.org>
272
273         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
274         https://bugs.webkit.org/show_bug.cgi?id=72562
275
276         Reviewed by Dirk Pranke.
277
278         * DumpRenderTree/chromium/TestShell.cpp:
279         (TestShell::runFileTest):
280
281 2011-11-16  Tony Chang  <tony@chromium.org>
282
283         [NRWT] speculative fix for multiple subprocess test on cygwin
284         https://bugs.webkit.org/show_bug.cgi?id=72518
285
286         Reviewed by Adam Barth.
287
288         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
289             tries to emulate posix fd behavior.
290         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
291
292 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
293
294         Revert r100509; change was committed twice (first time as r100491).
295         Unreviewed, build fix.
296
297         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
298
299 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
300
301         Run a dummy test in the gpu configurations if there's nothing to do.
302         https://bugs.webkit.org/show_bug.cgi?id=72498
303
304         Reviewed by James Robinson.
305
306         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
307
308 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
309
310         contributors_by_fuzzy_match is super slow
311         https://bugs.webkit.org/show_bug.cgi?id=72540
312
313         Reviewed by Eric Seidel.
314
315         Make contributors_by_name do case insensitive search using a dictionary.
316
317         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
318         because that's the most common case.
319
320         * Scripts/webkitpy/common/config/committers.py:
321         * Scripts/webkitpy/common/config/committers_unittest.py:
322
323 2011-11-16  David Levin  <levin@chromium.org>
324
325         check-webkit-style should recognize functions even if they have OVERRIDE after them.
326         https://bugs.webkit.org/show_bug.cgi?id=72515
327
328         Reviewed by Adam Barth.
329
330         * Scripts/webkitpy/style/checkers/cpp.py:
331         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
332
333 2011-11-16  Tony Chang  <tony@chromium.org>
334
335         [NRWT] refactor drivers to require pixel_tests param
336         https://bugs.webkit.org/show_bug.cgi?id=72517
337
338         Reviewed by Ojan Vafai.
339
340         No tests, just a refactoring.
341
342         * Scripts/webkitpy/layout_tests/port/chromium.py:
343         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
344         * Scripts/webkitpy/layout_tests/port/webkit.py:
345         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
346
347 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
348
349         Run a dummy test in the gpu configurations if there's nothing to do.
350         https://bugs.webkit.org/show_bug.cgi?id=72498
351
352         Reviewed by James Robinson.
353
354         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
355
356 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
357
358         WebKitTestRunner needs to support accessibility-related DRT APIs
359         https://bugs.webkit.org/show_bug.cgi?id=42131
360
361         Reviewed by Beth Dakin.
362
363         Port the AX code in DRT to WKTestRunner by using IDL.
364
365         * DumpRenderTree/AccessibilityUIElement.cpp:
366         (horizontalScrollbarCallback):
367         (verticalScrollbarCallback):
368         (AccessibilityUIElement::horizontalScrollbar):
369         (AccessibilityUIElement::verticalScrollbar):
370         (AccessibilityUIElement::getJSClass):
371         * DumpRenderTree/AccessibilityUIElement.h:
372         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
373         (AccessibilityUIElement::horizontalScrollbar):
374         (AccessibilityUIElement::verticalScrollbar):
375         * WebKitTestRunner/DerivedSources.make:
376         * WebKitTestRunner/GNUmakefile.am:
377         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
378         (WTR::AccessibilityController::create):
379         (WTR::AccessibilityController::AccessibilityController):
380         (WTR::AccessibilityController::~AccessibilityController):
381         (WTR::AccessibilityController::makeWindowObject):
382         (WTR::AccessibilityController::wrapperClass):
383         (WTR::AccessibilityController::rootElement):
384         (WTR::AccessibilityController::focusedElement):
385         (WTR::AccessibilityController::elementAtPoint):
386         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
387         (WTR::AccessibilityController::logFocusEvents):
388         (WTR::AccessibilityController::logValueChangeEvents):
389         (WTR::AccessibilityController::logScrollingStartEvents):
390         (WTR::AccessibilityController::logAccessibilityEvents):
391         (WTR::AccessibilityController::addNotificationListener):
392         (WTR::AccessibilityController::notificationReceived):
393         (WTR::AccessibilityController::resetToConsistentState):
394         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
395         (WTR::AccessibilityTextMarker::create):
396         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
397         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
398         (WTR::AccessibilityTextMarker::platformTextMarker):
399         (WTR::AccessibilityTextMarker::wrapperClass):
400         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
401         (WTR::AccessibilityTextMarker::isEqual):
402         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
403         (WTR::AccessibilityTextMarkerRange::create):
404         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
405         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
406         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
407         (WTR::AccessibilityTextMarkerRange::wrapperClass):
408         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
409         (WTR::AccessibilityTextMarkerRange::isEqual):
410         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
411         (WTR::AccessibilityUIElement::create):
412         (WTR::AccessibilityUIElement::wrapperClass):
413         (WTR::AccessibilityUIElement::isValid):
414         (WTR::AccessibilityUIElement::AccessibilityUIElement):
415         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
416         (WTR::AccessibilityUIElement::isEqual):
417         (WTR::AccessibilityUIElement::elementAtPoint):
418         (WTR::AccessibilityUIElement::childAtIndex):
419         (WTR::AccessibilityUIElement::indexOfChild):
420         (WTR::AccessibilityUIElement::childrenCount):
421         (WTR::AccessibilityUIElement::titleUIElement):
422         (WTR::AccessibilityUIElement::parentElement):
423         (WTR::AccessibilityUIElement::takeFocus):
424         (WTR::AccessibilityUIElement::takeSelection):
425         (WTR::AccessibilityUIElement::addSelection):
426         (WTR::AccessibilityUIElement::removeSelection):
427         (WTR::AccessibilityUIElement::allAttributes):
428         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
429         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
430         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
431         (WTR::AccessibilityUIElement::attributesOfChildren):
432         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
433         (WTR::AccessibilityUIElement::increment):
434         (WTR::AccessibilityUIElement::decrement):
435         (WTR::AccessibilityUIElement::showMenu):
436         (WTR::AccessibilityUIElement::press):
437         (WTR::AccessibilityUIElement::stringAttributeValue):
438         (WTR::AccessibilityUIElement::uiElementAttributeValue):
439         (WTR::AccessibilityUIElement::numberAttributeValue):
440         (WTR::AccessibilityUIElement::boolAttributeValue):
441         (WTR::AccessibilityUIElement::isAttributeSupported):
442         (WTR::AccessibilityUIElement::isAttributeSettable):
443         (WTR::AccessibilityUIElement::isActionSupported):
444         (WTR::AccessibilityUIElement::role):
445         (WTR::AccessibilityUIElement::subrole):
446         (WTR::AccessibilityUIElement::roleDescription):
447         (WTR::AccessibilityUIElement::title):
448         (WTR::AccessibilityUIElement::description):
449         (WTR::AccessibilityUIElement::language):
450         (WTR::AccessibilityUIElement::stringValue):
451         (WTR::AccessibilityUIElement::accessibilityValue):
452         (WTR::AccessibilityUIElement::helpText):
453         (WTR::AccessibilityUIElement::orientation):
454         (WTR::AccessibilityUIElement::x):
455         (WTR::AccessibilityUIElement::y):
456         (WTR::AccessibilityUIElement::width):
457         (WTR::AccessibilityUIElement::height):
458         (WTR::AccessibilityUIElement::intValue):
459         (WTR::AccessibilityUIElement::minValue):
460         (WTR::AccessibilityUIElement::maxValue):
461         (WTR::AccessibilityUIElement::valueDescription):
462         (WTR::AccessibilityUIElement::insertionPointLineNumber):
463         (WTR::AccessibilityUIElement::selectedTextRange):
464         (WTR::AccessibilityUIElement::isEnabled):
465         (WTR::AccessibilityUIElement::isRequired):
466         (WTR::AccessibilityUIElement::isFocused):
467         (WTR::AccessibilityUIElement::isFocusable):
468         (WTR::AccessibilityUIElement::isSelected):
469         (WTR::AccessibilityUIElement::isSelectable):
470         (WTR::AccessibilityUIElement::isMultiSelectable):
471         (WTR::AccessibilityUIElement::setSelectedChild):
472         (WTR::AccessibilityUIElement::selectedChildrenCount):
473         (WTR::AccessibilityUIElement::selectedChildAtIndex):
474         (WTR::AccessibilityUIElement::isExpanded):
475         (WTR::AccessibilityUIElement::isChecked):
476         (WTR::AccessibilityUIElement::isVisible):
477         (WTR::AccessibilityUIElement::isOffScreen):
478         (WTR::AccessibilityUIElement::isCollapsed):
479         (WTR::AccessibilityUIElement::isIgnored):
480         (WTR::AccessibilityUIElement::hasPopup):
481         (WTR::AccessibilityUIElement::hierarchicalLevel):
482         (WTR::AccessibilityUIElement::clickPointX):
483         (WTR::AccessibilityUIElement::clickPointY):
484         (WTR::AccessibilityUIElement::documentEncoding):
485         (WTR::AccessibilityUIElement::documentURI):
486         (WTR::AccessibilityUIElement::url):
487         (WTR::AccessibilityUIElement::speak):
488         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
489         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
490         (WTR::AccessibilityUIElement::attributesOfColumns):
491         (WTR::AccessibilityUIElement::attributesOfRows):
492         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
493         (WTR::AccessibilityUIElement::attributesOfHeader):
494         (WTR::AccessibilityUIElement::indexInTable):
495         (WTR::AccessibilityUIElement::rowIndexRange):
496         (WTR::AccessibilityUIElement::columnIndexRange):
497         (WTR::AccessibilityUIElement::rowCount):
498         (WTR::AccessibilityUIElement::columnCount):
499         (WTR::AccessibilityUIElement::selectedRowAtIndex):
500         (WTR::AccessibilityUIElement::disclosedByRow):
501         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
502         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
503         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
504         (WTR::AccessibilityUIElement::ariaIsGrabbed):
505         (WTR::AccessibilityUIElement::ariaDropEffects):
506         (WTR::AccessibilityUIElement::lineForIndex):
507         (WTR::AccessibilityUIElement::rangeForLine):
508         (WTR::AccessibilityUIElement::boundsForRange):
509         (WTR::AccessibilityUIElement::setSelectedTextRange):
510         (WTR::AccessibilityUIElement::stringForRange):
511         (WTR::AccessibilityUIElement::attributedStringForRange):
512         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
513         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
514         (WTR::AccessibilityUIElement::cellForColumnAndRow):
515         (WTR::AccessibilityUIElement::horizontalScrollbar):
516         (WTR::AccessibilityUIElement::verticalScrollbar):
517         (WTR::AccessibilityUIElement::addNotificationListener):
518         (WTR::AccessibilityUIElement::removeNotificationListener):
519         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
520         (WTR::AccessibilityUIElement::textMarkerRangeLength):
521         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
522         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
523         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
524         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
525         (WTR::AccessibilityUIElement::textMarkerForPoint):
526         (WTR::AccessibilityUIElement::previousTextMarker):
527         (WTR::AccessibilityUIElement::nextTextMarker):
528         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
529         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
530         (WTR::AccessibilityUIElement::platformUIElement):
531         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
532         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
533         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
534         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
535         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
536         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
537         (WTR::InjectedBundle::beginTesting):
538         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
539         (WTR::InjectedBundle::accessibilityController):
540         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
541         (WTR::InjectedBundlePage::didClearWindowForFrame):
542         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
543         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
544         (WTR::LayoutTestController::platformName):
545         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
546         (WTR::AccessibilityTextMarker::isEqual):
547         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
548         (WTR::AccessibilityTextMarkerRange::isEqual):
549         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
550         (+[NSString stringWithJSStringRef:]):
551         (-[NSString createJSStringRef]):
552         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
553         (-[AccessibilityNotificationHandler dealloc]):
554         (-[AccessibilityNotificationHandler _notificationReceived:]):
555         (-[AccessibilityNotificationHandler setCallback:]):
556         (WTR::AccessibilityUIElement::AccessibilityUIElement):
557         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
558         (WTR::AccessibilityUIElement::isEqual):
559         (WTR::descriptionOfValue):
560         (WTR::attributesOfElement):
561         (WTR::concatenateAttributeAndValue):
562         (WTR::convertNSArrayToVector):
563         (WTR::descriptionOfElements):
564         (WTR::AccessibilityUIElement::getLinkedUIElements):
565         (WTR::AccessibilityUIElement::getDocumentLinks):
566         (WTR::AccessibilityUIElement::getChildren):
567         (WTR::AccessibilityUIElement::getChildrenWithRange):
568         (WTR::AccessibilityUIElement::childrenCount):
569         (WTR::AccessibilityUIElement::elementAtPoint):
570         (WTR::AccessibilityUIElement::indexOfChild):
571         (WTR::AccessibilityUIElement::childAtIndex):
572         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
573         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
574         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
575         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
576         (WTR::AccessibilityUIElement::selectedChildAtIndex):
577         (WTR::AccessibilityUIElement::selectedChildrenCount):
578         (WTR::AccessibilityUIElement::selectedRowAtIndex):
579         (WTR::AccessibilityUIElement::titleUIElement):
580         (WTR::AccessibilityUIElement::parentElement):
581         (WTR::AccessibilityUIElement::disclosedByRow):
582         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
583         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
584         (WTR::AccessibilityUIElement::attributesOfChildren):
585         (WTR::AccessibilityUIElement::allAttributes):
586         (WTR::AccessibilityUIElement::stringAttributeValue):
587         (WTR::AccessibilityUIElement::numberAttributeValue):
588         (WTR::AccessibilityUIElement::uiElementAttributeValue):
589         (WTR::AccessibilityUIElement::boolAttributeValue):
590         (WTR::AccessibilityUIElement::isAttributeSettable):
591         (WTR::AccessibilityUIElement::isAttributeSupported):
592         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
593         (WTR::AccessibilityUIElement::role):
594         (WTR::AccessibilityUIElement::subrole):
595         (WTR::AccessibilityUIElement::roleDescription):
596         (WTR::AccessibilityUIElement::title):
597         (WTR::AccessibilityUIElement::description):
598         (WTR::AccessibilityUIElement::orientation):
599         (WTR::AccessibilityUIElement::stringValue):
600         (WTR::AccessibilityUIElement::language):
601         (WTR::AccessibilityUIElement::helpText):
602         (WTR::AccessibilityUIElement::x):
603         (WTR::AccessibilityUIElement::y):
604         (WTR::AccessibilityUIElement::width):
605         (WTR::AccessibilityUIElement::height):
606         (WTR::AccessibilityUIElement::clickPointX):
607         (WTR::AccessibilityUIElement::clickPointY):
608         (WTR::AccessibilityUIElement::intValue):
609         (WTR::AccessibilityUIElement::minValue):
610         (WTR::AccessibilityUIElement::maxValue):
611         (WTR::AccessibilityUIElement::valueDescription):
612         (WTR::AccessibilityUIElement::insertionPointLineNumber):
613         (WTR::AccessibilityUIElement::isActionSupported):
614         (WTR::AccessibilityUIElement::isEnabled):
615         (WTR::AccessibilityUIElement::isRequired):
616         (WTR::AccessibilityUIElement::isFocused):
617         (WTR::AccessibilityUIElement::isSelected):
618         (WTR::AccessibilityUIElement::isExpanded):
619         (WTR::AccessibilityUIElement::isChecked):
620         (WTR::AccessibilityUIElement::hierarchicalLevel):
621         (WTR::AccessibilityUIElement::speak):
622         (WTR::AccessibilityUIElement::ariaIsGrabbed):
623         (WTR::AccessibilityUIElement::ariaDropEffects):
624         (WTR::AccessibilityUIElement::lineForIndex):
625         (WTR::AccessibilityUIElement::rangeForLine):
626         (WTR::AccessibilityUIElement::boundsForRange):
627         (WTR::AccessibilityUIElement::stringForRange):
628         (WTR::AccessibilityUIElement::attributedStringForRange):
629         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
630         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
631         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
632         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
633         (WTR::AccessibilityUIElement::attributesOfColumns):
634         (WTR::AccessibilityUIElement::attributesOfRows):
635         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
636         (WTR::AccessibilityUIElement::attributesOfHeader):
637         (WTR::AccessibilityUIElement::rowCount):
638         (WTR::AccessibilityUIElement::columnCount):
639         (WTR::AccessibilityUIElement::indexInTable):
640         (WTR::AccessibilityUIElement::rowIndexRange):
641         (WTR::AccessibilityUIElement::columnIndexRange):
642         (WTR::AccessibilityUIElement::cellForColumnAndRow):
643         (WTR::AccessibilityUIElement::horizontalScrollbar):
644         (WTR::AccessibilityUIElement::verticalScrollbar):
645         (WTR::AccessibilityUIElement::selectedTextRange):
646         (WTR::AccessibilityUIElement::setSelectedTextRange):
647         (WTR::AccessibilityUIElement::increment):
648         (WTR::AccessibilityUIElement::decrement):
649         (WTR::AccessibilityUIElement::showMenu):
650         (WTR::AccessibilityUIElement::press):
651         (WTR::AccessibilityUIElement::setSelectedChild):
652         (WTR::AccessibilityUIElement::accessibilityValue):
653         (WTR::AccessibilityUIElement::documentEncoding):
654         (WTR::AccessibilityUIElement::documentURI):
655         (WTR::AccessibilityUIElement::url):
656         (WTR::AccessibilityUIElement::addNotificationListener):
657         (WTR::AccessibilityUIElement::removeNotificationListener):
658         (WTR::AccessibilityUIElement::isFocusable):
659         (WTR::AccessibilityUIElement::isSelectable):
660         (WTR::AccessibilityUIElement::isMultiSelectable):
661         (WTR::AccessibilityUIElement::isVisible):
662         (WTR::AccessibilityUIElement::isOffScreen):
663         (WTR::AccessibilityUIElement::isCollapsed):
664         (WTR::AccessibilityUIElement::isIgnored):
665         (WTR::AccessibilityUIElement::hasPopup):
666         (WTR::AccessibilityUIElement::takeFocus):
667         (WTR::AccessibilityUIElement::takeSelection):
668         (WTR::AccessibilityUIElement::addSelection):
669         (WTR::AccessibilityUIElement::removeSelection):
670         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
671         (WTR::AccessibilityUIElement::textMarkerRangeLength):
672         (WTR::AccessibilityUIElement::previousTextMarker):
673         (WTR::AccessibilityUIElement::nextTextMarker):
674         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
675         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
676         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
677         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
678         (WTR::AccessibilityUIElement::textMarkerForPoint):
679         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
680         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
681         (WTR::LayoutTestController::platformName):
682         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
683         (WTR::LayoutTestController::platformName):
684         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
685         (WTR::LayoutTestController::platformName):
686         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
687         * WebKitTestRunner/win/InjectedBundle.vcproj:
688
689 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
690
691         [Qt] Fix use of config.tests
692
693         We were checking @buildArgs to determine if the optional argument was
694         passed or not, but this is not the right way to do that in Perl. The
695         right way is to not use a prototype for the function, and to pass
696         the list as a reference (to avoid list expansion). That way we can
697         check the number of arguments, and choose the right code path based
698         on that.
699
700         We were also missing a default-value of 0 for any feature that's not
701         set in features.prf.
702
703         Reviewed by Kenneth Rohde Christiansen.
704
705         * Scripts/build-webkit:
706         * Scripts/webkitdirs.pm:
707         (qtFeatureDefaults):
708         (buildQMakeProject):
709
710 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
711
712         [Qt] Prospective fix for broken plugin tests
713
714         Don't hide symbols for the NPAPI test plugin
715
716         Rubber-stamped by Andreas Kling.
717
718         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
719
720 2011-11-16  Adam Roben  <aroben@apple.com>
721
722         Move filenames/line numbers off to the right edge in Leaks Viewer
723
724         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
725         because filenames/line numbers are right next to function names
726
727         Reviewed by Andreas Kling.
728
729         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
730         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
731         function name. Use the filename as the profile node's URL (we don't have enough info to
732         compute a real URL currently) and the line number as the profile node's line number so the
733         Inspector code will put them on the right side of the callstack graph.
734
735         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
736         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
737         passed here, just filenames.
738
739         (WebInspector.linkifyURLAsNode):
740         (WebInspector.linkifyResourceAsNode):
741         Copied and slightly modified from inspector.js.
742
743 2011-11-16  Adam Roben  <aroben@apple.com>
744
745         Make Leaks Viewer load builds from the new Lion Leaks bot
746
747         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
748
749         Reviewed by Andreas Kling.
750
751         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
752         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
753         SnowLeopard one.
754
755 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
756
757         [EFL] Clean up the offline apps-related functions in ewk_settings.
758         https://bugs.webkit.org/show_bug.cgi?id=72132
759
760         Reviewed by Kenneth Rohde Christiansen.
761
762         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
763         prefixes for code that is related only to the HTML5 app cache
764         features.
765
766         Use `ewk_settings_application_cache' and
767         `ewk_view_setting_application_cache' instead.
768
769         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
770         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
771
772 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
773
774         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
775
776         Reviewed by Tor Arne Vestbø.
777
778         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
779         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
780         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
781         removes the .so.0.0.0 and just produces .so.
782
783 2011-11-16  Peter Beverloo  <peter@chromium.org>
784
785         Explicitly include unistd.h in TestNetscapePlugIn
786         https://bugs.webkit.org/show_bug.cgi?id=72385
787
788         This is needed for the sleep() call in the indicateTestFailure method,
789         which seems to be implicitly available for other platforms. This is not
790         the case on Android.
791
792         Reviewed by Steve Block.
793
794         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
795
796 2011-11-16  Peter Beverloo  <peter@chromium.org>
797
798         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
799         https://bugs.webkit.org/show_bug.cgi?id=72384
800
801         Update to Android NDK r7, which was released last Friday. This adds
802         support for RTTI and the -mimplicit-it gcc flag, which are required to
803         respectively build ICU and Skia.
804
805         Reviewed by Steve Block.
806
807         * Scripts/update-webkit-chromium:
808         * Scripts/webkitdirs.pm:
809         (buildChromiumMakefile):
810
811 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
812
813         Unreviewed, rolling out r100266.
814         http://trac.webkit.org/changeset/100266
815
816         Broke WTR.
817
818         * qmake/mkspecs/features/default_post.prf:
819
820 2011-11-16  Eric Seidel  <eric@webkit.org>
821
822         check-webkit-style broken by r99773: "Could not determine the port"
823         https://bugs.webkit.org/show_bug.cgi?id=72275
824
825         Reviewed by Adam Barth.
826
827         I will continue engaging hacks, until windows improves.
828
829         * Scripts/webkitpy/common/host.py:
830          - Host uses self.executive instead of self._executive like Port does.
831          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
832
833 2011-11-16  Eric Seidel  <eric@webkit.org>
834
835         check-webkit-style broken by r99773: "Could not determine the port"
836         https://bugs.webkit.org/show_bug.cgi?id=72275
837
838         Reviewed by Adam Barth.
839
840         Engage windows hacks harder.
841
842         This is a speculative fix for ChromiumWin.  We're now
843         creating an SCM object much earlier, so we need to
844         engage our "awesome" windows hacks earlier.
845
846         * Scripts/webkitpy/common/host.py:
847         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
848
849 2011-11-15  Darin Adler  <darin@apple.com>
850
851         DRT's uiElementAttributeValueCallback function is leaky
852         https://bugs.webkit.org/show_bug.cgi?id=72453
853
854         Reviewed by Dan Bernstein.
855
856         * DumpRenderTree/AccessibilityUIElement.cpp:
857         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
858
859 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
860
861         Implement edit-distance based reviewer recognition algorithm
862         https://bugs.webkit.org/show_bug.cgi?id=72351
863
864         Reviewed by Eric Seidel.
865
866         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
867         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
868         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
869         "build fix" to a reviewer's name (e.g. with with edit distance 9).
870
871         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
872         the edit distance is implemented in edit_distance.py.
873
874         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
875         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
876
877         * Scripts/webkitpy/common/checkout/changelog.py:
878         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
879         * Scripts/webkitpy/common/config/committers.py:
880         * Scripts/webkitpy/common/config/committers_unittest.py:
881         * Scripts/webkitpy/common/editdistance.py: Added.
882         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
883         * Scripts/webkitpy/tool/steps/validatereviewer.py:
884         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
885
886 2011-11-15  Tony Chang  <tony@chromium.org>
887
888         Skip a failing webkitpy test on cygwin.
889
890         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
891
892 2011-11-15  Sam Weinig  <sam@webkit.org>
893
894         TestWebKitAPI should not put its resources in the root products directory
895         https://bugs.webkit.org/show_bug.cgi?id=72446
896
897         Reviewed by Anders Carlsson.
898
899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
900         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
901         directory.
902
903         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
904         (TEST_F):
905         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
908         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
909         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
910         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
911         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
912         (TestWebKitAPI::Util::createURLForResource):
913         Update calls to retrieve files from the bundle to look in the newly
914         created subdirectory.
915
916 2011-11-15  Tony Chang  <tony@chromium.org>
917
918         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
919
920         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
921
922 2011-11-15  Tony Chang  <tony@chromium.org>
923
924         Unreviewed, fix test-webkitpy tests.  Move the check for image results
925         earlier.
926
927         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
928         * Scripts/webkitpy/layout_tests/port/webkit.py:
929
930 2011-11-15  James Robinson  <jamesr@chromium.org>
931
932         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
933         https://bugs.webkit.org/show_bug.cgi?id=72444
934
935         Reviewed by Adam Barth.
936
937         * DumpRenderTree/chromium/DumpRenderTree.cpp:
938
939 2011-11-15  Tony Chang  <tony@chromium.org>
940
941         Unreviewed, better fix for ref tests failures on SL Intel bot.
942         Revert the previous change and return None if pixel results from
943         either the test page or the expected page is missing.
944
945         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
946         * Scripts/webkitpy/layout_tests/port/webkit.py:
947
948 2011-11-15  James Robinson  <jamesr@chromium.org>
949
950         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
951         https://bugs.webkit.org/show_bug.cgi?id=72402
952
953         Reviewed by Dirk Pranke.
954
955         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
956         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
957         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
958         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
959         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
960         compositing enabled.
961
962         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
963         patch should not impact any tests.
964
965         * DumpRenderTree/chromium/DumpRenderTree.cpp:
966         (main):
967         * DumpRenderTree/chromium/TestShell.cpp:
968         (TestShell::TestShell):
969         (TestShell::resetWebSettings):
970         * DumpRenderTree/chromium/TestShell.h:
971         (TestShell::setAcceleratedCompositingForVideoEnabled):
972         * DumpRenderTree/chromium/WebPreferences.cpp:
973         (WebPreferences::reset):
974         (WebPreferences::applyTo):
975         * DumpRenderTree/chromium/WebPreferences.h:
976         * Scripts/webkitpy/layout_tests/port/chromium.py:
977         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
978         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
979
980 2011-11-15  Tony Chang  <tony@chromium.org>
981
982         Unreviewed, try to fix ref tests failures on SL Intel bot.
983         It looks like ImageDiff isn't returning an image diff.
984
985         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
986
987 2011-11-15  Tony Chang  <tony@chromium.org>
988
989         Unreviewed fix of ref-tests on GTK+.
990         If a driver is never started, _xvfb_process is never set.
991
992         * Scripts/webkitpy/layout_tests/port/gtk.py:
993
994 2011-11-14  Tony Chang  <tony@chromium.org>
995
996         [NRWT] Reftests should run even when pixel tests are disabled.
997         https://bugs.webkit.org/show_bug.cgi?id=60605
998
999         Reviewed by Dirk Pranke.
1000
1001         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1002             Also add an assert to make sure we get image hashes back when running ref tests.
1003         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1004         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1005         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1006         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1007             of starting a pixel driver if needed.  It handles the logic of sending the test
1008             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1009         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1010         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1011         * Scripts/webkitpy/layout_tests/port/webkit.py:
1012         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1013         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1014
1015 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1016
1017         Don't use File::Slurp for run-leaks unit tests
1018         <http://webkit.org/b/72356>
1019
1020         Reviewed by Daniel Bates.
1021
1022         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1023         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1024         Extracted common package logic into RunLeaks.pm.  Fixed call to
1025         RunLeaks::parseLeaksOutput().
1026         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1027         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1028
1029 2011-11-15  Peter Kasting  <pkasting@google.com>
1030
1031         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1032         https://bugs.webkit.org/show_bug.cgi?id=72349
1033
1034         Reviewed by Adam Roben.
1035
1036         * Scripts/VCSUtils.pm:
1037         (isSVNDirectory):
1038
1039 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1040
1041         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1042
1043         Reviewed by Tor Arne Vestbø.
1044
1045         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1046         magic here where we handle all TEMPLATE = lib .pro files.
1047
1048 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1049
1050         [Qt] Unreviewed prospective --minimal build fix.
1051
1052         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1053         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1054
1055 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1056
1057         [Qt] Unreviewed --minimal build fix.
1058
1059         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1060         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1061         to make moc's preprocessor abort.
1062
1063 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1064
1065         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1066         https://bugs.webkit.org/show_bug.cgi?id=72156
1067
1068         Reviewed by Daniel Bates.
1069
1070         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1071         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1072
1073         * Scripts/build-webkit:
1074         * Scripts/webkitdirs.pm:
1075         (generateBuildSystemFromCMakeProject):
1076
1077 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1078
1079         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1080         https://bugs.webkit.org/show_bug.cgi?id=72340
1081
1082         Reviewed by Eric Seidel.
1083
1084         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1085         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1086
1087         * Scripts/webkitpy/common/checkout/changelog.py:
1088         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1089
1090 2011-11-14  Eric Seidel  <eric@webkit.org>
1091
1092         check-webkit-style broken by r99773: "Could not determine the port"
1093         https://bugs.webkit.org/show_bug.cgi?id=72275
1094
1095         Reviewed by Adam Barth.
1096
1097         The TestExpectationsChecker was using a generic try/except block
1098         which caught all exceptions, so we didn't notice that failing
1099         to pass a Host to PortFactory was causing an exception in port instantiation.
1100         I've factored out the "lookup the port" logic into a separate function
1101         which I've now unittested.  This should fix the bug and prevent
1102         others like it from occuring the the future.
1103
1104         * Scripts/webkitpy/style/checkers/test_expectations.py:
1105         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1106
1107 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1108
1109         Add --css-grid-layout to build-webkit and the build systems
1110         https://bugs.webkit.org/show_bug.cgi?id=72320
1111
1112         Reviewed by Ojan Vafai.
1113
1114         * Scripts/build-webkit:
1115         Added the option.
1116
1117 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1118
1119         Unreviewed, rolling out r100192.
1120         http://trac.webkit.org/changeset/100192
1121         https://bugs.webkit.org/show_bug.cgi?id=72328
1122
1123         Caused infinite tests to fail (Requested by abarth on
1124         #webkit).
1125
1126         * Scripts/webkitpy/layout_tests/port/base.py:
1127         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1128
1129 2011-11-14  Tony Chang  <tony@chromium.org>
1130
1131         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1132         https://bugs.webkit.org/show_bug.cgi?id=72196
1133
1134         Reviewed by Ojan Vafai.
1135
1136         * Scripts/build-webkit:
1137
1138 2011-11-14  John Yani  <vanuan@gmail.com>
1139
1140         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1141         Override LOCALE to en_US.
1142
1143         Reviewed by Eric Seidel.
1144
1145         * Scripts/webkitpy/layout_tests/port/base.py:
1146
1147 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1148
1149         [Chromium] build-webkit silently drops the features flags
1150         https://bugs.webkit.org/show_bug.cgi?id=72293
1151
1152         Reviewed by Tony Chang.
1153
1154         Chromium still ignores @features but now we give a warning!
1155
1156         * Scripts/build-webkit: Check if one of the features is different
1157         from the default and print a warning in this case.
1158
1159 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1160
1161         run-leaks does not work on Lion?
1162         <http://webkit.org/b/71059>
1163         <rdar://problem/10428527>
1164
1165         Reviewed by Adam Roben.
1166
1167         The output of leaks(1) changed again in Lion to move the
1168         "leaks Report Version: 2.0" line from the first line of the
1169         output to just above the "Process " lines that run-leaks is
1170         interested in parsing.  This required using a more generic
1171         algorithm to find the start of the "Process " lines.
1172
1173         * Scripts/run-leaks:
1174         (parseLeaksOutput): Make the code to skip headers more generic.
1175         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1176         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1177         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1178
1179 2011-11-14  Lei Zhang  <thestig@chromium.org>
1180
1181         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1182         https://bugs.webkit.org/show_bug.cgi?id=72088
1183
1184         Reviewed by Tony Chang.
1185
1186         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1187
1188 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1189
1190         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1191         https://bugs.webkit.org/show_bug.cgi?id=72147
1192
1193         Reviewed by Adam Barth.
1194
1195         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1196
1197 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1198
1199         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1200
1201         Reviewed by Simon Hausmann.
1202
1203         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1204
1205 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1206
1207         [Qt] Disable plugins on X11 for WK2
1208
1209         Reviewed by Kenneth Rohde Christiansen.
1210
1211         Currently plugins are in-process and they crash in the likely case of
1212         a plugin installation that uses Qt 4, which beautifully clashes with the
1213         Qt 5 based QtWebProcess.
1214
1215         * qmake/mkspecs/features/features.prf:
1216
1217 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1218
1219         [Qt] Add support for config tests for Qt 5
1220
1221         This allows us to build and run configure-tests at build
1222         time to determine if a given platform feature is available.
1223
1224         Reviewed by Simon Hausmann.
1225
1226         * Scripts/build-webkit:
1227         * Scripts/webkitdirs.pm:
1228         (qtFeatureDefaults):
1229         * qmake/configure.pro: Added.
1230         * qmake/mkspecs/features/features.prf:
1231         * qmake/sync.profile: Added.
1232
1233 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1234
1235         [Qt] Remove the QStyle dependency in Qt's mobile theme
1236         https://bugs.webkit.org/show_bug.cgi?id=67773
1237
1238         This refactoring splits up RenderThemeQt with two
1239         subclasses, a QStyle-backed one, and a Mobile version
1240         that uses the old mobile theme for now.
1241
1242         QStyle availability is detected at compile time, and
1243         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1244         environment variable.
1245
1246         Reviewed by Simon Hausmann.
1247
1248         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1249         (WTR::activateFonts):
1250         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1251         based on availability of QtWidgets.
1252         * qmake/mkspecs/features/webcore.prf: cleanup.
1253
1254 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1255
1256         Unreviewed, rolling out r100116.
1257         http://trac.webkit.org/changeset/100116
1258
1259         r100104 was rolled out, so no longer needed
1260
1261         * Scripts/run-bindings-tests:
1262
1263 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1264
1265         Unreviewed, rolling out r100104.
1266         http://trac.webkit.org/changeset/100104
1267         https://bugs.webkit.org/show_bug.cgi?id=72247
1268
1269         broke windows builds
1270
1271         * Scripts/check-webkit-style:
1272         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1273         * Scripts/webkitpy/common/checkout/deps.py:
1274         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1275         * Scripts/webkitpy/common/checkout/scm/detection.py:
1276         * Scripts/webkitpy/common/checkout/scm/git.py:
1277         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1278         * Scripts/webkitpy/common/checkout/scm/svn.py:
1279         * Scripts/webkitpy/common/host.py:
1280         * Scripts/webkitpy/common/host_mock.py:
1281         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1282         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1283         * Scripts/webkitpy/layout_tests/port/base.py:
1284         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1285         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1286         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1287         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1288
1289 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1290
1291         Unreviewed, build fix after r100104. run-binding-tests broke.
1292
1293         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1294
1295 2011-11-13  Eric Seidel  <eric@webkit.org>
1296
1297         Add SCMDetector object to make scm detection mockable
1298         https://bugs.webkit.org/show_bug.cgi?id=72247
1299
1300         Reviewed by Adam Barth.
1301
1302         I think SCM detection may eventually be rolled into Checkout,
1303         but this patch at least makes it possible to mock code-paths
1304         which rely on scm detection.
1305         In the process of replacing callers of these free-functions
1306         I found that one of the functions was no longer used,
1307         and that one of the callers could instead just use the SCM
1308         object it already had access to through port.host.scm().
1309         I also discovered that I was not calling Host._initialize_scm()
1310         and thus host.scm() was always returning None!
1311
1312         * Scripts/check-webkit-style:
1313         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1314         * Scripts/webkitpy/common/checkout/deps.py:
1315         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1316         * Scripts/webkitpy/common/checkout/scm/detection.py:
1317         * Scripts/webkitpy/common/checkout/scm/git.py:
1318         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1319         * Scripts/webkitpy/common/checkout/scm/svn.py:
1320         * Scripts/webkitpy/common/host.py:
1321         * Scripts/webkitpy/common/host_mock.py:
1322         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1323         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1324         * Scripts/webkitpy/layout_tests/port/base.py:
1325         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1326         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1327         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1328         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1329
1330 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1331
1332         command line control of webcore log channels in chromium DumpRenderTree
1333         https://bugs.webkit.org/show_bug.cgi?id=72126
1334         
1335         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1336         what chromium takes.
1337
1338         Reviewed by Kent Tamura.
1339
1340         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1341         (main):
1342
1343 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1344
1345         [Qt] Fix minor config typo in the build tool documentation
1346         https://bugs.webkit.org/show_bug.cgi?id=72194
1347
1348         Reviewed by Andreas Kling.
1349
1350         * qmake/README:
1351
1352 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1353
1354         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1355         https://bugs.webkit.org/show_bug.cgi?id=49257
1356
1357         Adds the remaining missing layout test functionality for printing.
1358
1359         Reviewed by Darin Fisher.
1360
1361         * DumpRenderTree/chromium/LayoutTestController.cpp:
1362         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1363         (parsePageNumber): Method to parse JS arguments for a page number
1364         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1365         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1366         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1367         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1368         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1369
1370 2011-11-11  Darin Adler  <darin@apple.com>
1371
1372         Remove all releaseRef implementations except for RetainPtr
1373         https://bugs.webkit.org/show_bug.cgi?id=71423
1374
1375         Reviewed by Julien Chaffraix.
1376
1377         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1378         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1379
1380 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1381
1382         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1383         https://bugs.webkit.org/show_bug.cgi?id=72090
1384
1385         Reviewed by Eric Seidel.
1386
1387         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1388         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1389
1390         yay! r100002.
1391
1392         * Scripts/webkitpy/common/checkout/changelog.py:
1393         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1394
1395 2011-11-11  Tony Chang  <tony@chromium.org>
1396
1397         Remove --force from gclient sync.  The bots seem to have made it past
1398         the update step.
1399
1400         * Scripts/update-webkit:
1401
1402 2011-11-11  Tony Chang  <tony@chromium.org>
1403
1404         Add --force to gclient sync. Once the cq bots cycle, we can remove
1405         this since it slows down the normal sync.
1406
1407         * Scripts/update-webkit:
1408
1409 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1410
1411         When --force is used, also use --reset
1412         https://bugs.webkit.org/show_bug.cgi?id=72129
1413
1414         Reviewed by Dimitri Glazkov.
1415
1416         * Scripts/update-webkit-chromium:
1417
1418 2011-11-11  Tony Chang  <tony@chromium.org>
1419
1420         allow two chromium drivers to run at the same time in NRWT
1421         https://bugs.webkit.org/show_bug.cgi?id=72067
1422
1423         Reviewed by Dirk Pranke.
1424
1425         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1426             posix prevents the subprocesses from sharing the same fd for stdin.
1427             Sharing the same fd prevents us from closing the files unless all references
1428             to the fd are closed.
1429         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1430             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1431             the timeout override. It looks like it regressed in r95875.
1432
1433 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1434
1435         Unreviewed, rolling out r99964.
1436         http://trac.webkit.org/changeset/99964
1437         https://bugs.webkit.org/show_bug.cgi?id=72124
1438
1439         Broke too many Qt tests (Requested by tronical_ on #webkit).
1440
1441         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1442         (WTR::activateFonts):
1443         * qmake/mkspecs/features/features.prf:
1444         * qmake/mkspecs/features/webcore.prf:
1445
1446 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1447
1448         [Qt] Remove the QStyle dependency in Qt's mobile theme
1449         https://bugs.webkit.org/show_bug.cgi?id=67773
1450
1451         This refactoring splits up RenderThemeQt with two
1452         subclasses, a QStyle-backed one, and a Mobile version
1453         that uses the old mobile theme for now.
1454
1455         QStyle availability is detected at compile time, and
1456         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1457         environment variable.
1458
1459         Reviewed by Simon Hausmann.
1460
1461         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1462         (WTR::activateFonts):
1463         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1464         based on availability of QtWidgets.
1465         * qmake/mkspecs/features/webcore.prf: cleanup.
1466
1467 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1468
1469         [Qt] Add missing include to PlatformWebViewQt
1470
1471         Reviewed by Simon Hausmann.
1472
1473         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1474
1475 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1476
1477         [Qt] Fix incremental builds on Windows after buildsystem refactor
1478
1479         The qmake rules to ensure that we run make on the derived sources
1480         before running qmake on the target were inside a unix-scope, which
1481         resulted in flakey builds on Windows.
1482
1483         We now generate a rule on all platforms that ensures that "make qmake"
1484         will always run make on the derived sources. In addition, on platforms
1485         that have GNU make (where "make incremental" does not run "make qmake",
1486         but only "make"), we add a similar rule that ensures that any time the
1487         target makefile is regenerated we first run qmake and make on the derived
1488         sources. This rule relies on GNU make's order-only-prerequisites to
1489         not trigger a qmake-run of the target every time we run make.
1490
1491         https://bugs.webkit.org/show_bug.cgi?id=71778
1492
1493         Reviewed by Simon Hausmann.
1494
1495         * qmake/mkspecs/features/functions.prf:
1496
1497 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1498
1499         [Qt][WK2] Remove QWebNavigationController
1500         https://bugs.webkit.org/show_bug.cgi?id=72113
1501
1502         Reviewed by Andreas Kling.
1503
1504         Adapt to the move of the QWebNavigationController functions/properties to
1505         QQuickWebView.
1506
1507         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1508         * MiniBrowser/qt/qml/BrowserWindow.qml:
1509
1510 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1511
1512         [Qt] Build system tweak
1513
1514         Reviewed by Tor Arne Vestbø.
1515
1516         Be a good qmake citizen, return true from our linkStaticLibrary
1517         "test" function.
1518
1519         * qmake/mkspecs/features/functions.prf:
1520
1521 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1522
1523         [Qt] Add support for QT += webkit-private
1524
1525         Reviewed by Tor Arne Vestbø.
1526
1527         * qmake/qt_webkit.pri: Declare private headers.
1528
1529 2011-11-11  Philippe Normand  <pnormand@igalia.com>
1530
1531         Unreviewed, build fix attempt after r99907. Since that revision
1532         GTK layout tests were not running at all...
1533
1534         * Scripts/webkitpy/layout_tests/port/gtk.py:
1535
1536 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
1537
1538         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
1539         https://bugs.webkit.org/show_bug.cgi?id=72001
1540
1541         Reviewed by Dirk Pranke.
1542
1543         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1544
1545 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
1546
1547         bencher script should support remote benchmarking
1548         https://bugs.webkit.org/show_bug.cgi?id=71618
1549
1550         Rubber-stamped by Geoff Garen.
1551         
1552         Added the following features:
1553         
1554         - Benchmark report tells you the hostname and machine model (according to
1555           'sysctl hw.model') of the machine you did the run on, and svn revision number
1556           (according to 'svn info') of the VMs you're testing.
1557         
1558         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
1559           acceptable, in addition to just host, in which case your username is used)
1560           and it automatically packages the build directories of the VMs you're testing,
1561           sends them to the remote machine along with your copy of the bencher script
1562           and all of the options you passed.  This pretty much seamlessly allows you
1563           to run a set of benchmarks on any machine that is sufficiently compatible with
1564           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
1565           must now include a tempPath setting that tells bencher where to put files
1566           when that machine is used as a slave in a remote benchmarking run.
1567           
1568         - Added yet another way of specifying which benchmarks to run. This was sort of
1569           necessary for --remote to work as expected. Previously, you either said what
1570           suites to exclude (for example --exclude-sunspider) or that you only wanted
1571           to run one suite to the exclusion of others (--sunspider-only). But it's
1572           often better to just be able to specify the list of suites you want. This is
1573           now supported. You can say, for example, --v8 --sunspider, which means, just
1574           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
1575           still supported.
1576
1577         * Scripts/bencher:
1578
1579 2011-11-10  Tony Chang  <tony@chromium.org>
1580
1581         Lazily start DRT instances in NRWT
1582         https://bugs.webkit.org/show_bug.cgi?id=72038
1583
1584         Reviewed by Eric Seidel.
1585
1586         Just a refactoring, no new tests.
1587
1588         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1589         * Scripts/webkitpy/layout_tests/port/chromium.py:
1590         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1591         * Scripts/webkitpy/layout_tests/port/test.py:
1592         * Scripts/webkitpy/layout_tests/port/webkit.py:
1593
1594 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
1595
1596         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
1597         https://bugs.webkit.org/show_bug.cgi?id=72057
1598
1599         Reviewed by Eric Seidel.
1600
1601         Make the regular expression more explicit.
1602
1603         * Scripts/webkitpy/common/checkout/changelog.py:
1604         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1605
1606 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
1607
1608         [Qt] X11 plugins need to be reworked for Qt5
1609         https://bugs.webkit.org/show_bug.cgi?id=70023
1610
1611         Reviewed by Simon Hausmann.
1612
1613         Rework our basic plugin support in a way that does
1614         not need a bridge between Qt and X. The solution is
1615         based on getting the content drawed by the plugin
1616         from the server as an image and creating a QImage
1617         from it.
1618
1619         * qmake/mkspecs/features/features.prf: Enable X11
1620         plugins if Qt is built with the xcb-xlib backend.
1621
1622 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
1623
1624         [Qt] Fix keyboard related layout tests after API refactoring
1625
1626         Reviewed by Tor Arne Vestbø.
1627
1628         Send key events to the handling page item, not the view.
1629
1630         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1631         (WTR::PlatformWebView::sendEvent):
1632         (WTR::PlatformWebView::postEvent):
1633
1634 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
1635
1636         [GTK] Make the ENABLE(FEATURE) macro work in DRT
1637         https://bugs.webkit.org/show_bug.cgi?id=71940
1638
1639         Reviewed by Philippe Normand.
1640
1641         * GNUmakefile.am:
1642         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
1643         ENABLE_* variables are part of the environment.
1644
1645 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
1646
1647         [Qt] Fix focus related layout tests after API refactoring
1648
1649         Reviewed by Tor Arne Vestbø.
1650
1651         Make sure the focus is set on the page now, not on the view
1652         (which doesn't actually handle the focus).
1653
1654         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1655         (WTR::WrapperWindow::WrapperWindow):
1656         (WTR::WrapperWindow::handleStatusChanged):
1657
1658 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
1659
1660         [Qt] Merge QTouchWebView and QDesktopWebView into one class
1661         https://bugs.webkit.org/show_bug.cgi?id=71355
1662
1663         Reviewed by Kenneth Rohde Christiansen.
1664
1665         Make MiniBrowser and WebKitTestRunner work again after the
1666         merge.
1667
1668         * MiniBrowser/qt/BrowserWindow.cpp:
1669         (BrowserWindow::BrowserWindow):
1670         (BrowserWindow::webView):
1671         * MiniBrowser/qt/MiniBrowser.pro:
1672         * MiniBrowser/qt/MiniBrowser.qrc:
1673         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1674         * MiniBrowser/qt/main.cpp:
1675         * MiniBrowser/qt/qml/BrowserWindow.qml:
1676         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
1677         * MiniBrowser/qt/qml/TouchView.qml: Removed.
1678         * WebKitTestRunner/PlatformWebView.h:
1679         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1680         (WTR::PlatformWebView::PlatformWebView):
1681
1682 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1683
1684         [Qt] Change semantics of the haveQt() function to match API promises
1685
1686         Having Qt 5 does not imply that we have Qt 4, from an API point of
1687         view, as a major version can in theory break BC/SC. Our minimum
1688         version of Qt 4 will always be the latest released version of Qt 4,
1689         so the only place we should use haveQt(4, x) is when checking for
1690         the minimum requirements.
1691
1692         Reviewed by Simon Hausmann.
1693
1694         * qmake/mkspecs/features/default_pre.prf:
1695         * qmake/mkspecs/features/features.prf:
1696         * qmake/mkspecs/features/functions.prf:
1697
1698 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
1699
1700         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
1701         https://bugs.webkit.org/show_bug.cgi?id=69411
1702
1703         Reviewed by Martin Robinson.
1704
1705         * WebKitTestRunner/EventSenderProxy.h:
1706         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1707         * WebKitTestRunner/TestController.cpp:
1708         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1709         use the EventSender instead of WebProcess Event Simulation.
1710         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1711         (WTR::WTREventQueueItem::WTREventQueueItem):
1712         (WTR::EventSenderProxy::EventSenderProxy):
1713         (WTR::getMouseButtonModifiers):
1714         (WTR::eventSenderButtonToGDKButton):
1715         (WTR::EventSenderProxy::createMouseButtonEvent):
1716         (WTR::EventSenderProxy::updateClickCountForButton):
1717         (WTR::EventSenderProxy::replaySavedEvents):
1718         (WTR::EventSenderProxy::sendOrQueueEvent):
1719         (WTR::webkitModifiersToGDKModifiers):
1720         (WTR::getGDKKeySymForKeyRef):
1721         (WTR::EventSenderProxy::keyDown):
1722         (WTR::EventSenderProxy::mouseDown):
1723         (WTR::EventSenderProxy::mouseUp):
1724         (WTR::EventSenderProxy::mouseMoveTo):
1725         (WTR::EventSenderProxy::mouseScrollBy):
1726         (WTR::EventSenderProxy::leapForward):
1727
1728 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
1729
1730         [Qt] Enable exports and constructor functions in static libs
1731
1732         Reviewed by Tor Arne Vestbø.
1733
1734         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
1735         mac/win32-msvc equivalents when linking static libraries into a shared
1736         library or executable.
1737
1738 2011-11-09  Hayato Ito  <hayato@chromium.org>
1739
1740         [NRWT] Make results.html aware of reference filename in reftests.
1741         https://bugs.webkit.org/show_bug.cgi?id=71574
1742
1743         Reviewed by Ryosuke Niwa.
1744
1745         If a reference filename is different from the default one, include that in result summary
1746         so results.html can link to the correct reference file.
1747
1748         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1749         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1750
1751 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
1752
1753         [wx] Unreviewed build fix. Update project files and
1754         add LTC stubs for new methods.
1755
1756         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1757         (LayoutTestController::addChromeInputField):
1758         (LayoutTestController::removeChromeInputField):
1759         (LayoutTestController::focusWebView):
1760         (LayoutTestController::setBackingScaleFactor):
1761         * waf/build/settings.py:
1762
1763 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
1764
1765         [wx] Unreviewed build fix. Support XCode 4 when building deps.
1766
1767         * wx/install-unix-extras:
1768
1769 2011-11-09  Eric Seidel  <eric@webkit.org>
1770
1771         Remove the concept of platform-dependent unittests
1772         https://bugs.webkit.org/show_bug.cgi?id=71963
1773
1774         Unreviewed.  Fix test-webkitpy on cygwin.
1775
1776         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1777
1778 2011-11-09  Dana Jansens  <danakj@chromium.org>
1779
1780         Add cc-bugs group to watch changes in chromium graphics
1781         https://bugs.webkit.org/show_bug.cgi?id=71690
1782
1783         Reviewed by David Levin.
1784
1785         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
1786         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
1787         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
1788         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
1789
1790 2011-11-09  Eric Seidel  <eric@webkit.org>
1791
1792         Remove more platform-dependent unittests
1793         https://bugs.webkit.org/show_bug.cgi?id=71971
1794
1795         Reviewed by Adam Barth.
1796
1797         Tests which only run on a couple platforms will break.
1798         All tests should run on all platforms where possible.
1799
1800         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1801         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1802         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1803         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1804
1805 2011-11-09  Ojan Vafai  <ojan@chromium.org>
1806
1807         Merge in results to the test results server even if build numbers conflict
1808         https://bugs.webkit.org/show_bug.cgi?id=71967
1809
1810         Reviewed by Tony Chang.
1811
1812         This was initially meant to be a sanity check that we don't
1813         enter duplicate runs, but it turns out that we can reasonably get
1814         in these situations when a builder is clobbered (e.g. the build
1815         numbers start over again from 0).
1816
1817         * TestResultServer/model/jsonresults.py:
1818         * TestResultServer/model/jsonresults_unittest.py:
1819
1820 2011-11-09  Eric Seidel  <eric@webkit.org>
1821
1822         Remove the concept of platform-dependent unittests
1823         https://bugs.webkit.org/show_bug.cgi?id=71963
1824
1825         Reviewed by Adam Barth.
1826
1827         These have been the source of never-ending sadness.
1828         We'd change behavior and forget to update results in
1829         some unittests because they were only run on certain platforms.
1830         This change removes a large source of these platform-dependent
1831         unittests, which was caused by the port_maker stuff.
1832
1833         It's possible that this change will break test-webkitpy
1834         on some platforms, but that will be a one-time cost.
1835         I will fix the breakage by removing the platform-dependantness
1836         of any such broken tests.
1837
1838         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1839         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1840         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1841         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1842         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1843         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1844         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1845         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1846         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1847         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1848         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1849         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1850         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1851
1852 2011-11-09  Eric Seidel  <eric@webkit.org>
1853
1854         Make the Port object have a Host
1855         https://bugs.webkit.org/show_bug.cgi?id=71961
1856
1857         Reviewed by Adam Barth.
1858
1859         This has been a long time coming.
1860         Now that Port has a Host object, it's very easy
1861         to write unittests which use a properly mocked Port.
1862         Soon we will remove the executive, filesystem and user
1863         members of Port and get everything through the Host.
1864
1865         Note how in many callsites we're actually removing
1866         explicit mocks, since we're now always going to get the
1867         correct Executive/User/FileSystem from the
1868         Host and callsites don't need to be careful to pass each one.
1869
1870         This is prep-work for adding a new Environment member to
1871         Host and needing to be able to access the Environment
1872         member from Port functions w/o needing to pass an Environment
1873         object (or appropriate Mock) every place we create a Port object.
1874         Now that we have a single Host object to reach out through, its
1875         simple to add additional functionality (like Environment) while
1876         keeping our unittests properly mocked.
1877
1878         * Scripts/webkitpy/common/host.py:
1879         * Scripts/webkitpy/common/net/credentials_unittest.py:
1880         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1881         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1882         * Scripts/webkitpy/layout_tests/port/apple.py:
1883         * Scripts/webkitpy/layout_tests/port/base.py:
1884         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1885         * Scripts/webkitpy/layout_tests/port/chromium.py:
1886         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1887         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1888         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1889         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1890         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1891         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1892         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1893         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1894         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1895         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1896         * Scripts/webkitpy/layout_tests/port/efl.py:
1897         * Scripts/webkitpy/layout_tests/port/factory.py:
1898         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1899         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1900         * Scripts/webkitpy/layout_tests/port/gtk.py:
1901         * Scripts/webkitpy/layout_tests/port/mac.py:
1902         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1903         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1904         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1905         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1906         * Scripts/webkitpy/layout_tests/port/qt.py:
1907         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1908         * Scripts/webkitpy/layout_tests/port/test.py:
1909         * Scripts/webkitpy/layout_tests/port/webkit.py:
1910         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1911         * Scripts/webkitpy/layout_tests/port/win.py:
1912         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1914         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1915         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1916         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1917
1918 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
1919
1920         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
1921         https://bugs.webkit.org/show_bug.cgi?id=71561
1922
1923         Reviewed by Dimitri Glazkov.
1924
1925         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1926         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
1927
1928 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
1929
1930         Implement dumpProgressFinishedCallback() for Mac layoutTestController
1931         https://bugs.webkit.org/show_bug.cgi?id=66772
1932
1933         Reviewed by Simon Fraser.
1934
1935         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
1936         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
1937
1938         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
1939         in the FrameLoadDelegate and print the output in response to the notification.
1940
1941         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1942         (-[FrameLoadDelegate init]):
1943         (-[FrameLoadDelegate dealloc]):
1944         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
1945
1946 2011-11-09  Philippe Normand  <pnormand@igalia.com>
1947
1948         [GTK][DRT] window internals object is not reset after each test
1949         https://bugs.webkit.org/show_bug.cgi?id=71890
1950
1951         Reviewed by Martin Robinson.
1952
1953         Call WebCoreTestSupport::resetInternalsObject without going
1954         through DumpRenderTreeSupport.
1955
1956         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1957         (runTest):
1958
1959 2011-11-09  Beth Dakin  <bdakin@apple.com>
1960
1961         Build fix.
1962
1963         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1964         (AccessibilityUIElement::uiElementAttributeValue):
1965
1966 2011-11-09  Beth Dakin  <bdakin@apple.com>
1967
1968         Speculative build fix.
1969
1970         * DumpRenderTree/AccessibilityUIElement.h:
1971
1972 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
1973
1974         Unreviewed build fix.
1975
1976         * DumpRenderTree/AccessibilityUIElement.cpp:
1977         (AccessibilityUIElement::makeJSAccessibilityUIElement):
1978         A bad merge added this check that is making the bots sad.
1979
1980 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
1981
1982         AX: crash when accessing selectedTab in a tab list
1983         https://bugs.webkit.org/show_bug.cgi?id=70938
1984
1985         Reviewed by Beth Dakin.
1986
1987         Add the ability to retrieve an element through an arbitrary attribute.
1988
1989         * DumpRenderTree/AccessibilityUIElement.cpp:
1990         (uiElementAttributeValueCallback):
1991         (AccessibilityUIElement::uiElementAttributeValue):
1992         (AccessibilityUIElement::getJSClass):
1993         * DumpRenderTree/AccessibilityUIElement.h:
1994         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1995         (AccessibilityUIElement::uiElementAttributeValue):
1996
1997 2011-11-09  Andy Wingo  <wingo@igalia.com>
1998
1999         Add webkitdirs.pm:getArchitecture implementation for GTK
2000         https://bugs.webkit.org/show_bug.cgi?id=71370
2001
2002         Reviewed by Xan Lopez.
2003
2004         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2005         implementation for ports using autotools, so that a vanilla
2006         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2007         to build-jsc on x86-64 machines.
2008
2009 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2010
2011         Unreviewed, rolling out r99707.
2012         http://trac.webkit.org/changeset/99707
2013
2014         Re-enable until we can disable it together with tests in one
2015         shot.
2016
2017         * qmake/mkspecs/features/features.prf:
2018
2019 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2020
2021         [Qt] Disable use of QtUiTools if the library/module is not found
2022
2023         We rely on the lookup order of prf files to inject our own uitools.prf
2024         that will verify that QtUiTools is in fact present before allowing the
2025         CONFIG += uitools to have any effect.
2026
2027         Reviewed by Simon Hausmann.
2028
2029         * DumpRenderTree/qt/DumpRenderTree.pro:
2030         * QtTestBrowser/QtTestBrowser.pro:
2031         * qmake/mkspecs/features/uitools.prf: Added.
2032
2033 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2034
2035         Unreviewed, rolling out r99701.
2036         http://trac.webkit.org/changeset/99701
2037
2038         Breaks Qt mac build
2039
2040         * qmake/mkspecs/features/functions.prf:
2041
2042 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2043
2044         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2045
2046         Reviewed by Tor Arne Vestbø.
2047
2048         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2049         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2050         is not up to the task of full XSLT support, so we should disable it.
2051
2052 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2053
2054         [Qt] Enable exports and constructor functions in static libs
2055
2056         Reviewed by Tor Arne Vestbø.
2057
2058         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2059         mac/win32-msvc equivalents when linking static libraries into a shared
2060         library or executable.
2061
2062 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2063
2064         [GTK][DRT] window internals object is not reset after each test
2065         https://bugs.webkit.org/show_bug.cgi?id=71890
2066
2067         Reviewed by Xan Lopez.
2068
2069         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2070         (runTest): reset the Internals object after each test.
2071
2072 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2073
2074         [Qt] Detect presence of QtUiTools and enable it only when available
2075
2076         The disable_uitools option was a workaround for missing detection.
2077
2078         Reviewed by Simon Hausmann.
2079
2080         * QtTestBrowser/QtTestBrowser.pro:
2081         * qmake/mkspecs/features/default_post.prf:
2082         * qmake/mkspecs/features/default_pre.prf:
2083
2084 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2085
2086         [Qt] Don't override config for the build_pass of debug_and_release
2087
2088         Qmake will parse the profile once for each configuration (debug and
2089         release), with the build_pass option set. In that situation we don't
2090         want to override what qmake is setting explicitly, otherwise the
2091         debug-step will end up hitting all the release-scopes.
2092
2093         Reviewed by Simon Hausmann.
2094
2095         * qmake/mkspecs/features/default_pre.prf:
2096
2097 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2098
2099         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2100
2101         * qmake/mkspecs/features/functions.prf:
2102
2103 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2104
2105         [Qt] Centralize duplicated code for linking the static libs
2106
2107         Reviewed by Tor Arne Vestbø.
2108
2109         * qmake/mkspecs/features/functions.prf:
2110         * qmake/mkspecs/features/javascriptcore.prf:
2111         * qmake/mkspecs/features/webcore.prf:
2112         * qmake/mkspecs/features/webkit2.prf:
2113
2114 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2115
2116         [Qt] Build system cleanup
2117         https://bugs.webkit.org/show_bug.cgi?id=71815
2118
2119         Reviewed by Kenneth Rohde Christiansen.
2120
2121         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2122         static library.
2123         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2124         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2125
2126 2011-11-08  Hayato Ito  <hayato@chromium.org>
2127
2128         [NRWT] Make single_test_runner aware of reference filename of test_input.
2129         https://bugs.webkit.org/show_bug.cgi?id=71567
2130
2131         Reviewed by Ryosuke Niwa.
2132
2133         Make single_test_runner honor a reference filename of given test_input so that
2134         we can use any file as reference html, instead of depending on implicit naming convention.
2135         The typical use case is to support w3c reftests.
2136
2137         No tests since no functional changes until there is a client.
2138         Test should be easily written with future clients.
2139
2140         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2141         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2142         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2143         * Scripts/webkitpy/layout_tests/models/test_input.py:
2144
2145 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2146
2147         https://bugs.webkit.org/show_bug.cgi?id=71839
2148         Update the leaks bot OS to Lion.
2149         Update the config.json to reflect the update.
2150
2151         Reviewed by Stephanie Lewis.
2152
2153         * BuildSlaveSupport/build.webkit.org-config/config.json:
2154
2155 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2156
2157         Unreviewed, rolling out r99626.
2158         http://trac.webkit.org/changeset/99626
2159         https://bugs.webkit.org/show_bug.cgi?id=71866
2160
2161         "C++ exceptions cannot be disabled without influencing the
2162         Objective-C exceptions" (Requested by benjaminp on #webkit).
2163
2164         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2165
2166 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2167
2168         [Mac] Disable C++ exceptions from DumpRenderTree
2169         https://bugs.webkit.org/show_bug.cgi?id=71834
2170
2171         Reviewed by Darin Adler.
2172
2173         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2174         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2175         which leads to crashes long after the exception was raised.
2176
2177         This patch disabled C++ exceptions in order to catch the problems where
2178         they happen when a C++ exception is raised.
2179
2180         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2181
2182 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2183
2184         Moved myself to the reviewer list (yay!).
2185
2186         * Scripts/webkitpy/common/config/committers.py:
2187
2188 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2189
2190         Added myself as a committer.
2191
2192         * Scripts/webkitpy/common/config/committers.py:
2193
2194 2011-11-08  Andy Wingo  <wingo@igalia.com>
2195
2196         Skip some ECMAScript tests that fail on Linux in some time zones.
2197         https://bugs.webkit.org/show_bug.cgi?id=71371
2198
2199         Reviewed by Martin Robinson.
2200
2201         * Scripts/run-javascriptcore-tests: Skip some more tests.
2202
2203 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2204
2205         [Qt] Unreviewed trivial fix after build system refactoring.
2206
2207         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2208
2209 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2210
2211         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2212
2213         If a pro file needs to access the OBJECTS_DIR it should use the
2214         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2215         after defaults_post has been processed.
2216
2217         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2218         the command line will override whatever we set in defaults_pre.
2219
2220         Reviewed by Simon Hausmann.
2221
2222         * qmake/mkspecs/features/default_post.prf:
2223         * qmake/mkspecs/features/default_pre.prf:
2224
2225 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2226
2227         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2228
2229         Reviewed by Simon Hausmann.
2230
2231         * qmake/mkspecs/features/default_post.prf:
2232
2233 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2234
2235         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2236         https://bugs.webkit.org/show_bug.cgi?id=71680
2237
2238         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2239         complete urls in MiniBrowser.
2240
2241         Reviewed by Tor Arne Vestbø.
2242
2243         * MiniBrowser/qt/BrowserWindow.cpp:
2244         (BrowserWindow::BrowserWindow):
2245         (BrowserWindow::load):
2246         * MiniBrowser/qt/qml/BrowserWindow.qml:
2247         * MiniBrowser/qt/utils.cpp:
2248         (Utils::urlFromUserInput):
2249         * MiniBrowser/qt/utils.h:
2250         (Utils::Utils):
2251
2252 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2253
2254         Added myself as a committer.
2255
2256         * Scripts/webkitpy/common/config/committers.py:
2257
2258 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2259
2260         Unreviewed webkitpy test fix after r99512.
2261
2262         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2263         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2264
2265 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2266
2267         Added myself as a committer.
2268
2269         * Scripts/webkitpy/common/config/committers.py:
2270
2271 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2272
2273         Unreviewed, rolling out r99470.
2274         http://trac.webkit.org/changeset/99470
2275         https://bugs.webkit.org/show_bug.cgi?id=71740
2276
2277         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2278
2279         * Scripts/webkitpy/common/config/watchlist:
2280
2281 2011-11-07  Tony Chang  <tony@chromium.org>
2282
2283         [chromium] update flakiness dashboard to reflect current bots
2284
2285         Reviewed by Ojan Vafai.
2286
2287         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2288             bots and merged linux debug bots into a single bot.
2289         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2290         (setupExpectationsTest):
2291
2292 2011-11-07  Dana Jansens  <danakj@chromium.org>
2293
2294         Add cc-bugs group to watch changes in chromium graphics
2295         https://bugs.webkit.org/show_bug.cgi?id=71690
2296
2297         Reviewed by James Robinson.
2298
2299         * Scripts/webkitpy/common/config/watchlist:
2300
2301 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2302
2303         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2304         https://bugs.webkit.org/show_bug.cgi?id=70912
2305
2306         Reviewed by Ojan Vafai.
2307
2308         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2309         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2310
2311 2011-11-07  Eric Seidel  <eric@webkit.org>
2312
2313         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2314         https://bugs.webkit.org/show_bug.cgi?id=62199
2315
2316         Reviewed by Dirk Pranke.
2317
2318         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2319         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2320         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2321
2322 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2323
2324         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2325         https://bugs.webkit.org/show_bug.cgi?id=71485
2326
2327         Reviewed by Darin Fisher.
2328
2329         * DumpRenderTree/chromium/EventSender.cpp:
2330         (EventSender::scalePageBy):
2331         * DumpRenderTree/chromium/TestShell.cpp:
2332         (TestShell::resetTestController):
2333
2334 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2335
2336         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2337
2338         Allows us to not package up the whole Source/JavaScriptCore directory for the
2339         buildbots.
2340
2341         Reviewed-by Simon Hausmann.
2342
2343         * BuildSlaveSupport/built-product-archive:
2344         * Scripts/webkitdirs.pm:
2345         (jscProductDir):
2346
2347 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2348
2349         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2350
2351         Reviewed-by Simon Hausmann.
2352
2353         * qmake/mkspecs/features/default_post.prf:
2354
2355 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2356
2357         [Qt] Sanitize qmake paths correctly before comparing
2358
2359         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2360         which caused us to always generate derived webcore sources, but never build
2361         them. The bug has been fixed, and we now also sanitize paths for the injected
2362         bundle derived sources.
2363
2364         Reviewed by Simon Hausmann.
2365
2366         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2367         * qmake/mkspecs/features/functions.prf:
2368
2369 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2370
2371         [Qt] Print right order for changing feature defines
2372
2373         Reviewed by Simon Hausmann.
2374
2375         * Scripts/webkitdirs.pm:
2376         (buildQMakeProject):
2377
2378 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2379
2380         [Qt] Unreviewed trivial fix after build system refactoring.
2381
2382         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2383
2384 2011-11-06  Eric Seidel  <eric@webkit.org>
2385
2386         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2387         https://bugs.webkit.org/show_bug.cgi?id=66078
2388
2389         Unreviewed.  Add an assert about the type of "args"
2390         to our Executive Mocks and fix a piece of code
2391         from this patch which was hitting that assert
2392         when executing for real.
2393
2394         * Scripts/webkitpy/common/system/executive_mock.py:
2395         * Scripts/webkitpy/layout_tests/port/webkit.py:
2396
2397 2011-11-06  Eric Seidel  <eric@webkit.org>
2398
2399         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2400         https://bugs.webkit.org/show_bug.cgi?id=71629
2401
2402         Reviewed by Adam Barth.
2403
2404         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2405
2406 2011-11-06  Eric Seidel  <eric@webkit.org>
2407
2408         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2409         https://bugs.webkit.org/show_bug.cgi?id=66078
2410
2411         Reviewed by Adam Barth.
2412
2413         The runtime feature detection was fixed to work in bug 64472.
2414         In this bug I moved the symbol-based feature detection from
2415         popen() to Executive.run_command and cleaned up the callers
2416         and unittests to make sure that we're correctly parsing the
2417         nm output correctly.  The old code happened to work even though
2418         the runtime-features path was using "str in list" and the
2419         symbol features path was using "str in str" and it just happened
2420         to do what we wanted to.  Now runtime features and symbol feature
2421         blacklists are computed separately (and with better documentation).
2422
2423         This system remains confusing, partially because these are black-lists
2424         which are amended to whatever static blacklist may exist for the
2425         port as part of a Skipped list file.
2426
2427         For example, notice how the runtime feature list only has directory
2428         blacklists for a couple features.  If all features are off,
2429         how do we skip enough tests with only 2 entries in the blacklist map?
2430         The answer is that Windows is the only port to use runtime feature
2431         detection, and the win/Skipped file turns off all the other features
2432         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2433         which use symbol-based feature detection turn of mathml, wcss, etc
2434         using the blacklists found in _missing_symbol_to_skipped_tests.
2435
2436         I also noticed a couple places where we still referenced xhtmlmp
2437         even though support for such has been removed from WebKit.  Removed those.
2438
2439         This should result in no functional change.
2440
2441         * Scripts/webkitpy/layout_tests/port/gtk.py:
2442          - Use self._filesystem instead of os.path
2443         * Scripts/webkitpy/layout_tests/port/webkit.py:
2444         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2445
2446 2011-11-06  Dan Bernstein  <mitz@apple.com>
2447
2448         Made show-pretty-diff work when the input path contains spaces.
2449
2450         Reviewed by Anders Carlsson.
2451
2452         * Scripts/show-pretty-diff:
2453
2454 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2455
2456         [chromium] Use the security origin instead of the URL when checking notification permissions
2457         https://bugs.webkit.org/show_bug.cgi?id=71590
2458
2459         Reviewed by Adam Barth.
2460
2461         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2462         (NotificationPresenter::checkPermission):
2463         * DumpRenderTree/chromium/NotificationPresenter.h:
2464
2465 2011-11-05  Darin Adler  <darin@apple.com>
2466
2467         Fix a small leak in Mac version of LayoutTestController
2468         https://bugs.webkit.org/show_bug.cgi?id=71615
2469
2470         Reviewed by Mark Rowe.
2471
2472         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2473         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
2474         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
2475
2476 2011-11-04  Eric Seidel  <eric@webkit.org>
2477
2478         Upgrade to the latest Mechanize
2479         https://bugs.webkit.org/show_bug.cgi?id=71594
2480
2481         Reviewed by Adam Barth.
2482
2483         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
2484         Mechanize is no longer two separate libraries, so importing it is much simpler.
2485
2486         * Scripts/webkitpy/thirdparty/__init__.py:
2487
2488 2011-11-04  Stephen Chenney  <schenney@chromium.org>
2489
2490         Crash in ScrollAnimator.cpp
2491         https://bugs.webkit.org/show_bug.cgi?id=69865
2492
2493         The code in ScrollAnimator assumes that horizontal per-page mouse
2494         wheel events cannot happen, which is not true. This patch adds layout
2495         tests for all paging wheel event situations and fixes the broken
2496         horizontal case.
2497
2498         Reviewed by Anders Carlsson
2499
2500         * DumpRenderTree/chromium/EventSender.cpp:
2501         (EventSender::handleMouseWheel): Added the ability to specify that a
2502         mouse wheel event should be paging.
2503
2504 2011-11-04  Eric Seidel  <eric@webkit.org>
2505
2506         Remove deprecated free functions in port.factory
2507         https://bugs.webkit.org/show_bug.cgi?id=71494
2508
2509         Unreviewed.  Fix exception when running new-run-webkit-httpd.
2510
2511         * Scripts/new-run-webkit-httpd:
2512
2513 2011-11-04  Adam Roben  <aroben@apple.com>
2514
2515         Remove Leopard-specific code from build.webkit.org
2516
2517         We don't have any Leopard bots anymore.
2518
2519         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
2520
2521         Reviewed by Mark Rowe.
2522
2523         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
2524         and StopATSServer steps.
2525         (unitTestsSupported): Removed check for mac-leopard.
2526         (TestFactory.__init__): Removed Leopard-specific steps.
2527
2528 2011-11-04  Eric Seidel  <eric@webkit.org>
2529
2530         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
2531         https://bugs.webkit.org/show_bug.cgi?id=71549
2532
2533         Reviewed by Adam Barth.
2534
2535         Several members of Host didn't really belong there
2536         and were instead specific to WebKitPatch, so I've moved
2537         them up onto that class.
2538
2539         * Scripts/webkitpy/common/host.py:
2540         * Scripts/webkitpy/common/host_mock.py:
2541         * Scripts/webkitpy/tool/main.py:
2542         * Scripts/webkitpy/tool/mocktool.py:
2543         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2544
2545 2011-11-04  Tony Chang  <tony@chromium.org>
2546
2547         garden-o-matic: bring back party time!
2548         https://bugs.webkit.org/show_bug.cgi?id=71582
2549
2550         Reviewed by Adam Barth.
2551
2552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
2553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
2554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
2555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
2556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
2558
2559 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
2560
2561         [EFL] DRT: Fix the order of the items in the dumped history list.
2562         https://bugs.webkit.org/show_bug.cgi?id=71562
2563
2564         It did not make much sense to hold the history list in a map, as we do not need
2565         the keys. And the printed items must be sorted by target, which is more easily
2566         done with a vector.
2567
2568         Should make tests such as http/tests/navigation/error404-frames.html pass.
2569
2570         Reviewed by Antonio Gomes.
2571
2572         * DumpRenderTree/efl/DumpHistoryItem.cpp:
2573         (compareHistoryItemsByTarget):
2574         (dumpHistoryItem):
2575
2576 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
2577
2578         [Qt] Remove ENABLE_SQLITE from qmake files
2579         https://bugs.webkit.org/show_bug.cgi?id=71546
2580
2581         Reviewed by Simon Hausmann.
2582
2583         * qmake/mkspecs/features/features.prf:
2584         * qmake/mkspecs/features/webcore.prf:
2585
2586 2011-11-04  Adam Barth  <abarth@webkit.org>
2587
2588         watchlist for WebIDL shouldn't trigger on Internals.idl
2589         https://bugs.webkit.org/show_bug.cgi?id=70657
2590
2591         Reviewed by David Levin.
2592
2593         Internals.idl isn't part of the Web-facing IDL in the project.
2594
2595         * Scripts/webkitpy/common/config/watchlist:
2596
2597 2011-11-04  Anders Carlsson  <andersca@apple.com>
2598
2599         Fix WKTR crash when running NPN_ConvertPoint test.
2600
2601         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
2602
2603         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
2604         (ConvertPoint::NPP_SetWindow):
2605
2606 2011-11-04  Anders Carlsson  <andersca@apple.com>
2607
2608         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
2609         https://bugs.webkit.org/show_bug.cgi?id=71570
2610
2611         Reviewed by Simon Fraser.
2612
2613         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2614         (PluginTest::NPP_SetWindow):
2615         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2616         Remove the NPP parameter from NPP_SetWindow.
2617
2618         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
2619         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
2620         Remove the NPP parameter from NPP_SetWindow.
2621
2622         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
2623         (PassDifferentNPPStruct::NPP_SetWindow):
2624         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
2625
2626         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
2627         (ConvertPoint::NPP_SetWindow):
2628         Run the test from NPP_SetWindow and call notifyDone() when done.
2629
2630         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2631         (NPP_SetWindow):
2632         Remove unnecessary parameter.
2633
2634 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
2635
2636         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
2637
2638         Rubber-stamped by Tor Arne Vestbø.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
2641         changed slightly after the refactoring.
2642
2643 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2644
2645         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
2646
2647         Reviewed by Simon Hausmann.
2648
2649         * qmake/mkspecs/features/default_pre.prf:
2650
2651 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2652
2653         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
2654
2655         Reviewed by Simmon Hausmann.
2656
2657         * qmake/mkspecs/features/default_pre.prf:
2658
2659 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2660
2661         [Qt] Disable STDIN check before cleaning build dir
2662
2663         It didn't work on the bots.
2664
2665         Reviewed by Ossy.
2666
2667         * Scripts/webkitdirs.pm:
2668
2669 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2670
2671         [Qt] Don't build all of webkit when running build-jsc
2672
2673         In case the whole webkit project was built, but we then subsequently
2674         want to build only JSC, we need to run make in the proper subdirectory.
2675
2676         This also means the incremental target needs to be added to all
2677         makefiles.
2678
2679         Reviewed by Simmon Hausmann.
2680
2681         * Scripts/webkitdirs.pm:
2682         (buildQMakeProject):
2683         * qmake/mkspecs/features/default_post.prf:
2684
2685 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
2686
2687         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
2688
2689         Reviewed by Tor Arne Vestbø.
2690
2691         * Scripts/webkitdirs.pm:
2692         (jscProductDir): jsc path changed.
2693
2694 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2695
2696         [Qt] Error out early if trying to build against Qt < 4.8
2697
2698         Reviewed by Simon Hausmann.
2699
2700         * qmake/mkspecs/features/default_pre.prf:
2701
2702 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
2703
2704         Fix run-launcher for Qt and Gtk.
2705
2706         Rubber-stamped by Tor Arne Vestbø.
2707
2708         * Scripts/webkitdirs.pm:
2709         (isWK2): Re-add isWK2(), as it's used in run-launcher.
2710
2711 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2712
2713         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
2714
2715         Reviewed by Simon Hausmann.
2716
2717         * Scripts/build-webkit:
2718
2719 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2720
2721         [GTK] Use web view title as window title in MiniBrowser
2722         https://bugs.webkit.org/show_bug.cgi?id=71544
2723
2724         Reviewed by Philippe Normand.
2725
2726         * MiniBrowser/gtk/BrowserWindow.c:
2727         (webViewURIChanged): Removed extra space.
2728         (webViewTitleChanged): Set window title using
2729         webkit_web_view_get_title().
2730         (browser_window_init): Set initial default window title.
2731         (browserWindowConstructed): Connect to WebView notify::title
2732         signal.
2733
2734 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2735
2736         [Qt] Refactor and clean up the qmake build system
2737
2738         The qmake build system has accumulated a bit of cruft and redundancy
2739         over time. There's also a fairly tight coupling between how to build
2740         the various targets, and _what_ to build, making it harder to add new
2741         rules or sources. This patch aims to elevate these issues somewhat.
2742
2743         This is a short-list of the changes:
2744
2745           * The rules for how to build targets are now mostly contained as
2746             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
2747             allows us to do pre- and post-processing of each project file,
2748             which helps to clean up the actual project files.
2749
2750           * Derived sources are no longer generated as a separate make-step
2751             but is part of each target's project file as a subdir. Makefile
2752             rules are used to ensure that we run make on the derived sources
2753             before running qmake on the actual target makefile. This makes
2754             it easier to keep a proper dependency between derived sources
2755             and the target.
2756
2757           * We use GNU make and the compiler to generate dependencies on
2758             UNIX-based systems running Qt 5. This allows us to lessen the
2759             need to run qmake, which should reduce compile time.
2760
2761           * WebKit2 is now build by default if building with Qt 5. It can
2762             be disabled by passing --no-webkit2 to build-webkit.
2763
2764         The result of these changes are hopefully a cleaner and easier
2765         build system to modify, and faster build times due to no longer
2766         running qmake on every single build. It's also a first step
2767         towards possibly generating the list of sources using another
2768         build system.
2769
2770         https://bugs.webkit.org/show_bug.cgi?id=71222
2771
2772         Reviewed by Simon Hausmann.
2773
2774         * DerivedSources.pro: Removed.
2775         * DumpRenderTree/qt/DumpRenderTree.pro:
2776         * DumpRenderTree/qt/ImageDiff.pro:
2777         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2778         * MiniBrowser/qt/MiniBrowser.pro:
2779         * QtTestBrowser/QtTestBrowser.pro:
2780         * QtTestBrowser/launcherwindow.cpp:
2781         (LauncherWindow::initializeView):
2782         (LauncherWindow::createChrome):
2783         (LauncherWindow::screenshot):
2784         * QtTestBrowser/launcherwindow.h:
2785         (WindowOptions::WindowOptions):
2786         * Scripts/build-webkit:
2787         (unlinkZeroFiles):
2788         * Scripts/webkitdirs.pm:
2789         (qtFeatureDefaults):
2790         (promptUser):
2791         (buildQMakeProject):
2792         * Tools.pro:
2793         * WebKitTestRunner/DerivedSources.pri: Added.
2794         * WebKitTestRunner/DerivedSources.pro: Removed.
2795         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
2796         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
2797         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
2798         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
2799         * WebKitTestRunner/Target.pri: Added.
2800         * WebKitTestRunner/WebKitTestRunner.pro:
2801         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2802         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
2803         * qmake/README: Added.
2804         * qmake/mkspecs/features/default_post.prf: Added.
2805         * qmake/mkspecs/features/default_pre.prf: Added.
2806         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
2807         * qmake/mkspecs/features/functions.prf: Added.
2808         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
2809         * qmake/mkspecs/features/mac/default_post.prf: Added.
2810         * qmake/mkspecs/features/mac/default_pre.prf: Added.
2811         * qmake/mkspecs/features/minimal_qt.prf: Added.
2812         * qmake/mkspecs/features/qtwebkit.prf: Added.
2813         * qmake/mkspecs/features/rpath.prf: Added.
2814         * qmake/mkspecs/features/unix/default_post.prf: Added.
2815         * qmake/mkspecs/features/unix/default_pre.prf: Added.
2816         * qmake/mkspecs/features/valgrind.prf: Added.
2817         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
2818         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
2819         * qmake/mkspecs/features/win32/default_post.prf: Added.
2820         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
2821         * qmake/syncqt-4.8: Added.
2822         (showUsage):
2823         ():
2824         (copyFile):
2825         (symlinkFile):
2826
2827 2011-11-04  Eric Seidel  <eric@webkit.org>
2828
2829         Remove deprecated free functions in port.factory
2830         https://bugs.webkit.org/show_bug.cgi?id=71494
2831
2832         Unreviewed.  Fixing exception seen when running test-webkitpy.
2833
2834         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
2835         unittest, since that script is nearly ready to be deleted.  But I added
2836         it back at the last second and failed to run the tests. :(
2837         This fixes the exception the bots were seeing.
2838
2839         * Scripts/webkitpy/style/checkers/test_expectations.py:
2840         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2841         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2842
2843 2011-11-02  Xiaomei Ji  <xji@chromium.org>
2844
2845         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
2846         https://bugs.webkit.org/show_bug.cgi?id=71163
2847
2848         Reviewed by Ryosuke Niwa.
2849
2850         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
2851         (WebPreferences::applyTo):
2852
2853 2011-11-03  Eric Seidel  <eric@webkit.org>
2854
2855         Remove deprecated free functions in port.factory
2856         https://bugs.webkit.org/show_bug.cgi?id=71494
2857
2858         Reviewed by Adam Barth.
2859
2860         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
2861         free functions in factory.py.  To remove these required fixing all callsites
2862         to use MockHost, Host, or PortFactory where appropriate.  After this change
2863         we're only left with a handfull of places where we inappropraitely use a
2864         real Executive, FileSystem or User object during unittesting.
2865
2866         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2867          - These PortFactory overrides were from an earlier edition of my previous patch
2868            in the end, I removed MockPortFactory so all tests ended up with this same
2869            real PortFactory() with a MockHost.  This was simply redundent code.
2870         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2871          - Use MockHost to get a mocked-out PortFactory.
2872         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2873          - This code has no access to a Host object, so we just use a default PortFactory
2874            for now.  This will still incorrectly create real Executive/FileSystem objects
2875            durring unittesting, which is wrong. :(
2876         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2877          - Use a MockHost to get a mocked PortFactory.
2878         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2879          - Use a MockHost to get a mocked PortFactory.
2880         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2881          - ditto.
2882         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2883          - ditto.
2884         * Scripts/webkitpy/layout_tests/port/__init__.py:
2885          - factory.get no longer exists.  Yay!
2886         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2887          - Use a MockHost to get a mocked PortFactory.
2888            To do this efficiently, I created a helper function
2889            and combined all these (mostly redundant) tests into one test
2890            with several calls to the helper function.
2891         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2892          - Pass MockUser and MockExecutive in these port testing subclasses.
2893          - I also removed a bunch of unecessary uses of mocktool. namespacing.
2894         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2895          - Awesome windows hacks should only happen on win32.  Once we started
2896            using MockExecutives these 'svn help' commands started printing in
2897            other tests, which is how I found this bug.
2898         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2899          - DryRunPort has no Host, so just use a PortFactory() directly.
2900            This will do the wrong thing if we're unittesting the DryRun port
2901            but it's no worse than the existing code.
2902         * Scripts/webkitpy/layout_tests/port/factory.py:
2903          - Remove the free functions.
2904          - Fix argument overriding to be able to override None.
2905         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2906          - Use a mocked-out PortFactory during testing.
2907         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2908          - Pass MockExecutive and MockUser to these manual Port instantiations.
2909         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2910          - No access to a Host object here, so just using PortFactory directly.
2911            This is wrong, but no more wrong than the existing code was.
2912         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2913          - Use a MockHost to get a mocked out PortFactory.
2914         * Scripts/webkitpy/layout_tests/port/test.py:
2915          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
2916         * Scripts/webkitpy/layout_tests/port/win.py:
2917          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
2918            now that we're actually passing MockExecutive to most Port instantiations during testing.
2919         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2920          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
2921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2922          - Host is the future.
2923         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2924          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
2925            we don't need to pass MockUser explicitly, it does that automatically for us.
2926         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2927          - Use a MockHost to get a mocked out PortFactory.
2928         * Scripts/webkitpy/style/checkers/test_expectations.py:
2929          - We don't have access to a Host object, so using PortFactory() directly.
2930         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2931          - Remove unused variable.
2932         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2933          - Host isn't accessible here, so using PortFactory() directly, which
2934            although unfortunate is no worse than before.
2935         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2936          - Testing is much easier when you don't need to hack global state...
2937         * Scripts/webkitpy/tool/commands/expectations.py:
2938          - Use the port_factory on the tool.
2939         * Scripts/webkitpy/tool/commands/rebaseline.py:
2940          - ditto.
2941         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2942          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
2943            the arguments in the right order.  Fixing that made it use a MockFileSystem
2944            (like it had been trying to), which then required us to actually populate
2945            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
2946         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2947          - Get the port_factory from the tool.
2948         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2949          - Ditto.
2950         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2951          - Use a MockHost to get a mocked out Port object.
2952
2953 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
2954
2955         [EFL] DRT: Allow choosing which backing store to use.
2956         https://bugs.webkit.org/show_bug.cgi?id=70532
2957
2958         Reviewed by Antonio Gomes.
2959
2960         This change makes it possible to change the backing store used by DRT
2961         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
2962         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
2963
2964         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2965         (DumpRenderTreeChrome::createView):
2966         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2967         (shouldUseSingleBackingStore):
2968         (chooseAndInitializeAppropriateSmartClass):
2969         (drtViewAdd):
2970         * DumpRenderTree/efl/DumpRenderTreeView.h:
2971
2972 2011-11-02  Erik Arvidsson  <arv@chromium.org>
2973
2974         JS Test Harness: Remove more link tags
2975         https://bugs.webkit.org/show_bug.cgi?id=71339
2976
2977         Reviewed by Ojan Vafai.
2978
2979         * Scripts/make-new-script-test:
2980         (writeTestFile): Don't output <link>
2981
2982 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
2983
2984         Reviewed by Martin Robinson.
2985
2986         [GTK] arguments passed to build-jsc are not taken into account
2987         https://bugs.webkit.org/show_bug.cgi?id=58333
2988
2989         * Scripts/build-jsc:
2990
2991 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2992
2993         [GTK] Show url of history items in a status bar in MiniBrowser
2994         https://bugs.webkit.org/show_bug.cgi?id=71474
2995
2996         Reviewed by Martin Robinson.
2997
2998         * MiniBrowser/gtk/BrowserWindow.c:
2999         (browserWindowSetStatusText): Set status text and show/hide the
3000         status label.
3001         (resetStatusText): Reset status text when history menu is hidden.
3002         (browserWindowHistoryItemSelected): Show url of currently selected
3003         history item.
3004         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3005         menu to reset the status text.
3006         (browserWindowConstructed): Use GtkOverlay if available to show
3007         status text.
3008
3009 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3010
3011         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3012         https://bugs.webkit.org/show_bug.cgi?id=71466
3013
3014         Reviewed by Martin Robinson.
3015
3016         * MiniBrowser/gtk/BrowserWindow.c:
3017         (browserWindowHistoryItemActivated): Go to selected back formard
3018         list item using webkit_web_view_go_to_back_forward_list_item()
3019         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3020         given GList of WebKitBackForwardListItems.
3021         (browserWindowUpdateNavigationActions): Enable/disable back and
3022         forward buttons depending on whether it's possible to go
3023         back/forward. Create a menu for back and forward toolbar buttons.
3024         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3025         (browserWindowConstructed): Connect to WebKitBackForwardList
3026         changed signal.
3027
3028 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3029
3030         [Qt] Remove Maemo specific code paths
3031         https://bugs.webkit.org/show_bug.cgi?id=71476
3032
3033         Reviewed by Kenneth Rohde Christiansen.
3034
3035         * QtTestBrowser/launcherwindow.cpp:
3036         (LauncherWindow::~LauncherWindow):
3037         (LauncherWindow::init):
3038         (LauncherWindow::showLinkHover):
3039         (LauncherWindow::selectElements):
3040         (LauncherWindow::showFPS):
3041         (LauncherWindow::updateFPS):
3042         * QtTestBrowser/launcherwindow.h:
3043         (WindowOptions::WindowOptions):
3044         * QtTestBrowser/locationedit.cpp:
3045         * QtTestBrowser/locationedit.h:
3046
3047 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3048
3049         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3050         https://bugs.webkit.org/show_bug.cgi?id=71461
3051
3052         Reviewed by Martin Robinson.
3053
3054         * MiniBrowser/gtk/BrowserWindow.c:
3055         (resetEntryProgress): Reset the entry progress after a while when
3056         load has been completed.
3057         (webViewLoadProgressChanged): Update location entry progress.
3058         (browserWindowConstructed): Connect to WebView
3059         notify::estimated-load-progress signal.
3060
3061 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3062
3063         [GTK] Remove WebKit2 C API from MiniBrowser
3064         https://bugs.webkit.org/show_bug.cgi?id=71459
3065
3066         Reviewed by Martin Robinson.
3067
3068         Use the GTK+ API instead to add minimum functionality. The other
3069         features will be ported to GTK+ API in following patches.
3070
3071         * MiniBrowser/gtk/BrowserWindow.c:
3072         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3073         (goBackCallback): Use webkit_web_view_go_back().
3074         (goForwardCallback): Use webkit_web_view_go_forward().
3075         (webViewURIChanged): Update location entry with current uri using
3076         webkit_web_view_get_uri().
3077         (browserWindowFinalize):
3078         (browserWindowGetProperty):
3079         (browserWindowSetProperty):
3080         (browser_window_init):
3081         (browserWindowConstructed): Connect to notify::uri signal of
3082         WebView to be notified when the URI changes.
3083         (browser_window_class_init):
3084         (browser_window_new): Use WebKitWebView.
3085         (browser_window_get_view): Use WebKitWebView
3086         * MiniBrowser/gtk/BrowserWindow.h:
3087         * MiniBrowser/gtk/GNUmakefile.am:
3088         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3089         * MiniBrowser/gtk/main.c:
3090         (loadURI): Use webkit_web_view_new().
3091         (main):
3092
3093 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3094
3095         [Qt] Unable to start MiniBrowser after run-webkit-tests
3096         https://bugs.webkit.org/show_bug.cgi?id=71469
3097
3098         Reviewed by Csaba Osztrogonác.
3099
3100         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3101         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3102         line arguments.
3103
3104 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3105
3106         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3107         https://bugs.webkit.org/show_bug.cgi?id=71445
3108
3109         Reviewed by Martin Robinson.
3110
3111         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3112         (initializeFonts): set directoriesDescription only when needed.
3113         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3114         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3115         refactored the font files loading code to avoid copy/pastes, ease
3116         maintenance and future font directories additions.
3117
3118 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3119
3120         [GTK] Remove GtkLauncher2
3121         https://bugs.webkit.org/show_bug.cgi?id=71449
3122
3123         Reviewed by Martin Robinson.
3124
3125         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3126         made sense when we wanted to implement the exactly same wk1 API
3127         for wk2. Now the code would require an ifdef for most the api, so
3128         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3129         GTK+ API.
3130
3131         * GNUmakefile.am:
3132         * GtkLauncher/main.c:
3133         (notifyProgressCb):
3134         (closeWebViewCb):
3135         (createBrowser):
3136         (addWebSettingsGroupToContext):
3137         (main):
3138
3139 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3140
3141         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3142         https://bugs.webkit.org/show_bug.cgi?id=71359
3143
3144         Reviewed by Martin Robinson.
3145
3146         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3147         (initializeFonts): Add the new font path for Debian fonts and
3148         refactored the font files loading code to avoid copy/pastes, ease
3149         maintenance and future font directories additions.
3150
3151 2011-11-02  Eric Seidel  <eric@webkit.org>
3152
3153         Move Mocks into _mock files near their implementations
3154         https://bugs.webkit.org/show_bug.cgi?id=71425
3155
3156         Reviewed by Adam Barth.
3157
3158         This entire change is splitting mocktool.py into separate _mock.py files
3159         and placing them next to their real implementations.
3160
3161         I also deleted MockPortFactory (since it was wrong) and was just hiding
3162         the fact that the "skipped-ports" command was broken (and has been for a long time).
3163         So I made MockHost use a real PortFactory (passed a MockHost) and changed
3164         the skipped-ports implementation to use modern PortFactory methods.
3165
3166         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3167         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
3168         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3169         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3170         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
3171         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3172         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3173         * Scripts/webkitpy/common/host.py:
3174         * Scripts/webkitpy/common/host_mock.py: Added.
3175         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
3176         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3177         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
3178         * Scripts/webkitpy/common/net/credentials_unittest.py:
3179         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3180         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3181         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3182         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3183         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3184         * Scripts/webkitpy/common/system/executive.py:
3185         * Scripts/webkitpy/common/system/executive_mock.py:
3186         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3187         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3188         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3189         * Scripts/webkitpy/common/system/workspace_unittest.py:
3190         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3191         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3192         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3193         * Scripts/webkitpy/layout_tests/port/__init__.py:
3194         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3195         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3196         * Scripts/webkitpy/layout_tests/port/factory.py:
3197         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3198         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3199         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3200         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3201         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3202         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3203         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3204         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3205         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3206         * Scripts/webkitpy/test/main.py:
3207         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3208         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3209         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3210         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3211         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3212         * Scripts/webkitpy/tool/mocktool.py:
3213         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3214
3215 2011-11-02  Dan Bernstein  <mitz@apple.com>
3216
3217         Fixed the build and removed another copy to ColorBits.ttf.
3218
3219         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3220         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3221         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
3222
3223 2011-11-02  Dan Bernstein  <mitz@apple.com>
3224
3225         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
3226         https://bugs.webkit.org/show_bug.cgi?id=71424
3227
3228         Reviewed by Sam Weinig.
3229
3230         Removed the ColorBits font and the code to register it in the process
3231         running the tests. The font was only used by the aforementioned test,
3232         which is now being removed.
3233
3234         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
3235         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
3236         * DumpRenderTree/mac/DumpRenderTree.mm:
3237         (allowedFontFamilySet):
3238         (activateTestingFonts):
3239         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3240         (WTR::inititializeFontConfigSetting):
3241         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3242         (WTR::allowedFontFamilySet):
3243         (WTR::activateFonts):
3244
3245 2011-11-02  Dan Bernstein  <mitz@apple.com>
3246
3247         Fix an intermittent hang in RenderedImageFromDOMRange.
3248
3249         Reviewed by Anders Carlsson.
3250
3251         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3252         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
3253         immediately if there are no sources by passing a date in the distant past.
3254
3255 2011-11-02  Adam Roben  <aroben@apple.com>
3256
3257         Add git-add-reviewer
3258
3259         I've been using this script for a while to add reviewers to git commits in my local
3260         repository before pushing them to the Subversion repository. Basic usage is:
3261
3262         git-add-reviewer HEAD^ "Joe Schmoe"
3263         or
3264         git-add-reviewer -i trunk
3265
3266         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
3267         git commits
3268
3269         Reviewed by Sam Weinig.
3270
3271         * Scripts/git-add-reviewer: Added.
3272         (top level): Parse options, check that the working tree is clean, then run in either
3273         interactive or non-interactive mode as appropriate.
3274         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
3275         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
3276         editor exits, we check out the commit just before the earliest one we're modifying. Then
3277         for each commit, we check it out, update the reviewer, and amend the commit to contain the
3278         new reviewer. Finally, we update the branch that was originally checked out to point to the
3279         last amended commit.
3280         (nonInteractive): Check out the commit to modify, write the current commit message to the
3281         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
3282         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
3283         a usage message and exit.
3284         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
3285         and index are clean.
3286         (fail): Print out the specified error message, if any, and return false. This function is
3287         used as a return value in various error cases throughout the script.
3288         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
3289         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
3290         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
3291         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
3292
3293         (addReviewerToChangeLog):
3294         (addReviewerToCommitMessage):
3295         These just call through to addReviewerToFile.
3296
3297         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
3298         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
3299         temp file, then move the temp file over the original file and stage it for the next commit.
3300         (head): Returns the name of the currently-checked-out branch.
3301         (isAncestor): Returns true if the first commit is an ancestor of the second.
3302         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
3303         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
3304         (resetToCommit): Checks out the given commit, throwing away any local changes.
3305         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
3306         the specified file.
3307         (rebaseOntoHead): Rebases the specified branch onto HEAD.
3308         (checkout): Checks out the given commit.
3309         (getConfigValue): Reads the specified config variable from git-config.
3310
3311 2011-11-02  Dean Jackson  <dino@apple.com>
3312
3313         Add ENABLE_CSS_SHADERS flag
3314         https://bugs.webkit.org/show_bug.cgi?id=71394
3315
3316         Reviewed by Sam Weinig.
3317
3318         * Scripts/build-webkit:
3319
3320 2011-10-31  Eric Seidel  <eric@webkit.org>
3321
3322         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
3323         https://bugs.webkit.org/show_bug.cgi?id=71237
3324
3325         Reviewed by Adam Barth.
3326
3327         Calling the static version of factory.get() with proper mocking
3328         requires passsing an explict filesystem, executive, etc.
3329         So instead, we use a PortFactory instance and pass it a Host pointer.
3330         I had to add a MockHost since we'd not needed a non-host tool before now.
3331
3332         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3333         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3334         * Scripts/webkitpy/tool/commands/rebaseline.py:
3335         * Scripts/webkitpy/tool/mocktool.py:
3336
3337 2011-11-02  Anders Carlsson  <andersca@apple.com>
3338
3339         Update for the WebKit2 API fixage.
3340
3341         * MiniBrowser/mac/BrowserWindowController.m:
3342         (-[BrowserWindowController awakeFromNib]):
3343         * WebKitTestRunner/TestController.cpp:
3344         (WTR::TestController::initialize):
3345
3346 2011-11-02  Anders Carlsson  <andersca@apple.com>
3347
3348         Fix build.
3349
3350         Add new functions to the page loader client.
3351
3352         * MiniBrowser/mac/BrowserWindowController.m:
3353         (-[BrowserWindowController awakeFromNib]):
3354         * WebKitTestRunner/TestController.cpp:
3355         (WTR::TestController::initialize):
3356
3357 2011-11-02  Dan Bernstein  <mitz@apple.com>
3358
3359         <rdar://problem/10336700> Add API to get rendered text image without having to select it
3360         https://bugs.webkit.org/show_bug.cgi?id=71407
3361
3362         Reviewed by Simon Fraser.
3363
3364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3365         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
3366         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
3367         (TestWebKitAPI::TEST):
3368
3369 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
3370
3371         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
3372         https://bugs.webkit.org/show_bug.cgi?id=71351
3373
3374         Reviewed by Darin Adler.
3375
3376         Add the delimiter "/" at the end of the path instead of adding +1 when using
3377         the path.
3378
3379         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3380         (-[NSURL _drt_descriptionSuitableForTestResult]):
3381
3382 2011-11-02  Tom Sepez  <tsepez@chromium.org>
3383
3384         XSSAuditor is silent
3385         https://bugs.webkit.org/show_bug.cgi?id=70973
3386
3387         Reviewed by Adam Barth.
3388
3389         * DumpRenderTree/chromium/WebViewHost.cpp:
3390         (WebViewHost::didDetectXSS):
3391         * DumpRenderTree/chromium/WebViewHost.h:
3392         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3393         (-[FrameLoadDelegate webView:didDetectXSS:]):
3394         * MiniBrowser/mac/BrowserWindowController.m:
3395         (didDetectXSSForFrame):
3396         (-[BrowserWindowController awakeFromNib]):
3397         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3398         (WTR::InjectedBundlePage::InjectedBundlePage):
3399         (WTR::InjectedBundlePage::didDetectXSSForFrame):
3400         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3401
3402 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3403
3404         [Qt] REGRESSION: 5 editing tests fail
3405         https://bugs.webkit.org/show_bug.cgi?id=71117
3406
3407         Reviewed by Andreas Kling.
3408
3409         Make sure that the view is properly focused, in order to get the
3410         didBeginEditing DRT calls.
3411
3412         This requires activating the window (the call will result in a FocusIn
3413         event to the window as well as setting QGuiApplication::focusWindow())
3414         as well as enabling the focus on the view item. The signature of
3415         setFocus has changed to take a boolean.
3416
3417         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3418         (WTR::WrapperWindow::handleStatusChanged):
3419
3420 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
3421
3422         [chromium] Add per-script font preferences support in overridePreference
3423         https://bugs.webkit.org/show_bug.cgi?id=71110
3424
3425         This allows a layout test to do something like:
3426
3427         // Set standard font for Arabic to Ahem.
3428         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
3429
3430         This should make writing a layout test for per-script fonts easier.
3431
3432         This change only affects the Chromium DumpRenderTree, but the other
3433         platforms should probably also have a similar change eventually.
3434
3435         Reviewed by Tony Chang.
3436
3437         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
3438         font preferences to overridePreference
3439         (LayoutTestController::cppVariantToWebStringArray):
3440         (setFontMap):
3441         (LayoutTestController::overridePreference):
3442         * DumpRenderTree/chromium/LayoutTestController.h:
3443         * DumpRenderTree/chromium/WebPreferences.cpp:
3444         (setStandardFontFamilyWrapper):
3445         (setFixedFontFamilyWrapper):
3446         (setSerifFontFamilyWrapper):
3447         (setSansSerifFontFamilyWrapper):
3448         (setCursiveFontFamilyWrapper):
3449         (setFantasyFontFamilyWrapper):
3450         (applyFontMap):
3451         (WebPreferences::applyTo):
3452         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
3453         preference members
3454         (WebPreferences::UScriptCodeHashTraits::emptyValue):
3455         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
3456         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
3457
3458 2011-11-02  Elliot Poger  <epoger@google.com>
3459
3460         until use_skia=1 by default on mac, default port should be chromium-cg-mac
3461         https://bugs.webkit.org/show_bug.cgi?id=71312
3462
3463         Reviewed by Adam Barth.
3464
3465         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3466         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3467         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3468
3469 2011-11-02  Stephen Chenney  <schenney@chromium.org>
3470
3471         printing layout test failures after r98634
3472         https://bugs.webkit.org/show_bug.cgi?id=71080
3473
3474         Reviewed by Kent Tamura
3475
3476         * DumpRenderTree/chromium/WebViewHost.cpp:
3477         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
3478         matches that for Skia.
3479
3480 2011-11-01  Sam Weinig  <sam@webkit.org>
3481
3482         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
3483         https://bugs.webkit.org/show_bug.cgi?id=71346
3484
3485         Reviewed by Dan Bernstein.
3486
3487         * Scripts/webkit-tools-completion.sh:
3488         Add "-o default" which allows for completing files in addition to the word list.
3489
3490 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3491
3492         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
3493         https://bugs.webkit.org/show_bug.cgi?id=71310
3494
3495         Reviewed by Kenneth Rohde Christiansen.
3496
3497         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
3498         define works in EventSendingController.idl
3499         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
3500         handlers.
3501         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
3502         required by tests.
3503         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
3504         ui process.
3505         (WTR::EventSendingController::addTouchPoint):
3506         (WTR::EventSendingController::updateTouchPoint):
3507         (WTR::EventSendingController::setTouchModifier):
3508         (WTR::EventSendingController::touchStart):
3509         (WTR::EventSendingController::touchMove):
3510         (WTR::EventSendingController::touchEnd):
3511         (WTR::EventSendingController::clearTouchPoints):
3512         (WTR::EventSendingController::releaseTouchPoint):
3513         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3514         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
3515         defines.
3516         * WebKitTestRunner/TestController.cpp:
3517         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
3518         touch messages to the EventSenderProxy.
3519         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
3520         (WTR::EventSenderProxy::EventSenderProxy):
3521         (WTR::EventSenderProxy::addTouchPoint):
3522         (WTR::EventSenderProxy::updateTouchPoint):
3523         (WTR::EventSenderProxy::setTouchModifier):
3524         (WTR::EventSenderProxy::touchStart):
3525         (WTR::EventSenderProxy::touchMove):
3526         (WTR::EventSenderProxy::touchEnd):
3527         (WTR::EventSenderProxy::clearTouchPoints):
3528         (WTR::EventSenderProxy::releaseTouchPoint):
3529         (WTR::EventSenderProxy::sendTouchEvent):
3530         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
3531
3532 2011-11-01  Sam Weinig  <sam@webkit.org>
3533
3534         resolve-ChangeLogs --help should be faster.
3535
3536         Reviewed by Adam Roben.
3537
3538         * Scripts/resolve-ChangeLogs:
3539         (usageAndExit):
3540         Add a call to usageAndExit() before doing work to find unmerged changelogs
3541         if --help or something illegal is provided on the command line.
3542
3543 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
3544
3545         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
3546         https://bugs.webkit.org/show_bug.cgi?id=71342
3547
3548         Reviewed by Darin Adler.
3549
3550         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
3551         [NSString substringFromIndex:] with an index out of the string range.
3552
3553         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
3554         from the root of the disk.
3555         The problem was hidden because the exception are catched when calling the delegate.
3556
3557         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
3558         in a subdirectory of the main frame.
3559
3560         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3561         (-[NSURL _drt_descriptionSuitableForTestResult]):
3562
3563 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
3564
3565         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
3566         https://bugs.webkit.org/show_bug.cgi?id=71318
3567
3568         Reviewed by James Robinson.
3569         
3570         Fixed a typo for --enable-hardware-gpu flag.
3571
3572         * Scripts/webkitpy/layout_tests/port/chromium.py:
3573
3574 2011-11-01  Elliot Poger  <epoger@google.com>
3575
3576         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
3577         https://bugs.webkit.org/show_bug.cgi?id=71286
3578
3579         Reviewed by Stephen White.
3580
3581         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3582
3583 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
3584
3585         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
3586         https://bugs.webkit.org/show_bug.cgi?id=71299
3587
3588         Reviewed by Andreas Kling.
3589
3590         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
3591         build to enable WebCoreTestSupport::injectInternalsObject.
3592         (WTR::InjectedBundlePage::didClearWindowForFrame):
3593         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
3594
3595 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3596
3597         [Qt] Merge common desktop and touch view APIs under a base class.
3598         https://bugs.webkit.org/show_bug.cgi?id=71280
3599
3600         Reviewed by Andreas Kling.
3601
3602         Remove unneded forwarding logic for TouchWebView since those properties are
3603         now in the view just as the desktop web view.
3604
3605         * MiniBrowser/qt/qml/TouchView.qml:
3606
3607 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3608
3609         check-webkit-style: Allow names starting with "_q_".
3610         https://bugs.webkit.org/show_bug.cgi?id=70625
3611