1c268231b84b8f2c011ac384ae7995953cbfe98d
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2
3         Ensure that inspector disabled build works
4         https://bugs.webkit.org/show_bug.cgi?id=77604
5
6         Reviewed by Tor Arne Vestbø.
7
8         * qmake/mkspecs/features/features.prf:
9
10 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
11
12         [chromium] add support for --makeargs to the ninja-based build
13         https://bugs.webkit.org/show_bug.cgi?id=77688
14
15         Reviewed by Adam Barth.
16
17         * Scripts/webkitdirs.pm:
18         (buildChromiumNinja):
19
20 2012-02-02  Eric Seidel  <eric@webkit.org>
21
22         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
23         https://bugs.webkit.org/show_bug.cgi?id=75145
24
25         Reviewed by Dirk Pranke.
26
27         * Scripts/webkitpy/layout_tests/port/mac.py:
28         (MacPort.default_child_processes):
29         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
30         (test_operating_system):
31         (test_default_child_processes):
32
33 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
34
35        nrwt shouldn't blow up when there are errors in test_expectations.txt
36        https://bugs.webkit.org/show_bug.cgi?id=73603
37
38        Reviewed by Ojan Vafai.
39
40        This change removes the distinction between 'errors' and 'warnings'
41        in the test expectations parser. Now, any problem is a
42        'warning', and if we are linting the file, warnings become fatal (errors).
43
44         This will allow a normal run-webkit-tests run to proceed even if
45         there are bad lines.
46
47         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
48         (ParseError.__init__):
49         (ParseError.__str__):
50         (ParseError.__repr__):
51         (TestExpectationSerializer.to_string):
52         (TestExpectationParser._parse_modifiers):
53         (TestExpectationParser._parse_expectations):
54         (TestExpectationParser._check_modifiers_against_expectations):
55         (TestExpectationParser._tokenize):
56         (TestExpectationLine.__init__):
57         (TestExpectationLine.is_invalid):
58         (TestExpectationsModel.add_expectation_line):
59         (TestExpectationsModel._already_seen_better_match):
60         (TestExpectations.__init__):
61         (TestExpectations._report_warnings):
62         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
63         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
64         (assert_bad_expectations):
65         (test_parse_warning):
66         (test_overrides__duplicate):
67         (ExpectationSyntaxTests.test_missing_expectation):
68         (ExpectationSyntaxTests.test_missing_colon):
69         (ExpectationSyntaxTests.test_too_many_colons):
70         (ExpectationSyntaxTests.test_too_many_equals_signs):
71         (ExpectationSyntaxTests.test_unrecognized_expectation):
72         (SemanticTests.test_bug_format):
73         (SemanticTests.test_bad_bugid):
74         (SemanticTests.test_slow_and_timeout):
75         (test_ambiguous):
76         (test_more_modifiers):
77         (test_order_in_file):
78         (test_macro_overrides):
79         (RebaseliningTest.assertRemove):
80         (TestExpectationParserTests.test_tokenize_blank):
81         (TestExpectationParserTests.test_tokenize_missing_colon):
82         (TestExpectationParserTests.test_tokenize_extra_colon):
83         (TestExpectationParserTests.test_tokenize_empty_comment):
84         (TestExpectationParserTests.test_tokenize_comment):
85         (TestExpectationParserTests.test_tokenize_missing_equal):
86         (TestExpectationParserTests.test_tokenize_extra_equal):
87         (TestExpectationParserTests.test_tokenize_valid):
88         (TestExpectationParserTests.test_tokenize_valid_with_comment):
89         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
90         (TestExpectationSerializerTests.test_unparsed_to_string):
91         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
92         (lint):
93         * Scripts/webkitpy/style/checkers/test_expectations.py:
94         (TestExpectationsChecker.check_test_expectations):
95
96 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
97
98         Unreviewed, rolling out r106543.
99         http://trac.webkit.org/changeset/106543
100         https://bugs.webkit.org/show_bug.cgi?id=77671
101
102         Made tests less stable (Requested by rniwa on #webkit).
103
104         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
105         (PerfTestsRunner):
106         (PerfTestsRunner.__init__):
107         (PerfTestsRunner._run_tests_set):
108         (PerfTestsRunner._run_single_test):
109         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
110         (MainTest.TestDriver.run_test):
111         (run_test):
112
113 2012-02-02  Beth Dakin  <bdakin@apple.com>
114
115         https://bugs.webkit.org/show_bug.cgi?id=77664
116         Add API tests for didNewFirstVisuallyNonEmptyLayout
117
118         Reviewed by Darin Adler.
119
120         Two new tests.
121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
122         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
123         (TestWebKitAPI):
124         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
125         (TestWebKitAPI::setPageLoaderClient):
126         (TestWebKitAPI::TEST):
127         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
128         (TestWebKitAPI):
129         (TestWebKitAPI::didForceRepaint):
130         (TestWebKitAPI::didFinishLoadForFrame):
131         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
132         (TestWebKitAPI::setPageLoaderClient):
133         (TestWebKitAPI::TEST):
134         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
135         (TestWebKitAPI):
136         (NewFirstVisuallyNonEmptyLayoutFailsTest):
137         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
138         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
139         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
140         (TestWebKitAPI):
141         (NewFirstVisuallyNonEmptyLayoutTest):
142         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
143         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
144
145 2012-02-02  Michael Saboff  <msaboff@apple.com>
146
147         Add Michael Saboff to reviewers list.
148
149         Rubber-stamped by Gavin Barraclough.
150
151         * Scripts/webkitpy/common/config/committers.py:
152
153 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
154
155         Add myself as a committer
156
157         Unreviewed
158
159         * Scripts/webkitpy/common/config/committers.py:
160
161 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
162
163         [PerformanceTests] tests have dependencies
164         https://bugs.webkit.org/show_bug.cgi?id=77506
165
166         Reviewed by Hajime Morita.
167
168         Load an initialization page before each test after starting a DRT so that
169         warming up DRT won't affect the performance test results.
170
171         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
172         (PerfTestsRunner):
173         (PerfTestsRunner.__init__):
174         (PerfTestsRunner._run_tests_set):
175         (PerfTestsRunner._run_single_test):
176         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
177         (MainTest.TestDriver.run_test):
178         (test_initial_page_loaded):
179         (test_initial_page_loaded.run_test):
180
181 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
182
183         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
184
185         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
186         (PerfTestsRunner._run_tests_set):
187         (PerfTestsRunner._run_single_test):
188         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
189         (create_runner):
190         (test_run_passing_test):
191         (test_run_silent_test):
192         (test_run_failed_test):
193         (test_run_tonguey_test):
194         (test_run_timeout_test):
195         (test_run_crash_test):
196         (test_run_test_set_kills_drt_per_run):
197         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
198         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
199         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
200
201 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
202
203         Webkit generate-coverage-data script needs update to use new test script
204         https://bugs.webkit.org/show_bug.cgi?id=77597
205
206         Reviewed by Dirk Schulze.
207
208         * Scripts/generate-coverage-data:
209
210 2012-02-01  Adam Barth  <abarth@webkit.org>
211
212         Update the tests to show that the mac-ews processes patches from
213         non-committers.
214
215         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
216         (EarlyWarningSytemTest.test_committer_only_ewses):
217         (EarlyWarningSytemTest.test_builder_ewses):
218
219 2012-02-01  Adam Barth  <abarth@webkit.org>
220
221         Mac-ews logs are huge
222         https://bugs.webkit.org/show_bug.cgi?id=77045
223
224         Reviewed by Eric Seidel.
225
226         In order to get the cr-linux-ews bot to run tests on EC2, we created
227         the chromium-xvfb port, which contained a number of tweaks to the
228         Chromium port's behavior.  This patch refactors those tweaks so they
229         can be shared with the mac-ews, mostly by moving them into the
230         non-interactive mode of RunTests.
231
232         * Scripts/webkitpy/common/config/ports.py:
233         (WebKitPort):
234         (WebKitPort.layout_tests_results_path):
235         (ChromiumPort.run_javascriptcore_tests_command):
236         (ChromiumXVFBPort):
237         (ChromiumXVFBPort.run_webkit_tests_command):
238         * Scripts/webkitpy/common/config/ports_mock.py:
239         (MockPort):
240         (MockPort.layout_tests_results_path):
241         * Scripts/webkitpy/common/config/ports_unittest.py:
242         (WebKitPortTest.test_chromium_xvfb_port):
243         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
244         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
245         * Scripts/webkitpy/tool/commands/queues_unittest.py:
246         (CommitQueueTest.test_commit_queue):
247         (test_rollout):
248         (test_manual_reject_during_processing):
249         * Scripts/webkitpy/tool/steps/runtests.py:
250         (RunTests.run):
251         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
252         (RunTestsTest.test_no_unit_tests):
253         * Scripts/webkitpy/tool/steps/steps_unittest.py:
254         (StepsTest.test_runtests_args):
255
256 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
257
258         Roll out r106442. It made some tests more stable but others less stable.
259
260         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
261         (PerfTestsRunner._run_tests_set):
262         (PerfTestsRunner._run_single_test):
263         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
264         (create_runner):
265         (test_run_passing_test):
266         (test_run_silent_test):
267         (test_run_failed_test):
268         (test_run_tonguey_test):
269         (test_run_timeout_test):
270         (test_run_crash_test):
271         (test_run_test_set):
272
273 2012-02-01  Lucas Forschler  <lforschler@apple.com>
274
275         Enable EWS for non-contributers.
276         https://bugs.webkit.org/show_bug.cgi?id=77576
277         
278         Reviewed by Adam Barth.
279
280         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
281         (MacEWS):
282
283 2012-02-01  Beth Dakin  <bdakin@apple.com>
284
285         https://bugs.webkit.org/show_bug.cgi?id=77383
286         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
287         -and corresponding-
288         <rdar://problem/10709560>
289
290         Reviewed by Sam Weinig.
291
292         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
293         for.
294         * MiniBrowser/mac/BrowserWindowController.m:
295         (-[BrowserWindowController awakeFromNib]):
296         * WebKitTestRunner/TestController.cpp:
297         (WTR::TestController::initialize):
298
299 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
300
301         TestWebKitAPI isn't being built on chromium bots any more
302         https://bugs.webkit.org/show_bug.cgi?id=77563
303
304         Reviewed by Dimitri Glazkov.
305
306         I accidentally dropped it in the refactoring in r105449.
307
308         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
309
310 2012-02-01  Hans Wennborg  <hans@chromium.org>
311
312         Rename WebSpeechInputResult::set() to assign()
313         https://bugs.webkit.org/show_bug.cgi?id=77540
314
315         Reviewed by Darin Fisher.
316
317         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
318         (MockWebSpeechInputController::addMockRecognitionResult):
319         (MockWebSpeechInputController::speechTaskFired):
320
321 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
322
323         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
324         https://bugs.webkit.org/show_bug.cgi?id=77542
325
326         Reviewed by Martin Robinson.
327
328         * gtk/generate-gtkdoc: Check first whether there's
329         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
330         instead.
331         (get_webkit2_options): Return just the options since the
332         pkg_config_path doesn't depend on options
333         (get_webkit1_options): Ditto.
334         (generate_doc): Helper function to create a generator and generate
335         documentation for the given pkg-config file with the given options.
336         * gtk/gtkdoc.py:
337         (GTKDoc.__init__): Don't use ** for args parameter, since it's
338         used as a dict and never expanded.
339         (PkgConfigGTKDoc.__init__): Ditto.
340
341 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
342
343         [GTK] API documentation is not installed even when building with --enable-gtk-doc
344         https://bugs.webkit.org/show_bug.cgi?id=77094
345
346         Reviewed by Martin Robinson.
347
348         * GNUmakefile.am: Add install-data-local and uninstall-local rules
349         to install/uninstall WebKit1 and WebKit2 API documentation.
350
351 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
352
353         Unreviewed, rolling out r106460.
354         http://trac.webkit.org/changeset/106460
355         https://bugs.webkit.org/show_bug.cgi?id=77552
356
357         It break unit tests if WEBKIT_TESTFONTS isn't defined.
358         (Requested by Ossy on #webkit).
359
360         * Scripts/webkitpy/layout_tests/port/qt.py:
361
362 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
363
364         [Qt] Automatic clean build feature always do clean build with --no-webkit2
365         https://bugs.webkit.org/show_bug.cgi?id=74519
366
367         Reviewed by Tor Arne Vestbø.
368
369         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
370
371         * qmake/mkspecs/features/features.prf:
372
373 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
374
375         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
376         https://bugs.webkit.org/show_bug.cgi?id=77466
377
378         Reviewed by Kenneth Rohde Christiansen.
379
380         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
381         is set or if we should raise an error.
382
383         * Scripts/webkitpy/layout_tests/port/qt.py:
384         (QtPort.setup_environ_for_server):
385
386 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
387
388         Reviewed by Martin Robinson.
389
390         [GTK] Improve FrameLoader signals. Resource loading
391         https://bugs.webkit.org/show_bug.cgi?id=49543
392
393         Support for the new loader signals in DRT.
394
395         * DumpRenderTree/gtk/DumpRenderTree.cpp:
396         (urlPath):
397         (willSendRequestCallback):
398         (urlSuitableForTestResult):
399         (descriptionSuitableForTestResult):
400         (didReceiveResponse):
401         (didFinishLoading):
402         (didFailLoadingWithError):
403         (createWebView):
404
405 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
406
407         run-perf-tests should restart DRT for each test
408         https://bugs.webkit.org/show_bug.cgi?id=77506
409
410         Reviewed by Adam Barth.
411
412         Always restart DRT when running performance tests in order to minimize the dependency between tests.
413
414         * Scripts/webkitpy/layout_tests/port/chromium.py:
415         (ChromiumDriver.stop):
416         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
417         (PerfTestsRunner._run_tests_set):
418         (PerfTestsRunner._run_single_test):
419         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
420         (create_runner):
421         (test_run_passing_test):
422         (test_run_silent_test):
423         (test_run_failed_test):
424         (test_run_tonguey_test):
425         (test_run_timeout_test):
426         (test_run_crash_test):
427         (test_run_test_set_kills_drt_per_run):
428         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
429         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
430         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
431
432 2012-01-31  Hans Wennborg  <hans@chromium.org>
433
434         Speech Input: Report speech element rect relative to window rather than frame
435         https://bugs.webkit.org/show_bug.cgi?id=76443
436
437         Reviewed by Darin Fisher.
438
439         Update LayoutTestController to allow for retrieving the speech
440         element's position used in a request.
441
442         In Chromium this is handled by the MockWebSpeechInputController;
443         adding stubs for the other implementations.
444
445         * DumpRenderTree/LayoutTestController.cpp:
446         (setMockSpeechInputDumpRectCallback):
447         (LayoutTestController::staticFunctions):
448         * DumpRenderTree/LayoutTestController.h:
449         (LayoutTestController):
450         * DumpRenderTree/chromium/LayoutTestController.cpp:
451         (LayoutTestController::LayoutTestController):
452         (LayoutTestController::setMockSpeechInputDumpRect):
453         * DumpRenderTree/chromium/LayoutTestController.h:
454         (LayoutTestController):
455         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
456         (MockWebSpeechInputController::setDumpRect):
457         (MockWebSpeechInputController::clearResults):
458         (MockWebSpeechInputController::startRecognition):
459         (MockWebSpeechInputController::MockWebSpeechInputController):
460         (makeRectResult):
461         (MockWebSpeechInputController::speechTaskFired):
462         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
463         (MockWebSpeechInputController):
464         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
465         (LayoutTestController::setMockSpeechInputDumpRect):
466         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
467         (LayoutTestController::setMockSpeechInputDumpRect):
468         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
469         (LayoutTestController::setMockSpeechInputDumpRect):
470         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
471         (LayoutTestController::setMockSpeechInputDumpRect):
472         * DumpRenderTree/qt/LayoutTestControllerQt.h:
473         (LayoutTestController):
474         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
475         (LayoutTestController::setMockSpeechInputDumpRect):
476         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
477         (LayoutTestController::setMockSpeechInputDumpRect):
478
479 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
480
481         [EFL] Add basic DRT/Efl implementation to support viewport test.
482         https://bugs.webkit.org/show_bug.cgi?id=77320
483
484         Reviewed by Andreas Kling.
485
486         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
487         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
488
489 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
490
491         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
492         https://bugs.webkit.org/show_bug.cgi?id=77473
493         <rdar://problem/10751357>
494
495         Reviewed by Darin Adler.
496
497         * DumpRenderTree/mac/EventSendingController.mm:
498         (-[EventSendingController keyDown:withModifiers:withLocation:]):
499         * WebKitTestRunner/mac/EventSenderProxy.mm:
500         (WTR::EventSenderProxy::keyDown):
501         Added a new special keyDown value to test this.
502
503 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
504
505         nrwt: fix the mock port to work with DriverProxy, reftests
506         https://bugs.webkit.org/show_bug.cgi?id=77170
507
508         Reviewed by Eric Seidel.
509
510         The DryrunPort used for benchmarking and testing NRWT has been
511         broken since we added the DriverProxy code. It isn't really
512         needed any more, so I've removed it.
513
514         The MockDRT port was also broken by DriverProxy, and moreover,
515         never worked w/ reftests. Since we don't exercise this module in
516         the unit tests, the code had also bitrotted some. I have cleaned
517         it up and made it use DriverInput and DriverOutput for
518         consistency.
519
520         * Scripts/webkitpy/layout_tests/port/dryrun.py:
521         (DryRunPort.__init__):
522         (DryRunPort):
523         (DryRunPort.real_name):
524         (DryRunPort.create_driver):
525         (DryRunPort.driver_cmd_line):
526         (DryRunPort._driver_class):
527         (DryrunDriver):
528         (DryrunDriver.run_test):
529         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
530         (MockDRTPort.create_driver):
531         (MockChromiumDRT.run_one_test):
532
533 2012-01-31  Ojan Vafai  <ojan@chromium.org>
534
535         run-webkit-tests calls out to webkit-build-directory twice
536         https://bugs.webkit.org/show_bug.cgi?id=77248
537
538         Reviewed by Dirk Pranke.
539
540         * Scripts/webkit-build-directory:
541         If called with no arguments, print out both the top-level directory and the 
542         configuration directory
543
544         * Scripts/webkitpy/layout_tests/port/config.py:
545         (Config.build_directory):
546         When called with no arguments, get and cache both the top-level and configuration directories.
547
548         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
549         (main):
550         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
551         (ConfigTest.assert_configuration):
552         (ConfigTest.test_build_directory.mock_webkit_build_directory):
553         (ConfigTest.test_build_directory):
554         (ConfigTest.test_default_configuration__notfound):
555         * Scripts/webkitpy/layout_tests/port/webkit.py:
556         (WebKitPort._build_path):
557         Cache the build directory in the options object so that other users
558         of the options object don't need to call out to webkit-build-directory.
559         Also, properly support the existing --build-directory argument.
560
561 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
562
563         Bump up the timeout for performance tests since DOM/DOMTable.html
564         and Parser/html5-full-render.html are timing out on the bot.
565
566         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
567         (PerfTestsRunner._parse_args):
568
569 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
570
571         Fix the update_webgl_conformance_tests.py script in order to enable it
572         to detect the SCM being used correctly.
573         https://bugs.webkit.org/show_bug.cgi?id=77462
574
575         Reviewed by Kenneth Russell.
576
577         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
578         (default_out_dir):
579
580 2012-01-31  Eric Seidel  <eric@webkit.org>
581
582         webkit-patch apply-from-bug should work regardless of your CWD
583         https://bugs.webkit.org/show_bug.cgi?id=77482
584
585         Reviewed by Adam Barth.
586
587         webkit-patch only ever works with patches made from the root
588         directory.  We should pass the CWD to svn-apply in the case
589         where we're running not from the webkit root.  I believe
590         this used to work in the past and regressed.
591
592         * Scripts/webkitpy/common/checkout/checkout.py:
593         (Checkout.apply_patch):
594         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
595         (CheckoutTest.test_apply_patch):
596
597 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
598
599         Unreviewed, rolling out r106302.
600         http://trac.webkit.org/changeset/106302
601         https://bugs.webkit.org/show_bug.cgi?id=77472
602
603         Broke building DRT before running the tests (Requested by ojan
604         on #webkit).
605
606         * Scripts/webkit-build-directory:
607         * Scripts/webkitpy/layout_tests/port/config.py:
608         (Config.build_directory):
609         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
610         (main):
611         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
612         (ConfigTest.assert_configuration):
613         (ConfigTest.test_build_directory.mock_webkit_build_directory):
614         (ConfigTest.test_build_directory):
615         (ConfigTest.test_default_configuration__notfound):
616         * Scripts/webkitpy/layout_tests/port/webkit.py:
617         (WebKitPort._build_path):
618
619 2012-01-31  Antoine Labour  <piman@chromium.org>
620
621         Merge WebGraphicsContext3D creation and initialization, and move it to
622         WebViewClient.
623         https://bugs.webkit.org/show_bug.cgi?id=76593
624
625         Reviewed by Darin Fisher.
626
627         * DumpRenderTree/chromium/TestWebPlugin.cpp:
628         (TestWebPlugin::TestWebPlugin):
629         (TestWebPlugin::initialize):
630         * DumpRenderTree/chromium/TestWebPlugin.h:
631         * DumpRenderTree/chromium/WebViewHost.cpp:
632         (WebViewHost::createGraphicsContext3D):
633         (WebViewHost::createPlugin):
634         * DumpRenderTree/chromium/WebViewHost.h:
635
636 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
637
638         [GTK] build-webkit warning.
639         https://bugs.webkit.org/show_bug.cgi?id=77411
640
641         Reviewed by Philippe Normand.
642
643         * Scripts/webkitdirs.pm:
644         (isCrossCompilation):
645
646 2012-01-31  Dan Bernstein  <mitz@apple.com>
647
648         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
649
650         Reviewed by Anders Carlsson.
651
652         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
653
654 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
655
656         If the QTDIR environment variable is set, the build system fails to compile WinCairo
657         https://bugs.webkit.org/show_bug.cgi?id=77112
658
659         Reviewed by Daniel Bates.
660
661         * Scripts/webkitdirs.pm:
662         (determineIsQt):
663
664 2012-01-31  Adam Roben  <aroben@apple.com>
665
666         Only call -typingAttributes on WebViews, not WebHTMLViews
667
668         Looks like this case was just missed in r105908.
669
670         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
671
672         Reviewed by Antti Koivisto.
673
674         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
675         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
676         earlier.
677
678 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
679
680         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
681         https://bugs.webkit.org/show_bug.cgi?id=77221
682
683         Reviewed by Kenneth Rohde Christiansen.
684
685         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
686
687         * MiniBrowser/qt/MiniBrowserApplication.cpp:
688         (MiniBrowserApplication::sendTouchEvent):
689
690 2012-01-26  Hans Wennborg  <hans@chromium.org>
691
692         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
693         https://bugs.webkit.org/show_bug.cgi?id=77083
694
695         Reviewed by Darin Fisher.
696
697         Add MockWebSpeechInputController which provides a mock implementation
698         of the WebSpeechInputController interface, and use that in
699         DumpRenderTree.
700
701         * DumpRenderTree/DumpRenderTree.gypi:
702         * DumpRenderTree/chromium/LayoutTestController.cpp:
703         (LayoutTestController::addMockSpeechInputResult):
704         * DumpRenderTree/chromium/LayoutTestController.h:
705         ():
706         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
707         (MockWebSpeechInputController::create):
708         (MockWebSpeechInputController::addMockRecognitionResult):
709         (MockWebSpeechInputController::clearResults):
710         (MockWebSpeechInputController::startRecognition):
711         (MockWebSpeechInputController::cancelRecognition):
712         (MockWebSpeechInputController::stopRecording):
713         (MockWebSpeechInputController::MockWebSpeechInputController):
714         (MockWebSpeechInputController::speechTaskFired):
715         (MockWebSpeechInputController::SpeechTask::SpeechTask):
716         (MockWebSpeechInputController::SpeechTask::stop):
717         (MockWebSpeechInputController::SpeechTask::runIfValid):
718         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
719         (WebKit):
720         (MockWebSpeechInputController):
721         (MockWebSpeechInputController::taskList):
722         (SpeechTask):
723         * DumpRenderTree/chromium/TestShell.cpp:
724         * DumpRenderTree/chromium/WebViewHost.cpp:
725         (WebViewHost::speechInputController):
726         * DumpRenderTree/chromium/WebViewHost.h:
727         (WebKit):
728         (WebViewHost::speechInputControllerMock):
729         (WebViewHost):
730         ():
731
732 2012-01-31  Hajime Morrita  <morrita@chromium.org>
733
734         [PerformanceTests] Add landing html for Dromaeo dom-query test
735         https://bugs.webkit.org/show_bug.cgi?id=77329
736
737         Reviewed by Ryosuke Niwa.
738
739         Added some more ignorable output patterns to allow warnings
740         from a third party test suite.
741
742         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
743         (PerfTestsRunner):
744         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
745
746 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
747
748         [wx] Unreviewed. Update download URLs to new domain.
749         
750         * waf/build/build_utils.py:
751         (update_wx_deps):
752
753 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
754
755         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
756         to the list of build directories.
757         
758         * waf/build/settings.py:
759
760 2012-01-30  Kentaro Hara  <haraken@chromium.org>
761
762         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
763         output an empty method name (i.e. "()")
764         https://bugs.webkit.org/show_bug.cgi?id=77336
765
766         Reviewed by Darin Adler.
767
768         r105797 tried to detect a change outside methods, but it causes a bug that
769         prepare-ChangeLog can output an empty method name, like this:
770
771             * foo/bar/baz.cpp:
772             (method1):
773             ():
774             (method2):
775
776         This is because the cpp parser in prepare-ChangeLog cannot distinguish
777         '{' as the beginning of a method with '{' as the beginning of an array definition
778         at the top level.
779
780             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
781
782             void func() { // This '{' is the beginning of a method.
783                 ...;
784             }
785
786         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
787
788         * Scripts/prepare-ChangeLog:
789         (get_function_line_ranges_for_cpp): Modified as described above.
790         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
791         an empty method name. Ideally this should not happen but may happen, since the
792         parsers are not perfect.
793         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
794         (NameSpace7):
795         (NameSpace8):
796         (Class109):
797         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
798
799 2012-01-30  Ojan Vafai  <ojan@chromium.org>
800
801         run-webkit-tests calls out to webkit-build-directory twice
802         https://bugs.webkit.org/show_bug.cgi?id=77248
803
804         Reviewed by Dirk Pranke.
805
806         This reduces to calls to webkit-build-directory to one call and
807         saves 500ms for run-webkit-tests over a single file.
808
809         * Scripts/webkit-build-directory:
810         If called with no arguments, print out both the top-level directory and the 
811         configuration directory.
812
813         * Scripts/webkit-build-directory:
814         * Scripts/webkitpy/layout_tests/port/config.py:
815         (Config.build_directory):
816         When called with no arguments, get and cache both the top-level and configuration directories.
817
818         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
819         (main):
820         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
821         (ConfigTest.assert_configuration):
822         (ConfigTest.test_build_directory.mock_webkit_build_directory):
823         (ConfigTest.test_build_directory):
824         (ConfigTest.test_default_configuration__notfound):
825         * Scripts/webkitpy/layout_tests/port/webkit.py:
826         (WebKitPort._build_path):
827         Cache the root directory in the options object so that other users
828         of the options object don't need to call out to webkit-build-directory.
829
830 2012-01-30  Ojan Vafai  <ojan@chromium.org>
831
832         Parsing test_expecations.txt + Skipped lists takes too long
833         https://bugs.webkit.org/show_bug.cgi?id=77059
834
835         Reviewed by Dirk Pranke.
836
837         This saves ~100ms on the Apple Mac port.
838         -memoize a bunch of path methods.
839         -Avoid doing multiple disk accesses per line.
840         -Parse the skipped list directly instead of turning it into a test_expecations.txt
841         formatting string and parsing that.
842
843         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
844         (TestExpectationParser):
845         (TestExpectationParser.expectation_for_skipped_test):
846         (TestExpectationParser._parse_line):
847         (TestExpectationParser._collect_matching_tests):
848         (TestExpectations.__init__):
849         (TestExpectations._add_skipped_tests):
850         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
851         (test_add_skipped_tests):
852         (test_add_skipped_tests_duplicate):
853         * Scripts/webkitpy/layout_tests/port/base.py:
854         (Port):
855         (Port.test_isfile):
856         (Port.normalize_test_name):
857         (Port.layout_tests_dir):
858         (Port.abspath_for_test):
859         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
860
861 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
862
863         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
864         
865         * Scripts/webkitpy/common/config/watchlist:
866
867 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
868
869         Unreviewed build fix following bug#76855
870
871         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
872         ():
873         (TestWebKitAPI::TEST_F):
874
875 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
876
877         [Qt] WKTR: Use a software rendering pipiline when running tests.
878         https://bugs.webkit.org/show_bug.cgi?id=76708
879
880         Reviewed by Kenneth Rohde Christiansen.
881
882         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
883         (WTR::WrapperWindow::WrapperWindow):
884         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
885
886 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
887
888         [Qt] Store build config immediately instead of waiting for a successfull build
889
890         Otherwise we will not pick up changes to the config if the build is aborted,
891         for example due to build errors or if the user pressed Ctrl+Z. We now write
892         the new config before starting a build, but still defer to write the SVN
893         revision once the build completes successfully.
894
895         Reviewed by Ossy.
896
897         * Scripts/webkitdirs.pm:
898         (buildQMakeProjects):
899
900 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
901
902         [Qt] Add "New Window" button to the Qt MiniBrowser
903         https://bugs.webkit.org/show_bug.cgi?id=77281
904
905         Reviewed by Tor Arne Vestbø.
906
907         * MiniBrowser/qt/BrowserWindow.cpp:
908         (BrowserWindow::BrowserWindow):
909         * MiniBrowser/qt/MiniBrowser.qrc:
910         * MiniBrowser/qt/icons/plus.png: Added.
911         * MiniBrowser/qt/qml/BrowserWindow.qml:
912
913 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
914
915         Unreviewed rolling out r106222.
916
917         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
918         (SingleTestRunner.__init__):
919         * Scripts/webkitpy/layout_tests/controllers/worker.py:
920         (Worker.handle_test_list):
921         * Scripts/webkitpy/layout_tests/models/test_input.py:
922         (TestInput.__init__):
923         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
924         (_set_up_derived_options):
925         (parse_args):
926         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
927         (MainTest.test_repeat_each):
928         * WebKitTestRunner/TestInvocation.cpp:
929         (WTR::TestInvocation::setIsPixelTest):
930
931 2012-01-30  Hans Wennborg  <hans@chromium.org>
932
933         Unreviewed, rolling out r106219.
934         http://trac.webkit.org/changeset/106219
935         https://bugs.webkit.org/show_bug.cgi?id=77083
936
937         This broke Chromium's test_shell.
938
939         * DumpRenderTree/DumpRenderTree.gypi:
940         * DumpRenderTree/chromium/LayoutTestController.cpp:
941         (LayoutTestController::addMockSpeechInputResult):
942         * DumpRenderTree/chromium/LayoutTestController.h:
943         (WebKit):
944         (LayoutTestController):
945         ():
946         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
947         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
948         * DumpRenderTree/chromium/TestShell.cpp:
949         * DumpRenderTree/chromium/WebViewHost.cpp:
950         (WebViewHost::speechInputController):
951         * DumpRenderTree/chromium/WebViewHost.h:
952         (WebKit):
953         (WebViewHost::speechInputControllerMock):
954         (WebViewHost):
955         ():
956
957 2012-01-26  Hans Wennborg  <hans@chromium.org>
958
959         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
960         https://bugs.webkit.org/show_bug.cgi?id=77083
961
962         Reviewed by Darin Fisher.
963
964         Add MockWebSpeechInputController which provides a mock implementation
965         of the WebSpeechInputController interface, and use that in
966         DumpRenderTree.
967
968         * DumpRenderTree/DumpRenderTree.gypi:
969         * DumpRenderTree/chromium/LayoutTestController.cpp:
970         (LayoutTestController::addMockSpeechInputResult):
971         * DumpRenderTree/chromium/LayoutTestController.h:
972         ():
973         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
974         (MockWebSpeechInputController::create):
975         (MockWebSpeechInputController::addMockRecognitionResult):
976         (MockWebSpeechInputController::clearResults):
977         (MockWebSpeechInputController::startRecognition):
978         (MockWebSpeechInputController::cancelRecognition):
979         (MockWebSpeechInputController::stopRecording):
980         (MockWebSpeechInputController::MockWebSpeechInputController):
981         (MockWebSpeechInputController::speechTaskFired):
982         (MockWebSpeechInputController::SpeechTask::SpeechTask):
983         (MockWebSpeechInputController::SpeechTask::stop):
984         (MockWebSpeechInputController::SpeechTask::runIfValid):
985         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
986         (WebKit):
987         (MockWebSpeechInputController):
988         (MockWebSpeechInputController::taskList):
989         (SpeechTask):
990         * DumpRenderTree/chromium/TestShell.cpp:
991         * DumpRenderTree/chromium/WebViewHost.cpp:
992         (WebViewHost::speechInputController):
993         * DumpRenderTree/chromium/WebViewHost.h:
994         (WebKit):
995         (WebViewHost::speechInputControllerMock):
996         (WebViewHost):
997         ():
998
999 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1000
1001         Unreviewed, rolling out r106109.
1002         http://trac.webkit.org/changeset/106109
1003         https://bugs.webkit.org/show_bug.cgi?id=77302
1004
1005         It made tests crash (Requested by Ossy_weekend on #webkit).
1006
1007         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1008         (WTR::WrapperWindow::WrapperWindow):
1009         (WTR::PlatformWebView::PlatformWebView):
1010
1011 2012-01-28  Nico Weber  <thakis@chromium.org>
1012
1013         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
1014         https://bugs.webkit.org/show_bug.cgi?id=77243
1015
1016         Reviewed by Adam Barth.
1017
1018         * Scripts/update-webkit:
1019         * Scripts/webkitdirs.pm:
1020         (isChromiumNinja):
1021         (determineIsChromiumNinja):
1022         (buildChromiumNinja):
1023         (buildChromium):
1024
1025 2012-01-27  Kentaro Hara  <haraken@chromium.org>
1026
1027         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
1028         https://bugs.webkit.org/show_bug.cgi?id=77241
1029
1030         Reviewed by Ryosuke Niwa.
1031
1032         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
1033         in a method in some namespace or class is treated as a method.
1034         This patch fixes the bug.
1035
1036             class C {
1037                 void func()
1038                 {
1039                     if (1) {    // This should not be treated as a method.
1040                     }
1041                 }
1042             };
1043
1044         * Scripts/prepare-ChangeLog:
1045         (get_function_line_ranges_for_cpp):
1046         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1047         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
1048         (Class108):
1049         (Class108::func35):
1050
1051 2012-01-27  Enrica Casucci  <enrica@apple.com>
1052
1053         Followup to http://trac.webkit.org/changeset/106171.
1054         Dan Bernstein pointed out correctly that I should
1055         have used copy instead of initWithString.
1056
1057         Reviewed by Dan Bernstein.
1058
1059         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1060         (-[LocalPasteboard initWithName:]):
1061
1062 2012-01-27  Enrica Casucci  <enrica@apple.com>
1063
1064         DRT pasteboard object should return the correct pasteboard name.
1065         https://bugs.webkit.org/show_bug.cgi?id=77260
1066         
1067         Currently the name property always returns nil.
1068         Adding a memeber variable to store the pasteboard name and return its
1069         value from the name method instead of returning nil always.
1070
1071         Reviewed by Dan Bernstein.
1072
1073         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
1074         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
1075         (-[LocalPasteboard initWithName:]):
1076         (-[LocalPasteboard name]):
1077
1078 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
1079
1080         [GTK] [WK2] Implement the policy client
1081         https://bugs.webkit.org/show_bug.cgi?id=76343
1082
1083         Reviewed by Gustavo Noronha Silva.
1084
1085         * gtk/generate-gtkdoc:
1086         (get_webkit2_options): Update the list of skipped source files to include all clients.
1087
1088 2012-01-27  Ada Chan  <adachan@apple.com>
1089
1090         Add test for WKBundleFrameGetParentFrame().
1091         https://bugs.webkit.org/show_bug.cgi?id=77161
1092
1093         Reviewed by Anders Carlsson.
1094
1095         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
1096         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
1097         (TestWebKitAPI):
1098         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
1099         (TestWebKitAPI::setInjectedBundleClient):
1100         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
1101         Make sure the check is successful.
1102         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
1103         (TestWebKitAPI):
1104         (ParentFrameTest):
1105         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
1106         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
1107         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
1108         to the test controller.
1109         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
1110
1111 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
1112
1113         [Gtk] DumpRenderTree lacks --no-timeout command line option
1114         https://bugs.webkit.org/show_bug.cgi?id=77196
1115
1116         Reviewed by Martin Robinson.
1117
1118         Add the --no-timeout command line option and reorganize
1119         watchdog code to make running DumpRenderTree without
1120         timeout possible.
1121
1122         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1123         (setWaitToDumpWatchdog):
1124         (shouldSetWaitToDumpWatchdog):
1125         (initializeGlobalsFromCommandLineOptions):
1126         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
1127         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1128         (waitToDumpWatchdogFired):
1129         (LayoutTestController::setWaitToDump):
1130
1131 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
1132
1133         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
1134         https://bugs.webkit.org/show_bug.cgi?id=77122
1135
1136         Reviewed by Kenneth Rohde Christiansen.
1137
1138         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1139         (MiniBrowserApplication::MiniBrowserApplication):
1140
1141 2012-01-27  Zeno Albisser  <zeno@webkit.org>
1142
1143         [Qt][Mac] Build fails after adding ICU support (r105997).
1144         https://bugs.webkit.org/show_bug.cgi?id=77118
1145
1146         Define WTF_USE_ICU_UNICODE if we are on mac.
1147
1148         Reviewed by Tor Arne Vestbø.
1149
1150         * qmake/mkspecs/features/features.prf:
1151
1152 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
1153
1154         Update committers.py with new contributors.
1155         https://bugs.webkit.org/show_bug.cgi?id=77207
1156
1157         I added six new contributors into committers.py:
1158
1159         - Adam Kallai
1160         - Balazs Ankes
1161         - Janos Badics
1162         - Nandor Huszka
1163         - Roland Takacs
1164         - Szilard Ledan-Muntean
1165
1166         * Scripts/webkitpy/common/config/committers.py:
1167
1168 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
1169
1170         Add Vsevolod Vlasov to reviewers list.
1171
1172         Reviewed by Pavel Feldman.
1173
1174         * Scripts/webkitpy/common/config/committers.py:
1175
1176 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1177
1178         [Qt] WKTR: Use a software rendering pipiline when running tests.
1179         https://bugs.webkit.org/show_bug.cgi?id=76708
1180
1181         Reviewed by Kenneth Rohde Christiansen.
1182
1183         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1184         (WTR::WrapperWindow::WrapperWindow):
1185         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
1186
1187 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
1188
1189         [wx] Unreviewed. Build fix, add WebCore/testing/js
1190         to the list of source directories we build.
1191
1192         * waf/build/settings.py:
1193
1194 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
1195
1196         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
1197         https://bugs.webkit.org/show_bug.cgi?id=77177
1198
1199         Reviewed by Jon Honeycutt.
1200
1201         * Scripts/commit-log-editor:
1202
1203 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1204
1205         Decrease sleep time when killing server_process on Mac.
1206         https://bugs.webkit.org/show_bug.cgi?id=77169
1207
1208         Reviewed by Eric Seidel.
1209
1210         This shaves another ~70ms off single test runtime.
1211
1212         * Scripts/webkitpy/layout_tests/port/server_process.py:
1213         (ServerProcess.stop):
1214
1215 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1216
1217         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
1218         https://bugs.webkit.org/show_bug.cgi?id=77164
1219
1220         Reviewed by Dirk Pranke.
1221
1222         http://trac.webkit.org/changeset/106035 depends on builder_name being
1223         falsey by default. There's other code that requires it to be iterable
1224         by default. So, make it be the empty string.
1225
1226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1227         (parse_args):
1228
1229 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
1230
1231         run-perf-test should include relative file paths in test names
1232         https://bugs.webkit.org/show_bug.cgi?id=77144
1233
1234         Reviewed by Adam Birth.
1235
1236         Include all directory names in the test name separated by "/".
1237         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
1238
1239         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1240         (PerfTestsRunner):
1241         (PerfTestsRunner._process_parser_test_result):
1242         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1243         (test_run_test_set_with_json_output):
1244         (test_run_test_set_with_json_source):
1245
1246 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
1247
1248         webkitpy: re-land cleanup of test scaffolding
1249         https://bugs.webkit.org/show_bug.cgi?id=77153
1250
1251         Reviewed by Eric Seidel.
1252
1253         This is an attempt to reland the change in bug 76973 / 
1254         r105935. My earlier attempt to manipulate PYTHONPATH
1255         seems to only work some of the time, for reasons that
1256         elude me. Directly adding Tools/Scripts to sys.path from
1257         inside the test script appears to work (more?) reliably.
1258
1259         Also, it seemed like the files didn't actually get deleted
1260         the last time; I don't know why.
1261
1262         * Scripts/test-webkitpy:
1263         * Scripts/webkitpy/common/system/executive_unittest.py:
1264         (command_line):
1265         (ExecutiveTest):
1266         (ExecutiveTest.test_run_command_args_type):
1267         (ExecutiveTest.test_run_command_with_unicode):
1268         (ExecutiveTest.test_running_pids):
1269         (main):
1270         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1271         * Scripts/webkitpy/test/cat.py: Removed.
1272         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1273         * Scripts/webkitpy/test/echo.py: Removed.
1274         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1275
1276 2012-01-26  Ojan Vafai  <ojan@chromium.org>
1277
1278         run-webkit-tests calls "nm" when it doesn't need to
1279         https://bugs.webkit.org/show_bug.cgi?id=77143
1280
1281         Reviewed by Dirk Pranke.
1282
1283         If we are not running any test that can be skipped by checking
1284         the DRT feature list or looking at the list of symbols, avoid calling
1285         out to DRT or calling "nm".
1286
1287         This saves ~700ms on my Mac Pro. In cases where you still have to call out
1288         to "nm" it's only a couple ms slower.
1289
1290         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1291         (TestExpectations.__init__):
1292         * Scripts/webkitpy/layout_tests/port/base.py:
1293         (Port.skipped_tests):
1294         * Scripts/webkitpy/layout_tests/port/webkit.py:
1295         (WebKitPort._should_check_for_missing_features):
1296         (WebKitPort):
1297         (WebKitPort._should_check_for_missing_symbols):
1298         (WebKitPort._skipped_tests_for_unsupported_features):
1299         (WebKitPort.skipped_layout_tests):
1300         (WebKitPort.skipped_tests):
1301         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1302         (WebKitPortTest.test_skipped_directories_for_symbols):
1303         (test_skipped_directories_for_features):
1304         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
1305         (test_skipped_layout_tests):
1306
1307 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
1308
1309         Support a suffix on ChangeLog filenames based on a configuration file
1310         https://bugs.webkit.org/show_bug.cgi?id=76956
1311
1312         Reviewed by Kentaro Hara.
1313
1314         Modify the tools used to generate, edit and resolve ChangeLogs to support
1315         the addition of a suffix to the ChangeLog filename.
1316
1317         This patch makes it easier to support alternate ChangeLog files in branches.
1318
1319         * Scripts/VCSUtils.pm:
1320         (changeLogSuffix):
1321         (changeLogFileName):
1322         * Scripts/commit-log-editor:
1323         * Scripts/prepare-ChangeLog:
1324         (getLatestChangeLogs):
1325         (generateNewChangeLogs):
1326         (generateFileList):
1327         * Scripts/resolve-ChangeLogs:
1328         (findChangeLog):
1329
1330 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1331
1332         Unreviewed, rolling out r106038.
1333         http://trac.webkit.org/changeset/106038
1334         https://bugs.webkit.org/show_bug.cgi?id=77142
1335
1336         Caused a bunch of skipped tests to not be skipped. (Requested
1337         by ojan on #webkit).
1338
1339         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1340         (TestExpectationParser):
1341         (TestExpectationParser.parse):
1342         (TestExpectationParser._parse_line):
1343         (TestExpectationParser._collect_matching_tests):
1344         (TestExpectations.__init__):
1345         (TestExpectations._add_skipped_tests):
1346         * Scripts/webkitpy/layout_tests/port/base.py:
1347         (Port.test_dirs):
1348         (Port.normalize_test_name):
1349         (Port.update_baseline):
1350         (Port.layout_tests_dir):
1351         (Port.relative_perf_test_filename):
1352         (Port.abspath_for_test):
1353
1354 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1355
1356         Parsing test_expecations.txt + Skipped lists takes too long
1357         https://bugs.webkit.org/show_bug.cgi?id=77059
1358
1359         Reviewed by Dirk Pranke.
1360
1361         This saves ~100ms on the Apple Mac port.
1362         -memoize a bunch of path methods.
1363         -Avoid doing multiple disk accesses per line.
1364         -Parse the skipped list directly instead of turning it into a test_expecations.txt
1365         formatting string and parsing that.
1366
1367         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1368         (TestExpectationParser):
1369         (TestExpectationParser.parse_skipped_tests):
1370         (TestExpectationParser._parse_line):
1371         (TestExpectationParser._collect_matching_tests):
1372         (TestExpectations.__init__):
1373         (TestExpectations._add_skipped_tests):
1374         * Scripts/webkitpy/layout_tests/port/base.py:
1375         (Port):
1376         (Port.test_isfile):
1377         (Port.normalize_test_name):
1378         (Port.layout_tests_dir):
1379         (Port.abspath_for_test):
1380
1381 2012-01-25  Ojan Vafai  <ojan@chromium.org>
1382
1383         Only store the SVN revision in the summarized results if we're on a builder
1384         https://bugs.webkit.org/show_bug.cgi?id=76976
1385
1386         Reviewed by Dirk Pranke.
1387
1388         This shaves another ~130ms off the single test run-webkit-tests runtime.
1389
1390         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1391         (summarize_results):
1392         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1393         (ResultSummaryTest.get_result):
1394         (ResultSummaryTest):
1395         (ResultSummaryTest.get_result_summary):
1396         (ResultSummaryTest.get_unexpected_results):
1397         (ResultSummaryTest.test_no_svn_revision):
1398         (ResultSummaryTest.test_svn_revision):
1399         * Scripts/webkitpy/layout_tests/port/base.py:
1400         (Port.use_trac_links_in_results_html):
1401
1402 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
1403
1404         [Qt][WK2] fast/loader tests failed after r94178
1405         https://bugs.webkit.org/show_bug.cgi?id=67388
1406
1407         Reviewed by Simon Hausmann.
1408
1409         Applying the same fix used for Qt-WebKit1 from bug #67254 -
1410         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
1411         https://bugs.webkit.org/show_bug.cgi?id=67254
1412         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
1413         derived from the running location of DumpRenderTree binary.
1414
1415         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1416         (WTR::LayoutTestController::pathToLocalResource):
1417
1418 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1419
1420         Implement overridePreference for boolean preferences in WebKitTestRunner
1421         https://bugs.webkit.org/show_bug.cgi?id=77033
1422
1423         Reviewed by Alexey Proskuryakov.
1424
1425         For now overridePreference supports boolean values.
1426
1427         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1428         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1429         (WTR::LayoutTestController::setXSSAuditorEnabled):
1430         (WTR::LayoutTestController::overridePreference):
1431         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1432         * WebKitTestRunner/TestController.cpp:
1433         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
1434         explicitly and properly disable the use of PageCache when resetting the
1435         state. Tests that use PageCache can now enable it via overridePreference.
1436
1437 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1438
1439         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
1440         https://bugs.webkit.org/show_bug.cgi?id=77100
1441
1442         Reviewed by Simon Hausmann.
1443
1444         This patch makes the MiniBrowser read multiple URL's from the command
1445         line such that there will be one browser window opened for each URL.
1446
1447         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1448         (MiniBrowserApplication::handleUserOptions):
1449
1450 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
1451
1452         [Qt] The Qt MiniBrowser crashes when given multiple URL's
1453         https://bugs.webkit.org/show_bug.cgi?id=77009
1454
1455         Reviewed by Simon Hausmann.
1456
1457         This patch fixes a crash in BrowserWindow::newWindow() where a
1458         BrowserWindow-object is constructed with a 0 pointer as the
1459         WindowOptions parameter which leads to a crash.
1460
1461         * MiniBrowser/qt/BrowserWindow.cpp:
1462         (BrowserWindow::BrowserWindow):
1463         (BrowserWindow::newWindow):
1464         * MiniBrowser/qt/BrowserWindow.h:
1465
1466 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1467
1468         [Qt] Use ICU if available
1469         https://bugs.webkit.org/show_bug.cgi?id=76821
1470
1471         Reviewed by Simon Hausmann.
1472
1473         Adding unicode defines for a Qt 5 based build.
1474
1475         * qmake/mkspecs/features/features.prf:
1476
1477 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1478
1479         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
1480         https://bugs.webkit.org/show_bug.cgi?id=42545
1481
1482         Reviewed by Zoltan Herczeg.
1483
1484         Implement the setGeolocationPermission method.
1485
1486         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1487         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1488         (WTR::LayoutTestController::setGeolocationPermission):
1489         (WTR):
1490         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1491         (LayoutTestController):
1492
1493 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
1494
1495         [NRWT] Support --ignore-metrics
1496         https://bugs.webkit.org/show_bug.cgi?id=76278
1497
1498         Reviewed by Tony Chang.
1499
1500         Port the feature from ORWT.
1501
1502         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1503         (SingleTestRunner._run_compare_test):
1504         * Scripts/webkitpy/layout_tests/port/driver.py:
1505         (DriverOutput):
1506         (DriverOutput.strip_metrics):
1507         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1508         (DriverOutputTest):
1509         (DriverOutputTest.test_strip_metrics):
1510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1511         (_set_up_derived_options):
1512         (parse_args):
1513
1514 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1515
1516         Unreviewed, rolling out r105935 and r105954.
1517         http://trac.webkit.org/changeset/105935
1518         http://trac.webkit.org/changeset/105954
1519         https://bugs.webkit.org/show_bug.cgi?id=77080
1520
1521         test-webkitpy is still broken (Requested by abarth on
1522         #webkit).
1523
1524         * Scripts/test-webkitpy:
1525         * Scripts/webkitpy/common/system/executive_unittest.py:
1526         (never_ending_command):
1527         (ExecutiveTest.test_run_command_args_type):
1528         (ExecutiveTest.test_run_command_with_unicode):
1529         (ExecutiveTest.test_running_pids):
1530         * Scripts/webkitpy/common/system/fileutils.py:
1531         (make_stdout_binary):
1532         * Scripts/webkitpy/test/cat.py:
1533         (command_arguments):
1534         (main):
1535         * Scripts/webkitpy/test/cat_unittest.py:
1536         (CatTest):
1537         (CatTest.assert_cat):
1538         (CatTest.test_basic):
1539         (CatTest.test_no_newline):
1540         (CatTest.test_unicode):
1541         (CatTest.test_as_command):
1542         * Scripts/webkitpy/test/echo.py:
1543         (command_arguments):
1544         (main):
1545         * Scripts/webkitpy/test/echo_unittest.py:
1546         (EchoTest):
1547         (EchoTest.test_basic):
1548         (EchoTest.test_no_newline):
1549         (EchoTest.test_unicode):
1550         (EchoTest.test_argument_order):
1551         (EchoTest.test_empty_arguments):
1552         (EchoTest.test_no_arguments):
1553         (EchoTest.test_as_command):
1554
1555 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
1556
1557         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
1558         https://bugs.webkit.org/show_bug.cgi?id=76138
1559
1560         Reviewed by Martin Robinson.
1561
1562         * Scripts/webkitdirs.pm:
1563         (isCrossCompilation):
1564         (buildAutotoolsProject):
1565
1566 2012-01-25  Adam Barth  <abarth@webkit.org>
1567
1568         Kentaro is a reviewer now.  Yay!
1569
1570         * Scripts/webkitpy/common/config/committers.py:
1571
1572 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1573
1574         nrwt: running w/ no arguments fails
1575         https://bugs.webkit.org/show_bug.cgi?id=77064
1576
1577         Unreviewed, build fix.
1578
1579         This change fixes a regression introduced in r105944
1580         where running without --platform <foo> or one of the other
1581         platform switches would cause a null deref :(.
1582
1583         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1584         (main):
1585
1586 2012-01-25  Eric Seidel  <eric@webkit.org>
1587
1588         Automatically CC someone from Apple on any changes to Obj-C public API
1589         https://bugs.webkit.org/show_bug.cgi?id=77053
1590
1591         Reviewed by Timothy Hatcher.
1592
1593         This has long been de-facto practice, seems now that we have
1594         fancy watchlist support, we should just make the tools
1595         do this automatically.
1596
1597         * Scripts/webkitpy/common/config/watchlist:
1598
1599 2012-01-25  Antoine Labour  <piman@chromium.org>
1600
1601         Updating status in committers.py.
1602
1603         Unreviewed.
1604
1605         * Scripts/webkitpy/common/config/committers.py:
1606
1607 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1608
1609         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1610         https://bugs.webkit.org/show_bug.cgi?id=77058
1611
1612         Reviewed by Eric Seidel.
1613
1614         r105935 broke executive_unittest by changing which script we
1615         were running and not ensuring that the PYTHONPATH was set up
1616         properly.
1617
1618         This change also fixes a regression introduced recently where
1619         test-webkitpy wasn't figuring out the path to Tools/Scripts
1620         right, either (so running ./test-webkitpy would fail).
1621
1622         * Scripts/test-webkitpy:
1623         * Scripts/webkitpy/common/system/executive_unittest.py:
1624         (script_dir):
1625         (ExecutiveTest.setUp):
1626         (ExecutiveTest):
1627         (ExecutiveTest.tearDown):
1628
1629 2012-01-25  Adam Barth  <abarth@webkit.org>
1630
1631         Disable tests on the mac-ews while we sort out hte stability issues.
1632
1633         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1634         (MacEWS):
1635
1636 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1637
1638         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1639         https://bugs.webkit.org/show_bug.cgi?id=76475
1640
1641         Reviewed by Eric Seidel.
1642
1643         This patch cleans up the internal usage of port names for the
1644         Apple mac and Apple win ports so that 'mac' and 'win are never
1645         considered "fully specified" port names: they are still legal
1646         input to the PortFactory.get() routine, but only if run on the given
1647         platform (i.e. trying to PortFactory.get('mac') on windows or
1648         linux will return an error, since we don't know which version of
1649         the port is desired.
1650
1651         This also cleans up handling of the webkit2 variants, so that
1652         the full port names consistently follow the
1653         <operating_system>-<version>[-<wk2>] convention.
1654
1655         Lastly this patch adds some assertions and removes some
1656         try/catch logic to catch more programming and usage errors;
1657         previously mac-tiger might've been allowed -- and it would've
1658         translated into using just the baselines in platform/mac -- but
1659         now it should fail.
1660
1661         * Scripts/webkitpy/layout_tests/port/apple.py:
1662         (ApplePort.determine_full_port_name):
1663         (ApplePort.__init__):
1664         (ApplePort):
1665         (ApplePort._port_name_with_version):
1666         * Scripts/webkitpy/layout_tests/port/builders.py:
1667         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1668         (FactoryTest.test_mac):
1669         (FactoryTest.test_win):
1670         * Scripts/webkitpy/layout_tests/port/mac.py:
1671         (MacPort.baseline_search_path):
1672         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1673         (MacTest.test_versions):
1674         * Scripts/webkitpy/layout_tests/port/win.py:
1675         (WinPort.baseline_search_path):
1676         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1677         (WinTest.test_versions):
1678
1679 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1680
1681         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1682         https://bugs.webkit.org/show_bug.cgi?id=76955
1683
1684         Reviewed by Adam Barth.
1685
1686         This change cleans up the errors that are printed so that the
1687         are more "quickfix" compatible (path:lineno).
1688
1689         Also, there were a bunch of redundant tests between
1690         layout_tests.models.test_expectations_unittest and
1691         style.checkers.test_expectations_unittest. The latter should
1692         just expect the former to do most of the testing.
1693
1694         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1695         (TestExpectationParser._parse_modifiers):
1696         (TestExpectations._report_errors):
1697         (TestExpectations._add_skipped_tests):
1698         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1699         (test_parse_error_nonfatal):
1700         (SemanticTests.test_bad_bugid):
1701         * Scripts/webkitpy/style/checkers/test_expectations.py:
1702         (TestExpectationsChecker.__init__):
1703         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1704         (TestExpectationsTestCase.assert_lines_lint):
1705         (TestExpectationsTestCase.test_valid_expectations):
1706         (TestExpectationsTestCase.test_invalid_expectations):
1707         (TestExpectationsTestCase.test_tab):
1708
1709 2012-01-25  Eric Seidel  <eric@webkit.org>
1710
1711         webkit-patch apply-* should always continue after failures
1712         https://bugs.webkit.org/show_bug.cgi?id=77057
1713
1714         Reviewed by Adam Barth.
1715
1716         As far as I can tell there is only one potential drawback to always
1717         forcing: that if you're somehow in the wrong directory it will create new
1718         directories for new files.  Since webkit-patch always cd's to the root
1719         it seems that's not a drawback.  The drawback of not using --force for
1720         svn-apply, is that it will stop after the first failure, which is rarely
1721         (if ever) the desired behavior.  This just removes the force option
1722         (which was strangely hidden behind --non-interactive).  This should
1723         make for a better user experiance.
1724
1725         * Scripts/webkitpy/common/checkout/checkout.py:
1726         (Checkout.apply_patch):
1727         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1728         (MockCheckout.apply_patch):
1729         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1730         (CheckoutTest.test_chromium_deps):
1731         (CheckoutTest):
1732         (CheckoutTest.test_apply_patch):
1733         * Scripts/webkitpy/tool/commands/download_unittest.py:
1734         (DownloadCommandsTest._default_options):
1735         * Scripts/webkitpy/tool/steps/applypatch.py:
1736         (ApplyPatch.options):
1737         (ApplyPatch.run):
1738         * Scripts/webkitpy/tool/steps/options.py:
1739         (Options):
1740
1741 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1742
1743         nrwt: should be able to run --platform test interactively
1744         https://bugs.webkit.org/show_bug.cgi?id=76959
1745
1746         Reviewed by Adam Barth.
1747
1748         As part of refactoring the Port interfaces, in r103254 I made
1749         passing a Host object to the Port mandatory; previously TestPort
1750         objects would create their own (mock) hosts. However,
1751         new-run-webkit-tests always passed a real Host, not a MockHost,
1752         and so you couldn't run new-run-webkit-tests --platform test
1753         interactively to debug test failures.
1754
1755         This change fixes that by creating a MockHost instead of a real
1756         host if you say --platform test*.
1757
1758         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1759         (main):
1760
1761 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1762
1763         run-webkit-tests --lint-test-files should lint all the ports by default
1764         https://bugs.webkit.org/show_bug.cgi?id=76749
1765
1766         Reviewed by Ojan Vafai.
1767
1768         Currently run-webkit-tests --lint-test-files will only lint the
1769         test_expectations for the single port determined by the command
1770         line options. This is not obvious and can produce unintended results
1771         if you want to lint the chromium port (probably the normal case
1772         for using --lint-test-files) but don't specify a port name or
1773         --chromium.
1774
1775         I think we should probably lint *all* of the ports if no port
1776         name is supplied. This change implements that, and also moves
1777         the linting logic out of the Manager class, since this really
1778         has nothing to do with Managers. It has little to do with
1779         run-webkit-tests, but splitting it into a different script would
1780         introduce compatibility issues. It might make sense to do that
1781         anyway, in a separate patch and combining that with cleaning up
1782         the style checker to share more code.
1783
1784         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1785         (Manager._strip_test_dir_prefix):
1786         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1787         (lint):
1788         (run):
1789         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1790         (LintTest.test_all_configurations): added.
1791         (LintTest.test_lint_test_files): added.
1792         (LintTest.test_lint_test_files__errors): added.
1793         (MainTest.test_lint_test_files): removed.
1794         (MainTest.test_lint_test_files__errors): removed.
1795
1796 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1797
1798         webkitpy: clean up a bunch of test scaffolding
1799         https://bugs.webkit.org/show_bug.cgi?id=76973
1800
1801         Reviewed by Eric Seidel.
1802
1803         There were several helper modules in the webkitpy.test package
1804         that appear to only be used by executive_unittest.py. I am
1805         rolling them all into that file to make that clearer.
1806
1807         * Scripts/webkitpy/common/system/executive_unittest.py:
1808         (ExecutiveTest.test_run_command_args_type):
1809         (ExecutiveTest.test_run_command_with_unicode):
1810         (ExecutiveTest.test_running_pids):
1811         (command_line):
1812         (main):
1813         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1814         * Scripts/webkitpy/test/cat.py: Removed.
1815         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1816         * Scripts/webkitpy/test/echo.py: Removed.
1817         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1818
1819 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1820
1821         webkitpy: clean up a bunch of test scaffolding
1822         https://bugs.webkit.org/show_bug.cgi?id=76973
1823
1824         Reviewed by Eric Seidel.
1825
1826         There were several helper modules in the webkitpy.test package
1827         that appear to only be used by executive_unittest.py. I am
1828         rolling them all into that file to make that clearer.
1829
1830         * Scripts/webkitpy/common/system/executive_unittest.py:
1831         (ExecutiveTest.test_run_command_args_type):
1832         (ExecutiveTest.test_run_command_with_unicode):
1833         (ExecutiveTest.test_running_pids):
1834         (command_line):
1835         (main):
1836         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1837         * Scripts/webkitpy/test/cat.py: Removed.
1838         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1839         * Scripts/webkitpy/test/echo.py: Removed.
1840         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1841
1842 2012-01-25  Eric Seidel  <eric@webkit.org>
1843
1844         Remove Python 2.5 support from WebKit
1845         https://bugs.webkit.org/show_bug.cgi?id=71593
1846
1847         Reviewed by Adam Barth.
1848
1849         Just removing support from this one core file.
1850         I'll commit the rest of the (large) change once we've
1851         gone 24 hours and seen that no bots have exploded.
1852         We can roll out this one change if we break bots
1853         and then roll in the rest once those bots are fixed.
1854
1855         * Scripts/webkitpy/common/system/executive.py:
1856         (Executive.cpu_count):
1857
1858 2012-01-25  Hajime Morita  <morrita@google.com>
1859
1860         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1861         https://bugs.webkit.org/show_bug.cgi?id=76863
1862
1863         Reviewed by Dimitri Glazkov.
1864
1865         Added a feature flag.
1866
1867         * Scripts/build-webkit:
1868         * qmake/mkspecs/features/features.prf:
1869
1870 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1871
1872         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1873         https://bugs.webkit.org/show_bug.cgi?id=76344
1874
1875         Reviewed by Sam Weinig.
1876
1877         Add a test verifying that the mouse button during policy decisions for
1878         events not triggered by mouse events is NoButton.
1879
1880         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1881         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1882         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1883
1884 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1885
1886         run-perf-tests should timeout sooner
1887         https://bugs.webkit.org/show_bug.cgi?id=77026
1888
1889         Reviewed by Adam Barth.
1890
1891         Bump off the timeout from 10 minutes to 4 minutes.
1892
1893         Also use float instead of str in test result values to compress the size of json files bots upload.
1894
1895         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1896         (PerfTestsRunner._parse_args):
1897         (PerfTestsRunner._process_chromium_style_test_result):
1898         (PerfTestsRunner._process_parser_test_result):
1899         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1900         (test_run_test_set_for_parser_tests):
1901         (test_run_test_set_with_json_output):
1902         (test_run_test_set_with_json_source):
1903
1904 2012-01-25  Enrica Casucci  <enrica@apple.com>
1905
1906         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1907         https://bugs.webkit.org/show_bug.cgi?id=76951
1908         <rdar://problem/9325158>
1909
1910         Reviewed by Alexey Proskuryakov.
1911
1912         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
1913         and WebHTMLView.
1914         (TestWebKitAPI::TEST):
1915
1916 2012-01-23  MORITA Hajime  <morrita@google.com>
1917
1918         [Refactoring][Internals] Should have InternalSettings
1919         https://bugs.webkit.org/show_bug.cgi?id=76424
1920
1921         Reviewed by Kent Tamura.
1922
1923         * GNUmakefile.am: Added so new files.
1924
1925 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
1926
1927         webkitpy: new-run-webkit-websocket is broken
1928         https://bugs.webkit.org/show_bug.cgi?id=76999
1929
1930         Reviewed by Dirk Pranke.
1931
1932         r105674 broke new-run-webkit-websocket, since options.chromium
1933         doesn't exist any more. new-run-webkit-httpd was also broken
1934         and already fixed at r105835.
1935         * Scripts/new-run-webkit-websocketserver:
1936         (main):
1937
1938 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1939
1940         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
1941         https://bugs.webkit.org/show_bug.cgi?id=63458
1942
1943         Reviewed by Adam Roben.
1944
1945         Implement the setPopupBlockingEnabled method.
1946
1947         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1948         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1949         (WTR::LayoutTestController::setPopupBlockingEnabled):
1950         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1951
1952 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
1953
1954         [Qt] Cleanup testfonts handling
1955         https://bugs.webkit.org/show_bug.cgi?id=76068
1956
1957         Reviewed by Simon Hausmann.
1958
1959         Factor test font initialization into it's own file  so test
1960         font users can share the implementation by adding the file
1961         to their build.
1962         Use fonts.conf from the test font directory to not require the
1963         current directory to be the WebKit root.
1964         Fix the -use-test-fonts option of QtTestBrowser by initializing
1965         the fonts earlier, before it is too late (namely before calling
1966         show on the main window).
1967
1968         * DumpRenderTree/qt/DumpRenderTree.pro:
1969         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1970         (WebCore::DumpRenderTree::open):
1971         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1972         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
1973         (WebKit::initializeTestFonts):
1974         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
1975         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
1976         we will use the one from the test fonts directory.
1977         * DumpRenderTree/qt/main.cpp:
1978         (main): Fix the ifdefs to make it clear that the code to
1979         set up the Dpi has not been ported to Qt5 yet.
1980         * QtTestBrowser/QtTestBrowser.pro:
1981         * QtTestBrowser/launcherwindow.h:
1982         (WindowOptions::WindowOptions):
1983         * QtTestBrowser/main.cpp:
1984         (launcherMain):
1985         (LauncherApplication::handleUserOptions):
1986         * WebKitTestRunner/InjectedBundle/Target.pri:
1987         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1988         (WTR::activateFonts): Remove the code to set up the Dpi
1989         because it does not work with Qt5.
1990
1991 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
1992
1993         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
1994
1995         Reviewed by Tor Arne Vestø.
1996
1997         Don't require it by making svnRevisionForDirectory return "unknown"
1998         instead of bailing out with an error.
1999
2000         * Scripts/VCSUtils.pm:
2001         (svnRevisionForDirectory):
2002
2003 2012-01-25  Adam Barth  <abarth@webkit.org>
2004
2005         Temporarily disable running the unit tests on the Chromium EWS.  These
2006         tests don't work properly (see
2007         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
2008         blocking the EWS.
2009
2010         * Scripts/webkitpy/common/config/ports.py:
2011         (ChromiumPort):
2012
2013 2012-01-25  Adam Barth  <abarth@webkit.org>
2014
2015         Update results.html version of PixelZoomer
2016         https://bugs.webkit.org/show_bug.cgi?id=76965
2017
2018         Reviewed by Ojan Vafai.
2019
2020         Improve readability as suggested by Ojan.
2021
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2023
2024 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2025
2026         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
2027         https://bugs.webkit.org/show_bug.cgi?id=76899
2028
2029         Reviewed by Martin Robinson.
2030
2031         * gtk/generate-gtkdoc:
2032         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
2033         WebKitLoaderClient.
2034
2035 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2036
2037         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
2038
2039         * BuildSlaveSupport/build.webkit.org-config/config.json:
2040
2041 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2042
2043         WebKit needs public performance tests running on public bots
2044         https://bugs.webkit.org/show_bug.cgi?id=10266
2045
2046         Reviewed by Adam Barth.
2047
2048         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
2049         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
2050
2051         * BuildSlaveSupport/build.webkit.org-config/config.json:
2052         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2053         (RunAndUploadPerfTests):
2054         (RunAndUploadPerfTests.start):
2055         (UploadPerfTestResults):
2056         (BuildAndPerfTestFactory):
2057         (BuildAndPerfTestFactory.__init__):
2058
2059 2012-01-24  Ojan Vafai  <ojan@chromium.org>
2060
2061         Initializing the browser property of the Bugzilla class takes too long
2062         https://bugs.webkit.org/show_bug.cgi?id=76960
2063
2064         Reviewed by Adam Barth.
2065
2066         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
2067         on my Mac Pro.
2068
2069         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2070         (Bugzilla.__init__):
2071         (Bugzilla._get_browser):
2072         (Bugzilla):
2073         (Bugzilla._set_browser):
2074
2075 2012-01-24  Mark Rowe  <mrowe@apple.com>
2076
2077         Death to JavaScriptGlue.
2078
2079         Rubber-stamped by Geoffrey Garen.
2080
2081         * BuildSlaveSupport/build-launcher-app:
2082         (copyNightlyLauncher):
2083         * Scripts/build-webkit:
2084         * Scripts/do-file-rename:
2085         * Scripts/do-webcore-rename:
2086         * Scripts/webkitpy/common/config/build.py:
2087         (_should_file_trigger_build):
2088         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
2089         path in conjunction with a cross-platform path.
2090         (ShouldBuildTest):
2091
2092 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2093
2094         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
2095         https://bugs.webkit.org/show_bug.cgi?id=75836
2096
2097         Reviewed by David Kilzer.
2098
2099         Previously parser_unittests.pl can just test the returned value of
2100         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
2101         parser_unittests.pl so that it also tests the stdout and stderr of
2102         get_function_line_ranges().
2103
2104         This patch adds css_unittests_warning.css, which contains test cases
2105         for warning messages of the CSS parser of prepare-ChangeLog.
2106
2107         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2108         (captureOutput): Captures the stdout and stderr of a given method.
2109         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
2110         string to relative paths.
2111
2112         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
2113         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
2114         (element1):
2115         (element2):
2116         (element3):
2117         (element4):
2118         ():
2119         (element5):
2120         (element6):
2121
2122         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2123         Just updated the test results, i.e. added stdout and stderr results.
2124         No essential changes in the test results.
2125         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
2126         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
2127         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
2128         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
2129         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
2130
2131 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2132
2133         webkitpy: new-run-webkit-httpd is broken
2134         https://bugs.webkit.org/show_bug.cgi?id=76963
2135
2136         Reviewed by Adam Barth.
2137
2138         r105674 broke new-run-webkit-httpd, since options.chromium
2139         doesn't exist any more. We didn't catch this because we don't
2140         run the integration tests by default anywhere :(.
2141
2142         * Scripts/new-run-webkit-httpd:
2143         (run):
2144         (main):
2145
2146 2012-01-24  Adam Barth  <abarth@webkit.org>
2147
2148         garden-o-matic pixel zoomer should let you look at every pixel of the image
2149         https://bugs.webkit.org/show_bug.cgi?id=76962
2150
2151         Reviewed by Ojan Vafai.
2152
2153         Previously, you couldn't get up to the right and bottom pixels.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
2156
2157 2012-01-24  Enrica Casucci  <enrica@apple.com>
2158
2159         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
2160         https://bugs.webkit.org/show_bug.cgi?id=76951
2161         <rdar://problem/9325158>
2162
2163         Added test to verify that WebHTMLView supports the typingAttributes method and that it
2164         works as expected.
2165         
2166         Reviewed by Alexey Proskuryakov.
2167
2168         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2169         (TestWebKitAPI::TEST):
2170
2171 2012-01-24  James Robinson  <jamesr@chromium.org>
2172
2173         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
2174         https://bugs.webkit.org/show_bug.cgi?id=76884
2175
2176         Reviewed by Adam Barth.
2177
2178         * Scripts/webkitpy/tool/bot/irc_command.py:
2179         (Rollout.execute):
2180         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2181         (SheriffIRCBotTest.test_rollout):
2182         (SheriffIRCBotTest.test_revert):
2183         (SheriffIRCBotTest.test_multi_rollout):
2184         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
2185         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2186         (SheriffIRCBotTest.test_rollout_invalidate_reason):
2187         (test_multi_rollout_invalidate_reason):
2188
2189 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2190
2191         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
2192         https://bugs.webkit.org/show_bug.cgi?id=75531
2193
2194         Reviewed by David Kilzer.
2195
2196         Previously, the cpp parser of prepare-ChangeLog could not detect a change
2197         outside methods. Consider the following cpp file.
2198
2199             namespace N {
2200             int a;     // this change does not appear on ChangeLog.
2201             class C {
2202                 int b;     // this change does not appear on ChangeLog.
2203                 void f()
2204                 {
2205                     int c;     // this change appears on ChangeLog.
2206                 }
2207                 int d;     // this change does not appear on ChangeLog.
2208             };
2209             int e;     // this change does not appear on ChangeLog.
2210             };
2211
2212         The previous prepare-ChangeLog outputs just methods in which a change is found:
2213             (N::C::f):
2214
2215         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
2216         and methods in which a change is found:
2217             (N):
2218             (N::C):
2219             (N::C::f):
2220
2221         * Scripts/prepare-ChangeLog:
2222         (get_function_line_ranges_for_cpp): Modified as described above.
2223
2224         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
2225         (Class104):
2226         (Class105):
2227         (Class106):
2228         (Class106::func32):
2229         (Class106::func33):
2230         (NameSpace3):
2231         (NameSpace4):
2232         (NameSpace5):
2233         (NameSpace6):
2234         (Class107):
2235         (NameSpace5::NameSpace6::Class107::func34):
2236         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2237
2238 2012-01-24  Kentaro Hara  <haraken@chromium.org>
2239
2240         prepare-ChangeLog outputs warnings for top-level { ... } blocks
2241         https://bugs.webkit.org/show_bug.cgi?id=75943
2242
2243         Reviewed by David Kilzer.
2244
2245         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
2246         because it does not distinguish '}' at the end of a subroutine
2247         with '}' at the end of a if or for statement.
2248
2249         foo.pl:
2250             if (1) {
2251             }
2252             for (@v) {
2253             }
2254
2255         output:
2256             nested functions found at top-level at foo.pl:2
2257             nested functions found at top-level at foo.pl:4
2258
2259         This patch fixes the bug.
2260
2261         * Scripts/prepare-ChangeLog:
2262         (get_function_line_ranges_for_perl):
2263         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2264         Added test cases. No change in the test results.
2265
2266 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
2267
2268         r105674 broke check-webkit-style for chromium's test_expectations.
2269
2270         Unreviewed, build fix.
2271         
2272         We now need to pass in a platform name of 'chromium' if we want
2273         the chromium port; options.chromium is no longer recognized. I
2274         will follow this patch up with a separate patch that has a test,
2275         but this at least fixes the build.
2276
2277         * Scripts/webkitpy/style/checkers/test_expectations.py:
2278         (TestExpectationsChecker._determine_port_from_exepectations_path):
2279
2280 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2281
2282         check-webkit-style of the chromium test_expectations.txt file takes too long
2283         https://bugs.webkit.org/show_bug.cgi?id=76745
2284
2285         Reviewed by Dimitri Glazkov.
2286
2287         When in lint mode, have TestExpectations test all configurations instead
2288         of looping over each configuration. This also has the benefit of making
2289         the error output considerably more concise.
2290
2291         Also, got rid of the double-printing of errors when linting through check-webkit-style.
2292
2293         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2294         (Manager.lint):
2295         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2296         (TestExpectations._report_errors):
2297         (TestExpectations._add_expectations):
2298         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2299         (test_parse_error_nonfatal):
2300         (test_error_on_different_platform):
2301         * Scripts/webkitpy/style/checkers/test_expectations.py:
2302         (TestExpectationsChecker.check_test_expectations):
2303         (TestExpectationsChecker.check):
2304         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2305         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
2306         (TestExpectationsTestCase.assert_lines_lint):
2307
2308 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2309
2310         Another build fix attempt after r105543.
2311
2312         * Scripts/webkitpy/common/net/file_uploader.py:
2313         (FileUploader.upload_as_multipart_form_data):
2314
2315 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
2316
2317         Build fix attempt after r105543.
2318
2319         * Scripts/webkitpy/common/net/file_uploader.py:
2320         (FileUploader.upload_as_multipart_form_data):
2321
2322 2012-01-24  Vincent Scheib  <scheib@chromium.org>
2323
2324         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
2325         https://bugs.webkit.org/show_bug.cgi?id=76411
2326
2327         Reviewed by Adam Barth.
2328
2329         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
2330         into a series of patches, this change adds a trivial
2331         pointer lock implementation to the Chromium port's DumpRenderTree
2332         and exposes LayoutTestController hooks to force failure conditions.
2333
2334         * DumpRenderTree/chromium/LayoutTestController.cpp:
2335         (LayoutTestController::LayoutTestController):
2336         (LayoutTestController::didLosePointerLock):
2337         (LayoutTestController::setPointerLockWillFailAsynchronously):
2338         (LayoutTestController::setPointerLockWillFailSynchronously):
2339         * DumpRenderTree/chromium/LayoutTestController.h:
2340         * DumpRenderTree/chromium/WebViewHost.cpp:
2341         (WebViewHost::requestPointerLock):
2342         (WebViewHost::requestPointerUnlock):
2343         (WebViewHost::isPointerLocked):
2344         (WebViewHost::didCompletePointerLock):
2345         (WebViewHost::didNotCompletePointerLock):
2346         (WebViewHost::didLosePointerLock):
2347         (WebViewHost::reset):
2348         * DumpRenderTree/chromium/WebViewHost.h:
2349         (WebViewHost::setPointerLockWillFailAsynchronously):
2350         (WebViewHost::setPointerLockWillFailSynchronously):
2351
2352 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
2353
2354         Unreviewed, skip WK2 API test timing out on some GTK bots.
2355
2356         WebKit2APITests/TestDownloads is consistently timing out on the
2357         32bit release and 64bit debug bots.
2358
2359         * Scripts/run-gtk-tests:
2360         (TestRunner): Skip WebKit2APITests/TestDownloads.
2361
2362 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2363
2364         [Qt] Fix the build with the newes Qt5 hashes
2365         https://bugs.webkit.org/show_bug.cgi?id=76657
2366
2367         Reviewed by Simon Hausmann.
2368
2369         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2370         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
2371         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
2372
2373 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2374
2375         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
2376
2377         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
2378         building with MinGW inside cmd.exe will require the same construct. Instead
2379         we assume that when the first character in PWD is a '/' we're running under
2380         Cygwin, and use the normal unix way of setting environment variables.
2381
2382         Reviewed by Simon Hausmann.
2383
2384         * qmake/mkspecs/features/default_pre.prf:
2385
2386 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
2387
2388         Some qmake build files must include Qt5's "quick" module.
2389         https://bugs.webkit.org/show_bug.cgi?id=76671
2390
2391         Unreviewed build fix.
2392
2393         * MiniBrowser/qt/MiniBrowser.pro:
2394         * WebKitTestRunner/Target.pri:
2395
2396 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
2397
2398         [Qt] Fix the event timestamps for touch mocking
2399
2400         Reviewed by Simon Hausmann.
2401
2402         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2403         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
2404         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
2405
2406 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2407
2408         [GTK] Implement DownloadClient in WebKit2 GTK+ API
2409         https://bugs.webkit.org/show_bug.cgi?id=72952
2410
2411         Reviewed by Martin Robinson.
2412
2413         * gtk/generate-gtkdoc:
2414         (get_webkit2_options): Ignore WebKitDownloadClient.
2415
2416 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
2417
2418         [GTK] editing/deleting/5408255.html results are incorrect
2419         https://bugs.webkit.org/show_bug.cgi?id=53644
2420
2421         Reviewed by Martin Robinson.
2422
2423         WEBKIT_TOP_LEVEL environment variable is now set directly in either
2424         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
2425         macro. This way both tools can be run outside the test harness without
2426         the need to manually set the environment variable.
2427
2428         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2429         (getTopLevelPath):
2430         * GNUmakefile.am:
2431         * Scripts/webkitpy/layout_tests/port/gtk.py:
2432         (GtkPort.setup_environ_for_server):
2433         * WebKitTestRunner/GNUmakefile.am:
2434         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
2435         (WTR::InjectedBundle::platformInitialize):
2436
2437 2012-01-23  Dmitry Lomov  <dslomov@google.com>
2438
2439         [Chromium] Implement layoutTestController.workerThreadCount in DRT
2440         https://bugs.webkit.org/show_bug.cgi?id=74653.
2441
2442         Reviewed by Darin Fisher.
2443
2444         * DumpRenderTree/chromium/LayoutTestController.cpp:
2445         (LayoutTestController::LayoutTestController):
2446         (LayoutTestController::workerThreadCount):
2447         * DumpRenderTree/chromium/LayoutTestController.h:
2448
2449 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2450
2451         nrwt: make --chromium work like --qt
2452         https://bugs.webkit.org/show_bug.cgi?id=76875
2453
2454         Reviewed by Adam Barth.
2455
2456         --chromium used to have to be handled differently from --qt
2457         due to the way the PortFactory was implemented; there's not
2458         really a good reason for that any more so this patch makes
2459         things slightly more consistent and eliminates the
2460         options.chromium flag (--chromium is now truly a synonym for
2461         --platform chromium).
2462
2463         * Scripts/webkitpy/layout_tests/port/factory.py:
2464         (PortFactory._default_port):
2465         (PortFactory.get):
2466         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2467         (FactoryTest.setUp):
2468         (FactoryTest.test_chromium_mac):
2469         (FactoryTest.test_chromium_linux):
2470         (FactoryTest.test_chromium_win):
2471         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2472         (parse_args):
2473
2474 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
2475
2476         run-webkit-tests needs to propagate --chromium
2477         https://bugs.webkit.org/show_bug.cgi?id=76870
2478
2479         Reviewed by Eric Seidel.
2480
2481         run-webkit-tests removes '--chromium' argument from @ARGV when
2482         determining which port to run, which means that that doesn't
2483         propagate to new-run-webkit-tests. That's bad (and is handled
2484         for the other ports by re-adding the flag, but apparently we're
2485         just now noticing for Chromium).
2486
2487         * Scripts/run-webkit-tests:
2488
2489 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
2490
2491         More build fixing after r105646.
2492
2493         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2494         (TestWebKitAPI::TestNode::key):
2495
2496 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
2497
2498         Unreviewed build fix - r105646 broke this.
2499
2500         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2501         (TestWebKitAPI::TestNode::TestNode):
2502         (TestWebKitAPI::TestNode::key):
2503         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
2504         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
2505         (TestWebKitAPI::RedBlackTreeTest::testDriver):
2506
2507 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2508
2509         Unreviewed, rolling out r105658.
2510         http://trac.webkit.org/changeset/105658
2511         https://bugs.webkit.org/show_bug.cgi?id=76883
2512
2513         We want this eventually, but not right at this moment
2514         (Requested by abarth on #webkit).
2515
2516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2517
2518 2012-01-23  Adam Barth  <abarth@webkit.org>
2519
2520         garden-o-matic should support Chromium Mac Lion
2521         https://bugs.webkit.org/show_bug.cgi?id=76880
2522
2523         Reviewed by Eric Seidel.
2524
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2526
2527 2012-01-23  Emil A Eklund  <eae@chromium.org>
2528
2529         check-webkit-style whitespace/operators triggers on overloaded division operator
2530         https://bugs.webkit.org/show_bug.cgi?id=76650
2531
2532         Reviewed by Darin Adler.
2533
2534         * Scripts/webkitpy/style/checkers/cpp.py:
2535         (check_spacing):
2536         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2537         (CppStyleTest.test_operator_methods):
2538
2539 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2540
2541         run-perf-tests should report server-side errors
2542         https://bugs.webkit.org/show_bug.cgi?id=76802
2543
2544         Reviewed by Tony Chang.
2545
2546         Report errors whenever server's response doesn't match "OK".
2547
2548         * Scripts/webkitpy/common/net/file_uploader.py:
2549         (FileUploader.upload_single_text_file):
2550         (FileUploader.upload_as_multipart_form_data):
2551         (FileUploader._upload_data.callback):
2552         (FileUploader):
2553         (FileUploader._upload_data):
2554         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2555         (PerfTestsRunner._upload_json):
2556         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2557         (test_upload_json):
2558         (test_upload_json.MockFileUploader.upload_single_text_file):
2559
2560 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2561
2562         run-perf-tests ignore Skipped list on chromium
2563         https://bugs.webkit.org/show_bug.cgi?id=76764
2564
2565         Reviewed by Dirk Pranke.
2566
2567         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2568         can also find skipped list. Chromium port only uses test_expectations.txt for
2569         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2570         also needs to use Skipped list.
2571
2572         * Scripts/webkitpy/layout_tests/port/base.py:
2573         (Port._tests_from_skipped_file_contents):
2574         (Port):
2575         (Port._expectations_from_skipped_files):
2576         (Port.skipped_perf_tests):
2577         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2578         (PortTest.test_skipped_perf_tests):
2579         (PortTest.test_skipped_perf_tests.add_text_file):
2580         * Scripts/webkitpy/layout_tests/port/webkit.py:
2581         (WebKitPort._skipped_tests_for_unsupported_features):
2582         (WebKitPort._skipped_file_search_paths):
2583         (WebKitPort.skipped_layout_tests):
2584
2585 2012-01-23  Andy Estes  <aestes@apple.com>
2586
2587         Fix the build after r105635.
2588
2589         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2590         (TestWebKitAPI::TEST):
2591
2592 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2593
2594         Basic enhancements to StringBuilder
2595         https://bugs.webkit.org/show_bug.cgi?id=67081
2596
2597         Reviewed by Darin Adler.
2598
2599         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2600         (TestWebKitAPI::TEST):
2601
2602 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2603
2604         [GTK] run-gtk-tests randomly fails while running the xprop comand
2605         https://bugs.webkit.org/show_bug.cgi?id=76817
2606
2607         Reviewed by Gustavo Noronha Silva.
2608
2609         No need to use xprop to remove the AT_SPI_BUS property since
2610         run-gtk-tests will always run new instances of Xvfb.
2611
2612         * Scripts/run-gtk-tests:
2613         (TestRunner): Unskip TestWebKitAccessibility.
2614         (TestRunner.run): Uncomment lines for launching the accessibility
2615         bus and registry daemon, and remove lines for running xprop.
2616
2617 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2618
2619         [Qt] Don't warn about override and final being C++11 extensions
2620
2621         Clang will emit a warning when these extensions are used without passing
2622         --std=c++11, but we use feature checking to decide if we have the right
2623         extensions, so we can safely ignore these warnings. The XCode and Windows
2624         project files have the same workaround.
2625
2626         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2627         we only have one extra compiler for Objective-C, which is also used for
2628         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2629         make sense for Objective-C.
2630
2631         Reviewed by Simon Hausmann.
2632
2633         * qmake/mkspecs/features/unix/default_post.prf:
2634
2635 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2636
2637         [Qt] Change how build-webkit decides when to do full incremental builds
2638
2639         Instead of relying on update-webkit (which isn't run on the bots) to
2640         decide when to do a full incremental build (make qmake), we let the
2641         build-webkit script itself check the current SVN revision against the
2642         previous build (by storing it in .webkit.config).
2643
2644         If the two differ we assume a full incremental build is needed, since
2645         the new revisions might have introduced problematic things like new
2646         Q_OBJECT macros. If not, we assume the developer is doing changes
2647         locally, and revert to doing a plain 'make'.
2648
2649         In addition, when the build fails in the latter case, we inform the
2650         developer of possible pitfalls and how to manually run 'make qmake'.
2651
2652         Reviewed by Ossy.
2653
2654         * Scripts/update-webkit:
2655         * Scripts/webkitdirs.pm:
2656         (buildQMakeProjects):
2657
2658 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2659
2660         [GTK] run-gtk-tests randomly fails while running the xprop comand
2661         https://bugs.webkit.org/show_bug.cgi?id=76817
2662
2663         Reviewed by Philippe Normand.
2664
2665         Temporarily comment the lines related to launching the ATSPI bus
2666         and registry daemon, which are making the bots to fail randomly.
2667
2668         * Scripts/run-gtk-tests:
2669         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2670         properly if the ATSPI infrastructure is not properly initialized.
2671         (TestRunner.run): Comment lines related to initialization of ATSPI.
2672
2673 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2674
2675         Windows python test build fix.
2676
2677         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2678         (PerfTestsRunner.__init__):
2679
2680 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2681
2682         [GTK] DumpRenderTree converts "file:///" to a path differently
2683         https://bugs.webkit.org/show_bug.cgi?id=76631
2684
2685         Reviewed by Martin Robinson.
2686
2687         DumpRenderTree should print "/" as the last path component if the
2688         path is a lone slash instead of empty output.
2689
2690         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2691         (webViewConsoleMessage):
2692
2693 2012-01-20  David Levin  <levin@chromium.org>
2694
2695         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2696         https://bugs.webkit.org/show_bug.cgi?id=76752
2697
2698         Reviewed by Eric Seidel.
2699
2700         * Scripts/webkitpy/style/checkers/cpp.py:
2701         (check_for_leaky_patterns):
2702         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2703         (LeakyPatternTest.test_create_dc):
2704         (LeakyPatternTest.test_create_compatible_dc):
2705
2706 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2707
2708         Changed my status in commiters.py
2709
2710         Unreviewed.
2711
2712         * Scripts/webkitpy/common/config/committers.py:
2713
2714 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2715
2716         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2717         https://bugs.webkit.org/show_bug.cgi?id=76748
2718
2719         Reviewed by Ryosuke Niwa.
2720
2721         It crawls the whole subtree and then doesn't use the data. Cutting this out
2722         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2723
2724         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2725         (run):
2726
2727 2012-01-20  Adam Barth  <abarth@webkit.org>
2728
2729         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2730         up slightly nicer when there aren't any failures.
2731
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2733         (#summary):
2734
2735 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2736
2737         run-perf-tests should support --test-results-server option
2738         https://bugs.webkit.org/show_bug.cgi?id=76680
2739
2740         Reviewed by Adam Barth.
2741
2742         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2743         to be used by perf bots. Also refactor file_uploader as needed.
2744
2745         * Scripts/webkitpy/common/net/file_uploader.py:
2746         (FileUploader.__init__):
2747         (FileUploader.upload_single_file):
2748         (FileUploader.upload_as_multipart_form_data):
2749         (FileUploader):
2750         (FileUploader._upload_data):
2751         (FileUploader._upload_data.callback):
2752         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2753         (JSONResultsGeneratorBase.upload_json_files):
2754         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2755         (PerfTestsRunner):
2756         (PerfTestsRunner._parse_args):
2757         (PerfTestsRunner.run):
2758         (PerfTestsRunner._generate_json):
2759         (PerfTestsRunner._upload_json):
2760         (PerfTestsRunner._run_tests_set):
2761         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2762         (create_runner):
2763         (test_run_with_upload_json):
2764         (test_run_with_upload_json.mock_upload_json):
2765         (test_upload_json):
2766         (test_upload_json.MockFileUploader):
2767         (test_upload_json.MockFileUploader.__init__):
2768         (test_upload_json.MockFileUploader.upload_single_file):
2769         (test_parse_args):
2770
2771 2012-01-20  Adam Barth  <abarth@webkit.org>
2772
2773         The party time image overlaps real content!  This patch makes the
2774         image centered vertically.
2775
2776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2777         (#onebar.partytime #summary):
2778
2779 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2780
2781         Refactor TestExpectationsParser in preparation for caching the results
2782         https://bugs.webkit.org/show_bug.cgi?id=76669
2783
2784         Reviewed by Dimitri Glazkov.
2785
2786         Make everything private expect for the parse method. 
2787         Eventually, we'll need the expectations lines to not be modified
2788         outside of TestExpectationsParser so we can cache the results.
2789         This makes check-webkit-style of the chromium test_expectations.txt file
2790         go from ~17 seconds to ~12 seconds on my Mac Pro.
2791
2792         This patch is just a refactor in preparation, so no new tests.
2793
2794         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2795         (TestExpectationEditorTests.make_parsed_expectation_lines):
2796         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2797         (TestExpectationParser.parse):
2798         (TestExpectationParser):
2799         (TestExpectationParser._parse_line):
2800         (TestExpectationParser._tokenize):
2801         (TestExpectationParser._tokenize_list):
2802         (TestExpectationsModel._clear_expectations_for_test):
2803         (TestExpectations.__init__):
2804         (TestExpectations._add_expectations):
2805         (TestExpectations._add_skipped_tests):
2806         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2807         (TestExpectationParserTests.test_tokenize_blank):
2808         (TestExpectationParserTests.test_tokenize_missing_colon):
2809         (TestExpectationParserTests.test_tokenize_extra_colon):
2810         (TestExpectationParserTests.test_tokenize_empty_comment):
2811         (TestExpectationParserTests.test_tokenize_comment):
2812         (TestExpectationParserTests.test_tokenize_missing_equal):
2813         (TestExpectationParserTests.test_tokenize_extra_equal):
2814         (TestExpectationParserTests.test_tokenize_valid):
2815         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2816         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2817         (TestExpectationParserTests.test_parse_empty_string):
2818         (TestExpectationSerializerTests.assert_round_trip):
2819         (TestExpectationSerializerTests.assert_list_round_trip):
2820         * Scripts/webkitpy/tool/commands/expectations.py:
2821         (OptimizeExpectations.execute):
2822         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2823         (GardeningExpectationsUpdater.update_expectations):
2824
2825 2012-01-20  Adam Barth  <abarth@webkit.org>
2826
2827         Follow-up to previous patch: don't produce NaN when the revision number
2828         is missing.
2829
2830         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2832
2833 2012-01-20  Adam Barth  <abarth@webkit.org>
2834
2835         Garden-o-matic should tell me which revisions have been checked by all the bots
2836         https://bugs.webkit.org/show_bug.cgi?id=76722
2837
2838         Reviewed by Dimitri Glazkov.
2839
2840         This information helps me know when it's safe for me to roll a
2841         candidate revision.
2842
2843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2846
2847 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2848
2849         build-webkit: Don't spit out congratulations message on Ctrl+C
2850
2851         Reviewed by Andreas Kling.
2852
2853         * Scripts/build-webkit:
2854
2855 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2856
2857         [GTK] Allow extra jhbuild modulesets
2858         https://bugs.webkit.org/show_bug.cgi?id=76691
2859
2860         Reviewed by Gustavo Noronha Silva.
2861
2862         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2863         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2864         env variables respectively. Use comma-separated values. Example:
2865         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2866
2867 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2868
2869         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2870         https://bugs.webkit.org/show_bug.cgi?id=72589
2871
2872         Reviewed by Martin Robinson.
2873
2874         Ensure the accessibility infrastructure is available when running
2875         the unit tests, otherwise WK2's accessibility tests won't work.
2876
2877         * Scripts/run-gtk-tests:
2878         (TestRunner):
2879         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2880         where at-spi2's stuff is located (like at-spi-bus-launcher and
2881         at-spi2-registryd).
2882         (TestRunner.run): Initialize the accessibility infrastructure.
2883
2884         * gtk/generate-gtkdoc:
2885         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
2886
2887         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
2888
2889 2012-01-20  Hayato Ito  <hayato@chromium.org>
2890
2891         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
2892         https://bugs.webkit.org/show_bug.cgi?id=76353
2893
2894         Reviewed by Hajime Morita.
2895
2896         Add ShadowRoot.idl, which is enabled only on chromium port since this is
2897         under development feature.
2898         ShadowRoot.idl contains minimum API so that we can test it.
2899         Other APIs should be added on other changes so that we can isolate issues.
2900
2901         * DumpRenderTree/chromium/TestShell.cpp:
2902         (TestShell::TestShell):
2903
2904 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2905
2906         [GTK] GTK's DRT not to log events for already defunct objects
2907         https://bugs.webkit.org/show_bug.cgi?id=76620
2908
2909         Reviewed by Martin Robinson.
2910
2911         Do not log 'state-change:defunct' events.
2912
2913         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2914         (printAccessibilityEvent): Early return if a
2915         'state-change:defunct' signal is passed.
2916         (axObjectEventListener): Pass the signal name and value in
2917         separate parameters to printAccessibilityEvent.
2918
2919 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2920
2921         Unreviewed build fix. Wrong variable being used as the cwd for git
2922         remote update command.
2923
2924         * gtk/run-with-jhbuild:
2925         (update_jhbuild):
2926
2927 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2928
2929         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
2930         https://bugs.webkit.org/show_bug.cgi?id=76585
2931
2932         Reviewed by Martin Robinson.
2933
2934         This allows us to specify a minimum version of jhbuild required,
2935         while also providing stability against changes done to the master
2936         branch, by letting us choose what is the exact version that will
2937         be used.
2938
2939         * gtk/run-with-jhbuild: refactored for more hackability and easier
2940         reading
2941         (jhbuild_installed): checks whether jhbuild is installed
2942         (jhbuild_cloned): checks whether jhbuild has been cloned
2943         (jhbuild_at_expected_revision): checks whether jhbuild is at the
2944         expected revision
2945         (update_jhbuild): brings jhbuild to the expected revision
2946         (clone_jhbuild): clones jhbuild
2947         (install_jhbuild): build and installs jhbuild
2948         (update_webkitgtk_libs): runs update-webkitgtk-libs
2949         (ensure_jhbuild): high-level logic to decide whether and which of
2950         the steps above are executed
2951
2952 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2953
2954         [WK2] DumpRenderTree converts "file:///" to a path differently
2955         https://bugs.webkit.org/show_bug.cgi?id=76653
2956
2957         Reviewed by John Sullivan.
2958
2959         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
2960         Do print a slash if there are no path components.
2961
2962 2012-01-19  Eric Seidel  <eric@webkit.org>
2963
2964         webkit-patch cannot rollout patches without changelog/bug number
2965         https://bugs.webkit.org/show_bug.cgi?id=75962
2966
2967         Reviewed by Adam Barth.
2968
2969         * Scripts/webkitpy/tool/commands/download.py:
2970         (AbstractRolloutPrepCommand._prepare_state):
2971         * Scripts/webkitpy/tool/commands/download_unittest.py:
2972         (AbstractRolloutPrepCommandTest.test_prepare_state):
2973
2974 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2975
2976         [WK2] fast/url/degenerate-file-base.html fails
2977         https://bugs.webkit.org/show_bug.cgi?id=76619
2978
2979         Reviewed by Adam Roben.
2980
2981         A URL generated form local path for loading had an extra slash, making document.URL
2982         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
2983
2984         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
2985
2986 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2987
2988         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
2989         https://bugs.webkit.org/show_bug.cgi?id=76510
2990
2991         Reviewed by Adam Barth.
2992
2993         Unlike other style rules, if you get the syntax of the test_expectations.txt
2994         file wrong, the layout tests won't run. Also, this check is simple and only
2995         slows down committing if you actually modify one of the test_expectations.txt files.
2996
2997         * Scripts/webkitpy/style/checkers/test_expectations.py:
2998         (TestExpectationsChecker.check_test_expectations):
2999         (TestExpectationsChecker.check):
3000         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3001         (TestExpectationsTestCase.test_check_covers_all_configurations):
3002         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
3003         (TestExpectationsTestCase):
3004         (assert_lines_lint):
3005
3006 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3007
3008         Build fix. Revert an unintentional change to WebKitDriver in r105443.
3009
3010         * Scripts/webkitpy/layout_tests/port/driver.py:
3011         (DriverProxy.__init__):
3012
3013 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
3014
3015         remove the duplicated build rules from WebKit.gyp, Tools.gyp
3016         https://bugs.webkit.org/show_bug.cgi?id=73384
3017
3018         Reviewed by Tony Chang.
3019
3020         This patch removes the no-longer-necessary conditional logic for
3021         build_webkit_exes_from_webkit_gyp; we now always build the exes
3022         from their own dedicated gyp files.
3023
3024         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3025
3026 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
3027
3028         make-new-script-test should work with HTTP tests
3029         https://bugs.webkit.org/show_bug.cgi?id=76603
3030
3031         Reviewed by Adam Roben.
3032
3033         * Scripts/make-new-script-test:
3034         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
3035         now also creates absolute paths for HTTP.
3036
3037 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
3038
3039         Some perf tests time out when ran by run-perf-tests
3040         https://bugs.webkit.org/show_bug.cgi?id=76612
3041
3042         Reviewed by Dirk Pranke and Eric Seidel.
3043
3044         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
3045         Otherwise some tests such as Parser/xml-parser.html will timeout.
3046
3047         --no-timeout option is currently supported by Chromium and Mac ports.
3048
3049         * Scripts/webkitpy/layout_tests/port/base.py:
3050         (Port.to.create_driver):
3051         * Scripts/webkitpy/layout_tests/port/chromium.py:
3052         (ChromiumDriver.__init__):
3053         (ChromiumDriver._wrapper_options):
3054         * Scripts/webkitpy/layout_tests/port/driver.py:
3055         (Driver.__init__):
3056         (DriverProxy.__init__):
3057         * Scripts/webkitpy/layout_tests/port/webkit.py:
3058         (WebKitDriver.__init__):
3059         (WebKitDriver.cmd_line):
3060         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3061         (WebKitDriverTest.test_read_binary_block):
3062         (WebKitDriverTest):
3063         (WebKitDriverTest.test_no_timeout):
3064         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3065         (get_tests_run.RecordingTestDriver.__init__):
3066         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3067         (PerfTestsRunner._parse_args):
3068         (PerfTestsRunner._run_tests_set):
3069         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3070         (create_runner):
3071
3072 2012-01-19  Ben Wells  <benwells@chromium.org>
3073
3074         Add support for window.print to chromium DRT
3075         https://bugs.webkit.org/show_bug.cgi?id=76479
3076
3077         When used in a test window.print goes into print mode and then
3078         straight out again. This will allow the afterprint event to be
3079         tested by having the afterprint event happen before the dump
3080         happens.
3081
3082         Reviewed by Mihai Parparita.
3083
3084         * DumpRenderTree/chromium/WebViewHost.cpp:
3085         (WebViewHost::printPage):
3086         * DumpRenderTree/chromium/WebViewHost.h:
3087
3088 2012-01-18  Enrica Casucci  <enrica@apple.com>
3089
3090         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
3091         https://bugs.webkit.org/show_bug.cgi?id=76588
3092         <rdar://problem/9325183>
3093
3094         Added test.
3095         
3096         Reviewed by Dan Bernstein.
3097
3098         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3099         (TestWebKitAPI::TEST):
3100
3101 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3102
3103         [Qt] Do full incremental builds until bots use update-webkit
3104
3105         Rubber-stamped by Simon Hausmann.
3106
3107         * Scripts/webkitdirs.pm:
3108         (buildQMakeProjects):
3109
3110 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3111
3112         Fix the Qt build
3113
3114         Unreviewed build fix.
3115
3116         * Scripts/webkitdirs.pm:
3117         (buildQMakeProjects):
3118
3119 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3120
3121         [Qt] Make build-webkit always do safe incremental builds after update-webkit
3122
3123         When building against Qt5 with GCC we would just run 'make' in the build dir,
3124         and rely on the dependency files output by GCC (-MD) to handle dependency
3125         tracking, but that fails for special-cases like adding a Q_OBJECT macro
3126         to a header.
3127
3128         To guarantee that an incrmental build will work, we have to run 'make qmake',
3129         which we now do on every build-webkit that's followed by a successful run
3130         of update-webkit. The reasoning is that update-webkit can result in such
3131         potential corner-cases being applied, and since we can't know for sure
3132         unless we inspect the diff and account for all the corner cases we assume
3133         the worst and always run 'make qmake'.
3134
3135         After a succesful run of build-webkit we proceed to do just 'make' for any
3136         subsequent runs, since we assume that the developer knows what kind of
3137         changes he/she is doing, and when a 'make qmake' is needed.
3138
3139         Reviewed by Simon Hausmann.
3140
3141         * Scripts/update-webkit:
3142         * Scripts/webkitdirs.pm:
3143         (determineCurrentSVNRevision):
3144         (currentSVNRevision):
3145         (buildQMakeProjects):
3146         * qmake/mkspecs/features/default_post.prf:
3147
3148 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3149
3150         run-perf-tests should support Skipped list
3151         https://bugs.webkit.org/show_bug.cgi?id=76594
3152
3153         Reviewed by Adam Barth.
3154
3155         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
3156
3157         * Scripts/webkitpy/layout_tests/port/base.py:
3158         (Port.perf_tests_dir):
3159         (Port.skipped_perf_tests):
3160         (Port.skips_perf_test):
3161         (Port.relative_perf_test_filename):
3162         * Scripts/webkitpy/layout_tests/port/test.py:
3163         (TestPort.perf_tests_dir):
3164         * Scripts/webkitpy/layout_tests/port/webkit.py:
3165         (WebKitPort._expectations_from_skipped_files):
3166         (WebKitPort):
3167         (WebKitPort.skipped_layout_tests):
3168         (WebKitPort.skipped_perf_tests):
3169         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3170         (PerfTestsRunner._collect_tests):
3171         (PerfTestsRunner.run):
3172         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3173         (test_run_test_set_with_json_output):
3174         (test_run_test_set_with_json_source):
3175         (test_collect_tests_with_skipped_list):
3176         (test_collect_tests_with_skipped_list.add_file):
3177
3178 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3179
3180         Fix path to chromium_src_dir introduced in previous change.
3181
3182         Unreviewed, build fix.
3183
3184         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3185
3186 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
3187
3188         Need infrastructure to test Content-Disposition filename encoding support
3189         https://bugs.webkit.org/show_bug.cgi?id=76572
3190         <rdar://problem/6421825>
3191
3192         Reviewed by Sam Weinig.
3193
3194         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
3195
3196         WebKitTestRunner does not have a policy delegate yet, bug 42546.
3197
3198         * DumpRenderTree/mac/PolicyDelegate.mm:
3199         (dispositionTypeFromContentDispositionHeader):
3200         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
3201
3202 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3203
3204         Fix tests from http://trac.webkit.org/changeset/105332.
3205
3206         The code assumed that if you passed an options object with a configuration
3207         attribute that it would have a valid value. A bunch of the testing mocks
3208         do things like having a configuration value of None.
3209
3210         * Scripts/webkitpy/layout_tests/port/base.py:
3211         (Port.__init__):
3212
3213 2012-01-18  Ojan Vafai  <ojan@chromium.org>
3214
3215         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
3216         https://bugs.webkit.org/show_bug.cgi?id=76576
3217
3218         Reviewed by Adam Barth.
3219
3220         Avoid calling default_configuration in base.py. We don't need it for
3221         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
3222         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
3223         from common.executive.
3224
3225         At some point someone should probably look into why that call is so slow
3226         since it's on the critical path for run-webkit-tests and build-webkit startup.
3227
3228         * Scripts/webkitpy/layout_tests/port/base.py:
3229         (Port.__init__):
3230         * Scripts/webkitpy/style/checkers/test_expectations.py:
3231         (TestExpectationsChecker._determine_port_from_exepectations_path):
3232
3233 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
3234
3235         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
3236         https://bugs.webkit.org/show_bug.cgi?id=76505
3237
3238         Reviewed by Tony Chang.
3239
3240         Update chromium build script to use All.gyp instead of WebKit.gyp
3241
3242         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
3243         * Scripts/webkitdirs.pm:
3244
3245 2012-01-18  Sam Weinig  <sam@webkit.org>
3246
3247         Don’t hardcode the path to ‘make‘.
3248
3249         Reviewed by Dan Bernstein.
3250
3251         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3252
3253 2012-01-18  Joshua Bell  <jsbell@chromium.org>
3254
3255         Adding myself to committers.py
3256         https://bugs.webkit.org/show_bug.cgi?id=76569
3257
3258         Unreviewed.
3259
3260         * Scripts/webkitpy/common/config/committers.py:
3261
3262 2012-01-18  Adam Barth  <abarth@webkit.org>
3263
3264         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
3265         https://bugs.webkit.org/show_bug.cgi?id=76567
3266
3267         Reviewed by Eric Seidel.
3268
3269         Current the AppleMac port has slightly more failures than we allow on
3270         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
3271         which should hopefully let the mac-ews run to completion.  Once
3272         AppleMac has fewer failures, we can lower the cap again.
3273
3274         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3275         (LayoutTestResultsReaderTest.test_layout_test_results):
3276         * Scripts/webkitpy/tool/steps/runtests.py:
3277         (RunTests):
3278         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3279
3280 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
3281
3282         Provide access to user's list of preferred languages
3283         https://bugs.webkit.org/show_bug.cgi?id=76138
3284
3285         Reviewed by Alexey Proskuryakov.
3286
3287         * GNUmakefile.am: Add JSInternalsCustom.cpp.
3288
3289 2012-01-18  Adam Barth  <abarth@webkit.org>
3290
3291         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
3292         configurations.
3293
3294         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3295         (ChromiumLinuxPort.__init__):
3296
3297 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
3298
3299         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3300         https://bugs.webkit.org/show_bug.cgi?id=73460
3301
3302         Reviewed by Chris Fleizach.
3303
3304         * DumpRenderTree/AccessibilityUIElement.h:
3305         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3306         (AccessibilityUIElement::AccessibilityUIElement):
3307         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3308         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3309         (AccessibilityUIElement::scrollToGlobalPointCallback):
3310         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3311         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3312         (AccessibilityUIElement::scrollToMakeVisible):
3313         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3314         (AccessibilityUIElement::scrollToGlobalPoint):
3315         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3316         (AccessibilityUIElement::scrollToMakeVisible):
3317         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3318         (AccessibilityUIElement::scrollToGlobalPoint):
3319         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3320         (AccessibilityUIElement::scrollToMakeVisible):
3321         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3322         (AccessibilityUIElement::scrollToGlobalPoint):
3323
3324 2012-01-17  Enrica Casucci  <enrica@apple.com>
3325
3326         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
3327         https://bugs.webkit.org/show_bug.cgi?id=76490
3328         <rdar://problem/9460733>
3329
3330         Added TestWebKitAPI test.
3331         
3332         Reviewed by Dan Bernstein.
3333
3334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
3335         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
3336         changeAttributes to the WebView.
3337         
3338 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
3339
3340         [Qt] Consolidate layout test crash logging
3341         https://bugs.webkit.org/show_bug.cgi?id=75088
3342
3343         Reviewed by Simon Hausmann.
3344
3345         Move backtrace generating logic into WTFReportBacktrace
3346         and add a way to deinstall signal handlers if we know
3347         that we have already printed the backtrace.
3348
3349         * DumpRenderTree/qt/main.cpp:
3350         (crashHandler):
3351         (setupSignalHandlers):
3352         (WTFCrashHook):
3353         (main):
3354         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3355         (WTR::crashHandler):
3356         (WTR::setupSignalHandlers):
3357         (WTR::crashHook):
3358         (WTR::InjectedBundle::platformInitialize):
3359
3360 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
3361
3362         Unreviewed build fix after r105256.
3363
3364         There was a cyclic dependency between self._port and self._host assigments.
3365
3366         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3367         (PerfTestsRunner.__init__):
3368
3369 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3370
3371         Add new watchlist rule for the Qt build system
3372
3373         Reviewed by Simon Hausmann.
3374
3375         * Scripts/webkitpy/common/config/watchlist:
3376
3377 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3378
3379         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
3380
3381         Reviewed by Simon Hausmann.
3382
3383         * Tools.pro:
3384
3385 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3386
3387         [Qt] Allow building only a subset of the WebKit sub-projects
3388
3389         Fixes build-jsc, broken in r104825.
3390
3391         We no longer need the intermediate buildQMakeQtProject(), as we're the
3392         only port using qmake, and buildQMakeProject is now highly Qt specific.
3393
3394         <http://webkit.org/b/76179>
3395
3396         Reviewed by Simon Hausmann.
3397
3398         * Scripts/build-jsc:
3399         * Scripts/build-webkit:
3400         * Scripts/webkitdirs.pm:
3401         (buildQMakeProjects):
3402
3403 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
3404
3405         run-perf-tests should generate a json file that summaries the result
3406         https://bugs.webkit.org/show_bug.cgi?id=76504
3407
3408         Reviewed by Adam Barth.
3409
3410         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
3411         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
3412         another json file to be merged into the generated json file.
3413
3414         Also fixed a bug that --build wasn't set by default.
3415
3416         * Scripts/webkitpy/layout_tests/port/test.py:
3417         (TestPort.webkit_base):
3418         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3419         (PerfTestsRunner.__init__):
3420         (PerfTestsRunner):
3421         (PerfTestsRunner._parse_args):
3422         (PerfTestsRunner.run):
3423         (PerfTestsRunner._generate_json_if_specified):
3424         (PerfTestsRunner._process_chromium_style_test_result):
3425         (PerfTestsRunner._process_parser_test_result):
3426         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3427         (MainTest):
3428         (create_runner):
3429         (test_run_test_set):
3430         (test_run_test_set_for_parser_tests):
3431         (test_run_test_set_with_summary_json):
3432         (test_collect_tests):
3433         (test_parse_args):
3434
3435 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3436
3437         Unreviewed, rolling out r105244.
3438         http://trac.webkit.org/changeset/105244
3439         https://bugs.webkit.org/show_bug.cgi?id=76518
3440
3441         broke Chromium Mac (Requested by rolandsteiner on #webkit).
3442
3443         * DumpRenderTree/AccessibilityUIElement.h:
3444         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3445         (AccessibilityUIElement::AccessibilityUIElement):
3446         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3447         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3448         (AccessibilityUIElement::removeSelection):
3449         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3450         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3451         (AccessibilityUIElement::removeSelection):
3452
3453 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
3454
3455         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
3456         https://bugs.webkit.org/show_bug.cgi?id=73460
3457
3458         Reviewed by Chris Fleizach.
3459
3460         * DumpRenderTree/AccessibilityUIElement.h:
3461         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3462         (AccessibilityUIElement::AccessibilityUIElement):
3463         (AccessibilityUIElement::scrollToMakeVisibleCallback):
3464         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
3465         (AccessibilityUIElement::scrollToGlobalPointCallback):
3466         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3467         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3468         (AccessibilityUIElement::scrollToMakeVisible):
3469         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3470         (AccessibilityUIElement::scrollToGlobalPoint):
3471         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3472         (AccessibilityUIElement::scrollToMakeVisible):
3473         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3474         (AccessibilityUIElement::scrollToGlobalPoint):
3475         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3476         (AccessibilityUIElement::scrollToMakeVisible):
3477         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3478         (AccessibilityUIElement::scrollToGlobalPoint):
3479
3480 2012-01-17  Adam Barth  <abarth@webkit.org>
3481
3482         Enable tests on the mac-ews
3483         https://bugs.webkit.org/show_bug.cgi?id=76502
3484
3485         Reviewed by Simon Fraser.
3486
3487         Apple now has five machines running the mac-ews.  Lucas Forschler has
3488         asked that we try enabling tests to see if we have enough bandwidth.
3489
3490         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3491         (MacEWS):
3492
3493 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
3494
3495         Add a check-webkit-style exception for GDBInterface.cpp
3496         https://bugs.webkit.org/show_bug.cgi?id=76187
3497
3498         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
3499         that it does not fail the style check.
3500
3501         Reviewed by Martin Robinson.
3502
3503         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
3504         readability/naming tests on
3505         Source/JavaScriptCore/jit/GDBInterface.cpp.
3506         * Scripts/webkitpy/style/checker_unittest.py:
3507         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
3508         the above exception.
3509
3510 2012-01-17  Hajime Morrita  <morrita@chromium.org>
3511
3512         https://bugs.webkit.org/show_bug.cgi?id=76245
3513         [Mac][DRT] should allow query string for the file URL.
3514
3515         Reviewed by Tony Chang.
3516
3517         Taught DRT about file:// as a url instead of a file path.
3518         We are now able to use a path file:///foo/bar.html?baz as a url
3519         with which DRT opens "/foo/bar.html" with "baz" as a query string.
3520
3521         * DumpRenderTree/mac/DumpRenderTree.mm:
3522         (runTest):
3523
3524 2012-01-17  Ojan Vafai  <ojan@chromium.org>
3525
3526         Check style on test_expectations.txt files before commit
3527         https://bugs.webkit.org/show_bug.cgi?id=76484
3528
3529         Reviewed by Adam Barth.
3530
3531         Unlike other style rules, if you get the syntax of the test_expectations.txt
3532         file wrong, the layout tests won't run. Also, this check is simple and only
3533         slows down committing if you actually modify one of the test_expectations.txt files.
3534
3535         * Scripts/webkitpy/tool/steps/commit.py:
3536         (Commit._check_test_expectations):
3537         (Commit.run):
3538         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
3539         (CommitTest):
3540         (CommitTest.test_check_test_expectations):
3541
3542 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3543
3544         [Qt] Debug build fails with debug qt5
3545         https://bugs.webkit.org/show_bug.cgi?id=76463
3546
3547         Reviewed by Simon Hausmann.
3548
3549         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
3550
3551         * QtTestBrowser/cookiejar.h:
3552
3553 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3554
3555         webkitpy: fix json import on linux
3556         https://bugs.webkit.org/show_bug.cgi?id=76481
3557
3558         Reviewed by Adam Barth.
3559
3560         For some reason, the version of simplejson autoinstalled on my linux
3561         box seems to be broken. We should really only be using
3562         simplejson if json isn't available anyway, so this change looks
3563         for json first.
3564
3565         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3566         (JSONGeneratorTest.test_test_timings_trie):
3567
3568 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3569
3570         Fix failures in test-webkitpy caused by r105177.
3571
3572         Unreviewed, build fix.
3573
3574         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3575         (ChromiumLinuxPort._determine_driver_path_statically):
3576         (ChromiumLinuxPort._static_build_path):
3577
3578 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3579
3580         webkitpy: make PortFactory.get() be fully data-driven
3581         https://bugs.webkit.org/show_bug.cgi?id=76360
3582
3583         Reviewed by Eric Seidel.
3584
3585         Refactor PortFactory.get() to be fully data-driven.
3586
3587         * Scripts/webkitpy/layout_tests/port/factory.py:
3588         (PortFactory):
3589         (PortFactory._default_port):
3590         (PortFactory.get):
3591         (PortFactory.get.in):
3592         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3593         (FactoryTest.assert_port):
3594
3595 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3596
3597         webkitpy: add determine_full_port_name(), clean up port.__init__()
3598         https://bugs.webkit.org/show_bug.cgi?id=76357
3599
3600         Reviewed by Adam Barth.
3601
3602         Each Port class is now required to implement a 'port_name' field
3603         that will match the start of all ports constructed by this class and
3604         a 'determine_full_port_name' field that will make the port
3605         fully-qualified.
3606
3607         * Scripts/webkitpy/layout_tests/port/apple.py:
3608         (ApplePort.__init__):
3609         * Scripts/webkitpy/layout_tests/port/base.py:
3610         (Port):
3611         (Port.determine_port_name):
3612         (Port.__init__):
3613         * Scripts/webkitpy/layout_tests/port/chromium.py:
3614         (ChromiumPort.for):
3615         (ChromiumPort.__init__):
3616         (ChromiumPort):
3617         (ChromiumPort._chromium_base_dir):
3618         (ChromiumPort.path_from_chromium_base):
3619         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3620         (ChromiumGpuLinuxPort):
3621         (ChromiumGpuLinuxPort.__init__):
3622         (ChromiumGpuMacPort):
3623         (ChromiumGpuMacPort.__init__):
3624         (ChromiumGpuWinPort):
3625         (ChromiumGpuWinPort.__init__):
3626         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3627         (ChromiumLinuxPort):
3628         (ChromiumLinuxPort.determine_port_name):
3629         (ChromiumLinuxPort.__init__):
3630         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3631         (ChromiumMacPort):
3632         (ChromiumMacPort.determine_port_name):
3633         (ChromiumMacPort.__init__):
3634         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3635         (ChromiumWinPort):
3636         (ChromiumWinPort.determine_port_name):
3637         (ChromiumWinPort.__init__):
3638         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3639         (DryRunPort):
3640         (DryRunPort.determine_port_name):
3641         (DryRunPort.__init__):
3642         * Scripts/webkitpy/layout_tests/port/efl.py:
3643         (EflPort):
3644         * Scripts/webkitpy/layout_tests/port/factory.py:
3645         (PortFactory):
3646         (PortFactory._default_port):
3647         (PortFactory.get):
3648         (PortFactory.get.in):
3649         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3650         (FactoryTest.assert_port):
3651         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3652         (GoogleChromeLinux32Port):
3653         (GoogleChromeLinux32Port.determine_port_name):
3654         (GoogleChromeLinux64Port):
3655         (GoogleChromeLinux64Port.determine_port_name):
3656         (GoogleChromeMacPort):
3657         (GoogleChromeMacPort.determine_port_name):
3658         (GoogleChromeWinPort):
3659         (GoogleChromeWinPort.determine_port_name):
3660         * Scripts/webkitpy/layout_tests/port/gtk.py:
3661         (GtkPort):
3662         * Scripts/webkitpy/layout_tests/port/mac.py:
3663         (MacPort):
3664         (MacPort.determine_port_name):
3665         (MacPort.__init__):
3666         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3667         (test_versions):
3668         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3669         (MockDRTPort):
3670         (MockDRTPort.determine_port_name):
3671         (MockDRTPort.__init__):
3672         (MockDRT):
3673         (MockDRT.determine_port_name):
3674         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3675         (PortTestCase.make_port):
3676         * Scripts/webkitpy/layout_tests/port/qt.py:
3677         (QtPort):
3678         (QtPort.determine_port_name):
3679         (QtPort.__init__):
3680         * Scripts/webkitpy/layout_tests/port/test.py:
3681         (TestPort):
3682         (TestPort.determine_port_name):
3683         (TestPort.__init__):
3684         * Scripts/webkitpy/layout_tests/port/webkit.py:
3685         (WebKitPort.__init__):
3686         * Scripts/webkitpy/layout_tests/port/win.py:
3687         (WinPort):
3688         (WinPort.determine_port_name):
3689         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3690         (get_test_baselines.AllPlatformsPort.__init__):
3691         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3692         (get_test_config.TestMacPort):
3693         (get_test_config):
3694
3695 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3696
3697         webkitpy: clean up port code in preparation for static port names
3698         https://bugs.webkit.org/show_bug.cgi?id=76356
3699
3700         Reviewed by Adam Barth.
3701
3702         To fix bug 76215 and be able to determine appropriate port names
3703         in webkitpy without actually constructing Port objects, we need
3704         to shuffle some logic in the chromium ports to be able to figure
3705         out whether we built DRT in 32 or 64-bit mode.
3706
3707         * Scripts/webkitpy/layout_tests/port/chromium.py:
3708         (ChromiumPort):
3709         (ChromiumPort._chromium_base_dir):
3710         (ChromiumPort.__init__):
3711         (ChromiumPort.path_from_chromium_base):
3712         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3713         (ChromiumLinuxPort):
3714         (ChromiumLinuxPort._determine_driver_path_statically):
3715         (ChromiumLinuxPort._static_build_path):
3716         (ChromiumLinuxPort._determine_architecture):
3717         (ChromiumLinuxPort.__init__):
3718         (ChromiumLinuxPort._build_path):
3719
3720 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
3721
3722         Do not remove pixel failures for ref tests.
3723         https://bugs.webkit.org/show_bug.cgi?id=76243
3724
3725         Reviewed by Tony Chang.
3726
3727         'NRWT --no-pixel-tests' complains when reftests are expected to
3728         be image mismatch.
3729
3730         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3731         (Manager._update_summary_with_result):
3732         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3733         (is_reftest_failure):
3734         (determine_result_type):
3735
3736 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3737
3738         REGRESSION(r81225): ORWT should ignore reftests
3739         https://bugs.webkit.org/show_bug.cgi?id=67936
3740
3741         Reviewed by Csaba Osztrogonác.
3742
3743         * Scripts/old-run-webkit-tests:
3744         (isUsedInReftest): $filename should be the first parameter
3745         (findTestsToRun): run test if it isn't reftest
3746
3747 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
3748
3749         Unreviewed. Fix python unit test I broke with r105142
3750
3751         * Scripts/webkitpy/common/config/ports_unittest.py:
3752         (WebKitPortTest.test_gtk_port):
3753
3754 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3755
3756         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
3757
3758         Qt 5 no longer has that flag.
3759
3760         Reviewed by Simon Hausmann.
3761
3762         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3763         (MiniBrowserApplication::notify):
3764
3765 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3766
3767         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
3768         https://bugs.webkit.org/show_bug.cgi?id=75857
3769
3770         Reviewed by Adam Barth.
3771
3772         * Scripts/webkitdirs.pm:
3773         (buildAutotoolsProject): move cleaning the build to happen early,
3774         and handle --update-gtk right after that
3775         * Scripts/webkitpy/common/config/ports.py:
3776         (GtkPort.build_webkit_command): pass --update-gtk as an option to
3777         build-webkit, so that it is used in the EWS
3778
3779 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3780
3781         [Qt] Don't add _debug postfix to targets when building debug only
3782
3783         Reviewed by Simon Hausmann.
3784
3785         * qmake/mkspecs/features/default_post.prf:
3786         * qmake/mkspecs/features/functions.prf:
3787
3788 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3789
3790         [Qt] Add more files to project-files for easier navigation in Qt Creator
3791
3792         Reviewed by Simon Hausmann.
3793
3794         * Tools.pro:
3795         * qmake/config.tests/README: Added.
3796
3797 2012-01-17  Philippe Normand  <pnormand@igalia.com>
3798
3799         [GTK] fast/dom/constructed-objects-prototypes.html fails
3800         https://bugs.webkit.org/show_bug.cgi?id=75432
3801
3802         Reviewed by Martin Robinson.
3803
3804         * Scripts/build-webkit: Enable video-track in GTK.
3805
3806 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
3807
3808         Add toyoshim as a committer.
3809         https://bugs.webkit.org/show_bug.cgi?id=76390
3810
3811         Reviewed by Hajime Morita.
3812
3813         * Scripts/webkitpy/common/config/committers.py:
3814
3815 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
3816
3817         [WinCairo] Build fix after r104155. Several debug targets were not
3818         properly including the '*Common' property sheets.
3819
3820         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
3821         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
3822         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
3823         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
3824         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
3825
3826 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
3827
3828         REGRESSION(r105072): It broke committers_unittest.py
3829         https://bugs.webkit.org/show_bug.cgi?id=76396
3830
3831         Reviewed by Adam Barth.
3832
3833         * Scripts/webkitpy/common/config/committers_unittest.py:
3834         (CommittersTest._assert_fuzz_match): It should handle more names.
3835         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
3836
3837 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
3838
3839         [GTK] Include gtk+3 in the jhbuild modules
3840         https://bugs.webkit.org/show_bug.cgi?id=76284
3841
3842         Reviewed by Philippe Normand.
3843
3844         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3845
3846 2012-01-16  Dan Winship  <danw@gnome.org>
3847
3848         Add myself as a committer
3849
3850         Unreviewed
3851
3852         * Scripts/webkitpy/common/config/committers.py:
3853
3854 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3855
3856         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
3857
3858         Some recent versions of a few Linux distributions have started passing
3859         --as-needed and --no-copy-dt-needed-entries by default to the linker,
3860         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
3861         needed a few symbols from libjavascriptcore_efl.so.
3862
3863         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
3864         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
3865         libraries are searched in the right order by the linker.
3866
3867 2012-01-16  Philippe Normand  <pnormand@igalia.com>
3868
3869         [GTK] set audio resources path in NRTW
3870         https://bugs.webkit.org/show_bug.cgi?id=76380
3871
3872         Reviewed by Martin Robinson.
3873
3874         * Scripts/webkitpy/layout_tests/port/gtk.py:
3875         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
3876         the uninstalled audio resources are used during webaudio tests.
3877
3878 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3879
3880         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
3881         https://bugs.webkit.org/show_bug.cgi?id=76369
3882
3883         Reviewed by Xan Lopez.
3884
3885         If there's an installed version of webkit and there are new
3886         symbols in the build tree, gtkdoc-scanobj fails due to undefined
3887         references, because the env ldflags are given before the local
3888         ones.
3889
3890         * gtk/gtkdoc.py:
3891         (GTKDoc._run_gtkdoc_scangobj):
3892
3893 2012-01-15  Pablo Flouret  <pablof@motorola.com>
3894
3895         Fix compilation errors on build-webkit --debug --no-video on mac.
3896         https://bugs.webkit.org/show_bug.cgi?id=75867
3897
3898         Reviewed by Philippe Normand.
3899
3900         Add --[no-]video-track to build-webkit, since video track feature
3901         depends on video.
3902
3903         * Scripts/build-webkit:
3904
3905 2012-01-14  James Robinson  <jamesr@chromium.org>
3906
3907         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
3908         https://bugs.webkit.org/show_bug.cgi?id=76313
3909
3910         Reviewed by Adam Barth.
3911
3912         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
3913
3914         * Scripts/run-chromium-webkit-unit-tests:
3915
3916 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3917
3918         Unreviewed, rolling out r105017.
3919         http://trac.webkit.org/changeset/105017
3920         https://bugs.webkit.org/show_bug.cgi?id=76333
3921
3922         broke the build (Requested by philn-tp on #webkit).
3923
3924         * gtk/jhbuild.modules:
3925
3926 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
3927
3928         [GTK] Include gtk+3 in the jhbuild modules
3929         https://bugs.webkit.org/show_bug.cgi?id=76284
3930
3931         Reviewed by Philippe Normand.
3932
3933         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3934
3935 2012-01-13  Adam Barth  <abarth@webkit.org>
3936
3937         Remove --dry-run support from webkit-patch
3938         https://bugs.webkit.org/show_bug.cgi?id=76300
3939
3940         Reviewed by Dirk Pranke.
3941
3942         This is the rest of the patch from Bug 76300.  I landed it separtely
3943         because main.py had some stray conflict markers that I needed to clean
3944         up first.
3945
3946         * Scripts/webkitpy/test/main.py:
3947         (Tester.parse_args):
3948         (Tester._run_tests):
3949
3950 2012-01-13  Adam Barth  <abarth@webkit.org>
3951
3952         test-webkitpy does not run
3953         https://bugs.webkit.org/show_bug.cgi?id=76318
3954
3955         Unreviewed.
3956
3957         Looks like some conflict markers got left in the file.
3958
3959         * Scripts/webkitpy/test/main.py:
3960         (Tester.run):
3961
3962 2012-01-13  Adam Barth  <abarth@webkit.org>
3963
3964         Remove --dry-run support from webkit-patch
3965         https://bugs.webkit.org/show_bug.cgi?id=76300
3966
3967         Reviewed by Dirk Pranke.
3968
3969         We don't use this functionality for anything, and it doesn't really
3970         work.  Someone in #webkit tried using it and and got sad/confused.  We
3971         should just remove it.
3972
3973         * Scripts/webkitpy/common/checkout/scm/git.py:
3974         (Git.push_local_commits_to_server):
3975         * Scripts/webkitpy/common/checkout/scm/scm.py:
3976         (SCM.__init__):
3977         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3978         (_shared_test_commit_with_message):
3979         (GitSVNTest.test_commit_text_parsing):
3980         * Scripts/webkitpy/common/checkout/scm/svn.py:
3981         (SVN.commit_with_message):
3982         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3983         (Bugzilla.__init__):
3984         (Bugzilla.quips):
3985         (Bugzilla.authenticate):
3986         (Bugzilla.add_attachment_to_bug):
3987         (Bugzilla.add_patch_to_bug):
3988         (Bugzilla.create_bug):
3989         (Bugzilla.clear_attachment_flags):
3990         (Bugzilla.set_flag_on_attachment):
3991         (Bugzilla.obsolete_attachment):
3992         (Bugzilla.add_cc_to_bug):
3993         (Bugzilla.post_comment_to_bug):
3994         (Bugzilla.close_bug_as_fixed):
3995         (Bugzilla.reassign_bug):
3996         (reopen_bug):
3997         * Scripts/webkitpy/test/main.py:
3998         (Tester.parse_args):
3999         (Tester.run_tests):
4000
4001 2012-01-13  David Levin  <levin@chromium.org>
4002
4003         check-webkit-style: should encourage the use of Own* classes for Windows DC.
4004         https://bugs.webkit.org/show_bug.cgi?id=76227
4005
4006         Reviewed by Dirk Pranke.
4007
4008         * Scripts/webkitpy/style/checkers/cpp.py:
4009         (check_for_leaky_patterns): The new check.
4010         (process_line): Added a call to the new check.
4011         (CppChecker): Added the new error type.
4012         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4013         (CppStyleTestBase):
4014         (CppStyleTestBase.perform_leaky_pattern_check):
4015         The check for only leaky pattern errors.
4016         (LeakyPatternTest): Test cases.
4017
4018 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4019
4020         test-webkitpy: clean up handling of test directories, QueueStatusServer
4021         https://bugs.webkit.org/show_bug.cgi?id=76238
4022
4023         Reviewed by Adam Barth.
4024
4025         This patch cleans up a bunch of hacks related to how we find all
4026         of the python unit tests and set up the sys.path variable in
4027         test-webkitpy.
4028
4029         This patch changes how test-webkitpy works slightly in that we
4030         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
4031         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
4032         This greatly simplifies the mapping of paths to module names and
4033         appears to have no significant performance impact or other drawbacks.
4034
4035         There are other ways that we could remove all of the hacks and
4036         still have a more flexible mapping of paths to module names, but
4037         the ones I've thought of so far add a decent amount of complexity to
4038         the implementation and don't seem to buy us much.
4039         
4040         * QueueStatusServer/__init__.py:
4041         * Scripts/test-webkitpy:
4042         * Scripts/webkitpy/test/main.py:
4043         (Tester._modules_from_paths):
4044         (Tester._is_module):
4045
4046 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4047
4048         test-webkitpy: should support classes and individual test names as well as modules
4049         https://bugs.webkit.org/show_bug.cgi?id=76233
4050
4051         Reviewed by Adam Barth.
4052
4053         The default unittest.main() supports a list of individual
4054         TestCase classes or individual tests as well as modules. This
4055         change adds support for the same to test-webkitpy, so now you
4056         can say
4057
4058           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
4059
4060         and
4061
4062           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
4063
4064         in addition to
4065
4066           % test-wekbitpy webkitpy.test.cat_unittest
4067
4068         * Scripts/test-webkitpy:
4069         * Scripts/webkitpy/test/cat_unittest.py:
4070         * Scripts/webkitpy/test/main.py:
4071         (Tester.parse_args):
4072         (Tester.run):
4073         (Tester):
4074         (Tester._find_modules):
4075         (Tester._exclude):
4076         (Tester._run_tests):
4077         (Tester._is_module):
4078         (Tester._log_exception):
4079
4080 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4081
4082         test-webkitpy: add basic code coverage support
4083         https://bugs.webkit.org/show_bug.cgi?id=76201
4084
4085         Reviewed by Adam Barth.
4086
4087         This test adds basic code coverage support to test-webkitpy; if
4088         you pass the -c flag, we will generate a new coverage file. We
4089         can start simply with this and add more features as necessary.
4090
4091         This patch requires coverage to be already installed on the
4092         machine. I am not auto-installing this for now.
4093
4094         * Scripts/webkitpy/test/main.py:
4095         (Tester.parse_args):
4096         (Tester.run_tests):
4097
4098 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
4099
4100         StatusBubbleTest.test_build_bubble is failing
4101         https://bugs.webkit.org/show_bug.cgi?id=76222
4102
4103         Reviewed by Adam Barth.
4104
4105         * QueueStatusServer/handlers/statusbubble_unittest.py:
4106         (StatusBubbleTest.test_build_bubble):
4107
4108 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
4109
4110         nrwt should use multiple http shards
4111         https://bugs.webkit.org/show_bug.cgi?id=75958
4112
4113         Add --max-locked-shards option to the nrwt for manual set
4114         the maximum number of the locked shards
4115
4116         Reviewed by Dirk Pranke.
4117
4118         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4119         (Manager._max_locked_shards):
4120         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4121         (ShardingTests.get_shards):
4122         (ShardingTests.test_multiple_locked_shards):
4123         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4124         (parse_args):
4125
4126 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
4127
4128         prepare-ChangeLog: Look for a text editor in a few more variables.
4129         https://bugs.webkit.org/show_bug.cgi?id=76289
4130
4131         Reviewed by Ryosuke Niwa.
4132
4133         A text editor was looked for only in the CHANGE_LOG_EDITOR and
4134         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
4135         to the OS X-specific open(1) command.
4136
4137         As there does not seem to be a common way of looking for a text editor
4138         among the scripts in Tools/Scripts right now, just look at $VISUAL and
4139         $EDITOR (set much more often than the other variables in Unix systems)
4140         before falling back to open(1).
4141
4142         * Scripts/prepare-ChangeLog:
4143         (openChangeLogs):
4144
4145 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
4146
4147         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
4148         https://bugs.webkit.org/show_bug.cgi?id=76269
4149
4150         Reviewed by Martin Robinson.
4151
4152         * gtk/gtkdoc.py:
4153         (GTKDoc._run_gtkdoc_scangobj):
4154
4155 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
4156
4157         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
4158         https://bugs.webkit.org/show_bug.cgi?id=76247
4159
4160         Reviewed by Kenneth Rohde Christiansen.
4161
4162         * WebKitTestRunner/TestController.cpp:
4163         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
4164
4165 2012-01-13  Hajime Morrita  <morrita@chromium.org>
4166
4167         [Mac][DRT] Should support --no-timeout
4168         https://bugs.webkit.org/show_bug.cgi?id=76242
4169
4170         Reviewed by Darin Adler.
4171
4172         * DumpRenderTree/mac/DumpRenderTree.mm:
4173         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
4174         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
4175         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
4176         * DumpRenderTree/mac/DumpRenderTreeMac.h:
4177         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4178         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
4179
4180 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
4181
4182         Mitigate scrollbar differences when running pixel tests
4183         https://bugs.webkit.org/show_bug.cgi?id=67217
4184
4185         Reviewed by Dan Bernstein.
4186         
4187         Enable mock scrollbars by default for tests.
4188
4189         * DumpRenderTree/mac/DumpRenderTree.mm:
4190         (resetDefaultsToConsistentValues):
4191         * WebKitTestRunner/TestController.cpp:
4192         (WTR::TestController::resetStateToConsistentValues):
4193
4194 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
4195
4196         Need a script to run tests in PerformanceTests
4197         https://bugs.webkit.org/show_bug.cgi?id=76132
4198
4199         Reviewed by Adam Barth.
4200
4201         Add run-perf-tests to run performance tests using parser/resources/runner.js.
4202         Unfortunately, there isn't an easy way of telling which test uses which format
4203         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
4204
4205         All test outputs are re-formatted to match Chromium perf-bot style.
4206
4207         * Scripts/run-inspector-perf-tests.py:
4208         * Scripts/run-perf-tests: Added.
4209         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4210         (PerfTestsRunner):
4211         (PerfTestsRunner.__init__):
4212         (PerfTestsRunner._collect_tests):
4213         (PerfTestsRunner.run):
4214         (PerfTestsRunner._print_status):
4215         (PerfTestsRunner._run_tests_set):
4216         (PerfTestsRunner._process_chromium_style_test_result):
4217         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
4218         (PerfTestsRunner._process_parser_test_result):
4219         (PerfTestsRunner._run_single_test):
4220         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4221         (MainTest.TestDriver.run_test):
4222         (create_runner):
4223         (run_test):
4224         (test_run_test_set):
4225         (test_run_test_set_for_parser_tests):
4226         (test_collect_tests):
4227
4228 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
4229
4230         webkitpy: clean up port unit tests in preparation for making port_name mandatory
4231         https://bugs.webkit.org/show_bug.cgi?id=76123
4232
4233         Reviewed by Adam Barth.
4234
4235         This change updates the unit tests to be more consistent in how
4236         ports are created, in preparation for making port_name a
4237         mandatory parameter to the constructor and removing any version
4238         interpretation from it.
4239
4240         There should be no functional changes in this patch, but some
4241         tests that are no longer relevant have been removed or reworked.
4242
4243         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4244         (PortTest.test_get_option__default):
4245         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
4246         (ChromiumLinuxPortTest):
4247         (ChromiumLinuxPortTest.assert_architecture):
4248         (ChromiumLinuxPortTest.test_determine_architecture_fails):
4249         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4250         (ChromiumMacPortTest):
4251         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4252         (ChromiumPortTest):
4253         (ChromiumPortTest.test_all_test_configurations):
4254         (ChromiumPortTest.TestMacPort.__init__):
4255         (ChromiumPortTest.TestLinuxPort.__init__):
4256         (ChromiumPortTest.TestWinPort.__init__):
4257         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4258         (ChromiumWinTest):
4259         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
4260         (EflPortTest):
4261         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
4262         (GtkPortTest):
4263         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4264         (MacTest):
4265         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4266         (MockDRTPortTest):
4267         (MockDRTPortTest.make_port):
4268         * Scripts/webkitpy/layout_tests/port/qt.py:
4269         (QtPort._port_flag_for_scripts):
4270         (QtPort.__init__):
4271         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4272         (QtPortTest):
4273         (QtPortTest._assert_search_path):
4274         (QtPortTest.test_baseline_search_path):
4275         (QtPortTest.test_operating_system):
4276         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4277         (WebKitPortTest):
4278         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4279         (WinPortTest):
4280         (WinPortTest._assert_search_path):
4281         (WinPortTest.test_baseline_search_path):
4282         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
4283         (get_test_config.TestMacPort.__init__):
4284
4285 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
4286
4287         test-webkitpy: clean up logging and provide a real --help message
4288         https://bugs.webkit.org/show_bug.cgi?id=76142
4289
4290         Reviewed by Adam Barth.
4291
4292         This test is mostly more refactoring - it calls objects in
4293         unittest directly instead of routing through unittest.main() --
4294         in order to gain more control over the logging and to provide a
4295         correct --help message. This will also give us a better
4296         foundation for adding more feautures down the road.
4297
4298         This patch adds different levels of logging controlled by the
4299         '-s', '-q', and '-v' options (see --help for details), and
4300         removes the --verbose-logging option.
4301
4302         * Scripts/test-webkitpy:
4303         * Scripts/webkitpy/test/main.py:
4304         (Tester):
4305         (Tester.clean_packages):
4306         (Tester.__init__):
4307         (Tester.parse_args):
4308         (Tester.configure):
4309         (Tester._configure_logging):
4310         (Tester.find_modules):
4311         (Tester._exclude):
4312         (Tester._modules_from_paths):
4313         (Tester.run_tests):
4314
4315 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
4316
4317         Make the new WTF module build on Qt
4318         https://bugs.webkit.org/show_bug.cgi?id=76163
4319
4320         Reviewed by Tor Arne Vestbø.
4321
4322         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
4323
4324 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
4325
4326         Unreviewed, mac DumpRenderTree fix.
4327
4328         * DumpRenderTree/mac/UIDelegate.mm:
4329         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4330
4331 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
4332
4333         WebKitTestRunner should not print console message line number when it is equal to zero.
4334         https://bugs.webkit.org/show_bug.cgi?id=76167
4335
4336         Reviewed by Csaba Osztrogonác.
4337
4338         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4339         (WTR::InjectedBundlePage::willAddMessageToConsole):
4340
4341 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
4342
4343         Make default console messages line numbers consistent.
4344         https://bugs.webkit.org/show_bug.cgi?id=74075
4345
4346         Reviewed by Pavel Feldman.
4347
4348         Unset line numbers are not printed to console now.
4349         Added Source/WebCore/inspector to efl DumpRenderTree include path.
4350
4351         * DumpRenderTree/chromium/WebViewHost.cpp:
4352         (WebViewHost::didAddMessageToConsole):
4353         * DumpRenderTree/efl/CMakeLists.txt:
4354         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
4355         (onConsoleMessage):
4356         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4357         (webViewConsoleMessage):
4358         * DumpRenderTree/mac/UIDelegate.mm:
4359         (-[UIDelegate webView:addMessageToConsole:withSource:]):
4360         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4361         (WebCore::WebPage::javaScriptConsoleMessage):
4362         * DumpRenderTree/win/UIDelegate.cpp:
4363         (UIDelegate::webViewAddMessageToConsole):
4364         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
4365         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
4366
4367 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
4368
4369         test-webkitpy: push more logic into webkitpy.test.main, clean up code
4370         https://bugs.webkit.org/show_bug.cgi?id=76021
4371