Tools/ChangeLog

   1 2011-01-03  Sam Weinig  <sam@webkit.org>
   2
   3         Reviewed by Anders Carlsson.
   4
   5         Make run-api-tests less chatty.
   6         https://bugs.webkit.org/show_bug.cgi?id=51831
   7
   8         - Make script quiet by default and add --verbose option (replacing --quiet).
   9         - When not verbose, pipe stdout and stderr to devnull.
  10
  11         * Scripts/run-api-tests:
  12
  13 2011-01-03  Pratik Solanki  <psolanki@apple.com>
  14
  15         Unreviewed. Adding myself to committers.py.
  16
  17         * Scripts/webkitpy/common/config/committers.py:
  18
  19 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
  20
  21         Reviewed by Xan Lopez.
  22
  23         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
  24         https://bugs.webkit.org/show_bug.cgi?id=51806
  25
  26         Originally, the $libraryName is 'JavaScriptCore'. When building release
  27         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
  28         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
  29         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
  30         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
  31         so make it 'WebKitBuild/Release/.libs'
  32
  33         * Scripts/webkitdirs.pm:
  34
  35 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
  36
  37         Reviewed by Adam Barth.
  38
  39         Make EFL a core builder
  40         https://bugs.webkit.org/show_bug.cgi?id=51804
  41
  42         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  43         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  44
  45 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
  46
  47         [Qt] Unreviewed fix after r74855 and r74875.
  48
  49         * BuildSlaveSupport/built-product-archive:
  50          - Create directories explicitly.
  51          - Pass shell=True to subprocess.call().
  52
  53 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
  54
  55         [Qt] Unreviewed fix after r74855.
  56
  57         Move JavaScriptCore to Source
  58         https://bugs.webkit.org/show_bug.cgi?id=51604
  59
  60         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
  61
  62 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
  63
  64         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
  65
  66         Move JavaScriptCore to Source
  67         https://bugs.webkit.org/show_bug.cgi?id=51604
  68
  69         * Scripts/webkitdirs.pm:
  70
  71 2011-01-02  Robert Hogan  <robert@webkit.org>
  72
  73         Unreviewed, build fix.
  74
  75         [Qt] Fix DRT build after 74855
  76
  77         * DumpRenderTree/qt/DumpRenderTree.pro:
  78
  79 2011-01-01  Adam Barth  <abarth@webkit.org>
  80
  81         Remove the assumption from the Qt and Gtk builds that every project is
  82         in the root directory.
  83
  84         * Scripts/build-webkit:
  85
  86 2011-01-01  Adam Barth  <abarth@webkit.org>
  87
  88         Reviewed by Eric Seidel.
  89
  90         Teach svn-apply how to apply patches even though JavaScriptCore has moved
  91         https://bugs.webkit.org/show_bug.cgi?id=51796
  92
  93         After this change, svn-apply will magically apply patches to
  94         JavaScriptCore/foo to Source/JavaScriptCore/foo.
  95
  96         * Scripts/VCSUtils.pm:
  97
  98 2011-01-01  Adam Barth  <abarth@webkit.org>
  99
 100         Reviewed by Eric Seidel.
 101
 102         Move JavaScriptCore to Source
 103         https://bugs.webkit.org/show_bug.cgi?id=51604
 104
 105         Update references to JavaScriptCore to point to the new location.
 106
 107         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 108         * DumpRenderTree/qt/DumpRenderTree.pro:
 109         * DumpRenderTree/qt/ImageDiff.pro:
 110         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 111         * DumpRenderTree/wscript:
 112         * Scripts/build-jsc:
 113         * Scripts/build-webkit:
 114         * Scripts/do-file-rename:
 115         * Scripts/do-webcore-rename:
 116         * Scripts/run-javascriptcore-tests:
 117         * Scripts/update-javascriptcore-test-results:
 118         * Scripts/webkitdirs.pm:
 119         * Scripts/webkitpy/common/config/build_unittest.py:
 120         * Scripts/webkitpy/style/checker.py:
 121         * Scripts/webkitpy/style/checker_unittest.py:
 122         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 123         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 124         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 125         * wx/build/settings.py:
 126
 127 2011-01-01  Adam Barth  <abarth@webkit.org>
 128
 129         Reviewed by Eric Seidel.
 130
 131         Move Sources to Source
 132         https://bugs.webkit.org/show_bug.cgi?id=51794
 133
 134         Update scripts to point to the new location.
 135
 136         * Scripts/build-webkit:
 137         * Scripts/do-file-rename:
 138         * Scripts/do-webcore-rename:
 139         * Scripts/webkitpy/common/config/build.py:
 140         * Scripts/webkitpy/common/config/build_unittest.py:
 141
 142 2010-12-31  Kent Tamura  <tkent@chromium.org>
 143
 144         Reviewed by Eric Seidel.
 145
 146         [DRT/Chromium] Enable mock spell checker on non-OSX
 147         https://bugs.webkit.org/show_bug.cgi?id=51401
 148
 149         * DumpRenderTree/chromium/WebViewHost.cpp:
 150         (WebViewHost::spellCheck):
 151
 152 2010-12-31  Adam Barth  <abarth@webkit.org>
 153
 154         Reviewed by Ariya Hidayat.
 155
 156         Remove Tools/Scripts/wkstyle
 157         https://bugs.webkit.org/show_bug.cgi?id=51774
 158
 159         This script appears to not have been touched in a while and seems to
 160         have been replaced by check-webkit-style.
 161
 162         * Scripts/wkstyle: Removed.
 163
 164 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
 165
 166         Unreviewed. Coding style fix.
 167
 168         * DumpRenderTree/chromium/TestShell.h:
 169
 170 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
 171
 172         Reviewed by Pavel Feldman.
 173
 174         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
 175
 176         It was a problem with Chromium DRT. DevToolsAgent object instance was
 177         attached not only to the inspected page but to the DevTools window too.
 178         As result all the inspector files were interpreted as a content of inspected page
 179         and were transfered to the DevTools scripts panel for debugging etc.
 180
 181         https://bugs.webkit.org/show_bug.cgi?id=51735
 182
 183         * DumpRenderTree/chromium/TestShell.cpp:
 184         (TestShell::TestShell):
 185         (TestShell::bindJSObjectsToWindow):
 186         (TestShell::createNewWindow):
 187         * DumpRenderTree/chromium/TestShell.h:
 188
 189 2010-12-31  Adam Barth  <abarth@webkit.org>
 190
 191         Rubber-stamped by Eric Seidel.
 192
 193         Move PageLoadTests to PerformanceTests/PageLoad
 194         https://bugs.webkit.org/show_bug.cgi?id=51771
 195
 196         Update references to PageLoadTests to point to the new location.
 197
 198         * Scripts/run-pageloadtest:
 199         * Scripts/webkitpy/common/config/build.py:
 200
 201 2010-12-31  Adam Barth  <abarth@webkit.org>
 202
 203         Rubber-stamped by Eric Seidel.
 204
 205         Move SunSpider into PerformanceTests
 206         https://bugs.webkit.org/show_bug.cgi?id=51769
 207
 208         Update these scripts to point to the new location.
 209
 210         * Scripts/run-sunspider:
 211         * Scripts/sunspider-compare-results:
 212
 213 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
 214
 215         Reviewed by Kent Tamura.
 216
 217         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
 218         https://bugs.webkit.org/show_bug.cgi?id=51728
 219
 220         Add implementation of the Mac WebThemeEngine that uses an NSScroller
 221         to render top-level scrollbars. This makes them match the Mac port's
 222         use of an NSScrollView, which means that we'll be able to share more
 223         pixel baselines.
 224
 225         The new rendering code will not be activated until the
 226         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
 227         ScrollbarThemeChromiumMac.
 228
 229         * DumpRenderTree/DumpRenderTree.gypi:
 230         * DumpRenderTree/chromium/TestShellMac.mm:
 231         (platformInit):
 232         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
 233         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
 234         (+[FakeActiveWindow alwaysActiveWindow]):
 235         (+[FakeActiveWindow alwaysInactiveWindow]):
 236         (-[FakeActiveWindow initWithActiveControls:]):
 237         (-[FakeActiveWindow _hasActiveControls]):
 238         (WebThemeEngineDRTMac::paintScrollbarThumb):
 239         (stateToHIEnableState):
 240         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
 241         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
 242
 243 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
 244
 245         Reviewed by David Kilzer.
 246
 247         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
 248         used
 249         https://bugs.webkit.org/show_bug.cgi?id=51672
 250
 251         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
 252         with USE_SYSTEM_MALLOC=1
 253         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
 254         with USE_SYSTEM_MALLOC=1
 255
 256 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 257
 258         Reviewed by David Kilzer.
 259
 260         [Qt] [Symbian] Fix build-webkit script for Symbian
 261         https://bugs.webkit.org/show_bug.cgi?id=51509
 262
 263         Set the OUTPUT_DIR for Symbian to be the same as the source
 264         directory.
 265
 266         * Scripts/webkitdirs.pm:
 267
 268 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
 269
 270         Reviewed by Darin Adler.
 271
 272         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
 273         https://bugs.webkit.org/show_bug.cgi?id=51758
 274
 275         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
 276
 277         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
 278         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
 279
 280 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
 281
 282         Unreviewed WinCE buildfix.
 283
 284         * WinCELauncher/main.cpp: Add missing include.
 285
 286 2010-12-29  Daniel Bates  <dbates@rim.com>
 287
 288         Reviewed by Darin Adler.
 289
 290         svn-apply updates date of wrong change log entry for a change log diff that
 291         contains two consecutive entries with the same author and date
 292         https://bugs.webkit.org/show_bug.cgi?id=46061
 293
 294         Fixes an issue where the date of the wrong change log entry may be modified.
 295         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
 296         in a ChangeLog file to the top of the file.
 297
 298         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
 299         diff when it detects that the diff inserts a change log entry earlier in a
 300         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
 301         change. With the advent of the commit-queue this functionality of bailing out
 302         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
 303         Instead, we should always move the change log entry to the top of the ChangeLog file.
 304
 305         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
 306         the date line of the correct change log entry in a ChangeLog diff.
 307
 308         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
 309
 310         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
 311           Updated the following unit tests now that we move entries inserted earlier to the top:
 312           - "fixChangeLogPatch: New entry inserted in middle."
 313             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
 314
 315           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
 316             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
 317
 318         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
 319
 320 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
 321
 322         Reviewed by Eric Seidel.
 323
 324         [Qt] Fixed compatibility with gold linker on X11 platforms
 325         https://bugs.webkit.org/show_bug.cgi?id=51700
 326
 327         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 328         Linked TestNetscapePlugin with libX11 on Unix platforms
 329
 330 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
 331
 332         Reviewed by Darin Adler.
 333
 334         Circular dependency in webkitpy.common.checkout.changelog module
 335         https://bugs.webkit.org/show_bug.cgi?id=50475
 336
 337         Remove automatic import of api.Checkout module when any checkout/
 338         submodule is imported (e.g.: when checkout.scm.Git is imported).
 339
 340         * Scripts/webkitpy/common/checkout/__init__.py:
 341
 342 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
 343
 344         Reviewed by Ojan Vafai.
 345
 346         prepare-ChangeLog should support the -g option for specifying the git-commit
 347         https://bugs.webkit.org/show_bug.cgi?id=51708
 348
 349         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
 350         webkit-patch, though the exact meaning of the two options remain different.
 351
 352         * Scripts/prepare-ChangeLog: Add -g.
 353
 354 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
 355
 356         Reviewed by Simon Hausmann.
 357
 358         [Qt] Fix compilation with Qt in namespace
 359         https://bugs.webkit.org/show_bug.cgi?id=51701
 360
 361         * QtTestBrowser/webview.h:
 362
 363 2010-12-28  Daniel Bates  <dbates@rim.com>
 364
 365         Reviewed by Sam Weinig.
 366
 367         Substitute // MARK: for compiler-specific #pragma mark
 368         https://bugs.webkit.org/show_bug.cgi?id=51657
 369
 370         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
 371         substituting  "// MARK:" for "#pragma mark", which provides
 372         analogous code-bookmarking functionality under Xcode.
 373
 374         Also, for consistency, we should substitute "// MARK:" for compiler-
 375         specific "#pragma mark" in the source files for the Mac port.
 376
 377         * DumpRenderTree/AccessibilityTextMarker.cpp:
 378         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
 379         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
 380         * DumpRenderTree/mac/ObjCController.m:
 381         * MiniBrowser/mac/AppDelegate.m:
 382         * MiniBrowser/mac/BrowserWindowController.m:
 383
 384 2010-12-28  Xan Lopez  <xlopez@igalia.com>
 385
 386         Reviewed by Eric Seidel.
 387
 388         Add --no-build option to run-sunspider
 389         https://bugs.webkit.org/show_bug.cgi?id=51658
 390
 391         * Scripts/run-sunspider: add --no-build flag to skip building
 392         phase.
 393
 394 2010-12-27  Daniel Bates  <dbates@rim.com>
 395
 396         Rubber-stamped by Martin Robinson.
 397
 398         Append the directory Tools/DumpRenderTree to the list of directories that
 399         do-webcore-rename should search so that it can rename DRT files and
 400         source code.
 401
 402         * Scripts/do-webcore-rename:
 403
 404 2010-12-27  Eric Seidel  <eric@webkit.org>
 405
 406         Reviewed by Adam Barth.
 407
 408         build-webkit should detect missing Java SDK and explain how to install it
 409         https://bugs.webkit.org/show_bug.cgi?id=51651
 410
 411         * Scripts/build-webkit:
 412
 413 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
 414
 415         Reviewed by Daniel Bates.
 416
 417         [GTK] Add support for build-jsc
 418         https://bugs.webkit.org/show_bug.cgi?id=51625
 419
 420         Add GTK+ support to build-jsc now that building the jsc executable as
 421         a standalone target is easy.
 422
 423         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
 424         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
 425         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
 426         and pass it along to buildAutotoolsProject.
 427
 428 2010-12-27  David Levin  <levin@chromium.org>
 429
 430         Reviewed by Eric Seidel.
 431
 432         check-webkit-style check for meaningless variable names in function declarations.
 433         https://bugs.webkit.org/show_bug.cgi?id=51523
 434
 435         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
 436         from the new check and whitespace/parens because the syntax is unusual and
 437         produced a fair number of positives for these checks.
 438         * Scripts/webkitpy/style/checkers/cpp.py:
 439         (_convert_to_lower_with_underscores): Used as a canonical form for type names
 440         and parameter names when determining if the parameter name is useless.
 441         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
 442         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
 443         format.
 444         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
 445         text or an acronym of it.
 446         (check_function_definition): Checks function definitions for meaningless variable names.
 447         (process_line): Added call to check_function_definition.
 448         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 449         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
 450         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
 451         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
 452         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
 453         because when only checking a snippet, there are a lot of bogus functions.
 454         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
 455         that I put there previously and just noticed.
 456         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
 457         check_function_definition and process_line.
 458
 459 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 460
 461         Reviewed by Martin Robinson.
 462
 463         [GTK] Disable flash plugin in GtkLauncher when using gtk3
 464         https://bugs.webkit.org/show_bug.cgi?id=51591
 465
 466         Flash plugin uses gtk2 that is incompatible with gtk3 making
 467         webkit crash when it's built with gtk3.
 468
 469         * GtkLauncher/main.c:
 470         (main):
 471
 472 2010-12-25  Adam Barth  <abarth@webkit.org>
 473
 474         Reviewed by Eric Seidel.
 475
 476         Move ANGLE to Sources/ThirdParty
 477         https://bugs.webkit.org/show_bug.cgi?id=51605
 478
 479         * Scripts/build-webkit:
 480           - Point to the new ANGLE location.
 481
 482 2010-12-26  David Levin  <levin@chromium.org>
 483
 484         Reviewed by Eric Seidel.
 485
 486         check-webkit-style should be able to parse function declaration parameters.
 487         https://bugs.webkit.org/show_bug.cgi?id=51451
 488
 489         * Scripts/webkitpy/style/checkers/cpp.py:
 490         (Position.__init__): Holds simple position information (row, column).
 491         (Parameter.__init__): Holds information about a parameter.
 492         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
 493         (SingleLineView.convert_column_to_row): Returns the original row given a column.
 494         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
 495         (find_parameter_name_index): Finds where the parameter name is.
 496         (parameter_list): Generates the list of parameters for a function.
 497         (_FunctionState.begin): Added information to allow determining the parameters
 498         on demand.
 499         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
 500         (detect_functions): Improve function detection for operator functions and
 501         determine where the parameters end and pass that to _FunctionState.begin.
 502         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 503         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
 504         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
 505         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
 506         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
 507         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
 508         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
 509         (FunctionDetectionTest.perform_function_detection): Added support for verifying
 510         the parameters found.
 511         (FunctionDetectionTest.test_function_declaration_detection): Added more function
 512         detection test to verify that we catch the operator functions.
 513         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
 514         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
 515         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
 516         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
 517         test_function_length_check_definition_severity1_for_test.
 518
 519 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
 520
 521         Unreviewed WinCE buildfix after r74334.
 522
 523         * CMakeListsWinCE.txt:
 524
 525 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
 526
 527         Unreviewed, rolling out r74632.
 528         http://trac.webkit.org/changeset/74632
 529         https://bugs.webkit.org/show_bug.cgi?id=51600
 530
 531         makes test-webkitpy hang forever on GTK (Requested by philn-tp
 532         on #webkit).
 533
 534         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 535         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
 536
 537 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
 538
 539         Reviewed by Kenneth Rohde Christiansen.
 540
 541         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
 542         https://bugs.webkit.org/show_bug.cgi?id=43528
 543
 544         Remove on_resize because ewk_view_fixed_layout_size_set should not be
 545         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
 546         FrameView, rendering was ignored when _ewk_view_smart_calculate was
 547         called.
 548
 549         * EWebLauncher/main.c:
 550         (browserCreate):
 551
 552 2010-12-24  Eric Seidel  <eric@webkit.org>
 553
 554         Reviewed by Adam Barth.
 555
 556         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
 557         https://bugs.webkit.org/show_bug.cgi?id=28291
 558
 559         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
 560         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
 561         to strings with find in the diff.
 562         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
 563
 564         * Scripts/webkitpy/common/checkout/api.py:
 565         * Scripts/webkitpy/common/checkout/diff_parser.py:
 566         * Scripts/webkitpy/tool/steps/abstractstep.py:
 567         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
 568         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
 569         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
 570         * Scripts/webkitpy/tool/steps/validatereviewer.py:
 571
 572 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
 573
 574         Reviewed by Kenneth Russell.
 575
 576         Modify new-run-webkit-tests to shut up and exit when all the threads
 577         are wedged so that test runs complete faster and we don't end up
 578         w/ enormous log files.
 579
 580         https://bugs.webkit.org/show_bug.cgi?id=51572
 581
 582         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 583         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
 584
 585 2010-12-24  Eric Seidel  <eric@webkit.org>
 586
 587         Reviewed by David Levin.
 588
 589         commit-queue should better explain how it will re-open bugs and follow duplicate chains
 590         https://bugs.webkit.org/show_bug.cgi?id=51549
 591
 592         I've had multiple people ask me about the commit-queue's behavior
 593         regarding reporting flaky tests.  I figured it would be best to just
 594         have the queue explain itself in the bugs it files.
 595
 596         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 597         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 598
 599 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
 600
 601         Reviewed by Eric Seidel.
 602
 603         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
 604         https://bugs.webkit.org/show_bug.cgi?id=51467
 605
 606         * Scripts/webkitpy/style/checker.py:
 607         * Scripts/webkitpy/style/checker_unittest.py:
 608
 609 2010-12-23  Adam Barth  <abarth@webkit.org>
 610
 611         Rubber-stamped by Eric Seidel.
 612
 613         Move JavaScriptGlue into Sources
 614         https://bugs.webkit.org/show_bug.cgi?id=51583
 615
 616         These tools refer to JavaScriptGlue and need to be updated to its new
 617         location.
 618
 619         * Scripts/build-webkit:
 620         * Scripts/do-file-rename:
 621         * Scripts/do-webcore-rename:
 622         * Scripts/webkitpy/common/config/build.py:
 623         * Scripts/webkitpy/common/config/build_unittest.py:
 624
 625 2010-12-23  Lucas Forschler  <lforschler@apple.com>
 626
 627         Reviewed by Eric Seidel.
 628
 629         Bug 51539 - update iexploder scripts to point to new location
 630
 631         * Scripts/run-iexploder-tests:
 632         * Scripts/update-iexploder-cssproperties:
 633
 634 2010-12-23  Evan Martin  <evan@chromium.org>
 635
 636         Reviewed by Ryosuke Niwa.
 637
 638         [chromium] LayoutTestController warning in float->int conversion
 639         https://bugs.webkit.org/show_bug.cgi?id=51553
 640
 641         Rather than reading an int, converting to a float, then getting a compiler
 642         warning on passing the float to something that expects an int, instead
 643         just pass around ints.
 644
 645         No tests, fixes a compiler warning.
 646
 647         * DumpRenderTree/chromium/LayoutTestController.cpp:
 648         (parsePageSizeParameters):
 649         (LayoutTestController::pageNumberForElementById):
 650         (LayoutTestController::numberOfPages):
 651
 652 2010-12-23  Lucas Forschler  <lforschler@apple.com>
 653
 654         Reviewed by Darin Adler.
 655
 656         Bug 51537 - iexploder needs cleanup
 657
 658         * iExploder/htdocs: Removed.
 659         * iExploder/htdocs/config.rb: Removed.
 660         * iExploder/htdocs/cssproperties.in: Removed.
 661         * iExploder/htdocs/cssvalues.in: Removed.
 662         * iExploder/htdocs/htmlattrs.in: Removed.
 663         * iExploder/htdocs/htmltags.in: Removed.
 664         * iExploder/htdocs/htmlvalues.in: Removed.
 665         * iExploder/htdocs/iexploder.cgi: Removed.
 666         * iExploder/htdocs/iexploder.rb: Removed.
 667         * iExploder/htdocs/index.html: Removed.
 668         * iExploder/htdocs/webserver.rb: Removed.
 669         * iExploder/iexploder-1.7.2/output: Removed.
 670         * iExploder/tools: Removed.
 671         * iExploder/tools/lasthit.rb: Removed.
 672         * iExploder/tools/osx_last_crash.rb: Removed.
 673         * iExploder/tools/showtest.rb: Removed.
 674
 675 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
 676
 677         Reviewed by Kenneth Rohde Christiansen.
 678
 679         [EFL] Make 'single' the default backing store in EWebLauncher
 680         https://bugs.webkit.org/show_bug.cgi?id=51534
 681
 682         'single' is the simplest backing store and the one intended to be the
 683         default in the test browser. By mistake the tiled backing store was
 684         left as default in r72617.
 685
 686         * EWebLauncher/main.c:
 687         (browserCreate): ditto.
 688
 689 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
 690
 691         Reviewed by Kenneth Rohde Christiansen.
 692
 693         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
 694         https://bugs.webkit.org/show_bug.cgi?id=51533
 695
 696         There's no point in concatenating env("HOME") with "blah", so remove
 697         option from EWebLauncher.
 698
 699         * EWebLauncher/main.c:
 700         (main): ditto.
 701
 702 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
 703
 704         Reviewed by Eric Seidel.
 705
 706         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
 707
 708         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
 709         I just discovered that we have two additional GC runs per each WebViewHost.
 710         Test_shell had no such calls.
 711         These gc runs eat 15% of cpu time.
 712
 713         https://bugs.webkit.org/show_bug.cgi?id=51479
 714
 715         * DumpRenderTree/chromium/WebViewHost.cpp:
 716         (WebViewHost::~WebViewHost):
 717
 718 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
 719
 720         Reviewed by Ojan Vafai.
 721
 722         This change splits out the TestRunner class into its own file.
 723         When we fork the code for message passing, we will create a new
 724         TestRunner, and this change will allow that to be more modular.
 725
 726         While we're at it, split out TestInput and ResultSummary into
 727         their own files, to reduce the size of run_webkit_tests to
 728         something more managable.
 729
 730         https://bugs.webkit.org/show_bug.cgi?id=51092
 731
 732         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 733         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
 734         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 735         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
 736         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
 737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 738         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 739
 740  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
 741
 742         Reviewed by Ojan Vafai.
 743
 744         nrwt multiprocessing - start over, prepare to fork the code
 745
 746         This code cleans up the signatures and implementation of the
 747         TestRunner class so we can easily fork it to run either the
 748         stable implementation or the new, unstable message-passing
 749         implementation. The two variants will have different
 750         implementations of the run_tests() method. We will switch
 751         between the two based on the setting for the '--worker-model'
 752         switch. We rename the two currently valid values to 'old-inline'
 753         and 'old-threads'.
 754
 755         https://bugs.webkit.org/show_bug.cgi?id=51081
 756
 757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 758         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 759
 760 2010-12-22  Victor Wang  <victorw@chromium.org>
 761
 762         Reviewed by Darin Fisher.
 763
 764         [Chromium] Update chromium archive test result url in rebaseline script.
 765
 766         https://bugs.webkit.org/show_bug.cgi?id=51503
 767
 768         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 769
 770 2010-12-22  Lucas Forschler  <lforschler@apple.com>
 771
 772         Reviewed by Alice Liu.
 773
 774         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
 775         Verified on Chrome, Safari, and IE.
 776         With this change, we will record memory from a parent browser window and all child processes.
 777
 778         * record-memory-win/main.cpp:
 779         (ProcessArgs):
 780         (PrintUsage):
 781         (getMemoryInfo):
 782         (printProcessInfo):
 783         (evalProcesses):
 784         (UseImage):
 785         (QueryContinuously):
 786         (ElapsedTime):
 787
 788 2010-12-22  Lucas Forschler  <lforschler@apple.com>
 789
 790         Unreviewed rollout r74489, because it was missing changelog.
 791
 792         * record-memory-win/main.cpp:
 793
 794 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
 795
 796         Adding myself as a reviewer.
 797
 798         * Scripts/webkitpy/common/config/committers.py:
 799
 800 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
 801
 802         Unreviewed.  Adding myself to committers.py.
 803
 804         * Scripts/webkitpy/common/config/committers.py:
 805
 806 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
 807
 808         Reviewed by Kenneth Rohde Christiansen.
 809
 810         TestNetscapePlugIn should use #if defined
 811         https://bugs.webkit.org/show_bug.cgi?id=51471
 812
 813         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
 814         (NP_Initialize):
 815         (NPP_New):
 816
 817 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
 818
 819         Reviewed by Yury Semikhatsky.
 820
 821         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
 822
 823         DevTools window should be closed explicitly because it has custom deinitialization code.
 824
 825         https://bugs.webkit.org/show_bug.cgi?id=50722
 826
 827         * DumpRenderTree/chromium/TestShell.cpp:
 828         (TestShell::closeRemainingWindows):
 829
 830 2010-12-22  David Levin  <levin@chromium.org>
 831
 832         Reviewed by Shinichiro Hamaji.
 833
 834         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
 835         https://bugs.webkit.org/show_bug.cgi?id=51452
 836
 837         * Scripts/webkitpy/style/checkers/cpp.py:
 838         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
 839         Using the file extension if possible but falling back to the file contents if we have a header file.
 840         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
 841         (_FileState.is_c_or_objective_c):
 842         (check_using_std): Changed to using _FileState to determine the file type.
 843         (check_max_min_macros): Ditto.
 844         (check_for_null): Ditto.
 845         (check_style): Changed the parameters to various calls since they now need _FileState
 846         to determine the file type.
 847         (check_language): Added the file_state parameter so it could be passed
 848         to check_identifier_name_in_declaration.
 849         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
 850         this is an Objective C file.
 851         (_process_lines): Added information for the _FileState constructor (and moved the
 852         call to a place that had the information).
 853         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 854         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
 855         its functionality.
 856         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
 857
 858 2010-12-21  Andy Estes  <aestes@apple.com>
 859
 860         Reviewed by Mark Rowe.
 861
 862         Do not build non-Intel architectures for WebKit2-related projects.
 863         https://bugs.webkit.org/show_bug.cgi?id=51440
 864
 865         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
 866         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
 867         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
 868
 869 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
 870
 871         Reviewed by Darin Fisher.
 872
 873         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
 874         https://bugs.webkit.org/show_bug.cgi?id=51406
 875
 876         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
 877         to WebThemeEngineDRTWin and update references everywhere.
 878
 879         * DumpRenderTree/DumpRenderTree.gypi:
 880         * DumpRenderTree/chromium/TestShellWin.cpp:
 881         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
 882         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
 883         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
 884         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
 885
 886 2010-12-21  Anders Carlsson  <andersca@apple.com>
 887
 888         Reviewed by John Sullivan.
 889
 890         Clicking missing plug-in text does not show a sheet
 891         https://bugs.webkit.org/show_bug.cgi?id=51403
 892
 893         Update for changes to the WebPageUIClient.
 894
 895         * MiniBrowser/mac/BrowserWindowController.m:
 896         (-[BrowserWindowController awakeFromNib]):
 897         * WebKitTestRunner/TestController.cpp:
 898         (WTR::createOtherPage):
 899         (WTR::TestController::initialize):
 900
 901 2010-12-21  Eric Seidel  <eric@webkit.org>
 902
 903         Reviewed by Adam Barth.
 904
 905         commit-queue will report constant failures as flaky if other tests flake
 906         https://bugs.webkit.org/show_bug.cgi?id=51272
 907
 908         This patch just removes functionality and adds testing.
 909         Previously we attempted to report flaky tests when we had
 910         two different tests fail in a row.  However, since we stop
 911         running the tests at the first failure, our code was wrong in
 912         trying to determine flakiness from the incomplete runs.
 913
 914         Originally I posted an alternate patch:
 915         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
 916         which fixed our flaky logic in this case, however it was decided
 917         that that patch would be too difficult to maintain, so now
 918         I'm just removing the broken logic.
 919
 920         This will dramatically cut-down on our flaky-test false positives
 921         at the (small) cost of the queues being unable to report
 922         any flakiness if the tree is very flaky.  (With at least one test
 923         flaking on every run, we'll never report failures anymore.)  I think
 924         this is a tradeoff worth making.
 925
 926         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 927         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 928
 929 2010-12-20  Eric Seidel  <eric@webkit.org>
 930
 931         Reviewed by Adam Barth.
 932
 933         commit-queue wrongly rejects patches when it can't update itself
 934         https://bugs.webkit.org/show_bug.cgi?id=46636
 935
 936         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 937         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 938         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 939
 940 2010-12-20  Adam Barth  <abarth@webkit.org>
 941
 942         Move web sites to Websites directory
 943         https://bugs.webkit.org/show_bug.cgi?id=51323
 944
 945         Update references to BugsSite to point to the new location.
 946
 947         This patch was never officially reviewed (because it was too large to
 948         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
 949         Rowe gave me the green light.
 950
 951         * Scripts/old-run-webkit-tests:
 952         * Scripts/webkitpy/common/config/build.py:
 953         * Scripts/webkitpy/common/config/build_unittest.py:
 954         * Scripts/webkitpy/common/prettypatch.py:
 955         * Scripts/webkitpy/layout_tests/port/base.py:
 956         * Scripts/webkitpy/style/main.py:
 957
 958 2010-12-20  Adrienne Walker  <enne@google.com>
 959
 960         Unreviewed. Adding myself to the list of committers.
 961
 962         * webkitpy/common/config/committers.py:
 963
 964 2010-12-20  Mark Rowe  <mrowe@apple.com>
 965
 966         Reviewed by Dan Bernstein.
 967
 968         <rdar://problem/8757601> Don't install header files in to the Resources directory.
 969
 970         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
 971         Resources directory.
 972
 973 2010-12-20  Eric Seidel  <eric@webkit.org>
 974
 975         Reviewed by Adam Barth.
 976
 977         commit-queue should include bot id when attaching failure diffs
 978         https://bugs.webkit.org/show_bug.cgi?id=51280
 979
 980         This is a tiny change to include the bot id in the name of the attachment.
 981         Most of this diff is just changing the unit test expectations
 982         now that I hid the comment printing when the comment is None.
 983
 984         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 985         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 986         * Scripts/webkitpy/tool/commands/upload_unittest.py:
 987         * Scripts/webkitpy/tool/mocktool.py:
 988
 989 2010-12-20  Jeff Miller  <jeffm@apple.com>
 990
 991         Reviewed by Dan Bernstein.
 992
 993         Tools/vcbin/midl.exe needs to be rebuilt
 994         https://bugs.webkit.org/show_bug.cgi?id=51347
 995
 996         * vcbin/midl.exe: Rebuilt.
 997
 998 2010-12-20  David Levin  <levin@chromium.org>
 999
1000         Reviewed by Ariya Hidayat.
1001
1002         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
1003         https://bugs.webkit.org/show_bug.cgi?id=51343
1004
1005         Follow up from the WebKitTools -> Tools rename.
1006
1007         * Scripts/webkit-tools-completion.sh:
1008
1009 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
1010
1011         Reviewed by James Robinson.
1012
1013         new-run-webkit-tests ignores trailing EOL differences in text tests
1014         https://bugs.webkit.org/show_bug.cgi?id=36983
1015
1016         Changed the handling of new-line characters within new-run-webkit-tests
1017         to match old-run-webkit-tests.  Differences in leading and trailing empty
1018         lines in text expectation files are no longer ignored.
1019
1020         * Scripts/webkitpy/layout_tests/port/base.py:
1021         * Scripts/webkitpy/layout_tests/port/test.py:
1022         Added unit tests.  Removed old duplicate unit test entries.
1023         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1024
1025 2010-12-20  David Levin  <levin@chromium.org>
1026
1027         Reviewed by Shinichiro Hamaji.
1028
1029         check-webkit-style should detect function declarations (and trivial functions).
1030         https://bugs.webkit.org/show_bug.cgi?id=51303
1031
1032         * Scripts/webkitpy/style/checkers/cpp.py:
1033         (_FunctionState.begin): Add is_declaration and changed the line count
1034         start to begin at -1 (which will keep the results consistent, since
1035         the starting line number passed in is one less in this change).
1036         (detect_functions): changed function detection to now catch trivial
1037         functions and declarations.
1038         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
1039         of the function as this may look at return values (when processing
1040         a declaration).
1041         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1042         (FunctionDetectionTest.perform_function_detection): Basic mechanics
1043         of testing the function detection.
1044         (FunctionDetectionTest.test_basic_function_detection): Test a simple
1045         function.
1046         (FunctionDetectionTest.test_function_declaration_detection): Test a
1047         declaration.
1048         (FunctionDetectionTest.test_non_functions): A test case for a case
1049         that caused the code to fail due to the { being in quotes.
1050         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
1051         cases to help catch false alarms for return values.
1052         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
1053         we don't get false alarms for member variables either.
1054
1055 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
1056
1057         Reviewed by Antonio Gomes.
1058
1059         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
1060         https://bugs.webkit.org/show_bug.cgi?id=51319
1061
1062         * CMakeListsEfl.txt:
1063
1064 2010-12-18  Adam Barth  <abarth@webkit.org>
1065
1066         Reviewed by Sam Weinig.
1067
1068         Move WebKitExamplePlugins to Examples
1069         https://bugs.webkit.org/show_bug.cgi?id=51291
1070
1071         * Scripts/webkitpy/common/config/build.py:
1072
1073 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
1074
1075         Unreviewed Qt buildfix after r74301.
1076
1077         Rename WebKitTools to Tools
1078         https://bugs.webkit.org/show_bug.cgi?id=49861
1079
1080         * MiniBrowser/DerivedSources.pro:
1081         * MiniBrowser/qt/MiniBrowser.pro:
1082
1083 2010-12-17  Dan Bernstein  <mitz@apple.com>
1084
1085         Reviewed by Simon Fraser.
1086
1087         Rename WebKitTools to Tools
1088         https://bugs.webkit.org/show_bug.cgi?id=49861
1089
1090         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1091         * CodeCoverage/README:
1092         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1093         (WebCore::DumpRenderTree::initializeFonts):
1094         * EWSTools/start-commit-queue.sh:
1095         * EWSTools/start-queue.sh:
1096         * GNUmakefile.am:
1097         * MIDLWrapper/MIDLWrapper.cpp:
1098         (wmain):
1099         * MiniBrowser/qt/MiniBrowser.pro:
1100         * Scripts/build-api-tests:
1101         * Scripts/build-dumprendertree:
1102         * Scripts/build-webkit:
1103         * Scripts/build-webkittestrunner:
1104         * Scripts/generate-coverage-data:
1105         * Scripts/old-run-webkit-tests:
1106         * Scripts/run-api-tests:
1107         * Scripts/run-iexploder-tests:
1108         * Scripts/run-javascriptcore-tests:
1109         * Scripts/run-mangleme-tests:
1110         * Scripts/run-sunspider:
1111         * Scripts/run-webkit-websocketserver:
1112         * Scripts/sunspider-compare-results:
1113         * Scripts/test-webkitperl:
1114         * Scripts/test-webkitpy:
1115         * Scripts/update-iexploder-cssproperties:
1116         * Scripts/update-webkit:
1117         * Scripts/update-webkit-localizable-strings:
1118         * Scripts/webkitdirs.pm:
1119         * Scripts/webkitpy/common/checkout/scm.py:
1120         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1121         * Scripts/webkitpy/common/config/committervalidator.py:
1122         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1123         * Scripts/webkitpy/common/config/ports.py:
1124         * Scripts/webkitpy/common/config/ports_unittest.py:
1125         * Scripts/webkitpy/common/system/logutils_unittest.py:
1126         * Scripts/webkitpy/common/system/ospath_unittest.py:
1127         * Scripts/webkitpy/layout_tests/port/chromium.py:
1128         * Scripts/webkitpy/layout_tests/port/config.py:
1129         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1130         * Scripts/webkitpy/layout_tests/port/http_server.py:
1131         * Scripts/webkitpy/layout_tests/port/test.py:
1132         * Scripts/webkitpy/style/checker.py:
1133         * Scripts/webkitpy/style/checker_unittest.py:
1134         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1135         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1136         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1137         * WebKitTestRunner/DerivedSources.pro:
1138         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1139         (WTR::activateFonts):
1140         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1141         * wx/build/build_utils.py:
1142
1143 2010-12-16  Antonio Gomes  <agomes@rim.com>
1144
1145         Reviewed by Martin Robinson.
1146
1147         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
1148         https://bugs.webkit.org/show_bug.cgi?id=51163
1149
1150         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
1151         GTK+'s DRT should also reset to UNIX after each test execution.
1152
1153         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1154         (resetDefaultsToConsistentValues):
1155
1156 2010-12-17  David Levin  <levin@chromium.org>
1157
1158         Reviewed by Eric Seidel.
1159
1160         check-webkit-style should understand WTF #include guards
1161         https://bugs.webkit.org/show_bug.cgi?id=44911
1162
1163         * Scripts/webkitpy/style/checkers/cpp.py:
1164         (get_header_guard_cpp_variable): modify to suggest the WTF style
1165         of header guard when appropriate.
1166         (check_for_header_guard): handle multiple return values from
1167         get_header_guard_cpp_variable
1168         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1169         (CppStyleTest.test_build_header_guard): Added tests for the WTF
1170         header style.
1171
1172 2010-12-16  David Levin  <levin@chromium.org>
1173
1174         Reviewed by Eric Seidel.
1175
1176         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
1177         https://bugs.webkit.org/show_bug.cgi?id=51210
1178
1179         The error only shows up when using python 2.6 or later.
1180
1181         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
1182         the decprecated field error,message with something equivalent.
1183
1184 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
1185
1186         Reviewed by Eric Seidel.
1187
1188         Add --exit-after-n-failures/crashes to NRWT
1189         https://bugs.webkit.org/show_bug.cgi?id=51160
1190
1191         Abort test run (in a similar way to how control-C is handled) when
1192         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
1193         that number of unexpected failures/crashes/timeouts.
1194
1195         * Scripts/webkitpy/layout_tests/port/test.py:
1196         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1197         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1198
1199 2010-12-16  David Levin  <levin@chromium.org>
1200
1201         Reviewed by Shinichiro Hamaji.
1202
1203         check-webkit-style unit tests has some duplicate boilerplate code.
1204         https://bugs.webkit.org/show_bug.cgi?id=49519
1205
1206         * Scripts/webkitpy/style/checkers/cpp.py:
1207         (update_include_state): Replaced the "io" parameter with the global
1208         configuration _unit_test_config. This allowed not calling into
1209         functions at a low level and also not plumbing through the injection
1210         information through many levels of code.
1211         (check_for_include_what_you_use): Ditto.
1212         (process_file_data): Added the ability to set up the unit test config
1213         to allow for injection.
1214         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1215         (ErrorCollector.__init__): Added support for having a filter for errors.
1216         (ErrorCollector.__call__): Ditto.
1217         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
1218         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
1219         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
1220         functions in the cpp.py with generic processing and a filter that
1221         indicates what errors should be kept.
1222         (CppStyleTestBase.perform_multi_line_lint): Ditto.
1223         (CppStyleTestBase.perform_language_rules_check): Ditto.
1224         (CppStyleTestBase.perform_function_lengths_check): Ditto.
1225         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
1226         (CppStyleTestBase.perform_include_what_you_use): Ditto.
1227         (CppStyleTest.test_multi_line_comments): Added another
1228         error message which applies to the test case.
1229         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
1230         to not have config.h, since it is processed as a header file.
1231         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
1232         style and indentation in checked code.
1233         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
1234         Fixed line number.
1235         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
1236         Ditto.
1237
1238 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1239
1240         Unreviewed, rolling out r74136.
1241         http://trac.webkit.org/changeset/74136
1242         https://bugs.webkit.org/show_bug.cgi?id=51135
1243
1244         r74136 breaks chromium canary bots because some tests are not
1245         rebaselined correctly to resolve EOL differences (Requested by
1246         jianli on #webkit).
1247
1248         * Scripts/webkitpy/layout_tests/port/base.py:
1249         * Scripts/webkitpy/layout_tests/port/test.py:
1250         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1251
1252 2010-12-15  Adam Roben  <aroben@apple.com>
1253
1254         Teach check-webkit-style to check .vcproj and .vsprops files for XML
1255         syntax errors
1256
1257         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
1258         XML syntax errors in .vcproj/.vsprops files
1259
1260         Reviewed by Dave Levin.
1261
1262         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
1263         that should be treated as XML and that should be allowed to contain
1264         carriage returns. (These lists happen to be identical currently.)
1265         (FileType): Added a new XML type.
1266         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
1267         Just does a simple file extension check.
1268         (CheckerDispatcher._file_type): Added a case for XML files.
1269         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
1270         files (surprise!).
1271         (StyleProcessor.process): Ask the dispatcher whether we should pass the
1272         lines through the carriage checker.
1273
1274         * Scripts/webkitpy/style/checker_unittest.py:
1275         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1276         Added. Checks a few file names to see if carriage returns are allowed
1277         or not.
1278         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
1279         other assert_checker_* functions.
1280         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1281         test_*_paths functions.
1282         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1283         test_*_paths functions.
1284         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
1285         file from this test case, as vcproj files now have a type.
1286         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
1287         Added. Similar to the other should_* functions.
1288         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
1289         Added. Checks that carriage returns aren't checked for or stripped for
1290         allowed files.
1291
1292         * Scripts/webkitpy/style/checkers/xml.py: Added.
1293         (XMLChecker.__init__): Simple init method.
1294         (XMLChecker.check): Pass each line through the expat parser, and record
1295         a style error for any errors thrown by the parser.
1296
1297         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
1298         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
1299         produce a style error.
1300         (XMLCheckerTest.assert_error): Checks that the given XML produces an
1301         error of the given category on the given line.
1302         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
1303         checking that the XMLChecker constructor works properly.
1304         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
1305         cause a style error (see, e.g., r73887).
1306         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
1307         cause a style error (see, e.g., r73773).
1308         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
1309         properly.
1310         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
1311         tags cause a style error (see, e.g., r72795).
1312         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
1313         style error.
1314
1315 2010-12-15  Lucas Forschler  <lforschler@apple.com>
1316
1317         Reviewed by Stephanie Lewis.
1318
1319         https://bugs.webkit.org/show_bug.cgi?id=51117
1320         Add a new leopard test bot
1321         really really commit to trunk this time.
1322
1323         * BuildSlaveSupport/build.webkit.org-config/config.json:
1324
1325 2010-12-15  Sam Weinig  <sam@webkit.org>
1326
1327         Reviewed by Anders Carlsson.
1328
1329         WebKit2: Can't add files to an <input type=file>
1330         https://bugs.webkit.org/show_bug.cgi?id=51087
1331
1332         * MiniBrowser/mac/BrowserWindowController.m:
1333         (runOpenPanel):
1334         (-[BrowserWindowController awakeFromNib]):
1335         Add simple implementation of runOpenPanel callback.
1336
1337         * MiniBrowser/win/BrowserView.cpp:
1338         (BrowserView::create):
1339         * WebKitTestRunner/TestController.cpp:
1340         (WTR::createOtherPage):
1341         (WTR::TestController::initialize):
1342         Stub out runOpenPanel callback.
1343
1344 2010-12-14  Eric Seidel  <eric@webkit.org>
1345
1346         Reviewed by Adam Barth.
1347
1348         commit-queue should upload failure diffs when tests flake
1349         https://bugs.webkit.org/show_bug.cgi?id=51051
1350
1351         To make this testable I needed to pipe FileSystem down onto tool.
1352         We've wanted it there for a long time anyway.
1353
1354         This patch is kinda a big hack.  But we don't have a nice
1355         way to read results.html files.  I think this will need further
1356         revision before this code actually feels clean.
1357
1358         As part of testing this change, I had to make MockBugzilla.create_bug
1359         actually return an id (like it should) which required updating
1360         a few other unit test results (for the better).
1361
1362         The results_matching_keys change in layouttestresults/rebasline
1363         was an alternate path which I decided not to use in the end, but
1364         I left the change as it seemed an improvement.
1365
1366         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1367         * Scripts/webkitpy/common/net/layouttestresults.py:
1368         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1369         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1370         * Scripts/webkitpy/tool/commands/queues.py:
1371         * Scripts/webkitpy/tool/commands/rebaseline.py:
1372         * Scripts/webkitpy/tool/main.py:
1373         * Scripts/webkitpy/tool/mocktool.py:
1374
1375 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
1376
1377         Reviewed by James Robinson.
1378
1379         new-run-webkit-tests ignores trailing EOL differences in text tests
1380         https://bugs.webkit.org/show_bug.cgi?id=36983
1381
1382         Changed the handling of new-line characters within new-run-webkit-tests
1383         to match old-run-webkit-tests.  Differences in leading and trailing empty
1384         lines in text expectation files are no longer ignored.
1385
1386         * Scripts/webkitpy/layout_tests/port/base.py:
1387         * Scripts/webkitpy/layout_tests/port/test.py:
1388         Added unit tests.  Removed old duplicate unit test entries.
1389         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1390
1391 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1392
1393         Reviewed by Adam Barth.
1394
1395         make status-bubble white-space:nowrap so we can measure it's width without wrapping
1396         https://bugs.webkit.org/show_bug.cgi?id=51149
1397
1398         * QueueStatusServer/templates/statusbubble.html:
1399
1400 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1401
1402         Reviewed by Adam Barth.
1403
1404         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
1405         https://bugs.webkit.org/show_bug.cgi?id=51125
1406
1407         * QueueStatusServer/templates/statusbubble.html:
1408
1409 2010-12-15  Darin Adler  <darin@apple.com>
1410
1411         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
1412
1413 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1414
1415         Unreviewed, rolling out r74117.
1416         http://trac.webkit.org/changeset/74117
1417         https://bugs.webkit.org/show_bug.cgi?id=51113
1418
1419         This broke the GTK1 build. (Requested by mrobinson on
1420         #webkit).
1421
1422         * Scripts/webkitdirs.pm:
1423
1424 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1425
1426         Reviewed by Martin Robinson.
1427
1428         Change generate-forwarding-headers.pl for GTK port usage
1429         (https://bugs.webkit.org/show_bug.cgi?id=37369)
1430
1431         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
1432
1433 2010-12-14  Kent Tamura  <tkent@chromium.org>
1434
1435         Reviewed by Jian Li.
1436
1437         [DRT/Chromium] Remove another unnecessary error message
1438         https://bugs.webkit.org/show_bug.cgi?id=51083
1439
1440         * DumpRenderTree/chromium/WebViewHost.cpp:
1441         (WebViewHost::didInvalidateRect):
1442
1443 2010-12-14  Lucas Forschler  <lforschler@apple.com>
1444
1445         Reviewed by Stephanie Lewis.
1446
1447         Add a new Leopard Debug Test WK2 Bot
1448
1449         * BuildSlaveSupport/build.webkit.org-config/config.json:
1450
1451 2010-12-14  Ojan Vafai  <ojan@chromium.org>
1452
1453         Fix python unittests after http://trac.webkit.org/changeset/74070.
1454
1455         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1456
1457 2010-12-14  Kent Tamura  <tkent@chromium.org>
1458
1459         Reviewed by Jian Li.
1460
1461         [DRT/Chromium] Remove a unnecessary error message
1462         https://bugs.webkit.org/show_bug.cgi?id=51069
1463
1464         * DumpRenderTree/chromium/WebViewHost.cpp:
1465         (WebViewHost::paintInvalidatedRegion):
1466
1467 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
1468
1469         Reviewed by Ojan Vafai.
1470
1471         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
1472         https://bugs.webkit.org/show_bug.cgi?id=48926
1473
1474         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1475         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
1476
1477 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1478
1479         Reviewed by Eric Seidel.
1480
1481         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
1482         https://bugs.webkit.org/show_bug.cgi?id=50231
1483
1484         Guard CONFIG+=link_pkgconfig with !symbian.
1485
1486         * DumpRenderTree/qt/DumpRenderTree.pro:
1487         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1488         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1489
1490 2010-12-14  Philippe Normand  <pnormand@igalia.com>
1491
1492         Reviewed by Ojan Vafai.
1493
1494         [new-run-webkit-tests] expectations parsing is slow
1495         https://bugs.webkit.org/show_bug.cgi?id=50635
1496
1497         Avoid expensive iteration of all the tests when checking if a test
1498         file is to be skipped or not.
1499
1500         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1501         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1502         * Scripts/webkitpy/layout_tests/port/test.py:
1503
1504 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
1505
1506         Reviewed by Xan Lopez.
1507
1508         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
1509         https://bugs.webkit.org/show_bug.cgi?id=27048
1510
1511         Add support in DRT for checking whether an accessibility UI
1512         element is focusable and/or focused. Implemented for GTK.
1513
1514         * DumpRenderTree/AccessibilityUIElement.cpp:
1515         (getIsFocusedCallback): New.
1516         (getIsFocusableCallback): New.
1517         (AccessibilityUIElement::getJSClass): Add the new available
1518         callbacks for isFocused and isFocusable.
1519         * DumpRenderTree/AccessibilityUIElement.h:
1520         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1521         (AccessibilityUIElement::isFocused): New, implemented by checking
1522         whether the related AtkState value is in the object's state set.
1523         (AccessibilityUIElement::isFocusable): Ditto.
1524         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1525         (AccessibilityUIElement::isFocused): New, dummy implementation.
1526         (AccessibilityUIElement::isFocusable): Ditto.
1527         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1528         (AccessibilityUIElement::isFocused): Ditto.
1529         (AccessibilityUIElement::isFocusable): Ditto.
1530
1531 2010-12-14  Eric Seidel  <eric@webkit.org>
1532
1533         Reviewed by Ojan Vafai.
1534
1535         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
1536         https://bugs.webkit.org/show_bug.cgi?id=50715
1537
1538         This patch makes webkit-patch print the following:
1539
1540         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
1541         Install a 64-bit git for better performance, see:
1542         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
1543
1544         I wrote this mostly because I have approximately 8 machines that I use
1545         and making sure each one is using a good Git install seemed folly.
1546         webkit-patch makes a lot of git calls, so using a fast git can shave
1547         several seconds in every invocation.  See the webkit-dev thread for more info.
1548
1549         This message will print twice during 'webkit-patch upload',
1550         once from webkit-patch and once from check-webkit-style.
1551
1552         Unfortunately there is no good way to test this due to how machine-dependent
1553         the code is.  I considered writing a test for the log message, but it seemed not worth it.
1554
1555         * Scripts/webkitpy/common/checkout/scm.py:
1556
1557 2010-12-13  Eric Seidel  <eric@webkit.org>
1558
1559         Reviewed by Adam Barth.
1560
1561         FlakyTestReporter doesn't understand bots running from multiple email addresses
1562         https://bugs.webkit.org/show_bug.cgi?id=50960
1563
1564         This explains at least one of the dupes of:
1565         https://bugs.webkit.org/show_bug.cgi?id=50863
1566         that we saw filed by the commit-queue this morning.
1567         I think the other one was explained by my previous fix to result counting code.
1568
1569         Since this is really hard to test with a unit test, instead I
1570         create a new (possibly useful in the future) command
1571         which given a layout test path will return you
1572         the one bug which our tools would assume it the flaky test bug.
1573         If some other script wants to use bug-for-test we'll
1574         need to extend it with some options like --create-if-missing or similar.
1575
1576         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1577         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1578         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1579         * Scripts/webkitpy/tool/commands/__init__.py:
1580         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
1581
1582 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
1583
1584         Reviewed by James Robinson.
1585
1586         Add option to build-webkit to not build WebKit2
1587         https://bugs.webkit.org/show_bug.cgi?id=50988
1588
1589         Add support for a --no-webkit2 option to build-webkit. It seems to save
1590         ~1 minute from clean builds and ~10 seconds from no-op builds.
1591
1592         * Scripts/build-webkit:
1593
1594 2010-12-13  Lucas Forschler  <lforschler@apple.com>
1595
1596         Reviewed by Dave Kilzer.
1597
1598         Update iexploder from 1.3.2 to 1.7.2
1599         Move 1.3.2 into its own subdir
1600         Add 1.7.2 into its own subdir
1601         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
1602
1603         * Scripts/run-iexploder-tests:
1604         * Scripts/update-iexploder-cssproperties:
1605         * iExploder/CHANGELOG.txt: Removed.
1606         * iExploder/LICENSE.txt: Removed.
1607         * iExploder/README.txt: Removed.
1608         * iExploder/htdocs: Removed.
1609         * iExploder/iexploder-1.3.2: Added.
1610         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
1611         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
1612         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
1613         * iExploder/iexploder-1.3.2/htdocs: Added.
1614         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
1615         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
1616         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
1617         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
1618         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
1619         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
1620         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
1621         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
1622         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
1623         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
1624         * iExploder/iexploder-1.3.2/tools: Added.
1625         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
1626         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
1627         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
1628         * iExploder/iexploder-1.7.2: Added.
1629         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
1630         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
1631         * iExploder/iexploder-1.7.2/README.txt: Added.
1632         * iExploder/iexploder-1.7.2/output: Added.
1633         * iExploder/iexploder-1.7.2/src: Added.
1634         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1635         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1636         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1637         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1638         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1639         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1640         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1641         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1642         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1643         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1644         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1645         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1646         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1647         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1648         * iExploder/iexploder-1.7.2/src/css-values: Added.
1649         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1650         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1651         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1652         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1653         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1654         * iExploder/iexploder-1.7.2/src/headers: Added.
1655         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1656         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1657         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1658         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1659         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1660         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1661         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1662         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1663         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1664         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1665         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1666         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1667         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1668         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1669         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1670         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1671         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1672         * iExploder/iexploder-1.7.2/src/html-values: Added.
1673         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1674         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1675         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1676         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1677         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1678         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1679         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1680         * iExploder/iexploder-1.7.2/src/index.html: Added.
1681         * iExploder/iexploder-1.7.2/src/media: Added.
1682         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1683         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1684         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1685         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1686         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1687         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1688         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1689         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1690         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1691         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1692         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1693         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1694         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1695         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1696         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1697         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1698         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1699         * iExploder/iexploder-1.7.2/src/protocols: Added.
1700         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1701         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1702         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1703         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1704         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1705         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1706         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1707         * iExploder/iexploder-1.7.2/testcases: Added.
1708         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1709         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1710         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1711         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1712         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1713         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1714         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1715         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1716         * iExploder/iexploder-1.7.2/tools: Added.
1717         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1718         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1719         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1720         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1721         * iExploder/tools: Removed.
1722
1723 2010-12-13  Sam Weinig  <sam@webkit.org>
1724
1725         Reviewed by Anders Carlsson.
1726
1727         Remove associated page concept from WKView constructor
1728         https://bugs.webkit.org/show_bug.cgi?id=50983
1729
1730         Step 1: Remove associate page constructors from WKView and make
1731         all views use the shared namespace for the context.
1732
1733         * TestWebKitAPI/PlatformWebView.h:
1734         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1735         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1736         * WebKitTestRunner/PlatformWebView.h:
1737         * WebKitTestRunner/TestController.cpp:
1738         (WTR::createOtherPage):
1739         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1740         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1741         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1742
1743 2010-12-13  Sam Weinig  <sam@webkit.org>
1744
1745         Reviewed by Anders Carlsson.
1746
1747         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1748         https://bugs.webkit.org/show_bug.cgi?id=50898
1749
1750         * MiniBrowser/mac/AppDelegate.h:
1751         * MiniBrowser/mac/AppDelegate.m:
1752         * MiniBrowser/mac/BrowserWindowController.h:
1753         * MiniBrowser/mac/BrowserWindowController.m:
1754         * MiniBrowser/win/BrowserView.cpp:
1755         Convert MiniBrowser to not use PageNamespaces.
1756
1757         * TestWebKitAPI/PlatformWebView.h:
1758         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1759         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1760         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1761         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1762         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1763         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1764         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1765         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1766         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1767         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1768         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1769         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1770         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1771         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1772         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1773         Convert TestWebKitAPI to not use PageNamespaces.
1774
1775         * WebKitTestRunner/PlatformWebView.h:
1776         * WebKitTestRunner/TestController.cpp:
1777         * WebKitTestRunner/TestController.h:
1778         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1779         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1780         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1781         Convert WebKitTestRunner to not use PageNamespaces.
1782
1783 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1784
1785         Reviewed by Eric Seidel.
1786
1787         webkit-patch rollout should be able to do multi-revision rollouts
1788         https://bugs.webkit.org/show_bug.cgi?id=33336
1789
1790         Make it possible to pass more than one revision to webkit-patch.
1791
1792         * Scripts/webkitpy/common/checkout/api.py:
1793         * Scripts/webkitpy/common/checkout/changelog.py:
1794         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1795         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1796         * Scripts/webkitpy/tool/commands/download.py:
1797         * Scripts/webkitpy/tool/commands/download_unittest.py:
1798         * Scripts/webkitpy/tool/mocktool.py:
1799         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1800         * Scripts/webkitpy/tool/steps/revertrevision.py:
1801
1802 2010-12-13  Eric Seidel  <eric@webkit.org>
1803
1804         Unreviewed.
1805
1806         Teach webkit-patch how to search bugzilla
1807         https://bugs.webkit.org/show_bug.cgi?id=50500
1808
1809         webkit-patch bug-search fails when there is only one result.
1810         Turns out we needed a bit more logic in our result count parsing code.
1811
1812         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1813         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1814
1815 2010-12-13  Antti Koivisto  <antti@apple.com>
1816
1817         Reviewed by Alexey Proskuryakov.
1818
1819         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1820         https://bugs.webkit.org/show_bug.cgi?id=50758
1821
1822         * DumpRenderTree/LayoutTestController.cpp:
1823         (setSerializeHTTPLoadsCallback):
1824         (LayoutTestController::staticFunctions):
1825         * DumpRenderTree/LayoutTestController.h:
1826         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1827         (LayoutTestController::setSerializeHTTPLoads):
1828         * DumpRenderTree/mac/DumpRenderTree.mm:
1829         (resetDefaultsToConsistentValues):
1830         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1831         (LayoutTestController::setSerializeHTTPLoads):
1832         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1833         (LayoutTestController::setSerializeHTTPLoads):
1834
1835 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1836
1837         Reviewed by Ojan Vafai.
1838
1839         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1840         https://bugs.webkit.org/show_bug.cgi?id=50936
1841
1842         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1843
1844 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1845
1846         Reviewed by Csaba Osztrogonác.
1847
1848         Add revlink to BuildBot status
1849         https://bugs.webkit.org/show_bug.cgi?id=50914
1850
1851         This adds a hyperlink to trac changeset on the revision numbers.
1852
1853         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1854
1855 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1856
1857         Reviewed by Csaba Osztrogonác.
1858
1859         [Qt][WK2] Fix build if WebKitTools are not available
1860         https://bugs.webkit.org/show_bug.cgi?id=50242
1861
1862         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1863         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1864         * MiniBrowser/DerivedSources.pro: Added.
1865
1866 2010-12-13  Eric Seidel  <eric@webkit.org>
1867
1868         Reviewed by Adam Barth.
1869
1870         EWS Queues should remove orpahned pyc files before starting
1871         https://bugs.webkit.org/show_bug.cgi?id=50904
1872
1873         A previous check added a platform.py which caused
1874         EWS bots on some platforms to hit an import exception.
1875         The platform.py file was removed in a subsequent commit, but
1876         the EWS bots in question stayed stuck.  This change will
1877         fix those bots once restarted (and prevent this in the future).
1878
1879         I also went ahead and unified start-queue and start-commit-queue
1880         since they were nearly identical.  I also added bot_id support
1881         to both force all EWSes to have bot ids as well as get rid of the one
1882         remaining reason why I had my own copies of these scripts.
1883         Hopefully this will be enough to get all the other bot admins
1884         (ahem, Adam, ahem) to move to using these checked in copies as well.
1885
1886         * EWSTools/start-commit-queue.sh: Removed.
1887         * EWSTools/start-queue.sh:
1888
1889 2010-10-28  MORITA Hajime  <morrita@google.com>
1890
1891         Reviewed by Ojan Vafai.
1892
1893         spellcheck does not check pasted text
1894         https://bugs.webkit.org/show_bug.cgi?id=40092
1895
1896         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1897         to control the setting.
1898
1899         * DumpRenderTree/LayoutTestController.cpp:
1900         (setAsynchronousSpellCheckingEnabledCallback):
1901         (LayoutTestController::staticFunctions):
1902         * DumpRenderTree/LayoutTestController.h:
1903         * DumpRenderTree/chromium/LayoutTestController.h:
1904         * DumpRenderTree/chromium/LayoutTestController.cpp:
1905         (LayoutTestController::LayoutTestController):
1906         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1907         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1908         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1909         * DumpRenderTree/mac/DumpRenderTree.mm:
1910         (resetDefaultsToConsistentValues):
1911         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1912         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1913         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1914         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1915         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1916         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1917         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1918         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1919         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1920
1921 2010-12-12  Sam Weinig  <sam@webkit.org>
1922
1923         Reviewed by Anders Carlsson.
1924
1925         Fix failing API test. It turns out that a pop-state event
1926         is sent before every fragment navigation, so we have to test
1927         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1928
1929         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1930         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1931
1932 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1933
1934         Reviewed by Eric Seidel.
1935
1936         [GTK] Add new-run-webkit-tests support to gtk
1937         https://bugs.webkit.org/show_bug.cgi?id=50681
1938
1939         Adding the basic support to run the new-run-webkit-tests.
1940
1941         * Scripts/webkitpy/layout_tests/port/gtk.py:
1942
1943 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1944
1945         Reviewed by Kenneth Rohde Christiansen.
1946
1947         [Qt] Mock DeviceOrientation client for DRT
1948         https://bugs.webkit.org/show_bug.cgi?id=47490
1949
1950         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1951         (WebCore::DumpRenderTree::DumpRenderTree):
1952         (WebCore::DumpRenderTree::~DumpRenderTree):
1953         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1954         (LayoutTestController::setMockDeviceOrientation):
1955
1956 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1957
1958         Reviewed by Gustavo Noronha Silva.
1959
1960         [GTK] launcher: disable the Mozilla-style fullscreen API
1961         https://bugs.webkit.org/show_bug.cgi?id=50874
1962
1963         Disabling the fullscreen API until its implementation for GTK is
1964         mature enough. The webview setting for it is already FALSE by
1965         default.
1966
1967         * GtkLauncher/main.c:
1968         (createWindow):
1969
1970 2010-12-10  Eric Seidel  <eric@webkit.org>
1971
1972         Reviewed by Adam Barth.
1973
1974         commit-queue flaky test messages show cryptic version information for mac os x
1975         https://bugs.webkit.org/show_bug.cgi?id=50864
1976
1977         Turns out platform.platform() returns kernel version information
1978         which isn't helpful, and just plain confusing on Mac
1979         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1980
1981         So I've updated PlatformInfo.display_name() to special case
1982         mac.  I also found a bad use of sys.platform in the process
1983         and fixed that.  (sys.platform always returns 'darwin' on mac).
1984
1985         * Scripts/webkitpy/common/system/platforminfo.py:
1986         * Scripts/webkitpy/common/system/user.py:
1987         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1988         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1989         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1990
1991 2010-12-10  Eric Seidel  <eric@webkit.org>
1992
1993         Unreviewed.
1994
1995         Exception seen while reporting flaky test with commit-queue.
1996         Just a missing include.
1997
1998         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1999         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2000
2001 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
2002
2003         Reviewed by Eric Seidel.
2004
2005         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
2006         https://bugs.webkit.org/show_bug.cgi?id=50796
2007
2008         Also updating the test code to use JSONResultsGeneratorBase and
2009         to improve test coverage for incremental cases.
2010
2011         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2012         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2013
2014 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
2015
2016         Reviewed by Darin Adler.
2017
2018         prepare-ChangeLog --help doesn't mention --bug shorthand -b
2019         https://bugs.webkit.org/show_bug.cgi?id=50835
2020
2021         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
2022
2023 2010-12-10  Eric Seidel  <eric@webkit.org>
2024
2025         Reviewed by Adam Barth.
2026
2027         Bugs created by the commit-queue should all block on a master bug
2028         https://bugs.webkit.org/show_bug.cgi?id=50857
2029
2030         This makes all bugs created by the commit-queue block on:
2031         https://bugs.webkit.org/show_bug.cgi?id=50856
2032
2033         In the process of testing this, I found that the existing
2034         create_bug code was wrong.  I also found that existing
2035         unit tests for create-rollout used invalid values
2036         for options.blocks.  I fixed both issues and tested.
2037
2038         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2039         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2040         * Scripts/webkitpy/tool/commands/commandtest.py:
2041         * Scripts/webkitpy/tool/commands/download_unittest.py:
2042         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2043         * Scripts/webkitpy/tool/mocktool.py:
2044         * Scripts/webkitpy/tool/steps/options.py:
2045
2046 2010-12-10  Eric Seidel  <eric@webkit.org>
2047
2048         Reviewed by Adam Barth.
2049
2050         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
2051         https://bugs.webkit.org/show_bug.cgi?id=50853
2052
2053         I also discovered when doing this that the code was posting
2054         the comment on the wrong bug, but that's fixed here too.
2055
2056         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2057         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2058         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2059         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2060         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2061         * Scripts/webkitpy/tool/mocktool.py:
2062
2063 2010-12-10  Anders Carlsson  <andersca@apple.com>
2064
2065         Reviewed by John Sullivan.
2066
2067         Make WKContextGetStatistics gather global statistics
2068         https://bugs.webkit.org/show_bug.cgi?id=50850
2069
2070         Remove the code that gets the statistics and fills in the per context
2071         statistics information for now.
2072
2073         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2074         (-[BrowserStatisticsWindowController refreshStatistics:]):
2075
2076 2010-12-10  Eric Seidel  <eric@webkit.org>
2077
2078         Unreviewed.
2079
2080         commit-queue should report port/platform information when commenting on flaky test bugs
2081         https://bugs.webkit.org/show_bug.cgi?id=50839
2082
2083         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
2084         which was only used by new run webkit tests (and clearly not unit tested).
2085
2086         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
2087         * Scripts/webkitpy/tool/main.py:
2088         * Scripts/webkitpy/tool/mocktool.py:
2089
2090 2010-12-10  Eric Seidel  <eric@webkit.org>
2091
2092         Reviewed by Tony Chang.
2093
2094         commit-queue should report port/platform information when commenting on flaky test bugs
2095         https://bugs.webkit.org/show_bug.cgi?id=50839
2096
2097         This was a suggestion from Tony Chang this morning.
2098         I added a platform.py class so I could easily mock the platform call,
2099         but that may not be the final solution for this mocking.
2100         We'll try it and see.
2101
2102         * Scripts/webkitpy/common/system/platform.py: Added.
2103         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2104         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2105         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2106         * Scripts/webkitpy/tool/main.py:
2107         * Scripts/webkitpy/tool/mocktool.py:
2108
2109 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
2110
2111         Reviewed by Joseph Pecoraro.
2112
2113         Bug 43455 - [Qt]: Implement Application Cache Quotas
2114         https://bugs.webkit.org/show_bug.cgi?id=43455
2115
2116         Introduce functions to allow new appcache layout test origin-quota.html
2117         to work correctly under Qt.
2118
2119         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2120         (WebCore::DumpRenderTree::DumpRenderTree):
2121         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
2122         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2123
2124         Introduce functions to allow new appcache layout test origin-quota.html
2125         to be successful under qt. Changes required because LayoutTestControllerQt
2126         does not inherit from LayoutController.
2127
2128         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2129         (LayoutTestController::reset):
2130         (LayoutTestController::clearAllApplicationCaches):
2131         (LayoutTestController::setApplicationCacheOriginQuota):
2132         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2133         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
2134         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
2135
2136 2010-12-10  Eric Seidel  <eric@webkit.org>
2137
2138         Reviewed by Adam Barth.
2139
2140         Move buildbot.py into its own module so we can split it out into one-file-per-class
2141         https://bugs.webkit.org/show_bug.cgi?id=50806
2142
2143         We're adding more buildbot logic these days, so it makes sense
2144         to give buildbot its own module.
2145
2146         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
2147         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
2148         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
2149         * Scripts/webkitpy/common/net/failuremap.py:
2150         * Scripts/webkitpy/common/net/regressionwindow.py:
2151         * Scripts/webkitpy/tool/commands/rebaseline.py:
2152
2153 2010-12-10  Tony Chang  <tony@chromium.org>
2154
2155         Reviewed by Eric Seidel.
2156
2157         Use FileSystem::remove when cleaning up http lock files
2158         https://bugs.webkit.org/show_bug.cgi?id=50830
2159
2160         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2161
2162 2010-12-10  Joone Hur  <joone@kldp.org>
2163
2164         Reviewed by Martin Robinson.
2165
2166         [GTK] DRT needs layoutTestController.setCacheModel
2167         https://bugs.webkit.org/show_bug.cgi?id=50705
2168
2169         webkit_set_cache_mode() is called to set the cache model.
2170
2171         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2172         (LayoutTestController::setCacheModel): Set the cache model.
2173
2174 2010-12-10  Tony Chang  <tony@chromium.org>
2175
2176         Reviewed by Ojan Vafai.
2177
2178         [chromium] remove --use-drt and add --use-test-shell
2179         https://bugs.webkit.org/show_bug.cgi?id=50701
2180
2181         * Scripts/webkitpy/common/config/ports.py:
2182         * Scripts/webkitpy/common/config/ports_unittest.py:
2183         * Scripts/webkitpy/layout_tests/port/chromium.py:
2184         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2185         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2186         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2187         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2188         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2189         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2190         * Scripts/webkitpy/layout_tests/port/webkit.py:
2191         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2192         * Scripts/webkitpy/style/checkers/test_expectations.py:
2193         * Scripts/webkitpy/tool/commands/queries.py:
2194
2195 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
2196
2197         Reviewed by Steve Block.
2198
2199         [Chromium] Implement mocks for client-based geolocation
2200         https://bugs.webkit.org/show_bug.cgi?id=46895
2201
2202         * DumpRenderTree/chromium/LayoutTestController.cpp:
2203         (LayoutTestController::setGeolocationPermission):
2204         (LayoutTestController::setMockGeolocationPosition):
2205         (LayoutTestController::setMockGeolocationError):
2206         * DumpRenderTree/chromium/LayoutTestController.h:
2207         * DumpRenderTree/chromium/WebViewHost.cpp:
2208         (WebViewHost::geolocationClient):
2209         (WebViewHost::geolocationClientMock):
2210         (WebViewHost::reset):
2211         * DumpRenderTree/chromium/WebViewHost.h:
2212
2213 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
2214
2215         Reviewed by Martin Robinson.
2216
2217         [GTK] Add hasSpellingMarker support to the DRT
2218         https://bugs.webkit.org/show_bug.cgi?id=50739
2219
2220         Implemented the hasSpellingMarker to support spelling tests.
2221
2222         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2223         (LayoutTestController::hasSpellingMarker):
2224
2225 2010-12-10  Eric Seidel  <eric@webkit.org>
2226
2227         Reviewed by Ojan Vafai.
2228
2229         webkit-patch: not possible to use build-and-test with local commits
2230         https://bugs.webkit.org/show_bug.cgi?id=33378
2231
2232         Make --no-clean not even check if we have local commits.
2233         It's unclear to me why the code was originally written this way.
2234         I was unable to dig up a reason from svn history.
2235
2236         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2237         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2238
2239 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
2240
2241         Reviewed by Martin Robinson.
2242
2243         [GTK] AX: implement isEnabled in DRT
2244         https://bugs.webkit.org/show_bug.cgi?id=50814
2245
2246         Implement AccessibilityUIElement::isEnabled() for GTK.
2247
2248         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2249         (checkElementState): New function to refactor common code.
2250         (AccessibilityUIElement::isEnabled): Implement this by checking
2251         the current state of the AtkObject.
2252         (AccessibilityUIElement::isSelected): Use the new
2253         checkElementState function.
2254
2255 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2256
2257         Reviewed by Kenneth Rohde Christiansen.
2258
2259         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
2260         https://bugs.webkit.org/show_bug.cgi?id=50750
2261
2262         * MiniBrowser/qt/BrowserView.cpp:
2263         (BrowserView::BrowserView):
2264         * MiniBrowser/qt/BrowserView.h:
2265         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2266         (WTR::WebView::WebView):
2267
2268 2010-12-10  Joone Hur  <joone@kldp.org>
2269
2270         Reviewed by Xan Lopez.
2271
2272         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
2273         https://bugs.webkit.org/show_bug.cgi?id=50808
2274
2275         Unskipping the following test cases:
2276         userscripts/mixed-case-stylesheet.html
2277         userscripts/simple-stylesheet.html
2278         userscripts/user-style-all-frames.html
2279
2280         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2281         (LayoutTestController::addUserStyleSheet):
2282
2283 2010-12-10  Joone Hur  <joone@kldp.org>
2284
2285         Reviewed by Eric Seidel.
2286
2287         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
2288         https://bugs.webkit.org/show_bug.cgi?id=50783
2289
2290         This patch allows to unskip the following test cases:
2291         printing/page-rule-selection.html
2292         printing/page-format-data.html
2293
2294         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2295         (LayoutTestController::pageProperty): Added.
2296         (LayoutTestController::isPageBoxVisible): Ditto.
2297         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
2298         (LayoutTestController::addUserStyleSheet): Ditto.
2299
2300 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2301
2302         Reviewed by Kenneth Rohde Christiansen.
2303
2304         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
2305
2306         A menu allows to switch QNAM back to the same thread.
2307
2308         * QtTestBrowser/launcherwindow.cpp:
2309         (LauncherWindow::initializeView):
2310         (LauncherWindow::createChrome):
2311         (LauncherWindow::toggleThreadedQnam):
2312         * QtTestBrowser/launcherwindow.h:
2313         (WindowOptions::WindowOptions):
2314         * QtTestBrowser/webpage.cpp:
2315         (WebPage::WebPage):
2316         (WebPage::setQnamThreaded):
2317         * QtTestBrowser/webpage.h:
2318         (QnamThread::QnamThread):
2319         (QnamThread::~QnamThread):
2320         (QnamThread::networkAccessManager):
2321         (QnamThread::run):
2322
2323 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
2324
2325         Reviewed by Xan Lopez.
2326
2327         [Gtk] style="font-family: courier" makes text disappear
2328         https://bugs.webkit.org/show_bug.cgi?id=47452
2329
2330         Add a test that verifies that fonts without valid charmaps are
2331         never selected.
2332
2333         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2334         (initializeFonts): Initialize DRT with our font (derived from Ahem)
2335         that has no valid charmap.
2336         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
2337         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
2338         settings which may disable selection of bitmap fonts.
2339
2340 2010-12-10  Eric Seidel  <eric@webkit.org>
2341
2342         Unreviewed.
2343
2344         The commit-queue should file bugs about flaky tests it encounters
2345         https://bugs.webkit.org/show_bug.cgi?id=50803
2346
2347         create_bug_for_flaky_test was insufficiently tested, thus buggy.
2348         Now it's tested.
2349
2350         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2351         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2352
2353 2010-12-10  Eric Seidel  <eric@webkit.org>
2354
2355         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
2356
2357         The commit-queue should file bugs about flaky tests it encounters
2358         https://bugs.webkit.org/show_bug.cgi?id=50803
2359
2360         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2361
2362 2010-12-09  Eric Seidel  <eric@webkit.org>
2363
2364         Reviewed by Adam Barth.
2365
2366         The commit-queue should file bugs about flaky tests it encounters
2367         https://bugs.webkit.org/show_bug.cgi?id=50803
2368
2369         This change got a bit big.  I also added a new config.urls file
2370         because I needed to share the view_source_url code with committervalidator.py.
2371
2372         This adds a new class FlakyTestReporter which holds all the logic about
2373         reporting flaky tests to bugzilla.
2374
2375         Right now this code knows how to look up bugs for flaky tests.
2376         If it can't find a bug filed from the commit-queue, it will open a new
2377         one, ccing the relevant people and adding information about the failure.
2378
2379         It is not yet smart enough to chase down duplicate chains, or to include
2380         the actual failure diff.  But those can be added in later iterations.
2381
2382         * Scripts/webkitpy/common/checkout/api.py:
2383         * Scripts/webkitpy/common/checkout/changelog.py:
2384         * Scripts/webkitpy/common/checkout/commitinfo.py:
2385         * Scripts/webkitpy/common/config/committervalidator.py:
2386         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2387         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2388         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
2389         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2390         * Scripts/webkitpy/tool/bot/irc_command.py:
2391         * Scripts/webkitpy/tool/bot/sheriff.py:
2392         * Scripts/webkitpy/tool/commands/download.py:
2393         * Scripts/webkitpy/tool/commands/queues.py:
2394         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2395         * Scripts/webkitpy/tool/comments.py:
2396         * Scripts/webkitpy/tool/mocktool.py:
2397         * Scripts/webkitpy/tool/steps/commit.py:
2398
2399 2010-12-09  Eric Seidel  <eric@webkit.org>
2400
2401         Reviewed by Adam Barth.
2402
2403         Teach webkit-patch how to search bugzilla
2404         https://bugs.webkit.org/show_bug.cgi?id=50500
2405
2406         This is a step towards teaching webkitpy how to file
2407         new bugs for flaky tests and update them when new flakes occur.
2408
2409         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2410         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2411         * Scripts/webkitpy/tool/commands/__init__.py:
2412         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
2413
2414 2010-12-09  Adam Barth  <abarth@webkit.org>
2415
2416         Reviewed by Ojan Vafai.
2417
2418         commit-queue errors out due to local commits
2419         https://bugs.webkit.org/show_bug.cgi?id=50766
2420
2421         We seem to be tripping over having local commits in the working copy a
2422         lot recently.  I don't quite fully understand what the issue is, but
2423         this patch attempts to solve the problem by adding an explicit clean
2424         step before processing a patch.  Previously, we did the cleaning as
2425         part of the apply-attachment step, so this might not actually fix the
2426         problem.
2427
2428         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2429         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2430         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2431
2432 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
2433
2434         Reviewed by Ojan Vafai.
2435
2436         Make new-run-webkit-tests --lint-test-files log slightly better
2437         messages and return -1 if lint fails. Remove the
2438         'suppress_errors' keyword param to the TestExpectationsFile
2439         class, and clean up logging and exception raising for error
2440         handling. Also add more unit tests and clean up the unit test code a bit.
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=50205
2443
2444         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2445         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2446         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
2447         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
2448         * Scripts/webkitpy/layout_tests/port/chromium.py:
2449         * Scripts/webkitpy/style/checkers/test_expectations.py:
2450         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2451
2452 2010-12-09  Tony Chang  <tony@chromium.org>
2453
2454         Unreviewed, fix for windows code.  We were catching the wrong
2455         exception in Windows.
2456
2457         * Scripts/webkitpy/common/system/filesystem.py:
2458
2459 2010-12-09  Antonio Gomes  <agomes@rim.com>
2460
2461         Reviewed by Martin Robinson.
2462
2463         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
2464         https://bugs.webkit.org/show_bug.cgi?id=48429
2465
2466         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
2467
2468         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2469         (LayoutTestController::workerThreadCount):
2470
2471 2010-12-06  Philippe Normand  <pnormand@igalia.com>
2472
2473         Reviewed by Martin Robinson.
2474
2475         [GTK] Support the Mozilla-style Fullscreen Javascript API
2476         https://bugs.webkit.org/show_bug.cgi?id=50572
2477
2478         Enable the Javascript Fullscreen support in the GtkLauncher. Also
2479         make DRT update the Chrome when the WebView settings have been
2480         reset to consistent values.
2481
2482         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2483         (resetDefaultsToConsistentValues):
2484         * GtkLauncher/main.c:
2485         (create_window):
2486         * Scripts/build-webkit:
2487
2488 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
2489
2490         Reviewed by Tor Arne Vestbø
2491
2492         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
2493         https://bugs.webkit.org/show_bug.cgi?id=50742
2494
2495         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
2496
2497         * Scripts/webkitdirs.pm:
2498
2499 2010-12-09  Joone Hur  <joone@kldp.org>
2500
2501          Reviewed by Martin Robinson.
2502
2503          [GTK] Support for viewport meta tag
2504          https://bugs.webkit.org/show_bug.cgi?id=45443
2505
2506          Add support for testing the viewport properties for WebKitGtk.
2507
2508          * DumpRenderTree/LayoutTestController.cpp:
2509          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
2510          (LayoutTestController::staticFunctions):
2511          * DumpRenderTree/LayoutTestController.h:
2512          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2513          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
2514          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2515          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2516          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2517          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2518          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2519          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2520          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2521          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2522
2523 2010-12-08  William Siegrist <wsiegrist@apple.com>
2524
2525         Reviewed by Eric Seidel.
2526
2527         Migrate buildbot.py from xmlrpc to json.
2528         https://bugs.webkit.org/show_bug.cgi?id=50647
2529
2530         * Scripts/webkitpy/common/net/buildbot.py:
2531
2532 2010-12-08  Tony Chang  <tony@chromium.org>
2533
2534         Reviewed by Eric Seidel.
2535
2536         make starting the websocket server more reliable on windows
2537         https://bugs.webkit.org/show_bug.cgi?id=50712
2538
2539         * Scripts/webkitpy/common/system/filesystem.py:
2540         (remove): Substitute method for os.remove to retry on error on Windows
2541         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2542         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
2543
2544 2010-12-08  Jessie Berlin  <jberlin@apple.com>
2545
2546         Reviewed by Adam Roben.
2547
2548         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
2549         https://bugs.webkit.org/show_bug.cgi?id=50656
2550
2551         * MiniBrowser/mac/BrowserWindowController.m:
2552         (-[BrowserWindowController awakeFromNib]):
2553         Indicate that exceededDatabaseQuota is not implemented.
2554         * MiniBrowser/win/BrowserView.cpp:
2555         (BrowserView::create):
2556         Ditto.
2557         * WebKitTestRunner/TestController.cpp:
2558         (WTR::createOtherPage):
2559         Ditto.
2560         (WTR::TestController::initialize):
2561         Ditto.
2562
2563 2010-12-08  Antonio Gomes  <agomes@rim.com>
2564
2565         Reviewed by Martin Robinson.
2566
2567         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
2568         https://bugs.webkit.org/show_bug.cgi?id=48429
2569
2570         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
2571         * webkit_gc_collect_javascript_objects;
2572         * webkit_gc_collect_javascript_objects_on_alternate_thread;
2573         * webkit_gc_count_javascript_objects;
2574         * webkit_web_frame_layout.
2575
2576         These were all only used by GTK+ DRT.
2577
2578         * DumpRenderTree/gtk/EventSender.cpp:
2579         (dispatchEvent):
2580         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2581         (GCController::collect):
2582         (GCController::collectOnAlternateThread):
2583         (GCController::getJSObjectCount):
2584
2585 2010-12-07  Tony Chang  <tony@chromium.org>
2586
2587         Reviewed by Ojan Vafai.
2588
2589         [chromium] force NRWT to use DRT
2590         https://bugs.webkit.org/show_bug.cgi?id=50359
2591
2592         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2593
2594 2010-12-06  Sam Weinig  <sam@webkit.org>
2595
2596         Reviewed by Anders Carlsson.
2597
2598         Generalize didChangeLocationWithinPageForFrame for all same document navigations
2599         https://bugs.webkit.org/show_bug.cgi?id=50584
2600
2601         * MiniBrowser/mac/BrowserWindowController.m:
2602         (didSameDocumentNavigationForFrame):
2603         (-[BrowserWindowController awakeFromNib]):
2604         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
2605         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2606         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2607         (TestWebKitAPI::TEST):
2608         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2609         (WTR::InjectedBundlePage::InjectedBundlePage):
2610         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
2611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2612         * WebKitTestRunner/TestController.cpp:
2613         (WTR::TestController::initialize):
2614
2615 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
2616
2617         Reviewed by Ojan Vafai.
2618
2619         Make TestResultsServer return 404 for non-existing results files.
2620         https://bugs.webkit.org/show_bug.cgi?id=50581
2621
2622         * TestResultServer/handlers/testfilehandler.py:
2623
2624 2010-12-06  Tony Chang  <tony@chromium.org>
2625
2626         Reviewed by Ojan Vafai.
2627
2628         [chromium] fix an assert hit in DRT
2629         https://bugs.webkit.org/show_bug.cgi?id=50575
2630
2631         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
2632         semantics.
2633
2634         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2635         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2636         WTF::RefCountedBase::ref()).
2637
2638         * DumpRenderTree/chromium/TestWebWorker.h:
2639         (TestWebWorker::TestWebWorker):
2640
2641 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2642
2643         Reviewed by Eric Seidel.
2644
2645         make webkit-patch command work when the git branch is not synced to the remote svn branch
2646         https://bugs.webkit.org/show_bug.cgi?id=50424
2647
2648         * Scripts/webkitpy/common/checkout/scm.py:
2649         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2650
2651 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2652
2653         Reviewed by Andreas Kling.
2654
2655         [WINCE] Add build system
2656         https://bugs.webkit.org/show_bug.cgi?id=50522
2657
2658         * CMakeListsWinCE.txt: Added.
2659
2660 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2661
2662         Reviewed by Tony Chang.
2663
2664         Allow the Chromium port to have Leopard-specific baselines
2665         https://bugs.webkit.org/show_bug.cgi?id=50506
2666
2667         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2668
2669 2010-12-03  Tony Chang  <tony@chromium.org>
2670
2671         Reviewed by Kent Tamura.
2672
2673         [chromium] fix 2 bugs with inspector tests in DRT
2674         https://bugs.webkit.org/show_bug.cgi?id=50492
2675
2676         Tasks can outlive the tasklist (even when canceled) so this was
2677         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2678         when a task is canceled.
2679
2680         Also fix an assert when closing devtool windows by copying some
2681         logic from test_shell.
2682
2683         * DumpRenderTree/chromium/Task.cpp:
2684         (WebTask::~WebTask):
2685         (TaskList::revokeAll):
2686         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2687             the tasklist (since the task can outlive the tasklist).
2688         * DumpRenderTree/chromium/TestShell.h:
2689         (TestShell::devToolsWebView):
2690         * DumpRenderTree/chromium/WebViewHost.cpp:
2691         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2692             a window if the window has devtools loaded.  This avoids an
2693             ASSERT and matches test_shell.
2694
2695 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2696
2697         Reviewed by Martin Robinson.
2698
2699         [GTK] Fix GtkLauncher.c style, use webkit style
2700         https://bugs.webkit.org/show_bug.cgi?id=50542
2701
2702         * GtkLauncher/main.c:
2703         (activateUriEntryCb):
2704         (updateTitle):
2705         (linkHoverCb):
2706         (notifyTitleCb):
2707         (notifyLoadStatusCb):
2708         (notifyProgressCb):
2709         (destroyCb):
2710         (goBackCb):
2711         (goForwardCb):
2712         (create_webViewCb):
2713         (webViewReadyCb):
2714         (closeWebViewCb):
2715         (createBrowser):
2716         (createStatusbar):
2717         (createToolbar):
2718         (createWindow):
2719         (main):
2720
2721 2010-12-04  Antonio Gomes  <agomes@rim.com>
2722
2723         Reviewed by Martin Robinson.
2724
2725         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2726         https://bugs.webkit.org/show_bug.cgi?id=48429
2727
2728         Moved more private method declared with WEBKIT_API to
2729         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2730
2731         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2732         (resetDefaultsToConsistentValues):
2733         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2734         (LayoutTestController::addOriginAccessWhitelistEntry):
2735         (LayoutTestController::execCommand):
2736         (LayoutTestController::isCommandEnabled):
2737
2738 2010-12-04  Antonio Gomes  <agomes@rim.com>
2739
2740         Reviewed by Andreas Kling.
2741
2742         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2743
2744         Method was removed by http://trac.webkit.org/changeset/71604
2745
2746         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2747
2748 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2749
2750         Reviewed by Xan Lopez.
2751
2752         [GTK] Fix compilation warnings reported by clang
2753         https://bugs.webkit.org/show_bug.cgi?id=50252
2754
2755         * GtkLauncher/main.c:
2756         (create_window): The create_statusbar function does not have
2757         parameters.
2758
2759 2010-12-05  Robert Hogan  <robert@webkit.org>
2760
2761         Reviewed by Andreas Kling.
2762
2763         [Qt] Zero-sized font does not yet work
2764
2765         Fix fast/text/font-size-zero.html
2766
2767         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2768
2769         https://bugs.webkit.org/show_bug.cgi?id=49759
2770
2771         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2772         (WebCore::WebPage::WebPage):
2773
2774 2010-12-04  Sam Weinig  <sam@webkit.org>
2775
2776         Reviewed by Jon Honeycutt.
2777
2778         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2779         https://bugs.webkit.org/show_bug.cgi?id=50511
2780
2781         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2782         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2783
2784         * MiniBrowser/mac/BrowserWindowController.m:
2785         (didChangeLocationWithinPageForFrame):
2786         (-[BrowserWindowController awakeFromNib]):
2787         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2788         * TestWebKitAPI/PlatformUtilities.cpp:
2789         (TestWebKitAPI::Util::toWK):
2790         * TestWebKitAPI/PlatformUtilities.h:
2791         (TestWebKitAPI::Util::adoptWK):
2792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2793         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2794         (TestWebKitAPI::nullJavaScriptCallback):
2795         (TestWebKitAPI::didFinishLoadForFrame):
2796         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2797         (TestWebKitAPI::TEST):
2798         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2799         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2800         * TestWebKitAPI/win/copy-resources.cmd:
2801         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2802         (WTR::InjectedBundlePage::InjectedBundlePage):
2803         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2804         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2805         * WebKitTestRunner/TestController.cpp:
2806         (WTR::TestController::initialize):
2807
2808 2010-11-08  Antonio Gomes  <agomes@rim.com>
2809
2810         Reviewed by Martin Robinson.
2811
2812         [Gtk] Populate DumpRenderTreeSupportGtk
2813         https://bugs.webkit.org/show_bug.cgi?id=48429
2814
2815         Made the previous calls to webkit_web_frame* functions defined as private
2816         APIs in webkitprivate.h go through DRTSupportGtk.
2817
2818         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2819         (AccessibilityController::focusedElement):
2820         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2821         (dumpFramesAsText):
2822         (resetDefaultsToConsistentValues):
2823         (dump):
2824         (webViewDocumentLoadFinished):
2825         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2826         (LayoutTestController::counterValueForElementById):
2827         (LayoutTestController::pageNumberForElementById):
2828         (LayoutTestController::numberOfPages):
2829         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2830         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2831         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2832         (LayoutTestController::numberOfActiveAnimations):
2833         (LayoutTestController::suspendAnimations):
2834         (LayoutTestController::resumeAnimations):
2835         (LayoutTestController::markerTextForListItem):
2836
2837 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2838
2839         Reviewed by Tony Chang.
2840
2841         Rebaseline server: use pretty text diff output
2842         https://bugs.webkit.org/show_bug.cgi?id=50484
2843
2844         Serve *-pretty-diff.html for text diff output.
2845
2846         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2847         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2848         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2849         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2850
2851 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2852
2853         Unreviewed, rolling out r73302.
2854         http://trac.webkit.org/changeset/73302
2855         https://bugs.webkit.org/show_bug.cgi?id=50499
2856
2857         Causes crashes in debug LayoutTests (Requested by xan_ on
2858         #webkit).
2859
2860         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2861         (AccessibilityUIElement::AccessibilityUIElement):
2862         (AccessibilityUIElement::parentElementCallback):
2863         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2864         * DumpRenderTree/chromium/CppBoundClass.cpp:
2865         * DumpRenderTree/chromium/CppBoundClass.h:
2866
2867 2010-12-03  Sam Weinig  <sam@webkit.org>
2868
2869         Reviewed by Maciej Stachowiak.
2870
2871         Enable <a ping> for Mac/Windows/WebKit2 builds
2872         <rdar://problem/8504473>
2873         https://bugs.webkit.org/show_bug.cgi?id=50488
2874
2875         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2876         (TestWebKitAPI::TEST): Test that the default value of
2877         WKPreferencesGetHyperlinkAuditingEnabled is true.
2878
2879 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2880
2881         Reviewed by Chris Fleizach.
2882
2883         Include the FrameView widget of a RenderWidget in the accessibility tree.
2884         https://bugs.webkit.org/show_bug.cgi?id=49106
2885
2886         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2887         (AccessibilityUIElement::AccessibilityUIElement):
2888         (AccessibilityUIElement::parentElementCallback):
2889         (AccessibilityUIElement::isEqualCallback):
2890         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2891         * DumpRenderTree/chromium/CppBoundClass.cpp:
2892         (CppBoundClass::getFromCppVariant):
2893         * DumpRenderTree/chromium/CppBoundClass.h:
2894
2895 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2896
2897         Reviewed by Tony Chang.
2898
2899         Rebaseline server: organize tests by state, add dry run mode
2900         https://bugs.webkit.org/show_bug.cgi?id=50473
2901
2902         Group tests in the menu by state, so that it's easier to see after
2903         processing the queue which failed.
2904
2905         Add support for the --dry-run flag so that it's easier to test changes
2906         such as this (stubs out filesystem and SCM operations).
2907
2908         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2909         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2910         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2911
2912 2010-12-03  Brady Eidson  <beidson@apple.com>
2913
2914         Reviewed by Anders Carlsson.
2915
2916         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2917         WebKit2 Authentication Support
2918
2919         Keep these builds working:
2920         * MiniBrowser/mac/BrowserWindowController.m:
2921         (-[BrowserWindowController awakeFromNib]):
2922
2923         * WebKitTestRunner/TestController.cpp:
2924         (WTR::TestController::initialize):
2925
2926 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2927
2928         Reviewed by Tony Chang.
2929
2930         Rebaseline server: move existing baselines
2931         https://bugs.webkit.org/show_bug.cgi?id=50421
2932
2933         Implement moving of existing baselines: move all files that are about
2934         to be overwriten by update baselines.
2935
2936         Also fix a typo in the UI JS.
2937
2938         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2939         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2940         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2941
2942 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2943
2944         Unreviewed, rolling out r73211.
2945         http://trac.webkit.org/changeset/73211
2946         https://bugs.webkit.org/show_bug.cgi?id=50450
2947
2948         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2949         yutak on #webkit).
2950
2951         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2952
2953 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2954
2955         Unreviewed, rolling out r73222.
2956         http://trac.webkit.org/changeset/73222
2957         https://bugs.webkit.org/show_bug.cgi?id=50449
2958
2959         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2960         (Requested by yutak on #webkit).
2961
2962         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2963         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2964         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2965         * Scripts/webkitpy/layout_tests/port/base.py:
2966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2967         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2968
2969 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2970
2971         Unreviewed, rolling out r73228.
2972         http://trac.webkit.org/changeset/73228
2973         https://bugs.webkit.org/show_bug.cgi?id=50448
2974
2975         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2976         (Requested by yutak on #webkit).
2977
2978         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2979         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2980         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2981         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2982         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2983
2984 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2985
2986         Unreviewed, rolling out r73231.
2987         http://trac.webkit.org/changeset/73231
2988         https://bugs.webkit.org/show_bug.cgi?id=50443
2989
2990         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2991         (Requested by yutak on #webkit).
2992
2993         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2994         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2996         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2997
2998 2010-12-03  David Levin  <levin@chromium.org>
2999
3000         Reviewed by Shinichiro Hamaji.
3001
3002         check-webkit-style: false positive reported for #if macro
3003         https://bugs.webkit.org/show_bug.cgi?id=48242
3004
3005         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
3006           all preprocessor commands.
3007         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
3008
3009 2010-12-02  Eric Seidel  <eric@webkit.org>
3010
3011         Reviewed by Adam Barth.
3012
3013         Update the EWSTools scripts to use modern-style git repos
3014         https://bugs.webkit.org/show_bug.cgi?id=50402
3015
3016         * EWSTools/create-webkit-git:
3017         * EWSTools/start-commit-queue.sh:
3018         * EWSTools/start-queue.sh:
3019
3020 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3021
3022         Fix Chromium Linux plugin tests by not logging
3023         unconditionally from the event handling code.
3024
3025         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3026         (handleEventX11):
3027
3028 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3029
3030         Reviewed by Tony Chang.
3031
3032         nrwt multiprocessing - move logic back into run_webkit_tests
3033
3034         This change moves a bunch of logic that I had put into
3035         message_broker back into run_webkit_tests, in a slightly
3036         different format. WorkerMessageBroker needed to become less aware of
3037         the logic the TestRunner class uses, and more generic.
3038         Eventually the MessageBroker will only do generic messaging and
3039         thread/process-pooling, and (almost) all of the
3040         run-webkit-tests-specific logic will be moved to
3041         run_webkit_tests.py and dump_render_tree_thread.py.
3042
3043         The biggest changes are that the Broker can now start a single
3044         worker, but the responsibility for starting all of them is pushed
3045         back to the TestRunner (Manager), and the logic for checking if
3046         the threads are done or wedged is moved back to TestRunner. We
3047         also remove WorkerMessageBroker.cleanup (not needed) and
3048         cancel_workers (they have to be cancelled individually).
3049
3050         The  message_broker is now encapsulated inside
3051         TestRunner._run_tests(); it only needs to exist while actually
3052         running the tests.
3053
3054         Also, delete a bunch of tests in message_broker_unittest that no
3055         longer make much sense.
3056
3057         This patch depends on bug 50372.
3058
3059         https://bugs.webkit.org/show_bug.cgi?id=50374
3060
3061         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3062         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3063         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3064         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3065         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3066
3067 2010-12-02  Hayato Ito  <hayato@chromium.org>
3068
3069         Reviewed by Eric Seidel.
3070
3071         Refactor test_types's compare_output() method so that it takes a
3072         TestInput object.
3073
3074         compare_output() will need additional information included in a TestInput
3075         object to support reftests. This change is a pre-requirement of that.
3076
3077         https://bugs.webkit.org/show_bug.cgi?id=50362
3078
3079         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3080         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3081         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3082         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
3083         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3084
3085 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3086
3087         Reviewed by Anders Carlsson.
3088
3089         Add the ability to run script on 'new' and 'paint' in the test plugin
3090         https://bugs.webkit.org/show_bug.cgi?id=50425
3091
3092         Add "onnew" and "onpaintevent" attributes to the test plugin,
3093         so that tests can run JS at these times.
3094
3095         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3096         (pluginAllocate):
3097         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3098         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3099         (NPP_New):
3100         (NPP_Destroy):
3101         (handleEventCarbon):
3102         (handleEventCocoa):
3103         (NPP_HandleEvent):
3104
3105 2010-12-02  Sam Weinig  <sam@webkit.org>
3106
3107         Fix Qt build.
3108
3109         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3110         (WTR::PlatformWebView::PlatformWebView):
3111
3112 2010-12-02  Sam Weinig  <sam@webkit.org>
3113
3114         Reviewed by Anders Carlsson.
3115
3116         WebKit2 Preferences should be held off the PageGroup, not the Context
3117         https://bugs.webkit.org/show_bug.cgi?id=50414
3118
3119         Update for API changes.
3120
3121         * WebKitTestRunner/PlatformWebView.h:
3122         * WebKitTestRunner/TestController.cpp:
3123         (WTR::createOtherPage):
3124         (WTR::TestController::initialize):
3125         (WTR::TestController::resetStateToConsistentValues):
3126         * WebKitTestRunner/TestController.h:
3127         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3128         (WTR::PlatformWebView::PlatformWebView):
3129         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3130         (WTR::PlatformWebView::PlatformWebView):
3131
3132 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3133
3134         Reviewed by Tony Chang.
3135
3136         new-run-webkit-tests: minor cleanup for multiprocessing work
3137
3138         This change:
3139         * moves worker naming into TestShellThread, eliminating a
3140           parameter to the constructor and putting the responsibility in
3141           the correct place.
3142         * eliminates the _WorkerState() class in message_broker, because
3143           it turns out that state really needs to be in run_webkit_tests
3144         * renames the Broker classes to be module-private.
3145         * fixes a bunch of minor commenting and whitespace issues to
3146           make subsequent patches a bit clearer.
3147         * Adds a Port hook for default_worker_model() so that we can
3148           accomodate the potential for different worker models on
3149           different ports.
3150         * merge in the fix from 50420 for the brokenness introduced in
3151           bug 50367.
3152
3153         This patch depends on bug 50367.
3154
3155         https://bugs.webkit.org/show_bug.cgi?id=50372
3156
3157         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3158         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3159         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3160         * Scripts/webkitpy/layout_tests/port/base.py:
3161         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3162         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3163
3164 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3165
3166         Reviewed by Tony Chang.
3167
3168         This change is a bunch of cleanup / refactoring of the file
3169         below. It moves a bunch of free functions to methods on the
3170         TestShellThread class, and restructures other methods to be
3171         closer to the structure we'll need for the multiprocessing
3172         rewrite.
3173
3174         It also makes the logic of --run-singly a *lot* easier to follow
3175         by nestling all of the separate-thread logic into a single
3176         routine.
3177
3178         There should be no semantic changes in this patch, just cleanup.
3179
3180         https://bugs.webkit.org/show_bug.cgi?id=50367
3181
3182         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3183
3184 2010-12-02  Tony Chang  <tony@chromium.org>
3185
3186         Unreviewed, rolling out r73164.
3187         http://trac.webkit.org/changeset/73164
3188         https://bugs.webkit.org/show_bug.cgi?id=50359
3189
3190         broke debugger tests on win
3191
3192         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3193
3194 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3195
3196         Reviewed by Tony Chang.
3197
3198         Rebaseline server: add updating of baselines
3199         https://bugs.webkit.org/show_bug.cgi?id=50305
3200
3201         Implements updating of baselines, where we copy -actual.* files over
3202         the current -expected.* files. To do this, we need a
3203         _get_actual_result_files method to get test results files and a
3204         _rebaseline_test method to actually do the file copy and SCM operation.
3205         _rebaseline_test logs output into a buffer, this is useful for both
3206         showing result in the UI and for unit tests.
3207
3208         To make passing around of the various test environment properties
3209         (results directory, filesystem, SCM, etc) easier, add a TestConfig
3210         class for them.
3211
3212         Moving of existing baselines is not implemented yet, this patch is big
3213         enough as it is.
3214
3215         * Scripts/webkitpy/common/system/filesystem.py:
3216         * Scripts/webkitpy/common/system/filesystem_mock.py:
3217         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3218         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3219         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3220         * Scripts/webkitpy/tool/mocktool.py:
3221
3222 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
3223
3224         Unreviewed build fix after vcproj updates.
3225
3226         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
3227         that WIN_CAIRO is defined for this build.
3228         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
3229         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
3230         (these were previously 'Debug_Cairo' and 'Release_Cairo'
3231
3232 2010-12-02  Sam Weinig  <sam@webkit.org>
3233
3234         Reviewed by Anders Carlsson.
3235
3236         WebKit2 needs API to turn on popup blocking
3237         https://bugs.webkit.org/show_bug.cgi?id=50407
3238
3239         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3240         (TestWebKitAPI::TEST):
3241         * WebKitTestRunner/TestController.cpp:
3242         (WTR::TestController::resetStateToConsistentValues):
3243
3244 2010-12-01  Tony Chang  <tony@chromium.org>
3245
3246         Reviewed by Ojan Vafai.
3247
3248         [chromium] force NRWT to use DRT
3249         https://bugs.webkit.org/show_bug.cgi?id=50359
3250
3251         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3252
3253 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
3254
3255         Reviewed by Xan Lopez.
3256
3257         [GTK] DumpRenderTree has two copies of JavaScriptCore
3258         https://bugs.webkit.org/show_bug.cgi?id=49877
3259
3260         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
3261         LDADD list for DumpRenderTree.
3262
3263 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
3264
3265         Unreviewed: Added myself to list of Committers.
3266
3267         * Scripts/webkitpy/common/config/committers.py:
3268
3269 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
3270
3271         Reviewed by Adam Barth.
3272
3273         build-webkit --chromium always updates DEPS and re-generates project files
3274         https://bugs.webkit.org/show_bug.cgi?id=50340
3275
3276         Make build-webkit --chromium invoke update-webkit-chromium only when
3277         --update-chromium is passed in, so that we don't add 20 seconds to all
3278         builds.
3279
3280         Making all invocations update was added with r61883, with the goal of
3281         making EWS bots always update. The bots will switch to using this flag
3282         (as will all other webkit-patch build steps) so nothing should change
3283         for them.
3284
3285         * Scripts/webkitdirs.pm:
3286         * Scripts/webkitpy/common/config/ports.py:
3287         * Scripts/webkitpy/common/config/ports_unittest.py:
3288
3289 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
3290
3291         Reviewed by Tony Chang.
3292
3293         new-run-webkit-tests: add a --dry-run / -n flag
3294         https://bugs.webkit.org/show_bug.cgi?id=50045
3295
3296         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3297         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3298
3299 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3300
3301         Reviewed by Adam Roben.
3302
3303         WinCairo build should not use link-time code generation (LTCG)
3304         https://bugs.webkit.org/show_bug.cgi?id=50353
3305
3306         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3307         * DumpRenderTree/win/DumpRenderTree.vcproj:
3308         * DumpRenderTree/win/ImageDiff.vcproj:
3309         * FindSafari/FindSafari.vcproj:
3310         * MiniBrowser/MiniBrowser.vcproj:
3311         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3312         * WebKitAPITest/WebKitAPITest.vcproj:
3313         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3314         * WebKitTestRunner/win/InjectedBundle.vcproj:
3315         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3316         * WinLauncher/WinLauncher.vcproj:
3317         * record-memory-win/record-memory-win.vcproj:
3318
3319 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3320
3321         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
3322         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
3323         adding the file to the sources list was not enough to force the rebuild.
3324
3325         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
3326         Remove an empty line at the end of this file to force a rebuild.
3327
3328 2010-12-01  Sam Weinig  <sam@webkit.org>
3329
3330         Fix windows build.
3331
3332         * MiniBrowser/win/BrowserView.cpp:
3333         (BrowserView::create):
3334
3335 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3336
3337         Add missing file to the TestNetscapePlugin sources list after r73057.
3338
3339         * GNUmakefile.am: Add missing file.
3340
3341 2010-12-01  Sam Weinig  <sam@webkit.org>
3342
3343         Reviewed by Anders Carlsson.
3344
3345         Add PageGrouping to WebKit2 API
3346         https://bugs.webkit.org/show_bug.cgi?id=50332
3347
3348         - Update testing harnesses to deal with new PageGroup API.
3349
3350         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3351         (WKBundleInitialize):
3352         * TestWebKitAPI/InjectedBundleController.cpp:
3353         (TestWebKitAPI::InjectedBundleController::initialize):
3354         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
3355         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
3356         * TestWebKitAPI/InjectedBundleController.h:
3357         * TestWebKitAPI/InjectedBundleTest.h:
3358         (TestWebKitAPI::InjectedBundleTest::initialize):
3359         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
3360         * TestWebKitAPI/PlatformUtilities.cpp:
3361         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3362         * TestWebKitAPI/PlatformUtilities.h:
3363         * TestWebKitAPI/PlatformWebView.h:
3364         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3365         (TestWebKitAPI::TEST):
3366         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3367         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3368         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3369         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3370         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3371         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3372         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3373         (WTR::InjectedBundle::didInitializePageGroup):
3374         (WTR::InjectedBundle::initialize):
3375         (WTR::InjectedBundle::beginTesting):
3376         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3377         (WTR::InjectedBundle::pageGroup):
3378         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3379         (WTR::LayoutTestController::addUserScript):
3380         (WTR::LayoutTestController::addUserStyleSheet):
3381         (WTR::LayoutTestController::setXSSAuditorEnabled):
3382         * WebKitTestRunner/TestController.cpp:
3383         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3384         (WTR::PlatformWebView::PlatformWebView):
3385
3386 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3387
3388         Reviewed by Adam Roben.
3389
3390         vcproj changes can't be applied cleanly by the Windows EWS bot
3391         https://bugs.webkit.org/show_bug.cgi?id=50328
3392
3393         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3394         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
3395         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3396         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
3397         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
3398         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
3399         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
3400         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
3401         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
3402         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
3403         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
3404         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
3405         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
3406         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3407         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
3408         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
3409         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
3410         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
3411         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
3412         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
3413         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
3414         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
3415         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
3416         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
3417         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
3418         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
3419         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
3420         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
3421         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
3422         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
3423         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
3424         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
3425         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
3426         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
3427         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
3428         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
3429         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
3430         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
3431         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
3432         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
3433         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
3434         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
3435         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
3436         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
3437         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
3438
3439 2010-12-01  Anders Carlsson  <andersca@apple.com>
3440
3441         Reviewed by Darin Adler.
3442
3443         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
3444         https://bugs.webkit.org/show_bug.cgi?id=50336
3445
3446         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3447         Add new test.
3448
3449         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3450         (PluginTest::NPP_New):
3451         Add default implementation/
3452
3453         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3454         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
3455         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
3456         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
3457         Get the user agent.
3458
3459         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3460         (NPP_New):
3461         Call PluginTest::NPP_New.
3462
3463         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3464         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3465         Add new files.
3466
3467         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3468         (webkit_test_plugin_new_instance):
3469         Call PluginTest::NPP_New.
3470
3471 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3472
3473         [wx] Build fixes after recent trunk changes.
3474
3475         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3476         (LayoutTestController::findString):
3477         * wx/build/settings.py:
3478
3479 2010-12-01  Dan Bernstein  <mitz@apple.com>
3480
3481         Reviewed by Darin Adler.
3482
3483         WebKitTestRunner needs layoutTestController.findString
3484         https://bugs.webkit.org/show_bug.cgi?id=50238
3485
3486         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
3487         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3488         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
3489         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3490
3491 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3492
3493         Try using svn:eol-style native on a vcproj file.
3494
3495         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
3496
3497 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
3498
3499         Reviewed by Adam Roben.
3500
3501         [WINCE] Add WinCELauncher
3502         https://bugs.webkit.org/show_bug.cgi?id=50217
3503
3504         * WinCELauncher/main.cpp: Added.
3505
3506 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3507
3508         Reviewed by Kenneth Rohde Christiansen.
3509
3510         [Qt] Implement layoutTestController.findString
3511         https://bugs.webkit.org/show_bug.cgi?id=50236
3512
3513         Add the missing function to the LayoutTestController.
3514
3515         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3516         (LayoutTestController::findString):
3517         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3518
3519 2010-11-30  Tony Chang  <tony@chromium.org>
3520
3521         Reviewed by Adam Barth.
3522
3523         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
3524         https://bugs.webkit.org/show_bug.cgi?id=49036
3525
3526         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
3527             for CppVariants.
3528         (LayoutTestController::cppVariantToBool):
3529         (LayoutTestController::cppVariantToInt32):
3530         (LayoutTestController::setDatabaseQuota):
3531         (LayoutTestController::evaluateInWebInspector):
3532         (LayoutTestController::setMockGeolocationError):
3533
3534 2010-11-30  Eric Seidel  <eric@webkit.org>
3535
3536         Reviewed by Tony Chang.
3537
3538         update-webkit should call git fetch before git svn rebase
3539         https://bugs.webkit.org/show_bug.cgi?id=50273
3540
3541         After discussion on webkit-dev, we've decided to move the "default"
3542         git setup to pulling updates from git.webkit.org in preference
3543         to rebuilding the local svn index using git svn fetch every time.
3544
3545         This change should have no effect on people using the "old" git setup
3546         and should dramatically increase the speed of updates for those using
3547         the "new" git setup along with update-webkit.  I'm about to move the
3548         EWS and other queues over to this setup once this lands.
3549
3550         * Scripts/update-webkit:
3551
3552 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
3553
3554         Reviewed by Xan Lopez.
3555
3556         GTK: AX: implement press in DRT
3557         https://bugs.webkit.org/show_bug.cgi?id=36146
3558
3559         Implement AccessibilityUIElement::press() for GTK.
3560
3561         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3562         (AccessibilityUIElement::press): Implemented.
3563
3564 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
3565
3566         Reviewed by Tony Chang.
3567
3568         config.webkit_base_dir returns a path with a trailing slash
3569         https://bugs.webkit.org/show_bug.cgi?id=50197
3570
3571         config.webkit_base_dir() should return a path without a trailing slash,
3572         like all the other methods that return paths.
3573
3574         Undoes MockFileSytem changes by r72640, since they're no longer
3575         necessary for GetBaselinesTest to pass.
3576
3577         * Scripts/webkitpy/common/system/filesystem_mock.py:
3578         * Scripts/webkitpy/layout_tests/port/base.py:
3579         * Scripts/webkitpy/layout_tests/port/config.py:
3580         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3581
3582 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3583
3584         Reviewed by Tony Chang.
3585
3586         Rebaseline server: baseline display tweaks
3587         https://bugs.webkit.org/show_bug.cgi?id=50207
3588
3589         Determine which baselines were used when running the tests and highlight
3590         them in the UI. Sort platform names alphabetically.
3591
3592         Also makes the server URL be launched in the user's browser
3593         automatically.
3594
3595         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3596         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3597         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3598         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3599         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3600
3601 2010-11-30  Dan Bernstein  <mitz@apple.com>
3602
3603         Reviewed by Anders Carlsson.
3604
3605         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
3606         https://bugs.webkit.org/show_bug.cgi?id=50238
3607
3608         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3609         (WTR::LayoutTestController::findString): Added.
3610         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3611
3612 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
3613
3614         Reviewed by Adam Roben.
3615
3616         All projects on Windows should use cmd files for build events
3617         https://bugs.webkit.org/show_bug.cgi?id=50213
3618
3619         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3620         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
3621         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
3622         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3623         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
3624         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
3625         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3626         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
3627         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
3628         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
3629         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3630         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
3631         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
3632         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3633         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3634         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3635         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3636         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3637         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.