1 2013-09-18 Filip Pizlo <fpizlo@apple.com>
3 DFG should support Int52 for local variables
4 https://bugs.webkit.org/show_bug.cgi?id=121064
6 Reviewed by Oliver Hunt.
8 * Scripts/run-jsc-stress-tests:
10 2013-09-18 peavo@outlook.com <peavo@outlook.com>
12 [Win] TestWebKitAPI does not compile.
13 https://bugs.webkit.org/show_bug.cgi?id=121485
15 Reviewed by Brent Fulgham.
17 It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
18 Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
19 to return null, which is the case we want to test.
21 * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
22 (TestWebKitAPI::TEST):
24 2013-09-18 Mario Sanchez Prada <mario.prada@samsung.com>
26 [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
27 https://bugs.webkit.org/show_bug.cgi?id=121495
29 Reviewed by Chris Fleizach.
31 Adapted DRT and WKTR to deal with the new names for the ATK object
32 attributes being exposed for 'aria-haspopup' and 'aria-sort'.
34 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
35 (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
36 (AccessibilityUIElement::stringAttributeValue): Ditto.
37 (AccessibilityUIElement::hasPopup): Ditto.
38 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
39 (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
40 (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
41 (WTR::AccessibilityUIElement::hasPopup): Ditto.
43 2013-09-18 Commit Queue <commit-queue@webkit.org>
45 Unreviewed, rolling out r156019 and r156020.
46 http://trac.webkit.org/changeset/156019
47 http://trac.webkit.org/changeset/156020
48 https://bugs.webkit.org/show_bug.cgi?id=121540
50 Broke tests (Requested by ap on #webkit).
52 * Scripts/run-jsc-stress-tests:
54 2013-09-17 Gwang Yoon Hwang <ryumiel@company100.net>
56 Unreviewed. Add myself as a committer.
58 * Scripts/webkitpy/common/config/contributors.json:
60 2013-09-17 Jae Hyun Park <jae.park@company100.net>
62 Unreviewed. Add myself as a committer.
64 * Scripts/webkitpy/common/config/contributors.json:
66 2013-09-17 Filip Pizlo <fpizlo@apple.com>
68 DFG should support Int52 for local variables
69 https://bugs.webkit.org/show_bug.cgi?id=121064
71 Reviewed by Oliver Hunt.
73 * Scripts/run-jsc-stress-tests:
75 2013-09-17 Alex Christensen <alex.christensen@flexsim.com>
77 Added back and forward buttons to WinLauncher.
78 https://bugs.webkit.org/show_bug.cgi?id=121212
80 Reviewed by Brent Fulgham.
82 * WinLauncher/WinLauncher.cpp:
84 Move new back and forward buttons to correct positions before URL bar.
85 (dllLauncherEntryPoint):
86 Store the default button window procedure and replace with my button procedures.
87 (EditProc): Updated style and renamed from MyEditProc.
88 (BackButtonProc): Added.
89 (ForwardButtonProc): Added.
91 2013-09-17 Michael Saboff <msaboff@apple.com>
93 Unreviewed typo fix after r155999
95 Changed en_US.UTB-8 to en_US.UTF-8
97 * Scripts/run-javascriptcore-tests:
99 2013-09-17 Michael Saboff <msaboff@apple.com>
101 run-jsc-stress-tests fails with ruby version 2
102 https://bugs.webkit.org/show_bug.cgi?id=121521
104 Reviewed by Jessie Berlin.
106 Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
108 * Scripts/run-javascriptcore-tests:
110 2013-09-17 Brent Fulgham <bfulgham@apple.com>
112 [Windows] Unreviewed build fix after r155963.
114 * DumpRenderTree/win/TestRunnerWin.cpp:
115 (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
117 2013-09-17 Anders Carlsson <andersca@apple.com>
121 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
122 (TestWebKitAPI::TEST):
124 2013-09-16 Anders Carlsson <andersca@apple.com>
126 HashMap should work with move-only keys
127 https://bugs.webkit.org/show_bug.cgi?id=121310
129 Reviewed by Darin Adler.
131 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
132 (TestWebKitAPI::TEST):
135 2013-09-17 YuTeh Shen <shenyute@hotmail.com>
137 BrowserMarshal.h build fail
138 https://bugs.webkit.org/show_bug.cgi?id=102938
140 Reviewed by Carlos Garcia Campos.
144 * MiniBrowser/gtk/GNUmakefile.am:
146 2013-09-16 Brent Fulgham <bfulgham@apple.com>
148 [Windows] Clean up WinLauncher by using smart pointers
149 https://bugs.webkit.org/show_bug.cgi?id=121467
151 Reviewed by Anders Carlsson.
153 * WinLauncher/PrintWebUIDelegate.cpp:
154 (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
155 * WinLauncher/WinLauncher.cpp:
156 (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
157 (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
158 (showLastVisitedSites): Smart pointer updates.
159 (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
160 (setToDefaultPreferences): Ditto.
161 (dllLauncherEntryPoint): Ditto.
163 (LaunchInspector): Ditto.
164 (NavigateToHistory): Ditto.
168 2013-09-16 Brent Fulgham <bfulgham@apple.com>
170 [Windows] Add rudimentary history to WinLauncher.
171 https://bugs.webkit.org/show_bug.cgi?id=121463
173 Reviewed by Anders Carlsson.
175 * WinLauncher/WinLauncher.cpp:
176 (updateMenuItemForHistoryItem): Added
177 (showLastVisitedSites): Added
178 (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
179 a new page has been visited.
180 (dllLauncherEntryPoint): Deallocate history on exit.
181 (NavigateToHistory): Added
182 (WndProc): Add handler for history entries
183 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
184 up to 10 history slots.
185 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
186 Windows utility library to allow use of _bstr_t type.
187 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
188 to hold up to 10 history slots.
189 * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
191 2013-09-16 Gustavo Noronha Silva <gns@gnome.org>
193 [GTK] Make symbol export filter more strict, and disable for dev/test builds
194 https://bugs.webkit.org/show_bug.cgi?id=120586
196 Reviewed by Martin Robinson.
198 * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
199 makefiles, so they can be included unconditionally.
200 * GtkLauncher/GNUmakefile.am: added.
201 * Scripts/webkitdirs.pm:
202 (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
203 to configure, since we consider builds done through build-webkit to be development
205 * gtk/GNUmakefile.am: added.
206 * gtk/common.py: do not use the Scripts directory as a reference to the top path;
207 it's not necessary and it will not work now that the Scripts directory is not
208 shipped in the tarball.
210 2013-09-16 Anders Carlsson <andersca@apple.com>
212 WTF::Deque should work with move only types
213 https://bugs.webkit.org/show_bug.cgi?id=121446
215 Reviewed by Andreas Kling.
217 * TestWebKitAPI/Tests/WTF/Deque.cpp:
218 (TestWebKitAPI::TEST):
221 2013-09-16 Wojciech Bielawski <w.bielawski@samsung.com>
223 [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
224 https://bugs.webkit.org/show_bug.cgi?id=98410
226 Reviewed by Darin Adler.
228 Add implementation of click() method of objects returned by eventSender.contextClick().
230 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
231 (MenuItemPrivateData):
232 (WTR::menuItemClickCallback):
233 (WTR::getMenuItemTitleCallback):
234 (WTR::staticMenuItemFinalize):
235 (WTR::getMenuItemClass):
236 (WTR::EventSendingController::contextClick):
238 2013-09-15 Zan Dobersek <zdobersek@igalia.com>
240 Make the GDB webkit.py script compatible with Python v3
241 https://bugs.webkit.org/show_bug.cgi?id=121395
243 Reviewed by Ryosuke Niwa.
245 GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
246 uses of xrange() in the script are replaced with range(), and the print statements are changed into
247 the print() function invocations.
250 (guess_string_length):
253 (WTFCStringPrinter.to_string):
254 (PrintPathToRootCommand.invoke):
256 2013-09-15 Zan Dobersek <zdobersek@igalia.com>
258 [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
259 https://bugs.webkit.org/show_bug.cgi?id=119631
261 Reviewed by Ryosuke Niwa.
263 The perf profiler is attached to the test runner after the test runner has been launched,
264 but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
265 UIProcess, meaning that WebProcess operations will not be profiled.
267 To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
268 This is done in the scope of already present support for wrapper scripts (such as valgrind)
269 that are settable through the --wrapper option. This causes the perf profiler to correctly
270 continue profiling the WebProcess after it was spawned.
272 When the profiler is launched, a wait process is launched with the profiler's pid as the
273 argument. This ensures we can check that the profiler exited normally. If it did not, its
274 output can be corrupted and can cause problems when that output is examined. The after-exit
275 report is avoided in that case.
277 * Scripts/webkitpy/common/system/profiler.py:
278 (Profiler.wrapper_arguments): The method returns an empty list by default.
279 (Perf.__init__): Remove unnecessary member variables.
280 (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
281 (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
282 the method returns a list of arguments that should be used as a wrapper for the test runner.
283 The arguments specify the 'perf record' command, with the output file and the instruction to
284 construct the call graph given as well.
285 (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
286 whitespace in the profile lines.
287 (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
288 running. If it is running even after that, or if the profiler process produced a non-zero exit
289 code, the method reports the profiling failure and returns. Otherwise it continues on reporting
290 the top 10 lines of the profile and how to examine the profile further.
291 * Scripts/webkitpy/port/driver.py:
292 (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
293 as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
294 or an empty list otherwise.
296 * Scripts/webkitpy/port/driver_unittest.py:
297 (DriverTest.make_port): Adjusted so mock host or options objects can be specified
298 for the testing-specific Port object.
299 (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
300 as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
302 (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
303 when profiling on the Linux platform with the perf profiler.
305 2013-09-14 Dan Bernstein <mitz@apple.com>
307 [mac] Check For Framework Include Consistency build phase checks the wrong framework
308 https://bugs.webkit.org/show_bug.cgi?id=121215
310 Reviewed by Mark Rowe.
312 * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
313 WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
314 public and private headers folder paths. Also tweaked the error messages’ format to make
315 Xcode recognize them as errors.
317 2013-09-14 Alberto Garcia <berto@igalia.com>
319 [GTK] Fails to compile if the build directory is in a different partition
320 https://bugs.webkit.org/show_bug.cgi?id=121296
322 Reviewed by Martin Robinson.
324 Instead of using os.symlink() to install the gtk-doc templates,
325 use os.link() first and fall back to os.symlink() if it fails.
328 (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
330 2013-09-14 Alberto Garcia <berto@igalia.com>
332 [GTK] WebKitGTK+ is linking against libxslt in too many places
333 https://bugs.webkit.org/show_bug.cgi?id=121356
335 Reviewed by Martin Robinson.
337 TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
338 so we don't need to link against it.
340 * MiniBrowser/gtk/GNUmakefile.am:
341 * TestWebKitAPI/GNUmakefile.am:
342 * WebKitTestRunner/GNUmakefile.am:
344 2013-09-14 Ross Burton <ross.burton@intel.com>
346 Uses gtk-doc tools even when --disable-gtk-doc passed
347 https://bugs.webkit.org/show_bug.cgi?id=91239
349 Reviewed by Martin Robinson.
351 Don't run generate-gtkdoc on install if gtk-doc is disabled.
355 2013-09-14 Alberto Garcia <berto@igalia.com>
357 [GTK] Fails to compile if the build directory is in a different partition
358 https://bugs.webkit.org/show_bug.cgi?id=121296
360 Reviewed by Carlos Garcia Campos.
362 Use symlinks instead of hard links to support building on a
363 different file system.
366 (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
368 2013-09-13 Darin Adler <darin@apple.com>
370 Use a better name than m_invertibleCTM
371 https://bugs.webkit.org/show_bug.cgi?id=121341
373 Reviewed by Andreas Kling.
375 * Scripts/do-webcore-rename: Updated to do this replace as we do.
377 2013-09-13 Anders Carlsson <andersca@apple.com>
379 Pick the correct overload when a const reference is passed to appendSlowCase.
380 https://bugs.webkit.org/show_bug.cgi?id=121326
382 Reviewed by Darin Adler.
384 * TestWebKitAPI/Tests/WTF/Vector.cpp:
385 (TestWebKitAPI::TEST):
387 2013-09-13 Darin Adler <darin@apple.com>
389 Rename confusingly named "runtimeObject" functions
390 https://bugs.webkit.org/show_bug.cgi?id=121339
392 Reviewed by Sam Weinig.
394 * Scripts/do-webcore-rename: Updated to do this replace as usual.
396 2013-09-13 Filip Pizlo <fpizlo@apple.com>
398 DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
399 https://bugs.webkit.org/show_bug.cgi?id=121330
401 Reviewed by Mark Hahnenberg and Oliver Hunt.
403 We should run tests even if they don't have expected files yet.
405 * Scripts/run-layout-jsc:
407 2013-09-13 Anders Carlsson <andersca@apple.com>
409 Use nullptr instead of 0 in calls to HashMap::add
410 https://bugs.webkit.org/show_bug.cgi?id=121322
412 Reviewed by Sam Weinig.
414 * DumpRenderTree/mac/TestRunnerMac.mm:
415 (TestRunner::evaluateScriptInIsolatedWorld):
416 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
417 (WTR::TestRunner::evaluateScriptInIsolatedWorld):
419 2013-09-13 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
421 [GTK] Move to the new web inspector
422 https://bugs.webkit.org/show_bug.cgi?id=120647
424 Reviewed by Carlos Garcia Campos.
426 * GtkLauncher/main.c:
427 (main): no longer set WEBKIT_INSPECTOR_PATH.
428 * MiniBrowser/gtk/main.c:
430 * Scripts/old-run-webkit-tests:
431 (openDumpTool): ditto.
432 * Scripts/run-gtk-tests: ditto.
433 * Scripts/webkitpy/port/gtk.py:
434 (GtkPort.setup_environ_for_server): ditto.
436 2013-09-13 Allan Sandfeld Jensen <allan.jensen@digia.com>
438 [Qt] REGRESSION(r154444): xss-DENIED test results changed
439 https://bugs.webkit.org/show_bug.cgi?id=120595
441 Reviewed by Jocelyn Turcotte.
443 Avoid overwriting Qt meta properties, which we identify by them being undeletable.
445 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
446 (DumpRenderTree::initJSObjects):
448 2013-09-13 Darin Adler <darin@apple.com>
450 Give actions in Range class NON_SHOUTING_NAMES
451 https://bugs.webkit.org/show_bug.cgi?id=121280
453 Reviewed by Andreas Kling.
455 * Scripts/do-webcore-rename: Updated to do this replace, keeping with
456 the tradition of checking in the last one we did, along with other
457 rename ideas for the future.
459 2013-09-12 Lucas Forschler <lforschler@apple.com>
461 Create short build logs for errors and warnings.
462 https://bugs.webkit.org/show_bug.cgi?id=120614
464 Reviewed by Ryosuke Niwa.
466 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
468 (CompileWebKit.createSummary):
469 -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
471 2013-09-12 Roger Fong <roger_fong@apple.com>
473 Update cygwin downloader to search for packages in the right location.
475 * CygwinDownloader/cygwin-downloader.py:
476 * CygwinDownloader/cygwin-downloader.zip:
478 2013-09-12 Anders Carlsson <andersca@apple.com>
480 Add rudimentary support for move-only types as values in HashMap
481 https://bugs.webkit.org/show_bug.cgi?id=121226
483 Reviewed by Andreas Kling.
485 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
486 (TestWebKitAPI::TEST):
487 Add a HashMap<unsigned, MoveOnly> test.
489 2013-09-12 Gabor Abraham <abrhm@inf.u-szeged.hu>
491 Auto GDB backtrace generation for EFL/GTK/Qt bots.
492 https://bugs.webkit.org/show_bug.cgi?id=119338
494 Reviewed by Csaba Osztrogonác.
496 * Scripts/webkitpy/port/efl.py:
497 (EflPort.check_sys_deps):
499 (EflPort._get_crash_log):
500 * Scripts/webkitpy/port/efl_unittest.py:
501 (EflPortTest.test_show_results_html_file):
503 (EflPortTest.test_get_crash_log):
504 * Scripts/webkitpy/port/gtk.py:
505 (GtkPort._get_crash_log):
506 * Scripts/webkitpy/port/gtk_unittest.py:
507 (GtkPortTest.test_get_crash_log):
508 * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
509 (GDBCrashLogGenerator):
510 (GDBCrashLogGenerator.__init__):
511 (GDBCrashLogGenerator._get_gdb_output):
512 (GDBCrashLogGenerator.generate_crash_log):
513 (GDBCrashLogGenerator.generate_crash_log.match_filename):
514 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
515 (GDBCrashLogGeneratorTest):
516 (GDBCrashLogGeneratorTest.test_generate_crash_log):
518 * Scripts/webkitpy/port/qt.py:
519 (QtPort.default_child_processes):
521 (QtPort._get_crash_log):
522 * Scripts/webkitpy/port/qt_unittest.py:
523 (QtPortTest.test_check_sys_deps):
525 (QtPortTest.test_get_crash_log):
527 2013-09-12 Peter Gal <galpeter@inf.u-szeged.hu>
529 Unreviewed. Moving myself to the commiters list.
531 * Scripts/webkitpy/common/config/contributors.json:
533 2013-09-12 ChangSeok Oh <changseok.oh@collabora.com>
535 [GTK] Add jhbuild-wayland.modules
536 https://bugs.webkit.org/show_bug.cgi?id=120455
538 Reviewed by Gustavo Noronha Silva.
540 Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
541 With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
542 WEBKIT_EXTRA_MODULESETS.
544 * gtk/jhbuild-wayland.modules: Added.
546 2013-09-12 Mario Sanchez Prada <mario.prada@samsung.com>
548 [GTK][WK2] a11y tests unconditionally launching a11y daemons
549 https://bugs.webkit.org/show_bug.cgi?id=120299
551 Reviewed by Carlos Garcia Campos.
553 Use the right variable name to store a reference to the at-spi2
554 bus launcher process, so we can be sure we are terminating it when
555 calling _tear_down_testing_environment().
557 * Scripts/run-gtk-tests:
558 (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
559 instead of _ally_bus_launcher.
561 2013-09-12 Carlos Garcia Campos <cgarcia@igalia.com>
563 [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
564 https://bugs.webkit.org/show_bug.cgi?id=121218
566 Reviewed by Philippe Normand.
568 Skipping the entire suite was added to skip tests when they can't
569 be run because of the environment, for example to skip the a11y
570 tests when the at-spi daemons fail to start. This is no longer
571 true for all the cases, so we can disable the tests that are
572 impossible to run instead of skipping them.
574 * Scripts/run-gtk-tests:
575 (TestRunner.__init__): Initialize the skipped tests list.
576 (TestRunner._setup_testing_environment): Add
577 TestWebKitAccessibility path to the list of disabled tests when
578 at-spi daemon fail to start.
579 (TestRunner._should_run_test_program): Check first if the test
580 program is disabled and then whether it's skipped honoring the
581 skipped command line option.
583 2013-09-12 Samuel White <samuel_white@apple.com>
585 <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
586 https://bugs.webkit.org/show_bug.cgi?id=117651
588 Reviewed by Mario Sanchez Prada.
590 Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
592 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
593 (AccessibilityUIElement::valueDescription):
594 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
595 (WTR::AccessibilityUIElement::valueDescription):
597 2013-09-12 Denis Nomiyama <d.nomiyama@samsung.com>
599 REGRESSION(r154781): accessibility/notification-listeners.html is failing
600 https://bugs.webkit.org/show_bug.cgi?id=120669
602 Reviewed by Chris Fleizach.
604 Fixed 4 problems that were causing notification-listeners.html to fail.
606 Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
607 implemented in axObjectEventListener().
609 A notification for AXFocusedUIElementChanged was incorrectly sent when
610 the element lost focus.
612 Global notification was not dispatched if an element notification was
613 present in the HashMap.
615 connectAccessibilityCallbacks() was connecting signals to callbacks
616 multiple times because it was not checking if
617 disconnectAccessibilityCallbacks() had an early return if there were
620 * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
621 disconnectAccessibilityCallbacks() to inform if the callbacks were
622 successfully disconnected.
623 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
624 (axObjectEventListener): Implemented notifications for
625 AXFocusedUIElementChanged and AXValueChanged. Fixed the global
626 notification, which was not dispatched if an element notification
627 existed. Fixed the notification for AXFocusedUIElementChanged that was
628 incorrectly sent when the element lost focus. In addition, fixed a typo
629 where TRUE should be true.
630 (connectAccessibilityCallbacks): Added early return if
631 disconnectAccessibilityCallbacks() did not disconnect the callbacks.
632 (disconnectAccessibilityCallbacks): Added a return value to inform if
633 callbacks were successfully disconnected.
635 2013-09-11 Anders Carlsson <andersca@apple.com>
637 Try to fix GCC builds.
639 * TestWebKitAPI/Tests/WTF/MoveOnly.h:
641 2013-09-11 Anders Carlsson <andersca@apple.com>
643 Try to fix the build.
645 Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
646 file in the Tests/ directory in the first place.
648 * TestWebKitAPI/CMakeLists.txt:
649 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
650 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
651 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
652 * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
654 2013-09-11 Brent Fulgham <bfulgham@apple.com>
656 [Windows] Build fix for MoveOnly
658 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
659 Tests to include search path.
660 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
663 2013-09-11 Anders Carlsson <andersca@apple.com>
666 https://bugs.webkit.org/show_bug.cgi?id=121192
668 Reviewed by Darin Adler.
670 Add a test for HashSet::take.
672 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
673 (TestWebKitAPI::TEST):
675 2013-09-11 Anders Carlsson <andersca@apple.com>
677 HashSet should work with move only types
678 https://bugs.webkit.org/show_bug.cgi?id=121188
680 Reviewed by Geoffrey Garen.
682 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
683 * TestWebKitAPI/Tests/MoveOnly.h: Added.
684 Move the MoveOnly class from Vector out into its own header.
686 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
687 (TestWebKitAPI::TEST):
688 Add aHashSet<MoveOnly> test.
690 * TestWebKitAPI/Tests/WTF/Vector.cpp:
693 2013-09-11 Brent Fulgham <bfulgham@apple.com>
695 [Windows] Avoid converting from IntSize->SIZE->IntSize
696 https://bugs.webkit.org/show_bug.cgi?id=121180
698 Reviewed by Anders Carlsson.
700 * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
701 (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
703 2013-09-11 Dan Bernstein <mitz@apple.com>
705 REGRESSION (r155561): extract-localizable-strings can miss strings
706 https://bugs.webkit.org/show_bug.cgi?id=121184
708 Reviewed by Darin Adler.
710 * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
711 parenthesis or bracket.
713 2013-09-11 Dan Bernstein <mitz@apple.com>
715 update-webkit-localizable-strings is at least 5.8x slower than it should be
716 https://bugs.webkit.org/show_bug.cgi?id=121178
718 Reviewed by Darin Adler.
720 * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
721 Note that this does not change functionality, because the script already does not understand
722 the line continuation sequence (backslash followed by a newline).
724 2013-09-11 Anders Carlsson <andersca@apple.com>
726 Vector::append doesn't work if element type has overloaded operator&
727 https://bugs.webkit.org/show_bug.cgi?id=121175
729 Reviewed by Brent Fulgham.
733 * TestWebKitAPI/Tests/WTF/Vector.cpp:
734 (TestWebKitAPI::TEST):
736 2013-09-11 Anders Carlsson <andersca@apple.com>
738 Implement Vector::append for move-only types
739 https://bugs.webkit.org/show_bug.cgi?id=120805
741 Reviewed by Sam Weinig.
743 Add a test for Vector<MoveOnly>::append.
745 * TestWebKitAPI/Tests/WTF/Vector.cpp:
746 (TestWebKitAPI::TEST):
748 2013-09-11 Csaba Osztrogonác <ossy@webkit.org>
750 Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
752 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
753 (RunAndUploadPerfTests):
754 (RunAndUploadPerfTests.start):
755 (RunAndUploadPerfTests.getText2):
757 2013-09-11 Anders Carlsson <andersca@apple.com>
759 The style checker shouldn't complain about returning or passing OwnPtr
760 https://bugs.webkit.org/show_bug.cgi?id=121163
762 Reviewed by Antti Koivisto.
764 * Scripts/webkitpy/style/checkers/cpp.py:
765 (check_function_definition_and_pass_ptr):
766 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
767 (PassPtrTest.test_pass_ref_ptr_return_value):
768 (PassPtrTest.test_own_ptr_parameter_value):
770 2013-09-11 Mario Sanchez Prada <mario.prada@samsung.com>
772 [GTK] Remove Gail dependency from build system for GTK3
773 https://bugs.webkit.org/show_bug.cgi?id=119673
775 Reviewed by Gustavo Noronha Silva.
777 * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
778 * Scripts/webkitpy/port/gtk.py:
779 (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
780 * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
782 2013-09-11 Gabor Abraham <abrhm@inf.u-szeged.hu>
784 Performance tester bots should report the number of failing tests
785 https://bugs.webkit.org/show_bug.cgi?id=120462
787 Reviewed by Csaba Osztrogonác.
789 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
790 (RunAndUploadPerfTests.start.getText):
791 (RunAndUploadPerfTests.start):
792 (RunAndUploadPerfTests):
793 (RunAndUploadPerfTests.start.getText2):
795 2013-09-11 Krzysztof Czech <k.czech@samsung.com>
797 [ATK] Adds mapping MenuItemRadioRole to ATK
798 https://bugs.webkit.org/show_bug.cgi?id=121149
800 Reviewed by Mario Sanchez Prada.
802 Adds mapping MenuItemRadioRole to ATK.
804 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
806 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
809 2013-09-10 Csaba Osztrogonác <ossy@webkit.org>
811 Unreviewed fix after the unreviewed r155498 to unbreak the failure
812 counter of run-javascriptcore-tests build step on build.webkit.org.
814 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
815 (RunJavaScriptCoreTests.commandComplete):
816 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
818 2013-09-10 Filip Pizlo <fpizlo@apple.com>
820 Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
821 got a bit overlooked from the fast/js->js refactoring.
823 * Scripts/run-javascriptcore-tests:
825 2013-09-10 Daniel Bates <dabates@apple.com>
827 [iOS] Upstream text autosizing
828 https://bugs.webkit.org/show_bug.cgi?id=121111
830 Reviewed by Andy Estes and Sam Weinig.
832 Implement infrastructure to test the iOS text autosizing code.
834 * DumpRenderTree/TestRunner.cpp:
835 (setTextAutosizingEnabledCallback): Added.
836 (TestRunner::staticFunctions):
837 * DumpRenderTree/TestRunner.h:
838 * DumpRenderTree/mac/DumpRenderTree.mm:
839 (resetDefaultsToConsistentValues):
840 * DumpRenderTree/mac/TestRunnerMac.mm:
841 (TestRunner::setTextAutosizingEnabled): Added.
843 2013-09-10 Mark Hahnenberg <mhahnenberg@apple.com>
845 run-jsc-stress-tests should have a mode for always running the copy phase
846 https://bugs.webkit.org/show_bug.cgi?id=121128
848 Reviewed by Geoffrey Garen.
850 This will increase test coverage of the copying phase, which might not always get
851 triggered normally with our default parameters for required Heap/CopiedBlock utilization.
853 * Scripts/run-jsc-stress-tests:
855 2013-09-10 Sergio Correia <sergio.correia@openbossa.org>
857 [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
858 https://bugs.webkit.org/show_bug.cgi?id=121114
860 Reviewed by Christophe Dumez.
862 Use a tarball for libseccomp instead of git to avoid network issues on
863 the buildbots while checking out the git repo. Using tarballs has the
864 advantage of them being cached if the checksum matches, in which case
865 there will be no need to download them again.
867 * efl/jhbuild.modules:
869 2013-09-10 Mark Lam <mark.lam@apple.com>
871 Replace remaining "fast js" names in scripts.
872 https://bugs.webkit.org/show_bug.cgi?id=120899.
874 Rubber stamped by Filip Pizlo.
876 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
877 (test_layout_failure_new_output):
878 (test_layout_crash_new_output):
879 (test_mozilla_and_layout_failure_new_output):
880 * Scripts/run-fast-jsc: Removed.
881 * Scripts/run-javascriptcore-tests:
882 * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
884 2013-09-10 Zan Dobersek <zdobersek@igalia.com>
886 Enable JSC stress tests for the rest of non-Windows platforms
887 https://bugs.webkit.org/show_bug.cgi?id=121021
889 Reviewed by Filip Pizlo.
891 The JSC stress tests can already be enabled on Linux-based ports.
893 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
894 (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
895 JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
896 complete output, with the number of failing or crashing tests properly extracted.
897 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
898 output in other unit tests testing the parsing of the output in the new format.
899 (test_jsc_stress_failure_new_output):
900 (test_fast_js_crashes_and_jsc_stress_failures_new_output):
901 * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
902 * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
903 variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
904 of available CPUs so the stress tests can be run in parallel.
906 2013-09-10 Chris Fleizach <cfleizach@apple.com>
908 AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
909 https://bugs.webkit.org/show_bug.cgi?id=120552
911 Unreviewed build fix.
913 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
914 (AccessibilityUIElement::classList):
916 2013-09-10 Chris Fleizach <cfleizach@apple.com>
918 AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
919 https://bugs.webkit.org/show_bug.cgi?id=120552
921 Reviewed by Darin Adler.
923 * DumpRenderTree/AccessibilityUIElement.cpp:
924 (getClassListCallback):
925 (AccessibilityUIElement::getJSClass):
926 * DumpRenderTree/AccessibilityUIElement.h:
927 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
928 (AccessibilityUIElement::classList):
929 * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
930 (AccessibilityUIElement::classList):
931 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
932 (AccessibilityUIElement::classList):
933 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
934 (AccessibilityUIElement::classList):
935 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
936 (WTR::AccessibilityUIElement::classList):
937 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
938 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
939 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
940 (WTR::AccessibilityUIElement::classList):
941 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
942 (WTR::AccessibilityUIElement::classList):
944 2013-09-10 Denis Nomiyama <d.nomiyama@samsung.com>
946 [GTK] accessibility/loading-iframe-sends-notification.html is failing
947 https://bugs.webkit.org/show_bug.cgi?id=98370
949 Reviewed by Chris Fleizach.
951 Added AXLayoutComplete for the GTK platform.
953 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
954 (axObjectEventListener): Added notification AXLayoutComplete for
955 layout-complete signal.
957 2013-09-09 Brent Fulgham <bfulgham@apple.com>
959 [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
960 https://bugs.webkit.org/show_bug.cgi?id=120778
962 Reviewed by Anders Carlsson.
964 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
965 (createBitmapContextFromWebView): Use GDIObject.
966 * Scripts/webkitpy/style/checkers/cpp.py:
967 (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
968 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
969 (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
970 (LeakyPatternTest.test_create_compatible_dc): Ditto.
972 2013-09-10 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
974 Unreviewed. Add myself as a committer.
976 * Scripts/webkitpy/common/config/contributors.json:
978 2013-09-10 Mark Lam <mark.lam@apple.com>
980 Move LayoutTests/fast/js to LayoutTests/js.
981 https://bugs.webkit.org/show_bug.cgi?id=120899.
983 Rubber stamped by Filip Pizlo.
985 Changed scripts to reflect the path change.
987 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
988 (RunJavaScriptCoreTests.commandComplete):
989 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
990 (test_fast_js_failure_new_output):
991 (test_fast_js_crash_new_output):
992 (test_mozilla_and_fast_js_failure_new_output):
993 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
994 (BlackBerry::WebKit::DumpRenderTree::runTests):
995 * Scripts/make-script-test-wrappers:
997 * Scripts/run-fast-jsc:
998 * Scripts/run-javascriptcore-tests:
999 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1002 2013-09-10 Denis Nomiyama <d.nomiyama@samsung.com>
1004 [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
1005 https://bugs.webkit.org/show_bug.cgi?id=70606
1007 Reviewed by Mario Sanchez Prada.
1009 Implemented the global notification listener for
1010 AccessibilityController. The signal is generated by
1011 AXObjectCache::postPlatformNotification() and received by
1012 axObjectEventListener(). axObjectEventListener will then invoke
1013 JSObjectCallAsFunction() with the respective callback function.
1015 There is no additional test for this patch since its implementation will
1016 be tested by a11y layout tests that are currently skipped (e.g. bug
1019 * DumpRenderTree/AccessibilityController.h: Added a global notification
1021 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1022 (AccessibilityController::AccessibilityController): Initializes the
1023 global handler with 0.
1024 (AccessibilityController::addNotificationListener): Creates the
1025 notification handler and sets the notification function callback.
1026 (AccessibilityController::removeNotificationListener): Removes the
1029 2013-09-10 Krzysztof Czech <k.czech@samsung.com>
1031 [ATK] Incorrect type for holding float value
1032 https://bugs.webkit.org/show_bug.cgi?id=121091
1034 Reviewed by Mario Sanchez Prada.
1036 Variable is not set properly, because of it's type.
1038 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1039 (WTR::alterCurrentValue):
1041 2013-09-10 Allan Sandfeld Jensen <allan.jensen@digia.com>
1043 [Qt] make use of qtHaveModule()
1044 https://bugs.webkit.org/show_bug.cgi?id=121090
1046 Reviewed by Jocelyn Turcotte.
1047 Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
1049 Use qtHaveModule instead of our own haveQtModule.
1051 * QtTestBrowser/QtTestBrowser.pro:
1052 * qmake/mkspecs/features/configure.prf:
1053 * qmake/mkspecs/features/features.prf:
1054 * qmake/mkspecs/features/functions.prf:
1056 2013-09-10 Michał Pakuła vel Rutka <m.pakula@samsung.com>
1058 Unreviewed. Add myself as a committer.
1060 * Scripts/webkitpy/common/config/contributors.json:
1062 2013-09-10 Radu Stavila <stavila@adobe.com>
1064 Unreviewed. Added myself as a committer.
1066 * Scripts/webkitpy/common/config/contributors.json:
1068 2013-09-10 Mario Sanchez Prada <mario.prada@samsung.com>
1070 [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
1071 https://bugs.webkit.org/show_bug.cgi?id=105538
1073 Reviewed by Chris Fleizach.
1075 Unskip passing test getTextInParagraphAndBodyModerate.
1077 * Scripts/run-gtk-tests:
1078 (TestRunner): Unskip pasing test.
1080 2013-09-09 Mark Lam <mark.lam@apple.com>
1082 Remove more references to the deleted js-test-style.css.
1083 https://bugs.webkit.org/show_bug.cgi?id=120899.
1085 Reviewed by Ryosuke Niwa.
1087 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1088 (translate_includes):
1090 2013-09-09 Mark Lam <mark.lam@apple.com>
1092 Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
1093 https://bugs.webkit.org/show_bug.cgi?id=120899.
1097 The webkitpy test failure that resulted in the rollout is due to
1098 update_webgl_conformance_tests_unittest.py referencing js-test-style.css
1099 which is to be deleted. Deleting that line fixes the issue.
1101 * Scripts/make-new-script-test:
1102 (makePathToSharedSources):
1103 * Scripts/run-fast-jsc:
1104 * Scripts/webkitperl/httpd.pm:
1105 (getDefaultConfigForTestDirectory):
1106 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1107 (LayoutTestApacheHttpd.__init__):
1108 * Scripts/webkitpy/layout_tests/servers/http_server.py:
1109 (Lighttpd.__init__):
1110 * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1111 (BaseTest.integration_test_port_and_root):
1112 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1113 (TestHttpServer.test_start_cmd):
1114 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1115 (translate_includes):
1116 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1117 (TestTranslation.test_include_rewriting):
1119 2013-09-09 Mark Lam <mark.lam@apple.com>
1121 Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
1122 https://bugs.webkit.org/show_bug.cgi?id=120899.
1126 * Scripts/make-new-script-test:
1127 (makePathToSharedSources):
1128 * Scripts/run-fast-jsc:
1129 * Scripts/webkitperl/httpd.pm:
1130 (getDefaultConfigForTestDirectory):
1131 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1132 (LayoutTestApacheHttpd.__init__):
1133 * Scripts/webkitpy/layout_tests/servers/http_server.py:
1134 (Lighttpd.__init__):
1135 * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1136 (BaseTest.integration_test_port_and_root):
1137 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1138 (TestHttpServer.test_start_cmd):
1139 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1140 (translate_includes):
1141 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1142 (TestTranslation.test_include_rewriting):
1144 2013-09-09 Mark Lam <mark.lam@apple.com>
1146 Point Tools scripts to LayoutTests/resources.
1147 https://bugs.webkit.org/show_bug.cgi?id=120899.
1149 Reviewed by Ryosuke Niwa.
1151 * Scripts/make-new-script-test:
1152 (makePathToSharedSources):
1153 * Scripts/run-fast-jsc:
1154 * Scripts/webkitperl/httpd.pm:
1155 (getDefaultConfigForTestDirectory):
1156 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1157 (LayoutTestApacheHttpd.__init__):
1158 * Scripts/webkitpy/layout_tests/servers/http_server.py:
1159 (Lighttpd.__init__):
1160 * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1161 (BaseTest.integration_test_port_and_root):
1162 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1163 (TestHttpServer.test_start_cmd):
1164 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1165 (translate_includes):
1166 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1167 (TestTranslation.test_include_rewriting):
1169 2013-09-09 Roger Fong <roger_fong@apple.com>
1171 Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
1173 * CygwinDownloader/cygwin-downloader.py:
1174 * CygwinDownloader/cygwin-downloader.zip:
1176 2013-09-09 Filip Pizlo <fpizlo@apple.com>
1178 Unreviewed, fix Ruby exception handling.
1180 * Scripts/run-jsc-stress-tests:
1182 2013-09-09 Filip Pizlo <fpizlo@apple.com>
1184 Stress tests should test the jsc profiler (-p)
1185 https://bugs.webkit.org/show_bug.cgi?id=121043
1187 Reviewed by Mark Hahnenberg.
1189 Add a runProfiler command that all tests could use. This requires profiler-test-helper,
1190 which first runs the JS test and then tries the output with display-profiler-output.
1191 But if any of the things required for this to work aren't present, we just do a simpler
1192 test that just uses "-p".
1194 Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
1195 to create test collections using a yaml file that specifies the test path and the
1198 * Scripts/jsc-stress-test-helpers: Added.
1199 * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
1200 * Scripts/run-javascriptcore-tests:
1201 * Scripts/run-jsc-stress-tests:
1203 2013-09-09 Zan Dobersek <zdobersek@igalia.com>
1205 [webkitpy] Remove the DeprecatedPort class
1206 https://bugs.webkit.org/show_bug.cgi?id=121030
1208 Reviewed by Ryosuke Niwa.
1210 Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
1212 The various methods returning commands are moved from the DeprecatedPort class into the Port class,
1213 with the Port subclasses overriding specific methods as required.
1215 * Scripts/webkitpy/common/config/ports.py: Removed.
1216 * Scripts/webkitpy/common/config/ports_mock.py: Removed.
1217 * Scripts/webkitpy/common/config/ports_unittest.py: Removed.
1218 * Scripts/webkitpy/port/base.py:
1219 (Port.tooling_flag): This method returns the command line argument that corresponds to the type of the port.
1220 It's formatted as '--port=port_name', where port_name is the port's name that's additionally appended the '-wk2'
1221 string if the port instance represents the WK2 variation of the port.
1222 (Port.script_shell_command): Moved here from the DeprecatedPort interface.
1223 (Port.make_args): Ditto.
1224 (Port.update_webkit_command): Ditto.
1225 (Port.check_webkit_style_command): Ditto.
1226 (Port.prepare_changelog_command): Ditto.
1227 (Port.build_webkit_command): Ditto.
1228 (Port.run_javascriptcore_tests_command): Ditto.
1229 (Port.run_webkit_unit_tests_command): Ditto.
1230 (Port.run_webkit_tests_command): Ditto.
1231 (Port.run_python_unittests_command): Ditto.
1232 (Port.run_perl_unittests_command): Ditto.
1233 (Port.run_bindings_tests_command): Ditto.
1234 * Scripts/webkitpy/port/base_unittest.py:
1235 (PortTest.test_build_webkit_command): Add a test for the Port.build_webkit_command() method that tests correct
1236 return value with different build types passed to the method.
1237 * Scripts/webkitpy/port/efl.py:
1238 (EflPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
1239 to the command line.
1240 * Scripts/webkitpy/port/efl_unittest.py:
1241 (EflPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
1242 variations of the EflPort class.
1243 * Scripts/webkitpy/port/gtk.py:
1244 (GtkPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
1245 to the command line.
1246 (GtkPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
1247 * Scripts/webkitpy/port/gtk_unittest.py:
1248 (GtkPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1
1249 and WK2 variations of the GtkPort class.
1250 * Scripts/webkitpy/port/mac_unittest.py:
1251 (MacTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
1252 variations of the MacPort class.
1253 * Scripts/webkitpy/port/qt.py:
1254 (QtPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
1255 to the command line.
1256 (QtPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
1257 * Scripts/webkitpy/port/qt_unittest.py:
1258 (QtPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
1259 variations of the QtPort class.
1260 * Scripts/webkitpy/port/test.py:
1261 (TestPort.make_args): Return a mock value that's intended for testing.
1262 (TestPort.check_webkit_style_command): Return the script's name prepended with 'mock-'.
1263 (TestPort.update_webkit_command): Ditto.
1264 (TestPort.build_webkit_command): Ditto.
1265 (TestPort.prepare_changelog_command): Ditto.
1266 (TestPort.run_python_unittests_command): Ditto.
1267 (TestPort.run_perl_unittests_command): Ditto.
1268 (TestPort.run_javascriptcore_tests_command): Ditto.
1269 (TestPort.run_webkit_unit_tests_command): Ditto.
1270 (TestPort.run_webkit_tests_command): Ditto.
1271 (TestPort.run_bindings_tests_command): Ditto.
1272 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1273 (FlakyTestReporter.__init__): WebKitPatch.port() should be called now.
1274 * Scripts/webkitpy/tool/bot/irc_command.py:
1275 (Rollout._update_working_copy): Ditto.
1276 * Scripts/webkitpy/tool/commands/download_unittest.py:
1277 (DownloadCommandsTest.test_land_cowhand): Fix a typo, javacriptcore -> javascriptcore.
1278 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1279 (AbstractEarlyWarningSystem.run_command): Use the tooling flag as provided by the Port interface.
1280 * Scripts/webkitpy/tool/commands/queues.py:
1281 (PatchProcessingQueue.begin_work_queue): Remove the use of the DeprecatedPort. Create the port that will be used
1282 by the PatchProcessingQueue through the tool's port factory, and also pass it to the tool, keeping the nasty
1283 abstraction violation.
1284 (CommitQueue.run_command): Use the tooling flag as provided by the Port interface.
1285 * Scripts/webkitpy/tool/main.py:
1286 (WebKitPatch.__init__): self._deprecated_port -> self._port.
1287 (WebKitPatch.port): Replaces the WebKitPatch.deprecated_port() method, returns self._port.
1288 (WebKitPatch.handle_global_options): Create the Port object through the PortFactory.
1289 * Scripts/webkitpy/tool/mocktool.py:
1290 (MockTool.__init__): self._deprecated_port -> self._port. The TestPort object also has its name method overridden
1291 to return 'MockPort', as many output comparisons rely on the MockPort name. These should all be replaced later, in
1293 (MockTool.port): Mimicks WebKitPatch.port().
1294 * Scripts/webkitpy/tool/steps/build.py:
1295 (Build.build): WebKitPatch.port() should be called now.
1296 * Scripts/webkitpy/tool/steps/checkstyle.py:
1297 (CheckStyle.run): Ditto.
1298 * Scripts/webkitpy/tool/steps/commit.py:
1299 (Commit._check_test_expectations): Ditto.
1300 * Scripts/webkitpy/tool/steps/preparechangelog.py:
1301 (PrepareChangeLog.run): Ditto.
1302 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1303 (PrepareChangeLogForRevert.run): Ditto.
1304 * Scripts/webkitpy/tool/steps/runtests.py:
1305 (RunTests.run): Ditto.
1306 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1307 (RunTestsTest.test_webkit_run_unit_tests): The unnecessary methods should now be overridden on MockTool._port.
1308 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1309 (StepsTest.test_runtests_args): Remove the MockTool._deprecated_port override, but don't replace it. Rather than
1310 that the expected test output is adjusted to contain the mock-* command names.
1311 * Scripts/webkitpy/tool/steps/update.py:
1312 (Update._update_command): WebKitPatch.port() should be called now.
1313 * Scripts/webkitpy/tool/steps/update_unittest.py:
1314 (UpdateTest.test_update_command_non_interactive): Override the MockTool._port for testing purposes with the port
1315 that corresponds to the removed DeprecatedPort subclasses.
1316 (UpdateTest.test_update_command_interactive): Ditto.
1318 2013-09-09 Zan Dobersek <zdobersek@igalia.com>
1320 [GTK] 32-bit builder should run the JSC tests
1321 https://bugs.webkit.org/show_bug.cgi?id=119215
1323 Reviewed by Philippe Normand.
1325 Rename the TestClass member of the TestFactory and BuildAndTestFactory classes
1326 to a more descriptive name, 'LayoutTestClass'. In these two factory classes, the layout testing-specific
1327 steps are only added if the LayoutTestClass member was not overridden to the value of None in a
1330 Remove the BuildAndAPITestFactory class and replace it with the BuildAndNonLayoutTestFactory class that
1331 is derived from the BuildAndTestFactory class and overrides the LayoutTestClass member to the value of None.
1332 This allows for builders of the BuildAndNonLayoutTest type to run all but the layout tests. This type
1333 is currently used by the GTK 32-bit builder - there's at the moment no interest to have the builder cover
1334 layout testing while other types of testing are still expected to be performed.
1336 * BuildSlaveSupport/build.webkit.org-config/config.json:
1337 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1338 (BuildFactory.__init__):
1340 (TestFactory.__init__):
1341 (BuildAndTestFactory):
1342 (BuildAndTestFactory.__init__):
1343 (BuildAndTestWebKit2Factory):
1344 (BuildAndTestWebKit2OnlyFactory):
1345 (BuildAndNonLayoutTestFactory):
1347 (TestWebKit2Factory):
1349 2013-09-09 Manuel Rego Casasnovas <rego@igalia.com>
1351 Unreviewed. Add myself as a committer.
1353 * Scripts/webkitpy/common/config/contributors.json:
1355 2013-09-09 Krzysztof Czech <k.czech@samsung.com>
1357 [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
1358 https://bugs.webkit.org/show_bug.cgi?id=121023
1360 Reviewed by Mario Sanchez Prada.
1362 Added mappings to ATK's ProgressBar element.
1364 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1366 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1367 (WTR::roleToString):
1369 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1371 run-jsc-stress-tests should be more paranoid about calling make
1372 https://bugs.webkit.org/show_bug.cgi?id=121011
1374 Reviewed by Oliver Hunt.
1376 If it returns with any kind of error then bail out. Also print the command being used
1377 in case we have to debug this, for example on the bots. The extra verbosity isn't a
1380 * Scripts/run-jsc-stress-tests:
1382 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1384 Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
1385 like that. Pass a string instead.
1387 * Scripts/run-jsc-stress-tests:
1389 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1391 run-jsc-stress-tests should run tests in parallel if possible
1392 https://bugs.webkit.org/show_bug.cgi?id=120996
1394 Reviewed by Oliver Hunt.
1396 Run tests in parallel by using Makefile hacks. This lets make take care of all load
1397 balancing. It's a really awesome speed-up for these tests.
1399 This reduces the FTL debug build stress test run time from 8m18s to 2m11s. The
1400 no-FTL debug build stress test time goes from 1m11s to 16s. This patch is pretty
1403 * Scripts/run-jsc-stress-tests:
1405 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1407 run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
1408 https://bugs.webkit.org/show_bug.cgi?id=120994
1410 Reviewed by Geoffrey Garen.
1412 run-jsc-stress-tests accepts a list of directories containing tests. It needs to
1413 come up with names for all of them. Currently it uses the basename of the test
1414 directory. But that means that JSRegress gets called "script-tests", which is
1415 unfortunate since any directory in LayoutTests containing .js files will be
1416 called "script-tests". So, this changes run-jsc-stress-tests to use more than
1417 just the basename if the basename has the word "tests" in it. This causes
1418 JSRegress to be called "regress/script-tests".
1420 * Scripts/run-jsc-stress-tests:
1422 2013-09-08 Sergio Correia <sergio.correia@openbossa.org>
1424 [EFL][JHBUILD] Fix evas build with giflib5
1425 https://bugs.webkit.org/show_bug.cgi?id=120863
1427 Original patch from Doug Newgard, at https://phab.enlightenment.org/D200.
1429 Reviewed by Anders Carlsson.
1431 * efl/jhbuild.modules: Apply patch to fix evas build with giflib5.
1432 * efl/patches/evas-fix-build-with-giflib5.patch: Added.
1434 2013-09-07 Filip Pizlo <fpizlo@apple.com>
1436 Only run FTL tests if we have the FTL
1437 https://bugs.webkit.org/show_bug.cgi?id=120974
1439 Reviewed by Geoffrey Garen.
1441 Pass --ftl-jit down into run-jsc-stress-tests so that it knows what test
1444 * Scripts/build-jsc:
1445 * Scripts/run-javascriptcore-tests:
1446 * Scripts/run-jsc-stress-tests:
1448 2013-09-07 Santosh Mahto <santosh.ma@samsung.com>
1450 removing --dialog-element from build-webkit --help option message
1451 https://bugs.webkit.org/show_bug.cgi?id=120955
1453 Reviewed by Daniel Bates.
1455 --dialog-element option is useless while building as
1456 Dialog Element support has been removed in following changeset.
1457 http://trac.webkit.org/changeset/154835
1458 http://trac.webkit.org/changeset/154870
1460 * Scripts/webkitperl/FeatureList.pm:
1461 Removed --dialog-element option message.
1463 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1465 It should be possible to run-javascriptcore-tests with only a subset of the test suites
1466 https://bugs.webkit.org/show_bug.cgi?id=120918
1468 Reviewed by Dan Bernstein.
1470 * Scripts/run-javascriptcore-tests:
1472 2013-09-06 Commit Queue <commit-queue@webkit.org>
1474 Unreviewed, rolling out r155196.
1475 http://trac.webkit.org/changeset/155196
1476 https://bugs.webkit.org/show_bug.cgi?id=120919
1478 Broke 16 tests on build.webkit.org (Requested by rniwa on
1481 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1482 (Manager._set_up_run):
1484 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1486 The 'failed' file should report collectionName/testName rather than just
1489 Rubber stamped by Mark Hahnenberg.
1491 * Scripts/run-jsc-stress-tests:
1493 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1495 Fix run-jsc-stress-tests to run on bots with old Ruby.
1497 Also make it create a repro file.
1499 Rubber stamped by Mark Hahnenberg.
1501 * Scripts/run-jsc-stress-tests:
1503 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1505 Actually increment $numFailures
1507 Reviewed by Mark Hahnenberg.
1509 * Scripts/run-jsc-stress-tests:
1511 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1513 Fix run-jsc-stress-tests to use Pathname instead of File.realpath.
1515 Also make it uses system() instead of popen(); that means that test output
1516 will go to the console. This reduces error detection flakiness. It's fine
1517 because stress tests don't print() unless they really have to.
1519 Rubber stamped by Mark Hahnenberg.
1521 * Scripts/run-jsc-stress-tests:
1523 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1525 Introduce a way to run benchmarks and JSRegress as stress tests with different jsc command-line options
1526 https://bugs.webkit.org/show_bug.cgi?id=120808
1528 Reviewed by Mark Hahnenberg and rubber stamped by Geoffrey Garen.
1530 Add a script for running stress tests. A stress test is a .js file that is run
1531 through different configurations of JSC. It can control which configurations it
1532 runs by using "//@ <ruby code>" to guide the script.
1534 This script is now run as part of run-javascriptcore-tests, on Mac only.
1536 * Scripts/run-javascriptcore-tests:
1537 * Scripts/run-jsc-stress-tests: Added.
1539 2013-09-06 Mario Sanchez Prada <mario.prada@samsung.com>
1541 [GTK] Desktop proxy settings are ignored inside the internal jhbuild
1542 https://bugs.webkit.org/show_bug.cgi?id=120833
1544 Reviewed by Gustavo Noronha Silva.
1546 Add dconf as an optional module for the internal jhbuild, along
1547 with vala 0.17 as a dependency, and make sure we do not explicitly
1548 set always the 'memory' backend, so we can have an easy way to
1549 allow apps access desktop settings from the jhbuild. This is
1550 useful for example to be able to run apps such as MiniBrowser
1551 inside the jhbuild (by means of run-launcher, for instance) while
1552 working behind a proxy, since those network settings have to be
1553 read from the system global configuration in org.gnome.system.proxy.
1555 * gtk/jhbuild-optional.modules: Added dconf 0.14 and vala 0.17.
1556 * gtk/jhbuildrc: Do not explicitly choose the GSettings memory
1557 backend here, since that will make more difficult to use the dconf
1558 backend from inside the jhbuild if we need to do it so.
1560 2013-09-06 Alexey Proskuryakov <ap@apple.com>
1562 Lots of pixel tests are failing on first run, so tests cannot finish
1563 https://bugs.webkit.org/show_bug.cgi?id=120755
1565 Reviewed by Ryosuke Niwa.
1567 For whatever reason, many reftests are color profile sensitive, and we only set
1568 color profile to a known one for pixel tests, not for reftests.
1570 Pixel testing mode is also enabled when retrying tests, so these failures used to
1571 be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
1572 But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
1574 This probably shouldn't happen, as reftests should not be color profile sensitive.
1575 The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
1577 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1578 (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
1580 2013-09-06 Denis Nomiyama <d.nomiyama@samsung.com>
1582 [GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
1583 https://bugs.webkit.org/show_bug.cgi?id=120416
1585 Reviewed by Mario Sanchez Prada.
1587 Fixed crashes when running debug DRT. Simplified loops at AccessibilityCallbackAtk.cpp where the HashMap
1588 iterator was removed inside a loop. Fixed AccessibilityUIElement::addNotificationListener() where
1589 m_notificationHandler expected RefPtr.
1591 The global notification handler was stored in the HashMap with key 0. And this caused an assertion when
1592 HashMap::add() or find() are called. To fix it, moved the global handler to a separated pointer.
1594 * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed the global notification key.
1595 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1596 (axObjectEventListener): Simplified the code by using HashMap::find() and a separate pointer for the
1597 global notification handler.
1598 (addAccessibilityNotificationHandler): Simplified the code by using HashMap::find() and a separate pointer
1599 for the global notification handler.
1600 (removeAccessibilityNotificationHandler): Added the removal for the global notification handler.
1601 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
1602 (AccessibilityNotificationHandler::create): Added static function to create
1603 AccessibilityNotificationHandler.
1604 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1605 (AccessibilityUIElement::addNotificationListener): Assigned m_notificationHandler with
1606 AccessibilityNotificationHandler::create().
1608 2013-09-06 Gabor Abraham <abrhm@inf.u-szeged.hu>
1610 [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
1611 https://bugs.webkit.org/show_bug.cgi?id=120847
1613 Reviewed by Csaba Osztrogonác.
1615 Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
1616 Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
1617 Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).
1619 * WebKitTestRunner/PlatformWebView.h:
1620 (WTR::PlatformWebView::windowSnapshotEnabled):
1621 * WebKitTestRunner/TestInvocation.cpp:
1622 (WTR::TestInvocation::dumpResults):
1623 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1624 (WTR::WrapperWindow::handleStatusChanged):
1625 (WTR::PlatformWebView::windowSnapshotEnabled):
1626 * WebKitTestRunner/qt/TestInvocationQt.cpp:
1627 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1629 2013-09-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
1631 REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
1632 https://bugs.webkit.org/show_bug.cgi?id=120843
1634 Reviewed by Csaba Osztrogonác.
1636 Call notifyDone like the platform specific forceRepaintDoneCallback methods
1637 it replaced did. The method is empty on the Apple ports.
1639 * WebKitTestRunner/TestInvocation.cpp:
1640 (WTR::TestInvocation::forceRepaintDoneCallback):
1642 2013-09-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
1644 [Qt][WK2] Window used by WebKitTestRunner loses active status
1645 https://bugs.webkit.org/show_bug.cgi?id=120774
1647 Reviewed by Jocelyn Turcotte.
1649 When focusing the PlatformWebView which is done at the start of each test, we should
1650 ensure the host window of PlatformWebView is also made active, otherwise we will
1651 not receive the keyboard events send by EventSenderProxy.
1653 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1654 (WTR::PlatformWebView::focus):
1656 2013-09-05 Seokju Kwon <seokju@webkit.org>
1658 Unreviewed build fix. VectorReverse.cpp was removed after r155151.
1660 * TestWebKitAPI/CMakeLists.txt:
1662 2013-09-05 Anders Carlsson <andersca@apple.com>
1664 Make Vector::uncheckedAppend work with move-only types
1665 https://bugs.webkit.org/show_bug.cgi?id=120799
1667 Reviewed by Andreas Kling.
1669 * TestWebKitAPI/Tests/WTF/Vector.cpp:
1670 (TestWebKitAPI::MoveOnly):
1671 Add a move-only class.
1673 (TestWebKitAPI::TEST):
1674 Add a test for Vector<MoveOnly>::uncheckedAppend.
1676 2013-09-05 Anders Carlsson <andersca@apple.com>
1678 Move all Vector tests into Vector.cpp
1679 https://bugs.webkit.org/show_bug.cgi?id=120797
1681 Reviewed by Andreas Kling.
1683 * TestWebKitAPI/CMakeLists.txt:
1684 * TestWebKitAPI/GNUmakefile.am:
1685 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1686 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1687 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1688 * TestWebKitAPI/Tests/WTF/Vector.cpp:
1689 (TestWebKitAPI::TEST):
1690 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
1691 * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
1692 * TestWebKitAPI/Tests/WTF/WTF.pro:
1694 2013-09-05 Simon Fraser <simon.fraser@apple.com>
1696 Expected result images are sometimes blank in WKTR
1697 https://bugs.webkit.org/show_bug.cgi?id=120715
1699 Reviewed by Tim Horton.
1701 In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
1702 sometimes blank if a previous test triggered compositing mode, and the
1703 current test or reference did not require compositing. This happened
1704 because the UI process didn't wait for the web process to complete
1705 its compositing mode switch before snapshotting. Fix by calling
1706 WKPageForceRepaint() before we take the snapshot; this is async,
1707 so we have to spin the runloop for a while.
1709 Remove the Qt/EFL code that does the same thing.
1711 * WebKitTestRunner/TestInvocation.cpp:
1712 (WTR::TestInvocation::forceRepaintDoneCallback):
1713 (WTR::TestInvocation::dumpResults):
1714 * WebKitTestRunner/TestInvocation.h:
1715 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1716 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1717 * WebKitTestRunner/qt/TestInvocationQt.cpp:
1718 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1720 2013-09-05 Csaba Osztrogonác <ossy@webkit.org>
1722 Make build.webkit.org report the number of failing run-fast-jsc tests
1723 https://bugs.webkit.org/show_bug.cgi?id=120766
1725 Reviewed by Filip Pizlo.
1727 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1728 (RunJavaScriptCoreTests.commandComplete):
1729 (RunJavaScriptCoreTests.getText2):
1730 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1731 (RunJavaScriptCoreTestsTest): Added.
1732 (RunJavaScriptCoreTestsTest.assertResults):
1733 (RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
1734 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1735 (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
1736 (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
1737 (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
1738 (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
1740 2013-09-05 Csaba Osztrogonác <ossy@webkit.org>
1742 Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
1743 https://bugs.webkit.org/show_bug.cgi?id=120759
1745 Reviewed by Filip Pizlo.
1747 * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
1748 * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
1750 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1752 Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
1753 Mozilla tests appears to run for a longer time.
1755 I think we want to continue to allow a few tests here and there to be
1756 longer-running, rather than excluding them. I seem to recall that those tests
1759 * Scripts/run-javascriptcore-tests:
1761 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1763 Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that
1764 can't support it because if non-bourne shells. This fixes part #2 of the Linux
1767 * Scripts/run-javascriptcore-tests:
1769 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1771 Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
1773 * Scripts/run-javascriptcore-tests:
1776 2013-09-04 Filip Pizlo <fpizlo@apple.com>
1778 jsc tests should have timeouts
1779 https://bugs.webkit.org/show_bug.cgi?id=120725
1781 Reviewed by Geoffrey Garen.
1783 Set the timeout to 20 seconds per test for now.
1785 * Scripts/run-javascriptcore-tests:
1787 2013-09-04 Filip Pizlo <fpizlo@apple.com>
1789 run-javascriptcore-tests should run-fast-jsc as well
1790 https://bugs.webkit.org/show_bug.cgi?id=120722
1792 Reviewed by Geoffrey Garen.
1794 Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
1795 Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
1797 * Scripts/run-javascriptcore-tests:
1800 2013-09-04 Sergio Correia <sergio.correia@openbossa.org>
1802 [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
1803 https://bugs.webkit.org/show_bug.cgi?id=120646
1805 Reviewed by Gyuyoung Kim.
1807 * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
1808 list of passing tests, since it started to pass after r154045.
1810 2013-09-04 Krzysztof Czech <k.czech@samsung.com>
1812 [ATK] Adds an accessibility support to access a value of the color control element
1813 https://bugs.webkit.org/show_bug.cgi?id=114354
1815 Reviewed by Mario Sanchez Prada.
1817 Added accessibility role of the color control element.
1819 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1821 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1822 (WTR::roleToString):
1824 2013-09-04 Mario Sanchez Prada <mario.prada@samsung.com>
1826 REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
1827 https://bugs.webkit.org/show_bug.cgi?id=100408
1829 Unreviewed gardening. Unskip TestWebKitAccessibility after
1830 manually checking that it's running properly in the bot.
1832 * Scripts/run-gtk-tests:
1833 (TestRunner): Unskipped TestWebKitAccessibility.
1835 2013-09-04 Zan Dobersek <zdobersek@igalia.com>
1837 [GTK] Add support for the Wayland build target
1838 https://bugs.webkit.org/show_bug.cgi?id=120627
1840 Reviewed by Gustavo Noronha Silva.
1842 * GNUmakefile.am: Define the additional macros also if building the Wayland target.
1844 2013-09-04 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
1846 [GStreamer] cannot play live streams
1847 https://bugs.webkit.org/show_bug.cgi?id=116831
1849 Reviewed by Philippe Normand.
1851 Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
1853 * gtk/jhbuild.modules:
1854 * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
1855 * gtk/patches/udpsrc-improve-timeouts.patch: Added.
1856 Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
1857 and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
1858 Both patches are applied upstream and can be removed once a new gstreamer release
1859 is out (up to 1.0.10 the patches are not included) and we bump the requirements.
1861 2013-09-03 Alexey Proskuryakov <ap@apple.com>
1863 [Mac] WebKitTestRunner still beeps sometimes
1864 https://bugs.webkit.org/show_bug.cgi?id=120652
1866 Reviewed by Tim Horton.
1868 In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
1869 UI process (notably, AppKit beeps when handling a key equivalent returns NO).
1871 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
1872 Use the same SPI that we use in DRT and in WebProcess to disable beeping.
1874 2013-09-03 Krzysztof Czech <k.czech@samsung.com>
1876 [AX][ATK] Added support for sort and help attributes
1877 https://bugs.webkit.org/show_bug.cgi?id=120456
1879 Reviewed by Chris Fleizach.
1881 Added missing implementation to AccessibilityUIElement::helpText and support for
1882 aria-sort attribute.
1884 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1885 (coreAttributeToAtkAttribute):
1886 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1887 (WTR::coreAttributeToAtkAttribute):
1888 (WTR::AccessibilityUIElement::helpText):
1890 2013-09-03 Allan Sandfeld Jensen <allan.jensen@digia.com>
1892 [Qt][WK1] PageVisibility tests are flaky
1893 https://bugs.webkit.org/show_bug.cgi?id=120418
1895 Reviewed by Jocelyn Turcotte.
1897 Implement resetPageVisibility so we can reset visibility without
1898 emiting visibility state change events.
1900 * DumpRenderTree/qt/TestRunnerQt.cpp:
1901 (TestRunner::resetPageVisibility):
1903 2013-09-03 ChangSeok Oh <changseok.oh@collabora.com>
1905 [GTK] libsoup upversion to fix a gstreamer issue, bug115354
1906 https://bugs.webkit.org/show_bug.cgi?id=120613
1908 Reviewed by Philippe Normand.
1910 Up version of libsoup to 2.43.90. But the exact version which we'll use is not 2.43.90.
1911 To fix bug115354, we need the Andre's patch for libsoup, but the lastest release
1912 does not contain it. https://bugzilla.gnome.org/show_bug.cgi?id=706338
1913 For the reason, we'll use libsoup git repo directly for a while until the next
1916 * gtk/jhbuild.modules:
1918 2013-09-02 Darin Adler <darin@apple.com>
1920 [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
1921 https://bugs.webkit.org/show_bug.cgi?id=120569
1923 Reviewed by Andy Estes.
1925 * DumpRenderTree/mac/DumpRenderTree.mm:
1926 (dump): Use CFBridgingRelease.
1928 2013-09-02 Anton Obzhirov <a.obzhirov@samsung.com>
1930 <https://webkit.org/b/98350> [GTK] accessibility/aria-invalid.html times out
1932 Reviewed by Mario Sanchez Prada.
1934 Added few mappings in DumpRenderTree and WebKitTestRunner for aria-invalid in order to get the tests run properly.
1936 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1937 (axObjectEventListener):
1938 Added mapping for invalid-entry event parameter.
1939 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1940 (coreAttributeToAtkAttribute):
1941 Added mapping to aria-invalid.
1942 (AccessibilityUIElement::stringAttributeValue):
1943 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1944 (WTR::coreAttributeToAtkAttribute):
1945 Added mapping to aria-invalid.
1947 2013-09-02 Nick Diego Yamane <nick.yamane@openbossa.org>
1949 Save md5 correctly when jhbuildPath doesn't exist yet
1950 https://bugs.webkit.org/show_bug.cgi?id=120548
1952 Reviewed by Gustavo Noronha Silva.
1954 After r152605, Md5 for jhbuild files are saved before the update
1955 process, this prevents the script to restart update from scratch
1956 when initial checkouts fail. However it causes an issue when builddir
1957 (or builddir/Dependencies) doesn't exist yet. In that case the
1958 saveJhbuildMd5 function fails to create md5 files.
1959 This patch adds a checking for the jhbuildPath and creates it if
1960 necessary before trying to open the md5 files.
1962 * Scripts/update-webkit-libs-jhbuild:
1965 2013-09-02 Mario Sanchez Prada <mario.prada@samsung.com>
1967 Unreviewed. Move myself to the reviewers list.
1969 * Scripts/webkitpy/common/config/contributors.json:
1971 2013-09-01 Alexey Proskuryakov <ap@apple.com>
1973 [WK2][Mac] Drag and drop tests interfere with user's UI
1974 https://bugs.webkit.org/show_bug.cgi?id=120538
1976 Reviewed by Dan Bernstein.
1978 This makes running WebKit2 regression tests locally more viable. The patch doesn't
1979 fix drag and drop tests to work as expected, I posted some thought about that in
1980 <https://bugs.webkit.org/show_bug.cgi?id=68552>.
1982 * WebKitTestRunner/EventSenderProxy.h:
1983 (WTR::EventSenderProxy::position):
1984 * WebKitTestRunner/TestController.h:
1985 (WTR::TestController::eventSenderProxy):
1986 Expose a way to get current mouse position from anywhere in WKTR code.
1988 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
1990 * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
1991 Copied a FIXME comment from DumpRenderTree.
1993 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1994 (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1995 Override drag initiation, using a custom NSDraggingInfo implementation.
1997 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
1998 Replace NSEvent with a custom class.
2000 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
2001 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
2002 * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
2003 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
2004 Largely a copy of DumpRenderTree classes, modified to not use global variables.
2005 We should consider making these variables static in EventSenderProxy though, as
2006 it's strange that mouse state in WKTR is reset between tests without WebKit ever
2007 being told about that.
2009 2013-08-30 Brent Fulgham <bfulgham@apple.com>
2011 [Windows] Unreviewed build fix.
2013 * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
2014 from the build machines.
2016 2013-08-30 Gabor Abraham <abrhm@inf.u-szeged.hu>
2018 [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
2019 https://bugs.webkit.org/show_bug.cgi?id=120464
2021 Reviewed by Jocelyn Turcotte.
2023 * Scripts/webkitpy/port/qt.py:
2024 (QtPort._search_paths):
2025 * Scripts/webkitpy/port/qt_unittest.py:
2028 2013-08-29 Filip Pizlo <fpizlo@apple.com>
2030 Just linking LLVM into JSC causes all plugin tests to fail
2031 https://bugs.webkit.org/show_bug.cgi?id=113915
2033 Reviewed by Oliver Hunt.
2035 Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
2036 raise/abort/__assert_rtn.
2038 * Scripts/configure-llvm:
2040 2013-08-29 Joseph Pecoraro <pecoraro@apple.com>
2042 new-run-webkit-tests does not respect --no-sample-on-timeout switch
2043 https://bugs.webkit.org/show_bug.cgi?id=120491
2045 Reviewed by Darin Adler.
2047 * Scripts/webkitpy/port/server_process.py:
2048 (ServerProcess._handle_timeout):
2050 2013-08-29 Sam Weinig <sam@webkit.org>
2052 Add ENABLE guards for Promises
2053 https://bugs.webkit.org/show_bug.cgi?id=120488
2055 Reviewed by Andreas Kling.
2057 * Scripts/webkitperl/FeatureList.pm:
2058 * qmake/mkspecs/features/features.pri:
2060 2013-08-29 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
2062 [GTK] Should enable WebGL by default on MiniBrowser
2063 https://bugs.webkit.org/show_bug.cgi?id=120420
2065 Reviewed by Gustavo Noronha Silva.
2067 Enable WebGL by default on MiniBrowser.
2069 * MiniBrowser/gtk/main.c:
2072 2013-08-28 Simon Fraser <simon.fraser@apple.com>
2074 Add a Command-R shortcut in MiniBrowser
2075 https://bugs.webkit.org/show_bug.cgi?id=120442
2077 Reviewed by Dean Jackson.
2079 Add a "Reload Page" item to the View menu with a Command-R
2082 * MiniBrowser/mac/MainMenu.xib:
2084 2013-08-29 Alberto Garcia <berto@igalia.com>
2086 [GTK] Update apt dependency list
2087 https://bugs.webkit.org/show_bug.cgi?id=120399
2089 Reviewed by Philippe Normand.
2091 Remove bogus package gail-3.0, add xfonts-utils (needed by
2092 xorg-xserver) and switch to the latest versions of libtiff and
2095 * gtk/install-dependencies:
2097 2013-08-28 Alexey Proskuryakov <ap@apple.com>
2099 [WK2][Mac] WebKitTestRunner doesn't force system appearance
2100 https://bugs.webkit.org/show_bug.cgi?id=120437
2102 Reviewed by Darin Adler.
2104 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2105 (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
2106 AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
2109 2013-08-16 Ryosuke Niwa <rniwa@webkit.org>
2111 <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
2113 Reviewed by Darin Adler.
2115 Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
2117 We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
2118 editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
2120 Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
2121 ranges in a given attributed string.
2123 * DumpRenderTree/mac/TextInputController.m:
2124 (-[WebNSRange initWithNSRange:]):
2125 (-[WebNSRange location]):
2126 (-[WebNSRange length]):
2127 (+[WebNSRange isSelectorExcludedFromWebScript:]):
2128 (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
2129 (+[NSMutableAttributedString webScriptNameForSelector:]):
2130 (-[NSMutableAttributedString ranges]): Added.
2131 (+[TextInputController isSelectorExcludedFromWebScript:]):
2132 (+[TextInputController webScriptNameForSelector:]):
2133 (-[TextInputController legacyAttributedString:]):
2135 2013-08-28 Denis Nomiyama <d.nomiyama@samsung.com>
2137 [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
2138 https://bugs.webkit.org/show_bug.cgi?id=120419
2140 Reviewed by Chris Fleizach.
2142 Added a notification for AXFocusedUIElementChanged.
2144 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2145 (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
2147 2013-08-28 Roger Fong <roger_fong@apple.com>
2149 Decrease number of workers used in NRWT by the Windows port.
2150 https://bugs.webkit.org/show_bug.cgi?id=120435.
2152 Reviewed by Brent Fulgham.
2154 * Scripts/webkitpy/port/win.py:
2155 (WinPort.default_child_processes):
2157 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
2159 Http tests fails on Debian with Apache 2.4
2160 https://bugs.webkit.org/show_bug.cgi?id=120352
2164 Remember to update unit-test expectations and old-run-webkit-tests as well.
2166 * Scripts/webkitperl/httpd.pm:
2167 (getHTTPDConfigPathForTestDirectory):
2168 * Scripts/webkitpy/port/port_testcase.py:
2169 (test_apache_config_file_name_for_platform):
2171 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
2173 Http tests fails on Debian with Apache 2.4
2174 https://bugs.webkit.org/show_bug.cgi?id=120352
2176 Reviewed by Andreas Kling.
2178 Select httpd.conf file for debian based on version, matching Fedora behavior.
2180 * Scripts/webkitpy/port/base.py:
2181 (Port._apache_config_file_name_for_platform):
2183 2013-08-28 Commit Queue <commit-queue@webkit.org>
2185 Unreviewed, rolling out r154593.
2186 http://trac.webkit.org/changeset/154593
2187 https://bugs.webkit.org/show_bug.cgi?id=120403
2189 Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
2192 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2193 (WebPage::~WebPage):
2195 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
2197 [Qt][Wk2] Many tests are flaky on Qt 5.1
2198 https://bugs.webkit.org/show_bug.cgi?id=118232
2200 Reviewed by Jocelyn Turcotte.
2202 We need to set renderToOffscreenBuffer since we won't otherwise get
2203 the paint calls necessary to synchronize UI- and Web-Process. It was
2204 only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
2205 which is no longer supported or needed.
2207 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2208 (WTR::WrapperWindow::handleStatusChanged):
2210 2013-08-27 Alexey Proskuryakov <ap@apple.com>
2212 [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
2213 https://bugs.webkit.org/show_bug.cgi?id=120379
2215 Reviewed by Darin Adler.
2217 All major platforms have implemented UI process eventSender support, keeping old
2218 web process side code only adds confusion.
2220 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2221 (WTR::EventSendingController::EventSendingController):
2222 (WTR::EventSendingController::mouseDown):
2223 (WTR::EventSendingController::mouseUp):
2224 (WTR::EventSendingController::mouseMoveTo):
2225 (WTR::EventSendingController::leapForward):
2226 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2227 * WebKitTestRunner/TestController.cpp:
2228 (WTR::TestController::resetStateToConsistentValues):
2229 (WTR::TestController::didReceiveMessageFromInjectedBundle):
2230 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2231 * WebKitTestRunner/TestController.h:
2233 2013-08-27 Roger Fong <roger_fong@apple.com>
2235 NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
2236 https://bugs.webkit.org/show_bug.cgi?id=120370.
2238 Reviewed by Brent Fulgham.
2240 * Scripts/webkitpy/port/win.py:
2241 (WinPort.delete_sem_locks):
2242 (WinPort.setup_test_run):
2244 2013-08-27 Denis Nomiyama <d.nomiyama@samsung.com>
2246 [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
2247 https://bugs.webkit.org/show_bug.cgi?id=119883
2249 Implemented the notification listener for AccessibilityUIElement. The signal is generated
2250 by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
2251 axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
2252 callback function. The global callback function and callbacks for specific elements are
2253 stored in a HashMap in AccessibilityCallbacksAtk.cpp.
2255 Reviewed by Chris Fleizach.
2257 * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
2258 * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
2259 and removeAccessibilityNotificationListener()
2260 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2261 (axObjectEventListener): Call JS callback for global notification or for a specific element
2262 (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
2263 notification handler
2264 (addAccessibilityNotificationHandler): Add notification listener to the list
2265 (removeAccessibilityNotificationHandler): Remove notification listener from the list
2266 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2267 (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
2268 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2269 (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
2270 (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
2271 Remove handler from the list and disconnect callbacks
2272 (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
2273 callback and connect callbacks to signals
2274 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
2275 (AccessibilityNotificationHandler::setPlatformElement): Set platform element
2276 (AccessibilityNotificationHandler::platformElement): Get platform element
2277 (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
2278 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2279 (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
2280 platform element and the notification callback
2281 (AccessibilityUIElement::removeNotificationListener):
2282 * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
2283 * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
2285 2013-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
2287 Unreviewed. Fix GTK+ build after r154601.
2289 * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
2290 compilation added by mistake in r154601.
2292 2013-08-26 Alexey Proskuryakov <ap@apple.com>
2294 WebKitTestRunner needs to protect the user's pasteboard contents while running
2295 https://bugs.webkit.org/show_bug.cgi?id=81419
2296 <rdar://problem/11066794>
2298 Reviewed by Darin Adler.
2300 Mostly a copy/paste of DRT code.
2302 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
2303 doesn't interfere with my clipboard while being run in a loop.
2305 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2306 * WebKitTestRunner/mac/PoseAsClass.h: Added.
2307 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
2308 * WebKitTestRunner/mac/TestControllerMac.mm:
2309 (WTR::TestController::platformInitialize):
2310 (WTR::TestController::platformDestroy):
2311 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
2312 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
2314 2013-08-26 Commit Queue <commit-queue@webkit.org>
2316 Unreviewed, rolling out r154640.
2317 http://trac.webkit.org/changeset/154640
2318 https://bugs.webkit.org/show_bug.cgi?id=120329
2320 Caused flaky crashes on a lot of editing tests (Requested by
2323 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2324 * WebKitTestRunner/mac/PoseAsClass.h: Removed.
2325 * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
2326 * WebKitTestRunner/mac/TestControllerMac.mm:
2327 (WTR::TestController::platformInitialize):
2328 (WTR::TestController::platformDestroy):
2329 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
2330 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
2332 2013-08-26 Dan Bernstein <mitz@apple.com>
2334 Automatic bug reports case pain
2335 https://bugs.webkit.org/show_bug.cgi?id=120330
2337 Reviewed by Anders Carlsson.
2339 * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
2340 of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
2341 “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
2343 2013-08-23 Andy Estes <aestes@apple.com>
2345 Fix issues found by the Clang Static Analyzer
2346 https://bugs.webkit.org/show_bug.cgi?id=120230
2348 Reviewed by Darin Adler.
2350 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2351 (-[LocalPasteboard initWithName:]): Called [super init] first so that we
2352 don't later use ivars from the wrong self.
2353 * DumpRenderTree/mac/TestRunnerMac.mm:
2354 (-[APITestDelegate initWithCompletionCondition:]): Ditto.
2355 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2356 (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
2357 WKBrowsingContextGroups, and WKViews.
2359 2013-08-26 Alexey Proskuryakov <ap@apple.com>
2361 WebKitTestRunner needs to protect the user's pasteboard contents while running
2362 https://bugs.webkit.org/show_bug.cgi?id=81419
2363 <rdar://problem/11066794>
2365 Reviewed by Darin Adler.
2367 Mostly a copy/paste of DRT code.
2369 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
2370 doesn't interfere with my clipboard while being run in a loop.
2372 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2373 * WebKitTestRunner/mac/PoseAsClass.h: Added.
2374 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
2375 * WebKitTestRunner/mac/TestControllerMac.mm:
2376 (WTR::TestController::platformInitialize):
2377 (WTR::TestController::platformDestroy):
2378 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
2379 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
2381 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
2383 [GTK] Include most of the WebKit2 unit tests into the build and testing
2384 https://bugs.webkit.org/show_bug.cgi?id=120307
2386 Reviewed by Philippe Normand.
2388 There are still various unit test source files that are not being included into
2389 the build. This patch includes most of these, only leaving out tests that do not
2390 compile or test features that are not supported by the GTK port.
2392 * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
2394 * TestWebKitAPI/GNUmakefile.am:
2396 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2398 [GTK] Allow to run tests without Xvfb in run-gtk-tests
2399 https://bugs.webkit.org/show_bug.cgi?id=120298
2401 Reviewed by Philippe Normand.
2403 Add --no-xvfb command line option to run tests in the current
2406 * Scripts/run-gtk-tests:
2407 (TestRunner._run_xvfb): Return early if option --no-xvfb has been
2409 (TestRunner._setup_testing_environment): Use helper function
2410 _run_xvfb to start Xvfb if needed.
2411 (TestRunner._tear_down_testing_environment): Check Xvfb is
2412 actually running before trying to terminate it.
2414 2013-08-26 Zoltan Arvai <zarvai@inf.u-szeged.hu>
2416 Adding Gabor Abraham to contributors.json.
2418 Reviewed by Csaba Osztrogonác.
2420 * Scripts/webkitpy/common/config/contributors.json:
2422 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2424 [GTK] Add support for passing test directories to run-gtk-tests
2425 https://bugs.webkit.org/show_bug.cgi?id=120296
2427 Reviewed by Philippe Normand.
2429 * Scripts/run-gtk-tests:
2430 (TestRunner._get_tests_from_dir): Helper function to return all
2431 unit tests found in a given directory.
2432 (TestRunner._get_tests): Check the given tests passed in the
2433 command line, so that if a directory is found the tests contained
2434 in the directory are added to the list of tests to run.
2436 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2438 [GTK] Improve the stop/reload button implementation in MiniBrowser
2439 https://bugs.webkit.org/show_bug.cgi?id=120292
2441 Reviewed by Philippe Normand.
2443 - Use an instance member of BrowserWindow for the button widget
2444 instead of a global variable.
2445 - Use notify::is-loading to monitor the WebView load instead of
2446 the estimated-load-progress property.
2447 - Use webkit_web_view_is_loading() to check whether the view
2448 is loading to change the button icon instead of a string
2449 comparison of the gtk stock icon id.
2450 - Use the right casts to fix compile warning.
2452 * MiniBrowser/gtk/BrowserWindow.c:
2453 (reloadOrStopCallback):
2454 (webViewLoadProgressChanged):
2455 (webViewIsLoadingChanged):
2456 (browser_window_init):
2457 (browserWindowConstructed):
2459 2013-08-26 Arunprasad Rajkumar <arurajku@cisco.com>
2461 [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
2462 https://bugs.webkit.org/show_bug.cgi?id=119791
2464 Reviewed by Jocelyn Turcotte.
2466 Load empty url to send onunload event to currently running page. onunload event is
2467 mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
2468 LayoutTests/plugins/geturlnotify-during-document-teardown.html.
2470 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2471 (WebPage::~WebPage):
2473 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2475 [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
2476 https://bugs.webkit.org/show_bug.cgi?id=120290
2478 Reviewed by Philippe Normand.
2480 * MiniBrowser/gtk/GNUmakefile.am: Add
2481 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
2483 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
2485 [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
2486 https://bugs.webkit.org/show_bug.cgi?id=120288
2488 Reviewed by Carlos Garcia Campos.
2490 * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
2491 into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
2492 These unit tests are at the moment failing in debug configurations, so it would be nice to
2493 have the GTK builds report these failures as well.
2495 2013-08-25 Ryuan Choi <ryuan.choi@samsung.com>
2497 [EFL] EWebLauncher is executed as full screen with device pixel ratio
2498 https://bugs.webkit.org/show_bug.cgi?id=120282
2500 Reviewed by Gyuyoung Kim.
2502 * EWebLauncher/main.c:
2503 Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
2505 2013-08-25 Zan Dobersek <zdobersek@igalia.com>
2507 [gdb] Remove the pretty printer for KURLGooglePrivate
2508 https://bugs.webkit.org/show_bug.cgi?id=120263
2510 Reviewed by Benjamin Poulain.
2512 Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
2513 was usable inside the gdb debugger. The structure was remove from the codebase
2514 along with the GoogleURL backend for KURL.
2517 (JSCJSStringPrinter.to_string):
2518 (add_pretty_printers):
2520 2013-08-24 Filip Pizlo <fpizlo@apple.com>
2522 Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
2523 prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
2524 libraries depend on libgtest anyway.
2526 * Scripts/copy-webkitlibraries-to-product-directory:
2528 2013-08-24 Darin Adler <darin@apple.com>
2530 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
2531 https://bugs.webkit.org/show_bug.cgi?id=120255
2533 Reviewed by Andreas Kling.
2535 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
2537 2013-08-24 Anders Carlsson <andersca@apple.com>
2539 Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
2540 https://bugs.webkit.org/show_bug.cgi?id=120249
2542 Reviewed by Andreas Kling.
2544 * Scripts/extract-localizable-strings:
2546 2013-08-24 Carlos Garcia Campos <cgarcia@igalia.com>
2548 [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
2549 https://bugs.webkit.org/show_bug.cgi?id=119743
2551 Reviewed by Anders Carlsson.
2553 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2554 (WTR::InjectedBundlePage::InjectedBundlePage): Add
2557 2013-08-23 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
2559 Move TestWebKitAPI_LIBRARIES before platform specific cmake include
2560 https://bugs.webkit.org/show_bug.cgi?id=120220
2562 Reviewed by Martin Robinson.
2564 * TestWebKitAPI/CMakeLists.txt:
2566 2013-08-22 Filip Pizlo <fpizlo@apple.com>
2568 build-jsc --ftl-jit should work
2569 https://bugs.webkit.org/show_bug.cgi?id=120194
2571 Reviewed by Oliver Hunt.
2573 * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
2575 2013-08-23 Commit Queue <commit-queue@webkit.org>
2577 Unreviewed, rolling out r153534.
2578 http://trac.webkit.org/changeset/153534
2579 https://bugs.webkit.org/show_bug.cgi?id=120216
2581 Too many tests failing just WinEWS bots (Requested by rfong on
2584 * Scripts/webkitpy/common/config/ews.json:
2586 2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
2588 Unreviewed. Added my webkit.org email address.
2590 * Scripts/webkitpy/common/config/contributors.json:
2592 2013-08-23 Peter Gal <galpeter@inf.u-szeged.hu>
2594 [WTR] Should dump as text when the mimetype is text/plain
2595 https://bugs.webkit.org/show_bug.cgi?id=118306
2597 Reviewed by Christophe Dumez.
2599 Check for the text/plain mimetype and if true then mark it as
2602 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2603 (WTR::InjectedBundlePage::dump):
2605 2013-08-22 Filip Pizlo <fpizlo@apple.com>
2607 Update LLVM binary drops and scripts to the latest version from SVN
2608 https://bugs.webkit.org/show_bug.cgi?id=120184
2610 Reviewed by Mark Hahnenberg.
2612 * ReducedFTL/build.sh:
2613 * Scripts/configure-llvm: Added.
2614 * Scripts/copy-webkitlibraries-to-product-directory:
2615 * Scripts/export-llvm-build:
2617 2013-08-22 Andy Estes <aestes@apple.com>
2619 <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
2621 Reviewed by David Kilzer.
2623 * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
2624 OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
2625 DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
2627 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
2629 NRWT: Add the ability to upload test results to new test results server
2630 https://bugs.webkit.org/show_bug.cgi?id=120146
2632 Reviewed by Andreas Kling.
2634 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
2635 that contains the full summary of the test run including information about passed tests.
2637 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
2640 --results-server-host
2642 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
2643 so we should be able to delete --test-results-server in time.
2645 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2647 (Manager._upload_json_files):
2649 (Manager.upload_results):
2650 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2651 (summarize_results):
2652 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2653 (summarized_results):
2654 (SummarizedResultsTest.test_summarized_results_wontfix):
2655 (SummarizedResultsTest):
2656 (SummarizedResultsTest.test_summarized_results_include_passes):
2657 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2660 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
2662 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
2664 * Scripts/webkitpy/tool/bot/irc_command.py:
2667 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
2669 [Qt] DRT bug revealed/caused by r154300
2670 https://bugs.webkit.org/show_bug.cgi?id=120151
2672 Reviewed by Simon Hausmann.
2674 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
2675 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
2678 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
2679 between native Qt methods and JSC bound methods. This patch changes the check to see if the
2680 property is writable since the Qt methods are ReadOnly.
2682 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2683 (DumpRenderTree::initJSObjects):
2685 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
2687 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
2689 Reviewed by Benjamin Poulain.
2691 WTFString moved the is8bit bit by one in r152201.
2693 * lldb/lldb_webkit.py:
2694 (WTFStringImplProvider.is_8bit):
2696 2013-08-21 Tim Horton <timothy_horton@apple.com>
2698 Revert http://trac.webkit.org/changeset/154022, as it failed to update
2699 a variety of scripts that depended on the old format.
2701 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
2703 * Scripts/prepare-ChangeLog:
2705 (generateNewChangeLogs):
2707 2013-08-21 Brent Fulgham <bfulgham@apple.com>
2709 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
2711 * WinLauncher/WinLauncher.cpp:
2712 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
2714 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
2716 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
2718 Reviewed by Andreas Kling.
2720 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2721 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
2722 (WTR::activateFonts): Ditto.
2724 2013-08-21 Brian Holt <brian.holt@samsung.com>
2726 [GTK] Suppress irrelevant or known leaks for Valgrind
2727 https://bugs.webkit.org/show_bug.cgi?id=119448
2729 Reviewed by Martin Robinson.
2731 Add a suppressions file to suppress known leaks for Valgrind.
2732 Valgrind also takes longer when using suppressions and
2733 times out unless the driver timeout is increased.
2735 * Scripts/valgrind/suppressions.txt: Added.
2736 * Scripts/webkitpy/port/gtk.py:
2737 (GtkPort.driver_stop_timeout):
2738 (GtkPort.setup_environ_for_server):
2740 2013-08-20 Alex Christensen <achristensen@apple.com>
2742 [Windows] Linking fix for Win64.
2744 Rubberstamped by Brent Fulgham.
2746 * win/DLLLauncher/DLLLauncherMain.cpp:
2747 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
2749 2013-08-20 Brent Fulgham <bfulgham@apple.com>
2751 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
2753 Reviewed by Tim Horton.
2755 * win/DLLLauncher/DLLLauncherMain.cpp:
2756 (getLastErrorString): New method to convert GetLastError to text.
2757 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
2759 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
2761 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
2763 Reviewed by Martin Robinson.
2765 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
2766 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
2768 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
2770 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
2772 Reviewed by Martin Robinson.
2774 Added stop button in MiniBrowser
2776 * MiniBrowser/gtk/BrowserWindow.c:
2777 (reloadOrStopCallback): Callback to handle stop or reload button click.
2778 (webViewLoadProgressChanged): Update reload or stop button icon.
2779 (browser_window_init): Save button pointer for further icon updates.
2781 2013-08-20 Simon Pena <simon.pena@samsung.com>
2783 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
2785 Reviewed by Alexey Proskuryakov.
2787 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
2788 printing didFailLoadWithError.
2790 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
2791 DumpRenderTree, printing didFailLoadWithError.
2793 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2794 (webFrameLoadStatusNotified):
2796 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
2798 <https://webkit.org/b/120049> Delete code for Snow Leopard
2800 Reviewed by Benjamin Poulain.
2802 * DumpRenderTree/mac/CheckedMalloc.cpp:
2803 (protectionOfRegion):
2804 (makeLargeMallocFailSilently):
2805 * DumpRenderTree/mac/DumpRenderTree.mm:
2806 (resetDefaultsToConsistentValues):
2807 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2808 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2809 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2811 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2812 * DumpRenderTree/mac/LayoutTestHelper.m:
2813 * DumpRenderTree/mac/TestRunnerMac.mm:
2814 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2815 (WTR::InjectedBundle::platformInitialize):
2816 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2817 (WTR::testPathFromURL):
2818 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2820 2013-08-19 Alexey Proskuryakov <ap@apple.com>
2822 https://bugs.webkit.org/show_bug.cgi?id=119915
2823 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
2825 Reviewed by Darin Adler.
2827 The issue was that we ended up having no CFNetwork cache in the testing session due
2828 to an incorrect cache model. There is a number of things not implemented when it
2829 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
2830 the easiest way to get this going is to initialize it to correct value upfront.
2832 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2834 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
2836 REGRESSION(r154275): webkitpy tests failing
2837 https://bugs.webkit.org/show_bug.cgi?id=120010
2839 Reviewed by Jocelyn Turcotte.
2841 Update unit-tests to tests the new search-path structure,
2842 but reverting the architecture search path addition.
2844 * Scripts/webkitpy/port/qt.py:
2847 (QtPort._generate_all_test_configurations):
2848 (QtPort.qt_architecture):
2849 * Scripts/webkitpy/port/qt_unittest.py:
2851 (QtPortTest._assert_search_path):
2852 (QtPortTest._assert_expectations_files):
2853 (QtPortTest._qt_version):
2855 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
2857 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
2859 Unreviewed meta gardening.
2861 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
2863 * Scripts/webkitpy/port/qt.py:
2864 (QtPort._search_paths):
2866 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
2868 Restructure Qt test expectations
2870 Unreviewed meta gardening.
2872 Removed 5.0 name from WK1 and WK2 results and made it possible to set
2873 expectations by both Qt version and mayor architectures.
2875 * Scripts/webkitpy/port/qt.py:
2876 (QtPort._wk2_port_name):
2878 (QtPort.qt_version):
2879 (QtPort.architecture):
2880 (QtPort._search_paths):
2881 (QtPort._port_specific_expectations_files):
2883 2013-08-16 Brent Fulgham <bfulgham@apple.com>
2885 [Windows] DRT is not using the same preferences as the Mac build.
2886 https://bugs.webkit.org/show_bug.cgi?id=119822
2888 Reviewed by Darin Adler.
2890 * DumpRenderTree/win/DumpRenderTree.cpp:
2891 (runTest): Process Windows message queue using CFRunLoop to allow
2892 dispatch routines to run properly.
2893 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
2894 to prevent problems on WinCairo port.
2896 2013-08-16 Brent Fulgham <bfulgham@apple.com>
2898 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
2899 https://bugs.webkit.org/show_bug.cgi?id=119583
2901 Reviewed by Alexey Proskuryakov.
2903 * DumpRenderTree/win/DumpRenderTree.cpp:
2904 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
2905 component if the URL does not contain the expected base URL.
2907 2013-08-16 Pratik Solanki <psolanki@apple.com>
2909 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
2911 Reviewed by Andreas Kling.
2913 m_script is never NULL so we can just return a reference. Also remove some pointless null
2914 checks as a result of doing this.
2916 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2917 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2919 2013-08-15 Alexey Proskuryakov <ap@apple.com>
2921 [WK2] NetworkProcess should use a temporary storage session for test
2922 https://bugs.webkit.org/show_bug.cgi?id=119855
2924 Reviewed by Darin Adler.
2926 Use a new API that takes care of both WebProcess and NetworkProcess.
2928 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2929 (WTR::InjectedBundle::initialize):
2930 * WebKitTestRunner/TestController.cpp:
2931 (WTR::TestController::initialize):
2933 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
2935 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
2937 Reviewed by Dirk Pranke.
2939 This is a port from Blink of
2940 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
2941 originally by Dirk Pranke.
2943 From the original commit:
2945 This gives something like a 15x speedup over compiling and matching
2946 one property at a time and doing multiple passes over the file.
2948 * Scripts/webkitpy/w3c/test_converter.py:
2949 (W3CTestConverter.__init__):
2950 (W3CTestConverter.convert_prefixed_properties):
2951 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2953 2013-08-15 Dan Bernstein <mitz@apple.com>
2955 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
2957 Reviewed by Darin Adler.
2959 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
2960 added a message that points to the source code. Removed some unnecessary repetition of what
2961 is already in the file.
2963 2013-08-15 Andy Estes <aestes@apple.com>
2965 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
2967 Reviewed by Brady Eidson.
2969 Wrote an API test that verifies -[WebView stopLoading:] can be called
2970 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
2972 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2973 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
2974 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
2975 (TestWebKitAPI::TEST):
2977 2013-08-15 Alexey Proskuryakov <ap@apple.com>
2979 Adding Myles Maxfield to contributors.json.
2981 Oops, wrong section, fixing.
2983 * Scripts/webkitpy/common/config/contributors.json:
2985 2013-08-15 Alexey Proskuryakov <ap@apple.com>
2987 Adding Myles Maxfield to contributors.json.
2989 * Scripts/webkitpy/common/config/contributors.json:
2991 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
2993 [Qt] Do not check specifically for version 5.0
2994 https://bugs.webkit.org/show_bug.cgi?id=119846
2996 Reviewed by Jocelyn Turcotte.
2998 For Qt 5.x we should always use both wk1 and wk2 basepath results.
3000 * Scripts/webkitpy/port/qt.py:
3001 (QtPort._search_paths):
3003 2013-08-15 Simon Pena <simon.pena@samsung.com>
3005 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
3007 Reviewed by Gustavo Noronha Silva.
3009 Following a similar approach as in r153977, return a path string
3010 that is relative to main frame URL or just file name if the
3011 resource is not in the same directory subtree, and replace empty
3012 strings with "(null)".
3014 Update pathFromSoupURI so it behaves more closely to the other
3015 ports, and remove the unused code after we no longer print
3016 <unknown> in certain cases. Also move
3017 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
3018 be used both in TestRunnerGtk and in DumpRenderTree.
3020 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3021 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
3022 we can print Soup URIs with the password, since soup_uri_to_string
3023 doesn't preserve them.
3024 (pathFromSoupURI): Updated following EFL implementation in
3025 r153977, and return a WTFString instead of a CString.
3026 (convertSoupMessageToURLPath): Return "(null)" instead of empty
3027 strings, and handle the new return type of pathFromSoupURI.
3028 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
3029 reference, and handle the new return type of pathFromSoupURI.
3030 (descriptionSuitableForTestResult): Remove unused code.
3031 (didFinishLoading): Use convertResourceToURLPath.
3032 (didFailLoadingWithError): Use convertResourceToURLPath.
3033 (authenticationCallback): Display the URL of the authentication
3035 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
3036 soupURIToStringPreservingPassword.
3037 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
3038 soupURIToStringPreservingPassword.
3040 2013-08-14 Tim Horton <timothy_horton@apple.com>
3042 Un-inline dataLog dumpers for IntSize and IntPoint
3043 https://bugs.webkit.org/show_bug.cgi?id=119697
3045 Reviewed by Sam Weinig.
3047 * TestWebKitAPI/GNUmakefile.am:
3049 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
3051 Flakiness dashboard build fix.
3053 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3054 (processTestRunsForBuilder):
3056 2013-08-14 Martin Robinson <mrobinson@igalia.com>
3058 [GTK] [CMake] Add support for building TestWebKitAPI
3059 https://bugs.webkit.org/show_bug.cgi?id=116987
3061 Reviewed by Philippe Normand.
3063 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
3064 platform-specific file, so that GTK+ can override them.
3065 * TestWebKitAPI/PlatformGTK.cmake: Added.
3067 2013-08-14 Brent Fulgham <bfulgham@apple.com>
3069 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
3070 https://bugs.webkit.org/show_bug.cgi?id=119775
3072 This bug updates the WinLauncher program with a few useful menu
3073 options to toggle certain debugging and development features of
3076 Reviewed by Tim Horton.
3078 * WinLauncher/WinLauncher.cpp:
3079 (dllLauncherEntryPoint): Clean up preference objects on exit.
3080 (ToggleMenuItem): New function.
3081 (LaunchInspector): New function.
3082 (WndProc): Add handler for new menu items. Also properly terminate
3083 CFRunLoop operation on program exit.
3084 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
3086 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
3087 resource folder to search path.
3088 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
3091 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
3093 Add a hyperlink from build.webkit.org to the flakiness dashboard.
3095 Rubbers-tamped by Simon Fraser.
3097 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3099 2013-08-14 Benjamin Dupont <bdupont@nds.com>
3101 [Qt] Activate visibility API layout tests
3102 https://bugs.webkit.org/show_bug.cgi?id=119790
3104 Reviewed by Allan Sandfeld Jensen.
3106 * DumpRenderTree/qt/TestRunnerQt.cpp:
3107 (TestRunner::resetPageVisibility):
3108 (TestRunner::setPageVisibility):
3110 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
3112 [GTK] WK does not link properly against libxslt
3113 https://bugs.webkit.org/show_bug.cgi?id=119688
3115 Reviewed by Gustavo Noronha Silva.
3117 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
3119 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
3121 2013-08-13 Alexey Proskuryakov <ap@apple.com>
3123 [Mac] fast/dom/attr-style-too-lazy.html is flaky
3124 https://bugs.webkit.org/show_bug.cgi?id=119763
3126 Reviewed by Darin Adler.
3128 * DumpRenderTree/mac/UIDelegate.mm:
3129 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
3130 a test, it would just semi-randomly leak to the next one.
3131 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
3134 2013-08-13 Tim Horton <timothy_horton@apple.com>
3136 [mac] Give MiniBrowser a reasonable bundle identifier
3137 https://bugs.webkit.org/show_bug.cgi?id=119773
3139 Rubber-stamped by Simon Fraser.
3141 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
3143 * MiniBrowser/mac/Info.plist:
3144 * MiniBrowser/mac/WebBundle/Info.plist:
3146 2013-08-13 Dean Jackson <dino@apple.com>
3148 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
3150 Reviewed by Mark Rowe.
3152 Have prepare-ChangeLog produce webkit.org/b/id style
3153 URLs rather than exposing the inner workings of our
3154 cgi. I was going to use the term "Future Proofing"
3155 but that seems excessive :)
3157 * Scripts/prepare-ChangeLog:
3158 (main): Generate a more human readable form.
3159 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
3161 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3163 [EFL][DRT] Simplify call to reverseFind()
3164 https://bugs.webkit.org/show_bug.cgi?id=119746
3166 Reviewed by Christophe Dumez.
3168 Follow-up to r153977.
3170 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3171 (pathSuitableForTestResult): Instead of defining a static variable
3172 that's only used in a single place, pass '/' to reverseFind() directly.
3174 2013-08-13 Alberto Garcia <berto@igalia.com>
3176 [GTK] Closing inspector window crashes wk
3177 https://bugs.webkit.org/show_bug.cgi?id=110865
3179 Reviewed by Carlos Garcia Campos.
3181 Disconnect all signal handlers if the inspector window is
3184 * GtkLauncher/LauncherInspectorWindow.c:
3185 (inspectorWindowDestroyed):
3186 (launcherInspectorWindowNew):
3188 2013-08-12 Dan Bernstein <mitz@apple.com>
3190 extract-localizable-strings output is not suited for parsing by Xcode
3191 https://bugs.webkit.org/show_bug.cgi?id=119728
3193 Reviewed by Darin Adler.
3195 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
3196 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
3197 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
3200 * Scripts/extract-localizable-strings:
3202 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
3204 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
3205 https://bugs.webkit.org/show_bug.cgi?id=119585
3207 Reviewed by Gyuyoung Kim.
3209 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3210 (pathSuitableForTestResult):
3211 Return path string that's relative to main frame URL, or just file name if
3212 the resource is not in the same directory subtree.
3213 Referenced WebKitTestRunner code in r153852.
3214 (descriptionSuitableForTestResult):
3215 (DumpRenderTreeChrome::onFrameRedirectRequested):
3216 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
3218 2013-08-12 Dan Bernstein <mitz@apple.com>
3220 extract-localizable-strings doesn't know how to verify an existing strings file
3221 https://bugs.webkit.org/show_bug.cgi?id=119704
3223 Reviewed by Darin Adler.
3225 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
3226 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
3227 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
3228 the way directories to skip are specified from prefixing the directory with a “-” to
3229 specifying it with --skip.
3230 Finally, added a --verify option. When specified, the strings file is not written to, but
3231 instead read in and checked for consistency with the comments, keys and values derived from
3232 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
3233 mismatching comments are reported as errors.
3234 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
3235 directories to skip and no exceptions file.
3237 2013-08-12 Alexey Proskuryakov <ap@apple.com>
3239 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
3240 https://bugs.webkit.org/show_bug.cgi?id=85522
3242 Reviewed by Andy Estes.
3244 * DumpRenderTree/mac/UIDelegate.mm:
3245 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
3246 when already done with a test. We already had this check in all UI delegate functions,
3247 except for -webView:addMessageToConsole:withSource: somehow.
3249 2013-08-12 Alexey Proskuryakov <ap@apple.com>
3251 https://bugs.webkit.org/show_bug.cgi?id=119693
3252 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
3253 because of connect-src-websocket-allowed.html
3255 Reviewed by Darin Adler.
3257 Starting a load of about:blank and immediately stopping it cancels outstanding
3258 resource loads, but the page has to transition to committed state to have timers
3259 or WebSockets stopped too.
3261 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
3262 ensure that transition to committed state happens before we start the next test.
3264 2013-08-12 Beth Dakin <bdakin@apple.com>
3266 The LayoutMilestones didLayout callback should only fire for the main frame
3267 https://bugs.webkit.org/show_bug.cgi?id=119457
3269 Reviewed by Sam Weinig.
3271 Now that the didLayout callback only fires for the main frame, we want to make
3272 sure it will fire even when all of the content is in a subframe.
3274 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3275 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
3276 (TestWebKitAPI::didLayout):
3277 (TestWebKitAPI::TEST):
3278 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
3280 2013-08-12 Beth Dakin <bdakin@apple.com>
3282 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
3283 https://bugs.webkit.org/show_bug.cgi?id=119658
3285 Reviewed by Darin Adler.
3287 * MiniBrowser/mac/WK2BrowserWindowController.m:
3288 (-[WK2BrowserWindowController awakeFromNib]):
3289 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3290 (WTR::InjectedBundlePage::InjectedBundlePage):
3291 * WebKitTestRunner/TestController.cpp:
3292 (WTR::TestController::createWebViewWithOptions):
3294 2013-08-12 Seokju Kwon <seokju@webkit.org>
3296 Remove glu's libtest rule from checker.py
3297 https://bugs.webkit.org/show_bug.cgi?id=119674
3299 Reviewed by Darin Adler.
3301 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
3303 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
3305 Unreviewed. Change my primary mail address.
3307 * Scripts/webkitpy/common/config/contributors.json:
3309 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
3311 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
3312 https://bugs.webkit.org/show_bug.cgi?id=115751
3314 Reviewed by Martin Robinson.
3316 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
3319 2013-08-09 Beth Dakin <bdakin@apple.com>
3321 AX: Not able to use arrow keys to read text in a WK2 app
3322 https://bugs.webkit.org/show_bug.cgi?id=119605
3324 <rdar://problem/14281275>
3326 Reviewed by Darin Adler.
3328 New test verifies that didNotHandleKeyEvent will be called when there is nothing
3330 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3331 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
3332 (TestWebKitAPI::didFinishLoadForFrame):
3333 (TestWebKitAPI::didNotHandleKeyEventCallback):
3334 (TestWebKitAPI::TEST):
3336 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
3338 Add support for KeyboardEvent.location attribute
3339 https://bugs.webkit.org/show_bug.cgi?id=119326
3341 Reviewed by Benjamin Poulain.
3343 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
3345 * DumpRenderTree/mac/EventSendingController.mm:
3346 (-[EventSendingController keyDown:withModifiers:withLocation:]):
3347 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
3348 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
3349 (-[EventSendingController handleEvent:]):
3350 (-[EventSendingController fireKeyboardEventsToElement:]):
3352 2013-08-09 Alexey Proskuryakov <ap@apple.com>
3354 <unknown> is often dumped instead of path in test output
3355 https://bugs.webkit.org/show_bug.cgi?id=119590
3357 Reviewed by Anders Carlsson.
3359 There were two reasons for <unknown>:
3360 1. When delegate logging is enabled via a testRunner call, that obviously happens
3361 after main resource load starts, so we don't record its URL.
3362 2. Authentication delegate logging relied on URL recording, but it's only turned on
3363 when enabling resource loading delegate logging, not auth one.
3365 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
3366 landed without posted rationale and unreviewed. Just undoing that change now.
3368 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3369 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3370 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3371 (WTR::InjectedBundlePage::didInitiateLoadForResource):
3373 2013-08-08 Alex Christensen <achristensen@apple.com>
3375 Windows build fixes.
3377 Rubberstamped by Brent Fulgham.
3379 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3380 Removed /SAFESEH link option which doesn't work with x64.
3382 2013-08-08 Daniel Bates <dabates@apple.com>
3384 Add iOS support to run-javascriptcore-tests
3385 https://bugs.webkit.org/show_bug.cgi?id=119602
3387 Reviewed by Joseph Pecoraro.
3389 Make run-javascriptcore-tests work for iOS WebKit.
3391 * Scripts/run-javascriptcore-tests:
3393 2013-08-08 Alexey Proskuryakov <ap@apple.com>
3395 [WK2] loader/go-back-cached-main-resource.html fails
3396 https://bugs.webkit.org/show_bug.cgi?id=116491
3398 Reviewed by Tim Horton.
3400 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3401 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3402 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3403 * DumpRenderTree/win/DumpRenderTree.cpp:
3404 Added FIXMEs about making path printing normalization more compatible.
3406 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
3407 Return last path component in cases where we used to return a full path, which is
3408 never desirable. Added a null check to basePath to prevent potentially getting
3409 an Objective C exception.
3411 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3412 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
3413 for a currently loading one (which is different for tests that use multiple windows).
3414 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
3415 last path component as last fallback.
3416 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
3417 frame URL here, and it was potentially a wrong frame.
3418 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
3419 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
3420 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
3421 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
3422 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
3424 2013-08-08 Alex Christensen <achristensen@apple.com>
3426 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
3427 https://bugs.webkit.org/show_bug.cgi?id=116125
3429 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
3431 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3432 (WTR::pathSuitableForTestResult):
3433 Changed string operations to match _drt_descriptionSuitableForTestResult.
3434 (WTR::dumpRequestDescriptionSuitableForTestResult):
3435 (WTR::dumpResponseDescriptionSuitableForTestResult):
3436 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3437 (WTR::InjectedBundlePage::didInitiateLoadForResource):
3438 (WTR::InjectedBundlePage::willSendRequestForFrame):
3439 (WTR::InjectedBundlePage::didReceiveResponseForResource):
3440 Pass the main frame's URL to pathSuitableForTestResult.
3441 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3442 Added WKBundlePageRef to willPerformClientRedirectForFrame.
3444 2013-08-07 Simon Fraser <simon.fraser@apple.com>
3446 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
3447 https://bugs.webkit.org/show_bug.cgi?id=119317
3449 Reviewed by Tim Horton.
3451 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
3452 the test to complete, which is not power friendly. Although DRT instances
3453 are generally busy anyway, not sitting in a busy loop should free up some CPU
3454 cycles for other instances of DRT.
3456 Editing tests continue to pass. All Java tests are skipped and were not
3457 tested, but when run fail similarly with and without the patch.
3459 * DumpRenderTree/mac/DumpRenderTree.mm:
3463 2013-08-07 Daniel Bates <dabates@apple.com>
3465 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
3466 <https://bugs.webkit.org/show_bug.cgi?id=119558>
3468 Reviewed by Martin Robinson.
3470 Currently we build the command line to execute jsDriver.pl twice so as to both
3471 print it to standard output and actually execute it. We should only build up
3472 this command line once. Moreover, we should print to standard output the actual
3473 command line that we are going to use including the GTK- and EFL-specific call
3474 to /Tools/jhbuild/jhbuild-wrapper.
3476 * Scripts/run-javascriptcore-tests:
3478 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
3480 [EFL] REGRESSION after r153432: some accessibility tests crash.
3481 https://bugs.webkit.org/show_bug.cgi?id=119333
3483 Reviewed by Darin Adler.
3485 Use a RefPtr to store a reference to the parent element of
3486 an AccessibilityUIElement instead of the raw pointer, so we
3487 never derefence a function from an invalid pointer.
3489 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3490 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
3492 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
3494 Unreviewed. Add myself as a committer.
3496 * Scripts/webkitpy/common/config/contributors.json:
3498 2013-08-04 Sam Weinig <sam@webkit.org>
3500 Remove support for HTML5 MicroData
3501 https://bugs.webkit.org/show_bug.cgi?id=119480
3503 Reviewed by Anders Carlsson.
3505 * Scripts/webkitperl/FeatureList.pm:
3506 * qmake/mkspecs/features/features.pri:
3508 2013-07-23 David Farler <dfarler@apple.com>
3510 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
3511 https://bugs.webkit.org/show_bug.cgi?id=117762
3513 Reviewed by Mark Rowe.
3515 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3516 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3517 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3518 Add ASAN_OTHER_LDFLAGS.
3519 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3520 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3521 * Scripts/check-for-weak-vtables-and-externals:
3522 Ignore ___asan externals, these are populated by compiler-rt.
3523 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3524 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3525 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3526 Add ASAN_OTHER_LDFLAGS.
3527 * WebKitLauncher/Configurations/Base.xcconfig:
3528 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3529 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
3530 Add ASAN_OTHER_LDFLAGS.
3531 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3532 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3533 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3534 Add ASAN_OTHER_LDFLAGS.
3535 * asan/asan.xcconfig: Added.
3536 * asan/webkit-asan-ignore.txt: Added.
3538 2013-08-05 Brian Holt <brian.holt@samsung.com>
3540 [GTK] Implement leak checking with valgrind
3541 https://bugs.webkit.org/show_bug.cgi?id=118785
3543 Reviewed by Dirk Pranke.
3545 Launch the DRT under Valgrind to generate xml files with details
3548 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3550 * Scripts/webkitpy/port/gtk.py:
3552 (GtkPort.default_timeout_ms): Allow extra time to run under
3554 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
3555 using environment variables.
3557 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
3559 [EFL] REGRESSION after r153432: some accessibility tests crash.
3560 https://bugs.webkit.org/show_bug.cgi?id=119333
3562 Reviewed by Gustavo Noronha Silva.
3564 Add missing null-check to avoid dereferencing a non-existent parent.
3566 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3567 (WTR::attributesOfElement): Ditto.
3569 2013-08-02 Patrick Gansterer <paroga@webkit.org>
3571 Add --rmdir option to git svn dcommit
3572 https://bugs.webkit.org/show_bug.cgi?id=119398
3574 Reviewed by Ryosuke Niwa.
3576 Add this option tells git-svn to remove empty directories
3577 from the svn tree so they do not leave over there.
3579 * Scripts/webkitpy/common/checkout/scm/git.py:
3580 (Git.push_local_commits_to_server):
3582 2013-08-01 Brent Fulgham <bfulgham@apple.com>
3584 [Windows] WebKit1 Fullscreen Video Play is Broken
3585 https://bugs.webkit.org/show_bug.cgi?id=119415
3587 Reviewed by Jer Noble.
3589 * WinLauncher/WinLauncher.cpp:
3590 (dllLauncherEntryPoint): Activate full screen mode via
3591 IWebPreferencesInternal interface.
3593 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
3595 Unreviewed. Add an alternative address to show my affiliation in team.html.
3597 * Scripts/webkitpy/common/config/contributors.json:
3599 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
3601 Duplicate property names can cause test to fail
3602 https://bugs.webkit.org/show_bug.cgi?id=119399
3604 Reviewed by Dirk Pranke.
3606 This problem was noticed when porting the patch for
3607 http://wkb.ug/119357 to Blink: a test would fail because the converted
3608 and test property lists weren't the same length, but they contained
3609 all of the same property names. It looks like this is actually caused
3610 by a bug in converting the HTML, which is being currently rewritten.
3611 In the meantime, as long as this compares the number of unique
3612 properties, it makes the test more robust.
3614 * Scripts/webkitpy/w3c/test_converter_unittest.py:
3615 (verify_prefixed_properties):
3617 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
3619 Unreviewed. Adding my expertise.
3621 * Scripts/webkitpy/common/config/contributors.json:
3623 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
3625 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
3627 * Scripts/webkitpy/common/config/contributors.json:
3629 2013-08-01 Commit Queue <commit-queue@webkit.org>
3631 Unreviewed, rolling out r153518.
3632 http://trac.webkit.org/changeset/153518
3633 https://bugs.webkit.org/show_bug.cgi?id=119386
3635 The Jhbuild dep bump of GTK+ is not actually required by
3636 layout testing, is causing pango dep problems (Requested by
3637 zdobersek on #webkit).
3639 * gtk/jhbuild.modules:
3641 2013-08-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
3643 Unreviewed. Add myself as a committer.
3645 * Scripts/webkitpy/common/config/contributors.json:
3647 2013-08-01 Jaehun Lim <ljaehun.lim@samsung.com>
3649 Unreviewed. Add myself as a committer.