1a1c7bbb21014d5b1eeb98ec6f35b3fe9d53ec62
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
2
3         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
4         https://bugs.webkit.org/show_bug.cgi?id=130476
5
6         Reviewed by Anders Carlsson.
7         
8         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
9
10         * MiniBrowser/mac/WK1BrowserWindowController.m:
11         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
12         Remove log.
13         * MiniBrowser/mac/WK2BrowserWindowController.m:
14         (-[WK2BrowserWindowController awakeFromNib]):
15         (-[WK2BrowserWindowController validateMenuItem:]):
16         (-[WK2BrowserWindowController reload:]):
17         Hook up reload.
18         (-[WK2BrowserWindowController toggleZoomMode:]):
19         (-[WK2BrowserWindowController resetZoom:]):
20         (-[WK2BrowserWindowController canResetZoom]):
21         (-[WK2BrowserWindowController currentZoomFactor]):
22         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
23         (-[WK2BrowserWindowController canZoomIn]):
24         (-[WK2BrowserWindowController canZoomOut]):
25
26 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
27
28         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
29         https://bugs.webkit.org/show_bug.cgi?id=130463
30
31         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
32
33 2014-03-18  Samuel White  <samuel_white@apple.com>
34
35         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
36         https://bugs.webkit.org/show_bug.cgi?id=130250
37
38         Reviewed by Chris Fleizach.
39
40         Added ability to toggle enhanced accessibility on and off to support tests that require it.
41
42         * DumpRenderTree/AccessibilityController.cpp:
43         (enableEnhancedAccessibilityCallback):
44         (getEnhancedAccessibilityEnabledCallback):
45         (AccessibilityController::getJSClass):
46         * DumpRenderTree/AccessibilityController.h:
47         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
48         (AccessibilityController::enableEnhancedAccessibility):
49         (AccessibilityController::enhancedAccessibilityEnabled):
50         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
51         (AccessibilityController::enableEnhancedAccessibility):
52         (AccessibilityController::enhancedAccessibilityEnabled):
53         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
54         (AccessibilityController::enableEnhancedAccessibility):
55         (AccessibilityController::enhancedAccessibilityEnabled):
56         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
57         (AccessibilityController::enableEnhancedAccessibility):
58         (AccessibilityController::enhancedAccessibilityEnabled):
59         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
60         (WTR::AccessibilityController::enableEnhancedAccessibility):
61         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
62         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
63         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
64
65 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
66
67         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
68         yet).
69
70         * Scripts/webkitpy/common/config/contributors.json:
71
72 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
73
74         Web Inspector: Remove stale ReportMemoryUsagePlugin
75         https://bugs.webkit.org/show_bug.cgi?id=130405
76
77         Reviewed by Andreas Kling.
78
79         This clang plugin looks like it was used for the old Inspector memory
80         instrumentation that was removed. So the tool can be removed.
81
82         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
83         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
84         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
85         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
86
87 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
88
89         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
90         https://bugs.webkit.org/show_bug.cgi?id=130220
91
92         Reviewed by Csaba Osztrogonác.
93
94         * Scripts/webkitpy/common/checkout/changelog.py:
95         (ChangeLog.set_reviewer):
96         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
97         (test_set_reviewer):
98
99 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
100
101         More FTL enabling.
102
103         Rubber stamped by Dan Bernstein.
104
105         * Tools/Scripts/build-webkit:
106
107 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
108
109         Renable pagination mode in WK2 MiniBrowser
110         https://bugs.webkit.org/show_bug.cgi?id=130374
111
112         Reviewed by Anders Carlsson.
113         
114         Put the implementation of togglePaginationMode: back, and correctly
115         enable the menu item.
116
117         * MiniBrowser/mac/WK2BrowserWindowController.m:
118         (-[WK2BrowserWindowController validateMenuItem:]):
119         (-[WK2BrowserWindowController isPaginated]):
120         (-[WK2BrowserWindowController togglePaginationMode:]):
121
122 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
123
124         Add --reset option to Tools/Scripts/set-webkit-configuration script
125         https://bugs.webkit.org/show_bug.cgi?id=130401
126
127         Reviewed by Csaba Osztrogonác.
128
129         * Scripts/set-webkit-configuration:
130
131 2014-03-18  Alberto Garcia  <berto@igalia.com>
132
133         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
134         https://bugs.webkit.org/show_bug.cgi?id=130388
135
136         Reviewed by Sergio Villar Senin.
137
138         * Scripts/webkitdirs.pm:
139         (shouldRemoveCMakeCache): make sure that the build directory
140         exists before attempting to create a file in it.
141
142 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
143
144         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
145         https://bugs.webkit.org/show_bug.cgi?id=130336
146
147         Reviewed by Gyuyoung Kim.
148
149         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
150         requires a space between literal and string macro [-Wliteral-suffix]'
151         warning treated as error.
152
153         This patch applies a solution from r162448 to the EFL port.
154
155         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
156         * efl/jhbuild.modules: Added appropriate patch section.
157
158 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
159
160         webkitpy test rebaseline.
161
162         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
163         (MainTest.test_default_args):
164
165 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
166
167         --profile should imply --test-runner-count=1 in run-perf-tests
168         https://bugs.webkit.org/show_bug.cgi?id=130375
169
170         Reviewed by Benjamin Poulain.
171
172         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
173
174         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
175         (PerfTestsRunner._parse_args): Use -1 as the default value.
176         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
177         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
178         should be 1.
179
180 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
181
182         Address some style nits.
183
184         * MiniBrowser/mac/WK2BrowserWindowController.m:
185
186 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
187
188         Add transparent window support back into MiniBrowser
189         https://bugs.webkit.org/show_bug.cgi?id=130363
190
191         Reviewed by Anders Carlsson.
192         
193         Re-enable transparent window support for WK2.
194
195         * MiniBrowser/mac/WK2BrowserWindowController.m:
196         (-[WK2BrowserWindowController validateMenuItem:]):
197         (-[WK2BrowserWindowController toggleTransparentWindow:]):
198
199 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
200
201         Fix the 32-bit build; make the open panel make a WK1 window.
202
203         * MiniBrowser/mac/AppDelegate.m:
204         (-[BrowserAppDelegate openDocument:]):
205
206 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
207
208         Convert MiniBrowser to use WKWebView API
209         https://bugs.webkit.org/show_bug.cgi?id=130061
210
211         Reviewed by Anders Carlsson.
212         
213         Convert the MiniBrowser WK2 window to use WebKit2 API as much
214         as possible.
215         
216         Some functionality was removed temporarily:
217             - text zoom, page zoom
218             - reload
219             - pagination mode
220             - transparent window
221             - dumping source
222             - window.open support
223             - beforeUnload panel
224             - find in page
225
226         * MiniBrowser/mac/AppDelegate.h:
227         * MiniBrowser/mac/AppDelegate.m:
228         (-[BrowserAppDelegate init]):
229         (-[BrowserAppDelegate newWindow:]):
230         (-[BrowserAppDelegate applicationWillTerminate:]):
231         (-[BrowserAppDelegate openDocument:]):
232         * MiniBrowser/mac/WK2BrowserWindowController.h:
233         * MiniBrowser/mac/WK2BrowserWindowController.m:
234         (-[WK2BrowserWindowController awakeFromNib]):
235         (-[WK2BrowserWindowController dealloc]):
236         (-[WK2BrowserWindowController fetch:]):
237         (-[WK2BrowserWindowController validateMenuItem:]):
238         (-[WK2BrowserWindowController reload:]):
239         (-[WK2BrowserWindowController goBack:]):
240         (-[WK2BrowserWindowController goForward:]):
241         (-[WK2BrowserWindowController toggleZoomMode:]):
242         (-[WK2BrowserWindowController resetZoom:]):
243         (-[WK2BrowserWindowController canResetZoom]):
244         (-[WK2BrowserWindowController dumpSourceToConsole:]):
245         (-[WK2BrowserWindowController togglePaginationMode:]):
246         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
247         (-[WK2BrowserWindowController windowShouldClose:]):
248         (-[WK2BrowserWindowController applicationTerminating]):
249         (-[WK2BrowserWindowController currentZoomFactor]):
250         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
251         (-[WK2BrowserWindowController toggleTransparentWindow:]):
252         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
253         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
254         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
255         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
256         (-[WK2BrowserWindowController find:]):
257         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
258         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
259         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
260         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
261         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
262         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
263         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
264         * WebKitTestRunner/PlatformWebView.h:
265         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
266         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
267
268 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
269
270         Use RunLoop objects through references instead of pointers
271         https://bugs.webkit.org/show_bug.cgi?id=130313
272
273         Reviewed by Andreas Kling.
274
275         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
276         return RunLoop reference instead of a pointer.
277
278         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
279         (loadedCallback):
280         (clickedCallback):
281
282 2014-03-17  Tim Horton  <timothy_horton@apple.com>
283
284         sort-export-file --help doesn't work (missing 'use')
285         https://bugs.webkit.org/show_bug.cgi?id=130338
286
287         Reviewed by Anders Carlsson.
288
289         * Scripts/sort-export-file:
290         Add a missing 'use', and fix a typo in an error message.
291
292 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
293
294         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
295         https://bugs.webkit.org/show_bug.cgi?id=130155
296
297         Reviewed by Philippe Normand.
298
299         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
300
301 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
302
303         [GTK] MiniBrowser fails to load injected bundle lib
304         https://bugs.webkit.org/show_bug.cgi?id=130332
305
306         Reviewed by Anders Carlsson.
307
308         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
309
310         * MiniBrowser/gtk/main.c:
311         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
312         process is spawn.
313
314 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
315
316         [EFL] Enable TOUCH_SLIDER macro
317         https://bugs.webkit.org/show_bug.cgi?id=130185
318
319         Reviewed by Gyuyoung Kim.
320
321         * Scripts/webkitperl/FeatureList.pm:
322
323 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
324
325         [GTK][CMake] Build with -fno-rtti
326         https://bugs.webkit.org/show_bug.cgi?id=130261
327
328         Reviewed by Martin Robinson.
329
330         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
331         defined to 0 to prevent typeid use in included GTest headers.
332
333 2014-03-16  Brian Burg  <bburg@apple.com>
334
335         Web Inspector: vended backend commands file should be generated as part of the build
336         https://bugs.webkit.org/show_bug.cgi?id=130110
337
338         Reviewed by Timothy Hatcher.
339
340         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
341
342 2014-03-16  Diego Pino García  <dpino@igalia.com>
343
344         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
345         https://bugs.webkit.org/show_bug.cgi?id=128999
346
347         Reviewed by Philippe Normand.
348
349         * MiniBrowser/gtk/BrowserWindow.c:
350         (reloadPage):
351         (reloadPageIgnoringCache):
352         (browser_window_init):
353
354 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
355
356         [GTK] Improve ninja detection in webkitdirs.pm
357         https://bugs.webkit.org/show_bug.cgi?id=129902
358
359         Reviewed by Daniel Bates.
360
361         * Scripts/webkitdirs.pm:
362         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
363         us to look for ninja-build as well.
364
365 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
366
367         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
368         https://bugs.webkit.org/show_bug.cgi?id=130276
369         <rdar://problem/16266927>
370         
371         Reviewed by Simon Fraser.
372
373         * BuildSlaveSupport/build-launcher-app:
374         * BuildSlaveSupport/build-launcher-dmg:
375         * DumpRenderTree/DumpRenderTree.h:
376         * DumpRenderTree/DumpRenderTreePrefix.h:
377         * DumpRenderTree/GCController.cpp:
378         * DumpRenderTree/GCController.h:
379         * DumpRenderTree/JavaScriptThreading.cpp:
380         * DumpRenderTree/JavaScriptThreading.h:
381         * DumpRenderTree/PixelDumpSupport.cpp:
382         * DumpRenderTree/PixelDumpSupport.h:
383         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
384         * DumpRenderTree/TestRunner.cpp:
385         * DumpRenderTree/TestRunner.h:
386         * DumpRenderTree/WorkQueue.cpp:
387         * DumpRenderTree/WorkQueue.h:
388         * DumpRenderTree/WorkQueueItem.h:
389         * DumpRenderTree/atk/AccessibilityCallbacks.h:
390         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
391         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
392         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
393         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
394         * DumpRenderTree/cg/PixelDumpSupportCG.h:
395         * DumpRenderTree/efl/EditingCallbacks.cpp:
396         * DumpRenderTree/efl/EditingCallbacks.h:
397         * DumpRenderTree/efl/EventSender.cpp:
398         * DumpRenderTree/efl/EventSender.h:
399         * DumpRenderTree/efl/GCControllerEfl.cpp:
400         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
401         * DumpRenderTree/efl/TestRunnerEfl.cpp:
402         * DumpRenderTree/gtk/DumpRenderTree.cpp:
403         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
404         * DumpRenderTree/gtk/EditingCallbacks.cpp:
405         * DumpRenderTree/gtk/EditingCallbacks.h:
406         * DumpRenderTree/gtk/EventSender.cpp:
407         * DumpRenderTree/gtk/EventSender.h:
408         * DumpRenderTree/gtk/GCControllerGtk.cpp:
409         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
410         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
411         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
412         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
413         * DumpRenderTree/gtk/TextInputController.cpp:
414         * DumpRenderTree/gtk/TextInputController.h:
415         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
416         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
417         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
418         * DumpRenderTree/mac/AppleScriptController.h:
419         * DumpRenderTree/mac/AppleScriptController.m:
420         * DumpRenderTree/mac/CheckedMalloc.cpp:
421         * DumpRenderTree/mac/CheckedMalloc.h:
422         * DumpRenderTree/mac/DumpRenderTree.mm:
423         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
424         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
425         * DumpRenderTree/mac/DumpRenderTreeMac.h:
426         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
427         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
428         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
429         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
430         * DumpRenderTree/mac/EditingDelegate.h:
431         * DumpRenderTree/mac/EditingDelegate.mm:
432         * DumpRenderTree/mac/EventSendingController.h:
433         * DumpRenderTree/mac/EventSendingController.mm:
434         * DumpRenderTree/mac/FrameLoadDelegate.h:
435         * DumpRenderTree/mac/FrameLoadDelegate.mm:
436         * DumpRenderTree/mac/GCControllerMac.mm:
437         * DumpRenderTree/mac/MockWebNotificationProvider.h:
438         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
439         * DumpRenderTree/mac/NavigationController.h:
440         * DumpRenderTree/mac/NavigationController.m:
441         * DumpRenderTree/mac/ObjCController.h:
442         * DumpRenderTree/mac/ObjCController.m:
443         * DumpRenderTree/mac/ObjCPlugin.h:
444         * DumpRenderTree/mac/ObjCPlugin.m:
445         * DumpRenderTree/mac/ObjCPluginFunction.h:
446         * DumpRenderTree/mac/ObjCPluginFunction.m:
447         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
448         * DumpRenderTree/mac/PolicyDelegate.h:
449         * DumpRenderTree/mac/PolicyDelegate.mm:
450         * DumpRenderTree/mac/ResourceLoadDelegate.h:
451         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
452         * DumpRenderTree/mac/TestRunnerMac.mm:
453         * DumpRenderTree/mac/TextInputController.h:
454         * DumpRenderTree/mac/TextInputController.m:
455         * DumpRenderTree/mac/UIDelegate.h:
456         * DumpRenderTree/mac/UIDelegate.mm:
457         * DumpRenderTree/mac/WorkQueueItemMac.mm:
458         * DumpRenderTree/win/DRTDataObject.cpp:
459         * DumpRenderTree/win/DRTDataObject.h:
460         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
461         * DumpRenderTree/win/DRTDropSource.cpp:
462         * DumpRenderTree/win/DRTDropSource.h:
463         * DumpRenderTree/win/DraggingInfo.h:
464         * DumpRenderTree/win/DumpRenderTree.cpp:
465         * DumpRenderTree/win/DumpRenderTreeWin.h:
466         * DumpRenderTree/win/EditingDelegate.cpp:
467         * DumpRenderTree/win/EditingDelegate.h:
468         * DumpRenderTree/win/EventSender.cpp:
469         * DumpRenderTree/win/EventSender.h:
470         * DumpRenderTree/win/FrameLoadDelegate.cpp:
471         * DumpRenderTree/win/FrameLoadDelegate.h:
472         * DumpRenderTree/win/GCControllerWin.cpp:
473         * DumpRenderTree/win/HistoryDelegate.cpp:
474         * DumpRenderTree/win/HistoryDelegate.h:
475         * DumpRenderTree/win/MD5.cpp:
476         * DumpRenderTree/win/MD5.h:
477         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
478         * DumpRenderTree/win/PolicyDelegate.cpp:
479         * DumpRenderTree/win/PolicyDelegate.h:
480         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
481         * DumpRenderTree/win/ResourceLoadDelegate.h:
482         * DumpRenderTree/win/TestRunnerWin.cpp:
483         * DumpRenderTree/win/TextInputController.cpp:
484         * DumpRenderTree/win/TextInputController.h:
485         * DumpRenderTree/win/TextInputControllerWin.cpp:
486         * DumpRenderTree/win/UIDelegate.cpp:
487         * DumpRenderTree/win/UIDelegate.h:
488         * DumpRenderTree/win/WorkQueueItemWin.cpp:
489         * EWebLauncher/main.c:
490         * GtkLauncher/main.c:
491         * ImageDiff/efl/ImageDiff.cpp:
492         * ImageDiff/gtk/ImageDiff.cpp:
493         * MiniBrowser/gtk/main.c:
494         * Scripts/SpacingHeuristics.pm:
495         * Scripts/VCSUtils.pm:
496         * Scripts/bisect-builds:
497         * Scripts/build-dumprendertree:
498         * Scripts/build-jsc:
499         * Scripts/build-webkit:
500         * Scripts/check-dom-results:
501         * Scripts/check-for-exit-time-destructors:
502         * Scripts/check-for-global-initializers:
503         * Scripts/commit-log-editor:
504         * Scripts/compare-timing-files:
505         * Scripts/debug-minibrowser:
506         * Scripts/debug-safari:
507         * Scripts/do-file-rename:
508         * Scripts/find-extra-includes:
509         * Scripts/generate-coverage-data:
510         * Scripts/make-script-test-wrappers:
511         * Scripts/malloc-tree:
512         * Scripts/old-run-webkit-tests:
513         * Scripts/parse-malloc-history:
514         * Scripts/report-include-statistics:
515         * Scripts/resolve-ChangeLogs:
516         * Scripts/run-bindings-tests:
517         * Scripts/run-iexploder-tests:
518         * Scripts/run-javascriptcore-tests:
519         * Scripts/run-jsc:
520         * Scripts/run-launcher:
521         * Scripts/run-leaks:
522         * Scripts/run-mangleme-tests:
523         * Scripts/run-minibrowser:
524         * Scripts/run-pageloadtest:
525         * Scripts/run-regexp-tests:
526         * Scripts/run-safari:
527         * Scripts/run-sunspider:
528         * Scripts/run-webkit-app:
529         * Scripts/sampstat:
530         * Scripts/set-webkit-configuration:
531         * Scripts/sort-Xcode-project-file:
532         * Scripts/sort-export-file:
533         * Scripts/split-file-by-class:
534         * Scripts/sunspider-compare-results:
535         * Scripts/svn-apply:
536         * Scripts/svn-create-patch:
537         * Scripts/svn-unapply:
538         * Scripts/test-webkit-scripts:
539         * Scripts/update-javascriptcore-test-results:
540         * Scripts/update-webkit:
541         * Scripts/update-webkit-auxiliary-libs:
542         * Scripts/update-webkit-dependency:
543         * Scripts/update-webkit-localizable-strings:
544         * Scripts/update-webkit-support-libs:
545         * Scripts/update-webkit-wincairo-libs:
546         * Scripts/webkit-build-directory:
547         * Scripts/webkitdirs.pm:
548         (installedSafariPath):
549         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
550         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
551         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
552         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
553         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
554         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
555         * Scripts/webkitperl/features.pm:
556         * Scripts/webkitperl/httpd.pm:
557         * Scripts/webkitpy/bindings/main.py:
558         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
559         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
560         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
561         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
562         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
563         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
564         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
565         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
566         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
567         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
568         * WebKitTestRunner/PixelDumpSupport.cpp:
569         * WebKitTestRunner/PixelDumpSupport.h:
570         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
571         * WinLauncher/WinLauncher.cpp:
572         * WinLauncher/WinLauncher.h:
573         * WinLauncher/stdafx.cpp:
574         * WinLauncher/stdafx.h:
575
576 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
577
578         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
579         https://bugs.webkit.org/show_bug.cgi?id=130265
580
581         Reviewed by Michael Saboff.
582
583         * Scripts/build-webkit:
584         * Scripts/copy-webkitlibraries-to-product-directory:
585
586 2014-03-14  Landry Breuil  <landry@openbsd.org>
587
588         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
589         Also allow to set MAKE in the environment.
590         https://bugs.webkit.org/show_bug.cgi?id=129991
591
592         Reviewed by Andreas Kling.
593
594         * Scripts/webkitdirs.pm:
595         (determineArchitecture):
596         (determineNumberOfCPUs):
597         (isBSD):
598         (buildAutotoolsProject):
599         * Scripts/webkitpy/common/system/platforminfo.py:
600         (PlatformInfo.__init__):
601         (PlatformInfo.is_openbsd):
602         (PlatformInfo):
603         (PlatformInfo.is_netbsd):
604         (PlatformInfo._determine_os_name):
605
606 2014-03-14  Dean Jackson  <dino@apple.com>
607
608         Remove libWebKitSystemInterfaceLion.a
609         https://bugs.webkit.org/show_bug.cgi?id=130254
610
611         Reviewed by Geoffrey Garen and Andreas Kling.
612
613         No need to copy the Lion libraries into the build.
614
615         * Scripts/copy-webkitlibraries-to-product-directory:
616
617 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
618
619         [EFL][MiniBrowser] Revise help messages of command line parameters
620         https://bugs.webkit.org/show_bug.cgi?id=130222
621
622         Reviewed by Csaba Osztrogonác.
623
624         Correct the default value description and make help messages to be consistent.
625
626         * MiniBrowser/efl/main.c:
627
628 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
629
630         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
631         https://bugs.webkit.org/show_bug.cgi?id=129612
632
633         Reviewed by Darin Adler.
634
635         For new code use static NeverDestroyed<T> instead.
636
637         * DumpRenderTree/JavaScriptThreading.cpp:
638         (javaScriptThreadsMutex):
639         (javaScriptThreads):
640         * DumpRenderTree/efl/EventSender.cpp:
641         (touchPointList):
642         (delayedEventQueue):
643         * DumpRenderTree/win/FrameLoadDelegate.cpp:
644         (delegatesWithDelayedWork):
645         * Scripts/check-for-exit-time-destructors:
646         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
647         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
648         (testsMap):
649
650 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
651
652         [EFL][WK2] Fix compilation warning in Minibrowser
653         https://bugs.webkit.org/show_bug.cgi?id=130132
654
655         Reviewed by Csaba Osztrogonác.
656
657         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
658
659         * MiniBrowser/efl/main.c:
660         (on_download_request):
661
662 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
663
664         FTL should support IsBlah
665         https://bugs.webkit.org/show_bug.cgi?id=130202
666
667         Reviewed by Geoffrey Garen.
668         
669         Running existing JSRegress tests with noInline gives us coverage for these
670         changes. Chances are, this will also give coverage for other interesting things
671         as well.
672
673         * Scripts/run-jsc-stress-tests:
674
675 2014-03-12  Brian Burg  <bburg@apple.com>
676
677         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
678         https://bugs.webkit.org/show_bug.cgi?id=129744
679
680         Reviewed by Timothy Hatcher.
681
682         * DumpRenderTree/TestRunner.cpp:
683         (evaluateInWebInspectorCallback):
684         * DumpRenderTree/TestRunner.h:
685         * DumpRenderTree/efl/TestRunnerEfl.cpp:
686         (TestRunner::evaluateInWebInspector):
687         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
688         (TestRunner::evaluateInWebInspector):
689         * DumpRenderTree/mac/TestRunnerMac.mm:
690         (TestRunner::evaluateInWebInspector):
691         * DumpRenderTree/win/TestRunnerWin.cpp:
692         (TestRunner::evaluateInWebInspector):
693         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
694         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
695         (WTR::TestRunner::evaluateInWebInspector):
696         * WebKitTestRunner/InjectedBundle/TestRunner.h:
697
698 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
699
700         [GTK] build-webkit shouldn't show error message when ninja isn't installed
701         https://bugs.webkit.org/show_bug.cgi?id=130129
702
703         Reviewed by Csaba Osztrogonác.
704
705         * Scripts/webkitdirs.pm:
706         (canUseNinja): Redirecting stderr to /dev/null
707
708 2014-03-13  Andres Gomez  <agomez@igalia.com>
709
710         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
711         https://bugs.webkit.org/show_bug.cgi?id=130092
712
713         Reviewed by Csaba Osztrogonác.
714
715         Added "python-dev" as dependency for deb based distros. It is
716         already present for rpm based distros. This dependency will allow
717         libxml2 to generate its python bindings, needed by gtk-doc.
718
719         * gtk/install-dependencies:
720
721 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
722
723         Unreviewed. Fix GTK+ cmake build after r165488.
724
725         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
726
727 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
728
729         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
730         https://bugs.webkit.org/show_bug.cgi?id=130014
731
732         Reviewed by Martin Robinson.
733
734         Include cmake or autotools config header.
735
736         * MiniBrowser/gtk/BrowserDownloadsBar.c:
737         * MiniBrowser/gtk/BrowserSearchBar.c:
738         * MiniBrowser/gtk/BrowserWindow.c:
739         * MiniBrowser/gtk/main.c:
740
741 2014-03-12  Commit Queue  <commit-queue@webkit.org>
742
743         Unreviewed, rolling out r165471.
744         https://bugs.webkit.org/show_bug.cgi?id=130139
745
746         Didn't really fix the issue and broke another bot (Requested
747         by mrobinson on #webkit).
748
749         Reverted changeset:
750
751         "[CMake] Newer versions of CMake cannot find older versions of
752         Freetype"
753         https://bugs.webkit.org/show_bug.cgi?id=130107
754         http://trac.webkit.org/changeset/165471
755
756 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
757
758         It should be possible to build WebKit with FTL on iOS
759         https://bugs.webkit.org/show_bug.cgi?id=130116
760
761         Reviewed by Dan Bernstein.
762
763         * Scripts/build-webkit:
764         * Scripts/copy-webkitlibraries-to-product-directory:
765
766 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
767
768         [Win] Remove use of QTSDK
769         https://bugs.webkit.org/show_bug.cgi?id=130049
770
771         Reviewed by Darin Adler.
772
773         * DumpRenderTree/win/DumpRenderTree.cpp:
774         (initialize): Remove QuickTime code.
775         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
776         building QTMovieWin.
777
778 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
779
780         [GTK][CMAKE] Too verbose build output
781         https://bugs.webkit.org/show_bug.cgi?id=130076
782
783         Reviewed by Carlos Garcia Campos.
784
785         Instead of building with cmake --build which isn't smart about pretty printing and
786         colors, we build with a script which calls the proper build command.
787
788         * Scripts/webkitdirs.pm:
789         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
790         the CMake configuration pass.
791
792 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
793
794         [CMake] Newer versions of CMake cannot find older versions of Freetype
795         https://bugs.webkit.org/show_bug.cgi?id=130107
796
797         Reviewed by Gustavo Noronha Silva.
798
799         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
800         to CMake during jhbuild initialization.
801
802 2014-03-12  Zalan Bujtas  <zalan@apple.com>
803
804         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
805         https://bugs.webkit.org/show_bug.cgi?id=129961
806
807         Reviewed by Simon Fraser.
808
809         Now scaled content can go through the window capturing mechanism too for compositing content.
810         AppleMagnifiedMode is redundant.
811
812         * DumpRenderTree/mac/DumpRenderTree.mm:
813         (setDefaultsToConsistentValuesForTesting):
814         (runTest):
815         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
816         (createBitmapContextFromWebView):
817         * WebKitTestRunner/PlatformWebView.h:
818         * WebKitTestRunner/cg/TestInvocationCG.cpp:
819         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
820         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
821         (WTR::PlatformWebView::didInitializeClients):
822         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
823         (WTR::PlatformWebView::forceWindowFramesChanged):
824         * WebKitTestRunner/mac/main.mm:
825         (setDefaultsToConsistentValuesForTesting):
826
827 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
828
829         Unreviewed. Add myself as a committer.
830
831         * Scripts/webkitpy/common/config/contributors.json:
832
833 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
834
835         Unreviewed build fix on the EFL port when used lower version of ATK
836
837         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
838         (WTR::AccessibilityUIElement::y): Fixed typo.
839
840 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
841
842         Some images are blank in the rebaseline server UI
843         https://bugs.webkit.org/show_bug.cgi?id=130104
844
845         Reviewed by Tim Horton.
846
847         Let the server check for images in the 'retries' directory
848         if it can't find an image otherwise.
849
850         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
851         (RebaselineHTTPRequestHandler.test_result):
852
853 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
854
855         [GTK][CMake] --update-gtk has no effect
856         https://bugs.webkit.org/show_bug.cgi?id=130088
857
858         Reviewed by Philippe Normand.
859
860         * Scripts/webkitdirs.pm:
861         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
862         as an argument.
863
864 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
865
866         Add "System Font" to the list of whitelisted DRT fonts
867         https://bugs.webkit.org/show_bug.cgi?id=130046
868
869         Reviewed by Darin Adler.
870
871         * DumpRenderTree/mac/DumpRenderTree.mm:
872         (allowedFontFamilySet):
873         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
874
875 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
876
877         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
878         https://bugs.webkit.org/show_bug.cgi?id=130064
879
880         Reviewed by Philippe Normand.
881
882         * efl/jhbuildrc: Remove duplicated code.
883         * gtk/jhbuildrc: Remove duplicated code.
884         * jhbuild/jhbuildrc_common.py:
885         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
886         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
887         and is apparently necessary for GTK+.
888
889 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
890
891         check-webkit-style failed to complain about missing braces
892         https://bugs.webkit.org/show_bug.cgi?id=34189
893
894         Reviewed by Ryosuke Niwa.
895
896         * Scripts/webkitpy/style/checkers/cpp.py:
897         (check_braces):
898         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
899         (WebKitStyleTest.test_braces):
900
901 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
902
903         Remove Qt cruft from style checker.
904         https://bugs.webkit.org/show_bug.cgi?id=130085
905
906         Reviewed by Csaba Osztrogonác.
907
908         There is no 'foreach' keyword in c++. That was a Qt feature
909         added in: http://trac.webkit.org/changeset/46113
910         Qt was removed from WebKit, so we should remove the checks
911         of this keyword from check-webkit-style scripts.
912
913         * Scripts/webkitpy/style/checkers/cpp.py:
914         (check_spacing_for_function_call):
915         (check_spacing):
916         (check_braces):
917         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
918         (CppStyleTest.test_mismatching_spaces_in_parens):
919         (CppStyleTest.test_spacing_for_fncall):
920         (WebKitStyleTest.test_braces):
921
922 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
923
924         [GTK] update-webkitgtk-libs needs itstool
925         https://bugs.webkit.org/show_bug.cgi?id=130082
926
927         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
928         itstool is a dependency of building gtk-doc from version 1.19, so it should
929         be added to Tools/gtk/install-dependencies script, too.
930
931         Reviewed by Philippe Normand.
932
933         * gtk/install-dependencies:
934
935 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
936
937         webkitbot rollout ChangeLogs should be nicer
938         https://bugs.webkit.org/show_bug.cgi?id=122654
939
940         Reviewed by Csaba Osztrogonác.
941
942         Added bug urls and descriptions of rolled out patches to the rollout changelog
943         if they are present in the original changelog. Additionally removed the list of
944         changed files and functions.
945
946         * Scripts/webkitpy/common/checkout/changelog.py:
947         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
948         * Scripts/webkitpy/common/checkout/checkout.py:
949         (Checkout._changelog_data_for_revision): Store bug description.
950         * Scripts/webkitpy/common/checkout/checkout_mock.py:
951         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
952         (CheckoutTest.test_commit_info_for_revision):
953         * Scripts/webkitpy/common/checkout/commitinfo.py:
954         (CommitInfo.bug_description): Added.
955         (CommitInfo.to_json):
956         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
957         (CommitInfoTest.test_commit_info_creation):
958         * Scripts/webkitpy/tool/commands/download.py:
959         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
960         out patches for creating rollout changelog.
961         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
962         caused the regression is stored in state["bug_blocked"] now.
963         * Scripts/webkitpy/tool/commands/download_unittest.py:
964         (test_prepare_rollout):
965         (test_create_rollout_multiple_revision):
966         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
967         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
968         rolled out patches to the changelog.
969         (PrepareChangeLogForRevert.run):
970         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
971         (UpdateChangeLogsForRevertTest):
972         (test_message_for_revert):
973         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
974         (ReopenBugAfterRollout.run):
975
976 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
977
978         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
979         https://bugs.webkit.org/show_bug.cgi?id=130021
980
981         Reviewed by Mario Sanchez Prada.
982
983         Replace deprecated functions to use new API from ATK 2.11.90.
984
985         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
986         (AccessibilityUIElement::x):
987         (AccessibilityUIElement::y):
988         (AccessibilityUIElement::width):
989         (AccessibilityUIElement::height):
990         (AccessibilityUIElement::clickPointX):
991         (AccessibilityUIElement::clickPointY):
992         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
993         (WTR::AccessibilityUIElement::x):
994         (WTR::AccessibilityUIElement::y):
995         (WTR::AccessibilityUIElement::width):
996         (WTR::AccessibilityUIElement::height):
997         (WTR::AccessibilityUIElement::clickPointX):
998         (WTR::AccessibilityUIElement::clickPointY):
999
1000 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1001
1002         [ATK] Expose aria-posinset and aria-setsize through object attributes
1003         https://bugs.webkit.org/show_bug.cgi?id=130011
1004
1005         Reviewed by Chris Fleizach.
1006
1007         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1008
1009         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1010         (AccessibilityUIElement::numberAttributeValue):
1011         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1012         (WTR::AccessibilityUIElement::numberAttributeValue):
1013
1014 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1015
1016         [Win] Unreviewed build fix.
1017
1018         Some bad Windows code was committed at some point that prevents the Apple Windows port
1019         from finding its runtime dependencies reliably.
1020
1021         * win/DLLLauncher/DLLLauncherMain.cpp:
1022         (appleApplicationSupportDirectory): Restored this function.
1023         (modifyPath): Update to use appleApplicationSupportDirectory function.
1024
1025 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1026
1027         Let the user define the full address of the performance-site-server for uploading results
1028         https://bugs.webkit.org/show_bug.cgi?id=129819
1029
1030         Reviewed by Ryosuke Niwa.
1031
1032         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1033         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1034         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1035         protocol for now, in order to avoid breaking the perf bots.
1036
1037         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1038         (_upload_json):
1039         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1040         (MainTest.test_upload_json):
1041
1042 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1043
1044         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1045         https://bugs.webkit.org/show_bug.cgi?id=130023
1046
1047         Reviewed by Dean Jackson.
1048
1049         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1050         /SAFESEH flag to DLL launcher process.
1051
1052 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1053
1054         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1055         https://bugs.webkit.org/show_bug.cgi?id=129980
1056
1057         Reviewed by Carlos Garcia Campos.
1058
1059         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1060
1061 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1062
1063         [GTK] Remove the WebView source-mode WebKit1 test
1064         https://bugs.webkit.org/show_bug.cgi?id=129976
1065
1066         Reviewed by Carlos Garcia Campos.
1067
1068         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1069
1070 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1071
1072         Unreviewed build fix for GTKbuild after the switch to CMake
1073
1074         * gtk/common.py:
1075         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1076         test-only bot doesn't have any build files.
1077
1078 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1079
1080         [GTK] built-product-archive does not handle GTK+ CMake build
1081         https://bugs.webkit.org/show_bug.cgi?id=129941
1082
1083         * BuildSlaveSupport/built-product-archive:
1084         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1085         the CMake build.
1086
1087 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1088
1089         [GTK] Include CMake into install-dependencies script
1090         https://bugs.webkit.org/show_bug.cgi?id=129909
1091
1092         Reviewed by Martin Robinson.
1093
1094         As since r165267 buid-webkit uses CMake by default, the dependency
1095         with 'cmake' package should be introduced.
1096
1097         * gtk/install-dependencies: Ditto.
1098
1099 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1100
1101         REGRESSION(165267): Broke a webkitpy unit tests
1102         https://bugs.webkit.org/show_bug.cgi?id=129904
1103
1104         Reviewed by Jon Honeycutt.
1105
1106         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1107         (GtkPort._is_cmake_build):
1108
1109 2014-03-07  Andres Gomez  <agomez@igalia.com>
1110
1111         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1112         https://bugs.webkit.org/show_bug.cgi?id=129893
1113
1114         Reviewed by Martin Robinson.
1115
1116         Added "git-svn" as dependency for deb based distros and,
1117         additionally, "subversion" for rpm based distros.
1118
1119         * gtk/install-dependencies:
1120
1121 2014-03-07  Roger Fong  <roger_fong@apple.com>
1122
1123         Remove dummy setSystemWebGLLoadPolicy client method.
1124         https://bugs.webkit.org/show_bug.cgi?id=129873.
1125
1126         Reviewed by Dean Jackson.
1127
1128         * WebKitTestRunner/TestController.cpp:
1129         (WTR::TestController::createWebViewWithOptions):
1130
1131 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1132
1133         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1134         https://bugs.webkit.org/show_bug.cgi?id=129886
1135
1136         Reviewed by Mark Lam.
1137
1138         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1139         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1140         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1141         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1142         make it through when in non-verbose mode.
1143
1144 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1145
1146         [GTK] buid-webkit should use CMake by default
1147         https://bugs.webkit.org/show_bug.cgi?id=129855
1148
1149         Reviewed by Carlos Garcia Campos.
1150
1151         Make the CMake build the default GTK+ build when using build-webkit. This will
1152         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1153         so that we have --gtk and --gtkautotools.
1154
1155         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1156         * Scripts/webkitpy/port/gtk.py: Ditto.
1157
1158 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1159
1160         [CMake] [GTK] Build with ninja when it is available
1161         https://bugs.webkit.org/show_bug.cgi?id=129805
1162
1163         Reviewed by Philippe Normand.
1164
1165         * Scripts/webkitdirs.pm:
1166         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1167         if it's available on the system.
1168         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1169         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1170
1171 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1172
1173         If the FTL is build-time enabled then it should be run-time enabled.
1174
1175         Rubber stamped by Geoffrey Garen.
1176
1177         * Scripts/run-jsc-stress-tests:
1178
1179 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1180
1181         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1182         https://bugs.webkit.org/show_bug.cgi?id=129837
1183
1184         Reviewed by Michael Saboff.
1185
1186         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1187         The fix is to use find instead of ls like we do in shell-runner.sh.
1188
1189         * Scripts/run-jsc-stress-tests:
1190
1191 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1192
1193         filter-build-webkit should not strip .o
1194         https://bugs.webkit.org/show_bug.cgi?id=129614
1195
1196         Reviewed by Dean Jackson.
1197
1198         This makes it much easier to jump from the failing output at
1199         the end back up to the compile errors earlier in the output.
1200
1201         * Scripts/filter-build-webkit:
1202
1203 2014-03-06  Anders Carlsson  <andersca@apple.com>
1204
1205         Build WebKit2 before building WebKit
1206         https://bugs.webkit.org/show_bug.cgi?id=129831
1207         <rdar://problem/15920020>
1208
1209         Reviewed by Dan Bernstein.
1210
1211         * Scripts/build-webkit:
1212         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1213
1214 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1215
1216         make-3.82 fails to build on ARM/Linux
1217         https://bugs.webkit.org/show_bug.cgi?id=107926
1218
1219         Reviewed by Martin Robinson.
1220
1221         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1222         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1223         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1224         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1225
1226         * gtk/patches/make-3.82-arg-list-length.patch:
1227
1228 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1229
1230         [GTK] Close the page when the view is disposed instead of when finalized
1231         https://bugs.webkit.org/show_bug.cgi?id=129783
1232
1233         Reviewed by Sergio Villar Senin.
1234
1235         Add test case but disabled for now because it's affetected by bug #129684.
1236
1237         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1238         (testProcessPerWebView):
1239
1240 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1241
1242         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1243         https://bugs.webkit.org/show_bug.cgi?id=129738
1244
1245         Reviewed by Sergio Villar Senin.
1246
1247         The problem is that we are calling g_object_unref() for the
1248         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1249         view only increases the reference counter when the settings is not
1250         the same it currently has. We should release our reference once.
1251
1252         * MiniBrowser/gtk/main.c:
1253         (createBrowserWindow):
1254         (main):
1255
1256 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1257
1258         [GTK][CMake] Tarball is created with wrong tarball paths
1259         https://bugs.webkit.org/show_bug.cgi?id=129496
1260
1261         Reviewed by Daniel Bates.
1262
1263         * gtk/make-dist.py:
1264         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1265         landing the original patch with some suggestions from the reviewer. With the
1266         checks corrected, the tarball path is constructed properly.
1267
1268 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1269
1270         Unreviewed. Update my email in contributors.json
1271
1272         * Scripts/webkitpy/common/config/contributors.json:
1273
1274 2014-03-05  Dean Jackson  <dino@apple.com>
1275
1276         [WebGL] Use WKSI to see what the system policy for WebGL is
1277         https://bugs.webkit.org/show_bug.cgi?id=129722
1278         <rdar://problem/15790542>
1279
1280         Reviewed by Tim Horton.
1281
1282         Dummy entry for setSystemWebGLLoadPolicy.
1283
1284         * WebKitTestRunner/TestController.cpp:
1285         (WTR::TestController::createWebViewWithOptions):
1286
1287 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1288
1289         [GTK][CMake] Generate documentation for the DOM bindings
1290         https://bugs.webkit.org/show_bug.cgi?id=126211
1291
1292         Reviewed by Carlos Garcia Campos.
1293
1294         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1295         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1296         * gtk/generate-webkitdom-doc-files: Removed.
1297         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1298         that it can be called by generate-gtkdoc.
1299
1300 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1301
1302         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1303         https://bugs.webkit.org/show_bug.cgi?id=129380
1304
1305         Reviewed by Philippe Normand.
1306
1307         * Scripts/webkitdirs.pm:
1308         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1309         skipping CMake execution.
1310
1311 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1312
1313         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1314         https://bugs.webkit.org/show_bug.cgi?id=129651
1315
1316         Reviewed by Philippe Normand.
1317
1318         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1319
1320 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1321
1322         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1323         https://bugs.webkit.org/show_bug.cgi?id=129637
1324
1325         Reviewed by Carlos Garcia Campos.
1326
1327         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1328         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1329         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1330         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1331         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1332         (TestFactory.__init__): Add the test for GTK+.
1333         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1334
1335 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1336
1337         [ATK] Expose missing functionalities of AtkTableCell to AT
1338         https://bugs.webkit.org/show_bug.cgi?id=129492
1339
1340         Reviewed by Mario Sanchez Prada.
1341
1342         Reducing some code by using new API of AtkTableCell.
1343
1344         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1345         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1346
1347 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1348
1349         Preparing to run layout tests on Wincairo.
1350         https://bugs.webkit.org/show_bug.cgi?id=129709
1351
1352         Reviewed by Brent Fulgham.
1353
1354         * Scripts/webkitdirs.pm:
1355         (setPathForRunningWebKitApp):
1356         Add GStreamer directory for WinCairo running layout tests.
1357         * win/DLLLauncher/DLLLauncherMain.cpp:
1358         (modifyPath):
1359         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1360
1361 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1362
1363         [GTK] Simplify the GObject DOM bindings API break check into one step
1364         https://bugs.webkit.org/show_bug.cgi?id=129571
1365
1366         Reviewed by Carlos Garcia Campos.
1367
1368         * GNUmakefile.am: Add the API break check to 'make check.'
1369         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1370         * gtk/check-gdom-symbols: Removed.
1371         * gtk/webkitdom.py: Added.
1372         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1373         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1374
1375 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1376
1377         Add Jeremy Jones to the contributors list as a contributor.
1378
1379         * Scripts/webkitpy/common/config/contributors.json:
1380
1381 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1382
1383         Unreviewed. Update contact email.
1384         https://bugs.webkit.org/show_bug.cgi?id=129610
1385
1386         * Scripts/webkitpy/common/config/contributors.json:
1387
1388 2014-03-02  Brian Burg  <bburg@apple.com>
1389
1390         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1391         https://bugs.webkit.org/show_bug.cgi?id=129460
1392
1393         Reviewed by Dan Bernstein.
1394
1395         Don't unconditionally open the inspector before running an inspector test.
1396         Instead, the test should request that the inspector open when it's ready.
1397
1398         This change was lost during a rebase, but is the same change made to
1399         DumpRenderTree.
1400
1401         * WebKitTestRunner/TestInvocation.cpp:
1402         (WTR::TestInvocation::invoke): 
1403
1404 2014-03-02  Darin Adler  <darin@apple.com>
1405
1406         Split TextIteratorBehavior into a separate header
1407         https://bugs.webkit.org/show_bug.cgi?id=129578
1408
1409         Reviewed by Sam Weinig.
1410
1411         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1412         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1413         task easy, but the remove is still a bit of a pain.
1414
1415 2014-03-02  Darin Adler  <darin@apple.com>
1416
1417         Sort Mac platform export files so they merge better
1418         https://bugs.webkit.org/show_bug.cgi?id=129581
1419
1420         Reviewed by Sam Weinig.
1421
1422         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1423         Mac export files in a "canonical" order for this project.
1424
1425 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1426
1427         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1428         https://bugs.webkit.org/show_bug.cgi?id=129438
1429
1430         Reviewed by Simon Fraser.
1431
1432         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1433         offscreen window. It makes testing subpixel rendering and positioning possible.
1434
1435         Both the offscreen window's and WebKit's scaling are set accordingly.
1436
1437         * DumpRenderTree/mac/DumpRenderTree.mm:
1438         (createWebViewAndOffscreenWindow): cleanup
1439         (destroyWebViewAndOffscreenWindow): cleanup
1440         (dumpRenderTree):
1441         (changeWindowScaleIfNeeded):
1442         (runTest):
1443         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1444         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1445         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1446         * WebKitTestRunner/PlatformWebView.h:
1447         * WebKitTestRunner/TestInvocation.cpp:
1448         (WTR::changeWindowScaleIfNeeded):
1449         (WTR::TestInvocation::invoke):
1450         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1451         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1452         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1453         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1454         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1455         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1456         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1457         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1458
1459 2014-02-28  Anders Carlsson  <andersca@apple.com>
1460
1461         Remove logging.
1462
1463         Reviewed by Dan Bernstein.
1464
1465         * MiniBrowser/mac/WK2BrowserWindowController.m:
1466         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1467
1468 2014-02-28  Daniel Bates  <dabates@apple.com>
1469
1470         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1471         https://bugs.webkit.org/show_bug.cgi?id=129163
1472
1473         Reviewed by David Kilzer.
1474
1475         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1476         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1477         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1478         bundle.
1479
1480         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1481         which is specified either explicitly when building with MAKE(1) or implicitly by
1482         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1483         the OS X SDK and toolchain since the built products are only applicable to OS X.
1484
1485         * DumpRenderTree/ios/PerlSupport/Makefile:
1486
1487 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1488
1489         Unreviewed, rolling out r164859.
1490         http://trac.webkit.org/changeset/164859
1491         https://bugs.webkit.org/show_bug.cgi?id=129483
1492
1493         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1494         #webkit).
1495
1496         * DumpRenderTree/mac/DumpRenderTree.mm:
1497         (createWebViewAndOffscreenWindow):
1498         (dumpRenderTree):
1499         (runTest):
1500         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1501         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1502         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1503         * WebKitTestRunner/PlatformWebView.h:
1504         * WebKitTestRunner/TestInvocation.cpp:
1505         (WTR::TestInvocation::invoke):
1506         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1507         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1508         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1509         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1510         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1511
1512 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1513
1514         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1515         https://bugs.webkit.org/show_bug.cgi?id=129438
1516
1517         Reviewed by Simon Fraser.
1518
1519         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1520         offscreen window. It makes testing subpixel rendering and positioning possible.
1521
1522         Both the offscreen window's and WebKit's scaling are set accordingly.
1523
1524         * DumpRenderTree/mac/DumpRenderTree.mm:
1525         (createWebViewAndOffscreenWindow): unrelated cleanup.
1526         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1527         (dumpRenderTree):
1528         (changeOffscreenWindowScaleIfNeeded):
1529         (runTest):
1530         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1531         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1532         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1533         * WebKitTestRunner/PlatformWebView.h:
1534         * WebKitTestRunner/TestInvocation.cpp:
1535         (WTR::changeOffscreenWindowScaleIfNeeded):
1536         (WTR::TestInvocation::invoke):
1537         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1538         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1539
1540 2014-02-27  Brian Burg  <bburg@apple.com>
1541
1542         Web Inspector: model tests should use a special Test.html inspector page
1543         https://bugs.webkit.org/show_bug.cgi?id=129190
1544
1545         Reviewed by Timothy Hatcher.
1546
1547         Remove code that immediately opens the Web Inspector based on the file path of the test.
1548         Instead, the test page should request that the inspector open inside its `test()` method.
1549
1550         This change is necessary because otherwise, the inspector would be opened too early for
1551         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1552         will get loaded instead of the minimal test page.
1553
1554         * DumpRenderTree/efl/DumpRenderTree.cpp:
1555         (createTestRunner):
1556         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1557         (runTest):
1558         * DumpRenderTree/mac/DumpRenderTree.mm:
1559         (runTest):
1560         * DumpRenderTree/win/DumpRenderTree.cpp:
1561         (runTest):
1562
1563 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1564
1565         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1566         https://bugs.webkit.org/show_bug.cgi?id=127076
1567
1568         Reviewed by Anders Carlsson.
1569
1570         Avoid match for :: as start of a member initialization list. Modify expression to match
1571         after a colon either non-colon character or end of line.
1572
1573         * Scripts/webkitpy/style/checkers/cpp.py:
1574         (check_member_initialization_list):
1575         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1576         (WebKitStyleTest.test_member_initialization_list):
1577
1578 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1579
1580         Unreviewed. Update my email addresses in contributors.json.
1581
1582         * Scripts/webkitpy/common/config/contributors.json:
1583
1584 2014-02-27  Alberto Garcia  <berto@igalia.com>
1585
1586         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1587         https://bugs.webkit.org/show_bug.cgi?id=128927
1588
1589         Reviewed by Philippe Normand.
1590
1591         Encode manually the data for sys.{stdout,stderr}.write.
1592
1593         * gtk/gtkdoc.py:
1594         (GTKDoc._run_command):
1595
1596 2014-02-27  Andres Gomez  <agomez@igalia.com>
1597
1598         Unreviewed. Add myself to watchlists
1599
1600         * Scripts/webkitpy/common/config/watchlist: Add myself to
1601         watchlists.
1602
1603 2014-02-27  Andres Gomez  <agomez@igalia.com>
1604
1605         Unreviewed, rolling out r164790.
1606         http://trac.webkit.org/changeset/164790
1607
1608         Revert r164790 because of erroneous commit log
1609
1610         * Scripts/webkitpy/common/config/watchlist:
1611
1612 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1613
1614         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1615         https://bugs.webkit.org/show_bug.cgi?id=129250
1616
1617         Reviewed by Mario Sanchez Prada.
1618
1619         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1620         Implementing methods so that we could test column/row headers represented as an array of cells.
1621
1622         * DumpRenderTree/AccessibilityUIElement.cpp:
1623         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1624         (AccessibilityUIElement::columnHeaders):
1625         (AccessibilityUIElement::rowHeaders):
1626         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1627         (AccessibilityUIElement::columnHeaders):
1628         (AccessibilityUIElement::rowHeaders):
1629         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1630         (WTR::AccessibilityUIElement::rowHeaders):
1631         (WTR::AccessibilityUIElement::columnHeaders):
1632         * efl/jhbuild.modules:
1633         * gtk/jhbuild.modules:
1634
1635 2014-02-27  Andres Gomez  <agomez@igalia.com>
1636
1637         Unreviewed. Add myself to watchlists
1638
1639         * Scripts/webkitpy/common/config/watchlist: Add myself to
1640         watchlists.
1641
1642 2014-02-27  Andres Gomez  <agomez@igalia.com>
1643
1644         Unreviewed. Add myself as a committer.
1645
1646         * Scripts/webkitpy/common/config/contributors.json:
1647
1648 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1649
1650         Unreviewed. Add Víctor Jáquez and myself to watchlists
1651
1652         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1653         myself to watchlists.
1654
1655 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1656
1657         Unreviewed. Add myself as a committer.
1658
1659         * Scripts/webkitpy/common/config/contributors.json:
1660
1661 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1662
1663         Unreviewed. Moved myself to the list of committers.
1664
1665         * Scripts/webkitpy/common/config/contributors.json:
1666
1667 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1668
1669         [GTK] Reduplicate common.top_level_path in scripts
1670         https://bugs.webkit.org/show_bug.cgi?id=129291
1671
1672         Reviewed by Philippe Normand.
1673
1674         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1675         path manipulation and weird dependencies on the jhbuild infrastructure.
1676
1677         * Scripts/run-gtk-tests: Use common again.
1678         (TestRunner._setup_testing_environment): Ditto.
1679         * gtk/check-gdom-symbols: Ditto.
1680         * gtk/common.py:
1681         (top_level_path): Re-add top_level_path..
1682         (get_build_path): Use the builtin top_level_path again.
1683         * gtk/find-make-dist-errors: Use common again.
1684         (get_missing_headers): Ditto.
1685         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1686
1687 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1688
1689         runscript: line 42: /bin/ls: Argument list too long
1690         https://bugs.webkit.org/show_bug.cgi?id=129376
1691
1692         Reviewed by Michael Saboff.
1693
1694         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1695         We should use find instead, which generates the list of files rather than expanding them all on 
1696         the command line and spitting them back out.
1697
1698         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1699
1700 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1701
1702         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1703         https://bugs.webkit.org/show_bug.cgi?id=129377
1704
1705         Reviewed by Csaba Osztrogonác.
1706
1707         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1708
1709 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1710
1711         [GTK] Re-enable gtk-doc in EWS
1712         https://bugs.webkit.org/show_bug.cgi?id=128369
1713
1714         Reviewed by Carlos Garcia Campos.
1715
1716         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1717
1718         * Scripts/webkitpy/common/config/ports.py:
1719         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1720         (GtkWK2Port.build_webkit_command): Ditto.
1721         * Scripts/webkitpy/common/config/ports_unittest.py:
1722         (DeprecatedPortTest.test_gtk_port): Ditto.
1723         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1724
1725 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1726
1727         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1728         https://bugs.webkit.org/show_bug.cgi?id=129319
1729
1730         Reviewed by Carlos Garcia Campos.
1731
1732         * gtk/generate-gtkdoc:
1733         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1734
1735 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1736
1737         Unreviewed. Add myself as a committer.
1738
1739         * Scripts/webkitpy/common/config/contributors.json:
1740
1741 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1742
1743         [CSS Grid Layout] Add ENABLE flag
1744         https://bugs.webkit.org/show_bug.cgi?id=129153
1745
1746         Reviewed by Simon Fraser.
1747
1748         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1749         all ports for developer builds.
1750
1751         * Scripts/webkitperl/FeatureList.pm:
1752
1753 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1754
1755         Added myself as a committer.
1756
1757         Unreviewed.
1758
1759         * Scripts/webkitpy/common/config/contributors.json:
1760
1761 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1762
1763         Unreviewed. Moved myself to the list of committers.
1764
1765         * Scripts/webkitpy/common/config/contributors.json:
1766
1767 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1768
1769         Move myself to the committers list.
1770
1771         Unreviewed.
1772
1773         * Scripts/webkitpy/common/config/contributors.json:
1774
1775 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
1776
1777         Unreviewed. Add myself as a committer.
1778
1779         * Scripts/webkitpy/common/config/contributors.json:
1780
1781 2014-02-25  Commit Queue  <commit-queue@webkit.org>
1782
1783         Unreviewed, rolling out r164639.
1784         http://trac.webkit.org/changeset/164639
1785         https://bugs.webkit.org/show_bug.cgi?id=129302
1786
1787         gtk-doc still have problems in EWS (Requested by rego on
1788         #webkit).
1789
1790         * Scripts/webkitpy/common/config/ports.py:
1791         (GtkPort.build_webkit_command):
1792         (GtkWK2Port.build_webkit_command):
1793         * Scripts/webkitpy/common/config/ports_unittest.py:
1794         (DeprecatedPortTest.test_gtk_port):
1795         (DeprecatedPortTest.test_gtk_wk2_port):
1796
1797 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
1798
1799         [GTK] Re-enable gtk-doc in EWS
1800         https://bugs.webkit.org/show_bug.cgi?id=128369
1801
1802         Reviewed by Carlos Garcia Campos.
1803
1804         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1805
1806         * Scripts/webkitpy/common/config/ports.py:
1807         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1808         (GtkWK2Port.build_webkit_command): Ditto.
1809         * Scripts/webkitpy/common/config/ports_unittest.py:
1810         (DeprecatedPortTest.test_gtk_port): Ditto.
1811         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1812
1813 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1814
1815         [GTK] Mark view source mode methods as deprecated
1816         https://bugs.webkit.org/show_bug.cgi?id=128920
1817
1818         Reviewed by Martin Robinson.
1819
1820         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1821         (beforeAll): Remove view mode test.
1822
1823 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1824
1825         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
1826         https://bugs.webkit.org/show_bug.cgi?id=128417
1827
1828         Reviewed by Carlos Garcia Campos.
1829
1830         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
1831         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
1832         a makefile. This allows accepting a header list from the build system, which can be used
1833         to dynamically build a list of ignored files. We can ignore any source file that doesn't
1834         have a corresponding header file on the header list. 
1835         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
1836         source directories to gtkdoc-scan.
1837
1838 2014-02-24  Anders Carlsson  <andersca@apple.com>
1839
1840         Add a DefaultVisitedLinkProvider and route visited link actions through it
1841         https://bugs.webkit.org/show_bug.cgi?id=129285
1842
1843         Reviewed by Dan Bernstein.
1844
1845         * MiniBrowser/mac/AppDelegate.m:
1846         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1847         Set a shared history so we'll get visited link tracking.
1848
1849         * MiniBrowser/mac/WK1BrowserWindowController.m:
1850         (-[WK1BrowserWindowController awakeFromNib]):
1851         Set a group name.
1852
1853 2014-02-24  Dan Bernstein  <mitz@apple.com>
1854
1855         iOS build fix after r164577.
1856
1857         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1858         (AccessibilityUIElement::selectedChildrenCount):
1859         (AccessibilityUIElement::selectedChildAtIndex):
1860
1861 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1862
1863         [ASan] Remove methods from ignore list that no longer cause crashes
1864         <http://webkit.org/b/129257>
1865
1866         Reviewed by Anders Carlsson.
1867
1868         * asan/webkit-asan-ignore.txt: Remove old methods.
1869
1870 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1871
1872         Extract common parts from jhbuildrc files.
1873         https://bugs.webkit.org/show_bug.cgi?id=125986
1874
1875         Reviewed by Csaba Osztrogonác.
1876
1877         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
1878
1879         * Scripts/run-gtk-tests:
1880         (TestRunner._setup_testing_environment):
1881         * efl/common.py: Removed.
1882         * efl/jhbuildrc:
1883         * gtk/check-gdom-symbols:
1884         * gtk/common.py:
1885         (binary_build_path):
1886         (get_build_path):
1887         * gtk/find-make-dist-errors:
1888         (get_missing_headers):
1889         * gtk/generate-gtkdoc:
1890         (get_webkit2_options):
1891         (get_webkit1_options.src_path):
1892         (get_webkit1_options):
1893         (get_webkitdom_options.src_path):
1894         (get_webkitdom_options):
1895         * gtk/generate-inspector-gresource-manifest.py:
1896         * gtk/jhbuildrc:
1897         * jhbuild/jhbuildrc_common.py: Added.
1898         (script_path):
1899         (top_level_path):
1900         (init):
1901
1902 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
1903
1904         Unreviewed. Fix code indentation and spacing.
1905
1906         * Scripts/webkitpy/style/checkers/js.py:
1907         (SingleQuoteChecker.check):
1908
1909 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
1910
1911         [ATK] Wrong selected element at a given index in a list box.
1912         https://bugs.webkit.org/show_bug.cgi?id=129039
1913
1914         Reviewed by Chris Fleizach.
1915
1916         Added missing implementation and proposed some new function for testing selection
1917         in a list boxes.
1918
1919         * DumpRenderTree/AccessibilityUIElement.cpp:
1920         (setSelectedChildAtIndexCallback):
1921         (removeSelectionAtIndexCallback):
1922         (AccessibilityUIElement::getJSClass):
1923         * DumpRenderTree/AccessibilityUIElement.h:
1924         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1925         (AccessibilityUIElement::selectedChildrenCount):
1926         (AccessibilityUIElement::selectedChildAtIndex):
1927         (AccessibilityUIElement::setSelectedChildAtIndex):
1928         (AccessibilityUIElement::removeSelectionAtIndex):
1929         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1930         (AccessibilityUIElement::selectedChildrenCount):
1931         (AccessibilityUIElement::selectedChildAtIndex):
1932         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1933         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1934         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1935         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1936         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1937         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1938         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1939         (WTR::AccessibilityUIElement::selectedChildrenCount):
1940         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
1941         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
1942
1943 2014-02-23  Diego Pino García  <dpino@igalia.com>
1944
1945         [GTK] Fix build after Web Inspector code reorganization (r164543)
1946         https://bugs.webkit.org/show_bug.cgi?id=129231
1947
1948         Reviewed by Dean Jackson.
1949
1950         * gtk/generate-inspector-gresource-manifest.py:
1951         Modify paths to Web Inspector code.
1952
1953 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1954
1955         [GTK] generate-gtkdoc should use argparse
1956         https://bugs.webkit.org/show_bug.cgi?id=128418
1957
1958         Reviewed by Carlos Garcia Campos.
1959
1960         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
1961         to all functions, and guard the main routine with a __name__ == __main__ check.
1962
1963 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
1964
1965         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
1966         https://bugs.webkit.org/show_bug.cgi?id=129191
1967
1968         Reviewed by Anders Carlsson.
1969
1970         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
1971         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
1972         name of the directory is "lib" and not "libs". Instead we should use the CMake
1973         variable specifically assigned to this task.
1974
1975 2014-02-23  David Kilzer  <ddkilzer@apple.com>
1976
1977         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
1978         <http://webkit.org/b/129209>
1979
1980         Reviewed by Geoffrey Garen.
1981
1982         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
1983         ignore list to make ASan builds usable again.  Follow-up
1984         investigation is tracked by <rdar://problem/16055903>.
1985
1986 2014-02-20  David Farler  <dfarler@apple.com>
1987
1988         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
1989         https://bugs.webkit.org/show_bug.cgi?id=128622
1990
1991         Reviewed by Simon Fraser.
1992
1993         With this change, we now have layout tests running in both DumpRenderTree
1994         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
1995         simulator.
1996
1997         * Scripts/old-run-webkit-tests:
1998         In general, make any specific reference to DumpRenderTree
1999         able to refer to WebKitTestRunner wherever possible:
2000         - Rename functions to remove DRT-specific naming.
2001         - Name FIFOs after the tool that is being used.
2002         -- Clean up FIFO creation code
2003         Other necessary changes:
2004         - Allow use of an ios-sim-wk2 platform.
2005         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2006         * WebKitTestRunner/TestController.cpp:
2007         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2008         (WTR::TestController::TestController):
2009         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2010         Copy the injected bundle into the app bundle.
2011
2012 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2013
2014         run-webkit-httpd fails to find httpd configuation file.
2015
2016         Reviewed by Ryosuke Niwa.
2017
2018         * Scripts/webkitperl/httpd.pm:
2019         (getHTTPDConfigPathForTestDirectory):
2020
2021 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2022
2023         Fix TimeRanges layering violations
2024         https://bugs.webkit.org/show_bug.cgi?id=128717
2025
2026         Reviewed by Jer Noble.
2027
2028         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2029         (TestWebKitAPI::TEST):
2030
2031 2014-02-21  Diego Pino García  <dpino@igalia.com>
2032
2033         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2034         https://bugs.webkit.org/show_bug.cgi?id=128422
2035
2036         Reviewed by Joseph Pecoraro.
2037
2038         * Scripts/webkitpy/style/checkers/js.py:
2039         (JSChecker.__init__):
2040         (JSChecker.check):
2041         (SingleQuoteChecker):
2042         (SingleQuoteChecker.__init__):
2043         (SingleQuoteChecker.check):
2044         * Scripts/webkitpy/style/checkers/js_unittest.py:
2045         (JSTestCase.assertError.error_for_test):
2046         (JSTestCase.assertError):
2047         (JSTestCase.test_no_error):
2048         (JSTestCase.test_error):
2049
2050 == Rolled over to ChangeLog-2014-02-20 ==