[MSE][GStreamer] Introduce AbortableTaskQueue
[WebKit-https.git] / Tools / ChangeLog
1 2018-11-12  Alicia Boya García  <aboya@igalia.com>
2
3         [MSE][GStreamer] Introduce AbortableTaskQueue
4         https://bugs.webkit.org/show_bug.cgi?id=190902
5
6         Reviewed by Xabier Rodriguez-Calvar.
7
8         Tests for AbortableTaskQueue are included.
9
10         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
11         * TestWebKitAPI/PlatformGTK.cmake:
12         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp: Added.
13         (TestWebKitAPI::TEST):
14         (TestWebKitAPI::FancyResponse::FancyResponse):
15         (TestWebKitAPI::FancyResponse::operator=):
16         (TestWebKitAPI::DeterministicScheduler::DeterministicScheduler):
17         (TestWebKitAPI::DeterministicScheduler::ThreadContext::ThreadContext):
18         (TestWebKitAPI::DeterministicScheduler::ThreadContext::waitMyTurn):
19         (TestWebKitAPI::DeterministicScheduler::ThreadContext::yieldToThread):
20
21 2018-11-11  Fujii Hironori  <Hironori.Fujii@sony.com>
22
23         run-bindings-tests is timing out in some WinCairo bots
24         https://bugs.webkit.org/show_bug.cgi?id=191348
25
26         Reviewed by Alex Christensen.
27
28         BuildBot kills run-bindings-tests if it outputs nothing for 20
29         minutes. run-bindings-tests runs very slowly in WinCairo Docker,
30         and it takes more than 30 minutes to finish. And, Windows Python
31         buffers the progress output.
32
33         * Scripts/webkitpy/bindings/main.py:
34         (BindingsTests.detect_changes): Call sys.stdout.flush() after the
35         test case result is output.
36
37 2018-11-11  Wenson Hsieh  <wenson_hsieh@apple.com>
38
39         Implement a new edit command to change the enclosing list type
40         https://bugs.webkit.org/show_bug.cgi?id=191487
41         <rdar://problem/45955922>
42
43         Reviewed by Ryosuke Niwa.
44
45         Add a new API test to verify that `-[WKWebView _changeListType:]` is hooked up to the corresponding editing
46         command in WebCore. See the new layout test for a test that exercises more nuanced corner cases.
47
48         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
49         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
50         (-[TestWKWebView setPosition:offset:]):
51         (-[TestWKWebView setBase:baseOffset:extent:extentOffset:]):
52         (TestWebKitAPI::webViewForEditActionTestingWithPageNamed):
53         (TestWebKitAPI::TEST):
54         * TestWebKitAPI/Tests/WebKitCocoa/editable-nested-lists.html: Added.
55
56 2018-11-11  Dan Bernstein  <mitz@apple.com>
57
58         ProcessPoolConfiguration::copy() doesn’t copy m_customWebContentServiceBundleIdentifier
59         https://bugs.webkit.org/show_bug.cgi?id=191514
60
61         Reviewed by Geoffrey Garen.
62
63         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
64         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm: Added.
65         (TEST):
66
67 2018-11-11  Benjamin Poulain  <benjamin@webkit.org>
68
69         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
70         https://bugs.webkit.org/show_bug.cgi?id=191492
71
72         Reviewed by Alex Christensen.
73
74         Update file name.
75
76         * DumpRenderTree/mac/DumpRenderTree.mm:
77         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
78         * WebKitTestRunner/mac/TestControllerMac.mm:
79
80 2018-11-10  Benjamin Poulain  <benjamin@webkit.org>
81
82         Fix a fixme: rename wtfObjcMsgSend to wtfObjCMsgSend
83         https://bugs.webkit.org/show_bug.cgi?id=191492
84
85         Reviewed by Alex Christensen.
86
87         * DumpRenderTree/mac/DumpRenderTree.mm:
88         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
89         * WebKitTestRunner/mac/TestControllerMac.mm:
90
91 2018-11-10  Ryan Haddad  <ryanhaddad@apple.com>
92
93         Unreviewed, rolling out r238065.
94
95         Breaks internal builds.
96
97         Reverted changeset:
98
99         "Make it possible to edit images inline"
100         https://bugs.webkit.org/show_bug.cgi?id=191352
101         https://trac.webkit.org/changeset/238065
102
103 2018-11-10  Michael Catanzaro  <mcatanzaro@igalia.com>
104
105         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
106         https://bugs.webkit.org/show_bug.cgi?id=191221
107
108         Unreviewed, fix a typo from the previous patch. After disabling the setting, we should test
109         that it is disabled, but we're testing that it is enabled, because I failed to update this
110         line.
111
112         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
113         (testWebKitSettings):
114
115 2018-11-10  Tim Horton  <timothy_horton@apple.com>
116
117         Make it possible to edit images inline
118         https://bugs.webkit.org/show_bug.cgi?id=191352
119         <rdar://problem/30107985>
120
121         Reviewed by Dean Jackson.
122
123         * WebKitTestRunner/TestController.cpp:
124         (WTR::updateTestOptionsFromTestHeader):
125         * WebKitTestRunner/TestOptions.h:
126         (WTR::TestOptions::hasSameInitializationOptions const):
127         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
128         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
129         (WTR::TestController::platformCreateWebView):
130         Add a test option to enable editable images.
131
132         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
133         (WTR::UIScriptController::drawSquareInEditableImage):
134         (WTR::UIScriptController::numberOfStrokesInEditableImage):
135         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
136         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
137         (WTR::UIScriptController::drawSquareInEditableImage):
138         (WTR::UIScriptController::numberOfStrokesInEditableImage):
139         * TestRunnerShared/UIScriptContext/UIScriptController.h:
140         * TestRunnerShared/spi/PencilKitTestSPI.h: Added.
141         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
142         (WTR::findEditableImageCanvas):
143         (WTR::UIScriptController::drawSquareInEditableImage):
144         (WTR::UIScriptController::numberOfStrokesInEditableImage):
145         Add the ability to draw on a PKCanvasView that is a subview of the WKWebView,
146         and also to retrieve the number of strokes currently on the PKCanvasView.
147         Currently this just takes the first canvas; we might need to make it
148         take an identifier or something in the future if we need tests with multiple
149         canvases. The indirect testing mechanism is required because PKCanvasView
150         can currently not actually paint its strokes in the Simulator.
151
152 2018-11-09  Chris Dumez  <cdumez@apple.com>
153
154         Suspended page persists even after back/forward list item is gone
155         https://bugs.webkit.org/show_bug.cgi?id=191488
156         <rdar://problem/45953006>
157
158         Reviewed by Geoffrey Garen.
159
160         Add API test coverage.
161
162         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
163
164 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
165
166         [Cocoa] Implement SPI on WKWebView to increase and decrease list levels
167         https://bugs.webkit.org/show_bug.cgi?id=191471
168         <rdar://problem/45952472>
169
170         Reviewed by Tim Horton.
171
172         Add an API test to ensure that list levels can be incremented and decremented via WKWebView SPI.
173
174         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
175         (TestWebKitAPI::webViewForEditActionTesting):
176         (TestWebKitAPI::TEST):
177
178 2018-11-09  Basuke Suzuki  <basuke.suzuki@sony.com>
179
180         [Curl][WebKit] Implement Proxy configuration API.
181         https://bugs.webkit.org/show_bug.cgi?id=189053
182
183         Reviewed by Youenn Fablet.
184
185         Added Proxy Settings dialog to call newly added API.
186
187         * MiniBrowser/win/BrowserWindow.h:
188         * MiniBrowser/win/Common.cpp:
189         (askProxySettings):
190         (askCredential):
191         (authDialogProc): Deleted.
192         * MiniBrowser/win/Common.h:
193         * MiniBrowser/win/DialogHelper.h: Added.
194         (Dialog::run):
195         (Dialog::doalogProc):
196         (Dialog::handle):
197         (Dialog::setup):
198         (Dialog::update):
199         (Dialog::validate):
200         (Dialog::updateOkButton):
201         (Dialog::command):
202         (Dialog::ok):
203         (Dialog::cancel):
204         (Dialog::close):
205         (Dialog::hDlg):
206         (Dialog::item):
207         (Dialog::setEnabled):
208         (Dialog::setText):
209         (Dialog::getText):
210         (Dialog::getTextLength):
211         (Dialog::RadioGroup::RadioGroup):
212         (Dialog::RadioGroup::set):
213         (Dialog::RadioGroup::get):
214         (Dialog::radioGroup):
215         * MiniBrowser/win/MainWindow.cpp:
216         (MainWindow::WndProc):
217         * MiniBrowser/win/MiniBrowserLib.rc:
218         * MiniBrowser/win/MiniBrowserLibResource.h:
219         * MiniBrowser/win/WebKitBrowserWindow.cpp:
220         (createWKURL):
221         (WebKitBrowserWindow::WebKitBrowserWindow):
222         (WebKitBrowserWindow::updateProxySettings):
223         (WebKitBrowserWindow::loadURL):
224         (WebKitBrowserWindow::loadHTMLString):
225         (WebKitBrowserWindow::openProxySettings):
226         * MiniBrowser/win/WebKitBrowserWindow.h:
227         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
228         (WebKitLegacyBrowserWindow::openProxySettings):
229         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
230
231 2018-11-09  Wenson Hsieh  <wenson_hsieh@apple.com>
232
233         [Cocoa] Introduce WKWebView SPI to insert nested ordered and unordered lists
234         https://bugs.webkit.org/show_bug.cgi?id=191410
235         <rdar://problem/45898610>
236
237         Reviewed by Dean Jackson.
238
239         Move WKWebViewEditActions from iOS to WebKitCocoa, and enable the relevant WKWebViewEditActions tests on macOS.
240         Additionally, add new API tests to verify that `-_pasteAsQuotation:` and `-_insertNested(Un)OrderedList:` are
241         hooked up to their respective editing commands.
242
243         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
244         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm: Renamed from Tools/TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm.
245         (-[TestWKWebView querySelectorExists:]):
246         (-[TestWKWebView insertString:]):
247
248         Add a helper method to insert a piece of text. This abstracts platform differences between iOS and macOS, by
249         invoking the WKWebView directly on macOS and calling on the content view on iOS.
250
251         (TestWebKitAPI::webViewForEditActionTesting):
252         (TestWebKitAPI::TEST):
253
254 2018-11-09  Philippe Normand  <pnormand@igalia.com>
255
256         [Flatpak] Refactoring and drive-by fixes
257         https://bugs.webkit.org/show_bug.cgi?id=191421
258
259         Reviewed by Michael Catanzaro.
260
261         * Scripts/webkitdirs.pm:
262         (inFlatpakSandbox): Flatpak now has a /.flatpak-info file when in
263         the sandbox, so rely on this.
264         * flatpak/flatpakutils.py:
265         (expand_manifest): Pass explicit keywords to load_manifest() and
266         remove unused local variable.
267         (WebkitFlatpak.clean_args): Move hard-coded sdk/runtime infos to the manifest file.
268         (WebkitFlatpak.run_in_sandbox): Add support for extra environment variables.
269         (WebkitFlatpak.setup_dev_env): Stop build at final app. Refactor
270         build_type handling a bit.
271         * flatpak/org.webkit.CommonModules.yaml: Added.
272         * flatpak/org.webkit.WPE.yaml: wpebackend upstream was renamed to libwpe.
273         * flatpak/org.webkit.WebKit.yaml: Move common dependencies
274         declaration to CommonModules, so it can be reused later when we
275         add support for building extra libraries depending on WPE.
276
277 2018-11-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
278
279 onal supported image formats
280         https://bugs.webkit.org/show_bug.cgi?id=190454
281
282         Reviewed by Simon Fraser.
283
284         Test opening a TGA image in WebView which is not allowed by default. The
285         TGA format will be allowed through WKWebViewConfiguration.
286
287         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
288         * TestWebKitAPI/Tests/WebKitCocoa/100x100-red.tga: Added.
289         * TestWebKitAPI/Tests/WebKitCocoa/400x400-green.png: Added.
290         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalSupportedImageTypes.mm: Added.
291         (runTest):
292         (TEST):
293
294 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
295
296         Unreviewed, a proper build fix for r237983
297
298         Don't include header PublicKeyCredential.h in CtapResponseTest.cpp.
299
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
301         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp.
302         (TestWebKitAPI::TEST):
303         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp.
304         (TestWebKitAPI::getTestCorruptedSignResponse):
305         (TestWebKitAPI::getTestCredentialRawIdBytes):
306         (TestWebKitAPI::convertToVector):
307         (TestWebKitAPI::TEST):
308
309 2018-11-08  Keith Rollin  <krollin@apple.com>
310
311         Create .xcfilelist files
312         https://bugs.webkit.org/show_bug.cgi?id=191324
313         <rdar://problem/45852819>
314
315         Reviewed by Alex Christensen.
316
317         As part of preparing for enabling XCBuild, create and use .xcfilelist
318         files. These files are using during Run Script build phases in an
319         Xcode project. If a Run Script build phase produces new files that are
320         used later as inputs to subsequent build phases, XCBuild needs to know
321         about these files. These files can be either specified in an "output
322         files" section of the Run Script phase editor, or in .xcfilelist files
323         that are associated with the Run Script build phase.
324
325         This patch takes the second approach. It consists of three sets of changes:
326
327         - Modify the DerivedSources.make files to have a
328           'print_all_generated_files" target that produces a list of the files
329           they create.
330
331         - Create a shell script that produces .xcfilelist files from the
332           output of the previous step, as well as for the files created in the
333           Generate Unified Sources build steps.
334
335         - Add the new .xcfilelist files to the associated projects.
336
337         Note that, with these changes, the Xcode workspace and projects can no
338         longer be fully loaded into Xcode 9. Xcode will attempt to load the
339         projects that have .xcfilelist files associated with them, but will
340         fail and display a placeholder for those projects instead. It's
341         expected that all developers are using Xcode 10 by now and that not
342         being able to load into Xcode 9 is not a practical issue. Keep in mind
343         that this is strictly an IDE issue, and that the projects can still be
344         built with `xcodebuild`.
345
346         Also note that the shell script that creates the .xcfilelist files can
347         also be used to verify that the set of files that's currently checked
348         in is up-to-date. This checking can be used as part of a check-in hook
349         or part of check-webkit-style to sooner catch cases where the
350         .xcfilelist files need to be regenerated.
351
352         * DumpRenderTree/DerivedSources.make:
353         * DumpRenderTree/DerivedSources.xcfilelist: Added.
354         * Scripts/generate-xcfilelists: Added.
355         * WebKitTestRunner/DerivedSources.make:
356         * WebKitTestRunner/DerivedSources.xcfilelist: Added.
357
358 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
359
360         Unreviewed, a quick build fix for r237983
361
362         Temporarily make CtapRequestTest.cpp/CtapResponseTest.cpp to mac only to avoid iOS build failures.
363
364         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj
365         * TestWebKitAPI/Tests/WebCore/mac/CtapRequestTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp.
366         (TestWebKitAPI::TEST):
367         * TestWebKitAPI/Tests/WebCore/mac/CtapResponseTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp.
368         (TestWebKitAPI::getTestCorruptedSignResponse):
369         (TestWebKitAPI::getTestCredentialRawIdBytes):
370         (TestWebKitAPI::convertToVector):
371         (TestWebKitAPI::TEST):
372
373 2018-11-05  Ryan Haddad  <ryanhaddad@apple.com>
374
375         Fix steps_unittest.py failures related to recent Win10/Win7 changes
376         https://bugs.webkit.org/show_bug.cgi?id=191290
377
378         Reviewed by Alexey Proskuryakov.
379
380         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update expected results.
381
382 2018-11-08  Dean Jackson  <dino@apple.com>
383
384         Add a String literal that returns a String
385         https://bugs.webkit.org/show_bug.cgi?id=191425
386         <rdar://problem/45914556>
387
388         Reviewed by Sam Weinig.
389
390         Test _str.
391
392         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
393         (TestWebKitAPI::TEST):
394
395 2018-11-08  Jonathan Bedard  <jbedard@apple.com>
396
397         webkitpy: Generalize trailing SDK specifier (Part 2)
398         https://bugs.webkit.org/show_bug.cgi?id=191275
399         <rdar://problem/45703660>
400
401         Rubber-stamped by Aakash Jain.
402
403         Re-landing this change, configuration issues have been resolved.
404
405         * Scripts/webkitpy/port/ios_device.py:
406         (IOSDevicePort): Use normalized SDK.
407         * Scripts/webkitpy/port/ios_simulator.py:
408         (IOSSimulatorPort): Use normalized SDK.
409         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
410
411 2018-11-08  Jiewen Tan  <jiewen_tan@apple.com>
412
413         [WebAuthN] Import CTAP device request/response converters from Chromium
414         https://bugs.webkit.org/show_bug.cgi?id=190784
415         <rdar://problem/45460333>
416
417         Reviewed by Brent Fulgham.
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp:
421         (TestWebKitAPI::TEST):
422         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp: Added.
423         (TestWebKitAPI::TEST):
424         * TestWebKitAPI/Tests/WebCore/CtapResponseTest.cpp: Added.
425         (TestWebKitAPI::getTestCorruptedSignResponse):
426         (TestWebKitAPI::getTestCredentialRawIdBytes):
427         (TestWebKitAPI::convertToVector):
428         (TestWebKitAPI::TEST):
429         * TestWebKitAPI/Tests/WebCore/FidoTestData.h: Added.
430
431 2018-11-07  Caio Lima  <ticaiolima@gmail.com>
432
433         [BigInt] Add support to BigInt into ValueAdd
434         https://bugs.webkit.org/show_bug.cgi?id=186177
435
436         Reviewed by Keith Miller.
437
438         * Scripts/run-jsc-benchmarks:
439
440 2018-11-07  Sihui Liu  <sihui_liu@apple.com>
441
442         RELEASE_ASSERT(!m_hardClosedForUserDelete) fails in WebCore::IDBServer::UniqueIDBDatabase::invokeOperationAndTransactionTimer
443         https://bugs.webkit.org/show_bug.cgi?id=191326
444         <rdar://problem/45769269>
445
446         Reviewed by Geoffrey Garen.
447
448         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
449         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.html: Added.
450         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm: Added.
451         (-[IndexedDBUserDeleteMessageHandler userContentController:didReceiveScriptMessage:]):
452         (TEST):
453
454 2018-11-07  Daniel Bates  <dabates@apple.com>
455
456         Override +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree
457         https://bugs.webkit.org/show_bug.cgi?id=190141
458
459         Reviewed by Darin Adler.
460
461         Override +[UIKeyboard isInHardwareKeyboardMode] to always return NO so as to make test
462         runs deterministic regardless of whether a hardware keyboard is attached.
463
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         (overrideIsInHardwareKeyboardMode): Added.
466         (prepareConsistentTestingEnvironment):
467         * TestRunnerShared/spi/UIKitTestSPI.h: Forward declare SPI.
468         * WebKitTestRunner/ios/TestControllerIOS.mm:
469         (overrideIsInHardwareKeyboardMode): Added.
470         (WTR::TestController::platformInitialize):
471
472 2018-11-07  Jonathan Bedard  <jbedard@apple.com>
473
474         Unreviewed, rolling out r237913.
475
476         Breaks running tests on Mac without iOS SDK installed
477
478         Reverted changeset:
479
480         "webkitpy: Generalize trailing SDK specifier (Part 2)"
481         https://bugs.webkit.org/show_bug.cgi?id=191275
482         https://trac.webkit.org/changeset/237913
483
484 2018-11-07  Zamiul Haque  <zhaque@apple.com>
485
486         Force a gregorian calendar to show for credit card expiration date inputs
487         (autocomplete='cc-exp'*) regardless of default system settings.
488         https://bugs.webkit.org/show_bug.cgi?id=191096
489         rdar://problem/42640256
490
491         Reviewed by Tim Horton.
492
493         Implemented simulateForeignDefaultCalendar and calendarType to be used
494         for changing the default calendar returned by the system (ie. [NSCalendar
495         currentCalendar]) and getting the calendar type identifier of a presented date
496         picker.
497
498         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
499         (WTR::UIScriptController::isShowingDataListSuggestions const):
500         (WTR::UIScriptController::calendarType const):
501         (WTR::UIScriptController::setDefaultCalendarType):
502         * DumpRenderTree/mac/UIScriptControllerMac.mm:
503         (WTR::UIScriptController::calendarType const):
504         (WTR::UIScriptController::setDefaultCalendarType):
505         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
506         (WTR::UIScriptController::selectionEndGrabberViewRect const):
507         (WTR::UIScriptController::calendarType const): Deleted.
508         * WebKitTestRunner/TestController.cpp:
509         * WebKitTestRunner/TestController.h:
510         * WebKitTestRunner/UIScriptControllerCocoa.mm:
511         (WTR::UIScriptController::calendarType const):
512         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
513         (WTR::swizzledCalendar):
514         (WTR::TestController::getOverriddenCalendarIdentifier const):
515         (WTR::TestController::setDefaultCalendarType):
516         (WTR::TestController::cocoaResetStateToConsistentValues):
517         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
518         (WTR::UIScriptController::selectionEndGrabberViewRect const):
519         (WTR::UIScriptController::calendarType const): Deleted.
520
521 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
522
523         webkitpy: Boot a single worker for custom devices
524         https://bugs.webkit.org/show_bug.cgi?id=191312
525         <rdar://problem/45848717>
526
527         Rubber-stamped by Aakash Jain.
528
529         * Scripts/webkitpy/layout_tests/controllers/manager.py:
530         (Manager.run): Custom devices only run a hand-full of tests. Booting multiple
531         simulators is expensive and unneeded for these tests.
532         * Scripts/webkitpy/port/ios.py:
533         (IOSPort. child_processes): No reason to memoize this call, and it prevents
534         overriding the number of child processes when booting custom devices.
535
536 2018-11-06  Jonathan Bedard  <jbedard@apple.com>
537
538         webkitpy: Generalize trailing SDK specifier (Part 2)
539         https://bugs.webkit.org/show_bug.cgi?id=191275
540         <rdar://problem/45703660>
541
542         Reviewed by Aakash Jain.
543
544         * Scripts/webkitpy/port/ios_device.py:
545         (IOSDevicePort): Use normalized SDK.
546         * Scripts/webkitpy/port/ios_simulator.py:
547         (IOSSimulatorPort): Use normalized SDK.
548         (IOSSimulatorPort._build_driver_flags): Use platform SDK in build driver flags.
549
550 2018-11-06  Justin Fan  <justin_fan@apple.com>
551
552         [WebGPU] Experimental prototype for WebGPURenderPipeline and WebGPUSwapChain
553         https://bugs.webkit.org/show_bug.cgi?id=191291
554
555         Reviewed by Myles Maxfield.
556
557         Properly disable WEBGPU on all non-Metal platforms for now.
558
559         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
560
561 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
562
563         [ews-app] Add URL configuration for OpenSource EWS Django app
564         https://bugs.webkit.org/show_bug.cgi?id=191132
565
566         Rubber-stamped by Lucas Forschler.
567
568         * BuildSlaveSupport/ews-app/ews-app/urls.py: Added entry for ews.urls.
569         * BuildSlaveSupport/ews-app/ews/urls.py: Added.
570
571 2018-11-06  Youenn Fablet  <youenn@apple.com>
572
573         Make mDNS ICE Candidate an experimental flag again
574         https://bugs.webkit.org/show_bug.cgi?id=191262
575
576         Reviewed by Dean Jackson.
577
578         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
579         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
580         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
581         (WTR::TestRunner::setMDNSICECandidatesEnabled): Deleted.
582         * WebKitTestRunner/InjectedBundle/TestRunner.h:
583
584 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
585
586         [ews-app] Add views for OpenSource EWS Django app
587         https://bugs.webkit.org/show_bug.cgi?id=191131
588
589         Rubber-stamped by Lucas Forschler.
590
591         * BuildSlaveSupport/ews-app/ews/views/index.py: Added.
592         * BuildSlaveSupport/ews-app/ews/views/patch.py:
593         * BuildSlaveSupport/ews-app/ews/views/results.py: Added.
594         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added.
595
596 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
597
598         [ews-app] Add models for OpenSource EWS Django app
599         https://bugs.webkit.org/show_bug.cgi?id=191123
600
601         Reviewed by Lucas Forschler.
602
603         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
604         * BuildSlaveSupport/ews-app/ews/models/buildermappings.py: Added.
605         * BuildSlaveSupport/ews-app/ews/models/builds.py: Added.
606         * BuildSlaveSupport/ews-app/ews/models/patch.py:
607         * BuildSlaveSupport/ews-app/ews/models/steps.py: Added.
608
609 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
610
611         [ews-app] Fix Invalid HTTP_HOST header
612         https://bugs.webkit.org/show_bug.cgi?id=191325
613
614         Reviewed by Lucas Forschler.
615
616         Changing ALLOWED_HOSTS to * as the landing page should be publicly accessible.
617
618         * BuildSlaveSupport/ews-app/ews-app/settings.py:
619
620 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
621
622         [ews-app] Rename EWS_app to ews-app - part 2
623         https://bugs.webkit.org/show_bug.cgi?id=191317
624
625         Reviewed by Lucas Forschler.
626
627         * BuildSlaveSupport/ews-app/EWS_app: Removed.
628         * BuildSlaveSupport/ews-app/ews-app: Moved from BuildSlaveSupport/ews-app/EWS_app.
629         * BuildSlaveSupport/ews-app/ews-app/settings.py:
630         * BuildSlaveSupport/ews-app/ews-app/urls.py:
631         * BuildSlaveSupport/ews-app/ews-app/wsgi.py:
632         * BuildSlaveSupport/ews-app/manage.py:
633
634 2018-11-06  Aakash Jain  <aakash_jain@apple.com>
635
636         [ews-app] Rename EWS_app to ews-app - part 1
637         https://bugs.webkit.org/show_bug.cgi?id=191317
638
639         Reviewed by Lucas Forschler.
640
641         * BuildSlaveSupport/EWS_app: Removed.
642         * BuildSlaveSupport/ews-app: Moved from BuildSlaveSupport/EWS_app.
643
644 2018-11-06  Myles C. Maxfield  <mmaxfield@apple.com>
645
646         Spelling dots are drawn in the wrong place
647         https://bugs.webkit.org/show_bug.cgi?id=190764
648
649         Reviewed by Dean Jackson.
650
651         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
652         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
653         dots to be drawn.
654
655         * WebKitTestRunner/TestController.cpp:
656         (WTR::TestController::resetStateToConsistentValues):
657         (WTR::updateTestOptionsFromTestHeader):
658         (WTR::TestController::platformResetStateToConsistentValues):
659         * WebKitTestRunner/TestController.h:
660         * WebKitTestRunner/TestOptions.h:
661         (WTR::TestOptions::hasSameInitializationOptions const):
662         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
663         (WTR::TestController::cocoaResetStateToConsistentValues):
664         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
665         * WebKitTestRunner/ios/TestControllerIOS.mm:
666         (WTR::TestController::platformResetStateToConsistentValues):
667         * WebKitTestRunner/mac/TestControllerMac.mm:
668         (WTR::TestController::platformResetStateToConsistentValues):
669
670 2018-11-06  Don Olmstead  <don.olmstead@sony.com>
671
672         Feature flags not present for Visual Studio when using build-webkit
673         https://bugs.webkit.org/show_bug.cgi?id=191288
674
675         Reviewed by Fujii Hironori.
676
677         Passes feature flags to Visual studio builds within build-webkit.
678         Removes cmakeBasedPortArguments as it is no longer in use.
679
680         * Scripts/build-jsc:
681         * Scripts/build-webkit:
682         * Scripts/webkitdirs.pm:
683         (cmakeBasedPortArguments): Deleted.
684
685 2018-11-06  Per Arne Vollan  <pvollan@apple.com>
686
687         REGRESSION (r230523): Caps lock indicator not shown in password field
688         https://bugs.webkit.org/show_bug.cgi?id=190056
689
690         Reviewed by Ryosuke Niwa.
691
692         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
693         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
694         (WTR::TestRunner::toggleCapsLock):
695         * WebKitTestRunner/InjectedBundle/TestRunner.h:
696         * WebKitTestRunner/TestController.h:
697         * WebKitTestRunner/TestInvocation.cpp:
698         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
699         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
700         (WTR::TestController::toggleCapsLock):
701
702 2018-11-06  Sihui Liu  <sihui_liu@apple.com>
703
704         IndexedDB: WAL file keeps growing
705         https://bugs.webkit.org/show_bug.cgi?id=191294
706         <rdar://problem/41333493>
707
708         Reviewed by Chris Dumez.
709
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
711         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-1.html: Added.
712         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize-2.html: Added.
713         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm: Added.
714         (-[IndexedDBFileSizeMessageHandler userContentController:didReceiveScriptMessage:]):
715         (TEST):
716
717 2018-11-06  Alex Christensen  <achristensen@webkit.org>
718
719         Fix tests after r237863
720         https://bugs.webkit.org/show_bug.cgi?id=191315
721
722         Reviewed by Chris Dumez.
723
724         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
725         With the timing change of r237863, the WKWebView progressed further than before when loading main.html so it completed before main2.html.
726         This test was meant to test that main2.html does eventually load, and it doesn't matter if main.html loads before it.  I updated the test
727         to verify that main2.html eventually loads, making this test less timing dependent.
728
729 2018-11-06  Ryan Haddad  <ryanhaddad@apple.com>
730
731         Unreviewed, rolling out r237834.
732
733         Tests for this change crash on iOS Simulator
734
735         Reverted changeset:
736
737         "Spelling dots are drawn in the wrong place"
738         https://bugs.webkit.org/show_bug.cgi?id=190764
739         https://trac.webkit.org/changeset/237834
740
741 2018-11-05  Alex Christensen  <achristensen@webkit.org>
742
743         [Mac] Implement safe browsing in WebKit
744         https://bugs.webkit.org/show_bug.cgi?id=188871
745
746         Reviewed by Tim Horton.
747
748         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
749         (-[SafeBrowsingNavigationDelegate webView:didCommitNavigation:]):
750         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:]):
751         (-[TestLookupContext lookUpURL:completionHandler:]):
752         (simpleURL):
753         (safeBrowsingView):
754         (TEST):
755         (-[SafeBrowsingNavigationDelegate webView:didFinishNavigation:]): Deleted.
756         (+[TestServiceLookupResult resultWithProvider:phishing:malware:unwantedSoftware:knownToBeUnsafe:]): Deleted.
757         (-[TestServiceLookupResult isKnownToBeUnsafe]): Deleted.
758         * TestWebKitAPI/Utilities.h:
759
760 2018-11-05  Jonathan Bedard  <jbedard@apple.com>
761
762         webkitpy: Generalize trailing SDK specifier (Part 1)
763         https://bugs.webkit.org/show_bug.cgi?id=191275
764         <rdar://problem/45703660>
765
766         Reviewed by Lucas Forschler.
767
768         * Scripts/webkitpy/common/system/platforminfo.py:
769         (PlatformInfo.available_sdks): List all installed SDKs with version numbers stripped out.
770         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
771         (TestPlatformInfo):
772         (TestPlatformInfo.test_available_sdks):
773
774 2018-11-05  Myles C. Maxfield  <mmaxfield@apple.com>
775
776         Spelling dots are drawn in the wrong place
777         https://bugs.webkit.org/show_bug.cgi?id=190764
778
779         Reviewed by Dean Jackson.
780
781         Previously, it was impossible for WebKitTestRunner to draw spelling dots. This patch adds support for a header
782         at the top of test files, of the form <!-- webkit-test-runner [ spellCheckingDots=true ] --> which will cause
783         dots to be drawn.
784
785         * WebKitTestRunner/TestController.cpp:
786         (WTR::TestController::resetStateToConsistentValues):
787         (WTR::updateTestOptionsFromTestHeader):
788         (WTR::TestController::platformResetStateToConsistentValues):
789         * WebKitTestRunner/TestController.h:
790         * WebKitTestRunner/TestOptions.h:
791         (WTR::TestOptions::hasSameInitializationOptions const):
792         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
793         (WTR::TestController::cocoaResetStateToConsistentValues):
794         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
795         * WebKitTestRunner/ios/TestControllerIOS.mm:
796         (WTR::TestController::platformResetStateToConsistentValues):
797         * WebKitTestRunner/mac/TestControllerMac.mm:
798         (WTR::TestController::platformResetStateToConsistentValues):
799
800 2018-11-05  Chris Dumez  <cdumez@apple.com>
801
802         Use same limit for page cache and suspended pages
803         https://bugs.webkit.org/show_bug.cgi?id=191266
804
805         Reviewed by Geoffrey Garen.
806
807         Update API tests accordingly.
808
809         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
810
811 2018-11-05  Basuke Suzuki  <Basuke.Suzuki@sony.com>
812
813         [style] Exclude style check for auto generated files.
814         https://bugs.webkit.org/show_bug.cgi?id=191118
815
816         Reviewed by Eric Carlson.
817
818         Some files checked in to the repository are generated by other tools. In this patch,
819         "MiniBrowserLibResource.h" is the file generated and managed by resource editor of
820         VisualStudio.
821
822         There's no need to check these files because it's not practical to fix the style errors
823         or it's hard to maintain those fixes.
824
825         * Scripts/webkitpy/style/checkers/cpp.py:
826         (is_generated_file):
827         (CppChecker.check):
828
829 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
830
831         [Flatpak] Build libx264 as it is the h264 encoder we support in WebRTC
832         https://bugs.webkit.org/show_bug.cgi?id=190680
833
834         Reviewed by Philippe Normand.
835
836         * flatpak/org.webkit.WebKit.yaml:
837
838 2018-11-05  Daniel Bates  <dabates@apple.com>
839
840         [lldb-webkit] Fix formatting nits in Document and Frame summary strings
841         https://bugs.webkit.org/show_bug.cgi?id=191094
842
843         Reviewed by Andy Estes.
844
845         Format boolean as 1/0 when printing Frame summary to be consistent with the formatting of
846         booleans in other summary strings, substitute "inMainFrame" for "isMainFrame" in the printed
847         Document summary and add closing brace '}' to both Frame and Document summary strings to make
848         them look pretty.
849
850         * lldb/lldb_webkit.py:
851         (WebCoreFrame_SummaryProvider):
852         (WebCoreDocument_SummaryProvider):
853
854 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
855
856         [iOS] Allow WKWebView clients to customize bar button item groups in the accessory view when editing
857         https://bugs.webkit.org/show_bug.cgi?id=191240
858         <rdar://problem/44872806>
859
860         Reviewed by Tim Horton.
861
862         Add new API tests to verify that setting leading and trailing bar button groups on WKWebView sets the first
863         responder's (i.e. WKContentView's) leading and trailing bar button groups, and that this can also be achieved by
864         overriding `-[WKWebView inputAssistantItem]`.
865
866         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
867         (-[InputAssistantItemTestingWebView fakeLeadingBarButtonItemAction]):
868         (-[InputAssistantItemTestingWebView fakeTrailingBarButtonItemAction]):
869         (+[InputAssistantItemTestingWebView barButtonIcon]):
870         (+[InputAssistantItemTestingWebView leadingItemsForWebView:]):
871         (+[InputAssistantItemTestingWebView trailingItemsForWebView:]):
872         (-[InputAssistantItemTestingWebView inputAssistantItem]):
873         (TestWebKitAPI::TEST):
874
875 2018-11-05  Wenson Hsieh  <wenson_hsieh@apple.com>
876
877         [iOS] Changing view scale sometimes does not zoom the page to the new initial scale when the page is zoomed in when ignoring meta viewport
878         https://bugs.webkit.org/show_bug.cgi?id=191226
879         <rdar://problem/45781765>
880
881         Reviewed by Tim Horton.
882
883         Add a missing check for `shouldIgnoreMetaViewport` when comparing TestOptions, to ensure that "ignore meta
884         viewport" state doesn't unexpectedly persist after running a layout test that ignores meta viewport.
885
886         * WebKitTestRunner/TestOptions.h:
887         (WTR::TestOptions::hasSameInitializationOptions const):
888
889 2018-11-05  Commit Queue  <commit-queue@webkit.org>
890
891         Unreviewed, rolling out r237784 and r237788.
892         https://bugs.webkit.org/show_bug.cgi?id=191270
893
894         Caused mediastream layout test failures (Requested by
895         ryanhaddad on #webkit).
896
897         Reverted changesets:
898
899         "[MediaStream] User should not be prompted again after denying
900         getDisplayMedia request"
901         https://bugs.webkit.org/show_bug.cgi?id=191227
902         https://trac.webkit.org/changeset/237784
903
904         "[MediaStream] User should not be prompted again after denying
905         getDisplayMedia request"
906         https://bugs.webkit.org/show_bug.cgi?id=191227
907         https://trac.webkit.org/changeset/237788
908
909 2018-11-05  Lucas Forschler  <lforschler@apple.com>
910
911         https://bugs.webkit.org/show_bug.cgi?id=191268
912         Remove unused bots.
913
914         rubber-stamped by Alexey Proskuryakov.
915
916         * BuildSlaveSupport/build.webkit.org-config/config.json:
917         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
918         (WebKitBuildbot):
919
920 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
921
922         [WPE][GTK] API test runner fails to respect default build type
923         https://bugs.webkit.org/show_bug.cgi?id=190247
924
925         Reviewed by Carlos Garcia Campos.
926
927         Problem is it's looking for a release build, even though I've run set-webkit-configuration
928         --debug. It should look for a debug build unless I explicitly pass --release.
929
930         * glib/api_test_runner.py:
931         (TestRunner.__init__):
932
933 2018-11-05  Thibault Saunier  <tsaunier@igalia.com>
934
935         [GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
936         https://bugs.webkit.org/show_bug.cgi?id=190674
937
938         Reviewed by Philippe Normand.
939
940         webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
941         it can use to implement encoding for different formats exposing a trimmed down unified API.
942
943         It also adds proper handling of H264 profiles.
944
945         The added files follow GStreamer coding style as we aim at upstreaming the element
946         in the future.
947
948         Reviewed by Philippe Normand.
949
950         * Scripts/webkitpy/style/checker.py:
951
952 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
953
954         [WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
955         https://bugs.webkit.org/show_bug.cgi?id=191221
956
957         Reviewed by Carlos Garcia Campos.
958
959         This test ensures that MSE is disabled by default, but we now enable it by default, so
960         reverse the semantics of the test.
961
962         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
963         (testWebKitSettings):
964
965 2018-11-05  Michael Catanzaro  <mcatanzaro@igalia.com>
966
967         REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
968         https://bugs.webkit.org/show_bug.cgi?id=191225
969
970         Reviewed by Alejandro G. Castro.
971
972         Fix a memory leak causing this test to fail.
973
974         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
975         (WebViewTest::initializeWebView):
976
977 2018-11-04  Zan Dobersek  <zdobersek@igalia.com>
978
979         [webkitpy] Support WPE in the run-web-platform-tests script
980         https://bugs.webkit.org/show_bug.cgi?id=191183
981
982         Reviewed by Alex Christensen.
983
984         * Scripts/webkitpy/w3c/wpt_runner.py:
985         (parse_args): Support `--wpe` as an argument that specifies WPE as the
986         target port. Additionally, the `--display-server` flag now accepts
987         `headless` as a valid value, enabling the WPE WebDriver to run in
988         headless mode.
989
990 2018-11-04  Fujii Hironori  <Hironori.Fujii@sony.com>
991
992         [Win] Use C++14, not C++17
993         https://bugs.webkit.org/show_bug.cgi?id=191101
994
995         Reviewed by Alex Christensen.
996
997         std::basic_string::data() returns a read-only const buffer in
998         C++14.
999
1000         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1001         (createString): Use std::vector instead of std::wstring.
1002         (createUTF8String): Use std::vector instead of std::string.
1003
1004 2018-11-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1005
1006         [Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
1007         https://bugs.webkit.org/show_bug.cgi?id=191231
1008
1009         Reviewed by Simon Fraser.
1010
1011         Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
1012         it can be shared between iOS-family and macOS platforms. See below for more details.
1013
1014         No change in behavior.
1015
1016         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1017         (WTR::UIScriptController::overridePreference):
1018
1019         Add a method stub for DumpRenderTree.
1020
1021         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1022         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1023         (WTR::UIScriptController::doAsyncTask):
1024         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
1025
1026         Unify these method implementations.
1027
1028         (WTR::UIScriptController::removeViewFromWindow):
1029         (WTR::UIScriptController::addViewToWindow):
1030
1031         Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
1032         to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
1033         block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
1034         begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.
1035
1036         (WTR::UIScriptController::overridePreference):
1037         (WTR::UIScriptController::findString):
1038         (WTR::UIScriptController::contentsOfUserInterfaceItem const):
1039
1040         Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.
1041
1042         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1043         (WTR::UIScriptController::doAsyncTask): Deleted.
1044         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1045         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1046         (WTR::UIScriptController::findString): Deleted.
1047         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1048         (WTR::UIScriptController::addViewToWindow): Deleted.
1049         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1050         (WTR::UIScriptController::doAsyncTask): Deleted.
1051         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
1052         (WTR::UIScriptController::overridePreference): Deleted.
1053         (WTR::UIScriptController::findString): Deleted.
1054         (WTR::UIScriptController::removeViewFromWindow): Deleted.
1055         (WTR::UIScriptController::addViewToWindow): Deleted.
1056         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
1057
1058 2018-11-04  Eric Carlson  <eric.carlson@apple.com>
1059
1060         [MediaStream] User should not be prompted again after denying getDisplayMedia request
1061         https://bugs.webkit.org/show_bug.cgi?id=191227
1062         <rdar://problem/45784512>
1063
1064         Reviewed by Youenn Fablet.
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1067         (-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1068         (TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
1069         (TestWebKitAPI::TEST_F):
1070
1071 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1072
1073         [LFC][BFC] Add support for percentage height in quirks mode.
1074         https://bugs.webkit.org/show_bug.cgi?id=191232
1075
1076         Reviewed by Antti Koivisto.
1077
1078         * LayoutReloaded/misc/LFC-passing-tests.txt:
1079
1080 2018-11-04  Zalan Bujtas  <zalan@apple.com>
1081
1082         [LFC][BCF] Add support for block level non-replaced inflow height percentage
1083         https://bugs.webkit.org/show_bug.cgi?id=191229
1084
1085         Reviewed by Antti Koivisto.
1086
1087         * LayoutReloaded/misc/LFC-passing-tests.txt:
1088
1089 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1090
1091         [LFC][BFC] Resolve percentage height values.
1092         https://bugs.webkit.org/show_bug.cgi?id=191224
1093
1094         Reviewed by Antti Koivisto.
1095
1096         * LayoutReloaded/misc/LFC-passing-tests.txt:
1097
1098 2018-11-03  Alex Christensen  <achristensen@webkit.org>
1099
1100         Mac production builds should sign the network process xpc service with entitlements
1101         https://bugs.webkit.org/show_bug.cgi?id=191209
1102         <rdar://problem/45377609>
1103
1104         Reviewed by Geoff Garen.
1105
1106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1107         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1108         (TEST):
1109
1110 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1111
1112         Unreviewed, rolling out r237761.
1113
1114         Makes most API tests timeout and WK2 tests crash
1115
1116         Reverted changeset:
1117
1118         "Mac production builds should sign the network process xpc
1119         service with entitlements"
1120         https://bugs.webkit.org/show_bug.cgi?id=191209
1121         https://trac.webkit.org/changeset/237761
1122
1123 2018-11-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1124
1125         Unreviewed API test gardening
1126
1127         * TestWebKitAPI/glib/TestExpectations.json:
1128
1129 2018-11-02  Justin Michaud  <justin_michaud@apple.com>
1130
1131         Add new global object and preliminary Worklets support for CSS painting api
1132         https://bugs.webkit.org/show_bug.cgi?id=190979
1133
1134         Reviewed by Chris Dumez.
1135
1136         * Scripts/webkitpy/bindings/main.py:
1137         (BindingsTests.generate_supplemental_dependency):
1138         (BindingsTests.main):
1139
1140 2018-11-02  Alex Christensen  <achristensen@webkit.org>
1141
1142         Mac production builds should sign the network process xpc service with entitlements
1143         https://bugs.webkit.org/show_bug.cgi?id=191209
1144         <rdar://problem/45377609>
1145
1146         Reviewed by Geoff Garen.
1147
1148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1149         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
1150         (TEST):
1151
1152 2018-11-02  Lucas Forschler  <lforschler@apple.com>
1153
1154         Add Windows 10 archive bots
1155         https://bugs.webkit.org/show_bug.cgi?id=190964
1156         
1157         This Change updates the Apple Windows Buildbot configuration.
1158         - Add Windows 10 specific builders and testers for release and debug.
1159         - Refactor Windows -> Windows 7.
1160         - Remove Windows 7 Debug.
1161
1162         Reviewed by Aakash Jain.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/config.json:
1165
1166 2018-11-02  Philippe Normand  <pnormand@igalia.com>
1167
1168         [GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
1169
1170         Rubber-stamped by Michael Catanzaro.
1171
1172         This variable is useful to get rid of shell color escapes in tests stderr files.
1173
1174         * Scripts/webkitpy/port/gtk.py:
1175         (GtkPort.setup_environ_for_server):
1176         * Scripts/webkitpy/port/wpe.py:
1177         (WPEPort.setup_environ_for_server):
1178
1179 2018-11-02  Aakash Jain  <aakash_jain@apple.com>
1180
1181         Add Basic Django web app for OpenSource EWS
1182         https://bugs.webkit.org/show_bug.cgi?id=191091
1183
1184         Reviewed by Lucas Forschler.
1185
1186         * BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
1187         * BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
1188         * BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
1189         * BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
1190         * BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
1191         * BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
1192         * BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
1193         * BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
1194         * BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
1195         * BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
1196         * BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
1197         * BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
1198         * BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
1199         * BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.
1200
1201 2018-11-02  Daniel Bates  <dabates@apple.com>
1202
1203         [iOS] WebKit should dispatch DOM events when a modifier key is pressed
1204         https://bugs.webkit.org/show_bug.cgi?id=190487
1205
1206         Reviewed by Tim Horton.
1207
1208         Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
1209         match my observations when using the simulator to simulate iOS 12 and add support for testing
1210         right-hand side modifiers.
1211
1212         * DumpRenderTree/mac/EventSendingController.mm:
1213         (modifierFlags):
1214         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1215         (-[EventSendingController setTouchModifier:value:]):
1216         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1217         (hidUsageCodeForCharacter):
1218
1219 2018-11-02  Chris Dumez  <cdumez@apple.com>
1220
1221         [PSON] Reuse SuspendedPages' process when possible, for performance
1222         https://bugs.webkit.org/show_bug.cgi?id=191166
1223
1224         Reviewed by Geoffrey Garen.
1225
1226         Add API test coverage.
1227
1228         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1229
1230 2018-11-02  Zalan Bujtas  <zalan@apple.com>
1231
1232         [LFC][IFC] Add support for intrinsic width calculation
1233         https://bugs.webkit.org/show_bug.cgi?id=191144
1234
1235         Reviewed by Antti Koivisto.
1236
1237         * LayoutReloaded/misc/LFC-passing-tests.txt:
1238
1239 2018-11-01  Philippe Normand  <pnormand@igalia.com>
1240
1241         [Apache] Self-signed SSL certificate RSA key is considered too weak
1242         https://bugs.webkit.org/show_bug.cgi?id=191156
1243
1244         Reviewed by Michael Catanzaro.
1245
1246         * Scripts/webkitpy/common/system/pemfile.py:
1247
1248 2018-11-02  Zan Dobersek  <zdobersek@igalia.com>
1249
1250         Unreviewed follow-up to r237678.
1251
1252         * wpe/jhbuild.modules: The patch element apparently has to be a child
1253         of the branch in order for Jhbuild to properly detect and apply the
1254         patch file.
1255
1256 2018-11-01  Ross Kirsling  <ross.kirsling@sony.com>
1257
1258         build-jsc --wincairo should update WinCairo libraries
1259         https://bugs.webkit.org/show_bug.cgi?id=191170
1260
1261         Reviewed by Fujii Hironori.
1262
1263         * Scripts/build-jsc:
1264
1265 2018-11-01  John Wilander  <wilander@apple.com>
1266
1267         In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
1268         https://bugs.webkit.org/show_bug.cgi?id=191119
1269         <rdar://problem/44176965>
1270
1271         Reviewed by Chris Dumez.
1272
1273         This is an API test for a WebKitLegacy WebView that is first closed and then
1274         JavaScript is handed a keyboard event.
1275
1276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1277         * TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
1278         (-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
1279         (-[KeyboardEventListener handleEvent:]):
1280         (TestWebKitAPI::TEST):
1281
1282 2018-11-01  Sihui Liu  <sihui_liu@apple.com>
1283
1284         Add a storage limit for IndexedDB
1285         https://bugs.webkit.org/show_bug.cgi?id=190598
1286         <rdar://problem/44654715>
1287
1288         Reviewed by Chris Dumez.
1289
1290         Add API for testing.
1291
1292         * DumpRenderTree/TestRunner.cpp:
1293         (setIDBPerOriginQuotaCallback):
1294         (TestRunner::staticFunctions):
1295         * DumpRenderTree/TestRunner.h:
1296         * DumpRenderTree/mac/TestRunnerMac.mm:
1297         (TestRunner::setIDBPerOriginQuota):
1298         * DumpRenderTree/win/TestRunnerWin.cpp:
1299         (TestRunner::setIDBPerOriginQuota):
1300         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1301         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1302         (WTR::TestRunner::setIDBPerOriginQuota):
1303         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1304         * WebKitTestRunner/TestController.cpp:
1305         (WTR::TestController::setIDBPerOriginQuota):
1306         * WebKitTestRunner/TestController.h:
1307         * WebKitTestRunner/TestInvocation.cpp:
1308         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1309
1310 2018-11-01  Chris Dumez  <cdumez@apple.com>
1311
1312         [PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
1313         https://bugs.webkit.org/show_bug.cgi?id=191076
1314
1315         Reviewed by Geoffrey Garen.
1316
1317         Add API test coverage.
1318
1319         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1320         (-[PSONNavigationDelegate init]):
1321         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1322
1323 2018-11-01  Adrian Perez de Castro  <aperez@igalia.com>
1324
1325         Fix build with VIDEO and WEB_AUDIO disabled
1326         https://bugs.webkit.org/show_bug.cgi?id=191147
1327         <rdar://problem/45726710>
1328
1329         Unreviewed build fix.
1330
1331         This adds the missing compilation guards in the WPE MiniBrowser.
1332
1333         * MiniBrowser/wpe/main.cpp:
1334         (main): Condition GST includes and calls.
1335
1336 2018-10-31  Zalan Bujtas  <zalan@apple.com>
1337
1338         [LFC][IFC] Add support for inline-block elements.
1339         https://bugs.webkit.org/show_bug.cgi?id=191143
1340
1341         Reviewed by Antti Koivisto.
1342
1343         * LayoutReloaded/misc/LFC-passing-tests.txt:
1344
1345 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1346
1347         [WPE] Add missing libsoup patch to jhbuild
1348         https://bugs.webkit.org/show_bug.cgi?id=191149
1349
1350         Reviewed by Žan Doberšek.
1351
1352         * wpe/jhbuild.modules:
1353         * wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1354
1355 2018-11-01  Claudio Saavedra  <csaavedra@igalia.com>
1356
1357         Fix build with VIDEO and WEB_AUDIO disabled
1358         https://bugs.webkit.org/show_bug.cgi?id=191147
1359
1360         Reviewed by Philippe Normand.
1361
1362         * MiniBrowser/gtk/main.c:
1363         (main): Condition GST includes and calls
1364
1365 2018-10-31  Justin Michaud  <justin_michaud@apple.com>
1366
1367         Add Justin Michaud to the list of WebKit Committers
1368         https://bugs.webkit.org/show_bug.cgi?id=191142
1369
1370         * Scripts/webkitpy/common/config/contributors.json:
1371
1372 2018-10-31  Guillaume Emont  <guijemont@igalia.com>
1373
1374         Don't run JIT tests on 32-bit platforms
1375         https://bugs.webkit.org/show_bug.cgi?id=191074
1376
1377         Reviewed by Michael Catanzaro.
1378
1379         * Scripts/run-jsc-stress-tests:
1380
1381 2018-10-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1382
1383         [Cocoa] Attachment dropped from one web view to another is missing its file wrapper
1384         https://bugs.webkit.org/show_bug.cgi?id=190530
1385         <rdar://problem/45232149>
1386
1387         Reviewed by Tim Horton.
1388
1389         Add a test to verify that copying different types of attachments and pasting in a new web view inserts
1390         attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
1391         is equivalent to the original file wrappers used to insert attachments in the first web view.
1392
1393         Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
1394         is still backed by the same NSFileWrapper instance.
1395
1396         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1397         (TestWebKitAPI::TEST):
1398
1399 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1400
1401         [Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
1402         https://bugs.webkit.org/show_bug.cgi?id=190949
1403
1404         Reviewed by Alex Christensen.
1405
1406         Visual Studio 2017 Community is the alternative.
1407
1408         * Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.
1409         (setupCygwinEnv): Remove obsolete code for Visual Studio Express.
1410         (buildVisualStudioProject): Ditto.
1411         (dieIfWindowsPlatformSDKNotInstalled): Deleted.
1412         (usingVisualStudioExpress): Deleted.
1413
1414 2018-10-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1415
1416         [Win][Direct2D] Support building DumpRenderTree for Direct2D
1417         https://bugs.webkit.org/show_bug.cgi?id=191093
1418         <rdar://problem/45685706>
1419
1420         Unreviewed build fix.
1421
1422         error C2065: 'renderTarget': undeclared identifier
1423
1424         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1425         (createBitmapContextFromWebView): Restored the previous implementation.
1426
1427 2018-10-30  Don Olmstead  <don.olmstead@sony.com>
1428
1429         [PlayStation] Enable JavaScriptCore
1430         https://bugs.webkit.org/show_bug.cgi?id=191072
1431
1432         Reviewed by Brent Fulgham.
1433
1434         Add platform scripts for building the PlayStation port.
1435         perl Tools/Scripts/build-webkit --playstation
1436
1437         * Scripts/build-webkit:
1438         * Scripts/build-webkittestrunner:
1439         * Scripts/webkitdirs.pm:
1440         (argumentsForConfiguration):
1441         (determineConfigurationProductDir):
1442         (isPlayStation): Added.
1443         (getMSBuildPlatformArgument): Added.
1444         (buildVisualStudioProject):
1445         (wrapperPrefixIfNeeded):
1446         (generateBuildSystemFromCMakeProject):
1447         * TestWebKitAPI/PlatformPlayStation.cmake: Added.
1448
1449 2018-10-30  Brent Fulgham  <bfulgham@apple.com>
1450
1451         [Win][Direct2D] Support building DumpRenderTree for Direct2D
1452         https://bugs.webkit.org/show_bug.cgi?id=191093
1453         <rdar://problem/45685706>
1454
1455         Reviewed by Alex Christensen.
1456
1457         * DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
1458         * DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
1459         * DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.
1460         (pixelDumpSystemFactory): Added.
1461         (printPNG): Create stub.
1462         (computeMD5HashStringForBitmapContext): Ditto.
1463         (dumpBitmap): Ditto.
1464         * DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.
1465         (BitmapContext::createByAdoptingBitmapAndContext):
1466         (BitmapContext::~BitmapContext):
1467         (BitmapContext::platformContext const):
1468         (BitmapContext::BitmapContext):
1469         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1470         (createBitmapContextFromWebView): Update to support Direct2D.
1471         * MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit
1472         logo is no longer available at this location. Switch to the new logo.
1473
1474 2018-10-30  Jonathan Bedard  <jbedard@apple.com>
1475
1476         webkitpy: Support alternate simctl list outputs
1477         https://bugs.webkit.org/show_bug.cgi?id=191090
1478         <rdar://problem/45684255>
1479
1480         Rubber-stamped by Aakash Jain.
1481
1482         * Scripts/webkitpy/xcode/simulated_device.py:
1483         (SimulatedDeviceManager._create_runtimes): Support alternative availability format.
1484         (SimulatedDeviceManager._create_device_with_runtime): Ditto.
1485         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
1486         (test_available_devices): Add iOS 12 with alternative availability format.
1487
1488 2018-10-30  Alexey Proskuryakov  <ap@apple.com>
1489
1490         Clean up some obsolete MAX_ALLOWED macros
1491         https://bugs.webkit.org/show_bug.cgi?id=190916
1492
1493         Reviewed by Tim Horton.
1494
1495         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
1496         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1497         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1498
1499 2018-10-30  Claudio Saavedra  <csaavedra@igalia.com>
1500
1501         [GTK][WPE] Fixes to the PublicSuffix implementation
1502         https://bugs.webkit.org/show_bug.cgi?id=191031
1503
1504         Reviewed by Michael Catanzaro.
1505
1506         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
1507         (TestWebKitAPI::TEST_F): Remove a test for a domain
1508         that is not registrable and shouldn't be tested there.
1509
1510 2018-10-29  Tim Horton  <timothy_horton@apple.com>
1511
1512         Modernize WebKit nibs and lprojs for localization's sake
1513         https://bugs.webkit.org/show_bug.cgi?id=190911
1514         <rdar://problem/45349466>
1515
1516         Reviewed by Dan Bernstein.
1517
1518         * Scripts/check-inspector-strings:
1519         * Scripts/update-webkit-localizable-strings:
1520         * gtk/manifest.txt.in:
1521         * wpe/manifest.txt.in:
1522         English->en
1523
1524 2018-10-29  Daniel Bates  <dabates@apple.com>
1525
1526         [lldb-webkit] Last aliased enumerator in OptionSet is printed; should print first enumerator
1527         https://bugs.webkit.org/show_bug.cgi?id=191036
1528
1529         Reviewed by Andy Estes.
1530
1531         Prefer the first enumerator (in parse order) when pretty-printing an OptionSet that is parameterized
1532         by an enum that contains two or more enumerators with the same value. For example, suppose
1533         you have the following enum:
1534
1535         enum Flag {
1536             A = 1 << 0,
1537             AAlias = A,
1538         };
1539
1540         Then pretty-printing OptionSet<Flag>(Flag::A) should print A instead of AAlias. A side effect of
1541         this change is that OptionSet<Flag>(Flag::AAlias) will also print A as its only member as we cannot
1542         differentiate between A and Alias. This should be acceptable in practice as aliased enumerators
1543         tend to be used in bounds checks as opposed to code that adds to a set.
1544
1545         * lldb/lldbWebKitTester/main.cpp:
1546         (testSummaryProviders):
1547         * lldb/lldb_webkit.py:
1548         (WTFOptionSetProvider.update):
1549         * lldb/lldb_webkit_unittest.py:
1550         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
1551         (TestSummaryProviders):
1552         (TestSummaryProviders.serial_test_WTFOptionSetProvider_aliased_flag):
1553
1554 2018-10-29  Daniel Bates  <dabates@apple.com>
1555
1556         [llbd-webkit] Add summaries for Document, Frame, and SecurityOrigin
1557         https://bugs.webkit.org/show_bug.cgi?id=191033
1558
1559         Reviewed by Andy Estes.
1560
1561         For Documents we display its origin, URL, whether it's in the main frame, and its page cache state.
1562         We display the same details in the summary for a Frame because its Document tends to be the most
1563         interesting aspect of it. For SecurityOrigin we display its origin, domain (affects cookie access),
1564         and whether the origin has universal access.
1565
1566         * lldb/lldb_webkit.py:
1567         (__lldb_init_module):
1568         Register new summary providers.
1569
1570         (WebCoreSecurityOrigin_SummaryProvider):
1571         (WebCoreFrame_SummaryProvider):
1572         (WebCoreDocument_SummaryProvider):
1573         Add new summary providers.
1574
1575         (StdOptionalWrapper):
1576         (StdOptionalWrapper.__init__):
1577         (StdOptionalWrapper.has_value):
1578         (StdOptionalWrapper.value):
1579         Convenience data type that provides access to the fields of a std::optional<>.
1580         
1581         (WebCoreSecurityOriginProvider):
1582         (WebCoreSecurityOriginProvider.__init__):
1583         (WebCoreSecurityOriginProvider.is_unique):
1584         (WebCoreSecurityOriginProvider.scheme):
1585         (WebCoreSecurityOriginProvider.host):
1586         (WebCoreSecurityOriginProvider.port):
1587         (WebCoreSecurityOriginProvider.domain):
1588         (WebCoreSecurityOriginProvider.has_universal_access):
1589         (WebCoreSecurityOriginProvider.to_string):
1590         (WebCoreFrameProvider):
1591         (WebCoreFrameProvider.__init__):
1592         (WebCoreFrameProvider.is_main_frame):
1593         (WebCoreFrameProvider.document):
1594         (WebCoreDocumentProvider):
1595         (WebCoreDocumentProvider.__init__):
1596         (WebCoreDocumentProvider.url):
1597         (WebCoreDocumentProvider.origin):
1598         (WebCoreDocumentProvider.page_cache_state):
1599         (WebCoreDocumentProvider.frame):
1600
1601 2018-10-29  Chris Dumez  <cdumez@apple.com>
1602
1603         [PSON] When Safari restores session state after launching, going back and forward does not swap processes
1604         https://bugs.webkit.org/show_bug.cgi?id=190975
1605         <rdar://problem/45059256>
1606
1607         Reviewed by Antti Koivisto.
1608
1609         Add API test coverage.
1610
1611         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1612
1613 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1614
1615         [LFC][IFC] Compute estimated margin top for inline formatting root's ancestors
1616         https://bugs.webkit.org/show_bug.cgi?id=191018
1617
1618         Reviewed by Antti Koivisto.
1619
1620         * LayoutReloaded/misc/LFC-passing-tests.txt:
1621
1622 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1623
1624         [LFC] Add support for inflow non replaced content height when the box is an inline formatting root.
1625         https://bugs.webkit.org/show_bug.cgi?id=191011
1626
1627         Reviewed by Antti Koivisto.
1628
1629         * LayoutReloaded/misc/LFC-passing-tests.txt:
1630
1631 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1632
1633         Missing from r237549
1634
1635         Reviewed by Antti Koivisto.
1636
1637         * LayoutReloaded/misc/LFC-passing-tests.txt:
1638
1639 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1640
1641         [LFC][IFC] Add support for simple intruding floats.
1642         https://bugs.webkit.org/show_bug.cgi?id=190998
1643
1644         Reviewed by Antti Koivisto.
1645
1646         * LayoutReloaded/misc/LFC-passing-tests.txt:
1647
1648 2018-10-29  Zalan Bujtas  <zalan@apple.com>
1649
1650         [LFC][IFC] Inline layout produces separate runs when float is present.
1651         https://bugs.webkit.org/show_bug.cgi?id=190980
1652
1653         Reviewed by Antti Koivisto.
1654
1655         * LayoutReloaded/misc/LFC-passing-tests.txt:
1656
1657 2018-10-29  Tadeu Zagallo  <tzagallo@apple.com>
1658
1659         New bytecode format for JSC
1660         https://bugs.webkit.org/show_bug.cgi?id=187373
1661         <rdar://problem/44186758>
1662
1663         Reviewed by Filip Pizlo.
1664
1665         Do not force ENABLE_JIT=true when $forceCLoop is false.
1666
1667         * Scripts/build-jsc:
1668
1669 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
1670
1671         [GTK] Try to fix the xserver-xorg build in the Ubuntu LTS bot
1672
1673         Unreviewed build fix
1674
1675         The build fails because of some array-bound check related
1676         to strcmp() macro optimizations. Disabling selective Werrors
1677         when building xserver-xorg might get past this.
1678
1679         * gtk/jhbuild.modules: Add --disable-selective-werror to xserver-xorg
1680         configuration.
1681
1682 2018-10-29  Claudio Saavedra  <csaavedra@igalia.com>
1683
1684         [GTK] Update API test expectations after r237383
1685         https://bugs.webkit.org/show_bug.cgi?id=186913
1686
1687         Unreviewed gardening.
1688
1689         * TestWebKitAPI/glib/TestExpectations.json: Remove
1690         passing TestSSL tests.
1691
1692 2018-10-28  Zan Dobersek  <zdobersek@igalia.com>
1693
1694         [WPE] Add the WebKitVersion.h header
1695         https://bugs.webkit.org/show_bug.cgi?id=191015
1696
1697         Reviewed by Michael Catanzaro.
1698
1699         * MiniBrowser/wpe/main.cpp:
1700         (automationStartedCallback): Remove the FIXME and finally enable the
1701         webkit_application_info_set_version() call.
1702         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Remove
1703         this FIXME as well and remove the custom WEBKIT_*_VERSION macros.
1704
1705 2018-10-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1706
1707         [Win] Remove obsolete code for vcxproj builds in build-api-tests and build-jsc
1708         https://bugs.webkit.org/show_bug.cgi?id=190948
1709
1710         Reviewed by Brent Fulgham.
1711
1712         vcxproj files have been removed in Bug 154388.
1713
1714         * Scripts/build-api-tests: Removed obsolete code to build vcproj.
1715         * Scripts/build-jsc:
1716         (buildMyProject): Ditto. Removed a condition of buiding bmalloc
1717         which is not used because Windows ports are using CMake.
1718
1719 2018-10-28  Geoffrey Garen  <ggaren@apple.com>
1720
1721         HashMap should support selecting a random entry
1722         https://bugs.webkit.org/show_bug.cgi?id=190814
1723
1724         Reviewed by Ryosuke Niwa.
1725
1726         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Renamed IsRandom to
1727         IsEvenlyDistributed to reflect the fact that we're only testing the
1728         distribution. Added a test case that covers more table densities and
1729         the remove() operation.
1730
1731 2018-10-27  Charlie Turner  <cturner@igalia.com>
1732
1733         [GTK] Add bubblewrap feature option
1734         https://bugs.webkit.org/show_bug.cgi?id=190981
1735
1736         Reviewed by Xabier Rodriguez-Calvar.
1737
1738         Without this, it was not possible to disable the bubblewrap sandbox
1739         from the webkit build scripts.
1740
1741         * Scripts/webkitperl/FeatureList.pm:
1742
1743 2018-10-26  Commit Queue  <commit-queue@webkit.org>
1744
1745         Unreviewed, rolling out r237479 and r237484.
1746         https://bugs.webkit.org/show_bug.cgi?id=190978
1747
1748         broke JSC on iOS (Requested by tadeuzagallo on #webkit).
1749
1750         Reverted changesets:
1751
1752         "New bytecode format for JSC"
1753         https://bugs.webkit.org/show_bug.cgi?id=187373
1754         https://trac.webkit.org/changeset/237479
1755
1756         "Gardening: Build fix after r237479."
1757         https://bugs.webkit.org/show_bug.cgi?id=187373
1758         https://trac.webkit.org/changeset/237484
1759
1760 2018-10-26  Tadeu Zagallo  <tzagallo@apple.com>
1761
1762         New bytecode format for JSC
1763         https://bugs.webkit.org/show_bug.cgi?id=187373
1764         <rdar://problem/44186758>
1765
1766         Reviewed by Filip Pizlo.
1767
1768         Do not force ENABLE_JIT=true when $forceCLoop is false.
1769
1770         * Scripts/build-jsc:
1771
1772 2018-10-26  Geoffrey Garen  <ggaren@apple.com>
1773
1774         HashMap should support selecting a random entry
1775         https://bugs.webkit.org/show_bug.cgi?id=190814
1776
1777         Reviewed by Antti Koivisto.
1778
1779         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Updated the Random_IsRandom to
1780         more thoroughly test for randomness.
1781
1782 2018-10-26  Antti Koivisto  <antti@apple.com>
1783
1784         hashSet.remove(hashSet.random()) doesn't build
1785         https://bugs.webkit.org/show_bug.cgi?id=190953
1786
1787         Reviewed by Chris Dumez.
1788
1789         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1790         (TestWebKitAPI::TEST):
1791
1792 2018-10-26  Zalan Bujtas  <zalan@apple.com>
1793
1794         [LFC][IFC] Layout floats as part of the inline content
1795         https://bugs.webkit.org/show_bug.cgi?id=190942
1796
1797         Reviewed by Antti Koivisto.
1798
1799         * LayoutReloaded/misc/LFC-passing-tests.txt:
1800
1801 2018-10-26  Alicia Boya García  <aboya@igalia.com>
1802
1803         [MSE][WTF][Media] Invalid MediaTime should be falsy
1804         https://bugs.webkit.org/show_bug.cgi?id=190893
1805
1806         Reviewed by Jer Noble.
1807
1808         This patch adds additional API tests for the conversions from
1809         MediaTime to boolean.
1810
1811         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1812         (TestWebKitAPI::TEST):
1813
1814 2018-10-25  Chris Dumez  <cdumez@apple.com>
1815
1816         [PSON] Navigating cross-site with locked history but unlocked back/forward list fails to create a new BackForwardListItem
1817         https://bugs.webkit.org/show_bug.cgi?id=190915
1818         <rdar://problem/45059069>
1819
1820         Reviewed by Geoffrey Garen.
1821
1822         Add API test coverage.
1823
1824         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1825
1826 2018-10-25  Joseph Pecoraro  <pecoraro@apple.com>
1827
1828         Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
1829         https://bugs.webkit.org/show_bug.cgi?id=190896
1830
1831         Reviewed by Matt Baker.
1832
1833         * Scripts/webkitpy/common/config/watchlist:
1834
1835 2018-10-25  Geoffrey Garen  <ggaren@apple.com>
1836
1837         HashMap should support selecting a random entry
1838         https://bugs.webkit.org/show_bug.cgi?id=190814
1839
1840         Reviewed by Antti Koivisto.
1841
1842         Unit testing is fun and easy!
1843
1844         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1845         (TestWebKitAPI::ZeroHash::hash):
1846         (TestWebKitAPI::TEST):
1847
1848 2018-10-24  Tim Horton  <timothy_horton@apple.com>
1849
1850         REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
1851         https://bugs.webkit.org/show_bug.cgi?id=190897
1852
1853         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1854         (TestWebKitAPI::TEST):
1855         Disable the test for now.
1856
1857 2018-10-24  Alexey Proskuryakov  <ap@apple.com>
1858
1859         Clean up some obsolete macOS version guards
1860         https://bugs.webkit.org/show_bug.cgi?id=190887
1861
1862         Reviewed by Dan Bernstein.
1863
1864         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1865         (__simulated_forceClickAssociatedEventsMask):
1866         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:clickCount:]):
1867         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1868         (WTR::initializeWebViewConfiguration):
1869         * WebKitTestRunner/mac/EventSenderProxy.mm:
1870         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
1871
1872 2018-10-24  Megan Gardner  <megan_gardner@apple.com>
1873
1874         Turn on Conic Gradients
1875         https://bugs.webkit.org/show_bug.cgi?id=190810
1876
1877         Reviewed by Tim Horton.
1878
1879         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1880
1881 2018-10-24  Pablo Saavedra  <psaavedra@igalia.com>
1882
1883         [WPE] Fix CMake rules in for TestWebKitAPIBase library building in developer mode
1884         https://bugs.webkit.org/show_bug.cgi?id=190328
1885
1886         Reviewed by Michael Catanzaro.
1887
1888         * TestWebKitAPI/CMakeLists.txt:
1889         * TestWebKitAPI/PlatformWPE.cmake:
1890
1891 2018-10-24  Chris Dumez  <cdumez@apple.com>
1892
1893         [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
1894         https://bugs.webkit.org/show_bug.cgi?id=190846
1895         <rdar://problem/45058938>
1896
1897         Reviewed by Antti Koivisto.
1898
1899         Add API test coverage.
1900
1901         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1902
1903 2018-10-24  Claudio Saavedra  <csaavedra@igalia.com>
1904
1905         [GTK] TestSSL failing because of missing libsoup patch
1906         https://bugs.webkit.org/show_bug.cgi?id=190869
1907
1908         Reviewed by Michael Catanzaro.
1909
1910         * gtk/jhbuild.modules: Add the patch below to fix the API test TestSSL
1911         * gtk/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.
1912
1913 2018-10-23  Justin Fan  <justin_fan@apple.com>
1914
1915         [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
1916         https://bugs.webkit.org/show_bug.cgi?id=190817
1917
1918         Reviewed by Dean Jackson.
1919
1920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1921         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm.
1922         (TestWebKitAPI::TEST_F):
1923         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Copied from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1924         (TestWebKitAPI::TEST_F):
1925         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm.
1926         (TestWebKitAPI::TEST_F):
1927         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm.
1928         (TestWebKitAPI::TEST_F):
1929         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm.
1930         (TestWebKitAPI::TEST_F):
1931         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebCore/mac/GPUTest.h.
1932
1933 2018-10-23  Chris Dumez  <cdumez@apple.com>
1934
1935         [PSON] Add support for cross-site client-side redirects
1936         https://bugs.webkit.org/show_bug.cgi?id=190806
1937         <rdar://problem/45047344>
1938
1939         Reviewed by Geoffrey Garen.
1940
1941         Add API test coverage.
1942
1943         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1944         (-[PSONNavigationDelegate _webView:willPerformClientRedirectToURL:delay:]):
1945         (-[PSONNavigationDelegate _webView:didPerformClientRedirectFromURL:toURL:]):
1946
1947 2018-10-23  Claudio Saavedra  <csaavedra@igalia.com>
1948
1949         [WPE][GTK] Pass full certificate chain in CertificateInfo coder
1950         https://bugs.webkit.org/show_bug.cgi?id=190789
1951
1952         Reviewed by Michael Catanzaro.
1953
1954         When the network process serializes certificate data to other
1955         processes through the argument coders, the certificate chain, if
1956         present, is lost. In practice this means that applications using
1957         the public API to process certificate info have no details on the
1958         certificate chain, other than the very basics included in the
1959         certificate. Serialize the entire chain if available in the
1960         certificate.
1961
1962         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1963         (testSSL): Test that the self-signed certificate has no bogus
1964         issuer certificate.
1965
1966 2018-10-22  Tim Horton  <timothy_horton@apple.com>
1967
1968         REGRESSION (r237331): InteractionDeadlockAfterCrash API test fails
1969         https://bugs.webkit.org/show_bug.cgi?id=190801
1970         <rdar://problem/43674361>
1971
1972         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
1973         (TEST):
1974         Use a parented WKWebView for this test, otherwise none of the assertions
1975         about gesture recognizers work anymore.
1976
1977 2018-10-22  Ryan Haddad  <ryanhaddad@apple.com>
1978
1979         REGRESSION (r234081): TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction is a flaky timeout
1980         https://bugs.webkit.org/show_bug.cgi?id=187972
1981
1982         Unreviewed test gardening.
1983
1984         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
1985         (TestWebKitAPI::TEST): Disable the flaky test.
1986
1987 2018-10-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1988
1989         [iOS] [Datalist] fast/forms/datalist/datalist-show-hide.html fails
1990         https://bugs.webkit.org/show_bug.cgi?id=190777
1991
1992         Reviewed by Tim Horton.
1993
1994         Implement isShowingDataListSuggestions on iOS. See below for more details.
1995
1996         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1997         (WTR::UIScriptController::isShowingDataListSuggestions const):
1998
1999         Add a stub implementation for DumpRenderTree.
2000
2001         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2002         (WTR::UIScriptController::isShowingDataListSuggestions const):
2003
2004         Move this stub implementation to !PLATFORM(COCOA).
2005
2006         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2007         (WTR::forEachViewInHierarchy):
2008
2009         Add a helper function to apply a given function to a UIView and each of its subviews, recursively.
2010
2011         (WTR::UIScriptController::isShowingDataListSuggestions const):
2012
2013         For iOS, return whether the UIRemoteKeyboardWindow contains a subview of type WKDataListSuggestionsPickerView.
2014
2015 2018-10-19  Dan Bernstein  <mitz@apple.com>
2016
2017         [macOS] MiniBrowser has an unused injected bundle
2018         https://bugs.webkit.org/show_bug.cgi?id=190770
2019
2020         Reviewed by Tim Horton.
2021
2022         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Removed.
2023         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed the MiniBrowserBundle target,
2024           the Copy Bundle build phase in the MiniBrowser target, and references to removed files.
2025         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Removed.
2026         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Removed.
2027         * MiniBrowser/mac/Bundle: Removed.
2028
2029 2018-10-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2030
2031         [iOS] [Datalist] Can't pick datalist suggestions in a stock WKWebView
2032         https://bugs.webkit.org/show_bug.cgi?id=190621
2033         <rdar://problem/45310649>
2034
2035         Reviewed by Tim Horton.
2036
2037         Add a UIScriptController hook to resign first responder on WKWebView. See LayoutTests/ChangeLog for more detail.
2038
2039         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2040         (WTR::UIScriptController::resignFirstResponder):
2041         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2042         (WTR::UIScriptController::resignFirstResponder):
2043         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2044         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2045         (WTR::UIScriptController::resignFirstResponder):
2046         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2047         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2048         (WTR::UIScriptController::resignFirstResponder):
2049         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2050         (WTR::PlatformWebView::makeWebViewFirstResponder):
2051
2052         Implement this method stub on iOS, to ensure that TestController::resetStateToConsistentValues restores first
2053         responder on the WKWebView when running iOS layout tests.
2054
2055         * WebKitTestRunner/ios/TestControllerIOS.mm:
2056         (WTR::TestController::platformResetStateToConsistentValues):
2057
2058         After resigning first responder to dismiss any on-screen keyboard, ensure that we restore first responder.
2059
2060 2018-10-19  Dean Jackson  <dino@apple.com>
2061
2062         ASSERTION FAILED: !frame().animation().hasAnimations() in WebCore::FrameView::didDestroyRenderTree()
2063         https://bugs.webkit.org/show_bug.cgi?id=186946
2064         <rdar://problem/41724248>
2065
2066         Reviewed by Antoine Quint.
2067
2068         If the incoming test has different enableWebAnimationsCSSIntegration options,
2069         then we need to create a new WebView.
2070
2071         * DumpRenderTree/TestOptions.cpp:
2072         (TestOptions::webViewIsCompatibleWithOptions const):
2073
2074 2018-10-19  Charlie Turner  <cturner@igalia.com>
2075
2076         [EME] Fix crash during tracing in  gst_qtdemux_request_protection_context
2077         https://bugs.webkit.org/show_bug.cgi?id=190738
2078
2079         Reviewed by Xabier Rodriguez-Calvar.
2080
2081         Add a GStreamer patch to avoid crashing when the run-time logging
2082         level is TRACE. There was a missing null check which caused many
2083         tests to crash.
2084
2085         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Added.
2086
2087 2018-10-18  Alicia Boya García  <aboya@igalia.com>
2088
2089         [Media] Use nanoseconds as MaximumTimeScale
2090         https://bugs.webkit.org/show_bug.cgi?id=190631
2091
2092         Rebased MediaTime tests covering timescales over the maximum.
2093
2094         Reviewed by Jer Noble.
2095
2096         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2097         (TestWebKitAPI::TEST):
2098
2099 2018-10-18  Dean Johnson  <dean_johnson@apple.com>
2100
2101         clean-webkit pulls in many unnecessary dependencies in webkitpy
2102         https://bugs.webkit.org/show_bug.cgi?id=190732
2103
2104         Reviewed by Alexey Proskuryakov.
2105
2106         * Scripts/webkitpy/common/host.py:
2107         (Host.__init__): Split out 'bugs', 'bugzilla', and 'web' to only be created when used.
2108         (Host):
2109         (Host.bugs):
2110         (Host.bugzilla):
2111         (Host.web):
2112
2113 2018-10-18  Chris Dumez  <cdumez@apple.com>
2114
2115         [PSON] SuspendedPages do not report meaningful domains in Activity Monitor
2116         https://bugs.webkit.org/show_bug.cgi?id=190721
2117         <rdar://problem/45059699>
2118
2119         Reviewed by Alex Christensen.
2120
2121         Add API test coverage.
2122
2123         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2124
2125 2018-10-18  Alexey Proskuryakov  <ap@apple.com>
2126
2127         Switch from PLATFORM(IOS) to PLATFORM(IOS_FAMILY)
2128         https://bugs.webkit.org/show_bug.cgi?id=190729
2129
2130         Reviewed by Tim Horton.
2131
2132         * DumpRenderTree/AccessibilityController.h:
2133         * DumpRenderTree/AccessibilityTextMarker.h:
2134         * DumpRenderTree/AccessibilityUIElement.cpp:
2135         (AccessibilityUIElement::getJSClass):
2136         * DumpRenderTree/AccessibilityUIElement.h:
2137         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
2138         * DumpRenderTree/TestRunner.cpp:
2139         (getSecureEventInputIsEnabledCallback):
2140         (TestRunner::staticFunctions):
2141         (TestRunner::callUIScriptCallback):
2142         * DumpRenderTree/TestRunner.h:
2143         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2144         * DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm:
2145         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2146         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
2147         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
2148         * DumpRenderTree/ios/TextInputControllerIOS.m:
2149         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2150         * DumpRenderTree/mac/AppleScriptController.m:
2151         * DumpRenderTree/mac/DumpRenderTree.mm:
2152         (createWebViewAndOffscreenWindow):
2153         (destroyWebViewAndOffscreenWindow):
2154         (resetWebPreferencesToConsistentValues):
2155         (setDefaultsToConsistentValuesForTesting):
2156         (allocateGlobalControllers):
2157         (releaseGlobalControllers):
2158         (addTestPluginsToPluginSearchPath):
2159         (prepareConsistentTestingEnvironment):
2160         (dumpRenderTree):
2161         (DumpRenderTreeMain):
2162         (dumpFrameAsPDF):
2163         (dumpBackForwardListForAllWindows):
2164         (updateDisplay):
2165         (dump):
2166         (resetWebViewToConsistentStateBeforeTesting):
2167         (runTest):
2168         (displayWebView):
2169         (displayAndTrackRepaintsWebView):
2170         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2171         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2172         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2173         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2174         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2175         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2176         (-[DumpRenderTreeWindow close]):
2177         (-[DumpRenderTreeWindow webView]):
2178         (-[DumpRenderTreeWindow webViewStartedAcceleratedCompositing:]):
2179         * DumpRenderTree/mac/EventSendingController.h:
2180         * DumpRenderTree/mac/EventSendingController.mm:
2181         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2182         (+[EventSendingController webScriptNameForSelector:]):
2183         (-[EventSendingController dealloc]):
2184         (-[EventSendingController currentEventTime]):
2185         (-[EventSendingController clearKillRing]):
2186         (modifierFlags):
2187         (-[EventSendingController mouseDown:withModifiers:]):
2188         (-[EventSendingController scalePageBy:atX:andY:]):
2189         (-[EventSendingController mouseUp:withModifiers:]):
2190         (-[EventSendingController mouseMoveToX:Y:]):
2191         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2192         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2193         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2194         (-[FrameLoadDelegate init]):
2195         (-[FrameLoadDelegate dealloc]):
2196         (-[FrameLoadDelegate processWork:]):
2197         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2198         (-[FrameLoadDelegate webView:didCommitLoadForFrame:]):
2199         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
2200         * DumpRenderTree/mac/LayoutTestHelper.m:
2201         * DumpRenderTree/mac/MockGeolocationProvider.mm:
2202         (-[MockGeolocationProvider timerFired]):
2203         * DumpRenderTree/mac/TestRunnerMac.mm:
2204         (TestRunner::setMainFrameIsFirstResponder):
2205         (TestRunner::setAutomaticLinkDetectionEnabled):
2206         (TestRunner::setUseDashboardCompatibilityMode):
2207         (TestRunner::isCommandEnabled):
2208         (TestRunner::inspectorTestStubURL):
2209         (TestRunner::apiTestNewWindowDataLoadBaseURL):
2210         (TestRunner::abortModal):
2211         (TestRunner::setTextDirection):
2212         (TestRunner::addChromeInputField):
2213         (TestRunner::removeChromeInputField):
2214         (TestRunner::focusWebView):
2215         (TestRunner::setBackingScaleFactor):
2216         (TestRunner::imageCountInGeneralPasteboard const):
2217         * DumpRenderTree/mac/UIDelegate.h:
2218         * DumpRenderTree/mac/UIDelegate.mm:
2219         (-[UIDelegate modalWindowWillClose:]):
2220         (-[UIDelegate webViewRunModal:]):
2221         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2222         (-[UIDelegate dealloc]):
2223         * Scripts/check-for-inappropriate-objc-class-names:
2224         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2225         * TestRunnerShared/spi/UIKitTestSPI.h:
2226         * TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
2227         * TestWebKitAPI/Tests/WebCore/MarkedText.cpp:
2228         (WebCore::operator<<):
2229         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
2230         (TestWebKitAPI::TEST):
2231         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2232         (TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
2233         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:
2234         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
2235         (TestWebKitAPI::TEST):
2236         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
2237         (TestWebKitAPI::TEST):
2238         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLs.mm:
2239         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
2240         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
2241         (TEST):
2242         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandle.mm:
2243         (TEST):
2244         * TestWebKitAPI/Tests/WebKitCocoa/BundleRangeHandlePlugIn.mm:
2245         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2246         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
2247         (TEST):
2248         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
2249         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
2250         (createWebViewWithCustomPasteboardDataEnabled):
2251         * TestWebKitAPI/Tests/WebKitCocoa/Copying.mm:
2252         (TEST):
2253         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
2254         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
2255         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
2256         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
2257         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
2258         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
2259         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
2260         * TestWebKitAPI/Tests/WebKitCocoa/Geolocation.mm:
2261         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
2262         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2263         (defaultWebsiteCacheDirectory):
2264         (defaultApplicationCacheDirectory):
2265         (TEST):
2266         * TestWebKitAPI/Tests/WebKitCocoa/NSFileManagerExtras.mm:
2267         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
2268         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
2269         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
2270         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
2271         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
2272         (TestWebKitAPI::TEST):
2273         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
2274         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2275         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptions.mm:
2276         (runTestWithWidth):
2277         * TestWebKitAPI/Tests/WebKitCocoa/RenderedImageWithOptionsPlugIn.mm:
2278         (-[RenderedImageWithOptionsPlugIn renderImageWithWidth:completionHandler:]):
2279         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2280         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
2281         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2282         * TestWebKitAPI/Tests/WebKitCocoa/VisibleContentRect.mm:
2283         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2284         (platformCopyRichTextWithMultipleAttachments):
2285         (platformCopyRichTextWithImage):
2286         (platformCopyPNG):
2287         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
2288         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
2289         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2290         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFViewStablePresentationUpdateCallback.mm:
2291         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2292         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-leaks.mm:
2293         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2294         (TEST):
2295         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2296         (TEST):
2297         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2298         (TEST):
2299         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
2300         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2301         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
2302         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
2303         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2304         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2305         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2306         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
2307         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2308         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2309         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
2310         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
2311         * TestWebKitAPI/Tests/ios/SynchronousTimeoutTests.mm:
2312         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
2313         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
2314         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
2315         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
2316         * TestWebKitAPI/Tests/ios/WKScrollViewDelegate.mm:
2317         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
2318         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2319         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm:
2320         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2321         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
2322         (-[WKWebView _test_waitForDidFinishNavigation]):
2323         * TestWebKitAPI/cocoa/TestWKWebView.h:
2324         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2325         * TestWebKitAPI/config.h:
2326         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2327         * TestWebKitAPI/ios/TestWKWebViewController.h:
2328         * TestWebKitAPI/ios/TestWKWebViewController.mm:
2329         * TestWebKitAPI/ios/UIKitSPI.h:
2330         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2331         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2332         (WTR::InjectedBundle::beginTesting):
2333         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2334         (WTR::TestRunner::inspectorTestStubURL):
2335         * WebKitTestRunner/TestController.cpp:
2336         (WTR::TestController::webProcessName):
2337         (WTR::TestController::networkProcessName):
2338         * WebKitTestRunner/TestInvocation.cpp:
2339         (WTR::TestInvocation::invoke):
2340         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2341         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2342         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2343         (WTR::initializeWebViewConfiguration):
2344         (WTR::TestController::platformCreateWebView):
2345         (WTR::TestController::imageCountInGeneralPasteboard const):
2346         (WTR::TestController::addTestKeyToKeychain):
2347         (WTR::TestController::cleanUpKeychain):
2348         (WTR::TestController::keyExistsInKeychain):
2349         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2350         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2351         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2352
2353 2018-10-18  Chris Dumez  <cdumez@apple.com>
2354
2355         [PSON] Cap number of SuspendedPageProxy objects and allow a WebPageProxy to have more than one
2356         https://bugs.webkit.org/show_bug.cgi?id=190688
2357         <rdar://problem/45354095>
2358
2359         Reviewed by Antti Koivisto.
2360
2361         Extended API test coverage to confirm that:
2362         - We do not accumulate more than 3 suspended processes.
2363         - We can navigate back 3 times and use the page cache for each of these loads.
2364
2365         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2366
2367 2018-10-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2368
2369         Enable the datalist element by default on iOS and macOS
2370         https://bugs.webkit.org/show_bug.cgi?id=190594
2371         <rdar://problem/45281159>
2372
2373         Reviewed by Ryosuke Niwa and Tim Horton.
2374
2375         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2376
2377 2018-10-17  Chris Fleizach  <cfleizach@apple.com>
2378
2379         AX: Certain tags should identify their context to iOS API
2380         https://bugs.webkit.org/show_bug.cgi?id=190622
2381         <rdar://problem/45308194>
2382
2383         Reviewed by Zalan Bujtas.
2384
2385         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2386         (AccessibilityUIElement::stringAttributeValue):
2387         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2388         (WTR::AccessibilityUIElement::stringAttributeValue):
2389
2390 2018-10-16  Sihui Liu  <sihui_liu@apple.com>
2391
2392         Add a switch for Web SQL
2393         https://bugs.webkit.org/show_bug.cgi?id=190271
2394
2395         Reviewed by Ryosuke Niwa.
2396
2397         * WebKitTestRunner/TestController.cpp:
2398         (WTR::TestController::resetPreferencesToConsistentValues):
2399
2400 2018-10-16  Alex Christensen  <achristensen@webkit.org>
2401
2402         Remove InjectedBundleBackForwardList
2403         https://bugs.webkit.org/show_bug.cgi?id=190640
2404
2405         Reviewed by Chris Dumez.
2406
2407         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2408         (WTR::InjectedBundle::dumpBackForwardListsForAllPages):
2409         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2410         (WTR::InjectedBundlePage::prepare):
2411         (WTR::InjectedBundlePage::dumpHistory):
2412         (WTR::hasPrefix): Deleted.
2413         (WTR::compareByTargetName): Deleted.
2414         (WTR::dumpBackForwardListItem): Deleted.
2415         (WTR::InjectedBundlePage::dumpBackForwardList): Deleted.
2416         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2417         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2418         (WTR::TestRunner::clearBackForwardList):
2419
2420 2018-10-16  Dominik Infuehr  <dinfuehr@igalia.com>
2421
2422         Unreviewed, added myself to contributors.json.
2423
2424         * Scripts/webkitpy/common/config/contributors.json:
2425
2426 2018-10-16  Justin Michaud  <justin_michaud@apple.com>
2427
2428         Implement feature flag and bindings for CSS Painting API
2429         https://bugs.webkit.org/show_bug.cgi?id=190237
2430
2431         Reviewed by Ryosuke Niwa.
2432
2433         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2434
2435 2018-10-16  Philippe Normand  <pnormand@igalia.com>
2436
2437         Unreviewed, GTK Ubuntu LTS Jhbuild prospective build fix
2438
2439         * gstreamer/jhbuild.modules:
2440
2441 2018-10-16  Philippe Normand  <pnormand@igalia.com>
2442
2443         [GTK][JHBuild] Disable libmount support in glib
2444
2445         Rubber-stamped by Alejandro G. Castro.
2446
2447         This feature doesn't seem required for our setup.
2448
2449         * gtk/jhbuild.modules:
2450
2451 2018-10-15  Justin Fan  <justin_fan@apple.com>
2452
2453         Add WebGPU 2018 feature flag and experimental feature flag
2454         https://bugs.webkit.org/show_bug.cgi?id=190509
2455
2456         Reviewed by Dean Jackson.
2457
2458         Re-add ENABLE_WEBGPU, an experimental feature flag, and a RuntimeEnabledFeature
2459         for the 2018 WebGPU prototype.
2460
2461         * DumpRenderTree/TestOptions.cpp:
2462         (TestOptions::TestOptions):
2463         * DumpRenderTree/TestOptions.h:
2464         * DumpRenderTree/mac/DumpRenderTree.mm:
2465         (setWebPreferencesForTestOptions):
2466         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2467
2468 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2469
2470         Update bot configuration for Sierra archive queues
2471         https://bugs.webkit.org/show_bug.cgi?id=190605
2472
2473         Reviewed by Aakash Jain.
2474
2475         * BuildSlaveSupport/build.webkit.org-config/config.json:
2476
2477 2018-10-15  Timothy Hatcher  <timothy@apple.com>
2478
2479         Add support for prefers-color-scheme media query
2480         https://bugs.webkit.org/show_bug.cgi?id=190499
2481         rdar://problem/45212025
2482
2483         Reviewed by Dean Jackson.
2484
2485         * Scripts/webkitperl/FeatureList.pm: Added ENABLE_DARK_MODE_CSS as dark-mode-css.
2486         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_DARK_MODE_CSS.
2487
2488 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
2489
2490         [JHBuild] Add xdg-dbus-proxy module
2491         https://bugs.webkit.org/show_bug.cgi?id=190589
2492
2493         Reviewed by Michael Catanzaro.
2494
2495         * gtk/jhbuild.modules:
2496
2497 2018-10-15  Patrick Griffis  <pgriffis@igalia.com>
2498
2499         [GTK] Add new sandboxing dependencies to install-dependencies
2500         https://bugs.webkit.org/show_bug.cgi?id=190588
2501
2502         Reviewed by Michael Catanzaro.
2503
2504         * gtk/install-dependencies:
2505
2506 2018-10-15  Chris Dumez  <cdumez@apple.com>
2507
2508         Experiment: target=_blank on anchors should imply rel=noopener
2509         https://bugs.webkit.org/show_bug.cgi?id=190481
2510
2511         Reviewed by Alex Christensen.
2512
2513         Add API test coverage to make sure we can now swap process when target=_blank
2514         is specified on an anchor but rel=noopener is not.
2515
2516         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2517
2518 2018-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
2519
2520         [iOS] Can't select text after dismissing the keyboard when changing focus
2521         https://bugs.webkit.org/show_bug.cgi?id=190563
2522         <rdar://problem/44613559>
2523
2524         Reviewed by Tim Horton.
2525
2526         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2527         (WTR::UIScriptController::isShowingKeyboard const):
2528
2529         Add a new UIScriptController method that returns whether the keyboard is shown. See `ui-helper.js` for more
2530         details.
2531
2532         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2533         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2534         (WTR::UIScriptController::isShowingKeyboard const):
2535         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2536         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2537         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2538
2539         Also rename the `isShowingKeyboard` Objective-C property to the more canonical `showingKeyboard`, with
2540         `isShowingKeyboard` as the getter method.
2541
2542         (-[TestRunnerWKWebView _invokeShowKeyboardCallbackIfNecessary]):
2543         (-[TestRunnerWKWebView _invokeHideKeyboardCallbackIfNecessary]):
2544         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2545         (WTR::UIScriptController::isShowingKeyboard const):
2546
2547 2018-10-15  Ryan Haddad  <ryanhaddad@apple.com>
2548
2549         Unreviewed, fix JSC tests after WebGPUShadingLanguageRI directory was removed in r237115.
2550
2551         * Scripts/run-javascriptcore-tests:
2552         (runJSCStressTests): Remove wsl-tests.yaml.
2553
2554 2018-10-15  Christopher Reid  <chris.reid@sony.com>
2555
2556         [Curl][WinCairo] Add Public Suffix support to WinCairo
2557         https://bugs.webkit.org/show_bug.cgi?id=183060
2558
2559         Reviewed by Alex Christensen.
2560
2561         Share mac's PublicSuffix tests with all ports.
2562
2563         * TestWebKitAPI/PlatformWin.cmake:
2564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2565         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:
2566         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Removed.
2567
2568 2018-10-15  Myles C. Maxfield  <mmaxfield@apple.com>
2569
2570         [WHLSL] Migrated WebGPUShadingLanguageRI to the W3C
2571         https://bugs.webkit.org/show_bug.cgi?id=190555
2572
2573         Unreviewed.
2574
2575         Migrated to https://github.com/gpuweb/WHLSL/tree/master/Source
2576
2577         * WebGPUShadingLanguageRI/AddressSpace.js: Removed.
2578         * WebGPUShadingLanguageRI/All.js: Removed.
2579         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Removed.
2580         * WebGPUShadingLanguageRI/AnonymousVariable.js: Removed.
2581         * WebGPUShadingLanguageRI/ArrayRefType.js: Removed.
2582         * WebGPUShadingLanguageRI/ArrayType.js: Removed.
2583         * WebGPUShadingLanguageRI/Assignment.js: Removed.
2584         * WebGPUShadingLanguageRI/AutoWrapper.js: Removed.
2585         * WebGPUShadingLanguageRI/Block.js: Removed.
2586         * WebGPUShadingLanguageRI/BoolLiteral.js: Removed.
2587         * WebGPUShadingLanguageRI/Break.js: Removed.
2588         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Removed.
2589         * WebGPUShadingLanguageRI/BuiltinMatrixGetter.js: Removed.
2590         * WebGPUShadingLanguageRI/BuiltinMatrixSetter.js: Removed.
2591         * WebGPUShadingLanguageRI/BuiltinVectorGetter.js: Removed.
2592         * WebGPUShadingLanguageRI/BuiltinVectorSetter.js: Removed.
2593         * WebGPUShadingLanguageRI/CallExpression.js: Removed.
2594         * WebGPUShadingLanguageRI/CallFunction.js: Removed.
2595         * WebGPUShadingLanguageRI/Casts.js: Removed.
2596         * WebGPUShadingLanguageRI/Check.js: Removed.
2597         * WebGPUShadingLanguageRI/CheckLiteralTypes.js: Removed.
2598         * WebGPUShadingLanguageRI/CheckLoops.js: Removed.
2599         * WebGPUShadingLanguageRI/CheckNativeFuncStages.js: Removed.
2600         * WebGPUShadingLanguageRI/CheckRecursion.js: Removed.
2601         * WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Removed.
2602         * WebGPUShadingLanguageRI/CheckReturns.js: Removed.
2603         * WebGPUShadingLanguageRI/CheckTypesWithArguments.js: Removed.
2604         * WebGPUShadingLanguageRI/CheckUnreachableCode.js: Removed.
2605         * WebGPUShadingLanguageRI/CheckWrapped.js: Removed.
2606         * WebGPUShadingLanguageRI/Checker.js: Removed.
2607         * WebGPUShadingLanguageRI/CloneProgram.js: Removed.
2608         * WebGPUShadingLanguageRI/CommaExpression.js: Removed.
2609         * WebGPUShadingLanguageRI/ConstexprFolder.js: Removed.
2610         * WebGPUShadingLanguageRI/Continue.js: Removed.
2611         * WebGPUShadingLanguageRI/ConvertPtrToArrayRefExpression.js: Removed.
2612         * WebGPUShadingLanguageRI/CreateLiteral.js: Removed.
2613         * WebGPUShadingLanguageRI/CreateLiteralType.js: Removed.
2614         * WebGPUShadingLanguageRI/DereferenceExpression.js: Removed.
2615         * WebGPUShadingLanguageRI/DoWhileLoop.js: Removed.
2616         * WebGPUShadingLanguageRI/DotExpression.js: Removed.
2617         * WebGPUShadingLanguageRI/EArrayRef.js: Removed.
2618         * WebGPUShadingLanguageRI/EBuffer.js: Removed.
2619         * WebGPUShadingLanguageRI/EBufferBuilder.js: Removed.
2620         * WebGPUShadingLanguageRI/EPtr.js: Removed.
2621         * WebGPUShadingLanguageRI/EnumLiteral.js: Removed.
2622         * WebGPUShadingLanguageRI/EnumMember.js: Removed.
2623         * WebGPUShadingLanguageRI/EnumType.js: Removed.
2624         * WebGPUShadingLanguageRI/EvaluationCommon.js: Removed.
2625         * WebGPUShadingLanguageRI/Evaluator.js: Removed.
2626         * WebGPUShadingLanguageRI/Expression.js: Removed.
2627         * WebGPUShadingLanguageRI/ExpressionFinder.js: Removed.
2628         * WebGPUShadingLanguageRI/ExternalOrigin.js: Removed.
2629         * WebGPUShadingLanguageRI/Field.js: Removed.
2630         * WebGPUShadingLanguageRI/FindHighZombies.js: Removed.
2631         * WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Removed.
2632         * WebGPUShadingLanguageRI/FloatLiteral.js: Removed.
2633         * WebGPUShadingLanguageRI/FloatLiteralType.js: Removed.
2634         * WebGPUShadingLanguageRI/FoldConstexprs.js: Removed.
2635         * WebGPUShadingLanguageRI/ForLoop.js: Removed.
2636         * WebGPUShadingLanguageRI/Func.js: Removed.
2637         * WebGPUShadingLanguageRI/FuncAttribute.js: Removed.
2638         * WebGPUShadingLanguageRI/FuncDef.js: Removed.
2639         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Removed.
2640         * WebGPUShadingLanguageRI/FuncParameter.js: Removed.
2641         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Removed.
2642         * WebGPUShadingLanguageRI/HighZombieFinder.js: Removed.
2643         * WebGPUShadingLanguageRI/IdentityExpression.js: Removed.
2644         * WebGPUShadingLanguageRI/IfStatement.js: Removed.
2645         * WebGPUShadingLanguageRI/IndexExpression.js: Removed.
2646         * WebGPUShadingLanguageRI/InferTypesForCall.js: Removed.
2647         * WebGPUShadingLanguageRI/Inline.js: Removed.
2648         * WebGPUShadingLanguageRI/Inliner.js: Removed.
2649         * WebGPUShadingLanguageRI/IntLiteral.js: Removed.
2650         * WebGPUShadingLanguageRI/IntLiteralType.js: Removed.
2651         * WebGPUShadingLanguageRI/Intrinsics.js: Removed.
2652         * WebGPUShadingLanguageRI/LayoutBuffers.js: Removed.
2653         * WebGPUShadingLanguageRI/Lexer.js: Removed.
2654         * WebGPUShadingLanguageRI/LexerToken.js: Removed.
2655         * WebGPUShadingLanguageRI/LiteralTypeChecker.js: Removed.
2656         * WebGPUShadingLanguageRI/LogicalExpression.js: Removed.
2657         * WebGPUShadingLanguageRI/LogicalNot.js: Removed.
2658         * WebGPUShadingLanguageRI/LoopChecker.js: Removed.
2659         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Removed.
2660         * WebGPUShadingLanguageRI/MakePtrExpression.js: Removed.
2661         * WebGPUShadingLanguageRI/MatrixType.js: Removed.
2662         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Removed.
2663         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Removed.
2664         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Removed.
2665         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Removed.
2666         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Removed.
2667         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Removed.
2668         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Removed.
2669         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Removed.
2670         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Removed.
2671         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Removed.
2672         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Removed.
2673         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Removed.
2674         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Removed.
2675         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Removed.
2676         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Removed.
2677         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Removed.
2678         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Removed.
2679         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Removed.
2680         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Removed.
2681         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Removed.
2682         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Removed.
2683         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Removed.
2684         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Removed.
2685         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Removed.
2686         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Removed.
2687         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Removed.
2688         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Removed.
2689         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Removed.
2690         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Removed.
2691         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Removed.
2692         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Removed.
2693         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Removed.
2694         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Removed.
2695         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Removed.
2696         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Removed.
2697         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Removed.
2698         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Removed.
2699         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Removed.
2700         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Removed.
2701         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Removed.
2702         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Removed.
2703         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Removed.
2704         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Removed.
2705         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Removed.
2706         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Removed.
2707         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Removed.
2708         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Removed.
2709         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Removed.
2710         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Removed.
2711         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Removed.
2712         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Removed.
2713         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Removed.
2714         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Removed.
2715         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Removed.
2716         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Removed.
2717         * WebGPUShadingLanguageRI/NameContext.js: Removed.
2718         * WebGPUShadingLanguageRI/NameFinder.js: Removed.
2719         * WebGPUShadingLanguageRI/NameResolver.js: Removed.
2720         * WebGPUShadingLanguageRI/NativeFunc.js: Removed.
2721         * WebGPUShadingLanguageRI/NativeType.js: Removed.
2722         * WebGPUShadingLanguageRI/Node.js: Removed.
2723         * WebGPUShadingLanguageRI/NormalUsePropertyResolver.js: Removed.
2724         * WebGPUShadingLanguageRI/NullLiteral.js: Removed.
2725         * WebGPUShadingLanguageRI/NullType.js: Removed.
2726         * WebGPUShadingLanguageRI/OperatorAnderIndexer.js: Removed.
2727         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js: Removed.
2728         * WebGPUShadingLanguageRI/OriginKind.js: Removed.
2729         * WebGPUShadingLanguageRI/OverloadResolutionFailure.js: Removed.
2730         * WebGPUShadingLanguageRI/Parse.js: Removed.
2731         * WebGPUShadingLanguageRI/Prepare.js: Removed.
2732         * WebGPUShadingLanguageRI/Program.js: Removed.
2733         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Removed.
2734         * WebGPUShadingLanguageRI/PropertyAccessExpression.js: Removed.
2735         * WebGPUShadingLanguageRI/PropertyResolver.js: Removed.
2736         * WebGPUShadingLanguageRI/PtrType.js: Removed.
2737         * WebGPUShadingLanguageRI/ReadModifyWriteExpression.js: Removed.
2738         * WebGPUShadingLanguageRI/RecursionChecker.js: Removed.
2739         * WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Removed.
2740         * WebGPUShadingLanguageRI/ReferenceType.js: Removed.
2741         * WebGPUShadingLanguageRI/ResolveNames.js: Removed.
2742         * WebGPUShadingLanguageRI/ResolveOverloadImpl.js: Removed.
2743         * WebGPUShadingLanguageRI/ResolveProperties.js: Removed.
2744         * WebGPUShadingLanguageRI/ResolveTypeDefs.js: Removed.
2745         * WebGPUShadingLanguageRI/ResourceSemantic.js: Removed.
2746         * WebGPUShadingLanguageRI/Return.js: Removed.
2747         * WebGPUShadingLanguageRI/ReturnChecker.js: Removed.
2748         * WebGPUShadingLanguageRI/ReturnException.js: Removed.
2749         * WebGPUShadingLanguageRI/Rewriter.js: Removed.
2750         * WebGPUShadingLanguageRI/SPIR-V.js: Removed.
2751         * WebGPUShadingLanguageRI/SPIRV.html: Removed.
2752         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed.
2753         * WebGPUShadingLanguageRI/SPIRVTypeAnalyzer.js: Removed.
2754         * WebGPUShadingLanguageRI/SPIRVVariableAnalyzer.js: Removed.
2755         * WebGPUShadingLanguageRI/Sampler.js: Removed.
2756         * WebGPUShadingLanguageRI/Semantic.js: Removed.
2757         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Removed.
2758         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Removed.
2759         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed.
2760         * WebGPUShadingLanguageRI/StatementCloner.js: Removed.
2761         * WebGPUShadingLanguageRI/StructLayoutBuilder.js: Removed.
2762         * WebGPUShadingLanguageRI/StructType.js: Removed.
2763         * WebGPUShadingLanguageRI/SwitchCase.js: Removed.
2764         * WebGPUShadingLanguageRI/SwitchStatement.js: Removed.
2765         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js: Removed.
2766         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js: Removed.
2767         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js: Removed.
2768         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js: Removed.
2769         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Removed.
2770         * WebGPUShadingLanguageRI/TernaryExpression.js: Removed.
2771         * WebGPUShadingLanguageRI/Test.html: Removed.
2772         * WebGPUShadingLanguageRI/Test.js: Removed.
2773         * WebGPUShadingLanguageRI/Texture.js: Removed.
2774         * WebGPUShadingLanguageRI/TextureOperations.js: Removed.
2775         * WebGPUShadingLanguageRI/TrapStatement.js: Removed.
2776         * WebGPUShadingLanguageRI/Type.js: Removed.
2777         * WebGPUShadingLanguageRI/TypeDef.js: Removed.
2778         * WebGPUShadingLanguageRI/TypeDefResolver.js: Removed.
2779         * WebGPUShadingLanguageRI/TypeOverloadResolutionFailure.js: Removed.
2780         * WebGPUShadingLanguageRI/TypeRef.js: Removed.
2781         * WebGPUShadingLanguageRI/TypedValue.js: Removed.
2782         * WebGPUShadingLanguageRI/UintLiteral.js: Removed.
2783         * WebGPUShadingLanguageRI/UintLiteralType.js: Removed.
2784         * WebGPUShadingLanguageRI/UnificationContext.js: Removed.
2785         * WebGPUShadingLanguageRI/UnreachableCodeChecker.js: Removed.
2786         * WebGPUShadingLanguageRI/Value.js: Removed.
2787         * WebGPUShadingLanguageRI/VariableDecl.js: Removed.
2788         * WebGPUShadingLanguageRI/VariableRef.js: Removed.
2789         * WebGPUShadingLanguageRI/VectorType.js: Removed.
2790         * WebGPUShadingLanguageRI/VisitingSet.js: Removed.
2791         * WebGPUShadingLanguageRI/Visitor.js: Removed.
2792         * WebGPUShadingLanguageRI/WLexicalError.js: Removed.
2793         * WebGPUShadingLanguageRI/WSyntaxError.js: Removed.
2794         * WebGPUShadingLanguageRI/WTrapError.js: Removed.
2795         * WebGPUShadingLanguageRI/WTypeError.js: Removed.
2796         * WebGPUShadingLanguageRI/WhileLoop.js: Removed.
2797         * WebGPUShadingLanguageRI/WrapChecker.js: Removed.
2798         * WebGPUShadingLanguageRI/index.html: Removed.
2799         * WebGPUShadingLanguageRI/spirv.core.grammar.json: Removed.
2800         * WebGPUShadingLanguageRI/wsl-tests.yaml: Removed.
2801
2802 2018-10-15  Philippe Normand  <pnormand@igalia.com>
2803
2804         [GTK] Disable MSE build support on Debian and Ubuntu LTS bots
2805         https://bugs.webkit.org/show_bug.cgi?id=190581
2806
2807         Reviewed by Michael Catanzaro.
2808
2809         These bots don't use JHBuild and their host GStreamer version is
2810         too old for the GStreamer MSE backend. Version 1.14 is needed at least.
2811
2812         * BuildSlaveSupport/build.webkit.org-config/config.json:
2813
2814 2018-10-15  Alex Christensen  <achristensen@webkit.org>
2815
2816         Use pragma once in WTF
2817         https://bugs.webkit.org/show_bug.cgi?id=190527
2818
2819         Reviewed by Chris Dumez.
2820
2821         Put WorkQueue in namespace DRT so it does not conflict with WTF::WorkQueue.
2822
2823         * DumpRenderTree/TestRunner.cpp:
2824         (TestRunner::queueLoadHTMLString):
2825         (TestRunner::queueLoadAlternateHTMLString):
2826         (TestRunner::queueBackNavigation):
2827         (TestRunner::queueForwardNavigation):
2828         (TestRunner::queueLoadingScript):
2829         (TestRunner::queueNonLoadingScript):
2830         (TestRunner::queueReload):
2831         * DumpRenderTree/WorkQueue.cpp:
2832         (WorkQueue::singleton): Deleted.
2833         (WorkQueue::WorkQueue): Deleted.
2834         (WorkQueue::queue): Deleted.
2835         (WorkQueue::dequeue): Deleted.
2836         (WorkQueue::count): Deleted.
2837         (WorkQueue::clear): Deleted.
2838         (WorkQueue::processWork): Deleted.
2839         * DumpRenderTree/WorkQueue.h:
2840         (WorkQueue::setFrozen): Deleted.
2841         * DumpRenderTree/WorkQueueItem.h:
2842         * DumpRenderTree/mac/DumpRenderTree.mm:
2843         (runTest):
2844         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2845         (-[FrameLoadDelegate processWork:]):
2846         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]):
2847         * DumpRenderTree/mac/TestRunnerMac.mm:
2848         (TestRunner::notifyDone):
2849         (TestRunner::forceImmediateCompletion):
2850         (TestRunner::queueLoad):
2851         * DumpRenderTree/win/DumpRenderTree.cpp:
2852         (runTest):
2853         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2854         (FrameLoadDelegate::processWork):
2855         (FrameLoadDelegate::locationChangeDone):
2856         * DumpRenderTree/win/TestRunnerWin.cpp:
2857         (TestRunner::notifyDone):
2858         (TestRunner::forceImmediateCompletion):
2859         (TestRunner::queueLoad):
2860
2861 2018-10-14  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
2862
2863         [JSC] Remove Option::useAsyncIterator
2864         https://bugs.webkit.org/show_bug.cgi?id=190567
2865
2866         Reviewed by Saam Barati.
2867
2868         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2869
2870 2018-10-15  Claudio Saavedra  <csaavedra@igalia.com>
2871
2872         [WPE] Silence a unused-parameter warning
2873
2874         Unreviewed.
2875         * MiniBrowser/wpe/main.cpp:
2876         (decidePermissionRequest):
2877
2878 2018-10-12  Guillaume Emont  <guijemont@igalia.com>
2879
2880         [Tools][webkitpy] fix handling of JSCTESTS_OPTIONS
2881         https://bugs.webkit.org/show_bug.cgi?id=190537
2882
2883         Reviewed by Alexey Proskuryakov.
2884
2885         In DeprecatedPort.run_javascriptcore_tests_command() JSCTESTS_OPTIONS
2886         needs to be split before adding it to the command since it is treated
2887         as a list of args.
2888
2889         * Scripts/webkitpy/common/config/ports.py:
2890         (DeprecatedPort.run_javascriptcore_tests_command):
2891
2892 2018-10-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2893
2894         [iOS] Allow SPI clients to lay out at arbitrarily scaled sizes and scale to fit the view
2895         https://bugs.webkit.org/show_bug.cgi?id=190504
2896         <rdar://problem/45117760>
2897
2898         Reviewed by Tim Horton.
2899
2900         Teach UIScriptController to set WKWebView's view scale via a new `setViewScale` method, supported in WebKit2 on
2901         macOS and iOS.
2902
2903         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2904         (WTR::UIScriptController::setViewScale):
2905         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2906         (WTR::UIScriptController::setViewScale):
2907         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2908         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2909         (WTR::UIScriptController::setViewScale):
2910         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2911         * WebKitTestRunner/UIScriptControllerCocoa.mm: Added.
2912
2913         Add a new file for UIScriptController methods on Cocoa platforms.
2914
2915         (WTR::UIScriptController::setViewScale):
2916         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2917         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2918         (WTR::TestController::cocoaResetStateToConsistentValues):
2919
2920         Ensure that _viewScale is reset to 1 after running a layout test.
2921
2922 2018-10-12  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [ews-build] Rename iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS
2925         https://bugs.webkit.org/show_bug.cgi?id=190536
2926
2927         Reviewed by Alexey Proskuryakov.
2928
2929         * BuildSlaveSupport/ews-build/config.json: Renamed iOS-11-Simulator-Tests-EWS to iOS-11-Simulator-WK2-Tests-EWS.
2930
2931 2018-10-11  Youenn Fablet  <youenn@apple.com>
2932
2933         IOS 12 - Service worker cache not shared when added to homescreen
2934         https://bugs.webkit.org/show_bug.cgi?id=190269
2935         <rdar://problem/45009961>
2936
2937         Reviewed by Alex Christensen.
2938
2939         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2940         Add test to ensure that CacheStorage use the default website data store parameters.
2941
2942 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2943
2944         Clicking on bookmarklet crashes at NavigationState::willRecordNavigationSnapshot
2945         https://bugs.webkit.org/show_bug.cgi?id=190476
2946         <rdar://problem/32757191>
2947
2948         Reviewed by Megan Gardner.
2949
2950         * TestWebKitAPI/Tests/WebKitCocoa/SnapshotStore.mm:
2951         (TEST):
2952         Add a test that we don't crash.
2953
2954 2018-10-11  Tim Horton  <timothy_horton@apple.com>
2955
2956         REGRESSION (r237037): Cannot use webkit-patch upload, always fails with unknown 'cc_radar'
2957
2958         * Scripts/webkitpy/tool/steps/options.py:
2959         (Options):
2960         Fix the name of the variable that the --cc-radar option writes into.
2961
2962 2018-10-10  Dean Jackson  <dino@apple.com>
2963
2964         Add --cc-radar option to webkit-patch bug creation
2965         https://bugs.webkit.org/show_bug.cgi?id=190451
2966         <rdar://problem/45176671>
2967
2968         Reviewed by Antoine Quint.
2969
2970         Add a new command line option to automatically
2971         CC radar to new or updated bugs.
2972
2973         * Scripts/webkitpy/tool/commands/commandtest.py:
2974         (CommandsTest.assert_execute_outputs):
2975         * Scripts/webkitpy/tool/commands/upload.py:
2976         (CreateBug.__init__):
2977         (CreateBug.execute):
2978         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2979         (test_prepare_with_cc):
2980         (test_prepare_with_radar):
2981         (test_prepare_with_cc_and_radar):
2982         * Scripts/webkitpy/tool/steps/createbug.py:
2983         (CreateBug.options):
2984         (CreateBug.run):
2985         * Scripts/webkitpy/tool/steps/options.py:
2986         (Options):
2987
2988 2018-10-11  Claudio Saavedra  <csaavedra@igalia.com>
2989
2990         [GStreamer] Do not build gstgtk plugins
2991         https://bugs.webkit.org/show_bug.cgi?id=190463
2992
2993         Reviewed by Xabier Rodriguez-Calvar.
2994
2995         These plugins pull a GTK+ dependency that, at least in WPE,
2996         is unnecessary. The GTK+ port doesn't need it either, as far
2997         as I can tell.
2998
2999         * gstreamer/jhbuild.modules: Disable gstgtk plugins
3000
3001 2018-10-11  Alejandro G. Castro  <alex@igalia.com>
3002
3003         [GTK][WPE] Add mediaDevices.enumerateDevices support
3004         https://bugs.webkit.org/show_bug.cgi?id=185761
3005
3006         Reviewed by Youenn Fablet.
3007
3008         Added new API test for the mediaDevices.enumerateDevices:
3009         usermedia-enumeratedevices-permission-check. And a new API test
3010         for the WebsiteDataStore: testWebsiteDataDeviceIdHashSalt.
3011
3012         * MiniBrowser/gtk/main.c:
3013         (gotWebsiteDataCallback): Added a new section to the about:data
3014         webpage to include the information about the hash salt.
3015         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
3016         (testWebViewUserMediaEnumerateDevicesPermissionCheck): Added the
3017         new test checking the enumerateDevices API when permission is
3018         denied and when permission is allowed for the origin.
3019         (beforeAll): Defined the new test.
3020         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3021         (serverCallback): Register a new URI for the enumerateDevices.
3022         (testWebsiteDataConfiguration): Remove the hash salts from the
3023         directories.
3024         (testWebsiteDataDeviceIdHashSalt): New test cheking the
3025         enumerateDevices API.
3026         (beforeAll): Added the new test testWebsiteDataDeviceIdHashSalt to
3027         the init structure.
3028         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
3029         (WebViewTest::initializeWebView): Make sure the media-stream is
3030         activated in the webView.
3031
3032 2018-10-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3033
3034         Add WinCairo to the flakiness dashboard
3035         https://bugs.webkit.org/show_bug.cgi?id=188345
3036
3037         Reviewed by Lucas Forschler.
3038
3039         * TestResultServer/static-dashboards/builders.jsonp: Regenerated by generate_builders_json.py.
3040         * TestResultServer/static-dashboards/flakiness_dashboard.js: Added a new platform 'WINCAIRO'.
3041
3042 2018-10-10  Dean Jackson  <dino@apple.com>
3043
3044         [WHSL -> MSL] Annotate semantics correctly in generated MSL
3045         https://bugs.webkit.org/show_bug.cgi?id=190452
3046         <rdar://problem/45178272>
3047
3048         Reviewed by Myles Maxfield.
3049
3050         Correctly label the appropriate semantics as [[position]]
3051         and [[color(N)]].
3052
3053         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Identify position
3054         and color attributes. Also use the semantic's index rather than
3055         a counter.
3056         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Use a <pre> for
3057         output, and only include the actual shader code.
3058
3059 2018-10-10  Ross Kirsling  <ross.kirsling@sony.com>
3060
3061         build-webkit --inspector-frontend shouldn't have a nonzero exit code
3062         https://bugs.webkit.org/show_bug.cgi?id=190430
3063
3064         Reviewed by Brian Burg.
3065
3066         * Scripts/webkitdirs.pm:
3067         (argumentsForConfiguration):
3068         --inspector-frontend should only be popped off of argv by determineIsInspectorFrontend;
3069         it shouldn't be re-inserted as a CLI option by argumentsForConfiguration.
3070
3071 2018-10-10  Tim Horton  <timothy_horton@apple.com>
3072
3073         Share more WKShareSheet code between macOS and iOS, and fix a few bugs
3074         https://bugs.webkit.org/show_bug.cgi?id=190420
3075
3076         Reviewed by Simon Fraser.
3077
3078         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3079         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3080         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3081         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3082         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3083         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3084         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3085         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3086         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3087         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3088         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3089         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3090         (WTR::UIScriptController::invokeShareSheetWithResolution): Deleted.
3091         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3092         (WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):
3093         Change the testing mechanism for the share sheet such that we up-front
3094         set that it should immediately return with a particular state, instead
3095         of programmatically dismissing the sheet.
3096
3097         Otherwise, running the tests on macOS doesn't work, because we pop
3098         a context menu, which spins the runloop and prevents dismissal from
3099         going through.
3100
3101 2018-10-10  Yusuke Suzuki  <yusukesuzuki@slowstart.org>
3102
3103         [JSC] Rename createXXX to tryCreateXXX if it can return RefPtr
3104         https://bugs.webkit.org/show_bug.cgi?id=190429
3105
3106         Reviewed by Saam Barati.
3107
3108         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3109         (TestWebKitAPI::TEST_F):
3110
3111 2018-10-10  Chris Dumez  <cdumez@apple.com>
3112
3113         Regression(PSON): Assertion hit under WebPageProxy::didNavigateWithNavigationData()
3114         https://bugs.webkit.org/show_bug.cgi?id=190418
3115         <rdar://problem/45059769>
3116
3117         Reviewed by Geoffrey Garen.
3118
3119         Add API test coverage.
3120
3121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3122
3123 2018-10-10  Guillaume Emont  <guijemont@igalia.com>
3124
3125         [JSCOnly Add an armv7 JSCOnly EWS that runs tests
3126         https://bugs.webkit.org/show_bug.cgi?id=190191
3127
3128         Reviewed by Michael Catanzaro.
3129
3130         * QueueStatusServer/config/queues.py:
3131         * Scripts/webkitpy/common/config/ews.json:
3132         * Scripts/webkitpy/common/config/ports.py:
3133         (DeprecatedPort.run_javascriptcore_tests_command):
3134         Add the possibility to pass arguments to run-javascriptcore-tests with
3135         the JSCTESTS_OPTIONS environment variable
3136         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3137         (test_ews_name):
3138
3139
3140 2018-10-09  Guillaume Emont  <guijemont@igalia.com>
3141
3142         Allow run-javascriptcore-tests to distribute tests between devices
3143         https://bugs.webkit.org/show_bug.cgi?id=190190
3144
3145         Reviewed by Michael Catanzaro.
3146
3147         * Scripts/run-jsc-stress-tests:
3148         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3149         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3150
3151 2018-10-09  Dean Jackson  <dino@apple.com>
3152
3153         Update WHLSL to Metal tester with semantics
3154         https://bugs.webkit.org/show_bug.cgi?id=190416
3155         <rdar://problem/45145139>
3156
3157         Reviewed by Myles Maxfield.
3158
3159         A few small changes to the WHLSL to Metal tools:
3160         - Make it compile by adding some missing JS files :)
3161         - Add semantics to the default shader
3162         - Add FIXMEs to the other shaders
3163         - Create an in-browser test for the WHLSLToMetal codepath
3164         - Fix typos in the semantics checker
3165
3166         * WebGPUShadingLanguageRI/Checker.js:
3167         (Checker.prototype._checkSemantics.checkSemanticTypes):
3168         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
3169         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m:
3170         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl:
3171         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl:
3172         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl:
3173         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
3174         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.html: Added.
3175
3176 2018-10-09  Jer Noble  <jer.noble@apple.com>
3177
3178         Crash when closing WKWebView during enter fullscreen animation
3179         https://bugs.webkit.org/show_bug.cgi?id=190412
3180
3181         Reviewed by Brian Burg.
3182
3183         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3184         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm: Added.
3185         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillEnterFullscreen:]):
3186         (-[CloseWebViewDuringEnterFullscreenUIDelegate _webViewWillExitFullscreen:]):
3187         (TestWebKitAPI::TEST):
3188
3189 2018-10-09  Chris Dumez  <cdumez@apple.com>
3190
3191         Anchor target should be ignored on activation when the download attribute is set
3192         https://bugs.webkit.org/show_bug.cgi?id=190408
3193
3194         Reviewed by Geoffrey Garen.
3195
3196         Update WebKitTestRunner to block popups by default and add support for testRunner.setCanOpenWindows()
3197         for tests that need popups. This aligns WebKitTestRunner with DumpRenderTree and allows testing
3198         popup blocking.
3199
3200         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3201         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3202         (WTR::TestRunner::setCanOpenWindows):
3203         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3204         * WebKitTestRunner/TestController.cpp:
3205         (WTR::TestController::createOtherPage):
3206         * WebKitTestRunner/TestController.h:
3207         * WebKitTestRunner/TestInvocation.cpp:
3208         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3209         * WebKitTestRunner/TestInvocation.h:
3210
3211 2018-10-09  Jer Noble  <jer.noble@apple.com>
3212
3213         WebDriver: thrown ObjC exception under -[WKFullScreenWindowController windowDidFailToEnterFullScreen:] when session is terminated
3214         https://bugs.webkit.org/show_bug.cgi?id=190098
3215         <rdar://problem/42822671>
3216
3217         Reviewed by Brian Burg.
3218
3219         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3220         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm: Added.
3221         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidEnterFullscreen:]):
3222         (-[CloseWebViewAfterEnterFullscreenUIDelegate _webViewDidExitFullscreen:]):
3223         (TestWebKitAPI::TEST):
3224
3225 2018-10-09  Jiewen Tan  <jiewen_tan@apple.com>
3226
3227         [WebAuthN] Import CTAP HID message and packet structure from Chromium
3228         https://bugs.webkit.org/show_bug.cgi?id=189289
3229         <rdar://problem/44120310>
3230
3231         Reviewed by Brent Fulgham.
3232
3233         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3234         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp: Added.
3235         (TestWebKitAPI::TEST):
3236
3237 2018-10-09  Chris Dumez  <cdumez@apple.com>
3238
3239         PSON: Doing a cross-site navigation via the URL bar does not swap process on iOS
3240         https://bugs.webkit.org/show_bug.cgi?id=190378
3241         <rdar://problem/45059466>
3242
3243         Reviewed by Geoffrey Garen.
3244
3245         Add API test coverage.
3246
3247         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3248
3249 2018-10-09  Jer Noble  <jer.noble@apple.com>
3250
3251         ISOTrackEncryptionBox returns incorrect defaultKeyID
3252         https://bugs.webkit.org/show_bug.cgi?id=190368
3253
3254         Reviewed by Eric Carlson.
3255
3256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3257         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3258         (TestWebKitAPI::TEST):
3259
3260 2018-10-09  Philippe Normand  <pnormand@igalia.com>
3261
3262         [JHBuild] Update to GStreamer 1.14.4
3263         https://bugs.webkit.org/show_bug.cgi?id=190395
3264
3265         Reviewed by Xabier Rodriguez-Calvar.
3266
3267         * gstreamer/jhbuild.modules: Remove patches merged in 1.14.4 and bump version of GStreamer modules.
3268         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Removed.
3269         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Removed.
3270         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Removed.
3271         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Removed.
3272
3273 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3274
3275         [macOS] API test DragAndDropTests.DropColor is failing on macOS 10.12
3276         https://bugs.webkit.org/show_bug.cgi?id=190386
3277
3278         Reviewed by Ryosuke Niwa.
3279
3280         Unlike macOS 10.13 and 10.14, -[NSColor redColor] is not equivalent to a fully red color in sRGB on macOS 10.12.
3281         Fix the test by dragging and dropping an NSColor that is equivalent to rgb(255, 0, 0) on all relevant versions
3282         of macOS.
3283
3284         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3285         (TEST):
3286
3287 2018-10-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3288
3289         [Cocoa] [WK2] Add support for text alignment and text lists in font attributes
3290         https://bugs.webkit.org/show_bug.cgi?id=190342
3291         <rdar://problem/44767118>
3292
3293         Reviewed by Tim Horton.
3294
3295         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3296         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm:
3297
3298         Add a new API test to check that the font attributes dictionary contains the correct NSParagraphStyles when
3299         moving the selection around text inside nested list elements.
3300
3301         (TestWebKitAPI::checkParagraphStyles):
3302
3303         Add a new helper to check an NSParagraphStyle against expected results.
3304
3305         (TestWebKitAPI::webViewForTestingFontAttributes):
3306
3307         Allow each test to pass in the name of the test page to load.
3308
3309         (TestWebKitAPI::TEST):
3310         * TestWebKitAPI/Tests/WebKitCocoa/nested-lists.html: Added.
3311
3312         Add a new test page that contains text enclosed in multiple levels of unordered and ordered lists.
3313
3314         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html:
3315
3316         Remove `text-align: left` from one of these elements, to test for NSTextAlignmentNatural.
3317
3318 2018-10-08  Justin Fan  <justin_fan@apple.com>
3319
3320         WebGPU: Rename old WebGPU prototype to WebMetal
3321         https://bugs.webkit.org/show_bug.cgi?id=190325
3322         <rdar://problem/44990443>
3323
3324         Reviewed by Dean Jackson.
3325
3326         Rename WebGPU prototype files to WebMetal in preparation for implementing the new (Oct 2018) WebGPU interface.
3327
3328         * DumpRenderTree/mac/DumpRenderTree.mm:
3329         (enableExperimentalFeatures):
3330         (resetWebPreferencesToConsistentValues):
3331         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3332         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm:
3333         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:
3334         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm:
3335         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm:
3336         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm:
3337         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3338         (WTR::InjectedBundle::beginTesting):
3339         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3340         (WTR::TestRunner::setWebMetalEnabled):
3341         (WTR::TestRunner::setWebGPUEnabled): Deleted.
3342         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3343
3344 2018-10-08  Commit Queue  <commit-queue@webkit.org>
3345
3346         Unreviewed, rolling out r236941.
3347         https://bugs.webkit.org/show_bug.cgi?id=190374
3348
3349         Causing API test failures in new test (Requested by jernoble
3350         on #webkit).
3351
3352         Reverted changeset:
3353
3354         "ISOTrackEncryptionBox returns incorrect defaultKeyID"
3355         https://bugs.webkit.org/show_bug.cgi?id=190368
3356         https://trac.webkit.org/changeset/236941
3357
3358 2018-10-08  Aditya Keerthi  <akeerthi@apple.com>
3359
3360         Make <input type=color> a runtime enabled (on-by-default) feature
3361         https://bugs.webkit.org/show_bug.cgi?id=189162
3362
3363         Reviewed by Wenson Hsieh and Tim Horton.
3364
3365         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3366
3367 2018-10-08  Jer Noble  <jer.noble@apple.com>
3368
3369         ISOTrackEncryptionBox returns incorrect defaultKeyID
3370         https://bugs.webkit.org/show_bug.cgi?id=190368
3371
3372         Reviewed by Eric Carlson.
3373
3374         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3375         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp: Added.
3376         (TestWebKitAPI::TEST):
3377
3378 2018-10-08  Alex Christensen  <achristensen@webkit.org>
3379
3380         Remove WKBundleFileHandleRef
3381         https://bugs.webkit.org/show_bug.cgi?id=190360
3382
3383         Reviewed by Tim Horton.
3384
3385         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3386         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle.cpp: Removed.
3387         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp: Removed.
3388
3389 2018-10-08  Dan Bernstein  <mitz@apple.com>
3390
3391         Tools part of [Xcode] Update some build settings as recommended by Xcode 10
3392         https://bugs.webkit.org/show_bug.cgi?id=190250
3393
3394         Reviewed by Anders Carlsson.
3395
3396         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3397
3398         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3399           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3400           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3401
3402         * DumpRenderTree/mac/DumpRenderTreeMac.h: Addressed the strict prototype warning.
3403
3404         * DumpRenderTree/mac/EditingDelegate.mm: Suppressed the deprecated implementations warning
3405           around deprecated methods or categories on deprecated classes.
3406         * DumpRenderTree/mac/FrameLoadDelegate.mm: Ditto.
3407         (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]):
3408         * DumpRenderTree/mac/TestRunnerMac.mm: Ditto.
3409         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3410
3411         * MiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3412           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3413           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3414
3415         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3416
3417         * MiniBrowser/mac/AppDelegate.h: Addressed the strict prototypes warning.
3418         * MiniBrowser/mac/WK2BrowserWindowController.m: Removed an unused #import to avoid having to
3419           address the fact that many of the WebKit C SPI headers trigger the strict prototypes warning.
3420
3421         * MobileMiniBrowser/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3422           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_SUSPICIOUS_MOVE (by fixing a typo),
3423           CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS, and CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF.
3424
3425         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Let Xcode update
3426           LastUpgradeCheck and remove the .xcconfig files from the Copy Bundle Resources build phase.
3427
3428         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled CLANG_WARN_COMMA,
3429           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3430           CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF, and CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED.
3431           Made the WebKit headers be treated as system headers to avoid dealing with the fact that
3432           many C SPI headers trigger the strict prototypes warning.
3433
3434         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3435
3436         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3437         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3438         (-[BlobDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3439         (-[UIDownloadAsFileTestDelegate _webView:contextMenu:forElement:]):
3440         (-[RedirectedDownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3441         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3442         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3443         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3444         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
3445         (-[AudioSessionCategoryUIWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3446         * TestWebKitAPI/Tests/WebKitLegacy/ios/SnapshotViaRenderInContext.mm:
3447         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3448         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3449         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm:
3450         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
3451         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
3452         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3453         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
3454         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
3455         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3456         (-[DragAndDropTestWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3457         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
3458         (-[SyntheticBackingScaleFactorWindow IGNORE_WARNINGS_END]):
3459         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]): Deleted.
3460         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3461         (-[TestDraggingInfo namesOfPromisedFilesDroppedAtDestination:]):
3462
3463         In all of the above, suppressed the deprecated implementations warning where needed.
3464
3465         * WebKitTestRunner/Configurations/Base.xcconfig: Enabled ENABLE_STRICT_OBJC_MSGSEND,
3466           CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_COMMA, CLANG_WARN_CONSTANT_CONVERSION,
3467           CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
3468           CLANG_WARN_STRICT_PROTOTYPES, CLANG_WARN_UNREACHABLE_CODE, CLANG_WARN__DUPLICATE_METHOD_MATCH,
3469           GCC_WARN_UNDECLARED_SELECTOR, CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF,
3470           CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED, CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS,
3471           and GCC_NO_COMMON_BLOCKS.
3472
3473         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Let Xcode update LastUpgradeCheck.
3474
3475         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3476         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Suppressed
3477           the deprecated implementations warning.
3478
3479         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3480         (WTR::UIScriptController::replaceTextAtRange): Addressed an int-conversion warning.
3481
3482 2018-10-07  Yacine Bandou  <yacine.bandou@softathome.com>
3483
3484         [GStreamer][EME][webm] Add the WebM encrypted content support in matroskademux
3485         https://bugs.webkit.org/show_bug.cgi?id=189238
3486
3487         Reviewed by Xabier Rodriguez-Calvar.
3488
3489         Modifications on GStreamer, tracked in GStreamer bugzilla:
3490         https://bugzilla.gnome.org/show_bug.cgi?id=797231
3491         https://bugzilla.gnome.org/show_bug.cgi?id=765275
3492
3493         * gstreamer/jhbuild.modules: Add new patches.
3494         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Added.
3495         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Added.
3496         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Added.
3497         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Added.
3498
3499 2018-10-06  Dan Bernstein  <mitz@apple.com>
3500
3501         [Xcode] Never build yasm with ASAN
3502         https://bugs.webkit.org/show_bug.cgi?id=190327
3503
3504         Reviewed by Youenn Fablet.
3505
3506         * asan/asan.xcconfig: Allow targets to opt out of building with ASAN by setting
3507           the WK_ASAN_DISALLOWED build setting to YES (or, actually, anything other than NO or unset).
3508
3509 2018-10-05  Chris Dumez  <cdumez@apple.com>
3510
3511         Regression(r236862): Crash under DOMWindowExtension::willDetachGlobalObjectFromFrame()
3512         https://bugs.webkit.org/show_bug.cgi?id=190320
3513         <rdar://problem/45044814>
3514
3515         Reviewed by Geoffrey Garen.
3516
3517         Add API test coverage.
3518
3519         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3520         (TestWebKitAPI::TEST):
3521         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3522         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
3523
3524 2018-10-03  Jer Noble  <jer.noble@apple.com>
3525
3526         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
3527         https://bugs.webkit.org/show_bug.cgi?id=190266
3528
3529         Reviewed by Eric Carlson.
3530
3531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3532         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
3533         (TestWebKitAPI::TEST):
3534
3535 2018-10-05  Ryan Haddad  <ryanhaddad@apple.com>
3536
3537         Unreviewed, rolling out r236866.
3538
3539         Breaks internal builds.
3540
3541         Reverted changeset:
3542
3543         "Add support for reporting "display composited video frames"
3544         through the VideoPlaybackQuality object."
3545         https://bugs.webkit.org/show_bug.cgi?id=190266
3546         https://trac.webkit.org/changeset/236866
3547
3548 2018-10-05  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3549
3550         [WPE][JSC] Use Unified Sources for Platform-specific sources
3551         https://bugs.webkit.org/show_bug.cgi?id=190300
3552
3553         Reviewed by Yusuke Suzuki.
3554
3555         Currently the GTK port already used Unified Sources with the same source files.
3556         As WPE has conditional code using gmodule, we need to add GLIB_GMODULE_LIBRARIES
3557         to the list of libraries to link with.
3558
3559         * TestWebKitAPI/PlatformWPE.cmake:
3560
3561 2018-10-05  Zach Li  <zachli@apple.com>
3562
3563         Expose whether WKWebProcessPlugInNodeHandle is a select element to clients
3564         https://bugs.webkit.org/show_bug.cgi?id=190302
3565         <rdar://problem/45031469>
3566
3567         Reviewed by Tim Horton.
3568
3569         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3570         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.mm: Added.
3571         (-[InjectedBundleNodeHandleIsSelectElement verifySelectElementForHTMLElementTag:document:jsContext:expectedResult:failedElementTags:]):
3572         (-[InjectedBundleNodeHandleIsSelectElement webProcessPlugIn:didCreateBrowserContextController:]):
3573         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3574         (-[InjectedBundleNodeHandleIsSelectElementDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3575         (TEST):
3576
3577 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3578
3579         [iOS] [WK2] Expose some more editing SPI on WKWebView
3580         https://bugs.webkit.org/show_bug.cgi?id=190232
3581         <rdar://problem/44963368>
3582
3583         Reviewed by Tim Horton.
3584
3585         Adds new API tests to exercise the new SPIs.
3586
3587         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3588         * TestWebKitAPI/Tests/ios/WKWebViewEditActions.mm: Added.
3589         (-[TestWKWebView querySelectorExists:]):
3590         (TestWebKitAPI::webViewForEditActionTesting):
3591         (TestWebKitAPI::TEST):
3592         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3593         (-[TestWKWebView collapseToStart]): Deleted.
3594         (-[TestWKWebView collapseToEnd]): Deleted.
3595         (-[TestWKWebView stylePropertyAtSelectionStart:]): Deleted.
3596         (-[TestWKWebView stylePropertyAtSelectionEnd:]): Deleted.
3597         * TestWebKitAPI/cocoa/TestWKWebView.h:
3598         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3599         (-[TestWKWebView stylePropertyAtSelectionStart:]):
3600         (-[TestWKWebView stylePropertyAtSelectionEnd:]):
3601         (-[TestWKWebView collapseToStart]):
3602         (-[TestWKWebView collapseToEnd]):
3603
3604         Pull some common testing helpers out of NSFontManager and into TestWKWebView.
3605
3606 2018-10-04  Jer Noble  <jer.noble@apple.com>
3607
3608         Add support for reporting "display composited video frames" through the VideoPlaybackQuality object.
3609         https://bugs.webkit.org/show_bug.cgi?id=190266
3610
3611         Reviewed by Eric Carlson.
3612
3613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3614         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm: Added.
3615         (TestWebKitAPI::TEST):
3616
3617 2018-10-04  Wenson Hsieh  <wenson_hsieh@apple.com>
3618
3619         [Cocoa] Add SPI to expose typing attributes at the current selection on WKWebView
3620         https://bugs.webkit.org/show_bug.cgi?id=190119
3621         <rdar://problem/44767062>
3622
3623         Reviewed by Tim Horton.
3624
3625         Add a new API test that loads a document containing various rich text styles. This test moves the selection
3626         around the document and checks the last set of font attributes received via the new UI delegate hook.
3627
3628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3629         * TestWebKitAPI/Tests/WebKitCocoa/FontAttributes.mm: Added.
3630         (-[FontAttributesListener _webView:didChangeFontAttributes:]):
3631         (-[FontAttributesListener lastFontAttributes]):
3632         (-[TestWKWebView selectElementWithIdentifier:]):
3633         (-[TestWKWebView fontAttributesAfterNextPresentationUpdate]):
3634         (ColorExpectation::ColorExpectation):
3635         (ShadowExpectation::ShadowExpectation):
3636         (checkColor):
3637         (checkShadow):
3638         (checkFont):
3639         (webViewForTestingFontAttributes):
3640         * TestWebKitAPI/Tests/WebKitCocoa/rich-text-attributes.html: Added.
3641