run-perf-tests should report server-side errors
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
2
3         run-perf-tests should report server-side errors
4         https://bugs.webkit.org/show_bug.cgi?id=76802
5
6         Reviewed by Tony Chang.
7
8         Report errors whenever server's response doesn't match "OK".
9
10         * Scripts/webkitpy/common/net/file_uploader.py:
11         (FileUploader.upload_single_text_file):
12         (FileUploader.upload_as_multipart_form_data):
13         (FileUploader._upload_data.callback):
14         (FileUploader):
15         (FileUploader._upload_data):
16         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
17         (PerfTestsRunner._upload_json):
18         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
19         (test_upload_json):
20         (test_upload_json.MockFileUploader.upload_single_text_file):
21
22 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
23
24         run-perf-tests ignore Skipped list on chromium
25         https://bugs.webkit.org/show_bug.cgi?id=76764
26
27         Reviewed by Dirk Pranke.
28
29         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
30         can also find skipped list. Chromium port only uses test_expectations.txt for
31         layout tests but performacne tests don't use test_expectations.txt so Chromium port
32         also needs to use Skipped list.
33
34         * Scripts/webkitpy/layout_tests/port/base.py:
35         (Port._tests_from_skipped_file_contents):
36         (Port):
37         (Port._expectations_from_skipped_files):
38         (Port.skipped_perf_tests):
39         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
40         (PortTest.test_skipped_perf_tests):
41         (PortTest.test_skipped_perf_tests.add_text_file):
42         * Scripts/webkitpy/layout_tests/port/webkit.py:
43         (WebKitPort._skipped_tests_for_unsupported_features):
44         (WebKitPort._skipped_file_search_paths):
45         (WebKitPort.skipped_layout_tests):
46
47 2012-01-23  Andy Estes  <aestes@apple.com>
48
49         Fix the build after r105635.
50
51         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
52         (TestWebKitAPI::TEST):
53
54 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
55
56         Basic enhancements to StringBuilder
57         https://bugs.webkit.org/show_bug.cgi?id=67081
58
59         Reviewed by Darin Adler.
60
61         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
62         (TestWebKitAPI::TEST):
63
64 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
65
66         [GTK] run-gtk-tests randomly fails while running the xprop comand
67         https://bugs.webkit.org/show_bug.cgi?id=76817
68
69         Reviewed by Gustavo Noronha Silva.
70
71         No need to use xprop to remove the AT_SPI_BUS property since
72         run-gtk-tests will always run new instances of Xvfb.
73
74         * Scripts/run-gtk-tests:
75         (TestRunner): Unskip TestWebKitAccessibility.
76         (TestRunner.run): Uncomment lines for launching the accessibility
77         bus and registry daemon, and remove lines for running xprop.
78
79 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
80
81         [Qt] Don't warn about override and final being C++11 extensions
82
83         Clang will emit a warning when these extensions are used without passing
84         --std=c++11, but we use feature checking to decide if we have the right
85         extensions, so we can safely ignore these warnings. The XCode and Windows
86         project files have the same workaround.
87
88         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
89         we only have one extra compiler for Objective-C, which is also used for
90         Objective-C++ sources, so we have to pass the flag, even if it doesn't
91         make sense for Objective-C.
92
93         Reviewed by Simon Hausmann.
94
95         * qmake/mkspecs/features/unix/default_post.prf:
96
97 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
98
99         [Qt] Change how build-webkit decides when to do full incremental builds
100
101         Instead of relying on update-webkit (which isn't run on the bots) to
102         decide when to do a full incremental build (make qmake), we let the
103         build-webkit script itself check the current SVN revision against the
104         previous build (by storing it in .webkit.config).
105
106         If the two differ we assume a full incremental build is needed, since
107         the new revisions might have introduced problematic things like new
108         Q_OBJECT macros. If not, we assume the developer is doing changes
109         locally, and revert to doing a plain 'make'.
110
111         In addition, when the build fails in the latter case, we inform the
112         developer of possible pitfalls and how to manually run 'make qmake'.
113
114         Reviewed by Ossy.
115
116         * Scripts/update-webkit:
117         * Scripts/webkitdirs.pm:
118         (buildQMakeProjects):
119
120 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
121
122         [GTK] run-gtk-tests randomly fails while running the xprop comand
123         https://bugs.webkit.org/show_bug.cgi?id=76817
124
125         Reviewed by Philippe Normand.
126
127         Temporarily comment the lines related to launching the ATSPI bus
128         and registry daemon, which are making the bots to fail randomly.
129
130         * Scripts/run-gtk-tests:
131         (TestRunner): Skip TestWebKitAccessibility, as it won't run
132         properly if the ATSPI infrastructure is not properly initialized.
133         (TestRunner.run): Comment lines related to initialization of ATSPI.
134
135 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
136
137         Windows python test build fix.
138
139         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
140         (PerfTestsRunner.__init__):
141
142 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
143
144         [GTK] DumpRenderTree converts "file:///" to a path differently
145         https://bugs.webkit.org/show_bug.cgi?id=76631
146
147         Reviewed by Martin Robinson.
148
149         DumpRenderTree should print "/" as the last path component if the
150         path is a lone slash instead of empty output.
151
152         * DumpRenderTree/gtk/DumpRenderTree.cpp:
153         (webViewConsoleMessage):
154
155 2012-01-20  David Levin  <levin@chromium.org>
156
157         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
158         https://bugs.webkit.org/show_bug.cgi?id=76752
159
160         Reviewed by Eric Seidel.
161
162         * Scripts/webkitpy/style/checkers/cpp.py:
163         (check_for_leaky_patterns):
164         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
165         (LeakyPatternTest.test_create_dc):
166         (LeakyPatternTest.test_create_compatible_dc):
167
168 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
169
170         Changed my status in commiters.py
171
172         Unreviewed.
173
174         * Scripts/webkitpy/common/config/committers.py:
175
176 2012-01-20  Ojan Vafai  <ojan@chromium.org>
177
178         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
179         https://bugs.webkit.org/show_bug.cgi?id=76748
180
181         Reviewed by Ryosuke Niwa.
182
183         It crawls the whole subtree and then doesn't use the data. Cutting this out
184         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
185
186         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
187         (run):
188
189 2012-01-20  Adam Barth  <abarth@webkit.org>
190
191         Another tiny tweak to the garden-o-matic CSS.  This makes things line
192         up slightly nicer when there aren't any failures.
193
194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
195         (#summary):
196
197 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
198
199         run-perf-tests should support --test-results-server option
200         https://bugs.webkit.org/show_bug.cgi?id=76680
201
202         Reviewed by Adam Barth.
203
204         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
205         to be used by perf bots. Also refactor file_uploader as needed.
206
207         * Scripts/webkitpy/common/net/file_uploader.py:
208         (FileUploader.__init__):
209         (FileUploader.upload_single_file):
210         (FileUploader.upload_as_multipart_form_data):
211         (FileUploader):
212         (FileUploader._upload_data):
213         (FileUploader._upload_data.callback):
214         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
215         (JSONResultsGeneratorBase.upload_json_files):
216         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
217         (PerfTestsRunner):
218         (PerfTestsRunner._parse_args):
219         (PerfTestsRunner.run):
220         (PerfTestsRunner._generate_json):
221         (PerfTestsRunner._upload_json):
222         (PerfTestsRunner._run_tests_set):
223         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
224         (create_runner):
225         (test_run_with_upload_json):
226         (test_run_with_upload_json.mock_upload_json):
227         (test_upload_json):
228         (test_upload_json.MockFileUploader):
229         (test_upload_json.MockFileUploader.__init__):
230         (test_upload_json.MockFileUploader.upload_single_file):
231         (test_parse_args):
232
233 2012-01-20  Adam Barth  <abarth@webkit.org>
234
235         The party time image overlaps real content!  This patch makes the
236         image centered vertically.
237
238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
239         (#onebar.partytime #summary):
240
241 2012-01-19  Ojan Vafai  <ojan@chromium.org>
242
243         Refactor TestExpectationsParser in preparation for caching the results
244         https://bugs.webkit.org/show_bug.cgi?id=76669
245
246         Reviewed by Dimitri Glazkov.
247
248         Make everything private expect for the parse method. 
249         Eventually, we'll need the expectations lines to not be modified
250         outside of TestExpectationsParser so we can cache the results.
251         This makes check-webkit-style of the chromium test_expectations.txt file
252         go from ~17 seconds to ~12 seconds on my Mac Pro.
253
254         This patch is just a refactor in preparation, so no new tests.
255
256         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
257         (TestExpectationEditorTests.make_parsed_expectation_lines):
258         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
259         (TestExpectationParser.parse):
260         (TestExpectationParser):
261         (TestExpectationParser._parse_line):
262         (TestExpectationParser._tokenize):
263         (TestExpectationParser._tokenize_list):
264         (TestExpectationsModel._clear_expectations_for_test):
265         (TestExpectations.__init__):
266         (TestExpectations._add_expectations):
267         (TestExpectations._add_skipped_tests):
268         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
269         (TestExpectationParserTests.test_tokenize_blank):
270         (TestExpectationParserTests.test_tokenize_missing_colon):
271         (TestExpectationParserTests.test_tokenize_extra_colon):
272         (TestExpectationParserTests.test_tokenize_empty_comment):
273         (TestExpectationParserTests.test_tokenize_comment):
274         (TestExpectationParserTests.test_tokenize_missing_equal):
275         (TestExpectationParserTests.test_tokenize_extra_equal):
276         (TestExpectationParserTests.test_tokenize_valid):
277         (TestExpectationParserTests.test_tokenize_valid_with_comment):
278         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
279         (TestExpectationParserTests.test_parse_empty_string):
280         (TestExpectationSerializerTests.assert_round_trip):
281         (TestExpectationSerializerTests.assert_list_round_trip):
282         * Scripts/webkitpy/tool/commands/expectations.py:
283         (OptimizeExpectations.execute):
284         * Scripts/webkitpy/tool/servers/gardeningserver.py:
285         (GardeningExpectationsUpdater.update_expectations):
286
287 2012-01-20  Adam Barth  <abarth@webkit.org>
288
289         Follow-up to previous patch: don't produce NaN when the revision number
290         is missing.
291
292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
294
295 2012-01-20  Adam Barth  <abarth@webkit.org>
296
297         Garden-o-matic should tell me which revisions have been checked by all the bots
298         https://bugs.webkit.org/show_bug.cgi?id=76722
299
300         Reviewed by Dimitri Glazkov.
301
302         This information helps me know when it's safe for me to roll a
303         candidate revision.
304
305         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
308
309 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
310
311         build-webkit: Don't spit out congratulations message on Ctrl+C
312
313         Reviewed by Andreas Kling.
314
315         * Scripts/build-webkit:
316
317 2012-01-20  Philippe Normand  <pnormand@igalia.com>
318
319         [GTK] Allow extra jhbuild modulesets
320         https://bugs.webkit.org/show_bug.cgi?id=76691
321
322         Reviewed by Gustavo Noronha Silva.
323
324         * gtk/jhbuildrc: Extra modulesets and modules can be added in
325         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
326         env variables respectively. Use comma-separated values. Example:
327         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
328
329 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
330
331         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
332         https://bugs.webkit.org/show_bug.cgi?id=72589
333
334         Reviewed by Martin Robinson.
335
336         Ensure the accessibility infrastructure is available when running
337         the unit tests, otherwise WK2's accessibility tests won't work.
338
339         * Scripts/run-gtk-tests:
340         (TestRunner):
341         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
342         where at-spi2's stuff is located (like at-spi-bus-launcher and
343         at-spi2-registryd).
344         (TestRunner.run): Initialize the accessibility infrastructure.
345
346         * gtk/generate-gtkdoc:
347         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
348
349         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
350
351 2012-01-20  Hayato Ito  <hayato@chromium.org>
352
353         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
354         https://bugs.webkit.org/show_bug.cgi?id=76353
355
356         Reviewed by Hajime Morita.
357
358         Add ShadowRoot.idl, which is enabled only on chromium port since this is
359         under development feature.
360         ShadowRoot.idl contains minimum API so that we can test it.
361         Other APIs should be added on other changes so that we can isolate issues.
362
363         * DumpRenderTree/chromium/TestShell.cpp:
364         (TestShell::TestShell):
365
366 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
367
368         [GTK] GTK's DRT not to log events for already defunct objects
369         https://bugs.webkit.org/show_bug.cgi?id=76620
370
371         Reviewed by Martin Robinson.
372
373         Do not log 'state-change:defunct' events.
374
375         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
376         (printAccessibilityEvent): Early return if a
377         'state-change:defunct' signal is passed.
378         (axObjectEventListener): Pass the signal name and value in
379         separate parameters to printAccessibilityEvent.
380
381 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
382
383         Unreviewed build fix. Wrong variable being used as the cwd for git
384         remote update command.
385
386         * gtk/run-with-jhbuild:
387         (update_jhbuild):
388
389 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
390
391         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
392         https://bugs.webkit.org/show_bug.cgi?id=76585
393
394         Reviewed by Martin Robinson.
395
396         This allows us to specify a minimum version of jhbuild required,
397         while also providing stability against changes done to the master
398         branch, by letting us choose what is the exact version that will
399         be used.
400
401         * gtk/run-with-jhbuild: refactored for more hackability and easier
402         reading
403         (jhbuild_installed): checks whether jhbuild is installed
404         (jhbuild_cloned): checks whether jhbuild has been cloned
405         (jhbuild_at_expected_revision): checks whether jhbuild is at the
406         expected revision
407         (update_jhbuild): brings jhbuild to the expected revision
408         (clone_jhbuild): clones jhbuild
409         (install_jhbuild): build and installs jhbuild
410         (update_webkitgtk_libs): runs update-webkitgtk-libs
411         (ensure_jhbuild): high-level logic to decide whether and which of
412         the steps above are executed
413
414 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
415
416         [WK2] DumpRenderTree converts "file:///" to a path differently
417         https://bugs.webkit.org/show_bug.cgi?id=76653
418
419         Reviewed by John Sullivan.
420
421         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
422         Do print a slash if there are no path components.
423
424 2012-01-19  Eric Seidel  <eric@webkit.org>
425
426         webkit-patch cannot rollout patches without changelog/bug number
427         https://bugs.webkit.org/show_bug.cgi?id=75962
428
429         Reviewed by Adam Barth.
430
431         * Scripts/webkitpy/tool/commands/download.py:
432         (AbstractRolloutPrepCommand._prepare_state):
433         * Scripts/webkitpy/tool/commands/download_unittest.py:
434         (AbstractRolloutPrepCommandTest.test_prepare_state):
435
436 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
437
438         [WK2] fast/url/degenerate-file-base.html fails
439         https://bugs.webkit.org/show_bug.cgi?id=76619
440
441         Reviewed by Adam Roben.
442
443         A URL generated form local path for loading had an extra slash, making document.URL
444         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
445
446         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
447
448 2012-01-18  Ojan Vafai  <ojan@chromium.org>
449
450         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
451         https://bugs.webkit.org/show_bug.cgi?id=76510
452
453         Reviewed by Adam Barth.
454
455         Unlike other style rules, if you get the syntax of the test_expectations.txt
456         file wrong, the layout tests won't run. Also, this check is simple and only
457         slows down committing if you actually modify one of the test_expectations.txt files.
458
459         * Scripts/webkitpy/style/checkers/test_expectations.py:
460         (TestExpectationsChecker.check_test_expectations):
461         (TestExpectationsChecker.check):
462         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
463         (TestExpectationsTestCase.test_check_covers_all_configurations):
464         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
465         (TestExpectationsTestCase):
466         (assert_lines_lint):
467
468 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
469
470         Build fix. Revert an unintentional change to WebKitDriver in r105443.
471
472         * Scripts/webkitpy/layout_tests/port/driver.py:
473         (DriverProxy.__init__):
474
475 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
476
477         remove the duplicated build rules from WebKit.gyp, Tools.gyp
478         https://bugs.webkit.org/show_bug.cgi?id=73384
479
480         Reviewed by Tony Chang.
481
482         This patch removes the no-longer-necessary conditional logic for
483         build_webkit_exes_from_webkit_gyp; we now always build the exes
484         from their own dedicated gyp files.
485
486         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
487
488 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
489
490         make-new-script-test should work with HTTP tests
491         https://bugs.webkit.org/show_bug.cgi?id=76603
492
493         Reviewed by Adam Roben.
494
495         * Scripts/make-new-script-test:
496         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
497         now also creates absolute paths for HTTP.
498
499 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
500
501         Some perf tests time out when ran by run-perf-tests
502         https://bugs.webkit.org/show_bug.cgi?id=76612
503
504         Reviewed by Dirk Pranke and Eric Seidel.
505
506         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
507         Otherwise some tests such as Parser/xml-parser.html will timeout.
508
509         --no-timeout option is currently supported by Chromium and Mac ports.
510
511         * Scripts/webkitpy/layout_tests/port/base.py:
512         (Port.to.create_driver):
513         * Scripts/webkitpy/layout_tests/port/chromium.py:
514         (ChromiumDriver.__init__):
515         (ChromiumDriver._wrapper_options):
516         * Scripts/webkitpy/layout_tests/port/driver.py:
517         (Driver.__init__):
518         (DriverProxy.__init__):
519         * Scripts/webkitpy/layout_tests/port/webkit.py:
520         (WebKitDriver.__init__):
521         (WebKitDriver.cmd_line):
522         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
523         (WebKitDriverTest.test_read_binary_block):
524         (WebKitDriverTest):
525         (WebKitDriverTest.test_no_timeout):
526         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
527         (get_tests_run.RecordingTestDriver.__init__):
528         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
529         (PerfTestsRunner._parse_args):
530         (PerfTestsRunner._run_tests_set):
531         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
532         (create_runner):
533
534 2012-01-19  Ben Wells  <benwells@chromium.org>
535
536         Add support for window.print to chromium DRT
537         https://bugs.webkit.org/show_bug.cgi?id=76479
538
539         When used in a test window.print goes into print mode and then
540         straight out again. This will allow the afterprint event to be
541         tested by having the afterprint event happen before the dump
542         happens.
543
544         Reviewed by Mihai Parparita.
545
546         * DumpRenderTree/chromium/WebViewHost.cpp:
547         (WebViewHost::printPage):
548         * DumpRenderTree/chromium/WebViewHost.h:
549
550 2012-01-18  Enrica Casucci  <enrica@apple.com>
551
552         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
553         https://bugs.webkit.org/show_bug.cgi?id=76588
554         <rdar://problem/9325183>
555
556         Added test.
557         
558         Reviewed by Dan Bernstein.
559
560         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
561         (TestWebKitAPI::TEST):
562
563 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
564
565         [Qt] Do full incremental builds until bots use update-webkit
566
567         Rubber-stamped by Simon Hausmann.
568
569         * Scripts/webkitdirs.pm:
570         (buildQMakeProjects):
571
572 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
573
574         Fix the Qt build
575
576         Unreviewed build fix.
577
578         * Scripts/webkitdirs.pm:
579         (buildQMakeProjects):
580
581 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
582
583         [Qt] Make build-webkit always do safe incremental builds after update-webkit
584
585         When building against Qt5 with GCC we would just run 'make' in the build dir,
586         and rely on the dependency files output by GCC (-MD) to handle dependency
587         tracking, but that fails for special-cases like adding a Q_OBJECT macro
588         to a header.
589
590         To guarantee that an incrmental build will work, we have to run 'make qmake',
591         which we now do on every build-webkit that's followed by a successful run
592         of update-webkit. The reasoning is that update-webkit can result in such
593         potential corner-cases being applied, and since we can't know for sure
594         unless we inspect the diff and account for all the corner cases we assume
595         the worst and always run 'make qmake'.
596
597         After a succesful run of build-webkit we proceed to do just 'make' for any
598         subsequent runs, since we assume that the developer knows what kind of
599         changes he/she is doing, and when a 'make qmake' is needed.
600
601         Reviewed by Simon Hausmann.
602
603         * Scripts/update-webkit:
604         * Scripts/webkitdirs.pm:
605         (determineCurrentSVNRevision):
606         (currentSVNRevision):
607         (buildQMakeProjects):
608         * qmake/mkspecs/features/default_post.prf:
609
610 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
611
612         run-perf-tests should support Skipped list
613         https://bugs.webkit.org/show_bug.cgi?id=76594
614
615         Reviewed by Adam Barth.
616
617         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
618
619         * Scripts/webkitpy/layout_tests/port/base.py:
620         (Port.perf_tests_dir):
621         (Port.skipped_perf_tests):
622         (Port.skips_perf_test):
623         (Port.relative_perf_test_filename):
624         * Scripts/webkitpy/layout_tests/port/test.py:
625         (TestPort.perf_tests_dir):
626         * Scripts/webkitpy/layout_tests/port/webkit.py:
627         (WebKitPort._expectations_from_skipped_files):
628         (WebKitPort):
629         (WebKitPort.skipped_layout_tests):
630         (WebKitPort.skipped_perf_tests):
631         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
632         (PerfTestsRunner._collect_tests):
633         (PerfTestsRunner.run):
634         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
635         (test_run_test_set_with_json_output):
636         (test_run_test_set_with_json_source):
637         (test_collect_tests_with_skipped_list):
638         (test_collect_tests_with_skipped_list.add_file):
639
640 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
641
642         Fix path to chromium_src_dir introduced in previous change.
643
644         Unreviewed, build fix.
645
646         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
647
648 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
649
650         Need infrastructure to test Content-Disposition filename encoding support
651         https://bugs.webkit.org/show_bug.cgi?id=76572
652         <rdar://problem/6421825>
653
654         Reviewed by Sam Weinig.
655
656         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
657
658         WebKitTestRunner does not have a policy delegate yet, bug 42546.
659
660         * DumpRenderTree/mac/PolicyDelegate.mm:
661         (dispositionTypeFromContentDispositionHeader):
662         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
663
664 2012-01-18  Ojan Vafai  <ojan@chromium.org>
665
666         Fix tests from http://trac.webkit.org/changeset/105332.
667
668         The code assumed that if you passed an options object with a configuration
669         attribute that it would have a valid value. A bunch of the testing mocks
670         do things like having a configuration value of None.
671
672         * Scripts/webkitpy/layout_tests/port/base.py:
673         (Port.__init__):
674
675 2012-01-18  Ojan Vafai  <ojan@chromium.org>
676
677         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
678         https://bugs.webkit.org/show_bug.cgi?id=76576
679
680         Reviewed by Adam Barth.
681
682         Avoid calling default_configuration in base.py. We don't need it for
683         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
684         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
685         from common.executive.
686
687         At some point someone should probably look into why that call is so slow
688         since it's on the critical path for run-webkit-tests and build-webkit startup.
689
690         * Scripts/webkitpy/layout_tests/port/base.py:
691         (Port.__init__):
692         * Scripts/webkitpy/style/checkers/test_expectations.py:
693         (TestExpectationsChecker._determine_port_from_exepectations_path):
694
695 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
696
697         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
698         https://bugs.webkit.org/show_bug.cgi?id=76505
699
700         Reviewed by Tony Chang.
701
702         Update chromium build script to use All.gyp instead of WebKit.gyp
703
704         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
705         * Scripts/webkitdirs.pm:
706
707 2012-01-18  Sam Weinig  <sam@webkit.org>
708
709         Don’t hardcode the path to ‘make‘.
710
711         Reviewed by Dan Bernstein.
712
713         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
714
715 2012-01-18  Joshua Bell  <jsbell@chromium.org>
716
717         Adding myself to committers.py
718         https://bugs.webkit.org/show_bug.cgi?id=76569
719
720         Unreviewed.
721
722         * Scripts/webkitpy/common/config/committers.py:
723
724 2012-01-18  Adam Barth  <abarth@webkit.org>
725
726         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
727         https://bugs.webkit.org/show_bug.cgi?id=76567
728
729         Reviewed by Eric Seidel.
730
731         Current the AppleMac port has slightly more failures than we allow on
732         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
733         which should hopefully let the mac-ews run to completion.  Once
734         AppleMac has fewer failures, we can lower the cap again.
735
736         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
737         (LayoutTestResultsReaderTest.test_layout_test_results):
738         * Scripts/webkitpy/tool/steps/runtests.py:
739         (RunTests):
740         * Scripts/webkitpy/tool/steps/steps_unittest.py:
741
742 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
743
744         Provide access to user's list of preferred languages
745         https://bugs.webkit.org/show_bug.cgi?id=76138
746
747         Reviewed by Alexey Proskuryakov.
748
749         * GNUmakefile.am: Add JSInternalsCustom.cpp.
750
751 2012-01-18  Adam Barth  <abarth@webkit.org>
752
753         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
754         configurations.
755
756         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
757         (ChromiumLinuxPort.__init__):
758
759 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
760
761         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
762         https://bugs.webkit.org/show_bug.cgi?id=73460
763
764         Reviewed by Chris Fleizach.
765
766         * DumpRenderTree/AccessibilityUIElement.h:
767         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
768         (AccessibilityUIElement::AccessibilityUIElement):
769         (AccessibilityUIElement::scrollToMakeVisibleCallback):
770         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
771         (AccessibilityUIElement::scrollToGlobalPointCallback):
772         * DumpRenderTree/chromium/AccessibilityUIElement.h:
773         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
774         (AccessibilityUIElement::scrollToMakeVisible):
775         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
776         (AccessibilityUIElement::scrollToGlobalPoint):
777         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
778         (AccessibilityUIElement::scrollToMakeVisible):
779         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
780         (AccessibilityUIElement::scrollToGlobalPoint):
781         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
782         (AccessibilityUIElement::scrollToMakeVisible):
783         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
784         (AccessibilityUIElement::scrollToGlobalPoint):
785
786 2012-01-17  Enrica Casucci  <enrica@apple.com>
787
788         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
789         https://bugs.webkit.org/show_bug.cgi?id=76490
790         <rdar://problem/9460733>
791
792         Added TestWebKitAPI test.
793         
794         Reviewed by Dan Bernstein.
795
796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
797         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
798         changeAttributes to the WebView.
799         
800 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
801
802         [Qt] Consolidate layout test crash logging
803         https://bugs.webkit.org/show_bug.cgi?id=75088
804
805         Reviewed by Simon Hausmann.
806
807         Move backtrace generating logic into WTFReportBacktrace
808         and add a way to deinstall signal handlers if we know
809         that we have already printed the backtrace.
810
811         * DumpRenderTree/qt/main.cpp:
812         (crashHandler):
813         (setupSignalHandlers):
814         (WTFCrashHook):
815         (main):
816         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
817         (WTR::crashHandler):
818         (WTR::setupSignalHandlers):
819         (WTR::crashHook):
820         (WTR::InjectedBundle::platformInitialize):
821
822 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
823
824         Unreviewed build fix after r105256.
825
826         There was a cyclic dependency between self._port and self._host assigments.
827
828         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
829         (PerfTestsRunner.__init__):
830
831 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
832
833         Add new watchlist rule for the Qt build system
834
835         Reviewed by Simon Hausmann.
836
837         * Scripts/webkitpy/common/config/watchlist:
838
839 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
840
841         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
842
843         Reviewed by Simon Hausmann.
844
845         * Tools.pro:
846
847 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
848
849         [Qt] Allow building only a subset of the WebKit sub-projects
850
851         Fixes build-jsc, broken in r104825.
852
853         We no longer need the intermediate buildQMakeQtProject(), as we're the
854         only port using qmake, and buildQMakeProject is now highly Qt specific.
855
856         <http://webkit.org/b/76179>
857
858         Reviewed by Simon Hausmann.
859
860         * Scripts/build-jsc:
861         * Scripts/build-webkit:
862         * Scripts/webkitdirs.pm:
863         (buildQMakeProjects):
864
865 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
866
867         run-perf-tests should generate a json file that summaries the result
868         https://bugs.webkit.org/show_bug.cgi?id=76504
869
870         Reviewed by Adam Barth.
871
872         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
873         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
874         another json file to be merged into the generated json file.
875
876         Also fixed a bug that --build wasn't set by default.
877
878         * Scripts/webkitpy/layout_tests/port/test.py:
879         (TestPort.webkit_base):
880         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
881         (PerfTestsRunner.__init__):
882         (PerfTestsRunner):
883         (PerfTestsRunner._parse_args):
884         (PerfTestsRunner.run):
885         (PerfTestsRunner._generate_json_if_specified):
886         (PerfTestsRunner._process_chromium_style_test_result):
887         (PerfTestsRunner._process_parser_test_result):
888         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
889         (MainTest):
890         (create_runner):
891         (test_run_test_set):
892         (test_run_test_set_for_parser_tests):
893         (test_run_test_set_with_summary_json):
894         (test_collect_tests):
895         (test_parse_args):
896
897 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
898
899         Unreviewed, rolling out r105244.
900         http://trac.webkit.org/changeset/105244
901         https://bugs.webkit.org/show_bug.cgi?id=76518
902
903         broke Chromium Mac (Requested by rolandsteiner on #webkit).
904
905         * DumpRenderTree/AccessibilityUIElement.h:
906         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
907         (AccessibilityUIElement::AccessibilityUIElement):
908         * DumpRenderTree/chromium/AccessibilityUIElement.h:
909         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
910         (AccessibilityUIElement::removeSelection):
911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
912         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
913         (AccessibilityUIElement::removeSelection):
914
915 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
916
917         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
918         https://bugs.webkit.org/show_bug.cgi?id=73460
919
920         Reviewed by Chris Fleizach.
921
922         * DumpRenderTree/AccessibilityUIElement.h:
923         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
924         (AccessibilityUIElement::AccessibilityUIElement):
925         (AccessibilityUIElement::scrollToMakeVisibleCallback):
926         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
927         (AccessibilityUIElement::scrollToGlobalPointCallback):
928         * DumpRenderTree/chromium/AccessibilityUIElement.h:
929         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
930         (AccessibilityUIElement::scrollToMakeVisible):
931         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
932         (AccessibilityUIElement::scrollToGlobalPoint):
933         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
934         (AccessibilityUIElement::scrollToMakeVisible):
935         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
936         (AccessibilityUIElement::scrollToGlobalPoint):
937         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
938         (AccessibilityUIElement::scrollToMakeVisible):
939         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
940         (AccessibilityUIElement::scrollToGlobalPoint):
941
942 2012-01-17  Adam Barth  <abarth@webkit.org>
943
944         Enable tests on the mac-ews
945         https://bugs.webkit.org/show_bug.cgi?id=76502
946
947         Reviewed by Simon Fraser.
948
949         Apple now has five machines running the mac-ews.  Lucas Forschler has
950         asked that we try enabling tests to see if we have enough bandwidth.
951
952         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
953         (MacEWS):
954
955 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
956
957         Add a check-webkit-style exception for GDBInterface.cpp
958         https://bugs.webkit.org/show_bug.cgi?id=76187
959
960         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
961         that it does not fail the style check.
962
963         Reviewed by Martin Robinson.
964
965         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
966         readability/naming tests on
967         Source/JavaScriptCore/jit/GDBInterface.cpp.
968         * Scripts/webkitpy/style/checker_unittest.py:
969         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
970         the above exception.
971
972 2012-01-17  Hajime Morrita  <morrita@chromium.org>
973
974         https://bugs.webkit.org/show_bug.cgi?id=76245
975         [Mac][DRT] should allow query string for the file URL.
976
977         Reviewed by Tony Chang.
978
979         Taught DRT about file:// as a url instead of a file path.
980         We are now able to use a path file:///foo/bar.html?baz as a url
981         with which DRT opens "/foo/bar.html" with "baz" as a query string.
982
983         * DumpRenderTree/mac/DumpRenderTree.mm:
984         (runTest):
985
986 2012-01-17  Ojan Vafai  <ojan@chromium.org>
987
988         Check style on test_expectations.txt files before commit
989         https://bugs.webkit.org/show_bug.cgi?id=76484
990
991         Reviewed by Adam Barth.
992
993         Unlike other style rules, if you get the syntax of the test_expectations.txt
994         file wrong, the layout tests won't run. Also, this check is simple and only
995         slows down committing if you actually modify one of the test_expectations.txt files.
996
997         * Scripts/webkitpy/tool/steps/commit.py:
998         (Commit._check_test_expectations):
999         (Commit.run):
1000         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
1001         (CommitTest):
1002         (CommitTest.test_check_test_expectations):
1003
1004 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
1005
1006         [Qt] Debug build fails with debug qt5
1007         https://bugs.webkit.org/show_bug.cgi?id=76463
1008
1009         Reviewed by Simon Hausmann.
1010
1011         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
1012
1013         * QtTestBrowser/cookiejar.h:
1014
1015 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1016
1017         webkitpy: fix json import on linux
1018         https://bugs.webkit.org/show_bug.cgi?id=76481
1019
1020         Reviewed by Adam Barth.
1021
1022         For some reason, the version of simplejson autoinstalled on my linux
1023         box seems to be broken. We should really only be using
1024         simplejson if json isn't available anyway, so this change looks
1025         for json first.
1026
1027         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1028         (JSONGeneratorTest.test_test_timings_trie):
1029
1030 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1031
1032         Fix failures in test-webkitpy caused by r105177.
1033
1034         Unreviewed, build fix.
1035
1036         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1037         (ChromiumLinuxPort._determine_driver_path_statically):
1038         (ChromiumLinuxPort._static_build_path):
1039
1040 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1041
1042         webkitpy: make PortFactory.get() be fully data-driven
1043         https://bugs.webkit.org/show_bug.cgi?id=76360
1044
1045         Reviewed by Eric Seidel.
1046
1047         Refactor PortFactory.get() to be fully data-driven.
1048
1049         * Scripts/webkitpy/layout_tests/port/factory.py:
1050         (PortFactory):
1051         (PortFactory._default_port):
1052         (PortFactory.get):
1053         (PortFactory.get.in):
1054         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1055         (FactoryTest.assert_port):
1056
1057 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1058
1059         webkitpy: add determine_full_port_name(), clean up port.__init__()
1060         https://bugs.webkit.org/show_bug.cgi?id=76357
1061
1062         Reviewed by Adam Barth.
1063
1064         Each Port class is now required to implement a 'port_name' field
1065         that will match the start of all ports constructed by this class and
1066         a 'determine_full_port_name' field that will make the port
1067         fully-qualified.
1068
1069         * Scripts/webkitpy/layout_tests/port/apple.py:
1070         (ApplePort.__init__):
1071         * Scripts/webkitpy/layout_tests/port/base.py:
1072         (Port):
1073         (Port.determine_port_name):
1074         (Port.__init__):
1075         * Scripts/webkitpy/layout_tests/port/chromium.py:
1076         (ChromiumPort.for):
1077         (ChromiumPort.__init__):
1078         (ChromiumPort):
1079         (ChromiumPort._chromium_base_dir):
1080         (ChromiumPort.path_from_chromium_base):
1081         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1082         (ChromiumGpuLinuxPort):
1083         (ChromiumGpuLinuxPort.__init__):
1084         (ChromiumGpuMacPort):
1085         (ChromiumGpuMacPort.__init__):
1086         (ChromiumGpuWinPort):
1087         (ChromiumGpuWinPort.__init__):
1088         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1089         (ChromiumLinuxPort):
1090         (ChromiumLinuxPort.determine_port_name):
1091         (ChromiumLinuxPort.__init__):
1092         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1093         (ChromiumMacPort):
1094         (ChromiumMacPort.determine_port_name):
1095         (ChromiumMacPort.__init__):
1096         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1097         (ChromiumWinPort):
1098         (ChromiumWinPort.determine_port_name):
1099         (ChromiumWinPort.__init__):
1100         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1101         (DryRunPort):
1102         (DryRunPort.determine_port_name):
1103         (DryRunPort.__init__):
1104         * Scripts/webkitpy/layout_tests/port/efl.py:
1105         (EflPort):
1106         * Scripts/webkitpy/layout_tests/port/factory.py:
1107         (PortFactory):
1108         (PortFactory._default_port):
1109         (PortFactory.get):
1110         (PortFactory.get.in):
1111         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1112         (FactoryTest.assert_port):
1113         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1114         (GoogleChromeLinux32Port):
1115         (GoogleChromeLinux32Port.determine_port_name):
1116         (GoogleChromeLinux64Port):
1117         (GoogleChromeLinux64Port.determine_port_name):
1118         (GoogleChromeMacPort):
1119         (GoogleChromeMacPort.determine_port_name):
1120         (GoogleChromeWinPort):
1121         (GoogleChromeWinPort.determine_port_name):
1122         * Scripts/webkitpy/layout_tests/port/gtk.py:
1123         (GtkPort):
1124         * Scripts/webkitpy/layout_tests/port/mac.py:
1125         (MacPort):
1126         (MacPort.determine_port_name):
1127         (MacPort.__init__):
1128         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1129         (test_versions):
1130         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1131         (MockDRTPort):
1132         (MockDRTPort.determine_port_name):
1133         (MockDRTPort.__init__):
1134         (MockDRT):
1135         (MockDRT.determine_port_name):
1136         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1137         (PortTestCase.make_port):
1138         * Scripts/webkitpy/layout_tests/port/qt.py:
1139         (QtPort):
1140         (QtPort.determine_port_name):
1141         (QtPort.__init__):
1142         * Scripts/webkitpy/layout_tests/port/test.py:
1143         (TestPort):
1144         (TestPort.determine_port_name):
1145         (TestPort.__init__):
1146         * Scripts/webkitpy/layout_tests/port/webkit.py:
1147         (WebKitPort.__init__):
1148         * Scripts/webkitpy/layout_tests/port/win.py:
1149         (WinPort):
1150         (WinPort.determine_port_name):
1151         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1152         (get_test_baselines.AllPlatformsPort.__init__):
1153         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1154         (get_test_config.TestMacPort):
1155         (get_test_config):
1156
1157 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
1158
1159         webkitpy: clean up port code in preparation for static port names
1160         https://bugs.webkit.org/show_bug.cgi?id=76356
1161
1162         Reviewed by Adam Barth.
1163
1164         To fix bug 76215 and be able to determine appropriate port names
1165         in webkitpy without actually constructing Port objects, we need
1166         to shuffle some logic in the chromium ports to be able to figure
1167         out whether we built DRT in 32 or 64-bit mode.
1168
1169         * Scripts/webkitpy/layout_tests/port/chromium.py:
1170         (ChromiumPort):
1171         (ChromiumPort._chromium_base_dir):
1172         (ChromiumPort.__init__):
1173         (ChromiumPort.path_from_chromium_base):
1174         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1175         (ChromiumLinuxPort):
1176         (ChromiumLinuxPort._determine_driver_path_statically):
1177         (ChromiumLinuxPort._static_build_path):
1178         (ChromiumLinuxPort._determine_architecture):
1179         (ChromiumLinuxPort.__init__):
1180         (ChromiumLinuxPort._build_path):
1181
1182 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
1183
1184         Do not remove pixel failures for ref tests.
1185         https://bugs.webkit.org/show_bug.cgi?id=76243
1186
1187         Reviewed by Tony Chang.
1188
1189         'NRWT --no-pixel-tests' complains when reftests are expected to
1190         be image mismatch.
1191
1192         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1193         (Manager._update_summary_with_result):
1194         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1195         (is_reftest_failure):
1196         (determine_result_type):
1197
1198 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
1199
1200         REGRESSION(r81225): ORWT should ignore reftests
1201         https://bugs.webkit.org/show_bug.cgi?id=67936
1202
1203         Reviewed by Csaba Osztrogonác.
1204
1205         * Scripts/old-run-webkit-tests:
1206         (isUsedInReftest): $filename should be the first parameter
1207         (findTestsToRun): run test if it isn't reftest
1208
1209 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
1210
1211         Unreviewed. Fix python unit test I broke with r105142
1212
1213         * Scripts/webkitpy/common/config/ports_unittest.py:
1214         (WebKitPortTest.test_gtk_port):
1215
1216 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1217
1218         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
1219
1220         Qt 5 no longer has that flag.
1221
1222         Reviewed by Simon Hausmann.
1223
1224         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1225         (MiniBrowserApplication::notify):
1226
1227 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1228
1229         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
1230         https://bugs.webkit.org/show_bug.cgi?id=75857
1231
1232         Reviewed by Adam Barth.
1233
1234         * Scripts/webkitdirs.pm:
1235         (buildAutotoolsProject): move cleaning the build to happen early,
1236         and handle --update-gtk right after that
1237         * Scripts/webkitpy/common/config/ports.py:
1238         (GtkPort.build_webkit_command): pass --update-gtk as an option to
1239         build-webkit, so that it is used in the EWS
1240
1241 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1242
1243         [Qt] Don't add _debug postfix to targets when building debug only
1244
1245         Reviewed by Simon Hausmann.
1246
1247         * qmake/mkspecs/features/default_post.prf:
1248         * qmake/mkspecs/features/functions.prf:
1249
1250 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1251
1252         [Qt] Add more files to project-files for easier navigation in Qt Creator
1253
1254         Reviewed by Simon Hausmann.
1255
1256         * Tools.pro:
1257         * qmake/config.tests/README: Added.
1258
1259 2012-01-17  Philippe Normand  <pnormand@igalia.com>
1260
1261         [GTK] fast/dom/constructed-objects-prototypes.html fails
1262         https://bugs.webkit.org/show_bug.cgi?id=75432
1263
1264         Reviewed by Martin Robinson.
1265
1266         * Scripts/build-webkit: Enable video-track in GTK.
1267
1268 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
1269
1270         Add toyoshim as a committer.
1271         https://bugs.webkit.org/show_bug.cgi?id=76390
1272
1273         Reviewed by Hajime Morita.
1274
1275         * Scripts/webkitpy/common/config/committers.py:
1276
1277 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
1278
1279         [WinCairo] Build fix after r104155. Several debug targets were not
1280         properly including the '*Common' property sheets.
1281
1282         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
1283         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
1284         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
1285         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
1286         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
1287
1288 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
1289
1290         REGRESSION(r105072): It broke committers_unittest.py
1291         https://bugs.webkit.org/show_bug.cgi?id=76396
1292
1293         Reviewed by Adam Barth.
1294
1295         * Scripts/webkitpy/common/config/committers_unittest.py:
1296         (CommittersTest._assert_fuzz_match): It should handle more names.
1297         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
1298
1299 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
1300
1301         [GTK] Include gtk+3 in the jhbuild modules
1302         https://bugs.webkit.org/show_bug.cgi?id=76284
1303
1304         Reviewed by Philippe Normand.
1305
1306         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1307
1308 2012-01-16  Dan Winship  <danw@gnome.org>
1309
1310         Add myself as a committer
1311
1312         Unreviewed
1313
1314         * Scripts/webkitpy/common/config/committers.py:
1315
1316 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1317
1318         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
1319
1320         Some recent versions of a few Linux distributions have started passing
1321         --as-needed and --no-copy-dt-needed-entries by default to the linker,
1322         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
1323         needed a few symbols from libjavascriptcore_efl.so.
1324
1325         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
1326         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
1327         libraries are searched in the right order by the linker.
1328
1329 2012-01-16  Philippe Normand  <pnormand@igalia.com>
1330
1331         [GTK] set audio resources path in NRTW
1332         https://bugs.webkit.org/show_bug.cgi?id=76380
1333
1334         Reviewed by Martin Robinson.
1335
1336         * Scripts/webkitpy/layout_tests/port/gtk.py:
1337         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
1338         the uninstalled audio resources are used during webaudio tests.
1339
1340 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1341
1342         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
1343         https://bugs.webkit.org/show_bug.cgi?id=76369
1344
1345         Reviewed by Xan Lopez.
1346
1347         If there's an installed version of webkit and there are new
1348         symbols in the build tree, gtkdoc-scanobj fails due to undefined
1349         references, because the env ldflags are given before the local
1350         ones.
1351
1352         * gtk/gtkdoc.py:
1353         (GTKDoc._run_gtkdoc_scangobj):
1354
1355 2012-01-15  Pablo Flouret  <pablof@motorola.com>
1356
1357         Fix compilation errors on build-webkit --debug --no-video on mac.
1358         https://bugs.webkit.org/show_bug.cgi?id=75867
1359
1360         Reviewed by Philippe Normand.
1361
1362         Add --[no-]video-track to build-webkit, since video track feature
1363         depends on video.
1364
1365         * Scripts/build-webkit:
1366
1367 2012-01-14  James Robinson  <jamesr@chromium.org>
1368
1369         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
1370         https://bugs.webkit.org/show_bug.cgi?id=76313
1371
1372         Reviewed by Adam Barth.
1373
1374         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
1375
1376         * Scripts/run-chromium-webkit-unit-tests:
1377
1378 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1379
1380         Unreviewed, rolling out r105017.
1381         http://trac.webkit.org/changeset/105017
1382         https://bugs.webkit.org/show_bug.cgi?id=76333
1383
1384         broke the build (Requested by philn-tp on #webkit).
1385
1386         * gtk/jhbuild.modules:
1387
1388 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1389
1390         [GTK] Include gtk+3 in the jhbuild modules
1391         https://bugs.webkit.org/show_bug.cgi?id=76284
1392
1393         Reviewed by Philippe Normand.
1394
1395         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1396
1397 2012-01-13  Adam Barth  <abarth@webkit.org>
1398
1399         Remove --dry-run support from webkit-patch
1400         https://bugs.webkit.org/show_bug.cgi?id=76300
1401
1402         Reviewed by Dirk Pranke.
1403
1404         This is the rest of the patch from Bug 76300.  I landed it separtely
1405         because main.py had some stray conflict markers that I needed to clean
1406         up first.
1407
1408         * Scripts/webkitpy/test/main.py:
1409         (Tester.parse_args):
1410         (Tester._run_tests):
1411
1412 2012-01-13  Adam Barth  <abarth@webkit.org>
1413
1414         test-webkitpy does not run
1415         https://bugs.webkit.org/show_bug.cgi?id=76318
1416
1417         Unreviewed.
1418
1419         Looks like some conflict markers got left in the file.
1420
1421         * Scripts/webkitpy/test/main.py:
1422         (Tester.run):
1423
1424 2012-01-13  Adam Barth  <abarth@webkit.org>
1425
1426         Remove --dry-run support from webkit-patch
1427         https://bugs.webkit.org/show_bug.cgi?id=76300
1428
1429         Reviewed by Dirk Pranke.
1430
1431         We don't use this functionality for anything, and it doesn't really
1432         work.  Someone in #webkit tried using it and and got sad/confused.  We
1433         should just remove it.
1434
1435         * Scripts/webkitpy/common/checkout/scm/git.py:
1436         (Git.push_local_commits_to_server):
1437         * Scripts/webkitpy/common/checkout/scm/scm.py:
1438         (SCM.__init__):
1439         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1440         (_shared_test_commit_with_message):
1441         (GitSVNTest.test_commit_text_parsing):
1442         * Scripts/webkitpy/common/checkout/scm/svn.py:
1443         (SVN.commit_with_message):
1444         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1445         (Bugzilla.__init__):
1446         (Bugzilla.quips):
1447         (Bugzilla.authenticate):
1448         (Bugzilla.add_attachment_to_bug):
1449         (Bugzilla.add_patch_to_bug):
1450         (Bugzilla.create_bug):
1451         (Bugzilla.clear_attachment_flags):
1452         (Bugzilla.set_flag_on_attachment):
1453         (Bugzilla.obsolete_attachment):
1454         (Bugzilla.add_cc_to_bug):
1455         (Bugzilla.post_comment_to_bug):
1456         (Bugzilla.close_bug_as_fixed):
1457         (Bugzilla.reassign_bug):
1458         (reopen_bug):
1459         * Scripts/webkitpy/test/main.py:
1460         (Tester.parse_args):
1461         (Tester.run_tests):
1462
1463 2012-01-13  David Levin  <levin@chromium.org>
1464
1465         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1466         https://bugs.webkit.org/show_bug.cgi?id=76227
1467
1468         Reviewed by Dirk Pranke.
1469
1470         * Scripts/webkitpy/style/checkers/cpp.py:
1471         (check_for_leaky_patterns): The new check.
1472         (process_line): Added a call to the new check.
1473         (CppChecker): Added the new error type.
1474         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1475         (CppStyleTestBase):
1476         (CppStyleTestBase.perform_leaky_pattern_check):
1477         The check for only leaky pattern errors.
1478         (LeakyPatternTest): Test cases.
1479
1480 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1481
1482         test-webkitpy: clean up handling of test directories, QueueStatusServer
1483         https://bugs.webkit.org/show_bug.cgi?id=76238
1484
1485         Reviewed by Adam Barth.
1486
1487         This patch cleans up a bunch of hacks related to how we find all
1488         of the python unit tests and set up the sys.path variable in
1489         test-webkitpy.
1490
1491         This patch changes how test-webkitpy works slightly in that we
1492         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1493         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1494         This greatly simplifies the mapping of paths to module names and
1495         appears to have no significant performance impact or other drawbacks.
1496
1497         There are other ways that we could remove all of the hacks and
1498         still have a more flexible mapping of paths to module names, but
1499         the ones I've thought of so far add a decent amount of complexity to
1500         the implementation and don't seem to buy us much.
1501         
1502         * QueueStatusServer/__init__.py:
1503         * Scripts/test-webkitpy:
1504         * Scripts/webkitpy/test/main.py:
1505         (Tester._modules_from_paths):
1506         (Tester._is_module):
1507
1508 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1509
1510         test-webkitpy: should support classes and individual test names as well as modules
1511         https://bugs.webkit.org/show_bug.cgi?id=76233
1512
1513         Reviewed by Adam Barth.
1514
1515         The default unittest.main() supports a list of individual
1516         TestCase classes or individual tests as well as modules. This
1517         change adds support for the same to test-webkitpy, so now you
1518         can say
1519
1520           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1521
1522         and
1523
1524           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1525
1526         in addition to
1527
1528           % test-wekbitpy webkitpy.test.cat_unittest
1529
1530         * Scripts/test-webkitpy:
1531         * Scripts/webkitpy/test/cat_unittest.py:
1532         * Scripts/webkitpy/test/main.py:
1533         (Tester.parse_args):
1534         (Tester.run):
1535         (Tester):
1536         (Tester._find_modules):
1537         (Tester._exclude):
1538         (Tester._run_tests):
1539         (Tester._is_module):
1540         (Tester._log_exception):
1541
1542 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1543
1544         test-webkitpy: add basic code coverage support
1545         https://bugs.webkit.org/show_bug.cgi?id=76201
1546
1547         Reviewed by Adam Barth.
1548
1549         This test adds basic code coverage support to test-webkitpy; if
1550         you pass the -c flag, we will generate a new coverage file. We
1551         can start simply with this and add more features as necessary.
1552
1553         This patch requires coverage to be already installed on the
1554         machine. I am not auto-installing this for now.
1555
1556         * Scripts/webkitpy/test/main.py:
1557         (Tester.parse_args):
1558         (Tester.run_tests):
1559
1560 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1561
1562         StatusBubbleTest.test_build_bubble is failing
1563         https://bugs.webkit.org/show_bug.cgi?id=76222
1564
1565         Reviewed by Adam Barth.
1566
1567         * QueueStatusServer/handlers/statusbubble_unittest.py:
1568         (StatusBubbleTest.test_build_bubble):
1569
1570 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1571
1572         nrwt should use multiple http shards
1573         https://bugs.webkit.org/show_bug.cgi?id=75958
1574
1575         Add --max-locked-shards option to the nrwt for manual set
1576         the maximum number of the locked shards
1577
1578         Reviewed by Dirk Pranke.
1579
1580         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1581         (Manager._max_locked_shards):
1582         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1583         (ShardingTests.get_shards):
1584         (ShardingTests.test_multiple_locked_shards):
1585         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1586         (parse_args):
1587
1588 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1589
1590         prepare-ChangeLog: Look for a text editor in a few more variables.
1591         https://bugs.webkit.org/show_bug.cgi?id=76289
1592
1593         Reviewed by Ryosuke Niwa.
1594
1595         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1596         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1597         to the OS X-specific open(1) command.
1598
1599         As there does not seem to be a common way of looking for a text editor
1600         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1601         $EDITOR (set much more often than the other variables in Unix systems)
1602         before falling back to open(1).
1603
1604         * Scripts/prepare-ChangeLog:
1605         (openChangeLogs):
1606
1607 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1608
1609         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1610         https://bugs.webkit.org/show_bug.cgi?id=76269
1611
1612         Reviewed by Martin Robinson.
1613
1614         * gtk/gtkdoc.py:
1615         (GTKDoc._run_gtkdoc_scangobj):
1616
1617 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1618
1619         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1620         https://bugs.webkit.org/show_bug.cgi?id=76247
1621
1622         Reviewed by Kenneth Rohde Christiansen.
1623
1624         * WebKitTestRunner/TestController.cpp:
1625         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1626
1627 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1628
1629         [Mac][DRT] Should support --no-timeout
1630         https://bugs.webkit.org/show_bug.cgi?id=76242
1631
1632         Reviewed by Darin Adler.
1633
1634         * DumpRenderTree/mac/DumpRenderTree.mm:
1635         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1636         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1637         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1638         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1639         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1640         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1641
1642 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1643
1644         Mitigate scrollbar differences when running pixel tests
1645         https://bugs.webkit.org/show_bug.cgi?id=67217
1646
1647         Reviewed by Dan Bernstein.
1648         
1649         Enable mock scrollbars by default for tests.
1650
1651         * DumpRenderTree/mac/DumpRenderTree.mm:
1652         (resetDefaultsToConsistentValues):
1653         * WebKitTestRunner/TestController.cpp:
1654         (WTR::TestController::resetStateToConsistentValues):
1655
1656 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1657
1658         Need a script to run tests in PerformanceTests
1659         https://bugs.webkit.org/show_bug.cgi?id=76132
1660
1661         Reviewed by Adam Barth.
1662
1663         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1664         Unfortunately, there isn't an easy way of telling which test uses which format
1665         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1666
1667         All test outputs are re-formatted to match Chromium perf-bot style.
1668
1669         * Scripts/run-inspector-perf-tests.py:
1670         * Scripts/run-perf-tests: Added.
1671         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1672         (PerfTestsRunner):
1673         (PerfTestsRunner.__init__):
1674         (PerfTestsRunner._collect_tests):
1675         (PerfTestsRunner.run):
1676         (PerfTestsRunner._print_status):
1677         (PerfTestsRunner._run_tests_set):
1678         (PerfTestsRunner._process_chromium_style_test_result):
1679         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1680         (PerfTestsRunner._process_parser_test_result):
1681         (PerfTestsRunner._run_single_test):
1682         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1683         (MainTest.TestDriver.run_test):
1684         (create_runner):
1685         (run_test):
1686         (test_run_test_set):
1687         (test_run_test_set_for_parser_tests):
1688         (test_collect_tests):
1689
1690 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1691
1692         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1693         https://bugs.webkit.org/show_bug.cgi?id=76123
1694
1695         Reviewed by Adam Barth.
1696
1697         This change updates the unit tests to be more consistent in how
1698         ports are created, in preparation for making port_name a
1699         mandatory parameter to the constructor and removing any version
1700         interpretation from it.
1701
1702         There should be no functional changes in this patch, but some
1703         tests that are no longer relevant have been removed or reworked.
1704
1705         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1706         (PortTest.test_get_option__default):
1707         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1708         (ChromiumLinuxPortTest):
1709         (ChromiumLinuxPortTest.assert_architecture):
1710         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1711         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1712         (ChromiumMacPortTest):
1713         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1714         (ChromiumPortTest):
1715         (ChromiumPortTest.test_all_test_configurations):
1716         (ChromiumPortTest.TestMacPort.__init__):
1717         (ChromiumPortTest.TestLinuxPort.__init__):
1718         (ChromiumPortTest.TestWinPort.__init__):
1719         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1720         (ChromiumWinTest):
1721         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1722         (EflPortTest):
1723         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1724         (GtkPortTest):
1725         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1726         (MacTest):
1727         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1728         (MockDRTPortTest):
1729         (MockDRTPortTest.make_port):
1730         * Scripts/webkitpy/layout_tests/port/qt.py:
1731         (QtPort._port_flag_for_scripts):
1732         (QtPort.__init__):
1733         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1734         (QtPortTest):
1735         (QtPortTest._assert_search_path):
1736         (QtPortTest.test_baseline_search_path):
1737         (QtPortTest.test_operating_system):
1738         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1739         (WebKitPortTest):
1740         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1741         (WinPortTest):
1742         (WinPortTest._assert_search_path):
1743         (WinPortTest.test_baseline_search_path):
1744         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1745         (get_test_config.TestMacPort.__init__):
1746
1747 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1748
1749         test-webkitpy: clean up logging and provide a real --help message
1750         https://bugs.webkit.org/show_bug.cgi?id=76142
1751
1752         Reviewed by Adam Barth.
1753
1754         This test is mostly more refactoring - it calls objects in
1755         unittest directly instead of routing through unittest.main() --
1756         in order to gain more control over the logging and to provide a
1757         correct --help message. This will also give us a better
1758         foundation for adding more feautures down the road.
1759
1760         This patch adds different levels of logging controlled by the
1761         '-s', '-q', and '-v' options (see --help for details), and
1762         removes the --verbose-logging option.
1763
1764         * Scripts/test-webkitpy:
1765         * Scripts/webkitpy/test/main.py:
1766         (Tester):
1767         (Tester.clean_packages):
1768         (Tester.__init__):
1769         (Tester.parse_args):
1770         (Tester.configure):
1771         (Tester._configure_logging):
1772         (Tester.find_modules):
1773         (Tester._exclude):
1774         (Tester._modules_from_paths):
1775         (Tester.run_tests):
1776
1777 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1778
1779         Make the new WTF module build on Qt
1780         https://bugs.webkit.org/show_bug.cgi?id=76163
1781
1782         Reviewed by Tor Arne Vestbø.
1783
1784         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1785
1786 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1787
1788         Unreviewed, mac DumpRenderTree fix.
1789
1790         * DumpRenderTree/mac/UIDelegate.mm:
1791         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1792
1793 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1794
1795         WebKitTestRunner should not print console message line number when it is equal to zero.
1796         https://bugs.webkit.org/show_bug.cgi?id=76167
1797
1798         Reviewed by Csaba Osztrogonác.
1799
1800         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1801         (WTR::InjectedBundlePage::willAddMessageToConsole):
1802
1803 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1804
1805         Make default console messages line numbers consistent.
1806         https://bugs.webkit.org/show_bug.cgi?id=74075
1807
1808         Reviewed by Pavel Feldman.
1809
1810         Unset line numbers are not printed to console now.
1811         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1812
1813         * DumpRenderTree/chromium/WebViewHost.cpp:
1814         (WebViewHost::didAddMessageToConsole):
1815         * DumpRenderTree/efl/CMakeLists.txt:
1816         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1817         (onConsoleMessage):
1818         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1819         (webViewConsoleMessage):
1820         * DumpRenderTree/mac/UIDelegate.mm:
1821         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1822         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1823         (WebCore::WebPage::javaScriptConsoleMessage):
1824         * DumpRenderTree/win/UIDelegate.cpp:
1825         (UIDelegate::webViewAddMessageToConsole):
1826         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1827         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1828
1829 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1830
1831         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1832         https://bugs.webkit.org/show_bug.cgi?id=76021
1833
1834         Reviewed by Eric Seidel.
1835
1836         I plan to add more functionality to test-webkitpy, but it is
1837         difficult to hack on now; this patch is the first of two that
1838         brings test-webkitpy more inline with current coding style by
1839         pushing more logic into the webkitpy.test.main.Tester class (so
1840         that it will be testable itself).
1841         
1842         There should be no functional changes in this patch.
1843
1844         * Scripts/test-webkitpy:
1845         (_path_from_webkit_root):
1846         * Scripts/webkitpy/test/main.py:
1847         (Tester):
1848         (Tester.init):
1849         (Tester.configure_logging):
1850         (Tester.configure_logging.filter):
1851         (Tester.clean_packages):
1852         (Tester.run_tests):
1853
1854 2012-01-11  Wei Jia  <wjia@chromium.org>
1855
1856         implement layout tests for <video> with media stream
1857         https://bugs.webkit.org/show_bug.cgi?id=74882
1858
1859         Reviewed by Kent Tamura.
1860
1861         * DumpRenderTree/DumpRenderTree.gypi:
1862         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1863         (WebKit::WebUserMediaClientMock::create):
1864         (WebKit::WebUserMediaClientMock::IsMockStream):
1865         (WebKit::WebUserMediaClientMock::requestUserMedia):
1866         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1867         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1868         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1869         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1870         * DumpRenderTree/chromium/WebViewHost.cpp:
1871         (WebViewHost::userMediaClient):
1872         (WebViewHost::userMediaClientMock):
1873         (WebViewHost::createMediaPlayer):
1874         (WebViewHost::mediaStreamUtil):
1875         (WebViewHost::testMediaStreamClient):
1876         * DumpRenderTree/chromium/WebViewHost.h:
1877
1878 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1879
1880         Unreviewed, build fix.
1881
1882         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1883
1884         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1885         (ChromiumWinPort.__init__):
1886
1887 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1888
1889         Sheriffbot build fix. Don't emit empty lines on IRC.
1890
1891         * Scripts/webkitpy/tool/bot/irc_command.py:
1892         (LastGreenRevision.execute):
1893
1894 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1895
1896         last-green-revision should report the revision that succeeded on all bots
1897         https://bugs.webkit.org/show_bug.cgi?id=76109
1898
1899         Reviewed by Adam Barth.
1900
1901         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1902         considered green by this algorithm, all matching builders must have a successful run at the revision
1903         or two consecutive successful runs before and after the revision.
1904
1905         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1906         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1907
1908         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1909         (BuildBot._revisions_for_builder):
1910         (BuildBot):
1911         (BuildBot._find_green_revision):
1912         (BuildBot.last_green_revision):
1913         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1914         (MockBuildBot.last_green_revision):
1915         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1916         (test_revisions_for_builder):
1917         (test_find_green_revision):
1918         (test_last_green_revision):
1919         * Scripts/webkitpy/tool/bot/irc_command.py:
1920         (LastGreenRevision.execute):
1921         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1922         (SheriffIRCBotTest.test_lgr):
1923         * Scripts/webkitpy/tool/commands/queries.py:
1924         (LastGreenRevision):
1925
1926 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1927
1928         Unreviewed, fix build bustage on win32 introduced by r104725.
1929
1930         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1931         (MockDRTPortTest.make_port):
1932         (MockChromiumDRTTest.test_pixeltest__fails):
1933
1934 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1935
1936         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1937         https://bugs.webkit.org/show_bug.cgi?id=75618
1938
1939         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1940
1941         Reviewed by Tony Chang.
1942
1943         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1944         (installLayoutTestColorProfile):
1945         (restoreUserColorProfile):
1946         (main):
1947
1948 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1949
1950         test-webkitpy: fix -v and eliminate some spurious warnings
1951         https://bugs.webkit.org/show_bug.cgi?id=76099
1952
1953         Reviewed by Adam Barth.
1954
1955         when we added support for --xml output, we broke the -v flag.
1956
1957         Also, fix the code to swallow a harmless warning from
1958         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1959
1960         test-webkitpy is now silent again except for the one known
1961         logging issue.
1962
1963         * Scripts/webkitpy/common/checkout/checkout.py:
1964         (Checkout.commit_message_for_this_commit):
1965         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1966         (test_commit_message_for_this_commit):
1967         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1968         (JSONChecker.check):
1969         (JSONChecker.line_number_from_json_exception):
1970         * Scripts/webkitpy/test/main.py:
1971         (Tester.run_tests):
1972
1973 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1974
1975         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1976         https://bugs.webkit.org/show_bug.cgi?id=76084
1977
1978         Reviewed by Adam Barth.
1979
1980         This will help make it easier to catch layering violations. This
1981         change just refactors test code; there are no changes to
1982         production code.
1983
1984         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1985         (PortTest.make_port):
1986         (PortTest.test_find_no_paths_specified):
1987         (PortTest.test_find_one_test):
1988         (PortTest.test_find_glob):
1989         (PortTest.test_find_with_skipped_directories):
1990         (PortTest.test_find_with_skipped_directories_2):
1991         (PortTest.test_parse_reftest_list):
1992         (PortTest.test_httpd_returns_error_code):
1993         (PortTest.test_virtual_methods):
1994         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1995         (ChromiumGpuTest.assert_port_works):
1996         (ChromiumGpuTest._assert_baseline_path):
1997         (ChromiumGpuTest.test_graphics_type):
1998         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1999         (ChromiumGpuTest.test_test_files):
2000         (ChromiumGpuTest.test_test_files.test_paths):
2001         (ChromiumGpuTest):
2002         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2003         (ChromiumLinuxPortTest.assert_architecture):
2004         (ChromiumLinuxPortTest.test_check_illegal_port_names):
2005         (ChromiumLinuxPortTest.test_determine_architecture_fails):
2006         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2007         (DriverTest.make_port):
2008         (DriverTest):
2009         (DriverTest.assertVirtual):
2010         (DriverTest._assert_wrapper):
2011         (DriverTest.test_virtual_driver_methods):
2012         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2013         (MockDRTPortTest.make_port):
2014         (MockDRTPortTest.test_port_name_in_constructor):
2015         (MockDRTTest.assertTest):
2016         (MockDRTTest.test_main):
2017         (MockChromiumDRTTest.test_pixeltest__fails):
2018         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2019         (QtPortTest._assert_search_path):
2020         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2021         (TestWebKitPort.__init__):
2022         (WebKitPortUnitTests.test_default_options):
2023         (test_runtime_feature_list):
2024         (test_test_expectations):
2025
2026 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2027
2028         Style skipped tests in the flakiness dashboard
2029         https://bugs.webkit.org/show_bug.cgi?id=76091
2030
2031         Reviewed by Tony Chang.
2032
2033         * TestResultServer/static-dashboards/dashboard_base.js:
2034         Removed "FLAKY" from this list since we don't ever mark individual runs
2035         as flaky. Also deleted an outdated line.
2036         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2037
2038 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2039
2040         Remove gtest normalization code from the test results server
2041         https://bugs.webkit.org/show_bug.cgi?id=76089
2042
2043         Reviewed by Tony Chang.
2044
2045         The normalization now happens on the gtest side.
2046
2047         * TestResultServer/model/jsonresults.py:
2048         (JsonResults.merge):
2049         * TestResultServer/model/jsonresults_unittest.py:
2050         (JsonResultsTest.test_gtest):
2051
2052 2012-01-11  Ojan Vafai  <ojan@chromium.org>
2053
2054         Be more aggressive about deleting unnecessary results from the test-results-server json files
2055         https://bugs.webkit.org/show_bug.cgi?id=76086
2056
2057         Reviewed by Tony Chang.
2058
2059         Remove any tests that only contain skip/pass/nodata values whose runtime
2060         is less than 5 seconds.
2061
2062         * TestResultServer/model/jsonresults.py:
2063         (JsonResults._normalize_results_json):
2064         * TestResultServer/model/jsonresults_unittest.py:
2065         (JsonResultsTest.test_merge_remove_test):
2066         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
2067
2068 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
2069
2070         last-green-revision should give us per-bot information
2071         https://bugs.webkit.org/show_bug.cgi?id=76011
2072
2073         Reviewed by Adam Barth.
2074
2075         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
2076         we report the latest green run on each bot from the last 100 runs.
2077
2078         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2079         (BuildBot._fetch_builder_page):
2080         (BuildBot):
2081         (BuildBot._green_revision_for_builder):
2082         (BuildBot.last_green_revision):
2083         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2084         (test_green_revision_for_builder):
2085         (test_last_green_revision):
2086         * Scripts/webkitpy/tool/bot/irc_command.py:
2087         (LastGreenRevision.execute):
2088         * Scripts/webkitpy/tool/commands/queries.py:
2089         (LastGreenRevision.execute):
2090
2091 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
2092
2093         webkitpy: clean up version detection in webkitpy.layout_tests.port
2094         https://bugs.webkit.org/show_bug.cgi?id=76016
2095
2096         Reviewed by Adam Barth.
2097
2098         This change updates the code in webkitpy.layout_tests.port to
2099         use the new os_name and os_version fields on host.platform. This
2100         gets layout_tests.port out of the version parsing business. Most
2101         of the diffs are just cleaning up test code to accomodate the
2102         changes.
2103
2104         * Scripts/webkitpy/common/system/executive_mock.py:
2105         (MockExecutive):
2106         (MockExecutive.ignore_error):
2107         (MockExecutive2):
2108         (MockExecutive2.ignore_error):
2109         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2110         (MockPlatformInfo.is_mac):
2111         (MockPlatformInfo.is_linux):
2112         (MockPlatformInfo.is_win):
2113         * Scripts/webkitpy/common/system/systemhost_mock.py:
2114         (MockSystemHost.__init__):
2115         * Scripts/webkitpy/layout_tests/port/apple.py:
2116         (ApplePort.__init__):
2117         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2118         (ChromiumMacPort.__init__):
2119         (ChromiumMacPort.check_wdiff):
2120         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2121         (ChromiumMacPortTest):
2122         (ChromiumMacPortTest.assert_name):
2123         (ChromiumMacPortTest.test_versions):
2124         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2125         (ChromiumPortTest.test_all_test_configurations):
2126         (ChromiumPortTest.TestMacPort.__init__):
2127         (ChromiumPortTest.TestLinuxPort.__init__):
2128         (ChromiumPortTest.TestWinPort.__init__):
2129         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2130         (ChromiumWinPort.__init__):
2131         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2132         (ChromiumWinTest):
2133         (ChromiumWinTest.assert_name):
2134         (ChromiumWinTest.test_versions):
2135         (ChromiumWinTest.test_baseline_path):
2136         (ChromiumWinTest.test_build_path):
2137         * Scripts/webkitpy/layout_tests/port/factory.py:
2138         (PortFactory._port_name_from_arguments_and_options):
2139         (PortFactory.get):
2140         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2141         (FactoryTest):
2142         (FactoryTest.setUp):
2143         (FactoryTest.assert_port):
2144         (FactoryTest.test_mac):
2145         (FactoryTest.test_win):
2146         (FactoryTest.test_google_chrome):
2147         (FactoryTest.test_gtk):
2148         (FactoryTest.test_qt):
2149         (FactoryTest.test_chromium_gpu):
2150         (FactoryTest.test_chromium_gpu_linux):
2151         (FactoryTest.test_chromium_gpu_mac):
2152         (FactoryTest.test_chromium_gpu_win):
2153         (FactoryTest.test_chromium_mac):
2154         (FactoryTest.test_chromium_linux):
2155         (FactoryTest.test_chromium_win):
2156         (FactoryTest.test_unknown_specified):
2157         (FactoryTest.test_unknown_default):
2158         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2159         (TestGoogleChromePort):
2160         (TestGoogleChromePort._verify_baseline_path):
2161         (TestGoogleChromePort._verify_expectations_overrides):
2162         (TestGoogleChromePort.test_get_google_chrome_port):
2163         * Scripts/webkitpy/layout_tests/port/mac.py:
2164         (MacPort):
2165         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2166         (MacTest):
2167         (assert_name):
2168         (test_tests_for_other_platforms):
2169         (test_version):
2170         (test_versions):
2171         (test_is_version_methods):
2172         (test_setup_environ_for_server):
2173         (_assert_search_path):
2174         (test_show_results_html_file):
2175         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2176         (PortTestCase):
2177         (PortTestCase.make_port):
2178         * Scripts/webkitpy/layout_tests/port/win.py:
2179         (WinPort):
2180         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2181         (WinPortTest):
2182         (WinPortTest.test_show_results_html_file):
2183         (WinPortTest._assert_search_path):
2184         (WinPortTest._assert_version):
2185
2186 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
2187
2188         [Qt][WK2] Remove workaround introduced into bug 75470
2189         https://bugs.webkit.org/show_bug.cgi?id=75889
2190
2191         Reviewed by Tor Arne Vestbø.
2192
2193         * MiniBrowser/qt/qml/BrowserWindow.qml:
2194
2195 2012-01-10  Dmitry Lomov  <dslomov@google.com>
2196
2197         [Chromium] Remove obsolete references to WebWorker class.
2198         https://bugs.webkit.org/show_bug.cgi?id=76020
2199
2200         Reviewed by David Levin.
2201
2202         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
2203         * DumpRenderTree/chromium/WebViewHost.cpp:
2204         * DumpRenderTree/chromium/WebViewHost.h:
2205
2206 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
2207
2208         [Qt] Some css3 filter tests are failing after r104698
2209         https://bugs.webkit.org/show_bug.cgi?id=76055
2210
2211         Reviewed by Simon Hausmann.
2212
2213         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2214         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
2215
2216 2012-01-11  Tony Chang  <tony@chromium.org>
2217
2218         Don't remove 0 byte files when running build-webkit --chromium
2219         https://bugs.webkit.org/show_bug.cgi?id=75997
2220
2221         Reviewed by Csaba Osztrogonác.
2222
2223         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
2224
2225         * Scripts/webkitdirs.pm:
2226         (determineIsQt):
2227
2228 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2229
2230         Add TestWebKitAPI tests for KURL
2231         <http://webkit.org/b/75774>
2232
2233         Reviewed by Adam Barth.
2234
2235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
2236         WebCore folder and KURL.cpp source file to the project.
2237         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
2238         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
2239         during setup since this test doesn't go through WebKit or
2240         WebKit2.
2241         (TestWebKitAPI::TEST_F): Add two basic tests.
2242
2243 2012-01-10  David Kilzer  <ddkilzer@apple.com>
2244
2245         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
2246
2247         Reviewed by Adam Barth.
2248
2249         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
2250
2251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
2252         WTFStringUtilities.h to the project.
2253         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
2254         WTFStringUtilities.h.
2255         * TestWebKitAPI/WTFStringUtilities.h: Added.
2256         (WTF::operator<<):
2257
2258 2012-01-10  Vincent Scheib  <scheib@chromium.org>
2259
2260         Clarify run-webkit-tests options reset-results and new-baseline
2261         https://bugs.webkit.org/show_bug.cgi?id=75993
2262
2263         Reviewed by Dirk Pranke.
2264
2265         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2266         (parse_args):
2267
2268 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
2269
2270         Disabled mock scrollbars should draw differently
2271         https://bugs.webkit.org/show_bug.cgi?id=75995
2272
2273         Reviewed by James Robinson.
2274
2275         When the scrollbar is disabled, paint the entire track of
2276         mock scrollbars with a lighter gray, and hide the thumb.
2277
2278         * DumpRenderTree/mac/DumpRenderTree.mm:
2279         (-[DRTMockScroller drawKnob]):
2280         (-[DRTMockScroller drawRect:]):
2281
2282 2012-01-10  James Robinson  <jamesr@chromium.org>
2283
2284         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
2285         https://bugs.webkit.org/show_bug.cgi?id=75988
2286
2287         Reviewed by Adam Barth.
2288
2289         * Scripts/webkitpy/common/config/ports.py:
2290         (WebKitPort.run_webkit_unit_tests_command):
2291         (WebKitPort):
2292         (ChromiumPort.run_webkit_unit_tests_command):
2293         (ChromiumPort):
2294         * Scripts/webkitpy/common/config/ports_mock.py:
2295         (MockPort.run_webkit_unit_tests_command):
2296         * Scripts/webkitpy/tool/commands/download_unittest.py:
2297         (DownloadCommandsTest.test_build_and_test):
2298         (test_land):
2299         (test_land_red_builders):
2300         * Scripts/webkitpy/tool/steps/runtests.py:
2301         (RunTests.run):
2302         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2303
2304 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2305
2306         webkitpy: add os_name, os_version to platforminfo
2307         https://bugs.webkit.org/show_bug.cgi?id=75931
2308
2309         Reviewed by Eric Siedel.
2310
2311         As a first step in cleaning up the version parsing logic in
2312         webkitpy.layout_tests.port, this adds common routines for
2313         getting the os_name and os_version fields to the PlatformInfo
2314         class. Nothing uses them yet but I've added FIXME's to some of
2315         the code that needs to be deleted in the port files.
2316
2317         * Scripts/webkitpy/common/system/platforminfo.py:
2318         (PlatformInfo.__init__):
2319         (PlatformInfo):
2320         (PlatformInfo._determine_os_name):
2321         (PlatformInfo._determine_mac_version):
2322         (PlatformInfo._determine_linux_version):
2323         (PlatformInfo._determine_win_version):
2324         (PlatformInfo.display_name):
2325         (PlatformInfo.total_bytes_memory):
2326         (PlatformInfo._compute_bytes_from_vm_stat_output):
2327         (PlatformInfo.free_bytes_memory):
2328         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
2329         (TestPlatformInfo):
2330         (TestPlatformInfo.make_info):
2331         (TestPlatformInfo.make_info.mock_run_command):
2332         (TestPlatformInfo.setUp):
2333         (TestPlatformInfo.tearDown):
2334         (TestPlatformInfo.test_basic):
2335         (TestPlatformInfo.integration_test_basic):
2336         (TestPlatformInfo.test_display_name_mac):
2337         (TestPlatformInfo.test_display_name_win32):
2338         (TestPlatformInfo.test_memory_mac):
2339         (TestPlatformInfo.test_memory_win32):
2340         (TestPlatformInfo.test_determine_os_name):
2341         (TestPlatformInfo.test_determine_mac_version):
2342         (TestPlatformInfo.test_determine_linux_version):
2343         (TestPlatformInfo.test_determine_win_version_from_tuple):
2344         (TestPlatformInfo.test_determine_win_version_from_cmd):
2345         * Scripts/webkitpy/layout_tests/port/apple.py:
2346         (ApplePort.__init__):
2347         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2348         (ChromiumMacPort.__init__):
2349         * Scripts/webkitpy/layout_tests/port/mac.py:
2350         (MacPort):
2351         * Scripts/webkitpy/layout_tests/port/win.py:
2352         (WinPort):
2353
2354 2012-01-10  Adam Roben  <aroben@apple.com>
2355
2356         Make it possible to type data: URLs into MiniBrowser on Windows
2357
2358         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
2359         MiniBrowser on Windows
2360
2361         Reviewed by Darin Adler.
2362
2363         * MiniBrowser/win/BrowserWindow.cpp:
2364         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
2365         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
2366         does, we assume it already has a scheme and don't modify it.
2367
2368 2012-01-10  Adam Roben  <aroben@apple.com>
2369
2370         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
2371
2372         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
2373         MiniBrowser on Windows
2374
2375         Reviewed by Darin Adler.
2376
2377         * MiniBrowser/win/BrowserView.cpp:
2378         (BrowserView::goToURL): Pass the typed string through
2379         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
2380
2381 2012-01-10  Ben Wells  <benwells@chromium.org>
2382
2383         Adding myself (benwells) to committers.py
2384         https://bugs.webkit.org/show_bug.cgi?id=75971
2385
2386         Reviewed by Ojan Vafai.
2387
2388         * Scripts/webkitpy/common/config/committers.py:
2389
2390 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2391
2392         AX: support helpText() in DumpRenderTree
2393         https://bugs.webkit.org/show_bug.cgi?id=40193
2394
2395         Reviewed by Chris Fleizach.
2396
2397         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2398         (AccessibilityUIElement::helpText): Implemented.
2399
2400 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2401
2402         Unreviewed, rolling out r104572.
2403         http://trac.webkit.org/changeset/104572
2404         https://bugs.webkit.org/show_bug.cgi?id=75967
2405
2406         It broke zillion tests (Requested by Ossy on #webkit).
2407
2408         * DumpRenderTree/qt/EventSenderQt.cpp:
2409         (EventSender::EventSender):
2410         (EventSender::sendOrQueueEvent):
2411         (EventSender::replaySavedEvents):
2412         (EventSender::eventFilter):
2413         * DumpRenderTree/qt/EventSenderQt.h:
2414
2415 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2416
2417         [Qt] fast/events/dont-loose-last-event test fails on WK1
2418         https://bugs.webkit.org/show_bug.cgi?id=73894
2419
2420         Reviewed by Simon Hausmann.
2421
2422         Empty the entire event queue when requested besides using
2423         sendEvent instead of postEvent to make sure all events were
2424         delivered.
2425         This commit also removes not working DRT code to handle drag and drop,
2426         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2427
2428         * DumpRenderTree/qt/EventSenderQt.cpp:
2429         (EventSender::EventSender):
2430         (EventSender::sendOrQueueEvent):
2431         (EventSender::replaySavedEvents):
2432         * DumpRenderTree/qt/EventSenderQt.h:
2433
2434 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2435
2436         [Qt] Enable CSS_FILTERS in Qt build
2437         https://bugs.webkit.org/show_bug.cgi?id=75777
2438
2439         Add the CSS_FILTERS feature flag to Qt.
2440
2441         Reviewed by Kenneth Rohde Christiansen.
2442
2443         * qmake/mkspecs/features/features.prf:
2444
2445 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2446
2447         [Qt] Unreviewed -Werror build fix.
2448
2449         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2450         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2451         declaration.
2452
2453 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2454
2455         [Qt] Remove dependency to uitools
2456         https://bugs.webkit.org/show_bug.cgi?id=75952
2457
2458         Reviewed by Tor Arne Vestbø.
2459
2460         QUiLoader is used for creating QLabel/QProgressBar widgets for
2461         a layout test, to verify some widget embedding feature. Unfortunately
2462         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2463         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2464         let's break the circular dependency.
2465
2466         * DumpRenderTree/qt/DumpRenderTree.pro:
2467         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2468         (WebCore::WebPage::createPlugin):
2469         * QtTestBrowser/QtTestBrowser.pro:
2470         * QtTestBrowser/launcherwindow.h:
2471         * QtTestBrowser/webpage.cpp:
2472         (WebPage::createPlugin):
2473         * qmake/mkspecs/features/minimal_qt.prf:
2474         * qmake/mkspecs/features/uitools.prf: Removed.
2475
2476 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2477
2478         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2479         https://bugs.webkit.org/show_bug.cgi?id=75894
2480
2481         Reviewed by Tor Arne Vestbø.
2482
2483         * MiniBrowser/qt/MiniBrowserApplication.h:
2484         (MiniBrowserApplication::windowOptions):
2485         * MiniBrowser/qt/main.cpp:
2486         (main):
2487
2488 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2489
2490         [Qt] DRT crashes with Qt 5
2491         https://bugs.webkit.org/show_bug.cgi?id=75951
2492
2493         Reviewed by Ossy.
2494
2495         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2496         Qt relies on font-config to define the default font family.
2497
2498 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2499
2500         [Qt] REGRESSION(r100130): Clean build feature is broken.
2501         https://bugs.webkit.org/show_bug.cgi?id=75863
2502
2503         Reviewed by Tor Arne Vestbø.
2504
2505         * Scripts/webkitdirs.pm:
2506         (buildQMakeProject):
2507
2508 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2509
2510         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2511         https://bugs.webkit.org/show_bug.cgi?id=75885
2512
2513         In QML events are propagated through parents. But since the
2514         WebView may consume key events, a shortcut might never reach
2515         the top QtQuickItem.
2516         Therefore an application wide event handling function in C++
2517         needs to take care of shortcuts for MiniBrowser.
2518
2519         Reviewed by Kenneth Rohde Christiansen.
2520
2521         * MiniBrowser/qt/BrowserWindow.cpp:
2522         (BrowserWindow::reload):
2523         (BrowserWindow::focusAddressBar):
2524         * MiniBrowser/qt/BrowserWindow.h:
2525         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2526         (MiniBrowserApplication::notify):
2527         * MiniBrowser/qt/qml/BrowserWindow.qml:
2528
2529 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2530
2531         Add --efl alias for --platform=efl to run-webkit-test
2532         https://bugs.webkit.org/show_bug.cgi?id=75937
2533
2534         Reviewed by Andreas Kling.
2535         
2536         * Scripts/run-webkit-tests: Add --efl alias.
2537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2538         (parse_args):
2539
2540 2012-01-09  Dan Bernstein  <mitz@apple.com>
2541
2542         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2543         https://bugs.webkit.org/show_bug.cgi?id=75920
2544
2545         Reviewed by Darin Adler.
2546
2547         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2548         (TestWebKitAPI::TEST): Added a test for a range in a
2549         -webkit-user-select: none; block.
2550
2551 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2552
2553         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2554         https://bugs.webkit.org/show_bug.cgi?id=75884
2555
2556         Reviewed by Ryosuke Niwa.
2557
2558         Fix regression introduced (revealed?) in r104340. Chromium file         
2559         url syntax is different on win32 and the test results weren't           
2560         expecting that.                                                         
2561
2562         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2563         (TestExpectations._report_errors):
2564         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2565         (test_parse_error_nonfatal):
2566         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2567         (MockDRTTest.input_line):
2568         (MockChromiumDRTTest.test_pixeltest__fails):
2569         * Scripts/webkitpy/layout_tests/port/test.py:
2570         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2571         (TestRebaseliner.make_rebaseliner):
2572         (TestRebaseliner.test_one_platform):
2573         (TestRebaseliner.test_all_platforms):
2574         (TestRebaseliner.test_png_file_with_comment):
2575         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2576         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2577         (TestRealMain.test_all_platforms):
2578
2579 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2580
2581         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2582
2583         Unreviewed, build fix.
2584
2585         test-webkitpy had a built-in self-test routine to verify that
2586         deleting the .pyc files worked correctly. When I removed the
2587         python24 directory in r104482, I broke the self-test.
2588
2589         I have deleted the self-test for now. Since I am reworking
2590         test-webkitpy I will make sure the new version is adequately
2591         tested.
2592
2593         * Scripts/test-webkitpy:
2594         (configure_logging):
2595         (_clean_pyc_files):
2596         (_clean_packages):
2597         (init):
2598
2599 2012-01-09  Justin Novosad  <junov@chromium.org>
2600
2601         [Chromium] remove all references to the legacy accelerated 2d Canvas
2602         implementation
2603         https://bugs.webkit.org/show_bug.cgi?id=75108
2604
2605         Purging an old settings flag that is no longer referenced
2606
2607         Reviewed by Darin Fisher.
2608
2609         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2610         (main):
2611         * DumpRenderTree/chromium/TestShell.cpp:
2612         (TestShell::TestShell):
2613         (TestShell::resetWebSettings):
2614         * DumpRenderTree/chromium/TestShell.h:
2615         (TestShell::setAccelerated2dCanvasEnabled):
2616         * DumpRenderTree/chromium/WebPreferences.cpp:
2617         (WebPreferences::reset):
2618         (WebPreferences::applyTo):
2619         * DumpRenderTree/chromium/WebPreferences.h:
2620
2621 2012-01-09  Adam Roben  <aroben@apple.com>
2622
2623         Convert Cygwin paths to Windows paths before passing them to DRT
2624
2625         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2626         NRWT
2627
2628         I couldn't find a way to test this because I couldn't figure out how to override the
2629         cygpath function as it is used by WebKitDriver.
2630
2631         Reviewed by Dirk Pranke.
2632
2633         * Scripts/webkitpy/layout_tests/port/webkit.py:
2634         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2635         Windows-style path before passing it to DRT.
2636
2637 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2638
2639         webkitpy: revamp version checking
2640         https://bugs.webkit.org/show_bug.cgi?id=75765
2641
2642         Reviewed by Adam Barth.
2643
2644         The version-checking code in webkitpy/python24/versioning seems really
2645         awkward and overdesigned, especially since we don't support python 2.4
2646         any more.
2647
2648         In addition, I am tired of getting warnings about Python 2.6 being "a
2649         newer release than what is supported" :).
2650
2651         I'm taking a page from the depot_tools python code and just creating a
2652         new webkitpy.common.version_check module that will print a message on
2653         stderr and call sys.exit() if we're running an unsupported version.
2654
2655         * Scripts/check-webkit-style:
2656         * Scripts/new-run-webkit-httpd:
2657         * Scripts/new-run-webkit-tests:
2658         * Scripts/rebaseline-chromium-webkit-tests:
2659         * Scripts/test-webkitpy:
2660         (configure_logging):
2661         (init):
2662         * Scripts/webkit-patch:
2663         (main):
2664         * Scripts/webkitpy/common/system/executive.py:
2665         (Executive._child_process_encoding):
2666         (Executive._should_encode_child_process_arguments):
2667         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2668         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2669         * Scripts/webkitpy/python24/__init__.py: Removed.
2670         * Scripts/webkitpy/python24/versioning.py: Removed.
2671         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2672
2673 2012-01-09  Adam Barth  <abarth@webkit.org>
2674
2675         Remove Chromium Mac CG from the flakiness dashboard
2676         https://bugs.webkit.org/show_bug.cgi?id=75873
2677
2678         Reviewed by Ojan Vafai.
2679
2680         This configuration no longer exists.
2681
2682         * TestResultServer/static-dashboards/builders.js:
2683         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2684         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2685         (testOverrideJustBuildType):
2686         (testPlatformAndBuildType):
2687
2688 2012-01-06  Adam Roben  <aroben@apple.com>
2689
2690         Print an error message when NRWT can't run Apache
2691
2692         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2693
2694         Reviewed by Dirk Pranke.
2695
2696         * Scripts/webkitpy/layout_tests/port/base.py:
2697         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2698         failing silently.
2699
2700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2701         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2702         run Apache.
2703         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2704         fails.
2705
2706 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2707
2708         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2709         https://bugs.webkit.org/show_bug.cgi?id=75846
2710
2711         Reviewed by Philippe Normand.
2712
2713         * Scripts/webkitdirs.pm:
2714         (runAutogenForAutotoolsProjectIfNecessary):
2715
2716 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2717
2718         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2719         https://bugs.webkit.org/show_bug.cgi?id=75807
2720
2721         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2722         which allows you to dynamically toggle whether touch mocking is
2723         enabled or disabled.
2724
2725         Reviewed by Tor Arne Vestbø.
2726
2727         * MiniBrowser/qt/MiniBrowser.qrc:
2728         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2729         (MiniBrowserApplication::notify):
2730         * MiniBrowser/qt/MiniBrowserApplication.h:
2731         (WindowOptions::WindowOptions):
2732         (WindowOptions::touchMockingEnabled):
2733         (WindowOptions::setTouchMockingEnabled):
2734         * MiniBrowser/qt/icons/touch.png: Added.
2735         * MiniBrowser/qt/qml/BrowserWindow.qml:
2736
2737 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2738
2739         Unreviewed. Fix make distcheck issues.
2740
2741         * MiniBrowser/gtk/GNUmakefile.am:
2742
2743 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2744
2745         Unreviewed, rolling out r104421.
2746         http://trac.webkit.org/changeset/104421
2747         https://bugs.webkit.org/show_bug.cgi?id=75816
2748
2749         Need to rebaseline some tests on Linux (Requested by noamr on
2750         #webkit).
2751
2752         * qmake/mkspecs/features/features.prf:
2753
2754 2012-01-08  Adam Barth  <abarth@webkit.org>
2755
2756         Remove support for Chromium Mac CG from garden-o-matic
2757         https://bugs.webkit.org/show_bug.cgi?id=75814
2758
2759         Reviewed by Eric Seidel.
2760
2761         This configuration no longer exists.  This patch is mostly a matter of
2762         updating config.js and removing the examples from the unit tests.
2763
2764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2767         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2768         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2769
2770 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2771
2772         [Qt] Enable CSS_FILTERS in Qt build
2773         https://bugs.webkit.org/show_bug.cgi?id=75777
2774
2775         Add the CSS_FILTERS feature flag to Qt.
2776
2777         Reviewed by Kenneth Rohde Christiansen.
2778
2779         * qmake/mkspecs/features/features.prf:
2780
2781 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2782
2783         Categorize bots by ports instead of core/non-core separation
2784         https://bugs.webkit.org/show_bug.cgi?id=75766
2785
2786         Reviewed by Eric Seidel.
2787
2788         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2789         (Chromium still comes before GTK and Qt).
2790
2791         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2792         (loadBuilderConfig):
2793         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2794
2795 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2796
2797         Remove the concept of core builders from webkitpy
2798         https://bugs.webkit.org/show_bug.cgi?id=75809
2799
2800         Reviewed by Ryosuke Niwa.
2801
2802         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2803         and remove the relevant code.
2804
2805         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2806         (BuildBot.__init__):
2807         (BuildBot._matches_regexps):
2808         (BuildBot._builder_statuses_with_names_matching_regexps):
2809         (BuildBot.builder_statuses):
2810         (BuildBot.failure_map):
2811         (BuildBot._latest_builds_from_builders):
2812         (BuildBot.last_green_revision):
2813         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2814         (MockBuildBot.builder_statuses):
2815         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2816         (test_status_parsing):
2817         (test_last_green_revision):
2818         (test_last_green_revision.mock_builds_from_builders):
2819
2820 2012-01-08  Adam Barth  <abarth@webkit.org>
2821
2822         Remove Chromium Mac CG concept from webkitpy
2823         https://bugs.webkit.org/show_bug.cgi?id=75810
2824
2825         Reviewed by Ryosuke Niwa.
2826
2827         This configuration no longer exists.  We can remove all the supporting
2828         code from webkitpy.
2829
2830         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2831         (BaselineOptimizerTest.test_move_baselines):
2832         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2833         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2834         (BaselineOptimizerTest.test_common_directory_includes_root):
2835         (BaselineOptimizerTest.test_complex_shadowing):
2836         * Scripts/webkitpy/common/config/build.py:
2837         (_should_file_trigger_build):
2838         * Scripts/webkitpy/common/config/build_unittest.py:
2839         (ShouldBuildTest):
2840         * Scripts/webkitpy/layout_tests/port/builders.py:
2841         * Scripts/webkitpy/layout_tests/port/chromium.py:
2842         (ChromiumPort):
2843         (ChromiumPort._generate_all_test_configurations):
2844         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2845         (_default_tests_paths):
2846         (ChromiumGpuLinuxPort.tests):
2847         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2848         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2849         (ChromiumGpuTest.assert_port_works):
2850         (ChromiumGpuTest.test_baseline_paths):
2851         (ChromiumGpuTest.test_graphics_type):
2852         (ChromiumGpuTest.test_default_tests_paths):
2853         (ChromiumGpuTest.test_test_files):
2854         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2855         (ChromiumMacPort):
2856         (ChromiumMacPort.__init__):
2857         (ChromiumMacPort.baseline_search_path):
2858         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2859         (ChromiumMacPortTest.test_graphics_type):
2860         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2861         (ChromiumPortTest.test_all_test_configurations):
2862         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2863         * Scripts/webkitpy/layout_tests/port/factory.py:
2864         (PortFactory._port_name_from_arguments_and_options):
2865         (PortFactory.get):
2866         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2867         (FactoryTest.test_chromium_gpu_mac):
2868         (FactoryTest.test_chromium_mac):
2869         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2870         (GetGoogleChromePortTest._verify_expectations_overrides):
2871         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2872         (MockChromiumDRTTest.test_chromium_parse_options):
2873         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2874         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2875         (test_url_fetcher):
2876         (test_zip_factory):
2877         (test_archive):
2878         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2879         (TestRebaseline.test_rebaseline_expectations):
2880
2881 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2882
2883         Categorize bots by ports instead of core/non-core separation
2884         https://bugs.webkit.org/show_bug.cgi?id=75766
2885
2886         Reviewed by Adam Barth.
2887
2888         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2889
2890         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2891         (loadBuilderConfig):
2892         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2893
2894 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2895
2896         Unreviewed, rolling out r104403.
2897         http://trac.webkit.org/changeset/104403
2898         https://bugs.webkit.org/show_bug.cgi?id=75803
2899
2900         It broke all tests on Qt5 (Requested by Ossy_weekend on
2901         #webkit).
2902
2903         * qmake/mkspecs/features/features.prf:
2904
2905 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2906
2907         [Qt] Enable CSS_FILTERS in Qt build
2908         https://bugs.webkit.org/show_bug.cgi?id=75777
2909
2910         Add the CSS_FILTERS feature flag to Qt.
2911
2912         Reviewed by Kenneth Rohde Christiansen.
2913
2914         * qmake/mkspecs/features/features.prf:
2915
2916 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2917
2918         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2919         https://bugs.webkit.org/show_bug.cgi?id=75202
2920
2921         Reviewed by David Kilzer.
2922
2923         The current CSS parser can just parse simple CSSes like
2924
2925             foo bar baz {
2926                 property1: value;
2927                 property2: value;
2928             }
2929
2930         , and cannot parse comments nor a CSS in which a selector and {
2931         appears in different lines. This patch rewrites the CSS parser
2932         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2933         shown in css_unittests.css.
2934
2935         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2936
2937         * Scripts/prepare-ChangeLog:
2938         (get_selector_line_ranges_for_css):
2939         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2940         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2941         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2942         (element1):
2943         (element2):
2944         (element3):
2945         (element4.p):
2946         (element5.p.q.r.s):
2947         (element6#p):
2948         (element7 element8):
2949         (element9.p element10.q):
2950         (element11#p element12#q):
2951         (element13, element14):
2952         (.p):
2953         (#p):
2954         (.p element15 #q element16.r element17#s):
2955         (element18:target):
2956         (element19):
2957         (element20):
2958         (element21):
2959         (element22):
2960
2961 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2962
2963         The Perl parser of prepare-ChangeLog can parse here-documents
2964         https://bugs.webkit.org/show_bug.cgi?id=73208
2965
2966         Reviewed by David Kilzer.
2967
2968         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2969         which results in wrong subroutine names in ChangeLogs.
2970         With this patch, prepare-ChangeLog can judge whether the line of "}"
2971         is the end of a subroutine or a line inside a here-document.
2972
2973         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2974
2975         * Scripts/prepare-ChangeLog:
2976         (get_function_line_ranges_for_perl):
2977         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2978         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2979         Added test cases for here-documents.
2980         (func7):
2981         (func8):
2982         (func9):
2983         (func10):
2984         (func11):
2985         (func12):
2986         (func13):
2987         (func14):
2988         (func15):
2989         (func16):
2990
2991 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2992
2993         Add unittests for the JavaScript parser of prepare-ChangeLog
2994         https://bugs.webkit.org/show_bug.cgi?id=75201
2995
2996         Reviewed by David Kilzer.
2997
2998         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2999         of prepare-ChangeLog.
3000
3001         * Scripts/prepare-ChangeLog:
3002         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
3003         omitted from parsing. Thus,
3004
3005             str = "foo"
3006             function func() {
3007             }
3008
3009         was recognized as equivalent to
3010
3011             str = function func() {
3012             }
3013
3014         This patch replaces a string with a dummy identifier 'string_appeared_here'
3015         to tell the parser that a string appeared there.
3016
3017         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
3018         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
3019         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
3020         (func1):
3021         (func2):
3022         (func3):
3023         (func4):
3024         (func5):
3025         (func6):
3026         (func7):
3027         (func8):
3028         (func9):
3029         (func10):
3030         (func11):
3031         (func12):
3032         (funcOverloaded):
3033         (Func1.prototype.get x1):
3034         (Func1.prototype.get x2):
3035         (Func1.prototype.set x1):
3036         (Func1.prototype.set x3):
3037         (Func2.prototype.func13):
3038         (Func2.prototype.func14):
3039         (Func2.prototype.func15):
3040         (func16.func17):
3041         (func16.func18):
3042         (func16.func19):
3043         (func16):
3044
3045 2012-01-08  David Levin  <levin@chromium.org>
3046
3047         [chromium] Add layout test support for autosize code in FrameView.
3048         https://bugs.webkit.org/show_bug.cgi?id=73631
3049
3050         Reviewed by Dmitry Titov.
3051
3052         * DumpRenderTree/chromium/LayoutTestController.cpp:
3053         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
3054         (LayoutTestController::reset): Set the autoresize mode back to false.
3055         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
3056         * DumpRenderTree/chromium/LayoutTestController.h:
3057         * DumpRenderTree/chromium/WebViewHost.cpp:
3058         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
3059         * DumpRenderTree/chromium/WebViewHost.h:
3060
3061 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3062
3063         [WK2][GTK] Each test takes roughly half a second to load
3064         https://bugs.webkit.org/show_bug.cgi?id=70699
3065
3066         Reviewed by Martin Robinson.
3067
3068         Set the XDG_CACHE_HOME environment variable when testing with
3069         WebKitTestRunner. This way the testing is started with a non-existing
3070         application cache. If the cache exists and is not empty, the emptying
3071         and vacuuming that is performed before every test can consume a lot of
3072         time.
3073
3074         This is just a temporary workaround until it becomes possible to set
3075         a desired directory to be used as the application cache location through
3076         WebKitWebContext.
3077
3078         * Scripts/webkitpy/layout_tests/port/gtk.py:
3079         (GtkPort.setup_environ_for_server):
3080
3081 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
3082
3083         [GTK] Enable requestAnimationFrame in build-webkit
3084         https://bugs.webkit.org/show_bug.cgi?id=75773
3085
3086         Reviewed by Martin Robinson.
3087
3088         Enable requestAnimationFrame for the Gtk port.
3089
3090         * Scripts/build-webkit:
3091
3092 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
3093
3094         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
3095
3096         * Scripts/webkitdirs.pm:
3097         (buildChromium):
3098         Missing parentheses.
3099
3100 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3101
3102         Fix DRT build on case-sensitive file systems.
3103
3104         Fix case of include of WebDynamicScrollBarsView.h
3105         
3106         * DumpRenderTree/mac/DumpRenderTree.mm:
3107
3108 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3109
3110         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
3111         https://bugs.webkit.org/show_bug.cgi?id=75662
3112
3113         Reviewed by Dan Bernstein.
3114         
3115         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
3116         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
3117         test window uses the main display's color space, so that the pixel values in the bitmap
3118         that gets checksummed are identical to the CSS colors.
3119         
3120         Removed the code that switches the display profile in DRT, since that is no longer required.
3121
3122         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
3123         * DumpRenderTree/mac/DumpRenderTree.mm:
3124         (crashHandler): Remove code that switches display profiles.
3125         (prepareConsistentTestingEnvironment): Ditto.
3126         (dumpRenderTree): Ditto.
3127         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
3128         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
3129         (createBitmapContextFromWebView): Add comment about the colorspace handling.
3130         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3131         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
3132         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
3133         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3134         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
3135         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
3136
3137 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3138
3139         run-api-tests: specify individual suites and tests on the command-line
3140
3141         Reviewed by Adam Roben.
3142
3143         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3144
3145         The run-api-tests script will now accept a list of arguments on
3146         the command-line that are used as prefix filters.  To run all
3147         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
3148         use:
3149
3150             $ run-api-tests WTF
3151
3152         To run only the tests in the "WTF" suite, not the "WTF_Vector"
3153         suite, use:
3154
3155             $ run-api-tests WTF.
3156
3157         * Scripts/run-api-tests: Filter tests if any prefix arguments
3158         are passed on the command-line.
3159
3160 2012-01-06  David Kilzer  <ddkilzer@apple.com>
3161
3162         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
3163
3164         Reviewed by Adam Roben.
3165
3166         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
3167
3168         * Scripts/run-api-tests:
3169         (dumpTestsBySuite): Update to accept array of tests instead of
3170         hash data structure.
3171         (runTestsBySuite): Ditto.
3172         (listAllTests): Rename from populateTests().  Update to return
3173         an array of tests instad of the hash data structure.
3174
3175 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3176
3177         webkitpy: clean up test/uri conversion routines
3178         https://bugs.webkit.org/show_bug.cgi?id=75648
3179
3180         Reviewed by Eric Seidel.
3181
3182         This change moves test_to_uri and uri_to_test from the Port
3183         class to the Driver class (the routines were only being
3184         called by the drivers), and removes a bunch of stale and/or
3185         busted logic.
3186
3187         * Scripts/webkitpy/layout_tests/port/base.py:
3188         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3189         * Scripts/webkitpy/layout_tests/port/chromium.py:
3190         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3191         * Scripts/webkitpy/layout_tests/port/driver.py:
3192         (is_http_test):
3193         (test_to_uri):
3194         (uri_to_test):
3195         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3196         (run_one_test):
3197         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3198         (MockDRTTest.input_line):
3199         (input_line):
3200         (expected_output):
3201         * Scripts/webkitpy/layout_tests/port/test.py:
3202         * Scripts/webkitpy/layout_tests/port/webkit.py:
3203         (_command_from_driver_input):
3204
3205 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
3206
3207         Mitigate scrollbar differences when running pixel tests
3208         https://bugs.webkit.org/show_bug.cgi?id=67217
3209
3210         Reviewed by Dan Bernstein.
3211         
3212         Add an NSScroller subclass that draws mock scrollbars identically
3213         to the WebCore mock scrollbar theme, and register it with the
3214         WebDynamicScrollbarsView.
3215
3216         * DumpRenderTree/mac/DumpRenderTree.mm:
3217         (-[DRTMockScroller rectForPart:]):
3218         (-[DRTMockScroller drawKnob]):
3219         (-[DRTMockScroller drawRect:]):
3220         (registerMockScrollbars):
3221         (prepareConsistentTestingEnvironment):
3222
3223 2012-01-05  Jon Lee  <jonlee@apple.com>
3224
3225         Update DRT on Mac to draw resize handles on text areas.
3226
3227         Reviewed by John Sullivan.
3228
3229         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
3230         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
3231
3232         * DumpRenderTree/mac/DumpRenderTree.mm:
3233         (resetDefaultsToConsistentValues):
3234
3235 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3236
3237         [Qt] Move listing of include paths and libs to pri files in sources
3238
3239         Includepaths are sometimes modified by non-Qt contributors so keeping
3240         them in files inside Sources makes it more likely that they are updated
3241         along with project files for the other ports.
3242
3243         Using pri files instead of prf files for this also has the benefit that
3244         the include() from the main target file can be parsed and followed by
3245         Qt Creator -- something that does not work with load().
3246
3247         Dependency from a target to a library through the WEBKIT variable are
3248         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
3249         set the source root of the module and include the right pri file.
3250
3251         Ideally we'd use the variant of include() that takes an optional
3252         namespace to read the variables into, or the fromfile() function,
3253         but both of these add an overhead of about 40% on the total qmake
3254         runtime, due to making a deep copy of all the variables in the
3255         project or re-reading all the prf files from scratch.
3256
3257         Reviewed by Simon Hausmann.
3258         Reviewed by Ossy.
3259
3260         * qmake/mkspecs/features/default_post.prf:
3261         * qmake/mkspecs/modules/javascriptcore.prf: Added.
3262         * qmake/mkspecs/modules/webcore.prf: Added.
3263         * qmake/mkspecs/modules/webkit2.prf: Added.
3264         * qmake/mkspecs/modules/wtf.prf: Added.
3265
3266 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
3267
3268         [EFL] Add pre-render handling code in EWebLauncher.
3269         https://bugs.webkit.org/show_bug.cgi?id=73430
3270
3271         Reviewed by Zoltan Herczeg.
3272
3273         Add pre-render handling code by pressing Insert key.
3274
3275         * EWebLauncher/main.c:
3276         (on_key_down):
3277
3278 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
3279
3280         NRWT should use test_expectation.txt on wk2 platforms
3281         https://bugs.webkit.org/show_bug.cgi?id=75417
3282
3283         Reviewed by Dirk Pranke.
3284
3285         * Scripts/webkitpy/layout_tests/port/webkit.py:
3286         (path_to_test_expectations_file):
3287         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3288         (test_path_to_test_expectations_file):
3289
3290 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3291
3292         Don't hardcode expected file URIs in as they depend on the platform
3293         https://bugs.webkit.org/show_bug.cgi?id=75666
3294
3295         Reviewed by Dirk Pranke.
3296
3297         * Scripts/webkitpy/layout_tests/port/win.py:
3298         (WinPort.show_results_html_file):
3299         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3300         (MainTest.test_unexpected_failures):
3301         (MainTest.test_results_directory_default):
3302         (MainTest.test_results_directory_relative):
3303
3304 2012-01-05  Anders Carlsson  <andersca@apple.com>
3305
3306         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
3307         https://bugs.webkit.org/show_bug.cgi?id=75667
3308         <rdar://problem/10389454>
3309
3310         Reviewed by Kevin Decker.
3311
3312         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
3313
3314         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3315         (PluginTest::executeScript):
3316         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3317         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
3318         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
3319         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
3320         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
3321
3322 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3323
3324         webkitpy: clean up port factory methods
3325         https://bugs.webkit.org/show_bug.cgi?id=75590
3326
3327         Reviewed by Eric Seidel.
3328
3329         This change consolidates much of the "factory method" logic
3330         of determining which port objects to create for a given set
3331         of configurations by merging the separate factory methods in
3332         chromium_gpu and google_chrome into PortFactory so that at least
3333         all of the logic is in one place.
3334
3335         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3336         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3337         * Scripts/webkitpy/layout_tests/port/factory.py:
3338         (_port_name_from_arguments_and_options):
3339         (get):
3340         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3341         (test_google_chrome):
3342         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3343         (GoogleChromeLinux32Port):
3344         (GoogleChromeLinux32Port.baseline_search_path):
3345         (test_expectations_overrides):
3346         (architecture):
3347         (GoogleChromeLinux64Port):
3348         (GoogleChromeLinux64Port.baseline_search_path):
3349         (GoogleChromeMacPort):
3350         (GoogleChromeMacPort.baseline_search_path):
3351         (GoogleChromeWinPort):
3352         (GoogleChromeWinPort.baseline_search_path):
3353         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3354         (_verify_baseline_path):
3355
3356 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
3357
3358         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
3359         https://bugs.webkit.org/show_bug.cgi?id=75617
3360
3361         Reviewed by Dirk Pranke.
3362
3363         * Scripts/webkitpy/common/system/filesystem.py:
3364         (FileSystem.exists):
3365         * Scripts/webkitpy/common/system/filesystem_mock.py:
3366         (MockFileSystem.exists):
3367         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3368         (GenericFileSystemTests.teardown_generic_test_dir):
3369         * Scripts/webkitpy/layout_tests/port/base.py:
3370         (Port.to.show_results_html_file):
3371         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3372         (MainTest.test_results_directory_absolute):
3373
3374 2012-01-05  Adam Roben  <aroben@apple.com>
3375
3376         Remove some unnecessary code from old-run-webkit-tests
3377
3378         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
3379         WebKitTestRunner.
3380
3381         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
3382         Windows
3383
3384         Reviewed by Eric Seidel.
3385
3386         * Scripts/old-run-webkit-tests:
3387         (top level):
3388         (openDumpTool):
3389         Removed calls to setPathForRunningWebKitApp.
3390
3391 2012-01-05  Adam Roben  <aroben@apple.com>
3392
3393         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3394
3395         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3396         better, since we always want to open results.html using the user's build of WebKit, not
3397         whatever their default browser is.
3398
3399         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3400         for Apple's Windows port
3401
3402         Reviewed by Eric Seidel.
3403
3404         * Scripts/webkitpy/layout_tests/port/win.py:
3405         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3406         an obsolete comment.
3407
3408         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3409         (WinPortTest.test_show_results_html_file): Updated expected results.
3410
3411 2012-01-05  Adam Roben  <aroben@apple.com>
3412
3413         Prepend Safari.exe's path to the command-line passed to CreateProcess
3414
3415         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3416         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3417         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3418         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3419         first argument that WebKitLauncherWin was trying to pass to it.
3420
3421         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3422
3423         Reviewed by Steve Falkenburg.
3424
3425         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3426         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3427         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3428
3429 2012-01-05  Adam Roben  <aroben@apple.com>
3430
3431         Stop using explicit memory management in WebKitLauncherWin
3432
3433         We now use stack-allocated STL objects instead.
3434
3435         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3436         Safari
3437
3438         Reviewed by Steve Falkenburg.
3439
3440         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3441         (getStringValue):
3442         (applePathFromRegistry):
3443         (safariInstallDir):
3444         (safariBrowserExe):
3445         (_tWinMain):
3446         Changed to use stack-allocated STL objects instead of malloc/free.
3447
3448 2012-01-05  Adam Roben  <aroben@apple.com>
3449
3450         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3451
3452         This allows us to add the Safari and Apple Application Support directories to PATH before
3453         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3454
3455         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3456         Windows port of DumpRenderTree/WebKitTestRunner
3457
3458         Reviewed by Steve Falkenburg.
3459
3460         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3461         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3462
3463         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3464         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3465         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3466
3467         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3468         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3469         the stub launcher.
3470
3471         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3472         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3473         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3474         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3475         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3476         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3477         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3478
3479         * WebKitTestRunner/win/main.cpp:
3480         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3481
3482 2012-01-05  Adam Roben  <aroben@apple.com>
3483
3484         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3485
3486         This allows us to add the Safari and Apple Application Support directories to PATH before
3487         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3488
3489         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3490         Windows port of DumpRenderTree/WebKitTestRunner
3491
3492         Reviewed by Steve Falkenburg.
3493
3494         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3495         which I forgot to add to this .sln when that project was created.
3496
3497         * DumpRenderTree/win/DumpRenderTree.cpp:
3498         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3499
3500         * DumpRenderTree/win/DumpRenderTree.vcproj:
3501         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3502         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3503
3504         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3505         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3506         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3507         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3508         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3509         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3510         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3511         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3512
3513         * win/DLLLauncher/DLLLauncherMain.cpp:
3514         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3515         Safari's directory to PATH so that SafariTheme.dll can be found.
3516
3517         (main):
3518         (wWinMain):
3519         Changed to use the new modifyPath function.
3520
3521 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3522
3523         [Qt] Never enable FontConfig on Mac OS X
3524         https://bugs.webkit.org/show_bug.cgi?id=75616
3525
3526         Reviewed by Tor Arne Vestbø.
3527
3528         * qmake/mkspecs/features/features.prf:
3529
3530 2012-01-05  Alpha Lam  <hclam@chromium.org>
3531
3532         Unreviewed, rolling out r104159.
3533         http://trac.webkit.org/changeset/104159
3534         https://bugs.webkit.org/show_bug.cgi?id=75590
3535
3536         Chromium port GPU tests cannot be executed.
3537
3538         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3539         (get):
3540         (_default_tests_paths):
3541         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3542         (ChromiumGpuTest.assert_port_works):
3543         * Scripts/webkitpy/layout_tests/port/factory.py:
3544         (PortFactory._port_name_from_arguments_and_options):
3545         (PortFactory):
3546         (PortFactory._get_kwargs):
3547         (PortFactory.get):
3548         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3549         (FactoryTest.test_google_chrome.names):
3550         (FactoryTest.test_google_chrome):
3551         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3552         (GetGoogleChromePort):
3553         (GetGoogleChromePort.GoogleChromeLinux32Port):
3554         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3555         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3556         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3557         (GetGoogleChromePort.GoogleChromeLinux64Port):
3558         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3559         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3560         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3561         (GetGoogleChromePort.GoogleChromeMacPort):
3562         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3563         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3564         (GetGoogleChromePort.GoogleChromeWinPort):
3565         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3566         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3567         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3568         (GetGoogleChromePortTest._verify_baseline_path):
3569         (GetGoogleChromePortTest._verify_expectations_overrides):
3570
3571 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3572
3573         webkitpy: clean up port factory methods
3574         https://bugs.webkit.org/show_bug.cgi?id=75590
3575
3576         Reviewed by Eric Seidel.
3577
3578         This change consolidates much of the "factory method" logic
3579         of determining which port objects to create for a given set
3580         of configurations by merging the separate factory methods in
3581         chromium_gpu and google_chrome into PortFactory so that at least
3582         all of the logic is in one place.
3583
3584         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3585         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3586         * Scripts/webkitpy/layout_tests/port/factory.py:
3587         (_port_name_from_arguments_and_options):
3588         (get):
3589         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3590         (test_google_chrome):
3591         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3592         (GoogleChromeLinux32Port):
3593         (GoogleChromeLinux32Port.baseline_search_path):
3594         (test_expectations_overrides):
3595         (architecture):
3596         (GoogleChromeLinux64Port):
3597         (GoogleChromeLinux64Port.baseline_search_path):
3598         (GoogleChromeMacPort):
3599         (GoogleChromeMacPort.baseline_search_path):
3600         (GoogleChromeWinPort):
3601         (GoogleChromeWinPort.baseline_search_path):
3602         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3603         (_verify_baseline_path):
3604
3605 2012-01-04  Adam Roben  <aroben@apple.com>
3606
3607         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3608
3609         This allows us to add the Apple Application Support directory to PATH before trying to load
3610         WebKit so that CoreGraphics.dll and friends can be found.
3611
3612         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3613
3614         Reviewed by Anders Carlsson.
3615
3616         * DumpRenderTree/win/ImageDiff.vcproj:
3617         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3618         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3619
3620         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3621         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3622
3623         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3624         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3625         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3626         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3627         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3628         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3629         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3630
3631         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3632         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3633         to main.
3634
3635         * win/DLLLauncher/DLLLauncherMain.cpp:
3636         (main):
3637         (wWinMain):
3638         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3639         stub launcher acts as a console program and calls a console version of
3640         dllLauncherEntryPoint.
3641
3642 2012-01-04  Adam Roben  <aroben@apple.com>
3643
3644         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3645
3646         This allows us to add the Apple Application Support directory to PATH before trying to load
3647         WebKit so that CoreGraphics.dll and friends can be found.
3648
3649         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3650         double-clicked
3651
3652         Reviewed by Anders Carlsson.
3653
3654         * MiniBrowser/MiniBrowser.vcproj:
3655         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3656         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3657
3658         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3659         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3660         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3661         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3662         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3663         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3664         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3665
3666         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3667         but changed to build the stub launcher.
3668
3669         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3670         it needs to be compiled into the .exe instead of the .dll.
3671         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3672         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3673         DLLLauncherMain code.