17698caa81a410ced7295f40857510cfd33ada65
[WebKit-https.git] / Tools / ChangeLog
1 2015-03-19  Alex Christensen  <achristensen@webkit.org>
2
3         [Content Extensions] Test regular expression parse failures.
4         https://bugs.webkit.org/show_bug.cgi?id=142872
5
6         Reviewed by Benjamin Poulain.
7
8         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9         (TestWebKitAPI::testPatternStatus):
10         (TestWebKitAPI::TEST_F):
11         Added tests for each parsing status.
12
13 2015-03-19  Alex Christensen  <achristensen@webkit.org>
14
15         Fix API tests after r181754.
16
17         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
18         (TestWebKitAPI::testRequest):
19
20 2015-03-19  Brady Eidson  <beidson@apple.com>
21
22         Part of content extensions should apply css selectors
23         https://bugs.webkit.org/show_bug.cgi?id=142604
24
25         Reviewed by Alex Christensen.
26
27         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
28         (WebCore::ContentExtensions::operator<<):
29
30 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
31
32         [Win] Activate tests on EWS
33         https://bugs.webkit.org/show_bug.cgi?id=142850
34
35         Reviewed by Alexey Proskuryakov.
36
37         * Scripts/webkitpy/common/config/ews.json: Add me as
38         the EWS bot watcher, and activate tests.
39
40 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
41
42         [GTK] Fix inspector userinterface related incremental build issue
43         https://bugs.webkit.org/show_bug.cgi?id=142849
44
45         Reviewed by Carlos Garcia Campos.
46
47         * Scripts/webkitdirs.pm:
48         (shouldRemoveCMakeCache):
49
50 2015-03-18  Alex Christensen  <achristensen@webkit.org>
51
52         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
53         https://bugs.webkit.org/show_bug.cgi?id=142799
54
55         Reviewed by Brady Eidson.
56
57         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
58         (TestWebKitAPI::testPattern):
59         (TestWebKitAPI::TEST_F):
60         Start testing regex failures.
61
62 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
63
64         Fix StringView typos after r181525 and r181558
65         https://bugs.webkit.org/show_bug.cgi?id=142772
66
67         Reviewed by Darin Adler.
68
69         Add some tests in [1] to cover the StringView::startsWith, 
70         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
71         StringView::endsWithIgnoringASCIICase implementations.
72
73         * TestWebKitAPI/Tests/WTF/StringView.cpp:
74         (TestWebKitAPI::TEST):
75
76 2015-03-18  Dana Burkart  <dburkart@apple.com>
77
78         Remove extraneous import to fix the build.
79
80         Unreviewed.
81
82         * Scripts/webkitpy/port/driver.py:
83
84 2015-03-18  Dana Burkart  <dburkart@apple.com>
85
86         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
87         https://bugs.webkit.org/show_bug.cgi?id=142547
88
89         Reviewed by Alexey Proskuryakov.
90
91         * Scripts/webkitpy/port/driver.py:
92         (Driver._setup_environ_for_driver):
93
94 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
95
96         Tweak how AppleSystemFontOSSubversion default is added
97         https://bugs.webkit.org/show_bug.cgi?id=142835
98
99         Reviewed by Dan Bernstein.
100
101         * DumpRenderTree/mac/DumpRenderTree.mm:
102         (setDefaultsToConsistentValuesForTesting):
103
104 2015-03-18  Dan Bernstein  <mitz@apple.com>
105
106         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
107         https://bugs.webkit.org/show_bug.cgi?id=142815
108
109         Reviewed by Darin Adler.
110
111         * Scripts/prepare-ChangeLog:
112         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
113         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
114         keep consuming the quoted text until the matching quotation mark is reached. Emit the
115         warning only if a line ends without a backslash before the matching quotation mark was found.
116
117 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
118
119         Remove unused "preprocessor" parameter to sub-CodeGenerators
120         https://bugs.webkit.org/show_bug.cgi?id=142793
121
122         Reviewed by Darin Adler.
123
124         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
125         (new):
126
127 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
128
129         [EFL] Bump gstreamer version to 1.4.4
130         https://bugs.webkit.org/show_bug.cgi?id=142782
131
132         Reviewed by Philippe Normand.
133
134         * efl/jhbuild.modules:
135         * efl/patches/gst-libav.patch:
136         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
137         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
138
139 2015-03-17  Tim Horton  <timothy_horton@apple.com>
140
141         Fix the iOS build.
142
143         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
144         (WTR::InjectedBundle::platformInitialize):
145
146 2015-03-17  Dean Jackson  <dino@apple.com>
147
148         check-webkit-style should allow "bool a : 1"
149         https://bugs.webkit.org/show_bug.cgi?id=142794
150
151         Reviewed by Brent Fulgham.
152
153         We should allow member bitfields of the form:
154
155         bool m_var : 1;
156
157         It seems that Visual Studio 8 was the last compiler that
158         wasn't happy about not using unsigned here. We already have
159         about 500 cases (in WebCore) where people were ignoring this rule.
160
161         * Scripts/webkitpy/style/checkers/cpp.py:
162         (check_language): Allow "bool".
163         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
164         (CppStyleTest.test_enum_bitfields):
165         (CppStyleTest.test_plain_integral_bitfields):
166
167 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
168
169         Compile character ranges targeting the same state as range check in the bytecode
170         https://bugs.webkit.org/show_bug.cgi?id=142759
171
172         Reviewed by Alex Christensen.
173
174         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
175         (TestWebKitAPI::TEST_F):
176
177 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
178
179         W3C test parser and converter should use test importer host
180         https://bugs.webkit.org/show_bug.cgi?id=142729
181
182         Reviewed by Bem Jones-Bey.
183
184         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
185         This enables adding more TestImporter unit testing.
186         This patch also ensures that the git object instantiated by TestDownloader is using the
187         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
188
189         * Scripts/webkitpy/common/system/filesystem_mock.py:
190         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
191         * Scripts/webkitpy/w3c/test_downloader.py:
192         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
193         (TestDownloader.checkout_test_repository): Making use of the new git function.
194         * Scripts/webkitpy/w3c/test_importer.py:
195         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
196         (TestImporter.import_tests): Adding host as parameter to the converter.
197         * Scripts/webkitpy/w3c/test_importer_unittest.py:
198         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
199         (TestImporterTest):
200         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
201         * Scripts/webkitpy/w3c/test_parser.py:
202         (TestParser.__init__): Adding host as parameter constructor.
203
204 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
205
206         [GTK] WebKitDOM objects leaking
207         https://bugs.webkit.org/show_bug.cgi?id=118788
208
209         Reviewed by Darin Adler and Sergio Villar Senin.
210
211         Update DOMObjectCache unit test to check that DOM objects are also
212         released when new contents are loaded in the web view, and the old
213         document is detached from the frame.
214
215         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
216         (testWebKitDOMObjectCache):
217         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
218         (runTest):
219
220 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
221
222         W3C test importer default import folder should be LayoutTests/imported/w3c
223         https://bugs.webkit.org/show_bug.cgi?id=142728
224
225         Reviewed by Bem Jones-Bey.
226
227         * Scripts/webkitpy/w3c/test_importer.py:
228         (parse_args): Updating the default destination option value to 'imported/w3c'.
229
230 2015-03-17  Philippe Normand  <pnormand@igalia.com>
231
232         [GTK] basic OpenWebRTC build support
233         https://bugs.webkit.org/show_bug.cgi?id=142393
234
235         Reviewed by Carlos Garcia Campos.
236
237         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
238         is not the upstream OpenWebRTC repository. This temporary fork
239         contains a few patches needed by WebKit for audio/video rendering.
240
241 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
242
243         [CMake][EFL] Build test tools only for developer mode
244         https://bugs.webkit.org/show_bug.cgi?id=142761
245
246         Reviewed by Csaba Osztrogonác.
247
248         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
249
250         * CMakeLists.txt:
251
252 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
253
254         Remove never used "useLayerOnTop" bindings generator argument
255         https://bugs.webkit.org/show_bug.cgi?id=142773
256
257         Reviewed by Darin Adler.
258
259         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
260         (new):
261
262 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
263
264         Enable ES6 classes by default
265         https://bugs.webkit.org/show_bug.cgi?id=142774
266
267         Reviewed by Gavin Barraclough.
268
269         * Scripts/webkitperl/FeatureList.pm:
270
271 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
272
273         Fix webkitpy tests after r181585.
274
275         Looks like "me" cannot be anyone's email, it's a special case.
276
277         * Scripts/webkitpy/common/config/contributors.json:
278
279 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
280
281         Add tolerance to WebAudio tests
282         https://bugs.webkit.org/show_bug.cgi?id=142676
283
284         Reviewed by Tim Horton.
285
286         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
287
288         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
289         (TestResultWriter.create_audio_diff_and_write_result):
290         * Scripts/webkitpy/layout_tests/models/test_failures.py:
291         (FailureAudio.write_failure):
292         * Scripts/webkitpy/port/base.py:
293         (Port.do_audio_results_differ):
294         Diff audio failures.
295
296         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
297         tests to use real parseable WAV data, and got rid of base64, which there didn't
298         seem to have been any reason for.
299
300 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
301
302         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
303         https://bugs.webkit.org/show_bug.cgi?id=142720
304
305         Reviewed by Myles C. Maxfield.
306
307         Activate system copies of Microsoft fonts for the current process, thus overriding
308         any other ones that could be preferred by the system otherwise.
309
310         * DumpRenderTree/mac/DumpRenderTree.mm:
311         (activateSystemCoreWebFonts):
312         (adjustFonts):
313         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
314         (WTR::activateSystemCoreWebFonts):
315         (WTR::activateFonts):
316
317 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
318
319         Created Streams API watchlist
320         https://bugs.webkit.org/show_bug.cgi?id=142684
321
322         Reviewed by Benjamin Poulain.
323
324         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
325         watchlist and added Benjamin, Youenn and me to it.
326
327 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
328
329         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
330         https://bugs.webkit.org/show_bug.cgi?id=142715
331
332         Reviewed by Brent Fulgham.
333
334         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
335         (TestWebKitAPI::TEST):
336
337 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
338
339         Change the exact attribute matching to be ASCII case-insensitive
340         https://bugs.webkit.org/show_bug.cgi?id=142609
341
342         Reviewed by Darin Adler.
343
344         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
345         * TestWebKitAPI/Tests/WTF/StringView.cpp:
346
347 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
348
349         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
350         https://bugs.webkit.org/show_bug.cgi?id=134764
351
352         Reviewed by Ryosuke Niwa.
353
354         TestDownloader is introduced to download W3C tests from the official
355         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
356         and https://github.com/w3c/csswg-test.git).
357         TestDownloader clones the repositories and checkouts revisions of the tests
358         defined in LayoutTests/imported/w3c/resources/TestRepositories.
359
360         Similarly to https://codereview.chromium.org/148173016,
361         TestDownloader copies part of the files based on the rules
362         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
363
364         TestDownloader is used by TestImporter when no source directory is provided.
365
366         * Scripts/webkitpy/w3c/test_downloader.py: Added.
367         (TestDownloader):
368         (TestDownloader.default_options):
369         (TestDownloader.load_test_repositories):
370         (TestDownloader.__init__):
371         (TestDownloader.checkout_test_repository):
372         (TestDownloader._init_paths_from_expectations):
373         (TestDownloader._add_test_suite_paths):
374         (TestDownloader._empty_directory):
375         (TestDownloader.copy_tests):
376         (TestDownloader.download_tests):
377         * Scripts/webkitpy/w3c/test_importer.py:
378         (main):
379         (parse_args):
380         (TestImporter.__init__):
381         (TestImporter.do_import):
382         (TestImporter.test_downloader):
383         (TestImporter.find_importable_tests.should_keep_subdir):
384         (TestImporter.should_convert_test_harness_links):
385         (TestImporter.import_tests):
386         (TestImporter.write_import_log):
387
388 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
389
390         [Mavericks] Test snapshots are 1600x1200 on Retina devices
391         https://bugs.webkit.org/show_bug.cgi?id=142630
392
393         Reviewed by Tim Horton.
394
395         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
396         Removed an ifdef that disabled the fix on Mavericks.
397
398 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
399
400         Remove isWK2 cruft from webkitdirs.pm after r170426
401         https://bugs.webkit.org/show_bug.cgi?id=142618
402
403         Reviewed by Daniel Bates.
404
405         * Scripts/webkitdirs.pm:
406         (isWK2): Deleted.
407
408 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
409
410         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
411         https://bugs.webkit.org/show_bug.cgi?id=138687
412
413         Reviewed by Carlos Garcia Campos.
414
415         Always change cookie policy from UI process, as changing it from WebProcess doesn't
416         affect other processes.
417
418         The implementation is imperfect, because the change happens asynchronously, but I
419         don't expect it to be a problem in practice.
420
421         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
422         (WTR::InjectedBundle::beginTesting):
423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
424         (WTR::TestRunner::setAlwaysAcceptCookies):
425         * WebKitTestRunner/TestInvocation.cpp:
426         (WTR::TestInvocation::invoke):
427         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
428
429 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
430
431         [EFL] Enable building EFL 1.13 with NEON support
432         https://bugs.webkit.org/show_bug.cgi?id=142619
433
434         Reviewed by Gyuyoung Kim.
435
436         * efl/jhbuild.modules:
437
438 2015-03-11  Alex Christensen  <achristensen@webkit.org>
439
440         [Content Extensions] Add resource type and load type triggers.
441         https://bugs.webkit.org/show_bug.cgi?id=142422
442
443         Reviewed by Benjamin Poulain.
444
445         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
446         (TestWebKitAPI::testRequest):
447         (TestWebKitAPI::mainDocumentRequest):
448         (TestWebKitAPI::TEST_F):
449         (TestWebKitAPI::testURL): Deleted.
450
451 2015-03-10  Sam Weinig  <sam@webkit.org>
452
453         Allow adding a button in input elements for auto fill related functionality
454         <rdar://problem/19782066>
455         https://bugs.webkit.org/show_bug.cgi?id=142564
456
457         Reviewed by Anders Carlsson.
458
459         * WebKitTestRunner/TestController.cpp:
460         (WTR::TestController::createOtherPage):
461         (WTR::TestController::createWebViewWithOptions):
462         Update for new callback.
463
464 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
465
466         Add basic support for BOL and EOL assertions to the URL Filter parser
467         https://bugs.webkit.org/show_bug.cgi?id=142568
468
469         Reviewed by Alex Christensen.
470
471         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
472         (TestWebKitAPI::TEST_F):
473
474 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
475
476         [GTK] Add support for handling TLS errors to MiniBrowser
477         https://bugs.webkit.org/show_bug.cgi?id=142576
478
479         Reviewed by Sergio Villar Senin.
480
481         It's useful for testing TLS errors handling itself, but also to
482         allow ignoring TLS errors when testing.
483
484         * MiniBrowser/gtk/BrowserWindow.c:
485         (webViewLoadFailedWithTLSerrors):
486         (browserWindowConstructed):
487
488 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
489
490         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
491         https://bugs.webkit.org/show_bug.cgi?id=142569
492
493         Reviewed by David Hyatt.
494
495         Test Optional::valueOrCompute().
496
497         * TestWebKitAPI/Tests/WTF/Optional.cpp:
498         (TestWebKitAPI::TEST):
499
500 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
501
502         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
503         https://bugs.webkit.org/show_bug.cgi?id=126688
504
505         Reviewed by Gustavo Noronha Silva.
506
507         * CMakeLists.txt: Build testing tools only for developer builds,
508         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
509         * MiniBrowser/gtk/CMakeLists.txt: Only add
510         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
511         and add a rule to install the MiniBrowser.
512         * MiniBrowser/gtk/main.c:
513         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
514         builds.
515
516 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
517
518         Add some DateMath tests to TestWebKitAPI
519         https://bugs.webkit.org/show_bug.cgi?id=142565
520
521         Reviewed by Alexey Proskuryakov.
522
523         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
524         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
525         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
526         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
527         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
528
529 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
530
531         Regression(r181257): WTF_WorkQueue.Simple is flaky
532         https://bugs.webkit.org/show_bug.cgi?id=142560
533
534         Unreviewed attempt to improve test stability.
535
536         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
537         the WorkQueue a little later to redue flakiness.
538
539 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
540
541         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
542         https://bugs.webkit.org/show_bug.cgi?id=142555
543
544         Reviewed by Simon Fraser.
545
546         * DumpRenderTree/mac/DumpRenderTree.mm:
547         (setDefaultsToConsistentValuesForTesting):
548         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
549         (WTR::InjectedBundle::platformInitialize):
550
551 2015-03-10  Alex Christensen  <achristensen@webkit.org>
552
553         Use unsigned for HashSet size.
554         https://bugs.webkit.org/show_bug.cgi?id=142518
555
556         Reviewed by Benjamin Poulain.
557
558         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
559         (TestWebKitAPI::TEST):
560         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
561         (TestWebKitAPI::testInitialCapacity):
562         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
563         (TestWebKitAPI::TEST):
564
565 2015-03-10  Daniel Bates  <dabates@apple.com>
566
567         [iOS] Add WebKitSystemInterface for iOS 8.2
568         https://bugs.webkit.org/show_bug.cgi?id=142505
569
570         Rubber-stamped by Anders Carlsson.
571
572         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
573         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
574         copy-webkitlibraries-to-product-directory in r181286.
575
576         * Scripts/copy-webkitlibraries-to-product-directory:
577
578 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
579
580         Extend URL filter's Term definition to support groups/subpatterns
581         https://bugs.webkit.org/show_bug.cgi?id=142519
582
583         Reviewed by Alex Christensen.
584
585         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
586         (TestWebKitAPI::testURL):
587
588 2015-03-06  Jer Noble  <jer.noble@apple.com>
589
590         Add an option to run-webkit-tests to override the LayoutTests/ directory
591         https://bugs.webkit.org/show_bug.cgi?id=142418
592
593         Reviewed by David Kilzer.
594
595         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
596         directory. The base port will parse the options during initialization and store the override
597         location if present. layout_tests_dir() will return this overridden location if set.
598
599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
600         (parse_args):
601         * Scripts/webkitpy/port/base.py:
602         (Port.__init__):
603         (Port.layout_tests_dir):
604
605 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
606
607         [CMake] Enable WorkQueue tests for CMake ports
608         https://bugs.webkit.org/show_bug.cgi?id=142473
609
610         Reviewed by Darin Adler.
611
612         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
613         the list of source files.
614         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
615         to the list of include directories for EFL.
616
617 2015-03-09  David Kilzer  <ddkilzer@apple.com>
618
619         Attempt to fix timeouts on iOS Simulator layout tests
620
621         * Scripts/webkitpy/port/ios.py:
622         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
623         Simulator end after the first 50 tests time out.  Some analysis
624         this past weekend shows that the 'Booted' status in the output
625         of `xcrun simctl list` is not sufficient (and watching the test
626         run shows that SpringBoard hasn't fully started to the point
627         where it's displaying icons on the home screen).  The workaround
628         until we have a better fix is to add an arbitrary timeout to let
629         SpringBoard finish launching.  In practice, 15 seconds is
630         probably enough, but 30 seconds should nearly always work.
631
632 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
633
634         Unreviewed. Add myself as a committer.
635
636         * Scripts/webkitpy/common/config/contributors.json:
637
638 2015-03-09  David Kilzer  <ddkilzer@apple.com>
639
640         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
641
642         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
643         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
644         an expectation that will fail if we hit the race condition.
645         This test is inherently racy and will deadlock if the first job
646         for queue2 takes the mutex lock before the second job for
647         queue1.
648
649 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
650
651         [Win] WTF::WorkQueue does not balance ref/deref properly
652         https://bugs.webkit.org/show_bug.cgi?id=142471
653
654         Reviewed by Antti Koivisto.
655
656         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
657         (TestWebKitAPI::TEST): Check that the refcount is correct.
658
659 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
660
661         Do not show passing test result on output of EFL layout test
662         https://bugs.webkit.org/show_bug.cgi?id=142380
663
664         Reviewed by Darin Adler.
665
666         To show passing tests has caused inconvenience when we detect problem tests
667         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
668         in order not to show passing tests in the output of EFL layout test.
669
670         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
671         (RunWebKitTests.start):
672
673 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
674
675         Unreviewed build fix.
676
677         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
678         (TestWebKitAPI::TEST): Remove two unused variables.
679
680 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
681
682         Add some WorkQueue tests to TestWebKitAPI
683         https://bugs.webkit.org/show_bug.cgi?id=142447
684
685         Reviewed by Sam Weinig.
686
687         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
688         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
690         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
691         (TestWebKitAPI::simpleTest):
692         (TestWebKitAPI::longTest):
693         (TestWebKitAPI::thirdTest):
694         (TestWebKitAPI::finishedTests):
695         (TestWebKitAPI::TEST):
696         (TestWebKitAPI::longTest2):
697
698 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
699
700         Remove willDestroyFrame in WKBundlePageLoaderClient
701         https://bugs.webkit.org/show_bug.cgi?id=142389
702
703         Reviewed by Anders Carlsson.
704
705         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
706         (WTR::InjectedBundlePage::InjectedBundlePage):
707
708 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
709
710         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
711         https://bugs.webkit.org/show_bug.cgi?id=142433
712
713         Reviewed by Darin Adler.
714
715         Include more TestWebKitAPI tests when building for Windows. Also
716         fix a build error in MetaAllocator.cpp caused by one of the
717         Microsoft headers #defining 'small'.
718
719         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
720         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
721         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
722
723 2015-03-06  Sam Weinig  <sam@webkit.org>
724
725         [Content Extensions] Move compiling of content extensions to the UIProcess
726         https://bugs.webkit.org/show_bug.cgi?id=142402
727
728         Reviewed by Benjamin Poulain.
729
730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
731         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
732         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
733         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
734         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
735         (TestWebKitAPI::TEST_F):
736         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
737         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
738         is now abstract).
739
740 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
741
742         [Win] Correct Windows build.
743
744         Rubberstamped by Michael Saboff
745
746         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
747         in the GOTO labels.
748
749 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
750
751         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
752         https://bugs.webkit.org/show_bug.cgi?id=142385
753
754         Reviewed by Sergio Villar Senin.
755
756         Use stack allocated GMainLoopSources to make sure they are
757         cancelled automatically if the test finishes before they have
758         been processed.
759
760         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
761         (testWebViewSyncRequestOnMaxConns):
762
763 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
764
765         Remove Mountain Lion libraries since ML isn't supported
766         https://bugs.webkit.org/show_bug.cgi?id=142332
767
768         Reviewed by Darin Adler.
769
770         * Scripts/copy-webkitlibraries-to-product-directory:
771
772 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
773
774         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
775         https://bugs.webkit.org/show_bug.cgi?id=142083
776
777         Reviewed by Simon Fraser.
778
779         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
780
781         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
782         (WebPlatformTestServer._copy_webkit_test_files):
783
784 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
785
786         setup-git-clone fails due to the failure to download python-irclib-0.4.8
787         https://bugs.webkit.org/show_bug.cgi?id=141946
788
789         Reviewed by Ryosuke Niwa.
790
791         Check in ircbot.py and irclib.py to avoid network problems in the future.
792
793         * Scripts/webkitpy/common/net/irc/ircbot.py:
794         * Scripts/webkitpy/thirdparty/__init__.py:
795         (AutoinstallImportHook.find_module):
796         (AutoinstallImportHook._install_irc): Deleted.
797         * Scripts/webkitpy/thirdparty/__init___unittest.py:
798         (ThirdpartyTest.test_imports):
799         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
800         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
801         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
802
803 2015-03-06  David Kilzer  <ddkilzer@apple.com>
804
805         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
806
807         See also fix to config.json in r181097.
808
809         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
810         (WebKitBuildbot): Add missing "WK2" to the names of the perf
811         bots.
812
813 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
814
815         run-jsc-stress-tests should determine the architecture from ELF binaries
816         https://bugs.webkit.org/show_bug.cgi?id=142335
817
818         Reviewed by Darin Adler.
819
820         * Scripts/run-jsc-stress-tests:
821
822 2015-03-05  David Kilzer  <ddkilzer@apple.com>
823
824         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
825         <http://webkit.org/b/142226>
826
827         Reviewed by Darin Adler.
828
829         * Scripts/webkitpy/port/ios.py:
830         (IOSSimulatorPort.default_baseline_search_path): Switch the
831         TestExpectations order of ios-simulator-wk2 from this:
832           ios-simulator-wk2, wk2, ios-simulator
833         To this:
834           ios-simulator-wk2, ios-simualtor, wk2
835
836 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
837
838         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
839         https://bugs.webkit.org/show_bug.cgi?id=142370
840
841         Reviewed by Dean Jackson.
842
843         * Scripts/webkitdirs.pm:
844         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
845         logs, one for warnings, the other for errors.
846         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
847         into the standard BuildOutput.htm document.
848
849 2015-03-05  David Kilzer  <ddkilzer@apple.com>
850
851         Dashboard has trouble parsing iOS test output
852         <http://webkit.org/b/142364>
853
854         Reviewed by Alex Christensen.
855
856         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
857         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
858         Add fallback path to build a regex using 'matchString' so that
859         it matches anywhere in the line.  In practice, 'matchString' is
860         a prefix for the label following the number.
861
862 2015-03-05  Alex Christensen  <achristensen@webkit.org>
863
864         Fix linker warnings in TestWebKitAPI.
865         https://bugs.webkit.org/show_bug.cgi?id=141912
866
867         Reviewed by David Kilzer.
868
869         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
870         Do not export TearDownTestCase or SetUpTestCase symbols.
871
872 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
873
874         [Win] Unreviewed EWS fix.
875
876         * Scripts/webkitdirs.pm:
877         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
878         the EWS output more usable.
879
880 2015-03-05  Chris Dumez  <cdumez@apple.com>
881
882         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
883         https://bugs.webkit.org/show_bug.cgi?id=142350
884
885         Reviewed by Michael Saboff and Benjamin Poulain.
886
887         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
888         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
889
890         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
891         (TestWebKitAPI::TEST):
892
893 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
894
895         [Win] Ensure build target directory exists when launching MSBuild
896         https://bugs.webkit.org/show_bug.cgi?id=142360
897
898         Reviewed by Dean Jackson.
899
900         Create the build output directory (if it doesn't exist) before
901         launching MSBuild so that it can immediately begin writing logs.
902
903         * Scripts/webkitdirs.pm:
904         (buildVisualStudioProject):
905
906 2015-03-05  Chris Dumez  <cdumez@apple.com>
907
908         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
909         https://bugs.webkit.org/show_bug.cgi?id=142325
910
911         Reviewed by Csaba Osztrogonác.
912
913         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
914         As a result, "--webkit-test-runner / -2" parameters are replaced by
915         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
916         than WebKitTestRunner.
917
918         * BuildSlaveSupport/build.webkit.org-config/config.json:
919         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
920         (RunWebKit1Tests):
921         (RunWebKit1Tests.start):
922         (RunWebKit1LeakTests):
923         (RunWebKit1LeakTests.start):
924         (RunAndUploadPerfTestsWebKit1):
925         (RunAndUploadPerfTestsWebKit1.start):
926         (TestFactory):
927         (TestWebKit1LeaksFactory):
928         (TestWebKit1LeaksFactory.__init__):
929         (TestWebKit1Factory):
930         (TestWebKit1AllButJSCFactory):
931         (TestAllButJSCFactory):
932         (BuildAndPerfTestWebKit1Factory):
933         (BuildAndPerfTestWebKit1Factory.__init__):
934         (BuildAndPerfTestFactory):
935         (BuildAndPerfTestFactory.__init__):
936         (DownloadAndPerfTestWebKit1Factory):
937         (DownloadAndPerfTestWebKit1Factory.__init__):
938         (DownloadAndPerfTestFactory):
939         (DownloadAndPerfTestFactory.__init__):
940         (RunWebKitLeakTests): Deleted.
941         (RunWebKitLeakTests.start): Deleted.
942         (RunWebKit2Tests): Deleted.
943         (RunWebKit2Tests.start): Deleted.
944         (RunAndUploadPerfTestsWebKit2): Deleted.
945         (RunAndUploadPerfTestsWebKit2.start): Deleted.
946         (TestLeaksFactory): Deleted.
947         (TestLeaksFactory.__init__): Deleted.
948         (TestWebKit2Factory): Deleted.
949         (TestWebKit2AndJSCFactory): Deleted.
950         (BuildAndPerfTestWebKit2Factory): Deleted.
951         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
952         (DownloadAndPerfTestWebKit2Factory): Deleted.
953         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
955         (parse_args):
956         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
957         (PerfTestsRunner._parse_args):
958         * Scripts/webkitpy/port/port_testcase.py:
959         (PortTestCase.test_build_driver):
960
961 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
962
963         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
964         https://bugs.webkit.org/show_bug.cgi?id=140845
965
966         Reviewed by David Kilzer.
967
968         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
969         and generate suitable build commands to drive a full build from our
970         existing solution files.
971
972         * Scripts/webkitdirs.pm:
973         (msBuildInstallDir): Added.
974         (determineConfigurationForVisualStudio): Revise to use MSBuild command
975         line arguments to drive the build.
976         (setupCygwinEnv): Warn user if MSBuild cannot be located.
977         (buildVisualStudioProject): Revise to use MSBuild command line arguments
978         to specify build architecture.
979         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
980         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
981         bother looking for CoreUI or SafariTheme build logs.
982
983 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
984
985         [buildbot] mastercfg_unittest.py should be runnable easily
986         https://bugs.webkit.org/show_bug.cgi?id=142219
987
988         Reviewed by Chris Dumez.
989
990         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
991         the last Twisted version works together with this buildbot version.
992
993         * Scripts/webkitpy/common/system/autoinstall.py:
994         (AutoInstaller): Added prepend_to_search_path argument to be able
995         to prefer autoinstalled package to system package.
996         (AutoInstaller.__init__):
997         (AutoInstaller._set_up_target_dir):
998         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
999         (AutoInstaller._prepare_package):
1000         (AutoInstaller._extract_targz): Renamed to _extract_tar.
1001         * Scripts/webkitpy/thirdparty/__init__.py:
1002         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1003
1004 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
1005
1006         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1007         https://bugs.webkit.org/show_bug.cgi?id=131162
1008
1009         Reviewed by Gyuyoung Kim.
1010
1011         * MiniBrowser/efl/main.c:
1012         (on_download_request):
1013         (on_download_finished):
1014         (on_download_failed):
1015         (window_create):
1016         Adapt download callbacks to new callback mechanism
1017
1018 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1019
1020         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1021
1022         In r180927 we updated the libsoup version used by the jhbuild. In
1023         this new version the sniffer uses image/x-icon instead of
1024         image/vnd.microsoft.icon for blank.ico resource.
1025
1026         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1027         (testWebResourceMimeType):
1028
1029 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1030
1031         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1032         https://bugs.webkit.org/show_bug.cgi?id=142244
1033
1034         Reviewed by Sergio Villar Senin.
1035
1036         Check that the SSL server doesn't process any request in case of
1037         TLS errors when the policy is set to FAIL.
1038
1039         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1040         (testTLSErrorsPolicy):
1041         (testTLSErrorsRedirect):
1042         (testTLSErrorsHTTPAuth):
1043         (testLoadFailedWithTLSErrors):
1044         (testSubresourceLoadFailedWithTLSErrors):
1045         (httpsServerCallback):
1046
1047 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
1048
1049         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1050         https://bugs.webkit.org/show_bug.cgi?id=141154
1051
1052         Reviewed by Jer Noble.
1053
1054         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1055
1056         For the sake of completeness WebKitTestRunner should specify temporary
1057         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1058
1059         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1060         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1061         to get data storage paths. Only Mac port has an actual implementation of it.
1062         However, WebKitTestRunner overrides them in favour of unique temporary dir
1063         which is taken from libraryPathForTesting().
1064
1065         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1066         is not implemented for EFL and GTK ports it returns an empty string.
1067         All default data folders besides MediaKeys are overridden in TestRunner
1068         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1069         env variable.
1070
1071         GTK port does not enable encrypted keys by default so
1072         WebMediaKeyStorageManager::initialize() code path is never triggered.
1073
1074         * WebKitTestRunner/TestController.cpp:
1075         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1076         WebKit ports.
1077
1078 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1079
1080         [buildbot] Add regression test to check which builder runs which tests
1081         https://bugs.webkit.org/show_bug.cgi?id=142166
1082
1083         Reviewed by Alexey Proskuryakov.
1084
1085         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1086         (BuildStepsConstructorTest.createTest):
1087         (BuildStepsTest):
1088         (BuildStepsTest.generateTests):
1089         (BuildStepsTest.createTest):
1090         (BuildStepsTest.createTest.doTest):
1091         (BuildStepsTest.test_unnecessary_expected_results):
1092
1093 2015-03-04  Commit Queue  <commit-queue@webkit.org>
1094
1095         Unreviewed, rolling out r181054.
1096         https://bugs.webkit.org/show_bug.cgi?id=142320
1097
1098         Broke the api tests (Requested by sundiamonde on #webkit).
1099
1100         Reverted changeset:
1101
1102         "Fix linker warnings in TestWebKitAPI."
1103         https://bugs.webkit.org/show_bug.cgi?id=141912
1104         http://trac.webkit.org/changeset/181054
1105
1106 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1107
1108         Fix linker warnings in TestWebKitAPI.
1109         https://bugs.webkit.org/show_bug.cgi?id=141912
1110
1111         Reviewed by David Kilzer.
1112
1113         * TestWebKitAPI/Configurations/Base.xcconfig:
1114         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1115
1116 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
1117
1118         [Mac] Set SystemUIFontSelect in DRT and WKTR
1119         https://bugs.webkit.org/show_bug.cgi?id=142303
1120
1121         Reviewed by Myles C. Maxfield.
1122
1123         * DumpRenderTree/mac/DumpRenderTree.mm:
1124         (setDefaultsToConsistentValuesForTesting):
1125         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1126         (WTR::InjectedBundle::platformInitialize):
1127
1128 2015-03-04  Chris Dumez  <cdumez@apple.com>
1129
1130         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1131         https://bugs.webkit.org/show_bug.cgi?id=142314
1132         <rdar://problem/20046835>
1133
1134         Reviewed by Ryosuke Niwa.
1135
1136         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1137         to get WK2 code coverage.
1138
1139         * BuildSlaveSupport/build.webkit.org-config/config.json:
1140
1141 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1142
1143         Move content extensions test to properly named directory.
1144         https://bugs.webkit.org/show_bug.cgi?id=142299
1145
1146         Reviewed by Tim Horton.
1147
1148         * WebKitTestRunner/mac/TestControllerMac.mm:
1149         (WTR::TestController::platformConfigureViewForTest):
1150
1151 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1152
1153         W3C test importer should use filesystem instead of os.walk
1154         https://bugs.webkit.org/show_bug.cgi?id=142085
1155
1156         Reviewed by Bem Jones-Bey.
1157
1158         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1159         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1160         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1161
1162         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1163         Added a unit test to check that test importer is now black-box testable using a Mock system.
1164
1165         * Scripts/webkitpy/common/system/filesystem.py:
1166         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1167         (FileSystem.dirs_under.filter_all):
1168         * Scripts/webkitpy/common/system/filesystem_mock.py:
1169         (MockFileSystem.dirs_under):
1170         (MockFileSystem.dirs_under.filter_all):
1171         (MockFileSystem.getsize):
1172         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1173         (MockFileSystemTest.test_dirs_under):
1174         (MockFileSystemTest.test_dirs_under.filter_dir):
1175         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1176         (RealFileSystemTest.test_sep):
1177         (RealFileSystemTest):
1178         (RealFileSystemTest.test_dirs_under):
1179         (RealFileSystemTest.test_dirs_under.filter_this_dir):
1180         * Scripts/webkitpy/w3c/test_importer.py:
1181         (TestImporter.do_import):
1182         (TestImporter.find_importable_tests.should_keep_subdir):
1183         (TestImporter.find_importable_tests):
1184         (TestImporter.should_keep_subdir): Deleted.
1185         (TestImporter.should_skip_file): Deleted.
1186         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1187         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1188
1189 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
1190
1191         [WebEditingTester] Add support for the find and replace bar
1192         https://bugs.webkit.org/show_bug.cgi?id=142247
1193
1194         Reviewed by Enrica Casucci.
1195
1196         While it's not hooked up yet in WKWebView, adding support for the
1197         find bar to WebEditingTester will help us implement that functionality.
1198
1199         * WebEditingTester/AppDelegate.h:
1200         * WebEditingTester/AppDelegate.m:
1201         (-[WebEditingAppDelegate performTextFinderAction:]):
1202         * WebEditingTester/MainMenu.xib:
1203         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1204
1205         * WebEditingTester/WK2WebDocumentController.m:
1206         (-[WK2WebDocumentController awakeFromNib]):
1207         (-[WK2WebDocumentController performTextFinderAction:]):
1208         (-[WK2WebDocumentController findBarView]):
1209         (-[WK2WebDocumentController setFindBarView:]):
1210         (-[WK2WebDocumentController isFindBarVisible]):
1211         (-[WK2WebDocumentController setFindBarVisible:]):
1212         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1213         (-[WK2WebDocumentController layout]):
1214         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1215         pointing at the WKWebView (currently nothing will work, but the bar will
1216         show up). Install and uninstall the bar as needed.
1217
1218         * WebEditingTester/WebDocument.xib:
1219         Don't use a full-size content view. There's no need, and it makes find
1220         bar layout harder.
1221
1222         * WebEditingTester/WebDocumentController.h:
1223         * WebEditingTester/WebDocumentController.m:
1224         (-[WebDocumentController performTextFinderAction:]):
1225
1226 2015-03-03  Sam Weinig  <sam@webkit.org>
1227
1228         [Content Extensions] Split parsing and compiling of content extensions into their own files
1229         https://bugs.webkit.org/show_bug.cgi?id=142259
1230
1231         Reviewed by Anders Carlsson.
1232
1233         Add basic unit test for the content filter compiler.
1234
1235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1236         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1237         (WebCore::ContentExtensions::operator<<):
1238         (TestWebKitAPI::ContentFilterTest::SetUp):
1239         (TestWebKitAPI::TEST_F):
1240
1241 2015-03-04  Matthew Mirman  <mmirman@apple.com>
1242
1243         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1244         https://bugs.webkit.org/show_bug.cgi?id=142230
1245
1246         Reviewed by Csaba Osztrogonác.
1247
1248         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1249         (TestFactory):
1250         (TestFactory.getProduct): Added
1251         (TestFactory.__init__): moved downloader to getProduct
1252         (BuildAndTestFactory):        
1253         (BuildAndTestFactory.getProduct): Added
1254         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1255         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
1256
1257 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
1258
1259         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1260         https://bugs.webkit.org/show_bug.cgi?id=142225
1261
1262         Reviewed by Carlos Garcia Campos.
1263
1264         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1265         (testWebViewWebContextLifetime):
1266         (beforeAll):
1267
1268 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1269
1270         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1271         <http://webkit.org/b/142243>
1272
1273         Reviewed by Alexey Proskuryakov.
1274
1275         * WebKitTestRunner/TestController.cpp:
1276         (WTR::TestController::webProcessName):
1277         (WTR::TestController::networkProcessName):
1278         - Return the same process name on iOS and Mac because they both
1279           use the same process name for local engineering builds.
1280
1281 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1282
1283         check-webkit-style: Add exception for FrameworkSoftLink.h header order
1284         <http://webkit.org/b/141872>
1285
1286         Reviewed by Alex Christensen.
1287
1288         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1289         semi-colons in various places and fix whitespace.
1290         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1291         constants.
1292         (_IncludeState.__init__): Add self._visited_soft_link_section
1293         boolean state variable.
1294         (_IncludeState.visited_soft_link_section): Getter for
1295         self._visited_soft_link_section.
1296         (_IncludeState.check_next_include_order): Update state machine
1297         for soft-link headers.  Add check that soft-link headers always
1298         appear last.
1299         (_classify_include): Add check for soft-link header type.
1300         (check_include_line): Return early if there is a soft-link
1301         header error.
1302
1303         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1304         (OrderOfIncludesTest.test_public_primary_header): Add tests for
1305         including soft-link headers.
1306         (OrderOfIncludesTest.test_classify_include): Add test for
1307         _SOFT_LINK_HEADER type.
1308
1309 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
1310
1311         build.webkit.org/dashboard: Don't repeatedly handle each test type
1312         https://bugs.webkit.org/show_bug.cgi?id=142211
1313
1314         Reviewed by Tim Horton and Matt Hanson.
1315
1316         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1317         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1318         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1319         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1320         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1321         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1322         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1323         Removed functions that build a link to test step results. The buildbot provides
1324         these links in JSON.
1325
1326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1327         (BuildbotIteration): Put failing tests into an array, instead of named variables.
1328         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1329         We can easily add them to the map as needed.
1330         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1331         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1332         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1333         and then build a BuildbotTestResults object, which was strange.
1334         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1335
1336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1337         Corrected an unrelated assertion that was buggy, and kept firing.
1338
1339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1340         (BuildbotTestResults):
1341         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1342         (BuildbotTestResults.prototype._parseResults):
1343         (BuildbotTestResults.prototype.addFullLayoutTestResults):
1344         Moved the code for parsing JSON results for a single step here.
1345
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1347         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1348         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1349         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1350         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1351         (BuildbotTesterQueueView.prototype.update): Deleted.
1352         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1353         Updated for the new data structures. One behavior change is that we now display individual
1354         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1355         test failures, 3 platform api test failures".
1356
1357 2015-03-03  Matthew Mirman  <mmirman@apple.com>
1358
1359         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1360         https://bugs.webkit.org/show_bug.cgi?id=142094
1361
1362         Reviewed by Csaba Osztrogonác.
1363
1364         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1366         (TestFactory):
1367         (TestFactory.__init__): Made running of JSC tests conditional.
1368         (TestAllButJSCFactory):
1369         (TestJSCFactory): Added.
1370         (TestJSCFactory.__init__):
1371         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1372
1373 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1374
1375         `build-webkit --help` is wrong about how to build for the iOS simulator
1376         <http://webkit.org/b/142223>
1377
1378         Reviewed by Csaba Osztrogonác.
1379
1380         * Scripts/build-webkit: Fix help.
1381
1382 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1383
1384         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1385
1386         * gtk/jhbuild.modules:
1387
1388 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1389
1390         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1391         https://bugs.webkit.org/show_bug.cgi?id=141508
1392
1393         Reviewed by Sergio Villar Senin.
1394
1395         Add a unit test to check that synchronous XHRs load even if the
1396         maximum connection limits are reached.
1397
1398         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1399         (testWebViewSyncRequestOnMaxConns):
1400         (serverCallback):
1401         (beforeAll):
1402         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1403
1404 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
1405
1406         Update the name of ASan build step.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1409
1410 2015-03-02  Jer Noble  <jer.noble@apple.com>
1411
1412         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1413         https://bugs.webkit.org/show_bug.cgi?id=142121
1414
1415         Reviewed by Simon Fraser.
1416
1417         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1418         that the initial and final screen rects for the web content are as expected.
1419
1420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1421         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1422         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1423         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1424         (runJavaScriptAlert):
1425         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1426         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1427         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1428         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1429         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1430         (TestWebKitAPI::TEST_F):
1431
1432 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1433
1434         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1435
1436         Follow-up fix for:
1437
1438         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1439         <http://webkit.org/b/142145>
1440
1441         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1442         (-[LTRelayController _environmentVariables]): Fix think-o.
1443
1444 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1445
1446         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1447         <http://webkit.org/b/142145>
1448
1449         Reviewed by Simon Fraser.
1450
1451         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1452         (-[LTRelayController _environmentVariables]): Add.
1453         (-[LTRelayController launchApp]): Use -_environmentVariables.
1454
1455 2015-02-28  David Kilzer  <ddkilzer@apple.com>
1456
1457         [iOS] Stop running webkit-build-directory on every layout test
1458
1459         This was originally fixed by David Farler for Bug 135409 in
1460         r172602.
1461
1462         * Scripts/webkitpy/port/ios.py:
1463         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1464         run webkit-build-directory every time it's called.
1465
1466 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1467
1468         W3C importer should use filesystem instead of shutil/host
1469         https://bugs.webkit.org/show_bug.cgi?id=142012
1470
1471         Reviewed by Bem Jones-Bey.
1472
1473         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1474
1475         * Scripts/webkitpy/w3c/test_importer.py:
1476         (main):
1477         (TestImporter.do_import):
1478         (TestImporter.find_importable_tests):
1479         (TestImporter.import_tests):
1480         (TestImporter.remove_deleted_files):
1481         (TestImporter.write_import_log):
1482
1483 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1484
1485         W3C test importer should use filesystem to read and write files
1486         https://bugs.webkit.org/show_bug.cgi?id=142084
1487
1488         Reviewed by Bem Jones-Bey.
1489
1490         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1491
1492         * Scripts/webkitpy/w3c/test_importer.py:
1493         (TestImporter.import_tests):
1494         (TestImporter.remove_deleted_files):
1495         (TestImporter.write_import_log):
1496
1497 2015-02-27  Sam Weinig  <sam@webkit.org>
1498
1499         Add WebKit2 SPI to create a DOM File object
1500         https://bugs.webkit.org/show_bug.cgi?id=142109
1501
1502         Reviewed by Tim Horton.
1503
1504         Add a test for WKBundleFileHandleRef.
1505
1506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1507         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1508         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1509         (TestWebKitAPI::didFinishLoadForFrame):
1510         (TestWebKitAPI::TEST):
1511         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1512         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1513         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1514
1515 2015-02-27  Michael Saboff  <msaboff@apple.com>
1516
1517         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1518         https://bugs.webkit.org/show_bug.cgi?id=142112
1519
1520         Reviewed by Filip Pizlo.
1521
1522         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1523         <someDir> as the library path.
1524
1525         * Scripts/run-jsc-benchmarks:
1526
1527 2015-02-27  Alex Christensen  <achristensen@webkit.org>
1528
1529         [WinCairo] Unreviewed build fix.
1530
1531         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1532         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1533
1534 2015-02-27  Anders Carlsson  <andersca@apple.com>
1535
1536         Add infrastructure for handling website data in the network process
1537         https://bugs.webkit.org/show_bug.cgi?id=142092
1538
1539         Reviewed by Andreas Kling.
1540
1541         Add a menu item that will fetch all website data, delete the returned data records, and
1542         fetch all website data again so we can confirm that it's all empty.
1543
1544         * MiniBrowser/mac/WK2BrowserWindowController.m:
1545         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1546
1547 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1548
1549         [Win] Remove remaining SafariTheme cruft
1550         https://bugs.webkit.org/show_bug.cgi?id=142075
1551
1552         Reviewed by Anders Carlsson.
1553
1554         Remove reference to SafariTheme-switching preference.
1555
1556         * DumpRenderTree/win/DumpRenderTree.cpp:
1557         (resetWebPreferencesToConsistentValues):
1558         (prepareConsistentTestingEnvironment):
1559
1560 2015-02-26  Doug Russell  <d_russell@apple.com>
1561
1562         AX: Expose caret browsing preference to accessibility API
1563         https://bugs.webkit.org/show_bug.cgi?id=141862
1564
1565         Reviewed by Chris Fleizach.
1566
1567         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1568         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1569
1570         * DumpRenderTree/AccessibilityUIElement.cpp:
1571         (setBoolAttributeValueCallback):
1572         (selectedTextMarkerRangeCallback):
1573         (resetSelectedTextMarkerRangeCallback):
1574         (AccessibilityUIElement::setBoolAttributeValue):
1575         (AccessibilityUIElement::selectedTextMarkerRange):
1576         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1577         (AccessibilityUIElement::getJSClass):
1578         * DumpRenderTree/AccessibilityUIElement.h:
1579         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1580         (AccessibilityUIElement::setBoolAttributeValue):
1581         (AccessibilityUIElement::selectedTextMarkerRange):
1582         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1583         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1584         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1585         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1586         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1587         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1588         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1589         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1590         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1591         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1592         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1593
1594 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1595
1596         [Win] Remove WebKitExportGenerator project (and related)
1597         https://bugs.webkit.org/show_bug.cgi?id=142035
1598
1599         Reviewed by Dean Jackson.
1600
1601         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1602         build log from WebKitExportGenerator.
1603
1604 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1605
1606         [EFL] Bump EFL version to 1.13.0
1607         https://bugs.webkit.org/show_bug.cgi?id=141708
1608
1609         Reviewed by Gyuyoung Kim.
1610
1611         * efl/jhbuild.modules:
1612
1613 2015-02-26  Sam Weinig  <sam@webkit.org>
1614
1615         Check in missing WebEditingTester.xcconfig file.
1616
1617         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1618
1619 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1620
1621         [webkitpy] Remove skipped file related crufts
1622         https://bugs.webkit.org/show_bug.cgi?id=142046
1623
1624         Reviewed by Ryosuke Niwa.
1625
1626         * Scripts/webkitpy/port/base.py:
1627         (Port.skipped_layout_tests):
1628         (Port._tests_from_skipped_file_contents): Deleted.
1629         (Port): Deleted.
1630         (Port._expectations_from_skipped_files): Deleted.
1631         * Scripts/webkitpy/port/mac_unittest.py:
1632         (MacTest.test_default_timeout_ms):
1633         (MacTest): Deleted.
1634         (test_tests_from_skipped_file_contents): Deleted.
1635
1636 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1637
1638         [Win] Unreviewed WinCairo build fix after r180653.
1639
1640         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1641
1642         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1643         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1644         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1645         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1646         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1647
1648 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
1649
1650         [Win] Use WEBCORE_EXPORT instead of Definition file
1651         https://bugs.webkit.org/show_bug.cgi?id=141734
1652
1653         Reviewed by Alex Christensen.
1654
1655         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1656         Use a precompiled header so we can define our export macros properly.
1657         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1658         Visual studio automatic update stuff.
1659         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1660         Set up Precompiled Header use for project..
1661         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1662         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1663         declarations for building DumpRenderTree as a client of
1664         WebCore/WebKit.
1665
1666 2015-02-25  Mark Lam  <mark.lam@apple.com>
1667
1668         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1669         <https://webkit.org/b/141672>
1670
1671         Reviewed by Alexey Proskuryakov.
1672
1673         ASan does not like the fact that we memcpy the stack for GC scans.  So,
1674         we're working around this by using our own memcpy (asanUnsafeMemcpy)
1675         implementation that we can tell ASan to ignore.
1676
1677         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1678         which isn't effective for working around this issue. 
1679
1680         * asan/webkit-asan-ignore.txt:
1681
1682 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
1683
1684         CodeBlock crashes when dumping op_push_name_scope
1685         https://bugs.webkit.org/show_bug.cgi?id=141953
1686
1687         Reviewed by Filip Pizlo.
1688
1689         * Scripts/run-jsc-stress-tests:
1690
1691 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1692
1693         W3C test importer should use argparse instead of optparse
1694         https://bugs.webkit.org/show_bug.cgi?id=142013
1695
1696         Reviewed by Bem Jones-Bey.
1697
1698         * Scripts/webkitpy/w3c/test_importer.py:
1699         (main): Updating according argparse.
1700         (parse_args): Moving from optparse to argparse.
1701
1702 2015-02-25  Brady Eidson  <beidson@apple.com>
1703
1704         Get rid of TestInvocation::pathOrURL
1705         https://bugs.webkit.org/show_bug.cgi?id=142021
1706
1707         Reviewed by Tim Horton.
1708
1709         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1710         but most code that uses it expected an absolute path.
1711
1712         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1713
1714         * WebKitTestRunner/TestController.cpp:
1715         (WTR::TestController::updateWebViewSizeForTest):
1716         (WTR::TestController::updateWindowScaleForTest):
1717         (WTR::shouldUseFixedLayout):
1718         (WTR::TestController::updateLayoutTypeForTest):
1719
1720         * WebKitTestRunner/TestInvocation.cpp:
1721         (WTR::TestInvocation::TestInvocation):
1722         (WTR::TestInvocation::urlContains):
1723         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1724         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1725         (WTR::TestInvocation::invoke):
1726         (WTR::shouldLogFrameLoadDelegates): Deleted.
1727         (WTR::shouldLogHistoryClientCallbacks): Deleted.
1728         * WebKitTestRunner/TestInvocation.h:
1729         (WTR::TestInvocation::pathOrURL): Deleted.
1730
1731         * WebKitTestRunner/ios/TestControllerIOS.mm:
1732         (WTR::shouldMakeViewportFlexible):
1733         (WTR::TestController::platformConfigureViewForTest):
1734
1735         * WebKitTestRunner/mac/TestControllerMac.mm:
1736         (WTR::shouldUseThreadedScrolling):
1737         (WTR::TestController::platformConfigureViewForTest):
1738
1739 2015-02-25  Brady Eidson  <beidson@apple.com>
1740
1741         Layout test support for user content filters
1742         https://bugs.webkit.org/show_bug.cgi?id=142018
1743
1744         Reviewed by Tim Horton.
1745
1746         * WebKitTestRunner/TestController.cpp:
1747         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1748
1749         * WebKitTestRunner/mac/TestControllerMac.mm:
1750         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1751           file before loading the test itself.
1752
1753 2015-02-24  Sam Weinig  <sam@webkit.org>
1754
1755         Convert WebEditingTester to use xcconfig files
1756         https://bugs.webkit.org/show_bug.cgi?id=141879
1757
1758         Reviewed by Darin Adler.
1759
1760         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1761
1762         * WebEditingTester/Configurations: Added.
1763         * WebEditingTester/Configurations/Base.xcconfig: Added.
1764         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1765         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1766
1767 2015-02-24  Andy Estes  <aestes@apple.com>
1768
1769         Teach MiniBrowser how to disable per-window web processes
1770         https://bugs.webkit.org/show_bug.cgi?id=141988
1771
1772         Reviewed by Darin Adler.
1773
1774         * MiniBrowser/mac/AppDelegate.m:
1775         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1776         * MiniBrowser/mac/SettingsController.h:
1777         * MiniBrowser/mac/SettingsController.m:
1778         (-[SettingsController _populateMenu]): Added a new Settings menu item.
1779         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1780         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1781         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1782
1783 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
1784
1785         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1786         https://bugs.webkit.org/show_bug.cgi?id=141889
1787
1788         Reviewed by Darin Adler.
1789
1790         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1791
1792 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1793
1794         REGRESSION(r179429): Can't type comments in Facebook
1795         https://bugs.webkit.org/show_bug.cgi?id=141859
1796
1797         Reviewed by Brent Fulgham.
1798
1799         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1800
1801         * DumpRenderTree/mac/DumpRenderTree.mm:
1802         (resetWebPreferencesToConsistentValues):
1803         * DumpRenderTree/win/DumpRenderTree.cpp:
1804         (resetWebPreferencesToConsistentValues):
1805         * WebKitTestRunner/TestController.cpp:
1806         (WTR::TestController::resetPreferencesToConsistentValues):
1807
1808 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1809
1810         Crash loading local file with WebPageProxy::loadAlternateHTMLString
1811         https://bugs.webkit.org/show_bug.cgi?id=141867
1812
1813         Reviewed by Anders Carlsson.
1814
1815         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1816         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1817         be shared with the new test.
1818         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1819         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1820         (testLoadAlternateHTMLForLocalPage):
1821         (beforeAll):
1822
1823 2015-02-24  David Kilzer  <ddkilzer@apple.com>
1824
1825         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1826         <http://webkit.org/b/141900>
1827
1828         Reviewed by Myles C. Maxfield.
1829
1830         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1831         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1832         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1833         - Rename to share code with iOS.
1834         - Add USE(APPKIT) around AppKit-specific headers and code.
1835         - Fix a check-webkit-style warning.
1836         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1837         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1838         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1839         - Remove ios/ActivateFontsIOS.mm.
1840         - Fix InjectedBundle/cocoa group to represent the directory on
1841           disk.  Includes a change to InjectedBundlePageCocoa.mm.
1842
1843 2015-02-23  Commit Queue  <commit-queue@webkit.org>
1844
1845         Unreviewed, rolling out r180547 and r180550.
1846         https://bugs.webkit.org/show_bug.cgi?id=141957
1847
1848         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1849
1850         Reverted changesets:
1851
1852         "REGRESSION(r179429): Can't type comments in Facebook"
1853         https://bugs.webkit.org/show_bug.cgi?id=141859
1854         http://trac.webkit.org/changeset/180547
1855
1856         "Constructor returning null should construct an object instead
1857         of null"
1858         https://bugs.webkit.org/show_bug.cgi?id=141640
1859         http://trac.webkit.org/changeset/180550
1860
1861 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
1862
1863         REGRESSION(r179429): Can't type comments in Facebook
1864         https://bugs.webkit.org/show_bug.cgi?id=141859
1865
1866         Reviewed by Geoffrey Garen.
1867
1868         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1869
1870         * DumpRenderTree/mac/DumpRenderTree.mm:
1871         (resetWebPreferencesToConsistentValues):
1872         * WebKitTestRunner/TestController.cpp:
1873         (WTR::TestController::resetPreferencesToConsistentValues):
1874
1875 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
1876
1877         [EFL] fix eo errors
1878         https://bugs.webkit.org/show_bug.cgi?id=141909
1879
1880         Reviewed by Gyuyoung Kim.
1881
1882         Fix eo errors that occur whenever minibrowser is launched.
1883         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1884         - elm_obj_win_resize_object_add's first parameter should be elm_win
1885
1886         * MiniBrowser/efl/main.c:
1887         (window_create):
1888
1889 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
1890
1891         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1892
1893         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1894         (TestWebKitAPI::TEST):
1895
1896 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1897
1898         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1899         https://bugs.webkit.org/show_bug.cgi?id=141935
1900
1901         Reviewed by Myles C. Maxfield.
1902
1903         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1904         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1905         tests for assigning from nullptr.
1906
1907 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
1908
1909         WTF::WeakPtr should have a 'forget' method.
1910         https://bugs.webkit.org/show_bug.cgi?id=141923
1911
1912         Reviewed by Myles C. Maxfield.
1913
1914         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1915         (TestWebKitAPI::TEST): Added 'Forget' tests case.
1916
1917 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1918
1919         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1920         https://bugs.webkit.org/show_bug.cgi?id=141920
1921
1922         Reviewed by Tim Horton.
1923
1924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1925         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1926         Do the same thing as we do for regular green bubbles.
1927
1928 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1929
1930         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1931         https://bugs.webkit.org/show_bug.cgi?id=141925
1932
1933         Reviewed by Tim Horton.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1936         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1937
1938 2015-02-23  Anders Carlsson  <andersca@apple.com>
1939
1940         Add API for fetching website data records to _WKWebsiteDataStore
1941         https://bugs.webkit.org/show_bug.cgi?id=141926
1942
1943         Reviewed by Beth Dakin.
1944
1945         * MiniBrowser/mac/MainMenu.xib:
1946         * MiniBrowser/mac/WK2BrowserWindowController.m:
1947         (-[WK2BrowserWindowController fetchWebsiteData:]):
1948         Add menu item to fetch and dump website data.
1949
1950 2015-02-23  David Kilzer  <ddkilzer@apple.com>
1951
1952         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1953         <http://webkit.org/b/141884>
1954
1955         Reviewed by Alexey Proskuryakov.
1956
1957         * Scripts/webkitpy/port/leakdetector.py:
1958         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1959         snowleopard, lion and older leaks.  Add known leak for
1960         mavericks, but check Port.operating_system before calling
1961         Port.is_mavericks.
1962         * Scripts/webkitpy/port/mac.py:
1963         (MacPort.is_snowleopard): Delete.
1964         (MacPort.is_lion): Delete.
1965         (MacPort.is_mavericks): Add.
1966
1967 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
1968
1969         build.webkit.org/dashboard should filter out commits to other branches
1970         https://bugs.webkit.org/show_bug.cgi?id=140362
1971
1972         Reviewed by Tim Horton.
1973
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1975         (BuildbotQueue):
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1977         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1978         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1979         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1980         (BuildbotQueueView.prototype.revisionContentForIteration):
1981         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1982         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1983         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1985         (Trac.prototype.get oldestRecordedRevisionNumber):
1986         (Trac.prototype.commitsOnBranch):
1987         (Trac.prototype._xmlTimelineURL):
1988         (Trac.prototype._convertCommitInfoElementToObject):
1989         (Trac.prototype._update):
1990         (Trac.prototype.startPeriodicUpdates):
1991         (Trac.prototype.loadMoreHistoricalData):
1992         (Trac.prototype.update): Deleted.
1993
1994 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1995
1996         Tests don't work on some bots: Failed to stop wptwk
1997         https://bugs.webkit.org/show_bug.cgi?id=141235
1998
1999         Reviewed by Ryosuke Niwa.
2000
2001         Logging of server subprocesses in launcher script.
2002         Killing of server subprocesses when stopping/before starting.
2003         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2004
2005         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2006         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
2007         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2008         (WebPlatformTestServer.__init__):
2009         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2010         (WebPlatformTestServer):
2011         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2012         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
2013         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2014         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2015         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2016         (TestWebPlatformTestServer):
2017         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2018
2019 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2020
2021         [WebEditingTester] Allow dropping HTML files on the app
2022         https://bugs.webkit.org/show_bug.cgi?id=141834
2023
2024         Reviewed by Simon Fraser.
2025
2026         * WebEditingTester/AppDelegate.m:
2027         (-[WebEditingAppDelegate openDocument:]):
2028         (-[WebEditingAppDelegate application:openFile:]):
2029         Implement application:openFile:, factoring file loading code out of openDocument.
2030
2031         * WebEditingTester/Info.plist:
2032         Register as an editor for HTML files.
2033
2034         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2035         Enrica is not an organization.
2036
2037 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2038
2039         [WebEditingTester] Expand "WK" to "WebKit" in a few places
2040         https://bugs.webkit.org/show_bug.cgi?id=141833
2041
2042         Reviewed by Anders Carlsson.
2043
2044         * WebEditingTester/AppDelegate.h:
2045         * WebEditingTester/AppDelegate.m:
2046         (-[WebEditingAppDelegate newEditor:]):
2047         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2048         (-[WebEditingAppDelegate validateMenuItem:]):
2049         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2050         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2051         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2052         (-[WebEditingAppDelegate showOperations:]): Deleted.
2053         * WebEditingTester/MainMenu.xib:
2054         The WK abbreviation is unnaturally grating in menu items for some reason.
2055
2056 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2057
2058         [WebEditingTester] Add a custom protocol for loading canned content
2059         https://bugs.webkit.org/show_bug.cgi?id=141830
2060
2061         Reviewed by Enrica Casucci.
2062
2063         Add a canned:// protocol handler, which can be used to emulate behaviors
2064         in WebKit client apps (like Mail) that use custom protocol handlers,
2065         which can have important effects on editing (mostly, the URLs are only
2066         valid inside of the client application, but not when copied/dragged out).
2067
2068         For now, we only support two canned files:
2069
2070             canned://dice is a PNG of dice (stolen from LayoutTests/)
2071             canned://text is the string "canned text" served as text/html
2072
2073         In the future we could support things like very large (generated) files,
2074         progressive loading, etc. to further simulate conditions in other apps.
2075
2076         * WebEditingTester/AppDelegate.m:
2077         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2078         Register the protocol with CFNetwork, and the scheme with WebKit2.
2079
2080         * WebEditingTester/Canned Content/dice.png: Added.
2081         * WebEditingTester/CannedContent.h: Added.
2082         * WebEditingTester/CannedContent.m: Added.
2083         (-[CannedContent initWithRequest:cachedResponse:client:]):
2084         (+[CannedContent canonicalRequestForRequest:]):
2085         (+[CannedContent canInitWithRequest:]):
2086         We only want to handle canned:// URLs.
2087
2088         (-[CannedContent startLoading]):
2089         For now, immediately load the two files we know about.
2090         Otherwise, immediately fail the load.
2091
2092         (-[CannedContent stopLoading]):
2093         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2094
2095 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2096
2097         [WebEditingTester] Implement an open panel
2098         https://bugs.webkit.org/show_bug.cgi?id=141829
2099
2100         Reviewed by Simon Fraser.
2101
2102         * WebEditingTester/AppDelegate.m:
2103         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2104         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2105         (-[WebEditingAppDelegate openDocument:]):
2106         Add an open panel (with radio buttons to pick which WebKit to open with).
2107         Loads the file as an HTML string.
2108
2109 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
2110
2111         [WebEditingTester] @properties, dot syntax, and remember the window position
2112         https://bugs.webkit.org/show_bug.cgi?id=141843
2113
2114         Reviewed by Tim Horton.
2115         
2116         Modernize a bit with more dot syntax, use @property for the web views,
2117         and give the main window an Autosave name so it remembers the widow position.
2118
2119         * WebEditingTester/WK1WebDocumentController.m:
2120         (-[WK1WebDocumentController awakeFromNib]):
2121         (-[WK1WebDocumentController loadHTMLString:]):
2122         * WebEditingTester/WK2WebDocumentController.m:
2123         (-[WK2WebDocumentController awakeFromNib]):
2124         * WebEditingTester/WebDocument.xib:
2125
2126 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2127
2128         [WebEditingTester] Hook up key equivalents for new window action
2129         https://bugs.webkit.org/show_bug.cgi?id=141828
2130
2131         Reviewed by Enrica Casucci.
2132
2133         * WebEditingTester/AppDelegate.h:
2134         * WebEditingTester/AppDelegate.m:
2135         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2136         (-[WebEditingAppDelegate newEditor:]):
2137         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2138         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2139         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2140         (defaultConfiguration): Deleted.
2141         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2142         Move WKWebViewConfiguration setup into WK2WebDocumentController.
2143         Remove unused application termination code.
2144         Update new-window menu item key equivalents when launching and when
2145         changing the use-WebKit2-by-default setting.
2146         Make WebDocumentController subclasses all initialized the same way,
2147         and use that to factor out alloc/init.
2148         Rename loadContent to loadHTMLString for future use.
2149
2150         * WebEditingTester/MainMenu.xib:
2151         Add default key equivalents.
2152         Cmd-N will always make the default kind of window (controlled by the pref).
2153         Cmd-Opt-N will always make the other kind.
2154         The menu items are configured as alternates so they only show up if you
2155         press alt (just like in MiniBrowser).
2156
2157         * WebEditingTester/WK1WebDocumentController.m:
2158         (-[WK1WebDocumentController loadHTMLString:]):
2159         (-[WK1WebDocumentController loadContent]): Deleted.
2160         * WebEditingTester/WK2WebDocumentController.h:
2161         * WebEditingTester/WK2WebDocumentController.m:
2162         (defaultConfiguration):
2163         (-[WK2WebDocumentController awakeFromNib]):
2164         (-[WK2WebDocumentController loadHTMLString:]):
2165         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2166         (-[WK2WebDocumentController dealloc]): Deleted.
2167         * WebEditingTester/WebDocumentController.h:
2168         * WebEditingTester/WebDocumentController.m:
2169         (-[WebDocumentController init]):
2170         (-[WebDocumentController initWithWindow:]):
2171         (+[WebDocumentController defaultEditingSource]):
2172         (-[WebDocumentController loadHTMLString:]):
2173         (-[WebDocumentController windowDidLoad]): Deleted.
2174         (-[WebDocumentController defaultEditingSource]): Deleted.
2175         (-[WebDocumentController applicationTerminating]): Deleted.
2176         (-[WebDocumentController loadContent]): Deleted.
2177
2178 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2179
2180         [WebEditingTester] ARC-ify WebEditingTester
2181         https://bugs.webkit.org/show_bug.cgi?id=141827
2182
2183         Reviewed by Sam Weinig.
2184
2185         * WebEditingTester/AppDelegate.m:
2186         (-[WebEditingAppDelegate showOperations:]):
2187         * WebEditingTester/EditingOperations.m:
2188         (editingOperations):
2189         * WebEditingTester/WK1WebDocumentController.m:
2190         (-[WK1WebDocumentController dealloc]): Deleted.
2191         * WebEditingTester/WK2WebDocumentController.m:
2192         (-[WK2WebDocumentController dealloc]): Deleted.
2193         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2194         Turn on ARC and remove a few retain/release/autorelease calls.
2195         We don't need to implement dealloc in either document controller
2196         because WebView and WKWebView's UIDelegate property does not hold a
2197         strong reference.
2198
2199 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2200
2201         [WebEditingTester] Factor out list of editing operations
2202         https://bugs.webkit.org/show_bug.cgi?id=141826
2203
2204         Reviewed by Sam Weinig.
2205
2206         * WebEditingTester/AppDelegate.m:
2207         (-[WebEditingAppDelegate showOperations:]):
2208         * WebEditingTester/EditingOperations.h: Added.
2209         * WebEditingTester/EditingOperations.m: Added.
2210         (editingOperations):
2211         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2212         Move EditingOperations array to its own file, and make it an NSArray
2213         instead of a C array. Adjust accordingly in showOperations:.
2214
2215 2015-02-20  Michael Saboff  <msaboff@apple.com>
2216
2217         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2218         https://bugs.webkit.org/show_bug.cgi?id=141676
2219
2220         Reviewed by Filip Pizlo.
2221
2222         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
2223         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
2224         large string expression that we want to eval.
2225
2226         * Scripts/run-jsc-stress-tests:
2227
2228 2015-02-19  Daniel Bates  <dabates@apple.com>
2229
2230         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2231         https://bugs.webkit.org/show_bug.cgi?id=141815
2232         <rdar://problem/19893933>
2233
2234         Reviewed by Simon Fraser.
2235
2236         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2237         was booted by iOS Simulator in a previous run of run-webkit-test.
2238
2239         * Scripts/webkitpy/port/ios.py:
2240         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2241         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2242         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2243
2244 2015-02-19  David Kilzer  <ddkilzer@apple.com>
2245
2246         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2247         <http://webkit.org/b/141799>
2248
2249         Reviewed by Alex Christensen.
2250
2251         * Scripts/webkitpy/style/checkers/cpp.py:
2252         (_IncludeState.check_next_include_order): Don't emit a warning
2253         if the primary header exists and the source file name ends with
2254         "SoftLink.cpp".  Add 'filename' argument to method.
2255         (check_include_line): Pass in 'filename'.
2256
2257         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2258         (OrderOfIncludesTest.test_check_next_include_order__no_config):
2259         (OrderOfIncludesTest.test_check_next_include_order__no_self):
2260         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2261         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2262         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2263         - Add test filename arguments for calls to
2264           check_next_include_order().
2265         (OrderOfIncludesTest.test_primary_header): Add test for a file
2266         name ending in "SoftLink.cpp".
2267
2268 2015-02-18  Enrica Casucci  <enrica@apple.com>
2269
2270         Add new tool to test editable Webviews.
2271         https://bugs.webkit.org/show_bug.cgi?id=141772
2272
2273         Reviewed by Tim Horton.
2274
2275         Adding WebEditingTester, a Cocoa application to
2276         test WK1 and Wk2 views in editable mode.
2277
2278         * WebEditingTester: Added.
2279         * WebEditingTester/AppDelegate.h: Added.
2280         * WebEditingTester/AppDelegate.m: Added.
2281         (-[WebEditingAppDelegate init]):
2282         (defaultConfiguration):
2283         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2284         (-[WebEditingAppDelegate applicationWillTerminate:]):
2285         (-[WebEditingAppDelegate newEditor:]):
2286         (-[WebEditingAppDelegate showOperations:]):
2287         (-[WebEditingAppDelegate useWebKit2ByDefault]):
2288         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2289         (-[WebEditingAppDelegate validateMenuItem:]):
2290         * WebEditingTester/Info.plist: Added.
2291         * WebEditingTester/MainMenu.xib: Added.
2292         * WebEditingTester/WK1WebDocumentController.h: Added.
2293         * WebEditingTester/WK1WebDocumentController.m: Added.
2294         (-[WK1WebDocumentController awakeFromNib]):
2295         (-[WK1WebDocumentController loadContent]):
2296         (-[WK1WebDocumentController dealloc]):
2297         (-[WK1WebDocumentController pasteAsMarkup:]):
2298         * WebEditingTester/WK2WebDocumentController.h: Added.
2299         * WebEditingTester/WK2WebDocumentController.m: Added.
2300         (-[WK2WebDocumentController initWithConfiguration:]):
2301         (-[WK2WebDocumentController pasteAsMarkup:]):
2302         (-[WK2WebDocumentController awakeFromNib]):
2303         (-[WK2WebDocumentController dealloc]):
2304         (-[WK2WebDocumentController loadContent]):
2305         * WebEditingTester/WebDocument.xib: Added.
2306         * WebEditingTester/WebDocumentController.h: Added.
2307         * WebEditingTester/WebDocumentController.m: Added.
2308         (-[WebDocumentController initWithWindow:]):
2309         (-[WebDocumentController windowDidLoad]):
2310         (-[WebDocumentController defaultEditingSource]):
2311         (-[WebDocumentController applicationTerminating]):
2312         (-[WebDocumentController loadContent]):
2313         * WebEditingTester/WebEditingTester.xcodeproj: Added.
2314         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2315         * WebEditingTester/main.m: Added.
2316         (main):
2317
2318 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
2319
2320         Run JSC tests on ARM EFL bots
2321         https://bugs.webkit.org/show_bug.cgi?id=141165
2322
2323         Reviewed by Alexey Proskuryakov.
2324
2325         * BuildSlaveSupport/build.webkit.org-config/config.json:
2326         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2327         (RunJavaScriptCoreTests.countFailures):
2328         (RunRemoteJavaScriptCoreTests):
2329         (RunRemoteJavaScriptCoreTests.start):
2330         (BuildAndRemoteJSCTestsFactory):
2331         (BuildAndRemoteJSCTestsFactory.__init__):
2332
2333 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
2334
2335         Streamline unexported function build fixes
2336         https://bugs.webkit.org/show_bug.cgi?id=141761
2337
2338         Reviewed by Alex Christensen.
2339
2340         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2341         We don't need to ignore symbols that are not exported due to the .unexp file.
2342
2343 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
2344
2345         Remove more references to WebCore.exp.in
2346         https://bugs.webkit.org/show_bug.cgi?id=141747
2347
2348         Reviewed by Alexey Proskuryakov.
2349
2350         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2351         (ShouldBuildTest):
2352
2353 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2354
2355         Windows test results should not fall back to mac-mountainlion after r180176
2356         https://bugs.webkit.org/show_bug.cgi?id=141719
2357
2358         Reviewed by Brent Fulgham.
2359
2360         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2361         (_should_file_trigger_build):
2362         * Scripts/webkitpy/port/win.py:
2363         (WinPort.default_baseline_search_path):
2364         * Scripts/webkitpy/port/win_unittest.py:
2365         (WinPortTest.test_baseline_search_path):
2366
2367 2015-02-17  Daniel Bates  <dabates@apple.com>
2368
2369         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2370         https://bugs.webkit.org/show_bug.cgi?id=141718
2371
2372         Reviewed by Alex Christensen.
2373
2374         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2375
2376         * Scripts/webkitpy/port/ios.py:
2377         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2378         Log a error and return False if we are unable to boot the simulator device so that the caller can take
2379         appropriate action, say exit(3) before running any layout tests.
2380         * Scripts/webkitpy/xcode/simulator.py:
2381         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2382         with the specified UDID.
2383         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2384         with the specified UDID can successfully boot and shut down. We make at most two attempts to
2385         boot and shut down the device, erasing the device between tries so as to restore the device
2386         to a known good state.
2387
2388 2015-02-17  Daniel Bates  <dabates@apple.com>
2389
2390         run_webkit_tests.py should not know about iOS Simulator details
2391         https://bugs.webkit.org/show_bug.cgi?id=141711
2392
2393         Reviewed by Alex Christensen.
2394
2395         Run_webkit_tests.py should only parse the iOS-specific command
2396         line options --runtime and --device-type. Let the port-specific
2397         logic in ios.py validate the parsed options and instantiate
2398         internal data structures.
2399
2400         Currently run_webkit_tests.py parses the iOS-specific command
2401         line options --runtime and --device-type, validates them, and
2402         instantiates internal data structures from the parsed strings.
2403         Instead the validation logic and instantiation of internal
2404         data structures should be handled by the iOS port object.
2405
2406         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2407         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2408         and instantiate internal data structures for them.
2409         * Scripts/webkitpy/port/driver.py:
2410         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2411         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2412         respectively.
2413         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2414         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2415         object from --runtime, if specified. Otherwise, instantiates a Runtime
2416         object for the latest installed iphonesimulator SDK version.
2417         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2418         object from --device-type, if specified. Otherwise, instantiates
2419         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2420         machine, respectively.
2421         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2422         runtime is available to use.
2423         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2424         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2425         * Scripts/webkitpy/xcode/simulator.py:
2426         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2427         with a runtime identifier for the specified iOS version.
2428
2429 2015-02-17  Dana Burkart  <dburkart@apple.com>
2430
2431         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2432         https://bugs.webkit.org/show_bug.cgi?id=141672
2433
2434         Reviewed by David Kilzer.
2435
2436         * asan/webkit-asan-ignore.txt:
2437
2438 2015-02-17  Alex Christensen  <achristensen@webkit.org>
2439
2440         Remove WebCore.exp.in and clean up.
2441         https://bugs.webkit.org/show_bug.cgi?id=141491
2442
2443         Reviewed by Andreas Kling.
2444
2445         * Scripts/sort-export-file: Removed.
2446         * Scripts/webkitpy/style/checker.py:
2447         (_all_categories):
2448         (FileType):
2449         (CheckerDispatcher._file_type):
2450         (CheckerDispatcher._create_checker):
2451         Don't check if the export files are sorted.
2452         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2453         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2454
2455 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2456
2457         Unreviewed. Fix GTK+ make distcheck.
2458
2459         Do not exclude bmalloc directory from the tarball.
2460
2461         * gtk/manifest.txt.in:
2462
2463 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2464
2465         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2466
2467         I forgot to add the return of a bool function.
2468
2469         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2470         (WebKitDOMNodeTest::testDOMCache):
2471
2472 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         [GTK] GObject DOM bindings object are cached forever
2475         https://bugs.webkit.org/show_bug.cgi?id=141558
2476
2477         Reviewed by Sergio Villar Senin.
2478
2479         Add checks for all DOM objects to ensure they are not leaked. Also
2480         add a dedicated test for the DOM Object Cache.
2481
2482         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2483         (WebKitDOMNodeFilterTest::testTreeWalker):
2484         (WebKitDOMNodeFilterTest::testNodeIterator):
2485         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2486         (WebKitDOMNodeTest::testHierarchyNavigation):
2487         (WebKitDOMNodeTest::testInsertion):
2488         (WebKitDOMNodeTest::testTagNames):
2489         (WebKitDOMNodeTest::testDOMCache):
2490         (registerTests):
2491         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2492         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2493         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2494         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2495         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2496         (testWebKitDOMObjectCache):
2497         (beforeAll):
2498         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2499         (documentLoadedCallback):
2500
2501 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2502
2503         [GTK] WebKitFrame objects are never released
2504         https://bugs.webkit.org/show_bug.cgi?id=141641
2505
2506         Reviewed by Martin Robinson.
2507
2508         Add a way to check GObjects leaks for WebProcess tests and check
2509         WebKitFrame objects are not leaked.
2510
2511         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2512         (WebKitFrameTest::testMainFrame):
2513         (WebKitFrameTest::testURI):
2514         (WebKitFrameTest::testJavaScriptContext):
2515         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2516         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2517         (runTest):
2518         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2519
2520 2015-02-16  Tim Horton  <timothy_horton@apple.com>
2521
2522         Fix the MiniBrowser build with newer clang
2523
2524         * MiniBrowser/mac/SettingsController.m:
2525         (-[SettingsController _toggleBooleanDefault:]):
2526         * MiniBrowser/mac/WK1BrowserWindowController.m:
2527         (-[WK1BrowserWindowController windowWillClose:]):
2528         * MiniBrowser/mac/WK2BrowserWindowController.m:
2529         (-[WK2BrowserWindowController windowWillClose:]):
2530         NSApp is id and clang gets confused about which -delegate we're talking about.
2531
2532 2015-02-16  Antti Koivisto  <antti@apple.com>
2533
2534         Develop/Disable Caches does not properly disable disk cache
2535         https://bugs.webkit.org/show_bug.cgi?id=141636
2536
2537         Reviewed by Anders Carlsson.
2538
2539         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2540         the network process too.
2541
2542         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2543
2544         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2545         (WTR::InjectedBundle::beginTesting):
2546         (WTR::InjectedBundle::setCacheModel):
2547         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2548         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2549
2550             Forward to TestController.
2551
2552         (WTR::TestRunner::setCacheModel):
2553         * WebKitTestRunner/TestInvocation.cpp:
2554         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2555
2556 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
2557
2558         Unreviewed. Add myself as a committer.
2559
2560         * Scripts/webkitpy/common/config/contributors.json:
2561
2562 2015-02-15  David Kilzer  <ddkilzer@apple.com>
2563
2564         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2565         <http://webkit.org/b/141607>
2566
2567         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2568         externals in Source/WebCore/Configurations/WebCore.unexp when
2569         building with Xcode 5.x.
2570         (readXcode5SymbolsToIgnore): Add.
2571
2572 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
2573
2574         [EFL] fix Evas GL engine error.
2575         https://bugs.webkit.org/show_bug.cgi?id=141621
2576
2577         Reviewed by Gyuyoung Kim.
2578
2579         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2580
2581         * MiniBrowser/efl/main.c:
2582         (elm_main):
2583
2584 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
2585
2586         [buildbot] Enable run-api-tests on release Mac bots
2587         https://bugs.webkit.org/show_bug.cgi?id=141518
2588
2589         Reviewed by Darin Adler.
2590
2591         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2592         (RunUnitTests):
2593         (BuildFactory.__init__):
2594         (TestFactory.__init__):
2595         (BuildAndTestFactory.__init__):
2596         (RunUnitTests.start): Deleted.
2597         (unitTestsSupported): Deleted.
2598
2599 2015-02-13  Anders Carlsson  <andersca@apple.com>
2600
2601         Add a move constructor and move assignment operator to Deque
2602         https://bugs.webkit.org/show_bug.cgi?id=141571
2603
2604         Reviewed by Andreas Kling.
2605
2606         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2607         (TestWebKitAPI::TEST):
2608
2609 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2610
2611         run-jsc-stress-tests --remote should skip profiler tests
2612         https://bugs.webkit.org/show_bug.cgi?id=141470
2613
2614         Reviewed by Filip Pizlo.
2615
2616         * Scripts/run-jsc-stress-tests:
2617
2618 2015-02-13  Anders Carlsson  <andersca@apple.com>
2619
2620         Add an initializer list constructor to Deque
2621         https://bugs.webkit.org/show_bug.cgi?id=141565
2622
2623         Reviewed by Andreas Kling.
2624
2625         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2626         (TestWebKitAPI::TEST):
2627
2628 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2629
2630         [buildbot] Remove buildJSCTool cruft from master.cfg
2631         https://bugs.webkit.org/show_bug.cgi?id=141513
2632
2633         Reviewed by Alexey Proskuryakov.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2636         (RunJavaScriptCoreTests):
2637         (RunJavaScriptCoreTests.start):
2638         (RunWebKitTests):
2639         (RunWebKitTests.start):
2640         (TestFactory.__init__):
2641         (TestLeaksFactory.__init__):
2642         (RunJavaScriptCoreTests.__init__): Deleted.
2643         (RunWebKitTests.__init__): Deleted.
2644
2645 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2646
2647         Unreviewed, remove empty directories.
2648
2649         * DumpRenderTree/gtk: Removed.
2650         * DumpRenderTree/gtk/fonts: Removed.
2651         * DumpRenderTree/unix: Removed.
2652         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2653         * GtkLauncher: Removed.
2654         * TestWebKitAPI/Tests/WebKitGtk: Removed.
2655         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2656         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2657         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2658
2659 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2660
2661         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2662         https://bugs.webkit.org/show_bug.cgi?id=141519
2663
2664         Reviewed by Alexey Proskuryakov.
2665
2666         * Scripts/build-webkittestrunner:
2667
2668 2015-02-12  Alex Christensen  <achristensen@webkit.org>
2669
2670         Removed empty directory.
2671
2672         * WinCELauncher: Removed.
2673
2674 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2675
2676         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2677         https://bugs.webkit.org/show_bug.cgi?id=141202
2678
2679         Reviewed by Darin Adler.
2680
2681         * Scripts/run-jsc-stress-tests:
2682
2683 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
2684
2685         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2686         https://bugs.webkit.org/show_bug.cgi?id=141517
2687
2688         Reviewed by Anders Carlsson.
2689
2690         We do not need to locate or use the DLL's that came with Safari, so stop
2691         failing when we cannot find them. Also remove some old Qt cruft from this
2692         script.
2693
2694         * BuildSlaveSupport/built-product-archive:
2695         (archiveBuiltProduct): 
2696         (extractBuiltProduct):
2697
2698 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
2699
2700         [Win] [64-bit] Work around MSVC2013 Runtime Bug
2701         https://bugs.webkit.org/show_bug.cgi?id=141498
2702         <rdar://problem/19803642>
2703
2704         Reviewed by Anders Carlsson.
2705
2706         Disable FMA3 instruction use in the MSVC math library to
2707         work around a VS2013 runtime crash. We can remove this
2708         workaround when we switch to VS2015.
2709
2710         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2711         disable FMA3 support.
2712         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2713         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2714         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2715         * Scripts/webkitperl/httpd.pm: Ditto.
2716         * TestWebKitAPI/win/main.cpp: Ditto.
2717         * WinLauncher/Common.cpp: Ditto.
2718         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2719
2720 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2721
2722         run-jsc-stress-tests should accept remote host config from JSON file
2723         https://bugs.webkit.org/show_bug.cgi?id=141509
2724
2725         Reviewed by Michael Saboff.
2726
2727         * Scripts/run-javascriptcore-tests:
2728         (runJSCStressTests):
2729         * Scripts/run-jsc-stress-tests:
2730
2731 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2732
2733         [GTK] Add API to allow overriding the default color chooser implementation
2734         https://bugs.webkit.org/show_bug.cgi?id=98935
2735
2736         Reviewed by Gustavo Noronha Silva.
2737
2738         Add a color chooser implementation for MiniBrowser using
2739         GtkPopover when the GTK+ version is recent enough.
2740         And a test case to check the new color chooser API.
2741
2742         * MiniBrowser/gtk/BrowserWindow.c:
2743         (colorChooserRGBAChanged):
2744         (popoverColorClosed):
2745         (colorChooserRequestFinished):
2746         (runColorChooserCallback):
2747         (browserWindowConstructed):
2748         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2749         (testWebViewColorChooserRequest):
2750         (beforeAll):
2751
2752 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2753
2754         Make run-jsc-stress-tests --remote work with make-based runner
2755         https://bugs.webkit.org/show_bug.cgi?id=141079
2756
2757         Reviewed by Darin Adler.
2758
2759         * Scripts/run-javascriptcore-tests:
2760         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2761         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2762         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2763         to avoid code duplication.
2764
2765 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2766
2767         run-jsc-stress tests should detect the number of processors on the remote machine too
2768         https://bugs.webkit.org/show_bug.cgi?id=141196
2769
2770         Reviewed by Darin Adler.
2771
2772         * Scripts/run-javascriptcore-tests:
2773         (runJSCStressTests): Pass through the --child-processes argument.
2774         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2775         to detect the number of local and remote processors with the same algorithm.
2776         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2777         same as $numProcessors.
2778
2779 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2780
2781         run-jsc-stress-tests should pass JSC_timeout to remote hosts
2782         https://bugs.webkit.org/show_bug.cgi?id=141164
2783
2784         Reviewed by Darin Adler.
2785
2786         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2787
2788         * Scripts/run-jsc-stress-tests:
2789
2790 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2791
2792         [GTK] Add default color chooser implementation using GtkColorChooserDialog
2793         https://bugs.webkit.org/show_bug.cgi?id=141392
2794
2795         Reviewed by Gustavo Noronha Silva.
2796
2797         Enable INPUT_TYPE_COLOR by default for GTK+ port.
2798
2799         * Scripts/webkitperl/FeatureList.pm:
2800
2801 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
2802
2803         run-jsc-stress-tests shell test runner should run tests in fixed order
2804         https://bugs.webkit.org/show_bug.cgi?id=141383
2805
2806         Reviewed by Darin Adler.
2807
2808         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2809
2810 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
2811
2812         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2813         https://bugs.webkit.org/show_bug.cgi?id=140485
2814
2815         Reviewed by Anders Carlsson.
2816
2817         Implement takeFocus() as a way to set focus through accessibility wrappers.
2818
2819         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2820         (AccessibilityUIElement::takeFocus):
2821         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2822         (WTR::AccessibilityUIElement::takeFocus):
2823
2824 2015-02-08  Darin Adler  <darin@apple.com>
2825
2826         Remove the SVG instance tree
2827         https://bugs.webkit.org/show_bug.cgi?id=140602
2828
2829         Reviewed by Dean Jackson.
2830
2831         * Scripts/check-for-global-initializers: Removed special case for
2832         SVGElementInstance.o.
2833
2834 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2835
2836         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2837         <http://webkit.org/b/141365>
2838
2839         Reviewed by Daniel Bates.
2840
2841         * Scripts/webkitpy/xcode/simulator.py:
2842         (Simulator): Add unavailable_version_re precompiled regex.
2843         (Simulator._parse_devices): Check for unavailable versions and
2844         ignore them if found when parsing the output of
2845         `xcrun simctl list`.
2846         * Scripts/webkitpy/xcode/simulator_unittest.py:
2847         (test_unavailable_devices): Add test with output from
2848         `xcrun simctl list` with unavailable runtimes that fails before
2849         the fix.
2850
2851 2015-02-07  Chris Dumez  <cdumez@apple.com>
2852
2853         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2854         https://bugs.webkit.org/show_bug.cgi?id=141321
2855
2856         Reviewed by Darin Adler.
2857
2858         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2859
2860 2015-02-07  David Kilzer  <ddkilzer@apple.com>
2861
2862         [iOS] Make Simulator class testable
2863         <http://webkit.org/b/141358>
2864
2865         Rubber-stamped by Darin Adler.
2866
2867         * Scripts/webkitpy/common/system/platforminfo.py:
2868         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2869         command to here from Simulator.refresh() in xcode/simulator.py
2870         so that the output of the command can be mocked.
2871
2872         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2873         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2874         to None.
2875         (MockPlatformInfo.xcode_simctl_list): Add method that returns
2876         self.expected_xcode_simctl_list expectation.
2877
2878         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2879         and license header.
2880         (Simulator.__init__): Add optional 'host' parameter to make it
2881         possible to pass in a mock object for testing.  Set self._host
2882         to 'host' parameter or create Host() object.
2883         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2884         method.
2885
2886         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2887         for current code.
2888         (SimulatorTest):
2889         (SimulatorTest.setUp):
2890         (SimulatorTest._set_expected_xcrun_simctl_list):
2891         (SimulatorTest.test_simulator_device_types):
2892         (test_invalid_device_types_header):
2893         (test_invalid_runtimes_header):
2894         (test_invalid_devices_header):
2895
2896 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
2897
2898         run-jsc-stress-tests --remote should use the default ssh port
2899         https://bugs.webkit.org/show_bug.cgi?id=141287
2900
2901         Reviewed by Darin Adler.
2902
2903         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2904
2905 2015-02-06  Dana Burkart  <dburkart@apple.com>
2906
2907         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2908         https://bugs.webkit.org/show_bug.cgi?id=141349
2909
2910         Reviewed by Alexey Proskuryakov.
2911
2912         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2913         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2914         (BuildbotTesterQueueView.prototype.update):
2915
2916 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
2917
2918         Report network process crashes during layout tests
2919         https://bugs.webkit.org/show_bug.cgi?id=139646
2920
2921         Reviewed by Anders Carlsson.
2922
2923         * WebKitTestRunner/TestController.cpp:
2924         (WTR::TestController::initialize):
2925         (WTR::TestController::networkProcessName):
2926         (WTR::TestController::networkProcessDidCrash):
2927         * WebKitTestRunner/TestController.h:
2928
2929 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
2930
2931         run-jsc-stress-tests --remote should create remote directory before copying the bundle
2932         https://bugs.webkit.org/show_bug.cgi?id=141329
2933
2934         Reviewed by Michael Saboff.
2935
2936         * Scripts/run-jsc-stress-tests:
2937
2938 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2939
2940         [GTK] Remove WebKitWebView::close-notification signal
2941         https://bugs.webkit.org/show_bug.cgi?id=141330
2942
2943         Reviewed by Gustavo Noronha Silva.
2944
2945         Update notifications unit tests according to the API changes, and
2946         add a test case to check that onclose event is fired when a
2947         notification is closed by the user.
2948
2949         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2950         (testWebViewNotification):
2951
2952 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
2953
2954         Dashboard doesn't consider building ASan a productive step
2955         https://bugs.webkit.org/show_bug.cgi?id=141312
2956
2957         Reviewed by Simon Fraser.
2958
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2960
2961 2015-02-05  Daniel Bates  <dabates@apple.com>
2962
2963         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2964         https://bugs.webkit.org/show_bug.cgi?id=141306
2965
2966         Reviewed by Alexey Proskuryakov.
2967
2968         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2969         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2970         existent runtime.
2971
2972         * Scripts/webkitpy/xcode/simulator.py:
2973         (Runtime.from_identifier):
2974
2975 2015-02-05  Daniel Bates  <dabates@apple.com>
2976
2977         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2978         https://bugs.webkit.org/show_bug.cgi?id=139746
2979         <rdar://problem/19283658>
2980
2981         Reviewed by Alexey Proskuryakov.
2982
2983         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2984         if the simulator device is not in state Booted.
2985
2986         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2987         launching/relaunching the iOS Simulator app and a simulator app can only be installed
2988         on a device that is in the Booted state. LayoutTestRelay may run before the
2989         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
2990         We should defer executing LayoutTestRelay until the simulator device booted by
2991         iOS Simulator is in the Booted state.
2992
2993         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
2994         Simulator methods with the module name, simulator.
2995         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
2996         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
2997         before launching iOS Simulator to boot it.
2998         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
2999         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
3000         * Scripts/webkitpy/xcode/simulator.py:
3001         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
3002         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
3003         interested in the state of the device are more likely interested in the current state of the device as
3004         opposed to the state of the device when the Device object was created.
3005         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
3006         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
3007         from both this function and Simulator.device_state().
3008         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
3009         (Simulator.DeviceState): Added; class of constants.
3010         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
3011         device is in the specified state.
3012         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
3013         (Simulator.device_directory): Added.
3014         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
3015
3016 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3017
3018         Disable retries on Mac debug testers
3019         https://bugs.webkit.org/show_bug.cgi?id=141296
3020
3021         Reviewed by Simon Fraser.
3022
3023         * BuildSlaveSupport/build.webkit.org-config/config.json:
3024
3025 2015-02-05  Dan Bernstein  <mitz@apple.com>
3026
3027         Need a way to force $xcodeSDK in webkitdirs.pm
3028         https://bugs.webkit.org/show_bug.cgi?id=141291
3029
3030         Reviewed by Anders Carlsson.
3031
3032         * Scripts/webkitdirs.pm:
3033         (setXcodeSDK): Added.
3034
3035 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
3036
3037         [Streams API] Implement a barebone ReadableStream interface
3038         https://bugs.webkit.org/show_bug.cgi?id=141045
3039
3040         Reviewed by Benjamin Poulain.
3041
3042         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
3043
3044 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
3045
3046         filter-build-webkit: reduce more unfiltered output
3047         https://bugs.webkit.org/show_bug.cgi?id=141282
3048
3049         Reviewed by Daniel Bates.
3050
3051         * Scripts/filter-build-webkit:
3052         Report CompileDTraceScript and Preprocess lines as successful.
3053
3054 2015-02-04  Dana Burkart  <dburkart@apple.com>
3055
3056         Botwatcher's Dashboard is cramped
3057         https://bugs.webkit.org/show_bug.cgi?id=140273
3058
3059         Reviewed by Alexey Proskuryakov.
3060
3061         Add a heading key which will allow for arbitrary headings in builder queues.
3062
3063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3064         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3065         (BuildbotBuilderQueueView.prototype.update):
3066         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3068         (BuildbotIteration.prototype._parseData):
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3070         (BuildbotLeaksQueueView.prototype.update):
3071         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3073         (BuildbotPerformanceQueueView.prototype.update):
3074         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3076         (BuildbotQueue):
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3078         (BuildbotQueueView.prototype._unauthorizedAccess):
3079         (BuildbotQueueView.prototype._appendBuild):
3080         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3081         (BuildbotTestResults):
3082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3083         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3084         (BuildbotTesterQueueView.prototype.update):
3085         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
3086
3087 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
3088
3089         WKTR should not use -mainScreen to pick a color profile
3090         https://bugs.webkit.org/show_bug.cgi?id=141265
3091
3092         Reviewed by Tim Horton.
3093         
3094         -[NSScreen mainScreen] depends on the active window, so use the first screen
3095         (which is the one we put the window on anyway).
3096         
3097         Do some cleanup in DRT that makes the code look similar.
3098
3099         * DumpRenderTree/mac/DumpRenderTree.mm:
3100         (createWebViewAndOffscreenWindow):
3101         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3102         (WTR::PlatformWebView::PlatformWebView):
3103
3104 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
3105
3106         LayoutTestHelper should set the color profile of all displays
3107         https://bugs.webkit.org/show_bug.cgi?id=141260
3108
3109         Reviewed by Tim Horton.
3110         
3111         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
3112         which is the screen with the active window. Make things more robust by changing
3113         the colorspace of all displays, not just the main screen, when running layout tests.
3114
3115         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
3116         * DumpRenderTree/mac/LayoutTestHelper.m: 
3117         (originalColorProfileURLs):
3118         (colorProfileURLForDisplay):
3119         (displayUUIDStrings):
3120         (saveDisplayColorProfiles):
3121         (setDisplayColorProfile):
3122         (restoreDisplayColorProfiles):
3123         (installLayoutTestColorProfile):
3124         (restoreUserColorProfile):
3125         (main):        
3126         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
3127         toll-free bridged, sadly). Use the map to restore all profiles on exit.
3128         Convert to use more Obj-C types.
3129
3130 2015-02-04  Daniel Bates  <dabates@apple.com>
3131
3132         test-webkitpy fails on Mac without iphoneos SDK
3133         https://bugs.webkit.org/show_bug.cgi?id=141255
3134         <rdar://problem/19619691>
3135
3136         I inadvertently committed the wrong exception message. Fix up the exception message
3137         to instruct a person to install the iOS SDK when it cannot be found.
3138
3139         * Scripts/webkitpy/port/ios.py:
3140         (IOSPort.determine_full_port_name):
3141
3142 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3143
3144         W3C test importer should sort the list of files when generating the w3c-import.log
3145         https://bugs.webkit.org/show_bug.cgi?id=141156
3146
3147         Reviewed by Bem Jones-Bey.
3148
3149         Sort explicitly the list of imported files written in the w3c-import.log.
3150         Removed logging of the import date.
3151
3152         * Scripts/webkitpy/w3c/test_importer.py:
3153         (TestImporter.write_import_log):
3154
3155 2015-02-04  Daniel Bates  <dabates@apple.com>
3156
3157         test-webkitpy fails on Mac without iphoneos SDK
3158         https://bugs.webkit.org/show_bug.cgi?id=141255
3159         <rdar://problem/19619691>
3160
3161         Reviewed by David Kilzer and Alexey Proskuryakov.
3162
3163         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
3164         should not require the iphoneos SDK to be installed to run the webkitpy tests.
3165
3166         * Scripts/webkitpy/common/system/platforminfo.py:
3167         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
3168         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
3169         to standard output if the SDK is installed to return the empty string if the SDK is
3170         not installed.
3171         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3172         (MockPlatformInfo.xcode_sdk_version): Added.
3173         * Scripts/webkitpy/port/ios.py:
3174         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
3175         to get the version of the iphoneos SDK, if installed.
3176
3177 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3178
3179         run-webkit-tests doesn't always capture ASan violation reports
3180         https://bugs.webkit.org/show_bug.cgi?id=141231
3181
3182         Reviewed by Darin Adler.
3183
3184         * Scripts/webkitpy/port/driver.py:
3185         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
3186         by the driver already (as is the case with ASan violations, which are printed to
3187         stderr).
3188         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
3189         report.
3190         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
3191         a separate variable for reporting.
3192
3193 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3194
3195         [webkitpy] Add platform specific Skipped file mechanism for performance tests
3196         https://bugs.webkit.org/show_bug.cgi?id=141152
3197
3198         Reviewed by Csaba Osztrogonác.
3199
3200         Support a test-expectation-like syntax in performance tests' skipped files.
3201         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
3202
3203         * Scripts/webkitpy/port/base.py:
3204         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
3205
3206         * Scripts/webkitpy/port/base_unittest.py:
3207         (PortTest.test_skipped_perf_tests): Test the new syntax.
3208
3209 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3210
3211         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
3212         https://bugs.webkit.org/show_bug.cgi?id=141236
3213
3214         Reviewed by Sam Weinig.
3215
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3217         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
3218
3219 2015-02-04  Chris Dumez  <cdumez@apple.com>
3220
3221         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
3222         https://bugs.webkit.org/show_bug.cgi?id=141192
3223
3224         Reviewed by Benjamin Poulain.
3225
3226         Add API tests for Vector::removeFirst(value) and
3227         Vector::removeAll(value).
3228
3229         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3230         (TestWebKitAPI::TEST):
3231
3232 2015-02-03  Tim Horton  <timothy_horton@apple.com>
3233
3234         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3235         https://bugs.webkit.org/show_bug.cgi?id=141217
3236
3237         Reviewed by Sam Weinig.
3238
3239         * WebKitTestRunner/TestController.cpp:
3240         (WTR::copyWebCryptoMasterKey):
3241         (WTR::TestController::createOtherPage):
3242         (WTR::TestController::createWebViewWithOptions):
3243         (WTR::TestController::ensureViewSupportsOptions):
3244         (WTR::TestController::didCommitNavigation):
3245         (WTR::TestController::didFinishNavigation):
3246         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3247         (WTR::TestController::didReceiveAuthenticationChallenge):
3248         (WTR::TestController::decidePolicyForPluginLoad):
3249         (WTR::TestController::decidePolicyForNavigationAction):
3250         (WTR::TestController::decidePolicyForNavigationResponse):
3251         (WTR::TestController::didCommitLoadForFrame): Deleted.
3252         (WTR::TestController::didFinishLoadForFrame): Deleted.
3253         * WebKitTestRunner/TestController.h:
3254         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3255
3256 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
3257
3258         Unreviewed. Add myself as a committer.
3259
3260         * Scripts/webkitpy/common/config/contributors.json:
3261
3262 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3263
3264         [Win] Unreviewed test fix.
3265
3266         * DumpRenderTree/win/PolicyDelegate.cpp:
3267         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3268         so was not matching expected output.
3269
3270 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3271
3272         Unreviewed. Moving myself to the committer section at last.
3273
3274         * Scripts/webkitpy/common/config/contributors.json:
3275
3276 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3277
3278         [Win] Tests fail because DRT reports '(null)' instead of an empty string
3279         https://bugs.webkit.org/show_bug.cgi?id=141205
3280
3281         Reviewed by Anders Carlsson.
3282
3283         * DumpRenderTree/win/HistoryDelegate.cpp:
3284         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3285         properly so that we match expected DumpRenderTree output.
3286
3287 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3288
3289         [GTK] TestWebKitAccessibility is not skipped
3290         https://bugs.webkit.org/show_bug.cgi?id=141179
3291
3292         Reviewed by Carlos Garcia Campos.
3293
3294         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3295         skipped, and it apparently works reliably on the bots.
3296
3297         * Scripts/run-gtk-tests:
3298         (TestRunner):
3299
3300 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3301
3302         run-perf-tests: allow to specify a wrapper command.
3303         https://bugs.webkit.org/show_bug.cgi?id=141172
3304
3305         Reviewed by Ryosuke Niwa.
3306
3307         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3308         (parse_args): Update text to indicate is also valid for WTR.
3309         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3310         (PerfTestsRunner._parse_args): Add wrapper command.
3311
3312 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3313
3314         [Win] Correct version parsing warning in update-webkit
3315         https://bugs.webkit.org/show_bug.cgi?id=141200
3316
3317         Reviewed by Anders Carlsson.
3318
3319         * Scripts/webkitdirs.pm:
3320         (setupAppleWinEnv): Strip out any specific version build level
3321         from the Cygwin version information.
3322   
3323
3324 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3325
3326         [Win] Attempt to improve the reliability of HTTP service
3327         https://bugs.webkit.org/show_bug.cgi?id=141191
3328
3329         Reviewed by Darin Adler.
3330
3331         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3332         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3333         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3334         when stopping the service doesn't do so on its own (for Windows runs).
3335
3336 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3337
3338         Web platform test server should not need to create __init__.py files
3339         https://bugs.webkit.org/show_bug.cgi?id=141030
3340
3341         Reviewed by Ryosuke Niwa.
3342
3343         W3C TestImporter ensures that copied __init__.py files are not empty.
3344         If needed, a comment is inserted in __init__.py files.
3345         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3346
3347         * Scripts/webkitpy/common/system/filesystem.py:
3348         (FileSystem.getsize):
3349         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3350         (TestWebPlatformTestServer.test_start_cmd):
3351         (TestWebPlatformTestServer):
3352         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3353         * Scripts/webkitpy/w3c/test_importer.py:
3354         (TestImporter.import_tests):
3355
3356 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3357
3358         Unreviewed. Moving myself to the committer section.
3359
3360         * Scripts/webkitpy/common/config/contributors.json:
3361
3362 2015-02-02  Saam Barati  <saambarati1@gmail.com>
3363
3364         Create tests for JSC's Control Flow Profiler
3365         https://bugs.webkit.org/show_bug.cgi?id=141123
3366
3367         Reviewed by Filip Pizlo.
3368
3369         * Scripts/run-javascriptcore-tests:
3370         (runJSCStressTests):
3371         * Scripts/run-jsc-stress-tests:
3372
3373 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
3374
3375         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3376         https://bugs.webkit.org/show_bug.cgi?id=141158
3377
3378         Reviewed by Darin Adler.
3379
3380         * Scripts/run-jsc-stress-tests:
3381
3382 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3383
3384         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3385         https://bugs.webkit.org/show_bug.cgi?id=141142
3386
3387         Reviewed by Carlos Garcia Campos.
3388
3389         * MiniBrowser/gtk/BrowserWindow.c:
3390         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3391
3392 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3393
3394         Web platform test server is not always launching properly on Mac EWS bots
3395         https://bugs.webkit.org/show_bug.cgi?id=141141
3396
3397         Unreviewed.
3398
3399         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3400         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3401
3402 2015-01-31  Sam Weinig  <sam@webkit.org>
3403
3404         Remove even more Mountain Lion support
3405         https://bugs.webkit.org/show_bug.cgi?id=141124
3406
3407         Reviewed by Alexey Proskuryakov.
3408
3409         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3410         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3411         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3412         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3413         * DumpRenderTree/mac/DumpRenderTree.mm:
3414         (activateTestingFonts):
3415         (prepareConsistentTestingEnvironment):
3416         * DumpRenderTree/mac/EventSendingController.mm:
3417         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3418         (-[EventSendingController contextClick]):
3419         * DumpRenderTree/mac/TextInputController.m:
3420         * LayoutTestRelay/Configurations/Base.xcconfig:
3421         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3422         * MiniBrowser/Configurations/Base.xcconfig:
3423         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3424         * MiniBrowser/mac/WK2BrowserWindowController.m:
3425         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3426         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3427         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3428         * TestWebKitAPI/Configurations/Base.xcconfig:
3429         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3430         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3431         (-[DownloadDelegate _downloadDidFinish:]):
3432         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3433         (TestWebKitAPI::TEST):
3434         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3435         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3436         * WebKitLauncher/Configurations/Base.xcconfig:
3437         * WebKitTestRunner/Configurations/Base.xcconfig:
3438         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3439         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3440         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3441         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3442         (WTR::activateFonts):
3443         * WebKitTestRunner/TestController.cpp:
3444         (WTR::TestController::initialize):
3445         (WTR::TestController::webProcessName):
3446         * WebKitTestRunner/mac/EventSenderProxy.mm:
3447         * asan/asan.xcconfig:
3448
3449 2015-01-31  Commit Queue  <commit-queue@webkit.org>
3450
3451         Unreviewed, rolling out r179408.
3452         https://bugs.webkit.org/show_bug.cgi?id=141117
3453
3454         This didn't fully fix the issue (Requested by anttik on
3455         #webkit).
3456
3457         Reverted changeset:
3458
3459         "OSObjectPtr does not work with dispatch_data_t on Maverics"
3460         https://bugs.webkit.org/show_bug.cgi?id=141081
3461         http://trac.webkit.org/changeset/179408
3462
3463 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3464
3465         https://trac.webkit.org/changeset/179439 breaks a python test
3466         https://bugs.webkit.org/show_bug.cgi?id=141114
3467
3468         Unreviewed.
3469
3470         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3471         (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.  
3472
3473 2015-01-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3474
3475         Import W3C web platform tests infrastructure
3476         https://bugs.webkit.org/show_bug.cgi?id=140934
3477
3478         Reviewed by Ryosuke Niwa.
3479
3480         Loading necessary web platform tests modules before launching server.
3481         Ensuring that some empty __init__.py files are present and create them if necessary. 
3482
3483         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3484         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3485
3486 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3487
3488         [Win] Another unreviewed test fix.
3489
3490         Correct copy/paste error in buildbot handling.
3491
3492         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3493         (LayoutTestApacheHttpd.__init__):
3494         (LayoutTestApacheHttpd._get_apache_config_file_path):
3495
3496 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3497
3498         [Win] Unreviewed test fix.
3499
3500         Correct path handling based on failures on test bots to get things running again.
3501
3502         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3503         (LayoutTestApacheHttpd.__init__):
3504         (LayoutTestApacheHttpd._get_apache_config_file_path):
3505
3506 2015-01-30  Chris Dumez  <cdumez@apple.com>
3507
3508         Unreviewed. Fix Windows build after r179409.
3509
3510         * DumpRenderTree/win/TestRunnerWin.cpp:
3511         (TestRunner::notifyDone):
3512         (TestRunner::queueLoad):
3513
3514 2015-01-30  Chris Dumez  <cdumez@apple.com>
3515
3516         Rename shared() static member functions to singleton() for singleton classes.
3517         https://bugs.webkit.org/show_bug.cgi?id=141088
3518
3519         Reviewed by Ryosuke Niwa and Benjamin Poulain.
3520
3521         Rename shared() static member functions to singleton() for singleton
3522         classes as per the recent coding style change.
3523
3524 2015-01-30  Antti Koivisto  <antti@apple.com>
3525
3526         OSObjectPtr does not work with dispatch_data_t on Maverics
3527         https://bugs.webkit.org/show_bug.cgi?id=141081
3528
3529         Reviewed by Pratik Solanki.
3530
3531         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
3532         (TestWebKitAPI::TEST):
3533
3534 2015-01-30  Brent Fulgham  <bfulgham@apple.com>
3535
3536         [Win] Switch to Apache on Windows
3537         https://bugs.webkit.org/show_bug.cgi?id=141060
3538
3539         Reviewed by Alexey Proskuryakov.
3540
3541         Update our scripts under Windows (and Cygwin) to locate and use
3542         the XAMPP installation of Apache for running tests.
3543
3544         * Scripts/run-webkit-httpd:
3545         * Scripts/webkitperl/httpd.pm:
3546         (getHTTPDPath):
3547         (getDefaultConfigForTestDirectory):
3548         (getHTTPDConfigPathForTestDirectory):
3549         * Scripts/webkitpy/common/system/executive_unittest.py:
3550         (ExecutiveTest.serial_test_kill_process):
3551         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3552         (LayoutTestApacheHttpd.__init__):
3553         (LayoutTestApacheHttpd._get_apache_config_file_path):
3554         (LayoutTestApacheHttpd._stop_running_server):
3555         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3556         (HttpServerBase._is_server_running_on_all_ports):
3557         * Scripts/webkitpy/port/base.py:
3558         (Port._apache_config_file_name_for_platform):
3559         * Scripts/webkitpy/port/port_testcase.py:
3560         (test_apache_config_file_name_for_platform):
3561         * Scripts/webkitpy/port/win.py:
3562         (WinPort.show_results_html_file):
3563         (WinPort._uses_apache):
3564         (WinPort):
3565         (WinPort._path_to_apache):
3566
3567 2015-01-29  Alexey Proskuryakov  <ap@apple.com>
3568
3569         Built result takes too long to be compressed on bots
3570         https://bugs.webkit.org/show_bug.cgi?id=141056
3571
3572         Reviewed by Daniel Bates.
3573
3574         Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
3575
3576         * BuildSlaveSupport/test-result-archive: (archiveTestResults):
3577
3578 2015-01-29  Sam Weinig  <sam@webkit.org>
3579
3580         Remove support for screen font substitution
3581         https://bugs.webkit.org/show_bug.cgi?id=141038
3582
3583         Reviewed by Tim Horton.
3584
3585         * DumpRenderTree/win/DumpRenderTree.cpp:
3586         (resetWebPreferencesToConsistentValues):
3587         Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
3588
3589 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3590
3591         Make run-jsc-stress-tests --remote work on Linux too
3592         https://bugs.webkit.org/show_bug.cgi?id=141000
3593
3594         Reviewed by Darin Adler.
3595
3596         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
3597         use bash/dash compatible signal names, use Linux/Mac compatible find options,
3598         use bash/dash compatible functions.
3599         * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
3600
3601 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3602
3603         [buildbot] Simplify jscore-test buildstep
3604         https://bugs.webkit.org/show_bug.cgi?id=140821
3605
3606         Reviewed by Alexey Proskuryakov.
3607
3608         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3609         (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
3610         (RunJavaScriptCoreTests.countFailures): Added.
3611         (RunJavaScriptCoreTests.commandComplete): Deleted.
3612         (RunJavaScriptCoreTests.evaluateCommand): Deleted.
3613         (RunJavaScriptCoreTests.getText): Deleted.
3614         (RunJavaScriptCoreTests.getText2): Deleted.
3615         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
3616         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3617         (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
3618         (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3619         (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
3620
3621 2015-01-29  Csaba Osztrogonác  <ossy@webkit.org>
3622
3623         Unreviewed, revert r179337, we don't need this dependency.
3624
3625         * efl/install-dependencies:
3626         * gtk/install-dependencies:
3627
3628 2015-01-28  Shivakumar JM  <shiva.jm@samsung.com>
3629
3630         Unreviewed. Moving myself to the committer section.
3631
3632         * Scripts/webkitpy/common/config/contributors.json:
3633
3634 2015-01-28  Csaba Osztrogonác  <ossy@webkit.org>
3635
3636         URTBF after r179326, added uuid-dev package as new dependency.
3637
3638         * efl/install-dependencies:
3639         * gtk/install-dependencies:
3640
3641 2015-01-28  Timothy Horton  <timothy_horton@apple.com>
3642
3643         Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
3644         https://bugs.webkit.org/show_bug.cgi?id=140673
3645
3646         Reviewed by Sam Weinig.
3647
3648         * Scripts/dtrace/trace-webkit2-messages.d: Added.
3649         Add a DTrace script that outputs a small blob of JSON per message.
3650
3651 2015-01-28  Geoffrey Garen  <ggaren@apple.com>
3652
3653         Removed fastMallocForbid / fastMallocAllow
3654         https://bugs.webkit.org/show_bug.cgi?id=141012
3655
3656         Reviewed by Mark Hahnenberg.
3657
3658         Fixed a test bug I noticed while testing.
3659
3660         * DumpRenderTree/JavaScriptThreading.cpp:
3661         (stopJavaScriptThreads): Lock the javaScriptThreads lock before
3662         accessing javaScriptThreads -- otherwise, you'll ASSERT.
3663
3664 2015-01-28  Dana Burkart  <dburkart@apple.com>
3665
3666         asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
3667         https://bugs.webkit.org/show_bug.cgi?id=141015
3668
3669         Reviewed by Alexey Proskuryakov.
3670
3671         * asan/asan.xcconfig:
3672
3673 2015-01-28  Sam Weinig  <sam@webkit.org>
3674
3675         Fix the build.
3676
3677         * Scripts/copy-webkitlibraries-to-product-directory:
3678
3679 2015-01-28  Lucas Forschler  <lforschler@apple.com>
3680
3681         Increase the FileUpload block size in an attempt to improve network performance.
3682         
3683         Reviewed by Alexey Proskuryakov.
3684         
3685         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3686         (UploadBuiltProduct.__init__):
3687
3688 2015-01-28  Dana Burkart  <dburkart@apple.com>
3689
3690         Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
3691         https://bugs.webkit.org/show_bug.cgi?id=136765
3692
3693         Reviewed by Alexey Proskuryakov.
3694
3695         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3696         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3697         * LayoutTestRelay/Configurations/Base.xcconfig:
3698         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3699         * MiniBrowser/Configurations/Base.xcconfig:
3700         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3701         * TestWebKitAPI/Configurations/Base.xcconfig:
3702         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3703         * WebKitLauncher/Configurations/Base.xcconfig:
3704         * WebKitTestRunner/Configurations/Base.xcconfig:
3705         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3706
3707 2015-01-28  Joanmarie Diggs  <jdiggs@igalia.com>
3708
3709         AX: [ATK] Implement support for new AtkRole types for MathML
3710         https://bugs.webkit.org/show_bug.cgi?id=140916
3711
3712         Reviewed by Chris Fleizach.
3713
3714         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
3715         * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
3716
3717 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3718
3719         [GTK] Stop removing color marks from unit tests output
3720         https://bugs.webkit.org/show_bug.cgi?id=140996
3721
3722         Reviewed by Philippe Normand.
3723
3724         Since r178236 google tests use a custom simplified output without
3725         any colors, so we don't need to handle the case of non ttys to
3726         remove the color marks.
3727
3728         * Scripts/run-gtk-tests:
3729         (TestRunner.__init__):
3730         (TestRunner._run_test_command.parse_line):
3731
3732 2015-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3733
3734         [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
3735         https://bugs.webkit.org/show_bug.cgi?id=131731
3736
3737         Reviewed by Žan Doberšek.
3738
3739         A web page loaded offscreen is in prerender state not hidden.
3740
3741         * Scripts/run-gtk-tests:
3742         (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
3743         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3744         (testWebViewPageVisibility):
3745
3746 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3747
3748         Partially revert r178802.
3749
3750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
3751         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
3752
3753 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3754
3755         build.webkit.org/dashboard asserts on some commits
3756         https://bugs.webkit.org/show_bug.cgi?id=140926
3757
3758         Reviewed by Tim Horton.
3759
3760         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3761         (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
3762
3763 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3764
3765         Make flakiness dashboard OS list actually match test_expectations.py
3766         https://bugs.webkit.org/show_bug.cgi?id=140969
3767
3768         Reviewed by Ryosuke Niwa.
3769
3770         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3771
3772 2015-01-27  Brent Fulgham  <bfulgham@apple.com>
3773
3774         [Win] WinLauncher crashes on eleventh site visited
3775         https://bugs.webkit.org/show_bug.cgi?id=140960
3776
3777         Reviewed by Anders Carlsson.
3778
3779         * WinLauncher/WinLauncher.cpp:
3780         (WinLauncher::showLastVisitedSites): Don't access off the end of
3781         the history array.
3782
3783 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3784
3785         [Mac] Disable building Java applets by default
3786         https://bugs.webkit.org/show_bug.cgi?id=140957
3787         rdar://problem/19619529
3788
3789         Reviewed by Anders Carlsson.
3790
3791         It was actually already disabled unconditionally, by accident.
3792
3793         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3794         * Scripts/webkitpy/port/mac.py:
3795         (MacPort._check_port_build):
3796         (MacPort._build_java_test_support):
3797
3798 2015-01-27  Daniel Bates  <dabates@apple.com>
3799
3800         [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3801         https://bugs.webkit.org/show_bug.cgi?id=140949
3802
3803         Reviewed by Alexey Proskuryakov.
3804
3805         Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3806         builders so that run-webkit-tests can lint the appropriate TestExpectation
3807         files.
3808
3809         * Scripts/webkitpy/port/builders.py:
3810         * Scripts/webkitpy/port/ios.py:
3811         (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3812         (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3813         information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3814         in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3815         will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3816         to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3817         test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3818
3819
3820 2015-01-27  Alexey Proskuryakov  <ap@apple.com>
3821
3822         Update bots on the flakiness dashboard
3823         https://bugs.webkit.org/show_bug.cgi?id=140956
3824
3825         Reviewed by Ryosuke Niwa.
3826
3827         * TestResultServer/static-dashboards/builders.jsonp:
3828         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3829
3830 2015-01-27  Daniel Bates  <dabates@apple.com>
3831
3832         [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3833         https://bugs.webkit.org/show_bug.cgi?id=140942
3834
3835         Reviewed by Alexey Proskuryakov.
3836
3837         The directory LayoutTests/platform/wk2 contains test expectations and test results that
3838         are applicable to all WebKit2 ports. We should make use of this information when
3839         running layout tests using iOS WebKit2.
3840
3841         Additionally, make use of the convenience function Port._wk2_port_name() for the name
3842         of the WebKit2 port instead of directly using string concatenation.
3843
3844         * Scripts/webkitpy/port/ios.py:
3845         (IOSSimulatorPort.default_baseline_search_path):
3846
3847 2015-01-27  Csaba Osztrogonác  <ossy@webkit.org>
3848
3849         [Win] Disable FTL stress tests
3850         https://bugs.webkit.org/show_bug.cgi?id=140932
3851
3852         Reviewed by Brent Fulgham.
3853
3854         * Scripts/run-javascriptcore-tests:
3855
3856 2015-01-27  Daniel Bates  <dabates@apple.com>
3857
3858         REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3859         https://bugs.webkit.org/show_bug.cgi?id=140939
3860
3861         Reviewed by Eric Carlson.
3862
3863         Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3864
3865         * Scripts/webkitdirs.pm:
3866         (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3867         of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3868         and define a function called wanted.
3869
3870 2015-01-27  Daniel Bates  <dabates@apple.com>
3871
3872         Teach run-webkit-app --simulator how to install custom built app
3873         https://bugs.webkit.org/show_bug.cgi?id=140691
3874
3875         Fix inadvertent omission of directory test flag in expression to check for the
3876         existence of the iOS simulator device-specific directory for user installed apps.
3877
3878         * Scripts/webkitdirs.pm:
3879         (hasUserInstalledAppInSimulatorDevice):
3880
3881 2015-01-26  Brent Fulgham  <bfulgham@apple.com>
3882
3883         [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3884         https://bugs.webkit.org/show_bug.cgi?id=87426
3885         <rdar://problem/11527899>
3886
3887         Reviewed by Darin Adler.
3888
3889         Revise COMPtr to work better with our HashMap implementation. Use
3890         modern loop syntax.
3891
3892         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3893         (AccessibilityController::~AccessibilityController):
3894         (AccessibilityController::winNotificationReceived):
3895         * DumpRenderTree/win/DumpRenderTree.cpp:
3896         (dumpBackForwardListForAllWindows):
3897
3898 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
3899
3900         [Win] Enable JSC stress tests by default
3901         https://bugs.webkit.org/show_bug.cgi?id=128307
3902
3903         Reviewed by Brent Fulgham.
3904
3905         * Scripts/run-javascriptcore-tests:
3906
3907 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3908
3909         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
3910         arguments for build and test scripts
3911         https://bugs.webkit.org/show_bug.cgi?id=139748
3912
3913         Reviewed by Daniel Bates.
3914
3915         There was much confusion resulting from the multitude of aliases used to build/test for
3916         the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
3917         tests directory.
3918
3919         This fixes an issue where run-api-tests and some other scripts failed when run with
3920         --simulator.
3921
3922         * Scripts/build-webkit:
3923         * Scripts/package-root:
3924         (usage):
3925         * Scripts/webkitdirs.pm:
3926         (argumentsForConfiguration):
3927         (determineXcodeSDK):
3928         * Scripts/webkitpy/port/factory.py:
3929         (platform_options):
3930
3931 2015-01-26  Simon Fraser  <simon.fraser@apple.com>
3932
3933         [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
3934         https://bugs.webkit.org/show_bug.cgi?id=140203
3935         rdar://problem/19198492
3936
3937         Reviewed by Sam Weinig.
3938
3939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3940         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
3941         (TEST):
3942
3943 2015-01-26  David Kilzer  <ddkilzer@apple.com>
3944
3945         Add iOS EWS to build.webkit.org/dashboard
3946         <http://webkit.org/b/140627>
3947
3948         Reviewed by Alexey Proskuryakov.
3949
3950         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
3951         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
3952         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3953         (BubbleQueueServer): Add ios-ews queue info.
3954         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3955         Add iOS8Device platform.
3956         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3957         (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
3958         iOS device logo.
3959
3960 2015-01-26  Filip Pizlo  <fpizlo@apple.com>
3961
3962         copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
3963         https://bugs.webkit.org/show_bug.cgi?id=140896
3964
3965         Reviewed by Michael Saboff.
3966         
3967         I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
3968         makes our script do this.
3969         
3970         Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
3971         this would be harder given llvm's autoconf setup.
3972
3973         * Scripts/copy-webkitlibraries-to-product-directory:
3974
3975 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
3976
3977         Update bot assignments.
3978
3979         * BuildSlaveSupport/build.webkit.org-config/config.json:
3980
3981 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3982
3983         Integrate WP python server into WebKit test framework
3984         https://bugs.webkit.org/show_bug.cgi?id=127094
3985
3986         Reviewed by Ryosuke Niwa.
3987
3988         This patch adds W3C web server (wptserver) as a new HTTP server.
3989         wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
3990         wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
3991
3992         Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
3993         Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
3994         It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
3995
3996         * Scripts/webkitpy/common/system/executive_mock.py:
3997         (MockProcess.communicate):
3998         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
3999         (LayoutTestRunner.__init__):
4000         (LayoutTestRunner.run_tests):
4001         (LayoutTestRunner.start_servers):
4002         (LayoutTestRunner.stop_servers):
4003         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
4004         (LayoutTestRunnerTests._run_tests):
4005         (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
4006         (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
4007         (LayoutTestRunnerTests):
4008         (LayoutTestRunnerTests.test_servers_started):
4009         * Scripts/webkitpy/layout_tests/controllers/manager.py:  Updated to check whether a test is a wpt test and whether wpt server launch is needed.
4010         (Manager.__init__):
4011         (Manager._is_http_test):
4012         (Manager._is_web_platform_test):
4013         (Manager._run_tests):
4014         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4015         (ManagerTest.test_needs_servers.get_wpt_doc_root):
4016         (ManagerTest.test_needs_servers.get_manager):
4017         (ManagerTest.test_needs_servers):
4018         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
4019         (parse_args):
4020         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
4021         (main):
4022         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
4023         (doc_root):
4024         (base_url):
4025         (WebPlatformTestServer):
4026         (WebPlatformTestServer.__init__):
4027         (WebPlatformTestServer._set_start_cmd):
4028         (WebPlatformTestServer._copy_webkit_test_files):
4029         (WebPlatformTestServer._clean_webkit_test_files):
4030         (WebPlatformTestServer._prepare_config):
4031         (WebPlatformTestServer._spawn_process):
4032         (WebPlatformTestServer._stop_running_server):
4033         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
4034         (TestWebPlatformTestServer):
4035         (TestWebPlatformTestServer.test_start_cmd):
4036         * Scripts/webkitpy/port/base.py:
4037         (Port.__init__):
4038         (Port.to.start_web_platform_test_server):
4039         (Port.to):
4040         (Port.to.web_platform_test_server_doc_root):
4041         (Port.to.web_platform_test_server_base_url):
4042         (Port.to.stop_web_platform_test_server):
4043         * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
4044         (Driver.__init__):
4045         (Driver.is_web_platform_test):
4046         (Driver.test_to_uri):
4047         (Driver.uri_to_test):
4048         (Driver._command_from_driver_input):
4049         * Scripts/webkitpy/port/driver_unittest.py:  Updated tests according new conversion rules.
4050         (DriverTest.test_test_to_uri):
4051         (DriverTest.test_uri_to_test):
4052
4053 2015-01-26  Daniel Bates  <dabates@apple.com>
4054
4055         Teach run-webkit-app --simulator how to install custom built app
4056         https://bugs.webkit.org/show_bug.cgi?id=140691
4057
4058         Reviewed by David Kilzer.
4059
4060         We should teach run-webkit-app --simulator how to install a custom built app.
4061
4062         Currently run-webkit-app --simulator can only run a system app or an app that
4063         was installed using the simctl command line tool. For convenience we should
4064         teach run-webkit-app --simulator how to install a custom built app.
4065
4066         As a side effect of this change run-safari --simulator will install and run
4067         a custom built of MobileSafari (if it exists).
4068
4069         * Scripts/webkitdirs.pm:
4070         (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
4071         Perl from the structure of the device.plist file.
4072         (plistPathFromBundle): Fix if-statement condition so that we actually perform a
4073         file system check to determine the plist path for a Mac app bundle.
4074         (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
4075         it will complain that it cannot find the file: "Domain ... does not exist".
4076         (appDisplayNameFromBundle): Ditto.
4077         (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
4078         until a simulator device is the specified state.
4079         (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
4080         (if it's open) before opening it again so as to ensure that the iOS Simulator boots
4081         the specified device.
4082         (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
4083         As implied by its name, this function will not return until the specified simulator
4084         device UDID is in the shutdown state.
4085         (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
4086         device with the specified UDID.
4087         (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
4088         before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
4089         return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
4090         expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
4091         symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
4092         /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
4093         which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
4094         (hasUserInstalledAppInSimulatorDevice): Added.
4095         (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
4096         "Booted" state.
4097         (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
4098         switching between a system installed app and a custom built version of the same app (e.g.
4099         custom build of MobileSafari) will erase all contents and settings in the simulator device.
4100         (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
4101         as that was the only caller of this function.
4102         (bootedIOSSimulatorDevice): Deleted.
4103         (openIOSSimulator): Deleted.
4104
4105 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
4106
4107         Update bot assignments.
4108
4109         * BuildSlaveSupport/build.webkit.org-config/config.json:
4110
4111 2015-01-26  Alexey Proskuryakov  <ap@apple.com>
4112
4113         Leaks bot shouldn't run JSC tests
4114         https://bugs.webkit.org/show_bug.cgi?id=140877
4115
4116         Reviewed by Darin Adler.
4117
4118         Shaves off 48 minutes of time.
4119
4120         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4121         (TestLeaksFactory): Slim down the leaks queue.
4122
4123         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4124         * Scripts/webkitpy/port/ios.py:
4125         (IOSSimulatorPort.print_leaks_summary):
4126         * Scripts/webkitpy/port/mac.py:
4127         (MacPort.print_leaks_summary):
4128         Don't yell when leaks are detected.
4129
4130 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
4131
4132         Refactor run-javascriptcore-tests
4133         https://bugs.webkit.org/show_bug.cgi?id=140824
4134
4135         Reviewed by Darin Adler.
4136
4137         Separated mozilla, stress test code paths and
4138         determining skipped mozilla tests into subroutines.
4139
4140         * Scripts/run-javascriptcore-tests:
4141         (runMozillaTests):
4142         (runJSCStressTests):
4143         (defaultJsDriverArgsForMozillaTests):
4144
4145 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
4146
4147         [buildbot] Fix grammar of TestWithFailureCount
4148         https://bugs.webkit.org/show_bug.cgi?id=140884
4149
4150         Reviewed by Alexey Proskuryakov.
4151
4152         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4153         (TestWithFailureCount):
4154         (TestWithFailureCount.commandComplete):
4155         (TestWithFailureCount.getText2):
4156         (RunUnitTests):
4157         (RunPythonTests):
4158         (RunPerlTests):
4159         (RunLLINTCLoopTests):
4160         (Run32bitJSCTests):
4161         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4162         (RunLLINTCLoopTestsTest.test_failure):
4163         (Run32bitJSCTestsTest.test_failure):
4164         (RunUnitTestsTest.assertFailures):
4165
4166 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4167
4168         Unreviewed. Moving myself to the committer section.
4169
4170         * Scripts/webkitpy/common/config/contributors.json:
4171
4172 2015-01-26  Michael Catanzaro  <mcatanzaro@igalia.com> and Carlos Garcia Campos  <cgarcia@igalia.com>
4173
4174         [GTK] gtkdoc does not appear in DevHelp
4175         https://bugs.webkit.org/show_bug.cgi?id=139369
4176
4177         Reviewed by Philippe Normand.
4178
4179         * gtk/generate-gtkdoc: Create the generators in the main function
4180         and use them to get the local cross renference dependencies. Also
4181         pass the generator module name to webkitdom.write_doc_files().
4182         (get_gtkdoc_module_paths): Receive a list of local cross reference
4183         dependencies.
4184         (get_generator_for_config): Set the main_sgml_file property of the
4185         GtkDoc object from the configuration file.
4186         (generate_documentation): Generate the documentation for the given
4187         generator.
4188         (generate_documentation_for_config): Deleted.
4189         * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
4190         * gtk/webkitdom.py:
4191         (write_doc_files): Receive the module name used to build the
4192         -sections.txt filename.
4193
4194 2015-01-26  Commit Queue  <commit-queue@webkit.org>
4195
4196         Unreviewed, rolling out r179107.
4197         https://bugs.webkit.org/show_bug.cgi?id=140880
4198
4199         The GCC in the bots doesn't support the AsyncTask
4200         implementation (Requested by KaL on #webkit).
4201
4202         Reverted changeset:
4203
4204         "[GTK] Enable IndexedDB"
4205         https://bugs.webkit.org/show_bug.cgi?id=98932
4206         http://trac.webkit.org/changeset/179107
4207
4208 2015-01-26  Csaba Osztrogonác  <ossy@webkit.org>
4209
4210         [EFL] Bump libseccomp version to 2.1.1
4211         https://bugs.webkit.org/show_bug.cgi?id=140357
4212
4213         Reviewed by Gyuyoung Kim.
4214
4215         * efl/jhbuild.modules:
4216
4217 2015-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
4218
4219         [GTK] Enable IndexedDB
4220         https://bugs.webkit.org/show_bug.cgi?id=98932
4221
4222         Reviewed by Žan Doberšek.
4223
4224         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
4225
4226 2015-01-25  Alexey Proskuryakov  <ap@apple.com>
4227
4228         Would like leaks bot results at build.webkit.org/dashboard
4229         https://bugs.webkit.org/show_bug.cgi?id=122657
4230
4231         Reviewed by Darin Adler.
4232
4233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4234         Record links provided by buildbot steps. Currently, the dashboard hardcodes more links
4235         than necessary, could use the ones from buildbot in more places.
4236
4237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4238         (BuildbotQueue): Reflect configuration option for leaks queues.
4239
4240         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4241         Add leaks queues to performance column. First, leaks are about performance indeed,
4242         and second, this is where we have some space to spare.
4243
4244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4245         (WebKitBuildbot): Added Yosemite Leaks queue, which was sitting neglected for at
4246         least a year.
4247
4248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4249         (table.queue-grid td): Moved height from queue-view - we can now have more than one
4250         queue view per cell. The heigt is needed to avoid ugly overlapping while loading
4251         results - once the results are loaded, all rows are currently higher than that.
4252
4253         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
4254         (.leaks-popover): Added.
4255
4256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
4257         Added.
4258
4259         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4260         Load BuildbotLeaksQueueView.js.
4261
4262 2015-01-25  peavo@outlook.com  <peavo@outlook.com>
4263
4264         [Win] Add WebKit message loop interface.
4265         https://bugs.webkit.org/show_bug.cgi?id=140857
4266
4267         Reviewed by Brent Fulgham.
4268
4269         Added message loop interface which will run the message loop,
4270         and perform required tasks (like calling CFRunLoopRunInMode)
4271         on each iteration of the loop.
4272
4273         * WinLauncher/WinMain.cpp:
4274         (wWinMain): Use new message loop interface.
4275
4276 2015-01-24  Dan Bernstein  <mitz@apple.com>
4277
4278         update-webkit’s --internal option is unused
4279         https://bugs.webkit.org/show_bug.cgi?id=140861
4280
4281         Reviewed by Anders Carlsson.
4282
4283         * Scripts/update-webkit: Removed the option.
4284
4285 2015-01-24  Brent Fulgham  <bfulgham@apple.com>
4286
4287         DumpRenderTree needs to run with Windows native controls on Windows
4288         https://bugs.webkit.org/show_bug.cgi?id=25592
4289
4290         Reviewed by Anders Carlsson.
4291
4292         * DumpRenderTree/win/DumpRenderTree.cpp:
4293         (resetWebPreferencesToConsistentValues): Tell DRT to use native controls.
4294         (prepareConsistentTestingEnvironment): Ditto.
4295
4296 2015-01-23  David Kilzer  <ddkilzer@apple.com>
4297
4298         test-webkitpy: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses fails on EFL, GTK, Win ports
4299         <http://webkit.org/b/140787>
4300
4301         Reviewed by Daniel Bates.
4302
4303         * Scripts/webkitpy/port/ios.py:
4304         (IOSPort.determine_full_port_name): Instead of checking the type
4305         of the current host, test if /usr/bin/xcrun exists before trying
4306         to use it.
4307
4308 2015-01-23  Csaba Osztrogonác  <ossy@webkit.org>
4309
4310         Fix the false positive build failures on the Windows buildbots
4311         https://bugs.webkit.org/show_bug.cgi?id=140819
4312
4313         Reviewed by Brent Fulgham.
4314
4315         Increase the build timeout (without producing output) to 2 hours for Windows bots,
4316         the default 20 minutes is enough for others since they produce output during the build.
4317
4318         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4319         (BuildFactory.__init__):
4320
4321 2015-01-23  Brent Fulgham  <bfulgham@apple.com>
4322
4323         [Win] Teach WebKit to provide IAccessible2 'get_language' and access AXLanguage