Kill old run-webkit-tests processes in kill-process on Mac
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Kill old run-webkit-tests processes in kill-process on Mac
4         https://bugs.webkit.org/show_bug.cgi?id=69976
5
6         Reviewed by Dirk Pranke.
7
8         Add a system call to remove all python processes running run-webkit-tests.
9
10         * BuildSlaveSupport/kill-old-processes:
11         * BuildSlaveSupport/mac: Removed.
12
13 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
14
15         Many WK2 snapshots are blank
16         https://bugs.webkit.org/show_bug.cgi?id=69953
17
18         Reviewed by Beth Dakin.
19         
20         Two fixes:
21         1. negating a size_t in CGContextTranslateCTM() fails, because
22         size_t is unsigned. Fix by casing to CGFloat before negation.
23         
24         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
25         Autodisplay is necessary to kick off Core Animation rendering.
26
27         * WebKitTestRunner/cg/TestInvocationCG.cpp:
28         (WTR::createCGContextFromImage):
29         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
30         (WTR::PlatformWebView::PlatformWebView):
31
32 2011-10-12  Adam Barth  <abarth@webkit.org>
33
34         commit-queue doesn't have a friendly error message when the reviewer line is messed up
35         https://bugs.webkit.org/show_bug.cgi?id=69979
36
37         Reviewed by Eric Seidel.
38
39         Rather than combining the ChangeLog validation with a more complicated
40         command, this patch has the commit-queue run it as a separate command,
41         which will give us more control over the error message.
42
43         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
44         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
45         * Scripts/webkitpy/tool/commands/download.py:
46         * Scripts/webkitpy/tool/commands/queues_unittest.py:
47         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
48         * Scripts/webkitpy/tool/steps/validatereviewer.py:
49
50 2011-10-12  Eric Seidel  <eric@webkit.org>
51
52         Layout tests asserting in LayoutTestController::pathToLocalResource()
53         https://bugs.webkit.org/show_bug.cgi?id=69898
54
55         Reviewed by Simon Fraser.
56
57         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
58
59         * Scripts/old-run-webkit-tests:
60         (openDumpTool):
61
62 2011-10-12  Adam Barth  <abarth@webkit.org>
63
64         The commit-queue doesn't tell me which tests my patch broke
65         https://bugs.webkit.org/show_bug.cgi?id=69975
66
67         Reviewed by Eric Seidel.
68
69         We now print the list of newly failing tests, like we do for the EWS.
70
71         * Scripts/webkitpy/tool/commands/queues.py:
72         * Scripts/webkitpy/tool/commands/queues_unittest.py:
73
74 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
75
76         Added myself as a committer.
77
78         * Scripts/webkitpy/common/config/committers.py:
79
80 2011-10-12  Adam Barth  <abarth@webkit.org>
81
82         _run_tests is a confusing variable name in webkitpy
83         https://bugs.webkit.org/show_bug.cgi?id=69971
84
85         Reviewed by Eric Seidel.
86
87         Eric and I thought this was a function.
88
89         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
90
91 2011-10-12  Tony Chang  <tony@chromium.org>
92
93         Fix test-webkitpy after r97307 and r97293.
94
95         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
96           is None during tests so add back the check.
97         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
98           output directory is now build/Debug.
99
100 2011-10-12  Tony Chang  <tony@chromium.org>
101
102         [chromium] remove old build dirs on chromium-win
103         https://bugs.webkit.org/show_bug.cgi?id=69961
104
105         Reviewed by Adam Barth.
106
107         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
108           always in build and never in chrome or webkit.
109
110 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
111
112         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
113         https://bugs.webkit.org/show_bug.cgi?id=69954
114
115         Also renamed the action and associated event name to address an FIXME.
116
117         Reviewed by Adam Barth.
118
119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
122
123 2011-10-12  Tony Chang  <tony@chromium.org>
124
125         stop spamming 'stopping test driver timed out, killing it' when running rwt
126         https://bugs.webkit.org/show_bug.cgi?id=69938
127
128         Reviewed by Adam Barth.
129
130         In http://trac.webkit.org/changeset/95875 , we made the timeout for
131         stopping the driver based on time_out_ms, but we based it on the wrong
132         default times.
133
134         * Scripts/webkitpy/layout_tests/port/chromium.py:
135
136 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
137
138         3D transforms are flattened in WebKit2 snapshots
139         https://bugs.webkit.org/show_bug.cgi?id=68276
140
141         Reviewed by Adam Roben.
142         
143         Fix WKImage leak noticed by Adam.
144
145         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
146         (WTR::PlatformWebView::windowSnapshotImage):
147
148 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
149
150         garden-o-matic should color-code test failure types.
151         https://bugs.webkit.org/show_bug.cgi?id=69945
152
153         Reviewed by Adam Barth.
154
155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
159
160 2011-10-12  Adam Barth  <abarth@webkit.org>
161
162         webkitpy tests are failing on Mac bots
163         https://bugs.webkit.org/show_bug.cgi?id=69929
164
165         Reviewed by Simon Fraser.
166
167         Admit that Lion exists.
168
169         * Scripts/webkitpy/layout_tests/port/chromium.py:
170         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
171
172 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
173
174         Improve output of run-api-tests to make time-outs more obvious
175         https://bugs.webkit.org/show_bug.cgi?id=69788
176
177         Reviewed by Adam Roben.
178         
179         List the tests that failed and timed out at the bottom of the output,
180         if run with --verbose.
181
182         * Scripts/run-api-tests:
183         (runAllTests):
184         (runTest):
185
186 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
187
188         Unreviewed, rolling out r97252.
189         http://trac.webkit.org/changeset/97252
190         https://bugs.webkit.org/show_bug.cgi?id=69944
191
192         Broke test-webkpy (Requested by abarth on #webkit).
193
194         * Scripts/webkitpy/layout_tests/port/qt.py:
195         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
196
197 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
198
199         new-run-webkit-tests does not support qt-4.8 results
200         https://bugs.webkit.org/show_bug.cgi?id=64071
201
202         Reviewed by Csaba Osztrogonác.
203
204         * Scripts/webkitpy/layout_tests/port/qt.py:
205         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
206
207 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
208
209         [GTK] [WebKit2] Make adding another unit test easier
210         https://bugs.webkit.org/show_bug.cgi?id=69409
211
212         Reviewed by Gustavo Noronha Silva.
213
214         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
215         new WebKit2 tests.
216
217 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
218
219         [WebSocket] update pywebsocket to 0.6b6.
220         https://bugs.webkit.org/show_bug.cgi?id=69824
221
222         Reviewed by Kent Tamura.
223
224         WebKit supports WebSocket with version 8 based protocol for now.
225         We should update its protocol to version 13 based one like hybi-17.
226         pywebsocket 0.6b6 supports both of version 8 and 13.
227
228         * Scripts/webkitpy/thirdparty/__init__.py:
229
230 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
231
232         WebKitTestRunner needs to link with WebKit for NSURL category methods
233         https://bugs.webkit.org/show_bug.cgi?id=69892
234
235         Reviewed by Sam Weinig.
236         
237         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
238         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
239         WebKit.framework to fix this.
240
241         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
242
243 2011-10-11  Adam Barth  <abarth@webkit.org>
244
245         sheriffbot takes too long to acknowledge rollout commands
246         https://bugs.webkit.org/show_bug.cgi?id=69871
247
248         Reviewed by Eric Seidel.
249
250         We used to update the working copy before acknowledging the command
251         because we wanted to ping all the relevant IRC nicks.  That's caused a
252         bunch of frustration because folks don't know whether the bot has heard
253         their commands.
254
255         This patch makes the bot reply immediately before updating the working
256         copy.  All the relevenat folks are still pinged when the bot finishes
257         preparing the rollout.
258
259         * Scripts/webkitpy/tool/bot/irc_command.py:
260         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
261
262 2011-10-11  Adam Barth  <abarth@webkit.org>
263
264         test-webkitpy fails on Lion
265         https://bugs.webkit.org/show_bug.cgi?id=69873
266
267         Reviewed by Eric Seidel.
268
269         This patch fixes one of the two failures.  I'll need to track down the
270         other failure another time.
271
272         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
273
274 2011-10-11  Adam Barth  <abarth@webkit.org>
275
276         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
277         https://bugs.webkit.org/show_bug.cgi?id=65230
278
279         Reviewed by Dimitri Glazkov.
280
281         This patch causes us to treat crashed or hung run-webkit-tests runs
282         similarly to how we treat compile failures.  In some sense, they're
283         similar because they prevent us from getting test coverage.
284
285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
287
288 2011-10-11  Adam Barth  <abarth@webkit.org>
289
290         Failing builder display in garden-o-matic should have the same visual style as the failure grid
291         https://bugs.webkit.org/show_bug.cgi?id=69876
292
293         Reviewed by Dimitri Glazkov.
294
295         This patch generalizes the view we use for failing builders in the
296         FailureGrid so that we can use it for the list of builders that aren't
297         compiling.
298
299         One downside of this patch is that it makes it harder to tell when
300         debug builders are failing (as opposed to release builders) because
301         that information isn't presented in this view.  A future patch will
302         improve this aspect.
303
304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
305         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
310
311 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
312
313         Some API tests are timing out in Release
314         https://bugs.webkit.org/show_bug.cgi?id=69787
315
316         Reviewed by Mark Rowe.
317         
318         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
319         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
320
321         * TestWebKitAPI/Configurations/Base.xcconfig:
322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
323         * TestWebKitAPI/config.h:
324
325 2011-10-11  Adam Barth  <abarth@webkit.org>
326
327         garden-o-matic links to flakiness dashboard should open in a new tab
328         https://bugs.webkit.org/show_bug.cgi?id=69864
329
330         Reviewed by Dimitri Glazkov.
331
332         This bug was obvious in the first five minutes of using this new
333         feature.  :)
334
335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
337
338 2011-10-11  Adam Barth  <abarth@webkit.org>
339
340         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
341         that * doesn't really mean "all".  I've emailed the W3C working group
342         about changing the spec.
343
344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
345
346 2011-10-11  Adam Barth  <abarth@webkit.org>
347
348         garden-o-matic should link to the flakiness dashboard
349         https://bugs.webkit.org/show_bug.cgi?id=69862
350
351         Reviewed by Dimitri Glazkov.
352
353         The flakiness dashboard has lots of great information about the failure
354         history of each test.  This patch adds a link from garden-o-matic to
355         the flakiness dashboard so the gardener can look at this information.
356
357         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
358         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
360
361 2011-10-11  David Levin  <levin@chromium.org>
362
363         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
364         https://bugs.webkit.org/show_bug.cgi?id=69789
365
366         Reviewed by Eric Seidel.
367
368         Made the signature of _assertRaisesRegexp match that of Python 2.7.
369
370         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
371         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
372         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
373         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
374
375 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
376
377         [EFL] DRT: Do not abort() when an unknown key is pressed.
378         https://bugs.webkit.org/show_bug.cgi?id=69856
379
380         Reviewed by Antonio Gomes.
381
382         A lot of tests crash due to the previous behaviour. Just using the
383         received name of the pressed key works most of the time, and when it
384         does not the failing tests should tell us.
385
386         * DumpRenderTree/efl/EventSender.cpp:
387         (keyPadNameFromJSValue):
388         (keyNameFromJSValue):
389         (keyDownCallback):
390
391 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
392
393         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
394         https://bugs.webkit.org/show_bug.cgi?id=68016
395
396         Reviewed by Chang Shu.
397
398         * Scripts/webkitpy/layout_tests/port/qt.py:
399
400 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
401
402         [EFL] DRT: Return the right window count in LayoutTestController.
403         https://bugs.webkit.org/show_bug.cgi?id=69764
404
405         Reviewed by Antonio Gomes.
406
407         Follow-up to r96943: now that we have DumpRenderTreeChrome and
408         DumpRenderTreeView in the tree, we can correctly count the number of
409         open windows in DRT.
410
411         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
412         (LayoutTestController::windowCount):
413
414 2011-10-11  Jer Noble  <jer.noble@apple.com>
415
416         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
417         https://bugs.webkit.org/show_bug.cgi?id=69800
418
419         Reviewed by Csaba Osztrogonác.
420
421         Enable WEB_AUDIO at runtime.
422
423         * DumpRenderTree/mac/DumpRenderTree.mm:
424         (resetDefaultsToConsistentValues):
425
426 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
427
428         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
429         https://bugs.webkit.org/show_bug.cgi?id=69769
430
431         Reviewed by Antonio Gomes.
432
433         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
434         (LayoutTestController::setIconDatabaseEnabled):
435
436 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
437
438         [Qt] Remove all references to QTDIR_build and standalone_package
439
440         Qt is now modularized, which means we no longer import WebKit into
441         the Qt source tree. Instead we use git submodules, and building
442         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
443
444         To decrease the number of buildsystem configurations we also remove
445         the standalone_package code-path used when we were providing tarballs
446         with the derived sources pre-generated.
447
448         Reviewed by Simon Hausmann.
449
450         * MiniBrowser/qt/MiniBrowser.pro:
451         * QtTestBrowser/QtTestBrowser.pro:
452         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
453
454 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
455
456         Update Chromium accessibility support in DRT.
457         https://bugs.webkit.org/show_bug.cgi?id=69676
458
459         Reviewed by Chris Fleizach.
460
461         Adds several missing properties and methods to enable more
462         tests to pass, and in particular adds support for notification
463         callbacks.
464
465         * DumpRenderTree/chromium/AccessibilityController.cpp:
466         (AccessibilityController::AccessibilityController):
467         (AccessibilityController::reset):
468         (AccessibilityController::getFocusedElement):
469         (AccessibilityController::shouldLogAccessibilityEvents):
470         (AccessibilityController::notificationReceived):
471         (AccessibilityController::logAccessibilityEventsCallback):
472         * DumpRenderTree/chromium/AccessibilityController.h:
473         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
474         (getHelpText):
475         (getStringValue):
476         (getOrientation):
477         (AccessibilityUIElement::AccessibilityUIElement):
478         (AccessibilityUIElement::getChildAtIndex):
479         (AccessibilityUIElement::isEqual):
480         (AccessibilityUIElement::notificationReceived):
481         (AccessibilityUIElement::roleGetterCallback):
482         (AccessibilityUIElement::titleGetterCallback):
483         (AccessibilityUIElement::descriptionGetterCallback):
484         (AccessibilityUIElement::helpTextGetterCallback):
485         (AccessibilityUIElement::stringValueGetterCallback):
486         (AccessibilityUIElement::xGetterCallback):
487         (AccessibilityUIElement::yGetterCallback):
488         (AccessibilityUIElement::widthGetterCallback):
489         (AccessibilityUIElement::heightGetterCallback):
490         (AccessibilityUIElement::intValueGetterCallback):
491         (AccessibilityUIElement::minValueGetterCallback):
492         (AccessibilityUIElement::maxValueGetterCallback):
493         (AccessibilityUIElement::childrenCountGetterCallback):
494         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
495         (AccessibilityUIElement::selectedTextRangeGetterCallback):
496         (AccessibilityUIElement::isEnabledGetterCallback):
497         (AccessibilityUIElement::isRequiredGetterCallback):
498         (AccessibilityUIElement::isFocusedGetterCallback):
499         (AccessibilityUIElement::isFocusableGetterCallback):
500         (AccessibilityUIElement::isSelectedGetterCallback):
501         (AccessibilityUIElement::isSelectableGetterCallback):
502         (AccessibilityUIElement::isMultiSelectableGetterCallback):
503         (AccessibilityUIElement::isExpandedGetterCallback):
504         (AccessibilityUIElement::isCheckedGetterCallback):
505         (AccessibilityUIElement::isVisibleGetterCallback):
506         (AccessibilityUIElement::isOffScreenGetterCallback):
507         (AccessibilityUIElement::isCollapsedGetterCallback):
508         (AccessibilityUIElement::hasPopupGetterCallback):
509         (AccessibilityUIElement::isValidGetterCallback):
510         (AccessibilityUIElement::orientationGetterCallback):
511         (AccessibilityUIElement::showMenuCallback):
512         (AccessibilityUIElement::pressCallback):
513         (AccessibilityUIElement::isEqualCallback):
514         (AccessibilityUIElement::addNotificationListenerCallback):
515         (AccessibilityUIElement::removeNotificationListenerCallback):
516         (AccessibilityUIElement::takeFocusCallback):
517         (AccessibilityUIElement::fallbackCallback):
518         (RootAccessibilityUIElement::getChildAtIndex):
519         (AccessibilityUIElementList::getOrCreate):
520         * DumpRenderTree/chromium/AccessibilityUIElement.h:
521         * DumpRenderTree/chromium/CppVariant.cpp:
522         (CppVariant::invokeDefault):
523         * DumpRenderTree/chromium/CppVariant.h:
524         * DumpRenderTree/chromium/LayoutTestController.cpp:
525         (LayoutTestController::LayoutTestController):
526         (LayoutTestController::reset):
527         * DumpRenderTree/chromium/LayoutTestController.h:
528         * DumpRenderTree/chromium/WebViewHost.cpp:
529         (WebViewHost::postAccessibilityNotification):
530
531 2011-10-10  Adam Klein  <adamk@chromium.org>
532
533         Support Distributed-CompileC as an action name in filter-build-webkit
534         https://bugs.webkit.org/show_bug.cgi?id=69783
535
536         Reviewed by Ojan Vafai.
537
538         * Scripts/filter-build-webkit:
539
540 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
541
542         3D transforms are flattened in WebKit2 snapshots
543         https://bugs.webkit.org/show_bug.cgi?id=68276
544
545         Reviewed by Anders Carlsson.
546         
547         Use a snapshot of the window, rather than an image from the web process
548         for pixel testing in WebKitTestRunner. This correctly captures compositing
549         layers, so works for 3D transform tests.
550
551         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
552         * WebKitTestRunner/cg/TestInvocationCG.cpp:
553         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
554         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
555         use that instead of the image we get from the web process.
556         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
557         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
558         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
559         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
560         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
561         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
562         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
563         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
564
565 2011-10-10  David Levin  <levin@chromium.org>
566
567         Quick fix for watchlist unit test failures when using Python 2.7+
568         Reviewed by Adam Barth.
569
570         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
571         better fix.
572
573         * Scripts/webkitpy/common/webkitunittest.py: Always use our
574         version of assertRaisesRegexp.
575
576 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
577
578         Unreviewed, rolling out r97082.
579         http://trac.webkit.org/changeset/97082
580         https://bugs.webkit.org/show_bug.cgi?id=69784
581
582         broke Windows build (Requested by smfr on #webkit).
583
584         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
585         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
586         (WTR::createCGContextFromImage):
587         (WTR::computeMD5HashStringForContext):
588         (WTR::dumpBitmap):
589         (WTR::paintRepaintRectOverlay):
590         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
591         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
592         (WTR::PlatformWebView::PlatformWebView):
593
594 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
595
596         3D transforms are flattened in WebKit2 snapshots
597         https://bugs.webkit.org/show_bug.cgi?id=68276
598
599         Reviewed by Anders Carlsson.
600         
601         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
602         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
603         the window when doing pixel tests.
604         
605         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
606
607         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
608         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
609         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
610         (WTR::computeMD5HashStringForContext):
611         (WTR::dumpBitmap):
612         (WTR::paintRepaintRectOverlay):
613         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
614         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
615         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
616         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
617         We need the window to autodisplay for Core Animation to render layers and start animations.
618
619 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
620
621         WebKitTestRunner needs layoutTestController.setWindowIsKey
622         https://bugs.webkit.org/show_bug.cgi?id=42688
623
624         Reviewed by Anders Carlsson.
625
626         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
627         This sets a flag that the platform layer uses to indicate that
628         the window is the key window, which fixes focus ring drawing
629         in pixel results.
630         
631         Also focus the web view when we get a 'didCommitLoad' for the main
632         frame, as DumpRenderTree does.
633
634         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
635         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
636         (WTR::InjectedBundle::postSetWindowIsKey):
637         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
638         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
639         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
640         (WTR::LayoutTestController::addChromeInputField):
641         (WTR::LayoutTestController::removeChromeInputField):
642         (WTR::LayoutTestController::focusWebView):
643         (WTR::LayoutTestController::setWindowIsKey):
644         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
645         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
646         (WTR::LayoutTestController::callFocusWebViewCallback):
647         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
648         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
649         so that we can override -isKeyWindow. Use a boolean member variable
650         to track window key status.
651         (WTR::PlatformWebView::setWindowIsKey):
652         (WTR::PlatformWebView::windowIsKey):
653         * WebKitTestRunner/TestController.cpp:
654         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
655         (WTR::closeOtherPage): Use the same cast as other functions.
656         (WTR::focus): Implement to call setWindowIsKey(true)
657         (WTR::unfocus): Implement to call setWindowIsKey(false)
658         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
659         (WTR::TestController::initialize):
660         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
661         * WebKitTestRunner/TestController.h:
662         * WebKitTestRunner/TestInvocation.cpp:
663         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
664         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
665         (WTR::PlatformWebView::PlatformWebView):
666         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
667         (-[WebKitTestRunnerWindow isKeyWindow]):
668         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
669         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
670         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
671         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
672         (WTR::PlatformWebView::PlatformWebView):
673         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
674         (WTR::PlatformWebView::PlatformWebView):
675
676 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
677
678         check-webkit-style: Add readability exception for Ewk_* data types.
679         https://bugs.webkit.org/show_bug.cgi?id=69763
680
681         Reviewed by David Levin.
682
683         Many EFL-related files (such as EditorClientEfl.h or
684         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
685         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
686         check-webkit-style.
687
688         Add an exception for them, just like there are exceptions for
689         Evas_*, Ecore_* and others.
690
691         * Scripts/webkitpy/style/checkers/cpp.py:
692         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
693
694 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
695
696         [Chromium] Get rid of WebAccessibilityCache.
697         https://bugs.webkit.org/show_bug.cgi?id=68224
698
699         Reviewed by Dimitri Glazkov.
700
701         * DumpRenderTree/chromium/AccessibilityController.cpp:
702         (AccessibilityController::bindToJavascript):
703
704 2011-10-09  Adam Barth  <abarth@webkit.org>
705
706         Remove "near miss" XSS vulnerabilities in garden-o-matic
707         https://bugs.webkit.org/show_bug.cgi?id=69708
708
709         Reviewed by David Levin.
710
711         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
712         any actual vulnerabilities yet, but he did identify a couple "near
713         misses" where a slight change in garden-o-matic could lead to a
714         vulnerability.  This patch removes those potential issues.
715
716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
717         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
718
719 2011-10-07  Adam Barth  <abarth@webkit.org>
720
721         Add a Content-Security-Policy to garden-o-matic
722         https://bugs.webkit.org/show_bug.cgi?id=69668
723
724         Reviewed by David Levin.
725
726         This will help mitigate cross-site script and will also help us dogfood CSP.
727
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
729
730 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
731
732         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
733         https://bugs.webkit.org/show_bug.cgi?id=66380
734
735         Reviewed by Antonio Gomes.
736
737         This encapsulates EWebKit into an object that manages multiple windows
738         and provides a cleaner interface to EFL's DumpRenderTree.
739
740         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
741         (DumpRenderTreeChrome::create):
742         (DumpRenderTreeChrome::DumpRenderTreeChrome):
743         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
744         (DumpRenderTreeChrome::createNewWindow):
745         (DumpRenderTreeChrome::createView):
746         (DumpRenderTreeChrome::removeWindow):
747         (DumpRenderTreeChrome::initialize):
748         (DumpRenderTreeChrome::extraViews):
749         (DumpRenderTreeChrome::mainFrame):
750         (DumpRenderTreeChrome::mainView):
751         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
752         (DumpRenderTreeChrome::onWindowObjectCleared):
753         (DumpRenderTreeChrome::onLoadStarted):
754         (DumpRenderTreeChrome::processWork):
755         (DumpRenderTreeChrome::onLoadFinished):
756         (DumpRenderTreeChrome::onStatusbarTextSet):
757         (DumpRenderTreeChrome::onTitleChanged):
758         (DumpRenderTreeChrome::onDocumentLoadFinished):
759         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
760         * DumpRenderTree/efl/EventSender.cpp:
761         (sendClick): Use browser->mainFrame() instead of mainFrame.
762         (mouseDownCallback): Ditto.
763         (mouseUpCallback): Ditto.
764         (mouseMoveToCallback): Ditto.
765         (mouseScrollByCallback): Ditto.
766         (keyDownCallback): Ditto.
767         (scalePageByCallback): Ditto.
768         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
769         (LayoutTestController::counterValueForElementById): Use
770         browser->mainFrame() instead of mainFrame.
771         (LayoutTestController::pageNumberForElementById): Ditto.
772         (LayoutTestController::numberOfPages): Ditto.
773         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
774         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
775         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
776         (LayoutTestController::numberOfActiveAnimations): Ditto.
777         (LayoutTestController::suspendAnimations): Ditto.
778         (LayoutTestController::resumeAnimations): Ditto.
779         (LayoutTestController::setWebViewEditable): Ditto.
780         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
781         instead of browser.
782         (LayoutTestController::queueLoad): Ditto.
783         (LayoutTestController::setAcceptsEditing): Ditto.
784         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
785         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
786         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
787         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
788         (LayoutTestController::setPluginsEnabled): Ditto.
789         (LayoutTestController::findString): Ditto.
790         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
791         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
792         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
793         mainFrame.
794         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
795         (LoadItem::invoke): Ditto.
796         (LoadHTMLStringItem::invoke): Ditto.
797         (ScriptItem::invoke): Ditto.
798         (ReloadItem::invoke): Use browser->mainView() instead of browser.
799
800 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
801
802         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
803         https://bugs.webkit.org/show_bug.cgi?id=69617
804
805         Reviewed by Andreas Kling.
806
807         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
808         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
809         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
810         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
811         logic.
812
813         * MiniBrowser/qt/MiniBrowserApplication.cpp:
814         (MiniBrowserApplication::MiniBrowserApplication):
815         (MiniBrowserApplication::notify):
816         * MiniBrowser/qt/MiniBrowserApplication.h:
817
818 2011-10-06  Adam Barth  <abarth@webkit.org>
819
820         Port PixelZoomer to work in garden-o-matic
821         https://bugs.webkit.org/show_bug.cgi?id=69577
822
823         Reviewed by David Levin.
824
825         This implementation of PixelZoomer is basically a fork of the
826         implementation used by results.html.  These two apps have different
827         requirements on where this code lives.  results.html wants to be
828         self-contained whereas garden-o-matic wants to live in the public_html
829         folder of the buildbot.  We could do something fancy here to share the
830         code, but that's not likely to be of much benefit.
831
832         I had to change a few things about pixelzoomer to accounter for the
833         differences in DOM between results.html and garden-o-matic, but
834         surprisingly little.  I also moved all the code into an anonymous
835         function, which is the style we're suing for module separation in
836         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
837         want to drag along too many extra functions from results.html.
838
839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
844         (.pixel-zoom-container):
845         (.pixel-zoom-container > *):
846         (.pixel-zoom-container .scaled-image-container):
847         (.scaled-image-container > img):
848
849 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
850
851         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
852         https://bugs.webkit.org/show_bug.cgi?id=69505
853
854         Reviewed by Andreas Kling.
855
856         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
857         (on_viewport_changed):
858
859 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
860
861         [WinCairo] Unreviewed test correction.
862
863         * Scripts/webkitdirs.pm:
864         (argumentsForConfiguration): Add 'wincairo' option to the set of
865         configuration flags used by run-javascript-core tests, so that it
866         does not attempt to run Apple's release version.
867
868 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
869
870         [WinCairo] Unreviewed test correction.
871
872         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
873          of known build slave types so that test-result-archive won't fail
874          when running tests.
875
876 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
877
878         The GTK+ WebKit2 headers produce a lot of style warnings
879         https://bugs.webkit.org/show_bug.cgi?id=69481
880
881         Reviewed by David Levin.
882
883         Prevent emitting so many style warnings for GTK+ API. We skip header
884         files in the WebKit2 GTK+ API directory and also avoid warnings about
885         identifier names that begin with "webkit_" in files that contain the
886         string "gtk".
887
888         * Scripts/webkitpy/style/checker.py: Do not check header files in
889         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
890         adding the ability to specify a regular expression in the skip list. Remove
891         a few files from the skipped list that no longer exist.
892         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
893         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
894         about identifiers that begin with "webkit_".
895         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
896
897 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
898
899         [WinCairo] Correct config.json for WinCairo Test builds.
900         https://bugs.webkit.org/show_bug.cgi?id=69272
901
902         Reviewed by Ryosuke Niwa.
903
904         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
905          old 'WinCairo Debug (Build)' label and replace with correct
906          'WinCairo Release' label.
907
908 2011-10-06  David Levin  <levin@chromium.org>
909
910         Add a style checker watchlist definition and add myself to it.
911         https://bugs.webkit.org/show_bug.cgi?id=69564
912
913         Reviewed by Daniel Bates.
914
915         * Scripts/webkitpy/common/config/watchlist:
916
917 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
918
919         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
920         https://bugs.webkit.org/show_bug.cgi?id=69450
921
922         Reviewed by Ryosuke Niwa.
923
924         This should avoid stderr messages when running
925         webarchive/test-link-rel-icon.html.
926
927         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
928         (LayoutTestController::setIconDatabaseEnabled):
929
930 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
931
932         [WK2] [GTK] Add Skipped file for Webkit2 test runner
933         https://bugs.webkit.org/show_bug.cgi?id=69517
934
935         Use the shared WK2 skipped file also in GTK port.
936
937         Reviewed by Martin Robinson.
938
939         * Scripts/old-run-webkit-tests:
940         (readSkippedFiles):
941
942 2011-10-06  Elliot Poger  <epoger@google.com>
943
944         allow new-run-webkit-tests to run on Lion
945         https://bugs.webkit.org/show_bug.cgi?id=69429
946
947         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
948         directory to fallback lists (even though that directory doesn't exist yet)
949
950         Reviewed by Adam Barth.
951
952         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
953         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
954
955 2011-10-03  Hans Wennborg  <hans@chromium.org>
956
957         IndexedDB: Remove SQLite-LevelDB migration code
958         https://bugs.webkit.org/show_bug.cgi?id=69264
959
960         Reviewed by Tony Chang.
961
962         Remove setOverrideIndexedDBBackingStore. It was used in the layout
963         test for migration.
964
965         * DumpRenderTree/chromium/LayoutTestController.cpp:
966         (LayoutTestController::LayoutTestController):
967         * DumpRenderTree/chromium/LayoutTestController.h:
968
969 2011-10-05  James Robinson  <jamesr@chromium.org>
970
971         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
972         https://bugs.webkit.org/show_bug.cgi?id=69498
973
974         Reviewed by Adam Barth.
975
976         * DumpRenderTree/chromium/DumpRenderTree.cpp:
977         (main):
978         * DumpRenderTree/chromium/TestShell.cpp:
979         (TestShell::TestShell):
980         (TestShell::resetWebSettings):
981         * DumpRenderTree/chromium/TestShell.h:
982         (TestShell::setThreadedCompositingEnabled):
983         * DumpRenderTree/chromium/WebPreferences.cpp:
984         (WebPreferences::reset):
985         (WebPreferences::applyTo):
986         * DumpRenderTree/chromium/WebPreferences.h:
987         * Scripts/webkitpy/layout_tests/port/chromium.py:
988         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
989
990 2011-10-05  Erik Arvidsson  <arv@chromium.org>
991
992         [QT] Fix DRT after r96779
993
994         unreviewed.
995
996         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
997         (WebCore::dumpHistoryItem):
998
999 2011-10-05  Erik Arvidsson  <arv@chromium.org>
1000
1001         window.location.href and others needlessly decodes URI-encoded characters
1002         https://bugs.webkit.org/show_bug.cgi?id=30225
1003
1004         Reviewed by Darin Adler.
1005
1006         * DumpRenderTree/chromium/TestShell.cpp:
1007         (normalizeLayoutTestURLInternal): Remove extra encode.
1008
1009 2011-10-05  Darin Adler  <darin@apple.com>
1010
1011         Fix build.
1012
1013         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1014         (TestWebKitAPI::TEST): Remove underscore prefix from call to
1015         WKContextRegisterURLSchemeAsEmptyDocument.
1016
1017 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
1018
1019         [WinCairo] Switch to building Release target, and activate tests.
1020         https://bugs.webkit.org/show_bug.cgi?id=69272
1021
1022         Reviewed by Adam Barth.
1023
1024         * BuildSlaveSupport/build.webkit.org-config/config.json:
1025         Change from debug to release target. Switch from "Build" to
1026         "BuildAndTest"
1027
1028 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
1029
1030         In WebKitTestRunner, text has font smoothing in pixel snapshots
1031         https://bugs.webkit.org/show_bug.cgi?id=69396
1032
1033         Reviewed by Darin Adler.
1034         
1035         Call the new WKContext method that disables font smoothing in
1036         WebKitTestRunner, so that pixel snapshots don't have font smoothing
1037         enabled. Remove leading underscore from a WKContext function call.
1038
1039         * WebKitTestRunner/TestController.cpp:
1040         (WTR::TestController::resetStateToConsistentValues):
1041
1042 2011-10-05  David Levin  <levin@chromium.org>
1043
1044         Improve the watchlist for threading entries.
1045         https://bugs.webkit.org/show_bug.cgi?id=69463
1046
1047         Reviewed by Adam Barth.
1048
1049         * Scripts/webkitpy/common/config/watchlist:
1050
1051 2011-10-05  Adam Roben  <aroben@apple.com>
1052
1053         Add tests for using RetainPtrs inside HashMap and HashSet
1054
1055         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
1056         in HashMap/HashSet fails to compile
1057
1058         Reviewed by John Sullivan.
1059
1060         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
1061         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
1062         and value type of HashMap.
1063
1064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1065         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1066         Added new file.
1067
1068 2011-10-05  Adam Barth  <abarth@webkit.org>
1069
1070         Mark as Expected in garden-o-matic is confusing
1071         https://bugs.webkit.org/show_bug.cgi?id=69452
1072
1073         Reviewed by David Levin.
1074
1075         krit didn't understand the difference between this button and the
1076         Rebaseline button because both of them seem to indicate that the new
1077         behavior is expected.  This patch renames "Mark as Expected" to "Expect
1078         Failure" to make it clear that we're just expecting the test to fail
1079         rather than accepting the new results as passing.  We might need to
1080         iterate on these names a bit more if folks continue to find them
1081         confusing.
1082
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1084
1085 2011-10-05  Adam Barth  <abarth@webkit.org>
1086
1087         Add watchlist entries for abarth
1088         https://bugs.webkit.org/show_bug.cgi?id=69461
1089
1090         Reviewed by David Levin.
1091
1092         I might have gone a bit overboard.  We'll see if this is too much spam
1093         for me.
1094
1095         * Scripts/webkitpy/common/config/watchlist:
1096
1097 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
1098
1099         [WinCairo] Teach old-run-webkit-tests about wincairo.
1100         https://bugs.webkit.org/show_bug.cgi?id=69280
1101
1102         Reviewed by Adam Roben.
1103
1104         * Scripts/old-run-webkit-tests: Handle wincairo case.
1105         (buildPlatformResultHierarchy):
1106         (readSkippedFiles): Ditto
1107         * Scripts/webkitdirs.pm: Deal with wincairo build case.
1108         (determineConfiguration):
1109
1110 2011-10-05  Chang Shu  <cshu@webkit.org>
1111
1112         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
1113         https://bugs.webkit.org/show_bug.cgi?id=68924
1114
1115         Added TextInputController files and JS interfaces for the above functions.
1116
1117         Reviewed by Darin Adler.
1118
1119         * WebKitTestRunner/DerivedSources.make:
1120         * WebKitTestRunner/DerivedSources.pro:
1121         * WebKitTestRunner/GNUmakefile.am:
1122         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
1123         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1124         (WTR::InjectedBundle::beginTesting):
1125         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1126         (WTR::InjectedBundle::textInputController):
1127         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1128         (WTR::InjectedBundlePage::didClearWindowForFrame):
1129         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
1130         (WTR::TextInputController::create):
1131         (WTR::TextInputController::TextInputController):
1132         (WTR::TextInputController::~TextInputController):
1133         (WTR::TextInputController::wrapperClass):
1134         (WTR::TextInputController::makeWindowObject):
1135         (WTR::TextInputController::setMarkedText):
1136         (WTR::TextInputController::hasMarkedText):
1137         (WTR::TextInputController::unmarkText):
1138         (WTR::TextInputController::insertText):
1139         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
1140         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1141         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1142         * WebKitTestRunner/win/InjectedBundle.vcproj:
1143
1144 2011-10-04  Oliver Hunt  <oliver@apple.com>
1145
1146         Add rudimentary filtering to write barriers
1147         https://bugs.webkit.org/show_bug.cgi?id=69392
1148
1149         Reviewed by Filip Pizlo.
1150
1151         When we're recording gc phase times Heap.o picks up
1152         some exit time destructors, so we'll just ignore Heap.o
1153         in this check.
1154
1155         * Scripts/check-for-exit-time-destructors:
1156
1157 2011-10-05  Chang Shu  <cshu@webkit.org>
1158
1159         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
1160         https://bugs.webkit.org/show_bug.cgi?id=69365
1161
1162         Reviewed by Darin Adler.
1163
1164         Added js API in WTR LayoutTestController.
1165
1166         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1167         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1168         (WTR::LayoutTestController::dumpConfigurationForViewport):
1169         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1170
1171 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1172
1173         [EFL] ImageDiff: Do not clear the image before it is processed and compared
1174         https://bugs.webkit.org/show_bug.cgi?id=69378
1175
1176         Reviewed by Antonio Gomes.
1177
1178         Commit 61836 to Evas added a few cleanup calls to some
1179         evas_object_image functions which effectively made ImageDiff consider
1180         all images to be equal.
1181
1182         It turns out that now evas_object_image_colorspace_set clears any
1183         data set, so the call to evas_object_image_data_set was not having any
1184         effect.
1185
1186         * DumpRenderTree/efl/ImageDiff.cpp:
1187         (readImageFromStdin): Call evas_object_image_data_set after
1188         evas_object_image_colorspace_set.
1189
1190 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
1191
1192         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
1193         https://bugs.webkit.org/show_bug.cgi?id=68449
1194
1195         Reviewed by Antonio Gomes.
1196
1197         evas_render() must be called to close up temporary files and unmap unused
1198         resources. evas_object_image_data_set() must be called after an
1199         evas_object_image_data_get() to balance an internal reference count.
1200
1201         * DumpRenderTree/efl/ImageDiff.cpp:
1202         (differenceImageFromDifferenceBuffer):
1203         (calculateDifference):
1204         (printImage):
1205         (printImageDifferences):
1206
1207 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
1208
1209         [Qt][WK2] Unreviewed build fix.
1210
1211         Don't use WebCore directly in WTR.
1212
1213         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1214         (WTR::PlatformWebView::addChromeInputField):
1215         (WTR::PlatformWebView::removeChromeInputField):
1216         (WTR::PlatformWebView::makeWebViewFirstResponder):
1217
1218 2011-10-05  David Levin  <levin@chromium.org>
1219
1220         watchlist: Add more rules for chromium public api and sort the file.
1221         https://bugs.webkit.org/show_bug.cgi?id=69323
1222
1223         Reviewed by Adam Barth.
1224
1225         * Scripts/webkitpy/common/config/watchlist:
1226
1227 2011-10-05  David Levin  <levin@chromium.org>
1228
1229         watchlist: Don't add the same message to a bug more than once.
1230         https://bugs.webkit.org/show_bug.cgi?id=69303
1231
1232         Reviewed by Adam Barth.
1233
1234         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
1235         if a message is in the comments already.
1236         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
1237         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
1238         Pick a bug supplied by the mock. Change the test due to different output
1239         from the mock watch list tool.
1240         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
1241         another email so it will be filtered out, fix bugs to have the cc and comment fields,
1242         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
1243         to debug).
1244         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
1245         and/or cc's that are already in the bug.
1246         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
1247         and remove a comment that is filtered out.
1248
1249 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
1250
1251         [Qt][WK2] Unreviewed build fix after r96643.
1252
1253         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1254         (WTR::PlatformWebView::addChromeInputField):
1255         (WTR::PlatformWebView::removeChromeInputField):
1256         (WTR::PlatformWebView::makeWebViewFirstResponder):
1257
1258 2011-10-04  Kent Tamura  <tkent@chromium.org>
1259
1260         Introduce feature flags for incomplete input types
1261         https://bugs.webkit.org/show_bug.cgi?id=68971
1262
1263         Reviewed by Hajime Morita.
1264
1265         * Scripts/build-webkit:
1266         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
1267         They are disabled by default.
1268
1269 2011-10-04  Adam Barth  <abarth@webkit.org>
1270
1271         garden-o-matic doesn't launch it's UI on Lion
1272         https://bugs.webkit.org/show_bug.cgi?id=69349
1273
1274         Reviewed by Darin Adler.
1275
1276         It turns out that Lion is a bit more picky about file URLs.  This patch
1277         switches us from using a path to using an actual file URL, silencing
1278         the warning and making the tool actually launch on Lion.
1279
1280         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1281
1282 2011-10-04  Daniel Bates  <dbates@rim.com>
1283
1284         Fix Perl undefined variable warning when using run-safari after
1285         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
1286
1287         Rubber-stamped by Alexey Proskuryakov.
1288
1289         * Scripts/webkitdirs.pm:
1290         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
1291         is defined before using it in a comparison operation.
1292
1293 2011-10-04  Scott Graham  <scottmg@chromium.org>
1294
1295         Add GAMEPAD feature flag
1296         https://bugs.webkit.org/show_bug.cgi?id=66859
1297
1298         Reviewed by Darin Fisher.
1299
1300         * Scripts/build-webkit:
1301
1302 2011-10-04  Jon Lee  <jonlee@apple.com>
1303
1304         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
1305         https://bugs.webkit.org/show_bug.cgi?id=68412
1306         <rdar://problem/9988252>
1307
1308         Reviewed by Darin Adler.
1309
1310         In order to create a test for the bug, I had to update DRT and WKTR to create some
1311         widget that allows first responder status to move away from the main web view.
1312
1313         Three methods were added to layoutTestController: addChromeInputField,
1314         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
1315         that is a sibling to the web view, and sets up the key event loop between the two.
1316         removeChromeInputField removes that field. focusWebView moves first responder
1317         status to the web view.
1318
1319         The test makes the call via layoutTestController and passes a callback that it
1320         assumes will be executed once the task is completed. In DRT the callback is called
1321         synchronously. In WKTR this is handled with message passing between the two
1322         processes.
1323
1324         * DumpRenderTree/LayoutTestController.cpp:
1325         (addChromeInputFieldCallback):
1326         (removeChromeInputFieldCallback):
1327         (focusWebViewCallback):
1328         (LayoutTestController::staticFunctions):
1329         * DumpRenderTree/LayoutTestController.h:
1330         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1331         (LayoutTestController::addChromeInputField):
1332         (LayoutTestController::removeChromeInputField):
1333         (LayoutTestController::focusWebView):
1334         * DumpRenderTree/mac/DumpRenderTree.mm:
1335         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
1336         make sure to remove the chrome input field.
1337         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1338         (LayoutTestController::addChromeInputField):
1339         (LayoutTestController::removeChromeInputField):
1340         (LayoutTestController::focusWebView):
1341         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1342         (LayoutTestController::addChromeInputField):
1343         (LayoutTestController::removeChromeInputField):
1344         (LayoutTestController::focusWebView):
1345         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1346         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1347         (WTR::InjectedBundle::didReceiveMessage):
1348         (WTR::InjectedBundle::postAddChromeInputField):
1349         (WTR::InjectedBundle::postRemoveChromeInputField):
1350         (WTR::InjectedBundle::postFocusWebView):
1351         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1352         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1353         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
1354         through JS.
1355         (WTR::cacheLayoutTestControllerCallback):
1356         (WTR::callLayoutTestControllerCallback):
1357         (WTR::LayoutTestController::addChromeInputField):
1358         (WTR::LayoutTestController::removeChromeInputField):
1359         (WTR::LayoutTestController::focusWebView):
1360         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
1361         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
1362         (WTR::LayoutTestController::callFocusWebViewCallback):
1363         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1364         * WebKitTestRunner/PlatformWebView.h:
1365         * WebKitTestRunner/TestController.cpp:
1366         (WTR::TestController::resetStateToConsistentValues):
1367         * WebKitTestRunner/TestInvocation.cpp:
1368         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1369         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1370         (WTR::PlatformWebView::addChromeInputField):
1371         (WTR::PlatformWebView::removeChromeInputField):
1372         (WTR::PlatformWebView::makeWebViewFirstResponder):
1373         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1374         (WTR::PlatformWebView::addChromeInputField):
1375         (WTR::PlatformWebView::removeChromeInputField):
1376         (WTR::PlatformWebView::makeWebViewFirstResponder):
1377         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1378         (WTR::PlatformWebView::addChromeInputField):
1379         (WTR::PlatformWebView::removeChromeInputField):
1380         (WTR::PlatformWebView::makeWebViewFirstResponder):
1381
1382         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
1383         with the patch-- just cleaning up style.
1384         (LayoutTestController::addDisallowedURL):
1385         (originsArrayToJS):
1386         (LayoutTestController::queueLoad):
1387         (LayoutTestController::setMockDeviceOrientation):
1388         (LayoutTestController::setIconDatabaseEnabled):
1389         (LayoutTestController::setEditingBehavior):
1390
1391 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
1392
1393         Move font-fixup code in WebKitTestRunner to a better place
1394         https://bugs.webkit.org/show_bug.cgi?id=69356
1395
1396         Reviewed by Sam Weinig.
1397         
1398         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
1399         already contains font-related code.
1400
1401         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1402         (WTR::InjectedBundle::initialize):
1403         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1404         (WTR::allowedFontFamilySet):
1405         (WTR::drt_NSFontManager_availableFontFamilies):
1406         (WTR::drt_NSFontManager_availableFonts):
1407         (WTR::swizzleNSFontManagerMethods):
1408         (WTR::activateFonts):
1409         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1410         (WTR::InjectedBundle::platformInitialize):
1411
1412 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
1413
1414         [EFL] DRT: Add DumpRenderTree.cpp
1415         https://bugs.webkit.org/show_bug.cgi?id=62034
1416
1417         Reviewed by Antonio Gomes.
1418
1419         This is the main implementation file for EFL's DumpRenderTree.
1420
1421         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
1422         (dumpFramesAsText):
1423         (dumpFrameScrollPosition):
1424         (shouldLogFrameLoadDelegates):
1425         (shouldDumpAsText):
1426         (sendPixelResultsEOF):
1427         (invalidateAnyPreviousWaitToDumpWatchdog):
1428         (onEcoreEvasResize):
1429         (onCloseWindow):
1430         (useLongRunningServerMode):
1431         (parseCommandLineOptions):
1432         (getFinalTestURL):
1433         (getExpectedPixelHash):
1434         (createLayoutTestController):
1435         (runTest):
1436         (runTestingServerLoop):
1437         (adjustOutputTypeByMimeType):
1438         (dumpFrameContentsAsText):
1439         (shouldDumpFrameScrollPosition):
1440         (shouldDumpPixelsAndCompareWithExpected):
1441         (shouldDumpBackForwardList):
1442         (initEfl):
1443         (shutdownEfl):
1444         (displayWebView):
1445         (dump):
1446         (initEcoreEvas):
1447         (main):
1448
1449 2011-10-03  Adam Barth  <abarth@webkit.org>
1450
1451         garden-o-matic should remove builders from the failure grid once they start to pass
1452         https://bugs.webkit.org/show_bug.cgi?id=69309
1453
1454         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
1455         in reviewing these patches.
1456
1457         This patch follows the update/purge model from UpdateTracker.  This
1458         patch is less awesome than it could be because it causes the UI to
1459         flash slightly.  In a future patch, we'll want to use these
1460         update/purge notifications to update the UI without flashing.  However,
1461         that's not such a big deal because this UI is hidden in the default
1462         view.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1468
1469 2011-10-03  David Levin  <levin@chromium.org>
1470
1471         webkitpy: Expose cc_emails and comments from bug.py
1472         https://bugs.webkit.org/show_bug.cgi?id=69308
1473
1474         Reviewed by Adam Barth.
1475
1476         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
1477         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
1478         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
1479         to comments being exposed.
1480
1481 2011-10-03  James Robinson  <jamesr@chromium.org>
1482
1483         Add myself to the watchlist for platform/graphics/chromium
1484         https://bugs.webkit.org/show_bug.cgi?id=69297
1485
1486         Reviewed by David Levin.
1487
1488         * Scripts/webkitpy/common/config/watchlist:
1489
1490 2011-10-03  Anders Carlsson  <andersca@apple.com>
1491
1492         Remove custom scrollbar painting hooks
1493         https://bugs.webkit.org/show_bug.cgi?id=69163
1494
1495         Reviewed by Alexey Proskuryakov.
1496
1497         * DumpRenderTree/chromium/WebPreferences.cpp:
1498         (WebPreferences::applyTo):
1499         No need to enable custom scrollbar painting.
1500
1501 2011-10-03  David Levin  <levin@chromium.org>
1502
1503         watchlist: Make watchlist run on a bot.
1504         https://bugs.webkit.org/show_bug.cgi?id=68974
1505
1506         Reviewed by Adam Barth.
1507
1508         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
1509         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1510         Change to log what is run so that we can see the style command
1511         and the watchlist command being run.
1512
1513 2011-10-03  David Levin  <levin@chromium.org>
1514
1515         watchlist: Allow specified a bug to attach the watchlist info to.
1516         https://bugs.webkit.org/show_bug.cgi?id=69288
1517
1518         Reviewed by Eric Seidel.
1519
1520         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
1521         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
1522         Add tests and fix an existing test because the unit tests do not go through the
1523         normal command line processing (so the -g argument remained when we determined bug ids).
1524         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
1525         get the assert raises regex method.
1526         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
1527
1528 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
1529
1530         [EFL] DRT: Add JSStringUtils.{cpp,h}
1531         https://bugs.webkit.org/show_bug.cgi?id=66397
1532
1533         Reviewed by Ryosuke Niwa.
1534         
1535         Adds helper functions to compare the equality of C-style strings and
1536         JSStringRef objects.
1537
1538         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
1539         (equals):
1540         * DumpRenderTree/efl/JSStringUtils.h: Added.
1541
1542 2011-10-03  Adam Barth  <abarth@webkit.org>
1543
1544         garden-o-matic should work in Safari 5.1
1545         https://bugs.webkit.org/show_bug.cgi?id=69290
1546
1547         Reviewed by Sam Weinig.
1548
1549         My old implementation of bind was too clever by half.  This one seems
1550         to work better, at least according to this test.
1551
1552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1554
1555 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1556
1557         Unreviewed: change my e-mail in commiters.py
1558
1559         (I'm leaving the company and my @openbossa.org will be no more)
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1562
1563 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
1564
1565         Correct post-build step for WinCairo test runs.
1566         https://bugs.webkit.org/show_bug.cgi?id=69191 
1567
1568         Reviewed by Brian Weinstein.
1569
1570         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
1571         shell case to handle the CFLite build.
1572
1573 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
1574
1575         Added myself to reviewers, because I'm now a reviewer.
1576
1577         * Scripts/webkitpy/common/config/committers.py:
1578
1579 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
1580
1581         Bencher script makes it difficult to do automated performance testing
1582         https://bugs.webkit.org/show_bug.cgi?id=69207
1583
1584         Reviewed by Sam Weinig.
1585         
1586         This adds two new features:
1587         
1588         The ability to disable automatic VM detection, which is flaky if any
1589         profiling features are enabled in jsc.
1590         
1591         The ability to compute, and report, a scaled result for all benchmark
1592         suites. It is the geometric mean of three numbers: SunSpider's
1593         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
1594         It is also possible to turn off all other output from bencher and just
1595         get this number with the --brief option.
1596
1597         * Scripts/bencher:
1598
1599 2011-10-01  Sam Weinig  <sam@webkit.org>
1600
1601         WTR is not successfully changing the NSUserDefaults
1602         https://bugs.webkit.org/show_bug.cgi?id=69204
1603
1604         Reviewed by Dan Bernstein.
1605
1606         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1607         (WTR::InjectedBundle::platformInitialize):
1608         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
1609         get our overrides picked up.
1610
1611 2011-09-30  Daniel Bates  <dbates@rim.com>
1612
1613         Cleanup: Extract code to launch a Mac WebKit application into a common function
1614         https://bugs.webkit.org/show_bug.cgi?id=68662
1615
1616         Reviewed by Adam Roben.
1617
1618         Extracts common code to launch a WebKit application on Mac OS X into a function
1619         so that we can remove duplicate code.
1620
1621         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
1622         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
1623         (runMacWebKitApp): Added.
1624         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
1625         (runMiniBrowser): Ditto.
1626         (runWebKitTestRunner): Ditto.
1627         (runTestWebKitAPI): Ditto.
1628
1629 2011-09-29  David Levin  <levin@chromium.org>
1630
1631         watchlist: Add webkit-patch command to run watchlist.
1632         https://bugs.webkit.org/show_bug.cgi?id=68973
1633
1634         Reviewed by Eric Seidel.
1635
1636         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
1637         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
1638         the cc and messages as sorted lists. To allow for deterministic ordering.
1639         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
1640         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
1641         that it will be exposed as a command by webkit-patch.
1642         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
1643         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
1644         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
1645         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
1646         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
1647         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
1648         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
1649         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
1650
1651 2011-09-30  David Levin  <levin@chromium.org>
1652
1653         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
1654         https://bugs.webkit.org/show_bug.cgi?id=69031
1655
1656         Reviewed by Adam Barth.
1657
1658         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
1659         a comment to explain something important about the email addresses, and
1660         a comment to let emacs know to treat the file as a python file.
1661         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
1662         Detects increases or decreases in a pattern.
1663         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
1664         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1665         Added unit tests for watchlist which has "more" or "less".
1666         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1667         Added support for "more" or "less".
1668
1669 2011-09-30  Sam Weinig  <sam@webkit.org>
1670
1671         Add support for eventSender.mouseScrollBy in WTR
1672         https://bugs.webkit.org/show_bug.cgi?id=69189
1673
1674         Add implementation of eventSender.mouseScrollBy for the mac.
1675
1676         Reviewed by Simon Fraser.
1677
1678         * WebKitTestRunner/EventSenderProxy.h:
1679         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1680         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1681         (WTR::EventSendingController::keyDown):
1682         (WTR::EventSendingController::mouseScrollBy):
1683         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1684         * WebKitTestRunner/TestController.cpp:
1685         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1686         * WebKitTestRunner/mac/EventSenderProxy.mm:
1687         (WTR::EventSenderProxy::mouseScrollBy):
1688
1689 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
1690
1691         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
1692         https://bugs.webkit.org/show_bug.cgi?id=35273
1693
1694         Reviewed by Dan Bernstein.
1695         
1696         There are two types of font issue that can cause layout test failure.
1697         First, the user may have non-standard fonts installed that affect the layout
1698         of some tests. For example, some tests use the MS Gothic font if installed.
1699         
1700         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
1701         which override the system fonts (e.g. a copy of Arial from MS Office). For
1702         some tests, this can affect font metrics or fallback behavior.
1703         
1704         This change addresses the first problem only. It limits the set of fonts
1705         available through NSFontManager, by swizzling some methods to return
1706         a list of fonts or font families which only include fonts from a hardcoded
1707         whitelist.
1708         
1709         * DumpRenderTree/mac/DumpRenderTree.mm:
1710         (allowedFontFamilySet):
1711         (drt_NSFontManager_availableFontFamilies):
1712         (drt_NSFontManager_availableFonts):
1713         (swizzleNSFontManagerMethods):
1714         (activateTestingFonts):
1715         (adjustFonts):
1716         (createWebViewAndOffscreenWindow):
1717         (prepareConsistentTestingEnvironment):
1718         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1719         (WTR::allowedFontFamilySet):
1720         (WTR::drt_NSFontManager_availableFontFamilies):
1721         (WTR::drt_NSFontManager_availableFonts):
1722         (WTR::swizzleNSFontManagerMethods):
1723         (WTR::InjectedBundle::platformInitialize):
1724
1725 2011-09-30  David Levin  <levin@chromium.org>
1726
1727         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
1728         https://bugs.webkit.org/show_bug.cgi?id=69039
1729
1730         Reviewed by Adam Barth.
1731
1732         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1733         Actually skip only one specific test that is failing on Windows.
1734
1735 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1736
1737         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
1738
1739         For DRT we didn't install the message handler early enough to
1740         catch output while constructing the QApplication. For WTR we
1741         didn't even install a message handler.
1742
1743         Since the UI process will forward any output from the web process
1744         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
1745         in WTR before the web process is started. This is picked up by the
1746         web process which installs its own message handler.
1747
1748         The environment variable can be overriden on the command line if you
1749         want to see output from the web process, or you can pass --verbose to
1750         WTR to see output from both processes.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=69132
1753
1754         Reviewed by Andreas Kling.
1755
1756         * DumpRenderTree/qt/main.cpp:
1757         * WebKitTestRunner/qt/main.cpp:
1758
1759 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1760
1761         [Qt] Make sure WTR sizes the window and item correctly
1762
1763         Revision 96345 changed the logic for how the view and
1764         window was created, but missed a vital part, setting
1765         the size.
1766
1767         We now use a QSGView for the window, that has a simple
1768         item as its root object that is always resized to fit
1769         within the window. The webview is then parented to the
1770         root object and set to anchors.fill: parent. That way
1771         any window geometry changes will propagate to the web
1772         view.
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=69134
1775
1776         Reviewed by Andreas Kling.
1777
1778         * WebKitTestRunner/PlatformWebView.h:
1779         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1780
1781 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
1782
1783         [EFL] Only save the current viewport in PixelDumpSupportEfl.
1784         https://bugs.webkit.org/show_bug.cgi?id=68450
1785
1786         Reviewed by Antonio Gomes.
1787
1788         The previous implementation saved the whole page contents in the final
1789         PNG, however the baselines and expectations in the tree only want the
1790         current viewport (with a scrollbar, if needed), so we now only save the
1791         currently visible contents.
1792
1793         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1794         (createBitmapContextFromWebView): Use
1795         ewk_frame_visible_content_geometry_get instead of
1796         ewk_frame_contents_size_get.
1797
1798 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
1799
1800         [EFL] Support and keep track of extra windows (views).
1801         https://bugs.webkit.org/show_bug.cgi?id=68454
1802
1803         Reviewed by Antonio Gomes.
1804
1805         So far, window.open and related JavaScript code would not work, as
1806         DRTView did not implementation
1807         Ewk_View_Smart_Class::window_{open,close}. The default implementation
1808         in ewk just returns the current window/view, which broke any
1809         layouttest which relied on window.open.
1810
1811         We now properly create and remove these new views. Unfortunately, the
1812         current way ewk works (and due to the fact that we cannot pass class
1813         methods as function pointers to the EFL functions), DRTView needs to
1814         know that DRTChrome exists and call `browser' directly in some points.
1815
1816         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1817         (onWindowCreate):
1818         (onWindowCloseDelayed):
1819         (onWindowClose):
1820         (drtViewTiledAdd):
1821
1822 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
1823
1824         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
1825         https://bugs.webkit.org/show_bug.cgi?id=42698
1826
1827         Reviewed by Andreas Kling.
1828
1829         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
1830         and call clearApplicationCache when layoutTest start up.
1831
1832         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1833         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1834         (WTR::InjectedBundle::beginTesting):
1835         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1836         (WTR::LayoutTestController::clearAllApplicationCaches):
1837         (WTR::LayoutTestController::setAppCacheMaximumSize):
1838         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1839
1840 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
1841
1842         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
1843         https://bugs.webkit.org/show_bug.cgi?id=69145
1844
1845         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
1846         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
1847         and is perfectly suitable for SceneGraph as well. GraphicsScene events
1848         will not be available in QtGui anymore in future. Therefore we also have to change
1849         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
1850
1851         Reviewed by Chang Shu.
1852
1853         * WebKitTestRunner/EventSenderProxy.h:
1854         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1855         (WTR::EventSenderProxy::createMouseEvent):
1856         (WTR::EventSenderProxy::mouseDown):
1857         (WTR::EventSenderProxy::mouseUp):
1858         (WTR::EventSenderProxy::mouseMoveTo):
1859
1860 2011-09-30  James Robinson  <jamesr@chromium.org>
1861
1862         [chromium] Add WebKit API for sending input events to the compositor thread
1863         https://bugs.webkit.org/show_bug.cgi?id=69117
1864
1865         Reviewed by Darin Fisher.
1866
1867         Adds support for creating and setting a compositor thread in DRT.
1868
1869         * DumpRenderTree/chromium/WebViewHost.cpp:
1870         (WebViewHost::WebViewHost):
1871         * DumpRenderTree/chromium/WebViewHost.h:
1872
1873 2011-09-29  David Levin  <levin@chromium.org>
1874
1875         watchlist: Add cross-checks for WatchList once it is filled.
1876         https://bugs.webkit.org/show_bug.cgi?id=68975
1877
1878         Reviewed by Eric Seidel.
1879
1880         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
1881         instead of having trivial getter and setters.
1882         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
1883         pass the validation checks.
1884         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
1885         and fix a few style nits.
1886         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
1887         validation checks.
1888         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
1889
1890 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
1891
1892         run-api-tests fails on chromium-win bot
1893         https://bugs.webkit.org/show_bug.cgi?id=69121
1894
1895         On Windows running a perl script needs the interpreter.
1896
1897         Reviewed by Adam Barth.
1898
1899         * Scripts/run-api-tests:
1900         (buildTestTool):
1901
1902 2011-09-29  Adam Barth  <abarth@webkit.org>
1903
1904         Attempt to make this tool work on Windows.
1905
1906         * Scripts/run-api-tests:
1907         (buildTestTool):
1908
1909 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1910
1911         [Qt] Try to fix the minial build
1912
1913         * QtTestBrowser/launcherwindow.cpp:
1914         * QtTestBrowser/webpage.cpp:
1915
1916 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1917
1918         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1919
1920         QWidget and friends now live in the QtWidgets library. We update
1921         includes in implementation files and private headers to us the
1922         non-module-prefixed path, and leave the lookup for the include
1923         path. For public headers we have to ifdef the includes as the
1924         user might now have the modules we need in his QT config.
1925
1926         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1927         have to update our code and use windowHandle() for setting the
1928         parent relationships.
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=68687
1931
1932         Reviewed by Andreas Kling.
1933
1934         * DumpRenderTree/qt/DumpRenderTree.pro:
1935         * DumpRenderTree/qt/ImageDiff.pro:
1936         * MiniBrowser/qt/BrowserView.cpp:
1937         * MiniBrowser/qt/BrowserView.h:
1938         * MiniBrowser/qt/BrowserWindow.cpp:
1939         * MiniBrowser/qt/BrowserWindow.h:
1940         * MiniBrowser/qt/MiniBrowser.pro:
1941         * MiniBrowser/qt/MiniBrowserApplication.h:
1942         * MiniBrowser/qt/main.cpp:
1943         * QtTestBrowser/QtTestBrowser.pro:
1944         * QtTestBrowser/launcherwindow.cpp:
1945         * QtTestBrowser/launcherwindow.h:
1946         * QtTestBrowser/locationedit.h:
1947         * QtTestBrowser/main.cpp:
1948         * QtTestBrowser/mainwindow.cpp:
1949         * QtTestBrowser/mainwindow.h:
1950         * QtTestBrowser/webinspector.h:
1951         * QtTestBrowser/webpage.cpp:
1952         * QtTestBrowser/webview.cpp:
1953         * WebKitTestRunner/PlatformWebView.h:
1954         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1955
1956 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
1957
1958         Initial implementation of WebInspector for WebKit2 GTK port.
1959         https://bugs.webkit.org/show_bug.cgi?id=68235
1960
1961         Reviewed by Martin Robinson.
1962
1963         * MiniBrowser/gtk/BrowserWindow.c:
1964         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
1965
1966 2011-09-29  Adam Barth  <abarth@webkit.org>
1967
1968         Unbreak the "update expectatations" button by using the existing
1969         machinery to create the failureInfo objects.
1970
1971         Unbreak the "close" button on the progress dialog by using |this|
1972         instead of the old name of the object.
1973
1974         Teach the controllers unit test not to talk to the actual network.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
1978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1979
1980 2011-09-29  Hans Wennborg  <hans@chromium.org>
1981
1982         IndexedDB: Use LevelDB also for in-memory databases
1983         https://bugs.webkit.org/show_bug.cgi?id=68903
1984
1985         Reviewed by Steve Block.
1986
1987         Remove the temporary dir that was necessary before LevelDB supported
1988         in-memory databases.
1989
1990         * DumpRenderTree/chromium/TestShell.cpp:
1991         (TestShell::TestShell):
1992         * DumpRenderTree/chromium/TestShell.h:
1993
1994 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1995
1996         Run TestWebKitAPI on Chromium buildbots
1997         https://bugs.webkit.org/show_bug.cgi?id=68678
1998
1999         Reviewed by Tony Chang.
2000
2001         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2002
2003 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
2004
2005         garden-o-matic results should anticipate 0 unexpected failures.
2006         https://bugs.webkit.org/show_bug.cgi?id=69036
2007
2008         Also fixes controllers: UnexpectedFailures test.
2009
2010         Reviewed by Adam Barth.
2011
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
2013
2014 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
2015
2016         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
2017
2018         https://bugs.webkit.org/show_bug.cgi?id=67253
2019
2020         Reviewed by Eric Seidel.
2021
2022         Nearly all of the work in this was done by Simon Fraser; I'm
2023         just repackaging it and cleaning it up a bit. This change
2024         modifies port.diff_image() to return a tuple of (pass/fail,
2025         %age), adds the value to the FailureImageHashMismatch, and
2026         writes the value into the full_results.json files to be
2027         displayed in the results page.
2028
2029         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2030         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2031         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2032         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2033         * Scripts/webkitpy/layout_tests/port/base.py:
2034         * Scripts/webkitpy/layout_tests/port/chromium.py:
2035         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2036         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2037         * Scripts/webkitpy/layout_tests/port/test.py:
2038         * Scripts/webkitpy/layout_tests/port/webkit.py:
2039         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2040
2041 2011-09-25  Kentaro Hara  <haraken@chromium.org>
2042
2043         Unreviewed. Adding myself to committers.py.
2044
2045         * Scripts/webkitpy/common/config/committers.py:
2046
2047 2011-09-28  Adam Barth  <abarth@webkit.org>
2048
2049         garden-o-matic shouldn't depend on test-results.appspot.com
2050         https://bugs.webkit.org/show_bug.cgi?id=69019
2051
2052         Reviewed by Dimitri Glazkov.
2053
2054         This patch moves garden-o-matic from getting full_results.json from
2055         test-results.appspot.com to getting that information directly from the
2056         buildbot.  This patch improve the load time and accuracy of
2057         garden-o-matic because test-results.appspot.com is slow and is dropping
2058         a significant number of writes (see
2059         https://bugs.webkit.org/show_bug.cgi?id=68748).
2060
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2064
2065 2011-09-28  David Levin  <levin@chromium.org>
2066
2067         watchlist: Add a way to load the watchlist from config.
2068         https://bugs.webkit.org/show_bug.cgi?id=68991
2069
2070         Reviewed by Eric Seidel.
2071
2072         * Scripts/webkitpy/common/config/watchlist: Added.
2073         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
2074         Support for loading the watch list.
2075         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
2076         Tests for the loading.
2077         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2078         Adjusted to use the common base class.
2079         * Scripts/webkitpy/common/webkitunittest.py: Added.
2080         Made a common base class for functionality used in more than one.
2081
2082 2011-09-28  David Levin  <levin@chromium.org>
2083
2084         Attempt fix for Leopard python unit test run.
2085
2086         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2087
2088 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
2089
2090         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
2091         https://bugs.webkit.org/show_bug.cgi?id=68938
2092
2093         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
2094
2095         Reviewed by David Hyatt.
2096
2097         * DumpRenderTree/chromium/WebViewHost.cpp:
2098         (WebViewHost::didUpdateLayout): Added width/height queries.
2099         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
2100
2101 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
2102
2103         Get rebaseline server running again
2104         https://bugs.webkit.org/show_bug.cgi?id=69020
2105
2106         Reviewed by Adam Barth.
2107
2108         Make rebaseline server run again after r90337 (missing format_date_time
2109         import, results_json wasn't outputting anything).
2110
2111         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2112         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2113
2114 2011-09-28  David Grogan  <dgrogan@chromium.org>
2115
2116         Move dgrogan from contributor to committer
2117         https://bugs.webkit.org/show_bug.cgi?id=69021
2118
2119         * Scripts/webkitpy/common/config/committers.py:
2120
2121 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
2122
2123         Add Mac Skia GPU bots to builders.py
2124         https://bugs.webkit.org/show_bug.cgi?id=69016
2125
2126         Reviewed by Eric Seidel.
2127
2128         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
2129         GPU tests.
2130
2131         * Scripts/webkitpy/layout_tests/port/builders.py:
2132         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2133
2134 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2135
2136         Second try at fixing the GTK+ build.
2137
2138         * GNUmakefile.am:
2139
2140 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
2141
2142         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
2143         https://bugs.webkit.org/show_bug.cgi?id=68680
2144
2145         Reviewed by Tony Chang.
2146
2147         * Scripts/run-chromium-webkit-unit-tests:
2148         * Scripts/webkitdirs.pm:
2149         (determineBaseProductDir):
2150
2151 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2152
2153         [Gtk] Implement textInputController.doCommand
2154         https://bugs.webkit.org/show_bug.cgi?id=66496
2155
2156         Reviewed by Martin Robinson.
2157
2158         * DumpRenderTree/gtk/TextInputController.cpp:
2159         (doCommandCallback): Callback function for textInputController.doCommand
2160
2161 2011-09-28  David Levin  <levin@chromium.org>
2162
2163         watchlist: Suggest corrections for typos and improve error message consistency.
2164         https://bugs.webkit.org/show_bug.cgi?id=68976
2165
2166         Reviewed by Adam Barth.
2167
2168         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
2169         for typos and improve consistency of the error messages.
2170         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
2171         and improve the regex that were already present.
2172
2173 2011-09-28  David Levin  <levin@chromium.org>
2174
2175         watchlist: Add support for matching added or deleted lines.
2176         https://bugs.webkit.org/show_bug.cgi?id=68972
2177
2178         Reviewed by Adam Barth.
2179
2180         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
2181         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
2182         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
2183         to the pattern match to only have the diff lines instead of the DiffFile.
2184         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2185         Add tests for the new patterns and combinations of the patterns.
2186         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2187         Sort imports. Add changeline support.
2188
2189 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
2190
2191         [GTK] Add WebKitError to GTK+ WebKit2 API
2192         https://bugs.webkit.org/show_bug.cgi?id=68508
2193
2194         Reviewed by Martin Robinson.
2195
2196         * GNUmakefile.am: Add path to webkitgtk derived sources to the
2197         include path.
2198
2199 2011-09-28  Philippe Normand  <pnormand@igalia.com>
2200
2201         [GTK] missing WebKit2 support in run-gtk-tests
2202         https://bugs.webkit.org/show_bug.cgi?id=68992
2203
2204         Rubber-stamped by Andreas Kling.
2205
2206         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
2207         webkit2 directory.
2208
2209 2011-09-27  Philippe Normand  <pnormand@igalia.com>
2210
2211         [GTK] build-webkit --no-webkit2 still builds WebKit2
2212         https://bugs.webkit.org/show_bug.cgi?id=68892
2213
2214         Reviewed by Martin Robinson.
2215
2216         Take the --no-webkit2 option in account when building WebKitGTK+.
2217
2218         * Scripts/build-webkit:
2219         * Scripts/webkitdirs.pm:
2220         (buildAutotoolsProject):
2221         (buildGtkProject):
2222
2223 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
2224
2225         Make Chromium Win Release (Tests) a core builder
2226         https://bugs.webkit.org/show_bug.cgi?id=68906
2227
2228         Reviewed by Adam Barth.
2229
2230         Add Chromium Win Release (Tests) to the list of core builders.
2231
2232         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2233         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2234
2235 2011-09-27  Adam Barth  <abarth@webkit.org>
2236
2237         garden-o-matic should load faster and inform the user what is happening
2238         https://bugs.webkit.org/show_bug.cgi?id=68954
2239
2240         Reviewed by Dimitri Glazkov.
2241
2242         This test disables the expected failures tab.  The web inspector showed
2243         that loading the data for this tab was slowing down the loading time
2244         for the whole app.  We need to find a way to load that data lazily.
2245
2246         This patch also improves the update message to better describe the
2247         progress the app is making analyzing data from the buildbot.
2248
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2252
2253 2011-09-27  Adam Barth  <abarth@webkit.org>
2254
2255         garden-o-matic should show the first result when examining results
2256         https://bugs.webkit.org/show_bug.cgi?id=68960
2257
2258         Reviewed by Dimitri Glazkov.
2259
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2261
2262 2011-09-27  David Levin  <levin@chromium.org>
2263
2264         watchlist: Add support for cc and message rules.
2265         https://bugs.webkit.org/show_bug.cgi?id=68950
2266
2267         Reviewed by Adam Barth.
2268
2269         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
2270         the cc's and messages for a patch.
2271         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
2272         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
2273         for the rules.
2274         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
2275         A generic encapsulation of either a message list or a cc list.
2276         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
2277
2278 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
2279
2280         webkit-patch doesn't like UTF-8 characters in reviewers names
2281         https://bugs.webkit.org/show_bug.cgi?id=63452
2282
2283         Reviewed by Eric Seidel.
2284
2285         * Scripts/webkit-patch:
2286
2287 2011-09-27  Adam Barth  <abarth@webkit.org>
2288
2289         garden-o-matic examine buttons shows both expected and unexpected failures
2290         https://bugs.webkit.org/show_bug.cgi?id=68918
2291
2292         Reviewed by Dimitri Glazkov.
2293
2294         This was a copy/paste error when I refactored this classes to share
2295         more code.
2296
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2298
2299 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
2300
2301         Add Kaustubh Atrawalkar to the list of contributors.
2302
2303         * Scripts/webkitpy/common/config/committers.py:
2304
2305 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
2306
2307         [Chromium] Fixed layout mode tests break subsequent tests
2308         https://bugs.webkit.org/show_bug.cgi?id=68923
2309         
2310         Reviewed by Adam Barth.        
2311
2312         Reset fixed layout mode between tests, so that tests that run after
2313         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
2314         regular 800x600 non-fixed layout.
2315
2316         * DumpRenderTree/chromium/TestShell.cpp:
2317         (TestShell::resetTestController):
2318
2319 2011-09-27  David Levin  <levin@chromium.org>
2320
2321         watchlist: Add the filename pattern for definitions.
2322         https://bugs.webkit.org/show_bug.cgi?id=68917
2323
2324         Reviewed by Adam Barth.
2325
2326         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
2327         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
2328         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
2329         for definitions.
2330         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
2331         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
2332
2333 2011-09-27  Adam Barth  <abarth@webkit.org>
2334
2335         garden-o-matic results view should sort test and builder names
2336         https://bugs.webkit.org/show_bug.cgi?id=68488
2337
2338         Reviewed by Andy Estes.
2339
2340         Previously, the test and builder names were displayed in an arbitrary
2341         order that changed from time to time.  That confused one user study
2342         participant.  This patch sorts the lists so that they occur in a
2343         predictable order.
2344
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2346
2347 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2348
2349         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
2350         http://trac.webkit.org/changeset/96108
2351         http://trac.webkit.org/changeset/96111
2352         http://trac.webkit.org/changeset/96113
2353         http://trac.webkit.org/changeset/96116
2354         https://bugs.webkit.org/show_bug.cgi?id=68913
2355
2356         Wait for working Qt5 (Requested by ossy on #webkit).
2357
2358         * DumpRenderTree/qt/DumpRenderTree.pro:
2359         * DumpRenderTree/qt/ImageDiff.pro:
2360         * MiniBrowser/qt/BrowserView.cpp:
2361         (BrowserView::BrowserView):
2362         * MiniBrowser/qt/BrowserView.h:
2363         * MiniBrowser/qt/BrowserWindow.cpp:
2364         (BrowserWindow::BrowserWindow):
2365         (BrowserWindow::urlChanged):
2366         (BrowserWindow::~BrowserWindow):
2367         * MiniBrowser/qt/BrowserWindow.h:
2368         * MiniBrowser/qt/MiniBrowser.pro:
2369         * MiniBrowser/qt/MiniBrowserApplication.h:
2370         * MiniBrowser/qt/main.cpp:
2371         * QtTestBrowser/QtTestBrowser.pro:
2372         * QtTestBrowser/launcherwindow.cpp:
2373         * QtTestBrowser/launcherwindow.h:
2374         * QtTestBrowser/locationedit.h:
2375         * QtTestBrowser/main.cpp:
2376         * QtTestBrowser/mainwindow.cpp:
2377         * QtTestBrowser/mainwindow.h:
2378         * QtTestBrowser/webinspector.h:
2379         * QtTestBrowser/webpage.cpp:
2380         * QtTestBrowser/webview.cpp:
2381         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2382         * WebKitTestRunner/PlatformWebView.h:
2383         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2384         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2385         (WTR::WebView::wkView):
2386         (WTR::WebView::pageRef):
2387         (WTR::WebView::~WebView):
2388         (WTR::WebView::WebView):
2389         (WTR::PlatformWebView::PlatformWebView):
2390         (WTR::PlatformWebView::sendEvent):
2391         (WTR::PlatformWebView::postEvent):
2392         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2393
2394 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2395
2396         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
2397         https://bugs.webkit.org/show_bug.cgi?id=65178
2398
2399         Reviewed by Martin Robinson.
2400
2401         * GNUmakefile.am:
2402         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
2403
2404 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
2405
2406         [Qt][WK2] Buildfix after r96108.
2407
2408         Rubber-stamped by Andreas Kling.
2409
2410         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2411         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2412         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2413
2414 2011-09-27  David Levin  <levin@chromium.org>
2415
2416         watchlist: Change watchlistparser.py to be class based.
2417         https://bugs.webkit.org/show_bug.cgi?id=68869
2418
2419         Reviewed by Eric Seidel.
2420
2421         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2422         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2423
2424 2011-09-27  David Levin  <levin@chromium.org>
2425
2426         watchlist: Break out the diff boilerplate to allow for re-use.
2427         https://bugs.webkit.org/show_bug.cgi?id=68871
2428
2429         Reviewed by Eric Seidel.
2430
2431         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2432         Break out the diff into a new file.
2433         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
2434
2435 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
2436
2437         Web Inspector: UI performance: introduce heap size tracking stats.
2438         https://bugs.webkit.org/show_bug.cgi?id=68901
2439
2440         It is interesting how much the heap memory is used by Inspector in order of running the test.
2441
2442         Reviewed by Yury Semikhatsky.
2443
2444         * DumpRenderTree/chromium/TestShell.cpp:
2445         (TestShell::showDevTools):
2446         (TestShell::closeDevTools):
2447
2448 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2449
2450         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
2451
2452         QWidget and friends now live in the QtWidgets library. We update
2453         includes in implementation files and private headers to us the
2454         non-module-prefixed path, and leave the lookup for the include
2455         path. For public headers we have to ifdef the includes as the
2456         user might now have the modules we need in his QT config.
2457
2458         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
2459         have to update our code and use windowHandle() for setting the
2460         parent relationships.
2461
2462         https://bugs.webkit.org/show_bug.cgi?id=68687
2463
2464         Reviewed by Andreas Kling.
2465
2466         * DumpRenderTree/qt/DumpRenderTree.pro:
2467         * DumpRenderTree/qt/ImageDiff.pro:
2468         * MiniBrowser/qt/BrowserView.cpp:
2469         * MiniBrowser/qt/BrowserView.h:
2470         * MiniBrowser/qt/BrowserWindow.cpp:
2471         * MiniBrowser/qt/BrowserWindow.h:
2472         * MiniBrowser/qt/MiniBrowser.pro:
2473         * MiniBrowser/qt/MiniBrowserApplication.h:
2474         * MiniBrowser/qt/main.cpp:
2475         * QtTestBrowser/QtTestBrowser.pro:
2476         * QtTestBrowser/launcherwindow.cpp:
2477         * QtTestBrowser/launcherwindow.h:
2478         * QtTestBrowser/locationedit.h:
2479         * QtTestBrowser/main.cpp:
2480         * QtTestBrowser/mainwindow.cpp:
2481         * QtTestBrowser/mainwindow.h:
2482         * QtTestBrowser/webinspector.h:
2483         * QtTestBrowser/webpage.cpp:
2484         * QtTestBrowser/webview.cpp:
2485         * WebKitTestRunner/PlatformWebView.h:
2486         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2487
2488 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2489
2490         [Qt][WK2] Add support for hover API in Qt WebKit2
2491         https://bugs.webkit.org/show_bug.cgi?id=68369
2492
2493         Reviewed by Andreas Kling.
2494
2495         Change the statusbar to show the link URL when hovering links in
2496         MiniBrowser using QDesktopWebView.
2497
2498         * MiniBrowser/qt/BrowserWindow.cpp:
2499         (BrowserWindow::BrowserWindow):
2500         (BrowserWindow::onLinkHovered):
2501         * MiniBrowser/qt/BrowserWindow.h:
2502
2503 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
2504
2505         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
2506         https://bugs.webkit.org/show_bug.cgi?id=68864
2507
2508         Reviewed by Adam Barth.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
2513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
2514
2515 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2516
2517         [Qt][WK2] One more unreviewed buildfix after r96005.
2518
2519         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
2520
2521 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2522
2523         [Qt][WK2] Unreviewed buildfix after r96005.
2524
2525         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2526         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2527
2528 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
2529
2530         garden-o-matic should be pretty in Open Sans.
2531         https://bugs.webkit.org/show_bug.cgi?id=68845
2532
2533         Reviewed by Adam Barth.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
2536
2537 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
2538
2539         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
2540         https://bugs.webkit.org/show_bug.cgi?id=68841
2541
2542         Reviewed by Adam Barth.
2543
2544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
2545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
2546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
2547
2548 2011-09-26  David Levin  <levin@chromium.org>
2549
2550         watchlist: Add parsing for definition section.
2551         https://bugs.webkit.org/show_bug.cgi?id=68850
2552
2553         Reviewed by Adam Barth.
2554
2555         * Scripts/webkitpy/common/watchlist/watchlist.py:
2556         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
2557         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
2558
2559 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
2560
2561         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
2562
2563         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2564         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2565         * WebKitTestRunner/win/TestInvocationWin.cpp:
2566         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2567
2568 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
2569
2570         Repaint tests don't work in WebKit2
2571         https://bugs.webkit.org/show_bug.cgi?id=68453
2572
2573         Reviewed by Sam Weinig.
2574         
2575         Convert DumpRenderTree to use use the repaint rects
2576         exposed via WebKit API when generating the repaint test
2577         overlay.
2578         
2579         Fix WebKitTestRunner to work with repaint tests, again
2580         using the repaint rects exposed from WK2.
2581         
2582         In both cases, layoutTestController.display() now just
2583         forces a display of the web view, and turns on repaint
2584         rect tracking on the main FrameView.
2585         
2586         Later, when pixel results are requested, the alpha overlay
2587         that shows the repaint rects is generated using the list
2588         of rects supplied by WebCore.
2589
2590         * DumpRenderTree/mac/DumpRenderTree.mm:
2591         (resetDefaultsToConsistentValues):
2592         (resetWebViewToConsistentStateBeforeTesting):
2593         (displayWebView):
2594         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2595         (paintRepaintRectOverlay):
2596         (createBitmapContextFromWebView):
2597         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2598         (WTR::InjectedBundle::beginTesting):
2599         (WTR::InjectedBundle::done):
2600         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2601         (WTR::InjectedBundle::setRepaintRects):
2602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2603         (WTR::InjectedBundlePage::reset):
2604         (WTR::InjectedBundlePage::dump):
2605         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2606         (WTR::LayoutTestController::display):
2607         * WebKitTestRunner/TestInvocation.cpp:
2608         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2609         * WebKitTestRunner/TestInvocation.h:
2610         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2611         (WTR::paintRepaintRectOverlay):
2612         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2613
2614 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
2615
2616         Get hover'ed element URL from HitTest.
2617
2618         mouseDidMoveOverElement now gets the hover'ed element link using
2619         WKHitTestResult API's.
2620         https://bugs.webkit.org/show_bug.cgi?id=68426 
2621
2622         Reviewed by Anders Carlsson.
2623
2624         * MiniBrowser/gtk/BrowserWindow.c:
2625         (mouseDidMoveOverElement):
2626
2627 2011-09-26  David Levin  <levin@chromium.org>
2628
2629         Add skeleton parsing for a WatchList.
2630         https://bugs.webkit.org/show_bug.cgi?id=68823
2631
2632         Reviewed by Adam Barth.
2633
2634         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
2635         Parses the top level watch list sections -- none are defined yet -- and
2636         throws an exception if an invalid one is listed.
2637         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
2638         Verify the exception for an invalid section in a watch list.
2639         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
2640
2641 2011-09-26  Adam Roben  <aroben@apple.com>
2642
2643         Clean up code imported from WebKitAPITest
2644
2645         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
2646         TestWebKitAPI conventions
2647
2648         Reviewed by David Levin.
2649
2650         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
2651         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
2652         namespace name.
2653
2654         (TestWebKitAPI::WebViewDestruction::SetUp):
2655         (TestWebKitAPI::WebViewDestruction::webViewCount):
2656         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
2657         (TestWebKitAPI::WebViewDestruction::runMessagePump):
2658         (TestWebKitAPI::WebViewDestruction::TearDown):
2659         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
2660         Moved functionality from free functions into these new test fixtures.
2661
2662         * TestWebKitAPI/win/HostWindow.cpp:
2663         * TestWebKitAPI/win/HostWindow.h:
2664         Prefixed Win32 API calls with ::. Updated namespace name.
2665
2666 2011-09-23  Adam Roben  <aroben@apple.com>
2667
2668         Merge WebKitAPITest into TestWebKitAPI
2669
2670         This also means that our formerly-WebKitAPITest tests will be run on the bots!
2671
2672         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
2673         them more idiomatic in a separate pass.
2674
2675         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
2676         functionality (and names!)
2677
2678         Reviewed by Anders Carlsson.
2679
2680         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
2681         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
2682         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
2683
2684         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
2685
2686         * TestWebKitAPI/win/main.cpp:
2687         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
2688
2689         * WebKitAPITest: Removed this directory and its contents.
2690
2691 2011-09-23  Adam Roben  <aroben@apple.com>
2692
2693         Remove two failing WebKitAPITest tests
2694
2695         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
2696
2697         Reviewed by Anders Carlsson.
2698
2699         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
2700         MainFrameAfterClose tests.
2701
2702 2011-09-25  Adam Barth  <abarth@webkit.org>
2703
2704         Finish removing PLATFORM(BREWMP) by removing associated code
2705         https://bugs.webkit.org/show_bug.cgi?id=68779
2706
2707         Reviewed by Sam Weinig.
2708
2709         * Scripts/webkitpy/common/config/build.py:
2710         * waf/build/settings.py:
2711
2712 2011-09-21  Ai Makabi  <makabi@google.com>
2713
2714         Provides a simple LRU cache class in Python.
2715
2716         https://bugs.webkit.org/show_bug.cgi?id=67823
2717
2718         Reviewed by Tony Chang.
2719
2720         * Scripts/webkitpy/common/lru_cache.py:
2721         * Scripts/webkitpy/common/lru_cache_unittest.py:
2722
2723 2011-09-25  Adam Barth  <abarth@webkit.org>
2724
2725         Remove PLATFORM(HAIKU) and associated code
2726         https://bugs.webkit.org/show_bug.cgi?id=68774
2727
2728         Reviewed by Sam Weinig.
2729
2730         * Scripts/webkitpy/common/config/build.py:
2731         * waf/build/settings.py:
2732
2733 2011-09-24  Adam Barth  <abarth@webkit.org>
2734
2735         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
2736         https://bugs.webkit.org/show_bug.cgi?id=68767
2737
2738         Reviewed by Eric Seidel.
2739
2740         * Scripts/build-webkit:
2741
2742 2011-09-24  Adam Barth  <abarth@webkit.org>
2743
2744         Remove ENABLE(WCSS) and associated code
2745         https://bugs.webkit.org/show_bug.cgi?id=68759
2746
2747         Reviewed by Darin Adler.
2748
2749         * Scripts/build-webkit:
2750         * Scripts/old-run-webkit-tests:
2751         * Scripts/webkitperl/features.pm:
2752         (hasFeature):
2753         * Scripts/webkitpy/layout_tests/port/webkit.py:
2754         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2755
2756 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
2757
2758         Fixed GTK compilation after r95878, the operator== was defined
2759         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
2760
2761         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2762
2763 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
2764
2765         [DRT] Include the right config file for EFL's DRT.
2766         https://bugs.webkit.org/show_bug.cgi?id=67042
2767
2768         Reviewed by Martin Robinson.
2769
2770         Ports which use CMake as their buildsystem (such as the EFL one) also
2771         have config.h files, but they are named differently, so include the
2772         right one depending on the buildsystem being used.
2773
2774         * DumpRenderTree/config.h:
2775
2776 2011-09-23  Adam Klein  <adamk@chromium.org>
2777
2778         Add ENABLE_MUTATION_OBSERVERS feature flag
2779         https://bugs.webkit.org/show_bug.cgi?id=68732
2780
2781         Reviewed by Ojan Vafai.
2782
2783         This flag will guard an implementation of the "Mutation Observers" proposed in
2784         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
2785
2786         * Scripts/build-webkit:
2787
2788 2011-09-23  Chang Shu  <cshu@webkit.org>
2789
2790         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
2791         https://bugs.webkit.org/show_bug.cgi?id=68556
2792
2793         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
2794
2795         Reviewed by Darin Adler.
2796
2797         * WebKitTestRunner/EventSenderProxy.h:
2798         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2799         * WebKitTestRunner/PlatformWebView.h:
2800         * WebKitTestRunner/mac/EventSenderProxy.mm:
2801         (WTR::EventSenderProxy::EventSenderProxy):
2802         (WTR::EventSenderProxy::leapForward):
2803         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2804         (WTR::EventSenderProxy::EventSenderProxy):
2805         (WTR::getMouseButton):
2806         (WTR::getModifiers):
2807         (WTR::EventSenderProxy::updateClickCountForButton):
2808         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
2809         (WTR::EventSenderProxy::mouseDown):
2810         (WTR::EventSenderProxy::mouseUp):
2811         (WTR::EventSenderProxy::mouseMoveTo):
2812         (WTR::EventSenderProxy::leapForward):
2813         (WTR::EventSenderProxy::sendOrQueueEvent):
2814         (WTR::EventSenderProxy::replaySavedEvents):
2815         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2816         (WTR::PlatformWebView::postEvent):
2817         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2818
2819 2011-09-23  Lei Zhang  <thestig@chromium.org>
2820
2821         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
2822         https://bugs.webkit.org/show_bug.cgi?id=68026
2823
2824         Reviewed by Dirk Pranke.
2825
2826         * Scripts/webkitpy/layout_tests/port/chromium.py:
2827
2828 2011-09-23  Elliot Poger  <epoger@google.com>
2829
2830         update layout_tests to account for new default of use_skia=1
2831         https://bugs.webkit.org/show_bug.cgi?id=68698
2832
2833         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
2834         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
2835         (Chromium-on-Mac now uses the Skia graphics library instead of
2836         Core Graphics).
2837
2838         Also updates layout_test code to work with that change.
2839
2840         Reviewed by Mihai Parparita.
2841
2842         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2843         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2844
2845 2011-09-23  Mark Rowe  <mrowe@apple.com>
2846
2847         Fix the build.
2848         
2849         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
2850         the WTF namespace.
2851
2852 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
2853
2854         enable NRWT for run-webkit-tests on Lion
2855         https://bugs.webkit.org/show_bug.cgi?id=68673
2856
2857         Reviewed by Eric Seidel.
2858
2859         * Scripts/run-webkit-tests:
2860         (useNewRunWebKitTests):
2861
2862 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2863
2864         Add unit test for existing StringBuilder
2865         https://bugs.webkit.org/show_bug.cgi?id=67080
2866
2867         Reviewed by Darin Adler.
2868
2869         * TestWebKitAPI/TestWebKitAPI.gypi:
2870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2871         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
2872         (operator<<):
2873         (TestWebKitAPI::expectBuilderContent):
2874         (TestWebKitAPI::expectEmpty):
2875         (TestWebKitAPI::TEST):
2876
2877 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
2878
2879         [EFL] Use ewk_view to navigate in history instead of ewk_history.
2880         https://bugs.webkit.org/show_bug.cgi?id=68455
2881
2882         Reviewed by Antonio Gomes.
2883
2884         BackForwardItem::invoke() was using ewk_history functions to navigate
2885         in history; however, this will only call WebCore::BackForwardListImpl
2886         and not move between pages at all. We now call ewk_view_navigate and
2887         its siblings to make sure the navigation actually happens.
2888
2889         This should make tests like fast/dom/navigation-type-back-forward.html
2890         stop timing out.
2891
2892         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2893         (BackForwardItem::invoke):
2894
2895 2011-09-22  Dean Jackson  <dino@apple.com>
2896
2897         Add ENABLE_CSS_FILTERS
2898         https://bugs.webkit.org/show_bug.cgi?id=68652
2899
2900         Reviewed by Simon Fraser.
2901
2902         * Scripts/build-webkit:
2903
2904 2011-09-22  Anders Carlsson  <andersca@apple.com>
2905
2906         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
2907         https://bugs.webkit.org/show_bug.cgi?id=68660
2908
2909         Reviewed by Adam Barth.
2910
2911         * WebKitTestRunner/mac/EventSenderProxy.mm:
2912         (WTR::EventSenderProxy::mouseUp):
2913
2914 2011-09-22  Adam Roben  <aroben@apple.com>
2915
2916         Remove FindSafari
2917
2918         It isn't used or built anymore.
2919
2920         Fixes <http://webkit.org/b/68628>
2921
2922         Reviewed by Darin Adler.
2923
2924         * FindSafari: Removed this directory and its contents.
2925
2926 2011-09-22  Adam Roben  <aroben@apple.com>
2927
2928         Remove FindSafari from all our .sln files
2929
2930         It isn't used anymore, so there's no point in building it.
2931
2932         Part of <http://webkit.org/b/68628> Remove FindSafari
2933
2934         Reviewed by Steve Falkenburg.
2935
2936         * DumpRenderTree/DumpRenderTree.sln:
2937         * WebKitTestRunner/WebKitTestRunner.sln:
2938
2939 2011-09-22  Adam Roben  <aroben@apple.com>
2940
2941         Remove all uses of FindSafari
2942
2943         It isn't really needed anymore.
2944
2945         Fixes <http://webkit.org/b/68626>.
2946
2947         Reviewed by Darin Adler.
2948
2949         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
2950
2951         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
2952         WebKit, but now we use WebKit.exe for that.
2953
2954         * Scripts/webkitdirs.pm:
2955         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
2956         do the same thing.
2957
2958         (readRegistryString):
2959         (writeRegistryString):
2960         Moved here from old-run-webkit-tests.
2961
2962 2011-09-22  Adam Roben  <aroben@apple.com>
2963
2964         Use the "direct object" form of system() to run WebKit.exe
2965
2966         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
2967         path to WebKit.exe.
2968
2969         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
2970         %WEBKITOUTPUTDIR%
2971
2972         Reviewed by Steve Falkenburg.
2973
2974         * Scripts/webkitdirs.pm:
2975         (runSafari):
2976
2977 2011-09-22  Adam Roben  <aroben@apple.com>
2978
2979         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
2980
2981         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
2982         spaces in the path to the WebKit source tree
2983
2984         Reviewed by John Sullivan.
2985
2986         * Scripts/webkitdirs.pm:
2987         (setupCygwinEnv):
2988
2989 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2990
2991         [Qt] Use same DPI for application font as rest of app in DRT and WTR
2992
2993         QApplication will initialize the default application font based
2994         on the application DPI at construction time, but we then override
2995         the application DPI using QX11Info (hard-coding it to 96 for
2996         consistency). This hard-coding is not reflected in the application
2997         font, so we explicitly have update the font ourselves.
2998
2999         The 6 test results that are updated were originally produced with
3000         a DPI of 75, as this is the default fallback DPI when a QFont is
3001         constructed before QApplication. This was wrong, and the results
3002         are updated to match a DPI of 96.
3003
3004         Reviewed by Csaba Osztrogonác.
3005
3006         * DumpRenderTree/qt/main.cpp:
3007         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3008
3009 2011-09-21  Anna Cavender  <annacc@chromium.org>
3010
3011         Update committers.py with a new contributor contact        
3012         https://bugs.webkit.org/show_bug.cgi?id=68565
3013
3014         Reviewed by Eric Carlson.
3015
3016         * Scripts/webkitpy/common/config/committers.py:
3017
3018 2011-09-21  Chang Shu  <cshu@webkit.org>
3019
3020         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
3021         https://bugs.webkit.org/show_bug.cgi?id=68108
3022
3023         This patch implements the event sender mouse events through WebKit2 UIProcess which is
3024         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
3025         platform as the first step so the existing code is still kept for other platforms.
3026
3027         Reviewed by Darin Adler.
3028
3029         * WebKitTestRunner/EventSenderProxy.h:
3030         (WTR::EventSenderProxy::EventSenderProxy):
3031         (WTR::EventSenderProxy::leapForward):
3032         (WTR::EventSenderProxy::currentEventTime):
3033         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3034         (WTR::EventSendingController::EventSendingController):
3035         (WTR::EventSendingController::mouseDown):
3036         (WTR::EventSendingController::mouseUp):
3037         (WTR::EventSendingController::mouseMoveTo):
3038         (WTR::EventSendingController::leapForward):
3039         (WTR::EventSendingController::keyDown):
3040         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3041         * WebKitTestRunner/TestController.cpp:
3042         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3043         * WebKitTestRunner/mac/EventSenderProxy.mm:
3044         (WTR::eventTypeForMouseButtonAndAction):
3045         (WTR::operator==):
3046         (WTR::EventSenderProxy::updateClickCountForButton):
3047         (WTR::EventSenderProxy::mouseDown):
3048         (WTR::EventSenderProxy::mouseUp):
3049         (WTR::EventSenderProxy::mouseMoveTo):
3050         (WTR::EventSenderProxy::keyDown):
3051         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3052         (WTR::EventSenderProxy::keyDown):
3053         (WTR::EventSenderProxy::mouseDown):
3054         (WTR::EventSenderProxy::mouseUp):
3055         (WTR::EventSenderProxy::mouseMoveTo):
3056
3057 2011-09-21  Dan Bernstein  <mitz@apple.com>
3058
3059         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
3060         https://bugs.webkit.org/show_bug.cgi?id=68451
3061
3062         Reviewed by Darin Adler.
3063
3064         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
3065         Objective-C classes with names not having one of a list of prefixes
3066         passed on the command line.
3067
3068 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
3069
3070         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
3071         https://bugs.webkit.org/show_bug.cgi?id=68206
3072
3073         Reviewed by Tony Chang.
3074
3075         * Scripts/webkitdirs.pm:
3076         (determineBaseProductDir): add support for chromium-mac
3077         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3078         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3079
3080 2011-09-21  Adam Barth  <abarth@webkit.org>
3081
3082         garden-o-matic command should explain that it is starting a local server
3083         https://bugs.webkit.org/show_bug.cgi?id=68486
3084
3085         Reviewed by Dimitri Glazkov.
3086
3087         In the user study, both participants didn't understand why the
3088         garden-o-matic command appeared to hang.  This patch adds an
3089         explaination of what's going on.  It also adds a confirmation prompt
3090         before launching the browser to give the user a chance to read the
3091         text.  If that's too much of a speed bump, we can iterate.
3092
3093         * Scripts/webkitpy/tool/commands/gardenomatic.py:
3094
3095 2011-09-21  Chang Shu  <cshu@webkit.org>
3096
3097         [Qt] Implement KeyDown function for WebKit2 EventSender.
3098         https://bugs.webkit.org/show_bug.cgi?id=56485
3099
3100         Implement the KeyDown function on Qt platform.
3101
3102         Reviewed by Andreas Kling.
3103
3104         * WebKitTestRunner/PlatformWebView.h:
3105         * WebKitTestRunner/TestController.cpp:
3106         (WTR::TestController::TestController):
3107         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3108         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
3109         (WTR::getModifiers):
3110         (WTR::EventSenderProxy::keyDown):
3111         (buildModifierFlags):
3112         (EventSenderProxy::keyDown):
3113         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3114         (WTR::PlatformWebView::sendEvent):
3115         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3116
3117 2011-09-20  Adam Barth  <abarth@webkit.org>
3118
3119         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
3120         https://bugs.webkit.org/show_bug.cgi?id=68496
3121
3122         Reviewed by Dimitri Glazkov.
3123
3124         This patch adds a bunch of sorting to make sure things happen in a
3125         predictable order in both JavaScriptCore and V8.  We've talked before
3126         about whether these two JavaScript engines should enumerate
3127         dictionaries in the same order, but the consensus has been that they
3128         shouldn't.  Personally, I disagree with that consensus, but such is life.
3129
3130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3134
3135 2011-09-20  Adam Barth  <abarth@webkit.org>
3136
3137         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
3138         https://bugs.webkit.org/show_bug.cgi?id=68495
3139
3140         Reviewed by Dimitri Glazkov.
3141
3142         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
3143
3144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3145
3146 2011-09-20  Eric Seidel  <eric@webkit.org>
3147
3148         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
3149         https://bugs.webkit.org/show_bug.cgi?id=65781
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
3154         to resolve the passed in url relative to the absolute url for the test.
3155         For http tests, since the test url is an http url, we can't resolve relative
3156         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
3157         for resolving.
3158
3159         I believe this is a better approach than the on used in the Qt and Chromium DRT's
3160         (which resolves the path relative to the built location of the DRT executable)
3161         and we should move this new code into a shared location in a follow-up patch.
3162
3163         It turns out that there was a second use for pathToLocalResource, used by one
3164         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
3165         To support this test I made the new pathToLocalResource smart enough to map
3166         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
3167
3168         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3169         (LayoutTestController::pathToLocalResource):
3170         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
3171
3172 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
3173
3174         Need to specify a django version, instead of using default
3175         https://bugs.webkit.org/show_bug.cgi?id=68398
3176
3177         Reviewed by Eric Seidel.
3178
3179         * QueueStatusServer/__init__.py:
3180         * QueueStatusServer/main.py:
3181
3182 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
3183
3184         Update committers.py with a few more contributor contacts
3185         https://bugs.webkit.org/show_bug.cgi?id=68487
3186
3187         Reviewed by Eric Seidel.
3188
3189         * Scripts/webkitpy/common/config/committers.py:
3190
3191 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
3192
3193         Fix webkitpy unit tests after 95547 and 95549
3194         https://bugs.webkit.org/show_bug.cgi?id=68483
3195
3196         Reviewed by Adam Barth.
3197         
3198         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
3199
3200         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
3201         parse_entries_from_file(), use StringIO and entry.reviewer_text().
3202         While testing parse_latest_entry_from_file(), expect the correct
3203         touched_files() list.
3204
3205 2011-09-20  Adam Barth  <abarth@webkit.org>
3206
3207         garden-o-matic makes it hard to compare images when scroll bars appear
3208         https://bugs.webkit.org/show_bug.cgi?id=68482
3209
3210         Reviewed by Eric Seidel.
3211
3212         Because we autoscale image width, the images rescale if we overflow
3213         vertically and get a scrollbar.  That makes it hard to compare two sets
3214         of images.  This patch reserves space for the scrollbar so we won't
3215         have the layout change.
3216
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
3218
3219 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3220
3221         Unreviewed, rolling out r95565.
3222         http://trac.webkit.org/changeset/95565
3223         https://bugs.webkit.org/show_bug.cgi?id=68470
3224
3225         Broke builds (Requested by andersca on #webkit).
3226
3227         * MiniBrowser/gtk/BrowserWindow.c:
3228         (mouseDidMoveOverElement):
3229
3230 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
3231
3232         Get hover'ed element URL from HitTest.
3233         
3234         mouseDidMoveOverElement now gets the hover'ed element link using
3235         WKHitTestResult API's.
3236         https://bugs.webkit.org/show_bug.cgi?id=68426
3237
3238         Reviewed by Anders Carlsson.
3239
3240         * MiniBrowser/gtk/BrowserWindow.c:
3241         (mouseDidMoveOverElement):
3242
3243 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
3244
3245         Changelog class should have a method to return all entries
3246         https://bugs.webkit.org/show_bug.cgi?id=68399
3247         
3248         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
3249         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
3250
3251         Reviewed by Ryosuke Niwa.
3252
3253         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
3254         and adapt it to become a generator.
3255         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
3256
3257 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
3258
3259         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
3260         https://bugs.webkit.org/show_bug.cgi?id=51159
3261
3262         Permit any URL with a local scheme to set a user style sheet. Allow qrc
3263         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
3264         
3265         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
3266
3267         Reviewed by Kenneth Rohde Christiansen.
3268
3269         * DumpRenderTree/qt/DumpRenderTree.pro:
3270         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
3271         * DumpRenderTree/qt/resources/user.css: Added.
3272         (body):
3273         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3274         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
3275         * WebKitTestRunner/qt/resources/user.css: Added.
3276         (body):
3277
3278 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
3279
3280         ChangeLogEntry class should contain a list of touched files
3281         https://bugs.webkit.org/show_bug.cgi?id=68115
3282
3283         Reviewed by Eric Seidel.
3284         
3285         Add method to return the list of files touched in a ChangeLog entry.
3286
3287         * Scripts/webkitpy/common/checkout/changelog.py: Add
3288         touched_files_regexp and touched_files() method.
3289         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
3290         unit tests for touched_files() method.
3291
3292 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3293
3294         Unreviewed, rolling out r95526 and r95541.
3295         http://trac.webkit.org/changeset/95526
3296         http://trac.webkit.org/changeset/95541
3297         https://bugs.webkit.org/show_bug.cgi?id=68443
3298
3299         It broke 6 tests (Requested by ossy_ on #webkit).
3300
3301         * DumpRenderTree/qt/main.cpp:
3302         (main):
3303         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3304         (WTR::activateFonts):
3305
3306 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
3307
3308         Fix patch and bug numbering in the mocktool simulation code
3309         https://bugs.webkit.org/show_bug.cgi?id=68374
3310
3311         Reviewed by Adam Barth.
3312
3313         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3314         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3315         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3316         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3317         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3318         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3319         * Scripts/webkitpy/tool/commands/download_unittest.py:
3320         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3321         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3322         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3323         * Scripts/webkitpy/tool/commands/queuestest.py:
3324         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3325         * Scripts/webkitpy/tool/mocktool.py:
3326         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3327         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3328
3329 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3330
3331         [Qt] Don't override default QApplication font for DRT and WTR
3332
3333         Revision 95526 moved the relevant code below the QApplication
3334         constructor, to fix a potential crash, and that made the code
3335         take effect, breaking 6 tests.
3336
3337         We should rely on the QWebSettings to set default fonts, and
3338         this QApplication::setFont() is a relic from when we didn't
3339         have that option, so we remove the code.
3340
3341         Reviewed by Csaba Osztrogonác.
3342
3343         * DumpRenderTree/qt/main.cpp:
3344         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3345
3346 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3347
3348         WebKitTestRunner: Provide usage if run without arguments
3349
3350         If WTR is run without either one or more filenames, or
3351         a '-' to indicate server mode, we don't need to start
3352         up the test machinery. Doing so might actually crash,
3353         as we'll exit the application immedeatly after anyways.
3354
3355         Reviewed by Simon Hausmann.
3356
3357         * WebKitTestRunner/TestController.cpp:
3358         (WTR::TestController::initialize):
3359
3360 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3361
3362         [Qt] Don't use QFont before initializing QApplication
3363
3364         Could potentially result in crash.
3365
3366         Reviewed by Simon Hausmann.
3367
3368         * DumpRenderTree/qt/main.cpp:
3369         (main):
3370
3371 2011-09-19  Adam Barth  <abarth@webkit.org>
3372
3373         Always enable ENABLE(EVENTSOURCE)
3374         https://bugs.webkit.org/show_bug.cgi?id=68414
3375
3376         Reviewed by Eric Seidel.
3377
3378         * Scripts/build-webkit:
3379
3380 2011-09-19  David Levin  <levin@chromium.org>
3381
3382         Sheriffbot rollout should be more intuitive.
3383         https://bugs.webkit.org/show_bug.cgi?id=68415
3384
3385         Reviewed by Adam Barth.
3386
3387         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
3388         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
3389           and a few others cases.
3390         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
3391
3392 2011-09-19  David Levin  <levin@chromium.org>
3393
3394         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
3395         https://bugs.webkit.org/show_bug.cgi?id=68391
3396
3397         Reviewed by Darin Adler.
3398
3399         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
3400         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
3401
3402 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
3403
3404         Style checker should not check public Qt WK2 API for parameter_name.
3405         https://bugs.webkit.org/show_bug.cgi?id=68359
3406
3407         Reviewed by Andreas Kling.
3408
3409         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
3410         Add an exception in the style checker to disable the check. Also added the test for it.
3411
3412         * Scripts/webkitpy/style/checker.py:
3413         * Scripts/webkitpy/style/checker_unittest.py:
3414
3415 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
3416
3417         GTK DRT leaks memory while comparing history items
3418         https://bugs.webkit.org/show_bug.cgi?id=68086
3419
3420         Reviewed by Martin Robinson.
3421         
3422         webkit_web_history_item_get_target() returns a g_strdup()'d string,
3423         so memory must be freed before compareHistoryItems() returns.
3424
3425         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3426         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
3427
3428 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3429
3430         Buildbot marks a nrwt bot red when tests are missing results
3431         https://bugs.webkit.org/show_bug.cgi?id=64812
3432
3433         Reviewed by Ryosuke Niwa.
3434
3435         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3436         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3437
3438 2011-09-19  Jessie Berlin  <jberlin@apple.com>
3439
3440         Sites that use history pushState or replaceState are recorded in history in Private Browsing
3441         mode.
3442         https://bugs.webkit.org/show_bug.cgi?id=68208
3443
3444         Reviewed by Brady Eidson.
3445
3446         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
3447         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
3448
3449         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
3450         (TestWebKitAPI::didNavigateWithNavigationData):
3451         This is a context history client callback, so it should not be called when in Private
3452         Browsing. Add a call to FAIL().
3453         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3454         This is a page load client callback that happens after the didNavigateWithNavigationData
3455         callback. End the test.
3456         (TestWebKitAPI::TEST):
3457         Enable Private Browsing and load a page that uses history.pushState.
3458
3459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3460         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
3461         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
3462         Ditto.
3463         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3464         Ditto.
3465         * TestWebKitAPI/win/copy-resources.cmd:
3466         Ditto.
3467
3468 2011-09-16  Elliot Poger  <epoger@google.com>
3469
3470         add non-CG Webkit-Mac builds to flakiness dashboard
3471         https://bugs.webkit.org/show_bug.cgi?id=68265
3472
3473         Reviewed by Adam Barth.
3474
3475         As Chromium-on-Mac approaches the switchover from Core Graphics to
3476         Skia, we need to add the Skia version to the flakiness dashboard.
3477
3478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3479         * TestResultServer/static-dashboards/builders.js:
3480         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3481
3482 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
3483
3484         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
3485         https://bugs.webkit.org/show_bug.cgi?id=68071
3486
3487         Reviewed by Adam Barth.
3488
3489         * DumpRenderTree/chromium/WebPermissions.cpp:
3490         (WebPermissions::allowImage):
3491         * DumpRenderTree/chromium/WebPermissions.h:
3492
3493 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
3494
3495         update-webkit-chromium should retry the gclient call if it fails once
3496         https://bugs.webkit.org/show_bug.cgi?id=68252
3497
3498         Reviewed by Adam Barth.
3499
3500         * Scripts/update-webkit-chromium:
3501
3502 2011-09-16  Rob Buis  <rbuis@rim.com>
3503
3504         Add Eli's rim address and change the nick.
3505
3506         * Scripts/webkitpy/common/config/committers.py:
3507
3508 2011-09-16  Anders Carlsson  <andersca@apple.com>
3509
3510         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
3511         https://bugs.webkit.org/show_bug.cgi?id=68269
3512
3513         Reviewed by Geoffrey Garen.
3514
3515         Update client function signatures.
3516
3517         * MiniBrowser/gtk/BrowserWindow.c:
3518         (browserWindowUIClientInit):
3519         * MiniBrowser/mac/BrowserWindowController.m:
3520         (mouseDidMoveOverElement):
3521         (-[BrowserWindowController awakeFromNib]):
3522         * MiniBrowser/win/BrowserView.cpp:
3523         (BrowserView::create):
3524         * WebKitTestRunner/TestController.cpp:
3525         (WTR::TestController::createOtherPage):
3526         (WTR::TestController::initialize):
3527
3528 2011-09-16  Anders Carlsson  <andersca@apple.com>
3529
3530         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
3531         https://bugs.webkit.org/show_bug.cgi?id=68266
3532
3533         Reviewed by John Sullivan.
3534
3535         * MiniBrowser/mac/BrowserWindowController.m:
3536         (mouseDidMoveOverElement):
3537
3538 2011-09-16  Vincent Scheib  <scheib@chromium.org>
3539
3540         Add Vincent Scheib to the committers list.
3541
3542         * Scripts/webkitpy/common/config/committers.py:
3543
3544 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
3545
3546         Unreviewed, rolling out r95285.
3547         http://trac.webkit.org/changeset/95285
3548         https://bugs.webkit.org/show_bug.cgi?id=68247
3549
3550         It broke a webkitpy test (Requested by ossy on #webkit).
3551
3552         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3553
3554 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3555
3556         Buildbot marks a nrwt bot red when tests are missing results
3557         https://bugs.webkit.org/show_bug.cgi?id=64812
3558
3559         Reviewed by Dirk Pranke.
3560
3561         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3562
3563 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
3564
3565         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
3566         https://bugs.webkit.org/show_bug.cgi?id=68178
3567
3568         Reviewed by Xan Lopez.
3569
3570         Add a work-around to enable WebKit2 when using build-webkit.
3571
3572         * Scripts/webkitdirs.pm:
3573         (buildAutotoolsProject): 
3574
3575 2011-09-15  James Robinson  <jamesr@chromium.org>
3576
3577         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
3578
3579         * Scripts/webkitpy/common/config/committers.py:
3580
3581 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
3582
3583         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
3584         https://bugs.webkit.org/show_bug.cgi?id=68003
3585
3586         Reviewed by Adam Barth.
3587
3588         * Scripts/webkitpy/tool/mocktool.py:
3589         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
3590         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3591
3592 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
3593
3594         Python version check is confusing in test-webkitpy
3595         https://bugs.webkit.org/show_bug.cgi?id=68004
3596
3597         Reviewed by Adam Barth.
3598
3599         * Scripts/test-webkitpy:
3600
3601 2011-09-15  Eric Seidel  <eric@webkit.org>
3602
3603         Reviewed by Adam Barth.
3604
3605         webkit-patch should be able to find users and add them to bugzilla groups
3606         https://bugs.webkit.org/show_bug.cgi?id=63351
3607
3608         These are both very basic commands.  But it's now possible to find
3609         all users matching a regexp, as well as add all users matching a regexp
3610         to a set of groups.
3611
3612         bugzilla.py already knew how to find users (for validate-committer-lists)
3613         but now it has the ability to modify the user records.
3614
3615         I split some of the logic out into a new EditUsersParser class
3616         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
3617
3618         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3619         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3620         * Scripts/webkitpy/tool/commands/__init__.py:
3621         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
3622         * Scripts/webkitpy/tool/commands/findusers.py: Added.
3623
3624 2011-09-15  Eric Seidel  <eric@webkit.org>
3625
3626         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
3627         https://bugs.webkit.org/show_bug.cgi?id=68182
3628
3629         Reviewed by Adam Barth.
3630
3631         * Scripts/build-webkit:
3632         * waf/build/settings.py:
3633
3634 2011-09-15  Eric Seidel  <eric@webkit.org>
3635
3636         Unreviewed.  Make contributor email look-up case-insensitive.
3637
3638         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
3639         was missing from committers.py due to case sensitivity.
3640
3641         This also includes a test expectations update to committers_unittest.py
3642         after my previous change.
3643
3644         * Scripts/webkitpy/common/config/committers.py:
3645         * Scripts/webkitpy/common/config/committers_unittest.py:
3646         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3647
3648 2011-09-15  Eric Seidel  <eric@webkit.org>
3649
3650         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
3651
3652         Add a bunch of email aliases to committers.py for regular contributors
3653         who are committing using other email addresses than they have listed in the file.
3654
3655         * Scripts/webkitpy/common/config/committers.py:
3656
3657 2011-09-15  Eric Seidel  <eric@webkit.org>
3658
3659         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
3660         https://bugs.webkit.org/show_bug.cgi?id=68022