bisect-builds should print Trac 'changeset' URL if only one build is detected
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-28  David Kilzer  <ddkilzer@apple.com>
2
3         bisect-builds should print Trac 'changeset' URL if only one build is detected
4         <http://webkit.org/b/130903>
5
6         Reviewed by Dan Bernstein.
7
8         * Scripts/bisect-builds:
9         (printTracLink): Print a direct link to the Trac 'changeset'
10         URL if there is only one revision in the range.
11
12 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
13
14         [EFL] Bump glib version from 2.36 to 2.38 
15         https://bugs.webkit.org/show_bug.cgi?id=130886
16
17         Reviewed by Csaba Osztrogonác.
18
19         There is a build break on EFL port when using glib 2.36 ver. To fix it,
20         we need to bump glib version up to 2.38 as gtk port.
21
22         * efl/jhbuild.modules:
23
24 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
25
26         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
27
28         Provide an implementation of WKContextHistoryClient that logs when called for tests in
29         the globalhistory directory.
30
31         Reviewed by Sam Weinig.
32
33         * WebKitTestRunner/TestController.cpp:
34         (WTR::TestController::TestController):
35         (WTR::TestController::initialize): Set the history client.
36         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
37         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
38         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
39         and we don't yet have API to access the data in question.
40         (WTR::TestController::didPerformClientRedirect):
41         (WTR::TestController::didPerformServerRedirect):
42         (WTR::TestController::didUpdateHistoryTitle):
43         * WebKitTestRunner/TestController.h:
44         (WTR::TestController::setShouldLogHistoryClientCallbacks):
45         * WebKitTestRunner/TestInvocation.cpp:
46         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
47         (WTR::TestInvocation::invoke):
48
49 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
50
51         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
52
53         * Scripts/build-webkit:
54         * Scripts/copy-webkitlibraries-to-product-directory:
55
56 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
57
58         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
59         https://bugs.webkit.org/show_bug.cgi?id=130867
60         <rdar://problem/16432456> 
61
62         Reviewed by Mark Hahnenberg.
63
64         * Scripts/build-webkit:
65         * Scripts/copy-webkitlibraries-to-product-directory:
66
67 2014-03-26  Andy Estes  <aestes@apple.com>
68
69         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
70         https://bugs.webkit.org/show_bug.cgi?id=130805
71
72         Reviewed by Dan Bernstein.
73
74         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
75         (-[DownloadDelegate _download:didReceiveResponse:]):
76         (-[DownloadDelegate _downloadDidFinish:]):
77         (runTest):
78         (TEST):
79         (-[FailingDownloadDelegate _downloadDidFinish:]):
80         (-[FailingDownloadDelegate _download:didFailWithError:]):
81         (-[FailingDownloadDelegate _downloadDidCancel:]):
82         (-[CancelledDownloadDelegate _downloadDidStart:]):
83         (-[CancelledDownloadDelegate _downloadDidFinish:]):
84         (-[CancelledDownloadDelegate _download:didFailWithError:]):
85         (-[CancelledDownloadDelegate _downloadDidCancel:]):
86         (-[DownloadDelegate initWithSourceURL:]): Deleted.
87         (-[DownloadDelegate sourceURL]): Deleted.
88         (runTestWithNavigationDelegate): Deleted.
89
90 2014-03-26  Anders Carlsson  <andersca@apple.com>
91
92         Change MiniBrowser to hold on to window controllers instead of windows
93         https://bugs.webkit.org/show_bug.cgi?id=130797
94
95         Reviewed by Oliver Hunt.
96
97         * MiniBrowser/mac/AppDelegate.h:
98         * MiniBrowser/mac/AppDelegate.m:
99         (-[BrowserAppDelegate init]):
100         (-[BrowserAppDelegate newWindow:]):
101         (-[BrowserAppDelegate browserWindowWillClose:]):
102         (-[BrowserAppDelegate applicationWillTerminate:]):
103         (-[BrowserAppDelegate frontmostBrowserWindowController]):
104
105 2014-03-26  Commit Queue  <commit-queue@webkit.org>
106
107         Unreviewed, rolling out r166264.
108         https://bugs.webkit.org/show_bug.cgi?id=130785
109
110         Broke some window.opener tests for WK2 Mavericks (Requested by
111         brrian__ on #webkit).
112
113         Reverted changeset:
114
115         "Web Replay: resource unique identifiers should be unique-per-
116         frame, not globally"
117         https://bugs.webkit.org/show_bug.cgi?id=130632
118         http://trac.webkit.org/changeset/166264
119
120 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
121
122         [CSS Shapes] Remove shape-inside support
123         https://bugs.webkit.org/show_bug.cgi?id=130698
124
125         Reviewed by David Hyatt.
126
127         * Scripts/webkitperl/FeatureList.pm:
128
129 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
130
131         Unreviewed. Add myself as a committer.
132
133         * Scripts/webkitpy/common/config/contributors.json:
134
135 2014-03-26  Tomas Popela  <tpopela@redhat.com>
136
137         run-launcher is Perl script so use elsif and not elif
138         https://bugs.webkit.org/show_bug.cgi?id=130771
139
140         Reviewed by Carlos Garcia Campos.
141
142         * Scripts/run-launcher:
143
144 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
145
146         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
147         https://bugs.webkit.org/show_bug.cgi?id=130575
148
149         Reviewed by Mario Sanchez Prada.
150
151         Change ATK version to 2.11.92. Adjust current implementation.
152
153         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
154         (AccessibilityUIElement::intValue):
155         (AccessibilityUIElement::minValue):
156         (AccessibilityUIElement::maxValue):
157         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
158         (WTR::AccessibilityUIElement::intValue):
159         (WTR::AccessibilityUIElement::minValue):
160         (WTR::AccessibilityUIElement::maxValue):
161         * efl/jhbuild.modules:
162         * gtk/jhbuild.modules:
163
164 2014-03-12  Philippe Normand  <pnormand@igalia.com>
165
166         [GTK] The gnumake package is no longer needed in jhbuild
167         https://bugs.webkit.org/show_bug.cgi?id=130121
168
169         Reviewed by Martin Robinson.
170
171         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
172         for a debug build cmake/system-gnumake worked just fine for me.
173
174         * gtk/jhbuild.modules: Removed gnumake.
175         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
176         * gtk/patches/make-3.82-parallel-build.patch: Removed.
177
178 2014-03-25  Andy Estes  <aestes@apple.com>
179
180         Fix a failing API test on Mountain Lion and remove temporary debug logging.
181
182         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
183         (-[DownloadDelegate _download:didReceiveData:]):
184         (-[DownloadDelegate _downloadDidFinish:]):
185
186 2014-03-25  Brian Burg  <bburg@apple.com>
187
188         Web Replay: resource unique identifiers should be unique-per-frame, not globally
189         https://bugs.webkit.org/show_bug.cgi?id=130623
190
191         Reviewed by Timothy Hatcher.
192
193         The resource loader callback dumping routines assumed that resource identifiers
194         were globally unique. Its map of resource identifiers to URLs must also track the
195         frame associated with the resource.
196
197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
198         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
199         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
200         stable as long as the frame is valid.
201         (WTR::InjectedBundlePage::didInitiateLoadForResource):
202         (WTR::InjectedBundlePage::willSendRequestForFrame):
203         (WTR::InjectedBundlePage::didReceiveResponseForResource):
204         (WTR::InjectedBundlePage::didFinishLoadForResource):
205         (WTR::InjectedBundlePage::didFailLoadForResource):
206
207 2014-03-25  Andy Estes  <aestes@apple.com>
208
209         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
210
211         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
212         (-[DownloadDelegate _download:didReceiveResponse:]):
213         (-[DownloadDelegate _download:didReceiveData:]):
214
215 2014-03-25  Andy Estes  <aestes@apple.com>
216
217         Add some debug logging to an API test that's failing on Mountain Lion.
218
219         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
220         (-[DownloadDelegate _download:didReceiveResponse:]):
221         (-[DownloadDelegate _downloadDidFinish:]):
222
223 2014-03-25  Anders Carlsson  <andersca@apple.com>
224
225         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
226         https://bugs.webkit.org/show_bug.cgi?id=130732
227
228         Reviewed by Tim Horton.
229
230         * MiniBrowser/mac/WK2BrowserWindowController.m:
231         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
232
233 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
234
235         [GTK] Remove the autotools build
236         https://bugs.webkit.org/show_bug.cgi?id=130717
237
238         Reviewed by Anders Carlsson.
239
240         * DumpRenderTree/config.h: Remove references to the autotools configure file.
241         * GNUmakefile.am: Removed.
242         * GtkLauncher/GNUmakefile.am: Removed.
243         * GtkLauncher/main.c: Remove references to the autotools configure file.
244         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
245         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
246         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
247         * MiniBrowser/gtk/GNUmakefile.am: Removed.
248         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
249         * Scripts/build-webkit: No longer handle autotools.
250         * Scripts/run-gtk-tests: Ditto.
251         (TestRunner._setup_testing_environment):
252         * Scripts/run-launcher: Ditto.
253         * Scripts/webkitdirs.pm: Ditto.
254         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
255         * Scripts/webkitpy/common/config/contributors.json: Ditto.
256         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
257         * Scripts/webkitpy/style/checker.py:
258         * TestWebKitAPI/GNUmakefile.am: Removed.
259         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
260         * WebKitTestRunner/GNUmakefile.am: Removed.
261         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
262         * gtk/GNUmakefile.am: Removed.
263         * gtk/common.py: Remove checks for the autotools build.
264         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
265
266 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
267
268         prepare-ChangeLog throws false positive warnings for modified files.
269         https://bugs.webkit.org/show_bug.cgi?id=130687
270
271         Reviewed by Darin Adler.
272
273         * Scripts/prepare-ChangeLog:
274         (originalFile): Ignore git commit paremeter.
275         We don't need this to get the unmodified file.
276         (extractLineRangeBeforeChange):
277         Simplify the if statement. Follow-up after r166189.
278
279 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
280
281         [EFL] Add ARM64 build support
282         https://bugs.webkit.org/show_bug.cgi?id=130506
283
284         Rubber stamped by Gyuyoung Kim.
285
286         * Scripts/webkitdirs.pm:
287         (isARM): Detect aarch64 as ARM.
288
289 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
290
291         [webkitpy] Improve _parse_bug_description to recognize more descriptions
292         https://bugs.webkit.org/show_bug.cgi?id=130137
293
294         Reviewed by Csaba Osztrogonác.
295
296         * Scripts/webkitpy/common/checkout/changelog.py:
297         (ChangeLogEntry._parse_bug_description):
298         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
299         (test_parse_log_entries_from_changelog):
300         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
301         (CheckoutTest.test_commit_info_for_revision):
302
303 2014-03-24  Andy Estes  <aestes@apple.com>
304
305         Fix the iOS build of TestWebKitAPI.
306
307         * TestWebKitAPI/Configurations/Base.xcconfig:
308         * TestWebKitAPI/PlatformUtilities.h:
309
310 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
311
312         Fix prepare-ChangeLog after r166156.
313         https://bugs.webkit.org/show_bug.cgi?id=130674
314
315         Reviewed by Darin Adler.
316
317         * Scripts/prepare-ChangeLog:
318         (generateFunctionLists):
319         (extractLineRangeBeforeChange):
320
321 2014-03-24  Andy Estes  <aestes@apple.com>
322
323         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
324         https://bugs.webkit.org/show_bug.cgi?id=129322
325
326         Reviewed by Anders Carlsson.
327
328         Add an API test suite for _WKDownload.
329
330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
331         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
332         (-[DownloadDelegate initWithSourceURL:]):
333         (-[DownloadDelegate sourceURL]):
334         (-[DownloadDelegate _downloadDidStart:]):
335         (-[DownloadDelegate _download:didReceiveResponse:]):
336         (-[DownloadDelegate _download:didReceiveData:]):
337         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
338         (-[DownloadDelegate _downloadDidFinish:]):
339         (TEST):
340         (runTestWithNavigationDelegate):
341         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
342         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
343
344 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
345
346         filter-build-webkit: reduce unfiltered output
347         https://bugs.webkit.org/show_bug.cgi?id=130485
348
349         Reviewed by Brent Fulgham.
350
351         * Scripts/filter-build-webkit:
352         (shouldIgnoreLine):
353
354 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
355
356         prepare-ChangeLog should list functions that have been removed too.
357         https://bugs.webkit.org/show_bug.cgi?id=130508
358
359         Reviewed by Darin Adler.
360
361         The prepare-ChangeLog does not list the deleted functions in the Changelog.
362         We have to read the functions and the line ranges of them from the source
363         before the change, then search for overlaps between them and the changed
364         line ranges from diff.
365
366         * Scripts/prepare-ChangeLog:
367         (originalFile): Get original source command.
368         (generateFunctionLists): Collect deleted functions too.
369         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
370         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
371         deleted functions ranges too.
372         (extractLineRange): Renamed to extractLineRangeAfterChange.
373
374 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
375
376         Move all EFL typedefs into EflTypedefs.h.
377         https://bugs.webkit.org/show_bug.cgi?id=130511
378
379         Reviewed by Gyuyoung Kim.
380
381         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
382         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
383         * WebKitTestRunner/PlatformWebView.h: Ditto.
384
385 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
386
387         Don't flush compositing layers within FrameView::willPaintContents()
388         https://bugs.webkit.org/show_bug.cgi?id=130627
389         <rdar://problem/16368869>
390
391         Reviewed by Sam Weinig.
392         
393         Fix DRT to correctly render tests with layers now that FrameView::paintContents
394         does not flush.
395         
396         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
397         into an explicit function called before dumping. 
398         
399         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
400         are flushed to CA. They will be pushed to the window by snapshotting.
401
402         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
403         Fix weird path to IOKit.framework.
404         * DumpRenderTree/mac/DumpRenderTree.mm:
405         (updateDisplay):
406         (dump):
407         * DumpRenderTree/mac/FrameLoadDelegate.mm:
408         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
409         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
410
411 2014-03-21  David Kilzer  <ddkilzer@apple.com>
412
413         fix-blink-patch: tool to fix up renamed directory paths in Blink
414         <http://webkit.org/b/130609>
415
416         Reviewed by Ryosuke Niwa.
417
418         Usage: cat blink.patch | fix-blink-patch | svn-apply
419
420         * Scripts/fix-blink-patch: Added.
421
422 2014-03-21  Darin Adler  <darin@apple.com>
423
424         Remove use of deprecatedCharacters in WebKit API tests
425         https://bugs.webkit.org/show_bug.cgi?id=130602
426
427         Reviewed by Antti Koivisto.
428
429         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
430         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
431         (TestWebKitAPI::expectEmpty): Use characters8.
432         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
433
434         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
435         Removed the test that is entirely about 16-bit conversion since that's basically a test of
436         the deprecatedCharacters function itself, which we are about to delete.
437
438 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
439
440         [webkitpy] Fix has_valid_reviewer()
441         https://bugs.webkit.org/show_bug.cgi?id=130589
442
443         Reviewed by Csaba Osztrogonác.
444
445         * Scripts/webkitpy/common/checkout/changelog.py:
446         (ChangeLogEntry.has_valid_reviewer):
447         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
448         (test_has_valid_reviewer):
449         * Scripts/webkitpy/common/config/committers.py:
450         (CommitterList._reviewer_only):
451         (CommitterList.committer_by_name):
452         (CommitterList.reviewer_by_email):
453         (CommitterList):
454         (CommitterList.reviewer_by_name):
455
456 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
457
458         Add cache support for jhbuild
459         https://bugs.webkit.org/show_bug.cgi?id=130588
460
461         Reviewed by Csaba Osztrogonác.
462
463         * jhbuild/jhbuildrc_common.py:
464         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
465
466 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
467
468         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
469         https://bugs.webkit.org/show_bug.cgi?id=130504
470
471         Reviewed by Martin Robinson.
472
473         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
474         CMake if not specified.
475         * Scripts/webkitdirs.pm:
476         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
477         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
478
479 2014-03-21  Andreas Kling  <akling@apple.com>
480
481         RetainPtr API test should use CFArray instead of CFString for testing.
482         <rdar://problem/16384899>
483
484         Unreviewed bot fix.
485
486         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
487         (TestWebKitAPI::TEST):
488         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
489         (TestWebKitAPI::TEST):
490
491 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
492
493         Move to using std::unique_ptr for EFL objects.
494         https://bugs.webkit.org/show_bug.cgi?id=129853
495
496         Reviewed by Gyuyoung Kim.
497
498         EflUniquePtr is a template alias of std::unique_ptr
499         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
500         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
501
502         * DumpRenderTree/efl/DumpRenderTree.cpp:
503         (main):
504         * ImageDiff/efl/ImageDiff.cpp:
505         (initEfl):
506         (main):
507
508 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
509
510         Unreviewed buildfix after r165983 for non Cocoa platforms
511
512         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
513
514         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
515         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
516         * WebKitTestRunner/TestController.cpp:
517
518 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
519
520         [GTK][CMake] Add support for building with Clang
521         https://bugs.webkit.org/show_bug.cgi?id=130260
522
523         Reviewed by Martin Robinson.
524
525         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
526         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
527         included GTest framework headers.
528         * gtk/generate-gtkdoc:
529         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
530         in case of using Clang since that is now set by the CMake rule.
531
532 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
533
534         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
535         https://bugs.webkit.org/show_bug.cgi?id=130476
536
537         Reviewed by Anders Carlsson.
538         
539         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
540
541         * MiniBrowser/mac/WK1BrowserWindowController.m:
542         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
543         Remove log.
544         * MiniBrowser/mac/WK2BrowserWindowController.m:
545         (-[WK2BrowserWindowController awakeFromNib]):
546         (-[WK2BrowserWindowController validateMenuItem:]):
547         (-[WK2BrowserWindowController reload:]):
548         Hook up reload.
549         (-[WK2BrowserWindowController toggleZoomMode:]):
550         (-[WK2BrowserWindowController resetZoom:]):
551         (-[WK2BrowserWindowController canResetZoom]):
552         (-[WK2BrowserWindowController currentZoomFactor]):
553         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
554         (-[WK2BrowserWindowController canZoomIn]):
555         (-[WK2BrowserWindowController canZoomOut]):
556
557 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
558
559         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
560         https://bugs.webkit.org/show_bug.cgi?id=130463
561
562         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
563
564 2014-03-18  Samuel White  <samuel_white@apple.com>
565
566         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
567         https://bugs.webkit.org/show_bug.cgi?id=130250
568
569         Reviewed by Chris Fleizach.
570
571         Added ability to toggle enhanced accessibility on and off to support tests that require it.
572
573         * DumpRenderTree/AccessibilityController.cpp:
574         (enableEnhancedAccessibilityCallback):
575         (getEnhancedAccessibilityEnabledCallback):
576         (AccessibilityController::getJSClass):
577         * DumpRenderTree/AccessibilityController.h:
578         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
579         (AccessibilityController::enableEnhancedAccessibility):
580         (AccessibilityController::enhancedAccessibilityEnabled):
581         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
582         (AccessibilityController::enableEnhancedAccessibility):
583         (AccessibilityController::enhancedAccessibilityEnabled):
584         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
585         (AccessibilityController::enableEnhancedAccessibility):
586         (AccessibilityController::enhancedAccessibilityEnabled):
587         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
588         (AccessibilityController::enableEnhancedAccessibility):
589         (AccessibilityController::enhancedAccessibilityEnabled):
590         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
591         (WTR::AccessibilityController::enableEnhancedAccessibility):
592         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
593         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
594         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
595
596 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
597
598         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
599         yet).
600
601         * Scripts/webkitpy/common/config/contributors.json:
602
603 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
604
605         Web Inspector: Remove stale ReportMemoryUsagePlugin
606         https://bugs.webkit.org/show_bug.cgi?id=130405
607
608         Reviewed by Andreas Kling.
609
610         This clang plugin looks like it was used for the old Inspector memory
611         instrumentation that was removed. So the tool can be removed.
612
613         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
614         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
615         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
616         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
617
618 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
619
620         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
621         https://bugs.webkit.org/show_bug.cgi?id=130220
622
623         Reviewed by Csaba Osztrogonác.
624
625         * Scripts/webkitpy/common/checkout/changelog.py:
626         (ChangeLog.set_reviewer):
627         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
628         (test_set_reviewer):
629
630 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
631
632         More FTL enabling.
633
634         Rubber stamped by Dan Bernstein.
635
636         * Tools/Scripts/build-webkit:
637
638 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
639
640         Renable pagination mode in WK2 MiniBrowser
641         https://bugs.webkit.org/show_bug.cgi?id=130374
642
643         Reviewed by Anders Carlsson.
644         
645         Put the implementation of togglePaginationMode: back, and correctly
646         enable the menu item.
647
648         * MiniBrowser/mac/WK2BrowserWindowController.m:
649         (-[WK2BrowserWindowController validateMenuItem:]):
650         (-[WK2BrowserWindowController isPaginated]):
651         (-[WK2BrowserWindowController togglePaginationMode:]):
652
653 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
654
655         Add --reset option to Tools/Scripts/set-webkit-configuration script
656         https://bugs.webkit.org/show_bug.cgi?id=130401
657
658         Reviewed by Csaba Osztrogonác.
659
660         * Scripts/set-webkit-configuration:
661
662 2014-03-18  Alberto Garcia  <berto@igalia.com>
663
664         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
665         https://bugs.webkit.org/show_bug.cgi?id=130388
666
667         Reviewed by Sergio Villar Senin.
668
669         * Scripts/webkitdirs.pm:
670         (shouldRemoveCMakeCache): make sure that the build directory
671         exists before attempting to create a file in it.
672
673 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
674
675         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
676         https://bugs.webkit.org/show_bug.cgi?id=130336
677
678         Reviewed by Gyuyoung Kim.
679
680         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
681         requires a space between literal and string macro [-Wliteral-suffix]'
682         warning treated as error.
683
684         This patch applies a solution from r162448 to the EFL port.
685
686         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
687         * efl/jhbuild.modules: Added appropriate patch section.
688
689 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
690
691         webkitpy test rebaseline.
692
693         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
694         (MainTest.test_default_args):
695
696 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
697
698         --profile should imply --test-runner-count=1 in run-perf-tests
699         https://bugs.webkit.org/show_bug.cgi?id=130375
700
701         Reviewed by Benjamin Poulain.
702
703         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
704
705         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
706         (PerfTestsRunner._parse_args): Use -1 as the default value.
707         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
708         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
709         should be 1.
710
711 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
712
713         Address some style nits.
714
715         * MiniBrowser/mac/WK2BrowserWindowController.m:
716
717 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
718
719         Add transparent window support back into MiniBrowser
720         https://bugs.webkit.org/show_bug.cgi?id=130363
721
722         Reviewed by Anders Carlsson.
723         
724         Re-enable transparent window support for WK2.
725
726         * MiniBrowser/mac/WK2BrowserWindowController.m:
727         (-[WK2BrowserWindowController validateMenuItem:]):
728         (-[WK2BrowserWindowController toggleTransparentWindow:]):
729
730 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
731
732         Fix the 32-bit build; make the open panel make a WK1 window.
733
734         * MiniBrowser/mac/AppDelegate.m:
735         (-[BrowserAppDelegate openDocument:]):
736
737 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
738
739         Convert MiniBrowser to use WKWebView API
740         https://bugs.webkit.org/show_bug.cgi?id=130061
741
742         Reviewed by Anders Carlsson.
743         
744         Convert the MiniBrowser WK2 window to use WebKit2 API as much
745         as possible.
746         
747         Some functionality was removed temporarily:
748             - text zoom, page zoom
749             - reload
750             - pagination mode
751             - transparent window
752             - dumping source
753             - window.open support
754             - beforeUnload panel
755             - find in page
756
757         * MiniBrowser/mac/AppDelegate.h:
758         * MiniBrowser/mac/AppDelegate.m:
759         (-[BrowserAppDelegate init]):
760         (-[BrowserAppDelegate newWindow:]):
761         (-[BrowserAppDelegate applicationWillTerminate:]):
762         (-[BrowserAppDelegate openDocument:]):
763         * MiniBrowser/mac/WK2BrowserWindowController.h:
764         * MiniBrowser/mac/WK2BrowserWindowController.m:
765         (-[WK2BrowserWindowController awakeFromNib]):
766         (-[WK2BrowserWindowController dealloc]):
767         (-[WK2BrowserWindowController fetch:]):
768         (-[WK2BrowserWindowController validateMenuItem:]):
769         (-[WK2BrowserWindowController reload:]):
770         (-[WK2BrowserWindowController goBack:]):
771         (-[WK2BrowserWindowController goForward:]):
772         (-[WK2BrowserWindowController toggleZoomMode:]):
773         (-[WK2BrowserWindowController resetZoom:]):
774         (-[WK2BrowserWindowController canResetZoom]):
775         (-[WK2BrowserWindowController dumpSourceToConsole:]):
776         (-[WK2BrowserWindowController togglePaginationMode:]):
777         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
778         (-[WK2BrowserWindowController windowShouldClose:]):
779         (-[WK2BrowserWindowController applicationTerminating]):
780         (-[WK2BrowserWindowController currentZoomFactor]):
781         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
782         (-[WK2BrowserWindowController toggleTransparentWindow:]):
783         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
784         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
785         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
786         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
787         (-[WK2BrowserWindowController find:]):
788         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
789         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
790         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
791         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
792         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
793         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
794         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
795         * WebKitTestRunner/PlatformWebView.h:
796         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
797         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
798
799 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
800
801         Use RunLoop objects through references instead of pointers
802         https://bugs.webkit.org/show_bug.cgi?id=130313
803
804         Reviewed by Andreas Kling.
805
806         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
807         return RunLoop reference instead of a pointer.
808
809         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
810         (loadedCallback):
811         (clickedCallback):
812
813 2014-03-17  Tim Horton  <timothy_horton@apple.com>
814
815         sort-export-file --help doesn't work (missing 'use')
816         https://bugs.webkit.org/show_bug.cgi?id=130338
817
818         Reviewed by Anders Carlsson.
819
820         * Scripts/sort-export-file:
821         Add a missing 'use', and fix a typo in an error message.
822
823 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
824
825         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
826         https://bugs.webkit.org/show_bug.cgi?id=130155
827
828         Reviewed by Philippe Normand.
829
830         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
831
832 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
833
834         [GTK] MiniBrowser fails to load injected bundle lib
835         https://bugs.webkit.org/show_bug.cgi?id=130332
836
837         Reviewed by Anders Carlsson.
838
839         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
840
841         * MiniBrowser/gtk/main.c:
842         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
843         process is spawn.
844
845 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
846
847         [EFL] Enable TOUCH_SLIDER macro
848         https://bugs.webkit.org/show_bug.cgi?id=130185
849
850         Reviewed by Gyuyoung Kim.
851
852         * Scripts/webkitperl/FeatureList.pm:
853
854 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
855
856         [GTK][CMake] Build with -fno-rtti
857         https://bugs.webkit.org/show_bug.cgi?id=130261
858
859         Reviewed by Martin Robinson.
860
861         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
862         defined to 0 to prevent typeid use in included GTest headers.
863
864 2014-03-16  Brian Burg  <bburg@apple.com>
865
866         Web Inspector: vended backend commands file should be generated as part of the build
867         https://bugs.webkit.org/show_bug.cgi?id=130110
868
869         Reviewed by Timothy Hatcher.
870
871         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
872
873 2014-03-16  Diego Pino García  <dpino@igalia.com>
874
875         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
876         https://bugs.webkit.org/show_bug.cgi?id=128999
877
878         Reviewed by Philippe Normand.
879
880         * MiniBrowser/gtk/BrowserWindow.c:
881         (reloadPage):
882         (reloadPageIgnoringCache):
883         (browser_window_init):
884
885 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
886
887         [GTK] Improve ninja detection in webkitdirs.pm
888         https://bugs.webkit.org/show_bug.cgi?id=129902
889
890         Reviewed by Daniel Bates.
891
892         * Scripts/webkitdirs.pm:
893         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
894         us to look for ninja-build as well.
895
896 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
897
898         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
899         https://bugs.webkit.org/show_bug.cgi?id=130276
900         <rdar://problem/16266927>
901         
902         Reviewed by Simon Fraser.
903
904         * BuildSlaveSupport/build-launcher-app:
905         * BuildSlaveSupport/build-launcher-dmg:
906         * DumpRenderTree/DumpRenderTree.h:
907         * DumpRenderTree/DumpRenderTreePrefix.h:
908         * DumpRenderTree/GCController.cpp:
909         * DumpRenderTree/GCController.h:
910         * DumpRenderTree/JavaScriptThreading.cpp:
911         * DumpRenderTree/JavaScriptThreading.h:
912         * DumpRenderTree/PixelDumpSupport.cpp:
913         * DumpRenderTree/PixelDumpSupport.h:
914         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
915         * DumpRenderTree/TestRunner.cpp:
916         * DumpRenderTree/TestRunner.h:
917         * DumpRenderTree/WorkQueue.cpp:
918         * DumpRenderTree/WorkQueue.h:
919         * DumpRenderTree/WorkQueueItem.h:
920         * DumpRenderTree/atk/AccessibilityCallbacks.h:
921         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
922         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
923         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
924         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
925         * DumpRenderTree/cg/PixelDumpSupportCG.h:
926         * DumpRenderTree/efl/EditingCallbacks.cpp:
927         * DumpRenderTree/efl/EditingCallbacks.h:
928         * DumpRenderTree/efl/EventSender.cpp:
929         * DumpRenderTree/efl/EventSender.h:
930         * DumpRenderTree/efl/GCControllerEfl.cpp:
931         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
932         * DumpRenderTree/efl/TestRunnerEfl.cpp:
933         * DumpRenderTree/gtk/DumpRenderTree.cpp:
934         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
935         * DumpRenderTree/gtk/EditingCallbacks.cpp:
936         * DumpRenderTree/gtk/EditingCallbacks.h:
937         * DumpRenderTree/gtk/EventSender.cpp:
938         * DumpRenderTree/gtk/EventSender.h:
939         * DumpRenderTree/gtk/GCControllerGtk.cpp:
940         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
941         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
942         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
943         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
944         * DumpRenderTree/gtk/TextInputController.cpp:
945         * DumpRenderTree/gtk/TextInputController.h:
946         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
947         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
948         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
949         * DumpRenderTree/mac/AppleScriptController.h:
950         * DumpRenderTree/mac/AppleScriptController.m:
951         * DumpRenderTree/mac/CheckedMalloc.cpp:
952         * DumpRenderTree/mac/CheckedMalloc.h:
953         * DumpRenderTree/mac/DumpRenderTree.mm:
954         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
955         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
956         * DumpRenderTree/mac/DumpRenderTreeMac.h:
957         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
958         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
959         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
960         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
961         * DumpRenderTree/mac/EditingDelegate.h:
962         * DumpRenderTree/mac/EditingDelegate.mm:
963         * DumpRenderTree/mac/EventSendingController.h:
964         * DumpRenderTree/mac/EventSendingController.mm:
965         * DumpRenderTree/mac/FrameLoadDelegate.h:
966         * DumpRenderTree/mac/FrameLoadDelegate.mm:
967         * DumpRenderTree/mac/GCControllerMac.mm:
968         * DumpRenderTree/mac/MockWebNotificationProvider.h:
969         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
970         * DumpRenderTree/mac/NavigationController.h:
971         * DumpRenderTree/mac/NavigationController.m:
972         * DumpRenderTree/mac/ObjCController.h:
973         * DumpRenderTree/mac/ObjCController.m:
974         * DumpRenderTree/mac/ObjCPlugin.h:
975         * DumpRenderTree/mac/ObjCPlugin.m:
976         * DumpRenderTree/mac/ObjCPluginFunction.h:
977         * DumpRenderTree/mac/ObjCPluginFunction.m:
978         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
979         * DumpRenderTree/mac/PolicyDelegate.h:
980         * DumpRenderTree/mac/PolicyDelegate.mm:
981         * DumpRenderTree/mac/ResourceLoadDelegate.h:
982         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
983         * DumpRenderTree/mac/TestRunnerMac.mm:
984         * DumpRenderTree/mac/TextInputController.h:
985         * DumpRenderTree/mac/TextInputController.m:
986         * DumpRenderTree/mac/UIDelegate.h:
987         * DumpRenderTree/mac/UIDelegate.mm:
988         * DumpRenderTree/mac/WorkQueueItemMac.mm:
989         * DumpRenderTree/win/DRTDataObject.cpp:
990         * DumpRenderTree/win/DRTDataObject.h:
991         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
992         * DumpRenderTree/win/DRTDropSource.cpp:
993         * DumpRenderTree/win/DRTDropSource.h:
994         * DumpRenderTree/win/DraggingInfo.h:
995         * DumpRenderTree/win/DumpRenderTree.cpp:
996         * DumpRenderTree/win/DumpRenderTreeWin.h:
997         * DumpRenderTree/win/EditingDelegate.cpp:
998         * DumpRenderTree/win/EditingDelegate.h:
999         * DumpRenderTree/win/EventSender.cpp:
1000         * DumpRenderTree/win/EventSender.h:
1001         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1002         * DumpRenderTree/win/FrameLoadDelegate.h:
1003         * DumpRenderTree/win/GCControllerWin.cpp:
1004         * DumpRenderTree/win/HistoryDelegate.cpp:
1005         * DumpRenderTree/win/HistoryDelegate.h:
1006         * DumpRenderTree/win/MD5.cpp:
1007         * DumpRenderTree/win/MD5.h:
1008         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1009         * DumpRenderTree/win/PolicyDelegate.cpp:
1010         * DumpRenderTree/win/PolicyDelegate.h:
1011         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1012         * DumpRenderTree/win/ResourceLoadDelegate.h:
1013         * DumpRenderTree/win/TestRunnerWin.cpp:
1014         * DumpRenderTree/win/TextInputController.cpp:
1015         * DumpRenderTree/win/TextInputController.h:
1016         * DumpRenderTree/win/TextInputControllerWin.cpp:
1017         * DumpRenderTree/win/UIDelegate.cpp:
1018         * DumpRenderTree/win/UIDelegate.h:
1019         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1020         * EWebLauncher/main.c:
1021         * GtkLauncher/main.c:
1022         * ImageDiff/efl/ImageDiff.cpp:
1023         * ImageDiff/gtk/ImageDiff.cpp:
1024         * MiniBrowser/gtk/main.c:
1025         * Scripts/SpacingHeuristics.pm:
1026         * Scripts/VCSUtils.pm:
1027         * Scripts/bisect-builds:
1028         * Scripts/build-dumprendertree:
1029         * Scripts/build-jsc:
1030         * Scripts/build-webkit:
1031         * Scripts/check-dom-results:
1032         * Scripts/check-for-exit-time-destructors:
1033         * Scripts/check-for-global-initializers:
1034         * Scripts/commit-log-editor:
1035         * Scripts/compare-timing-files:
1036         * Scripts/debug-minibrowser:
1037         * Scripts/debug-safari:
1038         * Scripts/do-file-rename:
1039         * Scripts/find-extra-includes:
1040         * Scripts/generate-coverage-data:
1041         * Scripts/make-script-test-wrappers:
1042         * Scripts/malloc-tree:
1043         * Scripts/old-run-webkit-tests:
1044         * Scripts/parse-malloc-history:
1045         * Scripts/report-include-statistics:
1046         * Scripts/resolve-ChangeLogs:
1047         * Scripts/run-bindings-tests:
1048         * Scripts/run-iexploder-tests:
1049         * Scripts/run-javascriptcore-tests:
1050         * Scripts/run-jsc:
1051         * Scripts/run-launcher:
1052         * Scripts/run-leaks:
1053         * Scripts/run-mangleme-tests:
1054         * Scripts/run-minibrowser:
1055         * Scripts/run-pageloadtest:
1056         * Scripts/run-regexp-tests:
1057         * Scripts/run-safari:
1058         * Scripts/run-sunspider:
1059         * Scripts/run-webkit-app:
1060         * Scripts/sampstat:
1061         * Scripts/set-webkit-configuration:
1062         * Scripts/sort-Xcode-project-file:
1063         * Scripts/sort-export-file:
1064         * Scripts/split-file-by-class:
1065         * Scripts/sunspider-compare-results:
1066         * Scripts/svn-apply:
1067         * Scripts/svn-create-patch:
1068         * Scripts/svn-unapply:
1069         * Scripts/test-webkit-scripts:
1070         * Scripts/update-javascriptcore-test-results:
1071         * Scripts/update-webkit:
1072         * Scripts/update-webkit-auxiliary-libs:
1073         * Scripts/update-webkit-dependency:
1074         * Scripts/update-webkit-localizable-strings:
1075         * Scripts/update-webkit-support-libs:
1076         * Scripts/update-webkit-wincairo-libs:
1077         * Scripts/webkit-build-directory:
1078         * Scripts/webkitdirs.pm:
1079         (installedSafariPath):
1080         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1081         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1082         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1083         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1084         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1085         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1086         * Scripts/webkitperl/features.pm:
1087         * Scripts/webkitperl/httpd.pm:
1088         * Scripts/webkitpy/bindings/main.py:
1089         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1090         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1091         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1092         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1093         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1094         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1095         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1096         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1097         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1098         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1099         * WebKitTestRunner/PixelDumpSupport.cpp:
1100         * WebKitTestRunner/PixelDumpSupport.h:
1101         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1102         * WinLauncher/WinLauncher.cpp:
1103         * WinLauncher/WinLauncher.h:
1104         * WinLauncher/stdafx.cpp:
1105         * WinLauncher/stdafx.h:
1106
1107 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1108
1109         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1110         https://bugs.webkit.org/show_bug.cgi?id=130265
1111
1112         Reviewed by Michael Saboff.
1113
1114         * Scripts/build-webkit:
1115         * Scripts/copy-webkitlibraries-to-product-directory:
1116
1117 2014-03-14  Landry Breuil  <landry@openbsd.org>
1118
1119         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1120         Also allow to set MAKE in the environment.
1121         https://bugs.webkit.org/show_bug.cgi?id=129991
1122
1123         Reviewed by Andreas Kling.
1124
1125         * Scripts/webkitdirs.pm:
1126         (determineArchitecture):
1127         (determineNumberOfCPUs):
1128         (isBSD):
1129         (buildAutotoolsProject):
1130         * Scripts/webkitpy/common/system/platforminfo.py:
1131         (PlatformInfo.__init__):
1132         (PlatformInfo.is_openbsd):
1133         (PlatformInfo):
1134         (PlatformInfo.is_netbsd):
1135         (PlatformInfo._determine_os_name):
1136
1137 2014-03-14  Dean Jackson  <dino@apple.com>
1138
1139         Remove libWebKitSystemInterfaceLion.a
1140         https://bugs.webkit.org/show_bug.cgi?id=130254
1141
1142         Reviewed by Geoffrey Garen and Andreas Kling.
1143
1144         No need to copy the Lion libraries into the build.
1145
1146         * Scripts/copy-webkitlibraries-to-product-directory:
1147
1148 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1149
1150         [EFL][MiniBrowser] Revise help messages of command line parameters
1151         https://bugs.webkit.org/show_bug.cgi?id=130222
1152
1153         Reviewed by Csaba Osztrogonác.
1154
1155         Correct the default value description and make help messages to be consistent.
1156
1157         * MiniBrowser/efl/main.c:
1158
1159 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1160
1161         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1162         https://bugs.webkit.org/show_bug.cgi?id=129612
1163
1164         Reviewed by Darin Adler.
1165
1166         For new code use static NeverDestroyed<T> instead.
1167
1168         * DumpRenderTree/JavaScriptThreading.cpp:
1169         (javaScriptThreadsMutex):
1170         (javaScriptThreads):
1171         * DumpRenderTree/efl/EventSender.cpp:
1172         (touchPointList):
1173         (delayedEventQueue):
1174         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1175         (delegatesWithDelayedWork):
1176         * Scripts/check-for-exit-time-destructors:
1177         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1178         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1179         (testsMap):
1180
1181 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1182
1183         [EFL][WK2] Fix compilation warning in Minibrowser
1184         https://bugs.webkit.org/show_bug.cgi?id=130132
1185
1186         Reviewed by Csaba Osztrogonác.
1187
1188         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1189
1190         * MiniBrowser/efl/main.c:
1191         (on_download_request):
1192
1193 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1194
1195         FTL should support IsBlah
1196         https://bugs.webkit.org/show_bug.cgi?id=130202
1197
1198         Reviewed by Geoffrey Garen.
1199         
1200         Running existing JSRegress tests with noInline gives us coverage for these
1201         changes. Chances are, this will also give coverage for other interesting things
1202         as well.
1203
1204         * Scripts/run-jsc-stress-tests:
1205
1206 2014-03-12  Brian Burg  <bburg@apple.com>
1207
1208         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1209         https://bugs.webkit.org/show_bug.cgi?id=129744
1210
1211         Reviewed by Timothy Hatcher.
1212
1213         * DumpRenderTree/TestRunner.cpp:
1214         (evaluateInWebInspectorCallback):
1215         * DumpRenderTree/TestRunner.h:
1216         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1217         (TestRunner::evaluateInWebInspector):
1218         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1219         (TestRunner::evaluateInWebInspector):
1220         * DumpRenderTree/mac/TestRunnerMac.mm:
1221         (TestRunner::evaluateInWebInspector):
1222         * DumpRenderTree/win/TestRunnerWin.cpp:
1223         (TestRunner::evaluateInWebInspector):
1224         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1225         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1226         (WTR::TestRunner::evaluateInWebInspector):
1227         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1228
1229 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1230
1231         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1232         https://bugs.webkit.org/show_bug.cgi?id=130129
1233
1234         Reviewed by Csaba Osztrogonác.
1235
1236         * Scripts/webkitdirs.pm:
1237         (canUseNinja): Redirecting stderr to /dev/null
1238
1239 2014-03-13  Andres Gomez  <agomez@igalia.com>
1240
1241         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1242         https://bugs.webkit.org/show_bug.cgi?id=130092
1243
1244         Reviewed by Csaba Osztrogonác.
1245
1246         Added "python-dev" as dependency for deb based distros. It is
1247         already present for rpm based distros. This dependency will allow
1248         libxml2 to generate its python bindings, needed by gtk-doc.
1249
1250         * gtk/install-dependencies:
1251
1252 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1253
1254         Unreviewed. Fix GTK+ cmake build after r165488.
1255
1256         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1257
1258 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1259
1260         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1261         https://bugs.webkit.org/show_bug.cgi?id=130014
1262
1263         Reviewed by Martin Robinson.
1264
1265         Include cmake or autotools config header.
1266
1267         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1268         * MiniBrowser/gtk/BrowserSearchBar.c:
1269         * MiniBrowser/gtk/BrowserWindow.c:
1270         * MiniBrowser/gtk/main.c:
1271
1272 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1273
1274         Unreviewed, rolling out r165471.
1275         https://bugs.webkit.org/show_bug.cgi?id=130139
1276
1277         Didn't really fix the issue and broke another bot (Requested
1278         by mrobinson on #webkit).
1279
1280         Reverted changeset:
1281
1282         "[CMake] Newer versions of CMake cannot find older versions of
1283         Freetype"
1284         https://bugs.webkit.org/show_bug.cgi?id=130107
1285         http://trac.webkit.org/changeset/165471
1286
1287 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1288
1289         It should be possible to build WebKit with FTL on iOS
1290         https://bugs.webkit.org/show_bug.cgi?id=130116
1291
1292         Reviewed by Dan Bernstein.
1293
1294         * Scripts/build-webkit:
1295         * Scripts/copy-webkitlibraries-to-product-directory:
1296
1297 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1298
1299         [Win] Remove use of QTSDK
1300         https://bugs.webkit.org/show_bug.cgi?id=130049
1301
1302         Reviewed by Darin Adler.
1303
1304         * DumpRenderTree/win/DumpRenderTree.cpp:
1305         (initialize): Remove QuickTime code.
1306         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1307         building QTMovieWin.
1308
1309 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1310
1311         [GTK][CMAKE] Too verbose build output
1312         https://bugs.webkit.org/show_bug.cgi?id=130076
1313
1314         Reviewed by Carlos Garcia Campos.
1315
1316         Instead of building with cmake --build which isn't smart about pretty printing and
1317         colors, we build with a script which calls the proper build command.
1318
1319         * Scripts/webkitdirs.pm:
1320         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1321         the CMake configuration pass.
1322
1323 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1324
1325         [CMake] Newer versions of CMake cannot find older versions of Freetype
1326         https://bugs.webkit.org/show_bug.cgi?id=130107
1327
1328         Reviewed by Gustavo Noronha Silva.
1329
1330         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1331         to CMake during jhbuild initialization.
1332
1333 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1334
1335         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1336         https://bugs.webkit.org/show_bug.cgi?id=129961
1337
1338         Reviewed by Simon Fraser.
1339
1340         Now scaled content can go through the window capturing mechanism too for compositing content.
1341         AppleMagnifiedMode is redundant.
1342
1343         * DumpRenderTree/mac/DumpRenderTree.mm:
1344         (setDefaultsToConsistentValuesForTesting):
1345         (runTest):
1346         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1347         (createBitmapContextFromWebView):
1348         * WebKitTestRunner/PlatformWebView.h:
1349         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1350         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1351         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1352         (WTR::PlatformWebView::didInitializeClients):
1353         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1354         (WTR::PlatformWebView::forceWindowFramesChanged):
1355         * WebKitTestRunner/mac/main.mm:
1356         (setDefaultsToConsistentValuesForTesting):
1357
1358 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1359
1360         Unreviewed. Add myself as a committer.
1361
1362         * Scripts/webkitpy/common/config/contributors.json:
1363
1364 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1365
1366         Unreviewed build fix on the EFL port when used lower version of ATK
1367
1368         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1369         (WTR::AccessibilityUIElement::y): Fixed typo.
1370
1371 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1372
1373         Some images are blank in the rebaseline server UI
1374         https://bugs.webkit.org/show_bug.cgi?id=130104
1375
1376         Reviewed by Tim Horton.
1377
1378         Let the server check for images in the 'retries' directory
1379         if it can't find an image otherwise.
1380
1381         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1382         (RebaselineHTTPRequestHandler.test_result):
1383
1384 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1385
1386         [GTK][CMake] --update-gtk has no effect
1387         https://bugs.webkit.org/show_bug.cgi?id=130088
1388
1389         Reviewed by Philippe Normand.
1390
1391         * Scripts/webkitdirs.pm:
1392         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1393         as an argument.
1394
1395 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1396
1397         Add "System Font" to the list of whitelisted DRT fonts
1398         https://bugs.webkit.org/show_bug.cgi?id=130046
1399
1400         Reviewed by Darin Adler.
1401
1402         * DumpRenderTree/mac/DumpRenderTree.mm:
1403         (allowedFontFamilySet):
1404         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1405
1406 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1407
1408         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1409         https://bugs.webkit.org/show_bug.cgi?id=130064
1410
1411         Reviewed by Philippe Normand.
1412
1413         * efl/jhbuildrc: Remove duplicated code.
1414         * gtk/jhbuildrc: Remove duplicated code.
1415         * jhbuild/jhbuildrc_common.py:
1416         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1417         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1418         and is apparently necessary for GTK+.
1419
1420 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1421
1422         check-webkit-style failed to complain about missing braces
1423         https://bugs.webkit.org/show_bug.cgi?id=34189
1424
1425         Reviewed by Ryosuke Niwa.
1426
1427         * Scripts/webkitpy/style/checkers/cpp.py:
1428         (check_braces):
1429         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1430         (WebKitStyleTest.test_braces):
1431
1432 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1433
1434         Remove Qt cruft from style checker.
1435         https://bugs.webkit.org/show_bug.cgi?id=130085
1436
1437         Reviewed by Csaba Osztrogonác.
1438
1439         There is no 'foreach' keyword in c++. That was a Qt feature
1440         added in: http://trac.webkit.org/changeset/46113
1441         Qt was removed from WebKit, so we should remove the checks
1442         of this keyword from check-webkit-style scripts.
1443
1444         * Scripts/webkitpy/style/checkers/cpp.py:
1445         (check_spacing_for_function_call):
1446         (check_spacing):
1447         (check_braces):
1448         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1449         (CppStyleTest.test_mismatching_spaces_in_parens):
1450         (CppStyleTest.test_spacing_for_fncall):
1451         (WebKitStyleTest.test_braces):
1452
1453 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1454
1455         [GTK] update-webkitgtk-libs needs itstool
1456         https://bugs.webkit.org/show_bug.cgi?id=130082
1457
1458         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1459         itstool is a dependency of building gtk-doc from version 1.19, so it should
1460         be added to Tools/gtk/install-dependencies script, too.
1461
1462         Reviewed by Philippe Normand.
1463
1464         * gtk/install-dependencies:
1465
1466 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1467
1468         webkitbot rollout ChangeLogs should be nicer
1469         https://bugs.webkit.org/show_bug.cgi?id=122654
1470
1471         Reviewed by Csaba Osztrogonác.
1472
1473         Added bug urls and descriptions of rolled out patches to the rollout changelog
1474         if they are present in the original changelog. Additionally removed the list of
1475         changed files and functions.
1476
1477         * Scripts/webkitpy/common/checkout/changelog.py:
1478         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1479         * Scripts/webkitpy/common/checkout/checkout.py:
1480         (Checkout._changelog_data_for_revision): Store bug description.
1481         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1482         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1483         (CheckoutTest.test_commit_info_for_revision):
1484         * Scripts/webkitpy/common/checkout/commitinfo.py:
1485         (CommitInfo.bug_description): Added.
1486         (CommitInfo.to_json):
1487         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1488         (CommitInfoTest.test_commit_info_creation):
1489         * Scripts/webkitpy/tool/commands/download.py:
1490         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1491         out patches for creating rollout changelog.
1492         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1493         caused the regression is stored in state["bug_blocked"] now.
1494         * Scripts/webkitpy/tool/commands/download_unittest.py:
1495         (test_prepare_rollout):
1496         (test_create_rollout_multiple_revision):
1497         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1498         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1499         rolled out patches to the changelog.
1500         (PrepareChangeLogForRevert.run):
1501         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1502         (UpdateChangeLogsForRevertTest):
1503         (test_message_for_revert):
1504         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1505         (ReopenBugAfterRollout.run):
1506
1507 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1508
1509         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1510         https://bugs.webkit.org/show_bug.cgi?id=130021
1511
1512         Reviewed by Mario Sanchez Prada.
1513
1514         Replace deprecated functions to use new API from ATK 2.11.90.
1515
1516         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1517         (AccessibilityUIElement::x):
1518         (AccessibilityUIElement::y):
1519         (AccessibilityUIElement::width):
1520         (AccessibilityUIElement::height):
1521         (AccessibilityUIElement::clickPointX):
1522         (AccessibilityUIElement::clickPointY):
1523         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1524         (WTR::AccessibilityUIElement::x):
1525         (WTR::AccessibilityUIElement::y):
1526         (WTR::AccessibilityUIElement::width):
1527         (WTR::AccessibilityUIElement::height):
1528         (WTR::AccessibilityUIElement::clickPointX):
1529         (WTR::AccessibilityUIElement::clickPointY):
1530
1531 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1532
1533         [ATK] Expose aria-posinset and aria-setsize through object attributes
1534         https://bugs.webkit.org/show_bug.cgi?id=130011
1535
1536         Reviewed by Chris Fleizach.
1537
1538         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1539
1540         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1541         (AccessibilityUIElement::numberAttributeValue):
1542         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1543         (WTR::AccessibilityUIElement::numberAttributeValue):
1544
1545 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1546
1547         [Win] Unreviewed build fix.
1548
1549         Some bad Windows code was committed at some point that prevents the Apple Windows port
1550         from finding its runtime dependencies reliably.
1551
1552         * win/DLLLauncher/DLLLauncherMain.cpp:
1553         (appleApplicationSupportDirectory): Restored this function.
1554         (modifyPath): Update to use appleApplicationSupportDirectory function.
1555
1556 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1557
1558         Let the user define the full address of the performance-site-server for uploading results
1559         https://bugs.webkit.org/show_bug.cgi?id=129819
1560
1561         Reviewed by Ryosuke Niwa.
1562
1563         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1564         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1565         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1566         protocol for now, in order to avoid breaking the perf bots.
1567
1568         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1569         (_upload_json):
1570         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1571         (MainTest.test_upload_json):
1572
1573 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1574
1575         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1576         https://bugs.webkit.org/show_bug.cgi?id=130023
1577
1578         Reviewed by Dean Jackson.
1579
1580         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1581         /SAFESEH flag to DLL launcher process.
1582
1583 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1584
1585         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1586         https://bugs.webkit.org/show_bug.cgi?id=129980
1587
1588         Reviewed by Carlos Garcia Campos.
1589
1590         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1591
1592 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1593
1594         [GTK] Remove the WebView source-mode WebKit1 test
1595         https://bugs.webkit.org/show_bug.cgi?id=129976
1596
1597         Reviewed by Carlos Garcia Campos.
1598
1599         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1600
1601 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1602
1603         Unreviewed build fix for GTKbuild after the switch to CMake
1604
1605         * gtk/common.py:
1606         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1607         test-only bot doesn't have any build files.
1608
1609 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1610
1611         [GTK] built-product-archive does not handle GTK+ CMake build
1612         https://bugs.webkit.org/show_bug.cgi?id=129941
1613
1614         * BuildSlaveSupport/built-product-archive:
1615         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1616         the CMake build.
1617
1618 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1619
1620         [GTK] Include CMake into install-dependencies script
1621         https://bugs.webkit.org/show_bug.cgi?id=129909
1622
1623         Reviewed by Martin Robinson.
1624
1625         As since r165267 buid-webkit uses CMake by default, the dependency
1626         with 'cmake' package should be introduced.
1627
1628         * gtk/install-dependencies: Ditto.
1629
1630 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1631
1632         REGRESSION(165267): Broke a webkitpy unit tests
1633         https://bugs.webkit.org/show_bug.cgi?id=129904
1634
1635         Reviewed by Jon Honeycutt.
1636
1637         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1638         (GtkPort._is_cmake_build):
1639
1640 2014-03-07  Andres Gomez  <agomez@igalia.com>
1641
1642         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1643         https://bugs.webkit.org/show_bug.cgi?id=129893
1644
1645         Reviewed by Martin Robinson.
1646
1647         Added "git-svn" as dependency for deb based distros and,
1648         additionally, "subversion" for rpm based distros.
1649
1650         * gtk/install-dependencies:
1651
1652 2014-03-07  Roger Fong  <roger_fong@apple.com>
1653
1654         Remove dummy setSystemWebGLLoadPolicy client method.
1655         https://bugs.webkit.org/show_bug.cgi?id=129873.
1656
1657         Reviewed by Dean Jackson.
1658
1659         * WebKitTestRunner/TestController.cpp:
1660         (WTR::TestController::createWebViewWithOptions):
1661
1662 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1663
1664         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1665         https://bugs.webkit.org/show_bug.cgi?id=129886
1666
1667         Reviewed by Mark Lam.
1668
1669         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1670         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1671         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1672         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1673         make it through when in non-verbose mode.
1674
1675 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1676
1677         [GTK] buid-webkit should use CMake by default
1678         https://bugs.webkit.org/show_bug.cgi?id=129855
1679
1680         Reviewed by Carlos Garcia Campos.
1681
1682         Make the CMake build the default GTK+ build when using build-webkit. This will
1683         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1684         so that we have --gtk and --gtkautotools.
1685
1686         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1687         * Scripts/webkitpy/port/gtk.py: Ditto.
1688
1689 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1690
1691         [CMake] [GTK] Build with ninja when it is available
1692         https://bugs.webkit.org/show_bug.cgi?id=129805
1693
1694         Reviewed by Philippe Normand.
1695
1696         * Scripts/webkitdirs.pm:
1697         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1698         if it's available on the system.
1699         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1700         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1701
1702 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1703
1704         If the FTL is build-time enabled then it should be run-time enabled.
1705
1706         Rubber stamped by Geoffrey Garen.
1707
1708         * Scripts/run-jsc-stress-tests:
1709
1710 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1711
1712         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1713         https://bugs.webkit.org/show_bug.cgi?id=129837
1714
1715         Reviewed by Michael Saboff.
1716
1717         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1718         The fix is to use find instead of ls like we do in shell-runner.sh.
1719
1720         * Scripts/run-jsc-stress-tests:
1721
1722 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1723
1724         filter-build-webkit should not strip .o
1725         https://bugs.webkit.org/show_bug.cgi?id=129614
1726
1727         Reviewed by Dean Jackson.
1728
1729         This makes it much easier to jump from the failing output at
1730         the end back up to the compile errors earlier in the output.
1731
1732         * Scripts/filter-build-webkit:
1733
1734 2014-03-06  Anders Carlsson  <andersca@apple.com>
1735
1736         Build WebKit2 before building WebKit
1737         https://bugs.webkit.org/show_bug.cgi?id=129831
1738         <rdar://problem/15920020>
1739
1740         Reviewed by Dan Bernstein.
1741
1742         * Scripts/build-webkit:
1743         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1744
1745 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1746
1747         make-3.82 fails to build on ARM/Linux
1748         https://bugs.webkit.org/show_bug.cgi?id=107926
1749
1750         Reviewed by Martin Robinson.
1751
1752         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1753         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1754         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1755         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1756
1757         * gtk/patches/make-3.82-arg-list-length.patch:
1758
1759 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1760
1761         [GTK] Close the page when the view is disposed instead of when finalized
1762         https://bugs.webkit.org/show_bug.cgi?id=129783
1763
1764         Reviewed by Sergio Villar Senin.
1765
1766         Add test case but disabled for now because it's affetected by bug #129684.
1767
1768         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1769         (testProcessPerWebView):
1770
1771 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1772
1773         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1774         https://bugs.webkit.org/show_bug.cgi?id=129738
1775
1776         Reviewed by Sergio Villar Senin.
1777
1778         The problem is that we are calling g_object_unref() for the
1779         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1780         view only increases the reference counter when the settings is not
1781         the same it currently has. We should release our reference once.
1782
1783         * MiniBrowser/gtk/main.c:
1784         (createBrowserWindow):
1785         (main):
1786
1787 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1788
1789         [GTK][CMake] Tarball is created with wrong tarball paths
1790         https://bugs.webkit.org/show_bug.cgi?id=129496
1791
1792         Reviewed by Daniel Bates.
1793
1794         * gtk/make-dist.py:
1795         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1796         landing the original patch with some suggestions from the reviewer. With the
1797         checks corrected, the tarball path is constructed properly.
1798
1799 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1800
1801         Unreviewed. Update my email in contributors.json
1802
1803         * Scripts/webkitpy/common/config/contributors.json:
1804
1805 2014-03-05  Dean Jackson  <dino@apple.com>
1806
1807         [WebGL] Use WKSI to see what the system policy for WebGL is
1808         https://bugs.webkit.org/show_bug.cgi?id=129722
1809         <rdar://problem/15790542>
1810
1811         Reviewed by Tim Horton.
1812
1813         Dummy entry for setSystemWebGLLoadPolicy.
1814
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::TestController::createWebViewWithOptions):
1817
1818 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1819
1820         [GTK][CMake] Generate documentation for the DOM bindings
1821         https://bugs.webkit.org/show_bug.cgi?id=126211
1822
1823         Reviewed by Carlos Garcia Campos.
1824
1825         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1826         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1827         * gtk/generate-webkitdom-doc-files: Removed.
1828         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1829         that it can be called by generate-gtkdoc.
1830
1831 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1832
1833         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1834         https://bugs.webkit.org/show_bug.cgi?id=129380
1835
1836         Reviewed by Philippe Normand.
1837
1838         * Scripts/webkitdirs.pm:
1839         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1840         skipping CMake execution.
1841
1842 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1843
1844         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1845         https://bugs.webkit.org/show_bug.cgi?id=129651
1846
1847         Reviewed by Philippe Normand.
1848
1849         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1850
1851 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1852
1853         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1854         https://bugs.webkit.org/show_bug.cgi?id=129637
1855
1856         Reviewed by Carlos Garcia Campos.
1857
1858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1859         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1860         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1861         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1862         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1863         (TestFactory.__init__): Add the test for GTK+.
1864         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1865
1866 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1867
1868         [ATK] Expose missing functionalities of AtkTableCell to AT
1869         https://bugs.webkit.org/show_bug.cgi?id=129492
1870
1871         Reviewed by Mario Sanchez Prada.
1872
1873         Reducing some code by using new API of AtkTableCell.
1874
1875         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1876         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1877
1878 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1879
1880         Preparing to run layout tests on Wincairo.
1881         https://bugs.webkit.org/show_bug.cgi?id=129709
1882
1883         Reviewed by Brent Fulgham.
1884
1885         * Scripts/webkitdirs.pm:
1886         (setPathForRunningWebKitApp):
1887         Add GStreamer directory for WinCairo running layout tests.
1888         * win/DLLLauncher/DLLLauncherMain.cpp:
1889         (modifyPath):
1890         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1891
1892 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1893
1894         [GTK] Simplify the GObject DOM bindings API break check into one step
1895         https://bugs.webkit.org/show_bug.cgi?id=129571
1896
1897         Reviewed by Carlos Garcia Campos.
1898
1899         * GNUmakefile.am: Add the API break check to 'make check.'
1900         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1901         * gtk/check-gdom-symbols: Removed.
1902         * gtk/webkitdom.py: Added.
1903         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1904         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1905
1906 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1907
1908         Add Jeremy Jones to the contributors list as a contributor.
1909
1910         * Scripts/webkitpy/common/config/contributors.json:
1911
1912 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1913
1914         Unreviewed. Update contact email.
1915         https://bugs.webkit.org/show_bug.cgi?id=129610
1916
1917         * Scripts/webkitpy/common/config/contributors.json:
1918
1919 2014-03-02  Brian Burg  <bburg@apple.com>
1920
1921         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1922         https://bugs.webkit.org/show_bug.cgi?id=129460
1923
1924         Reviewed by Dan Bernstein.
1925
1926         Don't unconditionally open the inspector before running an inspector test.
1927         Instead, the test should request that the inspector open when it's ready.
1928
1929         This change was lost during a rebase, but is the same change made to
1930         DumpRenderTree.
1931
1932         * WebKitTestRunner/TestInvocation.cpp:
1933         (WTR::TestInvocation::invoke): 
1934
1935 2014-03-02  Darin Adler  <darin@apple.com>
1936
1937         Split TextIteratorBehavior into a separate header
1938         https://bugs.webkit.org/show_bug.cgi?id=129578
1939
1940         Reviewed by Sam Weinig.
1941
1942         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1943         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1944         task easy, but the remove is still a bit of a pain.
1945
1946 2014-03-02  Darin Adler  <darin@apple.com>
1947
1948         Sort Mac platform export files so they merge better
1949         https://bugs.webkit.org/show_bug.cgi?id=129581
1950
1951         Reviewed by Sam Weinig.
1952
1953         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1954         Mac export files in a "canonical" order for this project.
1955
1956 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1957
1958         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1959         https://bugs.webkit.org/show_bug.cgi?id=129438
1960
1961         Reviewed by Simon Fraser.
1962
1963         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1964         offscreen window. It makes testing subpixel rendering and positioning possible.
1965
1966         Both the offscreen window's and WebKit's scaling are set accordingly.
1967
1968         * DumpRenderTree/mac/DumpRenderTree.mm:
1969         (createWebViewAndOffscreenWindow): cleanup
1970         (destroyWebViewAndOffscreenWindow): cleanup
1971         (dumpRenderTree):
1972         (changeWindowScaleIfNeeded):
1973         (runTest):
1974         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1975         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1976         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1977         * WebKitTestRunner/PlatformWebView.h:
1978         * WebKitTestRunner/TestInvocation.cpp:
1979         (WTR::changeWindowScaleIfNeeded):
1980         (WTR::TestInvocation::invoke):
1981         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1982         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1983         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1984         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1985         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1986         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1987         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1988         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1989
1990 2014-02-28  Anders Carlsson  <andersca@apple.com>
1991
1992         Remove logging.
1993
1994         Reviewed by Dan Bernstein.
1995
1996         * MiniBrowser/mac/WK2BrowserWindowController.m:
1997         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1998
1999 2014-02-28  Daniel Bates  <dabates@apple.com>
2000
2001         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
2002         https://bugs.webkit.org/show_bug.cgi?id=129163
2003
2004         Reviewed by David Kilzer.
2005
2006         Fixes an issue where DumpRenderTree Perl Support may build with the specified
2007         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
2008         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
2009         bundle.
2010
2011         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
2012         which is specified either explicitly when building with MAKE(1) or implicitly by
2013         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
2014         the OS X SDK and toolchain since the built products are only applicable to OS X.
2015
2016         * DumpRenderTree/ios/PerlSupport/Makefile:
2017
2018 2014-02-28  Commit Queue  <commit-queue@webkit.org>
2019
2020         Unreviewed, rolling out r164859.
2021         http://trac.webkit.org/changeset/164859
2022         https://bugs.webkit.org/show_bug.cgi?id=129483
2023
2024         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
2025         #webkit).
2026
2027         * DumpRenderTree/mac/DumpRenderTree.mm:
2028         (createWebViewAndOffscreenWindow):
2029         (dumpRenderTree):
2030         (runTest):
2031         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2032         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2033         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2034         * WebKitTestRunner/PlatformWebView.h:
2035         * WebKitTestRunner/TestInvocation.cpp:
2036         (WTR::TestInvocation::invoke):
2037         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2038         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2039         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2040         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2041         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2042
2043 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2044
2045         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2046         https://bugs.webkit.org/show_bug.cgi?id=129438
2047
2048         Reviewed by Simon Fraser.
2049
2050         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2051         offscreen window. It makes testing subpixel rendering and positioning possible.
2052
2053         Both the offscreen window's and WebKit's scaling are set accordingly.
2054
2055         * DumpRenderTree/mac/DumpRenderTree.mm:
2056         (createWebViewAndOffscreenWindow): unrelated cleanup.
2057         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2058         (dumpRenderTree):
2059         (changeOffscreenWindowScaleIfNeeded):
2060         (runTest):
2061         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2062         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2063         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2064         * WebKitTestRunner/PlatformWebView.h:
2065         * WebKitTestRunner/TestInvocation.cpp:
2066         (WTR::changeOffscreenWindowScaleIfNeeded):
2067         (WTR::TestInvocation::invoke):
2068         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2069         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2070
2071 2014-02-27  Brian Burg  <bburg@apple.com>
2072
2073         Web Inspector: model tests should use a special Test.html inspector page
2074         https://bugs.webkit.org/show_bug.cgi?id=129190
2075
2076         Reviewed by Timothy Hatcher.
2077
2078         Remove code that immediately opens the Web Inspector based on the file path of the test.
2079         Instead, the test page should request that the inspector open inside its `test()` method.
2080
2081         This change is necessary because otherwise, the inspector would be opened too early for
2082         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2083         will get loaded instead of the minimal test page.
2084
2085         * DumpRenderTree/efl/DumpRenderTree.cpp:
2086         (createTestRunner):
2087         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2088         (runTest):
2089         * DumpRenderTree/mac/DumpRenderTree.mm:
2090         (runTest):
2091         * DumpRenderTree/win/DumpRenderTree.cpp:
2092         (runTest):
2093
2094 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2095
2096         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2097         https://bugs.webkit.org/show_bug.cgi?id=127076
2098
2099         Reviewed by Anders Carlsson.
2100
2101         Avoid match for :: as start of a member initialization list. Modify expression to match
2102         after a colon either non-colon character or end of line.
2103
2104         * Scripts/webkitpy/style/checkers/cpp.py:
2105         (check_member_initialization_list):
2106         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2107         (WebKitStyleTest.test_member_initialization_list):
2108
2109 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2110
2111         Unreviewed. Update my email addresses in contributors.json.
2112
2113         * Scripts/webkitpy/common/config/contributors.json:
2114
2115 2014-02-27  Alberto Garcia  <berto@igalia.com>
2116
2117         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2118         https://bugs.webkit.org/show_bug.cgi?id=128927
2119
2120         Reviewed by Philippe Normand.
2121
2122         Encode manually the data for sys.{stdout,stderr}.write.
2123
2124         * gtk/gtkdoc.py:
2125         (GTKDoc._run_command):
2126
2127 2014-02-27  Andres Gomez  <agomez@igalia.com>
2128
2129         Unreviewed. Add myself to watchlists
2130
2131         * Scripts/webkitpy/common/config/watchlist: Add myself to
2132         watchlists.
2133
2134 2014-02-27  Andres Gomez  <agomez@igalia.com>
2135
2136         Unreviewed, rolling out r164790.
2137         http://trac.webkit.org/changeset/164790
2138
2139         Revert r164790 because of erroneous commit log
2140
2141         * Scripts/webkitpy/common/config/watchlist:
2142
2143 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2144
2145         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2146         https://bugs.webkit.org/show_bug.cgi?id=129250
2147
2148         Reviewed by Mario Sanchez Prada.
2149
2150         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2151         Implementing methods so that we could test column/row headers represented as an array of cells.
2152
2153         * DumpRenderTree/AccessibilityUIElement.cpp:
2154         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2155         (AccessibilityUIElement::columnHeaders):
2156         (AccessibilityUIElement::rowHeaders):
2157         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2158         (AccessibilityUIElement::columnHeaders):
2159         (AccessibilityUIElement::rowHeaders):
2160         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2161         (WTR::AccessibilityUIElement::rowHeaders):
2162         (WTR::AccessibilityUIElement::columnHeaders):
2163         * efl/jhbuild.modules:
2164         * gtk/jhbuild.modules:
2165
2166 2014-02-27  Andres Gomez  <agomez@igalia.com>
2167
2168         Unreviewed. Add myself to watchlists
2169
2170         * Scripts/webkitpy/common/config/watchlist: Add myself to
2171         watchlists.
2172
2173 2014-02-27  Andres Gomez  <agomez@igalia.com>
2174
2175         Unreviewed. Add myself as a committer.
2176
2177         * Scripts/webkitpy/common/config/contributors.json:
2178
2179 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2180
2181         Unreviewed. Add Víctor Jáquez and myself to watchlists
2182
2183         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2184         myself to watchlists.
2185
2186 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2187
2188         Unreviewed. Add myself as a committer.
2189
2190         * Scripts/webkitpy/common/config/contributors.json:
2191
2192 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2193
2194         Unreviewed. Moved myself to the list of committers.
2195
2196         * Scripts/webkitpy/common/config/contributors.json:
2197
2198 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2199
2200         [GTK] Reduplicate common.top_level_path in scripts
2201         https://bugs.webkit.org/show_bug.cgi?id=129291
2202
2203         Reviewed by Philippe Normand.
2204
2205         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2206         path manipulation and weird dependencies on the jhbuild infrastructure.
2207
2208         * Scripts/run-gtk-tests: Use common again.
2209         (TestRunner._setup_testing_environment): Ditto.
2210         * gtk/check-gdom-symbols: Ditto.
2211         * gtk/common.py:
2212         (top_level_path): Re-add top_level_path..
2213         (get_build_path): Use the builtin top_level_path again.
2214         * gtk/find-make-dist-errors: Use common again.
2215         (get_missing_headers): Ditto.
2216         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2217
2218 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2219
2220         runscript: line 42: /bin/ls: Argument list too long
2221         https://bugs.webkit.org/show_bug.cgi?id=129376
2222
2223         Reviewed by Michael Saboff.
2224
2225         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
2226         We should use find instead, which generates the list of files rather than expanding them all on 
2227         the command line and spitting them back out.
2228
2229         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
2230
2231 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2232
2233         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2234         https://bugs.webkit.org/show_bug.cgi?id=129377
2235
2236         Reviewed by Csaba Osztrogonác.
2237
2238         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2239
2240 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2241
2242         [GTK] Re-enable gtk-doc in EWS
2243         https://bugs.webkit.org/show_bug.cgi?id=128369
2244
2245         Reviewed by Carlos Garcia Campos.
2246
2247         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2248
2249         * Scripts/webkitpy/common/config/ports.py:
2250         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2251         (GtkWK2Port.build_webkit_command): Ditto.
2252         * Scripts/webkitpy/common/config/ports_unittest.py:
2253         (DeprecatedPortTest.test_gtk_port): Ditto.
2254         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2255
2256 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2257
2258         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2259         https://bugs.webkit.org/show_bug.cgi?id=129319
2260
2261         Reviewed by Carlos Garcia Campos.
2262
2263         * gtk/generate-gtkdoc:
2264         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2265
2266 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2267
2268         Unreviewed. Add myself as a committer.
2269
2270         * Scripts/webkitpy/common/config/contributors.json:
2271
2272 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2273
2274         [CSS Grid Layout] Add ENABLE flag
2275         https://bugs.webkit.org/show_bug.cgi?id=129153
2276
2277         Reviewed by Simon Fraser.
2278
2279         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2280         all ports for developer builds.
2281
2282         * Scripts/webkitperl/FeatureList.pm:
2283
2284 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2285
2286         Added myself as a committer.
2287
2288         Unreviewed.
2289
2290         * Scripts/webkitpy/common/config/contributors.json:
2291
2292 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2293
2294         Unreviewed. Moved myself to the list of committers.
2295
2296         * Scripts/webkitpy/common/config/contributors.json:
2297
2298 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2299
2300         Move myself to the committers list.
2301
2302         Unreviewed.
2303
2304         * Scripts/webkitpy/common/config/contributors.json:
2305
2306 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2307
2308         Unreviewed. Add myself as a committer.
2309
2310         * Scripts/webkitpy/common/config/contributors.json:
2311
2312 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2313
2314         Unreviewed, rolling out r164639.
2315         http://trac.webkit.org/changeset/164639
2316         https://bugs.webkit.org/show_bug.cgi?id=129302
2317
2318         gtk-doc still have problems in EWS (Requested by rego on
2319         #webkit).
2320
2321         * Scripts/webkitpy/common/config/ports.py:
2322         (GtkPort.build_webkit_command):
2323         (GtkWK2Port.build_webkit_command):
2324         * Scripts/webkitpy/common/config/ports_unittest.py:
2325         (DeprecatedPortTest.test_gtk_port):
2326         (DeprecatedPortTest.test_gtk_wk2_port):
2327
2328 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2329
2330         [GTK] Re-enable gtk-doc in EWS
2331         https://bugs.webkit.org/show_bug.cgi?id=128369
2332
2333         Reviewed by Carlos Garcia Campos.
2334
2335         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2336
2337         * Scripts/webkitpy/common/config/ports.py:
2338         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2339         (GtkWK2Port.build_webkit_command): Ditto.
2340         * Scripts/webkitpy/common/config/ports_unittest.py:
2341         (DeprecatedPortTest.test_gtk_port): Ditto.
2342         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2343
2344 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2345
2346         [GTK] Mark view source mode methods as deprecated
2347         https://bugs.webkit.org/show_bug.cgi?id=128920
2348
2349         Reviewed by Martin Robinson.
2350
2351         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2352         (beforeAll): Remove view mode test.
2353
2354 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2355
2356         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2357         https://bugs.webkit.org/show_bug.cgi?id=128417
2358
2359         Reviewed by Carlos Garcia Campos.
2360
2361         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2362         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2363         a makefile. This allows accepting a header list from the build system, which can be used
2364         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2365         have a corresponding header file on the header list. 
2366         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2367         source directories to gtkdoc-scan.
2368
2369 2014-02-24  Anders Carlsson  <andersca@apple.com>
2370
2371         Add a DefaultVisitedLinkProvider and route visited link actions through it
2372         https://bugs.webkit.org/show_bug.cgi?id=129285
2373
2374         Reviewed by Dan Bernstein.
2375
2376         * MiniBrowser/mac/AppDelegate.m:
2377         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2378         Set a shared history so we'll get visited link tracking.
2379
2380         * MiniBrowser/mac/WK1BrowserWindowController.m:
2381         (-[WK1BrowserWindowController awakeFromNib]):
2382         Set a group name.
2383
2384 2014-02-24  Dan Bernstein  <mitz@apple.com>
2385
2386         iOS build fix after r164577.
2387
2388         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2389         (AccessibilityUIElement::selectedChildrenCount):
2390         (AccessibilityUIElement::selectedChildAtIndex):
2391
2392 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2393
2394         [ASan] Remove methods from ignore list that no longer cause crashes
2395         <http://webkit.org/b/129257>
2396
2397         Reviewed by Anders Carlsson.
2398
2399         * asan/webkit-asan-ignore.txt: Remove old methods.
2400
2401 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2402
2403         Extract common parts from jhbuildrc files.
2404         https://bugs.webkit.org/show_bug.cgi?id=125986
2405
2406         Reviewed by Csaba Osztrogonác.
2407
2408         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2409
2410         * Scripts/run-gtk-tests:
2411         (TestRunner._setup_testing_environment):
2412         * efl/common.py: Removed.
2413         * efl/jhbuildrc:
2414         * gtk/check-gdom-symbols:
2415         * gtk/common.py:
2416         (binary_build_path):
2417         (get_build_path):
2418         * gtk/find-make-dist-errors:
2419         (get_missing_headers):
2420         * gtk/generate-gtkdoc:
2421         (get_webkit2_options):
2422         (get_webkit1_options.src_path):
2423         (get_webkit1_options):
2424         (get_webkitdom_options.src_path):
2425         (get_webkitdom_options):
2426         * gtk/generate-inspector-gresource-manifest.py:
2427         * gtk/jhbuildrc:
2428         * jhbuild/jhbuildrc_common.py: Added.
2429         (script_path):
2430         (top_level_path):
2431         (init):
2432
2433 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2434
2435         Unreviewed. Fix code indentation and spacing.
2436
2437         * Scripts/webkitpy/style/checkers/js.py:
2438         (SingleQuoteChecker.check):
2439
2440 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2441
2442         [ATK] Wrong selected element at a given index in a list box.
2443         https://bugs.webkit.org/show_bug.cgi?id=129039
2444
2445         Reviewed by Chris Fleizach.
2446
2447         Added missing implementation and proposed some new function for testing selection
2448         in a list boxes.
2449
2450         * DumpRenderTree/AccessibilityUIElement.cpp:
2451         (setSelectedChildAtIndexCallback):
2452         (removeSelectionAtIndexCallback):
2453         (AccessibilityUIElement::getJSClass):
2454         * DumpRenderTree/AccessibilityUIElement.h:
2455         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2456         (AccessibilityUIElement::selectedChildrenCount):
2457         (AccessibilityUIElement::selectedChildAtIndex):
2458         (AccessibilityUIElement::setSelectedChildAtIndex):
2459         (AccessibilityUIElement::removeSelectionAtIndex):
2460         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2461         (AccessibilityUIElement::selectedChildrenCount):
2462         (AccessibilityUIElement::selectedChildAtIndex):
2463         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2464         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2465         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2466         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2467         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2468         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2469         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2470         (WTR::AccessibilityUIElement::selectedChildrenCount):
2471         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2472         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2473
2474 2014-02-23  Diego Pino García  <dpino@igalia.com>
2475
2476         [GTK] Fix build after Web Inspector code reorganization (r164543)
2477         https://bugs.webkit.org/show_bug.cgi?id=129231
2478
2479         Reviewed by Dean Jackson.
2480
2481         * gtk/generate-inspector-gresource-manifest.py:
2482         Modify paths to Web Inspector code.
2483
2484 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2485
2486         [GTK] generate-gtkdoc should use argparse
2487         https://bugs.webkit.org/show_bug.cgi?id=128418
2488
2489         Reviewed by Carlos Garcia Campos.
2490
2491         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2492         to all functions, and guard the main routine with a __name__ == __main__ check.
2493
2494 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2495
2496         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2497         https://bugs.webkit.org/show_bug.cgi?id=129191
2498
2499         Reviewed by Anders Carlsson.
2500
2501         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2502         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2503         name of the directory is "lib" and not "libs". Instead we should use the CMake
2504         variable specifically assigned to this task.
2505
2506 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2507
2508         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2509         <http://webkit.org/b/129209>
2510
2511         Reviewed by Geoffrey Garen.
2512
2513         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2514         ignore list to make ASan builds usable again.  Follow-up
2515         investigation is tracked by <rdar://problem/16055903>.
2516
2517 2014-02-20  David Farler  <dfarler@apple.com>
2518
2519         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2520         https://bugs.webkit.org/show_bug.cgi?id=128622
2521
2522         Reviewed by Simon Fraser.
2523
2524         With this change, we now have layout tests running in both DumpRenderTree
2525         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2526         simulator.
2527
2528         * Scripts/old-run-webkit-tests:
2529         In general, make any specific reference to DumpRenderTree
2530         able to refer to WebKitTestRunner wherever possible:
2531         - Rename functions to remove DRT-specific naming.
2532         - Name FIFOs after the tool that is being used.
2533         -- Clean up FIFO creation code
2534         Other necessary changes:
2535         - Allow use of an ios-sim-wk2 platform.
2536         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2537         * WebKitTestRunner/TestController.cpp:
2538         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2539         (WTR::TestController::TestController):
2540         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2541         Copy the injected bundle into the app bundle.
2542
2543 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2544
2545         run-webkit-httpd fails to find httpd configuation file.
2546
2547         Reviewed by Ryosuke Niwa.
2548
2549         * Scripts/webkitperl/httpd.pm:
2550         (getHTTPDConfigPathForTestDirectory):
2551
2552 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2553
2554         Fix TimeRanges layering violations
2555         https://bugs.webkit.org/show_bug.cgi?id=128717
2556
2557         Reviewed by Jer Noble.
2558
2559         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2560         (TestWebKitAPI::TEST):
2561
2562 2014-02-21  Diego Pino García  <dpino@igalia.com>
2563
2564         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2565         https://bugs.webkit.org/show_bug.cgi?id=128422
2566
2567         Reviewed by Joseph Pecoraro.
2568
2569         * Scripts/webkitpy/style/checkers/js.py:
2570         (JSChecker.__init__):
2571         (JSChecker.check):
2572         (SingleQuoteChecker):
2573         (SingleQuoteChecker.__init__):
2574         (SingleQuoteChecker.check):
2575         * Scripts/webkitpy/style/checkers/js_unittest.py:
2576         (JSTestCase.assertError.error_for_test):
2577         (JSTestCase.assertError):
2578         (JSTestCase.test_no_error):
2579         (JSTestCase.test_error):
2580
2581 == Rolled over to ChangeLog-2014-02-20 ==