1 2015-04-26 Gyuyoung Kim <gyuyoung.kim@webkit.org>
3 [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake
4 https://bugs.webkit.org/show_bug.cgi?id=144217
6 Reviewed by Darin Adler.
8 * WebKitTestRunner/PlatformEfl.cmake:
10 2015-04-26 Doug Russell <d_russell@apple.com>
12 AX: richer text change notifications (142719)
13 https://bugs.webkit.org/show_bug.cgi?id=142719
15 Reviewed by Darin Adler.
17 Richer accessibility value change notifications. Introduce AXTextEditType,
18 postTextStateChangeNotification and postTextReplacementNotification to give assistive
19 tech apps more reliable context for responding to changes in web content. Also implement
20 a mechanism to post value changes in password form fields in coalesced ticks to thwart
21 analyzing the cadence of changes.
23 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
24 and an overload of postTextReplacementNotification to give assistive tech apps more
25 reliable context for responding to changes in web content selection. Also block posting
26 selection changes on password fields.
28 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
29 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
30 (-[AccessibilityNotificationHandler stopObserving]):
31 (-[AccessibilityNotificationHandler _notificationReceived:]):
32 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
33 (AccessibilityUIElement::removeNotificationListener):
34 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
35 (-[AccessibilityNotificationHandler _notificationReceived:]):
36 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
37 (WTR::AccessibilityUIElement::removeNotificationListener):
39 2015-04-25 Sungmann Cho <sungmann.cho@navercorp.com>
41 Add myself to contributors.json
42 https://bugs.webkit.org/show_bug.cgi?id=144204
44 Reviewed by Darin Adler.
46 * Scripts/webkitpy/common/config/contributors.json:
48 2015-04-25 Martin Robinson <mrobinson@igalia.com>
50 Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
51 https://bugs.webkit.org/show_bug.cgi?id=144182
53 Reviewed by Simon Fraser.
55 * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
57 2015-04-25 Dewei Zhu <dewei_zhu@apple.com>
59 https://bugs.webkit.org/show_bug.cgi?id=144038
61 Reviewed by Ryosuke Niwa
63 Add a script to run Speedometer and JetStream on a browser.
65 * Scripts/run-benchmark: Wrapper script to run benchmark.
67 * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
68 * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
69 * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
70 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
71 (BenchmarkBuilderFactory):
72 * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
73 * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
74 (GenericBenchmarkBuilder):
75 (GenericBenchmarkBuilder.prepare):
76 (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
77 (GenericBenchmarkBuilder._applyPatch):
78 (GenericBenchmarkBuilder.clean):
79 * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
80 (JetStreamBenchmarkBuilder):
81 (JetStreamBenchmarkBuilder.prepare):
82 (JetStreamBenchmarkBuilder._runCreateScript):
83 * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
85 (BenchmarkRunner.__init__):
86 (BenchmarkRunner.execute):
87 (BenchmarkRunner.dump):
88 (BenchmarkRunner.wrap):
89 (BenchmarkRunner.merge):
90 * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
91 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
93 (BrowserDriver.prepareEnv):
94 (BrowserDriver.launchUrl):
95 (BrowserDriver.closeBrowser):
96 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
97 (BrowserDriverFactory):
98 * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
99 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
101 (OSXChromeDriver.prepareEnv):
102 (OSXChromeDriver.launchUrl):
103 (OSXChromeDriver.closeBrowsers):
104 * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
106 (OSXSafariDriver.prepareEnv):
107 (OSXSafariDriver.launchUrl):
108 (OSXSafariDriver.closeBrowsers):
109 * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
110 * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
111 * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
112 * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
113 * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
115 (GenericFactory.iterateGetItem):
116 (GenericFactory.create):
117 * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
118 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
120 (ServerControl.render_GET):
121 (ServerControl.render_POST):
122 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
124 (HTTPServerDriver.serve):
125 (HTTPServerDriver.fetchResult):
126 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
127 (HTTPServerDriverFactory):
128 * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
129 * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
130 (SimpleHTTPServerDriver):
131 (SimpleHTTPServerDriver.depends):
132 (SimpleHTTPServerDriver.__init__):
133 (SimpleHTTPServerDriver.serve):
134 (SimpleHTTPServerDriver.baseUrl):
135 (SimpleHTTPServerDriver.fetchResult):
136 * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
137 (ModuleNotFoundError):
139 (getPathFromProjectRoot):
144 (timeout.handle_timeout):
148 2015-04-24 Commit Queue <commit-queue@webkit.org>
150 Unreviewed, rolling out r183303.
151 https://bugs.webkit.org/show_bug.cgi?id=144181
153 Change was incorrect, broke builds (Requested by smfr on
159 http://trac.webkit.org/changeset/183303
161 2015-04-24 Simon Fraser <simon.fraser@apple.com>
165 * MiniBrowser/mac/WK2BrowserWindowController.m:
166 (-[WK2BrowserWindowController initWithConfiguration:]):
168 2015-04-24 Brent Fulgham <bfulgham@apple.com>
170 Disable ActionMenusPDFTest due to timeout on test bot
172 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
173 (TestWebKitAPI::TEST):
175 2015-04-24 Commit Queue <commit-queue@webkit.org>
177 Unreviewed, rolling out r183266.
178 https://bugs.webkit.org/show_bug.cgi?id=144164
180 Broke 32-bit build and a test. (Requested by ap on #webkit).
184 "AX: richer text change notifications (142719)"
185 https://bugs.webkit.org/show_bug.cgi?id=142719
186 http://trac.webkit.org/changeset/183266
188 2015-04-24 Brent Fulgham <bfulgham@apple.com>
190 REGRESSION: WebKit2.ActionMenusTest API test fails
191 https://bugs.webkit.org/show_bug.cgi?id=144149
192 <rdar://problem/20677770>
194 Reviewed by Tim Horton.
196 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
197 as the 'ActionMenusPDFTest'.
198 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
199 (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
200 to match the hit test on the 'action-menu-target.pdf' test file.
202 2015-04-24 Daniel Bates <dabates@apple.com>
204 Cleanup: Use @memoized for property IOSSimulator.testing_device
205 https://bugs.webkit.org/show_bug.cgi?id=141715
207 Reviewed by Darin Adler.
209 Simplify the caching of the result of IOSSimulator.testing_device
210 and make the code more readable by making use of the @memoized declarator
211 instead of explicitly managing a private instance variable,
212 IOSSimulator._testing_device, for the cached result.
214 * Scripts/webkitpy/port/ios.py:
215 (IOSPort.determine_full_port_name):
216 (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
218 (IOSSimulatorPort.testing_device): No need to cache the created device object in
219 IOSSimulatorPort._testing_device since we are marking this function @memoized.
220 (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
221 of caching in local variable since we only make use of this value exactly once in this function.
222 (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
223 been used since being added in r178622. So, we can remove this constructor since
224 it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
226 2015-04-24 Anders Carlsson <andersca@apple.com>
228 Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
229 https://bugs.webkit.org/show_bug.cgi?id=144158
231 Reviewed by Beth Dakin.
233 * MiniBrowser/mac/WK2BrowserWindowController.m:
234 (-[WK2BrowserWindowController initWithConfiguration:]):
236 2015-04-24 Doug Russell <d_russell@apple.com>
238 AX: richer text change notifications (142719)
239 https://bugs.webkit.org/show_bug.cgi?id=142719
241 Reviewed by Darin Adler.
243 Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
245 Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
247 * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
248 * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
249 (-[AccessibilityNotificationHandler stopObserving]):
250 (-[AccessibilityNotificationHandler _notificationReceived:]):
251 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
252 (AccessibilityUIElement::removeNotificationListener):
253 * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
254 (-[AccessibilityNotificationHandler _notificationReceived:]):
255 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
256 (WTR::AccessibilityUIElement::removeNotificationListener):
258 2015-04-24 Darin Adler <darin@apple.com>
260 Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
261 https://bugs.webkit.org/show_bug.cgi?id=128007
263 Reviewed by Anders Carlsson.
265 * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
266 * DumpRenderTree/win/UIDelegate.h: Ditto.
268 * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
269 * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
271 * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
273 * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
274 (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
275 * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
276 (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
277 * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
278 (WebKitDOMDOMWindowTest::create): Ditto.
279 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
280 (documentLoadedCallback): Use a queue of DelayedSignal objects instead
281 of smart pointers to DelayedSIgnal objects.
282 (uriChangedCallback): Ditto.
284 2015-04-24 Brent Fulgham <bfulgham@apple.com>
286 [Mac] Unreviewed test fix.
287 https://bugs.webkit.org/show_bug.cgi?id=144149
289 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
290 (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
293 2015-04-23 Darin Adler <darin@apple.com>
295 Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
296 https://bugs.webkit.org/show_bug.cgi?id=144090
298 Reviewed by Anders Carlsson.
300 * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
302 2015-04-23 Michael Saboff <msaboff@apple.com>
304 lldb macro btjs sometimes can't get a frame description
305 https://bugs.webkit.org/show_bug.cgi?id=144130
307 Reviewed by Filip Pizlo.
309 We look to execute ExecState::describeFrame(). It appears that in some contexts the
310 debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
311 ExecState. Therefore we can fallback to using CallFrame::describeFrame().
313 * lldb/lldb_webkit.py:
316 2015-04-23 Alex Christensen <achristensen@webkit.org>
318 Use less memory when compiling content extensions.
319 https://bugs.webkit.org/show_bug.cgi?id=144051
321 Reviewed by Darin Adler and Benjamin Poulain.
323 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
324 (TestWebKitAPI::TEST_F):
325 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
326 (TestWebKitAPI::countLiveNodes):
328 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
330 [CMake] Clean up JSC JIT options
331 https://bugs.webkit.org/show_bug.cgi?id=143998
333 Reviewed by Filip Pizlo.
335 * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
336 * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
338 2015-04-21 Brent Fulgham <bfulgham@apple.com>
340 [Mac] Extend action menus to support PDF
341 https://bugs.webkit.org/show_bug.cgi?id=143895
342 <rdar://problem/19003333>
344 Reviewed by Tim Horton.
346 Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
347 of PDF content works.
349 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
350 * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
351 * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
352 * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
353 (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
354 Update to support PDF tests.
355 (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
356 (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
358 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
360 Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
362 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
364 (testWebViewAudioOnlyUserMediaPermissionRequests):
366 2015-04-22 Michael Catanzaro <mcatanzaro@igalia.com>
368 Add myself to watchlist
369 https://bugs.webkit.org/show_bug.cgi?id=144041
371 Reviewed by Alex Christensen.
373 Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
375 * Scripts/webkitpy/common/config/watchlist:
377 2015-04-22 Carlos Garcia Campos <cgarcia@igalia.com>
379 [GTK] MiniBrowser should use NetworkProcess by default
380 https://bugs.webkit.org/show_bug.cgi?id=143948
382 Reviewed by Sergio Villar Senin.
384 Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
385 unless MINIBROWSER_SINGLEPROCESS environment variable is present.
387 * MiniBrowser/gtk/main.c:
390 2015-04-21 Matthew Hanson <matthew_hanson@apple.com>
392 Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
394 Unreviewed build fix.
396 * Scripts/prepare-ChangeLog:
397 (get_function_line_ranges_for_cpp):
398 Use grep instead of any to determine if a string is an element of an array.
400 2015-04-21 Anders Carlsson <andersca@apple.com>
403 https://bugs.webkit.org/show_bug.cgi?id=144002
405 Reviewed by Andreas Kling.
407 * MiniBrowser/mac/WK2BrowserWindowController.m:
408 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
410 2015-04-21 Philippe Normand <pnormand@igalia.com>
412 [GTK] jhbuild should not use a branch for openwebrtc
413 https://bugs.webkit.org/show_bug.cgi?id=143981
415 Reviewed by Carlos Garcia Campos.
417 * gtk/jhbuild.modules:
419 2015-04-20 Matthew Hanson <matthew_hanson@apple.com>
421 Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
423 Unreviewed build fix.
425 The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
426 However, it has been exposed by List::MoreUtils since its inception. This patch uses
427 the any function exposed by List::MoreUtils for greater compatibility.
429 * Scripts/prepare-ChangeLog:
430 Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
431 the any function in all of versions of Perl used by our infrastructure.
433 2015-04-20 Alex Christensen <achristensen@webkit.org>
435 Remove unnecessary logs when resetting tests.
437 * WebKitTestRunner/mac/TestControllerMac.mm:
438 (WTR::TestController::platformResetPreferencesToConsistentValues):
439 In r183020 I added some logs when compiling or removing content extensions fails.
440 We often try to remove a content extension that does not exist, and that is not a problem.
442 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
444 prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
445 https://bugs.webkit.org/show_bug.cgi?id=143897
447 Reviewed by David Kilzer.
449 This is a speculative fix that addresses two issues:
451 1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
452 We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
454 So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
458 Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
459 Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
461 This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
462 to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
464 The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
466 2. Creating git diffs from HEAD and not origin/master by default.
468 Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
469 when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
471 * Scripts/prepare-ChangeLog:
473 Use HEAD instead of origin/master in default Git case.
475 (generateFunctionLists):
476 Ensure that the end line is not less than the start line.
478 (extractLineRangeAfterChange):
479 Set the end line to the start line if the end line is less than the start line.
481 (extractLineRangeBeforeChange):
484 2015-04-17 Matthew Hanson <matthew_hanson@apple.com>
486 Suppress warning in prepare-ChangeLog.
487 https://bugs.webkit.org/show_bug.cgi?id=143882
489 Reviewed by David Kilzer.
491 Prune noisy prepare-ChangeLog output by using the List::Util::any function
492 instead of the deprecated smartmatch operator.
494 * Scripts/prepare-ChangeLog:
495 Import the List::Util::any function.
497 (get_function_line_ranges_for_cpp):
498 Use the any function instead of smartmatch.
500 2015-04-20 Anders Carlsson <andersca@apple.com>
502 Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
503 https://bugs.webkit.org/show_bug.cgi?id=143966
505 Reviewed by Dan Bernstein.
507 * MiniBrowser/mac/WK2BrowserWindowController.m:
509 (-[WK2BrowserWindowController fetchWebsiteData:]):
510 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
511 (-[WK2BrowserWindowController clearWebsiteData:]):
513 2015-04-20 Alex Christensen <achristensen@webkit.org>
515 Fix content extension test flakiness.
516 https://bugs.webkit.org/show_bug.cgi?id=143950
518 Reviewed by Brady Eidson.
520 * WebKitTestRunner/mac/TestControllerMac.mm:
521 (WTR::TestController::platformResetPreferencesToConsistentValues):
522 Remove the TestContentExtensions if it exists.
523 (WTR::TestController::platformConfigureViewForTest):
524 Log errors in case there are any.
526 2015-04-20 Alex Christensen <achristensen@webkit.org>
528 Properly report errors from _WKUserContentExtensionStore.
529 https://bugs.webkit.org/show_bug.cgi?id=143808
531 Reviewed by Darin Adler.
533 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
536 2015-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
538 Add a rule for NetworkCache to watchlist file
539 https://bugs.webkit.org/show_bug.cgi?id=143945
541 Reviewed by Sergio Villar Senin.
543 And add myself to the list of watchers.
545 * Scripts/webkitpy/common/config/watchlist:
547 2015-04-19 Darin Adler <darin@apple.com>
549 Update RefPtr documentation and deprecation
550 https://bugs.webkit.org/show_bug.cgi?id=143936
552 Reviewed by Andreas Kling.
554 * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
556 2015-04-19 Yusuke Suzuki <utatane.tea@gmail.com>
558 Introduce bytecode intrinsics
559 https://bugs.webkit.org/show_bug.cgi?id=143926
561 Reviewed by Filip Pizlo.
563 Change cpplint to accept emit_intrinsic_XXX.
565 * Scripts/webkitpy/style/checkers/cpp.py:
566 (check_identifier_name_in_declaration):
568 2015-04-18 Simon Fraser <simon.fraser@apple.com>
570 Fix lldb_webkit.py to show StringImpls correctly
571 https://bugs.webkit.org/show_bug.cgi?id=143920
573 Reviewed by Andreas Kling.
575 Update WTFStringImplProvider's is_8bit to use the correct bitmask.
577 * lldb/lldb_webkit.py:
578 (WTFStringImplProvider.is_8bit):
580 2015-04-17 Daniel Bates <dabates@apple.com>
582 Not able to build WebKit against iOS Simulator 8.3 SDK
583 https://bugs.webkit.org/show_bug.cgi?id=143883
585 Reviewed by David Kilzer.
587 Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
588 so that Xcode uses them.
590 * Scripts/copy-webkitlibraries-to-product-directory:
592 2015-04-17 Beth Dakin <bdakin@apple.com>
594 Force mouse events should go through normal mouse event handling code paths
595 https://bugs.webkit.org/show_bug.cgi?id=143749
597 rdar://problem/20472895
599 Reviewed by Dean Jackson.
601 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
602 Since there is not a way to create an NSEventTypePressure from scratch, we
603 subclass NSEvent and override all of the critical methods.
605 * WebKitTestRunner/EventSenderProxy.h:
606 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
607 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
608 (WTR::EventSendingController::mouseForceDown):
609 (WTR::EventSendingController::mouseForceUp):
610 (WTR::EventSendingController::mouseForceChanged):
611 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
612 * WebKitTestRunner/TestController.cpp:
613 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
614 * WebKitTestRunner/mac/EventSenderProxy.mm:
615 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
616 (-[EventSenderPressureEvent timestamp]):
617 (-[EventSenderPressureEvent type]):
618 (-[EventSenderPressureEvent locationInWindow]):
619 (-[EventSenderPressureEvent location]):
620 (-[EventSenderPressureEvent stage]):
621 (-[EventSenderPressureEvent pressure]):
622 (-[EventSenderPressureEvent phase]):
623 (-[EventSenderPressureEvent eventNumber]):
624 (WTR::EventSenderProxy::mouseForceDown):
625 (WTR::EventSenderProxy::mouseForceUp):
626 (WTR::EventSenderProxy::mouseForceChanged):
628 2015-04-17 Alexey Proskuryakov <ap@apple.com>
630 build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
631 https://bugs.webkit.org/show_bug.cgi?id=143885
633 Reviewed by Tim Horton.
635 Fixed a case where we have two builds with the same revision(s). An in order build
636 is one for which the revision is strictly higher.
638 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
639 (BuildbotQueue.prototype._checkForInOrderResult):
640 (BuildbotQueue.prototype.compareIterationsByRevisions):
642 2015-04-17 Commit Queue <commit-queue@webkit.org>
644 Unreviewed, rolling out r182912 and r182920.
645 https://bugs.webkit.org/show_bug.cgi?id=143881
647 Build breakage in some configurations (Requested by ap on
652 "Force mouse events should go through normal mouse event
654 https://bugs.webkit.org/show_bug.cgi?id=143749
655 http://trac.webkit.org/changeset/182912
657 http://trac.webkit.org/changeset/182920
659 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
661 [GTK] One more unreviewed fix after r182882.
663 * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
665 2015-04-17 Csaba Osztrogonác <ossy@webkit.org>
667 [GTK] Unreviewed speculative clean build fix after r182882.
669 TestWebKitAPI's forwarding header generator depended on WeKit2's
670 which generated SOUP related forwarding headers too.
672 This dependency isn't necessary and was removed by r182882 to make
673 forwarding header generators parallelizable. But in this case
674 TestWebKitAPI's and WebKitTestRunner's forwarding header generator
675 should generate SOUP related forwarding headers too similar to EFL.
677 * TestWebKitAPI/PlatformGTK.cmake:
678 * WebKitTestRunner/PlatformGTK.cmake:
680 2015-04-17 Carlos Garcia Campos <cgarcia@igalia.com>
682 [SOUP] Redirect to non HTTP destination is broken
683 https://bugs.webkit.org/show_bug.cgi?id=143866
685 Reviewed by Sergio Villar Senin.
687 Add a unit test to check that redirect to a data URI works.
689 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
690 (testRedirectToDataURI):
694 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
696 Changes method of quitting iOS Simulator to be more correct.
697 https://bugs.webkit.org/show_bug.cgi?id=143847
698 <rdar://problem/20530344>
700 Reviewed by Darin Adler.
702 Fixes by addressing the app by ID rather than by name.
704 * Scripts/webkitdirs.pm:
706 * Scripts/webkitpy/port/ios.py:
707 (IOSSimulatorPort.check_sys_deps):
709 2015-04-16 Anders Carlsson <andersca@apple.com>
711 Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
712 https://bugs.webkit.org/show_bug.cgi?id=143844
714 Reviewed by Dan Bernstein.
716 * MiniBrowser/mac/AppDelegate.m:
717 (-[BrowserAppDelegate newPrivateWindow:]):
718 * MiniBrowser/mac/WK2BrowserWindowController.m:
719 (-[WK2BrowserWindowController initWithConfiguration:]):
720 (-[WK2BrowserWindowController fetchWebsiteData:]):
721 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
722 (-[WK2BrowserWindowController clearWebsiteData:]):
724 2015-04-16 Alex Christensen <achristensen@webkit.org>
728 * WebKitTestRunner/mac/TestControllerMac.mm:
729 (WTR::TestController::platformResetPreferencesToConsistentValues):
730 (WTR::TestController::platformConfigureViewForTest):
731 Added WK_API_ENABLED.
733 2015-04-16 Alex Christensen <achristensen@webkit.org>
735 Removed unused WKUserContentFilterRef.
736 https://bugs.webkit.org/show_bug.cgi?id=143852
738 Reviewed by Sam Weinig.
740 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
741 * WebKitTestRunner/mac/TestControllerMac.mm:
742 (WTR::TestController::platformResetPreferencesToConsistentValues):
743 (WTR::TestController::platformConfigureViewForTest):
745 2015-04-16 Jake Nielsen <jacob_nielsen@apple.com>
747 Unreviewed. Adding myself as a commiter in contributers.json.
749 * Scripts/webkitpy/common/config/contributors.json:
751 2015-04-16 Alexey Proskuryakov <ap@apple.com>
753 It is very hard to attach a debugger to WebProcess to debug tests
754 https://bugs.webkit.org/show_bug.cgi?id=143837
756 Reviewed by Chris Dumez.
758 --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
759 WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
761 Now it disables all timeouts in tools, as is best for debugging tests.
763 * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
764 that the script doesn't terminate DRT/WKTR when there is no output for a long time.
766 * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
767 now has the same functionality.
769 2015-04-16 Beth Dakin <bdakin@apple.com>
771 Force mouse events should go through normal mouse event handling code paths
772 https://bugs.webkit.org/show_bug.cgi?id=143749
774 rdar://problem/20472895
776 Reviewed by Dean Jackson.
778 Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner.
779 Since there is not a way to create an NSEventTypePressure from scratch, we
780 subclass NSEvent and override all of the critical methods.
782 * WebKitTestRunner/EventSenderProxy.h:
783 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
784 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
785 (WTR::EventSendingController::mouseForceDown):
786 (WTR::EventSendingController::mouseForceUp):
787 (WTR::EventSendingController::mouseForceChanged):
788 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
789 * WebKitTestRunner/TestController.cpp:
790 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
791 * WebKitTestRunner/mac/EventSenderProxy.mm:
792 (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
793 (-[EventSenderPressureEvent timestamp]):
794 (-[EventSenderPressureEvent type]):
795 (-[EventSenderPressureEvent locationInWindow]):
796 (-[EventSenderPressureEvent location]):
797 (-[EventSenderPressureEvent stage]):
798 (-[EventSenderPressureEvent pressure]):
799 (-[EventSenderPressureEvent phase]):
800 (-[EventSenderPressureEvent eventNumber]):
801 (WTR::EventSenderProxy::mouseForceDown):
802 (WTR::EventSenderProxy::mouseForceUp):
803 (WTR::EventSenderProxy::mouseForceChanged):
805 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
807 [EFL] Bump LLVM to version 3.6.0 on X86_64
808 https://bugs.webkit.org/show_bug.cgi?id=143604
810 Reviewed by Gyuyoung Kim.
812 * efl/jhbuild.modules:
813 * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
814 * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
815 * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
816 * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
818 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
820 [EFL] Remove an unnecessary workaround from jhbuildrc
821 https://bugs.webkit.org/show_bug.cgi?id=143823
823 Reviewed by Gyuyoung Kim.
827 2015-04-16 Csaba Osztrogonác <ossy@webkit.org>
829 [GTK] Run forwarding headers generator unconditionally
830 https://bugs.webkit.org/show_bug.cgi?id=143819
832 Reviewed by Carlos Garcia Campos.
834 * TestWebKitAPI/PlatformGTK.cmake:
835 * WebKitTestRunner/PlatformGTK.cmake:
837 2015-04-15 Gyuyoung Kim <gyuyoung.kim@webkit.org>
839 [EFL] Add gnutls to jhbuild.module
840 https://bugs.webkit.org/show_bug.cgi?id=143777
842 Reviewed by Csaba Osztrogonác.
844 EFL port has required at least 3.0.0 version of gnutls since r176712.
845 However some old linux distributions don't support 3.0.0 version. Besides
846 other projects sometimes need to use lower version of gnutls.
848 This patch supports to download gnutls through jhbuild, and use it.
850 * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev.
851 * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
853 2015-04-15 Mark Lam <mark.lam@apple.com>
855 Remove obsolete VMInspector debugging tool.
856 https://bugs.webkit.org/show_bug.cgi?id=143798
858 Reviewed by Michael Saboff.
860 * TestWebKitAPI/CMakeLists.txt:
861 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
862 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
863 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
864 * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
866 2015-04-15 Jer Noble <jer.noble@apple.com>
868 Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
870 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
872 2015-04-15 Jer Noble <jer.noble@apple.com>
874 Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
876 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
877 (TestWebKitAPI::TEST_F):
879 2015-04-15 Chris Dumez <cdumez@apple.com>
881 [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
882 https://bugs.webkit.org/show_bug.cgi?id=143779
884 Reviewed by Brent Fulgham.
886 Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
887 similarly to what is done on Mac / WK1. Without this, PageCache could
888 stay enabled after page cache tests and cause weird behaviors.
890 * DumpRenderTree/win/DumpRenderTree.cpp:
891 (resetWebPreferencesToConsistentValues):
893 2015-04-14 Simon Fraser <simon.fraser@apple.com>
895 Re-enable custom dilation for antialiased fonts
896 https://bugs.webkit.org/show_bug.cgi?id=143738
898 Reviewed by Tim Horton.
900 Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
901 but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
902 a private WebKit pref. This pref defaults to YES, enabling the feature by default
903 in WK1 as we do for WK2.
905 * DumpRenderTree/mac/DumpRenderTree.mm:
906 (resetWebPreferencesToConsistentValues):
907 * WebKitTestRunner/TestController.cpp:
908 (WTR::TestController::resetPreferencesToConsistentValues):
910 2015-04-14 Brent Fulgham <bfulgham@apple.com>
912 Correct layering violation in DumpRenderTree Build
913 https://bugs.webkit.org/show_bug.cgi?id=143732
915 Reviewed by Simon Fraser.
917 Correct a layering violation in DumpRenderTree by calling functions on the
918 WebCoreTestSupport library, rather than attempting to work with WebCore
921 * DumpRenderTree/mac/EventSendingController.mm:
922 (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
923 than WebCore itself.,
924 (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
926 2015-04-14 Benjamin Poulain <benjamin@webkit.org>
928 Add a conservative DFA minimizer for the content extension matcher
929 https://bugs.webkit.org/show_bug.cgi?id=143501
931 Reviewed by Alex Christensen.
933 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
934 * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
936 2015-04-14 Daniel Bates <dabates@apple.com>
938 Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
939 https://bugs.webkit.org/show_bug.cgi?id=143693
940 <rdar://problem/20530316>
942 Reviewed by Tim Horton.
944 Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
945 to use the fixed layout code on iOS at this time.
947 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
949 2015-04-14 Dominik Röttsches <dominik.rottsches@intel.com>
951 Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
952 https://bugs.webkit.org/show_bug.cgi?id=143705
954 Unreviewed change to watchlist file.
956 * Scripts/webkitpy/common/config/watchlist:
958 2015-04-14 KwangHyuk Kim <hyuki.kim@samsung.com>
960 [EFL] favicon wasn't updated for google.com sometimes.
961 https://bugs.webkit.org/show_bug.cgi?id=141940
963 Reviewed by Gyuyoung Kim.
965 As elm_entry_utf8_to_markup can include additional characters, parameter for the
966 on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
968 * MiniBrowser/efl/main.c:
971 2015-04-13 Tim Horton <timothy_horton@apple.com>
973 Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
974 https://bugs.webkit.org/show_bug.cgi?id=143560
975 <rdar://problem/16302047>
977 Reviewed by Darin Adler.
979 * MiniBrowser/mac/BrowserWindowController.h:
980 * MiniBrowser/mac/MainMenu.xib:
981 * MiniBrowser/mac/WK1BrowserWindowController.m:
982 (-[WK1BrowserWindowController setScale:]):
983 * MiniBrowser/mac/WK2BrowserWindowController.m:
984 (viewScaleForMenuItemTag):
985 (-[WK2BrowserWindowController setScale:]):
986 (-[WK2BrowserWindowController validateMenuItem:]):
987 Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
988 When in use, we resize the window so that the view fits correctly, and
989 use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
990 layout size will not change when scaling down (but will update appropriately
991 when the view is resized).
993 2015-04-13 Alexey Proskuryakov <ap@apple.com>
995 build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
996 https://bugs.webkit.org/show_bug.cgi?id=138630
998 Reviewed by Tim Horton.
1000 Make sure that we always load at least one in order productive iteration.
1002 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1003 (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1004 is done loading at least one iteration that wasn't an out of order build.
1005 (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1006 when that's needed to check for out of order builds.
1007 (BuildbotQueue.prototype.update): Ditto.
1008 (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1009 result, and if it does not, load more iterations.
1010 (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1011 an in order iteration loaded too.
1012 (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1013 corrected to always sort loaded iterations before unloaded ones.
1015 2015-04-10 Brent Fulgham <bfulgham@apple.com>
1017 Expand test infrastructure to support scrolling tests
1018 https://bugs.webkit.org/show_bug.cgi?id=143286
1019 <rdar://problem/20375516>
1021 Reviewed by Simon Fraser.
1023 Extend the WK1 and WK2 test programs to support two new EventSender commands:
1024 (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1025 block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1026 (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1027 relevant rubberband, scroll, and scroll-snap animations are finished.
1029 * DumpRenderTree/mac/EventSendingController.mm:
1030 (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1031 and 'monitorWheelEvents'.
1032 (+[EventSendingController webScriptNameForSelector:]): Ditto.
1033 (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1034 debugging test failures.
1035 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1036 (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1037 function, then passes it to WebCore to be called once the test deferrals have been cleared.
1038 (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1039 'callAfterScrollingCompletes' method.
1040 * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1041 and 'monitorWheelEvents'.
1042 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1043 (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1044 callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1045 (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1046 'callAfterScrollingComplates' method.
1047 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1049 2015-04-13 Alexey Proskuryakov <ap@apple.com>
1051 build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1052 https://bugs.webkit.org/show_bug.cgi?id=143656
1054 Reviewed by Darin Adler.
1056 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1057 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1059 2015-04-13 Sergio Villar Senin <svillar@igalia.com>
1061 REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1062 https://bugs.webkit.org/show_bug.cgi?id=142387
1064 Reviewed by Carlos Garcia Campos.
1066 Running mixed content is blocked by default since r181134. Updated
1067 the test case to reflect the new default settings.
1069 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1070 (testInsecureContent):
1072 2015-04-13 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1074 Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1075 https://bugs.webkit.org/show_bug.cgi?id=143667
1077 Reviewed by Csaba Osztrogonác.
1079 ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1080 since r169017. Added $hardwareConcurrencySupport for it.
1082 Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1084 * Scripts/webkitperl/FeatureList.pm:
1086 2015-04-13 Csaba Osztrogonác <ossy@webkit.org>
1088 [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1089 https://bugs.webkit.org/show_bug.cgi?id=143664
1091 Reviewed by Gyuyoung Kim.
1093 * Scripts/webkitperl/FeatureList.pm:
1095 2015-04-12 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1097 [EFL] Enable Media Source
1098 https://bugs.webkit.org/show_bug.cgi?id=143635
1100 Reviewed by Csaba Osztrogonác.
1102 * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1104 2015-04-12 Alexey Proskuryakov <ap@apple.com>
1106 build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1107 https://bugs.webkit.org/show_bug.cgi?id=143646
1109 Reviewed by David Kilzer.
1111 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1112 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1114 2015-04-11 Alexey Proskuryakov <ap@apple.com>
1116 Use en_US spell checker for tests on Mac instead of Multilingual
1117 https://bugs.webkit.org/show_bug.cgi?id=143641
1119 Reviewed by Dan Bernstein.
1121 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1122 While at it, override NSUserDictionaryReplacementItems, so that user replacements
1123 cannot affect tests.
1125 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1126 Made this more like WebKit1 version.
1128 2015-04-10 Tim Horton <timothy_horton@apple.com>
1130 Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1131 https://bugs.webkit.org/show_bug.cgi?id=143576
1133 Reviewed by Simon Fraser.
1135 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1139 2015-04-09 Gyuyoung Kim <gyuyoung.kim@webkit.org>
1141 Update my email address and expertise.
1142 https://bugs.webkit.org/show_bug.cgi?id=143586
1144 Unreviewed, just update my info.
1146 * Scripts/webkitpy/common/config/contributors.json:
1148 2015-04-09 Joseph Pecoraro <pecoraro@apple.com>
1150 Flakiness Dashboard not loading insecure content if loaded with https URL
1151 https://bugs.webkit.org/show_bug.cgi?id=143570
1153 Reviewed by Alexey Proskuryakov.
1155 * TestResultServer/app.yaml:
1156 * TestResultServer/static-dashboards/loader.js:
1157 Switch to https scheme.
1159 2015-04-09 Csaba Osztrogonác <ossy@webkit.org>
1161 [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1162 https://bugs.webkit.org/show_bug.cgi?id=142907
1164 Reviewed by Carlos Garcia Campos.
1166 * TestWebKitAPI/PlatformEfl.cmake:
1167 * TestWebKitAPI/PlatformGTK.cmake:
1168 * WebKitTestRunner/PlatformEfl.cmake:
1169 * WebKitTestRunner/PlatformGTK.cmake:
1171 2015-04-08 Brent Fulgham <bfulgham@apple.com>
1173 [Mac] Unreviewed test fix after r182584
1174 https://bugs.webkit.org/show_bug.cgi?id=143452
1176 Put both of these tests back to their original state now that the underlying
1179 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1180 (TestWebKitAPI::TEST):
1181 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1182 (TestWebKitAPI::TEST):
1184 2015-04-08 Filip Pizlo <fpizlo@apple.com>
1186 run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1187 https://bugs.webkit.org/show_bug.cgi?id=143553
1189 Reviewed by Ryosuke Niwa.
1191 Remove the spurious printVMs left over from an earlier change.
1193 * Scripts/run-jsc-benchmarks:
1195 2015-04-08 Brent Fulgham <bfulgham@apple.com>
1197 [Mac] Unreviewed test fix after r182581
1199 The behavior of control-left-click is controlled by a system preference.
1200 Our test bots have this turned off.
1202 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1203 (TestWebKitAPI::TEST):
1204 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1205 (TestWebKitAPI::TEST):
1207 2015-04-08 Brent Fulgham <bfulgham@apple.com>
1209 [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1210 https://bugs.webkit.org/show_bug.cgi?id=143452
1211 <rdar://problem/20437483>
1213 Reviewed by Tim Horton.
1215 Add a new API test to confirm that Cocoa mouse button press events are properly
1216 tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1218 The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1219 some registered event handlers that the expected button press and context menu
1220 events are received.
1222 The WK1 unit test creates an NSEvent with the desired button press state, and then
1223 uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1224 We check the resulting PlatformMouseEvent for proper state.
1226 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1227 * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1228 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1229 * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1230 * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1231 (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1232 (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1233 * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1234 (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1236 * TestWebKitAPI/mac/PlatformWebViewMac.h:
1238 2015-04-08 Michael Catanzaro <mcatanzaro@igalia.com>
1240 [GTK] Add pango to jhbuild-optional.modules
1241 https://bugs.webkit.org/show_bug.cgi?id=143537
1243 Reviewed by Martin Robinson.
1245 * gtk/jhbuild-optional.modules: Add pango.
1247 2015-04-08 Carlos Alberto Lopez Perez <clopez@igalia.com>
1249 [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1250 https://bugs.webkit.org/show_bug.cgi?id=143530
1252 Reviewed by Žan Doberšek.
1254 Assume that the default value for display (:0) is reserved and start checking on :1
1255 Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1256 and for X server named Xorg.bin (previous bug 1376599)
1258 * Scripts/webkitpy/port/xvfbdriver.py:
1259 (XvfbDriver._next_free_display)
1260 * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1261 (XvfbDriverTest.test_start_no_pixel_tests):
1262 (XvfbDriverTest.test_start_pixel_tests):
1263 (XvfbDriverTest.test_start_arbitrary_worker_number):
1264 (XvfbDriverTest.test_next_free_display):
1265 (XvfbDriverTest.test_start_next_worker):
1266 2015-04-08 Alex Christensen <achristensen@webkit.org>
1268 Block popups from content extensions.
1269 https://bugs.webkit.org/show_bug.cgi?id=143497
1271 Reviewed by Brady Eidson.
1273 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1274 (TestWebKitAPI::TEST_F):
1277 2015-04-08 Alex Christensen <achristensen@webkit.org> and Patrick Gansterer <paroga@webkit.org>
1279 Add CMake build system for WinCairo port.
1280 https://bugs.webkit.org/show_bug.cgi?id=115944
1282 Reviewed by Chris Dumez.
1285 * WinLauncher/CMakeLists.txt: Added.
1287 2015-04-08 Carlos Garcia Campos <cgarcia@igalia.com>
1289 [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
1290 https://bugs.webkit.org/show_bug.cgi?id=143521
1292 Reviewed by Martin Robinson.
1294 Add a way to detect unexpected web process crashes to WebViewTest,
1295 and a test case to testDOMCache to trigger the crash.
1297 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1298 (WebKitDOMNodeTest::testDOMCache):
1299 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1300 (testWebKitWebViewProcessCrashed):
1301 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1302 (WebViewTest::WebViewTest):
1303 (WebViewTest::webProcessCrashed):
1304 * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1306 2015-04-07 Alexey Proskuryakov <ap@apple.com>
1308 PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
1309 rdar://problem/20461342
1311 * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1313 2015-04-07 Commit Queue <commit-queue@webkit.org>
1315 Unreviewed, rolling out r182511.
1316 https://bugs.webkit.org/show_bug.cgi?id=143507
1318 caused debug test failures (Requested by alexchristensen on
1323 "Block popups from content extensions."
1324 https://bugs.webkit.org/show_bug.cgi?id=143497
1325 http://trac.webkit.org/changeset/182511
1327 2015-04-07 Alex Christensen <achristensen@webkit.org>
1329 Block popups from content extensions.
1330 https://bugs.webkit.org/show_bug.cgi?id=143497
1332 Reviewed by Brady Eidson.
1334 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1335 (TestWebKitAPI::TEST_F):
1338 2015-04-07 Benjamin Poulain <benjamin@webkit.org>
1340 Get the features.json files ready for open contributions
1341 https://bugs.webkit.org/show_bug.cgi?id=143436
1343 Reviewed by Darin Adler.
1345 * Scripts/webkitpy/style/checkers/jsonchecker.py:
1346 (JSONFeaturesChecker.check):
1347 Extend the syntax checking a bit, but leave everything non-mandatory
1348 very loose until we figure what fields are important.
1350 2015-04-07 Tim Horton <timothy_horton@apple.com>
1352 Expose and test fixedLayoutSize via modern WebKit SPI
1353 https://bugs.webkit.org/show_bug.cgi?id=143500
1355 Reviewed by Simon Fraser.
1357 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1358 * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
1359 (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
1361 Add a test that verifies that fixedLayoutSize works at all, that
1362 it persists through a navigation, and that turning it back off reverts to
1363 laying out at the size of the view.
1365 2015-04-07 Michael Catanzaro <mcatanzaro@igalia.com>
1367 Unreviewed. Add myself as a committer.
1369 * Scripts/webkitpy/common/config/contributors.json:
1371 2015-04-07 Brent Fulgham <bfulgham@apple.com>
1373 [Win] Bots complain about missing /etc/catalog
1374 https://bugs.webkit.org/show_bug.cgi?id=143484
1376 Reviewed by Chris Dumez.
1378 The libxml2 build on Mac, iOS, and Windows does not provide the set
1379 of default catalog files. We do not actually need these for our
1380 purposes, but we get warnings and some bot flakiness because they
1383 We can avoid both problems the same way the Mac and iOS ports do,
1384 by setting the XML_CATALOG_FILES environment variable to 'empty string',
1385 which avoid the warnings and bot problems.
1387 * Scripts/webkitpy/port/win.py:
1388 (WinPort.setup_environ_for_server): Added.
1390 2015-04-06 Sam Weinig <sam@webkit.org>
1392 Use content extensions in MiniBrowser.
1393 https://bugs.webkit.org/show_bug.cgi?id=143446
1395 Reviewed by Alex Christensen.
1397 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1398 * MiniBrowser/mac/AppDelegate.h:
1399 * MiniBrowser/mac/AppDelegate.m:
1400 (-[BrowserAppDelegate init]):
1401 (-[BrowserAppDelegate showExtensionsManager:]):
1402 (-[BrowserAppDelegate userContentContoller]):
1403 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1404 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1405 (-[ExtensionManagerWindowController init]):
1406 (-[ExtensionManagerWindowController windowDidLoad]):
1407 (-[ExtensionManagerWindowController add:]):
1408 (-[ExtensionManagerWindowController remove:]):
1409 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1410 * MiniBrowser/mac/MainMenu.xib:
1412 2015-04-07 Youenn Fablet <youenn.fablet@crf.canon.fr>
1414 web-platform-tests server should retrieve the modules file relatively to its docroot path
1415 https://bugs.webkit.org/show_bug.cgi?id=142742
1417 Reviewed by Darin Adler.
1419 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1420 (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
1422 2015-04-06 Commit Queue <commit-queue@webkit.org>
1424 Unreviewed, rolling out r182445.
1425 https://bugs.webkit.org/show_bug.cgi?id=143459
1427 broke 32 bit build (Requested by alexchristensen on #webkit).
1431 "Use content extensions in MiniBrowser."
1432 https://bugs.webkit.org/show_bug.cgi?id=143446
1433 http://trac.webkit.org/changeset/182445
1435 2015-04-06 Sam Weinig <sam@webkit.org>
1437 Use content extensions in MiniBrowser.
1438 https://bugs.webkit.org/show_bug.cgi?id=143446
1440 Reviewed by Alex Christensen.
1442 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1443 * MiniBrowser/mac/AppDelegate.h:
1444 * MiniBrowser/mac/AppDelegate.m:
1445 (-[BrowserAppDelegate init]):
1446 (-[BrowserAppDelegate showExtensionsManager:]):
1447 (-[BrowserAppDelegate userContentContoller]):
1448 * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
1449 * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
1450 (-[ExtensionManagerWindowController init]):
1451 (-[ExtensionManagerWindowController windowDidLoad]):
1452 (-[ExtensionManagerWindowController add:]):
1453 (-[ExtensionManagerWindowController remove:]):
1454 * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
1455 * MiniBrowser/mac/MainMenu.xib:
1457 2015-04-06 Michael Catanzaro <mcatanzaro@gnome.org>
1459 [GTK] install-dependencies should prefer dnf to yum
1460 https://bugs.webkit.org/show_bug.cgi?id=143441
1462 Reviewed by Martin Robinson.
1464 Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
1466 * gtk/install-dependencies:
1468 2015-04-06 Andy Estes <aestes@apple.com>
1470 [iOS] 'make clean' fails in Tools/WebKitTestRunner
1471 https://bugs.webkit.org/show_bug.cgi?id=143455
1473 Reviewed by Dan Bernstein.
1475 This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
1476 Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
1478 * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
1480 2015-04-06 Alexey Proskuryakov <ap@apple.com>
1482 WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
1483 https://bugs.webkit.org/show_bug.cgi?id=143450
1485 Reviewed by Anders Carlsson.
1487 * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
1488 Make sure that the view is actually closed, regardless of anything else that happens beneath.
1489 Also, removed unnecessary get() calls.
1491 2015-04-03 Alexey Proskuryakov <ap@apple.com>
1493 Reduce the dependency on Flash in regression tests
1494 https://bugs.webkit.org/show_bug.cgi?id=143391
1496 Reviewed by Anders Carlsson.
1498 * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
1499 Only allow QuickTime and the test plug-in.
1501 2015-04-06 Youenn Fablet <youenn.fablet@crf.canon.fr>
1503 W3C test importer should generate the modules installed dynamically to run wpt tests
1504 https://bugs.webkit.org/show_bug.cgi?id=142738
1506 Reviewed by Ryosuke Niwa.
1508 The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
1509 The implementation is done within TestDownloader and it is activated for the WPT repository.
1510 LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
1512 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1513 (WebPlatformTestServer._install_modules): Updated to cope with path as array.
1514 * Scripts/webkitpy/w3c/test_downloader.py:
1515 (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
1517 (TestDownloader._git_submodules_description): Computes submodule description.
1518 (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
1519 * Scripts/webkitpy/w3c/test_importer.py:
1520 (TestImporter.do_import): Added the possibility to post process the tests.
1522 (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
1523 (TestImporter.should_convert_test_harness_links): Updated according new options format.
1524 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1525 (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock.
1526 (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
1527 (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
1528 (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
1529 (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
1531 2015-04-05 Antti Koivisto <antti@apple.com>
1533 Bloom filter should support longer hashes
1534 https://bugs.webkit.org/show_bug.cgi?id=143419
1536 Reviewed by Dan Bernstein.
1538 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
1539 (TestWebKitAPI::generateRandomDigests):
1540 (TestWebKitAPI::TEST):
1542 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
1544 run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
1545 https://bugs.webkit.org/show_bug.cgi?id=143372
1547 Reviewed by Darin Adler.
1549 * Scripts/run-jsc-stress-tests:
1551 2015-04-03 Antti Koivisto <antti@apple.com>
1553 Add non-counting bloom filter class
1554 https://bugs.webkit.org/show_bug.cgi?id=143366
1556 Reviewed by Sam Weinig.
1558 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1559 * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
1560 (TestWebKitAPI::generateRandomHashes):
1561 (TestWebKitAPI::TEST):
1563 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
1565 FTL JIT tests should fail if LLVM library isn't available
1566 https://bugs.webkit.org/show_bug.cgi?id=143374
1568 Reviewed by Mark Lam.
1570 * Scripts/run-jsc-stress-tests:
1572 2015-04-03 Csaba Osztrogonác <ossy@webkit.org>
1574 [EFL] Speedup jhbuild with disable running autogen.sh
1575 https://bugs.webkit.org/show_bug.cgi?id=143369
1577 Reviewed by Gyuyoung Kim.
1579 * efl/jhbuild.modules:
1581 2015-04-01 Alexey Proskuryakov <ap@apple.com>
1583 filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
1584 https://bugs.webkit.org/show_bug.cgi?id=143282
1586 Reviewed by Daniel Bates.
1588 * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
1590 2015-04-01 Alexey Proskuryakov <ap@apple.com>
1592 When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
1593 https://bugs.webkit.org/show_bug.cgi?id=143240
1594 rdar://problem/19990425
1596 Reviewed by Tim Horton.
1598 * DumpRenderTree/mac/LayoutTestHelper.m:
1599 (colorProfileURLForDisplay):
1600 (saveDisplayColorProfiles):
1601 Gracefully handle it when the current profile cannot be retrieved, fixing at
1602 least one case when LayoutTestHelper couldn't start.
1604 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1605 (Manager._set_up_run):
1606 (Manager._force_pixel_tests_if_needed):
1607 * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
1608 * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
1609 Return and check an error from start_helper().
1611 2015-04-01 Brent Fulgham <bfulgham@apple.com>
1613 [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
1614 https://bugs.webkit.org/show_bug.cgi?id=143321
1616 Reviewed by Alexey Proskuryakov.
1618 * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
1620 2015-04-01 Enrica Casucci <enrica@apple.com>
1622 Injected bundle messages should be at the page level.
1623 https://bugs.webkit.org/show_bug.cgi?id=143283
1625 Reviewed by Alexey Proskuryakov.
1627 Updating WebKitTestRunner to use the new page level messaging.
1628 The author of this patch is Tim Horton, I just finished it.
1630 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1631 (WTR::EventSendingController::mouseDown):
1632 (WTR::EventSendingController::mouseUp):
1633 (WTR::EventSendingController::mouseMoveTo):
1634 (WTR::EventSendingController::leapForward):
1635 (WTR::EventSendingController::scheduleAsynchronousClick):
1636 (WTR::EventSendingController::keyDown):
1637 (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1638 (WTR::EventSendingController::mouseScrollBy):
1639 (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1640 (WTR::EventSendingController::continuousMouseScrollBy):
1641 (WTR::EventSendingController::addTouchPoint):
1642 (WTR::EventSendingController::updateTouchPoint):
1643 (WTR::EventSendingController::setTouchModifier):
1644 (WTR::EventSendingController::setTouchPointRadius):
1645 (WTR::EventSendingController::touchStart):
1646 (WTR::EventSendingController::touchMove):
1647 (WTR::EventSendingController::touchEnd):
1648 (WTR::EventSendingController::touchCancel):
1649 (WTR::EventSendingController::clearTouchPoints):
1650 (WTR::EventSendingController::releaseTouchPoint):
1651 (WTR::EventSendingController::cancelTouchPoint):
1652 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1653 (WTR::InjectedBundle::didReceiveMessage):
1654 (WTR::InjectedBundle::didReceiveMessageToPage):
1655 (WTR::InjectedBundle::done):
1656 (WTR::InjectedBundle::outputText):
1657 (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1658 (WTR::InjectedBundle::postAddChromeInputField):
1659 (WTR::InjectedBundle::postRemoveChromeInputField):
1660 (WTR::InjectedBundle::postFocusWebView):
1661 (WTR::InjectedBundle::postSetBackingScaleFactor):
1662 (WTR::InjectedBundle::postSetWindowIsKey):
1663 (WTR::InjectedBundle::postSimulateWebNotificationClick):
1664 (WTR::InjectedBundle::postSetAddsVisitedLinks):
1665 (WTR::InjectedBundle::setGeolocationPermission):
1666 (WTR::InjectedBundle::setMockGeolocationPosition):
1667 (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1668 (WTR::InjectedBundle::setUserMediaPermission):
1669 (WTR::InjectedBundle::setCustomPolicyDelegate):
1670 (WTR::InjectedBundle::setHidden):
1671 (WTR::InjectedBundle::setCacheModel):
1672 (WTR::InjectedBundle::shouldProcessWorkQueue):
1673 (WTR::InjectedBundle::processWorkQueue):
1674 (WTR::InjectedBundle::queueBackNavigation):
1675 (WTR::InjectedBundle::queueForwardNavigation):
1676 (WTR::InjectedBundle::queueLoad):
1677 (WTR::InjectedBundle::queueLoadHTMLString):
1678 (WTR::InjectedBundle::queueReload):
1679 (WTR::InjectedBundle::queueLoadingScript):
1680 (WTR::InjectedBundle::queueNonLoadingScript):
1681 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1682 (WTR::TestRunner::setHandlesAuthenticationChallenges):
1683 (WTR::TestRunner::setAuthenticationUsername):
1684 (WTR::TestRunner::setAuthenticationPassword):
1685 (WTR::TestRunner::secureEventInputIsEnabled):
1686 (WTR::TestRunner::setBlockAllPlugins):
1687 * WebKitTestRunner/TestController.cpp:
1688 (WTR::TestController::createWebViewWithOptions):
1689 (WTR::TestController::resetStateToConsistentValues):
1690 (WTR::TestController::didReceivePageMessageFromInjectedBundle):
1691 (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
1692 * WebKitTestRunner/TestController.h:
1693 * WebKitTestRunner/TestInvocation.cpp:
1694 (WTR::TestInvocation::invoke):
1695 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1697 2015-04-01 Commit Queue <commit-queue@webkit.org>
1699 Unreviewed, rolling out r182174 and r182177.
1700 https://bugs.webkit.org/show_bug.cgi?id=143314
1702 Try to correct EWS failures (Requested by bfulgham on
1705 Reverted changesets:
1707 "Python SCM should be able to retrieve untracked files"
1708 https://bugs.webkit.org/show_bug.cgi?id=143135
1709 http://trac.webkit.org/changeset/182174
1711 "[buildbot] clean-build script should remove untracked files
1712 and revert local changes too"
1713 https://bugs.webkit.org/show_bug.cgi?id=142400
1714 http://trac.webkit.org/changeset/182177
1716 2015-04-01 Alex Christensen <achristensen@webkit.org>
1718 [Content Extensions] Properly handle regexes that match everything.
1719 https://bugs.webkit.org/show_bug.cgi?id=143281
1721 Reviewed by Benjamin Poulain.
1723 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1724 (TestWebKitAPI::testRequest):
1725 (TestWebKitAPI::makeBackend):
1726 (TestWebKitAPI::TEST_F):
1727 Removed duplicate code and added test.
1729 2015-03-31 Benjamin Poulain <bpoulain@apple.com>
1731 Content Extensions: split the state machines to minimize prefix states
1732 https://bugs.webkit.org/show_bug.cgi?id=143253
1734 Reviewed by Alex Christensen.
1736 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1737 (TestWebKitAPI::TEST_F):
1738 (TestWebKitAPI::testPatternStatus):
1740 2015-03-31 Yusuke Suzuki <utatane.tea@gmail.com>
1742 Clean up Identifier factories to clarify the meaning of StringImpl*
1743 https://bugs.webkit.org/show_bug.cgi?id=143146
1745 Reviewed by Filip Pizlo.
1747 Simple API tests for StringImpl are added.
1749 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1750 (TestWebKitAPI::TEST):
1752 2015-03-31 Csaba Osztrogonác <ossy@webkit.org>
1754 [EFL] Add AArch64 builder and tester bot to build.webkit.org
1755 https://bugs.webkit.org/show_bug.cgi?id=143092
1757 Reviewed by Gyuyoung Kim.
1759 * BuildSlaveSupport/build.webkit.org-config/config.json:
1760 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1762 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1764 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
1766 [buildbot] clean-build script should remove untracked files and revert local changes too
1767 https://bugs.webkit.org/show_bug.cgi?id=142400
1769 Reviewed by Ryosuke Niwa.
1771 This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
1772 A helper routine SCM.discard_untracked_files is added for that purpose.
1774 * BuildSlaveSupport/clean-build:
1775 (main): Making call to Scripts/clean-webkit
1776 * Scripts/clean-webkit: Added.
1777 (main): Revert changes and delete untracked files.
1778 * Scripts/webkitpy/common/checkout/scm/scm.py:
1779 (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
1780 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1781 (SCMTest._shared_test_discard_untracked_files):
1782 (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
1784 2015-03-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
1786 Python SCM should be able to retrieve untracked files
1787 https://bugs.webkit.org/show_bug.cgi?id=143135
1789 Reviewed by Ryosuke Niwa.
1791 This patch introduces SCM.untracked_files to retrieve a list of untracked files.
1792 Ignored files may be included or not in this list according boolean passed to the function.
1794 * Scripts/webkitpy/common/checkout/scm/git.py:
1795 (Git.untracked_files):
1796 * Scripts/webkitpy/common/checkout/scm/scm.py:
1797 (SCM.untracked_files):
1798 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1799 (SCMTest._shared_test_untracked_files):
1800 (test_untracked_files):
1801 (GitSVNTest.test_untracked_files):
1802 * Scripts/webkitpy/common/checkout/scm/svn.py:
1803 (SVN.untracked_files):
1805 2015-03-30 Alex Christensen <achristensen@webkit.org>
1807 [Content Extensions] Correctly handle regular expressions matching everything
1808 https://bugs.webkit.org/show_bug.cgi?id=143235
1810 Reviewed by Benjamin Poulain.
1812 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1813 (TestWebKitAPI::checkCompilerError):
1814 (TestWebKitAPI::TEST_F):
1815 Test ContentExtensionErrors.
1817 2015-03-30 Alexey Proskuryakov <ap@apple.com>
1819 DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
1820 https://bugs.webkit.org/show_bug.cgi?id=143241
1821 rdar://problem/20351297
1823 Reviewed by Mark Lam.
1825 * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1827 2015-03-30 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1829 [CMake][EFL] Remove redundant library link and include path
1830 https://bugs.webkit.org/show_bug.cgi?id=143221
1832 Reviewed by Csaba Osztrogonác.
1834 * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
1836 2015-03-30 Sam Weinig <sam@webkit.org>
1838 [Content Extensions] Flesh out the UserContentExtensionStore
1839 https://bugs.webkit.org/show_bug.cgi?id=143123
1841 Reviewed by Benjamin Poulain.
1843 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1844 * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
1845 Add tests for _WKUserContentExtensionStore.
1847 2015-03-30 Marcos Chavarría Teijeiro <chavarria1991@gmail.com>
1849 Update install-dependencies Fedora packages after r181624
1850 https://bugs.webkit.org/show_bug.cgi?id=143215
1852 Add json-glib, libv4l, openssl and pulseaudio development packages to
1853 the Fedora list providing we need them to build WebKit dependencies
1854 for this distribution.
1856 Reviewed by Philippe Normand.
1858 * gtk/install-dependencies:
1860 2015-03-30 Commit Queue <commit-queue@webkit.org>
1862 Unreviewed, rolling out r182119.
1863 https://bugs.webkit.org/show_bug.cgi?id=143196
1865 problem with syntax (Requested by youenn on #webkit).
1869 "[buildbot] clean-build script should remove untracked files
1870 and revert local changes too"
1871 https://bugs.webkit.org/show_bug.cgi?id=142400
1872 http://trac.webkit.org/changeset/182119
1874 2015-03-30 Benjamin Poulain <benjamin@webkit.org>
1876 Start the features.json files
1877 https://bugs.webkit.org/show_bug.cgi?id=143207
1879 Reviewed by Darin Adler.
1881 I kept the style checking light. We'll have to figure
1882 what is the best format for each field.
1884 * Scripts/webkitpy/style/checker.py:
1885 (CheckerDispatcher._create_checker):
1886 * Scripts/webkitpy/style/checkers/jsonchecker.py:
1887 (JSONContributorsChecker.check):
1888 (JSONFeaturesChecker):
1889 (JSONFeaturesChecker.check):
1891 2015-03-29 Youenn Fablet <youenn.fablet@crf.canon.fr>
1893 [buildbot] clean-build script should remove untracked files and revert local changes too
1894 https://bugs.webkit.org/show_bug.cgi?id=142400
1896 Reviewed by Ryosuke Niwa.
1898 This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
1900 * BuildSlaveSupport/clean-build:
1901 (main): Adding call to Tools/Scripts/clean-webkit.
1902 * Scripts/clean-webkit: Added.
1903 (main): Removes untracked and changed files.
1904 * Scripts/webkitpy/common/checkout/scm/git.py:
1905 (Git.untracked_files): Retrieves GIT untracked files.
1906 * Scripts/webkitpy/common/checkout/scm/scm.py:
1907 (SCM.untracked_files): Retrieves SVN untracked files.
1909 (SCM.discard_untracked_files): Deletes untracked files/folders.
1910 * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1911 (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
1912 (test_untracked_files):
1913 (GitSVNTest.test_untracked_files):
1914 * Scripts/webkitpy/common/checkout/scm/svn.py:
1915 (SVN.untracked_files):
1917 2015-03-27 Gyuyoung Kim <gyuyoung.kim@samsung.com>
1919 [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro
1920 https://bugs.webkit.org/show_bug.cgi?id=143138
1922 Reviewed by Csaba Osztrogonác.
1924 INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
1925 be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
1927 * ImageDiff/CMakeLists.txt:
1928 Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
1929 * WebKitTestRunner/CMakeLists.txt: ditto.
1931 2015-03-27 Myles C. Maxfield <mmaxfield@apple.com>
1933 Support building WTF on Windows without Cygwin
1934 https://bugs.webkit.org/show_bug.cgi?id=143084
1936 Reviewed by Brent Fulgham.
1938 Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
1939 This patch also migrates to using File::Spec->catfile() for directory separators.
1941 * Scripts/update-webkit-dependency:
1943 * Scripts/update-webkit-support-libs:
1945 (downloadExpectedVersionNumber):
1947 (toUnixPath): Deleted.
1948 * Scripts/webkitdirs.pm:
1949 (determineSourceDir):
1950 (windowsSourceSourceDir):
1951 (windowsLibrariesDir):
1953 (checkInstalledTools):
1954 (buildVisualStudioProject):
1956 2015-03-27 Alex Christensen <achristensen@webkit.org>
1959 https://bugs.webkit.org/show_bug.cgi?id=143086
1961 Reviewed by Brent Fulgham.
1963 * Scripts/webkitdirs.pm:
1964 (buildVisualStudioProject):
1965 (runSvnUpdateAndResolveChangeLogs):
1966 Use ActivePerl-friendly perl.
1968 2015-03-27 Csaba Osztrogonác <ossy@webkit.org>
1970 URTBF after r182059 to fix the EFL build.
1972 * TestWebKitAPI/CMakeLists.txt:
1974 2015-03-26 Alexey Proskuryakov <ap@apple.com>
1976 Layout test results URL loads in WK1 but not WK2 minibrowser
1977 https://bugs.webkit.org/show_bug.cgi?id=143117
1979 Reviewed by Tim Horton.
1981 * MiniBrowser/mac/WK2BrowserWindowController.m:
1982 (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
1984 (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
1986 2015-03-26 Jer Noble <jer.noble@apple.com>
1988 Add --allowed-host support to run-webkit-tests
1989 https://bugs.webkit.org/show_bug.cgi?id=142938
1991 Reviewed by Brent Fulgham.
1993 Accept --allowed-host arguments from run-webkit-tests and pass them through to
1994 DumpRenderTree and WebKitTestRunner.
1996 Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
1997 are placed in the wrong location. The argument is compared with each tests's path, and if a
1998 relative path or a path with '..' was used, results are placed alongside the test. Take the
1999 absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2001 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2003 * Scripts/webkitpy/port/base.py:
2005 (Port.allowed_hosts):
2006 * Scripts/webkitpy/port/driver.py:
2009 2015-03-26 Jer Noble <jer.noble@apple.com>
2011 [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2012 https://bugs.webkit.org/show_bug.cgi?id=142931
2014 Reviewed by Brent Fulgham.
2016 Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2017 over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2018 WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2021 To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2022 hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2024 Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2025 injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2026 top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2027 the top loading frame from the page, as we do elsewhere in this class.
2029 * DumpRenderTree/TestRunner.h:
2030 (TestRunner::allowedHosts):
2031 (TestRunner::setAllowedHosts):
2032 * DumpRenderTree/mac/DumpRenderTree.mm:
2033 (initializeGlobalsFromCommandLineOptions):
2035 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2037 (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2038 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2039 (WTR::InjectedBundle::didReceiveMessage):
2040 (WTR::InjectedBundle::isAllowedHost):
2041 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2042 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2043 (WTR::isAllowedHost):
2044 (WTR::InjectedBundlePage::willSendRequestForFrame):
2045 * WebKitTestRunner/InjectedBundle/TestRunner.h:
2046 * WebKitTestRunner/Options.cpp:
2047 (WTR::handleOptionAllowedHost):
2048 (WTR::OptionsHandler::OptionsHandler):
2049 * WebKitTestRunner/Options.h:
2050 * WebKitTestRunner/TestController.cpp:
2051 (WTR::TestController::initialize):
2052 (WTR::TestController::resetStateToConsistentValues):
2053 * WebKitTestRunner/TestController.h:
2055 2015-03-26 Brady Eidson <beidson@apple.com>
2057 Apply ContentExtension actions after redirects.
2058 <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2060 Reviewed by Alex Christensen.
2062 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2063 (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2064 which is specifically interesting to a new test.
2066 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
2068 [EFL] Disable building libseccomp on AArch64
2069 https://bugs.webkit.org/show_bug.cgi?id=143094
2071 Reviewed by Gyuyoung Kim.
2075 2015-03-26 Csaba Osztrogonác <ossy@webkit.org>
2077 [jhbuild] git should use only 1 thread for cloning jhbuild
2078 https://bugs.webkit.org/show_bug.cgi?id=143095
2080 Reviewed by Gyuyoung Kim.
2082 * jhbuild/jhbuild-wrapper:
2085 2015-03-25 Joseph Pecoraro <pecoraro@apple.com>
2087 Update prepare-ChangeLog to work with ES6 Class syntax
2088 https://bugs.webkit.org/show_bug.cgi?id=143069
2090 Reviewed by Timothy Hatcher.
2092 * Scripts/prepare-ChangeLog:
2093 (get_function_line_ranges_for_javascript):
2094 Better handle ES6 Class syntax.
2096 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2097 * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2100 (DerivedClass.staticMethod):
2101 (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2102 (DerivedClass.prototype.method):
2103 (DerivedClass.prototype.get getter):
2104 (namespace.MyClass):
2105 (namespace.MyClass.staticMethod):
2106 (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2107 (namespace.MyClass.prototype.method):
2108 (namespace.MyClass.prototype.get getter):
2111 2015-03-25 Filip Pizlo <fpizlo@apple.com>
2113 Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2114 https://bugs.webkit.org/show_bug.cgi?id=142993
2116 Reviewed by Mark Lam.
2118 Bunch of support for testing executable allocation failure.
2120 * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2122 * Scripts/run-javascriptcore-tests:
2123 (runJSCStressTests):
2124 * Scripts/run-jsc-stress-tests:
2126 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
2128 Fix Windows build from r181977.
2132 * Scripts/update-webkit-dependency:
2134 2015-03-25 Sam Weinig <sam@webkit.org>
2136 Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2138 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2139 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2141 2015-03-25 Myles C. Maxfield <mmaxfield@apple.com>
2143 Migrate update-webkit for Windows to not require Cygwin
2144 https://bugs.webkit.org/show_bug.cgi?id=143040
2146 Reviewed by Brent Fulgham.
2148 * Scripts/update-webkit-dependency:
2150 (toUnixPath): Deleted.
2151 * Scripts/webkitdirs.pm:
2153 (checkInstalledTools):
2156 2015-03-25 Sam Weinig <sam@webkit.org>
2158 [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2159 https://bugs.webkit.org/show_bug.cgi?id=143059
2161 Reviewed by Alex Christensen.
2163 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2164 (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2165 Update for new interface of compileRuleList().
2167 2015-03-25 Alex Christensen <achristensen@webkit.org>
2169 [Content Extensions] Add multi-DFA compiling and interpreting.
2170 https://bugs.webkit.org/show_bug.cgi?id=143010
2172 Reviewed by Benjamin Poulain.
2174 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2175 (TestWebKitAPI::testRequest):
2176 (TestWebKitAPI::TEST_F):
2177 Add some tests for ignore-previous-rules and large rulesets.
2179 2015-03-25 Alexey Proskuryakov <ap@apple.com>
2181 Mavericks WK1 still runs JSC tests
2182 https://bugs.webkit.org/show_bug.cgi?id=143035
2184 Reviewed by Csaba Osztrogonác.
2186 * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2189 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2192 2015-03-25 Commit Queue <commit-queue@webkit.org>
2194 Unreviewed, rolling out r181932.
2195 https://bugs.webkit.org/show_bug.cgi?id=143041
2197 The test fails most of the time on bots (Requested by ap on
2202 "[Content Extensions] Add multi-DFA compiling and
2204 https://bugs.webkit.org/show_bug.cgi?id=143010
2205 http://trac.webkit.org/changeset/181932
2207 2015-03-24 Alex Christensen <achristensen@webkit.org>
2209 [Content Extensions] Add multi-DFA compiling and interpreting.
2210 https://bugs.webkit.org/show_bug.cgi?id=143010
2212 Reviewed by Benjamin Poulain.
2214 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2215 (TestWebKitAPI::testRequest):
2216 (TestWebKitAPI::TEST_F):
2217 Add some tests for ignore-previous-rules and large rulesets.
2219 2015-03-24 Benjamin Poulain <bpoulain@apple.com>
2221 Make URL filter patterns matching consistent and add a simple canonicalization step
2222 https://bugs.webkit.org/show_bug.cgi?id=142998
2224 Reviewed by Alex Christensen.
2226 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2228 2015-03-24 Csaba Osztrogonác <ossy@webkit.org>
2230 [EFL] Add OpenWebRTC in jhbuild
2231 https://bugs.webkit.org/show_bug.cgi?id=142778
2233 Reviewed by Gyuyoung Kim.
2235 Original patch by Philippe Normand <pnormand@igalia.com>
2237 * efl/install-dependencies: Dependencies for OpenWebRTC.
2238 * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2239 the openwebrtc gst plugins.
2241 2015-03-23 Brent Fulgham <bfulgham@apple.com>
2243 Regression(r181257): WTF_WorkQueue.Simple is flaky
2244 https://bugs.webkit.org/show_bug.cgi?id=142560
2246 Remove the check that the refCount has returned to one after the
2247 individual tasks have completed. It's too nondeterministic when
2248 the reference count will be reduced.
2250 Reviewed by Alexey Proskuryakov
2252 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2253 (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2255 2015-03-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2257 [CMake][EFL] Put failure API test excutables into failure directory
2258 https://bugs.webkit.org/show_bug.cgi?id=142965
2260 Reviewed by Csaba Osztrogonác.
2262 Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2264 * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2265 * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2267 2015-03-22 Benjamin Poulain <benjamin@webkit.org>
2269 CSS Selectors: fix attribute case-insensitive matching of Contain and List
2270 https://bugs.webkit.org/show_bug.cgi?id=142932
2272 Reviewed by Darin Adler.
2274 Add tests for the new features and fix some existing tests using the
2275 stringFromUTF8() utility recently added by Dhi.
2277 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2278 (TestWebKitAPI::stringFromUTF8):
2279 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2281 2015-03-22 Michael Catanzaro <mcatanzaro@igalia.com>
2283 [GTK] install-dependencies should install orc
2284 https://bugs.webkit.org/show_bug.cgi?id=142955
2286 Reviewed by Martin Robinson.
2288 Install orc, needed by openwebrtc
2290 * gtk/install-dependencies:
2292 2015-03-22 Benjamin Poulain <bpoulain@apple.com>
2294 Detect when url filter pattern with groups match the empty string
2295 https://bugs.webkit.org/show_bug.cgi?id=142930
2297 Reviewed by Sam Weinig.
2299 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2301 2015-03-22 Anders Carlsson <andersca@apple.com>
2303 _WKWebsiteDataStore should clear WebSQL databases
2304 https://bugs.webkit.org/show_bug.cgi?id=142947
2306 Reviewed by Sam Weinig.
2308 Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
2310 * MiniBrowser/mac/WK2BrowserWindowController.m:
2311 (-[WK2BrowserWindowController fetchWebsiteData:]):
2312 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
2313 (-[WK2BrowserWindowController clearWebsiteData:]):
2315 2015-03-20 Mark Hahnenberg <mhahnenb@gmail.com>
2317 GCTimer should know keep track of nested GC phases
2318 https://bugs.webkit.org/show_bug.cgi?id=142675
2320 Reviewed by Darin Adler.
2322 Adds a tool to aid in parsing the GC phase timing output into a
2323 tree-like structure based on the parent-child relationships
2324 of nested GC phases.
2326 * Scripts/parse-gc-phase-timings: Added.
2329 (Timing.__unicode__):
2333 (print_timing_node):
2334 (print_timing_tree):
2338 2015-03-20 Brent Fulgham <bfulgham@apple.com>
2340 [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
2342 * Scripts/webkitpy/common/config/ews.json:
2344 2015-03-20 Philippe Normand <pnormand@igalia.com>
2346 [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
2347 https://bugs.webkit.org/show_bug.cgi?id=142867
2349 Rubber-stamped by Csaba Osztrogon.
2351 * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
2352 a fixed revision for the openwebrtc-gst-plugins.
2354 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
2356 Unreviewed build fix. Don't try to report stats for all benchmarks.
2357 Just report the geometric mean of preferred means.
2359 * Scripts/run-jsc-benchmarks:
2361 2015-03-19 Ryosuke Niwa <rniwa@webkit.org>
2363 run-jsc-benchmarks should only report preferred mean
2364 https://bugs.webkit.org/show_bug.cgi?id=142874
2366 Reviewed by Geoffrey Garen.
2368 Just collect statistics for the preferred mean.
2370 * Scripts/run-jsc-benchmarks:
2372 2015-03-19 Alex Christensen <achristensen@webkit.org>
2374 [Content Extensions] Test regular expression parse failures.
2375 https://bugs.webkit.org/show_bug.cgi?id=142872
2377 Reviewed by Benjamin Poulain.
2379 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2380 (TestWebKitAPI::testPatternStatus):
2381 (TestWebKitAPI::TEST_F):
2382 Added tests for each parsing status.
2384 2015-03-19 Alex Christensen <achristensen@webkit.org>
2386 Fix API tests after r181754.
2388 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2389 (TestWebKitAPI::testRequest):
2391 2015-03-19 Brady Eidson <beidson@apple.com>
2393 Part of content extensions should apply css selectors
2394 https://bugs.webkit.org/show_bug.cgi?id=142604
2396 Reviewed by Alex Christensen.
2398 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2399 (WebCore::ContentExtensions::operator<<):
2401 2015-03-19 Brent Fulgham <bfulgham@apple.com>
2403 [Win] Activate tests on EWS
2404 https://bugs.webkit.org/show_bug.cgi?id=142850
2406 Reviewed by Alexey Proskuryakov.
2408 * Scripts/webkitpy/common/config/ews.json: Add me as
2409 the EWS bot watcher, and activate tests.
2411 2015-03-19 Csaba Osztrogonác <ossy@webkit.org>
2413 [GTK] Fix inspector userinterface related incremental build issue
2414 https://bugs.webkit.org/show_bug.cgi?id=142849
2416 Reviewed by Carlos Garcia Campos.
2418 * Scripts/webkitdirs.pm:
2419 (shouldRemoveCMakeCache):
2421 2015-03-18 Alex Christensen <achristensen@webkit.org>
2423 [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
2424 https://bugs.webkit.org/show_bug.cgi?id=142799
2426 Reviewed by Brady Eidson.
2428 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2429 (TestWebKitAPI::testPattern):
2430 (TestWebKitAPI::TEST_F):
2431 Start testing regex failures.
2433 2015-03-18 Dhi Aurrahman <diorahman@rockybars.com>
2435 Fix StringView typos after r181525 and r181558
2436 https://bugs.webkit.org/show_bug.cgi?id=142772
2438 Reviewed by Darin Adler.
2440 Add some tests in [1] to cover the StringView::startsWith,
2441 StringView::startsWithIgnoringASCIICase, StringView::endsWith and
2442 StringView::endsWithIgnoringASCIICase implementations.
2444 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2445 (TestWebKitAPI::TEST):
2447 2015-03-18 Dana Burkart <dburkart@apple.com>
2449 Remove extraneous import to fix the build.
2453 * Scripts/webkitpy/port/driver.py:
2455 2015-03-18 Dana Burkart <dburkart@apple.com>
2457 ASAN_OPTIONS=allocator_may_return_null=1 needs to be set
2458 https://bugs.webkit.org/show_bug.cgi?id=142547
2460 Reviewed by Alexey Proskuryakov.
2462 * Scripts/webkitpy/port/driver.py:
2463 (Driver._setup_environ_for_driver):
2465 2015-03-18 Alexey Proskuryakov <ap@apple.com>
2467 Tweak how AppleSystemFontOSSubversion default is added
2468 https://bugs.webkit.org/show_bug.cgi?id=142835
2470 Reviewed by Dan Bernstein.
2472 * DumpRenderTree/mac/DumpRenderTree.mm:
2473 (setDefaultsToConsistentValuesForTesting):
2475 2015-03-18 Dan Bernstein <mitz@apple.com>
2477 prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
2478 https://bugs.webkit.org/show_bug.cgi?id=142815
2480 Reviewed by Darin Adler.
2482 * Scripts/prepare-ChangeLog:
2483 (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
2484 quotation mark, use new variable $quotation_mark to remember what we are looking for, and
2485 keep consuming the quoted text until the matching quotation mark is reached. Emit the
2486 warning only if a line ends without a backslash before the matching quotation mark was found.
2488 2015-03-18 Joseph Pecoraro <pecoraro@apple.com>
2490 Remove unused "preprocessor" parameter to sub-CodeGenerators
2491 https://bugs.webkit.org/show_bug.cgi?id=142793
2493 Reviewed by Darin Adler.
2495 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2498 2015-03-18 Csaba Osztrogonác <ossy@webkit.org>
2500 [EFL] Bump gstreamer version to 1.4.4
2501 https://bugs.webkit.org/show_bug.cgi?id=142782
2503 Reviewed by Philippe Normand.
2505 * efl/jhbuild.modules:
2506 * efl/patches/gst-libav.patch:
2507 * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
2508 * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
2510 2015-03-17 Tim Horton <timothy_horton@apple.com>
2514 * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2515 (WTR::InjectedBundle::platformInitialize):
2517 2015-03-17 Dean Jackson <dino@apple.com>
2519 check-webkit-style should allow "bool a : 1"
2520 https://bugs.webkit.org/show_bug.cgi?id=142794
2522 Reviewed by Brent Fulgham.
2524 We should allow member bitfields of the form:
2528 It seems that Visual Studio 8 was the last compiler that
2529 wasn't happy about not using unsigned here. We already have
2530 about 500 cases (in WebCore) where people were ignoring this rule.
2532 * Scripts/webkitpy/style/checkers/cpp.py:
2533 (check_language): Allow "bool".
2534 * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
2535 (CppStyleTest.test_enum_bitfields):
2536 (CppStyleTest.test_plain_integral_bitfields):
2538 2015-03-17 Benjamin Poulain <bpoulain@apple.com>
2540 Compile character ranges targeting the same state as range check in the bytecode
2541 https://bugs.webkit.org/show_bug.cgi?id=142759
2543 Reviewed by Alex Christensen.
2545 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2546 (TestWebKitAPI::TEST_F):
2548 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
2550 W3C test parser and converter should use test importer host
2551 https://bugs.webkit.org/show_bug.cgi?id=142729
2553 Reviewed by Bem Jones-Bey.
2555 When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
2556 This enables adding more TestImporter unit testing.
2557 This patch also ensures that the git object instantiated by TestDownloader is using the
2558 same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
2560 * Scripts/webkitpy/common/system/filesystem_mock.py:
2561 (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
2562 * Scripts/webkitpy/w3c/test_downloader.py:
2563 (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
2564 (TestDownloader.checkout_test_repository): Making use of the new git function.
2565 * Scripts/webkitpy/w3c/test_importer.py:
2566 (TestImporter.find_importable_tests): Adding host as parameter to the parser.
2567 (TestImporter.import_tests): Adding host as parameter to the converter.
2568 * Scripts/webkitpy/w3c/test_importer_unittest.py:
2569 (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
2571 (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests.
2572 * Scripts/webkitpy/w3c/test_parser.py:
2573 (TestParser.__init__): Adding host as parameter constructor.
2575 2015-03-17 Carlos Garcia Campos <cgarcia@igalia.com>
2577 [GTK] WebKitDOM objects leaking
2578 https://bugs.webkit.org/show_bug.cgi?id=118788
2580 Reviewed by Darin Adler and Sergio Villar Senin.
2582 Update DOMObjectCache unit test to check that DOM objects are also
2583 released when new contents are loaded in the web view, and the old
2584 document is detached from the frame.
2586 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2587 (testWebKitDOMObjectCache):
2588 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2591 2015-03-17 Youenn Fablet <youenn.fablet@crf.canon.fr>
2593 W3C test importer default import folder should be LayoutTests/imported/w3c
2594 https://bugs.webkit.org/show_bug.cgi?id=142728
2596 Reviewed by Bem Jones-Bey.
2598 * Scripts/webkitpy/w3c/test_importer.py:
2599 (parse_args): Updating the default destination option value to 'imported/w3c'.
2601 2015-03-17 Philippe Normand <pnormand@igalia.com>
2603 [GTK] basic OpenWebRTC build support
2604 https://bugs.webkit.org/show_bug.cgi?id=142393
2606 Reviewed by Carlos Garcia Campos.
2608 * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
2609 is not the upstream OpenWebRTC repository. This temporary fork
2610 contains a few patches needed by WebKit for audio/video rendering.
2612 2015-03-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
2614 [CMake][EFL] Build test tools only for developer mode
2615 https://bugs.webkit.org/show_bug.cgi?id=142761
2617 Reviewed by Csaba Osztrogonác.
2619 Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
2623 2015-03-17 Joseph Pecoraro <pecoraro@apple.com>
2625 Remove never used "useLayerOnTop" bindings generator argument
2626 https://bugs.webkit.org/show_bug.cgi?id=142773
2628 Reviewed by Darin Adler.
2630 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2633 2015-03-16 Ryosuke Niwa <rniwa@webkit.org>
2635 Enable ES6 classes by default
2636 https://bugs.webkit.org/show_bug.cgi?id=142774
2638 Reviewed by Gavin Barraclough.
2640 * Scripts/webkitperl/FeatureList.pm:
2642 2015-03-16 Alexey Proskuryakov <ap@apple.com>
2644 Fix webkitpy tests after r181585.
2646 Looks like "me" cannot be anyone's email, it's a special case.
2648 * Scripts/webkitpy/common/config/contributors.json:
2650 2015-03-16 Alexey Proskuryakov <ap@apple.com>
2652 Add tolerance to WebAudio tests
2653 https://bugs.webkit.org/show_bug.cgi?id=142676
2655 Reviewed by Tim Horton.
2657 * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
2659 * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2660 (TestResultWriter.create_audio_diff_and_write_result):
2661 * Scripts/webkitpy/layout_tests/models/test_failures.py:
2662 (FailureAudio.write_failure):
2663 * Scripts/webkitpy/port/base.py:
2664 (Port.do_audio_results_differ):
2665 Diff audio failures.
2667 * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
2668 tests to use real parseable WAV data, and got rid of base64, which there didn't
2669 seem to have been any reason for.
2671 2015-03-16 Alexey Proskuryakov <ap@apple.com>
2673 [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
2674 https://bugs.webkit.org/show_bug.cgi?id=142720
2676 Reviewed by Myles C. Maxfield.
2678 Activate system copies of Microsoft fonts for the current process, thus overriding
2679 any other ones that could be preferred by the system otherwise.
2681 * DumpRenderTree/mac/DumpRenderTree.mm:
2682 (activateSystemCoreWebFonts):
2684 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2685 (WTR::activateSystemCoreWebFonts):
2686 (WTR::activateFonts):
2688 2015-03-16 Xabier Rodriguez Calvar <calvaris@igalia.com>
2690 Created Streams API watchlist
2691 https://bugs.webkit.org/show_bug.cgi?id=142684
2693 Reviewed by Benjamin Poulain.
2695 * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
2696 watchlist and added Benjamin, Youenn and me to it.
2698 2015-03-15 Benjamin Poulain <benjamin@webkit.org>
2700 CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
2701 https://bugs.webkit.org/show_bug.cgi?id=142715
2703 Reviewed by Brent Fulgham.
2705 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2706 (TestWebKitAPI::TEST):
2708 2015-03-15 Benjamin Poulain <bpoulain@apple.com>
2710 Change the exact attribute matching to be ASCII case-insensitive
2711 https://bugs.webkit.org/show_bug.cgi?id=142609
2713 Reviewed by Darin Adler.
2715 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2716 * TestWebKitAPI/Tests/WTF/StringView.cpp:
2718 2015-03-13 Youenn Fablet <youenn.fablet@crf.canon.fr>
2720 WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
2721 https://bugs.webkit.org/show_bug.cgi?id=134764
2723 Reviewed by Ryosuke Niwa.
2725 TestDownloader is introduced to download W3C tests from the official
2726 W3C tests repositories (https://github.com/w3c/web-platform-tests.git
2727 and https://github.com/w3c/csswg-test.git).
2728 TestDownloader clones the repositories and checkouts revisions of the tests
2729 defined in LayoutTests/imported/w3c/resources/TestRepositories.
2731 Similarly to https://codereview.chromium.org/148173016,
2732 TestDownloader copies part of the files based on the rules
2733 defined in LayoutTests/imported/w3c/resources/ImportExpectations.
2735 TestDownloader is used by TestImporter when no source directory is provided.
2737 * Scripts/webkitpy/w3c/test_downloader.py: Added.
2739 (TestDownloader.default_options):
2740 (TestDownloader.load_test_repositories):
2741 (TestDownloader.__init__):
2742 (TestDownloader.checkout_test_repository):
2743 (TestDownloader._init_paths_from_expectations):
2744 (TestDownloader._add_test_suite_paths):
2745 (TestDownloader._empty_directory):
2746 (TestDownloader.copy_tests):
2747 (TestDownloader.download_tests):
2748 * Scripts/webkitpy/w3c/test_importer.py:
2751 (TestImporter.__init__):
2752 (TestImporter.do_import):
2753 (TestImporter.test_downloader):
2754 (TestImporter.find_importable_tests.should_keep_subdir):
2755 (TestImporter.should_convert_test_harness_links):
2756 (TestImporter.import_tests):
2757 (TestImporter.write_import_log):
2759 2015-03-12 Alexey Proskuryakov <ap@apple.com>
2761 [Mavericks] Test snapshots are 1600x1200 on Retina devices
2762 https://bugs.webkit.org/show_bug.cgi?id=142630
2764 Reviewed by Tim Horton.
2766 * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
2767 Removed an ifdef that disabled the fix on Mavericks.
2769 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
2771 Remove isWK2 cruft from webkitdirs.pm after r170426
2772 https://bugs.webkit.org/show_bug.cgi?id=142618
2774 Reviewed by Daniel Bates.
2776 * Scripts/webkitdirs.pm:
2779 2015-03-12 Alexey Proskuryakov <ap@apple.com>
2781 testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
2782 https://bugs.webkit.org/show_bug.cgi?id=138687
2784 Reviewed by Carlos Garcia Campos.
2786 Always change cookie policy from UI process, as changing it from WebProcess doesn't
2787 affect other processes.
2789 The implementation is imperfect, because the change happens asynchronously, but I
2790 don't expect it to be a problem in practice.
2792 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2793 (WTR::InjectedBundle::beginTesting):
2794 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2795 (WTR::TestRunner::setAlwaysAcceptCookies):
2796 * WebKitTestRunner/TestInvocation.cpp:
2797 (WTR::TestInvocation::invoke):
2798 (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2800 2015-03-12 Csaba Osztrogonác <ossy@webkit.org>
2802 [EFL] Enable building EFL 1.13 with NEON support
2803 https://bugs.webkit.org/show_bug.cgi?id=142619
2805 Reviewed by Gyuyoung Kim.
2807 * efl/jhbuild.modules:
2809 2015-03-11 Alex Christensen <achristensen@webkit.org>
2811 [Content Extensions] Add resource type and load type triggers.
2812 https://bugs.webkit.org/show_bug.cgi?id=142422
2814 Reviewed by Benjamin Poulain.
2816 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2817 (TestWebKitAPI::testRequest):
2818 (TestWebKitAPI::mainDocumentRequest):
2819 (TestWebKitAPI::TEST_F):
2820 (TestWebKitAPI::testURL): Deleted.
2822 2015-03-10 Sam Weinig <sam@webkit.org>
2824 Allow adding a button in input elements for auto fill related functionality
2825 <rdar://problem/19782066>
2826 https://bugs.webkit.org/show_bug.cgi?id=142564
2828 Reviewed by Anders Carlsson.
2830 * WebKitTestRunner/TestController.cpp:
2831 (WTR::TestController::createOtherPage):
2832 (WTR::TestController::createWebViewWithOptions):
2833 Update for new callback.
2835 2015-03-11 Benjamin Poulain <bpoulain@apple.com>
2837 Add basic support for BOL and EOL assertions to the URL Filter parser
2838 https://bugs.webkit.org/show_bug.cgi?id=142568
2840 Reviewed by Alex Christensen.
2842 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2843 (TestWebKitAPI::TEST_F):
2845 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
2847 [GTK] Add support for handling TLS errors to MiniBrowser
2848 https://bugs.webkit.org/show_bug.cgi?id=142576
2850 Reviewed by Sergio Villar Senin.
2852 It's useful for testing TLS errors handling itself, but also to
2853 allow ignoring TLS errors when testing.
2855 * MiniBrowser/gtk/BrowserWindow.c:
2856 (webViewLoadFailedWithTLSerrors):
2857 (browserWindowConstructed):
2859 2015-03-11 Myles C. Maxfield <mmaxfield@apple.com>
2861 Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
2862 https://bugs.webkit.org/show_bug.cgi?id=142569
2864 Reviewed by David Hyatt.
2866 Test Optional::valueOrCompute().
2868 * TestWebKitAPI/Tests/WTF/Optional.cpp:
2869 (TestWebKitAPI::TEST):
2871 2015-03-11 Carlos Garcia Campos <cgarcia@igalia.com>
2873 [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
2874 https://bugs.webkit.org/show_bug.cgi?id=126688
2876 Reviewed by Gustavo Noronha Silva.
2878 * CMakeLists.txt: Build testing tools only for developer builds,
2879 but MiniBrowser when ENABLE_MINIBROWSER option is ON.
2880 * MiniBrowser/gtk/CMakeLists.txt: Only add
2881 -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
2882 and add a rule to install the MiniBrowser.
2883 * MiniBrowser/gtk/main.c:
2884 (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
2887 2015-03-11 Brent Fulgham <bfulgham@apple.com>
2889 Add some DateMath tests to TestWebKitAPI
2890 https://bugs.webkit.org/show_bug.cgi?id=142565
2892 Reviewed by Alexey Proskuryakov.
2894 * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
2895 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
2896 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
2897 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
2898 * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
2900 2015-03-10 Brent Fulgham <bfulgham@apple.com>
2902 Regression(r181257): WTF_WorkQueue.Simple is flaky
2903 https://bugs.webkit.org/show_bug.cgi?id=142560
2905 Unreviewed attempt to improve test stability.
2907 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
2908 the WorkQueue a little later to redue flakiness.
2910 2015-03-10 Myles C. Maxfield <mmaxfield@apple.com>
2912 Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
2913 https://bugs.webkit.org/show_bug.cgi?id=142555
2915 Reviewed by Simon Fraser.
2917 * DumpRenderTree/mac/DumpRenderTree.mm:
2918 (setDefaultsToConsistentValuesForTesting):
2919 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2920 (WTR::InjectedBundle::platformInitialize):
2922 2015-03-10 Alex Christensen <achristensen@webkit.org>
2924 Use unsigned for HashSet size.
2925 https://bugs.webkit.org/show_bug.cgi?id=142518
2927 Reviewed by Benjamin Poulain.
2929 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2930 (TestWebKitAPI::TEST):
2931 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2932 (TestWebKitAPI::testInitialCapacity):
2933 * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2934 (TestWebKitAPI::TEST):
2936 2015-03-10 Daniel Bates <dabates@apple.com>
2938 [iOS] Add WebKitSystemInterface for iOS 8.2
2939 https://bugs.webkit.org/show_bug.cgi?id=142505
2941 Rubber-stamped by Anders Carlsson.
2943 Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
2944 I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
2945 copy-webkitlibraries-to-product-directory in r181286.
2947 * Scripts/copy-webkitlibraries-to-product-directory:
2949 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
2951 Extend URL filter's Term definition to support groups/subpatterns
2952 https://bugs.webkit.org/show_bug.cgi?id=142519
2954 Reviewed by Alex Christensen.
2956 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2957 (TestWebKitAPI::testURL):
2959 2015-03-06 Jer Noble <jer.noble@apple.com>
2961 Add an option to run-webkit-tests to override the LayoutTests/ directory
2962 https://bugs.webkit.org/show_bug.cgi?id=142418
2964 Reviewed by David Kilzer.
2966 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
2967 directory. The base port will parse the options during initialization and store the override
2968 location if present. layout_tests_dir() will return this overridden location if set.
2970 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2972 * Scripts/webkitpy/port/base.py:
2974 (Port.layout_tests_dir):
2976 2015-03-09 Martin Robinson <mrobinson@igalia.com>
2978 [CMake] Enable WorkQueue tests for CMake ports
2979 https://bugs.webkit.org/show_bug.cgi?id=142473
2981 Reviewed by Darin Adler.
2983 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
2984 the list of source files.
2985 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
2986 to the list of include directories for EFL.
2988 2015-03-09 David Kilzer <ddkilzer@apple.com>
2990 Attempt to fix timeouts on iOS Simulator layout tests
2992 * Scripts/webkitpy/port/ios.py:
2993 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
2994 Simulator end after the first 50 tests time out. Some analysis
2995 this past weekend shows that the 'Booted' status in the output
2996 of `xcrun simctl list` is not sufficient (and watching the test
2997 run shows that SpringBoard hasn't fully started to the point
2998 where it's displaying icons on the home screen). The workaround
2999 until we have a better fix is to add an arbitrary timeout to let
3000 SpringBoard finish launching. In practice, 15 seconds is
3001 probably enough, but 30 seconds should nearly always work.
3003 2015-03-09 Per Arne Vollan <peavo@outlook.com>
3005 Unreviewed. Add myself as a committer.
3007 * Scripts/webkitpy/common/config/contributors.json:
3009 2015-03-09 David Kilzer <ddkilzer@apple.com>
3011 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3013 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3014 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3015 an expectation that will fail if we hit the race condition.
3016 This test is inherently racy and will deadlock if the first job
3017 for queue2 takes the mutex lock before the second job for
3020 2015-03-08 Brent Fulgham <bfulgham@apple.com>
3022 [Win] WTF::WorkQueue does not balance ref/deref properly
3023 https://bugs.webkit.org/show_bug.cgi?id=142471
3025 Reviewed by Antti Koivisto.
3027 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3028 (TestWebKitAPI::TEST): Check that the refcount is correct.
3030 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3032 Do not show passing test result on output of EFL layout test
3033 https://bugs.webkit.org/show_bug.cgi?id=142380
3035 Reviewed by Darin Adler.
3037 To show passing tests has caused inconvenience when we detect problem tests
3038 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3039 in order not to show passing tests in the output of EFL layout test.
3041 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3042 (RunWebKitTests.start):
3044 2015-03-08 Brent Fulgham <bfulgham@apple.com>
3046 Unreviewed build fix.
3048 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3049 (TestWebKitAPI::TEST): Remove two unused variables.
3051 2015-03-08 Brent Fulgham <bfulgham@apple.com>
3053 Add some WorkQueue tests to TestWebKitAPI
3054 https://bugs.webkit.org/show_bug.cgi?id=142447
3056 Reviewed by Sam Weinig.
3058 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3059 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3060 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3061 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3062 (TestWebKitAPI::simpleTest):
3063 (TestWebKitAPI::longTest):
3064 (TestWebKitAPI::thirdTest):
3065 (TestWebKitAPI::finishedTests):
3066 (TestWebKitAPI::TEST):
3067 (TestWebKitAPI::longTest2):
3069 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
3071 Remove willDestroyFrame in WKBundlePageLoaderClient
3072 https://bugs.webkit.org/show_bug.cgi?id=142389
3074 Reviewed by Anders Carlsson.
3076 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3077 (WTR::InjectedBundlePage::InjectedBundlePage):
3079 2015-03-07 Brent Fulgham <bfulgham@apple.com>
3081 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3082 https://bugs.webkit.org/show_bug.cgi?id=142433
3084 Reviewed by Darin Adler.
3086 Include more TestWebKitAPI tests when building for Windows. Also
3087 fix a build error in MetaAllocator.cpp caused by one of the
3088 Microsoft headers #defining 'small'.
3090 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3091 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3092 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3094 2015-03-06 Sam Weinig <sam@webkit.org>
3096 [Content Extensions] Move compiling of content extensions to the UIProcess
3097 https://bugs.webkit.org/show_bug.cgi?id=142402
3099 Reviewed by Benjamin Poulain.
3101 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3102 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3103 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3104 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3105 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3106 (TestWebKitAPI::TEST_F):
3107 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3108 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3111 2015-03-06 Brent Fulgham <bfulgham@apple.com>
3113 [Win] Correct Windows build.
3115 Rubberstamped by Michael Saboff
3117 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3120 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
3122 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3123 https://bugs.webkit.org/show_bug.cgi?id=142385
3125 Reviewed by Sergio Villar Senin.
3127 Use stack allocated GMainLoopSources to make sure they are
3128 cancelled automatically if the test finishes before they have
3131 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3132 (testWebViewSyncRequestOnMaxConns):
3134 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
3136 Remove Mountain Lion libraries since ML isn't supported
3137 https://bugs.webkit.org/show_bug.cgi?id=142332
3139 Reviewed by Darin Adler.
3141 * Scripts/copy-webkitlibraries-to-product-directory:
3143 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
3145 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3146 https://bugs.webkit.org/show_bug.cgi?id=142083
3148 Reviewed by Simon Fraser.
3150 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3152 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3153 (WebPlatformTestServer._copy_webkit_test_files):
3155 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
3157 setup-git-clone fails due to the failure to download python-irclib-0.4.8
3158 https://bugs.webkit.org/show_bug.cgi?id=141946
3160 Reviewed by Ryosuke Niwa.
3162 Check in ircbot.py and irclib.py to avoid network problems in the future.
3164 * Scripts/webkitpy/common/net/irc/ircbot.py:
3165 * Scripts/webkitpy/thirdparty/__init__.py:
3166 (AutoinstallImportHook.find_module):
3167 (AutoinstallImportHook._install_irc): Deleted.
3168 * Scripts/webkitpy/thirdparty/__init___unittest.py:
3169 (ThirdpartyTest.test_imports):
3170 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
3171 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
3172 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
3174 2015-03-06 David Kilzer <ddkilzer@apple.com>
3176 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
3178 See also fix to config.json in r181097.
3180 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3181 (WebKitBuildbot): Add missing "WK2" to the names of the perf
3184 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
3186 run-jsc-stress-tests should determine the architecture from ELF binaries
3187 https://bugs.webkit.org/show_bug.cgi?id=142335
3189 Reviewed by Darin Adler.
3191 * Scripts/run-jsc-stress-tests:
3193 2015-03-05 David Kilzer <ddkilzer@apple.com>
3195 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
3196 <http://webkit.org/b/142226>
3198 Reviewed by Darin Adler.
3200 * Scripts/webkitpy/port/ios.py:
3201 (IOSSimulatorPort.default_baseline_search_path): Switch the
3202 TestExpectations order of ios-simulator-wk2 from this:
3203 ios-simulator-wk2, wk2, ios-simulator
3205 ios-simulator-wk2, ios-simualtor, wk2
3207 2015-03-05 Brent Fulgham <bfulgham@apple.com>
3209 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
3210 https://bugs.webkit.org/show_bug.cgi?id=142370
3212 Reviewed by Dean Jackson.
3214 * Scripts/webkitdirs.pm:
3215 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
3216 logs, one for warnings, the other for errors.
3217 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
3218 into the standard BuildOutput.htm document.
3220 2015-03-05 David Kilzer <ddkilzer@apple.com>
3222 Dashboard has trouble parsing iOS test output
3223 <http://webkit.org/b/142364>
3225 Reviewed by Alex Christensen.
3227 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3228 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3229 Add fallback path to build a regex using 'matchString' so that
3230 it matches anywhere in the line. In practice, 'matchString' is
3231 a prefix for the label following the number.
3233 2015-03-05 Alex Christensen <achristensen@webkit.org>
3235 Fix linker warnings in TestWebKitAPI.
3236 https://bugs.webkit.org/show_bug.cgi?id=141912
3238 Reviewed by David Kilzer.
3240 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3241 Do not export TearDownTestCase or SetUpTestCase symbols.
3243 2015-03-05 Brent Fulgham <bfulgham@apple.com>
3245 [Win] Unreviewed EWS fix.
3247 * Scripts/webkitdirs.pm:
3248 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
3249 the EWS output more usable.
3251 2015-03-05 Chris Dumez <cdumez@apple.com>
3253 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
3254 https://bugs.webkit.org/show_bug.cgi?id=142350
3256 Reviewed by Michael Saboff and Benjamin Poulain.
3258 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
3259 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
3261 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3262 (TestWebKitAPI::TEST):
3264 2015-03-05 Brent Fulgham <bfulgham@apple.com>
3266 [Win] Ensure build target directory exists when launching MSBuild
3267 https://bugs.webkit.org/show_bug.cgi?id=142360
3269 Reviewed by Dean Jackson.
3271 Create the build output directory (if it doesn't exist) before
3272 launching MSBuild so that it can immediately begin writing logs.
3274 * Scripts/webkitdirs.pm:
3275 (buildVisualStudioProject):
3277 2015-03-05 Chris Dumez <cdumez@apple.com>
3279 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
3280 https://bugs.webkit.org/show_bug.cgi?id=142325
3282 Reviewed by Csaba Osztrogonác.
3284 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
3285 As a result, "--webkit-test-runner / -2" parameters are replaced by
3286 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
3287 than WebKitTestRunner.
3289 * BuildSlaveSupport/build.webkit.org-config/config.json:
3290 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3292 (RunWebKit1Tests.start):
3293 (RunWebKit1LeakTests):
3294 (RunWebKit1LeakTests.start):
3295 (RunAndUploadPerfTestsWebKit1):
3296 (RunAndUploadPerfTestsWebKit1.start):
3298 (TestWebKit1LeaksFactory):
3299 (TestWebKit1LeaksFactory.__init__):
3300 (TestWebKit1Factory):
3301 (TestWebKit1AllButJSCFactory):
3302 (TestAllButJSCFactory):
3303 (BuildAndPerfTestWebKit1Factory):
3304 (BuildAndPerfTestWebKit1Factory.__init__):
3305 (BuildAndPerfTestFactory):
3306 (BuildAndPerfTestFactory.__init__):
3307 (DownloadAndPerfTestWebKit1Factory):
3308 (DownloadAndPerfTestWebKit1Factory.__init__):
3309 (DownloadAndPerfTestFactory):
3310 (DownloadAndPerfTestFactory.__init__):
3311 (RunWebKitLeakTests): Deleted.
3312 (RunWebKitLeakTests.start): Deleted.
3313 (RunWebKit2Tests): Deleted.
3314 (RunWebKit2Tests.start): Deleted.
3315 (RunAndUploadPerfTestsWebKit2): Deleted.
3316 (RunAndUploadPerfTestsWebKit2.start): Deleted.
3317 (TestLeaksFactory): Deleted.
3318 (TestLeaksFactory.__init__): Deleted.
3319 (TestWebKit2Factory): Deleted.
3320 (TestWebKit2AndJSCFactory): Deleted.
3321 (BuildAndPerfTestWebKit2Factory): Deleted.
3322 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
3323 (DownloadAndPerfTestWebKit2Factory): Deleted.
3324 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
3325 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3327 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3328 (PerfTestsRunner._parse_args):
3329 * Scripts/webkitpy/port/port_testcase.py:
3330 (PortTestCase.test_build_driver):
3332 2015-03-05 Brent Fulgham <bfulgham@apple.com>
3334 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
3335 https://bugs.webkit.org/show_bug.cgi?id=140845
3337 Reviewed by David Kilzer.
3339 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
3340 and generate suitable build commands to drive a full build from our
3341 existing solution files.
3343 * Scripts/webkitdirs.pm:
3344 (msBuildInstallDir): Added.
3345 (determineConfigurationForVisualStudio): Revise to use MSBuild command
3346 line arguments to drive the build.
3347 (setupCygwinEnv): Warn user if MSBuild cannot be located.
3348 (buildVisualStudioProject): Revise to use MSBuild command line arguments
3349 to specify build architecture.
3350 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
3351 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
3352 bother looking for CoreUI or SafariTheme build logs.
3354 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
3356 [buildbot] mastercfg_unittest.py should be runnable easily
3357 https://bugs.webkit.org/show_bug.cgi?id=142219
3359 Reviewed by Chris Dumez.
3361 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
3362 the last Twisted version works together with this buildbot version.
3364 * Scripts/webkitpy/common/system/autoinstall.py:
3365 (AutoInstaller): Added prepend_to_search_path argument to be able
3366 to prefer autoinstalled package to system package.
3367 (AutoInstaller.__init__):
3368 (AutoInstaller._set_up_target_dir):
3369 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
3370 (AutoInstaller._prepare_package):
3371 (AutoInstaller._extract_targz): Renamed to _extract_tar.
3372 * Scripts/webkitpy/thirdparty/__init__.py:
3373 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
3375 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
3377 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
3378 https://bugs.webkit.org/show_bug.cgi?id=131162
3380 Reviewed by Gyuyoung Kim.
3382 * MiniBrowser/efl/main.c:
3383 (on_download_request):
3384 (on_download_finished):
3385 (on_download_failed):
3387 Adapt download callbacks to new callback mechanism
3389 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
3391 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
3393 In r180927 we updated the libsoup version used by the jhbuild. In
3394 this new version the sniffer uses image/x-icon instead of
3395 image/vnd.microsoft.icon for blank.ico resource.
3397 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3398 (testWebResourceMimeType):
3400 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
3402 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
3403 https://bugs.webkit.org/show_bug.cgi?id=142244
3405 Reviewed by Sergio Villar Senin.
3407 Check that the SSL server doesn't process any request in case of
3408 TLS errors when the policy is set to FAIL.
3410 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3411 (testTLSErrorsPolicy):
3412 (testTLSErrorsRedirect):
3413 (testTLSErrorsHTTPAuth):
3414 (testLoadFailedWithTLSErrors):
3415 (testSubresourceLoadFailedWithTLSErrors):
3416 (httpsServerCallback):
3418 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
3420 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
3421 https://bugs.webkit.org/show_bug.cgi?id=141154
3423 Reviewed by Jer Noble.
3425 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
3427 For the sake of completeness WebKitTestRunner should specify temporary
3428 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
3430 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
3431 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3432 to get data storage paths. Only Mac port has an actual implementation of it.
3433 However, WebKitTestRunner overrides them in favour of unique temporary dir
3434 which is taken from libraryPathForTesting().
3436 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
3437 is not implemented for EFL and GTK ports it returns an empty string.
3438 All default data folders besides MediaKeys are overridden in TestRunner
3439 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
3442 GTK port does not enable encrypted keys by default so
3443 WebMediaKeyStorageManager::initialize() code path is never triggered.
3445 * WebKitTestRunner/TestController.cpp:
3446 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
3449 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
3451 [buildbot] Add regression test to check which builder runs which tests
3452 https://bugs.webkit.org/show_bug.cgi?id=142166
3454 Reviewed by Alexey Proskuryakov.
3456 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3457 (BuildStepsConstructorTest.createTest):
3459 (BuildStepsTest.generateTests):
3460 (BuildStepsTest.createTest):
3461 (BuildStepsTest.createTest.doTest):
3462 (BuildStepsTest.test_unnecessary_expected_results):
3464 2015-03-04 Commit Queue <commit-queue@webkit.org>
3466 Unreviewed, rolling out r181054.
3467 https://bugs.webkit.org/show_bug.cgi?id=142320
3469 Broke the api tests (Requested by sundiamonde on #webkit).
3473 "Fix linker warnings in TestWebKitAPI."
3474 https://bugs.webkit.org/show_bug.cgi?id=141912
3475 http://trac.webkit.org/changeset/181054
3477 2015-03-04 Alex Christensen <achristensen@webkit.org>
3479 Fix linker warnings in TestWebKitAPI.
3480 https://bugs.webkit.org/show_bug.cgi?id=141912
3482 Reviewed by David Kilzer.
3484 * TestWebKitAPI/Configurations/Base.xcconfig:
3485 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
3487 2015-03-04 Alexey Proskuryakov <ap@apple.com>
3489 [Mac] Set SystemUIFontSelect in DRT and WKTR
3490 https://bugs.webkit.org/show_bug.cgi?id=142303
3492 Reviewed by Myles C. Maxfield.
3494 * DumpRenderTree/mac/DumpRenderTree.mm:
3495 (setDefaultsToConsistentValuesForTesting):
3496 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3497 (WTR::InjectedBundle::platformInitialize):
3499 2015-03-04 Chris Dumez <cdumez@apple.com>
3501 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3502 https://bugs.webkit.org/show_bug.cgi?id=142314
3503 <rdar://problem/20046835>
3505 Reviewed by Ryosuke Niwa.
3507 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
3508 to get WK2 code coverage.
3510 * BuildSlaveSupport/build.webkit.org-config/config.json:
3512 2015-03-04 Alex Christensen <achristensen@webkit.org>
3514 Move content extensions test to properly named directory.
3515 https://bugs.webkit.org/show_bug.cgi?id=142299
3517 Reviewed by Tim Horton.
3519 * WebKitTestRunner/mac/TestControllerMac.mm:
3520 (WTR::TestController::platformConfigureViewForTest):
3522 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
3524 W3C test importer should use filesystem instead of os.walk
3525 https://bugs.webkit.org/show_bug.cgi?id=142085
3527 Reviewed by Bem Jones-Bey.
3529 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
3530 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
3531 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
3533 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
3534 Added a unit test to check that test importer is now black-box testable using a Mock system.
3536 * Scripts/webkitpy/common/system/filesystem.py:
3537 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
3538 (FileSystem.dirs_under.filter_all):
3539 * Scripts/webkitpy/common/system/filesystem_mock.py:
3540 (MockFileSystem.dirs_under):
3541 (MockFileSystem.dirs_under.filter_all):
3542 (MockFileSystem.getsize):
3543 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
3544 (MockFileSystemTest.test_dirs_under):
3545 (MockFileSystemTest.test_dirs_under.filter_dir):
3546 * Scripts/webkitpy/common/system/filesystem_unittest.py:
3547 (RealFileSystemTest.test_sep):
3548 (RealFileSystemTest):
3549 (RealFileSystemTest.test_dirs_under):
3550 (RealFileSystemTest.test_dirs_under.filter_this_dir):
3551 * Scripts/webkitpy/w3c/test_importer.py:
3552 (TestImporter.do_import):
3553 (TestImporter.find_importable_tests.should_keep_subdir):
3554 (TestImporter.find_importable_tests):
3555 (TestImporter.should_keep_subdir): Deleted.
3556 (TestImporter.should_skip_file): Deleted.
3557 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3558 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
3560 2015-03-04 Timothy Horton <timothy_horton@apple.com>
3562 [WebEditingTester] Add support for the find and replace bar
3563 https://bugs.webkit.org/show_bug.cgi?id=142247
3565 Reviewed by Enrica Casucci.
3567 While it's not hooked up yet in WKWebView, adding support for the
3568 find bar to WebEditingTester will help us implement that functionality.
3570 * WebEditingTester/AppDelegate.h:
3571 * WebEditingTester/AppDelegate.m:
3572 (-[WebEditingAppDelegate performTextFinderAction:]):
3573 * WebEditingTester/MainMenu.xib:
3574 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
3576 * WebEditingTester/WK2WebDocumentController.m:
3577 (-[WK2WebDocumentController awakeFromNib]):
3578 (-[WK2WebDocumentController performTextFinderAction:]):
3579 (-[WK2WebDocumentController findBarView]):
3580 (-[WK2WebDocumentController setFindBarView:]):
3581 (-[WK2WebDocumentController isFindBarVisible]):
3582 (-[WK2WebDocumentController setFindBarVisible:]):
3583 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
3584 (-[WK2WebDocumentController layout]):
3585 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
3586 pointing at the WKWebView (currently nothing will work, but the bar will
3587 show up). Install and uninstall the bar as needed.
3589 * WebEditingTester/WebDocument.xib:
3590 Don't use a full-size content view. There's no need, and it makes find
3593 * WebEditingTester/WebDocumentController.h:
3594 * WebEditingTester/WebDocumentController.m:
3595 (-[WebDocumentController performTextFinderAction:]):
3597 2015-03-03 Sam Weinig <sam@webkit.org>
3599 [Content Extensions] Split parsing and compiling of content extensions into their own files
3600 https://bugs.webkit.org/show_bug.cgi?id=142259
3602 Reviewed by Anders Carlsson.
3604 Add basic unit test for the content filter compiler.
3606 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3607 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
3608 (WebCore::ContentExtensions::operator<<):
3609 (TestWebKitAPI::ContentFilterTest::SetUp):
3610 (TestWebKitAPI::TEST_F):
3612 2015-03-04 Matthew Mirman <mmirman@apple.com>
3614 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
3615 https://bugs.webkit.org/show_bug.cgi?id=142230
3617 Reviewed by Csaba Osztrogonác.
3619 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3621 (TestFactory.getProduct): Added
3622 (TestFactory.__init__): moved downloader to getProduct
3623 (BuildAndTestFactory):
3624 (BuildAndTestFactory.getProduct): Added
3625 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
3626 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
3628 2015-03-04 Debarshi Ray <debarshir@gnome.org>
3630 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
3631 https://bugs.webkit.org/show_bug.cgi?id=142225
3633 Reviewed by Carlos Garcia Campos.
3635 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3636 (testWebViewWebContextLifetime):
3639 2015-03-03 David Kilzer <ddkilzer@apple.com>
3641 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
3642 <http://webkit.org/b/142243>
3644 Reviewed by Alexey Proskuryakov.
3646 * WebKitTestRunner/TestController.cpp:
3647 (WTR::TestController::webProcessName):
3648 (WTR::TestController::networkProcessName):
3649 - Return the same process name on iOS and Mac because they both
3650 use the same process name for local engineering builds.
3652 2015-03-03 David Kilzer <ddkilzer@apple.com>
3654 check-webkit-style: Add exception for FrameworkSoftLink.h header order
3655 <http://webkit.org/b/141872>
3657 Reviewed by Alex Christensen.
3659 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
3660 semi-colons in various places and fix whitespace.
3661 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
3663 (_IncludeState.__init__): Add self._visited_soft_link_section
3664 boolean state variable.
3665 (_IncludeState.visited_soft_link_section): Getter for
3666 self._visited_soft_link_section.
3667 (_IncludeState.check_next_include_order): Update state machine
3668 for soft-link headers. Add check that soft-link headers always
3670 (_classify_include): Add check for soft-link header type.
3671 (check_include_line): Return early if there is a soft-link
3674 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3675 (OrderOfIncludesTest.test_public_primary_header): Add tests for
3676 including soft-link headers.
3677 (OrderOfIncludesTest.test_classify_include): Add test for
3678 _SOFT_LINK_HEADER type.
3680 2015-03-03 Alexey Proskuryakov <ap@apple.com>
3682 build.webkit.org/dashboard: Don't repeatedly handle each test type