Layout Test platform/chromium/compositing/zoom-animator-scale-test.html is failing.
[WebKit-https.git] / Tools / ChangeLog
1 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2
3         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
4
5         QWidget and friends now live in the QtWidgets library. We update
6         includes in implementation files and private headers to us the
7         non-module-prefixed path, and leave the lookup for the include
8         path. For public headers we have to ifdef the includes as the
9         user might now have the modules we need in his QT config.
10
11         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
12         have to update our code and use windowHandle() for setting the
13         parent relationships.
14
15         https://bugs.webkit.org/show_bug.cgi?id=68687
16
17         Reviewed by Andreas Kling.
18
19         * DumpRenderTree/qt/DumpRenderTree.pro:
20         * DumpRenderTree/qt/ImageDiff.pro:
21         * MiniBrowser/qt/BrowserView.cpp:
22         * MiniBrowser/qt/BrowserView.h:
23         * MiniBrowser/qt/BrowserWindow.cpp:
24         * MiniBrowser/qt/BrowserWindow.h:
25         * MiniBrowser/qt/MiniBrowser.pro:
26         * MiniBrowser/qt/MiniBrowserApplication.h:
27         * MiniBrowser/qt/main.cpp:
28         * QtTestBrowser/QtTestBrowser.pro:
29         * QtTestBrowser/launcherwindow.cpp:
30         * QtTestBrowser/launcherwindow.h:
31         * QtTestBrowser/locationedit.h:
32         * QtTestBrowser/main.cpp:
33         * QtTestBrowser/mainwindow.cpp:
34         * QtTestBrowser/mainwindow.h:
35         * QtTestBrowser/webinspector.h:
36         * QtTestBrowser/webpage.cpp:
37         * QtTestBrowser/webview.cpp:
38         * WebKitTestRunner/PlatformWebView.h:
39         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
40
41 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
42
43         [Qt][WK2] Add support for hover API in Qt WebKit2
44         https://bugs.webkit.org/show_bug.cgi?id=68369
45
46         Reviewed by Andreas Kling.
47
48         Change the statusbar to show the link URL when hovering links in
49         MiniBrowser using QDesktopWebView.
50
51         * MiniBrowser/qt/BrowserWindow.cpp:
52         (BrowserWindow::BrowserWindow):
53         (BrowserWindow::onLinkHovered):
54         * MiniBrowser/qt/BrowserWindow.h:
55
56 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
57
58         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
59         https://bugs.webkit.org/show_bug.cgi?id=68864
60
61         Reviewed by Adam Barth.
62
63         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
64         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
65         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
66         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
67
68 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
69
70         [Qt][WK2] One more unreviewed buildfix after r96005.
71
72         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
73
74 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
75
76         [Qt][WK2] Unreviewed buildfix after r96005.
77
78         * WebKitTestRunner/qt/TestInvocationQt.cpp:
79         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
80
81 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
82
83         garden-o-matic should be pretty in Open Sans.
84         https://bugs.webkit.org/show_bug.cgi?id=68845
85
86         Reviewed by Adam Barth.
87
88         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
89
90 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
91
92         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
93         https://bugs.webkit.org/show_bug.cgi?id=68841
94
95         Reviewed by Adam Barth.
96
97         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
98         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
99         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
100
101 2011-09-26  David Levin  <levin@chromium.org>
102
103         watchlist: Add parsing for definition section.
104         https://bugs.webkit.org/show_bug.cgi?id=68850
105
106         Reviewed by Adam Barth.
107
108         * Scripts/webkitpy/common/watchlist/watchlist.py:
109         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
110         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
111
112 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
113
114         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
115
116         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
117         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
118         * WebKitTestRunner/win/TestInvocationWin.cpp:
119         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
120
121 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
122
123         Repaint tests don't work in WebKit2
124         https://bugs.webkit.org/show_bug.cgi?id=68453
125
126         Reviewed by Sam Weinig.
127         
128         Convert DumpRenderTree to use use the repaint rects
129         exposed via WebKit API when generating the repaint test
130         overlay.
131         
132         Fix WebKitTestRunner to work with repaint tests, again
133         using the repaint rects exposed from WK2.
134         
135         In both cases, layoutTestController.display() now just
136         forces a display of the web view, and turns on repaint
137         rect tracking on the main FrameView.
138         
139         Later, when pixel results are requested, the alpha overlay
140         that shows the repaint rects is generated using the list
141         of rects supplied by WebCore.
142
143         * DumpRenderTree/mac/DumpRenderTree.mm:
144         (resetDefaultsToConsistentValues):
145         (resetWebViewToConsistentStateBeforeTesting):
146         (displayWebView):
147         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
148         (paintRepaintRectOverlay):
149         (createBitmapContextFromWebView):
150         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
151         (WTR::InjectedBundle::beginTesting):
152         (WTR::InjectedBundle::done):
153         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
154         (WTR::InjectedBundle::setRepaintRects):
155         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
156         (WTR::InjectedBundlePage::reset):
157         (WTR::InjectedBundlePage::dump):
158         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
159         (WTR::LayoutTestController::display):
160         * WebKitTestRunner/TestInvocation.cpp:
161         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
162         * WebKitTestRunner/TestInvocation.h:
163         * WebKitTestRunner/cg/TestInvocationCG.cpp:
164         (WTR::paintRepaintRectOverlay):
165         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
166
167 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
168
169         Get hover'ed element URL from HitTest.
170
171         mouseDidMoveOverElement now gets the hover'ed element link using
172         WKHitTestResult API's.
173         https://bugs.webkit.org/show_bug.cgi?id=68426 
174
175         Reviewed by Anders Carlsson.
176
177         * MiniBrowser/gtk/BrowserWindow.c:
178         (mouseDidMoveOverElement):
179
180 2011-09-26  David Levin  <levin@chromium.org>
181
182         Add skeleton parsing for a WatchList.
183         https://bugs.webkit.org/show_bug.cgi?id=68823
184
185         Reviewed by Adam Barth.
186
187         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
188         Parses the top level watch list sections -- none are defined yet -- and
189         throws an exception if an invalid one is listed.
190         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
191         Verify the exception for an invalid section in a watch list.
192         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
193
194 2011-09-26  Adam Roben  <aroben@apple.com>
195
196         Clean up code imported from WebKitAPITest
197
198         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
199         TestWebKitAPI conventions
200
201         Reviewed by David Levin.
202
203         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
204         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
205         namespace name.
206
207         (TestWebKitAPI::WebViewDestruction::SetUp):
208         (TestWebKitAPI::WebViewDestruction::webViewCount):
209         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
210         (TestWebKitAPI::WebViewDestruction::runMessagePump):
211         (TestWebKitAPI::WebViewDestruction::TearDown):
212         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
213         Moved functionality from free functions into these new test fixtures.
214
215         * TestWebKitAPI/win/HostWindow.cpp:
216         * TestWebKitAPI/win/HostWindow.h:
217         Prefixed Win32 API calls with ::. Updated namespace name.
218
219 2011-09-23  Adam Roben  <aroben@apple.com>
220
221         Merge WebKitAPITest into TestWebKitAPI
222
223         This also means that our formerly-WebKitAPITest tests will be run on the bots!
224
225         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
226         them more idiomatic in a separate pass.
227
228         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
229         functionality (and names!)
230
231         Reviewed by Anders Carlsson.
232
233         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
234         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
235         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
236
237         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
238
239         * TestWebKitAPI/win/main.cpp:
240         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
241
242         * WebKitAPITest: Removed this directory and its contents.
243
244 2011-09-23  Adam Roben  <aroben@apple.com>
245
246         Remove two failing WebKitAPITest tests
247
248         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
249
250         Reviewed by Anders Carlsson.
251
252         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
253         MainFrameAfterClose tests.
254
255 2011-09-25  Adam Barth  <abarth@webkit.org>
256
257         Finish removing PLATFORM(BREWMP) by removing associated code
258         https://bugs.webkit.org/show_bug.cgi?id=68779
259
260         Reviewed by Sam Weinig.
261
262         * Scripts/webkitpy/common/config/build.py:
263         * waf/build/settings.py:
264
265 2011-09-21  Ai Makabi  <makabi@google.com>
266
267         Provides a simple LRU cache class in Python.
268
269         https://bugs.webkit.org/show_bug.cgi?id=67823
270
271         Reviewed by Tony Chang.
272
273         * Scripts/webkitpy/common/lru_cache.py:
274         * Scripts/webkitpy/common/lru_cache_unittest.py:
275
276 2011-09-25  Adam Barth  <abarth@webkit.org>
277
278         Remove PLATFORM(HAIKU) and associated code
279         https://bugs.webkit.org/show_bug.cgi?id=68774
280
281         Reviewed by Sam Weinig.
282
283         * Scripts/webkitpy/common/config/build.py:
284         * waf/build/settings.py:
285
286 2011-09-24  Adam Barth  <abarth@webkit.org>
287
288         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
289         https://bugs.webkit.org/show_bug.cgi?id=68767
290
291         Reviewed by Eric Seidel.
292
293         * Scripts/build-webkit:
294
295 2011-09-24  Adam Barth  <abarth@webkit.org>
296
297         Remove ENABLE(WCSS) and associated code
298         https://bugs.webkit.org/show_bug.cgi?id=68759
299
300         Reviewed by Darin Adler.
301
302         * Scripts/build-webkit:
303         * Scripts/old-run-webkit-tests:
304         * Scripts/webkitperl/features.pm:
305         (hasFeature):
306         * Scripts/webkitpy/layout_tests/port/webkit.py:
307         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
308
309 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
310
311         Fixed GTK compilation after r95878, the operator== was defined
312         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
313
314         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
315
316 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
317
318         [DRT] Include the right config file for EFL's DRT.
319         https://bugs.webkit.org/show_bug.cgi?id=67042
320
321         Reviewed by Martin Robinson.
322
323         Ports which use CMake as their buildsystem (such as the EFL one) also
324         have config.h files, but they are named differently, so include the
325         right one depending on the buildsystem being used.
326
327         * DumpRenderTree/config.h:
328
329 2011-09-23  Adam Klein  <adamk@chromium.org>
330
331         Add ENABLE_MUTATION_OBSERVERS feature flag
332         https://bugs.webkit.org/show_bug.cgi?id=68732
333
334         Reviewed by Ojan Vafai.
335
336         This flag will guard an implementation of the "Mutation Observers" proposed in
337         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
338
339         * Scripts/build-webkit:
340
341 2011-09-23  Chang Shu  <cshu@webkit.org>
342
343         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
344         https://bugs.webkit.org/show_bug.cgi?id=68556
345
346         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
347
348         Reviewed by Darin Adler.
349
350         * WebKitTestRunner/EventSenderProxy.h:
351         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
352         * WebKitTestRunner/PlatformWebView.h:
353         * WebKitTestRunner/mac/EventSenderProxy.mm:
354         (WTR::EventSenderProxy::EventSenderProxy):
355         (WTR::EventSenderProxy::leapForward):
356         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
357         (WTR::EventSenderProxy::EventSenderProxy):
358         (WTR::getMouseButton):
359         (WTR::getModifiers):
360         (WTR::EventSenderProxy::updateClickCountForButton):
361         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
362         (WTR::EventSenderProxy::mouseDown):
363         (WTR::EventSenderProxy::mouseUp):
364         (WTR::EventSenderProxy::mouseMoveTo):
365         (WTR::EventSenderProxy::leapForward):
366         (WTR::EventSenderProxy::sendOrQueueEvent):
367         (WTR::EventSenderProxy::replaySavedEvents):
368         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
369         (WTR::PlatformWebView::postEvent):
370         * WebKitTestRunner/qt/WebKitTestRunner.pro:
371
372 2011-09-23  Lei Zhang  <thestig@chromium.org>
373
374         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
375         https://bugs.webkit.org/show_bug.cgi?id=68026
376
377         Reviewed by Dirk Pranke.
378
379         * Scripts/webkitpy/layout_tests/port/chromium.py:
380
381 2011-09-23  Elliot Poger  <epoger@google.com>
382
383         update layout_tests to account for new default of use_skia=1
384         https://bugs.webkit.org/show_bug.cgi?id=68698
385
386         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
387         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
388         (Chromium-on-Mac now uses the Skia graphics library instead of
389         Core Graphics).
390
391         Also updates layout_test code to work with that change.
392
393         Reviewed by Mihai Parparita.
394
395         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
396         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
397
398 2011-09-23  Mark Rowe  <mrowe@apple.com>
399
400         Fix the build.
401         
402         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
403         the WTF namespace.
404
405 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
406
407         enable NRWT for run-webkit-tests on Lion
408         https://bugs.webkit.org/show_bug.cgi?id=68673
409
410         Reviewed by Eric Seidel.
411
412         * Scripts/run-webkit-tests:
413         (useNewRunWebKitTests):
414
415 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
416
417         Add unit test for existing StringBuilder
418         https://bugs.webkit.org/show_bug.cgi?id=67080
419
420         Reviewed by Darin Adler.
421
422         * TestWebKitAPI/TestWebKitAPI.gypi:
423         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
424         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
425         (operator<<):
426         (TestWebKitAPI::expectBuilderContent):
427         (TestWebKitAPI::expectEmpty):
428         (TestWebKitAPI::TEST):
429
430 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
431
432         [EFL] Use ewk_view to navigate in history instead of ewk_history.
433         https://bugs.webkit.org/show_bug.cgi?id=68455
434
435         Reviewed by Antonio Gomes.
436
437         BackForwardItem::invoke() was using ewk_history functions to navigate
438         in history; however, this will only call WebCore::BackForwardListImpl
439         and not move between pages at all. We now call ewk_view_navigate and
440         its siblings to make sure the navigation actually happens.
441
442         This should make tests like fast/dom/navigation-type-back-forward.html
443         stop timing out.
444
445         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
446         (BackForwardItem::invoke):
447
448 2011-09-22  Dean Jackson  <dino@apple.com>
449
450         Add ENABLE_CSS_FILTERS
451         https://bugs.webkit.org/show_bug.cgi?id=68652
452
453         Reviewed by Simon Fraser.
454
455         * Scripts/build-webkit:
456
457 2011-09-22  Anders Carlsson  <andersca@apple.com>
458
459         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
460         https://bugs.webkit.org/show_bug.cgi?id=68660
461
462         Reviewed by Adam Barth.
463
464         * WebKitTestRunner/mac/EventSenderProxy.mm:
465         (WTR::EventSenderProxy::mouseUp):
466
467 2011-09-22  Adam Roben  <aroben@apple.com>
468
469         Remove FindSafari
470
471         It isn't used or built anymore.
472
473         Fixes <http://webkit.org/b/68628>
474
475         Reviewed by Darin Adler.
476
477         * FindSafari: Removed this directory and its contents.
478
479 2011-09-22  Adam Roben  <aroben@apple.com>
480
481         Remove FindSafari from all our .sln files
482
483         It isn't used anymore, so there's no point in building it.
484
485         Part of <http://webkit.org/b/68628> Remove FindSafari
486
487         Reviewed by Steve Falkenburg.
488
489         * DumpRenderTree/DumpRenderTree.sln:
490         * WebKitTestRunner/WebKitTestRunner.sln:
491
492 2011-09-22  Adam Roben  <aroben@apple.com>
493
494         Remove all uses of FindSafari
495
496         It isn't really needed anymore.
497
498         Fixes <http://webkit.org/b/68626>.
499
500         Reviewed by Darin Adler.
501
502         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
503
504         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
505         WebKit, but now we use WebKit.exe for that.
506
507         * Scripts/webkitdirs.pm:
508         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
509         do the same thing.
510
511         (readRegistryString):
512         (writeRegistryString):
513         Moved here from old-run-webkit-tests.
514
515 2011-09-22  Adam Roben  <aroben@apple.com>
516
517         Use the "direct object" form of system() to run WebKit.exe
518
519         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
520         path to WebKit.exe.
521
522         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
523         %WEBKITOUTPUTDIR%
524
525         Reviewed by Steve Falkenburg.
526
527         * Scripts/webkitdirs.pm:
528         (runSafari):
529
530 2011-09-22  Adam Roben  <aroben@apple.com>
531
532         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
533
534         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
535         spaces in the path to the WebKit source tree
536
537         Reviewed by John Sullivan.
538
539         * Scripts/webkitdirs.pm:
540         (setupCygwinEnv):
541
542 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
543
544         [Qt] Use same DPI for application font as rest of app in DRT and WTR
545
546         QApplication will initialize the default application font based
547         on the application DPI at construction time, but we then override
548         the application DPI using QX11Info (hard-coding it to 96 for
549         consistency). This hard-coding is not reflected in the application
550         font, so we explicitly have update the font ourselves.
551
552         The 6 test results that are updated were originally produced with
553         a DPI of 75, as this is the default fallback DPI when a QFont is
554         constructed before QApplication. This was wrong, and the results
555         are updated to match a DPI of 96.
556
557         Reviewed by Csaba Osztrogonác.
558
559         * DumpRenderTree/qt/main.cpp:
560         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
561
562 2011-09-21  Anna Cavender  <annacc@chromium.org>
563
564         Update committers.py with a new contributor contact        
565         https://bugs.webkit.org/show_bug.cgi?id=68565
566
567         Reviewed by Eric Carlson.
568
569         * Scripts/webkitpy/common/config/committers.py:
570
571 2011-09-21  Chang Shu  <cshu@webkit.org>
572
573         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
574         https://bugs.webkit.org/show_bug.cgi?id=68108
575
576         This patch implements the event sender mouse events through WebKit2 UIProcess which is
577         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
578         platform as the first step so the existing code is still kept for other platforms.
579
580         Reviewed by Darin Adler.
581
582         * WebKitTestRunner/EventSenderProxy.h:
583         (WTR::EventSenderProxy::EventSenderProxy):
584         (WTR::EventSenderProxy::leapForward):
585         (WTR::EventSenderProxy::currentEventTime):
586         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
587         (WTR::EventSendingController::EventSendingController):
588         (WTR::EventSendingController::mouseDown):
589         (WTR::EventSendingController::mouseUp):
590         (WTR::EventSendingController::mouseMoveTo):
591         (WTR::EventSendingController::leapForward):
592         (WTR::EventSendingController::keyDown):
593         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
594         * WebKitTestRunner/TestController.cpp:
595         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
596         * WebKitTestRunner/mac/EventSenderProxy.mm:
597         (WTR::eventTypeForMouseButtonAndAction):
598         (WTR::operator==):
599         (WTR::EventSenderProxy::updateClickCountForButton):
600         (WTR::EventSenderProxy::mouseDown):
601         (WTR::EventSenderProxy::mouseUp):
602         (WTR::EventSenderProxy::mouseMoveTo):
603         (WTR::EventSenderProxy::keyDown):
604         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
605         (WTR::EventSenderProxy::keyDown):
606         (WTR::EventSenderProxy::mouseDown):
607         (WTR::EventSenderProxy::mouseUp):
608         (WTR::EventSenderProxy::mouseMoveTo):
609
610 2011-09-21  Dan Bernstein  <mitz@apple.com>
611
612         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
613         https://bugs.webkit.org/show_bug.cgi?id=68451
614
615         Reviewed by Darin Adler.
616
617         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
618         Objective-C classes with names not having one of a list of prefixes
619         passed on the command line.
620
621 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
622
623         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
624         https://bugs.webkit.org/show_bug.cgi?id=68206
625
626         Reviewed by Tony Chang.
627
628         * Scripts/webkitdirs.pm:
629         (determineBaseProductDir): add support for chromium-mac
630         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
631         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
632
633 2011-09-21  Adam Barth  <abarth@webkit.org>
634
635         garden-o-matic command should explain that it is starting a local server
636         https://bugs.webkit.org/show_bug.cgi?id=68486
637
638         Reviewed by Dimitri Glazkov.
639
640         In the user study, both participants didn't understand why the
641         garden-o-matic command appeared to hang.  This patch adds an
642         explaination of what's going on.  It also adds a confirmation prompt
643         before launching the browser to give the user a chance to read the
644         text.  If that's too much of a speed bump, we can iterate.
645
646         * Scripts/webkitpy/tool/commands/gardenomatic.py:
647
648 2011-09-21  Chang Shu  <cshu@webkit.org>
649
650         [Qt] Implement KeyDown function for WebKit2 EventSender.
651         https://bugs.webkit.org/show_bug.cgi?id=56485
652
653         Implement the KeyDown function on Qt platform.
654
655         Reviewed by Andreas Kling.
656
657         * WebKitTestRunner/PlatformWebView.h:
658         * WebKitTestRunner/TestController.cpp:
659         (WTR::TestController::TestController):
660         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
661         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
662         (WTR::getModifiers):
663         (WTR::EventSenderProxy::keyDown):
664         (buildModifierFlags):
665         (EventSenderProxy::keyDown):
666         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
667         (WTR::PlatformWebView::sendEvent):
668         * WebKitTestRunner/qt/WebKitTestRunner.pro:
669
670 2011-09-20  Adam Barth  <abarth@webkit.org>
671
672         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
673         https://bugs.webkit.org/show_bug.cgi?id=68496
674
675         Reviewed by Dimitri Glazkov.
676
677         This patch adds a bunch of sorting to make sure things happen in a
678         predictable order in both JavaScriptCore and V8.  We've talked before
679         about whether these two JavaScript engines should enumerate
680         dictionaries in the same order, but the consensus has been that they
681         shouldn't.  Personally, I disagree with that consensus, but such is life.
682
683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
687
688 2011-09-20  Adam Barth  <abarth@webkit.org>
689
690         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
691         https://bugs.webkit.org/show_bug.cgi?id=68495
692
693         Reviewed by Dimitri Glazkov.
694
695         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
696
697         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
698
699 2011-09-20  Eric Seidel  <eric@webkit.org>
700
701         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
702         https://bugs.webkit.org/show_bug.cgi?id=65781
703
704         Reviewed by Ryosuke Niwa.
705
706         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
707         to resolve the passed in url relative to the absolute url for the test.
708         For http tests, since the test url is an http url, we can't resolve relative
709         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
710         for resolving.
711
712         I believe this is a better approach than the on used in the Qt and Chromium DRT's
713         (which resolves the path relative to the built location of the DRT executable)
714         and we should move this new code into a shared location in a follow-up patch.
715
716         It turns out that there was a second use for pathToLocalResource, used by one
717         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
718         To support this test I made the new pathToLocalResource smart enough to map
719         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
720
721         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
722         (LayoutTestController::pathToLocalResource):
723         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
724
725 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
726
727         Need to specify a django version, instead of using default
728         https://bugs.webkit.org/show_bug.cgi?id=68398
729
730         Reviewed by Eric Seidel.
731
732         * QueueStatusServer/__init__.py:
733         * QueueStatusServer/main.py:
734
735 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
736
737         Update committers.py with a few more contributor contacts
738         https://bugs.webkit.org/show_bug.cgi?id=68487
739
740         Reviewed by Eric Seidel.
741
742         * Scripts/webkitpy/common/config/committers.py:
743
744 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
745
746         Fix webkitpy unit tests after 95547 and 95549
747         https://bugs.webkit.org/show_bug.cgi?id=68483
748
749         Reviewed by Adam Barth.
750         
751         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
752
753         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
754         parse_entries_from_file(), use StringIO and entry.reviewer_text().
755         While testing parse_latest_entry_from_file(), expect the correct
756         touched_files() list.
757
758 2011-09-20  Adam Barth  <abarth@webkit.org>
759
760         garden-o-matic makes it hard to compare images when scroll bars appear
761         https://bugs.webkit.org/show_bug.cgi?id=68482
762
763         Reviewed by Eric Seidel.
764
765         Because we autoscale image width, the images rescale if we overflow
766         vertically and get a scrollbar.  That makes it hard to compare two sets
767         of images.  This patch reserves space for the scrollbar so we won't
768         have the layout change.
769
770         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
771
772 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
773
774         Unreviewed, rolling out r95565.
775         http://trac.webkit.org/changeset/95565
776         https://bugs.webkit.org/show_bug.cgi?id=68470
777
778         Broke builds (Requested by andersca on #webkit).
779
780         * MiniBrowser/gtk/BrowserWindow.c:
781         (mouseDidMoveOverElement):
782
783 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
784
785         Get hover'ed element URL from HitTest.
786         
787         mouseDidMoveOverElement now gets the hover'ed element link using
788         WKHitTestResult API's.
789         https://bugs.webkit.org/show_bug.cgi?id=68426
790
791         Reviewed by Anders Carlsson.
792
793         * MiniBrowser/gtk/BrowserWindow.c:
794         (mouseDidMoveOverElement):
795
796 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
797
798         Changelog class should have a method to return all entries
799         https://bugs.webkit.org/show_bug.cgi?id=68399
800         
801         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
802         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
803
804         Reviewed by Ryosuke Niwa.
805
806         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
807         and adapt it to become a generator.
808         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
809
810 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
811
812         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
813         https://bugs.webkit.org/show_bug.cgi?id=51159
814
815         Permit any URL with a local scheme to set a user style sheet. Allow qrc
816         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
817         
818         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
819
820         Reviewed by Kenneth Rohde Christiansen.
821
822         * DumpRenderTree/qt/DumpRenderTree.pro:
823         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
824         * DumpRenderTree/qt/resources/user.css: Added.
825         (body):
826         * WebKitTestRunner/qt/WebKitTestRunner.pro:
827         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
828         * WebKitTestRunner/qt/resources/user.css: Added.
829         (body):
830
831 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
832
833         ChangeLogEntry class should contain a list of touched files
834         https://bugs.webkit.org/show_bug.cgi?id=68115
835
836         Reviewed by Eric Seidel.
837         
838         Add method to return the list of files touched in a ChangeLog entry.
839
840         * Scripts/webkitpy/common/checkout/changelog.py: Add
841         touched_files_regexp and touched_files() method.
842         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
843         unit tests for touched_files() method.
844
845 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
846
847         Unreviewed, rolling out r95526 and r95541.
848         http://trac.webkit.org/changeset/95526
849         http://trac.webkit.org/changeset/95541
850         https://bugs.webkit.org/show_bug.cgi?id=68443
851
852         It broke 6 tests (Requested by ossy_ on #webkit).
853
854         * DumpRenderTree/qt/main.cpp:
855         (main):
856         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
857         (WTR::activateFonts):
858
859 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
860
861         Fix patch and bug numbering in the mocktool simulation code
862         https://bugs.webkit.org/show_bug.cgi?id=68374
863
864         Reviewed by Adam Barth.
865
866         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
867         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
868         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
869         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
870         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
871         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
872         * Scripts/webkitpy/tool/commands/download_unittest.py:
873         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
874         * Scripts/webkitpy/tool/commands/queries_unittest.py:
875         * Scripts/webkitpy/tool/commands/queues_unittest.py:
876         * Scripts/webkitpy/tool/commands/queuestest.py:
877         * Scripts/webkitpy/tool/commands/upload_unittest.py:
878         * Scripts/webkitpy/tool/mocktool.py:
879         * Scripts/webkitpy/tool/steps/steps_unittest.py:
880         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
881
882 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
883
884         [Qt] Don't override default QApplication font for DRT and WTR
885
886         Revision 95526 moved the relevant code below the QApplication
887         constructor, to fix a potential crash, and that made the code
888         take effect, breaking 6 tests.
889
890         We should rely on the QWebSettings to set default fonts, and
891         this QApplication::setFont() is a relic from when we didn't
892         have that option, so we remove the code.
893
894         Reviewed by Csaba Osztrogonác.
895
896         * DumpRenderTree/qt/main.cpp:
897         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
898
899 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
900
901         WebKitTestRunner: Provide usage if run without arguments
902
903         If WTR is run without either one or more filenames, or
904         a '-' to indicate server mode, we don't need to start
905         up the test machinery. Doing so might actually crash,
906         as we'll exit the application immedeatly after anyways.
907
908         Reviewed by Simon Hausmann.
909
910         * WebKitTestRunner/TestController.cpp:
911         (WTR::TestController::initialize):
912
913 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
914
915         [Qt] Don't use QFont before initializing QApplication
916
917         Could potentially result in crash.
918
919         Reviewed by Simon Hausmann.
920
921         * DumpRenderTree/qt/main.cpp:
922         (main):
923
924 2011-09-19  Adam Barth  <abarth@webkit.org>
925
926         Always enable ENABLE(EVENTSOURCE)
927         https://bugs.webkit.org/show_bug.cgi?id=68414
928
929         Reviewed by Eric Seidel.
930
931         * Scripts/build-webkit:
932
933 2011-09-19  David Levin  <levin@chromium.org>
934
935         Sheriffbot rollout should be more intuitive.
936         https://bugs.webkit.org/show_bug.cgi?id=68415
937
938         Reviewed by Adam Barth.
939
940         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
941         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
942           and a few others cases.
943         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
944
945 2011-09-19  David Levin  <levin@chromium.org>
946
947         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
948         https://bugs.webkit.org/show_bug.cgi?id=68391
949
950         Reviewed by Darin Adler.
951
952         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
953         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
954
955 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
956
957         Style checker should not check public Qt WK2 API for parameter_name.
958         https://bugs.webkit.org/show_bug.cgi?id=68359
959
960         Reviewed by Andreas Kling.
961
962         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
963         Add an exception in the style checker to disable the check. Also added the test for it.
964
965         * Scripts/webkitpy/style/checker.py:
966         * Scripts/webkitpy/style/checker_unittest.py:
967
968 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
969
970         GTK DRT leaks memory while comparing history items
971         https://bugs.webkit.org/show_bug.cgi?id=68086
972
973         Reviewed by Martin Robinson.
974         
975         webkit_web_history_item_get_target() returns a g_strdup()'d string,
976         so memory must be freed before compareHistoryItems() returns.
977
978         * DumpRenderTree/gtk/DumpRenderTree.cpp:
979         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
980
981 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
982
983         Buildbot marks a nrwt bot red when tests are missing results
984         https://bugs.webkit.org/show_bug.cgi?id=64812
985
986         Reviewed by Ryosuke Niwa.
987
988         * Scripts/webkitpy/layout_tests/controllers/manager.py:
989         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
990
991 2011-09-19  Jessie Berlin  <jberlin@apple.com>
992
993         Sites that use history pushState or replaceState are recorded in history in Private Browsing
994         mode.
995         https://bugs.webkit.org/show_bug.cgi?id=68208
996
997         Reviewed by Brady Eidson.
998
999         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
1000         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
1001
1002         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
1003         (TestWebKitAPI::didNavigateWithNavigationData):
1004         This is a context history client callback, so it should not be called when in Private
1005         Browsing. Add a call to FAIL().
1006         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1007         This is a page load client callback that happens after the didNavigateWithNavigationData
1008         callback. End the test.
1009         (TestWebKitAPI::TEST):
1010         Enable Private Browsing and load a page that uses history.pushState.
1011
1012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1013         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
1014         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
1015         Ditto.
1016         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1017         Ditto.
1018         * TestWebKitAPI/win/copy-resources.cmd:
1019         Ditto.
1020
1021 2011-09-16  Elliot Poger  <epoger@google.com>
1022
1023         add non-CG Webkit-Mac builds to flakiness dashboard
1024         https://bugs.webkit.org/show_bug.cgi?id=68265
1025
1026         Reviewed by Adam Barth.
1027
1028         As Chromium-on-Mac approaches the switchover from Core Graphics to
1029         Skia, we need to add the Skia version to the flakiness dashboard.
1030
1031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1032         * TestResultServer/static-dashboards/builders.js:
1033         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1034
1035 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
1036
1037         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
1038         https://bugs.webkit.org/show_bug.cgi?id=68071
1039
1040         Reviewed by Adam Barth.
1041
1042         * DumpRenderTree/chromium/WebPermissions.cpp:
1043         (WebPermissions::allowImage):
1044         * DumpRenderTree/chromium/WebPermissions.h:
1045
1046 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
1047
1048         update-webkit-chromium should retry the gclient call if it fails once
1049         https://bugs.webkit.org/show_bug.cgi?id=68252
1050
1051         Reviewed by Adam Barth.
1052
1053         * Scripts/update-webkit-chromium:
1054
1055 2011-09-16  Rob Buis  <rbuis@rim.com>
1056
1057         Add Eli's rim address and change the nick.
1058
1059         * Scripts/webkitpy/common/config/committers.py:
1060
1061 2011-09-16  Anders Carlsson  <andersca@apple.com>
1062
1063         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
1064         https://bugs.webkit.org/show_bug.cgi?id=68269
1065
1066         Reviewed by Geoffrey Garen.
1067
1068         Update client function signatures.
1069
1070         * MiniBrowser/gtk/BrowserWindow.c:
1071         (browserWindowUIClientInit):
1072         * MiniBrowser/mac/BrowserWindowController.m:
1073         (mouseDidMoveOverElement):
1074         (-[BrowserWindowController awakeFromNib]):
1075         * MiniBrowser/win/BrowserView.cpp:
1076         (BrowserView::create):
1077         * WebKitTestRunner/TestController.cpp:
1078         (WTR::TestController::createOtherPage):
1079         (WTR::TestController::initialize):
1080
1081 2011-09-16  Anders Carlsson  <andersca@apple.com>
1082
1083         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
1084         https://bugs.webkit.org/show_bug.cgi?id=68266
1085
1086         Reviewed by John Sullivan.
1087
1088         * MiniBrowser/mac/BrowserWindowController.m:
1089         (mouseDidMoveOverElement):
1090
1091 2011-09-16  Vincent Scheib  <scheib@chromium.org>
1092
1093         Add Vincent Scheib to the committers list.
1094
1095         * Scripts/webkitpy/common/config/committers.py:
1096
1097 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
1098
1099         Unreviewed, rolling out r95285.
1100         http://trac.webkit.org/changeset/95285
1101         https://bugs.webkit.org/show_bug.cgi?id=68247
1102
1103         It broke a webkitpy test (Requested by ossy on #webkit).
1104
1105         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1106
1107 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1108
1109         Buildbot marks a nrwt bot red when tests are missing results
1110         https://bugs.webkit.org/show_bug.cgi?id=64812
1111
1112         Reviewed by Dirk Pranke.
1113
1114         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1115
1116 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
1117
1118         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
1119         https://bugs.webkit.org/show_bug.cgi?id=68178
1120
1121         Reviewed by Xan Lopez.
1122
1123         Add a work-around to enable WebKit2 when using build-webkit.
1124
1125         * Scripts/webkitdirs.pm:
1126         (buildAutotoolsProject): 
1127
1128 2011-09-15  James Robinson  <jamesr@chromium.org>
1129
1130         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
1131
1132         * Scripts/webkitpy/common/config/committers.py:
1133
1134 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1135
1136         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
1137         https://bugs.webkit.org/show_bug.cgi?id=68003
1138
1139         Reviewed by Adam Barth.
1140
1141         * Scripts/webkitpy/tool/mocktool.py:
1142         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1143         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1144
1145 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
1146
1147         Python version check is confusing in test-webkitpy
1148         https://bugs.webkit.org/show_bug.cgi?id=68004
1149
1150         Reviewed by Adam Barth.
1151
1152         * Scripts/test-webkitpy:
1153
1154 2011-09-15  Eric Seidel  <eric@webkit.org>
1155
1156         Reviewed by Adam Barth.
1157
1158         webkit-patch should be able to find users and add them to bugzilla groups
1159         https://bugs.webkit.org/show_bug.cgi?id=63351
1160
1161         These are both very basic commands.  But it's now possible to find
1162         all users matching a regexp, as well as add all users matching a regexp
1163         to a set of groups.
1164
1165         bugzilla.py already knew how to find users (for validate-committer-lists)
1166         but now it has the ability to modify the user records.
1167
1168         I split some of the logic out into a new EditUsersParser class
1169         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
1170
1171         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1172         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1173         * Scripts/webkitpy/tool/commands/__init__.py:
1174         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
1175         * Scripts/webkitpy/tool/commands/findusers.py: Added.
1176
1177 2011-09-15  Eric Seidel  <eric@webkit.org>
1178
1179         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
1180         https://bugs.webkit.org/show_bug.cgi?id=68182
1181
1182         Reviewed by Adam Barth.
1183
1184         * Scripts/build-webkit:
1185         * waf/build/settings.py:
1186
1187 2011-09-15  Eric Seidel  <eric@webkit.org>
1188
1189         Unreviewed.  Make contributor email look-up case-insensitive.
1190
1191         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
1192         was missing from committers.py due to case sensitivity.
1193
1194         This also includes a test expectations update to committers_unittest.py
1195         after my previous change.
1196
1197         * Scripts/webkitpy/common/config/committers.py:
1198         * Scripts/webkitpy/common/config/committers_unittest.py:
1199         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1200
1201 2011-09-15  Eric Seidel  <eric@webkit.org>
1202
1203         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
1204
1205         Add a bunch of email aliases to committers.py for regular contributors
1206         who are committing using other email addresses than they have listed in the file.
1207
1208         * Scripts/webkitpy/common/config/committers.py:
1209
1210 2011-09-15  Eric Seidel  <eric@webkit.org>
1211
1212         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
1213         https://bugs.webkit.org/show_bug.cgi?id=68022
1214
1215         Reviewed by Ryosuke Niwa.
1216
1217         * Scripts/build-webkit:
1218         * waf/build/settings.py:
1219
1220 2011-09-15  Anders Carlsson  <andersca@apple.com>
1221
1222         Fix Mac build by including config.h where needed.
1223
1224         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1225         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1226         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1227         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1228         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
1229         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1230         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1231         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1232         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1233         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
1234         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
1235         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1236         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1237         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
1238         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1239         * TestWebKitAPI/mac/main.mm:
1240
1241 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1242
1243         Let TestWebKitAPI work for chromium
1244         https://bugs.webkit.org/show_bug.cgi?id=67756
1245
1246         Reviewed by Sam Weinig.
1247
1248         * Scripts/build-api-tests:
1249         * Scripts/run-api-tests:
1250         (isSupportedPlatform):
1251         (runTest):
1252         (populateTests):
1253         * Scripts/webkitdirs.pm:
1254         (determineBaseProductDir):
1255         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1256         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1257         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1258         * TestWebKitAPI/InjectedBundleController.cpp:
1259         * TestWebKitAPI/InjectedBundleMain.cpp:
1260         * TestWebKitAPI/JavaScriptTest.cpp:
1261         * TestWebKitAPI/PlatformUtilities.cpp:
1262         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
1263         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1264         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
1265         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1266         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
1267         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
1268         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
1269         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1270         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1271         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1272         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1273         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1274         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1275         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
1276         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1277         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1278         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1279         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
1280         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1281         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1282         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1283         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
1284         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1285         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
1286         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
1287         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
1288         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1289         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
1290         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1291         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1292         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1293         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1294         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
1295         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1296         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1297         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1298         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
1299         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
1300         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1301         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1302         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1303         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1304         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
1305         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1306         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
1307         * TestWebKitAPI/TestsController.cpp:
1308         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
1309         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
1310         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1311         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1312         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1313         * TestWebKitAPI/win/main.cpp:
1314
1315 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
1316
1317         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
1318         https://bugs.webkit.org/show_bug.cgi?id=68145
1319
1320         This will allow for other classes in DumpRenderTree to reuse this functionality
1321
1322         Reviewed by David Levin.
1323
1324         * DumpRenderTree/chromium/TestShell.cpp:
1325         (normalizeLayoutTestURLInternal):
1326         (dumpHistoryItem):
1327         (TestShell::normalizeLayoutTestURL):
1328         * DumpRenderTree/chromium/TestShell.h:
1329
1330 2011-09-14  Ada Chan  <adachan@apple.com>
1331
1332         Add test for WKBundleFrameCopyWebArchive().
1333         https://bugs.webkit.org/show_bug.cgi?id=67857
1334
1335         Reviewed by Anders Carlsson.
1336
1337         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
1338         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
1339         the returned data is a valid webarchive.
1340         (TestWebKitAPI::setInjectedBundleClient):
1341         (TestWebKitAPI::didFinishLoadForFrame):
1342         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
1343         injected bundle for the webarchive and check the returned webarchive.
1344         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
1345         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
1346         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
1347         the web archive.
1348
1349         Add files to project.
1350         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
1351         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1353
1354 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
1355
1356         committers.py should support multiple IRC nicknames
1357         https://bugs.webkit.org/show_bug.cgi?id=68110
1358
1359         Reviewed by Eric Seidel.
1360
1361         Add multiple IRC nickname support to committers.py
1362
1363         * Scripts/webkitpy/common/config/committers.py:
1364         * Scripts/webkitpy/common/config/committers_unittest.py:
1365         * Scripts/webkitpy/tool/bot/irc_command.py:
1366         * Scripts/webkitpy/tool/bot/sheriff.py:
1367
1368 2011-09-14  Jon Lee  <jonlee@apple.com>
1369
1370         Implement globalFlag for WebKitTestRunner
1371         https://bugs.webkit.org/show_bug.cgi?id=68033
1372         <rdar://problem/10119204>
1373
1374         Reviewed by Sam Weinig.
1375
1376         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
1377         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1378         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
1379         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
1380         (WTR::LayoutTestController::globalFlag): simple getter
1381         (WTR::LayoutTestController::setGlobalFlag): simple setter
1382
1383 2011-09-13  Eric Seidel  <eric@webkit.org>
1384
1385         Remove ENABLE_SVG_USE as <use> is required by HTML5
1386         https://bugs.webkit.org/show_bug.cgi?id=68019
1387
1388         Reviewed by Ryosuke Niwa.
1389
1390         * Scripts/build-webkit:
1391         * waf/build/settings.py:
1392
1393 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
1394
1395         Remove Jan Erik Hanssen (added in my r95078) from the list for now
1396         since I can't confirm acceptable his committership.
1397
1398         * Scripts/webkitpy/common/config/committers.py:
1399
1400 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
1401
1402         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
1403         https://bugs.webkit.org/show_bug.cgi?id=68066
1404
1405         Reviewed by Adam Barth.
1406
1407         * DumpRenderTree/chromium/WebViewHost.cpp:
1408         * DumpRenderTree/chromium/WebViewHost.h:
1409
1410 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1411
1412         committers.py is missing some contributors
1413         https://bugs.webkit.org/show_bug.cgi?id=68059
1414
1415         Reviewed by Adam Barth.
1416
1417         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
1418
1419         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
1420
1421         * Scripts/webkitpy/common/config/committers.py:
1422
1423 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1424
1425         Fix webkit python test after r95061.
1426
1427         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1428
1429 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
1430
1431         Add myself as a contributor. No review needed.
1432
1433         * Scripts/webkitpy/common/config/committers.py:
1434
1435 2011-09-13  Adam Barth  <abarth@webkit.org>
1436
1437         garden-o-matic has unfriendly error messages when the local server is not available
1438         https://bugs.webkit.org/show_bug.cgi?id=68042
1439
1440         Reviewed by Dimitri Glazkov.
1441
1442         This patch moves us from using alert to showing the error inline in the
1443         progress dialog.
1444
1445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1450
1451 2011-09-13  Adam Barth  <abarth@webkit.org>
1452
1453         FailureGrid in garden-o-matic should link to the builder's waterfall page
1454         https://bugs.webkit.org/show_bug.cgi?id=68036
1455
1456         Reviewed by Dimitri Glazkov.
1457
1458         One of the users in the user study thought the configurations names in
1459         the failure grid would link to the underlying bots.  That makes sense,
1460         so this patch adds the behavior.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1466
1467 2011-09-13  Adam Barth  <abarth@webkit.org>
1468
1469         garden-o-matic should be able to mark failures as expected
1470         https://bugs.webkit.org/show_bug.cgi?id=68027
1471
1472         Reviewed by Dimitri Glazkov.
1473
1474         All the back-end infrastructure exists for this operation.  This patch
1475         just adds some UI to the front-end and wires that UI up to the back
1476         end.  This exact UI will likely need some more polish, but this should
1477         be a reasonable first cut.
1478
1479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1484
1485 2011-09-13  Adam Barth  <abarth@webkit.org>
1486
1487         garden-o-matic should tell you about the progress of your rebaseline
1488         https://bugs.webkit.org/show_bug.cgi?id=67967
1489
1490         Reviewed by Dimitri Glazkov.
1491
1492         This patch adds ui.MessageBox, which is a light wrapper around jQuery
1493         UI's dialog widget.  We then use ui.MessageBox to show status messages
1494         about in-progress rebaselines.  As each baseline is downloaded, the
1495         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
1496
1497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1503
1504 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
1505
1506         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
1507         https://bugs.webkit.org/show_bug.cgi?id=68024
1508
1509         Reviewed by Gustavo Noronha Silva.
1510         
1511         Using g_list_count() and g_list_nth_data() together on a loop is
1512         inneficient since they're both O(n). Iterate over lists in a saner
1513         way.
1514
1515         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1516         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
1517         iterate on it using g_list_next(). Free the list after done with it.
1518         (dumpBackForwardListForWebView): Instead of appending (which is
1519         expensive in GLists) history items and then iterating from the tail
1520         of the itemsToPrint list, prepend items and walk forwards as usual.
1521         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
1522         remove the (unneeded) viewList variable.
1523
1524 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1525
1526         Add Eric's IRC nick.
1527
1528         * Scripts/webkitpy/common/config/committers.py:
1529
1530 2011-09-13  Anders Carlsson  <andersca@apple.com>
1531
1532         Disable C++ exceptions when building with clang
1533         https://bugs.webkit.org/show_bug.cgi?id=68031
1534         <rdar://problem/9556880>
1535
1536         Reviewed by Mark Rowe.
1537
1538         * MiniBrowser/Configurations/Base.xcconfig:
1539         * TestWebKitAPI/Configurations/Base.xcconfig:
1540         * WebKitTestRunner/Configurations/Base.xcconfig:
1541
1542 2011-09-13  Ojan Vafai  <ojan@chromium.org>
1543
1544         [chromium] fix flakiness dashboard for chromium interactive tests
1545         https://bugs.webkit.org/show_bug.cgi?id=68029
1546
1547         Reviewed by Tony Chang.
1548
1549         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1550         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1551
1552 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1553
1554         Add Alice and Aryeh to the list of contributors.
1555
1556         * Scripts/webkitpy/common/config/committers.py:
1557
1558 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1559
1560         sheriffbot whois should also tell us email addresses
1561         https://bugs.webkit.org/show_bug.cgi?id=67975
1562
1563         Reviewed by Eric Seidel and David Levin.
1564
1565         Taught sheriffbot how to tell us contributor's email addresses.
1566
1567         * Scripts/webkitpy/tool/bot/irc_command.py:
1568         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1569
1570 2011-09-13  Eric Seidel  <eric@webkit.org>
1571
1572         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
1573         https://bugs.webkit.org/show_bug.cgi?id=68018
1574
1575         Reviewed by Ryosuke Niwa.
1576
1577         * Scripts/build-webkit:
1578         * waf/build/settings.py:
1579
1580 2011-09-13  Chang Shu  <cshu@webkit.org>
1581
1582         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
1583         https://bugs.webkit.org/show_bug.cgi?id=57515
1584
1585         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
1586         TestController synchronously. The latter then sends simulated event to WebKit2 module,
1587         which is synchronous, too.
1588
1589         Reviewed by Darin Adler.
1590
1591         * WebKitTestRunner/EventSenderProxy.h: Added.
1592         (WTR::EventSenderProxy::EventSenderProxy):
1593         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1594         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1595         (WTR::EventSendingController::keyDown):
1596         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1597         * WebKitTestRunner/PlatformWebView.h:
1598         (WTR::PlatformWebView::platformWindow):
1599         * WebKitTestRunner/TestController.cpp:
1600         (WTR::TestController::TestController):
1601         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1602         * WebKitTestRunner/TestController.h:
1603         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1604         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
1605         (WTR::buildModifierFlags):
1606         (WTR::EventSenderProxy::keyDown):
1607
1608 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
1609
1610         [EFL] DRT: Add DumpRenderTreeEfl.h
1611         https://bugs.webkit.org/show_bug.cgi?id=63993
1612
1613         Reviewed by Eric Seidel.
1614         
1615         This header contains some global variables used by EFL's
1616         DumpRenderTree implementation.
1617
1618         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
1619         appropriate.
1620         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
1621
1622 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
1623
1624         [EFL] Send the right key names for PageUp and PageDown.
1625         https://bugs.webkit.org/show_bug.cgi?id=67044
1626
1627         Reviewed by Kenneth Rohde Christiansen.
1628
1629         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
1630         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
1631         However, EventSender was sending "Page_Up" and "Page_Down", so tests
1632         such as editing/input/page-up-down-scrolls.html were timing out due to
1633         the right key down events not being sent.
1634
1635         * DumpRenderTree/efl/EventSender.cpp:
1636         (keyPadNameFromJSValue):
1637         (keyNameFromJSValue):
1638
1639 2011-09-12  Eric Seidel  <eric@webkit.org>
1640
1641         sheriffbot whois is case sensitive
1642         https://bugs.webkit.org/show_bug.cgi?id=67972
1643
1644         Reviewed by Adam Barth.
1645
1646         I also fixed a typo in the "More than 5 contributors" message
1647         from my previous commit.
1648
1649         * Scripts/webkitpy/common/config/committers.py:
1650         * Scripts/webkitpy/common/config/committers_unittest.py:
1651         * Scripts/webkitpy/tool/bot/irc_command.py:
1652         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1653
1654 2011-09-12  Eric Seidel  <eric@webkit.org>
1655
1656         sheriffbot whois should be smarter
1657         https://bugs.webkit.org/show_bug.cgi?id=67971
1658
1659         Reviewed by Adam Barth.
1660
1661         This makes sheriffbot whois basically grep the committers list
1662         making it much easier to find a contributor by name.
1663
1664         Unfortunately the current unittests depend on the real committers.py
1665         file, so as we add more eric's to the project, this unittest result will
1666         change.  I think that's OK for now.  We'll fix it when it breaks.
1667
1668         * Scripts/webkitpy/common/config/committers.py:
1669         * Scripts/webkitpy/tool/bot/irc_command.py:
1670         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1671
1672 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1673
1674         Unreviewed, rolling out r94976.
1675         http://trac.webkit.org/changeset/94976
1676         https://bugs.webkit.org/show_bug.cgi?id=67953
1677
1678         Broke a bunch of security/load& tests (Requested by rniwa on
1679         #webkit).
1680
1681         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1682         (LayoutTestController::pathToLocalResource):
1683
1684 2011-09-12  Eric Seidel  <eric@webkit.org>
1685
1686         Rubber-stamped by Adam Barth.
1687
1688         Remove the "the tree is burning!" warning previously shown
1689         when landing patches.  It was a dream.  But it's just noise now.
1690
1691         Some bots will require a restart to notice the removal of the option
1692         so I've left the --ignore-builders option in for now.
1693
1694         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1695         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1696         * Scripts/webkitpy/tool/commands/download.py:
1697         * Scripts/webkitpy/tool/commands/download_unittest.py:
1698         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1699         * Scripts/webkitpy/tool/steps/__init__.py:
1700         * Scripts/webkitpy/tool/steps/commit.py:
1701         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
1702         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1703
1704 2011-09-12  Eric Seidel  <eric@webkit.org>
1705
1706         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
1707         https://bugs.webkit.org/show_bug.cgi?id=65781
1708
1709         Reviewed by Ryosuke Niwa.
1710
1711         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
1712         to resolve the passed in url relative to the absolute url for the test.
1713
1714         I believe this is a better approach than the on used in the Qt and Chromium DRT's
1715         (which resolves the path relative to the built location of the DRT executable)
1716         and we should move this new code into a shared location in a follow-up patch.
1717
1718         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1719         (LayoutTestController::pathToLocalResource):
1720
1721 2011-09-12  Eric Seidel  <eric@webkit.org>
1722
1723         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1724         https://bugs.webkit.org/show_bug.cgi?id=67530
1725
1726         Reviewed by Adam Barth.
1727
1728         I believe I've fixed the bug in the original patch which prompted the rollout.
1729         The previous patch was using the wrong deadline for the initial read,
1730         subtracting time.time() twice from the deadline value.
1731
1732         * Scripts/webkitpy/layout_tests/port/webkit.py:
1733         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1734
1735 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
1736
1737         [Qt][WK2] WebKitTestRunner does not produce crash logs
1738         https://bugs.webkit.org/show_bug.cgi?id=67714
1739
1740         Reviewed by Chang Shu.
1741
1742         Added a simple way of generating backtrace on crash
1743         to the web process. The implementation is similar what
1744         we have in DRT. It depends on GNU libc functionality
1745         so it is only enabled where we are running in such an environment.
1746
1747         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1748         (WTR::printBacktrace):
1749         (WTR::crashHandler):
1750         (WTR::InjectedBundle::platformInitialize):
1751
1752 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
1753
1754         Added my IRC nick to the committers file.
1755
1756         * Scripts/webkitpy/common/config/committers.py:
1757
1758 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
1759
1760         The executable allocator makes it difficult to free individual
1761         chunks of executable memory
1762         https://bugs.webkit.org/show_bug.cgi?id=66363
1763
1764         Reviewed by Oliver Hunt.
1765         
1766         Introduced a best-fit, balanced-tree based allocator. The allocator
1767         required a balanced tree that does not allocate memory and that
1768         permits the removal of individual nodes directly (as opposed to by
1769         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
1770         Changed all references to executable code to use a reference counted
1771         handle.
1772
1773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1774         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
1775         (TestWebKitAPI::TEST_F):
1776         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
1777         (TestWebKitAPI::Pair::findExact):
1778         (TestWebKitAPI::Pair::remove):
1779         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
1780         (TestWebKitAPI::Pair::assertFoundAndRemove):
1781         (TestWebKitAPI::Pair::assertEqual):
1782         (TestWebKitAPI::Pair::assertSameValuesForKey):
1783         (TestWebKitAPI::Pair::testDriver):
1784         (TestWebKitAPI::TEST_F):
1785
1786 2011-09-10  Andy Estes  <aestes@apple.com>
1787
1788         Move myself from committers_unable_to_review to reviewers_list.
1789
1790         * Scripts/webkitpy/common/config/committers.py:
1791
1792 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
1793
1794         [wx] Unreviewed build fix. MSW build fixes.
1795
1796         * DumpRenderTree/config.h:
1797         * waf/build/wxpresets.py:
1798
1799 2011-09-10  Andreas Kling  <kling@webkit.org>
1800
1801         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
1802         https://bugs.webkit.org/show_bug.cgi?id=59328
1803
1804         Reviewed by Kenneth Rohde Christiansen.
1805
1806         * MiniBrowser/mac/BrowserWindowController.m:
1807         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
1808
1809 2011-09-10  Adam Barth  <abarth@webkit.org>
1810
1811         Build fix for Android.  DumpRenderTree is a client of the WebKit API
1812         and does not have access to notImplemented().
1813
1814         * DumpRenderTree/chromium/TestShellAndroid.cpp:
1815         (openStartupDialog):
1816
1817 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
1818
1819         Add a script to create a monolithic script-test
1820         https://bugs.webkit.org/show_bug.cgi?id=67747
1821
1822         Reviewed by Darin Adler.
1823
1824         * Scripts/make-new-script-test: Added.
1825
1826 2011-09-09  Luiz Agostini  <luiz@webkit.org>
1827
1828         Adding myself to the reviewers list.
1829
1830         * Scripts/webkitpy/common/config/committers.py:
1831
1832 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
1833
1834         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
1835         https://bugs.webkit.org/show_bug.cgi?id=67855
1836
1837         Reviewed by Dirk Pranke.
1838
1839         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
1840         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
1841
1842         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
1843
1844         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1845
1846 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
1847
1848         Add myself to committers.py
1849         https://bugs.webkit.org/show_bug.cgi?id=67853
1850
1851         Reviewed by Darin Adler.
1852
1853         * Scripts/webkitpy/common/config/committers.py:
1854
1855 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1856
1857         [Qt] Remove common.pri
1858         https://bugs.webkit.org/show_bug.cgi?id=67814
1859
1860         Reviewed by Andreas Kling.
1861
1862         * Tools.pro:
1863
1864 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1865
1866         [NRWT] the nrwt check httpd with --no-http option
1867         https://bugs.webkit.org/show_bug.cgi?id=67835
1868
1869         Reviewed by Tony Chang.
1870
1871         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1872         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1873
1874 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
1875
1876         [chromium] Implement DRT support for Android.
1877         https://bugs.webkit.org/show_bug.cgi?id=67590
1878
1879         Reviewed by Tony Chang.
1880
1881         Add 2 mechanism to make DRT interaction more robust on Android:
1882         - Send 'QUIT' to DRT to make it stop.
1883         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
1884         input commands before it starts.
1885         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
1886         and <clocale> for 'LC_ALL' to compile on Android.
1887
1888         Also change to use sigaction instead of signal for TestShellGtk.cpp,
1889         as signal() man page recommends using sigaction().
1890
1891         * DumpRenderTree/DumpRenderTree.gypi:
1892         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1893         (main):
1894         * DumpRenderTree/chromium/LayoutTestController.cpp:
1895         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
1896         (AlarmHandler):
1897         (TestShell::waitTestFinished):
1898         (platformInit):
1899         (openStartupDialog):
1900         (checkLayoutTestSystemDependencies):
1901         * DumpRenderTree/chromium/TestShellGtk.cpp:
1902         (AlarmHandler):
1903         (TestShell::waitTestFinished):
1904
1905 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
1906
1907         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
1908
1909         * waf/build/settings.py:
1910
1911 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1912
1913         Unreviewed, rolling out r94851.
1914         http://trac.webkit.org/changeset/94851
1915         https://bugs.webkit.org/show_bug.cgi?id=67847
1916
1917         It broke a webkitpy test (Requested by ossy on #webkit).
1918
1919         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1920
1921 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1922
1923         [NRWT] the nrwt check httpd with --no-http option
1924         https://bugs.webkit.org/show_bug.cgi?id=67835
1925
1926         Reviewed by Csaba Osztrogonác.
1927
1928         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1929
1930 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
1931
1932         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
1933         https://bugs.webkit.org/show_bug.cgi?id=67794
1934         <rdar://problem/9892024>
1935         
1936         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
1937
1938         Reviewed by Brady Eidson.
1939
1940         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
1941         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
1942         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
1943         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
1944             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
1945             didPerformServerRedirect.
1946
1947         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
1948         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
1949             our InjectedBundleTest.
1950         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
1951             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
1952             the request.
1953         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
1954
1955         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
1956         
1957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1958         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1959         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
1960         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
1961
1962 2011-09-08  David Levin  <levin@chromium.org>
1963
1964         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
1965         https://bugs.webkit.org/show_bug.cgi?id=67797
1966
1967         Reviewed by Eric Seidel.
1968
1969         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
1970         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
1971
1972 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
1973
1974         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
1975         https://bugs.webkit.org/show_bug.cgi?id=67723
1976
1977         Reviewed by Adam Barth.
1978
1979         * DumpRenderTree/chromium/EventSender.h:
1980         * DumpRenderTree/chromium/LayoutTestController.cpp:
1981         (LayoutTestController::LayoutTestController):
1982         (LayoutTestController::enableFixedLayoutMode):
1983         (LayoutTestController::setFixedLayoutSize):
1984         * DumpRenderTree/chromium/LayoutTestController.h:
1985
1986 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
1987
1988         Add standalone script that filters the output of build-webkit to be more human-readable
1989         https://bugs.webkit.org/show_bug.cgi?id=44081
1990
1991         Reviewed by Daniel Bates.
1992
1993         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
1994         a build script (e.g. build-webkit) and it spits out a prettier version.
1995         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
1996         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
1997
1998 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
1999
2000         Add myself to committers.py                 
2001         https://bugs.webkit.org/show_bug.cgi?id=67696
2002
2003         Reviewed by Kent Tamura.
2004
2005         * Scripts/webkitpy/common/config/committers.py:
2006
2007 2011-09-07  Adam Barth  <abarth@webkit.org>
2008
2009         rebaseline button in garden-o-matic details view should work
2010         https://bugs.webkit.org/show_bug.cgi?id=67738
2011
2012         Reviewed by Dimitri Glazkov.
2013
2014         This patch wires up the rebaseline button in garden-o-matic results
2015         details view.  The button is current per-test, so there isn't a way to
2016         rebaseline individual bots.  This is a place to start.  If we decide we
2017         want per-bot rebaselining, we'll need to think of some better UI.
2018
2019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2023
2024 2011-09-07  Eric Seidel  <eric@webkit.org>
2025
2026         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
2027         https://bugs.webkit.org/show_bug.cgi?id=67737
2028
2029         Reviewed by Adam Barth.
2030
2031         I got a little over-eager when deprecating host.port_factory in the previous commit.
2032         Turns out that Host.port_factory was already the "modern" port/factory.py
2033         it was just the Module object.  I un-deprecated the variable, and changed it from
2034         being the module to being an actual PortFactory, passing it a host object.
2035         I also taught PortFactory how to set user/executive/filesystem in the kwargs
2036         when instantiating a new Port object.
2037         This magically fixed the test_rebaseline test, since its now no longer talking
2038         to the real filesystem.
2039
2040         * Scripts/webkitpy/common/host.py:
2041         * Scripts/webkitpy/layout_tests/port/factory.py:
2042         * Scripts/webkitpy/tool/commands/queries.py:
2043         * Scripts/webkitpy/tool/mocktool.py:
2044
2045 2011-09-07  Eric Seidel  <eric@webkit.org>
2046
2047         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
2048         https://bugs.webkit.org/show_bug.cgi?id=67734
2049
2050         Reviewed by Adam Barth.
2051
2052         Right now every place that creates a Port object has to be very careful
2053         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
2054         The correct fix is for port/factory.py (which creates most port objects)
2055         to know how to pass these in automatically.  However, currently all port/factory.py
2056         functions are free functions instead of being on an object.  This patch
2057         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
2058
2059         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
2060         pass along the proper scm/user/filesystem to the Port object.
2061
2062         * Scripts/webkitpy/common/host.py:
2063         * Scripts/webkitpy/layout_tests/port/factory.py:
2064         * Scripts/webkitpy/tool/commands/queries.py:
2065         * Scripts/webkitpy/tool/mocktool.py:
2066
2067 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2068
2069         Unreviewed, rolling out r94441.
2070         http://trac.webkit.org/changeset/94441
2071         https://bugs.webkit.org/show_bug.cgi?id=67731
2072
2073         "MacEWSes are backed up due to new machines not able to reach
2074         git.webkit.org.  Disabling tests for now" (Requested by
2075         eseidel2 on #webkit).
2076
2077         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2078
2079 2011-09-07  Elliot Poger  <epoger@google.com>
2080
2081         filter test_expectations properly for chromium-mac vs chromium-cg-mac
2082         https://bugs.webkit.org/show_bug.cgi?id=67324
2083
2084         Reviewed by Dirk Pranke.
2085
2086         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2087         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2088         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2089         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2090         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2091
2092 2011-09-07  Eric Boren  <borenet@gmail.com>
2093
2094         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2095         https://bugs.webkit.org/show_bug.cgi?id=66800
2096
2097         Reviewed by Darin Fisher.
2098
2099         * DumpRenderTree/chromium/EventSender.cpp:
2100         (EventSender::sendCurrentTouchEvent):
2101
2102 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
2103
2104         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
2105         https://bugs.webkit.org/show_bug.cgi?id=67254
2106
2107         Reviewed by Csaba Osztrogonác.
2108
2109         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
2110         derived from the running location of DumpRenderTree binary.
2111
2112         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2113         (LayoutTestController::pathToLocalResource):
2114         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
2115
2116 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2117
2118         REGRESSION(r94288) build-webkit doesn't work on Symbian
2119         https://bugs.webkit.org/show_bug.cgi?id=67706
2120
2121         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
2122         (buildQMakeProject):
2123
2124 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
2125
2126         REGRESSION(r94288) build-webkit doesn't work on Windows
2127         https://bugs.webkit.org/show_bug.cgi?id=67646
2128
2129         Roll back r94655 with a small fix.
2130
2131         * Scripts/webkitdirs.pm:
2132         (buildQMakeProject):
2133
2134 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2135
2136         Unreviewed, rolling out r94635.
2137         http://trac.webkit.org/changeset/94635
2138         https://bugs.webkit.org/show_bug.cgi?id=67704
2139
2140         Linux Touch build is failing to compile this change.
2141         (Requested by loislo on #webkit).
2142
2143         * DumpRenderTree/chromium/EventSender.cpp:
2144         (EventSender::sendCurrentTouchEvent):
2145
2146 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2147
2148         Unreviewed, rolling out r94655.
2149         http://trac.webkit.org/changeset/94655
2150         https://bugs.webkit.org/show_bug.cgi?id=67703
2151
2152         It broke Leopard debug bot (Requested by ossy on #webkit).
2153
2154         * Scripts/webkitdirs.pm:
2155
2156 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2157
2158         REGRESSION(r94288) build-webkit doesn't work on Windows
2159         https://bugs.webkit.org/show_bug.cgi?id=67646
2160
2161         Reviewed by Csaba Osztrogonác.
2162
2163         * Scripts/webkitdirs.pm:
2164
2165 2011-09-06  Eric Boren  <borenet@gmail.com>
2166
2167         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
2168         https://bugs.webkit.org/show_bug.cgi?id=66800
2169
2170         Reviewed by Darin Fisher.
2171
2172         * DumpRenderTree/chromium/EventSender.cpp:
2173         (EventSender::sendCurrentTouchEvent):
2174
2175 2011-09-06  Adam Barth  <abarth@webkit.org>
2176
2177         garden-o-matic details view should having working rebaseline and next/previous buttons
2178         https://bugs.webkit.org/show_bug.cgi?id=67659
2179
2180         Reviewed by Dimitri Glazkov.
2181
2182         This patch wires up basic back/forward buttons that let you traverse
2183         through the results we're examining in the details view.  This ended up
2184         being more code than I expected, but I wanted to keep all the state
2185         information in the DOM itself.
2186
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2190
2191 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
2192
2193         fix MockFileSystem.glob(), refactor filesystem tests
2194         https://bugs.webkit.org/show_bug.cgi?id=67462
2195
2196         Reviewed by Eric Seidel.
2197
2198         In debugging why my proposed change for MockFileSystem.glob()
2199         in bug 66228 didn't work, I stumbled across two real bugs
2200         that cancelled each other out for the unit tests. I fixed those
2201         (glob shouldn't recurse into subdirs, and we weren't populating
2202         self.dirs from self.files properly).
2203
2204         I have also created a "mixin" class for tests that can be shared
2205         between the real filesystem and the mock filesystem - MockFileSystem
2206         is being used enough it needs its own tests.
2207
2208         * Scripts/webkitpy/common/system/filesystem_mock.py:
2209         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
2210         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2211
2212 2011-09-06  Anders Carlsson  <andersca@apple.com>
2213
2214         Move NPAPI headers in bridge to plugins
2215         https://bugs.webkit.org/show_bug.cgi?id=67661
2216
2217         Update forwarding headers.
2218
2219         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
2220         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
2221
2222 2011-09-06  Tony Chang  <tony@chromium.org>
2223
2224         [chromium] Check in 'build' for compiled binaries first
2225         https://bugs.webkit.org/show_bug.cgi?id=67549
2226
2227         Reviewed by Dirk Pranke.
2228
2229         I'm working on moving the windows build output to a common location
2230         rather than relative to the sln file.  Because of that, we need to
2231         check those build locations first for DumpRenderTree.exe.
2232
2233         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2234
2235 2011-09-06  Adam Barth  <abarth@webkit.org>
2236
2237         Use a hierarchial structure for the garden-o-matic results view
2238         https://bugs.webkit.org/show_bug.cgi?id=67620
2239
2240         Reviewed by Dimitri Glazkov.
2241
2242         This patch re-organizes the results view to use a hierachial structure
2243         for selection.  At the top-level are sections for each test.  Expanding
2244         the test section shows a tab selector for builders.
2245
2246         This structure prepares us for wiring up various actions to this view.
2247
2248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2249         (.):
2250         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2251         ():
2252         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2253         (.):
2254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2256         (.results-view>.toolbar):
2257         (.results-view>.toolbar ul.actions):
2258         (.results-view>.toolbar ul.actions li):
2259         (.results-grid table):
2260         (.results-grid table td, .results-view table th):
2261         (.results-grid table th):
2262         (.results-grid .text-result):
2263         (.results-grid .image-result):
2264
2265 2011-09-06  Adam Barth  <abarth@webkit.org>
2266
2267         garden-o-matic's base.probe generates spam in the JavaScript console
2268         https://bugs.webkit.org/show_bug.cgi?id=67622
2269
2270         Reviewed by Dimitri Glazkov.
2271
2272         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
2273         instead of HTMLScriptElement to test whether results exist.  This
2274         reduces the console.log spam and saves bandwidth because we can use a
2275         HEAD request instead of a GET request.
2276
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
2278
2279 2011-09-05  Adam Barth  <abarth@webkit.org>
2280
2281         Add a tab to garden-o-matic for viewing expected failures
2282         https://bugs.webkit.org/show_bug.cgi?id=67619
2283
2284         Reviewed by Dimitri Glazkov.
2285
2286         This patch adds a basic tab to garden-o-matic that shows all the tests
2287         failing on the bots, including the expected failures.  This patch
2288         mostly involves refactoring existing classes to allow new subclasses.
2289
2290         This view is useful for when gardeners mark tests as expected to fail
2291         and then rebaseline them later.
2292
2293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
2297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2300
2301 2011-09-05  Adam Barth  <abarth@webkit.org>
2302
2303         Fix global variable leak in garden-o-matic
2304         https://bugs.webkit.org/show_bug.cgi?id=67617
2305
2306         Reviewed by Dimitri Glazkov.
2307
2308         Caught by running the unit tests with noglobals turned on.
2309
2310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2311
2312 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
2313
2314         [Qt][WK2] Add pixel test support
2315         https://bugs.webkit.org/show_bug.cgi?id=66283
2316
2317         Reviewed by Andreas Kling.
2318
2319         Implemented pixel result generation by reusing the logic
2320         that we have in DumpRenderTree.
2321         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2322         (WTR::dumpImage):
2323         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2324
2325 2011-09-04  Robin Dunn  <robin@alldunn.com>
2326
2327         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
2328         https://bugs.webkit.org/show_bug.cgi?id=67577
2329
2330         Reviewed by Kevin Ollivier.
2331
2332         * waf/build/settings.py:
2333
2334 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
2335
2336         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
2337
2338         * waf/build/settings.py:
2339
2340 2011-09-03  Dan Bernstein  <mitz@apple.com>
2341
2342         32-bit build fix.
2343
2344         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2345         (TestWebKitAPI::Util::toSTD):
2346
2347 2011-09-03  Dan Bernstein  <mitz@apple.com>
2348
2349         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
2350         https://bugs.webkit.org/show_bug.cgi?id=67559
2351
2352         Reviewed by Darin Adler.
2353
2354         * DumpRenderTree/mac/DumpRenderTree.mm:
2355         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
2356         the call to it.
2357         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
2358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
2359         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
2360         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
2361         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2362         (TestWebKitAPI::Util::toSTD): Added.
2363
2364 2011-09-03  Adam Barth  <abarth@webkit.org>
2365
2366         garden-o-matic results view should have a better results selector
2367         https://bugs.webkit.org/show_bug.cgi?id=67542
2368
2369         Reviewed by Dimitri Glazkov.
2370
2371         This patch adds a basic grid-based results selector to the results
2372         view.  Currently, this grid just shows how the tests fail on the
2373         various bots.  A future patch will let you select which failure to view
2374         and to mark the failures for rebaselining.
2375
2376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2378           - Add some more basic functions for manipulating dictionaries.
2379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2382
2383 2011-09-03  Adam Barth  <abarth@webkit.org>
2384
2385         garden-o-matic results view should show Actual and Expected results for text failures
2386         https://bugs.webkit.org/show_bug.cgi?id=67536
2387
2388         Reviewed by Eric Seidel.
2389
2390         In the past, we didn't show actual and expected text results (we just
2391         showed the diff) because we didn't have the awesome six-by-two results
2392         grid.  Now that we do, we can move show these results.
2393
2394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2396           - Fixed some typos that were preventing these unit tests from running.
2397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2398         (.):
2399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2400           - Report -actual.txt and -expected.txt as possible results URLs.
2401
2402 2011-09-03  Adam Barth  <abarth@webkit.org>
2403
2404         garden-o-matic shows "ghost" failures that are already fixed
2405         https://bugs.webkit.org/show_bug.cgi?id=67535
2406
2407         Reviewed by Eric Seidel.
2408
2409         About 10% of writes fail to stick on test-results.appspot.com.  This
2410         patch causes us to fetch the full_results.json blob directly from
2411         build.chromium.org rather than relying upon AppEngine.
2412
2413         Unforuntately, we still need to get historical information from
2414         AppEngine.  That will take several patches to fix becuase I need to
2415         change the bots to write the full_results.json file to the
2416         build-specific directory in addition to the zip file.
2417
2418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2421
2422 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2423
2424         Unreviewed, rolling out r94458.
2425         http://trac.webkit.org/changeset/94458
2426         https://bugs.webkit.org/show_bug.cgi?id=67558
2427
2428         Caused appcache test to fail on various bots (Requested by
2429         rniwa on #webkit).
2430
2431         * Scripts/webkitpy/layout_tests/port/webkit.py:
2432         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2433
2434 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2435
2436         Unreviewed, rolling out r94453.
2437         http://trac.webkit.org/changeset/94453
2438         https://bugs.webkit.org/show_bug.cgi?id=67557
2439
2440         Caused appcache test to fail on various bots (Requested by
2441         rniwa on #webkit).
2442
2443         * Scripts/webkitpy/layout_tests/port/webkit.py:
2444
2445 2011-09-02  Michael Saboff  <msaboff@apple.com>
2446
2447         Add JSC:RegExp functional tests
2448         https://bugs.webkit.org/show_bug.cgi?id=67339
2449
2450         New perl script to build JavaScriptCore and run the RegExp tests.
2451
2452         Reviewed by Gavin Barraclough.
2453
2454         * Scripts/run-regexp-tests: Added.
2455
2456 2011-09-02  Michael Saboff  <msaboff@apple.com>
2457
2458         Add JSC:RegExp functional tests
2459         https://bugs.webkit.org/show_bug.cgi?id=67339
2460
2461         New perl script to build JavaScriptCore and run the RegExp tests.
2462
2463         Reviewed by Gavin Barraclough.
2464
2465         * Scripts/run-regexp-tests: Added.
2466
2467 2011-09-02  Eric Seidel  <eric@webkit.org>
2468
2469         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2470         https://bugs.webkit.org/show_bug.cgi?id=67530
2471
2472         Unreviewed.  Fixing typo from previous commit.
2473
2474         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
2475         which exercises the code I previously made a typo in.
2476
2477         * Scripts/webkitpy/layout_tests/port/webkit.py:
2478         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2479
2480 2011-09-02  Eric Seidel  <eric@webkit.org>
2481
2482         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
2483         https://bugs.webkit.org/show_bug.cgi?id=67530
2484
2485         Reviewed by Adam Barth.
2486
2487         No functional change, just reshuffling code.
2488
2489         * Scripts/webkitpy/layout_tests/port/webkit.py:
2490
2491 2011-09-02  Darin Adler  <darin@apple.com>
2492
2493         Added Subversion ignore for .pyc generated files.
2494
2495         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
2496         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
2497         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
2498
2499 2011-09-02  Adam Barth  <abarth@webkit.org>
2500
2501         Enable testing on mac-ews
2502         https://bugs.webkit.org/show_bug.cgi?id=67505
2503
2504         Reviewed by Eric Seidel.
2505
2506         This patch enables testing on the Mac EWS, which should help
2507         contributors not turn the Mac bots red.
2508
2509         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2510
2511 2011-09-01  Beth Dakin  <bdakin@apple.com>
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=67451
2514         Add a test for going back to a cached page after changing the device scale factor
2515
2516         Reviewed by Adam Roben.
2517
2518         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
2519         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2520         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
2521         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2522         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
2523         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
2524         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
2525         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
2526         (TestWebKitAPI::TEST_F):
2527
2528         Added new function to WebKitAgnosticTest to goBack. Separated 
2529         waitForLoadToFinish() into its own function (instead of being a part of 
2530         loadAndWaitUntilFinished()) so that it can be called from goBack as 
2531         well. Also added initializeView() so we can set the cache model.
2532         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
2533         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
2534         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2535         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
2536         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
2537         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2538         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
2539         (TestWebKitAPI::WebKitAgnosticTest::goBack):
2540         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
2541
2542 2011-09-02  Anders Carlsson  <andersca@apple.com>
2543
2544         Build fix.
2545
2546         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
2547         (PrivateBrowsing::ScriptableObject::pluginTest):
2548
2549 2011-09-02  Anders Carlsson  <andersca@apple.com>
2550
2551         Move private browsing test to a PluginTest subclass
2552         https://bugs.webkit.org/show_bug.cgi?id=67498
2553
2554         Reviewed by Darin Adler.
2555
2556         * DumpRenderTree/DumpRenderTree.gypi:
2557         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2558         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2559         (pluginGetProperty):
2560         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2561         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2562         (PluginTest::NPP_SetValue):
2563         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2564         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
2565         (PrivateBrowsing::PrivateBrowsing):
2566         (PrivateBrowsing::privateBrowsingEnabled):
2567         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
2568         (PrivateBrowsing::ScriptableObject::hasProperty):
2569         (PrivateBrowsing::ScriptableObject::getProperty):
2570         (PrivateBrowsing::ScriptableObject::pluginTest):
2571         (PrivateBrowsing::NPP_New):
2572         (PrivateBrowsing::NPP_GetValue):
2573         (PrivateBrowsing::NPP_SetValue):
2574         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2575         (NPP_New):
2576         (NPP_SetValue):
2577         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2578         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2579         * GNUmakefile.am:
2580
2581 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
2582
2583         [Qt] Build dependency problems
2584         https://bugs.webkit.org/show_bug.cgi?id=38054
2585
2586         Trivial fix after r94288.
2587
2588         Rubber-stamped by Andras Becsi.
2589
2590         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
2591         (buildQMakeProject):
2592
2593 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
2594
2595         Remove my old e-mail address and add my new one.
2596
2597         Rubber-stamped by Tor Arne Vestbø.
2598
2599         * Scripts/webkitpy/common/config/committers.py:
2600
2601 2011-09-02  Philippe Normand  <pnormand@igalia.com>
2602
2603         [GTK] run-gtk-tests leaves a zombie Xvfb process
2604         https://bugs.webkit.org/show_bug.cgi?id=67389
2605
2606         Reviewed by Martin Robinson.
2607
2608         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
2609         child process instead of doing shell redirection.
2610
2611 2011-09-01  Mark Rowe  <mrowe@apple.com>
2612
2613         Fix the build by adding some more missing return types.
2614
2615         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2616         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
2617
2618 2011-09-01  Eric Seidel  <eric@webkit.org>
2619
2620         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
2621         https://bugs.webkit.org/show_bug.cgi?id=66228
2622
2623         Reviewed by Dirk Pranke.
2624
2625         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
2626         The LeaksViewer tool globs for all *-leaks.txt files.
2627         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
2628
2629         In order to test this I had to fix a limitation in our MockFileSystem.glob
2630         method.  However, doing so uncovered a typo and bug in the integration tests.
2631         I've disabled the offending integration tests.
2632
2633         * Scripts/webkitpy/common/system/filesystem_mock.py:
2634         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
2635         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
2636
2637 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
2638
2639         Adds a LayoutTestController method to make it possible to test
2640         starting speech input via an API call.
2641         https://bugs.webkit.org/show_bug.cgi?id=60170
2642
2643         Reviewed by Dimitri Glazkov.
2644
2645         * DumpRenderTree/LayoutTestController.h:
2646         * DumpRenderTree/chromium/LayoutTestController.cpp:
2647         (LayoutTestController::LayoutTestController):
2648         (LayoutTestController::startSpeechInput):
2649         * DumpRenderTree/chromium/LayoutTestController.h:
2650         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2651         (LayoutTestController::startSpeechInput):
2652         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2653         (LayoutTestController::startSpeechInput):
2654         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2655         (LayoutTestController::startSpeechInput):
2656         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2657         (LayoutTestController::startSpeechInput):
2658         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2659         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2660         (LayoutTestController::startSpeechInput):
2661         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2662         (LayoutTestController::startSpeechInput):
2663
2664 2011-09-01  Tim Horton  <hortont424@gmail.com>
2665
2666         Fix TestWebKitAPI build on clang-2.0
2667
2668         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2669
2670 2011-09-01  Adam Barth  <abarth@webkit.org>
2671
2672         Remove unused "extension" parameter from rebaseline gardeningserver handler
2673         https://bugs.webkit.org/show_bug.cgi?id=67384
2674
2675         Reviewed by James Robinson.
2676
2677         This parameter hasn't done anything in a while.
2678
2679         * Scripts/webkitpy/tool/commands/rebaseline.py:
2680         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2681         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2682
2683 2011-09-01  Eric Seidel  <eric@webkit.org>
2684
2685         Unreviewed.
2686
2687         Fix a typo in unittests.  Unfortunately fixing it
2688         caused several assertions.  Just disabling the test
2689         instead, since it was providing no value before due to the typo.
2690
2691         * Scripts/webkitpy/layout_tests/port/test.py:
2692
2693 2011-09-01  Adam Barth  <abarth@webkit.org>
2694
2695         Add a "rebaseline" button to the garden-o-matic summary page
2696         https://bugs.webkit.org/show_bug.cgi?id=67382
2697
2698         Reviewed by Dimitri Glazkov.
2699
2700         As much as we might wish folks to not rebaseline entire test groups at
2701         once, the truth is that doing so is a common operation.  Adding a
2702         button for this operation is likely to make folks happy.
2703
2704         This patch also cleans up a bunch of plumbing surrounding failureInfo
2705         objects.
2706
2707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2711         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2712         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2713         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2714         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2716         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2717
2718 2011-09-01  Adam Barth  <abarth@webkit.org>
2719
2720         garden-o-matic should let the gardener assign blame for a group of test failures
2721         https://bugs.webkit.org/show_bug.cgi?id=67379
2722
2723         Reviewed by Dimitri Glazkov.
2724
2725         If a group of test failures has a large revision range, the gardener
2726         might wish to blame a specific revision for the failure.  Currently,
2727         this only effect of assigning blame in this way is to hide the other
2728         suspect commits.
2729
2730         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2732         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2733
2734 2011-09-01  Adam Barth  <abarth@webkit.org>
2735
2736         Hide garden-o-matic failure table until hover
2737         https://bugs.webkit.org/show_bug.cgi?id=67376
2738
2739         Reviewed by Dimitri Glazkov.
2740
2741         This patch removes the failure table for build failures (because it
2742         does not make sense) and hides the failure table for test groups until
2743         the user hovers over the test failure block, reducing visual noise.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2748
2749 2011-09-01  Adam Barth  <abarth@webkit.org>
2750
2751         Switch garden-o-matic from commitData.title to commitData.summary
2752         https://bugs.webkit.org/show_bug.cgi?id=67375
2753
2754         Reviewed by Dimitri Glazkov.
2755
2756         commitData.title is a string provided by Trac, which isn't great in all
2757         cases.  commitData.summary is my attempt to find the most important
2758         one-line summary of the commit.  This patch switches garden-o-matic
2759         over to summary.
2760
2761         Also, this patch tweaks a bunch of CSS to tighten up the summary page
2762         and reduce visual noise.
2763
2764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
2767
2768 2011-09-01  Adam Barth  <abarth@webkit.org>
2769
2770         Group failing tests in garden-o-matic if there are more than three in a folder
2771         https://bugs.webkit.org/show_bug.cgi?id=67373
2772
2773         Reviewed by Dimitri Glazkov.
2774
2775         Sometimes a failure will cause many tests in a given directory to fail.
2776         When that happens, it's better to list the directory as a single item
2777         (with a count) rather than spamming all the test names.
2778
2779         (This patch also updates a bunch of unit test expected results after my last commit.)
2780
2781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2786
2787 2011-09-01  Adam Barth  <abarth@webkit.org>
2788
2789         Lower the visual noise from the failing builders display
2790         https://bugs.webkit.org/show_bug.cgi?id=67369
2791
2792         Reviewed by Dimitri Glazkov.
2793
2794         This patch ensures that the "Building" row in the failing builders
2795         display is always last and dims it by 50% to reduce visual noise.  This
2796         lets the gardener focus on the actual failures.
2797
2798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2800         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
2801
2802 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2803
2804         [Qt] Build dependency problems
2805         https://bugs.webkit.org/show_bug.cgi?id=38054
2806
2807         Make clean build after the defines are changed.
2808
2809         Reviewed by Csaba Osztrogonác.
2810
2811         * Scripts/webkitdirs.pm:
2812         (buildQMakeProject):
2813
2814 2011-08-31  Adam Barth  <abarth@webkit.org>
2815
2816         Move DumpRenderTree to WebKitPlatformSupport
2817         https://bugs.webkit.org/show_bug.cgi?id=67331
2818
2819         Reviewed by Darin Fisher.
2820
2821         This patch update DumpRenderTree to account for the WebKitClient =>
2822         WebKitPlatformSupport rename.
2823
2824         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2825         (NotificationPresenter::show):
2826         * DumpRenderTree/chromium/Task.cpp:
2827         (postTask):
2828
2829 2011-08-31  Eric Seidel  <eric@webkit.org>
2830
2831         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
2832         https://bugs.webkit.org/show_bug.cgi?id=67314
2833
2834         Reviewed by Adam Barth.
2835
2836         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
2837         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
2838         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
2839
2840         I also moved a bunch of code into dashboard.css which belonged there.
2841
2842         * QueueStatusServer/handlers/activebots.py: Added.
2843         * QueueStatusServer/main.py:
2844         * QueueStatusServer/stylesheets/dashboard.css:
2845         (.queue_bubble):
2846         (.queue_name):
2847         (.last_heard_from):
2848         (.status_text):
2849         (.alive):
2850         (.behind):
2851         (.dead):
2852         * QueueStatusServer/templates/activebots.html: Added.
2853         * QueueStatusServer/templates/dashboard.html:
2854         * QueueStatusServer/templates/recentstatus.html:
2855
2856 2011-08-31  Oliver Hunt  <oliver@apple.com>
2857
2858         Move CheckedArithmeticOperations.cpp to the intended location
2859
2860         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2861         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
2862
2863 2011-08-31  Elliot Poger  <epoger@google.com>
2864
2865         add unittest to validate the complete set of Chromium configurations
2866         https://bugs.webkit.org/show_bug.cgi?id=67211
2867
2868         Reviewed by Adam Barth.
2869
2870         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2871
2872 2011-08-31  Nico Weber  <thakis@chromium.org>
2873
2874         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
2875         https://bugs.webkit.org/show_bug.cgi?id=67297
2876
2877         Reviewed by Tony Chang.
2878
2879         Explicitly disable smooth scrolling in chromium's DRT.
2880
2881         * DumpRenderTree/chromium/WebPreferences.cpp:
2882         (WebPreferences::applyTo):
2883
2884 2011-08-31  Oliver Hunt  <oliver@apple.com>
2885
2886         Add Checked<> tests to windows build
2887
2888         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2889
2890 2011-08-30  Oliver Hunt  <oliver@apple.com>
2891
2892         Add support for checked arithmetic
2893         https://bugs.webkit.org/show_bug.cgi?id=67095
2894
2895         Reviewed by Sam Weinig.
2896
2897         Add test cases for Checked<>
2898
2899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2900         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
2901
2902 2011-08-31  Adam Barth  <abarth@webkit.org>
2903
2904         Move summary.html to garden-o-matic.html.
2905
2906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
2907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
2908         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
2909         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
2910
2911 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
2912
2913         [chromium] DRT linux should pass nativeKeyCode to plugins
2914         https://bugs.webkit.org/show_bug.cgi?id=66679
2915
2916         Reviewed by Tony Chang.
2917
2918         * DumpRenderTree/chromium/EventSender.cpp:
2919         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
2920         (simulated) nativeKeyCode for the given input keyboard code.
2921
2922 2011-08-31  Adam Barth  <abarth@webkit.org>
2923
2924         Tighen up UI for garden-o-matic tab strip
2925         https://bugs.webkit.org/show_bug.cgi?id=67266
2926
2927         Reviewed by Dimitri Glazkov.
2928
2929         This patch add CSS to move the tab strip to the edges of the page and
2930         to remove some gratuitous border-radius.
2931
2932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2934
2935 2011-08-31  Adam Barth  <abarth@webkit.org>
2936
2937         garden-o-matic results view shouldn't be horrifically ugly
2938         https://bugs.webkit.org/show_bug.cgi?id=67264
2939
2940         Reviewed by Dimitri Glazkov.
2941
2942         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
2943
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2947
2948 2011-08-31  Adam Barth  <abarth@webkit.org>
2949
2950         garden-o-matic needs a tabstrip
2951         https://bugs.webkit.org/show_bug.cgi?id=67263
2952
2953         Reviewed by Dimitri Glazkov.
2954
2955         This patch adds a basic tabstrip to garden-o-matic.  The results
2956         details view now opens in the "Results" tab, and the user can flip back
2957         and forth between the Summary and the Results tab quickly.  There's
2958         also a stub for a "Commits" tab, which is disabled.
2959
2960         This patch isn't the most beautiful in the world, but it gets the ball
2961         rolling on a multi-modal UI.
2962
2963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2968
2969 2011-08-31  Ai Makabi  <makabi@google.com>
2970
2971         Extract reference links from reftest test file.
2972         https://bugs.webkit.org/show_bug.cgi?id=66838
2973
2974         Reviewed by Shinichiro Hamaji.
2975
2976         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
2977         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
2978         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
2979
2980 2011-08-03  Philippe Normand  <pnormand@igalia.com>
2981
2982         [webkitpy] missing log import in common/net/resultsjsonparser.py
2983         https://bugs.webkit.org/show_bug.cgi?id=65606
2984
2985         Reviewed by Martin Robinson.
2986
2987         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
2988
2989 2011-08-30  Philippe Normand  <pnormand@igalia.com>
2990
2991         [stylechecker] complains about NULL usage in some gst_structure_ calls
2992         https://bugs.webkit.org/show_bug.cgi?id=67194
2993
2994         Reviewed by Martin Robinson.
2995
2996         Don't warn about NULL in some gst_structure_ calls. 0 can't be
2997         used for these, a proper sentinel is required.
2998
2999         * Scripts/webkitpy/style/checkers/cpp.py:
3000         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3001
3002 2011-08-30  Adam Barth  <abarth@webkit.org>
3003
3004         Remove old-style UI from garden-o-matic
3005         https://bugs.webkit.org/show_bug.cgi?id=67257
3006
3007         Reviewed by Dimitri Glazkov.
3008
3009         This code is nowhere near as awesome as the new hotness.  Let's remove
3010         it so it doesn't weigh us down.
3011
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
3018
3019 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3020
3021         [WebSocket] update pywebsocket to 0.6b5.
3022         https://bugs.webkit.org/show_bug.cgi?id=66924
3023
3024         Reviewed by Kent Tamura.
3025
3026         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3027         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
3028         0.6b3 or later supports a closing handshake handler and it is useful to
3029         verify client's closing handshake implementation.
3030         0.6b4 supports AbortedByUserException. It is useful to eliminate
3031         unnecessary server warning messages on intended abnormal closures.
3032         0.6b5 supports Python 2.5.1 or Mac 10.5.
3033
3034         * Scripts/webkitpy/thirdparty/__init__.py:
3035         Update download URL and directory path.
3036
3037 2011-08-30  Dan Bernstein  <mitz@apple.com>
3038
3039         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
3040         https://bugs.webkit.org/show_bug.cgi?id=67230
3041
3042         Reviewed by Darin Adler.
3043
3044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3045         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
3046         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
3047         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
3048         (TestWebKitAPI::TEST):
3049
3050 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
3051
3052         Add MediaSource API to HTMLMediaElement
3053         https://bugs.webkit.org/show_bug.cgi?id=64731
3054
3055         Reviewed by Eric Carlson.
3056
3057         * Scripts/build-webkit:
3058
3059 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3060
3061         Emit last progress notification before calling dispatchDidFinishLoad
3062         https://bugs.webkit.org/show_bug.cgi?id=28851
3063
3064         Reviewed by Adam Barth.
3065
3066         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
3067         Chromium and GTK ports. The first two were simple changes.
3068
3069         Some refactoring was needed in GTK port to assure that the dumps are emitted
3070         correctly and the processing after the page load finished is in the right place.
3071
3072         To detect the load finished, we use the callback for the "load-status" notifier
3073         signal of the top loading frame. And we use the deprecated "load-finished" signal
3074         for dumping (if enabled) the progress finished expected output.
3075
3076         * DumpRenderTree/LayoutTestController.cpp:
3077         (LayoutTestController::LayoutTestController):
3078         (dumpProgressFinishedCallbackCallback):
3079         (LayoutTestController::staticFunctions):
3080         * DumpRenderTree/LayoutTestController.h:
3081         (LayoutTestController::dumpProgressFinishedCallback):
3082         (LayoutTestController::setDumpProgressFinishedCallback):
3083         * DumpRenderTree/chromium/LayoutTestController.cpp:
3084         (LayoutTestController::LayoutTestController):
3085         (LayoutTestController::dumpProgressFinishedCallback):
3086         (LayoutTestController::reset):
3087         * DumpRenderTree/chromium/LayoutTestController.h:
3088         (LayoutTestController::shouldDumpProgressFinishedCallback):
3089         (LayoutTestController::setShouldDumpProgressFinishedCallback):
3090         * DumpRenderTree/chromium/WebViewHost.cpp:
3091         (WebViewHost::didStopLoading):
3092         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3093         (webViewLoadFinished):
3094         (topLoadingFrameLoadFinished):
3095         (webFrameLoadStatusNotified):
3096         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3097         (LayoutTestController::reset):
3098         (LayoutTestController::dumpProgressFinishedCallback):
3099         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3100
3101 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
3102
3103         JavaScriptCore does not have a good mechanism for performance
3104         regression testing
3105         https://bugs.webkit.org/show_bug.cgi?id=67177
3106
3107         Reviewed by Darin Adler.
3108         
3109         Added a new script, which allows for testing one, two, or more VMs
3110         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
3111         are interleaved at random to minimize systematics.  The results
3112         that bencher prints includes all possible relevant information about
3113         how bencher was invoked.  Bencher can be easily used to measure
3114         performance changes down to fractions of a percent.
3115         
3116         Bencher also includes experimental support for running benchmarks in
3117         a DumpRenderTree release build.  This works in SunSpider and V8, but
3118         not yet in Kraken.  Running benchmarks in DumpRenderTree more
3119         closely mimics the performance when running in browser.
3120
3121         * Scripts/bencher: Added.
3122
3123 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
3124
3125         DumpRenderTree should begin each test with an empty cookie store
3126         https://bugs.webkit.org/show_bug.cgi?id=63545
3127         <rdar://problem/5666907>
3128
3129         Reviewed by Darin Adler.
3130
3131         * DumpRenderTree/mac/DumpRenderTree.mm:
3132         (resetDefaultsToConsistentValues):
3133         (setDefaultsToConsistentValuesForTesting):
3134         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3135         (LayoutTestController::setAlwaysAcceptCookies):
3136         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3137         (WTR::InjectedBundle::beginTesting):
3138         Use new SPIs to manipulate sessions.
3139
3140 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
3141
3142         Unreviewed, rolling out r94055 and r94057.
3143         http://trac.webkit.org/changeset/94055
3144         http://trac.webkit.org/changeset/94057
3145         https://bugs.webkit.org/show_bug.cgi?id=67191
3146
3147         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
3148
3149         * Scripts/webkitpy/thirdparty/__init__.py:
3150
3151 2011-08-30  Adam Barth  <abarth@webkit.org>
3152
3153         Chromium Android should not be a core builder
3154         https://bugs.webkit.org/show_bug.cgi?id=67184
3155
3156         Reviewed by Ryosuke Niwa.
3157
3158         This bot hasn't been consistently green yet because it has never actually run!
3159
3160         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3161         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3162
3163 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
3164
3165         [WebSocket] update pywebsocket to 0.6b4.
3166         https://bugs.webkit.org/show_bug.cgi?id=66924
3167
3168         Reviewed by Kent Tamura.
3169
3170         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
3171         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
3172         0.6b3 or later supports a closing handshake handler and it is useful to
3173         verify client's closing handshake implementation.
3174         0.6b4 supports AbortedByUserException. It is useful to eliminate
3175         unnecessary server warning messages on intended abnormal closures.
3176
3177         * Scripts/webkitpy/thirdparty/__init__.py:
3178         Update download URL and directory path.
3179
3180 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
3181
3182         sheriffbot "usage" help statements are wrong
3183         https://bugs.webkit.org/show_bug.cgi?id=67170
3184
3185         Reviewed by Adam Barth.
3186
3187         * Scripts/webkitpy/tool/bot/irc_command.py:
3188         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3189         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3190
3191 2011-08-29  Adam Barth  <abarth@webkit.org>
3192
3193         Add support for chomium-mac (non-CoreGraphics) baselines
3194         https://bugs.webkit.org/show_bug.cgi?id=67163
3195
3196         Reviewed by Eric Seidel.
3197
3198         This patch teaches the non-CG chromium-mac bots to look at non-CG
3199         baselines.  However, the patch still leaves CG as the default set of
3200         baselines.
3201
3202         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3203         * Scripts/webkitpy/common/config/build.py:
3204         * Scripts/webkitpy/common/config/build_unittest.py:
3205         * Scripts/webkitpy/layout_tests/port/builders.py:
3206         * Scripts/webkitpy/layout_tests/port/chromium.py:
3207         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3208         * Scripts/webkitpy/layout_tests/port/factory.py:
3209         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3210         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3211         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3212         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3213
3214 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
3215
3216         Small fix in chromium port of new-run-webkit-tests.
3217         https://bugs.webkit.org/show_bug.cgi?id=67078
3218
3219         Reviewed by Dirk Pranke.
3220
3221         * Scripts/webkitpy/layout_tests/port/chromium.py:
3222
3223 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3224
3225         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
3226         r93999.
3227         http://trac.webkit.org/changeset/93987
3228         http://trac.webkit.org/changeset/93992
3229         http://trac.webkit.org/changeset/93995
3230         http://trac.webkit.org/changeset/93998
3231         http://trac.webkit.org/changeset/93999
3232         https://bugs.webkit.org/show_bug.cgi?id=67147
3233
3234         Many failing tests (Requested by ap on #webkit).
3235
3236         * DumpRenderTree/mac/DumpRenderTree.mm:
3237         (setDefaultsToConsistentValuesForTesting):
3238         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3239         (WTR::InjectedBundle::beginTesting):
3240
3241 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
3242
3243         DumpRenderTree should begin each test with an empty cookie store
3244         https://bugs.webkit.org/show_bug.cgi?id=63545
3245         <rdar://problem/5666907>
3246
3247         Reviewed by Darin Adler.
3248
3249         * DumpRenderTree/mac/DumpRenderTree.mm:
3250         (setDefaultsToConsistentValuesForTesting):
3251         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3252         (WTR::InjectedBundle::beginTesting):
3253         Tell WebCore to use a temporary session, starting with a clean cookie store.
3254
3255 2011-08-23  Chris Marrin  <cmarrin@apple.com>
3256
3257         [mac] requestAnimationFrame support for mac port
3258         https://bugs.webkit.org/show_bug.cgi?id=59146
3259
3260         Reviewed by Simon Fraser.
3261
3262         Add support for request-animation-callback flag
3263
3264         * Scripts/build-webkit:
3265
3266 2011-08-27  Peter Beverloo  <peter@chromium.org>
3267
3268         Add a build bot for Chromium with OS(ANDROID)
3269         https://bugs.webkit.org/show_bug.cgi?id=66687
3270
3271         Reviewed by Adam Barth.
3272
3273         * BuildSlaveSupport/build.webkit.org-config/config.json:
3274
3275 2011-08-27  Peter Beverloo  <peter@chromium.org>
3276
3277         Update the master build bot configuration script to properly
3278         deal with the --chromium-android switch.
3279         https://bugs.webkit.org/show_bug.cgi?id=66687
3280
3281         The --chromium-android switch is needed when running
3282         update-webkit-chromium and build-webkit, as it'll tell the
3283         scripts to pull in the right dependencies and cross-compile
3284         WebKit using the Android NDK.
3285
3286         Reviewed by Adam Barth.
3287
3288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3289
3290 2011-08-27  Peter Beverloo  <peter@chromium.org>
3291
3292         Teach the update and build scripts how to handle dependencies
3293         and cross-compiling rules for the Chromium port on OS(ANDROID).
3294         https://bugs.webkit.org/show_bug.cgi?id=66687
3295
3296         Reviewed by Adam Barth.
3297
3298         * Scripts/build-webkit:
3299         * Scripts/update-webkit:
3300         * Scripts/update-webkit-chromium:
3301         * Scripts/webkitdirs.pm:
3302         (argumentsForConfiguration):
3303         (isChromium):
3304         (isChromiumAndroid):
3305         (determineIsChromiumAndroid):
3306         (buildChromium):
3307
3308 2011-08-26  Adam Barth  <abarth@webkit.org>
3309
3310         garden-o-matic should let me know that I need to run the local server
3311         https://bugs.webkit.org/show_bug.cgi?id=66985
3312
3313         Reviewed by Dimitri Glazkov.
3314
3315         The patch triggers an alert dialog whenever the user tries to use a
3316         feature that requires the local server.
3317
3318         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
3321
3322 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3323
3324         garden-o-matic summary view should have pretty commit data information.
3325         https://bugs.webkit.org/show_bug.cgi?id=67069
3326
3327         Reviewed by Adam Barth.
3328
3329         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
3330         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
3332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
3333
3334 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3335
3336         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
3337         https://bugs.webkit.org/show_bug.cgi?id=67066
3338
3339         Reviewed by Adam Barth.
3340
3341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
3342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3343
3344 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
3345
3346         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
3347         https://bugs.webkit.org/show_bug.cgi?id=67041
3348
3349         Reviewed by Martin Robinson.
3350
3351         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
3352         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
3353         when the GTK+ port was being built.
3354
3355         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
3356
3357 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
3358
3359         Clean up and line up layout in garden-o-matic summary view.
3360         https://bugs.webkit.org/show_bug.cgi?id=67057
3361
3362         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
3363         2) Rearranged DOM structure a bit to accommodate recent changes;
3364         3) Added minimal CSS to line things up.
3365
3366         Reviewed by Adam Barth.
3367
3368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
3369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
3371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
3372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
3373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
3374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
3375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
3376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
3377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3378
3379 2011-08-26  Alice Liu  <alice.liu@apple.com>
3380
3381         https://bugs.webkit.org/show_bug.cgi?id=66823
3382         Add the request info to the WebPageProxy::CreateNewPage message
3383
3384         Reviewed by Anders Carlsson.
3385
3386         Update function declarations with additional parameter:
3387         * MiniBrowser/gtk/BrowserWindow.c:
3388         (createNewPage):
3389         * MiniBrowser/mac/BrowserWindowController.m:
3390         (createNewPage):
3391         * MiniBrowser/win/BrowserView.cpp:
3392         (createNewPage):
3393         * WebKitTestRunner/TestController.cpp:
3394         (WTR::TestController::createOtherPage):
3395         * WebKitTestRunner/TestController.h:
3396
3397 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
3398
3399         Make show-pretty-diff work on linux
3400         https://bugs.webkit.org/show_bug.cgi?id=67017
3401
3402         Reviewed by Adam Barth.
3403
3404         * Scripts/show-pretty-diff:
3405
3406 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3407
3408         Reorganize garden-o-matic CSS files to match JS-built views.
3409         https://bugs.webkit.org/show_bug.cgi?id=66998
3410
3411         Reviewed by Adam Barth.
3412
3413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
3414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
3415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
3417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
3419
3420 2011-08-25  Adam Barth  <abarth@webkit.org>
3421
3422         garden-o-matic should be able to roll out patches
3423         https://bugs.webkit.org/show_bug.cgi?id=66982
3424
3425         Reviewed by Dimitri Glazkov.
3426
3427         This patch just wires the rollout event through the controller to the
3428         local server, which is already set up to perform rollouts.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3434
3435 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3436
3437         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
3438         https://bugs.webkit.org/show_bug.cgi?id=66951
3439
3440         Reviewed by Andreas Kling.
3441
3442         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
3443         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
3444
3445         * MiniBrowser/qt/BrowserView.cpp:
3446         (BrowserView::resizeEvent):
3447
3448 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3449
3450         garden-o-matic summary view should provide information on builders still in flight.
3451         https://bugs.webkit.org/show_bug.cgi?id=66992
3452
3453         Reviewed by Adam Barth.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
3459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
3460
3461 2011-08-25  Adam Barth  <abarth@webkit.org>
3462
3463         webkit-patch rebaseline-expectations don't work when run outside the root
3464         https://bugs.webkit.org/show_bug.cgi?id=66966
3465
3466         Reviewed by Eric Seidel.
3467
3468         Turns out tool.path() used to be relative, which caused problems when
3469         running webkit-patch outside the root directory.  This patch makes it
3470         absolute.  I checked all callers, and they all appear to want this
3471         behavior.
3472
3473         It was unclear to me how to test this change because we only really
3474         have a testing strategy for webkitpy, not for the main script.
3475
3476         * Scripts/webkit-patch:
3477
3478 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3479
3480         garden-o-matic summary needs a mock view that could be used for working on styling
3481         https://bugs.webkit.org/show_bug.cgi?id=66971
3482
3483         Reviewed by Adam Barth.
3484
3485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
3486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
3487
3488 2011-08-25  Anders Carlsson  <andersca@apple.com>
3489
3490         Return the correct value for NPNVsupportsCarbonBool
3491         https://bugs.webkit.org/show_bug.cgi?id=66964
3492
3493         Add a test.
3494
3495         Reviewed by Adam Roben.
3496
3497         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3498         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
3499         (SupportsCarbonEventModel::SupportsCarbonEventModel):
3500         (SupportsCarbonEventModel::testConvert):
3501         (SupportsCarbonEventModel::runTest):
3502         (SupportsCarbonEventModel::NPP_New):
3503
3504 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3505
3506         garden-o-matic summary view should not be broken.
3507
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3509         (table.comparison): Added more specificity.
3510
3511 2011-08-25  Adam Barth  <abarth@webkit.org>
3512
3513         This command has been broken for a while.  This patch updates the
3514         callsite to the new API.
3515
3516         * Scripts/webkitpy/tool/commands/rebaseline.py:
3517
3518 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
3519
3520         garden-o-matic needs a way to report where and how tests are failing in the summary view.
3521         https://bugs.webkit.org/show_bug.cgi?id=66955
3522
3523         Introduce FailureGrid, your one-stop failure-indicating destination. 
3524
3525         Reviewed by Adam Barth.
3526
3527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
3528         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
3529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
3531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
3532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
3533
3534 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
3535
3536         Add myself to the committers list
3537         https://bugs.webkit.org/show_bug.cgi?id=66941
3538
3539         Reviewed by Andreas Kling.
3540
3541         * Scripts/webkitpy/common/config/committers.py:
3542
3543 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3544
3545         Unreviewed, rolling out r93767.
3546         http://trac.webkit.org/changeset/93767
3547         https://bugs.webkit.org/show_bug.cgi?id=66931
3548
3549         Broke Qt bot. (Requested by yutak on #webkit).
3550
3551         * Scripts/webkitpy/thirdparty/__init__.py:
3552
3553 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
3554
3555         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
3556         https://bugs.webkit.org/show_bug.cgi?id=66924
3557
3558         Reviewed by Kent Tamura.
3559
3560         * Scripts/webkitpy/thirdparty/__init__.py:
3561
3562 2011-08-24  Adam Barth  <abarth@webkit.org>
3563
3564         The user can't close the details view in garden-o-matic
3565         https://bugs.webkit.org/show_bug.cgi?id=66911
3566
3567         Reviewed by Dimitri Glazkov.
3568
3569         In addition to adding a close button, this patch changes the test
3570         selector to use a <select> element and refactors the test selector to
3571         share code with the builder selector.
3572
3573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3577
3578 2011-08-24  James Robinson  <jamesr@chromium.org>
3579
3580         [chromium] Stacktrace not in test output when a test crashes
3581         https://bugs.webkit.org/show_bug.cgi?id=66806
3582
3583         Reviewed by Dirk Pranke.
3584
3585         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
3586         trace.
3587
3588         * Scripts/webkitpy/layout_tests/port/chromium.py:
3589
3590 2011-08-24  Adam Barth  <abarth@webkit.org>
3591
3592         Remove empty directory.
3593
3594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
3595
3596 2011-08-24  Adam Barth  <abarth@webkit.org>
3597
3598         Finish writing up details-view in garden-o-matic
3599         https://bugs.webkit.org/show_bug.cgi?id=66891
3600
3601         Reviewed by Dimitri Glazkov.
3602
3603         This patch mostly just copies a bunch of CSS from main.css to
3604         summary.css.  Presumably we'll delete main.css soon.
3605
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3611
3612 2011-08-24  James Robinson  <jamesr@chromium.org>
3613
3614         Some compositing LayoutTests flakily crashing on Mac 10.6
3615         https://bugs.webkit.org/show_bug.cgi?id=66740
3616
3617         Reviewed by Adam Barth.
3618
3619         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
3620         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
3621         chromium configuration.
3622
3623         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3624         (NPP_Destroy):
3625
3626 2011-08-24  Anton D'Auria  <adauria@apple.com>
3627
3628         No review necessary.
3629
3630         Adding myself to list of committers.
3631
3632         * Scripts/webkitpy/common/config/committers.py:
3633
3634 2011-08-24  Avi Drissman  <avi@google.com>
3635
3636         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
3637         https://bugs.webkit.org/show_bug.cgi?id=66875
3638
3639         Reviewed by James Robinson.
3640
3641         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3642         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3643
3644 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
3645
3646         Make notifications appear in time order again.
3647         https://bugs.webkit.org/show_bug.cgi?id=66815
3648
3649         Reviewed by Adam Barth.
3650
3651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
3652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
3653
3654 2011-08-23  James Robinson  <jamesr@chromium.org>
3655
3656         [chromium] Need a way to test lost compositor context recovery
3657         https://bugs.webkit.org/show_bug.cgi?id=66820
3658
3659         Reviewed by Kenneth Russell.
3660
3661         Exposes a LayoutTestController interface in chromium to simulate a
3662         lost compositor context.