Unreviewed, rolling out r93426.
[WebKit-https.git] / Tools / ChangeLog
1 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r93426.
4         http://trac.webkit.org/changeset/93426
5         https://bugs.webkit.org/show_bug.cgi?id=66607
6
7         Broke the Mac build by not building gtest.framework anymore
8         (Requested by andersca on #webkit).
9
10         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
11
12 2011-08-19  James Robinson  <jamesr@chromium.org>
13
14         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
15         https://bugs.webkit.org/show_bug.cgi?id=66603
16
17         Reviewed by Dirk Pranke.
18
19         The various ChromiumGpu ports should use the same child worker
20         selection logic as other ports so they can run with full
21         parallelization on multicore systems.
22
23         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
24         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
25
26 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
27
28         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
29         https://bugs.webkit.org/show_bug.cgi?id=66570
30
31         Reviewed by Mihai Parparita.
32
33         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
34         (WebThemeControlDRTWin::draw):
35         (WebThemeControlDRTWin::drawTextField):
36         (WebThemeControlDRTWin::drawProgressBar):
37         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
38
39 2011-08-18  Dmitry Lomov  <dslomov@google.com>
40
41         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
42         https://bugs.webkit.org/show_bug.cgi?id=66521
43
44         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
45
46         Reviewed by David Levin.
47
48         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
49
50 2011-08-19  Adam Roben  <aroben@apple.com>
51
52         Add project file changes I left out in r93417
53
54         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
55
56 2011-08-19  Adam Roben  <aroben@apple.com>
57
58         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
59
60         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
61         NSScreen
62
63         Reviewed by Anders Carlsson.
64
65         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
66
67         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
68         (-[SimpleObject setValue:]): Original implementation.
69
70         (TestWebKitAPI::setValue2):
71         (TestWebKitAPI::setValue3):
72         Swizzled implementations.
73
74         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
75         instance method.
76
77         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
78         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
79         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
80         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
81
82 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
83
84         Fix _path_to_apache() error reporting
85         https://bugs.webkit.org/show_bug.cgi?id=66486
86
87         Reviewed by Ryosuke Niwa.
88
89         * Scripts/webkitpy/layout_tests/port/webkit.py:
90
91 2011-08-19  Adam Roben  <aroben@apple.com>
92
93         Windows build fix after r93404
94
95         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
96
97 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
98
99         Add leandrogracia to the committers list
100         https://bugs.webkit.org/show_bug.cgi?id=66552
101
102         Also fix line endings in file.
103
104         No reviewed required.
105
106         * Scripts/webkitpy/common/config/committers.py:
107
108 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
109
110         Fix compilation issue in WebKitTestRunner
111         https://bugs.webkit.org/show_bug.cgi?id=66554
112
113         Reviewed by Martin Robinson.
114
115         * WebKitTestRunner/PixelDumpSupport.cpp:
116
117 2011-08-19  Adam Roben  <aroben@apple.com>
118
119         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
120
121         This will make it easier to write other WebKit-agnostic tests
122
123         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
124         code in other WebKit-agnostic tests
125
126         Reviewed by Anders Carlsson.
127
128         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
129
130         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
131         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
132         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
133         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
134         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
135         WebKitAgnosticTest handles for us.
136         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
137
138         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
139         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
140         DynamicDeviceScaleFactor::runTest.
141
142         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
143         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
144         DynamicDeviceScaleFactor.WebKit.
145         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
146         DynamicDeviceScaleFactor.WebKit2.
147
148 2011-08-19  Adam Roben  <aroben@apple.com>
149
150         Clean up #includes in TestWebKitAPI
151
152         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
153
154         Reviewed by Anders Carlsson.
155
156         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
157         files and WebKit/WebKit.h for ObjC files.
158
159         * TestWebKitAPI/InjectedBundleController.cpp:
160         * TestWebKitAPI/JavaScriptTest.h:
161         * TestWebKitAPI/PlatformUtilities.h:
162         * TestWebKitAPI/PlatformWebView.h:
163         * TestWebKitAPI/Test.h:
164         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
165         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
166         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
167         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
168         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
169         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
170         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
171         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
172         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
173         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
174         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
175         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
176         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
177         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
178         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
179         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
180         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
181         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
182         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
183         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
184         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
185         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
186         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
187         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
188         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
189         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
190         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
191         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
192         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
193         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
194         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
195         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
196         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
197         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
198         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
199         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
200         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
201         * TestWebKitAPI/TestsController.cpp:
202         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
203         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
204         #includes since it is no longer a special header.
205
206 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
207
208         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
209         https://bugs.webkit.org/show_bug.cgi?id=64886
210
211         Temporarily disable the http locking to work around the issue.
212         I'm not actually sure if this is going to work or improve things
213         much.
214
215         Reviewed by Ryosuke Niwa.
216
217         * Scripts/webkitpy/layout_tests/port/mac.py:
218
219 2011-08-18  Tony Chang  <tony@chromium.org>
220
221         add embedded png checksums to WebKitTestRunner
222         https://bugs.webkit.org/show_bug.cgi?id=66494
223
224         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
225         some code from DRT and adds it to the WebKitTestRunner.
226
227         Reviewed by Darin Adler.
228
229         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
230         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
231         * WebKitTestRunner/GNUmakefile.am: Add new files
232         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
233         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
234         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
235         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
236         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
237         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
238         * WebKitTestRunner/cg/TestInvocationCG.cpp:
239         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
240         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
241         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
242
243 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
244
245         https://bugs.webkit.org/show_bug.cgi?id=47240
246
247         Fixed a cygwin path problem in the chromium port of diff_image;
248         Also made the return values of the diff_image function more consistent.
249
250         Reviewed by Dirk Pranke.
251
252         * Scripts/webkitpy/layout_tests/port/chromium.py:
253
254 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
255
256         [GTK] Fix compilation problems with deprecations in gtk+
257         https://bugs.webkit.org/show_bug.cgi?id=66073
258
259         Reviewed by Martin Robinson.
260
261         * DumpRenderTree/gtk/DumpRenderTree.cpp:
262         (main): G_CONST_RETURN was deprecated
263         * GtkLauncher/main.c:
264         (createWindow): Added gtk_box_new conditional compilation for
265         gtk+-3.
266         * MiniBrowser/gtk/BrowserWindow.c:
267         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
268         are just supporting gtk+-3 for WebKit2.
269
270 2011-08-18  Anders Carlsson  <andersca@apple.com>
271
272         Fix libc++ C++0x build
273         https://bugs.webkit.org/show_bug.cgi?id=66479
274
275         Reviewed by Adam Roben.
276
277         Add missing includes.
278
279         * DumpRenderTree/LayoutTestController.cpp:
280         * DumpRenderTree/mac/CheckedMalloc.cpp:
281
282 2011-08-18  Adam Roben  <aroben@apple.com>
283
284         Test that WebKit updates style when a WebView is moved between differently-scaled windows
285
286         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
287         WebView is moved between windows with different backing scale factors
288
289         Reviewed by Anders Carlsson.
290
291         * TestWebKitAPI/JavaScriptTest.cpp:
292         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
293         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
294         gtest's built-in error messages.
295
296         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
297         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
298         those overloads.
299
300         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
301
302         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
303         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
304         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
305         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
306         (TestWebKitAPI::setPageLoaderClient): Set up the client.
307         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
308         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
309         SyntheticBackingScaleFactorWindow and returns it.
310         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
311         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
312         window, is moved to a differently-scaled window, and is taken out of the window.
313         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
314         WebKit1 and WebKit2.
315         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
316
317         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
318
319         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
320         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
321
322         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
323         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
324         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
325         initializer.
326         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
327
328         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
329         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
330         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
331
332 2011-08-18  Dmitry Lomov  <dslomov@google.com>
333
334         https://bugs.webkit.org/show_bug.cgi?id=66425
335         check-webkit-style should detect incorrectly formatted file change descriptions.
336         Description, if present, should be separated from colon with a space.
337
338         Reviewed by David Levin.
339
340         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
341         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
342
343 2011-08-18  Adam Barth  <abarth@webkit.org>
344
345         webkit-patch pretty-diff should be shown in main help
346         https://bugs.webkit.org/show_bug.cgi?id=66404
347
348         Reviewed by Dimitri Glazkov.
349
350         As requested by dglazkov.
351
352         * Scripts/webkitpy/tool/commands/prettydiff.py:
353
354 2011-08-17  Dmitry Lomov  <dslomov@google.com>
355
356         https://bugs.webkit.org/show_bug.cgi?id=66400
357         Fix TestWebKitAPI build on Mac OS.
358
359         Reviewed by David Levin.
360
361         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
362
363 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
364
365         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
366         https://bugs.webkit.org/show_bug.cgi?id=66427
367
368         Reviewed by Adam Barth.
369
370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
375         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
376         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
462         ():
463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
485
486 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
487
488         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
489         https://bugs.webkit.org/show_bug.cgi?id=65877
490
491         Reviewed by Eric Seidel.
492
493         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
494
495 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
496
497         Remove base.keys and replace it with Object.keys.
498         https://bugs.webkit.org/show_bug.cgi?id=66422
499
500         Reviewed by Adam Barth.
501
502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
505
506 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
507
508         garden-o-matic Summary view should have items in descending chronological order.
509         https://bugs.webkit.org/show_bug.cgi?id=66403
510
511         Reviewed by Adam Barth.
512
513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
516
517 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
518
519         Fix a few errors in garden-o-matic frontend unit tests.
520         https://bugs.webkit.org/show_bug.cgi?id=66421
521
522         Reviewed by Adam Barth.
523
524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
527
528 2011-08-17  Adam Barth  <abarth@webkit.org>
529
530         Update Tools to account for (CG) being added to Chromium builder names
531         https://bugs.webkit.org/show_bug.cgi?id=66410
532
533         Reviewed by Adam Barth.
534
535         Some of these names will change back once we turn on Skia bots.
536
537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
540         * Scripts/webkitpy/layout_tests/port/builders.py:
541         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
542         * TestResultServer/static-dashboards/builders.js:
543         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
544
545 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
546
547         Wire up relative time to garden-o-matic summary view.
548         https://bugs.webkit.org/show_bug.cgi?id=66343
549
550         Reviewed by Adam Barth.
551
552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
554         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
555         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
556         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
557
558 2011-08-17  Adam Roben  <aroben@apple.com>
559
560         Make run-api-tests run tests in alphabetical order
561
562         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
563
564         Reviewed by David Kilzer.
565
566         * Scripts/run-api-tests:
567         (runAllTests):
568         (runAllTestsInSuite):
569         Sort the lists of tests and suites before iterating over them.
570
571 2011-08-17  Adam Barth  <abarth@webkit.org>
572
573         garden-o-matic should be able to rebaseline expected failures
574         https://bugs.webkit.org/show_bug.cgi?id=66204
575
576         Reviewed by Dimitri Glazkov.
577
578         This patch introduces a new view for displaying expect, actual, and
579         differences between results.  The new view also has a fledgling
580         controller that handles some basic operations.  The new view is
581         exercised by rebaseline.html, which lets you rebaselines expected
582         failures, but the new view is not fully integrated into
583         garden-o-matic.html
584
585         More patches will be required to make this stuff fully working, but
586         this patch was already somewhat spiraling out of control.  Hopefully
587         this patch will serve as a good starting point for further development.
588
589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
601
602 2011-08-16  Chang Shu  <cshu@webkit.org>
603
604         Support reset in WebCore::Internals
605         https://bugs.webkit.org/show_bug.cgi?id=66307
606
607         Reviewed by Dimitri Glazkov.
608
609         Added call to resetInternalsObject in DRT.
610
611         * DumpRenderTree/chromium/TestShell.cpp:
612         (TestShell::resetTestController):
613         * DumpRenderTree/mac/DumpRenderTree.mm:
614         (resetWebViewToConsistentStateBeforeTesting):
615         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
616         (WebCore::WebPage::resetSettings):
617
618 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
619
620         Add a new build slave for the Qt port on Mac OS SnowLeopard.
621         https://bugs.webkit.org/show_bug.cgi?id=66392
622
623         Modify the config file to include the new build slave.
624
625         Reviewed by Adam Roben.
626
627         * BuildSlaveSupport/build.webkit.org-config/config.json:
628
629 2011-08-17  Sam White  <samuel.white@rochester.edu>
630
631         AccessibilityObject levels are inconsistent
632         https://bugs.webkit.org/show_bug.cgi?id=66180
633         
634         Added the ability to get numeric attribute values using numberAttributeValue. This
635         function complements the existing stringAttributeValue and boolAttributeValue functions.
636         The addition of numberAttributeValue was necessary because the stringAttributeValue
637         function does a type check and will only return strings. This limitation made it
638         impossible to get values for attributes that returned an NSNumber.
639
640         Reviewed by Chris Fleizach.
641
642         * DumpRenderTree/AccessibilityUIElement.cpp:
643         (numberAttributeValueCallback):
644         (AccessibilityUIElement::getJSClass):
645         * DumpRenderTree/AccessibilityUIElement.h:
646         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
647         (AccessibilityUIElement::numberAttributeValue):
648         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
649         (AccessibilityUIElement::numberAttributeValue):
650         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
651         (AccessibilityUIElement::numberAttributeValue):
652
653 2011-08-17  Adam Roben  <aroben@apple.com>
654
655         Tell Trac logs always to display all specified revisions in a single page
656
657         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
658         revisions than that.
659
660         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
661         relevant revisions
662
663         Reviewed by Daniel Bates.
664
665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
666         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
667         a single page.
668
669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
671         Updated tests for the above.
672
673 2011-08-17  Adam Roben  <aroben@apple.com>
674
675         Fix TestFailures's link to file a bug about TestFailures itself
676
677         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
678         bug about itself is broken
679
680         Reviewed by Dan Bates.
681
682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
683         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
684         the host from the path.
685
686 2011-08-17  Adam Roben  <aroben@apple.com>
687
688         Teach TestFailures to ignore unbelievably short test runs
689
690         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
691         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
692
693         Reviewed by Dan Bates.
694
695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
696         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
697         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
698         that caused it not to run any tests at all (as happened for a while due to
699         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
700
701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
702         Test for the above.
703
704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
705         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
706
707 2011-08-16  Adam Barth  <abarth@webkit.org>
708
709         Add a CG qualifier similar to the GPU qualifier
710         https://bugs.webkit.org/show_bug.cgi?id=66359
711
712         Reviewed by Eric Seidel.
713
714         Once we have a Skia configuration on Chromium Mac, we'll use this CG
715         qualifier to note that expectations apply only to the CG configuration.
716
717         * Scripts/webkitpy/layout_tests/port/chromium.py:
718         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
719
720 2011-08-16  Eric Seidel  <eric@webkit.org>
721
722         REGRESSION(92717): WinPort needs to parse version information from port_name
723         https://bugs.webkit.org/show_bug.cgi?id=66325
724
725         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
726
727         * Scripts/webkitpy/layout_tests/port/mac.py:
728         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
729
730 2011-08-16  Adam Barth  <abarth@webkit.org>
731
732         Change webkit-patch analyze-baselines to print in a more unix-friendly way
733         https://bugs.webkit.org/show_bug.cgi?id=66349
734
735         Reviewed by James Robinson.
736
737         As requested by jamesr.
738
739         * Scripts/webkitpy/tool/commands/rebaseline.py:
740
741 2011-08-16  Eric Seidel  <eric@webkit.org>
742
743         REGRESSION(92717): WinPort needs to parse version information from port_name
744         https://bugs.webkit.org/show_bug.cgi?id=66325
745
746         Reviewed by Adam Barth.
747
748         WinPort didn't have any port_name parsing logic.
749         Seemed it was best to just share the logic from MacPort.
750         Sharing the logic from MacPort seemed easiest with a shared superclass.
751         Once I created ApplePort (the superclass) there was a bunch of logic to share.
752         I found LeakDetector was just in the way when switching back and forth
753         between win.py and mac.py so I moved it into its own file.
754
755         The only logic change here is that WinPort should now be
756         able to parse port_name values like MacPort (and other ports)
757         can.  The fact that ports do this in their constructors is
758         wrong and a source of many bugs.  But at least now WinPort
759         matches the status-quo.
760
761         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
762         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
763         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
764         * Scripts/webkitpy/layout_tests/port/mac.py:
765         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
766         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
767         * Scripts/webkitpy/layout_tests/port/win.py:
768         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
769
770 2011-08-16  Adam Barth  <abarth@webkit.org>
771
772         Add webkit-patch analyze-baselines, as requested by jamesr.
773
774         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
775         * Scripts/webkitpy/tool/commands/rebaseline.py:
776
777 2011-08-16  Adam Barth  <abarth@webkit.org>
778
779         Fold bulk-optimize-baselines into optimize-baselines
780         https://bugs.webkit.org/show_bug.cgi?id=66345
781
782         Reviewed by James Robinson.
783
784         bulk-optimize-baselines is now a superset of optimize-baselines, so
785         they can be combined.
786
787         * Scripts/webkitpy/tool/commands/rebaseline.py:
788
789 2011-08-16  Adam Barth  <abarth@webkit.org>
790
791         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
792         https://bugs.webkit.org/show_bug.cgi?id=66334
793
794         Reviewed by Tony Chang.
795
796         This patch moves us closer to switching the Chromium port from
797         CoreGraphics to Skia.  This patch teaches our tools that the current
798         Chromium Mac configuration is actually chromium-cg-mac, which makes
799         room for a future chromium-mac configuration that uses Skia.
800
801         Shortly after this patch lands, I'll do a server-side move of the
802         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
803         and chromium-cg-mac-leopard.
804
805         * BuildSlaveSupport/build.webkit.org-config/config.json:
806         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
807         * Scripts/webkitpy/common/config/build.py:
808         * Scripts/webkitpy/common/config/build_unittest.py:
809         * Scripts/webkitpy/layout_tests/port/base.py:
810         * Scripts/webkitpy/layout_tests/port/builders.py:
811         * Scripts/webkitpy/layout_tests/port/chromium.py:
812         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
813         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
814         * Scripts/webkitpy/layout_tests/port/dryrun.py:
815         * Scripts/webkitpy/layout_tests/port/factory.py:
816         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
817         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
818         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
819         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
820         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
821         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
822         * TestResultServer/static-dashboards/flakiness_dashboard.html:
823
824 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
825
826         garden-o-matic frontend needs a friendly relative time description method.
827         https://bugs.webkit.org/show_bug.cgi?id=66324
828
829         Reviewed by Adam Barth.
830
831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
834
835 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
836
837         Summary view should not add multiple entries for the same test failure.
838         https://bugs.webkit.org/show_bug.cgi?id=66318
839
840         Reviewed by Adam Barth.
841
842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
844             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
846
847 2011-08-16  Adam Roben  <aroben@apple.com>
848
849         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
850
851         The basic strategy here is that once a test has failed or passed many times in a row we
852         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
853         in many fewer false positives than our current behavior.
854
855         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
856         flaky, including tests that failed for a while but then were fixed
857
858         Reviewed by Dan Bates.
859
860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
861         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
862         number of non-too-many-failure builds we've seen.
863         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
864         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
865         tests, keep track of how many times they have passed or failed in a row. If they pass or
866         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
867         considered flaky it doesn't matter how many times it passes or fails.)
868
869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
870         Added tests for the above.
871
872 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
873
874         garden-o-matic needs a summary view with actions for each problem.
875         https://bugs.webkit.org/show_bug.cgi?id=66144
876
877         Reviewed by Adam Barth.
878
879         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
885
886 2011-08-16  Dean Jackson  <dino@apple.com>
887
888         Adding Ted "hober" O'Connor as a non-committing contributor.
889
890         * Scripts/webkitpy/common/config/committers.py:
891
892 2011-08-16  Adam Roben  <aroben@apple.com>
893
894         Teach TestFailures how to interpret unfinished test runs
895
896         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
897         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
898
899         Reviewed by David Kilzer.
900
901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
902         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
903         rather than "isStarted" so that we don't count builds for which the test run never finished.
904         Bumped the cache version to evict old, buggy cached data.
905
906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
907         Added a test for the above, and made a somewhat synthetic test more realistic by including
908         more of the actual JSON data from build.webkit.org.
909
910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
911         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
912         cached data.
913
914 2011-08-16  Adam Roben  <aroben@apple.com>
915
916         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
917
918         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
919         should match Lion's behavior.
920
921         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
922         but doesn't use Lion results
923
924         Reviewed by David Kilzer.
925
926         * Scripts/old-run-webkit-tests:
927         (expectedDirectoryForTest):
928         * Scripts/webkitpy/layout_tests/port/win.py:
929         (WinPort.baseline_search_path):
930         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
931         (WinPortTest.test_baseline_search_path):
932         Replaced mac-snowleopard with mac-lion.
933
934         * Scripts/webkitpy/common/config/build.py:
935         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
936         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
937         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
938         will no longer look there for results.
939
940         * Scripts/webkitpy/common/config/build_unittest.py:
941         (ShouldBuildTest.test_should_build): Tests for the above changes.
942
943 2011-08-16  Dean Jackson  <dino@apple.com>
944
945         Move me from contributor to reviewer.
946
947         * Scripts/webkitpy/common/config/committers.py:
948
949 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
950
951         garden-o-matic frontend needs model.commitDataForRevisionRange function.
952         https://bugs.webkit.org/show_bug.cgi?id=66252
953
954         Reviewed by Adam Barth.
955
956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
958
959 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
960
961         garden-o-matic frontend needs a generic way to track updates.
962         https://bugs.webkit.org/show_bug.cgi?id=66245
963
964         Reviewed by Adam Barth.
965
966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
968
969 2011-08-15  Adam Roben  <aroben@apple.com>
970
971         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
972
973         Failures now give output of the form: foo should be bar but is baz
974
975         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
976         test is in TestWebKitAPI's output
977
978         Reviewed by David Levin.
979
980         * TestWebKitAPI/JavaScriptTest.cpp:
981         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
982         members.
983         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
984         object, rather than doing any testing of it here.
985         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
986         to use a pretty error message when the test fails.
987
988         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
989         gtest-style macros that wrap it.
990
991         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
992
993         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
994         (TestWebKitAPI::TEST): Changed to use the new macros.
995
996         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
997         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
998         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
999         the test passes, though. Returning early seems to have been an unnecessary optimization.
1000
1001         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1002         (TestWebKitAPI::TEST): Changed to use the new macros.
1003
1004 2011-08-15  Eric Seidel  <eric@webkit.org>
1005
1006         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
1007
1008         Unreviewed.
1009
1010         * Scripts/run-webkit-tests:
1011         (usingLeaks):
1012         (useNewRunWebKitTests):
1013
1014 2011-08-14  Adam Barth  <abarth@webkit.org>
1015
1016         Switch results detail view over to new-style object-oriented UI widgets
1017         https://bugs.webkit.org/show_bug.cgi?id=66200
1018
1019         Reviewed by Dimitri Glazkov.
1020
1021         This patch replaces my goofy template-based UI for the results
1022         comparison screen with new object-oriented UI widgets.
1023
1024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
1026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
1030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1031
1032 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
1033
1034         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
1035         https://bugs.webkit.org/show_bug.cgi?id=66166
1036
1037         Also changed base.RequestTracker to:
1038         a) fire callback immediately if requestsInFlight is 0;
1039         b) not barf if callback is not supplied.
1040
1041         Reviewed by Adam Barth.
1042
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
1045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
1046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
1047
1048 2011-08-12  Mark Rowe  <mrowe@apple.com>
1049
1050         Be more forward-looking in the choice of compiler.
1051
1052         Rubber-stamped by Jon Honeycutt.
1053
1054         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
1055         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
1056         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1057         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
1058
1059 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1060
1061         DRT: Add support for gesture events.
1062         https://bugs.webkit.org/show_bug.cgi?id=66105
1063
1064         Reviewed by Darin Fisher.
1065
1066         * DumpRenderTree/chromium/EventSender.cpp:
1067         (EventSender::EventSender):
1068         (EventSender::gestureScrollBegin):
1069         (EventSender::gestureScrollEnd):
1070         (EventSender::gestureTap):
1071         (EventSender::gestureEvent):
1072         * DumpRenderTree/chromium/EventSender.h:
1073
1074 2011-08-12  Andy Estes  <aestes@apple.com>
1075
1076         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
1077         https://bugs.webkit.org/show_bug.cgi?id=66158
1078
1079         Reviewed by Dan Bernstein.
1080
1081         * DumpRenderTree/LayoutTestController.cpp:
1082         (allowRoundingHacksCallback): The third argument is the 'this'
1083         JSObjectRef, not the second.
1084
1085 2011-08-12  Andy Estes  <aestes@apple.com>
1086
1087         Cancel in onbeforeunload dialog sometime causes a button to stop working.
1088         https://bugs.webkit.org/show_bug.cgi?id=26211
1089
1090         Reviewed by Alexey Proskuryakov.
1091
1092         Implement a new LayoutTestController method that a test can call to set
1093         the return value of DumpRenderTree's beforeunload UI delegate.
1094
1095         * DumpRenderTree/LayoutTestController.cpp:
1096         (LayoutTestController::LayoutTestController): Initialize
1097         m_shouldStayOnPageAfterHandlingBeforeUnload.
1098         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
1099         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
1100         (LayoutTestController::staticFunctions): Register
1101         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
1102         * DumpRenderTree/LayoutTestController.h: 
1103         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
1104         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1105         * DumpRenderTree/chromium/LayoutTestController.cpp:
1106         (LayoutTestController::LayoutTestController): Initialize
1107         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
1108         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
1109         (LayoutTestController::reset): Reset
1110         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
1111         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1112         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
1113         from JavaScript.
1114         * DumpRenderTree/chromium/LayoutTestController.h:
1115         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
1116         * DumpRenderTree/chromium/WebViewHost.cpp:
1117         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
1118         return the inverse of
1119         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
1120         * DumpRenderTree/mac/UIDelegate.mm:
1121         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
1122         * DumpRenderTree/win/UIDelegate.cpp:
1123         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
1124         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1125         Define setShouldStayOnPageAfterHandlingBeforeUnload().
1126         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1127         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
1128         to the Test Controller telling it what value it should return in its
1129         onbeforeunload UI delegate.
1130         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1131         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1132         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
1133         Call InjectedBundle::postNewBeforeUnloadReturnValue().
1134         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1135         * WebKitTestRunner/TestController.cpp:
1136         (WTR::TestController::TestController): Initialize
1137         m_beforeUnloadReturnValue to true.
1138         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
1139         the value of TestController::beforeUnloadReturnValue().
1140         (WTR::TestController::resetStateToConsistentValues): Reset
1141         m_beforeUnloadReturnValue to true.
1142         * WebKitTestRunner/TestController.h:
1143         (WTR::TestController::beforeUnloadReturnValue):
1144         (WTR::TestController::setBeforeUnloadReturnValue):
1145         * WebKitTestRunner/TestInvocation.cpp:
1146         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
1147         message posted from the injected bundle by retrieving the message body
1148         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
1149
1150 2011-08-12  Sam Weinig  <sam@webkit.org>
1151
1152         Move compiler specific macros to their own header
1153         https://bugs.webkit.org/show_bug.cgi?id=66119
1154
1155         Reviewed by Anders Carlsson.
1156
1157         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
1158
1159 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1160
1161         Add a way to extend DOM objects in garden-o-matic.
1162         https://bugs.webkit.org/show_bug.cgi?id=66096
1163
1164         Reviewed by Adam Barth.
1165
1166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
1167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
1168
1169 2011-08-11  MORITA Hajime  <morrita@google.com>
1170
1171         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
1172         https://bugs.webkit.org/show_bug.cgi?id=45438
1173
1174         Reviewed by Kent Tamura.
1175
1176         MockSpellCheck was assuming the input of spellCheckWord() is a word.
1177         But it can be a series of word. This change made spellCheckWord()
1178         understand simple word boundary which appears in tests.
1179         
1180         * DumpRenderTree/chromium/MockSpellCheck.cpp:
1181         (MockSpellCheck::spellCheckWord):
1182
1183 2011-08-11  Mark Rowe  <mrowe@apple.com>
1184
1185         Rework some Makefile logic to remove a double-negative.
1186
1187         Reviewed by Jon Honeycutt.
1188
1189         * DumpRenderTree/mac/PerlSupport/Makefile:
1190
1191 2011-08-11  Anders Carlsson  <andersca@apple.com>
1192
1193         Add a FIXME.
1194
1195         * TestWebKitAPI/TestsController.cpp:
1196         (TestWebKitAPI::TestsController::TestsController):
1197
1198 2011-08-11  Anders Carlsson  <andersca@apple.com>
1199
1200         Initialize threading before running any tests
1201         https://bugs.webkit.org/show_bug.cgi?id=66112
1202
1203         Reviewed by Adam Barth.
1204
1205         * TestWebKitAPI/TestsController.cpp:
1206         (TestWebKitAPI::TestsController::TestsController):
1207
1208 2011-08-11  Adam Barth  <abarth@webkit.org>
1209
1210         Add unexpected-passes.html to TestFailures for marking tests as passing
1211         https://bugs.webkit.org/show_bug.cgi?id=66102
1212
1213         Reviewed by Dimitri Glazkov.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1217             - Move some code into the library so it can be shared.
1218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
1221             - Add round-trip unit tests.
1222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
1223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
1224             - I'm not entirely sure this feature should remain a separate HTML
1225               file, but it seemed better than cluttering up the main HTML file
1226               with too much extra stuff.
1227         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1228         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1229             - The gardening server couldn't handle adding PASS expectations.  Now it can.
1230
1231 2011-08-11  Eric Seidel  <eric@webkit.org>
1232
1233         NRWT has wrong fallback order for Mac now that Lion exists
1234         https://bugs.webkit.org/show_bug.cgi?id=66093
1235
1236         Reviewed by Adam Barth.
1237
1238         ORWT used a different system for fallback orders than NRWT did.
1239         I moved win.py to match ORWT fallback orders in bug 64486.
1240         This bug moves mac.py to match ORWT fallback order
1241         and adds 'lion' as a supported OS version.
1242
1243         Because ChromiumMac shares OS version detection code with AppleMac
1244         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
1245
1246         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1247         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1248         * Scripts/webkitpy/layout_tests/port/mac.py:
1249         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1250         * Scripts/webkitpy/layout_tests/port/win.py:
1251
1252 2011-08-11  Adam Barth  <abarth@webkit.org>
1253
1254         Update test results now that we use absolute URLs.
1255
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
1257
1258 2011-08-11  Adam Barth  <abarth@webkit.org>
1259
1260         garden-o-matic should be able to determine when tests unexpectedly pass
1261         https://bugs.webkit.org/show_bug.cgi?id=66092
1262
1263         Reviewed by Dimitri Glazkov.
1264
1265         This patch just contains the library methods for extracting this
1266         information.  I'll add some UI in a subsequent patch.
1267
1268         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
1269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
1270
1271 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1272
1273         New expectation entries should be placed next to existing ones.
1274         https://bugs.webkit.org/show_bug.cgi?id=66066
1275
1276         Reviewed by Adam Barth.
1277
1278         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
1279             which is computed as the last found reference to the same test.
1280         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
1281
1282 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1283
1284         Unreviewed, rolling out r92847.
1285         http://trac.webkit.org/changeset/92847
1286         https://bugs.webkit.org/show_bug.cgi?id=65986
1287
1288         Broke check-webkit-style
1289
1290         * Scripts/webkitpy/style/checker.py:
1291         * Scripts/webkitpy/style/checker_unittest.py:
1292
1293 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
1294
1295         Unreviewed, rolling out r92847.
1296         http://trac.webkit.org/changeset/92847
1297         https://bugs.webkit.org/show_bug.cgi?id=65986
1298
1299         Broke check-webkit-style
1300
1301         * Scripts/webkitpy/style/checker.py:
1302         * Scripts/webkitpy/style/checker_unittest.py:
1303
1304 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
1305
1306         [Qt] autotests shouldn't require config.h in the style check
1307         https://bugs.webkit.org/show_bug.cgi?id=65986
1308
1309         Remove the include rules from the style-check for Qt tests.
1310         Since for the most part it's just a matter of using the
1311         API provided by QtWebKit, enforcing the WebCore set of rules
1312         only seems to make sense in the case of MIMESniffing.
1313
1314         Reviewed by Benjamin Poulain.
1315
1316         * Scripts/webkitpy/style/checker.py:
1317         * Scripts/webkitpy/style/checker_unittest.py:
1318
1319 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
1320
1321         [WK2] Implement waitForPolicyDelegate
1322         https://bugs.webkit.org/show_bug.cgi?id=42330
1323
1324         Reviewed by Csaba Osztrogonác.
1325
1326         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1327         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1328         (WTR::navigationTypeToString):
1329         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1330         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1331         (WTR::LayoutTestController::LayoutTestController):
1332         (WTR::LayoutTestController::setCustomPolicyDelegate):
1333         (WTR::LayoutTestController::waitForPolicyDelegate):
1334         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1335         (WTR::LayoutTestController::isPolicyDelegateEnabled):
1336         (WTR::LayoutTestController::isPolicyDelegatePermissive):
1337
1338 2011-08-11  Adam Barth  <abarth@webkit.org>
1339
1340         rebaseline-expectations should use the release bots, not the debug
1341         bots.  The debug bots don't all run all the tests.  Also, delay
1342         updating test_expectations a long as possible to avoid clearing out
1343         lines that we'll need for other ports.
1344
1345         * Scripts/webkitpy/layout_tests/port/builders.py:
1346         * Scripts/webkitpy/tool/commands/rebaseline.py:
1347         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1348
1349 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
1350
1351         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
1352         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
1353
1354         * BuildSlaveSupport/build.webkit.org-config/config.json:
1355
1356 2011-08-10  Eric Seidel  <eric@webkit.org>
1357
1358         new-run-webkit-test's WinPort has no fallback logic
1359         https://bugs.webkit.org/show_bug.cgi?id=64486
1360
1361         Unreviewed.
1362
1363         Turns out that we've long had a subtle bug whereby if you didn't
1364         already have DumpRenderTree built, we might end up running unsupported tests
1365         because the DumpRenderTree --print-supported-features check would silently fail.
1366
1367         When I moved the call from using popen to using Executive.run_command, this silent
1368         failure became noisy.  (Breaking some bots.)
1369
1370         This re-orders our steps so that we always build DRT before collecting expectations,
1371         as well as adds a warning message when DumpRenderTree can't be found.
1372
1373         * Scripts/webkitpy/layout_tests/port/webkit.py:
1374         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1375
1376 2011-08-10  Eric Seidel  <eric@webkit.org>
1377
1378         new-run-webkit-test's WinPort has no fallback logic
1379         https://bugs.webkit.org/show_bug.cgi?id=64486
1380
1381         Unreviewed.  Fix test-webkitpy under Python 2.5.
1382
1383         * Scripts/webkitpy/layout_tests/port/win.py:
1384
1385 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
1386
1387         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
1388         https://bugs.webkit.org/show_bug.cgi?id=65875
1389
1390         Reviewed by Kenneth Rohde Christiansen.
1391
1392         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
1393
1394         This causes mouse events to be sent twice in some cases. We work around the problem
1395         by defining the first touch point to be a primary touch point (case which hit some
1396         weird condition in QWidget, skipping the generation of fake mouse events).
1397
1398         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1399         (MiniBrowserApplication::notify):
1400
1401 2011-08-10  David Hyatt  <hyatt@apple.com>
1402
1403         https://bugs.webkit.org/show_bug.cgi?id=66004
1404
1405         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
1406         the code on by default.
1407
1408         Reviewed by Adam Roben.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/config.json:
1411         * Scripts/build-webkit:
1412
1413 2011-08-10  Oliver Hunt  <oliver@apple.com>
1414
1415         JSEvaluteScript does not return the correct object when given JSONP data
1416         https://bugs.webkit.org/show_bug.cgi?id=66003
1417
1418         Reviewed by Gavin Barraclough.
1419
1420         Add a test case.
1421
1422         * DumpRenderTree/mac/DumpRenderTree.mm:
1423         (testStringByEvaluatingJavaScriptFromString):
1424
1425 2011-08-10  Eric Seidel  <eric@webkit.org>
1426
1427         WIN: NRWT runs compositing tests on configurations that don't support compositing
1428         https://bugs.webkit.org/show_bug.cgi?id=64472
1429
1430         Reviewed by Adam Barth.
1431
1432         I think the code was just wrong.  It was never splitting the string
1433         into list pieces before.
1434         I've now tested the supported_features code and theoretically it
1435         should now work with Windows DRT.
1436
1437         I also made the list-lookup functions always return lists, to make
1438         it possible to clean up the list-transform code in the future
1439         (I opted not to do that cleanup in this patch, but at least now
1440         both types of feature lookup functions match return types.)
1441
1442         * Scripts/webkitpy/layout_tests/port/webkit.py:
1443         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1444
1445 2011-08-10  Eric Seidel  <eric@webkit.org>
1446
1447         Clean up ChromiumDriver a little
1448         https://bugs.webkit.org/show_bug.cgi?id=65995
1449
1450         Unreviewed.
1451
1452         Fix NRWT for chromium.  Silly python.
1453
1454         * Scripts/webkitpy/layout_tests/port/chromium.py:
1455
1456 2011-08-10  Eric Seidel  <eric@webkit.org>
1457
1458         Clean up ChromiumDriver a little
1459         https://bugs.webkit.org/show_bug.cgi?id=65995
1460
1461         Reviewed by Adam Barth.
1462
1463         - We no longer support threading, so remove threading specific code.
1464         - Add FIXMEs about using ServerProcess instead.
1465         - Condense option-mapping if-cascade into a for loop.
1466         - Unindent long if blocks by using early return.
1467         - Unwrap lines which are needlessly wrapped.
1468
1469         There should be no functional changes here, just code cleanup/dead-code removal.
1470
1471         * Scripts/webkitpy/layout_tests/port/chromium.py:
1472
1473 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
1474
1475         Unmuddle construction options for TestConfiguration.
1476         https://bugs.webkit.org/show_bug.cgi?id=65988
1477
1478         The TestConfiguration instance is now constructed only using actual values.
1479         Port-based construction is split into a "from_port" class method.
1480
1481         Reviewed by Eric Seidel.
1482
1483         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
1484         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
1485         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
1486         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
1487         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
1488
1489 2011-08-10  Eric Seidel  <eric@webkit.org>
1490
1491         Leaks bot shows python logging prefixes as part of summary display
1492         https://bugs.webkit.org/show_bug.cgi?id=65931
1493
1494         Reviewed by Adam Barth.
1495
1496         The big part of this change is adding a unittesting system for
1497         master.cfg, so mere-mortals can make changes to build.webkit.org
1498         with greatly-reduced risk of breaking the world.
1499
1500         Turns out that in typing up my trival logging fix I made 2 typos,
1501         so hopefully the hour spent getting master.cfg to load was worth it. :)
1502
1503         I also tried to make mastercfg_unittest run as part of test-webkitpy
1504         but right now test-webkitpy requires that unittest files be located in
1505         a module-name-compatible directory.  'build.webkit.org-config' is not
1506         a valid module name.
1507
1508         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1509          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
1510            by using a new _strip_python_logging_prefix function.
1511          - Also fixed this function to file to work with a more modern
1512            simplejson version (which returns unicode objects instead of str objects)
1513            and filed a related bug with buildbot.net due to their handling of unicode builder names.
1514         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
1515          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
1516          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
1517         * Scripts/webkitpy/thirdparty/__init__.py:
1518          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
1519
1520 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
1521
1522         garden-o-matic should extrapolate failures given a set of known results
1523         https://bugs.webkit.org/show_bug.cgi?id=65882
1524
1525         Reviewed by Adam Barth.
1526
1527         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
1528         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
1529             adjusted all call sites.
1530         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
1531             makes wider net for specific failures.
1532         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
1533
1534 2011-08-10  Adam Barth  <abarth@webkit.org>
1535
1536         The URL we were computing for retrieving baselines was missing a slash
1537         character because our mocks had an extra slash character.  I've
1538         corrected both the code and the mock.
1539
1540         * Scripts/webkitpy/tool/commands/rebaseline.py:
1541         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1542         * Scripts/webkitpy/tool/mocktool.py:
1543
1544 2011-08-09  Adam Barth  <abarth@webkit.org>
1545
1546         Move the quote mark to the right place.
1547
1548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1549
1550 2011-08-09  Adam Barth  <abarth@webkit.org>
1551
1552         garden-o-matic should use huerstics to narrow regression range
1553         https://bugs.webkit.org/show_bug.cgi?id=65948
1554
1555         Reviewed by Dimitri Glazkov.
1556
1557         When analyzing a regression range, if one of the commit messages
1558         mentions the test in question, we now hueristically assume that
1559         revision caused the failure.  (I'm shamelessly stealing this idea from
1560         TestFailures.)
1561
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
1563
1564 2011-07-13  Eric Seidel  <eric@webkit.org>
1565
1566         new-run-webkit-test's WinPort has no fallback logic
1567         https://bugs.webkit.org/show_bug.cgi?id=64486
1568
1569         Reviewed by Adam Roben.
1570
1571         I've tried to write a patch for bug 64439 twice now, and both times
1572         I've ended up re-writing half the port system.  So I'm breaking
1573         things up into smaller pieces, this being the first.
1574
1575         WinPort still does not have any port_name parsing, so when instantiated
1576         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
1577         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
1578
1579         Otherwise this should "just work" for windows.  I've not been able to test the
1580         version detection on my mac, but the unit tests show the code behaving as designed.
1581
1582         * Scripts/webkitpy/layout_tests/port/win.py:
1583         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
1584
1585 2011-08-09  Adam Barth  <abarth@webkit.org>
1586
1587         Teach build.webkit.org's garden-o-matic how to talk to the local server
1588         https://bugs.webkit.org/show_bug.cgi?id=65940
1589
1590         Reviewed by Dimitri Glazkov.
1591
1592         After this patch, the version of garden-o-matic on build.webkit.org is
1593         fully functional.  It can interact with the local server via CORS.
1594
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
1598         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1599         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1600
1601 2011-08-09  Adam Barth  <abarth@webkit.org>
1602
1603         Enable CORS for garden-o-matic
1604         https://bugs.webkit.org/show_bug.cgi?id=65936
1605
1606         Reviewed by Dimitri Glazkov.
1607
1608         This patch will allow the hosted instance of garden-o-matic to
1609         communicate with the local server.
1610
1611         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1612         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1613
1614 2011-08-09  Adam Barth  <abarth@webkit.org>
1615
1616         Upgrade jquery in TestFailures
1617         https://bugs.webkit.org/show_bug.cgi?id=65935
1618
1619         Reviewed by Dimitri Glazkov.
1620
1621         Upgrade to a newer version of jQuery with better support for CORS and CSP.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1626
1627 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1628
1629         Unreviewed, rolling out r92683.
1630         http://trac.webkit.org/changeset/92683
1631         https://bugs.webkit.org/show_bug.cgi?id=65921
1632
1633          "Breaks Qt --minimal build. Revert pending update of the Qt
1634         minimal configuration" (Requested by simathur on #webkit).
1635
1636         * QtTestBrowser/cookiejar.cpp:
1637         (TestBrowserCookieJar::TestBrowserCookieJar):
1638         * QtTestBrowser/launcherwindow.cpp:
1639         (LauncherWindow::createChrome):
1640         (LauncherWindow::setDiskCache):
1641         * QtTestBrowser/main.cpp:
1642         (LauncherApplication::handleUserOptions):
1643         * QtTestBrowser/webpage.cpp:
1644         (WebPage::openUrlInDefaultBrowser):
1645
1646 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
1647
1648         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
1649         https://bugs.webkit.org/show_bug.cgi?id=65880
1650
1651         Reviewed by Andreas Kling.
1652
1653         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
1654         check for their feature flags. Assume that any reasonable Qt build provides them. 
1655         * QtTestBrowser/cookiejar.cpp:
1656         (TestBrowserCookieJar::TestBrowserCookieJar):
1657         * QtTestBrowser/launcherwindow.cpp:
1658         (LauncherWindow::createChrome):
1659         (LauncherWindow::setDiskCache):
1660         * QtTestBrowser/main.cpp:
1661         (LauncherApplication::handleUserOptions):
1662         * QtTestBrowser/webpage.cpp:
1663         (WebPage::openUrlInDefaultBrowser):
1664
1665 2011-08-09  Adam Barth  <abarth@webkit.org>
1666
1667         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
1668         https://bugs.webkit.org/show_bug.cgi?id=65891
1669
1670         Reviewed by Eric Seidel.
1671
1672         The problem was that platform/chromium contained a bogus expectation
1673         file that needed to be removed, but by the time we got around to
1674         removing it, we'd already moved the correct baseline into its place.
1675         After this patch, we copy the gold results into memory before
1676         reshuffling things on disk (and we delete bad things before adding good
1677         things).
1678
1679         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1680         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1681
1682 2011-08-08  Adam Barth  <abarth@webkit.org>
1683
1684         Chromium Windows bots can't figure out what SVN revision they're running
1685         https://bugs.webkit.org/show_bug.cgi?id=65893
1686
1687         Reviewed by Eric Seidel.
1688
1689         The comment in _engage_awesome_windows_hacks explains why we're making
1690         this change.  It's ugly and rediculous, but this approach seems better
1691         than using shell=True when calling popen.
1692
1693         * Scripts/webkitpy/common/checkout/scm/svn.py:
1694         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1695
1696 2011-08-08  Adam Barth  <abarth@webkit.org>
1697
1698         Remove deduplicate-tests
1699         https://bugs.webkit.org/show_bug.cgi?id=65886
1700
1701         Reviewed by Tony Chang.
1702
1703         This script is redundant with "webkit-patch bulk-optimize-baselines",
1704         which can find many more duplicates than deduplicate-tests because
1705         bulk-optimize-baselines can move results around whereas
1706         deduplicate-tests can only remove results.
1707
1708         * Scripts/deduplicate-tests: Removed.
1709         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
1710         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
1711
1712 2011-08-08  Adam Barth  <abarth@webkit.org>
1713
1714         scm.delete should delete empty parent directories as well
1715         https://bugs.webkit.org/show_bug.cgi?id=65878
1716
1717         Reviewed by Eric Seidel.
1718
1719         This behavior makes SVN match GIT (which has no concept of empty
1720         directories).  This bug comes up a lot when optimizing baselines, which
1721         often create empty directories when we're able to optimize everything
1722         out of a given folder.
1723
1724         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1725         * Scripts/webkitpy/common/checkout/scm/svn.py:
1726
1727 2011-08-08  Lucas Forschler  <lforschler@apple.com>
1728
1729         Add triggers for Lion WK2 test bots.
1730
1731         Reviewed by Stephanie Lewis.
1732
1733         * BuildSlaveSupport/build.webkit.org-config/config.json:
1734
1735 2011-08-08  Adam Barth  <abarth@webkit.org>
1736
1737         bulk-optimize-baselines should take directories on the command line
1738         https://bugs.webkit.org/show_bug.cgi?id=65879
1739
1740         Reviewed by Dimitri Glazkov.
1741
1742         Passing lists of tests via stdin is a pain.  It's easier if the command
1743         takes a list of tests on the command line, like run-webkit-tests.
1744
1745         * Scripts/webkitpy/tool/commands/rebaseline.py:
1746
1747 2011-08-08  Adam Barth  <abarth@webkit.org>
1748
1749         Deprecate rebaseline-chromium-webkit-tests
1750         https://bugs.webkit.org/show_bug.cgi?id=65873
1751
1752         Reviewed by Dimitri Glazkov.
1753
1754         This script never worked correctly and now is redundant with more
1755         modern infrastructure for rebaselining tests.  This patch deprecates
1756         the script in order to flush out any issues with the new tools.  Once
1757         folks are happy with the new tools, we'll delete this script.
1758
1759         * Scripts/rebaseline-chromium-webkit-tests:
1760
1761 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
1762
1763         garden-o-matic should only touch expectations that need updating.
1764         https://bugs.webkit.org/show_bug.cgi?id=65876
1765
1766         Reviewed by Adam Barth.
1767
1768         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
1769             so that a caller could influence which lines to serialize from values.
1770         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
1771         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
1772         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
1773
1774 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
1775
1776         TestExpectationsEditor should return a list of updated expectations.
1777         https://bugs.webkit.org/show_bug.cgi?id=65872
1778
1779         Reviewed by Adam Barth.
1780
1781         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
1782         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
1783
1784 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
1785
1786         Fix SCM webkitpy unit test failures
1787         https://bugs.webkit.org/show_bug.cgi?id=65823
1788
1789         Reviewed by Eric Seidel.
1790
1791         * Scripts/webkitpy/common/checkout/scm/git.py:
1792         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1793
1794 2011-08-08  Eric Seidel  <eric@webkit.org>
1795
1796         Move the --leaks bot back over to NRWT now that I'm back
1797         from vacation and able to debug it.
1798
1799         Unreviewed.
1800
1801         * Scripts/run-webkit-tests:
1802         (usingWebKit2):
1803         (useNewRunWebKitTests):
1804
1805 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
1806
1807         Wire up updating expectations in garden-o-matic.
1808         https://bugs.webkit.org/show_bug.cgi?id=65794
1809
1810         Reviewed by Adam Barth.
1811
1812         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
1813         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
1814         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
1815         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
1816
1817 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
1818
1819         webkit-patch doesn't get along with renamed files
1820         https://bugs.webkit.org/show_bug.cgi?id=48075
1821
1822         Possibly a bit heavy handed - I removed all instances of -C and
1823         changed every instance of -M with '--no-renames' in git.py. This
1824         forces git to not try to tell us about renames at all, which is
1825         ultimately the behaviour we want. The old file is shown deleted,
1826         then the new file is shown added, followed by any changes that
1827         occurred. Also gets rid of the problem where deleting one file
1828         and adding another file which has similar content would
1829         unexpectedly show up as a rename, and fall out of a diff.
1830
1831         Based on a patch by Wyatt Carss.
1832
1833         Reviewed by Eric Seidel.
1834
1835         * Scripts/webkitpy/common/checkout/scm/git.py:
1836
1837 2011-08-07  Sam White  <samuel.white@rochester.edu>
1838
1839         Add the ability to search the AccessibilityObject cache
1840         https://bugs.webkit.org/show_bug.cgi?id=64994
1841         
1842         Added testing support for AccessibilityObject cache searching. Currently,
1843         only the mac platform is full supported and has had API exposed. Other
1844         platforms have only have this new functionality stubbed. Full implementation
1845         is a job suited only for an accessibility expert of each respective platform.
1846
1847         Reviewed by Chris Fleizach.
1848
1849         * DumpRenderTree/AccessibilityUIElement.cpp:
1850         (uiElementForSearchPredicateCallback):
1851         (AccessibilityUIElement::getJSClass):
1852         * DumpRenderTree/AccessibilityUIElement.h:
1853         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1854         (AccessibilityUIElement::uiElementForSearchPredicate):
1855         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1856         (AccessibilityUIElement::uiElementForSearchPredicate):
1857         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1858         (AccessibilityUIElement::uiElementForSearchPredicate):
1859
1860 2011-08-06  Adam Barth  <abarth@webkit.org>
1861
1862         Remove dead code in webkitpy
1863         https://bugs.webkit.org/show_bug.cgi?id=65818
1864
1865         Reviewed by Dimitri Glazkov.
1866
1867         This code was added to support the rebaseline2 command six months ago,
1868         but the rebaseline2 command was never finished and no one else has used
1869         this code since it was landed.  This patch removes the dead code.  If
1870         we revive rebaseline2, then we can revert this patch and recover the
1871         code.  Until then, this code is just dead weight.
1872
1873         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1874         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1875         * Scripts/webkitpy/common/net/testoutput.py: Removed.
1876         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
1877         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
1878         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
1879         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
1880         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
1881         * Scripts/webkitpy/layout_tests/port/base.py:
1882         * Scripts/webkitpy/layout_tests/port/chromium.py:
1883         * Scripts/webkitpy/layout_tests/port/webkit.py:
1884
1885 2011-08-06  Adam Barth  <abarth@webkit.org>
1886
1887         webkit-patch optimize-baselines can't handle promotions to base results directory
1888         https://bugs.webkit.org/show_bug.cgi?id=65819
1889
1890         Reviewed by Dimitri Glazkov.
1891
1892         This bug came up when testing the optimizer on some editing baselines.
1893
1894         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1895         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1896
1897 2011-08-06  Adam Barth  <abarth@webkit.org>
1898
1899         Add a small command to optimize baselines in bulk.
1900
1901         * Scripts/webkitpy/tool/commands/rebaseline.py:
1902
1903 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
1904
1905         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
1906
1907         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
1908
1909 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
1910
1911         Garden-o-matic updateexpectations needs a unit test.
1912         https://bugs.webkit.org/show_bug.cgi?id=65780
1913
1914         Reviewed by Adam Barth.
1915
1916         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
1917
1918 2011-08-05  Anders Carlsson  <andersca@apple.com>
1919
1920         Future proof an Objective-C test
1921         https://bugs.webkit.org/show_bug.cgi?id=65788
1922
1923         Reviewed by Dan Bernstein.
1924
1925         Add isObjectInstanceOf to ObjCController.
1926
1927         * DumpRenderTree/mac/ObjCController.m:
1928         (+[ObjCController isSelectorExcludedFromWebScript:]):
1929         (+[ObjCController webScriptNameForSelector:]):
1930         (-[ObjCController isObject:instanceOf:]):
1931
1932 2011-08-05  Adam Barth  <abarth@webkit.org>
1933
1934         trac.js needs unittests
1935         https://bugs.webkit.org/show_bug.cgi?id=65673
1936
1937         Reviewed by Dimitri Glazkov.
1938
1939         This tests also have somewhat large fixtures.  I've trimmed the example
1940         XML down a bunch while still hitting interesting cases in the parsing.
1941
1942         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1943         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
1944
1945 2011-08-05  Adam Barth  <abarth@webkit.org>
1946
1947         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
1948         https://bugs.webkit.org/show_bug.cgi?id=65759
1949
1950         Reviewed by Dimitri Glazkov.
1951
1952         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
1953         architecture, is poorly tested, and has a bunch of quirks.  This patch
1954         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
1955         top of more modern infrastructure.  In the process, we get more code
1956         re-use and better testing.
1957
1958         Once we're satisfied with this new implementation, we can delete the
1959         old implementation.
1960
1961         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1962         * Scripts/webkitpy/common/net/web.py:
1963         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1964         * Scripts/webkitpy/layout_tests/port/builders.py:
1965         * Scripts/webkitpy/layout_tests/port/chromium.py:
1966         * Scripts/webkitpy/layout_tests/port/factory.py:
1967         * Scripts/webkitpy/layout_tests/port/webkit.py:
1968         * Scripts/webkitpy/tool/commands/rebaseline.py:
1969         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1970
1971 2011-08-05  Anders Carlsson  <andersca@apple.com>
1972
1973         Remove PluginHalter
1974         https://bugs.webkit.org/show_bug.cgi?id=65729
1975
1976         Reviewed by Darin Adler.
1977
1978         Remove call to set the allowed plug-in run time.
1979
1980         * DumpRenderTree/mac/DumpRenderTree.mm:
1981         (resetDefaultsToConsistentValues):
1982
1983 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
1984
1985         Unreviewed build fix for Qt-Minimal buildbot
1986
1987         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
1988         is disabled.
1989
1990         Rubber-stamped by Holger Freyther.
1991
1992         * QtTestBrowser/cookiejar.cpp:
1993         (TestBrowserCookieJar::TestBrowserCookieJar):
1994
1995 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1996
1997         [Qt] QtTestBrowser: Add support for saving cookies on disk
1998         https://bugs.webkit.org/show_bug.cgi?id=65328
1999
2000         Simple cookiejar that saves cookies on disk.
2001
2002         Added menu options to clear cookies (Edit->Clear cookies) and
2003         disable disk cookies (Settings->[ ]Save Cookies on Disk).
2004
2005         Option -no-disk-cookies is also available.
2006
2007         Reviewed by Andreas Kling.
2008
2009         * QtTestBrowser/QtTestBrowser.pro:
2010         * QtTestBrowser/cookiejar.cpp: Added.
2011         * QtTestBrowser/cookiejar.h: Added.
2012         * QtTestBrowser/launcherwindow.cpp:
2013         * QtTestBrowser/launcherwindow.h:
2014         * QtTestBrowser/main.cpp:
2015
2016 2011-08-04  Adam Barth  <abarth@webkit.org>
2017
2018         model.js needs some unit testing
2019         https://bugs.webkit.org/show_bug.cgi?id=65730
2020
2021         Reviewed by Dimitri Glazkov.
2022
2023         These tests do not cover all the functions exported by the model
2024         module.  We'll need to add the remaining ones in the future.
2025
2026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2028
2029 2011-08-04  Adam Barth  <abarth@webkit.org>
2030
2031         Another speculative fix for the "svn revision on Windows" problem.
2032
2033         * Scripts/webkitpy/common/checkout/scm/git.py:
2034
2035 2011-08-04  Mark Rowe  <mrowe@apple.com>
2036
2037         Future-proof Xcode configuration settings.
2038
2039         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2040         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
2041         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2042         * MiniBrowser/Configurations/Base.xcconfig:
2043         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
2044         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2045         * TestWebKitAPI/Configurations/Base.xcconfig:
2046         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
2047         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2048         * WebKitTestRunner/Configurations/Base.xcconfig:
2049         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
2050         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2051
2052 2011-08-04  Adam Barth  <abarth@webkit.org>
2053
2054         Fancier debug logging.
2055
2056         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2057
2058 2011-08-04  David Levin  <levin@chromium.org>
2059
2060         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
2061         https://bugs.webkit.org/show_bug.cgi?id=65685
2062
2063         Reviewed by Dmitry Titov.
2064
2065         * DumpRenderTree/chromium/WebViewHost.cpp:
2066         (WebViewHost::WebViewHost): Intialize WTF threading before
2067         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
2068         but in some cases code may use WTF without creating WebViewImpl and
2069         WTF code functionality may call WTF::currentThread, which requires
2070         this initialization now.
2071
2072 2011-08-04  Adam Barth  <abarth@webkit.org>
2073
2074         An educated guess at causing the Windows bots on build.webkit.org to
2075         find the SVN revision number.
2076
2077         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2078         * Scripts/webkitpy/layout_tests/port/base.py:
2079
2080 2011-08-04  Adam Barth  <abarth@webkit.org>
2081
2082         More logging to help debug the "no SVN rev on Chromium Windows bots"
2083         bug.  My current theory is that we're trying to detect the SCM system
2084         in the wrong directory.
2085
2086         * Scripts/webkitpy/layout_tests/port/base.py:
2087
2088 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
2089
2090         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
2091         https://bugs.webkit.org/show_bug.cgi?id=65697
2092
2093         I neglected to realize that collecting test names is not necessary for this operation.
2094
2095         Reviewed by Adam Barth.
2096
2097         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
2098
2099 2011-08-04  Adam Barth  <abarth@webkit.org>
2100
2101         checkout_unittest.js should have better coverage of checkout.js
2102         https://bugs.webkit.org/show_bug.cgi?id=65671
2103
2104         Reviewed by Dimitri Glazkov.
2105
2106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2107             - Remove unused functions.
2108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2109             - Test remaining public functions in the checkout module.
2110
2111 2011-08-04  Dmitry Lomov  <dslomov@google.com>
2112
2113         https://bugs.webkit.org/show_bug.cgi?id=65706
2114         Run run-unit-tests on release mode test bots.
2115         Reenabling after 61812 is fixed.
2116
2117         Reviewed by Adam Roben.
2118
2119         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2120
2121 2011-08-04  Adam Barth  <abarth@webkit.org>
2122
2123         builders.js needs unit tests
2124         https://bugs.webkit.org/show_bug.cgi?id=65670
2125
2126         Reviewed by Dimitri Glazkov.
2127
2128         This test requires somewhat large test fixtures, but using real
2129         examples seemed better than trimming them down too much.
2130
2131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
2133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2134             - Note: trac_unittests.js doesn't exist (yet!).
2135
2136 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
2137
2138         [Qt] Make navigation actions properly usable in QML.
2139         https://bugs.webkit.org/show_bug.cgi?id=65624
2140
2141         Fix compilation after the introduction of QWebNavigationController.
2142
2143         Reviewed by Benjamin Poulain.
2144
2145         * MiniBrowser/qt/BrowserView.cpp:
2146         (BrowserView::navigationAction):
2147
2148 2011-08-04  Adam Barth  <abarth@webkit.org>
2149
2150         Another subtle bug due to lack of testing in main.js.  :(
2151
2152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2153
2154 2011-08-04  Adam Barth  <abarth@webkit.org>
2155
2156         Fix types.  Sadly, main.js has no test coverage.  (I need to think
2157         about how to test this part of the code.)
2158
2159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2160
2161 2011-08-04  Adam Barth  <abarth@webkit.org>
2162
2163         bugzilla.js is missing unit tests
2164         https://bugs.webkit.org/show_bug.cgi?id=65656
2165
2166         Reviewed by Adam Roben.
2167
2168         Testing makes perfect.
2169
2170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
2172         (NetworkSimulator.prototype.runTest.get if):
2173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2174
2175 2011-08-04  Adam Barth  <abarth@webkit.org>
2176
2177         Add missing license blocks to garden-o-matic
2178         https://bugs.webkit.org/show_bug.cgi?id=65654
2179
2180         Reviewed by Dimitri Glazkov.
2181
2182         This patch is entirely boilerplate.
2183
2184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
2185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
2190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
2196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2202
2203 2011-08-04  Adam Barth  <abarth@webkit.org>
2204
2205         garden-o-matic needs a way to mock out the network
2206         https://bugs.webkit.org/show_bug.cgi?id=65653
2207
2208         Reviewed by Dimitri Glazkov.
2209
2210         This patch introduces the net module, which is a useful mock point for
2211         abstracting away the network.  Future patches will use this
2212         infrastructure to test some currently untested code.
2213
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
2223         (NetworkSimulator):
2224         (NetworkSimulator.prototype.scheduleCallback):
2225         (NetworkSimulator.prototype.runTest):
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2229         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2230
2231 2011-08-03  Adam Barth  <abarth@webkit.org>
2232
2233         Use failureInfo more pervasively in garden-o-matic
2234         https://bugs.webkit.org/show_bug.cgi?id=65650
2235
2236         Reviewed by Dimitri Glazkov.
2237
2238         These three variable appears in concert together many places.  This
2239         patch unifies the remaining uses into being failureInfo objects, which
2240         saves some marshalling.
2241
2242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
2247
2248 2011-08-03  Adam Barth  <abarth@webkit.org>
2249
2250         garden-o-matic should be able to update expecations from the details pane
2251         https://bugs.webkit.org/show_bug.cgi?id=65648
2252
2253         Reviewed by Dimitri Glazkov.
2254
2255         The new button queues up the updates, which get executed all at once.
2256
2257         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2260
2261 2011-08-03  Adam Barth  <abarth@webkit.org>
2262
2263         Add UI to garden-o-matic for updating expectations
2264         https://bugs.webkit.org/show_bug.cgi?id=65644
2265
2266         Reviewed by Dimitri Glazkov.
2267
2268         The patch plumbs the UI back to the gardening server, but the gardening
2269         server endpoint is just a stub at this point.
2270
2271         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2275         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2276         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2277
2278 2011-08-03  Adam Barth  <abarth@webkit.org>
2279
2280         garden-o-matic details view should queue rebaselines for later execution
2281         https://bugs.webkit.org/show_bug.cgi?id=65636
2282
2283         Reviewed by Dimitri Glazkov.
2284
2285         This patch doesn't contain any confirmation UI, but we'll probably want
2286         that at some point.
2287
2288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2290         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2292
2293 2011-08-03  Kentaro Hara  <haraken@google.com>
2294
2295         Implement EventSender.scalePageBy()
2296         https://bugs.webkit.org/show_bug.cgi?id=58013
2297
2298         Reviewed by Darin Fisher.
2299
2300         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
2301         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
2302         for the implementation of EventSender.scalePageBy(f, x, y).
2303
2304         Tests: compositing/scaling/tiled-layer-recursion.html
2305                fast/repaint/scale-page-shrink.html
2306                fast/dom/Element/scale-page-client-rects.html
2307                fast/dom/Range/scale-page-client-rects.html
2308                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
2309                fast/dom/Element/scale-page-bounding-client-rect.html
2310                fast/dom/Range/scale-page-bounding-client-rect.html
2311
2312         * DumpRenderTree/chromium/EventSender.cpp:
2313         (EventSender::EventSender): Added bindings for scalePageBy().
2314         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
2315         * DumpRenderTree/chromium/EventSender.h:
2316         * DumpRenderTree/chromium/TestShell.cpp:
2317         (TestShell::resetTestController): Resets the scale factor to 1.
2318
2319 2011-08-03  David Levin  <levin@chromium.org>
2320
2321         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
2322         https://bugs.webkit.org/show_bug.cgi?id=65652
2323
2324         Reviewed by Adam Barth.
2325
2326         * Scripts/webkitpy/style/checkers/cpp.py:
2327         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2328
2329 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
2330
2331         Adding Filip Pizlo to committer list.
2332
2333         Unreviewed.
2334
2335         * Scripts/webkitpy/common/config/committers.py:
2336
2337 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2338
2339         Add "optimize-expectations" command to webkit-patch.
2340         https://bugs.webkit.org/show_bug.cgi?id=65633
2341
2342         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
2343
2344         Reviewed by Adam Barth.
2345
2346         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
2347         * Scripts/webkitpy/tool/commands/expectations.py: Added.
2348
2349 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2350
2351         Allow multiple bug identifiers in test expectations.
2352         https://bugs.webkit.org/show_bug.cgi?id=65642
2353
2354         Reviewed by Adam Barth.
2355
2356         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
2357         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2358
2359 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
2360
2361         Teach BuilderToPort to distinguish between Release and Debug builders.
2362         https://bugs.webkit.org/show_bug.cgi?id=65628
2363
2364         Reviewed by Adam Barth.
2365
2366         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
2367         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
2368
2369 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2370
2371         [Qt] Fix running qmltests for WK2 in the bot
2372         https://bugs.webkit.org/show_bug.cgi?id=65621
2373
2374         Reviewed by Csaba Osztrogonác.
2375
2376         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
2377         but now there's the case for WK2 UIProcess tests as well.
2378
2379         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
2380
2381 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
2382
2383         Add a way to edit test expectations.
2384         https://bugs.webkit.org/show_bug.cgi?id=64922
2385
2386         Implements a TestExpectationsEditor, which provides a standard way to
2387         update and remove test expectations.
2388
2389         Reviewed by Adam Barth.
2390
2391         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
2392             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
2393             enchilada.
2394         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
2395
2396 2011-08-03  Andreas Kling  <kling@webkit.org>
2397
2398         [Qt] MiniBrowser: Unbreak load progress indication.
2399         https://bugs.webkit.org/show_bug.cgi?id=65614
2400
2401         Reviewed by Kenneth Rohde Christiansen.
2402
2403         loadProgress() was renamed to loadProgressChanged().
2404
2405         * MiniBrowser/qt/BrowserWindow.cpp:
2406         (BrowserWindow::BrowserWindow):
2407         (BrowserWindow::onLoadProgressChanged):
2408         * MiniBrowser/qt/BrowserWindow.h:
2409
2410 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
2411
2412         Build fix for WebKit2GTK+.
2413
2414         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
2415         of the library dependencies of the injected bundle.
2416
2417 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2418
2419         [GTK] Install web and plugin processes in libexecdir instead of bindir
2420         https://bugs.webkit.org/show_bug.cgi?id=65600
2421
2422         Reviewed by Martin Robinson.
2423
2424         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
2425         process from current directory instead of the intalled ones.
2426
2427         * MiniBrowser/gtk/GNUmakefile.am:
2428         * MiniBrowser/gtk/main.c:
2429         (main):
2430         * WebKitTestRunner/GNUmakefile.am:
2431         * WebKitTestRunner/gtk/main.cpp:
2432         (main):
2433
2434 2011-08-02  Anders Carlsson  <andersca@apple.com>
2435
2436         Add mac-lion platform to old-run-webkit-tests
2437         https://bugs.webkit.org/show_bug.cgi?id=65577
2438
2439         * Scripts/old-run-webkit-tests:
2440         * Scripts/webkitdirs.pm:
2441         (isLion):
2442
2443 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2444
2445         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
2446         https://bugs.webkit.org/show_bug.cgi?id=65554
2447
2448         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
2449
2450         Reviewed by Adam Roben.
2451
2452         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2453
2454 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
2455
2456         Implement WebPermissionClient::allowPlugins for layout tests
2457         https://bugs.webkit.org/show_bug.cgi?id=33991
2458
2459         Reviewed by Adam Barth.
2460
2461         * DumpRenderTree/chromium/LayoutTestController.cpp:
2462         (LayoutTestController::LayoutTestController):
2463         (LayoutTestController::setPluginsAllowed):
2464         * DumpRenderTree/chromium/LayoutTestController.h:
2465         * DumpRenderTree/chromium/WebPermissions.cpp:
2466         (WebPermissions::allowPlugins):
2467         (WebPermissions::setPluginsAllowed):
2468         (WebPermissions::reset):
2469         * DumpRenderTree/chromium/WebPermissions.h:
2470
2471 2011-08-02  Adam Barth  <abarth@webkit.org>
2472
2473         TestFailures unit tests leak a global variable
2474         https://bugs.webkit.org/show_bug.cgi?id=65500
2475
2476         Reviewed by Adam Roben.
2477
2478         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
2479
2480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
2481
2482 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
2483
2484         CSS Regions build bot should archive and upload output files
2485         https://bugs.webkit.org/show_bug.cgi?id=65200
2486
2487         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
2488         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
2489         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
2490         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
2491
2492         The "features" argument is now taken into account when determining the name of the archive on the server. That
2493         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
2494
2495         Reviewed by Adam Roben.
2496
2497         * BuildSlaveSupport/build.webkit.org-config/config.json:
2498         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2499
2500 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
2501
2502         Fix _win32_check_running_pid on 64bit windows python
2503         https://bugs.webkit.org/show_bug.cgi?id=64950
2504
2505         Reviewed by Adam Roben.
2506
2507         Use the correct types for the PROCESSENTRY32 struct.
2508         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
2509         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
2510         failure, when calling the Process32First function.
2511         This is covered by the executive unittest.
2512
2513         * Scripts/webkitpy/common/system/executive.py:
2514
2515 2011-08-01  Adam Barth  <abarth@webkit.org>
2516
2517         garden-o-matic should call optimize-baselines when rebaselining tests
2518         https://bugs.webkit.org/show_bug.cgi?id=65499
2519
2520         Reviewed by Dimitri Glazkov.
2521
2522         I took the opportunity to modernize this code to use some of our more
2523         powerful primitives from base.
2524
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
2526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
2527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
2528         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2529         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2530
2531 2011-08-01  Stephanie Lewis  <slewis@apple.com>
2532
2533         Finish reconfiguration started by Lucas Forschler
2534         Reconfigured slaves:
2535         Removed Leopard Intel Release (Build)
2536         Removed Leopard Intel Release (Tests)
2537         Remove apple-pixel-1
2538         Added Lion slaves from disabled Leopard slaves
2539
2540         Added builders:
2541         Lion Intel Release (Build)
2542         Lion Intel Debug (Build)
2543         Lion Intel Release (Tests)
2544         Lion Intel Release WK2 (Tests)
2545         Lion Intel Debug (Tests)
2546         Lion Intel Debug WK2 (Tests)
2547
2548         Added triggers:
2549         lion-intel-debug-tests
2550         lion-intel-debug-test-wk2
2551         lion-intel-release-tests
2552         lion-intel-release-tests-wk2
2553         
2554         Removed trigger:
2555         leopard-intel-release-tests
2556
2557         Added PlatformSpecificScheduler:
2558         mac-lion
2559
2560         Added "mac-lion" to build.py and build_unitttest.py
2561
2562         Reviewed by Mark Rowe.
2563
2564         * BuildSlaveSupport/build.webkit.org-config/config.json:
2565         * Scripts/webkitpy/common/config/build.py:
2566         * Scripts/webkitpy/common/config/build_unittest.py:
2567
2568  
2569 2011-08-01  Adam Barth  <abarth@webkit.org>
2570
2571         webkit-patch needs to be able to "optimize" the storage of baselines on disk
2572         https://bugs.webkit.org/show_bug.cgi?id=65418
2573
2574         Reviewed by Dimitri Glazkov.
2575
2576         If we're not careful when rebaselining tests, we can end up with lots
2577         of duplicate expected results files in the tree.  This patch adds a
2578         webkit-patch command that optimizes the storage of expected results on
2579         disk.
2580
2581         This command is similar to deduplicate-tests, except that it can move
2582         test results around rather than just remove duplicate results.
2583
2584         Unfortunately, this problem is very tricky because the baseline search
2585         structure is a hypergraph.  This patch include a huerstic optimizer
2586         that appears to work on a bunch of examples I've tried.  We'll likely
2587         need to refine it as gain experience.
2588
2589         * Scripts/webkitpy/common/system/filesystem.py:
2590         * Scripts/webkitpy/tool/commands/rebaseline.py:
2591
2592 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2593
2594         Teach TestExpectationSerializer about parsed expectations.
2595         https://bugs.webkit.org/show_bug.cgi?id=65444
2596
2597         This is a bit largish in size, but the essentials are:
2598         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
2599         * We now store original content of the expectation line on TestExpectationLine.
2600         * Lots of tests.
2601
2602         Reviewed by Adam Barth.
2603
2604         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
2605             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
2606             for all configurations.
2607         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
2608         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
2609             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
2610             changed to store and use TestExpectationLine.original_string.
2611         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
2612
2613 2011-08-01  Adam Barth  <abarth@webkit.org>
2614
2615         Remove unused functionality from gardeningserver
2616         https://bugs.webkit.org/show_bug.cgi?id=65479
2617
2618         Reviewed by Dimitri Glazkov.
2619
2620         We now handle these operations directly from the front-end.  That means
2621         they work even without the gardening server running!
2622
2623         Also, add some missing files to the list of static files.
2624
2625         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2626         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2627
2628 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
2629
2630         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
2631         https://bugs.webkit.org/show_bug.cgi?id=65413
2632
2633         Reviewed by Adam Barth.
2634
2635         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
2636             existing code to use it.
2637         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
2638
2639 2011-08-01  Adam Barth  <abarth@webkit.org>
2640
2641         Refactor bugzilla.js for use by garden-o-matic
2642         https://bugs.webkit.org/show_bug.cgi?id=65450
2643
2644         Reviewed by Dimitri Glazkov.
2645
2646         This patch refactors bugzilla.js to use the AsynchronousCache and
2647         updates the style to use a module instead of an object.  This patch
2648         then fixes all the existing code that uses this class to use the new
2649         API style.
2650
2651         This main benefit of this patch is we remove the tricky manual caching
2652         and this code is now available to use in garden-o-matic (since the
2653         dependency on Utilities.js is now gone).
2654
2655         I ran all the unit tests and poked around in TestFailures a bit to see
2656         that everything seemed to be working properly.
2657
2658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
2659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
2660         (FailingTestsBugForm):
2661         (FailingTestsBugForm.prototype._createBugTitle):
2662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
2664         (FlakyTestBugForm):
2665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
2666         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
2667         (NewBugForm):
2668         (NewBugForm.prototype.domElement):
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
2671         (TestRelatedBugForm):
2672         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
2673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
2674         (ViewController.prototype._displayBuilder.start):
2675         (ViewController.prototype._displayBuilder):
2676         (ViewController.prototype._domForAuxiliaryUIElements):
2677         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
2678         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
2679         (ViewController.prototype._domForPossiblyFlakyTests):
2680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2683
2684 2011-08-01  Adam Barth  <abarth@webkit.org>
2685
2686         garden-o-matic shouldn't require local server to determine if compile failed
2687         https://bugs.webkit.org/show_bug.cgi?id=65446
2688
2689         Reviewed by Dimitri Glazkov.
2690
2691         This patch adds some basic bindings for the buildbot JSON API.  I
2692         wanted to use Buildbot.js an Builder.js from the original TestFailures,
2693         but they make a number of WebKit-specific assumptions.  We'll
2694         eventually need to reconcile these pieces of code.
2695
2696         I should really add tests for this code, but that will require me to
2697         build a better mock network.  I'll be happy to do that in a follow-up
2698         patch.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
2701             - It's very unclear to me whether didFail is correct.  Supposedly
2702               the first entry here is the exit code of the step, which is 0 on
2703               success.  I suspect we'll need to improve this function over time.
2704         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
2707
2708 2011-08-01  Adam Barth  <abarth@webkit.org>
2709
2710         garden-o-matic should show all failures, even ones that it can't find a regression range for
2711         https://bugs.webkit.org/show_bug.cgi?id=65447
2712
2713         Reviewed by Dimitri Glazkov.
2714
2715         Previously, we just wouldn't display test failures that we couldn't
2716         identify a regression range for (or whose regression range had fallen
2717         off the page).  This patch just displays them at the end of the list,
2718         which is slightly (but not much) better.
2719
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2721
2722 2011-08-01  Jeff Miller  <jeffm@apple.com>
2723
2724         Windows build fix after r92096.
2725
2726         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
2727         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
2728
2729 2011-07-31  Anders Carlsson  <andersca@apple.com>
2730
2731         DownloadDecideDestinationCrash WebKit2 API tests crashes
2732         https://bugs.webkit.org/show_bug.cgi?id=65442
2733
2734         Reviewed by Sam Weinig.
2735
2736         Copy the 18-characters.html file to the destination directory so we won't
2737         crash trying to make an URL for it.
2738
2739         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2740
2741 2011-07-31  Anders Carlsson  <andersca@apple.com>
2742
2743         Fix SpacebarScrolling WebKit2 API test
2744         https://bugs.webkit.org/show_bug.cgi?id=65431
2745
2746         Reviewed by Sam Weinig.
2747
2748         Add a way to do platform-specific bundle initialization, and use it to disable smooth
2749         scrolling. Also make it possible for a test to load the injected bundle without actually running
2750         a test from it.
2751
2752         * TestWebKitAPI/InjectedBundleController.cpp:
2753         (TestWebKitAPI::InjectedBundleController::initialize):
2754         * TestWebKitAPI/InjectedBundleController.h:
2755         * TestWebKitAPI/PlatformUtilities.cpp:
2756         (TestWebKitAPI::Util::createContextWithInjectedBundle):
2757         * TestWebKitAPI/PlatformUtilities.h:
2758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2759         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2760         (TestWebKitAPI::TEST):
2761         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
2762         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2763         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
2764         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2765         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2766
2767 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
2768
2769         Use set comparison to find duplicate or overlapping specifiers in test expectations.
2770         https://bugs.webkit.org/show_bug.cgi?id=65430
2771
2772         Reviewed by Adam Barth.
2773
2774         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
2775             of a set is wrong.
2776         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
2777             regressions.
2778
2779 2011-07-31  Xan Lopez  <xlopez@igalia.com>
2780
2781         Group dependencies CFLAGS together.
2782
2783         * GNUmakefile.am: ditto.
2784
2785 2011-07-31  Daniel Bates  <dbates@webkit.org>
2786
2787         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
2788         (https://bugs.webkit.org/show_bug.cgi?id=65419).
2789
2790         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
2791
2792 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
2793
2794         Fix ports_unittest.py on native windows
2795         https://bugs.webkit.org/show_bug.cgi?id=64959
2796
2797         Reviewed by Adam Barth.
2798
2799         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
2800         The latter includes the interpreter executable required on native windows.
2801
2802         * Scripts/webkitpy/common/config/ports_unittest.py:
2803
2804 2011-07-30  Adam Barth  <abarth@webkit.org>
2805
2806         Properly escape regular expressions.  (Maybe these shouldn't be regular
2807         expressions?)
2808
2809         * Scripts/webkitpy/tool/commands/rebaseline.py:
2810
2811 2011-07-30  Adam Barth  <abarth@webkit.org>
2812
2813         Add support for Win7 to garden-o-matic.
2814
2815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
2816         * Scripts/webkitpy/tool/commands/rebaseline.py:
2817
2818 2011-07-30  Adam Barth  <abarth@webkit.org>
2819
2820         garden-o-matic regression ranges expand after fast bots start passing
2821         https://bugs.webkit.org/show_bug.cgi?id=65406
2822
2823         Reviewed by Dimitri Glazkov.
2824
2825         Once the gardener has fixed a problem, the fast bots pick up the fix,
2826         which means we end up using the slow bots to compute the regression
2827         range.  Unfortunately, the slow bots give us large regression ranges,
2828         leading to this strange effect where the regression range quality
2829         degrades as fixes roll in.
2830
2831         This patch causes us to remember the previous regression ranges we've
2832         seen and to use that information in the future, as long as it's
2833         consistent with the new information we receive.
2834
2835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2836
2837 2011-07-30  Adam Barth  <abarth@webkit.org>
2838
2839         garden-o-matic should have a Refresh button to update its display
2840         https://bugs.webkit.org/show_bug.cgi?id=65403
2841
2842         Reviewed by Dimitri Glazkov.
2843
2844         The refresh button should be faster and less disruptive than the browser's reload button.
2845
2846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
2848
2849 2011-07-30  Adam Barth  <abarth@webkit.org>
2850
2851         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
2852         https://bugs.webkit.org/show_bug.cgi?id=65231
2853
2854         Reviewed by Dimitri Glazkov.
2855
2856         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
2857
2858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2859
2860 2011-07-30  Adam Barth  <abarth@webkit.org>
2861
2862         garden-o-matic should strikeout revisions that have been rolled out
2863         https://bugs.webkit.org/show_bug.cgi?id=65227
2864
2865         Reviewed by Dimitri Glazkov.
2866
2867         This helps gardeners keep track of which problems have been solved.
2868
2869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
2870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
2871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
2872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
2873
2874 2011-07-30  Adam Barth  <abarth@webkit.org>
2875
2876         Add missing files to the server.
2877
2878         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2879
2880 2011-07-29  Adam Barth  <abarth@webkit.org>
2881
2882         Actually import the logging module!
2883
2884         * Scripts/webkitpy/common/checkout/scm/git.py:
2885
2886 2011-07-29  Adam Barth  <abarth@webkit.org>
2887
2888         More debug logging.  Maybe we're running the git version of this
2889         function somehow?  (That would explain why it doesn't work!)
2890
2891         * Scripts/webkitpy/common/checkout/scm/git.py:
2892
2893 2011-07-29  Adam Barth  <abarth@webkit.org>
2894
2895         Add some temporary debug logging messages to try to understand why the
2896         windows bots can't figure out their current SVN revision.
2897
2898         * Scripts/webkitpy/common/checkout/scm/svn.py:
2899
2900 2011-07-29  Adam Barth  <abarth@webkit.org>
2901
2902         Chromium try servers should use downstream test_expectations
2903         https://bugs.webkit.org/show_bug.cgi?id=65390
2904
2905         Reviewed by Dirk Pranke.
2906
2907         Otherwise the try servers will report bogus failures.
2908
2909         * Scripts/webkitpy/layout_tests/port/chromium.py:
2910
2911 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
2912
2913         Fix an error in macro collapsing, refactor code to be pretty.
2914         https://bugs.webkit.org/show_bug.cgi?id=65387
2915
2916         My set math was wrong.
2917
2918         Reviewed by Adam Barth.
2919
2920         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
2921         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
2922
2923 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
2924
2925         Style bot complains about EFL-specific forward declaration naming.
2926         https://bugs.webkit.org/show_bug.cgi?id=64680
2927
2928         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
2929
2930         Reviewed by Adam Barth.
2931
2932         * Scripts/webkitpy/style/checkers/cpp.py:
2933         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2934
2935 2011-07-27  Adam Roben  <aroben@apple.com>
2936
2937         Use wacky !svn/bc URLs consistently in Leaks Viewer
2938
2939         This ensures that any resources loaded via relative URLs will still get pulled from the same
2940         revision of Subversion.
2941
2942         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
2943
2944         Reviewed by David Kilzer.
2945
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
2947         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
2948         from Subversion.
2949
2950 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
2951
2952         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
2953         https://bugs.webkit.org/show_bug.cgi?id=65269
2954
2955         Reviewed by Kent Tamura.
2956
2957         WorkQueueItemEfl.h was being included by efl's
2958         LayoutTestControllerEfl.cpp, however the top-level
2959         LayoutTestController still included WorkQueueItem.h, causing a lot of
2960         type mismatches when running the WorkQueueItem code.
2961
2962         We can stick to the original WorkQueueItem header by making a few
2963         changes to EFL's LayoutTestController.
2964
2965         This should make tests such as
2966         fast/loader/non-deferred-substitute-load.html stop crashing.
2967
2968         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2969         (LayoutTestController::queueLoad):
2970         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2971         (LoadItem::invoke):
2972         (LoadHTMLStringItem::invoke):
2973         (ScriptItem::invoke):
2974         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
2975
2976 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2977
2978         Re-add unit tests I accidentally zapped in r91878.
2979
2980         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
2981
2982 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
2983
2984         Replace SpecificityCalculator with TestConfiguration-driven logic.
2985         https://bugs.webkit.org/show_bug.cgi?id=65206
2986
2987         Use our newly-acquired ability to expand modifiers into a set of
2988         matching TestConfiguration instances to calculate specificity and
2989         determine whether expectation applies to a given test configuration.
2990
2991         Also, store bug modifier on TestExpectationsLine.
2992
2993         Reviewed by Adam Barth.
2994
2995         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
2996             test configuration matching, removed a bunch of code.
2997         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
2998
2999
3000 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3001
3002         Allow ports to specify their own test expectation specifier macros.
3003         https://bugs.webkit.org/show_bug.cgi?id=65291
3004
3005         Reviewed by Adam Barth.
3006
3007         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
3008         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
3009         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
3010         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
3011         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
3012
3013 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3014
3015         Allow TestConfigurationConverter report conversion errors.
3016         https://bugs.webkit.org/show_bug.cgi?id=65287
3017
3018         Also, fix a few miscellaneous testing issues.
3019
3020         Reviewed by Adam Barth.
3021
3022         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
3023         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
3024         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
3025             was created. 'default' is not a valid build type.
3026         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
3027
3028 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
3029
3030         Teach all ports about their test configurations.
3031         https://bugs.webkit.org/show_bug.cgi?id=65278
3032
3033         Each Port object should return a valid set of all TestConfiguration instances,
3034         available for this port.
3035
3036         Reviewed by Philippe Normand.
3037
3038         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
3039             since it is different for each port.
3040         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
3041         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
3042             all test configurations as a param.
3043         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
3044         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
3045         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
3046         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
3047         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
3048         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
3049         * Scripts/webkitpy/layout_tests/port/win.py:
3050         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
3051         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
3052         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
3053         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
3054
3055 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
3056
3057         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
3058         https://bugs.webkit.org/show_bug.cgi?id=62969
3059
3060         Reviewed by Andreas Kling.
3061
3062         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
3063
3064         With the scene graph, the interface to have a window on screen is
3065         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
3066         dependency.
3067
3068         Both the BrowserView and the WebKitTest runner are changed from
3069         QGraphicsView to QSGCanvas.
3070
3071         * MiniBrowser/qt/BrowserView.cpp:
3072         (BrowserView::BrowserView):
3073         (BrowserView::resizeEvent):
3074         (BrowserView::view):
3075         * MiniBrowser/qt/BrowserView.h:
3076         * MiniBrowser/qt/BrowserWindow.cpp:
3077         (BrowserWindow::BrowserWindow):
3078         (BrowserWindow::urlChanged):
3079         (BrowserWindow::~BrowserWindow):
3080         * MiniBrowser/qt/BrowserWindow.h:
3081         * MiniBrowser/qt/MiniBrowser.pro:
3082         * MiniBrowser/qt/main.cpp:
3083         (main):
3084         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3085         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3086         (WTR::WebView::WebView):
3087         (WTR::PlatformWebView::PlatformWebView):
3088         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3089
3090 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
3091
3092         Unreviewed, rolling out r91792.
3093         http://trac.webkit.org/changeset/91792
3094         https://bugs.webkit.org/show_bug.cgi?id=65242
3095
3096         It broke NRWT on Qt and GTK (Requested by Ossy_night on
3097         #webkit).
3098
3099         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3100         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3101         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3102         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3103         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3104         * Scripts/webkitpy/layout_tests/port/test.py:
3105
3106 2011-07-26  Adam Barth  <abarth@webkit.org>
3107
3108         Switch to an older idiom that works on Python 2.5.
3109
3110         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
3111
3112 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3113
3114         Add an exception to coding style check for EFL port.
3115         https://bugs.webkit.org/show_bug.cgi?id=65162
3116
3117         Add an exception of whitespace/declaration for EFL port. Because,
3118         '*' operator is next to variable in EFL coding style.
3119
3120         Reviewed by Kent Tamura.
3121
3122         * Scripts/webkitpy/style/checker.py:
3123
3124 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
3125
3126         [Qt] Add option to turn on disk caching in QtTestBrowser
3127         https://bugs.webkit.org/show_bug.cgi?id=65007
3128
3129         Reviewed by Noam Rosenthal.
3130
3131         Add menu item and command line option to turn on disk caching in
3132         QtTestBrowser. Simple QNetworkDiskCache added to the page's
3133         QNetworkAccssManager.
3134
3135         * QtTestBrowser/launcherwindow.cpp:
3136         (LauncherWindow::initializeView):
3137         (LauncherWindow::createChrome):
3138         (LauncherWindow::setDiskCache):
3139         * QtTestBrowser/launcherwindow.h:
3140         (WindowOptions::WindowOptions):
3141         * QtTestBrowser/main.cpp:
3142         (LauncherApplication::handleUserOptions):
3143
3144 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3145
3146         Add support for download='filename' attribute in anchors.
3147         https://bugs.webkit.org/show_bug.cgi?id=64580
3148
3149         Reviewed by Adam Barth.
3150
3151         * DumpRenderTree/chromium/WebViewHost.cpp:
3152         (WebViewHost::loadURLExternally):
3153         * DumpRenderTree/chromium/WebViewHost.h:
3154
3155 2011-07-26  Dan Bernstein  <mitz@apple.com>
3156
3157         Rubber-stamped by Anders Carlsson.
3158
3159         Update DumpRenderTree and API tests for the pictograph font family preference.
3160
3161         * DumpRenderTree/mac/DumpRenderTree.mm:
3162         (resetDefaultsToConsistentValues):
3163         * DumpRenderTree/win/DumpRenderTree.cpp:
3164         (resetDefaultsToConsistentValues):
3165         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3166         (TestWebKitAPI::TEST):
3167         * WebKitTestRunner/TestController.cpp:
3168         (WTR::TestController::resetStateToConsistentValues):
3169
3170 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3171
3172         Replace SpecificityCalculator with TestConfiguration-driven logic.
3173         https://bugs.webkit.org/show_bug.cgi?id=65206
3174
3175         Use our newly-acquired ability to expand modifiers into a set of
3176         matching TestConfiguration instances to calculate specificity and
3177         determine whether expectation applies to a given test configuration.
3178
3179         Also, store bug modifier on TestExpectationsLine.
3180
3181         Reviewed by Adam Barth.
3182
3183         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
3184         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
3185         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
3186             test configuration matching, removed a bunch of code.
3187         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
3188         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
3189             was created. 'default' is not a valid build type.
3190         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
3191
3192 2011-07-26  Adam Barth  <abarth@webkit.org>
3193
3194         Increase the information density in garden-o-matic
3195         https://bugs.webkit.org/show_bug.cgi?id=65141
3196
3197         Reviewed by Dimitri Glazkov.
3198
3199         This patch changes lets us show each revision on a single line,
3200         allowing use to show an entire day's worth of commits at once.
3201
3202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3205
3206 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3207
3208         TestConfigurationConverter should not barf on invalid specifiers.
3209         https://bugs.webkit.org/show_bug.cgi?id=65194
3210
3211         Reviewed by Adam Barth.
3212
3213         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
3214             made it return empty set whenever an invalid specifier is encountered.
3215         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
3216
3217 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
3218
3219         Introduce a way to convert between specifier lists and TestConfiguration sets.
3220         https://bugs.webkit.org/show_bug.cgi?id=65094
3221
3222         Add TestConfigurationConverter, a facility to convert:
3223         1) a set of specifiers into a set of TestConfiguration instances;
3224         2) a set of TestConfiguration instances into a list of sets of specifiers.
3225
3226         Reviewed by Adam Barth.
3227
3228         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
3229         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
3230
3231 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
3232
3233         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
3234         https://bugs.webkit.org/show_bug.cgi?id=65171
3235
3236         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
3237         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
3238
3239         Reviewed by Adam Roben.
3240
3241         * BuildSlaveSupport/build.webkit.org-config/config.json:
3242         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3243
3244 2011-07-26  Chris Rogers  <crogers@google.com>
3245
3246         Avoid outputting #EOF twice for web audio tests in chromium DRT
3247         https://bugs.webkit.org/show_bug.cgi?id=65201
3248
3249         Reviewed by Dirk Pranke.
3250
3251         * DumpRenderTree/chromium/TestShell.cpp:
3252         (TestShell::dump):
3253
3254 2011-07-26  Adam Barth  <abarth@webkit.org>
3255
3256         Windows bots on build.chromium.org can't figure out the head_svn_revision
3257         https://bugs.webkit.org/show_bug.cgi?id=65156
3258
3259         Reviewed by Tony Chang.
3260
3261         This patch is a bit of a guess as to the issue based on the
3262         investigation in https://bugs.webkit.org/show_bug.cgi?id=65148.  I'm
3263         not sure whether it will fix the issue, but it seems worth a try.
3264
3265         * Scripts/webkitpy/common/checkout/scm/svn.py:
3266
3267 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3268
3269         Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
3270
3271         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
3272         (getPreferredSizeMethod):
3273
3274 2011-07-26  MORITA Hajime  <morrita@google.com>
3275
3276         [Chromium][DRT] MockSpellCheck.cpp should be clang clean
3277         https://bugs.webkit.org/show_bug.cgi?id=65166
3278
3279         Reviewed by Kent Tamura.
3280
3281         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3282         (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
3283
3284 2011-07-25  Patrick Gansterer  <paroga@webkit.org>
3285
3286         Ignore line endings in ChangeLogTests
3287         https://bugs.webkit.org/show_bug.cgi?id=64956
3288
3289         Reviewed by Adam Barth.
3290
3291         Split the lines of the ChangeLog text before comparing them.
3292         This fixes 3 tests on windows, since only the content importent.
3293
3294         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3295         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
3296
3297 2011-07-25  Adam Barth  <abarth@webkit.org>
3298
3299         Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
3300         https://bugs.webkit.org/show_bug.cgi?id=65148
3301
3302         Reviewed by Tony Chang.
3303
3304         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3305
3306 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3307
3308         Tweak whitespace wrapping to improve readability.
3309         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3310
3311 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3312
3313         Minor tweak to wrap label elements as atomic units.
3314
3315         * TestResultServer/static-dashboards/dashboard_base.js:
3316         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3317
3318 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3319
3320         always show flakiness details on the builder page
3321         https://bugs.webkit.org/show_bug.cgi?id=65139
3322
3323         Reviewed by Tony Chang.
3324
3325         In order to simplify the UI, we hide the flakiness details by default,
3326         but there's no actual use-case for this page without the flakiness details.
3327         So get rid of that option and always show the flakiness details.
3328
3329         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3330
3331 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3332
3333         simplify the UI of the header above the test list table
3334         https://bugs.webkit.org/show_bug.cgi?id=65136
3335
3336         Reviewed by Adam Barth.
3337
3338         Use checkboxes instead of links since this is really about which tests to include.
3339         Ends up using less text and put the checkboxes to the right of the header instead of below it.
3340
3341         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3342         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3343
3344 2011-07-25  Chris Rogers  <crogers@google.com>
3345
3346         Update new-run-webkit-tests to accomodate binary audio data
3347         https://bugs.webkit.org/show_bug.cgi?id=65135
3348
3349         Reviewed by Dirk Pranke.
3350
3351         * Scripts/webkitpy/layout_tests/port/chromium.py:
3352
3353 2011-07-25  Chris Rogers  <crogers@google.com>
3354
3355         Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
3356         https://bugs.webkit.org/show_bug.cgi?id=65039
3357
3358         Reviewed by Tony Chang.
3359
3360         * DumpRenderTree/chromium/LayoutTestController.cpp:
3361         (LayoutTestController::LayoutTestController):
3362         (LayoutTestController::setAudioData):
3363         * DumpRenderTree/chromium/LayoutTestController.h:
3364         (LayoutTestController::audioData):
3365         * DumpRenderTree/chromium/TestEventPrinter.cpp:
3366         (DRTPrinter::handleAudioHeader):
3367         (TestShellPrinter::handleAudioHeader):
3368         * DumpRenderTree/chromium/TestShell.cpp:
3369         (TestShell::dump):
3370
3371 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
3372
3373         Reviewed by Gustavo Noronha Silva.
3374
3375         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
3376         https://bugs.webkit.org/show_bug.cgi?id=62252
3377
3378         Add a new subclass of WebKitWebView that overrides the size request to
3379         return 1 pixel by 1 pixel. This ensure that it operates properly when
3380         not packed into a GtkScrolledWindow. Also construct the WebKitWebView
3381         with self-scrolling set to true.
3382
3383         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3384         (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
3385         (createWebView): Ditto.
3386         (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
3387         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
3388         (self_scrolling_webkit_web_view_class_init):
3389         (self_scrolling_webkit_web_view_init):
3390         (self_scrolling_webkit_web_view_new):
3391         (sizeRequestMethod):
3392         (getPreferredSizeMethod):
3393         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
3394         * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
3395
3396 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3397
3398         by default hide tests that have passes for all recorded runs
3399         https://bugs.webkit.org/show_bug.cgi?id=65127
3400
3401         Reviewed by Adam Barth.
3402
3403         This is part of simplifying the default views of the dashboard to
3404         make it show less information for the common use cases.
3405
3406         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3407         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3408
3409 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3410
3411         stop generating expectations.json now that it's unused
3412         https://bugs.webkit.org/show_bug.cgi?id=65130
3413
3414         Reviewed by Adam Barth.
3415
3416         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3417         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3418         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3419         * TestResultServer/handlers/menu.py:
3420         * TestResultServer/static-dashboards/dashboard_base.js:
3421         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3422
3423 2011-07-25  Ojan Vafai  <ojan@chromium.org>
3424
3425         don't show builders in the flakiness dashboard that have stopped running a given test suite
3426         https://bugs.webkit.org/show_bug.cgi?id=65126
3427
3428         Reviewed by Mihai Parparita.
3429
3430         * TestResultServer/static-dashboards/dashboard_base.js:
3431
3432 2011-07-25  Adam Barth  <abarth@webkit.org>
3433
3434         Overhaul garden-o-matic frontend to integrate revision history and failures
3435         https://bugs.webkit.org/show_bug.cgi?id=65089
3436
3437         Reviewed by Dimitri Glazkov.
3438
3439         This is a major overhaul of the garden-o-matic frontend.  The new UI
3440         integrates the revision history information with failures.  Failures
3441         appear in context adjacent to the revisions that caused them (which are
3442         highlighted).  Each buildbot receives a collumn to the left, which
3443         indicates which revisions that bot has tested and whether that bot
3444         showed the indicated failures.
3445
3446         Failures are selectable with checkboxes, and can then either be
3447         examined or rebaselined.
3448
3449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
3451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3458
3459 2011-07-25  Holger Hans Peter Freyther  <zecke@selfish.org>
3460
3461         [buildbot] Add Qt Linux MIPSEL Configuration
3462         https://bugs.webkit.org/show_bug.cgi?id=65116
3463
3464         Reviewed by Adam Roben.
3465
3466         Introduce a Qt Linux MIPS EL build slave. The configuration
3467         is a build only configuration.
3468
3469         * BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
3470
3471 2011-07-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3472
3473         [Qt][WK2] Add multi-point touch mocking to MiniBrowser
3474         https://bugs.webkit.org/show_bug.cgi?id=64374
3475
3476         Reviewed by Benjamin Poulain.
3477
3478         Each mouse button generate a touch point. The touch point stay
3479         virtually on screen if the mouse release happened while the Ctrl
3480         modifier was pressed.
3481
3482         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3483         (MiniBrowserApplication::notify):
3484         * MiniBrowser/qt/MiniBrowserApplication.h:
3485
3486 2011-07-25  Balazs Kelemen  <kbalazs@webkit.org>
3487
3488         [Qt][WK2] Use NRWT for Qt-WK2
3489         https://bugs.webkit.org/show_bug.cgi?id=65097
3490
3491         Reviewed by Andreas Kling.
3492
3493         * Scripts/run-webkit-tests:
3494         (useNewRunWebKitTests):
3495
3496 2011-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3497
3498         Unreviewed, rolling out r91635.
3499         http://trac.webkit.org/changeset/91635
3500         https://bugs.webkit.org/show_bug.cgi?id=65083
3501
3502         It broke the minimal build (Requested by Ossy___OFFLINE on
3503         #webkit).
3504
3505         * QtTestBrowser/launcherwindow.cpp:
3506         (LauncherWindow::initializeView):
3507         (LauncherWindow::createChrome):
3508         * QtTestBrowser/launcherwindow.h:
3509         (WindowOptions::WindowOptions):
3510         * QtTestBrowser/main.cpp:
3511         (LauncherApplication::handleUserOptions):
3512
3513 2011-07-24  Adam Barth  <abarth@webkit.org>
3514
3515         Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
3516
3517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3523
3524 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
3525
3526         TestConfiguration should be hashable and comparable for equality.
3527         https://bugs.webkit.org/show_bug.cgi?id=65070
3528
3529         Reviewed by Adam Barth.
3530
3531         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added __hash__ and __eq__ methods.
3532         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
3533
3534 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
3535
3536         Extract TestConfiguration from base and write a few unit tests to capture current behavior.
3537         https://bugs.webkit.org/show_bug.cgi?id=65066
3538
3539         Reviewed by Adam Barth.
3540
3541         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
3542         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
3543         * Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
3544
3545 2011-07-23  Alok Priyadarshi  <alokp@chromium.org>
3546
3547         Switching off acceleration for small canvas broke gpu tests
3548         https://bugs.webkit.org/show_bug.cgi?id=65053
3549
3550         Reviewed by Stephen White.
3551
3552         * DumpRenderTree/chromium/WebPreferences.cpp:
3553         (WebPreferences::reset):
3554         (WebPreferences::applyTo):
3555         * DumpRenderTree/chromium/WebPreferences.h:
3556
3557 2011-07-23  Keith Kyzivat  <keith.kyzivat@nokia.com>
3558
3559         [Qt] Add option to turn on disk caching in QtTestBrowser
3560         https://bugs.webkit.org/show_bug.cgi?id=65007
3561
3562         Reviewed by Noam Rosenthal.
3563
3564         Add menu item and command line option to turn on disk caching in
3565         QtTestBrowser. Simple QNetworkDiskCache added to the page's