144dbff730687175b1bc76d4226de4cf7e558cb8
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
2
3         remove dpranke from webkitpy watchlist
4         https://bugs.webkit.org/show_bug.cgi?id=122331
5
6         Reviewed by Brent Fulgham.
7
8         * Scripts/webkitpy/common/config/watchlist:
9
10 2013-10-04  Tim Horton  <timothy_horton@apple.com>
11
12         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
13         https://bugs.webkit.org/show_bug.cgi?id=122299
14
15         Reviewed by Beth Dakin.
16
17         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
18         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
19         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
20
21 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
22
23         Watchlist is broken after <http://trac.webkit.org/r156880>
24
25         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
26
27 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
28
29         Remove Qt features from build and test tools
30         https://bugs.webkit.org/show_bug.cgi?id=122312
31
32         Reviewed by Anders Carlsson.
33
34         * Scripts/build-dumprendertree:
35         * Scripts/build-jsc:
36         * Scripts/build-webkit:
37         * Scripts/build-webkittestrunner:
38         * Scripts/old-run-webkit-tests:
39         (openDumpTool):
40         (buildPlatformResultHierarchy):
41         (buildPlatformTestHierarchy):
42         (readSkippedFiles):
43         * Scripts/run-launcher:
44         * Scripts/run-qtwebkit-tests: Removed.
45         * Scripts/run-webkit-tests:
46         (useNewRunWebKitTests):
47         * Scripts/update-webkit:
48         * Scripts/webkit-build-directory:
49         * Scripts/webkitdirs.pm:
50         (argumentsForConfiguration):
51         (jscProductDir):
52         (builtDylibPathForName):
53         (isAppleWebKit):
54         (launcherPath):
55         (launcherName):
56         (checkRequiredSystemConfig):
57         (setupCygwinEnv):
58         (copyInspectorFrontendFiles):
59         (setPathForRunningWebKitApp):
60         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
61         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
62         (BaselineOptimizerTest.test_mac_future):
63         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
64         (BaselineOptimizerTest.test_common_directory_includes_root):
65         (BaselineOptimizerTest.test_virtual_ports_filtered):
66         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
67         (test_parse_reviewer_text):
68         * Scripts/webkitpy/common/config/watchlist:
69         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
70         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
71         * Scripts/webkitpy/port/base.py:
72         (Port.__init__):
73         (Port._port_flag_for_scripts):
74         (Port._wk2_port_name):
75         * Scripts/webkitpy/port/builders.py:
76         * Scripts/webkitpy/port/factory.py:
77         (platform_options):
78         (PortFactory):
79         (PortFactory._default_port):
80         * Scripts/webkitpy/port/factory_unittest.py:
81         (FactoryTest.test_gtk):
82         * Scripts/webkitpy/port/qt.py: Removed.
83         * Scripts/webkitpy/port/qt_unittest.py: Removed.
84         * Scripts/webkitpy/style/checker.py:
85         * Scripts/webkitpy/style/checker_unittest.py:
86         (GlobalVariablesTest.test_path_rules_specifier):
87         * Scripts/webkitpy/style/checkers/cmake.py:
88         (CMakeChecker):
89         * Scripts/webkitpy/style/checkers/cpp.py:
90         (_classify_include):
91         (check_include_line):
92         (check_identifier_name_in_declaration):
93         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
94         (OrderOfIncludesTest.test_classify_include):
95         (WebKitStyleTest.test_names):
96         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
97         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
98         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
99         (TestRebaselineTest.test_baseline_directory):
100         * Scripts/webkitpy/tool/main.py:
101         (WebKitPatch):
102
103 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
104
105         Unreviewed. Add myself to some watchlists.
106
107         * Scripts/webkitpy/common/config/watchlist:
108
109 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
110
111         Remove Qt builders from the flakiness dashboard.
112
113         * TestResultServer/static-dashboards/builders.jsonp:
114         * TestResultServer/static-dashboards/flakiness_dashboard.js:
115         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
116         * TestResultServer/static-dashboards/loader_unittests.js:
117
118 2013-10-03  Tim Horton  <timothy_horton@apple.com>
119
120         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
121         https://bugs.webkit.org/show_bug.cgi?id=122299
122
123         Reviewed by Beth Dakin.
124
125         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
126         Disable threaded scrolling.
127
128         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
129         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
130         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
131
132 2013-10-03  Anders Carlsson  <andersca@apple.com>
133
134         Use numeric strings in the OS version dictionary
135         https://bugs.webkit.org/show_bug.cgi?id=122300
136
137         Reviewed by Mark Rowe.
138
139         * Scripts/webkitpy/common/system/platforminfo.py:
140         (PlatformInfo._determine_mac_version):
141
142 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
143
144         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
145
146         Rubber-stamped by Tim Horton.
147
148         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
149         (LeaksViewer._displayURLPrompt):
150
151 2013-10-03  Dan Bernstein  <mitz@apple.com>
152
153         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
154         https://bugs.webkit.org/show_bug.cgi?id=122260
155
156         Reviewed by Alexey Proskuryakov.
157
158         For the API to work, the tests need to be compiled with a newer version of the LLVM
159         compiler. Until the bots are updated to that version, disable the tests on 10.8.
160
161         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
162
163 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
164
165         [ATK] Expose aria-invalid as a text attribute (not object attribute)
166         https://bugs.webkit.org/show_bug.cgi?id=122015
167
168         Reviewed by Chris Fleizach.
169
170         Adapted DRT and WKTR to check the exposure of the aria-invalid
171         attribute as a text attribute, instead of an object attribute.
172
173         Also, done some refactoring of the code to try to keep things
174         simpler and more coherent, by defining new helper functions,
175         simplifying code, moving static variables and functions into
176         unnammed namespaces and so on, without altering the logic other
177         than for checking the text attribute for aria-invalid.
178
179         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
180         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
181         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
182         Also, never return an empty string if not falling through any of
183         the cases checked here, and return the original attribute instead.
184         (atkAttributeValueToCoreAttributeValue): New helper function to
185         match the attributes values returned by the ATK wrapper with the
186         values expected by the layout tests. Moved the mappings for the
187         values of AXSortDirection here as well.
188         (getAttributeSet): New helper function to retrieve a list of
189         attributes (an AtkAttributeSet) from an AtkObject using the right
190         API depending on whether we want the object attributes or the text
191         attributes (in case the object implements AtkText).
192         (getAttributeSetValueForId): Simplified by using getAttributeSet
193         and atkAttributeValueToCoreAttributeValue. Also, added a new
194         parameter to indicater whether we are interested in object
195         attributes or text attributes.
196         (getAtkAttributeSetAsString): Ditto.
197         (attributesOfElement): Updated to pass the new required parameter
198         to getAtkAttributeSetAsString, indicating that we want the object
199         attributes in this case, for backwards compatibility.
200         (indexRangeInTable): Moved up in the file into the unnammed namespace.
201         (alterCurrentValue): Ditto.
202         (AccessibilityUIElement::stringAttributeValue): After moving most
203         of the code here to the new helper functions, simplified it by
204         just checking whether the required attribute is provided as an
205         object attribute or, if that's not the case, as a text attribute.
206         (AccessibilityUIElement::isAttributeSupported): Ditto.
207         (AccessibilityUIElement::intValue): Updated to pass the new
208         required parameter to getAttributeSetValueForId, indicating that
209         we want the object attributes in this case.
210         (AccessibilityUIElement::hasPopup): Ditto.
211
212         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
213         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
214         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
215         (WTR::getAttributeSet): Ditto.
216         (WTR::getAttributeSetValueForId): Ditto.
217         (WTR::getAtkAttributeSetAsString): Ditto.
218         (WTR::attributesOfElement): Ditto.
219         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
220         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
221         (WTR::AccessibilityUIElement::intValue): Ditto.
222         (WTR::AccessibilityUIElement::hasPopup): Ditto.
223
224 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
225
226         EWS build fix after the Qt EWS removal.
227
228         * QueueStatusServer/model/attachment.py:
229         (Attachment._calculate_queue_positions):
230
231 2013-10-02  Anders Carlsson  <andersca@apple.com>
232
233         Remove Qt code from Tools/
234         https://bugs.webkit.org/show_bug.cgi?id=122227
235
236         Reviewed by Andreas Kling.
237
238         * DumpRenderTree/WorkQueue.cpp:
239         * DumpRenderTree/blackberry/src.pro: Removed.
240         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
241         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
242         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
243         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
244         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
245         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
246         * DumpRenderTree/qt/EventSenderQt.h: Removed.
247         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
248         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
249         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
250         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
251         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
252         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
253         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
254         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
255         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
256         * DumpRenderTree/qt/resources/user.css: Removed.
257         * DumpRenderTree/qt/testplugin.cpp: Removed.
258         * DumpRenderTree/qt/testplugin.h: Removed.
259         * ImageDiff/ImageDiff.pro: Removed.
260         * ImageDiff/qt/ImageDiff.cpp: Removed.
261         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
262         * MiniBrowser/qt/BrowserWindow.h: Removed.
263         * MiniBrowser/qt/MiniBrowser.pro: Removed.
264         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
265         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
266         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
267         * MiniBrowser/qt/UrlLoader.cpp: Removed.
268         * MiniBrowser/qt/UrlLoader.h: Removed.
269         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
270         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
271         * MiniBrowser/qt/icons/contents_width.png: Removed.
272         * MiniBrowser/qt/icons/favicon.png: Removed.
273         * MiniBrowser/qt/icons/find.png: Removed.
274         * MiniBrowser/qt/icons/folder.png: Removed.
275         * MiniBrowser/qt/icons/info.png: Removed.
276         * MiniBrowser/qt/icons/next.png: Removed.
277         * MiniBrowser/qt/icons/plus.png: Removed.
278         * MiniBrowser/qt/icons/previous.png: Removed.
279         * MiniBrowser/qt/icons/refresh.png: Removed.
280         * MiniBrowser/qt/icons/stop.png: Removed.
281         * MiniBrowser/qt/icons/titlebar.png: Removed.
282         * MiniBrowser/qt/icons/touch.png: Removed.
283         * MiniBrowser/qt/icons/touchpoint.png: Removed.
284         * MiniBrowser/qt/icons/up.png: Removed.
285         * MiniBrowser/qt/js/MultiSelect.js: Removed.
286         * MiniBrowser/qt/main.cpp: Removed.
287         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
288         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
289         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
290         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
291         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
292         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
293         * MiniBrowser/qt/qml/Dialog.qml: Removed.
294         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
295         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
296         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
297         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
298         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
299         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
300         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
301         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
302         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
303         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
304         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
305         * MiniBrowser/qt/raw/Target.pri: Removed.
306         * MiniBrowser/qt/raw/View.cpp: Removed.
307         * MiniBrowser/qt/raw/View.h: Removed.
308         * MiniBrowser/qt/utils.cpp: Removed.
309         * MiniBrowser/qt/utils.h: Removed.
310         * QtTestBrowser/QtTestBrowser.pro: Removed.
311         * QtTestBrowser/QtTestBrowser.qrc: Removed.
312         * QtTestBrowser/cookiejar.cpp: Removed.
313         * QtTestBrowser/cookiejar.h: Removed.
314         * QtTestBrowser/favicon.png: Removed.
315         * QtTestBrowser/fpstimer.cpp: Removed.
316         * QtTestBrowser/fpstimer.h: Removed.
317         * QtTestBrowser/launcherwindow.cpp: Removed.
318         * QtTestBrowser/launcherwindow.h: Removed.
319         * QtTestBrowser/locationedit.cpp: Removed.
320         * QtTestBrowser/locationedit.h: Removed.
321         * QtTestBrowser/mainwindow.cpp: Removed.
322         * QtTestBrowser/mainwindow.h: Removed.
323         * QtTestBrowser/qttestbrowser.cpp: Removed.
324         * QtTestBrowser/urlloader.cpp: Removed.
325         * QtTestBrowser/urlloader.h: Removed.
326         * QtTestBrowser/useragentlist.txt: Removed.
327         * QtTestBrowser/utils.cpp: Removed.
328         * QtTestBrowser/utils.h: Removed.
329         * QtTestBrowser/webinspector.h: Removed.
330         * QtTestBrowser/webpage.cpp: Removed.
331         * QtTestBrowser/webpage.h: Removed.
332         * QtTestBrowser/webview.cpp: Removed.
333         * QtTestBrowser/webview.h: Removed.
334         * TestWebKitAPI/DerivedSources.pri: Removed.
335         * TestWebKitAPI/InjectedBundle.pri: Removed.
336         * TestWebKitAPI/PlatformWebView.h:
337         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
338         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
339         * TestWebKitAPI/Tests.pri: Removed.
340         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
341         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
342         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
343         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
344         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
345         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
346         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
347         * TestWebKitAPI/qt/main.cpp: Removed.
348         * Tools.pro: Removed.
349         * WebKitTestRunner/DerivedSources.pri: Removed.
350         * WebKitTestRunner/EventSenderProxy.h:
351         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
352         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
354         (WTR::InjectedBundlePage::resetAfterTest):
355         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
356         (WTR::InjectedBundlePage::didClearWindowForFrame):
357         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
358         * WebKitTestRunner/InjectedBundle/TestRunner.h:
359         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
360         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
361         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
362         * WebKitTestRunner/PlatformWebView.h:
363         * WebKitTestRunner/Target.pri: Removed.
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::TestController::resetStateToConsistentValues):
366         * WebKitTestRunner/TestController.h:
367         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
368         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
369         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
370         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
371         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
372         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
373         * WebKitTestRunner/qt/main.cpp: Removed.
374         * WebKitTestRunner/qt/resources/user.css: Removed.
375         * qmake/.qmake.cache: Removed.
376         * qmake/.qmake.conf: Removed.
377         * qmake/README: Removed.
378         * qmake/config.tests/README: Removed.
379         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
380         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
381         * qmake/config.tests/gccdepends/empty.cpp: Removed.
382         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
383         * qmake/config.tests/glx/glx.cpp: Removed.
384         * qmake/config.tests/glx/glx.pro: Removed.
385         * qmake/config.tests/gnuld/gnuld.pro: Removed.
386         * qmake/config.tests/gnuld/main.cpp: Removed.
387         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
388         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
389         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
390         * qmake/config.tests/libXrender/libXrender.pro: Removed.
391         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
392         * qmake/config.tests/libwebp/libwebp.pro: Removed.
393         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
394         * qmake/config.tests/libxml2/libxml2.pro: Removed.
395         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
396         * qmake/config.tests/libxslt/libxslt.pro: Removed.
397         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
398         * qmake/config.tests/libzlib/libzlib.pro: Removed.
399         * qmake/dump-features.pl: Removed.
400         * qmake/mkspecs/features/configure.prf: Removed.
401         * qmake/mkspecs/features/default_post.prf: Removed.
402         * qmake/mkspecs/features/default_pre.prf: Removed.
403         * qmake/mkspecs/features/features.prf: Removed.
404         * qmake/mkspecs/features/features.pri: Removed.
405         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
406         * qmake/mkspecs/features/functions.prf: Removed.
407         * qmake/mkspecs/features/gprof.prf: Removed.
408         * qmake/mkspecs/features/mac/default_post.prf: Removed.
409         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
410         * qmake/mkspecs/features/minimal_qt.prf: Removed.
411         * qmake/mkspecs/features/production_build.prf: Removed.
412         * qmake/mkspecs/features/rpath.prf: Removed.
413         * qmake/mkspecs/features/unix/default_post.prf: Removed.
414         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
415         * qmake/mkspecs/features/unix/icc.prf: Removed.
416         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
417         * qmake/mkspecs/features/valgrind.prf: Removed.
418         * qmake/mkspecs/features/webkit_modules.prf: Removed.
419         * qmake/mkspecs/features/win32/default_post.prf: Removed.
420         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
421         * qmake/mkspecs/modules/angle.prf: Removed.
422         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
423         * qmake/mkspecs/modules/webcore.prf: Removed.
424         * qmake/mkspecs/modules/webkit1.prf: Removed.
425         * qmake/mkspecs/modules/webkit2.prf: Removed.
426         * qmake/mkspecs/modules/wtf.prf: Removed.
427
428 2013-10-02  Tim Horton  <timothy_horton@apple.com>
429
430         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
431         https://bugs.webkit.org/show_bug.cgi?id=121859
432         <rdar://problem/15069359>
433
434         Reviewed by Anders Carlsson.
435
436         * WebKitTestRunner/TestInvocation.cpp:
437         (WTR::shouldUseThreadedScrolling):
438         (WTR::updateThreadedScrollingForCurrentTest):
439         (WTR::TestInvocation::invoke):
440         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
441         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
442         (WTR::PlatformWebView::PlatformWebView):
443         (WTR::PlatformWebView::viewSupportsOptions):
444         Rename the tiled drawing switch to threaded scrolling, since that's really
445         all it switches now that we use tiled drawing everywhere.
446
447         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
448         and to more closely match the case we're interested in testing.
449
450 2013-10-02  Anders Carlsson  <andersca@apple.com>
451
452         Move AHEM____.TTF from qt/fonts/ to fonts/.
453
454         Rubber-stamped by Andreas Kling.
455
456         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
457         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
458
459 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
460
461         Remove Qt bots and EWS from trunk.
462         https://bugs.webkit.org/show_bug.cgi?id=122210.
463
464         Reviewed by Allan Sandfeld Jensen.
465
466         Remove Qt buil dbots.
467
468         * BuildSlaveSupport/build.webkit.org-config/config.json:
469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
470         (appendCustomBuildFlags):
471         (RunGtkAPITests.getText2):
472         (Factory.__init__):
473         (TestFactory.__init__):
474         (BuildAndTestFactory.__init__):
475         (loadBuilderConfig):
476         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
477
478 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
479
480         Remove Qt bots and EWS from trunk.
481         https://bugs.webkit.org/show_bug.cgi?id=122210.
482
483         Reviewed by Allan Sandfeld Jensen.
484
485         Remove Qt EWS bots.
486
487         * QueueStatusServer/config/queues.py:
488         * Scripts/webkitpy/common/config/ews.json:
489
490 2013-10-01  Timothy Hatcher  <timothy@apple.com>
491
492         Fix singular labels for test failures.
493
494         https://bugs.webkit.org/show_bug.cgi?id=122200
495
496         Reviewed by Joseph Pecoraro.
497
498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
499         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
500
501 2013-10-01  Timothy Hatcher  <timothy@apple.com>
502
503         Don't keep appending iterations each time the queue updates.
504
505         https://bugs.webkit.org/show_bug.cgi?id=122198
506
507         Reviewed by Joseph Pecoraro.
508
509         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
510         (BuildbotQueue.prototype.update):
511
512 2013-10-01  Timothy Hatcher  <timothy@apple.com>
513
514         Properly sort iterations in the Dashboard by revision for out-of-order queues.
515
516         https://bugs.webkit.org/show_bug.cgi?id=122196
517
518         Reviewed by Brent Fulgham.
519
520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
521         (BuildbotIteration):
522         (BuildbotIteration.prototype.update):
523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
524         (BuildbotQueue.prototype.update):
525         (BuildbotQueue.prototype.sortIterations):
526
527 2013-10-01  Timothy Hatcher  <timothy@apple.com>
528
529         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
530
531         Also fix some URLs to not have extras slashes and add a page title.
532
533         https://bugs.webkit.org/show_bug.cgi?id=122192
534
535         Reviewed by Joseph Pecoraro.
536
537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
538         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
539         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
540         (WebKitBuildbot.prototype.buildLogURLForIteration):
541         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
542         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
543         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
544
545 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
546
547         [Mac] Set NSApplication current event while sending events directly to views
548         https://bugs.webkit.org/show_bug.cgi?id=122179
549
550         Reviewed by Darin Adler.
551
552         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
553         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
554         use the current event.
555
556         * DumpRenderTree/mac/EventSendingController.mm:
557         (-[EventSendingController mouseDown:withModifiers:]):
558         (-[EventSendingController mouseUp:withModifiers:]):
559         (-[EventSendingController mouseMoveToX:Y:]):
560         (-[EventSendingController mouseScrollByX:andY:continuously:]):
561         (-[EventSendingController contextClick]):
562         (-[EventSendingController keyDown:withModifiers:withLocation:]):
563         * WebKitTestRunner/mac/EventSenderProxy.mm:
564         (WTR::EventSenderProxy::mouseDown):
565         (WTR::EventSenderProxy::mouseUp):
566         (WTR::EventSenderProxy::mouseMoveTo):
567         (WTR::EventSenderProxy::keyDown):
568         (WTR::EventSenderProxy::mouseScrollBy):
569         Update the current event. We were already using the SPI in WebKit.
570
571 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
572
573         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
574         https://bugs.webkit.org/show_bug.cgi?id=122183
575
576         Reviewed by Timothy Hatcher.
577
578         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
579         (BuildbotIteration.prototype.update):
580
581 2013-10-01  Timothy Hatcher  <timothy@apple.com>
582
583         Tweaks to the Buildbot Dashboard
584
585         https://bugs.webkit.org/show_bug.cgi?id=122169
586
587         Reviewed by Alexey Proskuryakov.
588
589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
590         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
592         (BuildbotQueueView.prototype.revisionLinksForIteration):
593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
594         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
598         (WebKitBuildbot.prototype.buildLogURLForIteration):
599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
600
601 2013-10-01  Commit Queue  <commit-queue@webkit.org>
602
603         Unreviewed, rolling out r156725.
604         http://trac.webkit.org/changeset/156725
605         https://bugs.webkit.org/show_bug.cgi?id=122176
606
607         broke all the mismatch tests again (Requested by thorton on
608         #webkit).
609
610         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
611         (WTR::PlatformWebView::PlatformWebView):
612
613 2013-10-01  Alex Christensen  <achristensen@webkit.org>
614
615         Implemented createWebViewWithRequest in WinLauncher.
616         https://bugs.webkit.org/show_bug.cgi?id=122069
617
618         Reviewed by Brent Fulgham.
619
620         * WinLauncher/PrintWebUIDelegate.cpp:
621         (PrintWebUIDelegate::createWebViewWithRequest): Added.
622         * WinLauncher/PrintWebUIDelegate.h:
623         Removed createWebViewWithRequest stub.
624
625 2013-10-01  Tim Horton  <timothy_horton@apple.com>
626
627         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
628         https://bugs.webkit.org/show_bug.cgi?id=122006
629         <rdar://problem/15095197>
630
631         Reviewed by Dean Jackson.
632
633         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
634         (WTR::PlatformWebView::PlatformWebView):
635         Layer-back the root view in WebKitTestRunner's window, to work around a bug
636         where the window server snapshot API returns blank snapshots.
637
638         Re-landing after r156724, this should not break everything now.
639
640 2013-10-01  Tim Horton  <timothy_horton@apple.com>
641
642         [mac] 1x emulation on Retina hardware shouldn't use SPI
643         https://bugs.webkit.org/show_bug.cgi?id=122152
644         <rdar://problem/15119384>
645
646         Reviewed by Anders Carlsson.
647
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (createWebViewAndOffscreenWindow):
650         (main):
651         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
652         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
653         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
654         (WTR::PlatformWebView::PlatformWebView):
655         * WebKitTestRunner/mac/main.mm:
656         (main):
657         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
658
659 2013-09-30  Sam Weinig  <sam@webkit.org>
660
661         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
662         https://bugs.webkit.org/show_bug.cgi?id=116474
663
664         Reviewed by Ryosuke Niwa.
665
666         * Scripts/webkitpy/style/checkers/cpp.py:
667         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
668
669 2013-09-30  Sam Weinig  <sam@webkit.org>
670
671         Remove support for DOMFileSystem
672         https://bugs.webkit.org/show_bug.cgi?id=122137
673
674         Reviewed by Anders Carlsson.
675
676         * Scripts/webkitperl/FeatureList.pm:
677         * Scripts/webkitpy/style/checkers/cpp.py:
678         (check_spacing):
679         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
680         (CppStyleTest.test_spacing_for_binary_ops):
681         * qmake/mkspecs/features/features.pri:
682
683 2013-09-30  Mark Rowe  <mrowe@apple.com>
684
685         More build fixage for builds with SDKs.
686
687         * WebKitTestRunner/Configurations/Base.xcconfig:
688         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
689
690 2013-09-30  Timothy Hatcher  <timothy@apple.com>
691
692         Add initial version of a new Buildbot dashboard view.
693
694         https://bugs.webkit.org/show_bug.cgi?id=122131
695
696         Reviewed by Alexey Proskuryakov.
697
698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
699         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
702         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
703         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
704         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
705         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
706         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
707         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
709         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
710         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
711         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
713         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
715         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
716         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
717         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
719         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
721         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
723         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
724         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
726         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
728         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
729         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
730
731 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
732
733         Remove the code guarded by STYLE_SCOPED
734         https://bugs.webkit.org/show_bug.cgi?id=122123
735
736         Reviewed by Anders Carlsson.
737
738         * DumpRenderTree/gtk/DumpRenderTree.cpp:
739         (resetDefaultsToConsistentValues):
740         * Scripts/webkitperl/FeatureList.pm:
741         * qmake/mkspecs/features/features.pri:
742
743 2013-09-30  Mark Rowe  <mrowe@apple.com>
744
745         Fix the build when building against an SDK.
746
747         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
748         the compiler command lines. It can't know to do this for the system framework search paths
749         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
750
751         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
752         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
753
754 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
755
756         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
757
758         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
759         it to be double-freed.
760
761         * WinLauncher/WinLauncher.cpp:
762         (EditProc): Be explicit about type passed to loadURL.
763         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
764         that reallocating the BSTR is done with the knowledge of the smart pointer.
765
766 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
767
768         [Qt] Fix force_static_libs_as_shared in WebKit2
769         https://bugs.webkit.org/show_bug.cgi?id=121961
770
771         Reviewed by Csaba Osztrogonác.
772
773         Get rid of the unused WebKit2QML library
774
775         * qmake/mkspecs/features/webkit_modules.prf:
776         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
777
778 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
779
780         [EFL] Fix incorrect click counting in EventSenderProxy
781         https://bugs.webkit.org/show_bug.cgi?id=122098
782
783         Reviewed by Gyuyoung Kim.
784
785         Previously used two types of recording time, which conflicted with each other.
786
787         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
788         (WTR::EventSenderProxy::mouseUp):
789
790 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
791
792         [webkitpy] Make the Xvfb screen depth overridable
793         https://bugs.webkit.org/show_bug.cgi?id=122089
794
795         Reviewed by Gyuyoung Kim.
796
797         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
798         was set. The default value that's used if the variable wasn't set is 24.
799
800         * Scripts/webkitpy/port/xvfbdriver.py:
801         (XvfbDriver._xvfb_screen_depth):
802         (XvfbDriver._start):
803         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
804         (XvfbDriverTest.make_driver):
805         (XvfbDriverTest.test_start_no_pixel_tests):
806         (XvfbDriverTest.test_start_pixel_tests):
807         (XvfbDriverTest.test_start_arbitrary_worker_number):
808         (XvfbDriverTest.test_next_free_display):
809         (XvfbDriverTest.test_start_next_worker):
810
811 2013-09-29  Mark Rowe  <mrowe@apple.com>
812
813         Fix the Lion build.
814
815         Ensure that C++ and Objective-C++ files build with the right compiler flags.
816
817         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
818         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
819
820 2013-09-28  Mark Rowe  <mrowe@apple.com>
821
822         Fix some failures with newer versions of clang.
823
824         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
825         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
826         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
827         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
828         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
829
830         Reviewed by Dan Bernstein.
831
832         * DumpRenderTree/mac/Configurations/Base.xcconfig:
833         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
834         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
835         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
836         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
837         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
838         * WebKitTestRunner/Configurations/Base.xcconfig:
839         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
840         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
841         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
842         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
843
844 2013-09-27  Commit Queue  <commit-queue@webkit.org>
845
846         Unreviewed, rolling out r156569.
847         http://trac.webkit.org/changeset/156569
848         https://bugs.webkit.org/show_bug.cgi?id=122035
849
850         broke a lot of mismatch tests (Requested by thorton on
851         #webkit).
852
853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
854         (WTR::PlatformWebView::PlatformWebView):
855
856 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
857
858         Don't retry failures on Apple MountainLion Release WK1 tester
859         https://bugs.webkit.org/show_bug.cgi?id=122026
860
861         Reviewed by Mark Rowe.
862
863         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
864         on this bot.
865
866 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
867
868         Don't hardcode builder specific configuration in buildbot master.cfg
869         https://bugs.webkit.org/show_bug.cgi?id=122023
870
871         Reviewed by Mark Rowe.
872
873         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
874         property to Qt Mountain Lion Release, making it run pixel tests.
875
876         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
877         (RunWebKitTests.start): Use additionalArguments.
878         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
879
880 2013-09-27  Tim Horton  <timothy_horton@apple.com>
881
882         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
883         https://bugs.webkit.org/show_bug.cgi?id=122006
884         <rdar://problem/15095197>
885
886         Reviewed by Dean Jackson.
887
888         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
889         (WTR::PlatformWebView::PlatformWebView):
890         Layer-back the root view in WebKitTestRunner's window, to work around a bug
891         where the window server snapshot API returns blank snapshots.
892
893 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
894
895         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
896         https://bugs.webkit.org/show_bug.cgi?id=106924
897
898         Reviewed by Chris Fleizach.
899
900         Consider headings levels as values to be returned in intValue()
901         both in DRT and WKTR, so we can share more tests with other ports.
902
903         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
904         (AccessibilityUIElement::intValue): Consider headings too.
905         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
906         (WTR::AccessibilityUIElement::intValue): Ditto.
907
908 2013-09-26  Darin Adler  <darin@apple.com>
909
910         rename KURL to URL
911         https://bugs.webkit.org/show_bug.cgi?id=16214
912
913         Reviewed by Andreas Kling.
914
915         * many files: Renamed, using script.
916
917 2013-09-27  Darin Adler  <darin@apple.com>
918
919         Fix Python scripts test failures.
920
921         * Scripts/webkitpy/style/checkers/cpp.py:
922         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
923         now, not by the checker itself.
924
925 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
926
927         [GTK][WK2] Logging of accessibility events is not disabled between tests
928         https://bugs.webkit.org/show_bug.cgi?id=121957
929
930         Reviewed by Mario Sanchez Prada.
931
932         Fixed an issue in AccessibilityNotificationHandler where the destructor
933         was not disconnecting accessibility event callbacks if logging was on.
934         The decision of disconnecting events can solely rely on the existence of
935         notification handlers because logging uses the global notification
936         handler.
937
938         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
939         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
940         disconnection when logging is on.
941
942 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
943
944         Add general CMakeLists.txt for DRT
945         https://bugs.webkit.org/show_bug.cgi?id=119268
946
947         Reviewed by Gyuyoung Kim.
948
949         The new file allows better sharing between ports.
950
951         * CMakeLists.txt:
952         * DumpRenderTree/CMakeLists.txt: Added.
953         * DumpRenderTree/PlatformEfl.cmake: Added.
954         * DumpRenderTree/efl/CMakeLists.txt: Removed.
955
956 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
957
958         [Qt] Fix force_static_libs_as_shared in WebKit2
959         https://bugs.webkit.org/show_bug.cgi?id=121961
960
961         Reviewed by Csaba Osztrogonác.
962
963         Reenable force_static_libs_as_shared when building WebKit2.
964
965         * qmake/mkspecs/features/default_post.prf:
966
967 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
968
969         [Qt] Mock implementations of positioning and orientation not used
970         https://bugs.webkit.org/show_bug.cgi?id=121956
971
972         Reviewed by Csaba Osztrogonác.
973
974         Move production_build checks to sanitizeFeatures where its value is actually known.
975
976         * qmake/mkspecs/features/features.prf:
977         * qmake/mkspecs/features/features.pri:
978
979 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
980
981         [ATK] Normalize checks in entry points for DRT and WKTR
982         https://bugs.webkit.org/show_bug.cgi?id=121959
983
984         Reviewed by Chris Fleizach.
985
986         Always check if we have a proper instance of AtkObject,
987         implementing the interfaces that we might need for each case, at
988         the entry point of every method of AccessibilityUIElement for ATK,
989         and do those checks in an uniform way across DRT and WKTR, to
990         avoid confusion and issues when modifying these files in the future.
991
992         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
993         (AccessibilityUIElement::getChildren): Use normalized checks.
994         (AccessibilityUIElement::getChildrenWithRange): Ditto.
995         (AccessibilityUIElement::rowCount): Ditto.
996         (AccessibilityUIElement::columnCount): Ditto.
997         (AccessibilityUIElement::childrenCount): Ditto.
998         (AccessibilityUIElement::elementAtPoint): Ditto.
999         (AccessibilityUIElement::getChildAtIndex): Ditto.
1000         (AccessibilityUIElement::allAttributes): Ditto.
1001         (AccessibilityUIElement::titleUIElement): Ditto.
1002         (AccessibilityUIElement::parentElement): Ditto.
1003         (AccessibilityUIElement::attributesOfChildren): Ditto.
1004         (AccessibilityUIElement::role): Ditto.
1005         (AccessibilityUIElement::title): Ditto.
1006         (AccessibilityUIElement::description): Ditto.
1007         (AccessibilityUIElement::stringValue): Ditto.
1008         (AccessibilityUIElement::language): Ditto.
1009         (AccessibilityUIElement::x): Ditto.
1010         (AccessibilityUIElement::y): Ditto.
1011         (AccessibilityUIElement::width): Ditto.
1012         (AccessibilityUIElement::height): Ditto.
1013         (AccessibilityUIElement::orientation): Ditto.
1014         (AccessibilityUIElement::intValue): Ditto.
1015         (AccessibilityUIElement::minValue): Ditto.
1016         (AccessibilityUIElement::maxValue): Ditto.
1017         (indexRangeInTable): Ditto.
1018         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
1019         (AccessibilityUIElement::stringAttributeValue): Ditto.
1020         (alterCurrentValue): Ditto.
1021         (AccessibilityUIElement::press): Ditto.
1022         (AccessibilityUIElement::documentEncoding): Ditto.
1023         (AccessibilityUIElement::documentURI): Ditto.
1024         (AccessibilityUIElement::hasPopup): Ditto.
1025
1026         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1027         (WTR::indexRangeInTable): Use normalized checks.
1028         (WTR::alterCurrentValue): Ditto.
1029         (WTR::AccessibilityUIElement::getChildren): Ditto.
1030         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
1031         (WTR::AccessibilityUIElement::childrenCount): Ditto.
1032         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
1033         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
1034         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
1035         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
1036         (WTR::AccessibilityUIElement::parentElement): Ditto.
1037         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
1038         (WTR::AccessibilityUIElement::allAttributes): Ditto.
1039         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1040         (WTR::AccessibilityUIElement::role): Ditto.
1041         (WTR::AccessibilityUIElement::title): Ditto.
1042         (WTR::AccessibilityUIElement::description): Ditto.
1043         (WTR::AccessibilityUIElement::orientation): Ditto.
1044         (WTR::AccessibilityUIElement::stringValue): Ditto.
1045         (WTR::AccessibilityUIElement::language): Ditto.
1046         (WTR::AccessibilityUIElement::x): Ditto.
1047         (WTR::AccessibilityUIElement::y): Ditto.
1048         (WTR::AccessibilityUIElement::width): Ditto.
1049         (WTR::AccessibilityUIElement::height): Ditto.
1050         (WTR::AccessibilityUIElement::intValue): Ditto.
1051         (WTR::AccessibilityUIElement::minValue): Ditto.
1052         (WTR::AccessibilityUIElement::maxValue): Ditto.
1053         (WTR::AccessibilityUIElement::rowCount): Ditto.
1054         (WTR::AccessibilityUIElement::columnCount): Ditto.
1055         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
1056         (WTR::AccessibilityUIElement::press): Ditto.
1057         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
1058         (WTR::AccessibilityUIElement::documentURI): Ditto.
1059         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1060
1061 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1062
1063         [ATK] accessibility/aria-sort.html is failing after r156409
1064         https://bugs.webkit.org/show_bug.cgi?id=121947
1065
1066         Reviewed by Chris Fleizach.
1067
1068         Implement AccessibilityUIElement::isSupported for the ATK
1069         platforms, just by checking whether we have an associated object
1070         attribute exposed for the wrapper object matching the required
1071         attribute in the layout test (e.g "AXSortDirection" -> "sort").
1072
1073         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1074         (AccessibilityUIElement::isAttributeSupported): Implemented.
1075         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1076         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
1077
1078 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
1079
1080         [MediaStream] make MediaStream testable
1081         https://bugs.webkit.org/show_bug.cgi?id=121967
1082
1083         Reviewed by Dean Jackson.
1084
1085         * DumpRenderTree/mac/UIDelegate.mm:
1086         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
1087             user media request policy delegate.
1088
1089 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
1090
1091         build-webkit --inspector-frontend should copy WebInspectorUI files
1092         https://bugs.webkit.org/show_bug.cgi?id=117851
1093
1094         Reviewed by Joseph Pecoraro.
1095
1096         Change the --inspector-frontend build option to additionally build/copy 
1097         WebInspectorUI by setting it as the only project that needs to be built.
1098
1099         * Scripts/build-webkit:
1100
1101 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
1102
1103         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
1104         https://bugs.webkit.org/show_bug.cgi?id=121951
1105
1106         Reviewed by Carlos Garcia Campos.
1107
1108         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
1109         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
1110         500 layout tests that trigger accelerated compositing to be used.
1111
1112         * Scripts/webkitpy/port/xvfbdriver.py:
1113         (XvfbDriver._start):
1114         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
1115         (XvfbDriverTest.test_start_no_pixel_tests):
1116         (XvfbDriverTest.test_start_pixel_tests):
1117         (XvfbDriverTest.test_start_arbitrary_worker_number):
1118         (XvfbDriverTest.test_next_free_display):
1119         (XvfbDriverTest.test_start_next_worker):
1120
1121 2013-09-26  Tim Horton  <timothy_horton@apple.com>
1122
1123         Tiled drawing should not imply threaded scrolling
1124         https://bugs.webkit.org/show_bug.cgi?id=121874
1125         <rdar://problem/15071494>
1126
1127         Reviewed by Sam Weinig.
1128
1129         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1130         (WTR::PlatformWebView::PlatformWebView):
1131         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
1132
1133 2013-09-26  Commit Queue  <commit-queue@webkit.org>
1134
1135         Unreviewed, rolling out r156457.
1136         http://trac.webkit.org/changeset/156457
1137         https://bugs.webkit.org/show_bug.cgi?id=121960
1138
1139         Broke webkitpy tests. (Requested by kling on #webkit).
1140
1141         * Scripts/webkitpy/port/xvfbdriver.py:
1142         (XvfbDriver._start):
1143
1144 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
1145
1146         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
1147         https://bugs.webkit.org/show_bug.cgi?id=121951
1148
1149         Reviewed by Carlos Garcia Campos.
1150
1151         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
1152         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
1153         500 layout tests that trigger accelerated compositing to be used.
1154
1155         * Scripts/webkitpy/port/xvfbdriver.py:
1156         (XvfbDriver._start):
1157
1158 2013-09-25  Alex Christensen  <achristensen@webkit.org>
1159
1160         Removed check for Apple Application Support directory in WinCairo port.
1161         https://bugs.webkit.org/show_bug.cgi?id=121869
1162
1163         Reviewed by Brent Fulgham.
1164
1165         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1166         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1167         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1168         Use DLLLauncherWinCairo.props for WinCairo ports.
1169         * win/DLLLauncher/DLLLauncherMain.cpp:
1170         (wWinMain):
1171         Don't call modifyPath to check for AAS in the WinCairo port.
1172         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
1173
1174 2013-09-25  Alex Christensen  <achristensen@webkit.org>
1175
1176         Enabled AssembleBuildLogs on WinCairo port.
1177         https://bugs.webkit.org/show_bug.cgi?id=121923
1178
1179         Reviewed by Brent Fulgham.
1180
1181         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1182         Fixed reference to README, added WinCairo configurations.
1183         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
1184         Fixed reference to README.
1185         * win/AssembleBuildLogs/AssembleLogs.cmd:
1186         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
1187         * win/AssembleBuildLogs/README: Fixed spelling.
1188
1189 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
1190
1191         [WIN] Fix MSVC C4146 compiler warning
1192         https://bugs.webkit.org/show_bug.cgi?id=121838
1193
1194         Reviewed by Brent Fulgham.
1195
1196         Fix some variables from unsinged to int to fix the compiler warning
1197         "unary minus operator applied to unsigned type, result still unsigned".
1198
1199         * DumpRenderTree/WorkQueueItem.h:
1200         (BackItem::BackItem):
1201         (ForwardItem::ForwardItem):
1202         * DumpRenderTree/win/DumpRenderTree.cpp:
1203         (createWebViewAndOffscreenWindow):
1204
1205 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
1206
1207         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
1208         https://bugs.webkit.org/show_bug.cgi?id=121256
1209
1210         Reviewed by Martin Robinson.
1211
1212         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
1213         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/config.json:
1216
1217 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
1218
1219         Add style checker for CMake lists
1220         https://bugs.webkit.org/show_bug.cgi?id=121764
1221
1222         Reviewed by Ryosuke Niwa.
1223
1224         Add an additional check to make sure that list of files are sorted.
1225         Exclude lists of include directories for now, since the order
1226         can be importent for compilation of some files.
1227
1228         * Scripts/webkitpy/style/checkers/cmake.py:
1229         (CMakeChecker.check):
1230         (CMakeChecker._check_indent):
1231         (CMakeChecker):
1232         (CMakeChecker._check_list_order):
1233         (CMakeChecker._list_item_path):
1234         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1235         (CMakeCheckerTest.test_check):
1236
1237 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
1238
1239         CMakeChecker takes unusually long time to run
1240         https://bugs.webkit.org/show_bug.cgi?id=105662
1241
1242         Reviewed by Ryosuke Niwa.
1243
1244         Move the caching mechanism for regular expression of the C++ checker into
1245         a common file and use it for the CMake and ChangeLog checkers too.
1246
1247         * Scripts/webkitpy/style/checkers/changelog.py:
1248         (ChangeLogChecker.check_entry):
1249         * Scripts/webkitpy/style/checkers/cmake.py:
1250         (CMakeChecker._process_line):
1251         (CMakeChecker._check_no_space_cmds):
1252         (CMakeChecker._check_one_space_cmds):
1253         (CMakeChecker._check_non_lowercase_cmd):
1254         * Scripts/webkitpy/style/checkers/common.py:
1255         (match):
1256         (search):
1257         (searchIgnorecase):
1258         (sub):
1259         (subn):
1260         * Scripts/webkitpy/style/checkers/cpp.py:
1261
1262 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1263
1264         [Qt] Fix build with Qt 5.2 QtPosition module
1265         https://bugs.webkit.org/show_bug.cgi?id=121089
1266
1267         Reviewed by Simon Hausmann.
1268
1269         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
1270         that might depend on them.
1271
1272         * qmake/mkspecs/features/default_pre.prf:
1273         * qmake/mkspecs/features/features.prf:
1274
1275 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
1276
1277         [ATK] Fix style issues in AccessibilityUIElementAtk
1278         https://bugs.webkit.org/show_bug.cgi?id=121898
1279
1280         Reviewed by Chris Fleizach.
1281
1282         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
1283         instead of { 0, { { 0 } } } to initialize a GValue.
1284
1285         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1286         (AccessibilityUIElement::clickPointX): Remove suffix.
1287         (AccessibilityUIElement::clickPointY): Ditto.
1288         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
1289         (AccessibilityUIElement::minValue): Ditto.
1290         (AccessibilityUIElement::maxValue): Ditto.
1291         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
1292         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1293         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
1294         (WTR::AccessibilityUIElement::x): Ditto.
1295         (WTR::AccessibilityUIElement::y): Ditto.
1296         (WTR::AccessibilityUIElement::width): Ditto.
1297         (WTR::AccessibilityUIElement::height): Ditto.
1298         (WTR::AccessibilityUIElement::clickPointX): Ditto.
1299         (WTR::AccessibilityUIElement::clickPointY): Ditto.
1300         (WTR::AccessibilityUIElement::intValue): Ditto.
1301         (WTR::AccessibilityUIElement::minValue): Ditto.
1302         (WTR::AccessibilityUIElement::maxValue): Ditto.
1303
1304 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
1305
1306         [EFL] accessibility/loading-iframe-sends-notification.html is failing
1307         https://bugs.webkit.org/show_bug.cgi?id=112003
1308
1309         Reviewed by Mario Sanchez Prada.
1310
1311         Enabled addNotificationListener and removeNotificationListener for EFL port.
1312
1313         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1314         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1315         (WTR::AccessibilityController::removeNotificationListener):
1316
1317 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
1318
1319         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
1320         https://bugs.webkit.org/show_bug.cgi?id=121844
1321
1322         Reviewed by Mark Hahnenberg.
1323
1324         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
1325
1326 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
1327
1328         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
1329         https://bugs.webkit.org/show_bug.cgi?id=121854
1330
1331         Reviewed by Anders Carlsson.
1332
1333         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1334         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
1335         settings in underlying frameworks.
1336
1337 2013-09-24  Mark Rowe  <mrowe@apple.com>
1338
1339         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
1340
1341         Reviewed by Dan Bernstein.
1342
1343         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1344         * MiniBrowser/Configurations/Base.xcconfig:
1345         * TestWebKitAPI/Configurations/Base.xcconfig:
1346         * WebKitLauncher/Configurations/Base.xcconfig:
1347         * WebKitTestRunner/Configurations/Base.xcconfig:
1348
1349 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
1350
1351         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
1352         https://bugs.webkit.org/show_bug.cgi?id=121674
1353
1354         Reviewed by Mario Sanchez Prada.
1355
1356         Implemented the global notification listener for
1357         AccessibilityController. The signal is generated by
1358         AXObjectCache::postPlatformNotification() and received by
1359         axObjectEventListener(). axObjectEventListener will then invoke
1360         JSObjectCallAsFunction() with the respective callback function.
1361
1362         There is no additional test for this patch since its implementation will
1363         be tested by an accessibility layout test that is currently failing
1364         (accessibility/loading-iframe-sends-notification.html).
1365
1366         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
1367         stub implementations of addNotificationListener and
1368         removeNotificationListener for the GTK port.
1369         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1370         (WTR::AccessibilityController::addNotificationListener): Creates the
1371         notification handler and sets the notification function callback.
1372         (WTR::AccessibilityController::removeNotificationListener): Removes the
1373         global handler.
1374
1375 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1376
1377         [GTK] fast/images/exif-orientation-composited.html is failing
1378         https://bugs.webkit.org/show_bug.cgi?id=119731
1379
1380         Reviewed by Carlos Garcia Campos.
1381
1382         Add handling respect image orientation property in DRT.
1383
1384         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1385         (TestRunner::overridePreference):
1386
1387 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
1388
1389         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
1390         https://bugs.webkit.org/show_bug.cgi?id=121787
1391
1392         Reviewed by Gustavo Noronha Silva.
1393
1394         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
1395         with the Wayland target enabled to version 3.10.0.
1396
1397 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
1398
1399         use NOMINMAX instead of #define min min
1400         https://bugs.webkit.org/show_bug.cgi?id=73563
1401
1402         Reviewed by Brent Fulgham.
1403
1404         Use NOMINMAX instead of #define min/max as a cleaner
1405         way of ensuring that Windows system header files don't
1406         define min/max as macro in the first place.
1407
1408         * DumpRenderTree/DumpRenderTreePrefix.h:
1409         * DumpRenderTree/cg/ImageDiffCG.cpp:
1410         * DumpRenderTree/config.h:
1411         * DumpRenderTree/win/ImageDiffCairo.cpp:
1412         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1413         * WebKitTestRunner/config.h:
1414
1415 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
1416
1417         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
1418         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
1419
1420         Reviewed by Alexey Proskuryakov.
1421
1422         Previously, initalizing a WebPreference would change the cache model
1423         to WebCacheModelDocumentBrowser. That behavior was due to a stale
1424         preference file on disk.
1425
1426         This patch fixes the tests by resetting the default, and using the proper
1427         default values after initializing WebPreference.
1428
1429         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1430         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
1431         to the previous runs.
1432
1433         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1434         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
1435         cache model to the one required.
1436
1437         * TestWebKitAPI/ios/mainIOS.mm:
1438         (main): Reset the preferences before testing.
1439         * TestWebKitAPI/mac/mainMac.mm:
1440         (main): Ditto.
1441
1442 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
1443
1444         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
1445         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
1446
1447         Reviewed by Alexey Proskuryakov.
1448
1449         Previously, initalizing a WebPreference would change the cache model
1450         to WebCacheModelDocumentBrowser. That behavior was due to a stale
1451         preference file on disk.
1452
1453         This patch fixes the tests by resetting the default, and using the proper
1454         default values after initializing WebPreference.
1455
1456         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
1457         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
1458         to the previous runs.
1459
1460         * TestWebKitAPI/ios/mainIOS.mm:
1461         (main): Reset the preferences before testing.
1462         * TestWebKitAPI/mac/mainMac.mm:
1463         (main): Ditto.
1464
1465 2013-09-23  Anders Carlsson  <andersca@apple.com>
1466
1467         ListHashSet should work with move-only types
1468         https://bugs.webkit.org/show_bug.cgi?id=121802
1469
1470         Reviewed by Andreas Kling.
1471
1472         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1473         (TestWebKitAPI::TEST):
1474         Add a test for move-only types.
1475
1476 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
1477
1478         Added --64-bit option for Windows build.
1479         https://bugs.webkit.org/show_bug.cgi?id=121799
1480
1481         Reviewed by Brent Fulgham.
1482
1483         * Scripts/webkitdirs.pm:
1484         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
1485         (isWin64): Added.
1486         (determineIsWin64): Added.
1487
1488 2013-09-23  Anders Carlsson  <andersca@apple.com>
1489
1490         ListHashSet should use std::reverse_iterator for reverse iterators
1491         https://bugs.webkit.org/show_bug.cgi?id=121795
1492
1493         Reviewed by Antti Koivisto.
1494
1495         Add test for reverse iterators.
1496
1497         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
1498         (TestWebKitAPI::TEST):
1499
1500 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
1501
1502         [EFL] accessibility/aria-invalid is failing
1503         https://bugs.webkit.org/show_bug.cgi?id=111986
1504
1505         Reviewed by Mario Sanchez Prada.
1506
1507         Adds possibility to retrieve JS context.
1508         This is part of the implementation of AccessibilityUIElement::addNotificationListener
1509         from 119883 and 120421.
1510
1511         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1512         (axObjectEventListener):
1513         (addAccessibilityNotificationHandler):
1514         (removeAccessibilityNotificationHandler):
1515         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1516         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1517         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1518
1519 2013-09-20  Mark Rowe  <mrowe@apple.com>
1520
1521         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
1522
1523         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
1524
1525         Reviewed by David Kilzer.
1526
1527         * Scripts/webkitdirs.pm:
1528         (checkRequiredSystemConfig):
1529
1530 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1531
1532         [ATK] Do not expose aria-help in ATK based platforms
1533         https://bugs.webkit.org/show_bug.cgi?id=121675
1534
1535         Reviewed by Chris Fleizach.
1536
1537         Remove the implementations for AccessibilityUIElement::helpText()
1538         from DRT and WKTR for GTK and EFL, since they are based on the
1539         AccessibilityObject::helpText() method and the 'aria-help'
1540         attributes, which is wrong since they should not depend on that
1541         but in ATK specific API (see also http://webkit.org/b/121684).
1542
1543         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1544         (AccessibilityUIElement::helpText): Added a new and empty
1545         implementation, now that we are no longer using this in ATK.
1546         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
1547         as the only function provided here was helpText().
1548         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
1549         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
1550         removed from the list of sources to compile.
1551         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
1552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1553         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
1554         based in DumpRenderTreeSupportGtk with an empty one.
1555
1556 2013-09-20  Dan Bernstein  <mitz@apple.com>
1557
1558         Make extract-localizable-strings available to WebCore clients
1559         https://bugs.webkit.org/show_bug.cgi?id=121699
1560
1561         Reviewed by Darin Adler.
1562
1563         * Scripts/extract-localizable-strings: Copied to
1564         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
1565         executes the script from its new location. This is a temporary measure until certain code
1566         that is external to WebKit is adapted to the new location.
1567         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
1568         from its new location.
1569
1570 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
1571
1572         Nuke remaining VS2005 tools from the tree.
1573         https://bugs.webkit.org/show_bug.cgi?id=121691
1574
1575         Reviewed by Brent Fulgham.
1576
1577         * CLWrapper/CLWrapper.cpp: Removed.
1578         * CLWrapper/CLWrapper.sln: Removed.
1579         * CLWrapper/CLWrapper.vcproj: Removed.
1580         * MIDLWrapper/MIDLWrapper.cpp: Removed.
1581         * MIDLWrapper/MIDLWrapper.sln: Removed.
1582         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
1583         * Scripts/parallelcl: Removed.
1584         * vcbin/cl.exe: Removed.
1585         * vcbin/midl.exe: Removed.
1586
1587 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
1588
1589         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
1590         https://bugs.webkit.org/show_bug.cgi?id=121294
1591
1592         Reviewed by Martin Robinson.
1593
1594         Provide a new patch to deal with the issue in the GTK+ module from
1595         the internal jhbuild environment. This issue has been reported
1596         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
1597
1598         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
1599         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
1600
1601 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
1602
1603         [ATK][WTR] accessibility/aria-invalid.html times out
1604         https://bugs.webkit.org/show_bug.cgi?id=121668
1605
1606         Reviewed by Mario Sanchez Prada.
1607
1608         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
1609         false in case of aria-invalid event with empty value.
1610
1611         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1612         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
1613         case of aria-invalid event with empty value.
1614
1615 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
1616
1617         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
1618         https://bugs.webkit.org/show_bug.cgi?id=120421
1619
1620         Reviewed by Mario Sanchez Prada.
1621
1622         Implemented the notification listener for AccessibilityUIElement for
1623         WebKitTestRunner. The signal is generated by
1624         AXObjectCache::postPlatformNotification() and received by
1625         axObjectEventListener(). axObjectEventListener() will then invoke
1626         JSObjectCallAsFunction() with the respective callback function. The
1627         notification handlers are stored in HashMap in
1628         AccessibilityNotificationHandlerAtk.cpp.
1629
1630         Moved ATK signal handling (printAccessibilityEvent and
1631         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
1632
1633         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
1634         include path.
1635         * WebKitTestRunner/GNUmakefile.am:
1636         Added AccessibilityNotificationHandlerAtk.cpp/h.
1637         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
1638         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
1639         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
1640         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
1641         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
1642         notification handler for GTK+ and EFL.
1643         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1644         Moved printAccessibilityEvent and axObjectEventListener to
1645         AccessibilityNotificationHandlerAtk.cpp.
1646         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
1647         IDs to AccessibilityNotificationHandlerAtk.cpp.
1648         (WTR::AccessibilityController::resetToConsistentState): Moved listener
1649         IDs to AccessibilityNotificationHandlerAtk.cpp.
1650         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
1651         (WTR::printAccessibilityEvent): Prints accessibility events. This
1652         function was moved from AccessibilityControllerAtk.cpp.
1653         (WTR::axObjectEventListener): Callback for signals. This function was
1654         moved from AccessibilityControllerAtk.cpp.
1655         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
1656         Initialize element and function callback.
1657         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
1658         Removes handler from HashMap and disconnects callbacks if necessary.
1659         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
1660         logging mode and connects callbacks.
1661         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
1662         Sets the notification callback and connects callback to signals.
1663         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
1664         Removes the notification callback from HashMap.
1665         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
1666         Connects axObjectEventListener to ATK signals.
1667         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1668         Disconnects callback.
1669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
1670         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
1671         of AccessibilityNotificationHandler.
1672         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
1673         element.
1674         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
1675         element.
1676         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
1677         Gets the notification callback.
1678         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1679         (WTR::AccessibilityUIElement::addNotificationListener): Creates
1680         notification handler, set the platform element and the notification
1681         callback.
1682         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
1683         notification handler.
1684         * WebKitTestRunner/PlatformEfl.cmake:
1685         Added AccessibilityNotificationHandlerAtk.cpp.
1686
1687 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1688
1689         Update features.pri
1690         https://bugs.webkit.org/show_bug.cgi?id=121670
1691
1692         Reviewed by Jocelyn Turcotte.
1693
1694         Remove feature flags that no longer exists and new ones added to FeatureList.pm
1695
1696         * qmake/mkspecs/features/features.pri:
1697
1698 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
1699
1700         [GTK][WK2] accessibility/selection-states.html is failing
1701         https://bugs.webkit.org/show_bug.cgi?id=116972
1702
1703         Reviewed by Mario Sanchez Prada.
1704
1705         isSelectable() was not exposed in Accessibility.
1706
1707         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1708
1709 2013-09-19  Dan Bernstein  <mitz@apple.com>
1710
1711         Attempted build fix after r156114.
1712
1713         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
1714
1715 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
1716
1717         REGRESSION (r129451): run-safari --no-saved-state is broken
1718         https://bugs.webkit.org/show_bug.cgi?id=121566
1719
1720         Undo a last minute change that doesn't actually work.
1721
1722         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
1723         via command line, <rdar://problem/15032886>.
1724
1725 2013-09-19  Dan Bernstein  <mitz@apple.com>
1726
1727         Add a style guideline regarding spacing in range-based for loops
1728         https://bugs.webkit.org/show_bug.cgi?id=121620
1729
1730         Reviewed by Anders Carlsson.
1731
1732         * Scripts/webkitpy/style/checkers/cpp.py:
1733         (check_spacing): Added checking that there are spaces around the colon in a range-based for
1734         loop.
1735         (CppChecker): Added whitespace/colon to the categories set.
1736         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1737         (WebKitStyleTest.test_spacing): Added two tests for the new check.
1738
1739 2013-09-18  Sam Weinig  <sam@webkit.org>
1740
1741         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
1742         https://bugs.webkit.org/show_bug.cgi?id=121588
1743
1744         Reviewed by Anders Carlsson.
1745
1746         * DumpRenderTree/TestRunner.cpp:
1747         * ImageDiff/efl/ImageDiff.cpp:
1748         * TestWebKitAPI/JavaScriptTest.cpp:
1749         * TestWebKitAPI/PlatformUtilities.cpp:
1750         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1751         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1752         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1753         * WebKitTestRunner/StringFunctions.h:
1754         * WebKitTestRunner/TestInvocation.cpp:
1755         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1756         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1757
1758 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
1759
1760         W3C Test Import script reformats test HTML
1761         https://bugs.webkit.org/show_bug.cgi?id=119159
1762
1763         Reviewed by Dirk Pranke.
1764
1765         Completely rewrite the test conversion process to minimize
1766         reformatting when adding prefixes, etc. This isn't 100% perfect, there
1767         are still places where it will end up changing the formatting, but it
1768         is much better than before. Most notably, the public interface to the
1769         test converter has changed: now one calls a method instead of creating
1770         an instance of the test converter class. This is because the test
1771         converter class now has state, so one really needs a new instance for
1772         each test.
1773
1774         Note that this also lays some simple groundwork for being able to use
1775         a MockHost in the tests.
1776
1777         * Scripts/webkitpy/w3c/test_converter.py:
1778         (convert_for_webkit):
1779         (_W3CTestConverter):
1780         (_W3CTestConverter.__init__):
1781         (_W3CTestConverter.output):
1782         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
1783         (_W3CTestConverter.convert_style_data):
1784         (_W3CTestConverter.convert_attributes_if_needed):
1785         (_W3CTestConverter.handle_starttag):
1786         (_W3CTestConverter.handle_endtag):
1787         (_W3CTestConverter.handle_startendtag):
1788         (_W3CTestConverter.handle_data):
1789         (_W3CTestConverter.handle_entityref):
1790         (_W3CTestConverter.handle_charref):
1791         (_W3CTestConverter.handle_comment):
1792         (_W3CTestConverter.handle_decl):
1793         (_W3CTestConverter.handle_pi):
1794         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1795         (W3CTestConverterTest):
1796         (W3CTestConverterTest.fake_dir_path):
1797         (W3CTestConverterTest.test_read_prefixed_property_list):
1798         (verify_no_conversion_happened):
1799         * Scripts/webkitpy/w3c/test_importer.py:
1800         (TestImporter.import_tests):
1801
1802 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
1803
1804         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
1805         https://bugs.webkit.org/show_bug.cgi?id=121578
1806
1807         Rubber stamped by Geoffrey Garen.
1808
1809         * Scripts/run-layout-jsc:
1810
1811 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
1812
1813         Unreviewed, fix for Ruby 1.8.
1814
1815         * Scripts/run-jsc-stress-tests:
1816
1817 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
1818
1819         run-jsc-stress-tests should make it easier to look at error spew from tests
1820         https://bugs.webkit.org/show_bug.cgi?id=121531
1821
1822         Reviewed by Mark Hahnenberg.
1823         
1824         This makes two changes:
1825         
1826         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
1827         
1828         - The same spew also goes to the console but is prefixed by the test's name.
1829         
1830         This required some tee and awk hacks, and then some sh hacks to work around the fact
1831         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
1832         operator will only see a failure of bar failed. So to pass output to tee and awk, I
1833         needed to do weird things.
1834
1835         * Scripts/run-jsc-stress-tests:
1836
1837 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
1838
1839         REGRESSION (r129451): run-safari --no-saved-state is broken
1840         https://bugs.webkit.org/show_bug.cgi?id=121566
1841
1842         Reviewed by Mark Rowe.
1843
1844         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
1845         Check arguments, not the newly created empty array. Pass a value that silences warnings.
1846         While at it, removed a check for Snow Leopard.
1847
1848 2013-09-18  Alex Christensen  <achristensen@webkit.org>
1849
1850         Improved WinLauncher's URL handling.
1851         https://bugs.webkit.org/show_bug.cgi?id=121535
1852
1853         Reviewed by Brent Fulgham.
1854
1855         * WinLauncher/WinLauncher.cpp:
1856         (EditProc):
1857         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
1858         (loadURL):
1859         Prepend "http://" to URLs with no scheme.
1860
1861 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
1862
1863         DFG should support Int52 for local variables
1864         https://bugs.webkit.org/show_bug.cgi?id=121064
1865
1866         Reviewed by Oliver Hunt.
1867
1868         * Scripts/run-jsc-stress-tests:
1869
1870 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
1871
1872         [Win] TestWebKitAPI does not compile.
1873         https://bugs.webkit.org/show_bug.cgi?id=121485
1874
1875         Reviewed by Brent Fulgham.
1876
1877         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
1878         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
1879         to return null, which is the case we want to test.
1880
1881         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1882         (TestWebKitAPI::TEST):
1883
1884 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
1885
1886         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
1887         https://bugs.webkit.org/show_bug.cgi?id=121495
1888
1889         Reviewed by Chris Fleizach.
1890
1891         Adapted DRT and WKTR to deal with the new names for the ATK object
1892         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
1893
1894         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1895         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
1896         (AccessibilityUIElement::stringAttributeValue): Ditto.
1897         (AccessibilityUIElement::hasPopup): Ditto.
1898         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1899         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
1900         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1901         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1902
1903 2013-09-18  Commit Queue  <commit-queue@webkit.org>
1904
1905         Unreviewed, rolling out r156019 and r156020.
1906         http://trac.webkit.org/changeset/156019
1907         http://trac.webkit.org/changeset/156020
1908         https://bugs.webkit.org/show_bug.cgi?id=121540
1909
1910         Broke tests (Requested by ap on #webkit).
1911
1912         * Scripts/run-jsc-stress-tests:
1913
1914 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
1915
1916         Unreviewed. Add myself as a committer.
1917
1918         * Scripts/webkitpy/common/config/contributors.json:
1919
1920 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
1921
1922         Unreviewed. Add myself as a committer.
1923
1924         * Scripts/webkitpy/common/config/contributors.json:
1925
1926 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
1927
1928         DFG should support Int52 for local variables
1929         https://bugs.webkit.org/show_bug.cgi?id=121064
1930
1931         Reviewed by Oliver Hunt.
1932
1933         * Scripts/run-jsc-stress-tests:
1934
1935 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
1936
1937         Added back and forward buttons to WinLauncher.
1938         https://bugs.webkit.org/show_bug.cgi?id=121212
1939
1940         Reviewed by Brent Fulgham.
1941
1942         * WinLauncher/WinLauncher.cpp:
1943         (resizeSubViews):
1944         Move new back and forward buttons to correct positions before URL bar.
1945         (dllLauncherEntryPoint): 
1946         Store the default button window procedure and replace with my button procedures.
1947         (EditProc): Updated style and renamed from MyEditProc.
1948         (BackButtonProc): Added.
1949         (ForwardButtonProc): Added.
1950
1951 2013-09-17  Michael Saboff  <msaboff@apple.com>
1952
1953         Unreviewed typo fix after r155999
1954
1955         Changed en_US.UTB-8 to en_US.UTF-8
1956
1957         * Scripts/run-javascriptcore-tests:
1958
1959 2013-09-17  Michael Saboff  <msaboff@apple.com>
1960
1961         run-jsc-stress-tests fails with ruby version 2
1962         https://bugs.webkit.org/show_bug.cgi?id=121521
1963
1964         Reviewed by Jessie Berlin.
1965
1966         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
1967
1968         * Scripts/run-javascriptcore-tests:
1969
1970 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
1971
1972         [Windows] Unreviewed build fix after r155963.
1973
1974         * DumpRenderTree/win/TestRunnerWin.cpp:
1975         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
1976
1977 2013-09-17  Anders Carlsson  <andersca@apple.com>
1978
1979         Fix a typo.
1980
1981         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1982         (TestWebKitAPI::TEST):
1983
1984 2013-09-16  Anders Carlsson  <andersca@apple.com>
1985
1986         HashMap should work with move-only keys
1987         https://bugs.webkit.org/show_bug.cgi?id=121310
1988
1989         Reviewed by Darin Adler.
1990
1991         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1992         (TestWebKitAPI::TEST):
1993         Add test.
1994
1995 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
1996
1997         BrowserMarshal.h build fail
1998         https://bugs.webkit.org/show_bug.cgi?id=102938
1999
2000         Reviewed by Carlos Garcia Campos.
2001
2002         Fix variable name.
2003
2004         * MiniBrowser/gtk/GNUmakefile.am:
2005
2006 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
2007
2008         [Windows] Clean up WinLauncher by using smart pointers
2009         https://bugs.webkit.org/show_bug.cgi?id=121467
2010
2011         Reviewed by Anders Carlsson.
2012
2013         * WinLauncher/PrintWebUIDelegate.cpp:
2014         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
2015         * WinLauncher/WinLauncher.cpp:
2016         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
2017         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
2018         (showLastVisitedSites): Smart pointer updates.
2019         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
2020         (setToDefaultPreferences): Ditto.
2021         (dllLauncherEntryPoint): Ditto.
2022         (PrintView): Ditto.
2023         (LaunchInspector): Ditto.
2024         (NavigateToHistory): Ditto.
2025         (MyEditProc): Ditto.
2026         (loadURL): Ditto.
2027
2028 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
2029
2030         [Windows] Add rudimentary history to WinLauncher.
2031         https://bugs.webkit.org/show_bug.cgi?id=121463
2032
2033         Reviewed by Anders Carlsson.
2034
2035         * WinLauncher/WinLauncher.cpp:
2036         (updateMenuItemForHistoryItem): Added
2037         (showLastVisitedSites): Added
2038         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
2039         a new page has been visited.
2040         (dllLauncherEntryPoint): Deallocate history on exit.
2041         (NavigateToHistory): Added
2042         (WndProc): Add handler for history entries
2043         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
2044         up to 10 history slots.
2045         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
2046         Windows utility library to allow use of _bstr_t type.
2047         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
2048         to hold up to 10 history slots.
2049         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
2050
2051 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
2052
2053         [GTK] Make symbol export filter more strict, and disable for dev/test builds
2054         https://bugs.webkit.org/show_bug.cgi?id=120586
2055
2056         Reviewed by Martin Robinson.
2057
2058         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
2059         makefiles, so they can be included unconditionally.
2060         * GtkLauncher/GNUmakefile.am: added.
2061         * Scripts/webkitdirs.pm:
2062         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
2063         to configure, since we consider builds done through build-webkit to be development
2064         and test builds.
2065         * gtk/GNUmakefile.am: added.
2066         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
2067         it's not necessary and it will not work now that the Scripts directory is not
2068         shipped in the tarball.
2069
2070 2013-09-16  Anders Carlsson  <andersca@apple.com>
2071
2072         WTF::Deque should work with move only types
2073         https://bugs.webkit.org/show_bug.cgi?id=121446
2074
2075         Reviewed by Andreas Kling.
2076
2077         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2078         (TestWebKitAPI::TEST):
2079         Add a test.
2080
2081 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
2082
2083         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
2084         https://bugs.webkit.org/show_bug.cgi?id=98410
2085
2086         Reviewed by Darin Adler.
2087
2088         Add implementation of click() method of objects returned by eventSender.contextClick().
2089
2090         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2091         (MenuItemPrivateData):
2092         (WTR::menuItemClickCallback):
2093         (WTR::getMenuItemTitleCallback):
2094         (WTR::staticMenuItemFinalize):
2095         (WTR::getMenuItemClass):
2096         (WTR::EventSendingController::contextClick):
2097
2098 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
2099
2100         Make the GDB webkit.py script compatible with Python v3
2101         https://bugs.webkit.org/show_bug.cgi?id=121395
2102
2103         Reviewed by Ryosuke Niwa.
2104
2105         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
2106         uses of xrange() in the script are replaced with range(), and the print statements are changed into
2107         the print() function invocations.
2108
2109         * gdb/webkit.py:
2110         (guess_string_length):
2111         (ustring_to_string):
2112         (lstring_to_string):
2113         (WTFCStringPrinter.to_string):
2114         (PrintPathToRootCommand.invoke):
2115
2116 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
2117
2118         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
2119         https://bugs.webkit.org/show_bug.cgi?id=119631
2120
2121         Reviewed by Ryosuke Niwa.
2122
2123         The perf profiler is attached to the test runner after the test runner has been launched,
2124         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
2125         UIProcess, meaning that WebProcess operations will not be profiled.
2126
2127         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
2128         This is done in the scope of already present support for wrapper scripts (such as valgrind)
2129         that are settable through the --wrapper option. This causes the perf profiler to correctly
2130         continue profiling the WebProcess after it was spawned.
2131
2132         When the profiler is launched, a wait process is launched with the profiler's pid as the
2133         argument. This ensures we can check that the profiler exited normally. If it did not, its
2134         output can be corrupted and can cause problems when that output is examined. The after-exit
2135         report is avoided in that case.
2136
2137         * Scripts/webkitpy/common/system/profiler.py:
2138         (Profiler.wrapper_arguments): The method returns an empty list by default.
2139         (Perf.__init__): Remove unnecessary member variables.
2140         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
2141         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
2142         the method returns a list of arguments that should be used as a wrapper for the test runner.
2143         The arguments specify the 'perf record' command, with the output file and the instruction to
2144         construct the call graph given as well.
2145         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
2146         whitespace in the profile lines.
2147         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
2148         running. If it is running even after that, or if the profiler process produced a non-zero exit
2149         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
2150         the top 10 lines of the profile and how to examine the profile further.
2151         * Scripts/webkitpy/port/driver.py:
2152         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
2153         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
2154         or an empty list otherwise.
2155         (Driver.cmd_line):
2156         * Scripts/webkitpy/port/driver_unittest.py:
2157         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
2158         for the testing-specific Port object.
2159         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
2160         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
2161         a parameter.
2162         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
2163         when profiling on the Linux platform with the perf profiler.
2164
2165 2013-09-14  Dan Bernstein  <mitz@apple.com>
2166
2167         [mac] Check For Framework Include Consistency build phase checks the wrong framework
2168         https://bugs.webkit.org/show_bug.cgi?id=121215
2169
2170         Reviewed by Mark Rowe.
2171
2172         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
2173         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
2174         public and private headers folder paths. Also tweaked the error messages’ format to make
2175         Xcode recognize them as errors.
2176
2177 2013-09-14  Alberto Garcia  <berto@igalia.com>
2178
2179         [GTK] Fails to compile if the build directory is in a different partition
2180         https://bugs.webkit.org/show_bug.cgi?id=121296
2181
2182         Reviewed by Martin Robinson.
2183
2184         Instead of using os.symlink() to install the gtk-doc templates,
2185         use os.link() first and fall back to os.symlink() if it fails.
2186
2187         * gtk/gtkdoc.py:
2188         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
2189
2190 2013-09-14  Alberto Garcia  <berto@igalia.com>
2191
2192         [GTK] WebKitGTK+ is linking against libxslt in too many places
2193         https://bugs.webkit.org/show_bug.cgi?id=121356
2194
2195         Reviewed by Martin Robinson.
2196
2197         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
2198         so we don't need to link against it.
2199
2200         * MiniBrowser/gtk/GNUmakefile.am:
2201         * TestWebKitAPI/GNUmakefile.am:
2202         * WebKitTestRunner/GNUmakefile.am:
2203
2204 2013-09-14  Ross Burton  <ross.burton@intel.com>
2205
2206         Uses gtk-doc tools even when --disable-gtk-doc passed
2207         https://bugs.webkit.org/show_bug.cgi?id=91239
2208
2209         Reviewed by Martin Robinson.
2210
2211         Don't run generate-gtkdoc on install if gtk-doc is disabled.
2212
2213         * GNUmakefile.am:
2214
2215 2013-09-14  Alberto Garcia  <berto@igalia.com>
2216
2217         [GTK] Fails to compile if the build directory is in a different partition
2218         https://bugs.webkit.org/show_bug.cgi?id=121296
2219
2220         Reviewed by Carlos Garcia Campos.
2221
2222         Use symlinks instead of hard links to support building on a
2223         different file system.
2224
2225         * gtk/gtkdoc.py:
2226         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
2227
2228 2013-09-13  Darin Adler  <darin@apple.com>
2229
2230         Use a better name than m_invertibleCTM
2231         https://bugs.webkit.org/show_bug.cgi?id=121341
2232
2233         Reviewed by Andreas Kling.
2234
2235         * Scripts/do-webcore-rename: Updated to do this replace as we do.
2236
2237 2013-09-13  Anders Carlsson  <andersca@apple.com>
2238
2239         Pick the correct overload when a const reference is passed to appendSlowCase.
2240         https://bugs.webkit.org/show_bug.cgi?id=121326
2241
2242         Reviewed by Darin Adler.
2243
2244         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2245         (TestWebKitAPI::TEST):
2246
2247 2013-09-13  Darin Adler  <darin@apple.com>
2248
2249         Rename confusingly named "runtimeObject" functions
2250         https://bugs.webkit.org/show_bug.cgi?id=121339
2251
2252         Reviewed by Sam Weinig.
2253
2254         * Scripts/do-webcore-rename: Updated to do this replace as usual.
2255
2256 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
2257
2258         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
2259         https://bugs.webkit.org/show_bug.cgi?id=121330
2260
2261         Reviewed by Mark Hahnenberg and Oliver Hunt.
2262
2263         We should run tests even if they don't have expected files yet.
2264         
2265         * Scripts/run-layout-jsc:
2266
2267 2013-09-13  Anders Carlsson  <andersca@apple.com>
2268
2269         Use nullptr instead of 0 in calls to HashMap::add
2270         https://bugs.webkit.org/show_bug.cgi?id=121322
2271
2272         Reviewed by Sam Weinig.
2273
2274         * DumpRenderTree/mac/TestRunnerMac.mm:
2275         (TestRunner::evaluateScriptInIsolatedWorld):
2276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2277         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
2278
2279 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2280
2281         [GTK] Move to the new web inspector
2282         https://bugs.webkit.org/show_bug.cgi?id=120647
2283
2284         Reviewed by Carlos Garcia Campos.
2285
2286         * GtkLauncher/main.c:
2287         (main): no longer set WEBKIT_INSPECTOR_PATH.
2288         * MiniBrowser/gtk/main.c:
2289         (main): ditto.
2290         * Scripts/old-run-webkit-tests:
2291         (openDumpTool): ditto.
2292         * Scripts/run-gtk-tests: ditto.
2293         * Scripts/webkitpy/port/gtk.py:
2294         (GtkPort.setup_environ_for_server): ditto.
2295
2296 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2297
2298         [Qt] REGRESSION(r154444): xss-DENIED test results changed
2299         https://bugs.webkit.org/show_bug.cgi?id=120595
2300
2301         Reviewed by Jocelyn Turcotte.
2302
2303         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
2304
2305         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2306         (DumpRenderTree::initJSObjects):
2307
2308 2013-09-13  Darin Adler  <darin@apple.com>
2309
2310         Give actions in Range class NON_SHOUTING_NAMES
2311         https://bugs.webkit.org/show_bug.cgi?id=121280
2312
2313         Reviewed by Andreas Kling.
2314
2315         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
2316         the tradition of checking in the last one we did, along with other
2317         rename ideas for the future.
2318
2319 2013-09-12  Lucas Forschler  <lforschler@apple.com>
2320
2321         Create short build logs for errors and warnings.
2322         https://bugs.webkit.org/show_bug.cgi?id=120614
2323
2324         Reviewed by Ryosuke Niwa.
2325
2326         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2327             -include StringIO 
2328         (CompileWebKit.createSummary):
2329             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
2330
2331 2013-09-12  Roger Fong  <roger_fong@apple.com>
2332
2333         Update cygwin downloader to search for packages in the right location.
2334
2335         * CygwinDownloader/cygwin-downloader.py:
2336         * CygwinDownloader/cygwin-downloader.zip:
2337
2338 2013-09-12  Anders Carlsson  <andersca@apple.com>
2339
2340         Add rudimentary support for move-only types as values in HashMap
2341         https://bugs.webkit.org/show_bug.cgi?id=121226
2342
2343         Reviewed by Andreas Kling.
2344
2345         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2346         (TestWebKitAPI::TEST):
2347         Add a HashMap<unsigned, MoveOnly> test.
2348
2349 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2350
2351         Auto GDB backtrace generation for EFL/GTK/Qt bots.
2352         https://bugs.webkit.org/show_bug.cgi?id=119338
2353
2354         Reviewed by Csaba Osztrogonác.
2355
2356         * Scripts/webkitpy/port/efl.py:
2357         (EflPort.check_sys_deps):
2358         (EflPort):
2359         (EflPort._get_crash_log):
2360         * Scripts/webkitpy/port/efl_unittest.py:
2361         (EflPortTest.test_show_results_html_file):
2362         (EflPortTest):
2363         (EflPortTest.test_get_crash_log):
2364         * Scripts/webkitpy/port/gtk.py:
2365         (GtkPort._get_crash_log):
2366         * Scripts/webkitpy/port/gtk_unittest.py:
2367         (GtkPortTest.test_get_crash_log):
2368         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
2369         (GDBCrashLogGenerator):
2370         (GDBCrashLogGenerator.__init__):
2371         (GDBCrashLogGenerator._get_gdb_output):
2372         (GDBCrashLogGenerator.generate_crash_log):
2373         (GDBCrashLogGenerator.generate_crash_log.match_filename):
2374         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
2375         (GDBCrashLogGeneratorTest):
2376         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2377         (_mock_gdb_output):
2378         * Scripts/webkitpy/port/qt.py:
2379         (QtPort.default_child_processes):
2380         (QtPort):
2381         (QtPort._get_crash_log):
2382         * Scripts/webkitpy/port/qt_unittest.py:
2383         (QtPortTest.test_check_sys_deps):
2384         (QtPortTest):
2385         (QtPortTest.test_get_crash_log):
2386
2387 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
2388
2389         Unreviewed. Moving myself to the commiters list.
2390
2391         * Scripts/webkitpy/common/config/contributors.json:
2392
2393 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
2394
2395         [GTK] Add jhbuild-wayland.modules
2396         https://bugs.webkit.org/show_bug.cgi?id=120455
2397
2398         Reviewed by Gustavo Noronha Silva.
2399
2400         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
2401         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
2402         WEBKIT_EXTRA_MODULESETS.
2403
2404         * gtk/jhbuild-wayland.modules: Added.
2405
2406 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
2407
2408         [GTK][WK2] a11y tests unconditionally launching a11y daemons
2409         https://bugs.webkit.org/show_bug.cgi?id=120299
2410
2411         Reviewed by Carlos Garcia Campos.
2412
2413         Use the right variable name to store a reference to the at-spi2
2414         bus launcher process, so we can be sure we are terminating it when
2415         calling _tear_down_testing_environment().
2416
2417         * Scripts/run-gtk-tests:
2418         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
2419         instead of _ally_bus_launcher.
2420
2421 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2422
2423         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
2424         https://bugs.webkit.org/show_bug.cgi?id=121218
2425
2426         Reviewed by Philippe Normand.
2427
2428         Skipping the entire suite was added to skip tests when they can't
2429         be run because of the environment, for example to skip the a11y
2430         tests when the at-spi daemons fail to start. This is no longer
2431         true for all the cases, so we can disable the tests that are
2432         impossible to run instead of skipping them.
2433
2434         * Scripts/run-gtk-tests:
2435         (TestRunner.__init__): Initialize the skipped tests list.
2436         (TestRunner._setup_testing_environment): Add
2437         TestWebKitAccessibility path to the list of disabled tests when
2438         at-spi daemon fail to start.
2439         (TestRunner._should_run_test_program): Check first if the test
2440         program is disabled and then whether it's skipped honoring the
2441         skipped command line option.
2442
2443 2013-09-12  Samuel White  <samuel_white@apple.com>
2444
2445         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
2446         https://bugs.webkit.org/show_bug.cgi?id=117651
2447
2448         Reviewed by Mario Sanchez Prada.
2449
2450         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
2451
2452         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2453         (AccessibilityUIElement::valueDescription):
2454         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2455         (WTR::AccessibilityUIElement::valueDescription):
2456
2457 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
2458
2459         REGRESSION(r154781): accessibility/notification-listeners.html is failing
2460         https://bugs.webkit.org/show_bug.cgi?id=120669
2461
2462         Reviewed by Chris Fleizach.
2463
2464         Fixed 4 problems that were causing notification-listeners.html to fail.
2465
2466         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
2467         implemented in axObjectEventListener().
2468
2469         A notification for AXFocusedUIElementChanged was incorrectly sent when
2470         the element lost focus.
2471
2472         Global notification was not dispatched if an element notification was
2473         present in the HashMap.
2474
2475         connectAccessibilityCallbacks() was connecting signals to callbacks
2476         multiple times because it was not checking if
2477         disconnectAccessibilityCallbacks() had an early return if there were
2478         active handlers.
2479
2480         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
2481         disconnectAccessibilityCallbacks() to inform if the callbacks were
2482         successfully disconnected.
2483         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2484         (axObjectEventListener): Implemented notifications for
2485         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
2486         notification, which was not dispatched if an element notification
2487         existed. Fixed the notification for AXFocusedUIElementChanged that was
2488         incorrectly sent when the element lost focus. In addition, fixed a typo
2489         where TRUE should be true.
2490         (connectAccessibilityCallbacks): Added early return if
2491         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
2492         (disconnectAccessibilityCallbacks): Added a return value to inform if
2493         callbacks were successfully disconnected.
2494
2495 2013-09-11  Anders Carlsson  <andersca@apple.com>
2496
2497         Try to fix GCC builds.
2498
2499         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
2500
2501 2013-09-11  Anders Carlsson  <andersca@apple.com>
2502
2503         Try to fix the build.
2504
2505         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
2506         file in the Tests/ directory in the first place.
2507
2508         * TestWebKitAPI/CMakeLists.txt:
2509         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
2510         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2511         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2512         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
2513
2514 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
2515
2516         [Windows] Build fix for MoveOnly
2517
2518         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
2519         Tests to include search path.
2520         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
2521         Ditto.
2522
2523 2013-09-11  Anders Carlsson  <andersca@apple.com>
2524
2525         Add HashSet::take
2526         https://bugs.webkit.org/show_bug.cgi?id=121192
2527
2528         Reviewed by Darin Adler.
2529
2530         Add a test for HashSet::take.
2531
2532         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2533         (TestWebKitAPI::TEST):
2534
2535 2013-09-11  Anders Carlsson  <andersca@apple.com>
2536
2537         HashSet should work with move only types
2538         https://bugs.webkit.org/show_bug.cgi?id=121188
2539
2540         Reviewed by Geoffrey Garen.
2541
2542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2543         * TestWebKitAPI/Tests/MoveOnly.h: Added.
2544         Move the MoveOnly class from Vector out into its own header.
2545
2546         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2547         (TestWebKitAPI::TEST):
2548         Add aHashSet<MoveOnly> test.
2549
2550         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2551         Include MoveOnly.h.
2552
2553 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
2554
2555         [Windows] Avoid converting from IntSize->SIZE->IntSize
2556         https://bugs.webkit.org/show_bug.cgi?id=121180
2557
2558         Reviewed by Anders Carlsson.
2559
2560         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2561         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
2562
2563 2013-09-11  Dan Bernstein  <mitz@apple.com>
2564
2565         REGRESSION (r155561): extract-localizable-strings can miss strings
2566         https://bugs.webkit.org/show_bug.cgi?id=121184
2567
2568         Reviewed by Darin Adler.
2569
2570         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
2571         parenthesis or bracket.
2572
2573 2013-09-11  Dan Bernstein  <mitz@apple.com>
2574
2575         update-webkit-localizable-strings is at least 5.8x slower than it should be
2576         https://bugs.webkit.org/show_bug.cgi?id=121178
2577
2578         Reviewed by Darin Adler.
2579
2580         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
2581         Note that this does not change functionality, because the script already does not understand
2582         the line continuation sequence (backslash followed by a newline).
2583
2584 2013-09-11  Anders Carlsson  <andersca@apple.com>
2585
2586         Vector::append doesn't work if element type has overloaded operator&
2587         https://bugs.webkit.org/show_bug.cgi?id=121175
2588
2589         Reviewed by Brent Fulgham.
2590
2591         Add a test case.
2592
2593         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2594         (TestWebKitAPI::TEST):
2595
2596 2013-09-11  Anders Carlsson  <andersca@apple.com>
2597
2598         Implement Vector::append for move-only types
2599         https://bugs.webkit.org/show_bug.cgi?id=120805
2600
2601         Reviewed by Sam Weinig.
2602
2603         Add a test for Vector<MoveOnly>::append.
2604
2605         * TestWebKitAPI/Tests/WTF/Vector.cpp:
2606         (TestWebKitAPI::TEST):
2607
2608 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
2609
2610         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
2611
2612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2613         (RunAndUploadPerfTests):
2614         (RunAndUploadPerfTests.start):
2615         (RunAndUploadPerfTests.getText2):
2616
2617 2013-09-11  Anders Carlsson  <andersca@apple.com>
2618
2619         The style checker shouldn't complain about returning or passing OwnPtr
2620         https://bugs.webkit.org/show_bug.cgi?id=121163
2621
2622         Reviewed by Antti Koivisto.
2623
2624         * Scripts/webkitpy/style/checkers/cpp.py:
2625         (check_function_definition_and_pass_ptr):
2626         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2627         (PassPtrTest.test_pass_ref_ptr_return_value):
2628         (PassPtrTest.test_own_ptr_parameter_value):
2629
2630 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
2631
2632         [GTK] Remove Gail dependency from build system for GTK3
2633         https://bugs.webkit.org/show_bug.cgi?id=119673
2634
2635         Reviewed by Gustavo Noronha Silva.
2636
2637         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
2638         * Scripts/webkitpy/port/gtk.py:
2639         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
2640         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
2641
2642 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2643
2644         Performance tester bots should report the number of failing tests
2645         https://bugs.webkit.org/show_bug.cgi?id=120462
2646
2647         Reviewed by Csaba Osztrogonác.
2648
2649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2650         (RunAndUploadPerfTests.start.getText):
2651         (RunAndUploadPerfTests.start):
2652         (RunAndUploadPerfTests):
2653         (RunAndUploadPerfTests.start.getText2):
2654
2655 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
2656
2657         [ATK] Adds mapping MenuItemRadioRole to ATK
2658         https://bugs.webkit.org/show_bug.cgi?id=121149
2659
2660         Reviewed by Mario Sanchez Prada.
2661
2662         Adds mapping MenuItemRadioRole to ATK.
2663
2664         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2665         (roleToString):
2666         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2667         (WTR::roleToString):
2668
2669 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
2670
2671         Unreviewed fix after the unreviewed r155498 to unbreak the failure
2672         counter of run-javascriptcore-tests build step on build.webkit.org.
2673
2674         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2675         (RunJavaScriptCoreTests.commandComplete):
2676         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2677
2678 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
2679
2680         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
2681         got a bit overlooked from the fast/js->js refactoring.
2682
2683         * Scripts/run-javascriptcore-tests:
2684
2685 2013-09-10  Daniel Bates  <dabates@apple.com>
2686
2687         [iOS] Upstream text autosizing
2688         https://bugs.webkit.org/show_bug.cgi?id=121111
2689
2690         Reviewed by Andy Estes and Sam Weinig.
2691
2692         Implement infrastructure to test the iOS text autosizing code.
2693
2694         * DumpRenderTree/TestRunner.cpp:
2695         (setTextAutosizingEnabledCallback): Added.
2696         (TestRunner::staticFunctions):
2697         * DumpRenderTree/TestRunner.h:
2698         * DumpRenderTree/mac/DumpRenderTree.mm:
2699         (resetDefaultsToConsistentValues):
2700         * DumpRenderTree/mac/TestRunnerMac.mm:
2701         (TestRunner::setTextAutosizingEnabled): Added.
2702
2703 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
2704
2705         run-jsc-stress-tests should have a mode for always running the copy phase
2706         https://bugs.webkit.org/show_bug.cgi?id=121128
2707
2708         Reviewed by Geoffrey Garen.
2709
2710         This will increase test coverage of the copying phase, which might not always get 
2711         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
2712
2713         * Scripts/run-jsc-stress-tests:
2714
2715 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
2716
2717         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
2718         https://bugs.webkit.org/show_bug.cgi?id=121114
2719
2720         Reviewed by Christophe Dumez.
2721
2722         Use a tarball for libseccomp instead of git to avoid network issues on
2723         the buildbots while checking out the git repo. Using tarballs has the
2724         advantage of them being cached if the checksum matches, in which case
2725         there will be no need to download them again.
2726
2727         * efl/jhbuild.modules:
2728
2729 2013-09-10  Mark Lam  <mark.lam@apple.com>
2730
2731         Replace remaining "fast js" names in scripts.
2732         https://bugs.webkit.org/show_bug.cgi?id=120899.
2733
2734         Rubber stamped by Filip Pizlo.
2735
2736         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2737         (test_layout_failure_new_output):
2738         (test_layout_crash_new_output):
2739         (test_mozilla_and_layout_failure_new_output):
2740         * Scripts/run-fast-jsc: Removed.
2741         * Scripts/run-javascriptcore-tests:
2742         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
2743
2744 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
2745
2746         Enable JSC stress tests for the rest of non-Windows platforms
2747         https://bugs.webkit.org/show_bug.cgi?id=121021
2748
2749         Reviewed by Filip Pizlo.
2750
2751         The JSC stress tests can already be enabled on Linux-based ports.
2752
2753         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2754         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
2755         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
2756         complete output, with the number of failing or crashing tests properly extracted.
2757         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
2758         output in other unit tests testing the parsing of the output in the new format.
2759         (test_jsc_stress_failure_new_output):
2760         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
2761         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
2762         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
2763         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
2764         of available CPUs so the stress tests can be run in parallel.
2765
2766 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
2767
2768         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
2769         https://bugs.webkit.org/show_bug.cgi?id=120552
2770
2771         Unreviewed build fix.
2772
2773         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2774         (AccessibilityUIElement::classList):
2775
2776 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
2777
2778         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
2779         https://bugs.webkit.org/show_bug.cgi?id=120552
2780
2781         Reviewed by Darin Adler.
2782
2783         * DumpRenderTree/AccessibilityUIElement.cpp:
2784         (getClassListCallback):
2785         (AccessibilityUIElement::getJSClass):
2786         * DumpRenderTree/AccessibilityUIElement.h:
2787         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2788         (AccessibilityUIElement::classList):
2789         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2790         (AccessibilityUIElement::classList):
2791         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2792         (AccessibilityUIElement::classList):
2793         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2794         (AccessibilityUIElement::classList):
2795         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2796         (WTR::AccessibilityUIElement::classList):
2797         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2798         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2799         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2800         (WTR::AccessibilityUIElement::classList):
2801         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2802         (WTR::AccessibilityUIElement::classList):
2803
2804 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
2805
2806         [GTK] accessibility/loading-iframe-sends-notification.html is failing
2807         https://bugs.webkit.org/show_bug.cgi?id=98370
2808
2809         Reviewed by Chris Fleizach.
2810
2811         Added AXLayoutComplete for the GTK platform.
2812
2813         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2814         (axObjectEventListener): Added notification AXLayoutComplete for
2815         layout-complete signal.
2816
2817 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
2818
2819         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
2820         https://bugs.webkit.org/show_bug.cgi?id=120778
2821
2822         Reviewed by Anders Carlsson.
2823
2824         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2825         (createBitmapContextFromWebView): Use GDIObject.
2826         * Scripts/webkitpy/style/checkers/cpp.py:
2827         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
2828         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2829         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
2830         (LeakyPatternTest.test_create_compatible_dc): Ditto.
2831
2832 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2833
2834         Unreviewed. Add myself as a committer.
2835
2836         * Scripts/webkitpy/common/config/contributors.json:
2837
2838 2013-09-10  Mark Lam  <mark.lam@apple.com>
2839
2840         Move LayoutTests/fast/js to LayoutTests/js.
2841         https://bugs.webkit.org/show_bug.cgi?id=120899.
2842
2843         Rubber stamped by Filip Pizlo.
2844
2845         Changed scripts to reflect the path change.
2846
2847         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2848         (RunJavaScriptCoreTests.commandComplete):
2849         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2850         (test_fast_js_failure_new_output):
2851         (test_fast_js_crash_new_output):
2852         (test_mozilla_and_fast_js_failure_new_output):
2853         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2854         (BlackBerry::WebKit::DumpRenderTree::runTests):
2855         * Scripts/make-script-test-wrappers:
2856         (findTemplateFiles):
2857         * Scripts/run-fast-jsc:
2858         * Scripts/run-javascriptcore-tests:
2859         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2860         (TestExpectations):
2861
2862 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
2863
2864         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
2865         https://bugs.webkit.org/show_bug.cgi?id=70606
2866
2867         Reviewed by Mario Sanchez Prada.
2868
2869         Implemented the global notification listener for
2870         AccessibilityController. The signal is generated by
2871         AXObjectCache::postPlatformNotification() and received by
2872         axObjectEventListener(). axObjectEventListener will then invoke
2873         JSObjectCallAsFunction() with the respective callback function.
2874
2875         There is no additional test for this patch since its implementation will
2876         be tested by a11y layout tests that are currently skipped (e.g. bug
2877         98370).
2878
2879         * DumpRenderTree/AccessibilityController.h: Added a global notification
2880         handler for GTK+.
2881         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2882         (AccessibilityController::AccessibilityController): Initializes the
2883         global handler with 0.
2884         (AccessibilityController::addNotificationListener): Creates the
2885         notification handler and sets the notification function callback.
2886         (AccessibilityController::removeNotificationListener): Removes the
2887         global handler.
2888
2889 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
2890
2891         [ATK] Incorrect type for holding float value
2892         https://bugs.webkit.org/show_bug.cgi?id=121091
2893
2894         Reviewed by Mario Sanchez Prada.
2895
2896         Variable is not set properly, because of it's type.
2897
2898         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2899         (WTR::alterCurrentValue):
2900
2901 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2902
2903         [Qt] make use of qtHaveModule() 
2904         https://bugs.webkit.org/show_bug.cgi?id=121090
2905
2906         Reviewed by Jocelyn Turcotte.
2907         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
2908
2909         Use qtHaveModule instead of our own haveQtModule.
2910
2911         * QtTestBrowser/QtTestBrowser.pro:
2912         * qmake/mkspecs/features/configure.prf:
2913         * qmake/mkspecs/features/features.prf:
2914         * qmake/mkspecs/features/functions.prf:
2915
2916 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
2917
2918         Unreviewed. Add myself as a committer.
2919
2920         * Scripts/webkitpy/common/config/contributors.json:
2921
2922 2013-09-10  Radu Stavila  <stavila@adobe.com>
2923
2924         Unreviewed. Added myself as a committer.
2925
2926         * Scripts/webkitpy/common/config/contributors.json:
2927
2928 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2929
2930         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
2931         https://bugs.webkit.org/show_bug.cgi?id=105538
2932
2933         Reviewed by Chris Fleizach.
2934
2935         Unskip passing test getTextInParagraphAndBodyModerate.
2936
2937         * Scripts/run-gtk-tests:
2938         (TestRunner): Unskip pasing test.
2939
2940 2013-09-09  Mark Lam  <mark.lam@apple.com>
2941
2942         Remove more references to the deleted js-test-style.css.
2943         https://bugs.webkit.org/show_bug.cgi?id=120899.
2944
2945         Reviewed by Ryosuke Niwa.
2946
2947         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2948         (translate_includes):
2949
2950 2013-09-09  Mark Lam  <mark.lam@apple.com>
2951
2952         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
2953         https://bugs.webkit.org/show_bug.cgi?id=120899.
2954
2955         Not reviewed.
2956
2957         The webkitpy test failure that resulted in the rollout is due to
2958         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
2959         which is to be deleted. Deleting that line fixes the issue.
2960
2961         * Scripts/make-new-script-test:
2962         (makePathToSharedSources):
2963         * Scripts/run-fast-jsc:
2964         * Scripts/webkitperl/httpd.pm:
2965         (getDefaultConfigForTestDirectory):
2966         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2967         (LayoutTestApacheHttpd.__init__):
2968         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2969         (Lighttpd.__init__):
2970         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2971         (BaseTest.integration_test_port_and_root):
2972         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2973         (TestHttpServer.test_start_cmd):
2974         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2975         (translate_includes):
2976         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2977         (TestTranslation.test_include_rewriting):
2978
2979 2013-09-09  Mark Lam  <mark.lam@apple.com>
2980
2981         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
2982         https://bugs.webkit.org/show_bug.cgi?id=120899.
2983
2984         Not reviewed.
2985
2986         * Scripts/make-new-script-test:
2987         (makePathToSharedSources):
2988         * Scripts/run-fast-jsc:
2989         * Scripts/webkitperl/httpd.pm:
2990         (getDefaultConfigForTestDirectory):
2991         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2992         (LayoutTestApacheHttpd.__init__):
2993         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2994         (Lighttpd.__init__):
2995         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2996         (BaseTest.integration_test_port_and_root):
2997         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2998         (TestHttpServer.test_start_cmd):
2999         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3000         (translate_includes):
3001         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3002         (TestTranslation.test_include_rewriting):
3003
3004 2013-09-09  Mark Lam  <mark.lam@apple.com>
3005
3006         Point Tools scripts to LayoutTests/resources.
3007         https://bugs.webkit.org/show_bug.cgi?id=120899.
3008
3009         Reviewed by Ryosuke Niwa.
3010
3011         * Scripts/make-new-script-test:
3012         (makePathToSharedSources):
3013         * Scripts/run-fast-jsc:
3014         * Scripts/webkitperl/httpd.pm:
3015         (getDefaultConfigForTestDirectory):
3016         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3017         (LayoutTestApacheHttpd.__init__):
3018         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3019         (Lighttpd.__init__):
3020         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3021         (BaseTest.integration_test_port_and_root):
3022         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3023         (TestHttpServer.test_start_cmd):
3024         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3025         (translate_includes):
3026         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3027         (TestTranslation.test_include_rewriting):
3028
3029 2013-09-09  Roger Fong  <roger_fong@apple.com>
3030
3031         Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
3032
3033         * CygwinDownloader/cygwin-downloader.py:
3034         * CygwinDownloader/cygwin-downloader.zip:
3035
3036 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
3037
3038         Unreviewed, fix Ruby exception handling.
3039
3040         * Scripts/run-jsc-stress-tests:
3041
3042 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
3043
3044         Stress tests should test the jsc profiler (-p)
3045         https://bugs.webkit.org/show_bug.cgi?id=121043
3046
3047         Reviewed by Mark Hahnenberg.
3048         
3049         Add a runProfiler command that all tests could use. This requires profiler-test-helper,
3050         which first runs the JS test and then tries the output with display-profiler-output.
3051         But if any of the things required for this to work aren't present, we just do a simpler
3052         test that just uses "-p".
3053         
3054         Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
3055         to create test collections using a yaml file that specifies the test path and the
3056         command to run.
3057
3058         * Scripts/jsc-stress-test-helpers: Added.
3059         * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
3060         * Scripts/run-javascriptcore-tests:
3061         * Scripts/run-jsc-stress-tests:
3062
3063 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
3064
3065         [webkitpy] Remove the DeprecatedPort class
3066         https://bugs.webkit.org/show_bug.cgi?id=121030
3067
3068         Reviewed by Ryosuke Niwa.
3069
3070         Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
3071
3072         The various methods returning commands are moved from the DeprecatedPort class into the Port class,
3073         with the Port subclasses overriding specific methods as required.
3074
3075         * Scripts/webkitpy/common/config/ports.py: Removed.
3076         * Scripts/webkitpy/common/config/ports_mock.py: Removed.
3077         * Scripts/webkitpy/common/config/ports_unittest.py: Removed.
3078         * Scripts/webkitpy/port/base.py:
3079         (Port.tooling_flag): This method returns the command line argument that corresponds to the type of the port.
3080         It's formatted as '--port=port_name', where port_name is the port's name that's additionally appended the '-wk2'
3081         string if the port instance represents the WK2 variation of the port.
3082         (Port.script_shell_command): Moved here from the DeprecatedPort interface.
3083         (Port.make_args): Ditto.
3084         (Port.update_webkit_command): Ditto.
3085         (Port.check_webkit_style_command): Ditto.
3086         (Port.prepare_changelog_command): Ditto.
3087         (Port.build_webkit_command): Ditto.
3088         (Port.run_javascriptcore_tests_command): Ditto.
3089         (Port.run_webkit_unit_tests_command): Ditto.
3090         (Port.run_webkit_tests_command): Ditto.
3091         (Port.run_python_unittests_command): Ditto.
3092         (Port.run_perl_unittests_command): Ditto.
3093         (Port.run_bindings_tests_command): Ditto.
3094         * Scripts/webkitpy/port/base_unittest.py:
3095         (PortTest.test_build_webkit_command): Add a test for the Port.build_webkit_command() method that tests correct
3096         return value with different build types passed to the method.
3097         * Scripts/webkitpy/port/efl.py:
3098         (EflPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
3099         to the command line.
3100         * Scripts/webkitpy/port/efl_unittest.py:
3101         (EflPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
3102         variations of the EflPort class.
3103         * Scripts/webkitpy/port/gtk.py:
3104         (GtkPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
3105         to the command line.
3106         (GtkPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
3107         * Scripts/webkitpy/port/gtk_unittest.py:
3108         (GtkPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1
3109         and WK2 variations of the GtkPort class.
3110         * Scripts/webkitpy/port/mac_unittest.py:
3111         (MacTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
3112         variations of the MacPort class.
3113         * Scripts/webkitpy/port/qt.py:
3114         (QtPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
3115         to the command line.
3116         (QtPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
3117         * Scripts/webkitpy/port/qt_unittest.py:
3118         (QtPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
3119         variations of the QtPort class.
3120         * Scripts/webkitpy/port/test.py:
3121         (TestPort.make_args): Return a mock value that's intended for testing.
3122         (TestPort.check_webkit_style_command): Return the script's name prepended with 'mock-'.
3123         (TestPort.update_webkit_command): Ditto.
3124         (TestPort.build_webkit_command): Ditto.
3125         (TestPort.prepare_changelog_command): Ditto.
3126         (TestPort.run_python_unittests_command): Ditto.
3127         (TestPort.run_perl_unittests_command): Ditto.
3128         (TestPort.run_javascriptcore_tests_command): Ditto.
3129         (TestPort.run_webkit_unit_tests_command): Ditto.
3130         (TestPort.run_webkit_tests_command): Ditto.
3131         (TestPort.run_bindings_tests_command): Ditto.
3132         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3133         (FlakyTestReporter.__init__): WebKitPatch.port() should be called now.
3134         * Scripts/webkitpy/tool/bot/irc_command.py:
3135         (Rollout._update_working_copy): Ditto.
3136         * Scripts/webkitpy/tool/commands/download_unittest.py:
3137         (DownloadCommandsTest.test_land_cowhand): Fix a typo, javacriptcore -> javascriptcore.
3138         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3139         (AbstractEarlyWarningSystem.run_command): Use the tooling flag as provided by the Port interface.
3140         * Scripts/webkitpy/tool/commands/queues.py:
3141         (PatchProcessingQueue.begin_work_queue): Remove the use of the DeprecatedPort. Create the port that will be used
3142         by the PatchProcessingQueue through the tool's port factory, and also pass it to the tool, keeping the nasty
3143         abstraction violation.
3144         (CommitQueue.run_command): Use the tooling flag as provided by the Port interface.
3145         * Scripts/webkitpy/tool/main.py:
3146         (WebKitPatch.__init__): self._deprecated_port -> self._port.
3147         (WebKitPatch.port): Replaces the WebKitPatch.deprecated_port() method, returns self._port.
3148         (WebKitPatch.handle_global_options): Create the Port object through the PortFactory.
3149         * Scripts/webkitpy/tool/mocktool.py:
3150         (MockTool.__init__): self._deprecated_port -> self._port. The TestPort object also has its name method overridden
3151         to return 'MockPort', as many output comparisons rely on the MockPort name. These should all be replaced later, in
3152         a separate patch.
3153         (MockTool.port): Mimicks WebKitPatch.port().
3154         * Scripts/webkitpy/tool/steps/build.py:
3155         (Build.build): WebKitPatch.port() should be called now.
3156         * Scripts/webkitpy/tool/steps/checkstyle.py:
3157         (CheckStyle.run): Ditto.
3158         * Scripts/webkitpy/tool/steps/commit.py:
3159         (Commit._check_test_expectations): Ditto.
3160         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3161         (PrepareChangeLog.run): Ditto.
3162         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3163         (PrepareChangeLogForRevert.run): Ditto.
3164         * Scripts/webkitpy/tool/steps/runtests.py:
3165         (RunTests.run): Ditto.
3166         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3167         (RunTestsTest.test_webkit_run_unit_tests): The unnecessary methods should now be overridden on MockTool._port.
3168         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3169         (StepsTest.test_runtests_args): Remove the MockTool._deprecated_port override, but don't replace it. Rather than
3170         that the expected test output is adjusted to contain the mock-* command names.
3171         * Scripts/webkitpy/tool/steps/update.py:
3172         (Update._update_command): WebKitPatch.port() should be called now.
3173         * Scripts/webkitpy/tool/steps/update_unittest.py:
3174         (UpdateTest.test_update_command_non_interactive): Override the MockTool._port for testing purposes with the port
3175         that corresponds to the removed DeprecatedPort subclasses.
3176         (UpdateTest.test_update_command_interactive): Ditto.
3177
3178 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
3179
3180         [GTK] 32-bit builder should run the JSC tests
3181         https://bugs.webkit.org/show_bug.cgi?id=119215
3182
3183         Reviewed by Philippe Normand.
3184
3185         Rename the TestClass member of the TestFactory and BuildAndTestFactory classes
3186         to a more descriptive name, 'LayoutTestClass'. In these two factory classes, the layout testing-specific
3187         steps are only added if the LayoutTestClass member was not overridden to the value of None in a
3188         derived class.
3189
3190         Remove the BuildAndAPITestFactory class and replace it with the BuildAndNonLayoutTestFactory class that
3191         is derived from the BuildAndTestFactory class and overrides the LayoutTestClass member to the value of None.
3192         This allows for builders of the BuildAndNonLayoutTest type to run all but the layout tests. This type
3193         is currently used by the GTK 32-bit builder - there's at the moment no interest to have the builder cover
3194         layout testing while other types of testing are still expected to be performed.
3195
3196         * BuildSlaveSupport/build.webkit.org-config/config.json:
3197         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3198         (BuildFactory.__init__):
3199         (TestFactory):
3200         (TestFactory.__init__):
3201         (BuildAndTestFactory):
3202         (BuildAndTestFactory.__init__):
3203         (BuildAndTestWebKit2Factory):
3204         (BuildAndTestWebKit2OnlyFactory):
3205         (BuildAndNonLayoutTestFactory):
3206         (TestLeaksFactory):
3207         (TestWebKit2Factory):
3208
3209 2013-09-09  Manuel Rego Casasnovas  <rego@igalia.com>
3210
3211         Unreviewed. Add myself as a committer.
3212
3213         * Scripts/webkitpy/common/config/contributors.json:
3214
3215 2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
3216
3217         [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
3218         https://bugs.webkit.org/show_bug.cgi?id=121023
3219
3220         Reviewed by Mario Sanchez Prada.
3221
3222         Added mappings to ATK's ProgressBar element.
3223
3224         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3225         (roleToString):
3226         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3227         (WTR::roleToString):
3228
3229 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
3230
3231         run-jsc-stress-tests should be more paranoid about calling make
3232         https://bugs.webkit.org/show_bug.cgi?id=121011
3233
3234         Reviewed by Oliver Hunt.
3235         
3236         If it returns with any kind of error then bail out.  Also print the command being used
3237         in case we have to debug this, for example on the bots.  The extra verbosity isn't a
3238         big deal.
3239
3240         * Scripts/run-jsc-stress-tests:
3241
3242 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
3243
3244         Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
3245         like that. Pass a string instead.
3246
3247         * Scripts/run-jsc-stress-tests:
3248
3249 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
3250
3251         run-jsc-stress-tests should run tests in parallel if possible
3252         https://bugs.webkit.org/show_bug.cgi?id=120996
3253
3254         Reviewed by Oliver Hunt.
3255         
3256         Run tests in parallel by using Makefile hacks. This lets make take care of all load
3257         balancing. It's a really awesome speed-up for these tests.
3258         
3259         This reduces the FTL debug build stress test run time from 8m18s to 2m11s. The 
3260         no-FTL debug build stress test time goes from 1m11s to 16s. This patch is pretty
3261         much awesome.
3262
3263         * Scripts/run-jsc-stress-tests:
3264
3265 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
3266
3267         run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
3268         https://bugs.webkit.org/show_bug.cgi?id=120994
3269
3270         Reviewed by Geoffrey Garen.
3271         
3272         run-jsc-stress-tests accepts a list of directories containing tests.  It needs to
3273         come up with names for all of them.  Currently it uses the basename of the test
3274         directory.  But that means that JSRegress gets called "script-tests", which is
3275         unfortunate since any directory in LayoutTests containing .js files will be
3276         called "script-tests".  So, this changes run-jsc-stress-tests to use more than
3277         just the basename if the basename has the word "tests" in it.  This causes
3278         JSRegress to be called "regress/script-tests".
3279
3280         * Scripts/run-jsc-stress-tests:
3281
3282 2013-09-08  Sergio Correia  <sergio.correia@openbossa.org>
3283
3284         [EFL][JHBUILD] Fix evas build with giflib5
3285         https://bugs.webkit.org/show_bug.cgi?id=120863
3286
3287         Original patch from Doug Newgard, at https://phab.enlightenment.org/D200.
3288
3289         Reviewed by Anders Carlsson.
3290
3291         * efl/jhbuild.modules: Apply patch to fix evas build with giflib5.
3292         * efl/patches/evas-fix-build-with-giflib5.patch: Added.
3293
3294 2013-09-07  Filip Pizlo  <fpizlo@apple.com>
3295
3296         Only run FTL tests if we have the FTL
3297         https://bugs.webkit.org/show_bug.cgi?id=120974
3298
3299         Reviewed by Geoffrey Garen.
3300         
3301         Pass --ftl-jit down into run-jsc-stress-tests so that it knows what test
3302         variants to run.
3303
3304         * Scripts/build-jsc:
3305         * Scripts/run-javascriptcore-tests:
3306         * Scripts/run-jsc-stress-tests:
3307
3308 2013-09-07  Santosh Mahto  <santosh.ma@samsung.com>
3309
3310         removing --dialog-element from build-webkit --help option message
3311         https://bugs.webkit.org/show_bug.cgi?id=120955
3312
3313         Reviewed by Daniel Bates.
3314
3315         --dialog-element option is useless while building as
3316         Dialog Element support has been removed in following changeset.
3317         http://trac.webkit.org/changeset/154835
3318         http://trac.webkit.org/changeset/154870
3319
3320         * Scripts/webkitperl/FeatureList.pm:
3321         Removed --dialog-element option message.
3322
3323 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
3324
3325         It should be possible to run-javascriptcore-tests with only a subset of the test suites
3326         https://bugs.webkit.org/show_bug.cgi?id=120918
3327
3328         Reviewed by Dan Bernstein.
3329
3330         * Scripts/run-javascriptcore-tests:
3331
3332 2013-09-06  Commit Queue  <commit-queue@webkit.org>
3333
3334         Unreviewed, rolling out r155196.
3335         http://trac.webkit.org/changeset/155196
3336         https://bugs.webkit.org/show_bug.cgi?id=120919
3337
3338         Broke 16 tests on build.webkit.org (Requested by rniwa on
3339         #webkit).
3340
3341         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3342         (Manager._set_up_run):
3343
3344 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
3345
3346         The 'failed' file should report collectionName/testName rather than just
3347         testName.
3348
3349         Rubber stamped by Mark Hahnenberg.
3350
3351         * Scripts/run-jsc-stress-tests:
3352
3353 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
3354
3355         Fix run-jsc-stress-tests to run on bots with old Ruby.
3356         
3357         Also make it create a repro file.
3358
3359         Rubber stamped by Mark Hahnenberg.
3360
3361         * Scripts/run-jsc-stress-tests:
3362
3363 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
3364
3365         Actually increment $numFailures
3366
3367         Reviewed by Mark Hahnenberg.
3368
3369         * Scripts/run-jsc-stress-tests:
3370
3371 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
3372
3373         Fix run-jsc-stress-tests to use Pathname instead of File.realpath.
3374         
3375         Also make it uses system() instead of popen(); that means that test output
3376         will go to the console. This reduces error detection flakiness. It's fine
3377         because stress tests don't print() unless they really have to.
3378
3379         Rubber stamped by Mark Hahnenberg.
3380
3381         * Scripts/run-jsc-stress-tests:
3382
3383 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3384
3385         Introduce a way to run benchmarks and JSRegress as stress tests with different jsc command-line options
3386         https://bugs.webkit.org/show_bug.cgi?id=120808
3387
3388         Reviewed by Mark Hahnenberg and rubber stamped by Geoffrey Garen.
3389         
3390         Add a script for running stress tests.  A stress test is a .js file that is run
3391         through different configurations of JSC.  It can control which configurations it
3392         runs by using "//@ <ruby code>" to guide the script.
3393         
3394         This script is now run as part of run-javascriptcore-tests, on Mac only.
3395
3396         * Scripts/run-javascriptcore-tests:
3397         * Scripts/run-jsc-stress-tests: Added.
3398
3399 2013-09-06  Mario Sanchez Prada  <mario.prada@samsung.com>
3400
3401         [GTK] Desktop proxy settings are ignored inside the internal jhbuild
3402         https://bugs.webkit.org/show_bug.cgi?id=120833
3403
3404         Reviewed by Gustavo Noronha Silva.
3405
3406         Add dconf as an optional module for the internal jhbuild, along
3407         with vala 0.17 as a dependency, and make sure we do not explicitly
3408         set always the 'memory' backend, so we can have an easy way to
3409         allow apps access desktop settings from the jhbuild. This is
3410         useful for example to be able to run apps such as MiniBrowser
3411         inside the jhbuild (by means of run-launcher, for instance) while
3412         working behind a proxy, since those network settings have to be
3413         read from the system global configuration in org.gnome.system.proxy.
3414
3415         * gtk/jhbuild-optional.modules: Added dconf 0.14 and vala 0.17.
3416         * gtk/jhbuildrc: Do not explicitly choose the GSettings memory
3417         backend here, since that will make more difficult to use the dconf
3418         backend from inside the jhbuild if we need to do it so.
3419
3420 2013-09-06  Alexey Proskuryakov  <ap@apple.com>
3421
3422         Lots of pixel tests are failing on first run, so tests cannot finish
3423         https://bugs.webkit.org/show_bug.cgi?id=120755
3424
3425         Reviewed by Ryosuke Niwa.
3426
3427         For whatever reason, many reftests are color profile sensitive, and we only set
3428         color profile to a known one for pixel tests, not for reftests.
3429
3430         Pixel testing mode is also enabled  when retrying tests, so these failures used to
3431         be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
3432         But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
3433
3434         This probably shouldn't happen, as reftests should not be color profile sensitive.
3435         The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
3436
3437         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3438         (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
3439
3440 2013-09-06  Denis Nomiyama  <d.nomiyama@samsung.com>
3441
3442         [GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
3443         https://bugs.webkit.org/show_bug.cgi?id=120416
3444
3445         Reviewed by Mario Sanchez Prada.
3446
3447         Fixed crashes when running debug DRT. Simplified loops at AccessibilityCallbackAtk.cpp where the HashMap
3448         iterator was removed inside a loop. Fixed AccessibilityUIElement::addNotificationListener() where
3449         m_notificationHandler expected RefPtr.
3450
3451         The global notification handler was stored in the HashMap with key 0. And this caused an assertion when
3452         HashMap::add() or find() are called. To fix it, moved the global handler to a separated pointer.
3453
3454         * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed the global notification key.
3455         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3456         (axObjectEventListener): Simplified the code by using HashMap::find() and a separate pointer for the
3457         global notification handler.
3458         (addAccessibilityNotificationHandler): Simplified the code by using HashMap::find() and a separate pointer
3459         for the global notification handler.
3460         (removeAccessibilityNotificationHandler): Added the removal for the global notification handler.
3461         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
3462         (AccessibilityNotificationHandler::create): Added static function to create
3463         AccessibilityNotificationHandler.
3464         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3465         (AccessibilityUIElement::addNotificationListener): Assigned m_notificationHandler with
3466         AccessibilityNotificationHandler::create().
3467
3468 2013-09-06  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3469
3470         [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
3471         https://bugs.webkit.org/show_bug.cgi?id=120847
3472
3473         Reviewed by Csaba Osztrogonác.
3474
3475         Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
3476         Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
3477         Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).
3478
3479         * WebKitTestRunner/PlatformWebView.h:
3480         (WTR::PlatformWebView::windowSnapshotEnabled):
3481         * WebKitTestRunner/TestInvocation.cpp:
3482         (WTR::TestInvocation::dumpResults):
3483         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3484         (WTR::WrapperWindow::handleStatusChanged):
3485         (WTR::PlatformWebView::windowSnapshotEnabled):
3486         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3487         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3488
3489 2013-09-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3490
3491         REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
3492         https://bugs.webkit.org/show_bug.cgi?id=120843
3493
3494         Reviewed by Csaba Osztrogonác.
3495
3496         Call notifyDone like the platform specific forceRepaintDoneCallback methods
3497         it replaced did. The method is empty on the Apple ports.
3498
3499         * WebKitTestRunner/TestInvocation.cpp:
3500         (WTR::TestInvocation::forceRepaintDoneCallback):
3501
3502 2013-09-06  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3503
3504         [Qt][WK2] Window used by WebKitTestRunner loses active status
3505         https://bugs.webkit.org/show_bug.cgi?id=120774
3506
3507         Reviewed by Jocelyn Turcotte.
3508
3509         When focusing the PlatformWebView which is done at the start of each test, we should
3510         ensure the host window of PlatformWebView is also made active, otherwise we will
3511         not receive the keyboard events send by EventSenderProxy.
3512
3513         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3514         (WTR::PlatformWebView::focus):
3515
3516 2013-09-05  Seokju Kwon  <seokju@webkit.org>
3517
3518         Unreviewed build fix. VectorReverse.cpp was removed after r155151.
3519
3520         * TestWebKitAPI/CMakeLists.txt:
3521
3522 2013-09-05  Anders Carlsson  <andersca@apple.com>
3523
3524         Make Vector::uncheckedAppend work with move-only types
3525         https://bugs.webkit.org/show_bug.cgi?id=120799
3526
3527         Reviewed by Andreas Kling.
3528
3529         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3530         (TestWebKitAPI::MoveOnly):
3531         Add a move-only class.
3532
3533         (TestWebKitAPI::TEST):
3534         Add a test for Vector<MoveOnly>::uncheckedAppend.
3535
3536 2013-09-05  Anders Carlsson  <andersca@apple.com>
3537
3538         Move all Vector tests into Vector.cpp
3539         https://bugs.webkit.org/show_bug.cgi?id=120797
3540
3541         Reviewed by Andreas Kling.
3542
3543         * TestWebKitAPI/CMakeLists.txt:
3544         * TestWebKitAPI/GNUmakefile.am:
3545         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3546         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3547         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3548         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3549         (TestWebKitAPI::TEST):
3550         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
3551         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
3552         * TestWebKitAPI/Tests/WTF/WTF.pro:
3553
3554 2013-09-05  Simon Fraser  <simon.fraser@apple.com>
3555
3556         Expected result images are sometimes blank in WKTR
3557         https://bugs.webkit.org/show_bug.cgi?id=120715
3558
3559         Reviewed by Tim Horton.
3560         
3561         In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
3562         sometimes blank if a previous test triggered compositing mode, and the
3563         current test or reference did not require compositing. This happened
3564         because the UI process didn't wait for the web process to complete
3565         its compositing mode switch before snapshotting. Fix by calling
3566         WKPageForceRepaint() before we take the snapshot; this is async,
3567         so we have to spin the runloop for a while.
3568         
3569         Remove the Qt/EFL code that does the same thing.
3570
3571         * WebKitTestRunner/TestInvocation.cpp:
3572         (WTR::TestInvocation::forceRepaintDoneCallback):
3573         (WTR::TestInvocation::dumpResults):
3574         * WebKitTestRunner/TestInvocation.h:
3575         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3576         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3577         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3578         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3579
3580 2013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
3581
3582         Make build.webkit.org report the number of failing run-fast-jsc tests
3583         https://bugs.webkit.org/show_bug.cgi?id=120766
3584
3585         Reviewed by Filip Pizlo.
3586
3587         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3588         (RunJavaScriptCoreTests.commandComplete):
3589         (RunJavaScriptCoreTests.getText2):
3590         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3591         (RunJavaScriptCoreTestsTest): Added.
3592         (RunJavaScriptCoreTestsTest.assertResults):
3593         (RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
3594         (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3595         (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
3596         (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
3597         (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
3598         (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
3599
3600 2013-09-05  Csaba Osztrogonác  <ossy@webkit.org>
3601
3602         Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
3603         https://bugs.webkit.org/show_bug.cgi?id=120759
3604
3605         Reviewed by Filip Pizlo.
3606
3607         * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
3608         * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
3609
3610 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3611
3612         Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
3613         Mozilla tests appears to run for a longer time.
3614         
3615         I think we want to continue to allow a few tests here and there to be
3616         longer-running, rather than excluding them. I seem to recall that those tests
3617         catch good bugs.
3618
3619         * Scripts/run-javascriptcore-tests:
3620
3621 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3622
3623         Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that
3624         can't support it because if non-bourne shells. This fixes part #2 of the Linux
3625         bot breakage.
3626
3627         * Scripts/run-javascriptcore-tests:
3628
3629 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
3630
3631         Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
3632
3633         * Scripts/run-javascriptcore-tests:
3634         (readAllLines):
3635
3636 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
3637
3638         jsc tests should have timeouts
3639         https://bugs.webkit.org/show_bug.cgi?id=120725
3640
3641         Reviewed by Geoffrey Garen.
3642         
3643         Set the timeout to 20 seconds per test for now.
3644
3645         * Scripts/run-javascriptcore-tests:
3646
3647 2013-09-04  Filip Pizlo  <fpizlo@apple.com>
3648
3649         run-javascriptcore-tests should run-fast-jsc as well
3650         https://bugs.webkit.org/show_bug.cgi?id=120722
3651
3652         Reviewed by Geoffrey Garen.
3653         
3654         Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
3655         Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
3656
3657         * Scripts/run-javascriptcore-tests:
3658         (printThingsFound):
3659
3660 2013-09-04  Sergio Correia  <sergio.correia@openbossa.org>
3661
3662         [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
3663         https://bugs.webkit.org/show_bug.cgi?id=120646
3664
3665         Reviewed by Gyuyoung Kim.
3666
3667         * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
3668         list of passing tests, since it started to pass after r154045.
3669
3670 2013-09-04  Krzysztof Czech  <k.czech@samsung.com>
3671
3672         [ATK] Adds an accessibility support to access a value of the color control element
3673         https://bugs.webkit.org/show_bug.cgi?id=114354
3674
3675         Reviewed by Mario Sanchez Prada.
3676
3677         Added accessibility role of the color control element.
3678
3679         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3680         (roleToString):
3681         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3682         (WTR::roleToString):
3683
3684 2013-09-04  Mario Sanchez Prada  <mario.prada@samsung.com>
3685
3686         REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
3687         https://bugs.webkit.org/show_bug.cgi?id=100408
3688
3689         Unreviewed gardening. Unskip TestWebKitAccessibility after
3690         manually checking that it's running properly in the bot.
3691
3692         * Scripts/run-gtk-tests:
3693         (TestRunner): Unskipped TestWebKitAccessibility.
3694
3695 2013-09-04  Zan Dobersek  <zdobersek@igalia.com>
3696
3697         [GTK] Add support for the Wayland build target
3698         https://bugs.webkit.org/show_bug.cgi?id=120627
3699
3700         Reviewed by Gustavo Noronha Silva.
3701
3702         * GNUmakefile.am: Define the additional macros also if building the Wayland target.
3703
3704 2013-09-04  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
3705
3706         [GStreamer] cannot play live streams
3707         https://bugs.webkit.org/show_bug.cgi?id=116831
3708
3709         Reviewed by Philippe Normand.
3710
3711         Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
3712
3713         * gtk/jhbuild.modules:
3714         * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
3715         * gtk/patches/udpsrc-improve-timeouts.patch: Added.
3716         Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
3717         and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
3718         Both patches are applied upstream and can be removed once a new gstreamer release
3719         is out (up to 1.0.10 the patches are not included) and we bump the requirements.
3720
3721 2013-09-03  Alexey Proskuryakov  <ap@apple.com>
3722
3723         [Mac] WebKitTestRunner still beeps sometimes
3724         https://bugs.webkit.org/show_bug.cgi?id=120652
3725
3726         Reviewed by Tim Horton.
3727
3728         In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
3729         UI process (notably, AppKit beeps when handling a key equivalent returns NO).
3730
3731         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
3732         Use the same SPI that we use in DRT and in WebProcess to disable beeping.
3733
3734 2013-09-03  Krzysztof Czech  <k.czech@samsung.com>
3735
3736         [AX][ATK] Added support for sort and help attributes
3737         https://bugs.webkit.org/show_bug.cgi?id=120456
3738
3739         Reviewed by Chris Fleizach.
3740
3741         Added missing implementation to AccessibilityUIElement::helpText and support for
3742         aria-sort attribute.
3743
3744         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3745         (coreAttributeToAtkAttribute):
3746         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3747         (WTR::coreAttributeToAtkAttribute):
3748         (WTR::AccessibilityUIElement::helpText):
3749
3750 2013-09-03  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3751
3752         [Qt][WK1] PageVisibility tests are flaky
3753         https://bugs.webkit.org/show_bug.cgi?id=120418
3754
3755         Reviewed by Jocelyn Turcotte.
3756
3757         Implement resetPageVisibility so we can reset visibility without
3758         emiting visibility state change events.
3759
3760         * DumpRenderTree/qt/TestRunnerQt.cpp:
3761         (TestRunner::resetPageVisibility):
3762
3763 2013-09-03  ChangSeok Oh  <changseok.oh@collabora.com>
3764
3765         [GTK] libsoup upversion to fix a gstreamer issue, bug115354
3766         https://bugs.webkit.org/show_bug.cgi?id=120613
3767
3768         Reviewed by Philippe Normand.
3769
3770         Up version of libsoup to 2.43.90. But the exact version which we'll use is not 2.43.90.
3771         To fix bug115354, we need the Andre's patch for libsoup, but the lastest release
3772         does not contain it. https://bugzilla.gnome.org/show_bug.cgi?id=706338
3773         For the reason, we'll use libsoup git repo directly for a while until the next
3774         libsoup release.
3775
3776         * gtk/jhbuild.modules:
3777
3778 2013-09-02  Darin Adler  <darin@apple.com>
3779
3780         [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
3781         https://bugs.webkit.org/show_bug.cgi?id=120569
3782
3783         Reviewed by Andy Estes.
3784
3785         * DumpRenderTree/mac/DumpRenderTree.mm:
3786         (dump): Use CFBridgingRelease.
3787
3788 2013-09-02  Anton Obzhirov  <a.obzhirov@samsung.com>
3789
3790         <https://webkit.org/b/98350> [GTK] accessibility/aria-invalid.html times out
3791
3792         Reviewed by Mario Sanchez Prada.
3793
3794         Added few mappings in DumpRenderTree and WebKitTestRunner for aria-invalid in order to get the tests run properly.
3795
3796         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3797         (axObjectEventListener):
3798         Added mapping for invalid-entry event parameter.
3799         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3800         (coreAttributeToAtkAttribute):
3801         Added mapping to aria-invalid.
3802         (AccessibilityUIElement::stringAttributeValue):
3803         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3804         (WTR::coreAttributeToAtkAttribute):
3805         Added mapping to aria-invalid.
3806
3807 2013-09-02  Nick Diego Yamane  <nick.yamane@openbossa.org>
3808
3809         Save md5 correctly when jhbuildPath doesn't exist yet
3810         https://bugs.webkit.org/show_bug.cgi?id=120548
3811
3812         Reviewed by Gustavo Noronha Silva.
3813
3814         After r152605, Md5 for jhbuild files are saved before the update
3815         process, this prevents the script to restart update from scratch
3816         when initial checkouts fail. However it causes an issue when builddir
3817         (or builddir/Dependencies) doesn't exist yet. In that case the
3818         saveJhbuildMd5 function fails to create md5 files.
3819         This patch adds a checking for the jhbuildPath and creates it if
3820         necessary before trying to open the md5 files.
3821
3822         * Scripts/update-webkit-libs-jhbuild:
3823         (saveJhbuildMd5):
3824
3825 2013-09-02  Mario Sanchez Prada  <mario.prada@samsung.com>
3826
3827         Unreviewed. Move myself to the reviewers list.
3828
3829         * Scripts/webkitpy/common/config/contributors.json:
3830
3831 2013-09-01  Alexey Proskuryakov  <ap@apple.com>
3832
3833         [WK2][Mac] Drag and drop tests interfere with user's UI
3834         https://bugs.webkit.org/show_bug.cgi?id=120538
3835
3836         Reviewed by Dan Bernstein.
3837
3838         This makes running WebKit2 regression tests locally more viable. The patch doesn't
3839         fix drag and drop tests to work as expected, I posted some thought about that in
3840         <https://bugs.webkit.org/show_bug.cgi?id=68552>.
3841
3842         * WebKitTestRunner/EventSenderProxy.h:
3843         (WTR::EventSenderProxy::position):
3844         * WebKitTestRunner/TestController.h:
3845         (WTR::TestController::eventSenderProxy):
3846         Expose a way to get current mouse position from anywhere in WKTR code.
3847
3848         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
3849
3850         * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
3851         Copied a FIXME comment from DumpRenderTree.
3852
3853         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3854         (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
3855         Override drag initiation, using a custom NSDraggingInfo implementation.
3856
3857         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
3858         Replace NSEvent with a custom class.
3859
3860         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
3861         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
3862         * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
3863         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
3864         Largely a copy of DumpRenderTree classes, modified to not use global variables.
3865         We should consider making these variables static in EventSenderProxy though, as
3866         it's strange that mouse state in WKTR is reset between tests without WebKit ever
3867         being told about that.
3868
3869 2013-08-30  Brent Fulgham  <bfulgham@apple.com>
3870
3871         [Windows] Unreviewed build fix.
3872
3873         * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
3874         from the build machines.
3875
3876 2013-08-30  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3877
3878         [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
3879         https://bugs.webkit.org/show_bug.cgi?id=120464
3880
3881         Reviewed by Jocelyn Turcotte.
3882
3883         * Scripts/webkitpy/port/qt.py:
3884         (QtPort._search_paths):
3885         * Scripts/webkitpy/port/qt_unittest.py:
3886         (QtPortTest):
3887
3888 2013-08-29  Filip Pizlo  <fpizlo@apple.com>
3889
3890         Just linking LLVM into JSC causes all plugin tests to fail
3891         https://bugs.webkit.org/show_bug.cgi?id=113915
3892
3893         Reviewed by Oliver Hunt.
3894         
3895         Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
3896         raise/abort/__assert_rtn.
3897
3898         * Scripts/configure-llvm:
3899
3900 2013-08-29  Joseph Pecoraro  <pecoraro@apple.com>
3901
3902         new-run-webkit-tests does not respect --no-sample-on-timeout switch
3903         https://bugs.webkit.org/show_bug.cgi?id=120491
3904
3905         Reviewed by Darin Adler.
3906
3907         * Scripts/webkitpy/port/server_process.py:
3908         (ServerProcess._handle_timeout):
3909
3910 2013-08-29  Sam Weinig  <sam@webkit.org>
3911
3912         Add ENABLE guards for Promises
3913         https://bugs.webkit.org/show_bug.cgi?id=120488
3914
3915         Reviewed by Andreas Kling.
3916
3917         * Scripts/webkitperl/FeatureList.pm:
3918         * qmake/mkspecs/features/features.pri:
3919
3920 2013-08-29  Andre Moreira Magalhaes   <andre.magalhaes@collabora.co.uk>
3921
3922         [GTK] Should enable WebGL by default on MiniBrowser
3923         https://bugs.webkit.org/show_bug.cgi?id=120420
3924
3925         Reviewed by Gustavo Noronha Silva.
3926
3927         Enable WebGL by default on MiniBrowser.
3928
3929         * MiniBrowser/gtk/main.c:
3930         (main):
3931
3932 2013-08-28  Simon Fraser  <simon.fraser@apple.com>
3933
3934         Add a Command-R shortcut in MiniBrowser
3935         https://bugs.webkit.org/show_bug.cgi?id=120442
3936
3937         Reviewed by Dean Jackson.
3938         
3939         Add a "Reload Page" item to the View menu with a Command-R
3940         shortcut.
3941
3942         * MiniBrowser/mac/MainMenu.xib:
3943
3944 2013-08-29  Alberto Garcia  <berto@igalia.com>
3945
3946         [GTK] Update apt dependency list
3947         https://bugs.webkit.org/show_bug.cgi?id=120399
3948
3949         Reviewed by Philippe Normand.
3950
3951         Remove bogus package gail-3.0, add xfonts-utils (needed by
3952         xorg-xserver) and switch to the latest versions of libtiff and
3953         libjpeg.
3954
3955         * gtk/install-dependencies:
3956
3957 2013-08-28  Alexey Proskuryakov  <ap@apple.com>
3958
3959         [WK2][Mac] WebKitTestRunner doesn't force system appearance
3960         https://bugs.webkit.org/show_bug.cgi?id=120437
3961
3962         Reviewed by Darin Adler.
3963
3964         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3965         (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
3966         AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
3967         Fixed formatting.
3968
3969 2013-08-16  Ryosuke Niwa  <rniwa@webkit.org>
3970
3971         <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
3972
3973         Reviewed by Darin Adler.
3974
3975         Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
3976
3977         We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
3978         editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
3979
3980         Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
3981         ranges in a given attributed string.
3982
3983         * DumpRenderTree/mac/TextInputController.m:
3984         (-[WebNSRange initWithNSRange:]):
3985         (-[WebNSRange location]):
3986         (-[WebNSRange length]):
3987         (+[WebNSRange isSelectorExcludedFromWebScript:]):
3988         (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
3989         (+[NSMutableAttributedString webScriptNameForSelector:]):
3990         (-[NSMutableAttributedString ranges]): Added.
3991         (+[TextInputController isSelectorExcludedFromWebScript:]):
3992         (+[TextInputController webScriptNameForSelector:]):
3993         (-[TextInputController legacyAttributedString:]):
3994
3995 2013-08-28  Denis Nomiyama  <d.nomiyama@samsung.com>
3996
3997         [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
3998         https://bugs.webkit.org/show_bug.cgi?id=120419
3999
4000         Reviewed by Chris Fleizach.
4001
4002         Added a notification for AXFocusedUIElementChanged.
4003
4004         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
4005         (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
4006
4007 2013-08-28  Roger Fong  <roger_fong@apple.com>
4008
4009         Decrease number of workers used in NRWT by the Windows port.
4010         https://bugs.webkit.org/show_bug.cgi?id=120435.
4011
4012         Reviewed by Brent Fulgham.
4013
4014         * Scripts/webkitpy/port/win.py:
4015         (WinPort.default_child_processes):
4016
4017 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4018
4019         Http tests fails on Debian with Apache 2.4
4020         https://bugs.webkit.org/show_bug.cgi?id=120352
4021
4022         Unreviewed fix-up.
4023
4024         Remember to update unit-test expectations and old-run-webkit-tests as well.
4025
4026         * Scripts/webkitperl/httpd.pm:
4027         (getHTTPDConfigPathForTestDirectory):
4028         * Scripts/webkitpy/port/port_testcase.py:
4029         (test_apache_config_file_name_for_platform):
4030
4031 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4032
4033         Http tests fails on Debian with Apache 2.4
4034         https://bugs.webkit.org/show_bug.cgi?id=120352
4035
4036         Reviewed by Andreas Kling.
4037
4038         Select httpd.conf file for debian based on version, matching Fedora behavior.
4039
4040         * Scripts/webkitpy/port/base.py:
4041         (Port._apache_config_file_name_for_platform):
4042
4043 2013-08-28  Commit Queue  <commit-queue@webkit.org>
4044
4045         Unreviewed, rolling out r154593.
4046         http://trac.webkit.org/changeset/154593
4047         https://bugs.webkit.org/show_bug.cgi?id=120403
4048
4049         Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
4050         on #webkit).
4051
4052         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4053         (WebPage::~WebPage):
4054
4055 2013-08-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
4056
4057         [Qt][Wk2] Many tests are flaky on Qt 5.1
4058         https://bugs.webkit.org/show_bug.cgi?id=118232
4059
4060         Reviewed by Jocelyn Turcotte.
4061
4062         We need to set renderToOffscreenBuffer since we won't otherwise get
4063         the paint calls necessary to synchronize UI- and Web-Process. It was
4064         only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
4065         which is no longer supported or needed.
4066
4067         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4068         (WTR::WrapperWindow::handleStatusChanged):
4069
4070 2013-08-27  Alexey Proskuryakov  <ap@apple.com>
4071
4072         [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
4073         https://bugs.webkit.org/show_bug.cgi?id=120379
4074
4075         Reviewed by Darin Adler.
4076
4077         All major platforms have implemented UI process eventSender support, keeping old
4078         web process side code only adds confusion.
4079
4080         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4081         (WTR::EventSendingController::EventSendingController):
4082         (WTR::EventSendingController::mouseDown):
4083         (WTR::EventSendingController::mouseUp):
4084         (WTR::EventSendingController::mouseMoveTo):
4085         (WTR::EventSendingController::leapForward):
4086         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4087         * WebKitTestRunner/TestController.cpp:
4088         (WTR::TestController::resetStateToConsistentValues):
4089         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4090         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4091         * WebKitTestRunner/TestController.h:
4092
4093 2013-08-27  Roger Fong  <roger_fong@apple.com>
4094
4095         NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
4096         https://bugs.webkit.org/show_bug.cgi?id=120370.
4097
4098         Reviewed by Brent Fulgham.
4099
4100         * Scripts/webkitpy/port/win.py:
4101         (WinPort.delete_sem_locks):
4102         (WinPort.setup_test_run):
4103
4104 2013-08-27  Denis Nomiyama  <d.nomiyama@samsung.com>
4105
4106         [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
4107         https://bugs.webkit.org/show_bug.cgi?id=119883
4108
4109         Implemented the notification listener for AccessibilityUIElement. The signal is generated
4110         by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
4111         axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
4112         callback function. The global callback function and callbacks for specific elements are
4113         stored in a HashMap in AccessibilityCallbacksAtk.cpp.
4114
4115         Reviewed by Chris Fleizach.
4116
4117         * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
4118         * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
4119         and removeAccessibilityNotificationListener()
4120         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
4121         (axObjectEventListener): Call JS callback for global notification or for a specific element
4122         (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
4123         notification handler
4124         (addAccessibilityNotificationHandler): Add notification listener to the list
4125         (removeAccessibilityNotificationHandler): Remove notification listener from the list
4126         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
4127         (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
4128         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
4129         (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
4130         (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
4131         Remove handler from the list and disconnect callbacks
4132         (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
4133         callback and connect callbacks to signals
4134         * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
4135         (AccessibilityNotificationHandler::setPlatformElement): Set platform element
4136         (AccessibilityNotificationHandler::platformElement): Get platform element
4137         (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
4138         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4139         (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
4140         platform element and the notification callback
4141         (AccessibilityUIElement::removeNotificationListener):
4142         * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
4143         * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
4144
4145 2013-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4146
4147         Unreviewed. Fix GTK+ build after r154601.
4148
4149         * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
4150         compilation added by mistake in r154601.
4151
4152 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
4153
4154         WebKitTestRunner needs to protect the user's pasteboard contents while running
4155         https://bugs.webkit.org/show_bug.cgi?id=81419
4156         <rdar://problem/11066794>
4157
4158         Reviewed by Darin Adler.
4159
4160         Mostly a copy/paste of DRT code.
4161
4162         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
4163         doesn't interfere with my clipboard while being run in a loop.
4164
4165         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4166         * WebKitTestRunner/mac/PoseAsClass.h: Added.
4167         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
4168         * WebKitTestRunner/mac/TestControllerMac.mm:
4169         (WTR::TestController::platformInitialize):
4170         (WTR::TestController::platformDestroy):
4171         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
4172         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
4173
4174 2013-08-26  Commit Queue  <commit-queue@webkit.org>
4175
4176         Unreviewed, rolling out r154640.
4177         http://trac.webkit.org/changeset/154640
4178         https://bugs.webkit.org/show_bug.cgi?id=120329
4179
4180         Caused flaky crashes on a lot of editing tests (Requested by
4181         rniwa on #webkit).
4182
4183         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4184         * WebKitTestRunner/mac/PoseAsClass.h: Removed.
4185         * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
4186         * WebKitTestRunner/mac/TestControllerMac.mm:
4187         (WTR::TestController::platformInitialize):
4188         (WTR::TestController::platformDestroy):
4189         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
4190         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
4191
4192 2013-08-26  Dan Bernstein  <mitz@apple.com>
4193
4194         Automatic bug reports case pain
4195         https://bugs.webkit.org/show_bug.cgi?id=120330
4196
4197         Reviewed by Anders Carlsson.
4198
4199         * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
4200         of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
4201         “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
4202
4203 2013-08-23  Andy Estes  <aestes@apple.com>
4204
4205         Fix issues found by the Clang Static Analyzer
4206         https://bugs.webkit.org/show_bug.cgi?id=120230
4207
4208         Reviewed by Darin Adler.
4209
4210         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
4211         (-[LocalPasteboard initWithName:]): Called [super init] first so that we
4212         don't later use ivars from the wrong self.
4213         * DumpRenderTree/mac/TestRunnerMac.mm:
4214         (-[APITestDelegate initWithCompletionCondition:]): Ditto.
4215         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
4216         (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
4217         WKBrowsingContextGroups, and WKViews.
4218
4219 2013-08-26  Alexey Proskuryakov  <ap@apple.com>
4220
4221         WebKitTestRunner needs to protect the user's pasteboard contents while running
4222         https://bugs.webkit.org/show_bug.cgi?id=81419
4223         <rdar://problem/11066794>
4224
4225         Reviewed by Darin Adler.
4226
4227         Mostly a copy/paste of DRT code.
4228
4229         Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
4230         doesn't interfere with my clipboard while being run in a loop.
4231
4232         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4233         * WebKitTestRunner/mac/PoseAsClass.h: Added.
4234         * WebKitTestRunner/mac/PoseAsClass.mm: Added.
4235         * WebKitTestRunner/mac/TestControllerMac.mm:
4236         (WTR::TestController::platformInitialize):
4237         (WTR::TestController::platformDestroy):
4238         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
4239         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
4240
4241 2013-08-26  Zan Dobersek  <zdobersek@igalia.com>
4242
4243         [GTK] Include most of the WebKit2 unit tests into the build and testing
4244         https://bugs.webkit.org/show_bug.cgi?id=120307
4245
4246         Reviewed by Philippe Normand.
4247
4248         There are still various unit test source files that are not being included into
4249         the build. This patch includes most of these, only leaving out tests that do not
4250         compile or test features that are not supported by the GTK port.
4251
4252         * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
4253         (TestRunner):
4254         * TestWebKitAPI/GNUmakefile.am:
4255
4256 2013-08-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4257
4258         [GTK] Allow to run tests without Xvfb in run-gtk-tests
4259         https://bugs.webkit.org/show_bug.cgi?id=120298
4260
4261         Reviewed by Philippe Normand.
4262
4263         Add --no-xvfb command line option to run tests in the current
4264         display.
4265
4266         * Scripts/run-gtk-tests:
4267         (TestRunner._run_xvfb): Return early if option --no-xvfb has been
4268         passed.
4269         (TestRunner._setup_testing_environment): Use helper function