1442bdb7a502b264f40986bb71b9f6ebd23ff19c
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-07  Ojan Vafai  <ojan@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         stop generating results.json files
6         https://bugs.webkit.org/show_bug.cgi?id=53977
7
8         We've only used incremental_results.json for a while now
9         and there are plans to start generating a results.json file that matches
10         the format of unexpected_results.json.
11
12         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
13         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
14         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
15         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
16         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
17
18 2011-02-08  Sailesh Agrawal  <sail@chromium.org>
19
20         Reviewed by Kenneth Russell.
21
22         Invalidate rect doesn't work for windowless plugins on Chromium
23         https://bugs.webkit.org/show_bug.cgi?id=53117
24
25         Added two new utility methods.
26         - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
27         - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
28         This is used to test that invalidating a rect correctly causes a repaint of the plugin.
29
30         * DumpRenderTree/LayoutTestController.cpp:
31         (displayInvalidatedRegionCallback):
32         (LayoutTestController::staticFunctions):
33         * DumpRenderTree/LayoutTestController.h:
34         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
35         (invalidateRect):
36         (pluginInvoke):
37         * DumpRenderTree/chromium/LayoutTestController.cpp:
38         (LayoutTestController::LayoutTestController):
39         (LayoutTestController::displayInvalidatedRegion):
40         * DumpRenderTree/chromium/LayoutTestController.h:
41         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
42
43 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
44
45         Reviewed by Tony Chang.
46
47         new-run-webkit-tests: move the logic that starts and stops the
48         servers from dump_render_tree_thread into single_test_runner
49         so that we can reuse it in the new multiprocessing worker class
50         as well.
51
52         https://bugs.webkit.org/show_bug.cgi?id=53840
53
54         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
55         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
56  
57 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
58
59         Reviewed by Mihai Parparita.
60
61         new-run-webkit-tests: split out thread stack logging code into a sharable module
62
63         This patch splits out the code used to find and log thread
64         stacks from NRWT-specific packages to something generic and
65         shareable by other python modules. It will be shared in the near
66         future by the manager_worker_broker module, for example.
67
68         https://bugs.webkit.org/show_bug.cgi?id=53656
69
70         * Scripts/webkitpy/common/system/stack_utils.py: Added.
71         * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
72         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
73         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
74
75 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
76
77         Reviewed by Tony Chang.
78
79         new-run-webkit-tests: move a bunch of testing logic out of
80         dump_render_tree_thread and into single_test_runner so that we
81         will be able to reuse it in the new multiprocessing worker class as well.
82
83         https://bugs.webkit.org/show_bug.cgi?id=53838
84
85         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
86         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
87
88         
89 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
90
91         Reviewed by Ojan Vafai.
92
93         new-run-webkit-tests: remove no longer needed WatchableThread
94         class.
95
96         https://bugs.webkit.org/show_bug.cgi?id=53839
97
98         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
99
100 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
101
102         Reviewed by Tony Chang.
103
104         new-run-webkit-tests: add stubs for the Manager objects that
105         will abstract the concurrency implementation (inline / threads /
106         processes). These classes do nothing yet and are not wired up to
107         anything.
108
109         https://bugs.webkit.org/show_bug.cgi?id=53477
110
111         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
112         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
113
114 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
115
116         Reviewed by Tony Chang.
117
118         new-run-webkit-tests: add simplified message broker for new-style
119         messaging. This change adds a very simple message broker that
120         will be used to shuttle messages between the TestRunner2 manager
121         thread and the Worker threads. For now the class is not used by
122         anything, but the eventual usage can be seen in the patches
123         attached to bug 49566.
124
125         https://bugs.webkit.org/show_bug.cgi?id=53158
126
127         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
128         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
129
130 2011-02-08  Adam Barth  <abarth@webkit.org>
131
132         Reviewed by Dimitri Glazkov.
133
134         chromium-win builder shouldn't run python or perl tests
135         https://bugs.webkit.org/show_bug.cgi?id=54032
136
137         These tests don't pass on this builder because the builder isn't
138         running in cygwin.  There isn't really any point in running them and
139         making the bot red forever.
140
141         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
142
143 2011-02-08  Brady Eidson  <beidson@apple.com>
144
145         Reviewed by Darin Adler.
146
147         <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
148         didChangeBackForwardList should include some context about what changed
149
150         * MiniBrowser/mac/BrowserWindowController.m:
151         (didChangeBackForwardList):
152
153 2011-02-08  Sam Weinig  <sam@webkit.org>
154
155         Reviewed by Anders Carlsson.
156
157         WK2: Add ability to pass context to policy delegate methods
158         https://bugs.webkit.org/show_bug.cgi?id=54031
159
160         * MiniBrowser/mac/BrowserWindowController.m:
161         (decidePolicyForNavigationAction):
162         (decidePolicyForNewWindowAction):
163         (decidePolicyForMIMEType):
164         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
165         (TestWebKitAPI::decidePolicyForNavigationAction):
166         (TestWebKitAPI::decidePolicyForNewWindowAction):
167         (TestWebKitAPI::decidePolicyForMIMEType):
168         Update policy client for new API.
169
170 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
171
172         Reviewed by Xan Lopez.
173
174         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
175         https://bugs.webkit.org/show_bug.cgi?id=54033
176
177         Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
178         call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
179
180         * DumpRenderTree/gtk/DumpRenderTree.cpp:
181         (resetDefaultsToConsistentValues): Turn off the icon database.
182         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
183         (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
184         method.
185
186 2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>
187
188         Reviewed by Laszlo Gombos.
189
190         Local Storage settings can be enable/disable from "Develop" menu
191         https://bugs.webkit.org/show_bug.cgi?id=52296
192
193         * QtTestBrowser/launcherwindow.cpp:
194         (LauncherWindow::createChrome):
195         (LauncherWindow::toggleLocalStorage):
196         (LauncherWindow::toggleOfflineStorageDatabase):
197         (LauncherWindow::toggleOfflineWebApplicationCache):
198         (LauncherWindow::setOfflineStorageDefaultQuota):
199         * QtTestBrowser/launcherwindow.h:
200         (WindowOptions::WindowOptions):
201         * QtTestBrowser/main.cpp:
202         (LauncherApplication::handleUserOptions):
203
204 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
205
206         Reviewed by Eric Seidel.
207
208         [GTK] EventSender.keyDown does not support non-array modifier arguments
209         https://bugs.webkit.org/show_bug.cgi?id=53962
210
211         Support handling either an array or a string for the modifier argument
212         to EventSender.keyDown.
213
214         * DumpRenderTree/gtk/EventSender.cpp:
215         (gdkModifierFromJSValue): Added this helper which factors out the
216         string comparison bits.
217         (gdkModifersFromJSValue): Test up front whether the value is a string,
218         to handle it specially.
219
220 2011-02-08  Benjamin Poulain  <ikipou@gmail.com>
221
222         Reviewed by Csaba Osztrogonác.
223
224         openDatabaseSync() stop responding after too many call
225         https://bugs.webkit.org/show_bug.cgi?id=53945
226
227         Reset the database quota to a known state between each test.
228
229         Define a quota for the known origins at each test run and delete
230         all the databases.
231         This way, the database related test do not depend on previous
232         allocations.
233
234         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
235         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
236         (WebCore::DumpRenderTree::dumpDatabaseQuota):
237         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
238         (LayoutTestController::reset):
239
240 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
241
242         Reviewed by Martin Robinson.
243
244         [GTK] DRT's TextInputController is unimplemented on GTK
245         https://bugs.webkit.org/show_bug.cgi?id=52997
246
247         Initial implementation of TextInputController for GTK port.
248
249         * DumpRenderTree/gtk/DumpRenderTree.cpp:
250         (webViewWindowObjectCleared):
251         * DumpRenderTree/gtk/TextInputController.cpp: Added.
252         (setMarkedTextCallback):
253         (insertTextCallback):
254         (unmarkTextCallback):
255         (firstRectForCharacterRangeCallback):
256         (selectedRangeCallback):
257         (getClass):
258         (makeTextInputController):
259         * DumpRenderTree/gtk/TextInputController.h: Added.
260         * GNUmakefile.am:
261
262 2011-02-07  Tony Chang  <tony@chromium.org>
263
264         Reviewed by Adam Barth.
265
266         clean up python imports
267         https://bugs.webkit.org/show_bug.cgi?id=53966
268
269         Convert "import A.B.C.D as D" to "from A.B.C import D" and
270         make some imports absolute as required by PEP-8
271
272         * Scripts/webkitpy/common/checkout/scm.py:
273         * Scripts/webkitpy/common/net/irc/ircbot.py:
274         * Scripts/webkitpy/common/system/logutils.py:
275         * Scripts/webkitpy/common/system/logutils_unittest.py:
276         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
277         * Scripts/webkitpy/layout_tests/port/chromium.py:
278         * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
279         * Scripts/webkitpy/layout_tests/port/webkit.py:
280         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
281         * Scripts/webkitpy/tool/bot/irc_command.py:
282         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
283         * Scripts/webkitpy/tool/commands/download.py:
284         * Scripts/webkitpy/tool/commands/prettydiff.py:
285         * Scripts/webkitpy/tool/commands/queries.py:
286         * Scripts/webkitpy/tool/commands/roll.py:
287         * Scripts/webkitpy/tool/commands/stepsequence.py:
288         * Scripts/webkitpy/tool/commands/upload.py:
289         * Scripts/webkitpy/tool/main.py:
290
291 2011-02-07  James Robinson  <jamesr@chromium.org>
292
293         Reviewed by Adam Barth.
294
295         Teach do-webcore-rename about the WebKit move to Source/
296         https://bugs.webkit.org/show_bug.cgi?id=53967
297
298         * Scripts/do-webcore-rename:
299
300 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
301
302         Reviewed by Dan Bernstein.
303
304         Add resource load client for injected bundle and move willSendRequest there
305         https://bugs.webkit.org/show_bug.cgi?id=53972
306
307         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
308         (didCreatePage):
309         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
310         (WTR::InjectedBundlePage::InjectedBundlePage):
311         (WTR::InjectedBundlePage::didInitiateLoadForResource):
312         (WTR::InjectedBundlePage::didReceiveResponseForResource):
313         (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
314         (WTR::InjectedBundlePage::didFinishLoadForResource):
315         (WTR::InjectedBundlePage::didFailLoadForResource):
316         (WTR::InjectedBundlePage::willSendRequestForFrame):
317         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
318
319 2011-02-07  Adam Barth  <abarth@webkit.org>
320
321         Add Leopard Debug back to the core builders.
322
323         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
324         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
325
326 2011-02-07  Adam Klein  <adamk@chromium.org>
327
328         Reviewed by Jian Li.
329
330         [chromium] Remove deprecated method WebNotification::dir
331         https://bugs.webkit.org/show_bug.cgi?id=53735
332
333         * DumpRenderTree/chromium/NotificationPresenter.cpp:
334         (NotificationPresenter::show):
335
336 2011-02-07  Adam Barth  <abarth@webkit.org>
337
338         Reviewed by Eric Seidel.
339
340         Remove Leopard Debug as a core builder
341         https://bugs.webkit.org/show_bug.cgi?id=53971
342
343         The Leopard Debug builder has been failing to compile for several days.
344         My understanding is that folks are working on fixing the build, but for
345         the time being we should probably remove it from the list of core
346         builders so that the core waterfall can be green.  We can certainly add
347         it back once the build is fixed.
348
349         Also, I've removed the Tiger builders because those no longer appear to
350         be attached to the buildbot master.
351
352         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
353         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
354
355 2011-02-01  Ojan Vafai  <ojan@chromium.org>
356
357         Reviewed by Adam Roben.
358
359         include svn revisions in git diffs for the code review tool to use
360         https://bugs.webkit.org/show_bug.cgi?id=53569
361
362         * Scripts/webkitpy/common/checkout/scm.py:
363         * Scripts/webkitpy/common/checkout/scm_unittest.py:
364
365 2011-02-03  MORITA Hajime  <morrita@google.com>
366
367         Reviewed by Darin Fisher.
368
369         [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
370         https://bugs.webkit.org/show_bug.cgi?id=51013
371
372         Gave DRT implementation for requestTextCheck().
373
374         * DumpRenderTree/chromium/LayoutTestController.cpp:
375         (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
376         * DumpRenderTree/chromium/WebViewHost.cpp:
377         (invokeFinishLastTextCheck): Added.
378         (WebViewHost::requestTextCheck): Added.
379         (WebViewHost::finishLastTextCheck): Added.
380         * DumpRenderTree/chromium/WebViewHost.h:
381
382 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
383
384         Reviewed by Martin Robinson.
385
386         [Gtk] Implement layoutTestController.findString
387         https://bugs.webkit.org/show_bug.cgi?id=50237
388
389         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
390         (LayoutTestController::findString):
391
392 2011-02-07  Chang Shu  <chang.shu@nokia.com>
393
394         Reviewed by Darin Adler.
395
396         We should disable spatial navigation explicitly during the initialization
397         of DumpRenderTree.
398         https://bugs.webkit.org/show_bug.cgi?id=53928
399
400         * DumpRenderTree/mac/DumpRenderTree.mm:
401         (resetDefaultsToConsistentValues):
402
403 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
404
405         Not reviewed.
406
407         Fix WebKitTestRunner build on the SL bot.
408
409         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
410         of ICU headers.
411
412 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
413
414         Unreviewed.
415
416         [Qt][WK2] Buildfix after r77794.
417
418        WebKitTestRunner does not block remote resources or complain about them
419        https://bugs.webkit.org/show_bug.cgi?id=42139
420        <rdar://problem/8183942>
421
422         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
423
424 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
425
426         Not reviewed.
427
428         More bot appeasement.
429
430         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
431
432 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
433
434         Not reviewed.
435
436         Remove accidental references to directories on my laptop.
437
438         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
439
440 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
441
442         Reviewed by Antti Koivisto.
443
444         WebKitTestRunner does not block remote resources or complain about them
445         https://bugs.webkit.org/show_bug.cgi?id=42139
446         <rdar://problem/8183942>
447
448         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
449         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
450         checks (using KURL, to avoid need to invent a whole URL API).
451         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
452         directly to get at KURL symbols.
453
454 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
455
456         Reviewed by Daniel Bates.
457
458         Add WebKit2 bot to list of expected builders in Python regression test results.
459         https://bugs.webkit.org/show_bug.cgi?id=53905
460
461         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
462
463 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
464
465         Reviewed by Ryosuke Niwa.
466
467         Update test expectations for new core builder
468         https://bugs.webkit.org/show_bug.cgi?id=53904
469
470         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
471
472 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
473
474         Reviewed by David Levin.
475
476         Add WebKit2 test bot to core builders
477         https://bugs.webkit.org/show_bug.cgi?id=53901
478
479         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
480
481 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
482
483         Another unreviewed Chromium build fix.
484
485         * DumpRenderTree/chromium/LayoutTestController.cpp:
486         (LayoutTestController::pathToLocalResource):
487
488 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
489
490         Unreviewed Chromium build fix.
491
492         * DumpRenderTree/chromium/LayoutTestController.cpp:
493         (LayoutTestController::pathToLocalResource):
494
495 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
496
497         Reviewed by Darin Adler.
498
499         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
500         https://bugs.webkit.org/show_bug.cgi?id=52867
501
502         * DumpRenderTree/chromium/ImageDiff.cpp:
503         (Image::craeteFromStdin): Call adoptArrayPtr.
504
505 2011-02-06  James Kozianski  <koz@chromium.org>
506
507         Reviewed by Ojan Vafai.
508
509         Add classes for representing test outputs.
510         https://bugs.webkit.org/show_bug.cgi?id=52136
511
512         These classes will make it easier to write scripts that deal with test
513         outputs such as rebaselining and deduping scripts. The intent is that
514         eventually we will be have buildbot return TestOutputs for a
515         particular build which can be compared with TestOutputs derived from a
516         local LayoutTests directory.
517
518         * Scripts/webkitpy/common/net/testoutput.py: Added.
519         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
520         * Scripts/webkitpy/common/net/testoutputset.py: Added.
521         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
522         * Scripts/webkitpy/common/system/zip_mock.py: Added.
523
524 2011-02-06  Robert Hogan  <robert@webkit.org>
525
526         Reviewed by Andreas Kling.
527
528         [Qt] Clear page's groupName even when not in DRT
529         https://bugs.webkit.org/show_bug.cgi?id=53874
530
531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
532         (WebCore::DumpRenderTree::windowCloseRequested):
533
534 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
535
536         Reviewed by Andreas Kling.
537
538         [CMake] Add dependencies for Visual Studio projects
539         https://bugs.webkit.org/show_bug.cgi?id=53773
540
541         Add a WebKit dependecy to WinCELauncher, so CMake can 
542         generate the correct build order for the solution.
543
544         * CMakeListsWinCE.txt:
545
546 2011-02-06  Andreas Kling  <kling@webkit.org>
547
548         Reviewed by Antonio Gomes.
549
550         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
551         https://bugs.webkit.org/show_bug.cgi?id=53869
552
553         * MiniBrowser/qt/BrowserView.cpp:
554         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
555         * MiniBrowser/qt/BrowserWindow.cpp:
556         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
557         * MiniBrowser/qt/BrowserWindow.h:
558
559 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
560
561         Reviewed by Dan Bernstein.
562
563         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
564         https://bugs.webkit.org/show_bug.cgi?id=42690
565         <rdar://problem/8213851>
566
567         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
568         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
569         (WTR::InjectedBundlePage::willSendRequestForFrame):
570         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
571         (WTR::LayoutTestController::LayoutTestController):
572         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
573         (WTR::LayoutTestController::willSendRequestReturnsNull):
574         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
575
576 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
577
578         Unreviewed, rolling out r77720.
579         http://trac.webkit.org/changeset/77720
580         https://bugs.webkit.org/show_bug.cgi?id=53854
581
582         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
583         #webkit).
584
585         * Scripts/webkitpy/common/system/executive.py:
586
587 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
588
589         Unreviewed, rolling out r77725.
590         http://trac.webkit.org/changeset/77725
591         https://bugs.webkit.org/show_bug.cgi?id=53844
592
593         It broke Qt minimal build (Requested by Ossy_ on #webkit).
594
595         * QtTestBrowser/launcherwindow.cpp:
596         (LauncherWindow::createChrome):
597         * QtTestBrowser/launcherwindow.h:
598         (WindowOptions::WindowOptions):
599         * QtTestBrowser/main.cpp:
600         (LauncherApplication::handleUserOptions):
601
602 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
603
604         Reviewed by Adam Barth.
605
606         [GTK] plugins/plugin-document-back-forward.html fails
607         https://bugs.webkit.org/show_bug.cgi?id=53833
608
609         Add the new "alert on load" functionality for the Unix version of the
610         test plugin. This functionality was originally introduced in r77706.
611
612         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
613         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
614
615 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
616
617         Reviewed by Andreas Kling.
618
619         Local Storage settings can be enable/disable from "Develop" menu
620         https://bugs.webkit.org/show_bug.cgi?id=52296
621
622         * QtTestBrowser/launcherwindow.cpp:
623         (LauncherWindow::createChrome):
624         (LauncherWindow::toggleLocalStorage):
625         (LauncherWindow::toggleOfflineStorageDatabase):
626         (LauncherWindow::toggleOfflineWebApplicationCache):
627         (LauncherWindow::setOfflineStorageDefaultQuota):
628         * QtTestBrowser/launcherwindow.h:
629         (WindowOptions::WindowOptions):
630         * QtTestBrowser/main.cpp:
631         (LauncherApplication::handleUserOptions):
632
633 2011-02-04  Tony Chang  <tony@chromium.org>
634
635         Reviewed by Eric Seidel.
636
637         get test-webkitpy running on win32 python
638         https://bugs.webkit.org/show_bug.cgi?id=53822
639
640         The test harness crashes with a WindowsError because it can't find
641         'svn' when using subprocess.Popen.  This gets us past the error
642         so we can see the failing tests on the Chromium Win Release Tests
643         bot.
644
645         * Scripts/webkitpy/common/system/executive.py:
646
647 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
648
649         Reviewed by Gustavo Noronha Silva.
650
651         [GTK] fast/events/pagehide-timeout.html fails
652         https://bugs.webkit.org/show_bug.cgi?id=53771
653
654         Add knowledge of the document browser cache model the DRT. When resetting
655         WebKit settings to consistent values between tests, default to the document
656         browser cache model.
657
658         * DumpRenderTree/gtk/DumpRenderTree.cpp:
659         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
660         cache model between tests.
661         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
662         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
663         document browser cache model.
664
665 2011-02-04  Adam Barth  <abarth@webkit.org>
666
667         Reviewed by Eric Seidel.
668
669         PluginDocuments don't create widgets for plugins on back/forward
670         https://bugs.webkit.org/show_bug.cgi?id=53474
671
672         Teach the test plugin how to call alert on load.
673
674         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
675         (NPP_New):
676
677 2011-02-04  Adam Roben  <aroben@apple.com>
678
679         Add a test case for encode/decode of FormData/FormDataElement
680
681         If the fix made in r77401 is broken, this new test will crash.
682
683         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
684
685         Reviewed by Sam Weinig.
686
687         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
688         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
689
690         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
691         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
692         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
693         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
694         form, an return the session state data.
695         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
696         and restore it into another WKPage.
697
698         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
699
700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
701         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
702         * TestWebKitAPI/win/copy-resources.cmd:
703         Added new files.
704
705 2011-02-04  Adam Roben  <aroben@apple.com>
706
707         Move code to run JavaScript tests into its own files
708
709         This will allow other tests to use this mechanism.
710
711         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
712         world
713
714         Reviewed by Sam Weinig.
715
716         * TestWebKitAPI/JavaScriptTest.cpp: Added.
717         * TestWebKitAPI/JavaScriptTest.h: Added.
718         Moved code here...
719
720         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
721
722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
723         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
724         Added the new files.
725
726 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
727
728         Reviewed by Mihai Parparita.
729
730         merge test expectations for chromium, chromium-gpu. The
731         chromium-gpu port will no longer maintain its own
732         test expectations file.
733
734         Also add in a graphics_type() call on the port object to
735         determine what graphics type to use in the test configuration,
736         and log the configuration as a config setting.
737
738         https://bugs.webkit.org/show_bug.cgi?id=53562
739
740         * Scripts/webkitpy/layout_tests/port/base.py:
741         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
742         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
743         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
744
745 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
746
747         Reviewed by Pavel Feldman.
748
749         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
750         https://bugs.webkit.org/show_bug.cgi?id=53781
751
752         * Scripts/check-inspector-strings:
753
754 2011-02-04  Adam Roben  <aroben@apple.com>
755
756         Include the crashing function in the link to a crash log on Mac
757
758         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
759         function that crashed on Mac
760
761         Reviewed by David Kilzer.
762
763         * Scripts/old-run-webkit-tests:
764         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
765         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
766         the crash log.
767
768 2011-02-04  Adam Roben  <aroben@apple.com>
769
770         Link to Mac crash logs from results.html
771
772         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
773         results.html
774
775         Reviewed by David Kilzer.
776
777         * Scripts/old-run-webkit-tests:
778         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
779         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
780
781 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
782
783         Reviewed by Dan Bernstein.
784
785         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
786         https://bugs.webkit.org/show_bug.cgi?id=52897
787         <rdar://problem/8898294>
788
789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
790         (WTR::InjectedBundlePage::InjectedBundlePage):
791         (WTR::InjectedBundlePage::willSendRequestForFrame):
792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
793
794 2011-02-03  Ivan Krstić  <ike@apple.com>
795
796         Unreviewed.
797
798         Adding myself to committers.py.
799
800         * Scripts/webkitpy/common/config/committers.py:
801
802 2011-02-03  James Kozianski  <koz@chromium.org>
803
804         Reviewed by Dimitri Glazkov.
805
806         Add navigator.registerProtocolHandler behind a flag.
807         https://bugs.webkit.org/show_bug.cgi?id=52609
808
809         * Scripts/build-webkit:
810
811 2011-02-03  Hayato Ito  <hayato@chromium.org>
812
813         Reviewed by Eric Seidel.
814
815         [NRWT] Remove TestArgs class, which is wrongly used.
816
817         https://bugs.webkit.org/show_bug.cgi?id=53063
818
819         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
820         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
821         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
822         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
823         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
824         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
825
826 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
827
828         Reviewed by Kenneth Russell.
829
830         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
831         https://bugs.webkit.org/show_bug.cgi?id=53714
832
833         * Scripts/build-webkit: change --3d-canvas build option
834           to set ENABLE_WEBGL
835
836 2011-02-03  Hayato Ito  <hayato@chromium.org>
837
838         Reviewed by Tony Chang.
839
840         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
841         move _run_single_test() and _process_output() functions from
842         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
843
844         This is clean up and acts as a preparation for elimination of test_types/*
845         classes. These classes will move to the single_test_runner module introduced
846         in this patch.
847
848         https://bugs.webkit.org/show_bug.cgi?id=53004
849
850         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
851         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
852         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
853         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
854         * Scripts/webkitpy/layout_tests/port/base.py:
855         * Scripts/webkitpy/layout_tests/port/chromium.py:
856         * Scripts/webkitpy/layout_tests/port/dryrun.py:
857         * Scripts/webkitpy/layout_tests/port/test.py:
858         * Scripts/webkitpy/layout_tests/port/webkit.py:
859         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
860         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
861         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
862
863 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
864
865         Unreviewed, build fix.
866
867         Delete a line that was accidentally missed in r77586; without it
868         there is still a race between the two threads.
869
870         https://bugs.webkit.org/show_bug.cgi?id=51572
871
872         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
873
874 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
875
876         Reviewed by Tony Chang.
877
878         nrwt: handle "broken pipe" notifications from DRT more cleanly.
879
880         https://bugs.webkit.org/show_bug.cgi?id=52927
881
882         * Scripts/webkitpy/layout_tests/port/server_process.py:
883         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
884
885 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
886
887         Reviewed by Kenneth Russell.
888
889         Update, resubmit change to bug 51572. I think the race that was
890         fixed in r76703 caused the hang that caused us to roll this
891         patch out before, so I'd like to try again.
892
893         https://bugs.webkit.org/show_bug.cgi?id=51572
894
895         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
896         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
897
898 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
899
900         Unreviewed.
901
902         Adding myself to committers.py.
903
904         * Scripts/webkitpy/common/config/committers.py:
905
906 2011-02-03  Adam Roben  <aroben@apple.com>
907
908         Include the crashing function in the link to a crash log
909
910         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
911         function that crashed
912
913         Reviewed by David Kilzer.
914
915         * Scripts/old-run-webkit-tests:
916         (crashLocation): Added. Returns the location of the crash.
917         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
918         could be determined.
919
920 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
921
922         Unreviewed, build fix.
923
924         Actually make the changes suggested by Mihai in his review
925         of bug 53720 :(
926
927         https://bugs.webkit.org/show_bug.cgi?id=53720
928
929         * Scripts/webkitpy/layout_tests/port/test_files.py:
930         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
931
932 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
933
934         Reviewed by Mihai Parparita.
935
936         new-run-webkit-tests: Fix bug introduced in r77434 that was
937         causing us to run the canvas GPU tests on the Mac GPU port. This
938         bug revealed that we were not setting the port.name() field
939         properly in many cases, so I've cleaned up all of that code, and
940         removed a few comments about "version-specific" GPU ports that
941         don't exist and just confused things.
942
943         Testing also revealed that port.abspath_for_test() wasn't
944         normalizing paths on Windows properly, so I fixed that as well.
945
946         https://bugs.webkit.org/show_bug.cgi?id=53719
947
948         * Scripts/webkitpy/layout_tests/port/base.py:
949         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
950         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
951
952 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
953
954         Reviewed by Mihai Parparita.
955
956         new-run-webkit-tests: fix normalization of paths on windows when gathering files
957
958         r77434 introduced a bug that was causing the test expectations
959         for the GPU ports to not be treated properly. It turns out that
960         when we gathered the list of test files on Windows, we would
961         return paths of the form "c:\LayoutTests/fast/canvas", and the
962         mixture of backslashes and forward slashes was confusing things.
963
964         This patch normalizes all of the filenames returned from
965         test_files.find(), and adds better tests for this (fixing a
966         couple of other bugs found in the meantime).
967
968         https://bugs.webkit.org/show_bug.cgi?id=53720
969
970         * Scripts/webkitpy/layout_tests/port/test.py:
971         * Scripts/webkitpy/layout_tests/port/test_files.py:
972         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
973
974 2011-02-03  Adam Roben  <aroben@apple.com>
975
976         Add links to Windows crash logs in results.html
977
978         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
979         results.html
980
981         Reviewed by David Kilzer.
982
983         * Scripts/old-run-webkit-tests:
984         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
985         createDebuggerCommandFile).
986         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
987         tool has exited.
988         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
989         it into the test results directory tree. Only implemented for Cygwin currently.
990         (findNewestFileMatchingGlob): Added. Does what it says.
991         (htmlForResultsSection): Only link to files that exist.
992         (linksForErrorTest): Add a link to the crash log.
993         (deleteExpectedAndActualResults): Delete any old crash log for this test.
994         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
995         hardcoding it here.
996
997 2011-02-03  Adam Roben  <aroben@apple.com>
998
999         Tell the debugger the path to the WebKit source tree when saving a crash log
1000
1001         This allows the debugger to include the crashing line of code in the log.
1002
1003         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
1004         of code
1005
1006         Reviewed by Sam Weinig.
1007
1008         * Scripts/old-run-webkit-tests:
1009         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
1010         file and returns the path to that file. The commands we pass came from
1011         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
1012         WebKit source code lives.
1013         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
1014         line using -c, save them to a file and specify the path to that file using -cf. This works
1015         around what is presumably a bug in Windows's command line parsing, where having multiple
1016         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
1017         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
1018         together to make them easier to modify in the future.
1019
1020 2011-02-02  Sam Weinig  <sam@webkit.org>
1021
1022         Reviewed by Anders Carlsson.
1023
1024         Add notification of the end of a rubber band.
1025         <rdar://problem/8940648>
1026
1027         * MiniBrowser/mac/BrowserWindowController.m:
1028         (-[BrowserWindowController awakeFromNib]):
1029         * WebKitTestRunner/TestController.cpp:
1030         (WTR::TestController::createOtherPage):
1031         (WTR::TestController::initialize):
1032         Stub out the new WKUIClient function.
1033
1034 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
1035
1036         Unreviewed.
1037
1038         Adding myself to committers.py.
1039
1040         * Scripts/webkitpy/common/config/committers.py:
1041
1042 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
1043
1044         Reviewed by Csaba Osztrogonác.
1045
1046         [Qt][WK2] MiniBrowser's window size should be 800x600
1047         https://bugs.webkit.org/show_bug.cgi?id=53670
1048
1049         Make layout test failure debugging easier.
1050         * MiniBrowser/qt/BrowserWindow.cpp:
1051         (BrowserWindow::BrowserWindow):
1052
1053 2011-02-02  Andy Estes  <aestes@apple.com>
1054
1055         Reviewed by Mark Rowe.
1056
1057         'update-webkit' should handle OpenSource and Internal using different
1058         VCSs.
1059
1060         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
1061         Internal directory.
1062
1063 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1064
1065         Reviewed by Mihai Parparita.
1066
1067         new-run-webkit-tests: hardcode the directories to scan for tests
1068         for GPU bots instead of SKIPping them. See bug 53562 for some
1069         context, but we will now hard-code the list of directories to
1070         use by default instead of skipping over directories in the
1071         expectations file. We do this so that we will be able to merge
1072         the expectations files without getting conflicting SKIP
1073         directives. Note that this change will reduce the # of tests
1074         being run on the Mac GPU bots, because we're accidentally
1075         including some today.
1076
1077         https://bugs.webkit.org/show_bug.cgi?id=53631
1078
1079         * Scripts/webkitpy/layout_tests/port/base.py:
1080         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1081         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1082
1083 2011-02-02  Sam Weinig  <sam@webkit.org>
1084
1085         Reviewed by Beth Dakin.
1086
1087         Add ChromeClient function to paint custom overhang areas.
1088         https://bugs.webkit.org/show_bug.cgi?id=53639
1089
1090         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1091         (WTR::InjectedBundlePage::InjectedBundlePage):
1092         Stub out new callback.
1093
1094 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1095
1096         Reviewed by Tony Chang.
1097
1098         new-run-webkit-tests: support chromium code paths in mock_drt
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=53471
1101
1102         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1103         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1104
1105 2011-02-02  Adam Klein  <adamk@chromium.org>
1106
1107         Reviewed by Tony Chang.
1108
1109         Update new-run-webkit-tests --chromium to put output under Source/...
1110         https://bugs.webkit.org/show_bug.cgi?id=53612
1111
1112         * BuildSlaveSupport/test-result-archive:
1113         * Scripts/webkitpy/layout_tests/port/chromium.py:
1114
1115 2011-01-28  Tony Chang  <tony@chromium.org>
1116
1117         Reviewed by Eric Seidel.
1118
1119         [chromium] remove --use-test-shell from NRWT
1120         https://bugs.webkit.org/show_bug.cgi?id=53346
1121
1122         I've already started removing some of the bindings like eventSender so
1123         this already doesn't work isn't useful.  Also updated some comments to
1124         refer to DRT instead of test_shell.
1125
1126         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1127         * Scripts/webkitpy/layout_tests/port/chromium.py:
1128         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1129         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1130         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1131         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1132         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1133         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1134
1135 2011-02-02  Steve Lacey  <sjl@chromium.org>
1136
1137         Reviewed by Eric Carlson.
1138
1139         Implement basic media statistics on media elements.
1140         https://bugs.webkit.org/show_bug.cgi?id=53322
1141
1142         * Scripts/build-webkit:
1143
1144 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1145
1146         [wx] Build fixes for wxWebKit.
1147
1148         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1149         (LayoutTestController::setSerializeHTTPLoads):
1150         * wx/browser/wscript:
1151         * wx/build/build_utils.py:
1152         * wx/build/settings.py:
1153
1154 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1155
1156         Reviewed by Mihai Parparita.
1157
1158         new-run-webkit-tests: stop skipping so many tests
1159
1160         r77163 introduced a regression where we weren't resetting test
1161         expectations properly and were skipping too many tests as a
1162         result. This patch fixes that and adds a test for it.
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=53551
1165
1166         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1167         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1168
1169 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1170
1171         Reviewed by Tony Chang.
1172
1173         new-run-webkit-tests: add first stub of test_runner2. This
1174         will add support for the 'inline', 'threads', and 'processes'
1175         flags to --worker-model, but for now the implementatios just
1176         fall back on the old ones.
1177
1178         https://bugs.webkit.org/show_bug.cgi?id=53157
1179
1180         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1181         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1182
1183 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
1184
1185         Reviewed by James Robinson.
1186
1187         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
1188         https://bugs.webkit.org/show_bug.cgi?id=53522
1189
1190         * Scripts/run-chromium-webkit-unit-tests:
1191
1192 2011-02-01  Adam Barth  <abarth@webkit.org>
1193
1194         Reviewed by Mihai Parparita.
1195
1196         Using Control-C to cancel webkit-patch or other python tools causes
1197         unpleasant traceback console spew
1198         https://bugs.webkit.org/show_bug.cgi?id=53462
1199
1200         Catch the exception and don't print the stack trace.
1201
1202         * Scripts/webkit-patch:
1203
1204 2011-02-01  Scott Cameron  <sccameron@rim.com>
1205
1206         Reviewed by Daniel Bates.
1207
1208         Use Windows format for MinGW HTTPD path.
1209         https://bugs.webkit.org/show_bug.cgi?id=53503
1210
1211         * Scripts/webkitperl/httpd.pm:
1212           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
1213             so that we don't have to escape the space characters in the path. Also,
1214             changed path to Windows-style path and removed FIXME comment.
1215
1216 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
1217
1218         Reviewed by Andreas Kling.
1219
1220         [Qt][WK2] Add a way to use shared process model in MiniBrowser
1221         https://bugs.webkit.org/show_bug.cgi?id=53090
1222
1223         * MiniBrowser/qt/BrowserView.cpp:
1224         (BrowserView::BrowserView): Removed the m_context member.
1225         From now the context is guaranteed to be non-null and we
1226         don't need to store that in the object.
1227         * MiniBrowser/qt/BrowserView.h:
1228         * MiniBrowser/qt/BrowserWindow.cpp:
1229         Added static bool to determine that new windows need to be
1230         created with their own context or not. Use the same context
1231         and web process by default to be inilne with the other ports.
1232         (BrowserWindow::BrowserWindow):
1233         (BrowserWindow::newWindow):
1234         * MiniBrowser/qt/BrowserWindow.h:
1235         * MiniBrowser/qt/main.cpp:
1236         (main): Added command line switch to be able to use the
1237         non-shared process model. Simplify the handling of the command line
1238         switches a little bit.
1239
1240 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1241
1242         Reviewed by Andreas Kling.
1243
1244         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
1245         https://bugs.webkit.org/show_bug.cgi?id=53491
1246
1247         * MiniBrowser/qt/BrowserWindow.cpp:
1248         (BrowserWindow::BrowserWindow):
1249         (BrowserWindow::toggleFullScreenMode):
1250         * MiniBrowser/qt/BrowserWindow.h:
1251
1252 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1253
1254         Reviewed by Andreas Kling.
1255
1256         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
1257         https://bugs.webkit.org/show_bug.cgi?id=53489
1258
1259         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
1260         to Settings menu.
1261
1262         * MiniBrowser/qt/BrowserWindow.cpp:
1263         (BrowserWindow::BrowserWindow):
1264         (BrowserWindow::toggleFrameFlattening):
1265         (BrowserWindow::toggleDisableJavaScript):
1266         (BrowserWindow::toggleAutoLoadImages):
1267         * MiniBrowser/qt/BrowserWindow.h:
1268
1269 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
1270
1271         Reviewed by Tony Chang.
1272
1273         [Chromium] Switch chromium-mac to use ChromiumDriver
1274         https://bugs.webkit.org/show_bug.cgi?id=53461
1275         
1276         For the sake of consistency with the other Chromium platforms (and so
1277         that chromium-mac picks up special flags like --enable-hardware-gpu),
1278         switch chromium-mac from the WebKitDriver to ChromiumDriver.
1279
1280         * Scripts/webkitpy/layout_tests/port/chromium.py:
1281
1282 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
1283
1284         Reviewed by Mihai Parparita.
1285
1286         The current modifier parsing code in test_expectations is
1287         fragile and hard-coded, so it's not easy to understand the logic
1288         or easily add new types of modifiers (like GPU vs. CPU testing
1289         for graphics tests, or 32-bit vs. 64-bit differences).
1290
1291         This is the first of two patches that will add in more generic
1292         support and then eliminate the GPU-specific test expectations
1293         files for Chromium.
1294
1295         This patch adds two standalone objects for handling modifiers. The
1296         rules for interpreting modifiers, precedence, and conflicts are
1297         given in the docstring to the ModifierMatcher class, which
1298         returns ModifierMatchResult objects.
1299         
1300         This patch also adds routines to the Port interface and a
1301         default set of values in the base object, in order to obtain the
1302         values needed on a given test run. These values are then passed
1303         to the expectation parser. This also allows us to clean up the
1304         logic used to lint all of the different configurations in a
1305         single test_expectations.txt file.
1306
1307         The next patch will merge in the separate GPU expectations file.
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=51222
1310
1311         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1312         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1313         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1314         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1315         * Scripts/webkitpy/layout_tests/port/base.py:
1316         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1317         * Scripts/webkitpy/layout_tests/port/chromium.py:
1318         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1319         * Scripts/webkitpy/layout_tests/port/test.py:
1320         * Scripts/webkitpy/layout_tests/port/webkit.py:
1321         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1322         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1323         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1324         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
1325         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1326
1327 2011-01-31  Scott Cameron  <sccameron@rim.com>
1328
1329         Reviewed by Daniel Bates.
1330
1331         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
1332         https://bugs.webkit.org/show_bug.cgi?id=50036
1333
1334         This will add an Apache2.2 configuration file and modifies scripts to allow
1335         running an httpd server in an MSYS environment.
1336
1337         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
1338         in order to allow for simple installation/execution.  Simply install the latest
1339         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
1340         be able to execute run-webkit-httpd.
1341         
1342
1343         * Scripts/run-webkit-httpd:
1344         * Scripts/webkitperl/httpd.pm:
1345
1346 2011-01-31  Tony Chang  <tony@chromium.org>
1347
1348         Reviewed by Eric Seidel.
1349
1350         mac DRT should report RTL scroll offset relative to top right corner
1351         https://bugs.webkit.org/show_bug.cgi?id=53324
1352
1353         * DumpRenderTree/mac/DumpRenderTree.mm:
1354         (dumpFrameScrollPosition):
1355
1356 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
1357
1358         Reviewed by Andreas Kling.
1359
1360         [Qt] Add Take Screen Shot action to MiniBrowser
1361         https://bugs.webkit.org/show_bug.cgi?id=53422
1362
1363         Add Take Screen Shot action to MiniBrowser's view menu.
1364
1365         * MiniBrowser/qt/BrowserWindow.cpp:
1366         (BrowserWindow::BrowserWindow):
1367         (BrowserWindow::screenshot):
1368         * MiniBrowser/qt/BrowserWindow.h:
1369
1370 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1371
1372         Reviewed by Xan Lopez.
1373
1374         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
1375         https://bugs.webkit.org/show_bug.cgi?id=53379
1376
1377         Remove left over #ifdef's. I thought all of the conditional code
1378         had been freed from the condition, but I forgot to check DRT.
1379
1380         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1381         (resetDefaultsToConsistentValues):
1382         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1383         (LayoutTestController::setAlwaysAcceptCookies):
1384
1385 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1386
1387         Unreviewed, build fix.
1388
1389         Fix regression introduced in r77093 - path.rsplit() doesn't
1390         take keyword arguments.
1391
1392         https://bugs.webkit.org/show_bug.cgi?id=53326
1393
1394         * Scripts/webkitpy/common/system/filesystem_mock.py:
1395
1396 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1397
1398         Reviewed by Mihai Parparita.
1399
1400         Add more unit tests for rebaseline-chromium-webkit-tests. This
1401         change involves restructuring a bunch of r-c-w-t code to make it
1402         more testable as well. We also add wrapper classes for handling
1403         testing zip files and fetching URLs.
1404
1405         https://bugs.webkit.org/show_bug.cgi?id=53040
1406
1407         * Scripts/webkitpy/common/system/urlfetcher.py:
1408         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
1409         * Scripts/webkitpy/common/system/zipfileset_mock.py:
1410         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1411         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1412         * Scripts/webkitpy/tool/mocktool.py:
1413
1414 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1415
1416         Reviewed by Eric Seidel.
1417
1418         Clean up of the filesystem-related modules used in webkitpy.
1419         I've added relpath() to the filesystem interface, modified
1420         ospath.relpath() so that it could work with the filesystem
1421         interface, and modified the fileset* routines to use the
1422         filesystem interface consistently.
1423
1424         This patch also adds a close() routine to the fileset routines
1425         to indicate that the caller is done with the fileset. This
1426         allows zipfileset to clean up after itself when it creates
1427         tempfiles to store downloads.
1428
1429         https://bugs.webkit.org/show_bug.cgi?id=53326
1430
1431         * Scripts/webkitpy/common/system/directoryfileset.py:
1432         * Scripts/webkitpy/common/system/fileset.py:
1433         * Scripts/webkitpy/common/system/filesystem.py:
1434         * Scripts/webkitpy/common/system/filesystem_mock.py:
1435         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1436         * Scripts/webkitpy/common/system/ospath.py:
1437         * Scripts/webkitpy/common/system/zipfileset.py:
1438         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1439
1440 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1441
1442         Reviewed by Csaba Osztrogonác.
1443
1444         [Qt][WK2]REGRESSION (r76991): Fix build errors
1445         https://bugs.webkit.org/show_bug.cgi?id=53400
1446
1447         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1448         and remove WebKit2Prefix.h from the build.
1449         * MiniBrowser/qt/MiniBrowser.pro:
1450
1451 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1452
1453         Unreviewed.
1454
1455         [Qt][WK2] Buildfix.
1456
1457         * MiniBrowser/qt/MiniBrowser.pro:
1458
1459 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1460
1461         Reviewed by Adam Roben.
1462         
1463         define NOMINMAX when building ImageDiff, as we do elsewhere.
1464
1465         Add various clampToInt() methods to MathExtras.h
1466         https://bugs.webkit.org/show_bug.cgi?id=52910
1467
1468         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1469
1470 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1471
1472         Reviewed by Darin Adler.
1473
1474         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1475         https://bugs.webkit.org/show_bug.cgi?id=42682
1476
1477         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1478         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1479         (WTR::InjectedBundle::resetLocalSettings):
1480         (WTR::InjectedBundle::didReceiveMessage):
1481         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1482         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1483         (WTR::LayoutTestController::setPOSIXLocale):
1484         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1485
1486 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1487  
1488          Reviewed by Mihai Parparita.
1489  
1490          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1491  
1492          This patch re-enables this test and changes it to
1493          handle all of the mac platform versions, not just the one
1494          it is running on.
1495  
1496          https://bugs.webkit.org/show_bug.cgi?id=53356
1497  
1498          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1499  
1500 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1501
1502         Unreviewed, build fix.
1503
1504         Take two. The fix in 77023 didn't work, because we were
1505         still calling path.abspath_to_uri, which calls _cygpath under
1506         the covers, and it appears the cygpath on the bots does
1507         something different than it does on my machine. This patch
1508         removes the calls to path.abspath_to_uri, so it should be safe.
1509         If it doesn't work, I'll roll it out along with r76982 and 77023.
1510
1511         https://bugs.webkit.org/show_bug.cgi?id=53126
1512
1513         * Scripts/webkitpy/layout_tests/port/test.py:
1514
1515 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1516
1517         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1518         <http://webkit.org/b/53353>
1519
1520         Reviewed by Mark Rowe.
1521
1522         * Scripts/webkitdirs.pm:
1523         (checkRequiredSystemConfig): Check the Xcode marketing version
1524         in addition to the DevCoreTools build version before complaining
1525         about an old version of Xcode.  Also make the Mac OS X version
1526         check use Perl's built-in version string comparitor.
1527
1528 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1529
1530         Unreviewed, build fix.
1531
1532         Work around breakage on Win 7 Release bot caused by r76982
1533         and the fact that windows ports use "file:////" instead of
1534         "file:///". Ideally the test code should be isolated from
1535         this, but it isn't yet. Will fix properly in a bit.
1536
1537         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1538
1539 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1540
1541         Reviewed by Tony Chang.
1542
1543         new-run-webkit-tests: change worker model values to
1544         "old-inline", "old-threads" in preparation for test_runner2 /
1545         multiprocessing changes.
1546
1547         https://bugs.webkit.org/show_bug.cgi?id=53156
1548
1549         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1550         * Scripts/webkitpy/layout_tests/port/base.py:
1551         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1552         * Scripts/webkitpy/layout_tests/port/mac.py:
1553         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1554
1555 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1556
1557         Reviewed by Tony Chang.
1558
1559         committers.py - add an IRC nickname for dpranke
1560         https://bugs.webkit.org/show_bug.cgi?id=53335
1561
1562         * Scripts/webkitpy/common/config/committers.py:
1563
1564 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1565
1566         Reviewed by Tony Chang.
1567
1568         new-run-webkit-tests: add a "mock DRT" port implementation
1569         and a separate class that emulates what we expect the
1570         DumpRenderTree behavior to be.
1571
1572         This will eventually replace port/dryrun.py and allow us to get
1573         better test coverage of the new-run-webkit-tests code as well as
1574         a reference for what new-run-webkit-tests expects from DRT.
1575
1576         This is the first attempt at this, and it is pretty bare-boned. It
1577         really only has been tested on the 'mac' port (and a little on
1578         the 'chromium-mac' port.
1579
1580         https://bugs.webkit.org/show_bug.cgi?id=53126
1581
1582         * Scripts/webkitpy/common/system/filesystem_mock.py:
1583         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1584         * Scripts/webkitpy/layout_tests/port/factory.py:
1585         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1586         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1587         * Scripts/webkitpy/layout_tests/port/test.py:
1588
1589 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1590
1591         Unreviewed. Removing .swp file checked in by mistake.
1592
1593         * Scripts/.webkitdirs.pm.swp: Removed.
1594
1595 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1596
1597         Reviewed by David Kilzer.
1598
1599         Space not necessary for undefined feature
1600         https://bugs.webkit.org/show_bug.cgi?id=53317
1601
1602         * Scripts/build-webkit:
1603
1604 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1605
1606         Reviewed by Andreas Kling.
1607
1608         Reset NetworkAccessManager to clean up credentials from previous tests.
1609         This change causes no performance overhead either.
1610         https://bugs.webkit.org/show_bug.cgi?id=36688
1611
1612         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1613         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1614         (WebCore::DumpRenderTree::open):
1615         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1616
1617 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1618
1619         Reviewed by Andreas Kling.
1620
1621         [Qt] Add Zoom Text Only action to MiniBrowser
1622         https://bugs.webkit.org/show_bug.cgi?id=53297
1623
1624         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1625
1626         * MiniBrowser/qt/BrowserWindow.cpp:
1627         (BrowserWindow::BrowserWindow):
1628         (BrowserWindow::zoomIn):
1629         (BrowserWindow::zoomOut):
1630         (BrowserWindow::resetZoom):
1631         (BrowserWindow::toggleZoomTextOnly):
1632         (BrowserWindow::applyZoom):
1633         * MiniBrowser/qt/BrowserWindow.h:
1634
1635 2011-01-28  Adam Barth  <abarth@webkit.org>
1636
1637         Reviewed by Eric Seidel.
1638
1639         Add webkit-patch roll-chromium-deps
1640         https://bugs.webkit.org/show_bug.cgi?id=53288
1641
1642         This command updates the Source/WebKit/chromium/DEPS file with the
1643         last-known good revision of Chromium (or a revision specified on the
1644         command line).  I'd eventually like to turn this into a SheriffBot
1645         command, but this is the first step.
1646
1647         This patch somewhat sprawled because I needed to move a bunch of code
1648         out of ChangeLog that should never have been there in the first place.
1649         Also, I had to fix a bug in MockUser in order to test the new command.
1650
1651         * Scripts/webkitpy/common/checkout/api.py:
1652         * Scripts/webkitpy/common/checkout/changelog.py:
1653         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1654         * Scripts/webkitpy/common/checkout/deps.py: Added.
1655         * Scripts/webkitpy/common/config/urls.py:
1656         * Scripts/webkitpy/tool/commands/__init__.py:
1657         * Scripts/webkitpy/tool/commands/download_unittest.py:
1658         * Scripts/webkitpy/tool/commands/roll.py: Added.
1659         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1660         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1661         * Scripts/webkitpy/tool/mocktool.py:
1662         * Scripts/webkitpy/tool/steps/__init__.py:
1663         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1664         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1665         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1666         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1667         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1668         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1669
1670 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1671
1672         Reviewed by Laszlo Gombos.
1673
1674         Get rid of prefix header dependency for WebKit2 build system
1675         https://bugs.webkit.org/show_bug.cgi?id=50174
1676
1677         Change the style checker so that it enforces config.h include for
1678         WebKit2.
1679
1680         * Scripts/webkitpy/style/checker.py:
1681
1682 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1683
1684         Reviewed by Darin Adler.
1685
1686         execCommand("Paste") doesn't work in WebKitTestRunner
1687         https://bugs.webkit.org/show_bug.cgi?id=52785
1688
1689         Enable both of the settings needed to allow paste.
1690         
1691         * WebKitTestRunner/TestController.cpp:
1692         (WTR::TestController::resetStateToConsistentValues):
1693
1694 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1695
1696         Reviewed by Andreas Kling.
1697
1698         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1699         https://bugs.webkit.org/show_bug.cgi?id=48440
1700
1701         Preserve user input when toggling use of QGraphicsView
1702
1703         * QtTestBrowser/launcherwindow.cpp:
1704         (LauncherWindow::initializeView):
1705         (LauncherWindow::loadFinished):
1706         * QtTestBrowser/launcherwindow.h:
1707         * QtTestBrowser/mainwindow.cpp:
1708         (MainWindow::addressUrl):
1709         * QtTestBrowser/mainwindow.h:
1710
1711 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1712
1713         Reviewed by Mihai Parparita.
1714
1715         new-run-webkit-tests: turn off pixel tests correctly by default
1716         for webkit-based ports. r70013 (bug 47510) used
1717         port.set_option_default() to attempt to set default values, but
1718         that didn't work correctly. I have removed set_option_default
1719         for now since it was only being used in two places and in three
1720         useless unit tests. There is a separate bug open to fix the
1721         option parsing (48095), so this workaround is fine for now.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=53217
1724
1725         * Scripts/webkitpy/layout_tests/port/webkit.py:
1726         * Scripts/webkitpy/layout_tests/port/base.py:
1727         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1728
1729 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1730
1731         Rubber-stamped by Ariya Hidayat.
1732
1733         Trivial crash fix in WTR.
1734
1735         * WebKitTestRunner/TestController.cpp:
1736         (WTR::TestController::initialize): Increase the size
1737         of the vector by one to be able to store the null character.
1738
1739 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1740
1741         Reviewed by Csaba Osztrogonác.
1742
1743         [Qt][WK2] WTR should be initialized in the same way as DRT
1744         https://bugs.webkit.org/show_bug.cgi?id=53240
1745
1746         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1747         (WTR::activateFonts): Added missing initialization steps.
1748
1749 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1750
1751         Unreviewed. 
1752
1753         Adding myself to committers.py.
1754
1755         * Scripts/webkitpy/common/config/committers.py:
1756
1757 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1758
1759         Reviewed by Csaba Osztrogonác.
1760
1761         [Qt] [Symbian] Move project files into Source
1762         https://bugs.webkit.org/show_bug.cgi?id=52891
1763
1764         Fix the Symbian build after the project files
1765         are moved to Source directory. On Symbian qmake
1766         needs to run in the same directory where the main
1767         pro files (WebKit.pro, Tools.pro) are located.
1768
1769         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1770         is located before running qmake for Symbian. Qmake on Symbian
1771         does not properly honor the "-o" option, work it around by setting
1772         the name of the Makefile to bld.inf.
1773
1774 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1775
1776         Reviewed by Andreas Kling.
1777
1778         [Qt] Add simple zooming features to MiniBrowser
1779         https://bugs.webkit.org/show_bug.cgi?id=53231
1780
1781         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1782
1783         * MiniBrowser/qt/BrowserWindow.cpp:
1784         (BrowserWindow::BrowserWindow):
1785         (BrowserWindow::zoomIn):
1786         (BrowserWindow::zoomOut):
1787         (BrowserWindow::resetZoom):
1788         (BrowserWindow::updateUserAgentList):
1789         (BrowserWindow::applyZoom):
1790         * MiniBrowser/qt/BrowserWindow.h:
1791
1792 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1793
1794         Reviewed by Dan Bernstein.
1795
1796         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1797         https://bugs.webkit.org/show_bug.cgi?id=42319
1798         
1799         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1800
1801         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1802         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1803         (WTR::LayoutTestController::showWebInspector):
1804         (WTR::LayoutTestController::closeWebInspector):
1805         (WTR::LayoutTestController::evaluateInWebInspector):
1806         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1807         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1808         * WebKitTestRunner/TestInvocation.cpp:
1809         (WTR::shouldOpenWebInspector):
1810         (WTR::TestInvocation::invoke):
1811         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1812
1813 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1814
1815         Reviewed by Xan Lopez.
1816
1817         [GTK] Pixel dumps do not include scrollbars in output images
1818         https://bugs.webkit.org/show_bug.cgi?id=53216
1819
1820         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1821         that have scrollbars.
1822
1823         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1824         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1825         instead of the web view itself.
1826
1827 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1828
1829         Reviewed by Mihai Parparita.
1830
1831         Fix regression introduced in r76322 ... new-run-webkit-tests
1832         was attempting to save the image diff output as a UTF-8-encoded
1833         file.
1834
1835         https://bugs.webkit.org/show_bug.cgi?id=53210
1836
1837         * Scripts/webkitpy/layout_tests/port/webkit.py:
1838
1839 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1840
1841         Unreviewed, rolling out r76709.
1842         http://trac.webkit.org/changeset/76709
1843         https://bugs.webkit.org/show_bug.cgi?id=53194
1844
1845         "broke python tests on non-snowleopard platforms" (Requested
1846         by dpranke on #webkit).
1847
1848         * Scripts/webkitpy/layout_tests/port/factory.py:
1849         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1850         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1851
1852 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1853
1854         Reviewed by Tony Chang.
1855
1856         new-run-webkit-tests: add a "mock DRT" port implementation
1857         and a separate class that emulates what we expect the
1858         DumpRenderTree behavior to be.
1859
1860         This will eventually replace port/dryrun.py and allow us to get
1861         better test coverage of the new-run-webkit-tests code as well as
1862         a reference for what new-run-webkit-tests expects from DRT.
1863
1864         This is the first attempt at this, and it is pretty bare-boned. It
1865         really only has been tested on the 'mac' port (and a little on
1866         the 'chromium-mac' port.
1867
1868         https://bugs.webkit.org/show_bug.cgi?id=53126
1869
1870         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1871         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1872         * Scripts/webkitpy/layout_tests/port/factory.py:
1873
1874 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1875
1876         Reviewed by Tony Chang.
1877
1878         Add '--no-timeout' option to Chromium DRT to ease debugging.
1879         https://bugs.webkit.org/show_bug.cgi?id=52873
1880
1881         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1882         (main):
1883
1884 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1885
1886         Reviewed by Andreas Kling.
1887
1888         [Qt] Fix qt_minimal build
1889         https://bugs.webkit.org/show_bug.cgi?id=53172
1890
1891         * QtTestBrowser/locationedit.h:
1892
1893 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1894
1895         Reviewed by Antonio Gomes.
1896
1897         QtTestBrowser should have a UI Setting to disable plugins
1898         https://bugs.webkit.org/show_bug.cgi?id=52408
1899         
1900         Added a new action item named "Disable Plugins"
1901         under the "Settings" menu. 
1902
1903         * QtTestBrowser/launcherwindow.cpp:
1904         (LauncherWindow::createChrome):
1905         (LauncherWindow::togglePlugins):
1906         * QtTestBrowser/launcherwindow.h:
1907
1908 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1909
1910         Reviewed by Adam Barth.
1911
1912         Move main CMakeLists.txt into Source directory
1913         https://bugs.webkit.org/show_bug.cgi?id=52888
1914
1915         * Scripts/webkitdirs.pm:
1916
1917 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1918
1919         Reviewed by Eric Seidel.
1920
1921         Improve label text in submit-to-ews
1922         https://bugs.webkit.org/show_bug.cgi?id=53130
1923
1924         * QueueStatusServer/templates/submittoews.html:
1925
1926 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1927
1928         Reviewed by Antonio Gomes.
1929
1930         QtTestBrowser should have a UI Settings to prevent loading images
1931         https://bugs.webkit.org/show_bug.cgi?id=52409
1932         
1933         Added a new action item named "DisableAutoLoadImages"
1934         under the "Settings" menu 
1935
1936         * QtTestBrowser/launcherwindow.cpp:
1937         (LauncherWindow::createChrome):
1938         (LauncherWindow::toggleAutoLoadImages):
1939         * QtTestBrowser/launcherwindow.h:
1940
1941 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1942
1943         Reviewed by Tony Chang.
1944
1945         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1946         classes, test_expectations.py. This change adds "test-win" and
1947         "test-mac" variants to the test port so that we can better test
1948         rebaselining, and adds a MockUser() object for reuse in testing.
1949
1950         https://bugs.webkit.org/show_bug.cgi?id=53036
1951
1952         * Scripts/webkitpy/common/system/filesystem.py:
1953         * Scripts/webkitpy/common/system/filesystem_mock.py:
1954         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1955         * Scripts/webkitpy/layout_tests/port/factory.py:
1956         * Scripts/webkitpy/layout_tests/port/base.py:
1957         * Scripts/webkitpy/layout_tests/port/test.py:
1958         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1959         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1960         * Scripts/webkitpy/tool/mocktool.py:
1961
1962 2011-01-25  Tony Chang  <tony@chromium.org>
1963
1964         Reviewed by Dimitri Glazkov.
1965
1966         [chromium] remove unused layoutTestController callback
1967         https://bugs.webkit.org/show_bug.cgi?id=53103
1968
1969         This method is used by a test_shell_test, but not needed by DRT.
1970
1971         * DumpRenderTree/chromium/LayoutTestController.cpp:
1972         (LayoutTestController::LayoutTestController):
1973         * DumpRenderTree/chromium/LayoutTestController.h:
1974
1975 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1976
1977         Reviewed by Andreas Kling.
1978
1979         [GTK] Remove 64 bits release bot from the buildbot master
1980         https://bugs.webkit.org/show_bug.cgi?id=52899
1981
1982         Removes the 64 bits release slave from the buildbot configuration,
1983         so that we can use it as an EWS.
1984
1985         * BuildSlaveSupport/build.webkit.org-config/config.json:
1986
1987 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1988
1989         Reviewed by Dan Bernstein.
1990
1991         Implement database quota callback to fix storage tests on WebKit2 bot
1992         https://bugs.webkit.org/show_bug.cgi?id=53064
1993
1994         * WebKitTestRunner/TestController.cpp:
1995         (WTR::exceededDatabaseQuota):
1996         (WTR::TestController::createOtherPage):
1997         (WTR::TestController::initialize):
1998
1999 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2000
2001         Reviewed by Anders Carlsson.
2002
2003         Use designated temp directory for the database for WebKit2
2004         https://bugs.webkit.org/show_bug.cgi?id=53052
2005         
2006         Adopt the new WK2 API for this.
2007
2008         * WebKitTestRunner/TestController.cpp:
2009         (WTR::TestController::libraryPathForTesting):
2010         (WTR::TestController::initialize):
2011         * WebKitTestRunner/TestController.h:
2012         * WebKitTestRunner/mac/TestControllerMac.mm:
2013         (WTR::TestController::platformLibraryPathForTesting):
2014         * WebKitTestRunner/qt/TestControllerQt.cpp:
2015         (WTR::TestController::platformLibraryPathForTesting):
2016         * WebKitTestRunner/win/TestControllerWin.cpp:
2017         (WTR::TestController::platformLibraryPathForTesting):
2018
2019 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2020
2021         Reviewed by Stephanie Lewis.
2022
2023         Add a new Leopard test bot.
2024
2025         * BuildSlaveSupport/build.webkit.org-config/config.json:
2026
2027 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2028
2029         Reviewed by Adam Barth.
2030
2031         Add EFL Builder to core waterfall
2032         https://bugs.webkit.org/show_bug.cgi?id=52704
2033
2034         Add EFL Builder to the core waterfall again.
2035
2036         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2037         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2038
2039 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
2040
2041         Reviewed by Tony Chang.
2042
2043         new-run-webkit-tests fails to start HTTP server if there are proxy settings
2044         https://bugs.webkit.org/show_bug.cgi?id=52872
2045
2046         Force disabling proxy to resolve the problem.
2047
2048         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2049         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2050
2051 2011-01-24  Andreas Kling  <kling@webkit.org>
2052
2053         Reviewed by Darin Adler.
2054
2055         check-webkit-style: Update exemptions following Source/ move.
2056         https://bugs.webkit.org/show_bug.cgi?id=53017
2057
2058         * Scripts/webkitpy/style/checker.py:
2059         * Scripts/webkitpy/style/checker_unittest.py:
2060
2061 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2062
2063         Rubber-stamped by Csaba Osztrogonác.
2064
2065         [Qt] Move project files into Source
2066         https://bugs.webkit.org/show_bug.cgi?id=52891
2067
2068         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
2069
2070 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2071
2072         Reviewed by Yury Semikhatsky.
2073
2074         Web Inspector: Find duplicate strings in localizedStrings.js
2075
2076         https://bugs.webkit.org/show_bug.cgi?id=53005
2077
2078         * Scripts/check-inspector-strings:
2079
2080 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
2081
2082         Reviewed by Andreas Kling.
2083
2084         [Qt] Regroup MiniBrowser's menubar and add open file action
2085         https://bugs.webkit.org/show_bug.cgi?id=53000
2086
2087         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
2088
2089         * MiniBrowser/qt/BrowserWindow.cpp:
2090         (BrowserWindow::BrowserWindow):
2091         (BrowserWindow::openFile):
2092         (BrowserWindow::~BrowserWindow):
2093         * MiniBrowser/qt/BrowserWindow.h:
2094
2095 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
2096
2097         Unreviewed fix after r76496
2098
2099         [Qt] Move project files into Source
2100         https://bugs.webkit.org/show_bug.cgi?id=52891
2101
2102         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
2103         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
2104         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2105
2106 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2107
2108         Reviewed by Csaba Osztrogonác.
2109
2110         [Qt] Move project files into Source
2111         https://bugs.webkit.org/show_bug.cgi?id=52891
2112
2113         * DerivedSources.pro: Renamed from DerivedSources.pro.
2114         * DumpRenderTree/qt/DumpRenderTree.pro:
2115         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2116         * MiniBrowser/DerivedSources.pro:
2117         * MiniBrowser/qt/MiniBrowser.pro:
2118         * QtTestBrowser/QtTestBrowser.pro:
2119         * Scripts/webkitdirs.pm:
2120         * Tools.pro: Added.
2121         * WebKitTestRunner/DerivedSources.pro:
2122         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2123         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2124
2125 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2126
2127         Reviewed by Dan Bernstein.
2128
2129         Beefed up --threaded mode to catch even more kinds of errors.
2130         https://bugs.webkit.org/show_bug.cgi?id=52971
2131
2132         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
2133         context group to force JSC to mark multiple threads. (This used to be
2134         the default, but it changed in SnowLeopard.)
2135         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
2136         to give threading mistakes more chances to show themselves.
2137         (startJavaScriptThreads):
2138         (stopJavaScriptThreads):
2139
2140 2011-01-22  Robert Hogan  <robert@webkit.org>
2141
2142         Reviewed by Andreas Kling.
2143
2144         [Qt] Support layoutTestController.addURLToRedirect()
2145         https://bugs.webkit.org/show_bug.cgi?id=52956
2146
2147         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2148         (LayoutTestController::addURLToRedirect):
2149         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2150
2151 2011-01-22  Robert Hogan  <robert@webkit.org>
2152
2153         Reviewed by Kenneth Rohde Christiansen.
2154
2155         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
2156         https://bugs.webkit.org/show_bug.cgi?id=49802
2157
2158         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2159         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2160         (WebCore::DumpRenderTree::open):
2161
2162 2011-01-21  Adam Barth  <abarth@webkit.org>
2163
2164         Reviewed by Maciej Stachowiak.
2165
2166         Disable mac_unittest.py that fails on some of the Mac bots
2167         https://bugs.webkit.org/show_bug.cgi?id=52947
2168
2169         As noted in the comment, this test does not appear to be correct
2170         because the function this test is testing returns different results
2171         depending on which flavor of Mac the test is run on.  This patch
2172         disable the test.  Hopefully we can re-enable the test once we've
2173         probably insulated the test from its environment.
2174
2175         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2176
2177 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2178
2179         Reviewed by Mihai Parparita.
2180
2181         Fix bug introduced in r76322 that caused NRWT to not actually
2182         read the Skipped files properly.
2183
2184         https://bugs.webkit.org/show_bug.cgi?id=52771
2185
2186         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2187         * Scripts/webkitpy/layout_tests/port/webkit.py:
2188         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2189
2190 2011-01-21  Sam Weinig  <sam@webkit.org>
2191
2192         Reviewed by Geoffrey Sean Garen and Mark Rowe.
2193
2194         WebKitTestRunner needs the HOME environment variable to be set.
2195         <rdar://problem/8896573>
2196
2197         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
2198         it exists.
2199
2200 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2201
2202         Reviewed by Eric Seidel.
2203
2204         Suppress a few remaining integration tests so that none of the
2205         layout_test unit tests ever read from the filesystem or launch
2206         subprocesses that aren't part of the unit tests.
2207
2208         Also fix a minor bug in the printing unit tests that was
2209         incorrectly relying on sys.argv.
2210
2211         https://bugs.webkit.org/show_bug.cgi?id=52863
2212
2213         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2214         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2215         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2216
2217 2011-01-21  Darin Adler  <darin@apple.com>
2218
2219        Fix Mac build.
2220
2221         * MiniBrowser/mac/BrowserWindowController.m:
2222         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
2223
2224 2011-01-20  Darin Adler  <darin@apple.com>
2225
2226         Reviewed by Dan Bernstein.
2227
2228         WebKit2: Implement showModalDialog
2229         https://bugs.webkit.org/show_bug.cgi?id=52855
2230
2231         This fixes WebKitTestRunner to compile, but more work is probably
2232         needed to get it to pass the tests.
2233
2234         * WebKitTestRunner/TestController.cpp:
2235         (WTR::TestController::runModal): Added. Calls through to the
2236         platform-specific version of runModal.
2237         (WTR::TestController::createOtherPage): Changed to be a private
2238         static member function so it can refer to runModal, which is
2239         a private static member function.
2240         (WTR::TestController::initialize): Pass 0 for the runModal
2241         function since we don't need to run the main window modal.
2242         I suspect this is wrong and will need to change.
2243         * WebKitTestRunner/TestController.h: Added declarations for
2244         the functions added above.
2245         * WebKitTestRunner/mac/TestControllerMac.mm:
2246         (WTR::TestController::runModal): Added. Untested implementation.
2247         * WebKitTestRunner/qt/TestControllerQt.cpp:
2248         (WTR::TestController::runModal): Added.
2249         * WebKitTestRunner/win/TestControllerWin.cpp:
2250         (WTR::TestController::runModal): Added.
2251
2252 2011-01-21  Eric Seidel  <eric@webkit.org>
2253
2254         Reviewed by Adam Barth.
2255
2256         Split Host object off from WebKitPatch for easier re-use
2257         https://bugs.webkit.org/show_bug.cgi?id=52284
2258
2259         new-run-webkit-tests and other tools are eventually going to want one of these.
2260         Basically you need to inherit from this class if you want to pretend to be a
2261         self.tool object for Steps/Commands.
2262
2263         * Scripts/webkitpy/common/host.py: Added.
2264         * Scripts/webkitpy/tool/main.py:
2265
2266 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2267
2268         Reviewed by Adam Barth.
2269
2270         Disable the tests that start and stop the http server and web
2271         server, so that we don't have to worry about port collisions on
2272         the bots.
2273
2274         https://bugs.webkit.org/show_bug.cgi?id=52861
2275
2276         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2277
2278 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2279
2280         Reviewed by Eric Seidel.
2281
2282         nrwt: rewrite google_chrome_unittest to use mock filesystem.
2283         
2284         https://bugs.webkit.org/show_bug.cgi?id=52772
2285         
2286         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2287
2288 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2289
2290         Reviewed by Eric Siedel.
2291
2292         nrwt: clean up almost all remaining port references, remove
2293         unnecessary import clauses. The only remaining references are
2294         in places where a mock filesystem makes no sense or can't be
2295         used, and in one routine in port/google_chrome_unittest that
2296         I'll rewrite in a separate patch.
2297
2298         https://bugs.webkit.org/show_bug.cgi?id=52771
2299
2300         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2301         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2302         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2303         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2304         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2305         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2306         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2307         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2308         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2309         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2310         * Scripts/webkitpy/layout_tests/port/gtk.py:
2311         * Scripts/webkitpy/layout_tests/port/mac.py:
2312         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2313         * Scripts/webkitpy/layout_tests/port/qt.py:
2314         * Scripts/webkitpy/layout_tests/port/webkit.py:
2315         * Scripts/webkitpy/layout_tests/port/win.py:
2316         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2317
2318 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2319
2320         Reviewed by Mihai Parparita.
2321
2322         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
2323
2324         https://bugs.webkit.org/show_bug.cgi?id=52762
2325
2326         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2327         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2328
2329 2011-01-20  Tony Chang  <tony@chromium.org>
2330
2331         Reviewed by Ojan Vafai.
2332
2333         [chromium] fix the paths used for the rebaseline tool
2334         https://bugs.webkit.org/show_bug.cgi?id=52857
2335
2336         Some of the bots were renamed so the path to grab the results zip
2337         file has changed.
2338
2339         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2340
2341 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2342
2343         Reviewed by Tony Chang.
2344
2345         Fix bug introduced in r72688 / bug 52768 that broke the
2346         generation of the output filename links in the results.html
2347         output. Apparently none of the unit tests actually checked to
2348         make sure the generated links were correct :(
2349
2350         https://bugs.webkit.org/show_bug.cgi?id=52854
2351
2352         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2353         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2354
2355 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
2356
2357         Reviewed by Darin Adler.
2358
2359         https://bugs.webkit.org/show_bug.cgi?id=52849
2360         Make window.print work with WebKit2
2361
2362         * MiniBrowser/mac/BrowserWindowController.m:
2363         (-[BrowserWindowController awakeFromNib]):
2364         * WebKitTestRunner/TestController.cpp:
2365         (WTR::createOtherPage):
2366         (WTR::TestController::initialize):
2367         Added zeroes to WKPageUIClient structures to avoid build failures.
2368
2369 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2370
2371         Reviewed by Eric Seidel.
2372
2373         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=52756
2376
2377         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2378         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2379         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2380         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2381         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2382         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2383
2384 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
2385
2386         Reviewed by Antonio Gomes.
2387
2388         QtTestBrowser should have a seperate menu for Settings
2389         https://bugs.webkit.org/show_bug.cgi?id=52817
2390         
2391         Added a new menu item named "Settings"
2392         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
2393
2394         * QtTestBrowser/launcherwindow.cpp:
2395         (LauncherWindow::createChrome):
2396
2397 2011-01-20  Sam Weinig  <sam@webkit.org>
2398
2399         Reviewed by John Sullivan.
2400
2401         Update update-webkit-localizable-strings with new path to WebKit.
2402
2403         * Scripts/update-webkit-localizable-strings:
2404
2405 2011-01-20  James Robinson  <jamesr@chromium.org>
2406
2407         Reviewed by Darin Fisher.
2408
2409         Implement mozilla's requestAnimationFrame API
2410         https://bugs.webkit.org/show_bug.cgi?id=51218
2411
2412         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2413
2414         * DumpRenderTree/chromium/WebViewHost.cpp:
2415         (invokeScheduleComposite):
2416         (WebViewHost::scheduleAnimation):
2417         (WebViewHost::paintInvalidatedRegion):
2418         * DumpRenderTree/chromium/WebViewHost.h:
2419
2420 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
2421
2422         Reviewed by Adam Roben.
2423
2424         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
2425         https://bugs.webkit.org/show_bug.cgi?id=42327
2426
2427         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
2428         for methods that take their normal arguments but also a JSContextRef.
2429         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
2430         for evaluateScriptInIsolatedWorld.
2431         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2432         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
2433         this call is for an isolated world.
2434         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2435         (WTR::worldMap): Helper to create a world map.
2436         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
2437         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
2438         added LayoutTestController API.
2439         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2440
2441 2011-01-19  Adam Roben  <aroben@apple.com>
2442
2443         Convert paths in environment variables back to msys-style inside commit-log-editor
2444
2445         When this script gets run from inside git commit, msys-style paths in the environment will
2446         have been turned into Windows-style paths with forward slashes. This screws up functions
2447         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2448         the paths back to msys-style before doing anything else.
2449
2450         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2451         using msysgit's Perl and multiple ChangeLogs have been edited
2452
2453         Reviewed by David Kilzer.
2454
2455         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2456         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2457         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2458
2459 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2460
2461         [Win] Unreviewed build fix after r76248.
2462
2463         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2464
2465 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2466
2467         Reviewed by Csaba Osztrogonác.
2468
2469         Refactoring of the custom allocation framework
2470         https://bugs.webkit.org/show_bug.cgi?id=49897
2471
2472         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2473         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2474         equivalent macro implementation at the necessary places.
2475 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2476
2477         Unreviewed. 
2478
2479         Adding myself to committers.py.
2480
2481         * Scripts/webkitpy/common/config/committers.py:
2482
2483 2011-01-20  Adam Barth  <abarth@webkit.org>
2484
2485         Reviewed by Tony Chang.
2486
2487         Chromium builders don't delete unversioned directories when DEPS change
2488         https://bugs.webkit.org/show_bug.cgi?id=52745
2489
2490         If we pass this option to gclient sync, gclient will delete directories
2491         that are no longer part of DEPS instead of leaving them around to
2492         confuse us later.  Apparently, the downstream buildbots use this option
2493         already.
2494
2495         * Scripts/update-webkit-chromium:
2496
2497 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2498
2499         Unreviewed, build fix - I pulled this patch in to fix an issue
2500         revealed by r76195 running on some new bots). Also fix a couple
2501         of other issues revealed in testing.
2502
2503         nrwt: remove fs refs from layout_package/json*
2504
2505         https://bugs.webkit.org/show_bug.cgi?id=52754
2506
2507         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2508         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2509         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2510         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2511         * Scripts/webkitpy/layout_tests/port/base.py:
2512
2513 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2514
2515         Unreviewed, build fix.
2516
2517         Fix a couple of minor bugs discovered while bringing up new bots
2518         for testing.
2519
2520         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2521         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2522
2523 2011-01-19  James Robinson  <jamesr@chromium.org>
2524
2525         Unreviewed, rolling out r76194.
2526         http://trac.webkit.org/changeset/76194
2527         https://bugs.webkit.org/show_bug.cgi?id=51218
2528
2529         Caused mysterious compile failure on the chromium win
2530         build.webkit.org bots
2531
2532         * DumpRenderTree/chromium/WebViewHost.cpp:
2533         (WebViewHost::paintInvalidatedRegion):
2534         * DumpRenderTree/chromium/WebViewHost.h:
2535
2536 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2537
2538         Reviewed by Mihai Parparita.
2539
2540         remove fs refs from test_runner, dump_render_tree_thread
2541
2542         https://bugs.webkit.org/show_bug.cgi?id=52753
2543
2544         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2545         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2546         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2547         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2548
2549 2011-01-19  James Robinson  <jamesr@chromium.org>
2550
2551         Reviewed by Darin Fisher.
2552
2553         Implement mozilla's requestAnimationFrame API
2554         https://bugs.webkit.org/show_bug.cgi?id=51218
2555
2556         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2557
2558         * DumpRenderTree/chromium/WebViewHost.cpp:
2559         (invokeScheduleComposite):
2560         (WebViewHost::scheduleAnimation):
2561         (WebViewHost::paintInvalidatedRegion):
2562         * DumpRenderTree/chromium/WebViewHost.h:
2563
2564 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2565
2566         Unreviewed, build fix.
2567
2568         Fix a few incorrect "self._filesystem" references introduced in
2569         r76184.
2570
2571         * Scripts/webkitpy/layout_tests/port/chromium.py:
2572         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2573
2574 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2575
2576         Reviewed by Mihai Parparita.
2577
2578         add a .sep property, abspath(), isabs(), mtime(), and
2579         open_text_file_for_writing() to filesystem modules. Some of
2580         these properties are not needed in this patch but will be needed
2581         in subsequent patches (I'm doing this to avoid having to track
2582         multiple versions of a single file).
2583
2584         Also, change most of the port/* modules to use the filesystem
2585         objects instead of referencing the filesystem directly.
2586
2587         https://bugs.webkit.org/show_bug.cgi?id=52748
2588
2589         * Scripts/webkitpy/common/system/filesystem.py:
2590         * Scripts/webkitpy/common/system/filesystem_mock.py:
2591         * Scripts/webkitpy/layout_tests/port/__init__.py:
2592         * Scripts/webkitpy/layout_tests/port/base.py:
2593         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2594         * Scripts/webkitpy/layout_tests/port/chromium.py:
2595         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2596         * Scripts/webkitpy/layout_tests/port/config.py:
2597         * Scripts/webkitpy/layout_tests/port/test.py:
2598         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2599
2600 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2601
2602         Reviewed by Anders Carlsson.
2603
2604         If resetting between tests times out, treat it as a WebProcess crash
2605         https://bugs.webkit.org/show_bug.cgi?id=52757
2606
2607         * WebKitTestRunner/TestController.cpp:
2608         (WTR::TestController::runTest):
2609
2610 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2611
2612         Reviewed by Darin Adler.
2613
2614         https://bugs.webkit.org/show_bug.cgi?id=52739
2615         Make it possible for a WebKit2 client to print headers and footers
2616
2617         Added dummy implementations for new printing UIClient calls.
2618
2619         * MiniBrowser/mac/BrowserWindowController.m:
2620         (-[BrowserWindowController awakeFromNib]):
2621         * WebKitTestRunner/TestController.cpp:
2622         (WTR::createOtherPage):
2623         (WTR::TestController::initialize):
2624
2625 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2626
2627         Reviewed by Ojan Vafai.
2628
2629         Change webkitpy/layout_tests/port/test.py to use the
2630         in-memory filesystem for cleaner unit testing. This
2631         change allows us to kill a lot of code that was
2632         specific to the test port, at the cost of being a
2633         little less clear about how things would work if
2634         you didn't have a filesystem.
2635
2636         https://bugs.webkit.org/show_bug.cgi?id=52605
2637
2638         * Scripts/webkitpy/layout_tests/port/test.py:
2639
2640 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2641
2642         Unreviewed, build fix.
2643
2644         Fix test failure caused by committing attachment 79368 instead
2645         of attachment 79461 on bug 52604.
2646
2647         * Scripts/webkitpy/common/system/filesystem_mock.py:
2648
2649 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2650
2651         Reviewed by Mihai Parparita.
2652
2653         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2654         unit testing. os.walk() is too much of a hassle to implement on
2655         top of the in-memory mock filesystem and adding the necessary
2656         interface to files_under() gives clients a cleaner API anyway
2657         (for this particular usage model).
2658
2659         https://bugs.webkit.org/show_bug.cgi?id=52691
2660
2661         * Scripts/webkitpy/common/system/filesystem.py:
2662         * Scripts/webkitpy/common/system/filesystem_mock.py:
2663         * Scripts/webkitpy/layout_tests/port/test_files.py:
2664         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2665
2666 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2667
2668         Reviewed by Tony Chang.
2669
2670         Change more modules in the layout-tests code to use the
2671         filesystem wrapper for cleaner unit testing.
2672
2673         This patch also adds the glob() wrapper to the filesystem
2674         abstraction.
2675         
2676         https://bugs.webkit.org/show_bug.cgi?id=52604
2677
2678         * Scripts/webkitpy/layout_tests/port/test_files.py:
2679         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2680         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2681         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2682         * Scripts/webkitpy/common/system/filesystem.py:
2683         * Scripts/webkitpy/common/system/filesystem_mock.py:
2684
2685 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2686
2687         Unreviewed.
2688
2689         Updating my email addresses and irc nick.
2690
2691         * Scripts/webkitpy/common/config/committers.py:
2692
2693 2011-01-19  Tony Chang  <tony@chromium.org>
2694
2695         Reviewed by Mihai Parparita.
2696
2697         [chromium] [linux] if check-sys-deps fails, output the failure reason
2698         https://bugs.webkit.org/show_bug.cgi?id=52671
2699
2700         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2701             error handler functions.
2702         * Scripts/webkitpy/layout_tests/port/chromium.py:
2703             output the error text from --check-sys-deps
2704         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2705
2706 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2707
2708         Reviewed by Andreas Kling.
2709
2710         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2711         https://bugs.webkit.org/show_bug.cgi?id=52554
2712         
2713         QtNetworkAccessManager is created in a thread and set as
2714         member variable in QWebPage. When the thread is destroyed
2715         the object is still used. So fix will set the object to
2716         NULL once the thread is destroyed.
2717
2718         * QtTestBrowser/launcherwindow.cpp:
2719         (LauncherWindow::~LauncherWindow):
2720
2721 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2722
2723         Rubber stamped by Csaba Osztrogonac
2724
2725         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2726
2727 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2728
2729         Reviewed by Tony Chang.
2730
2731         new-run-webkit-tests: add a --build-directory command line argument
2732
2733         Official Google Chrome builds use a non-standard build directory
2734         location. This patch adds a --build-directory argument that
2735         allows that location to be specified on the command line. Only
2736         Chromium-based builds will use this flag for now, but anyone can
2737         in the future.
2738
2739         There are no unit tests for this since it's difficult to test
2740         until mock filesystems are fully supported in the code. This was
2741         tested by hand for now.
2742
2743         https://bugs.webkit.org/show_bug.cgi?id=52694
2744
2745         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2746         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2747         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2749
2750 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2751
2752         Not reviewed. Bot fix.
2753
2754         Remove an inadvertently committed debugging print.
2755
2756         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2757         (LayoutTestController::notifyDone):
2758
2759 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2760
2761         Reviewed by Sam Weinig.
2762
2763         WebKitTestRunner should track loading more like DumpRenderTree
2764         https://bugs.webkit.org/show_bug.cgi?id=52692
2765
2766         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2767         This makes some tests that call notifyDone multiple times pass.
2768         
2769         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2770         (WTR::InjectedBundle::InjectedBundle):
2771         (WTR::InjectedBundle::done):
2772         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2773         (WTR::InjectedBundle::topLoadingFrame):
2774         (WTR::InjectedBundle::setTopLoadingFrame):
2775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2776         (WTR::InjectedBundlePage::InjectedBundlePage):
2777         (WTR::InjectedBundlePage::stopLoading):
2778         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2779         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2780         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2781         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2782         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2783         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2784         (WTR::LayoutTestController::notifyDone):
2785         * WebKitTestRunner/TestController.cpp:
2786         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2787
2788 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2789
2790         Reviewed by Kent Tamura.
2791
2792         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2793         https://bugs.webkit.org/show_bug.cgi?id=52678
2794         
2795         Update path now that WebKit is inside Source.
2796
2797         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2798
2799 2011-01-18  Robert Hogan  <robert@webkit.org>
2800
2801         Reviewed by Simon Hausmann.
2802
2803         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2804         https://bugs.webkit.org/show_bug.cgi?id=44282
2805
2806         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2807         (WebCore::DumpRenderTree::dump):
2808
2809 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2810
2811         Reviewed by Mihai Parparita.
2812
2813         Fix a small race condition that could cause the unit tests for
2814         new-run-webkit-tests to fail in a multithreaded environment.
2815         There was a small window in the code where one thread would
2816         check to see if a thread had raised an exception, do something,
2817         and then check to see if the thread was alive. If the other
2818         thread raised an exception and exited in between these two
2819         steps, the exception would be lost. Flipping the order of the
2820         two checks fixes the race, since we will now always check for an
2821         exception on the thread before exiting.
2822
2823         https://bugs.webkit.org/show_bug.cgi?id=51579
2824
2825         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2826
2827 2011-01-18  Eric Seidel  <eric@webkit.org>
2828
2829         Reviewed by Adam Barth.
2830
2831         commit-queue dies when test archiving fails
2832         https://bugs.webkit.org/show_bug.cgi?id=52617
2833
2834         I looked at the machine and it had 10 archives already
2835         thus find_unused_name was returning None.  I've upped
2836         the limit to 100 (per bug) and tested the case where
2837         find_unused_name returns None (making archive return None).
2838
2839         * Scripts/webkitpy/common/system/workspace.py:
2840         * Scripts/webkitpy/common/system/workspace_unittest.py:
2841         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2842         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2843         * Scripts/webkitpy/tool/commands/queues.py:
2844
2845 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2846
2847         Reviewed by Ojan Vafai.
2848
2849         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2850         filesystem. Also fix a couple of "with" statements missed by
2851         r76050.
2852
2853         https://bugs.webkit.org/show_bug.cgi?id=52487
2854
2855         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2856
2857 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2858
2859         Reviewed by Martin Robinson.
2860
2861         [Gtk] Build fixes for gtk3 build
2862         https://bugs.webkit.org/show_bug.cgi?id=52648
2863
2864         * DumpRenderTree/gtk/EventSender.cpp:
2865         (beginDragWithFilesCallback):
2866
2867 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2868
2869         Reviewed by Mihai Parparita.
2870
2871         Update rebaseline-chromium-webkit-tests to use filesystem objects
2872         instead of direct references to os.path, shutil, tempfile, etc.
2873
2874         This patch doesn't change anything, but will allow subsequent
2875         patches to change the unit tests to no longer use the real
2876         filesystem.
2877
2878         This patch adds a bunch more methods to the filesystem object as
2879         well.
2880
2881         https://bugs.webkit.org/show_bug.cgi?id=52482
2882
2883         * Scripts/webkitpy/common/system/filesystem.py:
2884         * Scripts/webkitpy/common/system/filesystem_mock.py:
2885         * Scripts/webkitpy/tool/commands/queues.py:
2886         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2887         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2888
2889 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2890
2891         Reviewed by Mihai Parparita.
2892
2893         new-run-webkit-tests shouldn't crash when you try to run a
2894         directory containing only skipped files.
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=52478
2897         
2898         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2899         * Scripts/webkitpy/layout_tests/port/test.py:
2900         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2901
2902 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2903
2904         Reviewed by Gustavo Noronha Silva.
2905
2906         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2907         https://bugs.webkit.org/show_bug.cgi?id=40833
2908
2909         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2910         GTK+ event sender.
2911         (dragWithFilesDragDataGetCallback): Added.
2912         (dragWithFilesDragEndCallback): Added.
2913         (beginDragWithFilesCallback): Added.
2914
2915 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2916
2917         Reviewed by Adam Barth.
2918
2919         ews: Add additional watcher to efl ews
2920         https://bugs.webkit.org/show_bug.cgi?id=52613
2921
2922         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2923
2924         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2925
2926 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2927
2928         Reviewed by Alexey Proskuryakov.
2929
2930         Fix some headers with missing or misspelled #ifndef guards
2931         https://bugs.webkit.org/show_bug.cgi?id=52545
2932
2933         * DumpRenderTree/chromium/TestEventPrinter.h:
2934         * DumpRenderTree/chromium/WebPreferences.h:
2935
2936 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2937
2938         Reviewed by Anders Carlsson.
2939
2940         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2941         navigating back to an unreachable URL
2942         https://bugs.webkit.org/show_bug.cgi?id=52388
2943
2944         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2945
2946         * DumpRenderTree/LayoutTestController.cpp:
2947         (queueLoadHTMLStringCallback):
2948         (LayoutTestController::queueLoadHTMLString):
2949         (LayoutTestController::queueLoadAlternateHTMLString):
2950         * DumpRenderTree/LayoutTestController.h:
2951
2952         * DumpRenderTree/WorkQueueItem.h:
2953         (LoadHTMLStringItem::LoadHTMLStringItem):
2954
2955         * DumpRenderTree/chromium/LayoutTestController.cpp:
2956         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2957         (WorkItemLoadHTMLString::run):
2958         (LayoutTestController::queueLoadHTMLString):
2959
2960         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2961         (LoadHTMLStringItem::invoke):
2962         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2963         (LoadHTMLStringItem::invoke):
2964         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2965         (LoadHTMLStringItem::invoke):
2966
2967 2011-01-17  Dan Bernstein  <mitz@apple.com>
2968
2969         Rubber-stamped by Mark Rowe.
2970
2971         Update xcodeproj svn:ignore to include xcuserdata.
2972
2973         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2974         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2975         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2976         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2977         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2978
2979 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2980
2981         Unreviewed fix after r75908.
2982
2983         Move WebKit into Source
2984         https://bugs.webkit.org/show_bug.cgi?id=52530
2985
2986         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2987
2988 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2989
2990         Unreviewed.
2991
2992         Remove accidentally committed debug printing after r75908.
2993
2994         * Scripts/webkitdirs.pm:
2995
2996 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2997
2998         Unreviewed.
2999
3000         Add myself to committers list
3001         https://bugs.webkit.org/show_bug.cgi?id=52566
3002
3003         * Scripts/webkitpy/common/config/committers.py:
3004
3005 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3006
3007         Reviewed by Jeremy Orlow.
3008
3009         GeolocationController should call stopUpdating on destruction
3010         https://bugs.webkit.org/show_bug.cgi?id=52216
3011
3012         fast/dom/Geolocation/window-close-crash.html requires that a
3013         Geolocation watch be started in a secondary window. Consequently,
3014         we need to allow geolocation permission and provide a mock
3015         geolocation position for the secondary window's
3016         GeolocationClientMock.
3017
3018         * DumpRenderTree/chromium/LayoutTestController.cpp:
3019         (LayoutTestController::setGeolocationPermission):
3020         (LayoutTestController::setMockGeolocationPosition):
3021         (LayoutTestController::setMockGeolocationError):
3022         * DumpRenderTree/chromium/TestShell.h:
3023         (TestShell::windowList):
3024
3025 2011-01-16  Adam Barth  <abarth@webkit.org>
3026
3027         Update more include paths to reflect WebKit move.
3028
3029         * DumpRenderTree/chromium/EventSender.cpp:
3030         (EventSender::keyDown):
3031         (EventSender::needsShiftModifier):
3032         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3033         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3034
3035 2011-01-16  Kent Tamura  <tkent@chromium.org>
3036
3037         Unreviewed, Chromium build fix.
3038
3039         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
3040
3041 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
3042
3043         Build fix for GTK+ after source directory movement.
3044
3045         * GNUmakefile.am: Correct include paths.
3046
3047 2011-01-16  Adam Barth  <abarth@webkit.org>
3048
3049         Teach svn-apply about WebKit move.
3050
3051         * Scripts/VCSUtils.pm:
3052
3053 2011-01-16  Adam Barth  <abarth@webkit.org>
3054
3055         Rubber-stamped by Eric Seidel.
3056
3057         Move WebKit into Source
3058         https://bugs.webkit.org/show_bug.cgi?id=52530
3059
3060         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3061         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3062         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3063         * DumpRenderTree/qt/GCControllerQt.cpp:
3064         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3065         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3066         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3067         * DumpRenderTree/wscript:
3068         * QtTestBrowser/launcherwindow.h:
3069         * Scripts/build-webkit:
3070         * Scripts/webkitdirs.pm:
3071
3072 2011-01-15  Adam Barth  <abarth@webkit.org>
3073
3074         Teach svn-apply about WebKit2 move.
3075
3076         * Scripts/VCSUtils.pm:
3077
3078 2011-01-15  Adam Barth  <abarth@webkit.org>
3079
3080         Rubber-stamped by Eric Seidel.
3081
3082         Move WebKit2 into Source
3083         https://bugs.webkit.org/show_bug.cgi?id=52438
3084
3085         * MiniBrowser/qt/MiniBrowser.pro:
3086         * Scripts/build-webkit:
3087         * Scripts/do-file-rename:
3088         * Scripts/do-webcore-rename:
3089         * Scripts/test-webkitpy:
3090         * Scripts/webkitdirs.pm:
3091         * Scripts/webkitpy/style/checker.py:
3092         * WebKitTestRunner/DerivedSources.pro:
3093         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3094         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3095
3096 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
3097
3098         Reviewed by David Levin.
3099
3100         [chromium] remove obsolete createView method
3101         https://bugs.webkit.org/show_bug.cgi?id=52437
3102
3103         * DumpRenderTree/chromium/WebViewHost.cpp:
3104         (WebViewHost::createView):
3105         * DumpRenderTree/chromium/WebViewHost.h:
3106
3107 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
3108
3109         Reviewed by Geoff Garen.
3110
3111         ShouldLoadResourceForFrame should use strings, not URLs.
3112         https://bugs.webkit.org/show_bug.cgi?id=52476
3113
3114         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3115         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
3116         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3117
3118 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
3119
3120         Reviewed by David Levin.
3121
3122         Add Tony Gentilcore as a reviewer
3123         https://bugs.webkit.org/show_bug.cgi?id=52480
3124
3125         * Scripts/webkitpy/common/config/committers.py:
3126
3127 2011-01-14  David Levin  <levin@chromium.org>
3128
3129         Reviewed by Eric Seidel.
3130
3131         check-webkit-style: _FunctionState should keep track of where the function name starts.
3132         https://bugs.webkit.org/show_bug.cgi?id=52454
3133
3134         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
3135         _FunctionState and logic for setting it correctly.
3136         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3137
3138 2011-01-14  Vincent Scheib  <scheib@chromium.org>
3139
3140         Reviewed by David Levin.
3141
3142         Add support to DumpRenderTree to use the GPU rather than software renderer
3143         https://bugs.webkit.org/show_bug.cgi?id=52333
3144
3145         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3146         (main):
3147         * Scripts/webkitpy/layout_tests/port/chromium.py:
3148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3149
3150 2011-01-14  Tony Chang  <tony@chromium.org>
3151
3152         Reviewed by Kent Tamura.
3153
3154         [chromium] update fonts.conf to fix 6 linux tests in drt
3155         https://bugs.webkit.org/show_bug.cgi?id=52411
3156
3157         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
3158             chromium's src/webkit/tools/test_shell/resources/fonts.conf
3159
3160 2011-01-14  Eric Seidel  <eric@webkit.org>
3161
3162         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
3163
3164         Reviewed by Adam Barth.
3165
3166         Fix when running Tools/Scripts/check-webkit-style without arguments.
3167         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
3168
3169         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
3170         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3171
3172 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
3173
3174         Reviewed by David Levin.
3175
3176         Store the tempdir object in a variable so it doesn't get deleted too early.
3177         https://bugs.webkit.org/show_bug.cgi?id=51875
3178
3179         * Scripts/update-webkit-auxiliary-libs:
3180         * Scripts/update-webkit-support-libs:
3181
3182 2011-01-14  Eric Seidel  <eric@webkit.org>
3183
3184         Unreviewed.  Make it work in python 2.5.
3185
3186         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3187         https://bugs.webkit.org/show_bug.cgi?id=49158
3188
3189         * Scripts/webkitpy/common/checkout/api_unittest.py:
3190
3191 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3192
3193         Unreviewed, rolling out r75774.
3194         http://trac.webkit.org/changeset/75774
3195         https://bugs.webkit.org/show_bug.cgi?id=52431
3196
3197         gtk builds were broken (Requested by loislo2 on #webkit).
3198
3199         * Scripts/webkitpy/common/checkout/scm.py:
3200
3201 2011-01-14  David Levin  <levin@chromium.org>
3202
3203         Reviewed by Shinichiro Hamaji.
3204
3205         check-webkit-style: _FunctionState should detect pure functions.
3206         https://bugs.webkit.org/show_bug.cgi?id=52428
3207
3208         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
3209         is a pure virtual function.
3210         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
3211         virtual functions are correctly detected.
3212
3213 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
3214
3215         Reviewed by Yury Semikhatsky.
3216
3217         Just small fix for problem with check-webkit-style.
3218         It just didn't work for this patch.
3219         Old code can't concatenate a list of strings with None.
3220
3221         * Scripts/webkitpy/common/checkout/scm.py:
3222
3223 2011-01-13  David Levin  <levin@chromium.org>
3224
3225         Reviewed by Shinichiro Hamaji.
3226
3227         check-webkit-style: _FunctionState should use Position to know where items are.
3228         https://bugs.webkit.org/show_bug.cgi?id=52424
3229
3230         * Scripts/webkitpy/style/checkers/cpp.py:
3231         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
3232         (detect_functions): Changed to pass Position's to _FunctionState.begin and
3233         did some minor clean-up.
3234         (*): Other changes are simply about converting to use the Position's in_FunctionState
3235         instead of line numbers.
3236         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
3237         to verify the positions stored in _FunctionState.
3238
3239 2011-01-13  Eric Seidel  <eric@webkit.org>
3240
3241         Reviewed by David Levin.
3242
3243         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3244         https://bugs.webkit.org/show_bug.cgi?id=49158
3245
3246         This is not the most elegant, but it is a very safe fix to this bug.
3247         One advantage of catching ScriptError like this instead of adding a
3248         new added_or_modified_files or fixing all changed_files callers
3249         to use a more specific change_files variant, is that we catch
3250         all kinds of ScriptErrors which might cause our (non-essential)
3251         suggest-reviewers code to fail out.  This should make passing
3252         --suggest-reviewers to webkit-patch upload much more robust
3253         and may even make it possible for us to make it default.
3254
3255         The root of the problem here is that SCM.changed_files includes
3256         deleted ChangeLog paths (from moves, etc) which then when we ask
3257         SVN/Git for the contents of the file at that revision, the command
3258         errors out and Executive.run_command raises a ScriptError.
3259
3260         In the future we might fix this differently by making all current
3261         callers of chagned_files use a more specific method for requesting
3262         what types of changes they're interested in (adds, modifies, deletes, etc.)
3263
3264         * Scripts/webkitpy/common/checkout/api.py:
3265         * Scripts/webkitpy/common/checkout/api_unittest.py:
3266
3267 2011-01-13  Dan Bernstein  <mitz@apple.com>
3268
3269         Reviewed by Alexey Proskuryakov.
3270
3271         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
3272         https://bugs.webkit.org/show_bug.cgi?id=52419
3273
3274         Allow to further control the behavior of the willSendRequest delegate callback by making it
3275         set a different URL in the new request.
3276
3277         * DumpRenderTree/LayoutTestController.cpp:
3278         (addURLToRedirectCallback): Added.
3279         (LayoutTestController::staticFunctions): Added addURLToRedirect.
3280         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
3281         (LayoutTestController::redirectionDestinationForURL): Added this getter.
3282         * DumpRenderTree/LayoutTestController.h:
3283         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3284         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
3285         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
3286         change the URL in the new request to the redirect destination.
3287
3288 2011-01-13  Eric Seidel  <eric@webkit.org>
3289
3290         Reviewed by Mihai Parparita.
3291
3292         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
3293         https://bugs.webkit.org/show_bug.cgi?id=52416
3294
3295         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
3296         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
3297
3298         I also added FIXMEs about the changed_files returning deleted files problem
3299         which is causing the other most common exception for suggest-reviewers
3300         (and is probably breaking sheriff-bots blame detection).
3301
3302         * Scripts/webkitpy/common/checkout/api.py:
3303         * Scripts/webkitpy/common/checkout/api_unittest.py:
3304         * Scripts/webkitpy/common/checkout/scm.py:
3305
3306 2011-01-13  Eric Seidel  <eric@webkit.org>
3307
3308         Reviewed by Adam Barth.
3309
3310         results archives from commit-queue are too large to upload
3311         https://bugs.webkit.org/show_bug.cgi?id=52405
3312
3313         * Scripts/webkitpy/common/system/filesystem.py:
3314         * Scripts/webkitpy/common/system/filesystem_mock.py:
3315         * Scripts/webkitpy/tool/commands/queues.py:
3316
3317 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
3318
3319         Reviewed by Martin Robinson.
3320
3321         [gtk] Zero-sized font does not yet work
3322         https://bugs.webkit.org/show_bug.cgi?id=49793
3323
3324         Set minimum-font-size to 0 for the DRT.
3325
3326         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3327         (resetDefaultsToConsistentValues):
3328
3329 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3330
3331         Reviewed by Darin Adler.
3332
3333         Make old-run-webkit-tests more robust on buildbots
3334         https://bugs.webkit.org/show_bug.cgi?id=52364
3335
3336         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
3337
3338 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3339
3340         Reviewed by Darin Adler.
3341
3342         Make old-run-webkit-tests more robust on buildbots
3343         https://bugs.webkit.org/show_bug.cgi?id=52364
3344
3345         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
3346
3347 2011-01-13  Tony Chang  <tony@chromium.org>
3348
3349         Reviewed by Kent Tamura.
3350
3351         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
3352         https://bugs.webkit.org/show_bug.cgi?id=52332
3353
3354         Forked Info.plist is not longer needed.
3355
3356         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
3357
3358 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
3359
3360         Reviewed by Timothy Hatcher.
3361
3362         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
3363         to be passed directly to WebInspector.UIString
3364
3365         https://bugs.webkit.org/show_bug.cgi?id=52365
3366
3367         * Scripts/check-inspector-strings:
3368
3369 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3370
3371         Unreviewed, rolling out r74881.
3372         http://trac.webkit.org/changeset/74881
3373         https://bugs.webkit.org/show_bug.cgi?id=52357
3374
3375         The EFL builder has been red for days (Requested by abarth on
3376         #webkit).
3377
3378         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3379         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3380
3381 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3382
3383         Reviewed by David Levin.
3384
3385         Add beforeunload support to WebKitTestRunner
3386         https://bugs.webkit.org/show_bug.cgi?id=52353
3387         
3388         This makes a number of currently failing tests pass.
3389
3390         * WebKitTestRunner/TestController.cpp:
3391         (WTR::runBeforeUnloadConfirmPanel):
3392         (WTR::createOtherPage):
3393         (WTR::TestController::initialize):
3394
3395 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3396
3397         Reviewed by Sam Weinig.
3398
3399         Detect, identify and recover from WebProcess crashes in run-webkit-tests
3400         https://bugs.webkit.org/show_bug.cgi?id=52330
3401
3402         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
3403         a web process crash.
3404         * WebKitTestRunner/TestController.cpp:
3405         (WTR::TestController::initialize): Set up a processDidCrash
3406         callback.
3407         (WTR::TestController::processDidCrash): Report that the Web process
3408         crashed.
3409         * WebKitTestRunner/TestController.h:
3410
3411 2011-01-12  David Levin  <levin@chromium.org>
3412
3413         Reviewed by Shinichiro Hamaji.
3414
3415         check-webkit-style -- close_expression function doesn't work correctly.
3416         https://bugs.webkit.org/show_bug.cgi?id=52272
3417
3418         * Scripts/webkitpy/style/checkers/cpp.py:
3419         (Position.__str__): Added a way to convert it to a string which is useful in tests.
3420         (Position.__cmp__): Added a way to compare Position which is useful in tests and
3421         generally useful (for upcoming code changes).
3422         (close_expression): Changed to use Position for input and output.
3423         Also, fixed many bugs such as only working correctly for parenthesis,
3424         not working correctly if given an offset in a line and not finding
3425         the real closing element if there were multiple closing elements in
3426         the same line.
3427         (detect_functions): Adjusted due to the change in arguments for
3428         close_expression.
3429         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3430         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
3431         two positions are the same.
3432         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
3433         (CppStyleTest.test_close_expression): Added tests to catch the issues
3434         that were fixed.
3435
3436 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3437
3438         Unreviewed, rolling out r75576.
3439         http://trac.webkit.org/changeset/75576
3440         https://bugs.webkit.org/show_bug.cgi?id=52304
3441
3442         broke rebaseline-chromium-webkit-test (Requested by thakis on
3443         #webkit).
3444
3445         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3446         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3447         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3448         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3449         * Scripts/webkitpy/layout_tests/port/base.py:
3450         * Scripts/webkitpy/layout_tests/port/chromium.py:
3451         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3452         * Scripts/webkitpy/layout_tests/port/test.py:
3453         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3454         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3455         * Scripts/webkitpy/style/checkers/test_expectations.py:
3456         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3457
3458 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3459
3460         Reviewed by Darin Adler.
3461
3462         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3463         https://bugs.webkit.org/show_bug.cgi?id=52307
3464
3465         * Scripts/old-run-webkit-tests:
3466
3467 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3468
3469         Reviewed by Martin Robinson.
3470
3471         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3472         https://bugs.webkit.org/show_bug.cgi?id=50867
3473
3474         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3475         TestNetscapePlugin.cpp 
3476
3477         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3478         * Scripts/webkitdirs.pm:
3479
3480 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3481
3482         Reviewed by Pavel Feldman.
3483
3484         Add check-inspector-strings script.
3485
3486         https://bugs.webkit.org/show_bug.cgi?id=52295
3487
3488         * Scripts/check-inspector-strings: Added.
3489
3490 2011-01-12  Adam Roben  <aroben@apple.com>
3491
3492         Advertise the .testnetscape file extension on Windows
3493
3494         Fixes <http://webkit.org/b/52298>
3495         plugins/no-mime-with-valid-extension.html fails on Windows
3496
3497         Reviewed by Dan Bernstein.
3498
3499         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3500         FileExtents field to map the .testnetscape file extension to the
3501         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3502
3503 2011-01-12  Adam Barth  <abarth@webkit.org>
3504
3505         Reviewed by Eric Seidel.
3506
3507         Make webkit-patch support subdirectories for SVN checkouts
3508         https://bugs.webkit.org/show_bug.cgi?id=52261
3509
3510         os.relpath does not exist on Python 2.5, so we need to call our version
3511         of the API.
3512
3513         * Scripts/webkitpy/common/checkout/scm.py:
3514
3515 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3516
3517         Reviewed by Eric Seidel.
3518
3519         Close additional pages opened during a test once the test completes.
3520         https://bugs.webkit.org/show_bug.cgi?id=52276
3521
3522         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3523         (WTR::InjectedBundle::done):
3524
3525 2011-01-11  David Levin  <levin@chromium.org>
3526
3527         Reviewed by Eric Seidel.
3528
3529         Errors should be separated from the command line in bot messages.
3530         https://bugs.webkit.org/show_bug.cgi?id=52275
3531
3532         * Scripts/webkitpy/common/system/executive.py:
3533         (ScriptError.message_with_output): Added a newline to separate the command
3534         line from the errors.
3535         * Scripts/webkitpy/common/system/executive_unittest.py:
3536         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3537         paths in message_with_output.
3538
3539 2011-01-11  Eric Seidel  <eric@webkit.org>
3540
3541         Unreviewed.
3542
3543         commit-queue should know how to upload archived results (for test flakes or general failures)
3544         https://bugs.webkit.org/show_bug.cgi?id=52048
3545
3546         The zips are mostly empty due to forgetting -r.
3547         Expected diffs were not being pulled from the archive due
3548         to the archive having longer paths than I realized.
3549
3550         * Scripts/webkitpy/common/system/workspace.py:
3551         * Scripts/webkitpy/common/system/workspace_unittest.py:
3552         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3553         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3554
3555 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3556
3557         Reviewed by Ojan Vafai.
3558
3559         The current modifier parsing code in test_expectations is
3560         fragile and hard-coded, so it's not easy to understand the logic
3561         or easily add new types of modifiers (like GPU vs. CPU testing
3562         for graphics tests, or 32-bit vs. 64-bit differences).
3563
3564         This is the first of two patches that will add in more generic
3565         support and then eliminate the GPU-specific test expectations
3566         files for Chromium.
3567
3568         This patch adds two standalone objects for handling modifiers. The
3569         rules for interpreting modifiers, precedence, and conflicts are
3570         given in the docstring to the ModifierMatcher class, which
3571         returns ModifierMatchResult objects.
3572         
3573         This patch also adds routines to the Port interface and a
3574         default set of values in the base object, in order to obtain the
3575         values needed on a given test run. These values are then passed
3576         to the expectation parser. This also allows us to clean up the
3577         logic used to lint all of the different configurations in a
3578         single test_expectations.txt file.
3579
3580         The next patch will merge in the separate GPU expectations file.
3581
3582         https://bugs.webkit.org/show_bug.cgi?id=51222
3583
3584         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3585         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3586         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3587         * Scripts/webkitpy/layout_tests/port/base.py:
3588         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3589         * Scripts/webkitpy/layout_tests/port/chromium.py:
3590         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3591         * Scripts/webkitpy/layout_tests/port/test.py:
3592         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3593         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3594
3595 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3596
3597         Reviewed by Adam Barth.
3598
3599         Make webkit-patch support subdirectories for SVN checkouts
3600         https://bugs.webkit.org/show_bug.cgi?id=52261
3601
3602         * Scripts/webkitpy/common/checkout/scm.py:
3603         * Scripts/webkitpy/style_references.py:
3604         * Scripts/webkitpy/tool/main.py:
3605         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3606
3607 2011-01-11  Eric Seidel  <eric@webkit.org>
3608
3609         Unreviewed.
3610
3611         commit-queue should know how to upload archived results (for test flakes or general failures)
3612         https://bugs.webkit.org/show_bug.cgi?id=52048
3613
3614         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3615         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3616
3617         * Scripts/webkitpy/common/system/workspace.py:
3618         * Scripts/webkitpy/common/system/workspace_unittest.py:
3619         * Scripts/webkitpy/tool/commands/queues.py:
3620
3621 2011-01-11  Sam Weinig  <sam@webkit.org>
3622
3623         Roll r75474 back in.
3624
3625 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3626
3627         Reviewed by Kenneth Rohde Christiansen.
3628
3629         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3630         https://bugs.webkit.org/show_bug.cgi?id=51204
3631
3632         * QtTestBrowser/webpage.h:
3633         (QtNAMThread::QtNAMThread):
3634         (QtNAMThread::networkAccessManager):
3635         (QtNAMThread::run):
3636
3637 2011-01-11  Peter Varga  <pvarga@webkit.org>
3638
3639         Unreviewed.
3640
3641         Add myself to committers' list.
3642
3643         * Scripts/webkitpy/common/config/committers.py:
3644
3645 2011-01-11  Eric Seidel  <eric@webkit.org>
3646
3647         Reviewed by Adam Barth.
3648
3649         commit-queue should know how to upload archived results (for test flakes or general failures)
3650         https://bugs.webkit.org/show_bug.cgi?id=52048
3651
3652         Now the queue will always upload results.  Either the entire zip, or just
3653         the diffs.txt in the case of text failures.
3654
3655         This should make understanding flakes much easier, and paves the way
3656         for having the EWS run layout tests (and upload failures).
3657
3658         In order to upload .zip files I had to teach bugzilla.py to autodetect
3659         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3660         for .patch files, I have it add one before calling guess_type.
3661
3662         We may find that always uploading the whole zip instead of just the -diffs.txt
3663         file is preferable, but for now I'm keeping the old behavior because it makes
3664         quickly understanding text failures easy.
3665
3666         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3667         * Scripts/webkitpy/common/system/workspace.py: Added.
3668         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3669         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3670         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3671         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3672         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3673         * Scripts/webkitpy/tool/commands/queues.py:
3674         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3675
3676 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3677
3678         Unreviewed, rolling out r75464.
3679         http://trac.webkit.org/changeset/75464
3680         https://bugs.webkit.org/show_bug.cgi?id=52193
3681
3682         Followup rollout for 75474 (Requested by Ossy on #webkit).
3683
3684         * MiniBrowser/mac/BrowserWindowController.m:
3685         (-[BrowserWindowController awakeFromNib]):
3686         * MiniBrowser/win/BrowserView.cpp:
3687         (BrowserView::create):
3688         * WebKitTestRunner/TestController.cpp:
3689         (WTR::createOtherPage):
3690         (WTR::TestController::initialize):
3691
3692 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3693
3694         Reviewed by Csaba Osztrogonác.
3695
3696         [Qt] Baseline qt_minimal configuration
3697         https://bugs.webkit.org/show_bug.cgi?id=51313
3698
3699         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3700         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3701         QT_NO_UNDOSTACK guard.
3702
3703         * QtTestBrowser/launcherwindow.cpp:
3704         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3705         guards.
3706         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3707         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3708         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3709         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3710
3711         * QtTestBrowser/launcherwindow.h:
3712         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3713         * QtTestBrowser/locationedit.h: Ditto.
3714
3715         * QtTestBrowser/mainwindow.cpp:
3716         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3717         QT_NO_UNDOSTACK guards.
3718         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3719         (MainWindow::changeLocation): Ditto.
3720         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3721         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3722
3723         * QtTestBrowser/webpage.cpp:
3724         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3725         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3726
3727         * QtTestBrowser/webview.cpp:
3728         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3729         (WebViewGraphicsBased::animatedYFlip): Ditto.
3730
3731 2011-01-10  Sam Weinig  <sam@webkit.org>
3732
3733         Fix build.
3734
3735         * MiniBrowser/mac/BrowserWindowController.m:
3736         (-[BrowserWindowController awakeFromNib]):
3737         * MiniBrowser/win/BrowserView.cpp:
3738         (BrowserView::create):
3739         * WebKitTestRunner/TestController.cpp:
3740         (WTR::createOtherPage):
3741         (WTR::TestController::initialize):
3742
3743 2011-01-10  Eric Seidel  <eric@webkit.org>
3744
3745         Reviewed by Ojan Vafai.
3746
3747         style-queue messages are way too long for big patches
3748         https://bugs.webkit.org/show_bug.cgi?id=52161
3749
3750         We definitely could build much fancier list-to-string-with-limit functions
3751         but this should be sufficient for our needs at the moment.
3752
3753         * Scripts/webkitpy/common/system/executive.py:
3754         * Scripts/webkitpy/common/system/executive_unittest.py:
3755
3756 2011-01-10  Tony Chang  <tony@chromium.org>
3757
3758         Unreviewed, rolling out r75398.
3759         http://trac.webkit.org/changeset/75398
3760         https://bugs.webkit.org/show_bug.cgi?id=52008
3761
3762         Some layout tests are crashing on Chromium Win.
3763
3764         * DumpRenderTree/chromium/WebViewHost.cpp:
3765         (WebViewHost::updatePaintRect):
3766         * DumpRenderTree/chromium/WebViewHost.h:
3767
3768 2011-01-10  Adam Roben  <aroben@apple.com>
3769
3770         Roll out r75392
3771
3772         It isn't needed now that r75289 has been rolled out.
3773
3774         * Scripts/run-javascriptcore-tests:
3775
3776 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3777
3778         Reviewed by Anders Carlsson.
3779
3780         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3781         https://bugs.webkit.org/show_bug.cgi?id=52160
3782
3783         * WebKitTestRunner/mac/TestControllerMac.mm:
3784         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3785         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3786         anyway.
3787
3788 2011-01-10  Tony Chang  <tony@chromium.org>
3789
3790         Reviewed by Mihai Parparita.
3791
3792         [chromium] fix for animated gif layout tests
3793         https://bugs.webkit.org/show_bug.cgi?id=52008
3794
3795         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3796             to trigger gif animations.
3797         (WebViewHostPaintTask::WebViewHostPaintTask):
3798         (WebViewHostPaintTask::runIfValid):
3799         (WebViewHost::updatePaintRect):
3800         * DumpRenderTree/chromium/WebViewHost.h:
3801         (WebViewHost::taskList):
3802
3803 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3804
3805         Reviewed by Xan Lopez.
3806
3807         [GTK] Fix gtk2 compilation for master
3808         https://bugs.webkit.org/show_bug.cgi?id=51885
3809
3810         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3811         (createBitmapContextFromWebView): Replaced the old
3812         gdk_drawable_get_size with gdk_pixmap_get_size.
3813
3814 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3815
3816         Reviewed by Laszlo Gombos.
3817
3818         [WINCE] Reenable NPAPI after r75203
3819         https://bugs.webkit.org/show_bug.cgi?id=52109
3820
3821         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3822         it with !isEfl(), because EFL port does not support NPAPI (yet).
3823
3824         * Scripts/build-webkit:
3825
3826 2011-01-10  Adam Roben  <aroben@apple.com>
3827
3828         Skip some asserting JS tests
3829
3830         See <http://webkit.org/b/52156>.
3831
3832         * Scripts/run-javascriptcore-tests:
3833
3834 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3835
3836         Reviewed by Xan Lopez.
3837
3838         [GTK] build-webkit disable Blob support via arguments passed to automake
3839         https://bugs.webkit.org/show_bug.cgi?id=52097
3840
3841         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3842         build-webkit.
3843
3844 2011-01-10  Adam Roben  <aroben@apple.com>
3845
3846         Use the same name and description for TestNetscapePlugin on Windows and
3847         Mac
3848
3849         Fixes <http://webkit.org/b/52151>
3850         fast/frames/iframe-reparenting-plugins.html fails on Windows
3851
3852         Reviewed by Steve Falkenburg.
3853
3854         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3855         the name and description from Mac's Info.plist.
3856
3857 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3858
3859         Reviewed by Laszlo Gombos.
3860
3861         [Qt][WK2] Guard gcc-specific syntax
3862
3863         Non-gcc based compliers choke on the "-include"
3864         syntax for preinclude, place guard around it.
3865
3866         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3867         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3868
3869 2011-01-10  Andreas Kling  <kling@webkit.org>
3870
3871         Reviewed by Simon Hausmann.
3872
3873         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3874         https://bugs.webkit.org/show_bug.cgi?id=52111
3875
3876         When getting a createNewPage() callback from QWKPage, create the
3877         new page with the same QWKContext as the page that is passed to
3878         the callback.
3879
3880         * MiniBrowser/qt/BrowserView.h:
3881         * MiniBrowser/qt/BrowserWindow.cpp:
3882         (newPageFunction):
3883         (BrowserWindow::BrowserWindow):
3884         * MiniBrowser/qt/BrowserWindow.h:
3885
3886 2011-01-10  Andreas Kling  <kling@webkit.org>
3887
3888         Reviewed by Kenneth Rohde Christiansen.
3889
3890         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3891
3892         BrowserView set its own useless createNewPage() callback on QWKPage.
3893         This was immediately overridden by BrowserWindow anyway, so remove
3894         the BrowserView one.
3895
3896         * MiniBrowser/qt/BrowserView.cpp:
3897         (BrowserView::BrowserView):
3898
3899 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3900
3901         Reviewed by Jeremy Orlow.
3902
3903         [Chromium] Remove non-client-based Geolocation code
3904         https://bugs.webkit.org/show_bug.cgi?id=50921
3905
3906         * DumpRenderTree/chromium/LayoutTestController.cpp:
3907         (LayoutTestController::setGeolocationPermission):
3908         (LayoutTestController::setMockGeolocationPosition):
3909         (LayoutTestController::setMockGeolocationError):
3910         * DumpRenderTree/chromium/WebViewHost.cpp:
3911         (WebViewHost::geolocationClientMock):
3912         (WebViewHost::reset):
3913         * DumpRenderTree/chromium/WebViewHost.h:
3914
3915 2011-01-10  Eric Seidel  <eric@webkit.org>
3916
3917         Reviewed by Adam Barth.
3918
3919         Commit bot tried to land r? cq+ patch
3920         https://bugs.webkit.org/show_bug.cgi?id=36638
3921
3922         It should now be possible to post a patch with r? and cq+ and the
3923         commit-queue will correctly wait for the r+ before attempting to land the patch.
3924         (This was a feature requested by several users.)
3925
3926         One caveat: We don't actually reject r-, cq+ patches from the queue
3927         (we just ignore them), but I think that's OK for now.
3928
3929         I also noticed that setting r- once a commit-queue node had grabbed
3930         a patch would not properly cancel the landing.  That's fixed and
3931         tested in this patch.
3932
3933         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3934         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3935         * Scripts/webkitpy/tool/bot/feeders.py:
3936         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3937
3938 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3939
3940         Reviewed by Kenneth Rohde Christiansen.
3941
3942         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3943         https://bugs.webkit.org/show_bug.cgi?id=51934
3944
3945         When accessing the network from the destructor of QWebPage, the network access manager
3946         was already deleted because the object WebPage was already destructed.
3947
3948         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3949         The object is now destructed in the destructor of QObject.
3950
3951         * QtTestBrowser/webpage.cpp:
3952         (WebPage::WebPage):
3953         (WebPage::setQnamThreaded):
3954         * QtTestBrowser/webpage.h:
3955         (QtNAMThread::QtNAMThread):
3956
3957 2011-01-08  Eric Seidel  <eric@webkit.org>
3958
3959         Reviewed by Ojan Vafai.
3960
3961         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3962         https://bugs.webkit.org/show_bug.cgi?id=52067
3963
3964         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3965         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3966
3967         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3968
3969 2011-01-08  Eric Seidel  <eric@webkit.org>
3970
3971         Reviewed by Mihai Parparita.
3972
3973         commit-queue hangs when the ChangeLog diff is bad
3974         https://bugs.webkit.org/show_bug.cgi?id=52072
3975
3976         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3977         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3978
3979 2011-01-08  Adam Barth  <abarth@webkit.org>
3980
3981         Teach svn-apply how to re-write WebCore to Source/WebCore.
3982
3983         * Scripts/VCSUtils.pm:
3984
3985 2011-01-07  Adam Barth  <abarth@webkit.org>
3986
3987         Rubber-stamped by Eric Seidel.
3988
3989         Move WebCore to Source
3990         https://bugs.webkit.org/show_bug.cgi?id=52050
3991
3992         Update the tools to understand WebCore's new location.
3993
3994         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3995         * DumpRenderTree/wscript:
3996         * GNUmakefile.am:
3997         * Scripts/build-webkit:
3998         * Scripts/do-file-rename:
3999         * Scripts/do-webcore-rename:
4000         * Scripts/generate-qt-inspector-resource:
4001         * Scripts/prepare-ChangeLog:
4002         * Scripts/run-bindings-tests:
4003         * Scripts/update-iexploder-cssproperties:
4004         * Scripts/update-sources-list.py:
4005         * Scripts/update-webkit-localizable-strings:
4006         * Scripts/webkitdirs.pm:
4007         * Scripts/webkitpy/common/config/build.py:
4008         * Scripts/webkitpy/common/config/build_unittest.py:
4009         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
4010         * Scripts/webkitpy/style/checker.py:
4011         * Scripts/webkitpy/style/checker_unittest.py:
4012         * WebKitTestRunner/DerivedSources.pro:
4013         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4014         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
4015         * wx/browser/wscript:
4016         * wx/build/settings.py:
4017
4018 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
4019
4020         Reviewed by Sam Weinig.
4021
4022         Make WebKitTestRunner rest between loads more robust to avoid test crashes
4023         https://bugs.webkit.org/show_bug.cgi?id=52086
4024
4025         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4026         (WTR::InjectedBundle::didReceiveMessage):
4027         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4028         (WTR::LayoutTestController::notifyDone):
4029         * WebKitTestRunner/TestController.cpp:
4030         (WTR::TestController::resetStateToConsistentValues):
4031         (WTR::TestController::run):
4032
4033 2011-01-07  James Robinson  <jamesr@chromium.org>
4034
4035         Revert "Implement mozilla's animationTime property"
4036         https://bugs.webkit.org/show_bug.cgi?id=51952
4037
4038         This approach isn't quite right.
4039
4040         * DumpRenderTree/chromium/WebViewHost.cpp:
4041         (WebViewHost::paintInvalidatedRegion):
4042
4043 2011-01-07  Adam Roben  <aroben@apple.com>
4044
4045         Build master fix
4046
4047         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4048         (RunWebKitTests.start): Don't try to concatenate a list and a string.
4049
4050 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
4051
4052         Reviewed by Csaba Osztrogonác.
4053
4054         run-qtwebkit-tests should be able to kill a testsuite.
4055
4056         Add new option in the script that can setup a timeout for a test.
4057         If the test execution takes more then specified time then the test
4058         would be terminated.
4059
4060         [Qt] run-qtwebkit-tests needs timeout
4061         https://bugs.webkit.org/show_bug.cgi?id=51894
4062
4063         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4064         * Scripts/run-qtwebkit-tests:
4065
4066 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
4067
4068         Unreviewed fix after r75233.
4069
4070         Based on idea from Eric Seidel.
4071
4072         Add remote zip file handling to webkitpy.
4073         https://bugs.webkit.org/show_bug.cgi?id=50901
4074
4075         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
4076
4077 2011-01-07  Shane Stephens  <shanestephens@google.com>
4078
4079         Reviewed by Eric Seidel.
4080
4081         svn-apply: should support git binary delta diffs
4082         https://bugs.webkit.org/show_bug.cgi?id=38864
4083
4084         * Scripts/VCSUtils.pm:
4085         * Scripts/svn-apply:
4086
4087 2011-01-06  Julie Parent  <jparent@chromium.org>
4088
4089         Reviewed by Eric Seidel.
4090
4091         Test Result Server not removing old results.
4092         https://bugs.webkit.org/show_bug.cgi?id=52012
4093
4094         * TestResultServer/model/jsonresults.py:
4095         Fix off-by-one: Truncate if >= num_runs, not just >.
4096         * TestResultServer/model/jsonresults_unittest.py:
4097         Add unit test to test that merging in a new result with the same value
4098         as the last result causes previous result to fall off.
4099
4100 2011-01-06  James Kozianski  <koz@chromium.org>
4101
4102         Reviewed by Mihai Parparita.
4103
4104         Add classes to provide a consistent interface to a set of files.
4105         https://bugs.webkit.org/show_bug.cgi?id=50901
4106
4107         These classes allow us to write code that is agnostic to whether a
4108         particular set of files resides in a local directory or in a zip file
4109         on a remote machine.
4110
4111         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
4112         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
4113         * Scripts/webkitpy/common/system/fileset.py: Added.
4114         * Scripts/webkitpy/common/system/filesystem.py:
4115         * Scripts/webkitpy/common/system/filesystem_mock.py:
4116         * Scripts/webkitpy/common/system/zipfileset.py: Added.
4117         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
4118
4119 2011-01-06  Eric Seidel  <eric@webkit.org>
4120
4121         Reviewed by Adam Barth.
4122
4123         NetworkTransaction should log the url it is retrying
4124         https://bugs.webkit.org/show_bug.cgi?id=52043
4125
4126         * Scripts/webkitpy/common/net/networktransaction.py:
4127         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
4128
4129 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
4130
4131         Windows build fix.
4132         Import os before using it.
4133
4134         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4135
4136 2011-01-06  Eric Seidel  <eric@webkit.org>
4137
4138         Reviewed by Adam Barth.
4139
4140         StyleQueue fails to report errors when patches have many files
4141         https://bugs.webkit.org/show_bug.cgi?id=52042
4142
4143         This is one of at least two errors preventing style error reporting at the moment.
4144         When we moved to passing the list of files to check explicitly,
4145         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
4146         We could change the type of the QueueStatus.message type, or we could
4147         just teach statusserver.py how to clamp values (and warn when it does).
4148         I chose the latter path.
4149
4150         * Scripts/webkitpy/common/net/statusserver.py:
4151
4152 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
4153
4154         Reviewed by Stephanie Lewis.
4155         
4156         Fix syntax error in script.
4157
4158         Windows bots need to archive/unarchive builds to/from configuration-specific directories
4159         https://bugs.webkit.org/show_bug.cgi?id=51996
4160
4161         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4162
4163 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4164
4165         Unreviewed, fixing WinCE build after r75196.
4166
4167         WinCE port does not (yet) support NPAPI.
4168
4169         * Scripts/build-webkit:
4170
4171 2011-01-06  Xan Lopez  <xlopez@igalia.com>
4172
4173         Reviewed by Darin Adler.
4174
4175         File::Spec->rel2abs in sunspider-compare-results mangles parameters
4176         https://bugs.webkit.org/show_bug.cgi?id=52015
4177
4178         * Scripts/sunspider-compare-results: call rel2abs on our arguments
4179         after the platform has been detected, otherwise the script will
4180         mangle things like '--gtk' into '/a/path/--gtk', breaking the
4181         detection.
4182
4183 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4184
4185         Reviewed by Eric Seidel.
4186
4187         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
4188         https://bugs.webkit.org/show_bug.cgi?id=51346
4189
4190         * Scripts/build-webkit:
4191
4192 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
4193
4194         Reviewed by Adam Roben.
4195
4196         Windows bots need to archive/unarchive builds to/from configuration-specific directories
4197         https://bugs.webkit.org/show_bug.cgi?id=51996
4198         
4199         After the configuration directory change, we were archiving the incorrect directory for
4200         build product, so we were running tests on the wrong binaries.
4201         
4202         This change archives the correct directory, and also unarchives it into a configuration-
4203         specific directory.
4204
4205         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
4206         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
4207
4208 2011-01-06  Eric Seidel  <eric@webkit.org>
4209
4210         Reviewed by Mihai Parparita.
4211
4212         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
4213         https://bugs.webkit.org/show_bug.cgi?id=52002
4214
4215         See an example of this here:
4216         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
4217
4218         It's due to the fact that we pass around TestFailure() instance
4219         objects and yet expect them to all compare to be the same.
4220
4221         This is bad.  We should either have shared instances of these values
4222         or we should just pass around the class names.  There are already hacks
4223         in place to make TestFailure objects pass equality tests, I just added
4224         a __hash__ implementation so they can be used in sets as expected.
4225
4226         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4227         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4228
4229 2011-01-06  Evan Martin  <evan@chromium.org>
4230
4231         Reviewed by Tony Chang.
4232
4233         [gdb] handle inaccessible memory and UChar*
4234         https://bugs.webkit.org/show_bug.cgi?id=52003
4235
4236         To pretty-print a UChar*, we just grope around in the memory
4237         looking for a terminating NUL.  We need to handle the exception
4238         that can occur when we poke into an invalid location.
4239
4240         Additionally, the logic for choosing which pretty-printer would
4241         early return before hitting the point where we'd use the UChar*
4242         printer.  (Did this ever work?  How did it regress?)
4243
4244         * gdb/webkit.py:
4245
4246 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
4247
4248         Reviewed by Ada Chan.
4249
4250         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
4251         https://bugs.webkit.org/show_bug.cgi?id=51969
4252         
4253         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
4254
4255         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4256         (WTR::InjectedBundlePage::InjectedBundlePage):
4257         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
4258         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4259
4260 2011-01-06  James Robinson  <jamesr@chromium.org>
4261
4262         Reviewed by Simon Fraser.
4263
4264         Implement mozilla's animationTime property
4265         https://bugs.webkit.org/show_bug.cgi?id=51952
4266
4267         Chromium DRT support for webkitAnimationTime.
4268
4269         * DumpRenderTree/chromium/WebViewHost.cpp:
4270         (WebViewHost::paintInvalidatedRegion):
4271
4272 2011-01-06  Julie Parent  <jparent@chromium.org>
4273
4274         Reviewed by Tony Chang.
4275
4276         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
4277         https://bugs.webkit.org/show_bug.cgi?id=51217
4278
4279         * TestResultServer/model/jsonresults.py:
4280         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
4281         Adds missing documentation.
4282         * TestResultServer/model/jsonresults_unittest.py:
4283         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
4284         Update test_merge to take a number of builds to truncate at.
4285
4286 2011-01-06  Adam Barth  <abarth@webkit.org>
4287
4288         Reviewed by Eric Seidel.
4289
4290         The EWS should log outside of the working directory
4291         https://bugs.webkit.org/show_bug.cgi?id=51986
4292
4293         This patch prepare us for using git clean -x -d -f in the EWS wrapper
4294         script, which will actually clean the working copy back to a pristine
4295         state instead of leaving untracked directories and ignored files.
4296
4297         * Scripts/webkitpy/tool/commands/queues.py:
4298         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4299
4300 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
4301
4302         Windows build fix.
4303         Back out attempted change to built-product-archive.
4304
4305         * BuildSlaveSupport/built-product-archive:
4306
4307 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
4308
4309         Windows build fix.
4310         Include configuration name when unpacking a build archive.
4311
4312         Needed, since we split Windows build results into configuration-specific directories
4313         under WebKitOutputDir.
4314
4315         * BuildSlaveSupport/built-product-archive:
4316
4317 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
4318
4319         Reviewed by Darin Adler.
4320
4321         Debug and Release builds on Windows clobber each other
4322         https://bugs.webkit.org/show_bug.cgi?id=49185
4323
4324         Changes the structure of WebKitBuild build products directory so we
4325         completely separate each build configuration into independent directories.
4326         
4327         Although we previously had per-configuration directories for obj, this change adds
4328         per-configuration directories for bin, lib, obj, and include. Each configuration's
4329         build products are stored within a directory inside of WebKitBuild.
4330         
4331         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
4332         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
4333
4334         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
4335         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
4336         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
4337         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
4338         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
4339         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
4340         * DumpRenderTree/win/ImageDiffCommon.vsprops:
4341         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
4342         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
4343         * FindSafari/FindSafari.vcproj:
4344         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
4345         * MiniBrowser/MiniBrowserPostBuild.cmd:
4346         * MiniBrowser/MiniBrowserPreBuild.cmd:
4347         * Scripts/webkitdirs.pm:
4348         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
4349         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
4350         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
4351         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
4352         * TestWebKitAPI/win/copy-resources.cmd:
4353         * WebKitAPITest/WebKitAPITestCommon.vsprops:
4354         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
4355         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
4356         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
4357         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
4358         * WebKitTestRunner/win/InjectedBundle.vcproj:
4359         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
4360         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
4361         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
4362         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
4363         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
4364         * WinLauncher/WinLauncherCommon.vsprops:
4365         * WinLauncher/WinLauncherPostBuild.cmd:
4366         * WinLauncher/WinLauncherPreBuild.cmd:
4367
4368 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
4369
4370         Reviewed by Ariya Hidayat.
4371
4372         [Qt] TestNetscapePlugin doesn't link on OS X
4373         https://bugs.webkit.org/show_bug.cgi?id=51948
4374
4375         Only add a dependency on libX11 on X11 systems
4376
4377         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4378
4379 2011-01-05  Jeff Miller  <jeffm@apple.com>
4380
4381         Reviewed by Adam Roben.
4382
4383         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
4384         https://bugs.webkit.org/show_bug.cgi?id=51970
4385
4386         * Scripts/webkitpy/style/checker.py:
4387         Add -readability/naming for WebKit2 C API directories.
4388
4389 2011-01-05  Eric Seidel  <eric@webkit.org>
4390
4391         Unreviewed, just fixing one more log error from my previous python patch.
4392
4393         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4394         https://bugs.webkit.org/show_bug.cgi?id=51802
4395
4396         webkit-patch failure-reason was logging about parsing errors
4397         due to my misunderstanding of how BeautifulSoup.findAll worked.
4398
4399         Fixed, and added a unit test.
4400
4401         * Scripts/webkitpy/common/net/layouttestresults.py:
4402         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4403
4404 2011-01-05