2010-12-23 Lucas Forschler <lforschler@apple.com>
[WebKit-https.git] / Tools / ChangeLog
1 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2
3         Reviewed by Eric Seidel.
4
5         Bug 51539 - update iexploder scripts to point to new location
6
7         * Scripts/run-iexploder-tests:
8         * Scripts/update-iexploder-cssproperties:
9
10 2010-12-23  Evan Martin  <evan@chromium.org>
11
12         Reviewed by Ryosuke Niwa.
13
14         [chromium] LayoutTestController warning in float->int conversion
15         https://bugs.webkit.org/show_bug.cgi?id=51553
16
17         Rather than reading an int, converting to a float, then getting a compiler
18         warning on passing the float to something that expects an int, instead
19         just pass around ints.
20
21         No tests, fixes a compiler warning.
22
23         * DumpRenderTree/chromium/LayoutTestController.cpp:
24         (parsePageSizeParameters):
25         (LayoutTestController::pageNumberForElementById):
26         (LayoutTestController::numberOfPages):
27
28 2010-12-23  Lucas Forschler  <lforschler@apple.com>
29
30         Reviewed by Darin Adler.
31
32         Bug 51537 - iexploder needs cleanup
33         
34         * iExploder/htdocs: Removed.
35         * iExploder/htdocs/config.rb: Removed.
36         * iExploder/htdocs/cssproperties.in: Removed.
37         * iExploder/htdocs/cssvalues.in: Removed.
38         * iExploder/htdocs/htmlattrs.in: Removed.
39         * iExploder/htdocs/htmltags.in: Removed.
40         * iExploder/htdocs/htmlvalues.in: Removed.
41         * iExploder/htdocs/iexploder.cgi: Removed.
42         * iExploder/htdocs/iexploder.rb: Removed.
43         * iExploder/htdocs/index.html: Removed.
44         * iExploder/htdocs/webserver.rb: Removed.
45         * iExploder/iexploder-1.7.2/output: Removed.
46         * iExploder/tools: Removed.
47         * iExploder/tools/lasthit.rb: Removed.
48         * iExploder/tools/osx_last_crash.rb: Removed.
49         * iExploder/tools/showtest.rb: Removed.
50
51 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
52
53         Reviewed by Kenneth Rohde Christiansen.
54
55         [EFL] Make 'single' the default backing store in EWebLauncher
56         https://bugs.webkit.org/show_bug.cgi?id=51534
57
58         'single' is the simplest backing store and the one intended to be the
59         default in the test browser. By mistake the tiled backing store was
60         left as default in r72617.
61
62         * EWebLauncher/main.c:
63         (browserCreate): ditto.
64
65 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
66
67         Reviewed by Kenneth Rohde Christiansen.
68
69         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
70         https://bugs.webkit.org/show_bug.cgi?id=51533
71
72         There's no point in concatenating env("HOME") with "blah", so remove
73         option from EWebLauncher.
74
75         * EWebLauncher/main.c:
76         (main): ditto.
77
78 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
79
80         Reviewed by Eric Seidel.
81
82         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
83
84         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
85         I just discovered that we have two additional GC runs per each WebViewHost.
86         Test_shell had no such calls.
87         These gc runs eat 15% of cpu time.
88
89         https://bugs.webkit.org/show_bug.cgi?id=51479
90
91         * DumpRenderTree/chromium/WebViewHost.cpp:
92         (WebViewHost::~WebViewHost):
93
94 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
95
96         Reviewed by Ojan Vafai.
97
98         This change splits out the TestRunner class into its own file.
99         When we fork the code for message passing, we will create a new
100         TestRunner, and this change will allow that to be more modular.
101
102         While we're at it, split out TestInput and ResultSummary into
103         their own files, to reduce the size of run_webkit_tests to
104         something more managable.
105
106         https://bugs.webkit.org/show_bug.cgi?id=51092
107
108         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
109         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
110         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
111         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
112         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
113         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
114         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
115
116  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
117
118         Reviewed by Ojan Vafai.
119
120         nrwt multiprocessing - start over, prepare to fork the code
121  
122         This code cleans up the signatures and implementation of the
123         TestRunner class so we can easily fork it to run either the
124         stable implementation or the new, unstable message-passing
125         implementation. The two variants will have different
126         implementations of the run_tests() method. We will switch
127         between the two based on the setting for the '--worker-model'
128         switch. We rename the two currently valid values to 'old-inline'
129         and 'old-threads'.
130
131         https://bugs.webkit.org/show_bug.cgi?id=51081
132
133         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
134         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
135
136 2010-12-22  Victor Wang  <victorw@chromium.org>
137
138         Reviewed by Darin Fisher.
139
140         [Chromium] Update chromium archive test result url in rebaseline script.
141
142         https://bugs.webkit.org/show_bug.cgi?id=51503
143
144         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
145
146 2010-12-22  Lucas Forschler  <lforschler@apple.com>
147
148         Reviewed by Alice Liu.
149
150         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
151         Verified on Chrome, Safari, and IE.
152         With this change, we will record memory from a parent browser window and all child processes.
153
154         * record-memory-win/main.cpp:
155         (ProcessArgs):
156         (PrintUsage):
157         (getMemoryInfo):
158         (printProcessInfo):
159         (evalProcesses):
160         (UseImage):
161         (QueryContinuously):
162         (ElapsedTime):
163
164 2010-12-22  Lucas Forschler  <lforschler@apple.com>
165
166         Unreviewed rollout r74489, because it was missing changelog.
167
168         * record-memory-win/main.cpp:
169         
170 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
171
172         Adding myself as a reviewer.
173
174         * Scripts/webkitpy/common/config/committers.py:
175
176 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
177
178         Unreviewed.  Adding myself to committers.py.
179
180         * Scripts/webkitpy/common/config/committers.py:
181
182 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
183
184         Reviewed by Kenneth Rohde Christiansen.
185
186         TestNetscapePlugIn should use #if defined
187         https://bugs.webkit.org/show_bug.cgi?id=51471
188
189         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
190         (NP_Initialize):
191         (NPP_New):
192
193 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
194
195         Reviewed by Yury Semikhatsky.
196
197         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
198
199         DevTools window should be closed explicitly because it has custom deinitialization code.
200
201         https://bugs.webkit.org/show_bug.cgi?id=50722
202
203         * DumpRenderTree/chromium/TestShell.cpp:
204         (TestShell::closeRemainingWindows):
205
206 2010-12-22  David Levin  <levin@chromium.org>
207
208         Reviewed by Shinichiro Hamaji.
209
210         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
211         https://bugs.webkit.org/show_bug.cgi?id=51452
212
213         * Scripts/webkitpy/style/checkers/cpp.py:
214         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
215         Using the file extension if possible but falling back to the file contents if we have a header file.
216         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
217         (_FileState.is_c_or_objective_c):
218         (check_using_std): Changed to using _FileState to determine the file type.
219         (check_max_min_macros): Ditto.
220         (check_for_null): Ditto.
221         (check_style): Changed the parameters to various calls since they now need _FileState
222         to determine the file type.
223         (check_language): Added the file_state parameter so it could be passed
224         to check_identifier_name_in_declaration.
225         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
226         this is an Objective C file.
227         (_process_lines): Added information for the _FileState constructor (and moved the
228         call to a place that had the information).
229         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
230         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
231         its functionality.
232         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
233
234 2010-12-21  Andy Estes  <aestes@apple.com>
235
236         Reviewed by Mark Rowe.
237
238         Do not build non-Intel architectures for WebKit2-related projects.
239         https://bugs.webkit.org/show_bug.cgi?id=51440
240
241         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
242         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
243         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
244
245 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
246
247         Reviewed by Darin Fisher.
248
249         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
250         https://bugs.webkit.org/show_bug.cgi?id=51406 
251         
252         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
253         to WebThemeEngineDRTWin and update references everywhere.
254
255         * DumpRenderTree/DumpRenderTree.gypi:
256         * DumpRenderTree/chromium/TestShellWin.cpp:
257         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
258         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
259         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
260         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
261
262 2010-12-21  Anders Carlsson  <andersca@apple.com>
263
264         Reviewed by John Sullivan.
265
266         Clicking missing plug-in text does not show a sheet
267         https://bugs.webkit.org/show_bug.cgi?id=51403
268
269         Update for changes to the WebPageUIClient.
270
271         * MiniBrowser/mac/BrowserWindowController.m:
272         (-[BrowserWindowController awakeFromNib]):
273         * WebKitTestRunner/TestController.cpp:
274         (WTR::createOtherPage):
275         (WTR::TestController::initialize):
276
277 2010-12-21  Eric Seidel  <eric@webkit.org>
278
279         Reviewed by Adam Barth.
280
281         commit-queue will report constant failures as flaky if other tests flake
282         https://bugs.webkit.org/show_bug.cgi?id=51272
283
284         This patch just removes functionality and adds testing.
285         Previously we attempted to report flaky tests when we had
286         two different tests fail in a row.  However, since we stop
287         running the tests at the first failure, our code was wrong in
288         trying to determine flakiness from the incomplete runs.
289
290         Originally I posted an alternate patch:
291         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
292         which fixed our flaky logic in this case, however it was decided
293         that that patch would be too difficult to maintain, so now
294         I'm just removing the broken logic.
295
296         This will dramatically cut-down on our flaky-test false positives
297         at the (small) cost of the queues being unable to report
298         any flakiness if the tree is very flaky.  (With at least one test
299         flaking on every run, we'll never report failures anymore.)  I think
300         this is a tradeoff worth making.
301
302         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
303         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
304
305 2010-12-20  Eric Seidel  <eric@webkit.org>
306
307         Reviewed by Adam Barth.
308
309         commit-queue wrongly rejects patches when it can't update itself
310         https://bugs.webkit.org/show_bug.cgi?id=46636
311
312         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
313         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
314         * Scripts/webkitpy/tool/commands/queues_unittest.py:
315
316 2010-12-20  Adam Barth  <abarth@webkit.org>
317
318         Move web sites to Websites directory
319         https://bugs.webkit.org/show_bug.cgi?id=51323
320
321         Update references to BugsSite to point to the new location.
322
323         This patch was never officially reviewed (because it was too large to
324         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
325         Rowe gave me the green light.
326
327         * Scripts/old-run-webkit-tests:
328         * Scripts/webkitpy/common/config/build.py:
329         * Scripts/webkitpy/common/config/build_unittest.py:
330         * Scripts/webkitpy/common/prettypatch.py:
331         * Scripts/webkitpy/layout_tests/port/base.py:
332         * Scripts/webkitpy/style/main.py:
333
334 2010-12-20  Adrienne Walker  <enne@google.com>
335
336         Unreviewed. Adding myself to the list of committers.
337
338         * webkitpy/common/config/committers.py:
339
340 2010-12-20  Mark Rowe  <mrowe@apple.com>
341
342         Reviewed by Dan Bernstein.
343
344         <rdar://problem/8757601> Don't install header files in to the Resources directory.
345
346         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
347         Resources directory.
348
349 2010-12-20  Eric Seidel  <eric@webkit.org>
350
351         Reviewed by Adam Barth.
352
353         commit-queue should include bot id when attaching failure diffs
354         https://bugs.webkit.org/show_bug.cgi?id=51280
355
356         This is a tiny change to include the bot id in the name of the attachment.
357         Most of this diff is just changing the unit test expectations
358         now that I hid the comment printing when the comment is None.
359
360         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
361         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
362         * Scripts/webkitpy/tool/commands/upload_unittest.py:
363         * Scripts/webkitpy/tool/mocktool.py:
364
365 2010-12-20  Jeff Miller  <jeffm@apple.com>
366
367         Reviewed by Dan Bernstein.
368
369         Tools/vcbin/midl.exe needs to be rebuilt
370         https://bugs.webkit.org/show_bug.cgi?id=51347
371
372         * vcbin/midl.exe: Rebuilt.
373
374 2010-12-20  David Levin  <levin@chromium.org>
375
376         Reviewed by Ariya Hidayat.
377
378         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
379         https://bugs.webkit.org/show_bug.cgi?id=51343
380
381         Follow up from the WebKitTools -> Tools rename.
382
383         * Scripts/webkit-tools-completion.sh:
384
385 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
386
387         Reviewed by James Robinson.
388
389         new-run-webkit-tests ignores trailing EOL differences in text tests
390         https://bugs.webkit.org/show_bug.cgi?id=36983
391
392         Changed the handling of new-line characters within new-run-webkit-tests
393         to match old-run-webkit-tests.  Differences in leading and trailing empty
394         lines in text expectation files are no longer ignored.
395
396         * Scripts/webkitpy/layout_tests/port/base.py:
397         * Scripts/webkitpy/layout_tests/port/test.py:
398         Added unit tests.  Removed old duplicate unit test entries.
399         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
400
401 2010-12-20  David Levin  <levin@chromium.org>
402
403         Reviewed by Shinichiro Hamaji.
404
405         check-webkit-style should detect function declarations (and trivial functions).
406         https://bugs.webkit.org/show_bug.cgi?id=51303
407
408         * Scripts/webkitpy/style/checkers/cpp.py:
409         (_FunctionState.begin): Add is_declaration and changed the line count
410         start to begin at -1 (which will keep the results consistent, since
411         the starting line number passed in is one less in this change).
412         (detect_functions): changed function detection to now catch trivial
413         functions and declarations.
414         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
415         of the function as this may look at return values (when processing
416         a declaration).
417         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
418         (FunctionDetectionTest.perform_function_detection): Basic mechanics
419         of testing the function detection.
420         (FunctionDetectionTest.test_basic_function_detection): Test a simple
421         function.
422         (FunctionDetectionTest.test_function_declaration_detection): Test a
423         declaration.
424         (FunctionDetectionTest.test_non_functions): A test case for a case
425         that caused the code to fail due to the { being in quotes.
426         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
427         cases to help catch false alarms for return values.
428         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
429         we don't get false alarms for member variables either.
430
431 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
432
433         Reviewed by Antonio Gomes.
434
435         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
436         https://bugs.webkit.org/show_bug.cgi?id=51319
437
438         * CMakeListsEfl.txt:
439
440 2010-12-18  Adam Barth  <abarth@webkit.org>
441
442         Reviewed by Sam Weinig.
443
444         Move WebKitExamplePlugins to Examples
445         https://bugs.webkit.org/show_bug.cgi?id=51291
446
447         * Scripts/webkitpy/common/config/build.py:
448
449 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
450
451         Unreviewed Qt buildfix after r74301.
452
453         Rename WebKitTools to Tools
454         https://bugs.webkit.org/show_bug.cgi?id=49861
455
456         * MiniBrowser/DerivedSources.pro:
457         * MiniBrowser/qt/MiniBrowser.pro:
458
459 2010-12-17  Dan Bernstein  <mitz@apple.com>
460
461         Reviewed by Simon Fraser.
462
463         Rename WebKitTools to Tools
464         https://bugs.webkit.org/show_bug.cgi?id=49861
465
466         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
467         * CodeCoverage/README:
468         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
469         (WebCore::DumpRenderTree::initializeFonts):
470         * EWSTools/start-commit-queue.sh:
471         * EWSTools/start-queue.sh:
472         * GNUmakefile.am:
473         * MIDLWrapper/MIDLWrapper.cpp:
474         (wmain):
475         * MiniBrowser/qt/MiniBrowser.pro:
476         * Scripts/build-api-tests:
477         * Scripts/build-dumprendertree:
478         * Scripts/build-webkit:
479         * Scripts/build-webkittestrunner:
480         * Scripts/generate-coverage-data:
481         * Scripts/old-run-webkit-tests:
482         * Scripts/run-api-tests:
483         * Scripts/run-iexploder-tests:
484         * Scripts/run-javascriptcore-tests:
485         * Scripts/run-mangleme-tests:
486         * Scripts/run-sunspider:
487         * Scripts/run-webkit-websocketserver:
488         * Scripts/sunspider-compare-results:
489         * Scripts/test-webkitperl:
490         * Scripts/test-webkitpy:
491         * Scripts/update-iexploder-cssproperties:
492         * Scripts/update-webkit:
493         * Scripts/update-webkit-localizable-strings:
494         * Scripts/webkitdirs.pm:
495         * Scripts/webkitpy/common/checkout/scm.py:
496         * Scripts/webkitpy/common/checkout/scm_unittest.py:
497         * Scripts/webkitpy/common/config/committervalidator.py:
498         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
499         * Scripts/webkitpy/common/config/ports.py:
500         * Scripts/webkitpy/common/config/ports_unittest.py:
501         * Scripts/webkitpy/common/system/logutils_unittest.py:
502         * Scripts/webkitpy/common/system/ospath_unittest.py:
503         * Scripts/webkitpy/layout_tests/port/chromium.py:
504         * Scripts/webkitpy/layout_tests/port/config.py:
505         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
506         * Scripts/webkitpy/layout_tests/port/http_server.py:
507         * Scripts/webkitpy/layout_tests/port/test.py:
508         * Scripts/webkitpy/style/checker.py:
509         * Scripts/webkitpy/style/checker_unittest.py:
510         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
511         * Scripts/webkitpy/tool/commands/queues_unittest.py:
512         * Scripts/webkitpy/tool/steps/steps_unittest.py:
513         * WebKitTestRunner/DerivedSources.pro:
514         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
515         (WTR::activateFonts):
516         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
517         * wx/build/build_utils.py:
518
519 2010-12-16  Antonio Gomes  <agomes@rim.com>
520
521         Reviewed by Martin Robinson.
522
523         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
524         https://bugs.webkit.org/show_bug.cgi?id=51163
525
526         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
527         GTK+'s DRT should also reset to UNIX after each test execution.
528
529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
530         (resetDefaultsToConsistentValues):
531
532 2010-12-17  David Levin  <levin@chromium.org>
533
534         Reviewed by Eric Seidel.
535
536         check-webkit-style should understand WTF #include guards
537         https://bugs.webkit.org/show_bug.cgi?id=44911
538
539         * Scripts/webkitpy/style/checkers/cpp.py:
540         (get_header_guard_cpp_variable): modify to suggest the WTF style
541         of header guard when appropriate.
542         (check_for_header_guard): handle multiple return values from
543         get_header_guard_cpp_variable
544         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
545         (CppStyleTest.test_build_header_guard): Added tests for the WTF
546         header style.
547
548 2010-12-16  David Levin  <levin@chromium.org>
549
550         Reviewed by Eric Seidel.
551
552         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
553         https://bugs.webkit.org/show_bug.cgi?id=51210
554
555         The error only shows up when using python 2.6 or later.
556
557         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
558         the decprecated field error,message with something equivalent.
559
560 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
561
562         Reviewed by Eric Seidel.
563
564         Add --exit-after-n-failures/crashes to NRWT
565         https://bugs.webkit.org/show_bug.cgi?id=51160
566         
567         Abort test run (in a similar way to how control-C is handled) when
568         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
569         that number of unexpected failures/crashes/timeouts.
570
571         * Scripts/webkitpy/layout_tests/port/test.py:
572         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
573         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
574
575 2010-12-16  David Levin  <levin@chromium.org>
576
577         Reviewed by Shinichiro Hamaji.
578
579         check-webkit-style unit tests has some duplicate boilerplate code.
580         https://bugs.webkit.org/show_bug.cgi?id=49519
581
582         * Scripts/webkitpy/style/checkers/cpp.py:
583         (update_include_state): Replaced the "io" parameter with the global
584         configuration _unit_test_config. This allowed not calling into
585         functions at a low level and also not plumbing through the injection
586         information through many levels of code.
587         (check_for_include_what_you_use): Ditto.
588         (process_file_data): Added the ability to set up the unit test config
589         to allow for injection.
590         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
591         (ErrorCollector.__init__): Added support for having a filter for errors.
592         (ErrorCollector.__call__): Ditto.
593         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
594         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
595         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
596         functions in the cpp.py with generic processing and a filter that
597         indicates what errors should be kept.
598         (CppStyleTestBase.perform_multi_line_lint): Ditto.
599         (CppStyleTestBase.perform_language_rules_check): Ditto.
600         (CppStyleTestBase.perform_function_lengths_check): Ditto.
601         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
602         (CppStyleTestBase.perform_include_what_you_use): Ditto.
603         (CppStyleTest.test_multi_line_comments): Added another
604         error message which applies to the test case.
605         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
606         to not have config.h, since it is processed as a header file.
607         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
608         style and indentation in checked code.
609         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
610         Fixed line number.
611         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
612         Ditto.
613
614 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
615
616         Unreviewed, rolling out r74136.
617         http://trac.webkit.org/changeset/74136
618         https://bugs.webkit.org/show_bug.cgi?id=51135
619
620         r74136 breaks chromium canary bots because some tests are not
621         rebaselined correctly to resolve EOL differences (Requested by
622         jianli on #webkit).
623
624         * Scripts/webkitpy/layout_tests/port/base.py:
625         * Scripts/webkitpy/layout_tests/port/test.py:
626         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
627
628 2010-12-15  Adam Roben  <aroben@apple.com>
629
630         Teach check-webkit-style to check .vcproj and .vsprops files for XML
631         syntax errors
632
633         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
634         XML syntax errors in .vcproj/.vsprops files
635
636         Reviewed by Dave Levin.
637
638         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
639         that should be treated as XML and that should be allowed to contain
640         carriage returns. (These lists happen to be identical currently.)
641         (FileType): Added a new XML type.
642         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
643         Just does a simple file extension check.
644         (CheckerDispatcher._file_type): Added a case for XML files.
645         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
646         files (surprise!).
647         (StyleProcessor.process): Ask the dispatcher whether we should pass the
648         lines through the carriage checker.
649
650         * Scripts/webkitpy/style/checker_unittest.py:
651         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
652         Added. Checks a few file names to see if carriage returns are allowed
653         or not.
654         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
655         other assert_checker_* functions.
656         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
657         test_*_paths functions.
658         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
659         test_*_paths functions.
660         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
661         file from this test case, as vcproj files now have a type.
662         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
663         Added. Similar to the other should_* functions.
664         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
665         Added. Checks that carriage returns aren't checked for or stripped for
666         allowed files.
667
668         * Scripts/webkitpy/style/checkers/xml.py: Added.
669         (XMLChecker.__init__): Simple init method.
670         (XMLChecker.check): Pass each line through the expat parser, and record
671         a style error for any errors thrown by the parser.
672
673         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
674         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
675         produce a style error.
676         (XMLCheckerTest.assert_error): Checks that the given XML produces an
677         error of the given category on the given line.
678         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
679         checking that the XMLChecker constructor works properly.
680         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
681         cause a style error (see, e.g., r73887).
682         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
683         cause a style error (see, e.g., r73773).
684         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
685         properly.
686         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
687         tags cause a style error (see, e.g., r72795).
688         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
689         style error.
690
691 2010-12-15  Lucas Forschler  <lforschler@apple.com>
692
693         Reviewed by Stephanie Lewis.
694
695         https://bugs.webkit.org/show_bug.cgi?id=51117
696         Add a new leopard test bot
697         really really commit to trunk this time.
698
699         * BuildSlaveSupport/build.webkit.org-config/config.json:
700
701 2010-12-15  Sam Weinig  <sam@webkit.org>
702
703         Reviewed by Anders Carlsson.
704
705         WebKit2: Can't add files to an <input type=file>
706         https://bugs.webkit.org/show_bug.cgi?id=51087
707
708         * MiniBrowser/mac/BrowserWindowController.m:
709         (runOpenPanel):
710         (-[BrowserWindowController awakeFromNib]):
711         Add simple implementation of runOpenPanel callback.
712
713         * MiniBrowser/win/BrowserView.cpp:
714         (BrowserView::create):
715         * WebKitTestRunner/TestController.cpp:
716         (WTR::createOtherPage):
717         (WTR::TestController::initialize):
718         Stub out runOpenPanel callback. 
719
720 2010-12-14  Eric Seidel  <eric@webkit.org>
721
722         Reviewed by Adam Barth.
723
724         commit-queue should upload failure diffs when tests flake
725         https://bugs.webkit.org/show_bug.cgi?id=51051
726
727         To make this testable I needed to pipe FileSystem down onto tool.
728         We've wanted it there for a long time anyway.
729
730         This patch is kinda a big hack.  But we don't have a nice
731         way to read results.html files.  I think this will need further
732         revision before this code actually feels clean.
733
734         As part of testing this change, I had to make MockBugzilla.create_bug
735         actually return an id (like it should) which required updating
736         a few other unit test results (for the better).
737
738         The results_matching_keys change in layouttestresults/rebasline
739         was an alternate path which I decided not to use in the end, but
740         I left the change as it seemed an improvement.
741
742         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
743         * Scripts/webkitpy/common/net/layouttestresults.py:
744         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
745         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
746         * Scripts/webkitpy/tool/commands/queues.py:
747         * Scripts/webkitpy/tool/commands/rebaseline.py:
748         * Scripts/webkitpy/tool/main.py:
749         * Scripts/webkitpy/tool/mocktool.py:
750
751 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
752
753         Reviewed by James Robinson.
754
755         new-run-webkit-tests ignores trailing EOL differences in text tests
756         https://bugs.webkit.org/show_bug.cgi?id=36983
757
758         Changed the handling of new-line characters within new-run-webkit-tests
759         to match old-run-webkit-tests.  Differences in leading and trailing empty
760         lines in text expectation files are no longer ignored.
761
762         * Scripts/webkitpy/layout_tests/port/base.py:
763         * Scripts/webkitpy/layout_tests/port/test.py:
764         Added unit tests.  Removed old duplicate unit test entries.
765         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
766
767 2010-12-15  Ojan Vafai  <ojan@chromium.org>
768
769         Reviewed by Adam Barth.
770
771         make status-bubble white-space:nowrap so we can measure it's width without wrapping
772         https://bugs.webkit.org/show_bug.cgi?id=51149
773
774         * QueueStatusServer/templates/statusbubble.html:
775
776 2010-12-15  Ojan Vafai  <ojan@chromium.org>
777
778         Reviewed by Adam Barth.
779
780         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
781         https://bugs.webkit.org/show_bug.cgi?id=51125
782
783         * QueueStatusServer/templates/statusbubble.html:
784
785 2010-12-15  Darin Adler  <darin@apple.com>
786
787         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
788
789 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
790
791         Unreviewed, rolling out r74117.
792         http://trac.webkit.org/changeset/74117
793         https://bugs.webkit.org/show_bug.cgi?id=51113
794
795         This broke the GTK1 build. (Requested by mrobinson on
796         #webkit).
797
798         * Scripts/webkitdirs.pm:
799
800 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
801
802         Reviewed by Martin Robinson.
803
804         Change generate-forwarding-headers.pl for GTK port usage 
805         (https://bugs.webkit.org/show_bug.cgi?id=37369)
806
807         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
808
809 2010-12-14  Kent Tamura  <tkent@chromium.org>
810
811         Reviewed by Jian Li.
812
813         [DRT/Chromium] Remove another unnecessary error message
814         https://bugs.webkit.org/show_bug.cgi?id=51083
815
816         * DumpRenderTree/chromium/WebViewHost.cpp:
817         (WebViewHost::didInvalidateRect):
818
819 2010-12-14  Lucas Forschler  <lforschler@apple.com>
820
821         Reviewed by Stephanie Lewis.
822
823         Add a new Leopard Debug Test WK2 Bot
824
825         * BuildSlaveSupport/build.webkit.org-config/config.json:
826
827 2010-12-14  Ojan Vafai  <ojan@chromium.org>
828
829         Fix python unittests after http://trac.webkit.org/changeset/74070.
830
831         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
832
833 2010-12-14  Kent Tamura  <tkent@chromium.org>
834
835         Reviewed by Jian Li.
836
837         [DRT/Chromium] Remove a unnecessary error message
838         https://bugs.webkit.org/show_bug.cgi?id=51069
839
840         * DumpRenderTree/chromium/WebViewHost.cpp:
841         (WebViewHost::paintInvalidatedRegion):
842
843 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
844
845         Reviewed by Ojan Vafai.
846
847         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
848         https://bugs.webkit.org/show_bug.cgi?id=48926
849
850         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
851         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
852
853 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
854
855         Reviewed by Eric Seidel.
856
857         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
858         https://bugs.webkit.org/show_bug.cgi?id=50231
859
860         Guard CONFIG+=link_pkgconfig with !symbian.
861
862         * DumpRenderTree/qt/DumpRenderTree.pro:
863         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
864         * WebKitTestRunner/qt/WebKitTestRunner.pro:
865
866 2010-12-14  Philippe Normand  <pnormand@igalia.com>
867
868         Reviewed by Ojan Vafai.
869
870         [new-run-webkit-tests] expectations parsing is slow
871         https://bugs.webkit.org/show_bug.cgi?id=50635
872
873         Avoid expensive iteration of all the tests when checking if a test
874         file is to be skipped or not.
875
876         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
877         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
878         * Scripts/webkitpy/layout_tests/port/test.py:
879
880 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
881
882         Reviewed by Xan Lopez.
883
884         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
885         https://bugs.webkit.org/show_bug.cgi?id=27048
886
887         Add support in DRT for checking whether an accessibility UI
888         element is focusable and/or focused. Implemented for GTK.
889
890         * DumpRenderTree/AccessibilityUIElement.cpp:
891         (getIsFocusedCallback): New.
892         (getIsFocusableCallback): New.
893         (AccessibilityUIElement::getJSClass): Add the new available
894         callbacks for isFocused and isFocusable.
895         * DumpRenderTree/AccessibilityUIElement.h:
896         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
897         (AccessibilityUIElement::isFocused): New, implemented by checking
898         whether the related AtkState value is in the object's state set.
899         (AccessibilityUIElement::isFocusable): Ditto.
900         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
901         (AccessibilityUIElement::isFocused): New, dummy implementation.
902         (AccessibilityUIElement::isFocusable): Ditto.
903         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
904         (AccessibilityUIElement::isFocused): Ditto.
905         (AccessibilityUIElement::isFocusable): Ditto.
906
907 2010-12-14  Eric Seidel  <eric@webkit.org>
908
909         Reviewed by Ojan Vafai.
910
911         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
912         https://bugs.webkit.org/show_bug.cgi?id=50715
913
914         This patch makes webkit-patch print the following:
915
916         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
917         Install a 64-bit git for better performance, see:
918         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
919
920         I wrote this mostly because I have approximately 8 machines that I use
921         and making sure each one is using a good Git install seemed folly.
922         webkit-patch makes a lot of git calls, so using a fast git can shave
923         several seconds in every invocation.  See the webkit-dev thread for more info.
924
925         This message will print twice during 'webkit-patch upload',
926         once from webkit-patch and once from check-webkit-style.
927
928         Unfortunately there is no good way to test this due to how machine-dependent
929         the code is.  I considered writing a test for the log message, but it seemed not worth it.
930
931         * Scripts/webkitpy/common/checkout/scm.py:
932
933 2010-12-13  Eric Seidel  <eric@webkit.org>
934
935         Reviewed by Adam Barth.
936
937         FlakyTestReporter doesn't understand bots running from multiple email addresses
938         https://bugs.webkit.org/show_bug.cgi?id=50960
939
940         This explains at least one of the dupes of:
941         https://bugs.webkit.org/show_bug.cgi?id=50863
942         that we saw filed by the commit-queue this morning.
943         I think the other one was explained by my previous fix to result counting code.
944
945         Since this is really hard to test with a unit test, instead I
946         create a new (possibly useful in the future) command
947         which given a layout test path will return you
948         the one bug which our tools would assume it the flaky test bug.
949         If some other script wants to use bug-for-test we'll
950         need to extend it with some options like --create-if-missing or similar.
951
952         * Scripts/webkitpy/common/net/bugzilla/bug.py:
953         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
954         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
955         * Scripts/webkitpy/tool/commands/__init__.py:
956         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
957
958 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
959
960         Reviewed by James Robinson.
961
962         Add option to build-webkit to not build WebKit2
963         https://bugs.webkit.org/show_bug.cgi?id=50988
964         
965         Add support for a --no-webkit2 option to build-webkit. It seems to save
966         ~1 minute from clean builds and ~10 seconds from no-op builds.
967
968         * Scripts/build-webkit:
969
970 2010-12-13  Lucas Forschler  <lforschler@apple.com>
971
972         Reviewed by Dave Kilzer.
973
974         Update iexploder from 1.3.2 to 1.7.2
975         Move 1.3.2 into its own subdir
976         Add 1.7.2 into its own subdir
977         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
978
979         * Scripts/run-iexploder-tests:
980         * Scripts/update-iexploder-cssproperties:
981         * iExploder/CHANGELOG.txt: Removed.
982         * iExploder/LICENSE.txt: Removed.
983         * iExploder/README.txt: Removed.
984         * iExploder/htdocs: Removed.
985         * iExploder/iexploder-1.3.2: Added.
986         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
987         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
988         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
989         * iExploder/iexploder-1.3.2/htdocs: Added.
990         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
991         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
992         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
993         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
994         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
995         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
996         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
997         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
998         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
999         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
1000         * iExploder/iexploder-1.3.2/tools: Added.
1001         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
1002         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
1003         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
1004         * iExploder/iexploder-1.7.2: Added.
1005         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
1006         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
1007         * iExploder/iexploder-1.7.2/README.txt: Added.
1008         * iExploder/iexploder-1.7.2/output: Added.
1009         * iExploder/iexploder-1.7.2/src: Added.
1010         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1011         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1012         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1013         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1014         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1015         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1016         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1017         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1018         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1019         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1020         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1021         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1022         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1023         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1024         * iExploder/iexploder-1.7.2/src/css-values: Added.
1025         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1026         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1027         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1028         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1029         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1030         * iExploder/iexploder-1.7.2/src/headers: Added.
1031         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1032         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1033         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1034         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1035         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1036         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1037         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1038         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1039         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1040         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1041         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1042         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1043         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1044         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1045         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1046         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1047         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1048         * iExploder/iexploder-1.7.2/src/html-values: Added.
1049         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1050         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1051         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1052         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1053         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1054         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1055         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1056         * iExploder/iexploder-1.7.2/src/index.html: Added.
1057         * iExploder/iexploder-1.7.2/src/media: Added.
1058         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1059         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1060         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1061         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1062         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1063         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1064         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1065         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1066         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1067         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1068         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1069         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1070         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1071         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1072         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1073         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1074         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1075         * iExploder/iexploder-1.7.2/src/protocols: Added.
1076         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1077         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1078         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1079         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1080         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1081         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1082         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1083         * iExploder/iexploder-1.7.2/testcases: Added.
1084         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1085         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1086         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1087         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1088         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1089         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1090         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1091         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1092         * iExploder/iexploder-1.7.2/tools: Added.
1093         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1094         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1095         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1096         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1097         * iExploder/tools: Removed.
1098
1099 2010-12-13  Sam Weinig  <sam@webkit.org>
1100
1101         Reviewed by Anders Carlsson.
1102
1103         Remove associated page concept from WKView constructor
1104         https://bugs.webkit.org/show_bug.cgi?id=50983
1105
1106         Step 1: Remove associate page constructors from WKView and make
1107         all views use the shared namespace for the context.
1108
1109         * TestWebKitAPI/PlatformWebView.h:
1110         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1111         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1112         * WebKitTestRunner/PlatformWebView.h:
1113         * WebKitTestRunner/TestController.cpp:
1114         (WTR::createOtherPage):
1115         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1116         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1117         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1118
1119 2010-12-13  Sam Weinig  <sam@webkit.org>
1120
1121         Reviewed by Anders Carlsson.
1122
1123         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1124         https://bugs.webkit.org/show_bug.cgi?id=50898
1125
1126         * MiniBrowser/mac/AppDelegate.h:
1127         * MiniBrowser/mac/AppDelegate.m:
1128         * MiniBrowser/mac/BrowserWindowController.h:
1129         * MiniBrowser/mac/BrowserWindowController.m:
1130         * MiniBrowser/win/BrowserView.cpp:
1131         Convert MiniBrowser to not use PageNamespaces.
1132
1133         * TestWebKitAPI/PlatformWebView.h:
1134         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1135         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1136         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1137         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1138         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1139         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1140         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1141         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1142         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1143         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1144         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1145         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1146         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1147         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1148         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1149         Convert TestWebKitAPI to not use PageNamespaces.
1150
1151         * WebKitTestRunner/PlatformWebView.h:
1152         * WebKitTestRunner/TestController.cpp:
1153         * WebKitTestRunner/TestController.h:
1154         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1155         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1156         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1157         Convert WebKitTestRunner to not use PageNamespaces.
1158
1159 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1160
1161         Reviewed by Eric Seidel.
1162
1163         webkit-patch rollout should be able to do multi-revision rollouts
1164         https://bugs.webkit.org/show_bug.cgi?id=33336
1165
1166         Make it possible to pass more than one revision to webkit-patch.
1167
1168         * Scripts/webkitpy/common/checkout/api.py:
1169         * Scripts/webkitpy/common/checkout/changelog.py:
1170         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1171         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1172         * Scripts/webkitpy/tool/commands/download.py:
1173         * Scripts/webkitpy/tool/commands/download_unittest.py:
1174         * Scripts/webkitpy/tool/mocktool.py:
1175         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1176         * Scripts/webkitpy/tool/steps/revertrevision.py:
1177
1178 2010-12-13  Eric Seidel  <eric@webkit.org>
1179
1180         Unreviewed.
1181
1182         Teach webkit-patch how to search bugzilla
1183         https://bugs.webkit.org/show_bug.cgi?id=50500
1184
1185         webkit-patch bug-search fails when there is only one result.
1186         Turns out we needed a bit more logic in our result count parsing code.
1187
1188         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1189         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1190
1191 2010-12-13  Antti Koivisto  <antti@apple.com>
1192
1193         Reviewed by Alexey Proskuryakov.
1194
1195         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1196         https://bugs.webkit.org/show_bug.cgi?id=50758
1197
1198         * DumpRenderTree/LayoutTestController.cpp:
1199         (setSerializeHTTPLoadsCallback):
1200         (LayoutTestController::staticFunctions):
1201         * DumpRenderTree/LayoutTestController.h:
1202         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1203         (LayoutTestController::setSerializeHTTPLoads):
1204         * DumpRenderTree/mac/DumpRenderTree.mm:
1205         (resetDefaultsToConsistentValues):
1206         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1207         (LayoutTestController::setSerializeHTTPLoads):
1208         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1209         (LayoutTestController::setSerializeHTTPLoads):
1210
1211 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1212
1213         Reviewed by Ojan Vafai.
1214
1215         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1216         https://bugs.webkit.org/show_bug.cgi?id=50936
1217
1218         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1219
1220 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1221
1222         Reviewed by Csaba Osztrogonác.
1223
1224         Add revlink to BuildBot status
1225         https://bugs.webkit.org/show_bug.cgi?id=50914
1226
1227         This adds a hyperlink to trac changeset on the revision numbers. 
1228
1229         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1230
1231 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1232
1233         Reviewed by Csaba Osztrogonác.
1234
1235         [Qt][WK2] Fix build if WebKitTools are not available
1236         https://bugs.webkit.org/show_bug.cgi?id=50242
1237
1238         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1239         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1240         * MiniBrowser/DerivedSources.pro: Added.
1241
1242 2010-12-13  Eric Seidel  <eric@webkit.org>
1243
1244         Reviewed by Adam Barth.
1245
1246         EWS Queues should remove orpahned pyc files before starting
1247         https://bugs.webkit.org/show_bug.cgi?id=50904
1248
1249         A previous check added a platform.py which caused
1250         EWS bots on some platforms to hit an import exception.
1251         The platform.py file was removed in a subsequent commit, but
1252         the EWS bots in question stayed stuck.  This change will
1253         fix those bots once restarted (and prevent this in the future).
1254
1255         I also went ahead and unified start-queue and start-commit-queue
1256         since they were nearly identical.  I also added bot_id support
1257         to both force all EWSes to have bot ids as well as get rid of the one
1258         remaining reason why I had my own copies of these scripts.
1259         Hopefully this will be enough to get all the other bot admins
1260         (ahem, Adam, ahem) to move to using these checked in copies as well.
1261
1262         * EWSTools/start-commit-queue.sh: Removed.
1263         * EWSTools/start-queue.sh:
1264
1265 2010-10-28  MORITA Hajime  <morrita@google.com>
1266
1267         Reviewed by Ojan Vafai.
1268
1269         spellcheck does not check pasted text
1270         https://bugs.webkit.org/show_bug.cgi?id=40092
1271
1272         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1273         to control the setting.
1274
1275         * DumpRenderTree/LayoutTestController.cpp:
1276         (setAsynchronousSpellCheckingEnabledCallback):
1277         (LayoutTestController::staticFunctions):
1278         * DumpRenderTree/LayoutTestController.h:
1279         * DumpRenderTree/chromium/LayoutTestController.h:
1280         * DumpRenderTree/chromium/LayoutTestController.cpp:
1281         (LayoutTestController::LayoutTestController):
1282         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1283         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1284         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1285         * DumpRenderTree/mac/DumpRenderTree.mm:
1286         (resetDefaultsToConsistentValues):
1287         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1288         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1289         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1290         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1291         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1292         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1293         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1294         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1295         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1296
1297 2010-12-12  Sam Weinig  <sam@webkit.org>
1298
1299         Reviewed by Anders Carlsson.
1300
1301         Fix failing API test. It turns out that a pop-state event
1302         is sent before every fragment navigation, so we have to test
1303         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1304
1305         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1306         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1307
1308 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1309
1310         Reviewed by Eric Seidel.
1311
1312         [GTK] Add new-run-webkit-tests support to gtk
1313         https://bugs.webkit.org/show_bug.cgi?id=50681
1314
1315         Adding the basic support to run the new-run-webkit-tests.
1316
1317         * Scripts/webkitpy/layout_tests/port/gtk.py:
1318
1319 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1320
1321         Reviewed by Kenneth Rohde Christiansen.
1322
1323         [Qt] Mock DeviceOrientation client for DRT
1324         https://bugs.webkit.org/show_bug.cgi?id=47490
1325
1326         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1327         (WebCore::DumpRenderTree::DumpRenderTree):
1328         (WebCore::DumpRenderTree::~DumpRenderTree):
1329         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1330         (LayoutTestController::setMockDeviceOrientation):
1331
1332 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1333
1334         Reviewed by Gustavo Noronha Silva.
1335
1336         [GTK] launcher: disable the Mozilla-style fullscreen API
1337         https://bugs.webkit.org/show_bug.cgi?id=50874
1338
1339         Disabling the fullscreen API until its implementation for GTK is
1340         mature enough. The webview setting for it is already FALSE by
1341         default.
1342
1343         * GtkLauncher/main.c:
1344         (createWindow):
1345
1346 2010-12-10  Eric Seidel  <eric@webkit.org>
1347
1348         Reviewed by Adam Barth.
1349
1350         commit-queue flaky test messages show cryptic version information for mac os x
1351         https://bugs.webkit.org/show_bug.cgi?id=50864
1352
1353         Turns out platform.platform() returns kernel version information
1354         which isn't helpful, and just plain confusing on Mac
1355         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1356
1357         So I've updated PlatformInfo.display_name() to special case
1358         mac.  I also found a bad use of sys.platform in the process
1359         and fixed that.  (sys.platform always returns 'darwin' on mac).
1360
1361         * Scripts/webkitpy/common/system/platforminfo.py:
1362         * Scripts/webkitpy/common/system/user.py:
1363         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1364         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1365         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1366
1367 2010-12-10  Eric Seidel  <eric@webkit.org>
1368
1369         Unreviewed.
1370
1371         Exception seen while reporting flaky test with commit-queue.
1372         Just a missing include.
1373
1374         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1375         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1376
1377 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1378
1379         Reviewed by Eric Seidel.
1380
1381         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1382         https://bugs.webkit.org/show_bug.cgi?id=50796
1383
1384         Also updating the test code to use JSONResultsGeneratorBase and
1385         to improve test coverage for incremental cases.
1386
1387         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1388         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1389
1390 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1391
1392         Reviewed by Darin Adler.
1393
1394         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1395         https://bugs.webkit.org/show_bug.cgi?id=50835
1396
1397         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1398
1399 2010-12-10  Eric Seidel  <eric@webkit.org>
1400
1401         Reviewed by Adam Barth.
1402
1403         Bugs created by the commit-queue should all block on a master bug
1404         https://bugs.webkit.org/show_bug.cgi?id=50857
1405
1406         This makes all bugs created by the commit-queue block on:
1407         https://bugs.webkit.org/show_bug.cgi?id=50856
1408
1409         In the process of testing this, I found that the existing
1410         create_bug code was wrong.  I also found that existing
1411         unit tests for create-rollout used invalid values
1412         for options.blocks.  I fixed both issues and tested.
1413
1414         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1415         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1416         * Scripts/webkitpy/tool/commands/commandtest.py:
1417         * Scripts/webkitpy/tool/commands/download_unittest.py:
1418         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1419         * Scripts/webkitpy/tool/mocktool.py:
1420         * Scripts/webkitpy/tool/steps/options.py:
1421
1422 2010-12-10  Eric Seidel  <eric@webkit.org>
1423
1424         Reviewed by Adam Barth.
1425
1426         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1427         https://bugs.webkit.org/show_bug.cgi?id=50853
1428
1429         I also discovered when doing this that the code was posting
1430         the comment on the wrong bug, but that's fixed here too.
1431
1432         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1433         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1434         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1435         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1436         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1437         * Scripts/webkitpy/tool/mocktool.py:
1438
1439 2010-12-10  Anders Carlsson  <andersca@apple.com>
1440
1441         Reviewed by John Sullivan.
1442
1443         Make WKContextGetStatistics gather global statistics
1444         https://bugs.webkit.org/show_bug.cgi?id=50850
1445
1446         Remove the code that gets the statistics and fills in the per context
1447         statistics information for now.
1448
1449         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1450         (-[BrowserStatisticsWindowController refreshStatistics:]):
1451
1452 2010-12-10  Eric Seidel  <eric@webkit.org>
1453
1454         Unreviewed.
1455
1456         commit-queue should report port/platform information when commenting on flaky test bugs
1457         https://bugs.webkit.org/show_bug.cgi?id=50839
1458
1459         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1460         which was only used by new run webkit tests (and clearly not unit tested).
1461
1462         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1463         * Scripts/webkitpy/tool/main.py:
1464         * Scripts/webkitpy/tool/mocktool.py:
1465
1466 2010-12-10  Eric Seidel  <eric@webkit.org>
1467
1468         Reviewed by Tony Chang.
1469
1470         commit-queue should report port/platform information when commenting on flaky test bugs
1471         https://bugs.webkit.org/show_bug.cgi?id=50839
1472
1473         This was a suggestion from Tony Chang this morning.
1474         I added a platform.py class so I could easily mock the platform call,
1475         but that may not be the final solution for this mocking.
1476         We'll try it and see.
1477
1478         * Scripts/webkitpy/common/system/platform.py: Added.
1479         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1480         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1481         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1482         * Scripts/webkitpy/tool/main.py:
1483         * Scripts/webkitpy/tool/mocktool.py:
1484
1485 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1486
1487         Reviewed by Joseph Pecoraro.
1488
1489         Bug 43455 - [Qt]: Implement Application Cache Quotas
1490         https://bugs.webkit.org/show_bug.cgi?id=43455
1491
1492         Introduce functions to allow new appcache layout test origin-quota.html
1493         to work correctly under Qt.
1494
1495         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1496         (WebCore::DumpRenderTree::DumpRenderTree):
1497         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1498         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1499
1500         Introduce functions to allow new appcache layout test origin-quota.html
1501         to be successful under qt. Changes required because LayoutTestControllerQt
1502         does not inherit from LayoutController.
1503
1504         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1505         (LayoutTestController::reset):
1506         (LayoutTestController::clearAllApplicationCaches):
1507         (LayoutTestController::setApplicationCacheOriginQuota):
1508         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1509         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1510         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1511
1512 2010-12-10  Eric Seidel  <eric@webkit.org>
1513
1514         Reviewed by Adam Barth.
1515
1516         Move buildbot.py into its own module so we can split it out into one-file-per-class
1517         https://bugs.webkit.org/show_bug.cgi?id=50806
1518
1519         We're adding more buildbot logic these days, so it makes sense
1520         to give buildbot its own module.
1521
1522         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1523         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1524         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1525         * Scripts/webkitpy/common/net/failuremap.py:
1526         * Scripts/webkitpy/common/net/regressionwindow.py:
1527         * Scripts/webkitpy/tool/commands/rebaseline.py:
1528
1529 2010-12-10  Tony Chang  <tony@chromium.org>
1530
1531         Reviewed by Eric Seidel.
1532
1533         Use FileSystem::remove when cleaning up http lock files
1534         https://bugs.webkit.org/show_bug.cgi?id=50830
1535
1536         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1537
1538 2010-12-10  Joone Hur  <joone@kldp.org>
1539
1540         Reviewed by Martin Robinson.
1541
1542         [GTK] DRT needs layoutTestController.setCacheModel
1543         https://bugs.webkit.org/show_bug.cgi?id=50705
1544         
1545         webkit_set_cache_mode() is called to set the cache model.
1546         
1547         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1548         (LayoutTestController::setCacheModel): Set the cache model. 
1549
1550 2010-12-10  Tony Chang  <tony@chromium.org>
1551
1552         Reviewed by Ojan Vafai.
1553
1554         [chromium] remove --use-drt and add --use-test-shell
1555         https://bugs.webkit.org/show_bug.cgi?id=50701
1556
1557         * Scripts/webkitpy/common/config/ports.py:
1558         * Scripts/webkitpy/common/config/ports_unittest.py:
1559         * Scripts/webkitpy/layout_tests/port/chromium.py:
1560         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1561         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1562         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1563         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1564         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1565         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1566         * Scripts/webkitpy/layout_tests/port/webkit.py:
1567         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1568         * Scripts/webkitpy/style/checkers/test_expectations.py:
1569         * Scripts/webkitpy/tool/commands/queries.py:
1570
1571 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1572
1573         Reviewed by Steve Block.
1574
1575         [Chromium] Implement mocks for client-based geolocation
1576         https://bugs.webkit.org/show_bug.cgi?id=46895
1577
1578         * DumpRenderTree/chromium/LayoutTestController.cpp:
1579         (LayoutTestController::setGeolocationPermission):
1580         (LayoutTestController::setMockGeolocationPosition):
1581         (LayoutTestController::setMockGeolocationError):
1582         * DumpRenderTree/chromium/LayoutTestController.h:
1583         * DumpRenderTree/chromium/WebViewHost.cpp:
1584         (WebViewHost::geolocationClient):
1585         (WebViewHost::geolocationClientMock):
1586         (WebViewHost::reset):
1587         * DumpRenderTree/chromium/WebViewHost.h:
1588
1589 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1590
1591         Reviewed by Martin Robinson.
1592
1593         [GTK] Add hasSpellingMarker support to the DRT
1594         https://bugs.webkit.org/show_bug.cgi?id=50739
1595
1596         Implemented the hasSpellingMarker to support spelling tests.
1597
1598         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1599         (LayoutTestController::hasSpellingMarker):
1600
1601 2010-12-10  Eric Seidel  <eric@webkit.org>
1602
1603         Reviewed by Ojan Vafai.
1604
1605         webkit-patch: not possible to use build-and-test with local commits
1606         https://bugs.webkit.org/show_bug.cgi?id=33378
1607
1608         Make --no-clean not even check if we have local commits.
1609         It's unclear to me why the code was originally written this way.
1610         I was unable to dig up a reason from svn history.
1611
1612         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1613         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1614
1615 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1616
1617         Reviewed by Martin Robinson.
1618
1619         [GTK] AX: implement isEnabled in DRT
1620         https://bugs.webkit.org/show_bug.cgi?id=50814
1621
1622         Implement AccessibilityUIElement::isEnabled() for GTK.
1623
1624         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1625         (checkElementState): New function to refactor common code.
1626         (AccessibilityUIElement::isEnabled): Implement this by checking
1627         the current state of the AtkObject.
1628         (AccessibilityUIElement::isSelected): Use the new
1629         checkElementState function.
1630
1631 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1632
1633         Reviewed by Kenneth Rohde Christiansen.
1634
1635         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1636         https://bugs.webkit.org/show_bug.cgi?id=50750
1637
1638         * MiniBrowser/qt/BrowserView.cpp:
1639         (BrowserView::BrowserView):
1640         * MiniBrowser/qt/BrowserView.h:
1641         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1642         (WTR::WebView::WebView):
1643
1644 2010-12-10  Joone Hur  <joone@kldp.org>
1645
1646         Reviewed by Xan Lopez.
1647
1648         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1649         https://bugs.webkit.org/show_bug.cgi?id=50808
1650
1651         Unskipping the following test cases:
1652         userscripts/mixed-case-stylesheet.html
1653         userscripts/simple-stylesheet.html
1654         userscripts/user-style-all-frames.html
1655
1656         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1657         (LayoutTestController::addUserStyleSheet):
1658
1659 2010-12-10  Joone Hur  <joone@kldp.org>
1660
1661         Reviewed by Eric Seidel.
1662
1663         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1664         https://bugs.webkit.org/show_bug.cgi?id=50783
1665
1666         This patch allows to unskip the following test cases:
1667         printing/page-rule-selection.html
1668         printing/page-format-data.html
1669
1670         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1671         (LayoutTestController::pageProperty): Added.
1672         (LayoutTestController::isPageBoxVisible): Ditto.
1673         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1674         (LayoutTestController::addUserStyleSheet): Ditto.
1675
1676 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1677
1678         Reviewed by Kenneth Rohde Christiansen.
1679
1680         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1681
1682         A menu allows to switch QNAM back to the same thread.
1683
1684         * QtTestBrowser/launcherwindow.cpp:
1685         (LauncherWindow::initializeView):
1686         (LauncherWindow::createChrome):
1687         (LauncherWindow::toggleThreadedQnam):
1688         * QtTestBrowser/launcherwindow.h:
1689         (WindowOptions::WindowOptions):
1690         * QtTestBrowser/webpage.cpp:
1691         (WebPage::WebPage):
1692         (WebPage::setQnamThreaded):
1693         * QtTestBrowser/webpage.h:
1694         (QnamThread::QnamThread):
1695         (QnamThread::~QnamThread):
1696         (QnamThread::networkAccessManager):
1697         (QnamThread::run):
1698
1699 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1700
1701         Reviewed by Xan Lopez.
1702
1703         [Gtk] style="font-family: courier" makes text disappear
1704         https://bugs.webkit.org/show_bug.cgi?id=47452
1705
1706         Add a test that verifies that fonts without valid charmaps are
1707         never selected.
1708
1709         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1710         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1711         that has no valid charmap.
1712         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1713         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1714         settings which may disable selection of bitmap fonts.
1715
1716 2010-12-10  Eric Seidel  <eric@webkit.org>
1717
1718         Unreviewed.
1719
1720         The commit-queue should file bugs about flaky tests it encounters
1721         https://bugs.webkit.org/show_bug.cgi?id=50803
1722
1723         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1724         Now it's tested.
1725
1726         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1727         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1728
1729 2010-12-10  Eric Seidel  <eric@webkit.org>
1730
1731         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1732
1733         The commit-queue should file bugs about flaky tests it encounters
1734         https://bugs.webkit.org/show_bug.cgi?id=50803
1735
1736         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1737
1738 2010-12-09  Eric Seidel  <eric@webkit.org>
1739
1740         Reviewed by Adam Barth.
1741
1742         The commit-queue should file bugs about flaky tests it encounters
1743         https://bugs.webkit.org/show_bug.cgi?id=50803
1744
1745         This change got a bit big.  I also added a new config.urls file
1746         because I needed to share the view_source_url code with committervalidator.py.
1747
1748         This adds a new class FlakyTestReporter which holds all the logic about
1749         reporting flaky tests to bugzilla.
1750
1751         Right now this code knows how to look up bugs for flaky tests.
1752         If it can't find a bug filed from the commit-queue, it will open a new
1753         one, ccing the relevant people and adding information about the failure.
1754
1755         It is not yet smart enough to chase down duplicate chains, or to include
1756         the actual failure diff.  But those can be added in later iterations.
1757
1758         * Scripts/webkitpy/common/checkout/api.py:
1759         * Scripts/webkitpy/common/checkout/changelog.py:
1760         * Scripts/webkitpy/common/checkout/commitinfo.py:
1761         * Scripts/webkitpy/common/config/committervalidator.py:
1762         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1763         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1764         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1765         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1766         * Scripts/webkitpy/tool/bot/irc_command.py:
1767         * Scripts/webkitpy/tool/bot/sheriff.py:
1768         * Scripts/webkitpy/tool/commands/download.py:
1769         * Scripts/webkitpy/tool/commands/queues.py:
1770         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1771         * Scripts/webkitpy/tool/comments.py:
1772         * Scripts/webkitpy/tool/mocktool.py:
1773         * Scripts/webkitpy/tool/steps/commit.py:
1774
1775 2010-12-09  Eric Seidel  <eric@webkit.org>
1776
1777         Reviewed by Adam Barth.
1778
1779         Teach webkit-patch how to search bugzilla
1780         https://bugs.webkit.org/show_bug.cgi?id=50500
1781
1782         This is a step towards teaching webkitpy how to file
1783         new bugs for flaky tests and update them when new flakes occur.
1784
1785         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1786         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1787         * Scripts/webkitpy/tool/commands/__init__.py:
1788         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1789
1790 2010-12-09  Adam Barth  <abarth@webkit.org>
1791
1792         Reviewed by Ojan Vafai.
1793
1794         commit-queue errors out due to local commits
1795         https://bugs.webkit.org/show_bug.cgi?id=50766
1796
1797         We seem to be tripping over having local commits in the working copy a
1798         lot recently.  I don't quite fully understand what the issue is, but
1799         this patch attempts to solve the problem by adding an explicit clean
1800         step before processing a patch.  Previously, we did the cleaning as
1801         part of the apply-attachment step, so this might not actually fix the
1802         problem.
1803
1804         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1805         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1806         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1807
1808 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Reviewed by Ojan Vafai.
1811
1812         Make new-run-webkit-tests --lint-test-files log slightly better
1813         messages and return -1 if lint fails. Remove the
1814         'suppress_errors' keyword param to the TestExpectationsFile
1815         class, and clean up logging and exception raising for error
1816         handling. Also add more unit tests and clean up the unit test code a bit.
1817
1818         https://bugs.webkit.org/show_bug.cgi?id=50205
1819
1820         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1821         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1822         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1823         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1824         * Scripts/webkitpy/layout_tests/port/chromium.py:
1825         * Scripts/webkitpy/style/checkers/test_expectations.py:
1826         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1827
1828 2010-12-09  Tony Chang  <tony@chromium.org>
1829
1830         Unreviewed, fix for windows code.  We were catching the wrong
1831         exception in Windows.
1832
1833         * Scripts/webkitpy/common/system/filesystem.py:
1834
1835 2010-12-09  Antonio Gomes  <agomes@rim.com>
1836
1837         Reviewed by Martin Robinson.
1838
1839         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1840         https://bugs.webkit.org/show_bug.cgi?id=48429
1841
1842         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1843
1844         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1845         (LayoutTestController::workerThreadCount):
1846
1847 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1848
1849         Reviewed by Martin Robinson.
1850
1851         [GTK] Support the Mozilla-style Fullscreen Javascript API
1852         https://bugs.webkit.org/show_bug.cgi?id=50572
1853
1854         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1855         make DRT update the Chrome when the WebView settings have been
1856         reset to consistent values.
1857
1858         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1859         (resetDefaultsToConsistentValues):
1860         * GtkLauncher/main.c:
1861         (create_window):
1862         * Scripts/build-webkit:
1863
1864 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1865
1866         Reviewed by Tor Arne Vestbø
1867
1868         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1869         https://bugs.webkit.org/show_bug.cgi?id=50742
1870
1871         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1872
1873         * Scripts/webkitdirs.pm:
1874
1875 2010-12-09  Joone Hur  <joone@kldp.org>
1876
1877          Reviewed by Martin Robinson.
1878
1879          [GTK] Support for viewport meta tag
1880          https://bugs.webkit.org/show_bug.cgi?id=45443
1881
1882          Add support for testing the viewport properties for WebKitGtk.
1883
1884          * DumpRenderTree/LayoutTestController.cpp:
1885          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1886          (LayoutTestController::staticFunctions):
1887          * DumpRenderTree/LayoutTestController.h:
1888          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1889          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1890          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1891          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1892          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1893          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1894          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1895          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1896          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1897          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1898
1899 2010-12-08  William Siegrist <wsiegrist@apple.com>
1900
1901         Reviewed by Eric Seidel.
1902
1903         Migrate buildbot.py from xmlrpc to json.
1904         https://bugs.webkit.org/show_bug.cgi?id=50647
1905
1906         * Scripts/webkitpy/common/net/buildbot.py:
1907
1908 2010-12-08  Tony Chang  <tony@chromium.org>
1909
1910         Reviewed by Eric Seidel.
1911
1912         make starting the websocket server more reliable on windows
1913         https://bugs.webkit.org/show_bug.cgi?id=50712
1914
1915         * Scripts/webkitpy/common/system/filesystem.py:
1916         (remove): Substitute method for os.remove to retry on error on Windows
1917         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1918         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1919
1920 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1921
1922         Reviewed by Adam Roben.
1923
1924         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1925         https://bugs.webkit.org/show_bug.cgi?id=50656
1926
1927         * MiniBrowser/mac/BrowserWindowController.m:
1928         (-[BrowserWindowController awakeFromNib]):
1929         Indicate that exceededDatabaseQuota is not implemented.
1930         * MiniBrowser/win/BrowserView.cpp:
1931         (BrowserView::create):
1932         Ditto.
1933         * WebKitTestRunner/TestController.cpp:
1934         (WTR::createOtherPage):
1935         Ditto.
1936         (WTR::TestController::initialize):
1937         Ditto.
1938
1939 2010-12-08  Antonio Gomes  <agomes@rim.com>
1940
1941         Reviewed by Martin Robinson.
1942
1943         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1944         https://bugs.webkit.org/show_bug.cgi?id=48429
1945
1946         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1947         * webkit_gc_collect_javascript_objects;
1948         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1949         * webkit_gc_count_javascript_objects;
1950         * webkit_web_frame_layout.
1951
1952         These were all only used by GTK+ DRT.
1953
1954         * DumpRenderTree/gtk/EventSender.cpp:
1955         (dispatchEvent):
1956         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1957         (GCController::collect):
1958         (GCController::collectOnAlternateThread):
1959         (GCController::getJSObjectCount):
1960
1961 2010-12-07  Tony Chang  <tony@chromium.org>
1962
1963         Reviewed by Ojan Vafai.
1964
1965         [chromium] force NRWT to use DRT
1966         https://bugs.webkit.org/show_bug.cgi?id=50359
1967
1968         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1969
1970 2010-12-06  Sam Weinig  <sam@webkit.org>
1971
1972         Reviewed by Anders Carlsson.
1973
1974         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1975         https://bugs.webkit.org/show_bug.cgi?id=50584
1976
1977         * MiniBrowser/mac/BrowserWindowController.m:
1978         (didSameDocumentNavigationForFrame):
1979         (-[BrowserWindowController awakeFromNib]):
1980         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1981         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1982         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1983         (TestWebKitAPI::TEST):
1984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1985         (WTR::InjectedBundlePage::InjectedBundlePage):
1986         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1987         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1988         * WebKitTestRunner/TestController.cpp:
1989         (WTR::TestController::initialize):
1990
1991 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1992
1993         Reviewed by Ojan Vafai.
1994
1995         Make TestResultsServer return 404 for non-existing results files.
1996         https://bugs.webkit.org/show_bug.cgi?id=50581
1997
1998         * TestResultServer/handlers/testfilehandler.py:
1999
2000 2010-12-06  Tony Chang  <tony@chromium.org>
2001
2002         Reviewed by Ojan Vafai.
2003
2004         [chromium] fix an assert hit in DRT
2005         https://bugs.webkit.org/show_bug.cgi?id=50575
2006
2007         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
2008         semantics.
2009
2010         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2011         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2012         WTF::RefCountedBase::ref()).
2013
2014         * DumpRenderTree/chromium/TestWebWorker.h:
2015         (TestWebWorker::TestWebWorker):
2016
2017 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2018
2019         Reviewed by Eric Seidel.
2020
2021         make webkit-patch command work when the git branch is not synced to the remote svn branch
2022         https://bugs.webkit.org/show_bug.cgi?id=50424
2023
2024         * Scripts/webkitpy/common/checkout/scm.py:
2025         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2026
2027 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2028
2029         Reviewed by Andreas Kling.
2030
2031         [WINCE] Add build system
2032         https://bugs.webkit.org/show_bug.cgi?id=50522
2033
2034         * CMakeListsWinCE.txt: Added.
2035
2036 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2037
2038         Reviewed by Tony Chang.
2039
2040         Allow the Chromium port to have Leopard-specific baselines
2041         https://bugs.webkit.org/show_bug.cgi?id=50506
2042
2043         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2044
2045 2010-12-03  Tony Chang  <tony@chromium.org>
2046
2047         Reviewed by Kent Tamura.
2048
2049         [chromium] fix 2 bugs with inspector tests in DRT
2050         https://bugs.webkit.org/show_bug.cgi?id=50492
2051
2052         Tasks can outlive the tasklist (even when canceled) so this was
2053         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2054         when a task is canceled.
2055
2056         Also fix an assert when closing devtool windows by copying some
2057         logic from test_shell.
2058
2059         * DumpRenderTree/chromium/Task.cpp:
2060         (WebTask::~WebTask):
2061         (TaskList::revokeAll):
2062         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2063             the tasklist (since the task can outlive the tasklist).
2064         * DumpRenderTree/chromium/TestShell.h:
2065         (TestShell::devToolsWebView):
2066         * DumpRenderTree/chromium/WebViewHost.cpp:
2067         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2068             a window if the window has devtools loaded.  This avoids an
2069             ASSERT and matches test_shell.
2070
2071 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2072
2073         Reviewed by Martin Robinson.
2074
2075         [GTK] Fix GtkLauncher.c style, use webkit style
2076         https://bugs.webkit.org/show_bug.cgi?id=50542
2077
2078         * GtkLauncher/main.c:
2079         (activateUriEntryCb):
2080         (updateTitle):
2081         (linkHoverCb):
2082         (notifyTitleCb):
2083         (notifyLoadStatusCb):
2084         (notifyProgressCb):
2085         (destroyCb):
2086         (goBackCb):
2087         (goForwardCb):
2088         (create_webViewCb):
2089         (webViewReadyCb):
2090         (closeWebViewCb):
2091         (createBrowser):
2092         (createStatusbar):
2093         (createToolbar):
2094         (createWindow):
2095         (main):
2096
2097 2010-12-04  Antonio Gomes  <agomes@rim.com>
2098
2099         Reviewed by Martin Robinson.
2100
2101         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2102         https://bugs.webkit.org/show_bug.cgi?id=48429
2103
2104         Moved more private method declared with WEBKIT_API to
2105         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2106
2107         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2108         (resetDefaultsToConsistentValues):
2109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2110         (LayoutTestController::addOriginAccessWhitelistEntry):
2111         (LayoutTestController::execCommand):
2112         (LayoutTestController::isCommandEnabled):
2113
2114 2010-12-04  Antonio Gomes  <agomes@rim.com>
2115
2116         Reviewed by Andreas Kling.
2117
2118         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2119
2120         Method was removed by http://trac.webkit.org/changeset/71604
2121
2122         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2123
2124 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2125
2126         Reviewed by Xan Lopez.
2127
2128         [GTK] Fix compilation warnings reported by clang
2129         https://bugs.webkit.org/show_bug.cgi?id=50252
2130
2131         * GtkLauncher/main.c:
2132         (create_window): The create_statusbar function does not have
2133         parameters.
2134
2135 2010-12-05  Robert Hogan  <robert@webkit.org>
2136
2137         Reviewed by Andreas Kling.
2138
2139         [Qt] Zero-sized font does not yet work
2140
2141         Fix fast/text/font-size-zero.html
2142
2143         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2144
2145         https://bugs.webkit.org/show_bug.cgi?id=49759
2146
2147         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2148         (WebCore::WebPage::WebPage):
2149
2150 2010-12-04  Sam Weinig  <sam@webkit.org>
2151
2152         Reviewed by Jon Honeycutt.
2153
2154         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2155         https://bugs.webkit.org/show_bug.cgi?id=50511
2156
2157         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2158         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2159
2160         * MiniBrowser/mac/BrowserWindowController.m:
2161         (didChangeLocationWithinPageForFrame):
2162         (-[BrowserWindowController awakeFromNib]):
2163         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2164         * TestWebKitAPI/PlatformUtilities.cpp:
2165         (TestWebKitAPI::Util::toWK):
2166         * TestWebKitAPI/PlatformUtilities.h:
2167         (TestWebKitAPI::Util::adoptWK):
2168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2169         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2170         (TestWebKitAPI::nullJavaScriptCallback):
2171         (TestWebKitAPI::didFinishLoadForFrame):
2172         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2173         (TestWebKitAPI::TEST):
2174         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2175         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2176         * TestWebKitAPI/win/copy-resources.cmd:
2177         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2178         (WTR::InjectedBundlePage::InjectedBundlePage):
2179         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2180         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2181         * WebKitTestRunner/TestController.cpp:
2182         (WTR::TestController::initialize):
2183
2184 2010-11-08  Antonio Gomes  <agomes@rim.com>
2185
2186         Reviewed by Martin Robinson.
2187
2188         [Gtk] Populate DumpRenderTreeSupportGtk
2189         https://bugs.webkit.org/show_bug.cgi?id=48429
2190
2191         Made the previous calls to webkit_web_frame* functions defined as private
2192         APIs in webkitprivate.h go through DRTSupportGtk.
2193
2194         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2195         (AccessibilityController::focusedElement):
2196         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2197         (dumpFramesAsText):
2198         (resetDefaultsToConsistentValues):
2199         (dump):
2200         (webViewDocumentLoadFinished):
2201         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2202         (LayoutTestController::counterValueForElementById):
2203         (LayoutTestController::pageNumberForElementById):
2204         (LayoutTestController::numberOfPages):
2205         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2206         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2207         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2208         (LayoutTestController::numberOfActiveAnimations):
2209         (LayoutTestController::suspendAnimations):
2210         (LayoutTestController::resumeAnimations):
2211         (LayoutTestController::markerTextForListItem):
2212
2213 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2214
2215         Reviewed by Tony Chang.
2216
2217         Rebaseline server: use pretty text diff output
2218         https://bugs.webkit.org/show_bug.cgi?id=50484
2219         
2220         Serve *-pretty-diff.html for text diff output.
2221
2222         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2223         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2224         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2225         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2226
2227 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2228
2229         Unreviewed, rolling out r73302.
2230         http://trac.webkit.org/changeset/73302
2231         https://bugs.webkit.org/show_bug.cgi?id=50499
2232
2233         Causes crashes in debug LayoutTests (Requested by xan_ on
2234         #webkit).
2235
2236         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2237         (AccessibilityUIElement::AccessibilityUIElement):
2238         (AccessibilityUIElement::parentElementCallback):
2239         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2240         * DumpRenderTree/chromium/CppBoundClass.cpp:
2241         * DumpRenderTree/chromium/CppBoundClass.h:
2242
2243 2010-12-03  Sam Weinig  <sam@webkit.org>
2244
2245         Reviewed by Maciej Stachowiak.
2246
2247         Enable <a ping> for Mac/Windows/WebKit2 builds
2248         <rdar://problem/8504473>
2249         https://bugs.webkit.org/show_bug.cgi?id=50488
2250
2251         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2252         (TestWebKitAPI::TEST): Test that the default value of
2253         WKPreferencesGetHyperlinkAuditingEnabled is true.
2254
2255 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2256
2257         Reviewed by Chris Fleizach.
2258
2259         Include the FrameView widget of a RenderWidget in the accessibility tree.
2260         https://bugs.webkit.org/show_bug.cgi?id=49106
2261
2262         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2263         (AccessibilityUIElement::AccessibilityUIElement):
2264         (AccessibilityUIElement::parentElementCallback):
2265         (AccessibilityUIElement::isEqualCallback):
2266         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2267         * DumpRenderTree/chromium/CppBoundClass.cpp:
2268         (CppBoundClass::getFromCppVariant):
2269         * DumpRenderTree/chromium/CppBoundClass.h:
2270
2271 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2272
2273         Reviewed by Tony Chang.
2274
2275         Rebaseline server: organize tests by state, add dry run mode
2276         https://bugs.webkit.org/show_bug.cgi?id=50473
2277         
2278         Group tests in the menu by state, so that it's easier to see after
2279         processing the queue which failed.
2280         
2281         Add support for the --dry-run flag so that it's easier to test changes
2282         such as this (stubs out filesystem and SCM operations).
2283
2284         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2285         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2286         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2287
2288 2010-12-03  Brady Eidson  <beidson@apple.com>
2289
2290         Reviewed by Anders Carlsson.
2291
2292         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2293         WebKit2 Authentication Support
2294
2295         Keep these builds working:
2296         * MiniBrowser/mac/BrowserWindowController.m:
2297         (-[BrowserWindowController awakeFromNib]):
2298
2299         * WebKitTestRunner/TestController.cpp:
2300         (WTR::TestController::initialize):
2301
2302 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2303
2304         Reviewed by Tony Chang.
2305
2306         Rebaseline server: move existing baselines
2307         https://bugs.webkit.org/show_bug.cgi?id=50421
2308         
2309         Implement moving of existing baselines: move all files that are about
2310         to be overwriten by update baselines.
2311         
2312         Also fix a typo in the UI JS.
2313
2314         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2315         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2316         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2317
2318 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2319
2320         Unreviewed, rolling out r73211.
2321         http://trac.webkit.org/changeset/73211
2322         https://bugs.webkit.org/show_bug.cgi?id=50450
2323
2324         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2325         yutak on #webkit).
2326
2327         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2328
2329 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2330
2331         Unreviewed, rolling out r73222.
2332         http://trac.webkit.org/changeset/73222
2333         https://bugs.webkit.org/show_bug.cgi?id=50449
2334
2335         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2336         (Requested by yutak on #webkit).
2337
2338         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2339         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2340         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2341         * Scripts/webkitpy/layout_tests/port/base.py:
2342         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2343         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2344
2345 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2346
2347         Unreviewed, rolling out r73228.
2348         http://trac.webkit.org/changeset/73228
2349         https://bugs.webkit.org/show_bug.cgi?id=50448
2350
2351         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2352         (Requested by yutak on #webkit).
2353
2354         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2355         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2356         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2357         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2358         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2359
2360 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2361
2362         Unreviewed, rolling out r73231.
2363         http://trac.webkit.org/changeset/73231
2364         https://bugs.webkit.org/show_bug.cgi?id=50443
2365
2366         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2367         (Requested by yutak on #webkit).
2368
2369         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2370         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2371         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2372         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2373
2374 2010-12-03  David Levin  <levin@chromium.org>
2375
2376         Reviewed by Shinichiro Hamaji.
2377
2378         check-webkit-style: false positive reported for #if macro
2379         https://bugs.webkit.org/show_bug.cgi?id=48242
2380
2381         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2382           all preprocessor commands.
2383         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2384
2385 2010-12-02  Eric Seidel  <eric@webkit.org>
2386
2387         Reviewed by Adam Barth.
2388
2389         Update the EWSTools scripts to use modern-style git repos
2390         https://bugs.webkit.org/show_bug.cgi?id=50402
2391
2392         * EWSTools/create-webkit-git:
2393         * EWSTools/start-commit-queue.sh:
2394         * EWSTools/start-queue.sh:
2395
2396 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2397
2398         Fix Chromium Linux plugin tests by not logging
2399         unconditionally from the event handling code.
2400
2401         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2402         (handleEventX11):
2403
2404 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2405
2406         Reviewed by Tony Chang.
2407
2408         nrwt multiprocessing - move logic back into run_webkit_tests
2409
2410         This change moves a bunch of logic that I had put into
2411         message_broker back into run_webkit_tests, in a slightly
2412         different format. WorkerMessageBroker needed to become less aware of
2413         the logic the TestRunner class uses, and more generic.
2414         Eventually the MessageBroker will only do generic messaging and
2415         thread/process-pooling, and (almost) all of the
2416         run-webkit-tests-specific logic will be moved to
2417         run_webkit_tests.py and dump_render_tree_thread.py.
2418         
2419         The biggest changes are that the Broker can now start a single
2420         worker, but the responsibility for starting all of them is pushed
2421         back to the TestRunner (Manager), and the logic for checking if
2422         the threads are done or wedged is moved back to TestRunner. We
2423         also remove WorkerMessageBroker.cleanup (not needed) and
2424         cancel_workers (they have to be cancelled individually).
2425         
2426         The  message_broker is now encapsulated inside
2427         TestRunner._run_tests(); it only needs to exist while actually
2428         running the tests.
2429
2430         Also, delete a bunch of tests in message_broker_unittest that no
2431         longer make much sense.
2432
2433         This patch depends on bug 50372.
2434
2435         https://bugs.webkit.org/show_bug.cgi?id=50374
2436
2437         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2438         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2439         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2440         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2441         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2442
2443 2010-12-02  Hayato Ito  <hayato@chromium.org>
2444
2445         Reviewed by Eric Seidel.
2446
2447         Refactor test_types's compare_output() method so that it takes a
2448         TestInput object.
2449
2450         compare_output() will need additional information included in a TestInput
2451         object to support reftests. This change is a pre-requirement of that.
2452
2453         https://bugs.webkit.org/show_bug.cgi?id=50362
2454
2455         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2456         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2457         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2458         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2459         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2460
2461 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2462
2463         Reviewed by Anders Carlsson.
2464
2465         Add the ability to run script on 'new' and 'paint' in the test plugin
2466         https://bugs.webkit.org/show_bug.cgi?id=50425
2467         
2468         Add "onnew" and "onpaintevent" attributes to the test plugin,
2469         so that tests can run JS at these times.
2470
2471         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2472         (pluginAllocate):
2473         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2474         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2475         (NPP_New):
2476         (NPP_Destroy):
2477         (handleEventCarbon):
2478         (handleEventCocoa):
2479         (NPP_HandleEvent):
2480
2481 2010-12-02  Sam Weinig  <sam@webkit.org>
2482
2483         Fix Qt build.
2484
2485         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2486         (WTR::PlatformWebView::PlatformWebView):
2487
2488 2010-12-02  Sam Weinig  <sam@webkit.org>
2489
2490         Reviewed by Anders Carlsson.
2491
2492         WebKit2 Preferences should be held off the PageGroup, not the Context
2493         https://bugs.webkit.org/show_bug.cgi?id=50414
2494
2495         Update for API changes.
2496
2497         * WebKitTestRunner/PlatformWebView.h:
2498         * WebKitTestRunner/TestController.cpp:
2499         (WTR::createOtherPage):
2500         (WTR::TestController::initialize):
2501         (WTR::TestController::resetStateToConsistentValues):
2502         * WebKitTestRunner/TestController.h:
2503         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2504         (WTR::PlatformWebView::PlatformWebView):
2505         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2506         (WTR::PlatformWebView::PlatformWebView):
2507
2508 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2509
2510         Reviewed by Tony Chang.
2511
2512         new-run-webkit-tests: minor cleanup for multiprocessing work
2513
2514         This change:
2515         * moves worker naming into TestShellThread, eliminating a
2516           parameter to the constructor and putting the responsibility in
2517           the correct place.
2518         * eliminates the _WorkerState() class in message_broker, because
2519           it turns out that state really needs to be in run_webkit_tests
2520         * renames the Broker classes to be module-private.
2521         * fixes a bunch of minor commenting and whitespace issues to
2522           make subsequent patches a bit clearer.
2523         * Adds a Port hook for default_worker_model() so that we can
2524           accomodate the potential for different worker models on
2525           different ports.
2526         * merge in the fix from 50420 for the brokenness introduced in
2527           bug 50367.
2528
2529         This patch depends on bug 50367.
2530
2531         https://bugs.webkit.org/show_bug.cgi?id=50372
2532
2533         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2534         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2535         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2536         * Scripts/webkitpy/layout_tests/port/base.py:
2537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2538         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2539
2540 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2541
2542         Reviewed by Tony Chang.
2543
2544         This change is a bunch of cleanup / refactoring of the file
2545         below. It moves a bunch of free functions to methods on the
2546         TestShellThread class, and restructures other methods to be
2547         closer to the structure we'll need for the multiprocessing
2548         rewrite.
2549
2550         It also makes the logic of --run-singly a *lot* easier to follow
2551         by nestling all of the separate-thread logic into a single
2552         routine.
2553
2554         There should be no semantic changes in this patch, just cleanup.
2555
2556         https://bugs.webkit.org/show_bug.cgi?id=50367
2557
2558         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2559
2560 2010-12-02  Tony Chang  <tony@chromium.org>
2561
2562         Unreviewed, rolling out r73164.
2563         http://trac.webkit.org/changeset/73164
2564         https://bugs.webkit.org/show_bug.cgi?id=50359
2565
2566         broke debugger tests on win
2567
2568         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2569
2570 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2571
2572         Reviewed by Tony Chang.
2573
2574         Rebaseline server: add updating of baselines
2575         https://bugs.webkit.org/show_bug.cgi?id=50305
2576         
2577         Implements updating of baselines, where we copy -actual.* files over
2578         the current -expected.* files. To do this, we need a
2579         _get_actual_result_files method to get test results files and a
2580         _rebaseline_test method to actually do the file copy and SCM operation.
2581         _rebaseline_test logs output into a buffer, this is useful for both
2582         showing result in the UI and for unit tests.
2583         
2584         To make passing around of the various test environment properties
2585         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2586         class for them.
2587         
2588         Moving of existing baselines is not implemented yet, this patch is big
2589         enough as it is.
2590
2591         * Scripts/webkitpy/common/system/filesystem.py:
2592         * Scripts/webkitpy/common/system/filesystem_mock.py:
2593         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2594         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2595         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2596         * Scripts/webkitpy/tool/mocktool.py:
2597
2598 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2599
2600         Unreviewed build fix after vcproj updates.
2601
2602         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2603         that WIN_CAIRO is defined for this build.
2604         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2605         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2606         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2607
2608 2010-12-02  Sam Weinig  <sam@webkit.org>
2609
2610         Reviewed by Anders Carlsson.
2611
2612         WebKit2 needs API to turn on popup blocking
2613         https://bugs.webkit.org/show_bug.cgi?id=50407
2614
2615         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2616         (TestWebKitAPI::TEST):
2617         * WebKitTestRunner/TestController.cpp:
2618         (WTR::TestController::resetStateToConsistentValues):
2619
2620 2010-12-01  Tony Chang  <tony@chromium.org>
2621
2622         Reviewed by Ojan Vafai.
2623
2624         [chromium] force NRWT to use DRT
2625         https://bugs.webkit.org/show_bug.cgi?id=50359
2626
2627         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2628
2629 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2630
2631         Reviewed by Xan Lopez.
2632
2633         [GTK] DumpRenderTree has two copies of JavaScriptCore
2634         https://bugs.webkit.org/show_bug.cgi?id=49877
2635
2636         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2637         LDADD list for DumpRenderTree.
2638
2639 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2640
2641         Unreviewed: Added myself to list of Committers.
2642
2643         * Scripts/webkitpy/common/config/committers.py:
2644
2645 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2646
2647         Reviewed by Adam Barth.
2648
2649         build-webkit --chromium always updates DEPS and re-generates project files
2650         https://bugs.webkit.org/show_bug.cgi?id=50340
2651         
2652         Make build-webkit --chromium invoke update-webkit-chromium only when
2653         --update-chromium is passed in, so that we don't add 20 seconds to all
2654         builds.
2655         
2656         Making all invocations update was added with r61883, with the goal of
2657         making EWS bots always update. The bots will switch to using this flag
2658         (as will all other webkit-patch build steps) so nothing should change
2659         for them.
2660
2661         * Scripts/webkitdirs.pm:
2662         * Scripts/webkitpy/common/config/ports.py:
2663         * Scripts/webkitpy/common/config/ports_unittest.py:
2664
2665 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2666
2667         Reviewed by Tony Chang.
2668
2669         new-run-webkit-tests: add a --dry-run / -n flag
2670         https://bugs.webkit.org/show_bug.cgi?id=50045
2671
2672         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2673         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2674
2675 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2676
2677         Reviewed by Adam Roben.
2678
2679         WinCairo build should not use link-time code generation (LTCG)
2680         https://bugs.webkit.org/show_bug.cgi?id=50353
2681
2682         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2683         * DumpRenderTree/win/DumpRenderTree.vcproj:
2684         * DumpRenderTree/win/ImageDiff.vcproj:
2685         * FindSafari/FindSafari.vcproj:
2686         * MiniBrowser/MiniBrowser.vcproj:
2687         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2688         * WebKitAPITest/WebKitAPITest.vcproj:
2689         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2690         * WebKitTestRunner/win/InjectedBundle.vcproj:
2691         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2692         * WinLauncher/WinLauncher.vcproj:
2693         * record-memory-win/record-memory-win.vcproj:
2694
2695 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2696
2697         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2698         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2699         adding the file to the sources list was not enough to force the rebuild.
2700
2701         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2702         Remove an empty line at the end of this file to force a rebuild.
2703
2704 2010-12-01  Sam Weinig  <sam@webkit.org>
2705
2706         Fix windows build.
2707
2708         * MiniBrowser/win/BrowserView.cpp:
2709         (BrowserView::create):
2710
2711 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2712
2713         Add missing file to the TestNetscapePlugin sources list after r73057.
2714
2715         * GNUmakefile.am: Add missing file.
2716
2717 2010-12-01  Sam Weinig  <sam@webkit.org>
2718
2719         Reviewed by Anders Carlsson.
2720
2721         Add PageGrouping to WebKit2 API
2722         https://bugs.webkit.org/show_bug.cgi?id=50332
2723
2724         - Update testing harnesses to deal with new PageGroup API.
2725
2726         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2727         (WKBundleInitialize):
2728         * TestWebKitAPI/InjectedBundleController.cpp:
2729         (TestWebKitAPI::InjectedBundleController::initialize):
2730         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2731         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2732         * TestWebKitAPI/InjectedBundleController.h:
2733         * TestWebKitAPI/InjectedBundleTest.h:
2734         (TestWebKitAPI::InjectedBundleTest::initialize):
2735         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2736         * TestWebKitAPI/PlatformUtilities.cpp:
2737         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2738         * TestWebKitAPI/PlatformUtilities.h:
2739         * TestWebKitAPI/PlatformWebView.h:
2740         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2741         (TestWebKitAPI::TEST):
2742         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2743         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2744         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2745         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2746         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2747         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2748         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2749         (WTR::InjectedBundle::didInitializePageGroup):
2750         (WTR::InjectedBundle::initialize):
2751         (WTR::InjectedBundle::beginTesting):
2752         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2753         (WTR::InjectedBundle::pageGroup):
2754         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2755         (WTR::LayoutTestController::addUserScript):
2756         (WTR::LayoutTestController::addUserStyleSheet):
2757         (WTR::LayoutTestController::setXSSAuditorEnabled):
2758         * WebKitTestRunner/TestController.cpp:
2759         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2760         (WTR::PlatformWebView::PlatformWebView):
2761
2762 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2763
2764         Reviewed by Adam Roben.
2765
2766         vcproj changes can't be applied cleanly by the Windows EWS bot
2767         https://bugs.webkit.org/show_bug.cgi?id=50328
2768
2769         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2770         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2771         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2772         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2773         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2774         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2775         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2776         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2777         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2778         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2779         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2780         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2781         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2782         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2783         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2784         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2785         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2786         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2787         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2788         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2789         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2790         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2791         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2792         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2793         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2794         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2795         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2796         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2797         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2798         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2799         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2800         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2801         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2802         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2803         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2804         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2805         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2806         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2807         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2808         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2809         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2810         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2811         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2812         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2813         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2814
2815 2010-12-01  Anders Carlsson  <andersca@apple.com>
2816
2817         Reviewed by Darin Adler.
2818
2819         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2820         https://bugs.webkit.org/show_bug.cgi?id=50336
2821
2822         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2823         Add new test.
2824
2825         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2826         (PluginTest::NPP_New):
2827         Add default implementation/
2828
2829         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2830         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2831         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2832         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2833         Get the user agent.
2834
2835         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2836         (NPP_New):
2837         Call PluginTest::NPP_New.
2838
2839         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2840         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2841         Add new files.
2842
2843         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2844         (webkit_test_plugin_new_instance):
2845         Call PluginTest::NPP_New.
2846
2847 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2848
2849         [wx] Build fixes after recent trunk changes.
2850
2851         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2852         (LayoutTestController::findString):
2853         * wx/build/settings.py:
2854
2855 2010-12-01  Dan Bernstein  <mitz@apple.com>
2856
2857         Reviewed by Darin Adler.
2858
2859         WebKitTestRunner needs layoutTestController.findString
2860         https://bugs.webkit.org/show_bug.cgi?id=50238
2861
2862         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2863         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2864         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2865         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2866
2867 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2868
2869         Try using svn:eol-style native on a vcproj file.
2870
2871         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2872
2873 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2874
2875         Reviewed by Adam Roben.
2876
2877         [WINCE] Add WinCELauncher
2878         https://bugs.webkit.org/show_bug.cgi?id=50217
2879
2880         * WinCELauncher/main.cpp: Added.
2881
2882 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2883
2884         Reviewed by Kenneth Rohde Christiansen.
2885
2886         [Qt] Implement layoutTestController.findString
2887         https://bugs.webkit.org/show_bug.cgi?id=50236
2888
2889         Add the missing function to the LayoutTestController.
2890
2891         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2892         (LayoutTestController::findString):
2893         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2894
2895 2010-11-30  Tony Chang  <tony@chromium.org>
2896
2897         Reviewed by Adam Barth.
2898
2899         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2900         https://bugs.webkit.org/show_bug.cgi?id=49036
2901
2902         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2903             for CppVariants.
2904         (LayoutTestController::cppVariantToBool):
2905         (LayoutTestController::cppVariantToInt32):
2906         (LayoutTestController::setDatabaseQuota):
2907         (LayoutTestController::evaluateInWebInspector):
2908         (LayoutTestController::setMockGeolocationError):
2909
2910 2010-11-30  Eric Seidel  <eric@webkit.org>
2911
2912         Reviewed by Tony Chang.
2913
2914         update-webkit should call git fetch before git svn rebase
2915         https://bugs.webkit.org/show_bug.cgi?id=50273
2916
2917         After discussion on webkit-dev, we've decided to move the "default"
2918         git setup to pulling updates from git.webkit.org in preference
2919         to rebuilding the local svn index using git svn fetch every time.
2920
2921         This change should have no effect on people using the "old" git setup
2922         and should dramatically increase the speed of updates for those using
2923         the "new" git setup along with update-webkit.  I'm about to move the
2924         EWS and other queues over to this setup once this lands.
2925
2926         * Scripts/update-webkit:
2927
2928 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2929
2930         Reviewed by Xan Lopez.
2931
2932         GTK: AX: implement press in DRT
2933         https://bugs.webkit.org/show_bug.cgi?id=36146
2934
2935         Implement AccessibilityUIElement::press() for GTK.
2936
2937         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2938         (AccessibilityUIElement::press): Implemented.
2939
2940 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2941
2942         Reviewed by Tony Chang.
2943
2944         config.webkit_base_dir returns a path with a trailing slash
2945         https://bugs.webkit.org/show_bug.cgi?id=50197
2946         
2947         config.webkit_base_dir() should return a path without a trailing slash,
2948         like all the other methods that return paths.
2949         
2950         Undoes MockFileSytem changes by r72640, since they're no longer
2951         necessary for GetBaselinesTest to pass.
2952
2953         * Scripts/webkitpy/common/system/filesystem_mock.py:
2954         * Scripts/webkitpy/layout_tests/port/base.py:
2955         * Scripts/webkitpy/layout_tests/port/config.py:
2956         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2957
2958 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2959
2960         Reviewed by Tony Chang.
2961
2962         Rebaseline server: baseline display tweaks
2963         https://bugs.webkit.org/show_bug.cgi?id=50207
2964         
2965         Determine which baselines were used when running the tests and highlight
2966         them in the UI. Sort platform names alphabetically.
2967         
2968         Also makes the server URL be launched in the user's browser
2969         automatically.
2970
2971         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2972         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2973         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2974         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2975         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2976
2977 2010-11-30  Dan Bernstein  <mitz@apple.com>
2978
2979         Reviewed by Anders Carlsson.
2980
2981         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2982         https://bugs.webkit.org/show_bug.cgi?id=50238
2983
2984         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2985         (WTR::LayoutTestController::findString): Added.
2986         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2987
2988 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2989
2990         Reviewed by Adam Roben.
2991
2992         All projects on Windows should use cmd files for build events
2993         https://bugs.webkit.org/show_bug.cgi?id=50213
2994
2995         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2996         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2997         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2998         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2999         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
3000         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
3001         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3002         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
3003         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
3004         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
3005         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3006         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
3007         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
3008         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3009         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3010         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3011         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3012         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3013         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
3014         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
3015         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3016         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3017         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
3018         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
3019         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
3020         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
3021         * WinLauncher/WinLauncherCommon.vsprops:
3022         * WinLauncher/WinLauncherPostBuild.cmd: Added.
3023         * WinLauncher/WinLauncherPreBuild.cmd: Added.
3024
3025 2010-11-29  Dan Bernstein  <mitz@apple.com>
3026
3027         GTK DumpRenderTree build fix after r72887.
3028
3029         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3030         (LayoutTestController::findString):
3031
3032 2010-11-29  Dan Bernstein  <mitz@apple.com>
3033
3034         Windows DumpRenderTree build fix after r72887.
3035
3036         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3037         (LayoutTestController::findString): Added empty implementation.
3038
3039 2010-11-29  Dan Bernstein  <mitz@apple.com>
3040
3041         Reviewed by Darin Adler.
3042
3043         DumpRenderTree changes for testing the text search API.
3044         https://bugs.webkit.org/show_bug.cgi?id=50038
3045
3046         * DumpRenderTree/LayoutTestController.cpp:
3047         (findStringCallback):
3048         (LayoutTestController::staticFunctions):
3049         * DumpRenderTree/LayoutTestController.h:
3050         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3051         (LayoutTestController::findString):
3052         * MiniBrowser/mac/BrowserWindowController.m:
3053         (-[BrowserWindowController find:]):
3054
3055 2010-11-29  Johnny Ding  <jnd@chromium.org>
3056
3057         Unreviewed: Add myself to the list of Committers.
3058
3059         * Scripts/webkitpy/common/config/committers.py:
3060
3061 2010-11-29  Mark Rowe  <mrowe@apple.com>
3062
3063         Reviewed by Adele Peterson.
3064
3065         <rdar://problem/8694997> DumpRenderTree fails to build.
3066
3067         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
3068
3069 2010-11-29  Mark Rowe  <mrowe@apple.com>
3070
3071         Reviewed by Adele Peterson.
3072
3073         <rdar://problem/8694997> DumpRenderTree fails to build.
3074
3075         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
3076         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
3077         * DumpRenderTree/mac/PerlSupport/Makefile:
3078
3079 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
3080
3081         Reviewed by Martin Robinson.
3082
3083         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
3084         https://bugs.webkit.org/show_bug.cgi?id=50154
3085
3086         Added missing checks to allAttributes().
3087
3088         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3089         (AccessibilityUIElement::allAttributes): Added missing checks.
3090
3091 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3092
3093         Reviewed by Kenneth Rohde Christiansen.
3094
3095         [Qt] Allow pre-generation for package builds for WebKit2
3096         https://bugs.webkit.org/show_bug.cgi?id=50139
3097
3098         Use a build variable for the generated directory path and set the
3099         value based on CONFIG just like for WebKit1.
3100
3101         For non-package builds use a relative base path for the
3102         genrated directory just like for WebKit1.
3103
3104         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3105         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3106
3107 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3108
3109         Reviewed by Kenneth Rohde Christiansen.
3110
3111         [Qt] Move some build logic from Qt to platform independent code
3112         https://bugs.webkit.org/show_bug.cgi?id=50134
3113
3114         Create target directories inside generate-forwarding-headers.pl.
3115
3116         * Scripts/generate-forwarding-headers.pl:
3117
3118 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3119
3120         Reviewed by Martin Robinson.
3121
3122         [GTK] Windowless plugins gets broken key input
3123         https://bugs.webkit.org/show_bug.cgi?id=49927
3124
3125         Convert the XEvent::keycode to ASCII before printing it. Not
3126         doing this was causing false positive in 
3127         plugins/keyboard-events.html.
3128
3129         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3130         (keycode_to_char):
3131         (webkit_test_plugin_handle_event):
3132
3133 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3134
3135         Reviewed by Antonio Gomes.
3136
3137         [Qt] Html autofocus not working with QGraphicsWebView
3138         https://bugs.webkit.org/show_bug.cgi?id=43169
3139
3140         Tell the scene to set the webview item as the currently
3141         focused item. This makes the input field with autofocus get
3142         focus as it should.
3143
3144         * QtTestBrowser/webview.cpp:
3145         (WebViewGraphicsBased::WebViewGraphicsBased):
3146
3147 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3148
3149         Reviewed by Tony Chang.
3150
3151         nrwt - clean up create_driver interface and print out the
3152         command line used for DumpRenderTree/TestShell.
3153
3154         This patch adds a driver_cmd_line() call to the Port class in
3155         order to retrive the command line to print it out (as part of
3156         --print config).
3157
3158         In addition, this patch cleans up the Port.create_driver()
3159         signature and the Driver constructor interface to take a worker
3160         number and no longer require the image_path argument (Chromium's
3161         drivers now synthesize the image_path from the worker number
3162         internally).
3163
3164         https://bugs.webkit.org/show_bug.cgi?id=49934
3165
3166         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3167         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3168         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3169         * Scripts/webkitpy/layout_tests/port/base.py:
3170         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3171         * Scripts/webkitpy/layout_tests/port/chromium.py:
3172         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3173         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3174         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3175         * Scripts/webkitpy/layout_tests/port/test.py:
3176         * Scripts/webkitpy/layout_tests/port/webkit.py:
3177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3178         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3179
3180 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3181
3182         Reviewed by Tony Chang.
3183
3184         [chromium] improve memory usage for test results server and store fewer runs
3185         https://bugs.webkit.org/show_bug.cgi?id=50035
3186
3187         Store fewer runs and don't pass full files around when we only need bools.
3188         Greatly improves error rates on test-results.appspot.com.
3189
3190         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3191         * TestResultServer/handlers/testfilehandler.py:
3192         * TestResultServer/model/dashboardfile.py:
3193         * TestResultServer/model/jsonresults.py:
3194
3195 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3196
3197         Reviewed by Tony Chang.
3198
3199         This patch implements the first part of the manager side of the
3200         Broker objects - it handles creating threads, waiting for them
3201         to complete, and running a single-threaded loop as well.
3202
3203         https://bugs.webkit.org/show_bug.cgi?id=49779
3204
3205         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3206         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3207         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3208         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3209
3210 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3211
3212         Reviewed by David Levin.
3213
3214         DRT should not generate pixel output for text/plain tests
3215         https://bugs.webkit.org/show_bug.cgi?id=50002
3216         
3217         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3218         when encountering a text/plain response (the Chromium one already does
3219         this, and none of the other ports special-case text/plain output in
3220         the first place).
3221
3222         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3223         (dump):
3224         * DumpRenderTree/mac/DumpRenderTree.mm:
3225         (dump):
3226         * DumpRenderTree/win/DumpRenderTree.cpp:
3227         (dump):
3228
3229 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3230
3231         Unreviewed.
3232
3233         Add my other email address to committers.py.
3234
3235         * Scripts/webkitpy/common/config/committers.py:
3236
3237 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3238
3239         Reviewed by Csaba Osztrogonác.
3240
3241         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3242         https://bugs.webkit.org/show_bug.cgi?id=49975
3243
3244         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3245         to enable the script to define it 0 in case of a minimal build.
3246
3247 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3248
3249         Reviewed by Xan Lopez.
3250
3251         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3252         https://bugs.webkit.org/show_bug.cgi?id=49143
3253
3254         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3255         (createWebView): Call the new connectEditingCallbacks function.
3256         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3257         (dumpNodePath):
3258         (dumpRange):
3259         (insertActionString):
3260         (selectionAffinityString):
3261         (shouldBeginEditing):
3262         (shouldEndEditing):
3263         (shouldInsertNode):
3264         (shouldInsertText):
3265         (shouldDeleteRange):
3266         (shouldShowDeleteInterfaceForElement):
3267         (shouldChangeSelectedRange):
3268         (shouldApplyStyle):
3269         (editingBegan):
3270         (userChangedContents):
3271         (editingEnded):
3272         (selectionChanged):
3273         (connectEditingCallbacks):
3274         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3275         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3276
3277 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3278
3279         Reviewed by Andreas Kling.
3280
3281         [Qt] Make QtTestBrowser remember the selected user agent
3282         https://bugs.webkit.org/show_bug.cgi?id=50021
3283
3284         Set user agent for a new page by using the old page's
3285
3286         * QtTestBrowser/mainwindow.cpp:
3287         (MainWindow::setPage):
3288
3289 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3290
3291         Reviewed by Csaba Osztrogonác.
3292
3293         Remove Bakefile build system files
3294         https://bugs.webkit.org/show_bug.cgi?id=49983
3295
3296         r53757 only removed the content, but not the files.
3297         This patch removes that empty files.
3298
3299         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3300         * wx/browser/browser.bkl: Removed.
3301         * wx/build-wxwebkit: Removed.
3302
3303 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3304
3305         Reviewed by Tony Chang.
3306
3307         This patch cleans up the logic used to shard tests into groups a
3308         bit and adds the --worker-model flag to NRWT. The flag is only
3309         used at the moment to control whether to run single-threaded or
3310         not, but eventually will also allow toggling between threads and
3311         processes.
3312
3313         Also add a minor cleanup with _test_is_slow(), which just
3314         eliminates some repetition and gives slightly better encapsulation.
3315
3316         https://bugs.webkit.org/show_bug.cgi?id=49773
3317
3318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3319         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3320
3321 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3322
3323         Reviewed by Tony Chang.
3324
3325         Rebaseline server: list current baselines and platforms
3326         https://bugs.webkit.org/show_bug.cgi?id=49991
3327         
3328         List existing baselines (with Trac links) for tests.
3329         
3330         Add dropdowns for choosing with platform baselines to target (and what
3331         to do with existing ones).
3332
3333         Also fix MockFileSystem.join to behave more like os.path.join (unit
3334         test was ending up with two consecutive slashes in a layout test
3335         path).        
3336
3337         * Scripts/webkitpy/common/system/filesystem_mock.py:
3338         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3339         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3340         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3341         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3342         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3343         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3344         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3345
3346 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3347
3348         Reviewed by Tony Chang.
3349
3350         remove timeout argument to urlopen
3351         https://bugs.webkit.org/show_bug.cgi?id=49995
3352
3353         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3354
3355         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3356
3357 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3358
3359         Unreviewed, rolling out r72628.
3360         http://trac.webkit.org/changeset/72628
3361         https://bugs.webkit.org/show_bug.cgi?id=49994
3362
3363         This patch is causing layout-test failtures on GTK Linux
3364         64-bit Debug (Requested by ctguil on #webkit).
3365
3366         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3367         (AccessibilityUIElement::AccessibilityUIElement):
3368         (AccessibilityUIElement::parentElementCallback):
3369         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3370         * DumpRenderTree/chromium/CppBoundClass.cpp:
3371         * DumpRenderTree/chromium/CppBoundClass.h:
3372
3373 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3374
3375         Reviewed by Tony Chang.
3376
3377         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3378         https://bugs.webkit.org/show_bug.cgi?id=49944
3379
3380         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3381
3382 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3383
3384         Reviewed by Dimitri Glazkov.
3385
3386         Include the FrameView widget of a RenderWidget in the accessibility tree.
3387         https://bugs.webkit.org/show_bug.cgi?id=49106
3388
3389         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3390         (AccessibilityUIElement::AccessibilityUIElement):
3391         (AccessibilityUIElement::parentElementCallback):
3392         (AccessibilityUIElement::isEqualCallback):
3393         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3394         * DumpRenderTree/chromium/CppBoundClass.cpp:
3395         (CppBoundClass::getFromCppVariant):
3396         * DumpRenderTree/chromium/CppBoundClass.h:
3397
3398 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3399
3400         Reviewed by Kenneth Rohde Christiansen.
3401
3402         [EFL] Add tiled backing store to EWebLauncher
3403         https://bugs.webkit.org/show_bug.cgi?id=45777
3404
3405         Allow EWebLauncher to choose between single and tiled backing store
3406
3407         * EWebLauncher/main.c:
3408         (on_key_down):
3409         (browserCreate):
3410         (main):
3411
3412 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3413
3414         Reviewed by Tor Arne Vestbø.
3415
3416         [Qt] Review the setUserPermission & friends API
3417         https://bugs.webkit.org/show_bug.cgi?id=46810
3418
3419         Renamed requestPermissionFromUser to featurePermissionRequested
3420         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3421
3422         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3423         (WebCore::WebPage::WebPage):
3424         * QtTestBrowser/webpage.cpp:
3425         (WebPage::WebPage):
3426         (WebPage::featurePermissionRequestCanceled):
3427         * QtTestBrowser/webpage.h:
3428
3429 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3430
3431         Reviewed by Tor Arne Vestbø.
3432
3433         [Qt] Review the setUserPermission & friends API
3434         https://bugs.webkit.org/show_bug.cgi?id=46810
3435
3436         Rename setUserPermission to setFeaturePermission
3437
3438         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3439         (WebCore::WebPage::requestPermission):
3440         (WebCore::WebPage::permissionSet):
3441         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3442         (LayoutTestController::grantDesktopNotificationPermission):
3443         * QtTestBrowser/webpage.cpp:
3444         (WebPage::requestPermission):
3445
3446 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3447
3448         Reviewed by Tor Arne Vestbø.
3449
3450         [Qt] Review the setUserPermission & friends API
3451         https://bugs.webkit.org/show_bug.cgi?id=46810
3452
3453         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3454         and GeolocationPermissionDomain to Geolocation.
3455
3456         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3457         (WebCore::WebPage::WebPage):
3458         (WebCore::WebPage::requestPermission):
3459         (WebCore::WebPage::cancelPermission):
3460         (WebCore::WebPage::permissionSet):
3461         (WebCore::DumpRenderTree::geolocationPermissionSet):
3462         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3463         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3464         (LayoutTestController::grantDesktopNotificationPermission):
3465         * QtTestBrowser/webpage.cpp:
3466         (WebPage::WebPage):
3467         (WebPage::requestPermission):
3468         (WebPage::cancelRequestsForPermission):
3469         * QtTestBrowser/webpage.h:
3470
3471 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3472
3473         Reviewed by Tor Arne Vestbø.
3474
3475         [Qt] Review the setUserPermission & friends API
3476         https://bugs.webkit.org/show_bug.cgi?id=46810
3477
3478         Add a ByUser suffix to PermissionGranted/Denied. In the future
3479         we can add PermissionGrantedByDefault.
3480
3481
3482         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3483         (WebCore::WebPage::requestPermission):
3484         (WebCore::WebPage::permissionSet):
3485         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3486         (LayoutTestController::grantDesktopNotificationPermission):
3487         * QtTestBrowser/webpage.cpp:
3488         (WebPage::requestPermission):
3489
3490 2010-11-18  Satish Sampath  <satish@chromium.org>
3491
3492         Reviewed by Jeremy Orlow.
3493
3494         For speech input event, send an event object containing all the recognition results and metadata.
3495         https://bugs.webkit.org/show_bug.cgi?id=49736
3496
3497         Updated DRT by renaming the mock result method on all platforms to the new signature.
3498
3499         * DumpRenderTree/LayoutTestController.cpp:
3500         (addMockSpeechInputResultCallback):
3501         (LayoutTestController::staticFunctions):
3502         * DumpRenderTree/LayoutTestController.h:
3503         * DumpRenderTree/chromium/LayoutTestController.cpp:
3504         (LayoutTestController::LayoutTestController):
3505         (LayoutTestController::addMockSpeechInputResult):
3506         * DumpRenderTree/chromium/LayoutTestController.h:
3507         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3508         (LayoutTestController::addMockSpeechInputResult):
3509         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3510         (LayoutTestController::addMockSpeechInputResult):
3511         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3512         (LayoutTestController::addMockSpeechInputResult):
3513         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3514         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3515         (LayoutTestController::addMockSpeechInputResult):
3516         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3517         (LayoutTestController::addMockSpeechInputResult):
3518
3519 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3520
3521         Reviewed by Tony Chang.
3522
3523         Fix some spacing issues with log messages with
3524         new-run-webkit-tests --verbose.
3525
3526         https://bugs.webkit.org/show_bug.cgi?id=49936
3527
3528         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3529
3530 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3531
3532         Reviewed by Adam Barth.
3533
3534         update scm to work with different remote branches
3535         https://bugs.webkit.org/show_bug.cgi?id=49949
3536
3537         This works if there are multiple svn tracking branches
3538         and/or if the tracking branch is refs/remots/origin/master
3539         instead of refs/remotes/trunk which is the direction we're trying
3540         to head since that makes fetches faster.
3541
3542         * Scripts/webkitpy/common/checkout/scm.py:
3543         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3544
3545 2010-11-22  Hayato Ito  <hayato@chromium.org>
3546
3547         Reviewed by Shinichiro Hamaji.
3548
3549         Ignore reference files which will be used by reftests when collecting
3550         test cases.
3551         https://bugs.webkit.org/show_bug.cgi?id=49835
3552
3553         * Scripts/webkitpy/layout_tests/port/test_files.py:
3554         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3555
3556 2010-11-22  Adam Roben  <aroben@apple.com>
3557
3558         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3559
3560         Apple's Windows build allows placing header files and import libraries for WebKit's
3561         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3562         $WebKitLibrariesDir environment variable. This is both required for production builds and
3563         convenient for Apple-internal developer builds. Apple's production builds also require that
3564         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3565         builds, the files are copied into that directory tree by the
3566         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3567         copying is done by
3568         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3569
3570         This .vsprops copying is problematic in one very important case: when a developer updates
3571         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3572         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3573         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3574         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3575         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3576         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3577
3578         To fix this, we now use normal relative paths to access the .vsprops files in the source
3579         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3580         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3581         unset, so the normal relative paths are used to read the .vsprops files out of the source
3582         tree directly. In production builds, this environment variable is set to a fake directory
3583         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3584         is resolved.
3585         
3586         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3587
3588         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3589
3590         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3591         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3592         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3593         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3594         FeatureDefines.vsprops becomes:
3595
3596         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3597
3598         which resolves to:
3599
3600         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3601
3602         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3603         actually exist since they are matched by an equal number of ".." path components.)
3604
3605         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3606         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3607
3608         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3609         updated
3610
3611         Reviewed by Dave Hyatt.
3612
3613         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3614         * DumpRenderTree/win/DumpRenderTree.vcproj:
3615         * DumpRenderTree/win/ImageDiff.vcproj:
3616         * FindSafari/FindSafari.vcproj:
3617         * MiniBrowser/MiniBrowser.vcproj:
3618         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3619         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3620         * WebKitAPITest/WebKitAPITest.vcproj:
3621         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3622         * WebKitTestRunner/win/InjectedBundle.vcproj:
3623         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3624         * WinLauncher/WinLauncher.vcproj:
3625         * record-memory-win/record-memory-win.vcproj:
3626         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3627         files.
3628
3629 2010-11-22  Adam Roben  <aroben@apple.com>
3630
3631         Make it possible to run tests on Windows without Visual Studio or VC++
3632         Express installed
3633
3634         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3635         are not installed. But this function doesn't need to be called when we