[EFL][DRT] Implement LayoutTestController::execCommand
[WebKit-https.git] / Tools / ChangeLog
1 2012-05-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2
3         [EFL][DRT] Implement LayoutTestController::execCommand
4         https://bugs.webkit.org/show_bug.cgi?id=82286
5
6         Reviewed by Antonio Gomes.
7
8         Add missing implementation execCommand and isCommandEnabled to EFL's
9         LayoutTestController. 
10
11         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12         (LayoutTestController::execCommand):
13         (LayoutTestController::isCommandEnabled):
14
15 2012-05-06  Hayato Ito  <hayato@chromium.org>
16
17         [prepare-ChangeLog] Excludes a reference file used by reftests from test files.
18         https://bugs.webkit.org/show_bug.cgi?id=74268
19
20         Reviewed by Ryosuke Niwa.
21
22         * Scripts/prepare-ChangeLog:
23         (generateFileList):
24
25 2012-05-06  Mary Wu  <mary.wu@torchmobile.com.cn>
26
27         Add a contributor to committers.py
28         https://bugs.webkit.org/show_bug.cgi?id=85761
29
30         Reviewed by Unreviewed.
31
32         Add myself to committers.py contributor.
33
34         * Scripts/webkitpy/common/config/committers.py:
35
36 2012-05-06  Dan Bernstein  <mitz@apple.com>
37
38         Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
39         https://bugs.webkit.org/show_bug.cgi?id=85739
40
41         Reviewed by Daniel Bates.
42
43         * Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
44         from here...
45         * Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
46
47 2012-05-06  Andy Estes  <aestes@apple.com>
48
49         Fix the build after r116246.
50
51         * DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
52
53 2012-05-06  Eric Seidel  <eric@webkit.org>
54
55         Update several build-webkit options to match the #defines they toggle
56         https://bugs.webkit.org/show_bug.cgi?id=85744
57
58         Reviewed by Adam Barth.
59
60         Most notable here is fixing --3d-canvas to be --webgl these days --
61         the define was renamed 15 months ago!
62
63         * Scripts/webkitperl/FeatureList.pm:
64
65 2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
66
67         [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
68         https://bugs.webkit.org/show_bug.cgi?id=83687
69
70         Reviewed by Antonio Gomes.
71
72         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
73         (LayoutTestController::setJavaScriptCanAccessClipboard):
74
75 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
76
77         Convert isPageBoxVisible to use Internals interface.
78         https://bugs.webkit.org/show_bug.cgi?id=85692
79
80         Reviewed by Darin Adler.
81
82         Remove isPageBoxVisible functions, because it is able to work in the
83         cross-port way through the Internals interface.
84
85         * DumpRenderTree/LayoutTestController.cpp:
86         (LayoutTestController::staticFunctions):
87         * DumpRenderTree/LayoutTestController.h:
88         (LayoutTestController):
89         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
90         * DumpRenderTree/chromium/LayoutTestController.cpp:
91         (LayoutTestController::LayoutTestController):
92         * DumpRenderTree/chromium/LayoutTestController.h:
93         (LayoutTestController):
94         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
95         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
96         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
97         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
98         * DumpRenderTree/qt/LayoutTestControllerQt.h:
99         (LayoutTestController):
100         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
101         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
102
103 2012-05-06  Tom Zakrajsek  <tomz@codeaurora.org>
104
105         sheriffbot isn't reopening patches after it lands rollouts
106         https://bugs.webkit.org/show_bug.cgi?id=64418
107
108         Reviewed by Adam Barth.
109
110         * Scripts/webkitpy/tool/commands/download_unittest.py:
111         * Scripts/webkitpy/tool/steps/createbug.py:
112         (CreateBug.run):
113
114 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
115
116         webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
117         https://bugs.webkit.org/show_bug.cgi?id=85697
118
119         Reviewed by Eric Seidel.
120
121         * Scripts/new-run-webkit-tests: Instead of manually detecting whether
122         the path separator should be ':' or ';' by checking sys.platform, rely
123         on os.pathsep which has exactly the same information (os.pathsep is
124         ':' for Cygwin, from what I could check in Python's sources).
125
126 2012-05-05  Sheriff Bot  <webkit.review.bot@gmail.com>
127
128         Unreviewed, rolling out r116223.
129         http://trac.webkit.org/changeset/116223
130         https://bugs.webkit.org/show_bug.cgi?id=85718
131
132         The bots need to set XDG_DATA_DIRS (Requested by rakuco on
133         #webkit).
134
135         * efl/jhbuildrc:
136         * gtk/jhbuildrc:
137
138 2012-05-05  Raphael Kubo da Costa  <rakuco@webkit.org>
139
140         [jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
141         https://bugs.webkit.org/show_bug.cgi?id=85717
142
143         Reviewed by Martin Robinson.
144
145         After r116209, the XDG_DATA_DIRS environment variable is now
146         passed by webkitpy's layout_tests code to run-with-jhbuild, so
147         instead of setting a few defaults in jhbuildrc we can now rely on
148         the values set and really used by each system.
149
150         * efl/jhbuildrc:
151         * gtk/jhbuildrc:
152
153 2012-05-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
154
155         [Qt] Buildfix for --minimal build after r116107.
156
157         Reviewed by Csaba Osztrogonác.
158
159         * qmake/mkspecs/features/features.prf:
160
161 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
162
163         [Gtk] GtkDriver is not required anymore after r116134
164         https://bugs.webkit.org/show_bug.cgi?id=85699
165
166         Reviewed by Csaba Osztrogonác.
167
168         Remove GtkDriver as it was replaced by the XvfbDriver and is
169         no longer needed.
170
171         * Scripts/webkitpy/layout_tests/port/gtk.py:
172
173 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
174
175         Increase the display ID for the Xvfb process to use if pixel_tests argument
176         is true rather than if pixel_tests option is present. This fixes the
177         XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.
178
179         Rubber-stamped by Csaba Osztrogonác.
180
181         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
182         (XvfbDriver._start):
183
184 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
185
186         webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
187         https://bugs.webkit.org/show_bug.cgi?id=85694
188
189         Reviewed by Martin Robinson.
190
191         This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
192         preserved, as it is particularly useful for Linux/Unix
193         environments.  As a real use case, if shared-mime-info is
194         installed into a non-trivial prefix, Glib and other libraries will
195         have trouble to properly identify mimetypes (in ResourceResponses,
196         for example) as the base freedesktop.org mimetype file will not be
197         found.
198
199         * Scripts/webkitpy/layout_tests/port/base.py:
200         (Port.to.setup_environ_for_server):
201
202 2012-05-04  Gustavo Noronha Silva  <gns@gnome.org>
203
204         [GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
205         https://bugs.webkit.org/show_bug.cgi?id=85691
206
207         * GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
208
209 2012-05-04  Eric Seidel  <eric@webkit.org>
210
211         Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
212         https://bugs.webkit.org/show_bug.cgi?id=85583
213
214         Reviewed by Daniel Bates.
215
216         * Scripts/webkitperl/FeatureList.pm:
217
218 2012-05-04  Eric Seidel  <eric@webkit.org>
219
220         Sort entries in FeaturesList.pm to make them easier to autogenerate
221         https://bugs.webkit.org/show_bug.cgi?id=85584
222
223         Reviewed by Daniel Bates.
224
225         No functional changes, only sorting.
226
227         * Scripts/webkitperl/FeatureList.pm:
228
229 2012-05-04  Andy Estes  <aestes@apple.com>
230
231         REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
232         https://bugs.webkit.org/show_bug.cgi?id=85675
233
234         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
235         (TestWebKitAPI::TEST): Disable the test.
236
237 2012-04-30  Jer Noble  <jer.noble@apple.com>
238
239         Full screen will exit during a provisional load of a non-ancestor iframe.
240         https://bugs.webkit.org/show_bug.cgi?id=85230
241
242         Reviewed by Maciej Stachowiak .
243
244         Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
245         * DumpRenderTree/mac/UIDelegate.mm:
246         (-[UIDelegate webView:closeFullScreenWithListener:]):
247
248         Add support for the new closeFullScreen injected bundle method:
249         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
250         (WTR::InjectedBundlePage::InjectedBundlePage):
251         (WTR::InjectedBundlePage::closeFullScreen):
252         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
253
254 2012-05-04  Ojan Vafai  <ojan@chromium.org>
255
256         Fix test naming to be camel-case like the methods they are testing.
257
258         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
259         (test):
260
261 2012-05-04  Ojan Vafai  <ojan@chromium.org>
262
263         Show the results links in the embedded flakiness dashboard
264         https://bugs.webkit.org/show_bug.cgi?id=85660
265
266         Reviewed by Adam Barth.
267
268         Turns out these links don't add much visual noise and it's annoying
269         to have to go to the dashboard from garden-o-matic just to view the
270         results for a test.
271
272         This is useful for cases where garden-o-matic doesn't properly show the
273         results (e.g. missing tests). If we address all those cases, then
274         we could easily hide the results links again if we wanted to.
275
276         * TestResultServer/static-dashboards/flakiness_dashboard.js:
277         (showUpdateInfoForTest):
278         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
279         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
280         (test):
281
282 2012-05-04  Dirk Pranke  <dpranke@chromium.org>
283
284         Revert to using chromium --test-shell mode on SL in NRWT
285
286         https://bugs.webkit.org/show_bug.cgi?id=83076
287
288         Unreviewed, build fix.
289
290         We seem to be seeing a lot more flakiness on the bot since
291         I switched NRWT to "DRT" mode. We'll try reverting back and
292         see if this helps things.
293
294         * Scripts/webkitpy/layout_tests/port/chromium.py:
295         (ChromiumDriver.__init__):
296
297 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
298
299         [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
300         https://bugs.webkit.org/show_bug.cgi?id=84941
301
302         Reviewed by Martin Robinson.
303
304         Print MIME type detection messages in EFL's DumpRenderTree if
305         LayoutTestController's dumpResourceResponseMIMETypes() returns true.
306
307         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
308         (DumpRenderTreeChrome::onResponseReceived):
309
310 2012-05-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
311
312         [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
313         https://bugs.webkit.org/show_bug.cgi?id=85134
314
315         Reviewed by Martin Robinson.
316
317         Add missing implementation setDefersLoading and goBack to GTK's
318         LayoutTestController so that the test case rely on these methods
319         can be enabled.
320
321         * DumpRenderTree/gtk/DumpRenderTree.cpp:
322         (resetDefaultsToConsistentValues):
323         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
324         (LayoutTestController::goBack):
325         (LayoutTestController::setDefersLoading):
326
327 2012-05-04  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
328
329         [Qt][NRWT] Run each DRT in it's own xvfb
330         https://bugs.webkit.org/show_bug.cgi?id=77335
331
332         Reviewed by Dirk Pranke.
333
334         * Scripts/webkitpy/layout_tests/port/gtk.py:
335         (GtkPort._driver_class):
336         * Scripts/webkitpy/layout_tests/port/qt.py:
337         (QtPort._driver_class):
338         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
339         (XvfbDriver):
340         (XvfbDriver._start):
341         (XvfbDriver._start.x_filter):
342         (XvfbDriver.stop):
343
344 2012-05-04  Zan Dobersek  <zandobersek@gmail.com>
345
346         Use destructuring assingment for the return values of the
347         port.diff_image() method call.
348
349         Rubber-stamped by Dirk Pranke.
350
351         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
352         (write_test_result):
353
354 2012-05-03  Ojan Vafai  <ojan@chromium.org>
355
356         Store fewer runs by default in the flakiness dashboard
357         https://bugs.webkit.org/show_bug.cgi?id=85568
358
359         Reviewed by Dirk Pranke.
360
361         This will greatly shrink the size of the json files we load,
362         resulting in a much faster initial load. People rarely care
363         about more than 100 runs. For the cases they do, they can still click
364         the show all runs checkbox to show 500 runs.
365
366         * TestResultServer/model/jsonresults.py:
367
368 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
369
370         [EFL] Frame load callbacks output is missing for redirections
371         https://bugs.webkit.org/show_bug.cgi?id=85173
372
373         Reviewed by Antonio Gomes.
374
375         Catch the new ewk_frame signals to print the expected output in case
376         of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
377         returns true.
378
379         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
380         (DumpRenderTreeChrome::createView):
381         (DumpRenderTreeChrome::onWillSendRequest):
382         (DumpRenderTreeChrome::onFrameCreated):
383         (DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
384         (DumpRenderTreeChrome::onFrameRedirectRequested):
385         (DumpRenderTreeChrome::onResponseReceived):
386         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
387         (DumpRenderTreeChrome):
388
389 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
390
391         [Qt] Fix up warning about missing GLib/Gio/GStreamer
392
393         We don't actually fall back.
394
395         Rubber-stamped by Csaba Osztrogonác.
396
397         * qmake/mkspecs/features/features.prf:
398
399 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
400
401         [Qt] Clarify warning about missing GLib/Gio/GStreamer for media support
402
403         And only print it once.
404
405         Reviewed by Csaba Osztrogonác.
406
407         * qmake/mkspecs/features/features.prf:
408
409 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
410
411         [Qt] Clean up and split features.prf into a static list of defaults
412
413         The static list of feature defaults is used as a fallback for any
414         feature that's not dynamically detected or overriden on the command
415         line (though build-webkit or passing DEFINES+= to qmake).
416
417         The static list is complete, which allows for auto-generation based
418         on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)
419
420         https://bugs.webkit.org/show_bug.cgi?id=85611
421
422         Reviewed by Simon Hausmann.
423
424         * Scripts/build-webkit:
425         * Tools.pro:
426         * qmake/mkspecs/features/features.prf:
427         * qmake/mkspecs/features/features.pri: Added.
428
429 2012-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
430
431         Unreviewed, rolling out r116085, r116091, and r116095.
432         http://trac.webkit.org/changeset/116085
433         http://trac.webkit.org/changeset/116091
434         http://trac.webkit.org/changeset/116095
435         https://bugs.webkit.org/show_bug.cgi?id=85628
436
437         We are not ready with dependencies on all platform yet (mac) +
438         problems with debug builds. (Requested by Zoltan on #webkit).
439
440         * qmake/mkspecs/features/features.prf:
441
442 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
443
444         [EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
445         https://bugs.webkit.org/show_bug.cgi?id=85171
446
447         Reviewed by Andreas Kling.
448
449         Implement support for overriding "WebKitLoadSiteIconsKey" setting in
450         EFL's LayoutTestController.
451
452         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
453         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
454         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
455         (LayoutTestController::overridePreference):
456
457 2012-05-03  Alexis Menard  <alexis.menard@openbossa.org>
458
459         [Qt] Enable fullscreen API for WebKit2.
460         https://bugs.webkit.org/show_bug.cgi?id=85498
461
462         Reviewed by Simon Hausmann.
463
464         Enable the fullscreen API on the MiniBrowser and turn
465         it default on WebKit2, disable it on WK1.
466
467         * MiniBrowser/qt/BrowserWindow.cpp:
468         (BrowserWindow::BrowserWindow):
469         * MiniBrowser/qt/qml/BrowserWindow.qml:
470         * Scripts/webkitperl/FeatureList.pm:
471         * qmake/mkspecs/features/features.prf:
472
473 2012-05-04  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
474
475         REGRESSION(r116008) old-run-webkit-tests broken
476         https://bugs.webkit.org/show_bug.cgi?id=85597
477
478         Reviewed by Simon Hausmann.
479
480         Reinstate libraryContainsSymbol.
481
482         * Scripts/webkitperl/features.pm:
483         (libraryContainsSymbol):
484
485 2012-05-04  Zoltan Horvath  <zoltan@webkit.org>
486
487         [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
488         https://bugs.webkit.org/show_bug.cgi?id=80400
489
490         Remove WTF_USE_QT_IMAGE_DECODER macro.
491
492         Reviewed by Simon Hausmann.
493
494         * qmake/mkspecs/features/features.prf:
495
496 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
497
498         [EFL] DRT should obey layoutTestController's addURLToRedirect()
499         https://bugs.webkit.org/show_bug.cgi?id=82722
500
501         Reviewed by Maciej Stachowiak.
502
503         Implement support for layoutTestController's addURLToRedirect()
504         in EFL's DRT so that it redirects properly when indicated.
505
506         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
507         (DumpRenderTreeChrome::onWillSendRequest):
508
509 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
510
511         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
512         https://bugs.webkit.org/show_bug.cgi?id=82704
513
514         Reviewed by Antonio Gomes.
515
516         EFL's DRT needs to obey LayoutTestController's
517         willSendRequestReturnsNullOnRedirect().
518
519         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
520         (DumpRenderTreeChrome::onWillSendRequest):
521
522 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
523
524         git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
525         https://bugs.webkit.org/show_bug.cgi?id=85570
526
527         Reviewed by Adam Roben.
528
529         The standard format of commit messages and ChangeLog entries has a
530         short summary in the first line, followed by the bug URL in
531         Bugzilla. Passing "%s" in the pretty format line to git-rev-list
532         merges these two lines into a single one separated by a space
533         character, which is not what we want.
534
535         Since "%s%n%n%b" is in practice "%B" (raw message), use it
536         instead, as the first two lines do not end up being merged
537         together.
538
539         * Scripts/git-add-reviewer:
540         (writeCommitMessageToFile):
541
542 2012-05-03  Ojan Vafai  <ojan@chromium.org>
543
544         Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
545         https://bugs.webkit.org/show_bug.cgi?id=85566
546
547         Reviewed by Adam Barth.
548
549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
550         (.):
551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
552         (.):
553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
554
555 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
556
557         webkitpy: Recognize FreeBSD as a valid platform.
558         https://bugs.webkit.org/show_bug.cgi?id=81467
559
560         Reviewed by Adam Barth.
561
562         Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
563         on FreeBSD does not raise an "unrecognized platform" exception.
564
565         Most of this patch contains some unit tests for the mentioned
566         method, as currently platform-specific code is needed only on
567         Windows.
568
569         * Scripts/webkitpy/common/system/platforminfo.py:
570         (PlatformInfo.__init__):
571         (PlatformInfo.is_freebsd):
572         (PlatformInfo._determine_os_name):
573         * Scripts/webkitpy/common/system/platforminfo_mock.py:
574         (MockPlatformInfo.is_freebsd):
575         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
576         (fake_platform):
577         (fake_platform.FakePlatformModule.release):
578         (TestPlatformInfo.test_real_code):
579         (TestPlatformInfo.test_os_name_and_wrappers):
580         (TestPlatformInfo.test_os_version):
581         (TestPlatformInfo.test_display_name):
582         (TestPlatformInfo.test_total_bytes_memory):
583         (TestPlatformInfo.test_free_bytes_memory):
584         * Scripts/webkitpy/layout_tests/port/factory.py:
585         (PortFactory._default_port):
586
587 2012-05-03  Ojan Vafai  <ojan@chromium.org>
588
589         Make the table headers white-space:nowrap. This decreases the vertical size,
590         which makes for more minimal embedding in garden-o-matic.
591
592         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
593         (.table-header-content *):
594
595 2012-05-03  Eric Seidel  <eric@webkit.org>
596
597         Split build-webkit's feature option list off into its own module in preparation for autogeneration
598         https://bugs.webkit.org/show_bug.cgi?id=85548
599
600         Reviewed by Daniel Bates.
601
602         My Perl-fu is very weak.  This moves the feature option list off into a separate module
603         file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
604         It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
605         not to matter.  Also, build-webkit doesn't actually use any of the variables we're using to
606         store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
607         which is actually cleaner.  Callers can't assume that they would get a new array every time, but someone
608         with more Perl-fu than I could create something fancier than this if we need in the future.
609
610         * Scripts/build-webkit:
611         * Scripts/webkitperl/FeatureList.pm: Added.
612         (getFeatureOptionList):
613
614 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
615
616         REGRESSION: run-webkit-tests failing on Chromium Mac
617         https://bugs.webkit.org/show_bug.cgi?id=85459
618
619         Unreviewed, build fix.
620
621         Turns out select doesn't throw IOErrors, it has it's own kind of
622         error :(. Trap that instead.
623
624         * Scripts/webkitpy/layout_tests/port/server_process.py:
625         (ServerProcess._wait_for_data_and_update_buffers_using_select):
626
627 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
628
629         [CMake] Rewrite FindCairo.cmake.
630         https://bugs.webkit.org/show_bug.cgi?id=84895
631
632         Reviewed by Daniel Bates.
633
634         The old approach relied on pkg-config for finding Cairo (which
635         introduced a dependency on pkg-config that could be avoided), used
636         the LibFindMacros code that we should probably remove in the
637         future and did not use the FindPackageHandleStandardArguments
638         module.
639
640         Change all that by rewriting the module.
641         - Use the pkg-config output optionally instead of requiring it
642         like LibFindMacros did.
643         - Remove the implicit dependency on FreeType which often found it
644         the wrong way via pkg-config and without considering
645         CMAKE_PREFIX_PATH.
646         - Retrieve the Cairo version by looking at cairo-version.h instead
647         of relying on pkg-config. It requires some additional code for
648         checking if the desired version has been found, but that will not
649         be needed once we start depending on CMake 2.8.3 or later.
650
651         The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
652         instead of <Name>_FOUND, and to keep things consistent
653         Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
654         and CAIRO_INCLUDE_DIRS.
655
656         * DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of
657         Cairo_FOO.
658         * EWebLauncher/CMakeLists.txt: Ditto.
659
660 2012-05-03  Ojan Vafai  <ojan@chromium.org>
661
662         Fix modifier and bug sorting on the flakiness dashboard
663         https://bugs.webkit.org/show_bug.cgi?id=85554
664
665         Reviewed by Dirk Pranke.
666
667         The sorting assumes that the column header name matches a field
668         in the testResults object and uses that field for sorting.
669         Filter the bugs out of the modifiers list and put them in a bugs field
670         and only put the non-bug modifiers in the modifiers list.
671
672         * TestResultServer/static-dashboards/flakiness_dashboard.js:
673         (populateExpectationsData):
674         (htmlForSingleTestRow):
675         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
676
677 2012-05-03  Ojan Vafai  <ojan@chromium.org>
678
679         Fix some state resetting when running unittests. HtmlForSingleTestRow
680         was flaky.
681
682         * TestResultServer/static-dashboards/flakiness_dashboard.js:
683         (htmlForSingleTestRow):
684         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
685         (resetGlobals):
686
687 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
688
689         webkitpy: Use PlatformInfo wherever possible in the User class.
690         https://bugs.webkit.org/show_bug.cgi?id=85549
691
692         Reviewed by Dirk Pranke.
693
694         Instead of relying on sys.platform to detect whether the current
695         platform is a Mac, use the PlatformInfo class instead.
696
697         * Scripts/webkitpy/common/system/user.py:
698         (User.__init__):
699         (User.edit_changelog):
700
701 2012-05-03  Ojan Vafai  <ojan@chromium.org>
702
703         Remove the percent failed column from the flakiness dashboard
704         https://bugs.webkit.org/show_bug.cgi?id=85552
705
706         Reviewed by Dirk Pranke.
707
708         This column isn't useful enough to justify the visual noise.
709
710         * TestResultServer/static-dashboards/flakiness_dashboard.js:
711         (processMissingAndExtraExpectations):
712         (tableHeaders):
713         (htmlForSingleTestRow):
714         (sortTests):
715         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
716         (test):
717
718 2012-05-03  Eric Seidel  <eric@webkit.org>
719
720         --coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
721         https://bugs.webkit.org/show_bug.cgi?id=85542
722
723         Reviewed by Daniel Bates.
724
725         Remove these last two odd-men-out, so that we can generate the default feature options
726         for build-webkit using the new generate-feature-files command.
727         The Mac build system has some special casing for ENABLE_ defines which gets them
728         defined as -D on the build command, even though initially they start out as
729         environment variables ENABLE_FOO = ENABLE_FOO.  The Feature options in build-webkit
730         depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
731         I'm told that WTF_URL is not actively being worked on, so just removing it for now.
732         It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
733         should be made generically smarter about these USE_WTF defines.
734         (There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
735         used by Qt.  If someone tried build-webkit --tiled-backing-store on Mac today it
736         would not work!)
737
738         * Scripts/build-webkit:
739
740 2012-05-03  Eric Seidel  <eric@webkit.org>
741
742         Remove the last bits of Leopard support from our perl scripts
743         https://bugs.webkit.org/show_bug.cgi?id=85545
744
745         Reviewed by Daniel Bates.
746
747         Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
748         Leopard support several months ago.  Remove the last bits of isLeopard() branching
749         in our Perl scripts, since no one is using this (Chromium has never used this Perl code).
750
751         * Scripts/build-webkit:
752         * Scripts/old-run-webkit-tests:
753         (countAndPrintLeaks):
754         (captureSavedCrashLog):
755         * Scripts/webkitdirs.pm:
756         (determineArchitecture):
757         (argumentsForRunAndDebugMacWebKitApp):
758
759 2012-05-03  Ojan Vafai  <ojan@chromium.org>
760
761         [Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
762         https://bugs.webkit.org/show_bug.cgi?id=85551
763
764         Reviewed by Dirk Pranke.
765
766         It's not uploading results and in the short term we don't plan to have it start.
767
768         * TestResultServer/static-dashboards/builders.js:
769         (isChromiumWebkitTipOfTreeTestRunner):
770         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
771
772 2012-05-03  Ojan Vafai  <ojan@chromium.org>
773
774         Show the test name in the dashboard if showChrome==false and we're showing multiple tests
775         https://bugs.webkit.org/show_bug.cgi?id=85243
776
777         Reviewed by Dirk Pranke.
778
779         This happens for cases where a test name matches multiple tests.
780         In practice, this only happens for virtual test suites (e.g. the canvas tests).
781
782         * TestResultServer/static-dashboards/flakiness_dashboard.js:
783         (htmlForIndividualTestOnAllBuildersWithChrome):
784         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
785         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
786         (testHtmlForIndividualTestOnAllBuildersWithChrome):
787         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
788         (testHtmlForIndividualTests):
789
790 2012-05-03  Ojan Vafai  <ojan@chromium.org>
791
792         Port the flakiness dashboard unittests to qunit
793         https://bugs.webkit.org/show_bug.cgi?id=85544
794
795         Reviewed by Adam Barth.
796
797         * TestResultServer/static-dashboards/dashboard_base.js:
798         (appendJSONScriptElements):
799         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
800         (resetGlobals):
801         (runExpectationsTest):
802         (test):
803         * TestResultServer/static-dashboards/run-unittests.html: Added.
804
805 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
806
807         webkitpy: Remove check for readline on Mac.
808         https://bugs.webkit.org/show_bug.cgi?id=85547
809
810         Reviewed by Eric Seidel.
811
812         Python 2.5 is not supported by the WebKit project anymore, and
813         Python's readline documentation does not mention the module not
814         being available in the supported versions.
815
816         * Scripts/webkitpy/common/system/user.py:
817
818 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
819
820         [NRWT] Run performance tests with lock
821         https://bugs.webkit.org/show_bug.cgi?id=78628
822
823         Reviewed by Tony Chang.
824
825         Locking performance tests (like we do for http tests) will force them
826         to run in serial. This reduces the load of the machine when running perf
827         tests and minimizes the chances of the tests to fail, specially
828         timeouts.
829
830         * Scripts/webkitpy/layout_tests/controllers/manager.py:
831         (Manager.__init__):
832         (Manager._is_perf_test):
833         (Manager._test_requires_lock):
834         * Scripts/webkitpy/layout_tests/port/http_lock.py:
835
836 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
837
838         Attempt to fix a crash on SL ...
839
840         Unreviewed, build fix.
841
842         It looks like we may be getting an IOError raised during
843         select() on chromium mac, and that error isn't being caught.
844         Pushing it into the try/catch block will hopefully catch this
845         and allow us to see why the subprocess is crashing.
846
847         * Scripts/webkitpy/layout_tests/port/server_process.py:
848         (ServerProcess._wait_for_data_and_update_buffers_using_select):
849
850 2012-05-02  Jon Honeycutt  <jhoneycutt@apple.com>
851
852         WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
853         implemented for WebKit2
854         https://bugs.webkit.org/show_bug.cgi?id=84304
855
856         Reviewed by Jessie Berlin.
857
858         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
859         Added new files to project.
860
861         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.
862         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
863         Look for the "DidReceiveWillSendSubmitEvent" message. The message body
864         will be the dictionary of form control names and values passed to the
865         injected bundle's willSendSubmitEvent handler; look for the pairs
866         "textField" -> "text field" and "passwordField" -> "password field".
867         Check that "hiddenField" is not included.
868         (TestWebKitAPI::setInjectedBundleClient):
869         (TestWebKitAPI::TEST):
870
871         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.
872         (TestWebKitAPI::willSendSubmitEvent):
873         Post a message to the TestWebKitAPI process with the dictionary of form
874         control names and values that we received.
875         (TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
876         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
877         Set up the page's form client.
878
879         * TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.
880
881 2012-05-03  Eric Seidel  <eric@webkit.org>
882
883         Remove dead code from build-webkit for working around old XCode dependency bug
884         https://bugs.webkit.org/show_bug.cgi?id=85535
885
886         Reviewed by Adam Barth.
887
888         Xcode used to have a bug whereby it didn't notice if you changed the #defines
889         passed on the command line to xcodebuild.  I wrote code to work around this
890         while bringing up SVG support 5-6 years ago.  I think we can finally remove this
891         code from build-webkit, since SVG is the only feature flag to ever use it
892         (modern in-progress features like MathML don't seem to be using the support)
893         an I suspect the XCode bug has long been fixed.
894
895         * Scripts/build-webkit:
896         * Scripts/webkitperl/features.pm:
897
898 2012-05-03  Andy Estes  <aestes@apple.com>
899
900         InjectedBundleControllerMac.mm needs to include config.h
901         https://bugs.webkit.org/show_bug.cgi?id=85531
902
903         Reviewed by Andreas Kling.
904
905         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
906
907 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
908
909         webkitpy: Use PlatformInfo whenever possible in server_process.py.
910         https://bugs.webkit.org/show_bug.cgi?id=85516
911
912         Reviewed by Eric Seidel.
913
914         Eliminate direct access to sys.platform wherever possible by using
915         PlatformInfo.is_win() instead.
916
917         * Scripts/webkitpy/layout_tests/port/server_process.py:
918         (ServerProcess.__init__): Remove the executive parameter as it was
919         not passed by any caller, obtain a SystemHost from port_obj
920         instead.
921         (ServerProcess._log): Style, remove extra empty line.
922         (ServerProcess._start):
923         (ServerProcess.stop):
924         (ServerProcess.kill):
925         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
926         (TrivialMockPort.__init__): Create a MockSystemHost used by
927         ServerProcess.
928         (TestServerProcess.test_broken_pipe): Test different platforms.
929
930 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
931
932         webkitpy: Style checker broken when committing a PNG
933         https://bugs.webkit.org/show_bug.cgi?id=85504
934
935         Reviewed by Dirk Pranke.
936
937         * Scripts/webkitpy/style/checkers/png.py:
938         (PNGChecker.__init__):
939
940 2012-05-03  Philippe Normand  <pnormand@igalia.com>
941
942         Unreviewed, fix another call to join(), similar to the ones landed
943         in r115975.
944
945         * Scripts/webkitdirs.pm:
946         (jhbuildConfigurationChanged):
947
948 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
949
950         webkitpy: Remove sys.platform accesses in CrashLogs.
951         https://bugs.webkit.org/show_bug.cgi?id=85436
952
953         Reviewed by Dirk Pranke.
954
955         Instead of directly checking for sys.platform == 'darwin', use a
956         SystemHost and call PlatformInfo.is_mac().
957
958         * Scripts/webkitpy/common/system/crashlogs.py:
959         (CrashLogs.__init__):
960         (CrashLogs.find_newest_log):
961         (CrashLogs._log_directory_darwin):
962         (CrashLogs._find_newest_log_darwin):
963         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
964         (CrashLogsTest.test_find_log_darwin):
965         * Scripts/webkitpy/layout_tests/port/mac.py:
966         (MacPort._get_crash_log):
967         * Scripts/webkitpy/layout_tests/port/test.py:
968         (TestDriver.run_test):
969         * Scripts/webkitpy/tool/commands/queries.py:
970         (execute):
971
972 2012-05-03  Philippe Normand  <pnormand@igalia.com>
973
974         [GTK] join() is wrongly used in webkitdirs.pm since r115532
975         https://bugs.webkit.org/show_bug.cgi?id=85501
976
977         Reviewed by Martin Robinson.
978
979         * Scripts/webkitdirs.pm:
980         (getJhbuildPath):
981         (buildAutotoolsProject):
982
983 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
984
985         [Gtk] ImageDiff crashes when it can't open a display
986         https://bugs.webkit.org/show_bug.cgi?id=85476
987
988         Reviewed by Martin Robinson.
989
990         Replace gdk_init() initialization call with the g_type_init()
991         call. GdkPixbufLoader doesn't actually need the current call to be
992         made and this change will also remove crashes when ImageDiff
993         is started in an environment without a DISPLAY env.
994
995         * DumpRenderTree/gtk/ImageDiff.cpp:
996         (main):
997
998 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
999
1000         ImageDiff should be run inside a properly established environment
1001         https://bugs.webkit.org/show_bug.cgi?id=85292
1002
1003         Reviewed by Martin Robinson.
1004
1005         When creating the ImageDiff server process, pass along a freshly-set-up environment
1006         in which the process should be executed in.
1007
1008         * Scripts/webkitpy/layout_tests/port/webkit.py:
1009         (WebKitPort._start_image_diff_process):
1010
1011 2012-05-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1012
1013         [Qt] Allow the web process and WTR to be paused on startup
1014
1015         Makes it easier to debug the web process or run-webkit-tests -2, as you
1016         have ample time to attach gdb to the process.
1017
1018         Reviewed by Simon Hausmann.
1019
1020         * Scripts/webkitpy/layout_tests/port/qt.py:
1021         (QtPort.setup_environ_for_server):
1022         * WebKitTestRunner/qt/main.cpp:
1023         (main):
1024
1025 2012-05-03  Csaba Osztrogonác  <ossy@webkit.org>
1026
1027         Password protect "Stop build" button
1028         https://bugs.webkit.org/show_bug.cgi?id=81982
1029
1030         Reviewed by Ryosuke Niwa.
1031
1032         Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
1033         features to prevent killing builds on build.webkit.org by SPAM bots.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1036
1037 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
1038
1039         [DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
1040         https://bugs.webkit.org/show_bug.cgi?id=85468
1041
1042         Reviewed by Nikolas Zimmermann.
1043
1044         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1045         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
1046         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1047         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
1048         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1049         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
1050         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1051         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
1052         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1053         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
1054
1055 2012-05-03  Stephanie Lewis  <slewis@apple.com>
1056
1057         https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
1058         <rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run
1059
1060         Reviewed by Brady Eidson.
1061
1062         The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
1063         for every world, even those that did not need the callback.  This had the side effect of creating a
1064         JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
1065         unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
1066         in the API.  The object can be accessed later by those worlds which require it.
1067
1068         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
1069         (TestWebKitAPI):
1070         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1071         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1072         (TestWebKitAPI):
1073         (DOMWindowExtensionBasic):
1074         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
1075         (TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
1076         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
1077
1078 2012-05-03  Nikolas Zimmermann  <nzimmermann@rim.com>
1079
1080         Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.
1081
1082         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1083         (LayoutTestController::resetPageVisibility):
1084         (LayoutTestController::setPageVisibility):
1085
1086 2012-05-02  Alexander Færøy  <ahf@0x90.dk>
1087
1088         Rename deviceDPI to devicePixelRatio
1089         https://bugs.webkit.org/show_bug.cgi?id=85049
1090
1091         Reviewed by Kenneth Rohde Christiansen.
1092
1093         Use 1.5 as device pixel ratio for the Qt MiniBrowser.
1094
1095         * MiniBrowser/qt/qml/BrowserWindow.qml:
1096
1097 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
1098
1099         [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
1100         https://bugs.webkit.org/show_bug.cgi?id=85347
1101
1102         Reviewed by Nikolas Zimmermann.
1103
1104         * DumpRenderTree/LayoutTestController.h:
1105         (LayoutTestController):
1106         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1107         (LayoutTestController::resetPageVisibility): Not implemented.
1108         (LayoutTestController::setPageVisibility): Not implemented.
1109         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1110         (LayoutTestController::resetPageVisibility): Reset the page visibility.
1111         (LayoutTestController::setPageVisibility): Set the page visibility.
1112         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1113         (LayoutTestController::resetPageVisibility): Not implemented.
1114         (LayoutTestController::setPageVisibility): Not implemented.
1115         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1116         (LayoutTestController::resetPageVisibility): Not implemented.
1117         (LayoutTestController::setPageVisibility): Not implemented.
1118         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1119         (LayoutTestController::resetPageVisibility): Not implemented.
1120         (LayoutTestController::setPageVisibility): Not implemented.
1121         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1122         (LayoutTestController::resetPageVisibility): Not implemented.
1123         (LayoutTestController::setPageVisibility): Not implemented.
1124
1125 2012-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1126
1127         Unreviewed, rolling out r115918.
1128         http://trac.webkit.org/changeset/115918
1129         https://bugs.webkit.org/show_bug.cgi?id=85452
1130
1131         "Broke test-webkitpy on Apple Lion bots" (Requested by estes
1132         on #webkit).
1133
1134         * Scripts/webkitpy/common/system/crashlogs.py:
1135         (CrashLogs.__init__):
1136         (CrashLogs.find_newest_log):
1137         (CrashLogs._log_directory_darwin):
1138         (CrashLogs._find_newest_log_darwin):
1139         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1140         (CrashLogsTest.test_find_log_darwin):
1141         * Scripts/webkitpy/layout_tests/port/mac.py:
1142         (MacPort._get_crash_log):
1143         * Scripts/webkitpy/layout_tests/port/test.py:
1144         (TestDriver.run_test):
1145         * Scripts/webkitpy/tool/commands/queries.py:
1146         (execute):
1147
1148 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1149
1150         webkitpy: Remove sys.platform accesses in CrashLogs.
1151         https://bugs.webkit.org/show_bug.cgi?id=85436
1152
1153         Reviewed by Dirk Pranke.
1154
1155         Instead of directly checking for sys.platform == 'darwin', use a
1156         SystemHost and call PlatformInfo.is_mac().
1157
1158         * Scripts/webkitpy/common/system/crashlogs.py:
1159         (CrashLogs.__init__):
1160         (CrashLogs.find_newest_log):
1161         (CrashLogs._log_directory_darwin):
1162         (CrashLogs._find_newest_log_darwin):
1163         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1164         (CrashLogsTest.test_find_log_darwin):
1165         * Scripts/webkitpy/layout_tests/port/mac.py:
1166         (MacPort._get_crash_log):
1167         * Scripts/webkitpy/layout_tests/port/test.py:
1168         (TestDriver.run_test):
1169         * Scripts/webkitpy/tool/commands/queries.py:
1170         (execute):
1171
1172 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1173
1174         webkitpy: Special-case win32 calls in file_lock and executive.
1175         https://bugs.webkit.org/show_bug.cgi?id=85431
1176
1177         Reviewed by Dirk Pranke.
1178
1179         Simplify accesses to sys.platform by only checking if sys.platform
1180         is "win32" and removing explicit checks for the else case.
1181
1182         * Scripts/webkitpy/common/system/executive.py:
1183         (Executive.check_running_pid):
1184         * Scripts/webkitpy/common/system/file_lock.py:
1185         (FileLock._create_lock):
1186         (FileLock._remove_lock):
1187
1188 2012-05-02  Ojan Vafai  <ojan@chromium.org>
1189
1190         Remove pink from flakiness dashboard
1191         https://bugs.webkit.org/show_bug.cgi?id=85422
1192
1193         Reviewed by Dirk Pranke.
1194
1195         The pink indicates that the test doesn't match it's listing in test_expectations.txt.
1196         In practice, this just added noise and confused people.
1197
1198         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1199         (htmlForSingleTestRow):
1200         (showLegend):
1201         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
1202         (#legend-contents *):
1203         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1204         (testHtmlForSingleTestRow):
1205
1206 2012-05-02  Gustavo Noronha Silva  <gns@gnome.org>
1207
1208         Unreviewed. Fix mistake I committed when applying review comments.
1209
1210         * jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
1211         appended to its path, so jhbuild itself was being cloned and
1212         installed in the wrong place when using WEBKITOUTPUTDIR.
1213
1214 2012-05-02  Dirk Pranke  <dpranke@chromium.org>
1215
1216         nrwt: make ServerProcess work on chromium win
1217         https://bugs.webkit.org/show_bug.cgi?id=85333
1218
1219         Reviewed by Ojan Vafai.
1220
1221         This change implements a poor man's select() that will
1222         slow-spin doing non-blocking reads on the stdout and stderr
1223         named pipes connecting the worker to the driver. Seems to work
1224         and I have yet to see much overhead or ill effects but it
1225         probably needs more testing.
1226
1227         * Scripts/webkitpy/layout_tests/port/chromium.py:
1228         (ChromiumDriver.__init__):
1229         * Scripts/webkitpy/layout_tests/port/server_process.py:
1230         (ServerProcess._start):
1231         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1232         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1233         (ServerProcess):
1234         (ServerProcess._non_blocking_read_win32):
1235         (ServerProcess._read):
1236         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1237         (TestServerProcess.test_basic): Added.
1238
1239 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1240
1241         webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
1242         https://bugs.webkit.org/show_bug.cgi?id=85426
1243
1244         Reviewed by Dirk Pranke.
1245
1246         r115880 replaced the direct use of sys.platform with a
1247         PlatformInfo object. Dirk Pranke later told me SystemHost objects
1248         should be preferred, as nothing out of webkitpy.common.system
1249         should create its own PlatformInfo instances.
1250
1251         * Scripts/webkitpy/common/system/systemhost_mock.py:
1252         (MockSystemHost.__init__): Make it possible to specify a custom
1253         filesystem object.
1254         * Scripts/webkitpy/style/checkers/png.py:
1255         (PNGChecker.__init__): Accept a host object instead of a
1256         filesystem one, which is now obtained from host.
1257         (PNGChecker._config_file_path): Retrieve PlatformInfo from
1258         SystemHost.
1259         * Scripts/webkitpy/style/checkers/png_unittest.py:
1260         (PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
1261         constructor signature.
1262         (PNGCheckerTest.test_check): Ditto.
1263
1264 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1265
1266         webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
1267         https://bugs.webkit.org/show_bug.cgi?id=85424
1268
1269         Reviewed by Tony Chang.
1270
1271         We should reduce direct usage of sys.platform in webkitpy and use
1272         PlatformInfo instead.
1273
1274         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1275         (Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
1276         checking for 'darwin' directly.
1277         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1278         (HttpServerBase.__init__): Ditto.
1279
1280 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1281
1282         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
1283         https://bugs.webkit.org/show_bug.cgi?id=85419
1284
1285         Reviewed by Dirk Pranke.
1286
1287         As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
1288         be created directly, we should should a SystemHost instead.
1289
1290         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1291         (MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
1292         object from it instead of creating PlatformInfo directly.
1293
1294 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1295
1296         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
1297         https://bugs.webkit.org/show_bug.cgi?id=85419
1298
1299         Rubber-stamped by Dirk Pranke.
1300
1301         Follow-up patch to r115887 which fixes some capitalization problems
1302         pointed out in comments 2 and 4.
1303
1304         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1305         (MainTest.setUp):
1306         (MainTest.test_child_processes_2):
1307         (MainTest.test_child_processes_min):
1308         (MainTest.test_exception_raised):
1309         (MainTest.test_keyboard_interrupt):
1310
1311 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1312
1313         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
1314         https://bugs.webkit.org/show_bug.cgi?id=85419
1315
1316         Reviewed by Dirk Pranke.
1317
1318         Another part of the work towards replacing direct sys.platform
1319         usage with PlatformInfo.
1320
1321         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1322         (MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
1323         here. Even though it is costlier, unittest.setUpClass was
1324         introduced in Python 2.7.
1325         (MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
1326         (MainTest.test_child_processes_min): Ditto.
1327         (MainTest.test_exception_raised): Ditto.
1328         (MainTest.test_keyboard_interrupt): Ditto.
1329         (MainTest.test_crash_log): Check for PlatformInfo.is_mac().
1330         (MainTest.test_web_process_crash_log): Ditto, and remove duplicate
1331         check at the end.
1332         (MainTest.test_no_http_tests): Remove check for (cygwin && Python
1333         2.5.2), as we only support Python 2.6+.
1334
1335 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1336
1337         webkitpy: Remove direct sys.platform usage in the PNG checker.
1338         https://bugs.webkit.org/show_bug.cgi?id=85407
1339
1340         Reviewed by Tony Chang.
1341
1342         Work towards replacing direct sys.platform usage with
1343         PlatformInfo.
1344
1345         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1346         (MockPlatformInfo.__init__): Accept os_name and os_version as
1347         arguments.
1348         * Scripts/webkitpy/style/checkers/png.py:
1349         (PNGChecker.__init__): Create a PlatformInfo object instead of
1350         using sys.platform when needed.
1351         (PNGChecker._config_file_path): Check for the current platform via
1352         PlatformInfo.
1353         * Scripts/webkitpy/style/checkers/png_unittest.py:
1354         (PNGCheckerTest.test_check): Update tests after the changes above.
1355
1356 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
1357
1358         [watchlist] Update watchlist rules for EFL-related patches.
1359         http://bugs.webkit.org/show_bug.cgi?id=85160
1360
1361         Reviewed by Eric Seidel.
1362
1363         * Scripts/webkitpy/common/config/watchlist: Monitor
1364         Source/WTF/wtf/efl and LayoutTests/platform/efl as well.
1365
1366 2012-05-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1367
1368         Revert r115191 - "Make the web view's url property follow the active url"
1369
1370         It uncovered/caused issues in the icon-implementation that can't be
1371         easily fixed, so rolling out instead.
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=77554
1374
1375         Rubber-stamped by Simon Hausmann.
1376
1377         * MiniBrowser/qt/qml/BrowserWindow.qml:
1378         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1379         (TestWebKitAPI::TEST):
1380
1381 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
1382
1383         Reftest mismatches are providing undefined diff percent in results.html
1384         https://bugs.webkit.org/show_bug.cgi?id=85283
1385
1386         Reviewed by Ojan Vafai.
1387
1388         When writing test results for a reftest mismatch, also take into account the
1389         difference percent that is produced when generating image diff. This value is
1390         then used when creating test results in the form of dictionaries, stored under
1391         the 'image_diff_percent' key. It ultimately ends up in JSON results data,
1392         providing additional information about the reftest difference.
1393
1394         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1395         (interpret_test_failures): Store the diff percent for reftest failure under the
1396         'image_diff_percent' key.
1397         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1398         (write_test_result): Also set the new diff_percent attribute of the reftest
1399         mismatch failure to the value of the difference percent ImageDiff outputs.
1400         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1401         (FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
1402         default value of None.
1403         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1404         (EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.
1405
1406 2012-05-02  Terry Anderson  <tdanderson@chromium.org>
1407
1408         Addition of a contributor to committers.py
1409         https://bugs.webkit.org/show_bug.cgi?id=85324
1410
1411         Reviewed by Unreviewed.
1412
1413         * Scripts/webkitpy/common/config/committers.py:
1414
1415 2012-05-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1416
1417         [EFL] EFL's LayoutTestController overridePreference implementation
1418         https://bugs.webkit.org/show_bug.cgi?id=83007
1419
1420         Reviewed by Antonio Gomes.
1421
1422         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1423         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1424         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1425         (toBool): aux function converting JSStringRef to bool
1426         (toInt): aux function converting JSStringRef to int
1427         (LayoutTestController::overridePreference): added implementation
1428
1429 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
1430
1431         webkitpy: Fix sys.platform check in find_files_unittest.
1432         https://bugs.webkit.org/show_bug.cgi?id=85339
1433
1434         Reviewed by Ryosuke Niwa.
1435
1436         Follow-up to r101618 -- 'win' is not a valid sys.platform value,
1437         'win32' should be used instead. The check always returned false
1438         due to this, so assert_normalize() was never called.
1439
1440         * Scripts/webkitpy/common/find_files_unittest.py:
1441         (TestWinNormalize.test_win): Add the missing import for the
1442         FileSystem class and fix the sys.platform check.
1443
1444 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
1445
1446         [GTK] drag&drop related failures
1447         https://bugs.webkit.org/show_bug.cgi?id=84675
1448
1449         Reviewed by Philippe Normand.
1450
1451         Rather than checking options to see whether we're running pixel tests
1452         the pixel_tests argument passed to GtkDriver._start should be used as
1453         it also covers cases when pixel tests should be run because of testing
1454         reftests. This again creates different Xvfb processes with proper
1455         display IDs for a worker that's performing both ordinary and pixel
1456         tests, as was the case before changes made in r114788.
1457
1458         * Scripts/webkitpy/layout_tests/port/gtk.py:
1459         (GtkDriver._start):
1460
1461 2012-05-02  Simon Hausmann  <simon.hausmann@nokia.com>
1462
1463         [Qt] Enable device orientation/motion with Qt 5
1464
1465         Reviewed by Tor Arne Vestbø.
1466
1467         Enable device orientation/motion features with Qt 5 if Qt Sensors is available.
1468
1469         * qmake/mkspecs/features/features.prf:
1470
1471 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
1472
1473         webkitpy: Remove unused platform imports.
1474         https://bugs.webkit.org/show_bug.cgi?id=85341
1475
1476         Reviewed by Eric Seidel.
1477
1478         Remove a few uses of `import platform' which were either rendered
1479         unneeded after r105931 or were never needed at all.
1480
1481         * Scripts/webkitpy/common/system/executive.py:
1482         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1483
1484 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
1485
1486         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
1487         https://bugs.webkit.org/show_bug.cgi?id=85289
1488
1489         Reviewed by Eric Seidel.
1490
1491         * DumpRenderTree/chromium/EventSender.cpp:
1492         (EventSender::gestureEvent):
1493             This change will allow for testing of WK85101. Currently
1494             no tests use the extra parameters deltaX and deltaY. Added
1495             a check for the size of |arguments|.
1496
1497 2012-05-01  Eric Seidel  <eric@webkit.org>
1498
1499         Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
1500         https://bugs.webkit.org/show_bug.cgi?id=85305
1501
1502         Reviewed by Adam Barth.
1503
1504         * Scripts/webkitpy/common/config/watchlist:
1505
1506 2012-05-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1507
1508         Unreviewed, rolling out r115735.
1509         http://trac.webkit.org/changeset/115735
1510         https://bugs.webkit.org/show_bug.cgi?id=85314
1511
1512         cause two tests to crash due to an ASSERTION failure
1513         (Requested by zhenyao on #webkit).
1514
1515         * DumpRenderTree/chromium/EventSender.cpp:
1516         (EventSender::gestureEvent):
1517
1518 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
1519
1520         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
1521         https://bugs.webkit.org/show_bug.cgi?id=85289
1522
1523         Reviewed by Eric Seidel.
1524
1525         * DumpRenderTree/chromium/EventSender.cpp:
1526         (EventSender::gestureEvent):
1527             This change will allow for testing of WK85101. Currently no tests use the extra
1528             parameters deltaX and deltaY.
1529
1530 2012-05-01  Zan Dobersek  <zandobersek@gmail.com>
1531
1532         Print out stderr output of ImageDiff if it is present
1533         https://bugs.webkit.org/show_bug.cgi?id=85285
1534
1535         Reviewed by Philippe Normand.
1536
1537         Log the stderr output of ImageDiff as a warning if present. This is
1538         especially helpful when ImageDiff crashes and stderr data might contain
1539         relevant information about what caused the crash.
1540
1541         * Scripts/webkitpy/layout_tests/port/webkit.py:
1542         (WebKitPort._read_image_diff):
1543
1544 2012-05-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1545
1546         [Qt] Add an experimental extension to set the min. contents width
1547         https://bugs.webkit.org/show_bug.cgi?id=85281
1548
1549         Reviewed by Antonio Gomes.
1550
1551         * MiniBrowser/qt/qml/BrowserWindow.qml:
1552
1553         Set the value of preferredMinimumContentsWidth to 980.
1554
1555 2012-04-30  Ojan Vafai  <ojan@chromium.org>
1556
1557         Fix tests to not depend on the actual list of builders at build.chromium.org.
1558
1559         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1560         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1561         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1562
1563 2012-04-29  Sam Weinig  <sam@webkit.org>
1564
1565         Remove BlobBuilder
1566         https://bugs.webkit.org/show_bug.cgi?id=84036
1567
1568         Reviewed by Anders Carlsson.
1569
1570         * Scripts/build-webkit:
1571         * qmake/mkspecs/features/features.prf:
1572         Make exposing the WebKitBlobBuilder JS object conditional on a new
1573         ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
1574         but do for everyone else.
1575
1576 2012-04-30  Amruth Raj Padmanabhuni  <amruthraj@motorola.com>
1577
1578         [GTK] Add glib as a dependency to build glib-networking
1579         https://bugs.webkit.org/show_bug.cgi?id=85181
1580
1581         Reviewed by Martin Robinson.
1582
1583         * gtk/jhbuild.modules:
1584
1585 2012-04-30  Alexis Menard  <alexis.menard@openbossa.org>
1586
1587         Move myself to reviewers.
1588
1589         Reviewed by Andreas Kling.
1590
1591         * Scripts/webkitpy/common/config/committers.py:
1592
1593 2012-04-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1594
1595         Unreviewed, move myself to reviewers
1596
1597         * Scripts/webkitpy/common/config/committers.py:
1598
1599 2012-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
1600
1601         Unreviewed. Fix make distcheck.
1602
1603         * TestWebKitAPI/GNUmakefile.am: Add missing headers to compilation
1604         and resources to EXTRA_DIST.
1605
1606 2012-04-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1607
1608         [GTK] DRT support for layoutTestController.removeOriginAccessWhitelistEntry
1609         https://bugs.webkit.org/show_bug.cgi?id=85156
1610
1611         Reviewed by Martin Robinson.
1612
1613         Add missing implementation removeOriginAccessWhitelistEntry to
1614         GTK's LayoutTestController.
1615
1616         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1617         (LayoutTestController::removeOriginAccessWhitelistEntry):
1618
1619 2012-04-29  Maciej Stachowiak  <mjs@apple.com>
1620
1621         REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
1622         https://bugs.webkit.org/show_bug.cgi?id=81729
1623
1624         Reviewed by Dan Bernstein.
1625
1626         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1627         (Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.
1628
1629 2012-04-29  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1630
1631         [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
1632         https://bugs.webkit.org/show_bug.cgi?id=85131
1633
1634         Reviewed by Martin Robinson.
1635
1636         Add missing implementation setDomainRelaxationForbiddenForURLScheme to
1637         GTK's LayoutTestController.
1638
1639         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1640         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
1641
1642 2012-04-28  Sam Weinig  <sam@webkit.org>
1643
1644         Smooth scrolling needs a new key
1645         <rdar://problem/11331632>
1646
1647         Reviewed by Dan Bernstein.
1648
1649         * DumpRenderTree/mac/DumpRenderTree.mm:
1650         (resetDefaultsToConsistentValues):
1651         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
1652         (TestWebKitAPI::InjectedBundleController::platformInitialize):
1653         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1654         (WTR::InjectedBundle::platformInitialize):
1655         Update for new key.
1656
1657 2012-04-28  Zan Dobersek  <zandobersek@gmail.com>
1658
1659         [WK2] http/tests/navigation/anchor-frames-gbk.html fails
1660         https://bugs.webkit.org/show_bug.cgi?id=76896
1661
1662         Reviewed by Darin Adler.
1663
1664         Only dump as text if currently dumping render tree. This ensures that
1665         calling dumpAsText in a test with dumpChildFramesAsText already being
1666         called doesn't override the first decision, possibly making tests fail.
1667
1668         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1669         (WTR::LayoutTestController::dumpAsText):
1670
1671 2012-04-28  Dan Winship  <danw@gnome.org>
1672
1673         Unreviewed; Add me to the SoupNetwork watchlist
1674
1675         * Scripts/webkitpy/common/config/watchlist:
1676
1677 2012-04-27  Gustavo Noronha Silva  <gns@gnome.org>
1678
1679         [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
1680         https://bugs.webkit.org/show_bug.cgi?id=76161
1681
1682         Reviewed by Martin Robinson.
1683
1684         * Scripts/webkitdirs.pm:
1685         (getJhbuildPath): New method to obtain the jhbuild base directory,
1686         using the product base directory
1687         (jhbuildConfigurationChanged): Use the new method
1688         (buildAutotoolsProject): Ditto.
1689         * efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
1690         * gtk/jhbuildrc: Ditto.
1691         * jhbuild/jhbuild-wrapper: Ditto.
1692
1693 2012-04-27  Scott Graham  <scottmg@chromium.org>
1694
1695         [chromium] make case of npTestNetscapePlugIn.dll match case in copy rule
1696         https://bugs.webkit.org/show_bug.cgi?id=85083
1697
1698         Reviewed by Dirk Pranke.
1699
1700         Make output product_name for npTestNetscapePlugIn.dll match the case
1701         of the copy_TestNetscapePlugIn rule. This is required for ninja, which
1702         is more particular about case matching in rules than the VS build.
1703
1704         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1705
1706 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1707
1708         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
1709         https://bugs.webkit.org/show_bug.cgi?id=84917
1710
1711         Unreviewed, build fix.
1712
1713         Reland the change in r115453 with a fix for chromium win.
1714         The logic in ChromiumDriver was busted on windows, causing DRT
1715         to get launched without the --test-shell flag.
1716
1717         * Scripts/webkitpy/layout_tests/port/chromium.py:
1718         (ChromiumDriver):
1719         (ChromiumDriver.__init__):
1720         (ChromiumDriver._wrapper_options):
1721         (ChromiumDriver.cmd_line):
1722         (ChromiumDriver._start):
1723         (ChromiumDriver.has_crashed):
1724         (ChromiumDriver.run_test):
1725         (ChromiumDriver.stop):
1726         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1727         (ChromiumDriverTest.setUp):
1728         (ChromiumDriverTest.test_stop):
1729         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
1730         (ChromiumDriverTest.test_two_drivers):
1731
1732 2012-04-27  Peter Beverloo  <peter@chromium.org>
1733
1734         Add John Grabowski as a non-committer to committers.py
1735         https://bugs.webkit.org/show_bug.cgi?id=85080
1736
1737         Reviewed by Dirk Pranke.
1738
1739         He's being CC'ed often enough because of his involvement in the Chromium
1740         side of Chrome for Android upstreaming.
1741
1742         * Scripts/webkitpy/common/config/committers.py:
1743           add jrg@chromium.org
1744
1745 2012-04-27  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1746
1747         [Qt] Fix minimal build.
1748         https://bugs.webkit.org/show_bug.cgi?id=85045
1749
1750         Reviewed by Tor Arne Vestbø.
1751
1752         Do not set conflicting values of ENABLE_XSLT.
1753
1754         * qmake/mkspecs/features/features.prf:
1755
1756 2012-04-27  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1757
1758         [EFL][DRT] EFL should sanitize pulseaudio module configuration too
1759         https://bugs.webkit.org/show_bug.cgi?id=85047
1760
1761         Reviewed by Dirk Pranke.
1762
1763         PulseAudio test setup sanitization shared between EFL and GTK.
1764
1765         * Scripts/webkitpy/layout_tests/port/efl.py:
1766         (EflPort):
1767         (EflPort.setup_test_run):
1768         (EflPort.clean_up_test_run):
1769         * Scripts/webkitpy/layout_tests/port/gtk.py:
1770         (GtkPort): Moving pulseaudio unload/restore out to shared class.
1771         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py: Added.
1772         (PulseAudioSanitizer):
1773         (PulseAudioSanitizer._unload_pulseaudio_module):
1774         (PulseAudioSanitizer._restore_pulseaudio_module):
1775
1776 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1777
1778         Unreviewed, revert r115453 - broke chromium win bots
1779
1780         * Scripts/webkitpy/layout_tests/port/chromium.py:
1781         (ChromiumPort._path_to_image_diff):
1782         (ChromiumDriver):
1783         (ChromiumDriver.__init__):
1784         (ChromiumDriver._wrapper_options):
1785         (ChromiumDriver.cmd_line):
1786         (ChromiumDriver.stop):
1787         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1788         (ChromiumDriverTest.setUp):
1789         (ChromiumDriverTest.test_stop):
1790         (ChromiumDriverTest.test_two_drivers):
1791         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
1792
1793 2012-04-27  Ryosuke Niwa  <rniwa@webkit.org>
1794
1795         Chromium Windows Perf bots timeout due to not output
1796         https://bugs.webkit.org/show_bug.cgi?id=84940
1797
1798         Reviewed by Dirk Pranke.
1799
1800         Dirk and I investigated the issue on the bot but we couldn't figure out what is going wrong.
1801         Since we run-perf-tests don't need any of fancy feature printer provides, just use python's
1802         built-in logging module instead. Printing out to stdout and stderr seem to work so hopefully
1803         this will fix the issue on the bot.
1804
1805         * Scripts/run-perf-tests:
1806         * Scripts/webkitpy/performance_tests/perftest.py:
1807         (PerfTest.run):
1808         (PerfTest.run_failed):
1809         (PerfTest.parse_output):
1810         (PerfTest.output_statistics):
1811         (ChromiumStylePerfTest.parse_output):
1812         (PageLoadingPerfTest.run):
1813         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1814         (MainTest.test_parse_output):
1815         (MainTest.test_parse_output_with_failing_line):
1816         (TestPageLoadingPerfTest):
1817         (TestPageLoadingPerfTest.test_run):
1818         (TestPageLoadingPerfTest.test_run_with_bad_output):
1819         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1820         (PerfTestsRunner.__init__):
1821         (PerfTestsRunner._parse_args):
1822         (PerfTestsRunner.run):
1823         (PerfTestsRunner._upload_json):
1824         (PerfTestsRunner._print_status):
1825         (PerfTestsRunner._run_tests_set):
1826         (PerfTestsRunner._run_single_test):
1827         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1828         (create_runner):
1829         (test_run_test_set):
1830         (test_run_test_set_kills_drt_per_run):
1831         (test_run_test_pause_before_testing):
1832         (test_run_test_set_for_parser_tests):
1833         (test_run_test_set_with_json_output):
1834         (test_run_test_set_with_json_source):
1835         (test_run_test_set_with_multiple_repositories):
1836         (test_upload_json):
1837         (test_parse_args):
1838
1839 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1840
1841         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
1842         https://bugs.webkit.org/show_bug.cgi?id=84917
1843
1844         Reviewed by Ojan Vafai.
1845
1846         This change changes the chromium new-run-webkit-tests
1847         implementation to use the code in WebKitDriver and ServerProcess
1848         by default on Mac and Linux, instead of using the old-style
1849         Chromium/test_shell style of output.
1850
1851         We will still use the test_shell style on Windows for now
1852         and you can still get the old style of behavior with
1853         new-run-webkit-tests --additional-drt-flag --test-shell
1854
1855         * Scripts/webkitpy/layout_tests/port/chromium.py:
1856         (ChromiumDriver):
1857         (ChromiumDriver.__init__):
1858         (ChromiumDriver._wrapper_options):
1859         (ChromiumDriver.cmd_line):
1860         (ChromiumDriver._start):
1861         (ChromiumDriver.has_crashed):
1862         (ChromiumDriver.run_test):
1863         (ChromiumDriver.stop):
1864         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1865         (ChromiumDriverTest.setUp):
1866         (ChromiumDriverTest.test_stop):
1867         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
1868         (ChromiumDriverTest.test_two_drivers):
1869
1870 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
1871
1872         webkitpy: fix race in unit tests for manager_worker_broker
1873         https://bugs.webkit.org/show_bug.cgi?id=84925
1874
1875         Reviewed by Ojan Vafai.
1876
1877         I have been intermittently seeing hangs when running
1878         test-webkitpy on Mac SL; it appears that there's a bug (?) in
1879         the multiprocessing module where queue references are getting
1880         leaked or not cleaned up somehow. By explicitly closing the
1881         queues, things seem to be happy, so this patch adds a cleanup()
1882         method to the message broker and modifies the manager (and the
1883         unit tests) to call it. This may get rid of the intermittent
1884         error on shutdown on Linux I've seen as well.
1885
1886         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1887         (Manager._run_tests):
1888         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1889         (_Broker.__del__):
1890         (_Broker):
1891         (_Broker.cleanup):
1892         (_BrokerConnection.cleanup):
1893         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1894         (_TestsMixin.test_name):
1895         (_TestsMixin.test_cancel):
1896         (_TestsMixin.test_done):
1897         (_TestsMixin.test_unknown_message):
1898
1899 2012-04-27  Gavin Peters  <gavinp@chromium.org>
1900
1901         Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
1902         https://bugs.webkit.org/show_bug.cgi?id=84871
1903
1904         Reviewed by Adam Barth.
1905
1906         Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
1907         API separates it from prefetching.  Having separate include guards lets ports enable prefetching,
1908         a relatively easy change, without needing to build the infrastructure for prerendering, which
1909         is considerably more complicated.
1910
1911 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1912
1913         Unreviewed, GTK gardening.
1914
1915         * Scripts/run-gtk-tests:
1916         (TestRunner): Skip flaky WebKit2 API test.
1917
1918 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1919
1920         Unreviewed, GTK gardening.
1921
1922         * Scripts/run-gtk-tests:
1923         (TestRunner): Fix another typo. So easy to get confused by a Test
1924         name and the actual name of the executable...
1925
1926 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1927
1928         Unreviewed, GTK gardening.
1929
1930         * Scripts/run-gtk-tests:
1931         (TestRunner): Skip failing WebKit2 API test.
1932
1933 2012-04-27  Christophe Dumez  <christophe.dumez@intel.com>
1934
1935         [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
1936         https://bugs.webkit.org/show_bug.cgi?id=81891
1937
1938         Reviewed by Philippe Normand.
1939
1940         Implement support for LayoutTestController's
1941         dumpResourceLoadCallbacks() in EFL's DumpRenderTree by catching new
1942         ewk_view signals about resource loading and print out the expected
1943         information. This allows for several test cases to be removed from the
1944         skip list.
1945
1946         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1947         (DumpRenderTreeChrome::createView):
1948         (descriptionSuitableForTestResult):
1949         (DumpRenderTreeChrome::onResponseReceived):
1950         (DumpRenderTreeChrome::onResourceLoadFinished):
1951         (DumpRenderTreeChrome::onResourceLoadFailed):
1952         (DumpRenderTreeChrome::onNewResourceRequest):
1953         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1954         (DumpRenderTreeChrome):
1955
1956 2012-04-27  Philippe Normand  <pnormand@igalia.com>
1957
1958         Unreviewed, GTK typo fix.
1959
1960         * Scripts/run-gtk-tests:
1961         (TestRunner): Fix-up skipped WebKit2 API test name TestWKConnection.
1962
1963 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
1964
1965         [SOUP] Add a way to register custom uri schemes in WebKit2
1966         https://bugs.webkit.org/show_bug.cgi?id=84130
1967
1968         Reviewed by Martin Robinson.
1969
1970         * Scripts/webkitpy/style/checkers/cpp.py:
1971         (check_identifier_name_in_declaration): Add webkit_soup prefix to
1972         the list of exceptions to the underscores in identifiers rule.
1973
1974 2012-04-26  Ryosuke Niwa  <rniwa@webkit.org>
1975
1976         Extract PerfTestFactory
1977         https://bugs.webkit.org/show_bug.cgi?id=83944
1978
1979         Reviewed by Dirk Pranke.
1980         
1981         Extracted PerfTestFactory out of PerfTest. This class creates appropriate PerfTest object given
1982         a test name and a path. Also removed dirname from the constructors of PerfTest and its subclasses.
1983
1984         Also added simple test cases to sanity check PerfTestFactory.
1985
1986         * Scripts/webkitpy/performance_tests/perftest.py:
1987         (PerfTest.__init__):
1988         (PerfTest.test_name):
1989         (ChromiumStylePerfTest.__init__):
1990         (PageLoadingPerfTest.__init__):
1991         (PageLoadingPerfTest.run):
1992         (PerfTestFactory):
1993         (PerfTestFactory.create_perf_test):
1994         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1995         (MainTest.test_parse_output):
1996         (MainTest.test_parse_output_with_failing_line):
1997         (TestPageLoadingPerfTest.test_run):
1998         (TestPageLoadingPerfTest.test_run_with_bad_output):
1999         (TestPerfTestFactory):
2000         (TestPerfTestFactory.test_regular_test):
2001         (TestPerfTestFactory.test_inspector_test):
2002         (TestPerfTestFactory.test_page_loading_test):
2003         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2004         (PerfTestsRunner):
2005         (PerfTestsRunner._collect_tests):
2006         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2007         (run_test):
2008         (_tests_for_runner):
2009
2010 2012-04-26  Dirk Pranke  <dpranke@chromium.org>
2011
2012         nrwt: clean up server process, webkit driver so chromium can use it
2013         https://bugs.webkit.org/show_bug.cgi?id=84910
2014
2015         Reviewed by Ojan Vafai.
2016
2017         This change moves the "sample a process" logic out of
2018         server_process.py and into a port-specific class (where really
2019         only the mac has an implementation), and also preemptively kills
2020         DRT when a test times out in WebKitDriver (rather than waiting through the
2021         additional delays caused by calling stop() when we would want to
2022         restart the driver generically in worker.py).
2023
2024         These changes will make it possible for the chromium port to
2025         switch over to the stock WebKitDriver implementation, at least
2026         on mac and linux.
2027
2028         * Scripts/webkitpy/layout_tests/port/base.py:
2029         (Port.sample_process):
2030         * Scripts/webkitpy/layout_tests/port/mac.py:
2031         (MacPort.sample_process):
2032         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2033         (test_helper_fails_to_stop):
2034         (test_sample_process):
2035         (test_sample_process.logging_run_command):
2036         (test_sample_process_throws_exception):
2037         (test_sample_process_throws_exception.throwing_run_command):
2038         * Scripts/webkitpy/layout_tests/port/server_process.py:
2039         (ServerProcess._log):
2040         (ServerProcess._handle_timeout):
2041         (ServerProcess.stop):
2042         (ServerProcess):
2043         (ServerProcess.kill): Here we add a method to immediately stop
2044         the process rather than trying to shut it down cleanly.
2045         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2046         (TestServerProcess.test_broken_pipe):
2047         * Scripts/webkitpy/layout_tests/port/webkit.py:
2048         (WebKitDriver.run_test): Fix an issue where we weren't passing
2049         along any per-test args (only needed for Chromium, but still).
2050         Also, kill the driver immediately if we time out a test.
2051
2052 2012-04-26  Benjamin Poulain  <bpoulain@apple.com>
2053
2054         ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
2055         https://bugs.webkit.org/show_bug.cgi?id=84668
2056
2057         Reviewed by Alexey Proskuryakov.
2058
2059         Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.
2060
2061         * DumpRenderTree/mac/ObjCPlugin.m:
2062         (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
2063         (+[ObjCPlugin webScriptNameForSelector:]):
2064         (-[ObjCPlugin methodMappedToLongName]):
2065         (-[ObjCPlugin testConversionColon:]):
2066         (-[ObjCPlugin _:]):
2067
2068 2012-04-26  Dimitri Glazkov  <dglazkov@chromium.org>
2069
2070         Unreviewed, rolling out r115340.
2071         http://trac.webkit.org/changeset/115340
2072         https://bugs.webkit.org/show_bug.cgi?id=83048
2073
2074         Does not work with Windows.
2075
2076         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2077         (SingleTestRunner._run_reftest):
2078         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2079         (copy_file):
2080         * Scripts/webkitpy/layout_tests/port/base.py:
2081         (Port._parse_reftest_list):
2082         (Port.reference_files):
2083         (Port._real_tests):
2084         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2085         (PortTest.test_reference_files):
2086         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2087         (ChromiumDriverTest.test_write_command_and_read_line):
2088
2089 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
2090
2091         [EFL] Enable VIDEO_TRACK feature
2092         https://bugs.webkit.org/show_bug.cgi?id=84830
2093
2094         Reviewed by Gustavo Noronha Silva.
2095
2096         Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
2097         used.
2098
2099         * Scripts/build-webkit:
2100
2101 2012-04-08  Robert Hogan  <robert@webkit.org>
2102
2103         new-webkit-run-tests: handle ref tests from the CSS test suite
2104         https://bugs.webkit.org/show_bug.cgi?id=83048
2105
2106         Reviewed by Ryosuke Niwa.
2107
2108         This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
2109         of pixel and text results that are no longer required now that the reference results are used and adds in the support
2110         files from the CSS test suite that allow the ref tests to run.
2111
2112         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2113         (SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would
2114          run without it and report a pass!
2115         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2116         (copy_file): ensure the output directory exists, it may not if the reference test is
2117           contained in a folder that contains nothing but reference tests.
2118         * Scripts/webkitpy/layout_tests/port/base.py:
2119         (Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
2120         (Port.reference_files): Only return reference results in the reftest list that actually exist on
2121           disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
2122           don't ignore them just because we have a reftest list for the test's directory.
2123         (Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic
2124           is used by the CSS 2.1 test suite.
2125         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2126         (PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result
2127           on disk but no reference result listed in the directory's reftest list picks up its reference result.
2128         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2129         (ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated
2130          as the same file.
2131
2132 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2133
2134         Unreviewed. Fix GTK+ build after r115314.
2135
2136         For some reason it fails while bulding GtkVersioning for WTR, but
2137         it didn't fail neither in EWS nor in my laptop. We don't really
2138         need GtkVersioning in WTR since it already depends on GTK+3
2139         unconditionally.
2140
2141         * WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from
2142         compilation.
2143         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2144         (WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
2145         directly instead of getDefaultGDKPointerDevice() helper.
2146         (WTR::EventSenderProxy::keyDown): Ditto.
2147         (WTR::EventSenderProxy::mouseMoveTo): Ditto.
2148
2149 2012-04-24  Ojan Vafai  <ojan@chromium.org>
2150
2151         Show flakiness dashboard data in garden-o-matic
2152         https://bugs.webkit.org/show_bug.cgi?id=83716
2153
2154         Reviewed by Dimitri Glazkov.
2155
2156         Put an iframe below the expected/actual results in the Results view.
2157         Size the iframe to it's height.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2166
2167 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2168
2169         [EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
2170         https://bugs.webkit.org/show_bug.cgi?id=84576
2171
2172         Reviewed by Martin Robinson.
2173
2174         Add missing implementation setJavaScriptProfilingEnabled to EFL's
2175         LayoutTestController in order to unskip tests rely on this setting.
2176
2177         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2178         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2179         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2180         (LayoutTestController::setJavaScriptProfilingEnabled):
2181
2182 2012-04-26  Xianzhu Wang  <wangxianzhu@chromium.org>
2183
2184         Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
2185
2186         Not reviewed.
2187
2188         * Scripts/webkitpy/common/config/committers.py:
2189
2190 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2191
2192         [GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
2193         https://bugs.webkit.org/show_bug.cgi?id=84957
2194
2195         Reviewed by Martin Robinson.
2196
2197         * Scripts/run-gtk-tests:
2198         (TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
2199         TestNewFirstVisuallyNonEmptyLayoutForImages.
2200         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2201         (TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
2202         toplevel window containing the web view to make sure events are
2203         received.
2204
2205 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2206
2207         Unreviewed. Add bug numbers to skipped tests.
2208
2209         * Scripts/run-gtk-tests:
2210         (TestRunner):
2211
2212 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2213
2214         [GTK] Build and run TestWebKitAPI WebKit2 unit tests
2215         https://bugs.webkit.org/show_bug.cgi?id=84446
2216
2217         Reviewed by Philippe Normand.
2218
2219         * Scripts/run-gtk-tests:
2220         (TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
2221         containing tests. Unskip FunctionalTest.RefCountedStorage, since
2222         we are now using a custom main that initializes WTF threading.
2223         (TestRunner._setup_testing_environment): Set environment variables
2224         required to run WebKit2 tests.
2225         * TestWebKitAPI/GNUmakefile.am:
2226         * TestWebKitAPI/JavaScriptTest.cpp: Use
2227         JavaScriptCore/JSContextRef.h instead of
2228         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
2229         unconditionally.
2230         * TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
2231         PlatformWindow for GTK.
2232         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
2233         unneded header that breaks the build of GTK port.
2234         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
2235         JavaScriptCore/JSContextRef.h instead of
2236         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
2237         unconditionally.
2238         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2239         (TestWebKitAPI::TEST): Add expected values for GTK+ port.
2240         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
2241         (TestWebKitAPI):
2242         (TestWebKitAPI::InjectedBundleController::platformInitialize):
2243         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
2244         (TestWebKitAPI::Util::checkTestFinished):
2245         (TestWebKitAPI::Util::run):
2246         (TestWebKitAPI::Util::sleep):
2247         (TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
2248         (TestWebKitAPI::Util::createInjectedBundlePath):
2249         (TestWebKitAPI::Util::createURLForResource):
2250         (TestWebKitAPI::Util::URLForNonExistentResource):
2251         (TestWebKitAPI::Util::isKeyDown):
2252         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
2253         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2254         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
2255         (TestWebKitAPI::PlatformWebView::page):
2256         (TestWebKitAPI::PlatformWebView::resizeTo):
2257         (TestWebKitAPI::doKeyStroke):
2258         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2259         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
2260         (TestWebKitAPI::doMouseButtonEvent):
2261         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2262         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
2263         * TestWebKitAPI/gtk/main.cpp:
2264         (main):
2265
2266 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2267
2268         [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
2269         https://bugs.webkit.org/show_bug.cgi?id=84695
2270
2271         Reviewed by Philippe Normand.
2272
2273         It also adds a command line option to be able to pass a custom
2274         timeout value, instead of hard-coding it. The default timeout is 10
2275         seconds if no other value is passed to the script.
2276
2277         * Scripts/run-gtk-tests:
2278         (TestTimeout): Exception raised when a test times out.
2279         (TestRunner._get_child_pid_from_test_output): Helper function to
2280         get the pid of the running test from gtester output.
2281         (TestRunner._kill_process): Helper funtion ot kill a process
2282         ignoring exceptions if the process is already died.
2283         (TestRunner._run_test_command): Run the test command raising
2284         TestTimeout exception if the test doesn't finish before the given
2285         timeout in seconds.
2286         (TestRunner._run_test_command.alarm_handler): Alarm handler that
2287         raises TestTimeout exception.
2288         (TestRunner._run_test_glib): Use _run_test_command() to run the test.
2289         (TestRunner._run_test_google): Ditto.
2290         (TestRunner.run_tests): Add current test to the list of timed out
2291         test if TestTimeout exception is raised. Show the list of timed
2292         out test at the end.
2293
2294 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2295
2296         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
2297         https://bugs.webkit.org/show_bug.cgi?id=83880
2298
2299         Reviewed by Antonio Gomes.
2300
2301         Add missing implementation addOriginAccessWhitelistEntry and
2302         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
2303         in order to unskip tests which rely on this.
2304
2305         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2306         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2307         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2308         (LayoutTestController::addOriginAccessWhitelistEntry):
2309         (LayoutTestController::removeOriginAccessWhitelistEntry):
2310
2311 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2312
2313         [GTK] Add downloads support to MiniBrowser
2314         https://bugs.webkit.org/show_bug.cgi?id=73662
2315
2316         Reviewed by Philippe Normand.
2317
2318         * MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
2319         (browserDownloadsBarChildRemoved): Close the downloads bar if
2320         there aren't active downloads.
2321         (browserDownloadsBarResponse): Destroy the downloads bar when
2322         closed.
2323         (browser_downloads_bar_init):
2324         (browser_downloads_bar_class_init):
2325         (browser_downloads_bar_new): Create a new downloads bar.
2326         (actionButtonClicked): Cancel the download if cancel button was
2327         clicked, or open the downloaded file if the download finished.
2328         (browserDownloadFinalize):
2329         (browser_download_init):
2330         (browser_download_class_init):
2331         (downloadReceivedResponse): Update download message using the
2332         response URI.
2333         (remainingTime): Helper function to get human readable remaining
2334         time.
2335         (downloadProgress): Update downloads progress.
2336         (downloadReceivedData):
2337         (downloadFinished): Update download message and turn download
2338         button into open.
2339         (downloadFailed): Show error message or destroy the download UI if
2340         it was cancelled.
2341         (browserDownloadNew): Create a new download widget for the given
2342         WebKitDownload.
2343         (browser_downloads_bar_add_download): Add download widget to the
2344         downloads bar.
2345         * MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
2346         * MiniBrowser/gtk/BrowserWindow.c:
2347         (downloadStarted): Create a download widget and add it to the
2348         downloads bar when a new download is started.
2349         (browserWindowConstructed): Connect to
2350         WebKitWebContext::download-started signal.
2351         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
2352
2353 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2354
2355         Unreviewed. Skip unit test failing in debug bot.
2356
2357         * Scripts/run-gtk-tests:
2358         (TestRunner):
2359
2360 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
2361
2362         [EFL][DRT] "resource,request,willsend" signal needs to provide more information
2363         https://bugs.webkit.org/show_bug.cgi?id=84670
2364
2365         Reviewed by Andreas Kling.
2366
2367         Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
2368         passed with the "resource,request,willsend" signal and dump
2369         information about the network request and the possible network
2370         response if LayoutTestController's dumpResourceLoadCallbacks() returns
2371         true.
2372
2373         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2374         (pathSuitableForTestResult):
2375         (urlSuitableForTestResult):
2376         (descriptionSuitableForTestResult):
2377         (DumpRenderTreeChrome::onWillSendRequest):
2378
2379 2012-04-25  Csaba Osztrogonác  <ossy@webkit.org>
2380
2381         [Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
2382         http://trac.webkit.org/changeset/113703
2383         https://bugs.webkit.org/show_bug.cgi?id=83024
2384
2385         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2386         * Tools.pro:
2387         * qmake/mkspecs/features/features.prf:
2388         * qmake/mkspecs/features/functions.prf:
2389
2390 2012-04-25  Maciej Stachowiak  <mjs@apple.com>
2391
2392         Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
2393         https://bugs.webkit.org/show_bug.cgi?id=84931
2394
2395         Reviewed by Filip Pizlo.
2396
2397         * DumpRenderTree/mac/LayoutTestHelper.m:
2398         (installLayoutTestColorProfile): Account for the possibility of the default
2399         profile being a factory profile.
2400
2401 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2402
2403         Unreviewed, rolling out r115240.
2404         http://trac.webkit.org/changeset/115240
2405         https://bugs.webkit.org/show_bug.cgi?id=84928
2406
2407         It broke everything (Requested by Ossy_HOME on #webkit).
2408
2409         * Scripts/webkitpy/layout_tests/port/gtk.py:
2410         (GtkDriver):
2411         (GtkDriver._start):
2412         (GtkDriver._start.x_filter):
2413         (GtkDriver.stop):
2414         (GtkPort._driver_class):
2415         * Scripts/webkitpy/layout_tests/port/qt.py:
2416         (QtPort._build_driver):
2417         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
2418
2419 2012-04-25  Dirk Pranke  <dpranke@chromium.org>
2420
2421         [chromium] change DRT's "DRT" output to match the other ports
2422         https://bugs.webkit.org/show_bug.cgi?id=84904
2423
2424         Reviewed by Kent Tamura.
2425
2426         Since we run Chromium's DRT in --test-shell mode, the
2427         non-test-shell output has never been really beaten on to make
2428         sure it's right. This fixes a few issues and will be tested
2429         with upcoming NRWT changes that'll land in a separate patch.
2430         In particular we should never output framing text like "\n"
2431         or "#EOF" outside of something outside of TestEventPrinter,
2432         and we weren't handling audio output properly at all.
2433
2434         * DumpRenderTree/chromium/TestEventPrinter.cpp:
2435         (DRTPrinter):
2436         (TestShellPrinter):
2437         (DRTPrinter::handleTextFooter):
2438         (DRTPrinter::handleAudioFooter):
2439         (DRTPrinter::handleTestFooter):
2440         (TestShellPrinter::handleAudioFooter):
2441         * DumpRenderTree/chromium/TestEventPrinter.h:
2442         (TestEventPrinter):
2443         * DumpRenderTree/chromium/TestShell.cpp:
2444         (TestShell::TestShell):
2445         (TestShell::dump):
2446
2447 2012-04-25  Joshua Bell  <jsbell@chromium.org>
2448
2449         Unreviewed: Adding Alec Flett as a contributor (non-committer).
2450
2451         * Scripts/webkitpy/common/config/committers.py:
2452
2453 2012-04-25  Abhishek Arya  <inferno@chromium.org>
2454
2455         Mark myself as a reviewer.
2456         https://bugs.webkit.org/show_bug.cgi?id=84902
2457
2458         Reviewed by Dimitri Glazkov.
2459
2460         * Scripts/webkitpy/common/config/committers.py:
2461
2462 2012-04-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2463
2464         [Qt][NRWT] Run each DRT in it's own xvfb
2465         https://bugs.webkit.org/show_bug.cgi?id=77335
2466
2467         Reviewed by Dirk Pranke.
2468
2469         * Scripts/webkitpy/layout_tests/port/gtk.py:
2470         (GtkPort._driver_class):
2471         * Scripts/webkitpy/layout_tests/port/qt.py:
2472         (QtPort._driver_class):
2473         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
2474         (XvfbDriver):
2475         (XvfbDriver._start):
2476         (XvfbDriver._start.x_filter):
2477         (XvfbDriver.stop):
2478
2479 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2480
2481         Unreviewed, rolling out r115222.
2482         http://trac.webkit.org/changeset/115222
2483         https://bugs.webkit.org/show_bug.cgi?id=84874
2484
2485         Caused test regressions on the EFL build (Requested by rakuco
2486         on #webkit).
2487
2488         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2489         (LayoutTestController::addOriginAccessWhitelistEntry):
2490         (LayoutTestController::removeOriginAccessWhitelistEntry):
2491
2492 2012-04-25  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2493
2494         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
2495         https://bugs.webkit.org/show_bug.cgi?id=83880
2496
2497         Reviewed by Antonio Gomes.
2498
2499         Add missing implementation addOriginAccessWhitelistEntry and
2500         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
2501         in order to unskip tests which rely on this.
2502
2503         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2504         (LayoutTestController::addOriginAccessWhitelistEntry):
2505         (LayoutTestController::removeOriginAccessWhitelistEntry):
2506
2507 2012-04-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2508
2509         [EFL] [DRT] Reset text zoom factor before running a test
2510         https://bugs.webkit.org/show_bug.cgi?id=84861
2511
2512         Reviewed by Antonio Gomes.
2513
2514         This fix eliminates most of the current flakiness on EFL build
2515         bots, although some CSS tests will now need rebasiling.
2516
2517         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2518         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2519
2520 2012-04-25  Milian Wolff  <milian.wolff@kdab.com>
2521
2522         [Qt] add LayoutTestController::setPrinting support to Qt unit tests
2523         https://bugs.webkit.org/show_bug.cgi?id=84246
2524
2525         Reviewed by Simon Hausmann.
2526
2527         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2528         (WebCore::DumpRenderTree::dump):
2529
2530 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2531
2532         [Qt] Make the web view's url property follow the active url
2533
2534         https://bugs.webkit.org/show_bug.cgi?id=77554
2535
2536         Update  the location bar in the minibrowser to behave
2537         a bit more like normal browsers in terms of when the url will change
2538         and how active focus is handled.
2539
2540         Reviewed by Simon Hausmann.
2541
2542         * MiniBrowser/qt/qml/BrowserWindow.qml:
2543
2544 2012-04-25  Philippe Normand  <pnormand@igalia.com>
2545
2546         Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
2547         https://bugs.webkit.org/show_bug.cgi?id=81913
2548
2549         Reviewed by Tor Arne Vestbø.
2550
2551         * qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
2552         and gstreamer-plugins-base >= 0.10.30 just like the GTK port
2553         does. 0.10.27 is unfortunately not recent enough to get the media
2554         player working reliably.
2555
2556
2557 2012-04-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2558
2559         [BlackBerry] Run tests in '/http/tests/local' with local URI
2560         https://bugs.webkit.org/show_bug.cgi?id=84820
2561
2562         Reviewed by Nikolas Zimmermann.
2563
2564         Currently we run all tests under folder "/http/tests/" as HTTP
2565         tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
2566         'http/tests/local' are run with local path (like '/developer/LayoutTests
2567         /http/tests/local/absolute-url-strip-whitespace.html').
2568         With this patch we can keep the same behaviour as other portings.
2569
2570         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2571         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
2572
2573 2012-04-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2574
2575         [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
2576         https://bugs.webkit.org/show_bug.cgi?id=84709
2577
2578         Reviewed by Eric Seidel.
2579
2580         Not all the settings that can be changed by layout testcases through a JS API were 
2581         reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
2582
2583         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2584         (defaultEditingBehavior): returns editing behavior depending on current platform.
2585         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
2586
2587 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
2588
2589         nrwt: add ASAN handling to chromium crash logs
2590         https://bugs.webkit.org/show_bug.cgi?id=84664
2591
2592         Reviewed by Ojan Vafai.
2593
2594         * Scripts/webkitpy/layout_tests/port/chromium.py:
2595         (ChromiumPort._get_crash_log):
2596
2597 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
2598
2599         webkit-patch rebaseline-test is retrieving stale expectations
2600         https://bugs.webkit.org/show_bug.cgi?id=84762
2601
2602         Reviewed by Ojan Vafai.
2603
2604         webkit-patch rebaseline-expectations is fetching files directly
2605         from the layout-test-results directory on the buildbots, rather
2606         than fetching them from the archive. This is problematic because
2607         we don't clobber the directory after each run and so you can end
2608         up fetching stale failing results.
2609
2610         This change temporarily changes the code to fetch the zip file
2611         instead -- making things much slower -- until I can confer w/
2612         abarth and ojan over the best way to fix this for the long-term.
2613
2614         * Scripts/webkitpy/tool/commands/rebaseline.py:
2615         (RebaselineTest.__init__):
2616         (RebaselineTest._zip_file_set):
2617         (RebaselineTest):
2618         (RebaselineTest._fetch_baseline):
2619         (RebaselineTest._rebaseline_test):
2620         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2621         (TestRebaseline.stub_rebaseline_test_command_and_tool):
2622         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
2623         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
2624         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2625         (test_rebaseline_updates_expectations_file):
2626         (test_rebaseline_test):
2627         (test_rebaseline_and_copy_test):
2628         (test_rebaseline_and_copy_test_no_existing_result):
2629         (test_rebaseline_and_copy_test_with_lion_result):
2630         (test_rebaseline_and_copy_no_overwrite_test):
2631
2632 2012-04-24  Ojan Vafai  <ojan@chromium.org>
2633
2634         Improve code for embedding flakiness dashboard as an iframe
2635         https://bugs.webkit.org/show_bug.cgi?id=84782
2636
2637         Reviewed by Dirk Pranke.
2638
2639         -Include the horizontal scrollbar height in the measured height of the page.
2640         -Post a message everytime the height changes instead of in response to a queryContentHeight message.
2641         This way, the embedder doesn't need to poll.
2642
2643         No new tests. This is hard to test because it involves postMessage and iframes.
2644         Once we switch the dashboard tests over to qunit, we should be able to write an
2645         asyncTest for this.
2646
2647         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2648         (generatePage):
2649         (appendHTML):
2650         (appendExpectations):
2651         (postHeightChangedMessage):
2652         (generatePageForIndividualTests.if):
2653         (generatePageForIndividualTests):
2654         * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
2655
2656 2012-04-16  Ojan Vafai  <ojan@chromium.org>
2657
2658         Replace garden-o-matic accordion UI with a panel UI
2659         https://bugs.webkit.org/show_bug.cgi?id=84081
2660
2661         Reviewed by Dimitri Glazkov.
2662
2663         This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
2664         since we can reuse the same iframe without moving it in the DOM.
2665
2666         Also, excise unnecessary jquery-isms.
2667
2668         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2671
2672 2012-04-24  Peter Beverloo  <peter@chromium.org>
2673
2674         [Chromium] DumpRenderTree should depend on base.gyp:test_support_base
2675         https://bugs.webkit.org/show_bug.cgi?id=84729
2676
2677         Reviewed by Dirk Pranke.
2678
2679         This dependency is necessary for Android since it'll soon be
2680         calling InitAndroidOSPathStub() in it's platform support. The
2681         TestWebKitAPI and webkit_unit_tests already have this dependency.
2682
2683         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2684
2685 2012-04-24  Ojan Vafai  <ojan@chromium.org>
2686
2687         Replace vague informative statement with the list of builders where the test isn't listed
2688         https://bugs.webkit.org/show_bug.cgi?id=84779
2689
2690         Reviewed by Dirk Pranke.
2691
2692         This is more informative and more likely to be noticed. With the old UI, people never
2693         read the line and if they did, they didn't really understand what it meant. Hopefully
2694         have the list of builders will be more clear.
2695
2696         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2697         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
2698         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2699
2700 2012-04-24  Tommy Widenflycht  <tommyw@google.com>
2701
2702         MediaStream API: Create a new flag for PeerConnection
2703         https://bugs.webkit.org/show_bug.cgi?id=84723
2704
2705         Reviewed by Dimitri Glazkov.
2706
2707         To allow Chrome to make the GetUserMedia functionality available by default we
2708         need another flag for the PeerConnection related parts. This new flag is in
2709         addition to the general media stream flag, and both need to be enabled for
2710         PeerConnection object creation.
2711
2712         * DumpRenderTree/chromium/TestShell.cpp:
2713         (TestShell::TestShell):
2714
2715 2012-04-24  Joe Mason  <jmason@rim.com>
2716
2717         [BlackBerry] Revert broken changes to authentication dialog
2718         https://bugs.webkit.org/show_bug.cgi?id=80135
2719
2720         Reviewed by Antonio Gomes.
2721
2722         The previous patches from this bug caused an infinite loop when using digest auth;
2723         apparently they were only tested with basic.
2724
2725         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2726         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2727         (WebCore):
2728
2729 2012-04-24  Zan Dobersek  <zandobersek@gmail.com>
2730
2731         [TestResultsServer] Add a unit test for changes in r114868
2732         https://bugs.webkit.org/show_bug.cgi?id=84713
2733
2734         Reviewed by Ojan Vafai.
2735
2736         Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
2737         that is created for either DEPS or ToT builder groups. The unit test covers changes
2738         made in r114868.
2739
2740         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2741         (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
2742         (testBuilderGroupIsToTWebKitAttribute.assertEquals):
2743
2744 2012-04-24  Brady Eidson  <beidson@apple.com>
2745
2746         <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
2747          Need DOMWindow mechanism to supplement UserScripts for page cache notifications
2748
2749         Reviewed by Sam Weinig.
2750
2751         Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
2752
2753         It makes sure new extensions can be added at the right times, and that all of the expected
2754         callbacks are made.
2755
2756         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
2757         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
2758         (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
2759            bundle to a set of known expected messages.
2760
2761         Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
2762         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
2763         (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
2764         (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
2765         (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
2766         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
2767         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
2768         (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
2769         (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
2770         (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
2771         (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
2772         (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
2773         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2774         (TestWebKitAPI::didFinishLoadForFrameCallback):
2775         (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
2776         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
2777         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
2778         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
2779
2780         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2781         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
2782
2783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2784
2785 2012-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2786
2787         [GTK] Build and run TestWebKitAPI unit tests
2788         https://bugs.webkit.org/show_bug.cgi?id=84325
2789
2790         Reviewed by Philippe Normand.
2791
2792         We only build WTF unit tests for now. WebKit2 tests will be
2793         enabled in a follow up patch.
2794
2795         * Scripts/run-gtk-tests:
2796         (TestRunner): Add TestWebKitAPI/WTF to the list of directories
2797         containing unit tests.
2798         (TestRunner._run_test_glib): Run glib tests using gtester.
2799         (TestRunner._run_test_google): Run google tests.
2800         (TestRunner._run_test): Use _run_test_glib or _run_test_google
2801         depending on whether given test is glib or google test
2802         * TestWebKitAPI/GNUmakefile.am: Added.
2803         * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
2804         warning with -Wundef. Include WebKit2 headers only when building
2805         WebKit2.
2806
2807 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2808
2809         [Qt][WK2] Convert touch-point area
2810         https://bugs.webkit.org/show_bug.cgi?id=84434
2811
2812         Reviewed by Kenneth Rohde Christiansen.
2813
2814         Fix failing test after r114917 by also adding the new EventSender API
2815         to WebKitTestRunner.
2816
2817         * WebKitTestRunner/EventSenderProxy.h:
2818         (EventSenderProxy):
2819         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2820         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2821         (WTR::EventSendingController::setTouchPointRadius):
2822         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2823         (EventSendingController):
2824         * WebKitTestRunner/TestController.cpp:
2825         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2826         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2827         (WTR::EventSenderProxy::addTouchPoint):
2828         (WTR::EventSenderProxy::updateTouchPoint):
2829         (WTR::EventSenderProxy::setTouchPointRadius):
2830         (WTR::EventSenderProxy::clearTouchPoints):
2831
2832 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
2833
2834         [Chromium] Unreviewed test expectations update.
2835         https://bugs.webkit.org/show_bug.cgi?id=84726
2836
2837         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
2838
2839         * Scripts/webkitpy/test/test_finder.py:
2840         (TestFinder._default_names):
2841
2842 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
2843
2844         [EFL] Enable Web Timing
2845         https://bugs.webkit.org/show_bug.cgi?id=84705
2846
2847         Reviewed by Tony Gentilcore.
2848
2849         Enable web timing by default whenever build-webkit is used.
2850
2851         * Scripts/build-webkit:
2852
2853 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
2854
2855         Return value from executed script in Chromium.
2856         https://bugs.webkit.org/show_bug.cgi?id=79851
2857
2858         Reviewed by Adam Barth.
2859
2860         Adding a function to LayoutTestController that evaluates a script in
2861         an isolated wold an returns the result of the evaluation.
2862
2863         * DumpRenderTree/LayoutTestController.cpp:
2864         (evaluateScriptInIsolatedWorldAndReturnValue):
2865         (LayoutTestController::staticFunctions):
2866         * DumpRenderTree/LayoutTestController.h:
2867         (LayoutTestController):
2868         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2869         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2870         * DumpRenderTree/chromium/LayoutTestController.cpp:
2871         (LayoutTestController::LayoutTestController):
2872         (LayoutTestController::setXSSAuditorEnabled):
2873         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2874         * DumpRenderTree/chromium/LayoutTestController.h:
2875         (LayoutTestController):
2876         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2877         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2878         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2879         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2880         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2881         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2882         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2883         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2884         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2885         (LayoutTestController):
2886         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2887         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2888         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2889         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
2890
2891 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
2892
2893         run-perf-tests fail intermittently with an exception
2894         https://bugs.webkit.org/show_bug.cgi?id=83532
2895
2896         Reviewed by Ryosuke Niwa.
2897
2898         This bulletproofs port.get_option('child_processes')
2899         against the case where the option wasn't set.
2900
2901         * Scripts/webkitpy/layout_tests/port/mac.py:
2902         (MacPort._get_crash_log):
2903         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2904         (test_get_crash_log):
2905         (test_get_crash_log.fake_time_cb):
2906
2907 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
2908
2909         [Qt] Add desktop zooming support for QQuickWebView
2910         https://bugs.webkit.org/show_bug.cgi?id=82337
2911
2912         Unreviewed typo fix after r114900.
2913
2914         * MiniBrowser/qt/BrowserWindow.cpp:
2915         (BrowserWindow::BrowserWindow): Fix the mistyped
2916         value of a zoom level.
2917
2918 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
2919
2920         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
2921         https://bugs.webkit.org/show_bug.cgi?id=84580
2922
2923         Reviewed by Ojan Vafai.
2924
2925         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
2926         Take the opportunity to get rid of the trick.
2927
2928         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2929         (ChromiumAndroidPort.start_helper):
2930         (ChromiumAndroidPort._push_fonts):
2931
2932 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
2933
2934         test-webkitpy is failing
2935         https://bugs.webkit.org/show_bug.cgi?id=84617
2936
2937         Reviewed by Eric Seidel.
2938
2939         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2940         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
2941
2942 2012-04-23  Ojan Vafai  <ojan@chromium.org>
2943
2944         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
2945         of making the code more maintainable (e.g. being able to use qunit for testing).
2946
2947         * TestResultServer/static-dashboards/dashboard_base.js:
2948         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
2949         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2950         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
2951         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
2952         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
2953
2954 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2955
2956         [Qt][WK2] Convert touch-point area.
2957         https://bugs.webkit.org/show_bug.cgi?id=84434
2958
2959         Reviewed by Kenneth Rohde Christiansen.
2960
2961         Add feature to set touch-point radius for emitted touch-events.
2962
2963         * DumpRenderTree/qt/EventSenderQt.cpp:
2964         (EventSender::addTouchPoint):
2965         (EventSender::updateTouchPoint):
2966         (EventSender::setTouchPointRadius):
2967         (EventSender::clearTouchPoints):
2968         * DumpRenderTree/qt/EventSenderQt.h:
2969         (EventSender):
2970
2971 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
2972
2973         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
2974         https://bugs.webkit.org/show_bug.cgi?id=84425
2975
2976         Reviewed by Antonio Gomes.
2977
2978         Use the new helper in DumpRenderTreeSupportEfl to properly
2979         test whether an element performs autocompletion.
2980
2981         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2982         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2983
2984 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2985
2986         master.cfg cleanup, remove dead codes after r92792.
2987         https://bugs.webkit.org/show_bug.cgi?id=84433
2988
2989         Relanding r114881 after typo fix in UploadBuiltProduct.
2990
2991         Reviewed by Ryosuke Niwa.
2992
2993         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2994
2995 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
2996
2997         [EFL][DRT] Need to support requestAnimationFrame
2998         https://bugs.webkit.org/show_bug.cgi?id=84585
2999
3000         Reviewed by Martin Robinson.
3001
3002         Making requestAnimationFrame() support a default on the EFL build.
3003
3004         * Scripts/build-webkit:
3005
3006 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
3007
3008         [Qt] Add desktop zooming support for QQuickWebView
3009         https://bugs.webkit.org/show_bug.cgi?id=82337
3010
3011         Reviewed by Simon Hausmann.
3012
3013         Add zooming support for MiniBrowser to
3014         test the new API.
3015
3016         * MiniBrowser/qt/BrowserWindow.cpp:
3017         (BrowserWindow::BrowserWindow):
3018         (BrowserWindow::zoomIn):
3019         (BrowserWindow::zoomOut):
3020         (BrowserWindow::keyPressEvent):
3021         (BrowserWindow::wheelEvent):
3022         * MiniBrowser/qt/BrowserWindow.h:
3023         (BrowserWindow):
3024
3025 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
3026
3027         Unreviewed rolling out r114881, because it broke upload buildstep.
3028
3029         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3030         (ConfigureBuild.__init__):
3031         (ConfigureBuild.start):
3032         (CompileWebKit.start):
3033         (UploadBuiltProduct):
3034         (UploadBuiltProduct.determineExtraFeatures):
3035         (Factory.__init__):
3036         (BuildFactory.__init__):
3037         (TestFactory.__init__):
3038         (loadBuilderConfig):
3039
3040 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
3041
3042         master.cfg cleanup, remove dead codes after r92792.
3043         https://bugs.webkit.org/show_bug.cgi?id=84433
3044
3045         Reviewed by Ryosuke Niwa.
3046
3047         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3048
3049 2012-04-23  Milian Wolff  <mail@milianw.de>
3050
3051         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
3052         https://bugs.webkit.org/show_bug.cgi?id=84327
3053
3054         Reviewed by Csaba Osztrogonác.
3055
3056         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3057         (WebCore::DumpRenderTree::dump):
3058
3059 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3060
3061         [Gtk] Added MOZ_X11 build flag for TARGET_X11
3062         https://bugs.webkit.org/show_bug.cgi?id=40785
3063
3064         Reviewed by Anders Carlsson.
3065
3066         * GNUmakefile.am:
3067
3068 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
3069
3070         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
3071         https://bugs.webkit.org/show_bug.cgi?id=84544
3072
3073         Reviewed by Ryosuke Niwa.
3074
3075         Use the groupEnum parameter that is passed through to the onBuilderListLoad
3076         function rather than an undefined attribute of the BuilderGroup object. This
3077         makes it again possible to inspect builds on non-Chromium builders in the
3078         test results server by not trying to always add Chromium revision links.
3079
3080         * TestResultServer/static-dashboards/builders.js:
3081
3082 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
3083
3084         [GTK] Revert changes that disabled Cairo fonts metrics hinting
3085         https://bugs.webkit.org/show_bug.cgi?id=84502
3086
3087         Reviewed by Daniel Bates.
3088
3089         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
3090         reference and pixel test results. This makes our font metrics a bit different
3091         than the Mac port's, but it's a decent price to pay for consistent results.
3092
3093         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3094         (initializeGtkFontSettings):
3095         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3096         (WTR::initializeGtkSettings):
3097
3098 2012-04-04  Jer Noble  <jer.noble@apple.com>
3099
3100         apple.com top navigation bar appears inside video during full screen exit animation
3101         https://bugs.webkit.org/show_bug.cgi?id=83095
3102
3103         Reviewed by Eric Carlson.
3104
3105         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
3106         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
3107         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
3108         from within LayoutTests.
3109
3110         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
3111         * DumpRenderTree/LayoutTestController.cpp:
3112         (setHasCustomFullScreenBehaviorCallback):
3113         (LayoutTestController::staticFunctions):
3114         * DumpRenderTree/LayoutTestController.h:
3115         (LayoutTestController::setHasCustomFullScreenBehavior):
3116         (LayoutTestController::hasCustomFullScreenBehavior):
3117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3118         (WTR::InjectedBundlePage::enterFullScreenForElement):
3119         (WTR::InjectedBundlePage::exitFullScreenForElement):
3120         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3121         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3122         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3123         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
3124         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
3125         * DumpRenderTree/chromium/LayoutTestController.cpp:
3126         (LayoutTestController::LayoutTestController):
3127         (LayoutTestController::reset):
3128         * DumpRenderTree/chromium/LayoutTestController.h:
3129         (LayoutTestController::setHasCustomFullScreenBehavior):
3130         (LayoutTestController::hasCustomFullScreenBehavior):
3131
3132         Query the new methods before calling will/did/Enter/ExitFullScreen:
3133         * DumpRenderTree/chromium/WebViewHost.cpp:
3134         (WebViewHost::enterFullScreenNow):
3135         (WebViewHost::exitFullScreenNow):
3136         * DumpRenderTree/mac/UIDelegate.mm:
3137         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
3138         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
3139
3140 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
3141
3142         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
3143         https://bugs.webkit.org/show_bug.cgi?id=72841
3144
3145         Reviewed by Dirk Pranke
3146
3147         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
3148         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
3149         and 'reference_files' fields to the TestInput objects, and use those flags
3150         to select the right driver to use in the DriverProxy.
3151
3152         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3153         (SingleTestRunner.__init__):
3154         (SingleTestRunner._driver_input):
3155         (SingleTestRunner._run_reftest):
3156         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3157         (Worker.handle_test_list):
3158         (Worker._update_test_input):
3159         * Scripts/webkitpy/layout_tests/models/test_input.py:
3160         (TestInput):
3161         (TestInput.__init__):
3162         (TestInput.__repr__):
3163         * Scripts/webkitpy/layout_tests/port/chromium.py:
3164         (ChromiumDriver._wrapper_options):
3165         (ChromiumDriver.run_test):
3166         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3167         (ChromiumDriverTest.test_crash_log):
3168         * Scripts/webkitpy/layout_tests/port/driver.py:
3169         (DriverInput.__init__):
3170         (Driver.__init__):
3171         (DriverProxy.__init__):
3172         (DriverProxy.run_test):
3173         (DriverProxy.start):
3174         (DriverProxy.cmd_line):
3175         * Scripts/webkitpy/layout_tests/port/gtk.py:
3176         (GtkDriver._start):
3177         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3178         (MockDRT.run):
3179         (MockDRT.input_from_line):
3180         (MockDRT.output_for_test):
3181         (MockDRT.write_test_output):
3182         (MockChromiumDRT.input_from_line):
3183         (MockChromiumDRT.output_for_test):
3184         (MockChromiumDRT.write_test_output):
3185         * Scripts/webkitpy/layout_tests/port/webkit.py:
3186         (WebKitDriver.cmd_line):
3187         (WebKitDriver.run_test):
3188         * WebKitTestRunner/TestController.cpp:
3189         (WTR::TestController::TestController):
3190         (WTR::TestController::initialize):
3191         (WTR::TestController::runTest):
3192         * WebKitTestRunner/TestController.h:
3193         (TestController):
3194         * WebKitTestRunner/TestInvocation.cpp:
3195         (WTR::TestInvocation::TestInvocation):
3196         (WTR::TestInvocation::setIsPixelTest):
3197         * WebKitTestRunner/TestInvocation.h:
3198         (TestInvocation):
3199
3200 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3201
3202         [EFL] Make it possible to define offline storage quota per origin
3203         https://bugs.webkit.org/show_bug.cgi?id=84170
3204
3205         Improved LayoutTestController::setDatabaseQuota to set quota based on
3206         origin which was causing some tests to fail. Also align the default
3207         quota for testing (5MB) with others ports.
3208
3209         When dumpDatabaseCallbacks is set to true by, also dump some database
3210         information when quota is exceed, which is also required by some tests.
3211
3212         Reviewed by Antonio Gomes.
3213
3214         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3215         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3216         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3217         (onExceededDatabaseQuota):
3218         (drtViewAdd):
3219         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3220         (LayoutTestController::setDatabaseQuota):
3221
3222 2012-04-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3223
3224         [EFL] [DRT] Send double click event from EventSender
3225         https://bugs.webkit.org/show_bug.cgi?id=82867
3226
3227         Reviewed by Daniel Bates.
3228
3229         Add support for EFL DumpRenderTree EventSender to send
3230         double click events.
3231
3232         * DumpRenderTree/efl/EventSender.cpp:
3233         (sendMouseEvent):
3234
3235 2012-04-20  Sergio Villar Senin  <svillar@igalia.com>
3236
3237         [GTK] Enable Web Timing
3238         https://bugs.webkit.org/show_bug.cgi?id=42432
3239
3240         Reviewed by Gustavo Noronha Silva.
3241
3242         Build web timing by default whenever build-webkit is used.
3243
3244         * Scripts/build-webkit:
3245
3246 2012-04-20  Kamil Blank  <k.blank@samsung.com>
3247
3248         [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
3249         https://bugs.webkit.org/show_bug.cgi?id=84430
3250
3251         Reviewed by Daniel Bates.
3252
3253         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3254         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3255
3256 2012-04-20  Ryosuke Niwa  <rniwa@webkit.org>
3257
3258         REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
3259         https://bugs.webkit.org/show_bug.cgi?id=84424
3260
3261         Reviewed by Mark Rowe.
3262
3263         Let Windows and Chromium have their own list of files to copy.
3264
3265         * BuildSlaveSupport/built-product-archive:
3266         (removeDirectoryIfExists):
3267         (copyBuildFiles):
3268         (archiveBuiltProduct):
3269
3270 2012-04-20  Kamil Blank  <k.blank@samsung.com>
3271
3272         [EFL] Add setting API for author and user styles.
3273         https://bugs.webkit.org/show_bug.cgi?id=82860
3274
3275         Reviewed by Daniel Bates.
3276
3277         Implementation of setAuthorAndUserStylesEnabled.
3278
3279         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3280         (LayoutTestController::setAuthorAndUserStylesEnabled):
3281
3282 2012-04-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3283
3284         [EFL] Missing keycode translation for space key
3285         https://bugs.webkit.org/show_bug.cgi?id=84153
3286
3287         Reviewed by Antonio Gomes.
3288
3289         Set keyname for space key before dispatching event.
3290
3291         * DumpRenderTree/efl/EventSender.cpp:
3292         (keyNameFromJSValue):
3293
3294 2012-04-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3295
3296         [GTK] Allow to use WebInspector in GtkLauncher
3297         https://bugs.webkit.org/show_bug.cgi?id=84143
3298
3299         Reviewed by Martin Robinson.
3300
3301         * GNUmakefile.am: Add new files to compilation.
3302         * GtkLauncher/LauncherInspectorWindow.c: Added.
3303         (launcherInspectorWindowFinalize):
3304         (launcher_inspector_window_init):
3305         (launcher_inspector_window_class_init):
3306         (inspectedURIChanged): Update the window title based on current
3307         inspected URI.
3308         (showInspectorWindow): Show inspector window.
3309         (closeInspectorWindow): Hide inspector window.
3310         (launcherInspectorWindowNew): Create an inspector window.
3311         (launcherInspectorWindowGetWebView): Return the inspected web view.
3312         * GtkLauncher/LauncherInspectorWindow.h: Added.
3313         * GtkLauncher/main.c:
3314         (inspectorInspectWebViewCb): Create an inspector window.
3315         (createBrowser): Connect to inspect-web-view signal of the view
3316         inspector.
3317
3318 2012-04-19  Jeremy Mao  <yujie.mao@intel.com>
3319
3320         Media Stream API: Piece of code cleanup for the chromium port
3321         https://bugs.webkit.org/show_bug.cgi?id=84328
3322
3323         Reviewed by Kent Tamura.
3324
3325         WebUserMediaClientMock use an old requestUserMedia interface and
3326         Replace it with the new interface.
3327
3328         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3329         (WebKit::WebUserMediaClientMock::requestUserMedia):
3330         Remove the old requestUserMedia and replace it with the new.
3331         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3332         (WebUserMediaClientMock):
3333
3334 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
3335
3336         [EFL] DRT console messages should contain only the file name part of local URIs
3337         https://bugs.webkit.org/show_bug.cgi?id=84236
3338
3339         Reviewed by Kentaro Hara.
3340
3341         Process console messages before printing them in EFL's DumpRenderTree
3342         them so that they contain only the file name part of local URIs. This
3343         is what is expected by test cases.
3344
3345         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3346         (urlSuitableForTestResult):
3347         (onConsoleMessage):
3348
3349 2012-04-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3350
3351         [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
3352         https://bugs.webkit.org/show_bug.cgi?id=84169
3353
3354         All databases were being created inside ~/.webkit which was causing
3355         flaky tests when running multiple tests in parallel, specially timeouts
3356         due to concurrency.
3357
3358         Reviewed by Eric Seidel.
3359
3360         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3361         (DumpRenderTreeChrome::initialize):
3362
3363 2012-04-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3364
3365         [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
3366         https://bugs.webkit.org/show_bug.cgi?id=82484
3367
3368         Reviewed by Martin Robinson.
3369
3370         Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
3371
3372         * efl/jhbuild.modules:
3373         * gtk/jhbuild.modules:
3374
3375 2012-04-19  Lucas Forschler  <lforschler@apple.com>
3376
3377         Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
3378         
3379         * BuildSlaveSupport/build.webkit.org-config/config.json:
3380
3381 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
3382
3383         [EFL] dispatchDidCancelClientRedirect needs implementation
3384         https://bugs.webkit.org/show_bug.cgi?id=83669
3385
3386         Reviewed by Antonio Gomes.
3387
3388         Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
3389         and print out information that is expected by several test cases if
3390         LayoutTestController's dumpFrameLoadCallback() returns true.
3391
3392         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3393         (DumpRenderTreeChrome::createView):
3394         (DumpRenderTreeChrome::onFrameCreated):
3395         (DumpRenderTreeChrome::onFrameRedirectCancelled):
3396         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3397         (DumpRenderTreeChrome):
3398
3399 2012-04-18  Hironori Bono  <hbono@chromium.org>
3400
3401         Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
3402         https://bugs.webkit.org/show_bug.cgi?id=83748
3403
3404         Reviewed by Ryosuke Niwa.
3405
3406         This change replaces a call for SpellChecker::didCheck() with one for
3407         SpellChecker::didCheckCenceled() because didCheck() has been split into
3408         didCheckSucceeded() and didCheckCanceled().
3409
3410         * DumpRenderTree/chromium/WebViewHost.cpp:
3411         (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
3412
3413 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
3414
3415         Fix failure in test-webkitpy after r114583.
3416
3417         Unreviewed, build fix.
3418
3419         Updating the call site in r114583 w/o updating the test caused
3420         the test to fail. Somehow I forgot to run the unit tests :(.
3421
3422         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3423         (ChromiumDriverTest.test_crash_log):
3424
3425 2012-04-18  Filip Pizlo  <fpizlo@apple.com>
3426
3427         JSC testing should have complete coverage over typed array types
3428         https://bugs.webkit.org/show_bug.cgi?id=84302
3429
3430         Reviewed by Geoff Garen.
3431         
3432         Made run-fast-jsc print something and a newline if jsc threw an exception or
3433         otherwise returned with an error code, but did not crash.
3434
3435         * Scripts/run-fast-jsc:
3436
3437 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
3438
3439         Fix crash in chromium.py after r114877.
3440
3441         Unreviewed, build fix.
3442
3443         Missed updating one call site for get_crash_log() :(.
3444
3445         * Scripts/webkitpy/layout_tests/port/chromium.py:
3446         (ChromiumDriver.run_test):
3447
3448 2012-04-18  Philippe Normand  <pnormand@igalia.com>
3449
3450         [GTK] NRWT bails out if more than one X server runs on the machine
3451         https://bugs.webkit.org/show_bug.cgi?id=84276
3452
3453         Reviewed by Dirk Pranke.
3454
3455         Set up GTK driver's Xvfb display number based on Xorg servers
3456         currently running.
3457
3458         * Scripts/webkitpy/layout_tests/port/gtk.py:
3459         (GtkDriver._start):
3460         (GtkDriver._start.x_filter):
3461
3462 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
3463
3464         run-webkit-tests picked up an old crash log
3465         https://bugs.webkit.org/show_bug.cgi?id=84196
3466
3467         Reviewed by Ryosuke Niwa.
3468
3469         Modify the crash log-finding code so that we can
3470         limit our search to logs newer than X - this prevents
3471         us from finding old crash logs for a given process/pid
3472         combination even when the PIDs might've wrapped.
3473  
3474         Also fix a bug in filesystem_mock where files_under() would
3475         return paths that didn't exist.
3476
3477         * Scripts/webkitpy/common/system/crashlogs.py:
3478         (CrashLogs.find_newest_log):
3479         (CrashLogs._find_newest_log_darwin):
3480         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3481         (CrashLogsTest.test_find_log_darwin):
3482         (CrashLogsTest.test_find_log_darwin.bad_read):
3483         (CrashLogsTest):
3484         * Scripts/webkitpy/common/system/filesystem_mock.py:
3485         (MockFileSystem.files_under):
3486         * Scripts/webkitpy/layout_tests/port/base.py:
3487         (Port._get_crash_log):
3488         * Scripts/webkitpy/layout_tests/port/gtk.py:
3489         (GtkPort._get_crash_log):
3490         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3491         * Scripts/webkitpy/layout_tests/port/mac.py:
3492         (MacPort._get_crash_log):
3493         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3494         (PortTestCase.test_get_crash_log):
3495         * Scripts/webkitpy/layout_tests/port/webkit.py:
3496         (WebKitDriver.run_test):
3497
3498 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
3499
3500         nrwt: support additional test expectations files
3501         https://bugs.webkit.org/show_bug.cgi?id=84222
3502
3503         Reviewed by Ojan Vafai.
3504
3505         This patch adds an --additional-expectations flag that can be
3506         used to point to more files that will override the default set
3507         of expectations. This will allow us to remove the
3508         'google_chrome' ports and eventually help to clean up override
3509         handling in the chromium ports and unify expectations files and
3510         Skipped files; this can also be used to specify overrides for
3511         tests that run differently on a given machine.
3512
3513         * Scripts/webkitpy/layout_tests/port/base.py:
3514         (Port.test_expectations_overrides):
3515         * Scripts/webkitpy/layout_tests/port/chromium.py:
3516         (ChromiumPort.test_expectations_overrides):
3517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3518         (parse_args):
3519         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3520         (MainTest.test_additional_expectations):
3521
3522 2012-04-18  Jer Noble  <jer.noble@apple.com>
3523
3524         Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
3525         https://bugs.webkit.org/show_bug.cgi?id=84177
3526
3527         Reviewed by Dirk Pranke.
3528
3529         Try to delete the pid file left by Apache in the case it was killed forcefully.
3530
3531         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3532         (LayoutTestApacheHttpd._stop_running_server):
3533
3534 2012-04-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3535
3536         Clean-up WheelEvent Conversion.
3537         https://bugs.webkit.org/show_bug.cgi?id=84243
3538
3539         Reviewed by Simon Hausmann.
3540         
3541         Calculate proper wheel-delta from pixel-delta given.
3542
3543         * DumpRenderTree/qt/EventSenderQt.cpp:
3544         (EventSender::EventSender):
3545         (EventSender::mouseScrollBy):
3546         (EventSender::continuousMouseScrollBy):
3547
3548 2012-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3549
3550         Unreviewed, rolling out r114506.
3551         http://trac.webkit.org/changeset/114506
3552         https://bugs.webkit.org/show_bug.cgi?id=84254
3553
3554         Seems to be making gtk's DumpRenderTree crash occasionally
3555         (Requested by tomz on #webkit).
3556
3557         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3558         (resetDefaultsToConsistentValues):
3559
3560 2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3561
3562         [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
3563         https://bugs.webkit.org/show_bug.cgi?id=84229
3564
3565         CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
3566         subsequent builds, stopping WebCore from being built ever again.
3567
3568         Instead of trying to emulate a build target using command line options,
3569         just build the existing jsc target directly.
3570
3571         Reviewed by Rob Buis.
3572
3573         * Scripts/build-jsc:
3574
3575 2012-04-18  Simon Pena  <spena@igalia.com>
3576
3577         [GTK] r114021 triggered media flakyness
3578         https://bugs.webkit.org/show_bug.cgi?id=83874
3579
3580         Reviewed by Philippe Normand.
3581
3582         Now that there is gtk API to update the
3583         MediaPlaybackRequiresUserGesture property, set it to false from the
3584         DumpRenderTree tool when resetting defaults to consistent values.
3585
3586         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3587         (resetDefaultsToConsistentValues):
3588
3589 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
3590
3591         Web Inspector: Disabling Inspector causes build failure on Windows
3592         https://bugs.webkit.org/show_bug.cgi?id=83557
3593
3594         Reviewed by Pavel Feldman.
3595
3596         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
3597         This change brings all such API calls under the guard.
3598
3599         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3600         (WTR::LayoutTestController::showWebInspector):
3601         (WTR::LayoutTestController::closeWebInspector):
3602         (WTR::LayoutTestController::evaluateInWebInspector):
3603         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
3604         * WebKitTestRunner/TestInvocation.cpp:
3605         (WTR::TestInvocation::invoke):
3606
3607 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
3608
3609         [GTK] atk/textChangedNotifications API test fails
3610         https://bugs.webkit.org/show_bug.cgi?id=84010
3611
3612         Unreviewed, unskipping test after bug being fixed by r114311.
3613
3614         * Scripts/run-gtk-tests:
3615         (TestRunner): Unskip now passing test.
3616
3617 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
3618
3619         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
3620         https://bugs.webkit.org/show_bug.cgi?id=84199
3621
3622         Reviewed by George Staikos.
3623
3624         Revert a part of the change master_32/SHA:fa0f8ee9 and use
3625         WebPage::setUserScalable instead.
3626
3627         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3628         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3629
3630 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
3631
3632         build-webkit: make ninja work with chromium linux
3633         https://bugs.webkit.org/show_bug.cgi?id=84213
3634
3635         Reviewed by Eric Seidel.
3636
3637         Fix typos so that build-webkit will use ninja to
3638         build chromium if a build.ninja file exists and is up-to-date.
3639
3640         * Scripts/webkitdirs.pm:
3641         (determineIsChromiumNinja):
3642
3643 2012-04-17  Ojan Vafai  <ojan@chromium.org>
3644
3645         Add caching to the flakiness dashboard json files
3646         https://bugs.webkit.org/show_bug.cgi?id=84198
3647
3648         Reviewed by Dirk Pranke.
3649
3650         * TestResultServer/handlers/testfilehandler.py:
3651         (GetFile._get_file_list):
3652         (GetFile._get_file_content):
3653         (GetFile._get_file_content_from_key):
3654         (GetFile._get_test_list_json):
3655         (GetFile._serve_json):
3656         Add a Last-Modified header and handle If-Modified-Since headers.
3657         (GetFile.get):
3658
3659 2012-04-17  Anders Carlsson  <andersca@apple.com>
3660
3661         Need a client callback for when the user tries to interact with an already unresponsive page
3662         https://bugs.webkit.org/show_bug.cgi?id=84201
3663         <rdar://problem/11140862>
3664
3665         Reviewed by Andreas Kling.