WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
[WebKit-https.git] / Tools / ChangeLog
1 2013-08-22  Ryosuke Niwa  <rniwa@webkit.org>
2
3         WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
4
5         * Scripts/webkitpy/tool/bot/irc_command.py:
6         (Hi.execute):
7
8 2013-08-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
9
10         [Qt] DRT bug revealed/caused by r154300
11         https://bugs.webkit.org/show_bug.cgi?id=120151
12
13         Reviewed by Simon Hausmann.
14
15         Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
16         the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
17         in r154300.
18
19         DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
20         between native Qt methods and JSC bound methods. This patch changes the check to see if the 
21         property is writable since the Qt methods are ReadOnly.
22
23         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
24         (DumpRenderTree::initJSObjects):
25
26 2013-08-21  Joseph Pecoraro  <pecoraro@apple.com>
27
28         <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
29
30         Reviewed by Benjamin Poulain.
31
32         WTFString moved the is8bit bit by one in r152201.
33
34         * lldb/lldb_webkit.py:
35         (WTFStringImplProvider.is_8bit):
36
37 2013-08-21  Tim Horton  <timothy_horton@apple.com>
38
39         Revert http://trac.webkit.org/changeset/154022, as it failed to update
40         a variety of scripts that depended on the old format.
41
42         See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
43
44         * Scripts/prepare-ChangeLog:
45         (main):
46         (generateNewChangeLogs):
47
48 2013-08-21  Brent Fulgham  <bfulgham@apple.com>
49
50         [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
51
52         * WinLauncher/WinLauncher.cpp:
53         (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
54
55 2013-08-21  Zan Dobersek  <zdobersek@igalia.com>
56
57         <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
58
59         Reviewed by Andreas Kling.
60
61         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
62         (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
63         (WTR::activateFonts): Ditto.
64
65 2013-08-21  Brian Holt  <brian.holt@samsung.com>
66
67         [GTK] Suppress irrelevant or known leaks for Valgrind
68         https://bugs.webkit.org/show_bug.cgi?id=119448
69
70         Reviewed by Martin Robinson.
71
72         Add a suppressions file to suppress known leaks for Valgrind.
73         Valgrind also takes longer when using suppressions and
74         times out unless the driver timeout is increased.
75
76         * Scripts/valgrind/suppressions.txt: Added.
77         * Scripts/webkitpy/port/gtk.py:
78         (GtkPort.driver_stop_timeout):
79         (GtkPort.setup_environ_for_server):
80
81 2013-08-20  Alex Christensen  <achristensen@apple.com>
82
83         [Windows] Linking fix for Win64.
84
85         Rubberstamped by Brent Fulgham.
86
87         * win/DLLLauncher/DLLLauncherMain.cpp:
88         (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
89
90 2013-08-20  Brent Fulgham  <bfulgham@apple.com>
91
92         <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
93
94         Reviewed by Tim Horton.
95
96         * win/DLLLauncher/DLLLauncherMain.cpp:
97         (getLastErrorString): New method to convert GetLastError to text.
98         (wWinMain): Use new error formatter to provide useful diagnostic text to user.
99
100 2013-08-19  Gustavo Noronha Silva  <gns@gnome.org>
101
102         <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
103
104         Reviewed by Martin Robinson.
105
106         * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
107         from naming/enum_casing rules, since it needs to provide GObject-style APIs.
108
109 2013-08-20  Anton Obzhirov  <a.obzhirov@samsung.com>
110
111         <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
112
113         Reviewed by Martin Robinson.
114
115         Added stop button in MiniBrowser
116
117         * MiniBrowser/gtk/BrowserWindow.c:
118         (reloadOrStopCallback): Callback to handle stop or reload button click.
119         (webViewLoadProgressChanged): Update reload or stop button icon.
120         (browser_window_init): Save button pointer for further icon updates.
121
122 2013-08-20  Simon Pena  <simon.pena@samsung.com>
123
124         <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
125
126         Reviewed by Alexey Proskuryakov.
127
128         Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
129         printing didFailLoadWithError.
130
131         Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
132         DumpRenderTree, printing didFailLoadWithError.
133
134         * DumpRenderTree/gtk/DumpRenderTree.cpp:
135         (webFrameLoadStatusNotified):
136
137 2013-08-19  Ryosuke Niwa  <rniwa@webkit.org>
138
139         <https://webkit.org/b/120049> Delete code for Snow Leopard
140
141         Reviewed by Benjamin Poulain.
142
143         * DumpRenderTree/mac/CheckedMalloc.cpp:
144         (protectionOfRegion):
145         (makeLargeMallocFailSilently):
146         * DumpRenderTree/mac/DumpRenderTree.mm:
147         (resetDefaultsToConsistentValues):
148         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
149         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
150         * DumpRenderTree/mac/FrameLoadDelegate.mm:
151         (testPathFromURL):
152         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
153         * DumpRenderTree/mac/LayoutTestHelper.m:
154         * DumpRenderTree/mac/TestRunnerMac.mm:
155         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
156         (WTR::InjectedBundle::platformInitialize):
157         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
158         (WTR::testPathFromURL):
159         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
160
161 2013-08-19  Alexey Proskuryakov  <ap@apple.com>
162
163         https://bugs.webkit.org/show_bug.cgi?id=119915
164         REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
165
166         Reviewed by Darin Adler.
167
168         The issue was that we ended up having no CFNetwork cache in the testing session due
169         to an incorrect cache model. There is a number of things not implemented when it
170         comes to dynamically changing cache model as attempted by WebKitTestRunner, but
171         the easiest way to get this going is to initialize it to correct value upfront.
172
173         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
174
175 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
176
177         REGRESSION(r154275): webkitpy tests failing
178         https://bugs.webkit.org/show_bug.cgi?id=120010
179
180         Reviewed by Jocelyn Turcotte.
181
182         Update unit-tests to tests the new search-path structure,
183         but reverting the architecture search path addition.
184
185         * Scripts/webkitpy/port/qt.py:
186         (QtPort):
187         (QtPort.__init__):
188         (QtPort._generate_all_test_configurations):
189         (QtPort.qt_architecture):
190         * Scripts/webkitpy/port/qt_unittest.py:
191         (QtPortTest):
192         (QtPortTest._assert_search_path):
193         (QtPortTest._assert_expectations_files):
194         (QtPortTest._qt_version):
195
196 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
197
198         [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
199
200         Unreviewed meta gardening.
201
202         We need to keep using the qt-5.0-wk2 path until it is fully migrated.
203
204         * Scripts/webkitpy/port/qt.py:
205         (QtPort._search_paths):
206
207 2013-08-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
208
209         Restructure Qt test expectations
210
211         Unreviewed meta gardening.
212
213         Removed 5.0 name from WK1 and WK2 results and made it possible to set
214         expectations by both Qt version and mayor architectures.
215
216         * Scripts/webkitpy/port/qt.py:
217         (QtPort._wk2_port_name):
218         (QtPort.__init__):
219         (QtPort.qt_version):
220         (QtPort.architecture):
221         (QtPort._search_paths):
222         (QtPort._port_specific_expectations_files):
223
224 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
225
226         [Windows] DRT is not using the same preferences as the Mac build.
227         https://bugs.webkit.org/show_bug.cgi?id=119822
228
229         Reviewed by Darin Adler.
230
231         * DumpRenderTree/win/DumpRenderTree.cpp:
232         (runTest): Process Windows message queue using CFRunLoop to allow
233         dispatch routines to run properly.
234         (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
235         to prevent problems on WinCairo port.
236
237 2013-08-16  Brent Fulgham  <bfulgham@apple.com>
238
239         [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
240         https://bugs.webkit.org/show_bug.cgi?id=119583
241
242         Reviewed by Alexey Proskuryakov.
243
244         * DumpRenderTree/win/DumpRenderTree.cpp:
245         (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
246         component if the URL does not contain the expected base URL.
247
248 2013-08-16  Pratik Solanki  <psolanki@apple.com>
249
250         <https://webkit.org/b/119852> Frame::scriptController() should return a reference
251
252         Reviewed by Andreas Kling.
253
254         m_script is never NULL so we can just return a reference. Also remove some pointless null
255         checks as a result of doing this.
256
257         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
258         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
259
260 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
261
262         [WK2] NetworkProcess should use a temporary storage session for test
263         https://bugs.webkit.org/show_bug.cgi?id=119855
264
265         Reviewed by Darin Adler.
266
267         Use a new API that takes care of both WebProcess and NetworkProcess.
268
269         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
270         (WTR::InjectedBundle::initialize):
271         * WebKitTestRunner/TestController.cpp:
272         (WTR::TestController::initialize):
273
274 2013-08-15  Bem Jones-Bey  <bjonesbe@adobe.com>
275
276         <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
277
278         Reviewed by Dirk Pranke.
279
280         This is a port from Blink of
281         https://src.chromium.org/viewvc/blink?revision=155647&view=revision
282         originally by Dirk Pranke.
283
284         From the original commit:
285
286         This gives something like a 15x speedup over compiling and matching
287         one property at a time and doing multiple passes over the file.
288
289         * Scripts/webkitpy/w3c/test_converter.py:
290         (W3CTestConverter.__init__):
291         (W3CTestConverter.convert_prefixed_properties):
292         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
293
294 2013-08-15  Dan Bernstein  <mitz@apple.com>
295
296         <https://webkit.org/b/119856> Improve extract-localizable-strings messages
297
298         Reviewed by Darin Adler.
299
300         * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
301         added a message that points to the source code. Removed some unnecessary repetition of what
302         is already in the file.
303
304 2013-08-15  Andy Estes  <aestes@apple.com>
305
306         <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
307
308         Reviewed by Brady Eidson.
309
310         Wrote an API test that verifies -[WebView stopLoading:] can be called
311         inside webView:resource:didFinishLoadingFromDataSource: without crashing.
312
313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
314         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
315         (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
316         (TestWebKitAPI::TEST):
317
318 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
319
320         Adding Myles Maxfield to contributors.json.
321
322         Oops, wrong section, fixing.
323
324         * Scripts/webkitpy/common/config/contributors.json:
325
326 2013-08-15  Alexey Proskuryakov  <ap@apple.com>
327
328         Adding Myles Maxfield to contributors.json.
329
330         * Scripts/webkitpy/common/config/contributors.json:
331
332 2013-08-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
333
334         [Qt] Do not check specifically for version 5.0
335         https://bugs.webkit.org/show_bug.cgi?id=119846
336
337         Reviewed by Jocelyn Turcotte.
338
339         For Qt 5.x we should always use both wk1 and wk2 basepath results.
340
341         * Scripts/webkitpy/port/qt.py:
342         (QtPort._search_paths):
343
344 2013-08-15  Simon Pena  <simon.pena@samsung.com>
345
346         <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
347
348         Reviewed by Gustavo Noronha Silva.
349
350         Following a similar approach as in r153977, return a path string
351         that is relative to main frame URL or just file name if the
352         resource is not in the same directory subtree, and replace empty
353         strings with "(null)".
354
355         Update pathFromSoupURI so it behaves more closely to the other
356         ports, and remove the unused code after we no longer print
357         <unknown> in certain cases. Also move
358         soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
359         be used both in TestRunnerGtk and in DumpRenderTree.
360
361         * DumpRenderTree/gtk/DumpRenderTree.cpp:
362         (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
363         we can print Soup URIs with the password, since soup_uri_to_string
364         doesn't preserve them.
365         (pathFromSoupURI): Updated following EFL implementation in
366         r153977, and return a WTFString instead of a CString.
367         (convertSoupMessageToURLPath): Return "(null)" instead of empty
368         strings, and handle the new return type of pathFromSoupURI.
369         (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
370         reference, and handle the new return type of pathFromSoupURI.
371         (descriptionSuitableForTestResult): Remove unused code.
372         (didFinishLoading): Use convertResourceToURLPath.
373         (didFailLoadingWithError): Use convertResourceToURLPath.
374         (authenticationCallback): Display the URL of the authentication
375         challenge.
376         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
377         soupURIToStringPreservingPassword.
378         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
379         soupURIToStringPreservingPassword.
380
381 2013-08-14  Tim Horton  <timothy_horton@apple.com>
382
383         Un-inline dataLog dumpers for IntSize and IntPoint
384         https://bugs.webkit.org/show_bug.cgi?id=119697
385
386         Reviewed by Sam Weinig.
387
388         * TestWebKitAPI/GNUmakefile.am:
389
390 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
391
392         Flakiness dashboard build fix.
393
394         * TestResultServer/static-dashboards/flakiness_dashboard.js:
395         (processTestRunsForBuilder):
396
397 2013-08-14  Martin Robinson  <mrobinson@igalia.com>
398
399         [GTK] [CMake] Add support for building TestWebKitAPI
400         https://bugs.webkit.org/show_bug.cgi?id=116987
401
402         Reviewed by Philippe Normand.
403
404         * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
405         platform-specific file, so that GTK+ can override them.
406         * TestWebKitAPI/PlatformGTK.cmake: Added.
407
408 2013-08-14  Brent Fulgham  <bfulgham@apple.com>
409
410         [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
411         https://bugs.webkit.org/show_bug.cgi?id=119775
412
413         This bug updates the WinLauncher program with a few useful menu
414         options to toggle certain debugging and development features of
415         WebKit.
416
417         Reviewed by Tim Horton.
418
419         * WinLauncher/WinLauncher.cpp:
420         (dllLauncherEntryPoint): Clean up preference objects on exit.
421         (ToggleMenuItem): New function.
422         (LaunchInspector): New function.
423         (WndProc): Add handler for new menu items. Also properly terminate
424         CFRunLoop operation on program exit.
425         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
426         menu items.
427         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
428         resource folder to search path.
429         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
430         for new menu items.
431
432 2013-08-14  Ryosuke Niwa  <rniwa@webkit.org>
433
434         Add a hyperlink from build.webkit.org to the flakiness dashboard.
435
436         Rubbers-tamped by Simon Fraser.
437
438         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
439
440 2013-08-14  Benjamin Dupont   <bdupont@nds.com>
441
442         [Qt] Activate visibility API layout tests
443         https://bugs.webkit.org/show_bug.cgi?id=119790
444
445         Reviewed by Allan Sandfeld Jensen.
446
447         * DumpRenderTree/qt/TestRunnerQt.cpp:
448         (TestRunner::resetPageVisibility):
449         (TestRunner::setPageVisibility):
450
451 2013-08-13  Xabier Rodriguez Calvar  <calvaris@igalia.com>
452
453         [GTK] WK does not link properly against libxslt
454         https://bugs.webkit.org/show_bug.cgi?id=119688
455
456         Reviewed by Gustavo Noronha Silva.
457
458         * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
459         MiniBrowser.
460         * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
461
462 2013-08-13  Alexey Proskuryakov  <ap@apple.com>
463
464         [Mac] fast/dom/attr-style-too-lazy.html is flaky
465         https://bugs.webkit.org/show_bug.cgi?id=119763
466
467         Reviewed by Darin Adler.
468
469         * DumpRenderTree/mac/UIDelegate.mm:
470         (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
471         a test, it would just semi-randomly leak to the next one.
472         (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
473         for good measure.
474
475 2013-08-13  Tim Horton  <timothy_horton@apple.com>
476
477         [mac] Give MiniBrowser a reasonable bundle identifier
478         https://bugs.webkit.org/show_bug.cgi?id=119773
479
480         Rubber-stamped by Simon Fraser.
481
482         Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
483
484         * MiniBrowser/mac/Info.plist:
485         * MiniBrowser/mac/WebBundle/Info.plist:
486
487 2013-08-13  Dean Jackson  <dino@apple.com>
488
489         <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
490
491         Reviewed by Mark Rowe.
492
493         Have prepare-ChangeLog produce webkit.org/b/id style
494         URLs rather than exposing the inner workings of our
495         cgi. I was going to use the term "Future Proofing"
496         but that seems excessive :)
497
498         * Scripts/prepare-ChangeLog:
499         (main): Generate a more human readable form.
500         (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
501
502 2013-08-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
503
504         [EFL][DRT] Simplify call to reverseFind()
505         https://bugs.webkit.org/show_bug.cgi?id=119746
506
507         Reviewed by Christophe Dumez.
508
509         Follow-up to r153977.
510
511         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
512         (pathSuitableForTestResult): Instead of defining a static variable
513         that's only used in a single place, pass '/' to reverseFind() directly.
514
515 2013-08-13  Alberto Garcia  <berto@igalia.com>
516
517         [GTK] Closing inspector window crashes wk
518         https://bugs.webkit.org/show_bug.cgi?id=110865
519
520         Reviewed by Carlos Garcia Campos.
521
522         Disconnect all signal handlers if the inspector window is
523         destroyed.
524
525         * GtkLauncher/LauncherInspectorWindow.c:
526         (inspectorWindowDestroyed):
527         (launcherInspectorWindowNew):
528
529 2013-08-12  Dan Bernstein  <mitz@apple.com>
530
531         extract-localizable-strings output is not suited for parsing by Xcode
532         https://bugs.webkit.org/show_bug.cgi?id=119728
533
534         Reviewed by Darin Adler.
535
536         Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
537         removed “ERROR” since messages that refer to a line in a file are shown as error by default,
538         added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
539         with 0).
540
541         * Scripts/extract-localizable-strings:
542
543 2013-08-12  Ryuan Choi  <ryuan.choi@samsung.com>
544
545         [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
546         https://bugs.webkit.org/show_bug.cgi?id=119585
547
548         Reviewed by Gyuyoung Kim.
549
550         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
551         (pathSuitableForTestResult):
552         Return path string that's relative to main frame URL, or just file name if
553         the resource is not in the same directory subtree.
554         Referenced WebKitTestRunner code in r153852.
555         (descriptionSuitableForTestResult):
556         (DumpRenderTreeChrome::onFrameRedirectRequested):
557         (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
558
559 2013-08-12  Dan Bernstein  <mitz@apple.com>
560
561         extract-localizable-strings doesn't know how to verify an existing strings file
562         https://bugs.webkit.org/show_bug.cgi?id=119704
563
564         Reviewed by Darin Adler.
565
566         * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
567         exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
568         exceptions file name to omitting the --exceptions option. Added a --skip option, changing
569         the way directories to skip are specified from prefixing the directory with a “-” to
570         specifying it with --skip.
571         Finally, added a --verify option. When specified, the strings file is not written to, but
572         instead read in and checked for consistency with the comments, keys and values derived from
573         the source files and the exceptions file. Missing keys, unused keys, mismatching values and
574         mismatching comments are reported as errors.
575         * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
576         directories to skip and no exceptions file.
577
578 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
579
580         http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
581         https://bugs.webkit.org/show_bug.cgi?id=85522
582
583         Reviewed by Andy Estes.
584
585         * DumpRenderTree/mac/UIDelegate.mm:
586         (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
587         when already done with a test. We already had this check in all UI delegate functions,
588         except for -webView:addMessageToConsole:withSource: somehow.
589
590 2013-08-12  Alexey Proskuryakov  <ap@apple.com>
591
592         https://bugs.webkit.org/show_bug.cgi?id=119693
593         [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
594         because of connect-src-websocket-allowed.html
595
596         Reviewed by Darin Adler.
597
598         Starting a load of about:blank and immediately stopping it cancels outstanding
599         resource loads, but the page has to transition to committed state to have timers
600         or WebSockets stopped too.
601
602         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
603         ensure that transition to committed state happens before we start the next test.
604
605 2013-08-12  Beth Dakin  <bdakin@apple.com>
606
607         The LayoutMilestones didLayout callback should only fire for the main frame
608         https://bugs.webkit.org/show_bug.cgi?id=119457
609
610         Reviewed by Sam Weinig.
611
612         Now that the didLayout callback only fires for the main frame, we want to make 
613         sure it will fire even when all of the content is in a subframe.
614
615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
616         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
617         (TestWebKitAPI::didLayout):
618         (TestWebKitAPI::TEST):
619         * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
620
621 2013-08-12  Beth Dakin  <bdakin@apple.com>
622
623         Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
624         https://bugs.webkit.org/show_bug.cgi?id=119658
625
626         Reviewed by Darin Adler.
627
628         * MiniBrowser/mac/WK2BrowserWindowController.m:
629         (-[WK2BrowserWindowController awakeFromNib]):
630         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
631         (WTR::InjectedBundlePage::InjectedBundlePage):
632         * WebKitTestRunner/TestController.cpp:
633         (WTR::TestController::createWebViewWithOptions):
634
635 2013-08-12  Seokju Kwon  <seokju@webkit.org>
636
637         Remove glu's libtest rule from checker.py
638         https://bugs.webkit.org/show_bug.cgi?id=119674
639
640         Reviewed by Darin Adler.
641
642         * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
643
644 2013-08-11  ChangSeok Oh  <changseok.oh@collabora.com>
645
646         Unreviewed. Change my primary mail address.
647
648         * Scripts/webkitpy/common/config/contributors.json:
649
650 2013-08-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
651
652         [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
653         https://bugs.webkit.org/show_bug.cgi?id=115751
654
655         Reviewed by Martin Robinson.
656
657         * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
658         with yum.
659
660 2013-08-09  Beth Dakin  <bdakin@apple.com>
661
662         AX: Not able to use arrow keys to read text in a WK2 app
663         https://bugs.webkit.org/show_bug.cgi?id=119605
664         -and corresponding-
665         <rdar://problem/14281275>
666
667         Reviewed by Darin Adler.
668
669         New test verifies that didNotHandleKeyEvent will be called when there is nothing 
670         to scroll. 
671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
672         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
673         (TestWebKitAPI::didFinishLoadForFrame):
674         (TestWebKitAPI::didNotHandleKeyEventCallback):
675         (TestWebKitAPI::TEST):
676
677 2013-08-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
678
679         Add support for KeyboardEvent.location attribute
680         https://bugs.webkit.org/show_bug.cgi?id=119326
681
682         Reviewed by Benjamin Poulain.
683
684         Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
685
686         * DumpRenderTree/mac/EventSendingController.mm:
687         (-[EventSendingController keyDown:withModifiers:withLocation:]):
688         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
689         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
690         (-[EventSendingController handleEvent:]):
691         (-[EventSendingController fireKeyboardEventsToElement:]):
692
693 2013-08-09  Alexey Proskuryakov  <ap@apple.com>
694
695         <unknown> is often dumped instead of path in test output
696         https://bugs.webkit.org/show_bug.cgi?id=119590
697
698         Reviewed by Anders Carlsson.
699
700         There were two reasons for <unknown>:
701         1. When delegate logging is enabled via a testRunner call, that obviously happens
702         after main resource load starts, so we don't record its URL.
703         2. Authentication delegate logging relied on URL recording, but it's only turned on
704         when enabling resource loading delegate logging, not auth one.
705
706         URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
707         landed without posted rationale and unreviewed. Just undoing that change now.
708
709         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
710         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
711         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
712         (WTR::InjectedBundlePage::didInitiateLoadForResource):
713
714 2013-08-08  Alex Christensen  <achristensen@apple.com>
715
716         Windows build fixes.
717
718         Rubberstamped by Brent Fulgham.
719
720         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
721         Removed /SAFESEH link option which doesn't work with x64.
722
723 2013-08-08  Daniel Bates  <dabates@apple.com>
724
725         Add iOS support to run-javascriptcore-tests
726         https://bugs.webkit.org/show_bug.cgi?id=119602
727
728         Reviewed by Joseph Pecoraro.
729
730         Make run-javascriptcore-tests work for iOS WebKit.
731
732         * Scripts/run-javascriptcore-tests:
733
734 2013-08-08  Alexey Proskuryakov  <ap@apple.com>
735
736         [WK2] loader/go-back-cached-main-resource.html fails
737         https://bugs.webkit.org/show_bug.cgi?id=116491
738
739         Reviewed by Tim Horton.
740
741         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
742         * DumpRenderTree/gtk/DumpRenderTree.cpp:
743         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
744         * DumpRenderTree/win/DumpRenderTree.cpp:
745         Added FIXMEs about making path printing normalization more compatible.
746
747         * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
748         Return last path component in cases where we used to return a full path, which is
749         never desirable. Added a null check to basePath to prevent potentially getting
750         an Objective C exception.
751
752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
753         (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
754         for a currently loading one (which is different for tests that use multiple windows).
755         Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
756         last path component as last fallback.
757         (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
758         frame URL here, and it was potentially a wrong frame.
759         (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
760         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
761         (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
762         (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
763         (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
764
765 2013-08-08  Alex Christensen  <achristensen@apple.com>
766
767         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
768         https://bugs.webkit.org/show_bug.cgi?id=116125
769
770         Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
771
772         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
773         (WTR::pathSuitableForTestResult):
774         Changed string operations to match _drt_descriptionSuitableForTestResult.
775         (WTR::dumpRequestDescriptionSuitableForTestResult):
776         (WTR::dumpResponseDescriptionSuitableForTestResult):
777         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
778         (WTR::InjectedBundlePage::didInitiateLoadForResource):
779         (WTR::InjectedBundlePage::willSendRequestForFrame):
780         (WTR::InjectedBundlePage::didReceiveResponseForResource):
781         Pass the main frame's URL to pathSuitableForTestResult.
782         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
783         Added WKBundlePageRef to willPerformClientRedirectForFrame.
784
785 2013-08-07  Simon Fraser  <simon.fraser@apple.com>
786
787         Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
788         https://bugs.webkit.org/show_bug.cgi?id=119317
789
790         Reviewed by Tim Horton.
791         
792         The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
793         the test to complete, which is not power friendly. Although DRT instances
794         are generally busy anyway, not sitting in a busy loop should free up some CPU
795         cycles for other instances of DRT.
796         
797         Editing tests continue to pass. All Java tests are skipped and were not
798         tested, but when run fail similarly with and without the patch.
799
800         * DumpRenderTree/mac/DumpRenderTree.mm:
801         (dump):
802         (runTest):
803
804 2013-08-07  Daniel Bates  <dabates@apple.com>
805
806         Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
807         <https://bugs.webkit.org/show_bug.cgi?id=119558>
808
809         Reviewed by Martin Robinson.
810
811         Currently we build the command line to execute jsDriver.pl twice so as to both
812         print it to standard output and actually execute it. We should only build up
813         this command line once. Moreover, we should print to standard output the actual
814         command line that we are going to use including the GTK- and EFL-specific call
815         to /Tools/jhbuild/jhbuild-wrapper.
816
817         * Scripts/run-javascriptcore-tests:
818
819 2013-08-07  Mario Sanchez Prada  <mario.prada@samsung.com>
820
821         [EFL] REGRESSION after r153432: some accessibility tests crash.
822         https://bugs.webkit.org/show_bug.cgi?id=119333
823
824         Reviewed by Darin Adler.
825
826         Use a RefPtr to store a reference to the parent element of
827         an AccessibilityUIElement instead of the raw pointer, so we
828         never derefence a function from an invalid pointer.
829
830         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
831         (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
832
833 2013-08-07  Cosmin Truta  <ctruta@blackberry.com>
834
835         Unreviewed. Add myself as a committer.
836
837         * Scripts/webkitpy/common/config/contributors.json:
838
839 2013-08-04  Sam Weinig  <sam@webkit.org>
840
841         Remove support for HTML5 MicroData
842         https://bugs.webkit.org/show_bug.cgi?id=119480
843
844         Reviewed by Anders Carlsson.
845
846         * Scripts/webkitperl/FeatureList.pm:
847         * qmake/mkspecs/features/features.pri:
848
849 2013-07-23  David Farler  <dfarler@apple.com>
850
851         Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
852         https://bugs.webkit.org/show_bug.cgi?id=117762
853
854         Reviewed by Mark Rowe.
855
856         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
857         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
858         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
859         Add ASAN_OTHER_LDFLAGS.
860         * MiniBrowser/Configurations/DebugRelease.xcconfig:
861         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
862         * Scripts/check-for-weak-vtables-and-externals:
863         Ignore ___asan externals, these are populated by compiler-rt.
864         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
865         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
866         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
867         Add ASAN_OTHER_LDFLAGS.
868         * WebKitLauncher/Configurations/Base.xcconfig:
869         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
870         * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
871         Add ASAN_OTHER_LDFLAGS.
872         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
873         Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
874         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
875         Add ASAN_OTHER_LDFLAGS.
876         * asan/asan.xcconfig: Added.
877         * asan/webkit-asan-ignore.txt: Added.
878
879 2013-08-05  Brian Holt  <brian.holt@samsung.com>
880
881         [GTK] Implement leak checking with valgrind
882         https://bugs.webkit.org/show_bug.cgi?id=118785
883
884         Reviewed by Dirk Pranke.
885
886         Launch the DRT under Valgrind to generate xml files with details
887         of leaks found.
888
889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
890         (parse_args):
891         * Scripts/webkitpy/port/gtk.py:
892         (GtkPort.__init__):
893         (GtkPort.default_timeout_ms): Allow extra time to run under
894         Valgrind.
895         (GtkPort.setup_environ_for_server): Pass Valgrind instructions
896         using environment variables.
897
898 2013-08-02  Mario Sanchez Prada  <mario.prada@samsung.com>
899
900         [EFL] REGRESSION after r153432: some accessibility tests crash.
901         https://bugs.webkit.org/show_bug.cgi?id=119333
902
903         Reviewed by Gustavo Noronha Silva.
904
905         Add missing null-check to avoid dereferencing a non-existent parent.
906
907         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
908         (WTR::attributesOfElement): Ditto.
909
910 2013-08-02  Patrick Gansterer  <paroga@webkit.org>
911
912         Add --rmdir option to git svn dcommit
913         https://bugs.webkit.org/show_bug.cgi?id=119398
914
915         Reviewed by Ryosuke Niwa.
916
917         Add this option tells git-svn to remove empty directories
918         from the svn tree so they do not leave over there.
919
920         * Scripts/webkitpy/common/checkout/scm/git.py:
921         (Git.push_local_commits_to_server):
922
923 2013-08-01  Brent Fulgham  <bfulgham@apple.com>
924
925         [Windows] WebKit1 Fullscreen Video Play is Broken
926         https://bugs.webkit.org/show_bug.cgi?id=119415
927
928         Reviewed by Jer Noble.
929
930         * WinLauncher/WinLauncher.cpp:
931         (dllLauncherEntryPoint): Activate full screen mode via
932         IWebPreferencesInternal interface.
933
934 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
935
936         Unreviewed. Add an alternative address to show my affiliation in team.html.
937
938         * Scripts/webkitpy/common/config/contributors.json:
939
940 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
941
942         Duplicate property names can cause test to fail
943         https://bugs.webkit.org/show_bug.cgi?id=119399
944
945         Reviewed by Dirk Pranke.
946
947         This problem was noticed when porting the patch for
948         http://wkb.ug/119357 to Blink: a test would fail because the converted
949         and test property lists weren't the same length, but they contained
950         all of the same property names. It looks like this is actually caused
951         by a bug in converting the HTML, which is being currently rewritten.
952         In the meantime, as long as this compares the number of unique
953         properties, it makes the test more robust.
954
955         * Scripts/webkitpy/w3c/test_converter_unittest.py:
956         (verify_prefixed_properties):
957
958 2013-08-01  Bem Jones-Bey  <bjonesbe@adobe.com>
959
960         Unreviewed. Adding my expertise.
961
962         * Scripts/webkitpy/common/config/contributors.json:
963
964 2013-08-01  ChangSeok Oh  <changseok.oh@collabora.com>
965
966         Unreviewed. Add myself as a committer. Yoo-hoo! \o/
967
968         * Scripts/webkitpy/common/config/contributors.json:
969
970 2013-08-01  Commit Queue  <commit-queue@webkit.org>
971
972         Unreviewed, rolling out r153518.
973         http://trac.webkit.org/changeset/153518
974         https://bugs.webkit.org/show_bug.cgi?id=119386
975
976         The Jhbuild dep bump of GTK+ is not actually required by
977         layout testing, is causing pango dep problems (Requested by
978         zdobersek on #webkit).
979
980         * gtk/jhbuild.modules:
981
982 2013-08-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
983
984         Unreviewed. Add myself as a committer.
985
986         * Scripts/webkitpy/common/config/contributors.json:
987
988 2013-08-01  Jaehun Lim  <ljaehun.lim@samsung.com>
989
990         Unreviewed. Add myself as a committer.
991
992         * Scripts/webkitpy/common/config/contributors.json:
993
994 2013-07-31  Jinwoo Song  <jinwoo7.song@samsung.com>
995
996         Unreviewed. Add myself as a committer.
997
998         * Scripts/webkitpy/common/config/contributors.json:
999
1000 2013-08-01  Alberto Garcia  <berto@igalia.com>
1001
1002         Unreviewed. Add myself as a committer.
1003
1004         * Scripts/webkitpy/common/config/contributors.json:
1005
1006 2013-07-31  Seokju Kwon  <seokju@webkit.org>
1007
1008         Unreviewed. Add myself as a committer.
1009
1010         * Scripts/webkitpy/common/config/contributors.json:
1011
1012 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1013
1014         W3C test import script prefixes some properties that it shouldn't
1015         https://bugs.webkit.org/show_bug.cgi?id=119357
1016
1017         Reviewed by Dirk Pranke.
1018
1019         Some prefixed properties also have unprefixed implemetations, but when
1020         the implementations aren't identical, they aren't declared in
1021         CSSPropertyNames.in on the same line. This fixes the import script so
1022         that it catches all instances of prefixed properties that have an
1023         unprefixed variant, and does not add the prefix in those cases.
1024
1025         * Scripts/webkitpy/w3c/test_converter.py:
1026         (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1027         the properties on every line and record if they are prefixed or not.
1028         Use this information to only return prefixed properties that do not
1029         have any unprefixed variant. The prefixed property list has also
1030         changed to not include the '-webkit-' prefix, making it much easier to
1031         do the comparison, and removing the need to remove the prefix later.
1032         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1033         longer needs to remove the '-webkit-' prefix, but needs to add it in
1034         the case where a property that needs a prefix is found.
1035         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1036         (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1037         for '-webkit-' prefix, as it is no longer included in the properties
1038         in the prefixed property list.
1039
1040 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1041
1042         Update location of w3c shapes tests to reflect new import location
1043         https://bugs.webkit.org/show_bug.cgi?id=118156
1044
1045         Reviewed by Dirk Pranke.
1046
1047         Partial imports should not be imported to the same place as the full
1048         import, so this adds an option to allow importing to a different
1049         location than the default. In doing that, I found that imports from
1050         contributor directories didn't seem to be working correctly, so I
1051         updated the import to be smarter about both contributor directories
1052         and the test status directories. It should now be more likely that the
1053         script guesses the root directory properly.
1054
1055         * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1056             script not working with the full set of contributors, as that is
1057             no longer true, and I didn't see a good way to keep that behavior.
1058             Also update documentation to properly explain what happens when a
1059             contributor dir is imported.
1060         (main): Attempt to find the proper repo dir by looking at the
1061             directory above the "test status" in the given path, this is still
1062             not exactly right, but is less error prone than just trimming.
1063         (parse_args): Add -d option to set the import directory.
1064         (TestImporter.__init__): Stop appending the subdirs to the
1065             destination_directory because it was making things more complex
1066             and isn't really needed.
1067         (TestImporter.update_test_status): Remove hardcoded strings and use
1068             the TEST_STATUS constants instead.
1069         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1070         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1071             support for new option.
1072         (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1073
1074 2013-07-31  Brent Fulgham  <bfulgham@apple.com>
1075
1076         [Windows] Winlauncher shouldn't look for Safari Install Directory
1077         https://bugs.webkit.org/show_bug.cgi?id=119351
1078
1079         Reviewed by Darin Adler.
1080
1081         * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1082         the Safari install location. Instead, use the proper support
1083         library path for the build architecture.
1084
1085 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1086
1087         Update scripts to reference contributors.json instead of committers.py in messaging
1088         https://bugs.webkit.org/show_bug.cgi?id=119342
1089
1090         Reviewed by Ryosuke Niwa.
1091
1092         Change the scripts to point people to contributors.json instead of
1093         committers.py since the latter no longer contains the list of
1094         contributors.
1095
1096         * Scripts/webkitpy/common/config/committervalidator.py:
1097         (CommitterValidator._contributors_json_path):
1098         (CommitterValidator._flag_permission_rejection_message):
1099         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1100         (CommitterValidatorTest.test_flag_permission_rejection_message):
1101         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1102         (Bugzilla._commit_queue_flag):
1103         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1104         (WatchListParser._validate):
1105         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1106         (WatchListParserTest.test_cc_rule_with_invalid_email):
1107         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1108         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1109         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1110         (ValidateReviewer.run):
1111
1112 2013-07-31  Roger Fong  <roger_fong@apple.com>
1113
1114         Unreviewed. Re-enable WinEWS tests following r153527.
1115
1116         * Scripts/webkitpy/common/config/ews.json:
1117
1118 2013-07-31  Bem Jones-Bey  <bjonesbe@adobe.com>
1119
1120         Unreviewed: Adding myself to the committers' list.
1121
1122         * Scripts/webkitpy/common/config/contributors.json:
1123
1124 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1125
1126         [Qt] Build WebKit with C++11
1127         https://bugs.webkit.org/show_bug.cgi?id=119337
1128
1129         Reviewed by Csaba Osztrogonác.
1130
1131         Enable building with C++11.
1132
1133         * qmake/mkspecs/features/default_pre.prf:
1134         * qmake/mkspecs/features/unix/default_post.prf:
1135         * qmake/mkspecs/features/unix/default_pre.prf:
1136
1137 2013-07-31  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1138
1139         [Qt] ASSERTS trigger in release builds
1140         https://bugs.webkit.org/show_bug.cgi?id=119336
1141
1142         Reviewed by Jocelyn Turcotte.
1143
1144         Ensure the qmake also defaults to release if no configuration is known.
1145
1146         * qmake/mkspecs/features/default_post.prf:
1147
1148 2013-07-31  Zan Dobersek  <zdobersek@igalia.com>
1149
1150         [texmap][GStreamer][GTK] composited video shows tearing
1151         https://bugs.webkit.org/show_bug.cgi?id=118253
1152
1153         Reviewed by Martin Robinson.
1154
1155         * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1156         The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1157         screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1158
1159 2013-07-30  Ruth Fong  <ruth_fong@apple.com>
1160
1161         Unreviewed: Adding myself to the committers' list.
1162
1163         * Scripts/webkitpy/common/config/contributors.json:
1164
1165 2013-07-30  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1166
1167         Unreviewed, add my new email to contributors.json.
1168
1169         * Scripts/webkitpy/common/config/contributors.json:
1170
1171 2013-07-30  Krzysztof Czech  <k.czech@samsung.com>
1172
1173         [EFL] REGRESSION after r153439: layout tests do not run.
1174         https://bugs.webkit.org/show_bug.cgi?id=119240
1175
1176         Reviewed by Christophe Dumez.
1177
1178         Changed attribute name from check_xvfb to check_driver.
1179
1180         * Scripts/webkitpy/port/efl.py:
1181         (EflPort.check_sys_deps):
1182
1183 2013-07-29  Commit Queue  <commit-queue@webkit.org>
1184
1185         Unreviewed, rolling out r152860.
1186         http://trac.webkit.org/changeset/152860
1187         https://bugs.webkit.org/show_bug.cgi?id=119227
1188
1189         Disable WinEWS tests until tests stop crashing (Requested by
1190         rfong on #webkit).
1191
1192         * Scripts/webkitpy/common/config/ews.json:
1193
1194 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1195
1196         [GTK] Add WestonDriver, use it when appropriate
1197         https://bugs.webkit.org/show_bug.cgi?id=119100
1198
1199         Reviewed by Dirk Pranke.
1200
1201         Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1202         and sets up an environment that enables the test runner to run inside it.
1203
1204         The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1205         environment variable is set, that is when NRWT is being run under a Wayland display.
1206
1207         * Scripts/webkitpy/port/base.py:
1208         (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1209         * Scripts/webkitpy/port/gtk.py:
1210         (GtkPort):
1211         (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1212         should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1213         (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1214         instead of hard-coding the XvfbDriver class in the check.
1215         * Scripts/webkitpy/port/westondriver.py: Added.
1216         (WestonDriver):
1217         (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1218         (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1219         (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1220         driver and then launches the driver in said environment, using the driver's Weston display.
1221         (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1222         (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1223         and returns the absolute path to it.
1224         * Scripts/webkitpy/port/xvfbdriver.py:
1225         (XvfbDriver.check_driver): Renamed from check_xvfb.
1226         (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1227
1228 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1229
1230         [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1231         https://bugs.webkit.org/show_bug.cgi?id=118967
1232
1233         Reviewed by Gustavo Noronha Silva.
1234
1235         Implemented AccessibilityUIElement::attributesOfChildren() both
1236         in DumpRenderTree and the WebKitTestRunner.
1237
1238         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1239         (AccessibilityUIElement::attributesOfChildren): Implemented.
1240
1241         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1242         (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1243
1244 2013-07-29  Mario Sanchez Prada  <mario.prada@samsung.com>
1245
1246         [ATK] Implement allAttributes() for AccessibilityUIElement
1247         https://bugs.webkit.org/show_bug.cgi?id=118966
1248
1249         Reviewed by Gustavo Noronha Silva.
1250
1251         Implemented AccessibilityUIElement::allAttributes() both in
1252         DumpRenderTree and the WebKitTestRunner.
1253
1254         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1255         (getAtkAttributeSetAsString): Moved up in the file, and refactored
1256         to use StringBuilder and return a String instead of a gchar*.
1257         (roleToString): Changed not to return the "AXRole: " prefix, so
1258         we can use it as well from attributesOfElement().
1259         (attributesOfElement): New function to dump attributes for an object.
1260         (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1261         (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1262
1263         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1264         (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1265         a String instead of a gchar*.
1266
1267         (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1268         so we can use it as well from attributesOfElement().
1269         (WTF::attributesOfElement): New function to dump attributes for an object.
1270         (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1271         (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1272
1273 2013-07-29  Daniel Bates  <dabates@apple.com>
1274
1275         Add support infrastructure for iOS WebKit port
1276         https://bugs.webkit.org/show_bug.cgi?id=119168
1277
1278         Reviewed by Ryosuke Niwa.
1279
1280         Implement support infrastructure towards building iOS WebKit.
1281
1282         * Scripts/webkitdirs.pm:
1283         (xcodeSDKPlatformName): Added.
1284         (determineConfigurationProductDir):
1285         (builtDylibPathForName):
1286         (willUseIOSDeviceSDKWhenBuilding): Added.
1287         (willUseIOSSimulatorSDKWhenBuilding): Added.
1288         (isIOSWebKit): Added.
1289         (copyInspectorFrontendFiles):
1290
1291 2013-07-29  Sergio Correia  <sergio.correia@openbossa.org>
1292
1293         CoordinatedGraphics: Add API to get and set the active state of a WebView
1294         https://bugs.webkit.org/show_bug.cgi?id=119067
1295
1296         Reviewed by Noam Rosenthal.
1297
1298         Added API tests for WKViewIsActive and WKViewSetIsActive.
1299
1300         * TestWebKitAPI/PlatformEfl.cmake:
1301         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1302         (TestWebKitAPI::didFinishLoadForFrame):
1303         (TestWebKitAPI::webProcessCrashed):
1304         (TestWebKitAPI::webProcessRelaunched):
1305         (TestWebKitAPI::TEST):
1306         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1307         Bundle added to allow crashing the WebProcess and testing the active state of a view
1308         under such condition.
1309         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1310         (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1311
1312 2013-07-29  Zan Dobersek  <zdobersek@igalia.com>
1313
1314         [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1315         https://bugs.webkit.org/show_bug.cgi?id=119212
1316
1317         Reviewed by Carlos Garcia Campos.
1318
1319         * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1320         variables that are not defined during the configuration process.
1321         * TestWebKitAPI/GNUmakefile.am: Ditto.
1322         * WebKitTestRunner/GNUmakefile.am: Ditto.
1323
1324 2013-07-28  Andy Estes  <aestes@apple.com>
1325
1326         Include <stdio.h> to declare perror()
1327         https://bugs.webkit.org/show_bug.cgi?id=119198
1328
1329         Reviewed by Andreas Kling.
1330
1331         Silences an implicit declaration warning.
1332
1333         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1334
1335 2013-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
1336
1337         [EFL] Bump required version of EFL to 1.7
1338         https://bugs.webkit.org/show_bug.cgi?id=119144
1339
1340         Reviewed by Christophe Dumez.
1341
1342         * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1343
1344 2013-07-26  Filip Pizlo  <fpizlo@apple.com>
1345
1346         WKTR should know about the JSC extensions to testRunner
1347         https://bugs.webkit.org/show_bug.cgi?id=119154
1348
1349         Reviewed by Mark Hahnenberg and Geoffrey Garen.
1350         
1351         This makes some fast/js tests pass.
1352
1353         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1354         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1355         (WTR::TestRunner::numberOfDFGCompiles):
1356         (WTR::TestRunner::neverInlineFunction):
1357         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1358
1359 2013-07-25  Mark Rowe  <mrowe@apple.com>
1360
1361         Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1362
1363         * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1364         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1365         so they pull the version out of the SDK.
1366
1367 2013-07-25  Anders Carlsson  <andersca@apple.com>
1368
1369         Localizable.strings generated by extract-localizable-strings should be UTF-8
1370         https://bugs.webkit.org/show_bug.cgi?id=119106
1371
1372         Reviewed by Mark Rowe.
1373
1374         Output strings as UTF-8.
1375
1376         * Scripts/extract-localizable-strings:
1377
1378 2013-07-25  Sam Weinig  <sam@webkit.org>
1379
1380         -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1381         https://bugs.webkit.org/show_bug.cgi?id=119099
1382         <rdar://problem/13439291>
1383
1384         Reviewed by Enrica Casucci.
1385
1386         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1387         * TestWebKitAPI/Tests/mac/AttributedString.mm:
1388         (TestWebKitAPI::attributedString):
1389         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1390         (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1391         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1392         (TestWebKitAPI::TEST_F):
1393         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1394         (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1395         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1396         * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1397         Add tests for attributed strings with strikethrough.  Refactor the attributed string tests
1398         to make adding more easier in the future.
1399
1400 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1401
1402         fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1403         https://bugs.webkit.org/show_bug.cgi?id=118948
1404
1405         Reviewed by Sam Weinig.
1406         
1407         - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1408           by exporting it as a function.
1409         
1410         - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1411           it even if you know that you've already done so. See processIRDump.sh.
1412         
1413         - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1414           runs it through ReducedFTL automatically. You typically want to say something like:
1415           
1416           jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1417           ./processIRDump.sh --timing < jsc-output.txt
1418
1419         * ReducedFTL/ReducedFTL.c:
1420         (webkit_osr_exit):
1421         * ReducedFTL/combineModules.rb:
1422         * ReducedFTL/processIRDump.sh: Added.
1423
1424 2013-07-20  Filip Pizlo  <fpizlo@apple.com>
1425
1426         fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1427         https://bugs.webkit.org/show_bug.cgi?id=118947
1428
1429         Reviewed by Dan Bernstein.
1430
1431         * Scripts/copy-webkitlibraries-to-product-directory:
1432
1433 2013-07-16  Filip Pizlo  <fpizlo@apple.com>
1434
1435         fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1436         https://bugs.webkit.org/show_bug.cgi?id=118647
1437
1438         Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1439
1440         Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1441         way that the FTL would.
1442         
1443         Also add a tool that combines multiple LLVM modules generated by FTL into a
1444         single module.
1445
1446         * ReducedFTL: Added.
1447         * ReducedFTL/ReducedFTL.c: Added.
1448         (usage):
1449         (currentTime):
1450         (MemorySection):
1451         (mmAllocateCodeSection):
1452         (mmAllocateDataSection):
1453         (mmApplyPermissions):
1454         (mmDestroy):
1455         (symbolLookupCallback):
1456         (main):
1457         * ReducedFTL/build.sh: Added.
1458         * ReducedFTL/combineModules.rb: Added.
1459
1460 2013-06-09  Filip Pizlo  <fpizlo@apple.com>
1461
1462         Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1463         for the "/" that is printed between engine counts.
1464
1465         * Scripts/display-profiler-output:
1466
1467 2013-05-28  Filip Pizlo  <fpizlo@apple.com>
1468
1469         testRunner should have a way of disabling inlining of functions
1470         https://bugs.webkit.org/show_bug.cgi?id=116875
1471
1472         Reviewed by Mark Hahnenberg.
1473
1474         * DumpRenderTree/TestRunner.cpp:
1475         (neverInlineFunction):
1476         (TestRunner::staticFunctions):
1477
1478 2013-05-27  Filip Pizlo  <fpizlo@apple.com>
1479
1480         testRunner should be able to tell you if a function is DFG compiled
1481         https://bugs.webkit.org/show_bug.cgi?id=116847
1482
1483         Reviewed by Mark Hahnenberg.
1484
1485         * DumpRenderTree/TestRunner.cpp:
1486         (numberOfDFGCompiles):
1487         (TestRunner::staticFunctions):
1488
1489 2013-05-21  Filip Pizlo  <fpizlo@apple.com>
1490
1491         fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1492         https://bugs.webkit.org/show_bug.cgi?id=116556
1493
1494         Reviewed by Oliver Hunt.
1495         
1496         This adds three new capabilities:
1497         
1498         - 'display' now accepts negative compilation indices, and allows specifying
1499           wildcard hashes combined with combination indices. Previously you could say
1500           'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1501           latter would display every compilation. This improves this so that you can
1502           say 'display *-<index>-<engine>'. It also makes it so that you can give a
1503           negative index, which allows you to say things like 'display blah--1-dfg',
1504           which displays just the last DFG compilation. Also you can say
1505           'display *--1-dfg', which displays the last DFG compilation for each code
1506           block. I realize that this is kind of ugly, but gosh is it practical.
1507         
1508         - You can now say 'sort hash', which will henceforth sort all of the output
1509           by code hash rather than by the time when it was compiled. This means that
1510           if you're doing 'dispay *--1-dfg' and then want to diff the results against
1511           something else, you can ensure that this doesn't get confused just by
1512           changes in compilation order.
1513         
1514         - You can now say 'counts off', which will henceforth disable the display of
1515           execution counts from 'bytecode' and 'display'. This is also useful for
1516           diffs, since if you're trying to figure out why two compilations are
1517           different, they probably have radically different counts. 'counts off' gets
1518           this out of the output so that it doesn't confuse your diff.
1519         
1520         Note that to use this effectively you should also have a script that scrubs
1521         pointers from text so that the diff doesn't get confused by pointers. I'll
1522         post my elimptr script to the bug. Maybe at some point I'll integrate that
1523         into display-profiler-output.
1524         
1525         Put together this is pretty awesome. I was able to do the following:
1526         
1527         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1528         (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1529         diff -u richards-serial.asm richards-concurrent.asm
1530         
1531         And this immediately told me that the reason why richards is slower in the
1532         concurrent compilation case is just that we end up compiling *tons* more
1533         functions, most of which are trivially inlineable. Basically, concurrent
1534         compilation breaks our previous heuristics for delaying compilation of
1535         inlineables just enough that they never trigger compilation. We should fix
1536         that in a separate bug.
1537
1538         * Scripts/display-profiler-output:
1539
1540 2013-04-30  Filip Pizlo  <fpizlo@apple.com>
1541
1542         fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1543
1544         Rubber stamped by Mark Rowe.
1545
1546         * Scripts/copy-webkitlibraries-to-product-directory:
1547
1548 2013-07-16  Oliver Hunt <oliver@apple.com>
1549
1550         Merge dfgFourthTier r148853
1551
1552     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1553
1554         fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1555         https://bugs.webkit.org/show_bug.cgi?id=114933
1556
1557         Reviewed by Andy Estes.
1558         
1559         This makes it easy to get set up for tandem LLVM builds.
1560
1561         * Scripts/copy-webkitlibraries-to-product-directory:
1562
1563 2013-07-16  Oliver Hunt <oliver@apple.com>
1564
1565         Merge dfgFourthTier r148850
1566
1567     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1568
1569         fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1570         https://bugs.webkit.org/show_bug.cgi?id=114926
1571
1572         Reviewed by Geoffrey Garen.
1573         
1574         If the LLVM libraries change, then touch a phony header, which will force relink
1575         of JavaScriptCore.
1576
1577         * Scripts/copy-webkitlibraries-to-product-directory:
1578         (unpackIfNecessary):
1579
1580 2013-07-16  Oliver Hunt <oliver@apple.com>
1581
1582         Merge dfgFourthTier r148848
1583
1584     2013-04-21  Filip Pizlo  <fpizlo@apple.com>
1585
1586         fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1587         https://bugs.webkit.org/show_bug.cgi?id=114925
1588
1589         Reviewed by Geoffrey Garen.
1590         
1591         This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1592         will also optionally build LLVM and quickly symlink LLVM's built products into
1593         the right places.
1594         
1595         Most WebKit and JSC hackers will want to rely on the checked-in already-built
1596         versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1597         increasingly common use-case for me, and it may become a common use case for a
1598         handful of others. Currently, this is really painful: you first have to build
1599         LLVM, then you have to export-llvm-build (which takes a while), and then you
1600         have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1601         variables are set to point to the thing you exported. The whole process loses
1602         track of dependencies very quickly: making a tiny change in LLVM requires
1603         packaging, and then unpackaging, a large number of potentially large headers and
1604         static libraries. Not only is this slow but it then causes the WebKit build
1605         system to rebuild anything that transitively includes any LLVM header, which is
1606         now quite a few files. While this sort of use pattern is still worthwhile if
1607         you're trying to package a binary drop and test it, it's not great if you're
1608         just trying to do experimental development that involves making small changes
1609         in both trees.
1610         
1611         This change fixes this use case while keeping the old use cases intact. You can
1612         do tandem development using one of two modes:
1613         
1614         Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1615         the LLVM directory you're using. Once this is done, any invocation of a WebKit
1616         build via build-jsc or build-webkit will also build LLVM, and then quickly
1617         symlink things into place without perturbing dependency tracking.
1618         
1619         Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1620         right off of the WebKit source tree, then the build system will automatically
1621         use this.
1622         
1623         Here's how this takes care of dependencies:
1624         
1625         Headers: the include/llvm and include/llvm-c directories are symlinked into
1626         $productsDir/usr/local/include. And then everything just works.
1627         
1628         Libraries: the build system detects, by reading LLVM's Makefile.config, which
1629         mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1630         the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1631         if they have changed, by checking both the modification time and also whether
1632         the last time we had a symlink, that symlink was from the same directory.
1633         This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1634         but that build wasn't yet ranlib'd.
1635         
1636         One problem that this does not yet solve is that xcodebuild will not relink
1637         JavaScriptCore if the only thing that changed was the libraries. I will work
1638         on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1639
1640         * Scripts/copy-webkitlibraries-to-product-directory:
1641         (unpackIfNecessary):
1642         (fileContains):
1643         (fileContentsEquals):
1644
1645 2013-04-15  Filip Pizlo  <fpizlo@apple.com>
1646
1647         fourthTier: Update LLVM-related build scripts to copy generated headers as well
1648         https://bugs.webkit.org/show_bug.cgi?id=114551
1649
1650         Reviewed by Oliver Hunt.
1651         
1652         Also added the ability to use something other than bzip2 compression, since although
1653         it is great for checking things into the tree, it increases turn-around times when
1654         experimenting.
1655
1656         * Scripts/copy-webkitlibraries-to-product-directory:
1657         (unpackIfNecessary):
1658         * Scripts/export-llvm-build:
1659
1660 2013-04-03  Filip Pizlo  <fpizlo@apple.com>
1661
1662         fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1663         https://bugs.webkit.org/show_bug.cgi?id=113921
1664
1665         Reviewed by Oliver Hunt.
1666
1667         The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1668         the export script to do this.
1669         
1670         * Scripts/export-llvm-build:
1671
1672 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1673
1674         fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1675         https://bugs.webkit.org/show_bug.cgi?id=113452
1676
1677         Rubber stamped by Mark Hahnenberg.
1678
1679         * Scripts/copy-webkitlibraries-to-product-directory:
1680         * Scripts/export-llvm-build:
1681
1682 2013-03-29  Filip Pizlo  <fpizlo@apple.com>
1683
1684         fourthTier: FTL JIT should be able run some simple function
1685         https://bugs.webkit.org/show_bug.cgi?id=113481
1686
1687         Reviewed by Geoffrey Garen.
1688         
1689         Give the scripts the ability to find an LLVM build and use it.
1690         
1691         Also added a script, export-llvm-build, that allows you to take your
1692         own build of LLVM and package it for use by WebKit's build system.
1693         
1694         The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1695         one for the library archives and one for the headers. It then unpacks
1696         them into your built products directory in a mannner that is mostly
1697         analogous to how WebKitSystemInterface works.
1698
1699         * Scripts/build-jsc:
1700         * Scripts/copy-webkitlibraries-to-product-directory:
1701         (unpackIfNecessary):
1702         (dittoHeaders):
1703         * Scripts/export-llvm-build: Added.
1704
1705 2013-07-24  Anders Carlsson  <andersca@apple.com>
1706
1707         Crash when calling WKPageGetProcessIdentifier after aborted process launch
1708         https://bugs.webkit.org/show_bug.cgi?id=119069
1709         <rdar://problem/14494064>
1710
1711         Reviewed by Andreas Kling.
1712
1713         Add a test.
1714
1715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1717         (TestWebKitAPI::didFinishLoadForFrame):
1718         (TestWebKitAPI::TEST):
1719
1720 2013-07-24  Zan Dobersek  <zdobersek@igalia.com>
1721
1722         Make KURL::hasPath private
1723         https://bugs.webkit.org/show_bug.cgi?id=118279
1724
1725         Reviewed by Darin Adler.
1726
1727         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1728         (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1729
1730 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1731
1732         [GTK] TestInspectorServer unit test is timing out
1733         https://bugs.webkit.org/show_bug.cgi?id=105866
1734
1735         Reviewed by Gustavo Noronha Silva.
1736
1737         * Scripts/run-gtk-tests:
1738         (TestRunner):
1739
1740 2013-07-24  Anton Obzhirov  <a.obzhirov@samsung.com>
1741
1742         [GTK] [WK2] Handle wheel event with delta zero
1743         https://bugs.webkit.org/show_bug.cgi?id=118973
1744
1745         Reviewed by Gustavo Noronha Silva.
1746
1747         Added handling of zero mouse scroll deltas in EventSenderProxy similar
1748         to WK1 and Qt/EFL ports.
1749
1750         fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1751         failing on WK2.
1752
1753         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1754         (WTR::EventSenderProxy::mouseScrollBy):
1755
1756 2013-07-23  Andreas Kling  <akling@apple.com>
1757
1758         REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1759         <rdar://problem/14324895>
1760         <http://webkit.org/b/119023>
1761
1762         Reviewed by Simon Fraser.
1763
1764         Add a test for this rather specific problem.
1765
1766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1767         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1768         (TestWebKitAPI::TEST):
1769         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1770         (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1771         (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1772         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1773
1774 2013-07-23  Tim Horton  <timothy_horton@apple.com>
1775
1776         Add a test for plug-in unavailability indicator obscurity detection
1777         https://bugs.webkit.org/show_bug.cgi?id=119007
1778
1779         Reviewed by Anders Carlsson.
1780
1781         Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1782
1783         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1784         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1785         (WTR::TestRunner::setBlockAllPlugins):
1786         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1787         * WebKitTestRunner/TestInvocation.cpp:
1788         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1789         Add testRunner.setBlockAllPlugins function (and corresponding message to
1790         forward it through to TestController).
1791
1792         * WebKitTestRunner/TestController.cpp:
1793         Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1794
1795         (WTR::TestController::createWebViewWithOptions):
1796         Register our pluginLoadPolicy callback.
1797
1798         (WTR::TestController::resetStateToConsistentValues):
1799         Reset m_shouldBlockAllPlugins to false.
1800
1801         (WTR::TestController::pluginLoadPolicy):
1802         Return the existing plugin load policy, unless setBlockAllPlugins(true)
1803         was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
1804
1805         * WebKitTestRunner/TestController.h:
1806         (WTR::TestController::setBlockAllPlugins):
1807
1808 2013-07-21  Andreas Kling  <akling@apple.com>
1809
1810         KURL creates duplicate strings when completing data: URIs.
1811         <http://webkit.org/b/118952>
1812         <rdar://problem/14504480>
1813
1814         Reviewed by Anders Carlsson.
1815
1816         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1817         (TestWebKitAPI::TEST_F):
1818
1819 2013-07-19  Chris Fleizach  <cfleizach@apple.com>
1820
1821         AX: VoiceOver not detecting misspelled words don't work in all cases
1822         https://bugs.webkit.org/show_bug.cgi?id=118924
1823
1824         Reviewed by Tim Horton.
1825
1826         Make the misspelled detection dependent on both types of attributes being present.
1827
1828         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1829         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1830         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1831         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1832
1833 2013-07-19  Alex Christensen  <achristensen@apple.com>
1834
1835         Improved code coverage generation.
1836         https://bugs.webkit.org/show_bug.cgi?id=118926
1837
1838         Reviewed by Tim Horton.
1839
1840         * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
1841         * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
1842         (generateReport): Moved report generation to a subroutine.
1843
1844 2013-07-19  Stephanie Lewis  <slewis@apple.com>
1845
1846         <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
1847
1848         Unreviewed.
1849
1850         Rebaseline pagination test after http://trac.webkit.org/changeset/152911
1851
1852         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
1853         (TestWebKitAPI::didLayout):
1854
1855 2013-07-19  Daniel Bates  <dabates@apple.com>
1856
1857         Make Perl tools work when using git bisect with Git branch build setup
1858         https://bugs.webkit.org/show_bug.cgi?id=118512
1859
1860         Reviewed by Martin Robinson.
1861
1862         The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
1863         during a git bisect session with a Git branch build setup (i.e. git config
1864         core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
1865         specific build of WebKit because they cannot determine the branch Git is on (since
1866         git bisect puts Git into a detached HEAD state). We should teach our tooling to
1867         parse the file .git/BISECT_START (created by git bisect start) for the name of the
1868         branch Git was on when we began a git bisect session. Then the tools can determine
1869         the path to the built WebKit.
1870
1871         * Scripts/VCSUtils.pm:
1872         (gitDirectory): Added.
1873         (gitBisectStartBranch): Added.
1874         (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
1875         HEAD (e.g. running git bisect).
1876         (determineVCSRoot): Modified to call gitDirectory() to determine the path to
1877         the .git directory in the Git checkout.
1878
1879 2013-07-19  Alex Christensen  <achristensen@apple.com>
1880
1881         Added x64 configuration to Visual Studio build.
1882         https://bugs.webkit.org/show_bug.cgi?id=118888
1883
1884         Reviewed by Brent Fulgham.
1885
1886         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1887         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1888         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
1889         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
1890         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
1891         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
1892         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1893         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1894         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1895         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
1896         * win/record-memory/record-memory.vcxproj:
1897
1898 2013-07-19  Martin Robinson  <mrobinson@igalia.com>
1899
1900         Add a couple people to the MathML watchlist
1901         https://bugs.webkit.org/show_bug.cgi?id=118909
1902
1903         Reviewed by Andreas Kling.
1904
1905         Add a couple people to the MathML watchlist and add Kalyan's other
1906         email address to fix style checker warnings about the watchlist
1907         contents.
1908
1909         * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
1910         list of contributors and add Kalyan's second email address.
1911         * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
1912         watchlist.
1913
1914 2013-07-19  Simon Pena  <simon.pena@samsung.com>
1915
1916         [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
1917         https://bugs.webkit.org/show_bug.cgi?id=118895
1918
1919         Reviewed by Philippe Normand.
1920
1921         In r152782 an uri is used to create an string representation without checking first if it
1922         is valid. That fails later when the string is used to check for existing redirections. This
1923         patch ensures that the uri is valid before using it.
1924
1925         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1926         (willSendRequestCallback): Ensure an uri is valid before using it.
1927
1928 2013-07-18  Timothy Hatcher  <timothy@apple.com>
1929
1930         Add extract-localizable-js-strings and use it for WebInspectorUI.
1931
1932         https://bugs.webkit.org/show_bug.cgi?id=118851
1933
1934         Reviewed by Joseph Pecoraro.
1935
1936         * Scripts/extract-localizable-js-strings: Added.
1937         * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
1938         * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
1939         the WebInspectorUI project.
1940
1941 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
1942
1943         [Windows] Build correction #2 after r152861.
1944
1945         * WinLauncher/WinLauncher.cpp: Declare proper linkage.
1946
1947 2013-07-18  Brent Fulgham  <bfulgham@apple.com>
1948
1949         [Windows] Build correction after r152861.
1950
1951         * WinLauncher/WinLauncher.cpp: Don't reference private header.
1952
1953 2013-07-16  Brent Fulgham  <bfulgham@apple.com>
1954
1955         [Win] Support in-band text tracks.
1956         https://bugs.webkit.org/show_bug.cgi?id=103770
1957
1958         Reviewed by Eric Carlson.
1959
1960         Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
1961         libdispatch and CFRunLoop elements are services during the run loop.
1962
1963         * WinLauncher/WinLauncher.cpp:
1964         (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
1965         a CoreFoundation (or CFLite) support library.
1966         * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
1967         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
1968         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
1969         and WinLauncherCFLite.props.
1970
1971 2013-07-18  Roger Fong  <roger_fong@apple.com>
1972
1973         Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
1974
1975         * Scripts/webkitpy/common/config/ews.json:
1976
1977 2013-07-18  Daniel Bates  <dabates@apple.com>
1978
1979         REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
1980         https://bugs.webkit.org/show_bug.cgi?id=118854
1981         <rdar://problem/14081339>
1982
1983         Reviewed by David Kilzer.
1984
1985         Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
1986         Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
1987         run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
1988         listen on these ports so that we can run tests that use port 8443 and 8080.
1989
1990         * Scripts/old-run-webkit-tests:
1991         (configureAndOpenHTTPDIfNeeded):
1992
1993 2013-07-17  Tim Horton  <timothy_horton@apple.com>
1994
1995         Update blocked/missing plug-in UI
1996         https://bugs.webkit.org/show_bug.cgi?id=118347
1997         <rdar://problem/14209318>
1998
1999         Reviewed by Sam Weinig.
2000
2001         * MiniBrowser/mac/WK2BrowserWindowController.m:
2002         (-[WK2BrowserWindowController awakeFromNib]):
2003         * WebKitTestRunner/TestController.cpp:
2004         (WTR::TestController::createWebViewWithOptions):
2005         Match new WKPageLoaderClient entry.
2006
2007 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2008
2009         Unreviewed, rolling out r152701, r152703, r152739, r152754,
2010         and r152756.
2011         http://trac.webkit.org/changeset/152701
2012         http://trac.webkit.org/changeset/152703
2013         http://trac.webkit.org/changeset/152739
2014         http://trac.webkit.org/changeset/152754
2015         http://trac.webkit.org/changeset/152756
2016         https://bugs.webkit.org/show_bug.cgi?id=118821
2017
2018         this was a buggy fix and we're going to try something
2019         different (Requested by thorton on #webkit).
2020
2021         * MiniBrowser/mac/WK2BrowserWindowController.m:
2022         (-[WK2BrowserWindowController awakeFromNib]):
2023         * WebKitTestRunner/TestController.cpp:
2024         (WTR::TestController::createWebViewWithOptions):
2025
2026 2013-07-17  Commit Queue  <commit-queue@webkit.org>
2027
2028         Unreviewed, rolling out r151535.
2029         http://trac.webkit.org/changeset/151535
2030         https://bugs.webkit.org/show_bug.cgi?id=118804
2031
2032         Re-disable WinEWS tests (Requested by rfong on #webkit).
2033
2034         * Scripts/webkitpy/common/config/ews.json:
2035
2036 2013-07-17  Simon Pena  <simon.pena@samsung.com>
2037
2038         [GTK] Make DRT obbey testRunner's addURLToRedirect
2039         https://bugs.webkit.org/show_bug.cgi?id=118239
2040
2041         Reviewed by Gustavo Noronha Silva.
2042
2043         Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2044         to the proper URI when indicated.
2045
2046         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2047         (willSendRequestCallback):
2048
2049 2013-07-17  Gabor Abraham  <abrhm@inf.u-szeged.hu>
2050
2051         Add a new find-resolved-bugs command to webkit-patch.
2052         https://bugs.webkit.org/show_bug.cgi?id=118060
2053
2054         Reviewed by Csaba Osztrogonác.
2055
2056         * Scripts/webkitpy/tool/commands/queries.py:
2057         (PrintBaselines._platform_for_path):
2058         (FindResolvedBugs):
2059         (FindResolvedBugs.execute):
2060
2061 2013-07-16  Balazs Kelemen  <kbalazs@webkit.org>
2062
2063         [CMake] Undefined references should be detected at build time
2064         https://bugs.webkit.org/show_bug.cgi?id=110236
2065
2066         Reviewed by Christophe Dumez.
2067
2068         Add library dependencies that were not defined explicitly before.
2069
2070         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2071         * TestWebKitAPI/CMakeLists.txt:
2072         * WebKitTestRunner/CMakeLists.txt:
2073
2074 2013-07-16  Kwang Yul Seo  <skyul@company100.net>
2075
2076         check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2077         https://bugs.webkit.org/show_bug.cgi?id=118755
2078
2079         Reviewed by Ryosuke Niwa.
2080
2081         Fix r152719 to check "using namespace foo;" only in headers.
2082
2083         * Scripts/webkitpy/style/checkers/cpp.py:
2084         (check_using_namespace):
2085         (check_style):
2086         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2087         (WebKitStyleTest.test_using_namespace):
2088
2089 2013-07-16  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2090
2091         Get rid of multiple inheritance support from the bindings generators
2092         https://bugs.webkit.org/show_bug.cgi?id=118353
2093
2094         Reviewed by Kentaro Hara.
2095
2096         Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2097         deprecated domInterface->parents.
2098
2099         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2100         (_parentInterface):
2101
2102 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2103
2104         check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2105         https://bugs.webkit.org/show_bug.cgi?id=57241
2106
2107         Reviewed by Ryosuke Niwa.
2108
2109         Added check for "using namespace foo" and unit test.
2110
2111         * Scripts/webkitpy/style/checkers/cpp.py:
2112         (check_using_namespace):
2113         (check_style):
2114         (CppChecker):
2115         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2116         (WebKitStyleTest.test_using_namespace):
2117
2118 2013-07-16  Anton Obzhirov  <a.obzhirov@samsung.com>
2119
2120         [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2121         https://bugs.webkit.org/show_bug.cgi?id=110222
2122
2123         Reviewed by Gustavo Noronha Silva.
2124
2125         Added handling of zero mouse scroll deltas in EventSender.
2126
2127         * DumpRenderTree/gtk/EventSender.cpp:
2128         (mouseScrollByCallback):
2129
2130 2013-07-16  Brian Holt  <brian.holt@samsung.com>
2131
2132         webkitpy: replace urllib with urllib2 for downloading additional modules
2133         https://bugs.webkit.org/show_bug.cgi?id=118671
2134
2135         Reviewed by Ryosuke Niwa.
2136
2137         Urllib2 is available whereever urllib is, but has better proxy support.
2138
2139         * Scripts/webkitpy/common/system/autoinstall.py:
2140         (AutoInstaller._download_to_stream):
2141
2142 2013-07-16  Krzysztof Czech  <k.czech@samsung.com>
2143
2144         [ATK] Adds support for aria-haspopup property.
2145         https://bugs.webkit.org/show_bug.cgi?id=117834
2146
2147         Reviewed by Christophe Dumez.
2148
2149         Adds implementation for testing aria-haspopup property.
2150
2151         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2152         (getAttributeSetValueForId):
2153         (AccessibilityUIElement::stringAttributeValue):
2154         (AccessibilityUIElement::hasPopup):
2155         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2156         (WTR::getAttributeSetValueForId):
2157         (WTR::AccessibilityUIElement::stringAttributeValue):
2158         (WTR::AccessibilityUIElement::hasPopup):
2159
2160 2013-07-16  Michael Brüning  <michael.bruning@digia.com>
2161
2162         [Qt] Replace Nokia references.
2163         https://bugs.webkit.org/show_bug.cgi?id=118728
2164
2165         Reviewed by Simon Hausmann.
2166
2167         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2168         (MiniBrowserApplication::MiniBrowserApplication):
2169         * QtTestBrowser/qttestbrowser.cpp:
2170         (LauncherApplication::LauncherApplication):
2171
2172 2013-07-15  Tim Horton  <timothy_horton@apple.com>
2173
2174         Update blocked/missing plug-in UI
2175         https://bugs.webkit.org/show_bug.cgi?id=118347
2176         <rdar://problem/14209318>
2177
2178         Reviewed by Sam Weinig.
2179
2180         * MiniBrowser/mac/WK2BrowserWindowController.m:
2181         (-[WK2BrowserWindowController awakeFromNib]):
2182         * WebKitTestRunner/TestController.cpp:
2183         (WTR::TestController::createWebViewWithOptions):
2184         Match new WKPageLoaderClient entry.
2185
2186 2013-07-15  Chris Fleizach  <cfleizach@apple.com>
2187
2188         Update James Craig's email address.
2189
2190         * Scripts/webkitpy/common/config/contributors.json:
2191
2192 2013-07-15  Dong-Gwan Kim  <donggwan.kim@samsung.com>
2193
2194         [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2195         https://bugs.webkit.org/show_bug.cgi?id=118583
2196
2197         Reviewed by Christophe Dumez.
2198
2199         There're many fails on efl webkit2 API test if opengl is not available.
2200         So, add fallback to non-opengl evas engine.
2201
2202         * TestWebKitAPI/efl/PlatformWebView.cpp:
2203         (TestWebKitAPI::initEcoreEvas):
2204
2205 2013-07-15  Brian Holt  <brian.holt@samsung.com>
2206
2207         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2208         https://bugs.webkit.org/show_bug.cgi?id=118592
2209
2210         Reviewed by Martin Robinson.
2211
2212         Added a suppression for pylint false positives and a unit test.
2213
2214         * Scripts/webkitpy/style/checkers/python.py:
2215         (Pylinter):
2216         * Scripts/webkitpy/style/checkers/python_unittest.py:
2217         (PythonCheckerTest.test_check):
2218         (PythonCheckerTest):
2219         (PythonCheckerTest.test_pylint_false_positives):
2220         (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2221         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2222         (test_popen):
2223
2224 2013-07-15  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2225
2226         [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2227         https://bugs.webkit.org/show_bug.cgi?id=115166
2228
2229         Reviewed by Philippe Normand.
2230
2231         * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2232
2233 2013-07-12  Kwang Yul Seo  <skyul@company100.net>
2234
2235         Unreviewed. Add an email address and update my domain of experts.
2236
2237         * Scripts/webkitpy/common/config/contributors.json:
2238
2239 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2240
2241         [jhbuild] Avoid restarting from scratch failed initial checkouts
2242         https://bugs.webkit.org/show_bug.cgi?id=118603
2243
2244         Reviewed by Martin Robinson.
2245
2246         If the initial checkout is interrupted midway (eg. because the internet
2247         connection went down) config files do not get generated and that causes
2248         the next checkout to start from scratch (the missing files cause the
2249         script to delete the build root and the downloaded sources).
2250
2251         By generating the files before invoking jhbuild, subsequent runs are able
2252         to start where the previous run left.
2253
2254         * Scripts/update-webkit-libs-jhbuild:
2255         (saveJhbuildMd5): invoke it before runJhbuild().
2256
2257 2013-07-12  Brent Fulgham  <bfulgham@apple.com>
2258
2259         [Windows] Remove single-worker restriction on tests.
2260
2261         * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2262
2263 2013-07-12  Commit Queue  <commit-queue@webkit.org>
2264
2265         Unreviewed, rolling out r152599.
2266         http://trac.webkit.org/changeset/152599
2267         https://bugs.webkit.org/show_bug.cgi?id=118612
2268
2269         This patch includes a failing unit test (Requested by
2270         mrobinson on #webkit).
2271
2272         * Scripts/webkitpy/style/checkers/python.py:
2273         (Pylinter):
2274         * Scripts/webkitpy/style/checkers/python_unittest.py:
2275         (PythonCheckerTest.test_check):
2276         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2277
2278 2013-07-12  Emanuele Aina  <emanuele.aina@collabora.com>
2279
2280         [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2281         https://bugs.webkit.org/show_bug.cgi?id=91223
2282
2283         Reviewed by Martin Robinson.
2284
2285         When run on a clean checkout, `build-webkit` complains that no
2286         GNUmakefile exists when trying to detect the previously configured
2287         architecture, but in this case there's no previous configuration so
2288         the warning is pointless.
2289
2290         * Scripts/webkitdirs.pm:
2291         (determineArchitecture): Redirect grep stderr to /dev/null.
2292
2293 2013-07-12  Brian Holt  <brian.holt@samsung.com>
2294
2295         check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2296         https://bugs.webkit.org/show_bug.cgi?id=118592
2297
2298         Reviewed by Martin Robinson.
2299
2300         Added a suppression for pylint false positives and a unit test.
2301
2302         * Scripts/webkitpy/style/checkers/python.py:
2303         (Pylinter):
2304         * Scripts/webkitpy/style/checkers/python_unittest.py:
2305         (PythonCheckerTest.test_check):
2306         (PythonCheckerTest):
2307         (PythonCheckerTest.test_pylint_false_positives):
2308         (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2309         * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2310         (test_popen):
2311
2312 2013-07-11  Arnaud Renevier  <a.renevier@samsung.com>
2313
2314         Unreviewed. Add myself as a committer.
2315
2316         * Scripts/webkitpy/common/config/contributors.json:
2317
2318 2013-07-10  Sergio Correia  <sergio.correia@openbossa.org>
2319
2320         Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2321         https://bugs.webkit.org/show_bug.cgi?id=118538
2322
2323         Reviewed by Christophe Dumez.
2324
2325         When attempting some odd url such as ``foo'', MiniBrowser will now show an
2326         error message such as "Cannot resolve hostname (foo)".
2327
2328         Previously, it had the following behavior if MiniBrowser was started with
2329         such urls, e.g ``./MiniBrowser foo'':
2330
2331         - Debug:
2332         It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2333
2334         - Release:
2335         No asserts, naturally, but the view would remain blank, even if we tried to
2336         change to a valid url.
2337
2338         * MiniBrowser/efl/main.c:
2339         (window_create):
2340
2341 2013-07-10  Simon Pena  <simon.pena@samsung.com>
2342
2343         [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2344         https://bugs.webkit.org/show_bug.cgi?id=118509
2345
2346         Reviewed by Martin Robinson.
2347
2348         In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2349         when trying to remove an event already removed, if another event is
2350         processed in the middle. By using a Deque's takeFirst, we ensure the
2351         element is removed before we dispatch it.
2352
2353         fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2354         crashes after this fix is added.
2355
2356         * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2357         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2358         (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2359         from the queue.
2360
2361 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
2362
2363         [EFL] Add ewk_view_device_pixel_ratio_set
2364         https://bugs.webkit.org/show_bug.cgi?id=118521
2365
2366         Reviewed by Gyuyoung Kim.
2367
2368         * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2369         (windowCreate):
2370         (parseUserArguments):
2371
2372 2013-07-09  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
2373
2374         Unreviewed change of my email addresses.
2375         https://bugs.webkit.org/show_bug.cgi?id=100122
2376
2377         * Scripts/webkitpy/common/config/contributors.json:
2378
2379 2013-07-09  Anders Carlsson  <andersca@apple.com>
2380
2381         DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2382         https://bugs.webkit.org/show_bug.cgi?id=118514
2383         <rdar://problem/13686836>
2384
2385         Reviewed by Sam Weinig.
2386
2387         Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2388
2389         * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2390         * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2391         (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2393         Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2394
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (allocateGlobalControllers):
2397         Allocate a DefaultPolicyDelegate object.
2398
2399         (resetWebViewToConsistentStateBeforeTesting):
2400         Set the policy delegate to the default policy delegate.
2401
2402         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2403         Declare the defaultPolicyDelegate object.
2404
2405         * DumpRenderTree/mac/TestRunnerMac.mm:
2406         (TestRunner::setCustomPolicyDelegate):
2407         Set the policy delegate to the default delegate if setDelegate is false.
2408
2409 2013-07-08  Zan Dobersek  <zdobersek@igalia.com>
2410
2411         KURL unit test fixture class should have a meaningful name
2412         https://bugs.webkit.org/show_bug.cgi?id=118467
2413
2414         Reviewed by Sam Weinig.
2415
2416         * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2417         (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2418         instead of the generic and inappropriate 'WebCore' name.
2419
2420 2013-07-08  Antti Koivisto  <antti@apple.com>
2421
2422         Add Deque::removeLast
2423         https://bugs.webkit.org/show_bug.cgi?id=118466
2424
2425         Reviewed by Andreas Kling.
2426
2427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2428         * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2429         (TestWebKitAPI::TEST):
2430
2431 2013-07-08  Brian Holt  <brian.holt@samsung.com>
2432
2433         [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2434         https://bugs.webkit.org/show_bug.cgi?id=118412
2435
2436         Reviewed by Martin Robinson.
2437
2438         An adoptRef is required to balance ref and deref calls.
2439
2440         * DumpRenderTree/gtk/EventSender.cpp:
2441         (beginDragWithFilesCallback):
2442
2443 2013-07-06  Sergio Correia  <sergio.correia@openbossa.org>
2444
2445         Update list of EFL WK2 API tests
2446         https://bugs.webkit.org/show_bug.cgi?id=118443
2447
2448         Reviewed by Christophe Dumez.
2449
2450         The following tests were included:
2451
2452         Passing:
2453         - CloseThenTerminate
2454         - DidAssociateFormControls
2455         - PageVisibilityState
2456         - ResponsivenessTimerDoesntFireEarly
2457         - TerminateTwice
2458         - WillLoad
2459
2460         Failing:
2461         - ResizeReversePaginatedWebView
2462         - ScrollPinningBehaviors
2463
2464         This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2465         alphabetical order.
2466
2467         * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2468         * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2469
2470 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2471
2472         Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2473         https://bugs.webkit.org/show_bug.cgi?id=118439
2474         <rdar://problem/14366120>
2475
2476         Reviewed by Anders Carlsson.
2477
2478         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2479         (TestWebKitAPI::didLayout):
2480         (TestWebKitAPI::TEST):
2481         - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2482         - Assert that we got the right number of pages for sanity.
2483         - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2484             so much memory that SharedMemory asserts and makes the test time out.
2485         - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2486             because paint doesn't fire if the window is offscreen.
2487
2488 2013-07-05  Tim Horton  <timothy_horton@apple.com>
2489
2490         [wk2] Add API to lock the scroll position at the top or bottom of the page
2491         https://bugs.webkit.org/show_bug.cgi?id=118429
2492         <rdar://problem/14120323>
2493
2494         Reviewed by Anders Carlsson.
2495
2496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2497         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2498         (TestWebKitAPI::didFinishDocumentLoadForFrame):
2499         (TestWebKitAPI::TEST):
2500         Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2501         all work correctly in the face of resizing the view and scrolling from JS.
2502
2503 2013-07-05  Michael Pruett  <michael@68k.org>
2504
2505         Unreviewed. Add myself as a committer.
2506
2507         * Scripts/webkitpy/common/config/contributors.json:
2508
2509 2013-07-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2510
2511         [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2512         https://bugs.webkit.org/show_bug.cgi?id=111434
2513
2514         Reviewed by Carlos Garcia Campos.
2515
2516         * Scripts/run-gtk-tests:
2517         (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2518
2519 2013-07-04  Viatcheslav Ostapenko  <sl.ostapenko@samsung.com>
2520
2521         [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2522         https://bugs.webkit.org/show_bug.cgi?id=118370
2523
2524         Reviewed by Christophe Dumez.
2525
2526         Add fallback to software X11 engine if opengl_x11 engine creation fails.
2527
2528         * DumpRenderTree/efl/DumpRenderTree.cpp:
2529         (initEcoreEvas):
2530
2531 2013-07-04  Brian Holt  <brian.holt@samsung.com>
2532
2533         [ATK] Leak: AtkAttributeSet* should be freed
2534         https://bugs.webkit.org/show_bug.cgi?id=118307
2535
2536         Reviewed by Christophe Dumez.
2537
2538         Fixed memory leaks for AtkAttributeSet by calling
2539         atk_attribute_set_free().
2540
2541         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2542         (AccessibilityController::childElementById):
2543         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2544         (getAtkAttributeSetAsString):
2545         (AccessibilityUIElement::allAttributes):
2546         (AccessibilityUIElement::stringAttributeValue):
2547         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2548         (WTR::childElementById):
2549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2550         (WTR::getAtkAttributeSetAsString):
2551         (WTR::AccessibilityUIElement::allAttributes):
2552         (WTR::AccessibilityUIElement::stringAttributeValue):
2553
2554 2013-07-03  David Farler  <dfarler@apple.com>
2555
2556         Add Makefile to WebKitLauncher
2557         https://bugs.webkit.org/show_bug.cgi?id=118365
2558
2559         Reviewed by Mark Rowe.
2560
2561         * WebKitLauncher/Makefile: Added.
2562
2563 2013-07-03  Brian Holt  <brian.holt@samsung.com>
2564
2565         [ATK] Leak: more leaks in AccessibilityUIElement
2566         https://bugs.webkit.org/show_bug.cgi?id=118362
2567
2568         Reviewed by Christophe Dumez.
2569
2570         Free the memory created by g_strdup_printf.
2571
2572         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2573         (AccessibilityUIElement::language):
2574         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2575         (WTR::AccessibilityUIElement::language):
2576
2577 2013-07-03  Jer Noble  <jer.noble@apple.com>
2578
2579         Xcode often gets in a state where the debugger is completely unresponsive
2580         https://bugs.webkit.org/show_bug.cgi?id=118157
2581
2582         The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2583         Rather than pull the character data out of the debugger one byte at a time
2584         through the GetPointeeData() API, retrieve the memory contents of the string through
2585         the ReadMemory() API, and convert the retrieved memory into a python string.
2586
2587         Reviewed by Anders Carlsson.
2588
2589         * lldb/lldb_webkit.py:
2590         (__lldb_init_module.lldb_webkit):
2591         (guess_string_length):
2592         (ustring_to_string):
2593         (lstring_to_string):
2594
2595 2013-07-03  Morten Stenshorne  <mstensho@opera.com>
2596
2597         [GTK] Let F5 refresh the page in MiniBrowser
2598         https://bugs.webkit.org/show_bug.cgi?id=117638
2599
2600         Reviewed by Carlos Garcia Campos.
2601
2602         Also use the correct icon for the refresh button that was already there.
2603
2604         * MiniBrowser/gtk/BrowserWindow.c:
2605         (browser_window_init):
2606
2607 2013-07-02  Kondapally Kalyan  <kalyan.kondapally@intel.com>
2608
2609         Unreviewed. Add my email to a few watchlists.
2610
2611         * Scripts/webkitpy/common/config/watchlist:
2612
2613 2013-07-02  David Farler  <dfarler@apple.com>
2614
2615         Unreviewed. Adding myself to contributors.json.
2616
2617         * Scripts/webkitpy/common/config/contributors.json:
2618
2619 2013-07-02  Brian Holt  <brian.holt@samsung.com>
2620
2621         [ATK] Leak: leaks in AccessibilityUIElement
2622         https://bugs.webkit.org/show_bug.cgi?id=118297
2623
2624         Fixed memory leak.
2625
2626         Reviewed by Christophe Dumez.
2627
2628         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2629         (AccessibilityUIElement::stringValue):
2630
2631 2013-07-02  Byungwoo Lee  <bw80.lee@samsung.com>
2632
2633         Fix WebKitTestRunner crashes.
2634         https://bugs.webkit.org/show_bug.cgi?id=117630
2635
2636         Reviewed by Darin Adler.
2637
2638         Create static function to dump for WebProcess unresponsiveness status,
2639         and use it before calling TestController::runTest().
2640
2641         Accessing TestController::m_currentInvocation before calling
2642         TestController::runTest() can make crash because the invocation
2643         instance will be assigned at the function.
2644
2645         * WebKitTestRunner/TestController.cpp:
2646         (WTR::TestController::run):
2647         * WebKitTestRunner/TestInvocation.cpp:
2648         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2649         * WebKitTestRunner/TestInvocation.h:
2650
2651 2013-07-02  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2652
2653         [Qt][WK1] Support WebGL with EGL on Linux
2654         https://bugs.webkit.org/show_bug.cgi?id=118251
2655
2656         Reviewed by Kenneth Rohde Christiansen.
2657
2658         * qmake/mkspecs/features/features.prf:
2659
2660 2013-07-01  Nick Diego Yamane  <nick.yamane@openbossa.org>
2661
2662         [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2663         https://bugs.webkit.org/show_bug.cgi?id=118267
2664
2665         Reviewed by Gyuyoung Kim.
2666
2667         After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2668         WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2669         Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2670
2671         * efl/jhbuildrc:
2672         * gtk/jhbuildrc:
2673
2674 2013-07-01  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2675
2676         [GTK] Remove unsupported AC backends
2677         https://bugs.webkit.org/show_bug.cgi?id=117362
2678
2679         Reviewed by Martin Robinson.
2680
2681         * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2682         and cogl, so removed.
2683
2684 2013-07-01  Timothy Hatcher  <timothy@apple.com>
2685
2686         Link to WebInspectorUI.framework at build time instead of soft linking.
2687
2688         https://bugs.webkit.org/show_bug.cgi?id=118261
2689
2690         Reviewed by Joseph Pecoraro.
2691
2692         * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2693
2694 2013-07-01  Tim Horton  <timothy_horton@apple.com>
2695
2696         Maximum scroll position can be negative in some cases
2697         https://bugs.webkit.org/show_bug.cgi?id=118175
2698         <rdar://problem/14301217>
2699
2700         Reviewed by Anders Carlsson.
2701
2702         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2703         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2704         (TestWebKitAPI::didRunJavaScript):
2705         (TestWebKitAPI::didLayout):
2706         (TestWebKitAPI::TEST):
2707         * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2708         Add a test that loads a vertical-lr document, paginates it horizontally
2709         from right to left, resizes the view to fit the entire document, and
2710         verifies that the scroll position is negative, as it must be for the
2711         document to be enclosed by the view.
2712
2713 2013-07-01  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2714
2715         [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2716         https://bugs.webkit.org/show_bug.cgi?id=117249
2717
2718         Reviewed by Brent Fulgham.
2719
2720         Finish converting all use cases of WEBKITOUTPUTDIR to
2721         WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2722
2723         * DumpRenderTree/efl/FontManagement.cpp:
2724         (getCustomBuildDir):
2725         (getPlatformFontsPath):
2726         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2727         (getOutputDir):
2728         * Scripts/webkitdirs.pm:
2729         (determineBaseProductDir):
2730         (usesPerConfigurationBuildDirectory):
2731         * Scripts/webkitpy/port/base.py:
2732         (Port.to.setup_environ_for_server):
2733         * Scripts/webkitpy/port/driver.py:
2734         (Driver._setup_environ_for_driver):
2735         * Scripts/webkitpy/port/gtk.py:
2736         (GtkPort.setup_environ_for_server):
2737         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2738         (WTR::getOutputDir):
2739         * jhbuild/jhbuildutils.py:
2740         (get_dependencies_path):
2741
2742 2013-07-01  Rafael Brandao  <rafael.lobo@webkit.org>
2743
2744         Unreviewed change of my email address.
2745
2746         * Scripts/webkitpy/common/config/contributors.json:
2747
2748 2013-06-28  Andreas Kling  <akling@apple.com>
2749
2750         Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2751
2752         * DumpRenderTree/win/DumpRenderTree.cpp:
2753         (addFontFallbackIfPresent):
2754         (removeFontFallbackIfPresent):
2755
2756 2013-06-28  Anders Carlsson  <andersca@apple.com>
2757
2758         Remove String::deprecatedCharactersWithNullTermination() and related code
2759         https://bugs.webkit.org/show_bug.cgi?id=118211
2760
2761         Reviewed by Benjamin Poulain.
2762
2763         Remove all hasTerminatingNullCharacter() checks.
2764
2765         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2766         (TestWebKitAPI::TEST):
2767         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2768         (TestWebKitAPI::TEST):
2769         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2770         (TestWebKitAPI::TEST):
2771
2772 2013-06-28  Alexey Proskuryakov  <ap@apple.com>
2773
2774         [Mac] Crash when loading is stopped from -didReceiveResponse
2775         https://bugs.webkit.org/show_bug.cgi?id=118209
2776         <rdar://problem/14259249>
2777
2778         Reviewed by Brady Eidson.
2779
2780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2781         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2782         * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2783         (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2784         (TestWebKitAPI::TEST):
2785
2786 2013-06-28  Andy Estes  <aestes@apple.com>
2787
2788         [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2789         https://bugs.webkit.org/show_bug.cgi?id=118208
2790
2791         Reviewed by Mark Rowe.
2792
2793         Newer versions of clang use a default template depth of 128, but this
2794         is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2795         previous default.
2796
2797         Clang lowered the default to keep recursive template instantiation
2798         from overflowing the stack (see <rdar://problem/13935016>), but
2799         TestWebKitAPI's C++ files don't trigger a stack overflow even with the
2800         higher limit. If for some reason this starts happening then we can
2801         lower the limit back down.
2802
2803         * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
2804
2805 2013-06-28  Nick Diego Yamane  <nick.yamane@openbossa.org>
2806
2807         [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
2808         https://bugs.webkit.org/show_bug.cgi?id=118195
2809
2810         Reviewed by Daniel Bates.
2811
2812         Currently, ports that use jhbuild fail to determine jhbuild directory
2813         when "webKitBranchBuild" git configuration property is enabled. To reproduce
2814         that issue in Efl port, enable that flag in .git/config, switch to a git branch
2815         other than "master" and try to build webkit. The build will fail to
2816         locate dependencies due to lack of pkg-config paths which should be set
2817         by jhbuild.
2818
2819         For more details about "webKitBranchBuild" option, see:
2820         https://trac.webkit.org/wiki/UsingGitWithWebKit
2821
2822         * Scripts/webkitdirs.pm:
2823         (getJhbuildPath):
2824
2825 2013-06-28  Jessie Berlin  <jberlin@apple.com>
2826
2827         WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
2828         https://bugs.webkit.org/show_bug.cgi?id=118201
2829
2830         Reviewed by Dean Jackson.
2831
2832         * WebKitTestRunner/mac/main.mm:
2833         (main):
2834         Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
2835         setAutomaticDashSubstitutionEnabled are not exposed on WKView.
2836
2837 2013-06-28  David Farler  <dfarler@apple.com>
2838
2839         Upstream WebKit Nightly’s WebKitLauncher
2840         https://bugs.webkit.org/show_bug.cgi?id=117418
2841
2842         Reviewed by Mark Rowe.
2843
2844         Literal patch from Nightly's OpenSource repo.
2845
2846         * WebKitLauncher/Configurations/Base.xcconfig:
2847         * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
2848         * WebKitLauncher/Info.plist:
2849         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2850         * WebKitLauncher/WebKitLauncherURLProtocol.m:
2851         (+[WebKitLauncherURLProtocol load]):
2852         (+[WebKitLauncherURLProtocol canInitWithRequest:]):
2853         (-[WebKitLauncherURLProtocol startLoading]):
2854         (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
2855         (-[WebKitLauncherURLProtocol resourceNotFound]):
2856         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2857         (initializeSparkle):
2858         * WebKitLauncher/main.m:
2859         (determineExecutablePath):
2860         (currentMacOSXVersion):
2861         (main):
2862         * WebKitLauncher/start.html:
2863
2864 2013-06-28  Balazs Kelemen  <b.kelemen@samsung.com>
2865
2866         [EFL] back/forward keyboard shortcuts are non-intuitive
2867         https://bugs.webkit.org/show_bug.cgi?id=118193
2868
2869         Reviewed by Christophe Dumez.
2870
2871         Changed shortcuts for go-back/go-forward to alt+left and alt+right.
2872
2873         * EWebLauncher/main.c:
2874         (on_key_down):
2875         * MiniBrowser/efl/main.c:
2876         (on_key_down):
2877
2878 2013-06-28  Roger Fong  <roger_fong@apple.com>
2879
2880         Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
2881         https://bugs.webkit.org/show_bug.cgi?id=118194.
2882
2883         Reviewed by Brent Fulgham.
2884
2885         * DumpRenderTree/win/DumpRenderTree.cpp:
2886         (dllLauncherEntryPoint):
2887         * WinLauncher/WinLauncher.cpp:
2888         (dllLauncherEntryPoint):
2889
2890 2013-06-28  Roger Fong  <roger_fong@apple.com>
2891
2892         Unreviewed build fix for AppleWin port. Fix some file paths.
2893
2894         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2895         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2896
2897 2013-06-27  Roger Fong  <roger_fong@apple.com>
2898
2899         Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
2900         https://bugs.webkit.org/show_bug.cgi?id=118160.
2901
2902         Reviewed by Brent Fulgham.
2903
2904         * WinLauncher/AccessibilityDelegate.cpp: Added.
2905         (AccessibilityDelegate::QueryInterface):
2906         (AccessibilityDelegate::AddRef):
2907         (AccessibilityDelegate::Release):
2908         (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
2909         (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
2910         * WinLauncher/AccessibilityDelegate.h: Added.
2911         (AccessibilityDelegate::AccessibilityDelegate):
2912         * WinLauncher/WinLauncher.cpp:
2913         (dllLauncherEntryPoint):
2914         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2915         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2916
2917 2013-06-28  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2918
2919         Clean up temporary files created by the bindings test script
2920         https://bugs.webkit.org/show_bug.cgi?id=118189
2921
2922         Reviewed by Kentaro Hara.
2923
2924         Remove temporary files created by preprocess-idls.pl script after
2925         the bindings tests are executed.
2926
2927         Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
2928
2929         * Scripts/webkitpy/bindings/main.py:
2930         (BindingsTests.main):
2931
2932 2013-06-26  Dean Jackson  <dino@apple.com>
2933
2934         [Mac] Add Mavericks system font to Test systems
2935         https://bugs.webkit.org/show_bug.cgi?id=118109
2936
2937         Reviewed by Simon Fraser.
2938
2939         OS X Mavericks uses a different font for system controls. Tell DRT and
2940         WKTR about them otherwise they use a fallback font. Unfortunately the
2941         fonts are hidden (not found in the list of available fonts) so I
2942         had to add them manually.
2943
2944         Even though there is only one at the moment, I implemented this
2945         as a set so it will be easier to add new fonts if necessary.
2946
2947         * DumpRenderTree/mac/DumpRenderTree.mm:
2948         (allowedFontFamilySet): Fixed typo.
2949         (systemHiddenFontFamilySet): New method that returns the system control font.
2950         (drt_NSFontManager_availableFonts): Merge the hidden fonts.
2951         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2952         (WTR::allowedFontFamilySet): Fixed typo.
2953         (WTR::systemHiddenFontFamilySet): As above.
2954         (WTR::wtr_NSFontManager_availableFonts):
2955
2956 2013-06-27  Anders Carlsson  <andersca@apple.com>
2957
2958         Get rid of the last uses of deprecatedCharactersWithNullTermination()
2959         https://bugs.webkit.org/show_bug.cgi?id=118159
2960
2961         Reviewed by Andreas Kling.
2962
2963         Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
2964
2965         * DumpRenderTree/win/DumpRenderTree.cpp:
2966         (findFontFallback):
2967
2968 2013-06-27  Bem Jones-Bey  <bjonesbe@adobe.com>
2969
2970         Sync up w3c import script with changes in Blink
2971         https://bugs.webkit.org/show_bug.cgi?id=118149
2972
2973         Reviewed by Dirk Pranke.
2974
2975         This is a port of the following blink changes:
2976
2977         https://codereview.chromium.org/15366004
2978         https://chromiumcodereview.appspot.com/15592005
2979         https://codereview.chromium.org/16021006
2980         https://codereview.chromium.org/15590004
2981         https://codereview.chromium.org/15901008
2982         https://codereview.chromium.org/16171009
2983         https://codereview.chromium.org/16465007
2984         https://codereview.chromium.org/15981013
2985
2986         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2987         (setUp):
2988         (test_commit_message_for_this_commit):
2989         * Scripts/webkitpy/port/base.py:
2990         (Port):
2991         * Scripts/webkitpy/port/test.py:
2992         * Scripts/webkitpy/w3c/test_converter.py:
2993         (W3CTestConverter.__init__):
2994         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2995         (W3CTestConverter.convert_for_webkit):
2996         (W3CTestConverter.convert_css):
2997         (W3CTestConverter.convert_html):
2998         (W3CTestConverter.convert_testharness_paths):
2999         (W3CTestConverter.convert_prefixed_properties):
3000         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3001         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3002         * Scripts/webkitpy/w3c/test_importer.py:
3003         (main):
3004         (configure_logging):
3005         (configure_logging.LogHandler):
3006         (configure_logging.LogHandler.format):
3007         (parse_args):
3008         (TestImporter.__init__):
3009         (TestImporter.find_importable_tests):
3010         (TestImporter.import_tests):
3011         (TestImporter.setup_destination_directory):
3012         (TestImporter.remove_deleted_files):
3013         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3014         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3015         (TestImporterTest.test_import_dir_with_no_tests):
3016         (TestImporterTest):
3017         * Scripts/webkitpy/w3c/test_parser.py:
3018         (TestParser.load_file):
3019         (TestParser.analyze_test):
3020         (TestParser.support_files):
3021         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3022
3023 2013-06-27  Csaba Osztrogonác  <ossy@webkit.org>
3024
3025         [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3026         https://bugs.webkit.org/show_bug.cgi?id=118128
3027
3028         Reviewed by Ryosuke Niwa.
3029
3030         It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3031         https://bugs.webkit.org/show_bug.cgi?id=117831
3032
3033         * Scripts/webkitpy/tool/commands/download.py:
3034         (AbstractPatchSequencingCommand):
3035         (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3036         (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3037         (AbstractPatchSequencingCommand._prepare_state): Added.
3038
3039 2013-06-27  Brendan Long  <b.long@cablelabs.com>
3040
3041         [Qt] Build overrides -j when given --makeargs="-sj40"
3042         https://bugs.webkit.org/show_bug.cgi?id=116897
3043
3044         Reviewed by Csaba Osztrogonác.
3045
3046         * Scripts/webkitdirs.pm:
3047         (buildQMakeProjects):
3048         Change regex checking for -j* to also check for -*j*
3049
3050 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3051
3052         Remove [NoInterfaceObject] from WorkerGlobalScope
3053         https://bugs.webkit.org/show_bug.cgi?id=118071
3054
3055         Reviewed by Kentaro Hara.
3056
3057         Update bindings test script to pass 2 additional parameters
3058         now needed by the preprocess-idls.pl script.
3059
3060         * Scripts/webkitpy/bindings/main.py:
3061         (BindingsTests.generate_supplemental_dependency):
3062         (BindingsTests.main):
3063
3064 2013-06-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3065
3066         Fixing some compiler warnings
3067         https://bugs.webkit.org/show_bug.cgi?id=117791
3068
3069         Reviewed by Martin Robinson.
3070
3071         * GNUmakefile.am: Silenced format warning.
3072         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3073         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3074         Solved warning about uninitialized variable.
3075
3076 2013-06-27  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3077
3078         Fix bindings tests after r152080
3079         https://bugs.webkit.org/show_bug.cgi?id=118118
3080
3081         Reviewed by Gyuyoung Kim.
3082
3083         r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3084         to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3085         accordingly.
3086
3087         * Scripts/webkitpy/bindings/main.py:
3088         (BindingsTests.generate_supplemental_dependency):
3089         (BindingsTests.main):
3090
3091 2013-06-26  Carlos Garcia Campos  <cargarcia@blackberry.com>
3092
3093         [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3094         https://bugs.webkit.org/show_bug.cgi?id=117982
3095
3096         Reviewed by Rob Buis.
3097
3098         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3099         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3100         m_policyDelegateIsPermissive.
3101         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3102         Reset m_policyDelegateIsPermissive.
3103         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3104         m_policyDelegateIsPermissive.
3105         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3106         (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3107         Return whether custom policy is enabled.
3108         (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3109         Return whether custom policy is permissive.
3110
3111 2013-06-26  Anders Carlsson  <andersca@apple.com>
3112
3113         Deprecate StringImpl::charactersWithNullTermination
3114         https://bugs.webkit.org/show_bug.cgi?id=118108
3115
3116         Reviewed by Beth Dakin.
3117
3118         Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3119
3120         * DumpRenderTree/win/DumpRenderTree.cpp:
3121         (findFontFallback):
3122         (addFontFallbackIfPresent):
3123         (removeFontFallbackIfPresent):
3124
3125 2013-06-26  Nico Weber  <thakis@chromium.org>
3126
3127         Remove detect-mismached-virtual-const.
3128         https://bugs.webkit.org/show_bug.cgi?id=117999
3129
3130         Reviewed by Anders Carlsson.
3131
3132         Clang warns on mismatched virtual const, so there's no need for this
3133         script any more.
3134
3135         * Scripts/detect-mismatched-virtual-const: Removed.
3136
3137 2013-06-26  Alex Christensen  <achristensen@apple.com>
3138
3139         Added a code coverage report.
3140         https://bugs.webkit.org/show_bug.cgi?id=117941
3141
3142         Reviewed by Joseph Pecoraro.
3143
3144         * CodeCoverage: Added.
3145         * CodeCoverage/results-template.html: Added.
3146         * Scripts/generate-coverage-data: Generate and open the new report.
3147
3148 2013-06-25  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3149
3150         gdb: Remove the webcore.py pretty printer.
3151         https://bugs.webkit.org/show_bug.cgi?id=117992
3152
3153         Reviewed by Jochen Eisinger.
3154
3155         webcore.py has been only a placeholder for backwards compatibility
3156         for almost 3 years. It should be safe enough to remove it now.
3157
3158         * gdb/webcore.py: Removed.
3159
3160 2013-05-26  Peter Gal  <galpeter@inf.u-szeged.hu>
3161
3162         Creating cURL watchlist and adding myself to it.
3163
3164         Reviewed by Csaba Osztrogonác.
3165
3166         * Scripts/webkitpy/common/config/watchlist:
3167
3168 2013-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3169
3170         Unreviewed, change my email address for watch list.
3171
3172         * Scripts/webkitpy/common/config/watchlist:
3173
3174 2013-06-25  Byungwoo Lee  <bw80.lee@samsung.com>
3175
3176         [EFL] Add a script to install dependencies.
3177         https://bugs.webkit.org/show_bug.cgi?id=117968
3178
3179         Reviewed by Christophe Dumez.
3180
3181         Add a script which installs basic dependencies for building WebKit EFL.
3182
3183         The dependencies are from the current EFLWebKit wiki page.
3184         After this patch is landed, the wiki page will be updated to use
3185         this script.
3186
3187         * efl/install-dependencies: Added.
3188
3189 2013-06-24  Dean Jackson  <dino@apple.com>
3190
3191         [Mac] Update font used for Chinese in test systems
3192         https://bugs.webkit.org/show_bug.cgi?id=117970
3193
3194         Reviewed by Alexey Proskuryakov.
3195
3196         Add "Songti TC" and "Songti SC" to the list of allowed fonts
3197         in DRT and WKTR.
3198
3199         * DumpRenderTree/mac/DumpRenderTree.mm:
3200         (allowedFontFamilySet):
3201         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3202         (WTR::allowedFontFamilySet):
3203
3204 2013-06-24  Tim Horton  <timothy_horton@apple.com>
3205
3206         Make MiniBrowser paginated mode work with WebKit1
3207         https://bugs.webkit.org/show_bug.cgi?id=117950
3208
3209         Reviewed by Beth Dakin.
3210
3211         * MiniBrowser/mac/WK1BrowserWindowController.m:
3212         (-[WK1BrowserWindowController isPaginated]):
3213         (-[WK1BrowserWindowController togglePaginationMode:]):
3214         Hook up isPaginated and togglePaginationMode just as for WebKit2.
3215
3216 2013-06-24  David Kilzer  <ddkilzer@apple.com>
3217
3218         bisect-builds: improve heuristic for choosing the next build after a broken build
3219         <http://webkit.org/b/117918>
3220
3221         Reviewed by Simon Fraser.
3222
3223         * Scripts/bisect-builds: When a build is broken, use a heuristic
3224         that "bisects" the left side or the right side of the remaining
3225         revisions to pick a revision that's sufficiently different from
3226         the revision of the broken build.  This heuristic assumes there
3227         is a sequential range of broken builds whenever one broken build
3228         is found.
3229
3230 2013-06-24  Chris Rogers  <crogers@google.com>
3231
3232         WaveTable name has changed to PeriodicWave
3233         https://bugs.webkit.org/show_bug.cgi?id=117748
3234
3235         Reviewed by Jer Noble.
3236
3237         * Scripts/do-webcore-rename:
3238
3239 2013-06-22  Santosh Mahto  <santosh.ma@samsung.com>
3240
3241         [EFL] Add support for MHTML save/load feature to MiniBrowser
3242         https://bugs.webkit.org/show_bug.cgi?id=106620
3243
3244         Reviewed by Christophe Dumez.
3245
3246         Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3247         from filesystem.
3248
3249         * MiniBrowser/efl/CMakeLists.txt:
3250         * MiniBrowser/efl/main.c:
3251         (page_contents_callback):
3252         (on_key_down):
3253         (show_file_entry_dialog): generic function to show file enrty
3254         selector dialogue
3255
3256 2013-06-21  Brent Fulgham  <bfulgham@apple.com>
3257
3258         [Windows] Unreviewed crash protection for DRT
3259
3260         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3261         to avoid crashing during test runs.
3262
3263 2013-06-21  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3264
3265         REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3266         https://bugs.webkit.org/show_bug.cgi?id=117825
3267
3268         Reviewed by Kentaro Hara.
3269
3270         DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3271
3272         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3273         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3274         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3275         (TestRunner::overridePreference):
3276
3277 2013-06-21  Krzysztof Czech  <k.czech@samsung.com>
3278
3279         [ATK] Added support for aria-required attribute.
3280         https://bugs.webkit.org/show_bug.cgi?id=117730
3281
3282         Reviewed by Chris Fleizach.
3283
3284         Added support for testing aria-required attribute.
3285
3286         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3287         (AccessibilityUIElement::isRequired):
3288         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3289         (WTR::AccessibilityUIElement::isRequired):
3290
3291 2013-06-20  Ryuan Choi  <ryuan.choi@samsung.com>
3292
3293         [CMAKE][EFL] Enable DOM4 Events Constructor
3294         https://bugs.webkit.org/show_bug.cgi?id=117858
3295
3296         Reviewed by Laszlo Gombos.
3297
3298         * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3299
3300 2013-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3301
3302         [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3303         https://bugs.webkit.org/show_bug.cgi?id=117827
3304
3305         Reviewed by Rob Buis.
3306
3307         Reset the passed in request if willSendRequestReturnsNull() is
3308         true or willSendRequestReturnsNullOnRedirect() is true and it's a
3309         redirection.
3310
3311         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3312         (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3313         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3314
3315 2013-06-20  Csaba Osztrogonác  <ossy@webkit.org>
3316
3317         Commit queue shouldn't reopen unrelated bugs because of flakiness
3318         https://bugs.webkit.org/show_bug.cgi?id=117503
3319
3320         Reviewed by Ryosuke Niwa.
3321
3322         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3323         (_follow_duplicate_chain):
3324         (_update_bug_for_flaky_test):
3325
3326 2013-06-19  Brent Fulgham  <bfulgham@apple.com>
3327
3328         [Windows] AX: Expand notification support.
3329         https://bugs.webkit.org/show_bug.cgi?id=117761
3330
3331         Reviewed by Anders Carlsson.
3332
3333         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3334         (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3335         (AccessibilityUIElement::press): Provide implementation.
3336
3337 2013-06-19  Benjamin Poulain  <bpoulain@apple.com>
3338
3339         Use the PlatformEvent timestamp when creating a DOM Event
3340         https://bugs.webkit.org/show_bug.cgi?id=117179
3341
3342         Reviewed by Darin Adler.
3343
3344         * WebKitTestRunner/mac/EventSenderProxy.mm:
3345         (WTR::EventSenderProxy::mouseDown):
3346         (WTR::EventSenderProxy::mouseUp):
3347         (WTR::EventSenderProxy::mouseMoveTo):
3348         (WTR::EventSenderProxy::keyDown):
3349
3350 2013-06-18  Alex Christensen  <achristensen@apple.com>
3351
3352         Working on coverage script, added xml to json data extraction script.
3353         https://bugs.webkit.org/show_bug.cgi?id=117648
3354
3355         This is part of a new test code coverage analysis tool.  This compiles WebKit to generate
3356         coverage data, runs the tests, and collects all of the data in json format.
3357
3358         Reviewed by Stephanie Lewis.
3359
3360         * Scripts/generate-coverage-data:
3361         (parseGcovrOutput):
3362         (getFileHitsAndBranches):
3363         (addLineCounts):
3364         (createResultName):
3365         * Scripts/webkitpy/tool/gcovr: Added.
3366
3367 2013-06-18  Ryuan Choi  <ryuan.choi@samsung.com>
3368
3369         Unreviewed build fix after r151699.
3370
3371         * TestWebKitAPI/CMakeLists.txt:
3372         * WebKitTestRunner/CMakeLists.txt:
3373         Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3374
3375 2013-06-18  Roger Fong  <roger_fong@apple.com>
3376
3377         Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3378         <rdar://problem/14118143>.
3379
3380         Rubberstamped by Brent Fulgham.
3381
3382         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3383         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3384         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3385         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3386         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3387         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3388         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3389         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3390         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3391         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3392         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3393         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3394         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3395         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3396         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3397         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3398         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3399         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3400         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3401         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3402         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3403         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3404         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3405         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3406         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3407         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3408         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3409         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3410         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3411         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3412         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3413         * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3414         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3415         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3416         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3417         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3418         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3419         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3420         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3421         * win/record-memory/record-memory.vcxproj:
3422         * win/record-memory/record-memoryDebug.props:
3423         * win/record-memory/record-memoryDebugWinCairo.props:
3424         * win/record-memory/record-memoryProduction.props:
3425         * win/record-memory/record-memoryRelease.props:
3426         * win/record-memory/record-memoryReleaseWinCairo.props:
3427
3428 2013-06-17  Kangil Han  <kangil.han@samsung.com>
3429
3430         Unreviewed. Add my email to a DOM watchlist.
3431
3432         * Scripts/webkitpy/common/config/watchlist:
3433
3434 2013-06-17  Zan Dobersek  <zdobersek@igalia.com>
3435
3436         Unreviewed GTK gardening.
3437
3438         * Scripts/run-gtk-tests:
3439         (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3440
3441 2013-06-15  Bruno de Oliveira Abinader  <brunoabinader@gmail.com>
3442
3443         Unreviewed. Reorder my email addresses.
3444         https://bugs.webkit.org/show_bug.cgi?id=100122
3445
3446         * Scripts/webkitpy/common/config/contributors.json:
3447
3448 2013-06-14  Enrica Casucci  <enrica@apple.com>
3449
3450         WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3451         https://bugs.webkit.org/show_bug.cgi?id=117647
3452         <rdar://problem/13881024>
3453
3454         Reviewed by Darin Adler.
3455         
3456         The test now uses content with a selection and tests both
3457         forwards and backward find as well as the case of a find
3458         that has no matches after the user selection.
3459
3460         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3461         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3462         (TestWebKitAPI::didFindStringMatches):
3463         * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3464
3465 2013-06-14  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3466
3467         Remove myself from Qt build system watchlist
3468
3469         Reviewed by Simon Hausmann.
3470
3471         * Scripts/webkitpy/common/config/watchlist:
3472
3473 2013-06-13  Michael Brüning  <michael.bruning@digia.com>
3474
3475         [Qt][Mac] Disable QTKit video on OS X.
3476         https://bugs.webkit.org/show_bug.cgi?id=117591
3477
3478         Reviewed by Tor Arne Vestbø.
3479
3480         Deployment of Qt binaries to different Mac OS X
3481         platform version makes it impossible to link against
3482         the correct version of the WebKitSystemInterface library,
3483         so we need to disable QTKit for media elements.
3484
3485         * qmake/mkspecs/features/features.prf:
3486
3487 2013-06-13  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3488
3489         [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3490         https://bugs.webkit.org/show_bug.cgi?id=116610
3491
3492         Reviewed by Noam Rosenthal.
3493
3494         Remove unnecessary code adjusting context menu position to webview position.
3495         Now position is calculcated in EwkView.
3496
3497         * MiniBrowser/efl/main.c:
3498         (on_context_menu_show):
3499
3500 2013-06-12  Roger Fong  <roger_fong@apple.com>
3501
3502         Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3503
3504         * Scripts/webkitpy/common/config/ews.json:
3505
3506 2013-06-12  Eduardo Lima Mitev  <elima@igalia.com>
3507
3508         [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3509         https://bugs.webkit.org/show_bug.cgi?id=115647
3510
3511         Reviewed by Martin Robinson.
3512
3513         Locale resolution is moved to WebKitAccessibleWrapperAtk using
3514         AtkObject::get_object_locale() API. Now, implementation of
3515         AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3516         be leveraged to get_object_locale() of AtkObject.
3517
3518         Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3519         method.
3520
3521         No new functionality, no new tests.
3522
3523         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3524         (AccessibilityUIElement::language): Leverage locale resolution to
3525         AtkObject::get_object_locale().
3526         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3527         (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3528         AtkObject::get_object_locale().
3529
3530 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3531
3532         Remove last bits of GYP from build-webkit and update-webkit scripts
3533         https://bugs.webkit.org/show_bug.cgi?id=117557
3534
3535         Reviewed by Ryosuke Niwa.
3536
3537         * Scripts/build-webkit:
3538         * Scripts/update-webkit:
3539
3540 2013-06-12  Hugo Parente Lima  <hugo.lima@openbossa.org>
3541
3542         Remove forgotten unused Tools/Script/make-gypi script
3543         https://bugs.webkit.org/show_bug.cgi?id=117558
3544
3545         Reviewed by Ryosuke Niwa.
3546
3547         This script isn't used since the GYP removal from WebKit.
3548
3549         * Scripts/make-gypi: Removed.
3550
3551 2013-06-12  Andres Gomez  <agomez@igalia.com>
3552
3553         [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
3554         https://bugs.webkit.org/show_bug.cgi?id=117533
3555
3556         Reviewed by Carlos Garcia Campos.
3557
3558         MiniBrowser now starts automatically the download of the documents
3559         that cannot be shown just by WebKit itself on link left clicking.
3560
3561         * MiniBrowser/gtk/BrowserWindow.c:
3562         (webViewDecidePolicy): handled the
3563         WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
3564
3565 2013-06-12  Zan Dobersek  <zdobersek@igalia.com>
3566
3567         [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
3568         https://bugs.webkit.org/show_bug.cgi?id=116723
3569
3570         Reviewed by Carlos Garcia Campos.
3571
3572         * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
3573         remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
3574         and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
3575         not expensive and produces a working archive without problems even on incremental builds.
3576
3577 2013-06-11  Santosh Mahto  <santosh.ma@samsung.com>
3578
3579         [EFL] Window resize should close the popupmenu
3580         https://bugs.webkit.org/show_bug.cgi?id=117391
3581
3582         Reviewed by Christophe Dumez.
3583         
3584         Added the code to close the popup when main window is resized.
3585
3586         * MiniBrowser/efl/main.c:
3587         (on_window_resize):
3588
3589 2013-06-11  Alex Christensen  <achristensen@apple.com>
3590
3591         Removed old broken code coverage tool.
3592         https://bugs.webkit.org/show_bug.cgi?id=117520
3593
3594         Reviewed by Sam Weinig.
3595
3596         * CodeCoverage: Removed.
3597         * CodeCoverage/README: Removed.
3598         * CodeCoverage/amber.png: Removed.
3599         * CodeCoverage/cov.py: Removed.
3600         * CodeCoverage/emerald.png: Removed.
3601         * CodeCoverage/gcov.css: Removed.
3602         * CodeCoverage/glass.png: Removed.
3603         * CodeCoverage/regenerate-coverage-display: Removed.
3604         * CodeCoverage/ruby.png: Removed.
3605         * CodeCoverage/run-generate-coverage-data: Removed.
3606         * CodeCoverage/snow.png: Removed.
3607
3608 2013-06-11  Timothy Hatcher  <timothy@apple.com>
3609
3610         Have build-webkit build the WebInspectorUI project.
3611
3612         * Scripts/build-webkit:
3613
3614 2013-06-11  Ryosuke Niwa  <rniwa@webkit.org>
3615
3616         Add an option to run-webkit-tests to skip java dependency check
3617         https://bugs.webkit.org/show_bug.cgi?id=117516
3618
3619         Reviewed by Andreas Kling.
3620
3621         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3622         (parse_args):
3623         * Scripts/webkitpy/port/mac.py:
3624         (MacPort._check_port_build):
3625
3626 2013-06-11  Alex Christensen  <achristensen@apple.com>
3627
3628         https://bugs.webkit.org/show_bug.cgi?id=117514
3629         Removed extra Xcode code coverage flags.
3630
3631         Reviewed by Sam Weinig.
3632
3633         * Scripts/webkitdirs.pm:
3634         (XcodeCoverageSupportOptions):
3635
3636 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
3637
3638         [Windows] Implement 'attributeValue' accessor to support testing
3639         https://bugs.webkit.org/show_bug.cgi?id=117513
3640
3641         Reviewed by Anders Carlsson.
3642
3643         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3644         (comparableObject): Move earlier in file.
3645         (findAccessibleObjectById): New implemenation.
3646         (AccessibilityController::accessibleElementById): New implementation.
3647
3648 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
3649
3650         Make WTR use its own temporary directory for application cache
3651         https://bugs.webkit.org/show_bug.cgi?id=117143
3652
3653         Reviewed by Alexey Proskuryakov.
3654
3655         * WebKitTestRunner/TestController.cpp:
3656         (WTR::TestController::initialize):
3657
3658 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
3659
3660         https://bugs.webkit.org/show_bug.cgi?id=117449
3661         Remove dead code for storing fonts in __DATA section
3662
3663         Reviewed by Dan Bernstein.
3664
3665         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3666         Don't copy font resources to __DATA, as we don't have any code that reads them
3667         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").