Use xcrun to find compiler paths for Generate Derived Sources build phase script
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-24  David Kilzer  <ddkilzer@apple.com>
2
3         Use xcrun to find compiler paths for Generate Derived Sources build phase script
4         <http://webkit.org/b/79512>
5
6         Reviewed by Dan Bernstein.
7
8         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9         (Generate Derived Sources): Use xcrun to find the path to the
10         compiler since that works on both iOS and OS X.
11
12 2012-02-24  James Robinson  <jamesr@chromium.org>
13
14         Create a watchlist for ScrollingCoordinator changes
15         https://bugs.webkit.org/show_bug.cgi?id=79511
16
17         Reviewed by Anders Carlsson.
18
19         * Scripts/webkitpy/common/config/watchlist:
20
21 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
22
23         [EFL][DRT] Implement setValueForUser and setAutofilled.
24         https://bugs.webkit.org/show_bug.cgi?id=79237
25
26         Reviewed by Andreas Kling.
27
28         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
29         Those implementations are related with input fields and allow to pass following tests:
30         fast/forms/onchange-setvalueforuser.html
31         fast/forms/input-autofilled.html
32         fast/forms/reset-autofilled.html
33
34         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
35         (LayoutTestController::setValueForUser):
36         (LayoutTestController::setAutofilled):
37
38 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
39
40         [Qt] Allow to use WebCore imagedecoders
41         https://bugs.webkit.org/show_bug.cgi?id=32410
42
43         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
44
45         Reviewed by Simon Hausmann.
46
47         * qmake/mkspecs/features/features.prf:
48
49 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
50
51         [Qt] Add Qt5 way to force 96 DPI for tests
52         https://bugs.webkit.org/show_bug.cgi?id=79364
53
54         Reviewed by Simon Hausmann.
55
56         * DumpRenderTree/qt/main.cpp:
57         (main):
58         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
59         (WTR::activateFonts):
60
61 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
62
63         [GTK] MiniBrowser should reload the view then the reload button is clicked
64         https://bugs.webkit.org/show_bug.cgi?id=79472
65
66         Reviewed by Philippe Normand.
67
68         * MiniBrowser/gtk/BrowserWindow.c:
69         (reloadCallback): Call webkit_web_view_reload().
70         (browser_window_init): Connect reload item clicked even to
71         reloadCallback instead of activateUriEntryCallback.
72
73 2012-02-24  Kentaro Hara  <haraken@chromium.org>
74
75         Add performance tests for DOM attribute getters and setters
76         https://bugs.webkit.org/show_bug.cgi?id=79208
77
78         Reviewed by Ryosuke Niwa.
79
80         We want to allow perf tests to output info messages
81         that do not affect the test results. To accomplish this,
82         this patch modifies perftestsrunner.py so that it ignores
83         a line that starts from "Info:".
84
85         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
86         (PerfTestsRunner):
87
88 2012-02-24  Andrew Lo  <anlo@rim.com>
89
90         [BlackBerry] Enable requestAnimationFrame
91         https://bugs.webkit.org/show_bug.cgi?id=79408
92
93         Enable requestAnimationFrame for BlackBerry.
94
95         Reviewed by Rob Buis.
96
97         * Scripts/build-webkit:
98
99 2012-02-24  Adam Barth  <abarth@webkit.org>
100
101         style-queue tries to apply the patch twice
102         https://bugs.webkit.org/show_bug.cgi?id=79459
103
104         Reviewed by Eric Seidel.
105
106         Previously, we applied the patch using both apply-patch and
107         check-style.  This patch introduces a check-style-local to mirror the
108         apply-watchlist-local, which operates on the current working diff.
109
110         This patch also cleans up some other bugs I found by running the queue
111         locally for a while.  The queue still prints out a slightly
112         less-than-ideal message on the bugs when it find an error, but it's ok
113         for now.  We'll need to iterate a bit.
114
115         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
116         (StyleQueueTask.validate):
117         (StyleQueueTask._check_style):
118         * Scripts/webkitpy/tool/commands/download.py:
119         (CheckStyleLocal):
120         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
121         (EarlyWarningSytemTest._default_expected_stderr):
122         (EarlyWarningSytemTest._test_testing_ews):
123         * Scripts/webkitpy/tool/commands/queues.py:
124         (AbstractReviewQueue.handle_script_error):
125         (StyleQueue.review_patch):
126         * Scripts/webkitpy/tool/commands/queues_unittest.py:
127         * Scripts/webkitpy/tool/commands/queuestest.py:
128         (QueuesTest.assert_queue_outputs):
129
130 2012-02-23  Adam Barth  <abarth@webkit.org>
131
132         should_proceed_with_work_item is unused and can be removed
133         https://bugs.webkit.org/show_bug.cgi?id=79416
134
135         Reviewed by Eric Seidel.
136
137         We used to use this function to check whether the tree is red.  Now, we
138         don't use external measures of whether to proceed with work items.
139         Instead, we analyze them with the idea in mind that the tree might be
140         red.
141
142         * Scripts/webkitpy/tool/bot/queueengine.py:
143         (QueueEngineDelegate.next_work_item):
144         (QueueEngine.run):
145         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
146         (LoggingDelegate):
147         (LoggingDelegate.next_work_item):
148         (RaisingDelegate.process_work_item):
149         (QueueEngineTest.test_terminating_error):
150         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
151         (AbstractEarlyWarningSystem.__init__):
152         * Scripts/webkitpy/tool/commands/queues.py:
153         (AbstractQueue.next_work_item):
154         (FeederQueue.next_work_item):
155         (CommitQueue.next_work_item):
156         (AbstractReviewQueue.next_work_item):
157         (StyleQueue.__init__):
158         * Scripts/webkitpy/tool/commands/queues_unittest.py:
159         (FeederQueueTest.test_feeder_queue):
160         (CommitQueueTest.test_commit_queue):
161         (test_commit_queue_failure):
162         (test_commit_queue_failure_with_failing_tests):
163         (test_rollout):
164         (test_rollout_lands):
165         (StyleQueueTest.test_style_queue_with_style_exception):
166         (test_style_queue_with_watch_list_exception):
167         * Scripts/webkitpy/tool/commands/queuestest.py:
168         (QueuesTest.assert_queue_outputs):
169         * Scripts/webkitpy/tool/commands/sheriffbot.py:
170         (SheriffBot.next_work_item):
171
172 2012-02-23  Adrienne Walker  <enne@google.com>
173
174         Unreviewed, add Stephen Chenney to committers.py as a contributor.
175
176         * Scripts/webkitpy/common/config/committers.py:
177
178 2012-02-23  Adam Barth  <abarth@webkit.org>
179
180         style-queue logs bogus messages to the QueueStatusServer
181         https://bugs.webkit.org/show_bug.cgi?id=79424
182
183         Reviewed by Eric Seidel.
184
185         Copy/paste error.
186
187         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
188         (StyleQueueTask._check_style):
189         (StyleQueueTask._apply_watch_list):
190         * Scripts/webkitpy/tool/commands/queues_unittest.py:
191
192 2012-02-23  Eric Seidel  <eric@webkit.org>
193
194         Use self._filesystem in more places in the SCM classes
195         https://bugs.webkit.org/show_bug.cgi?id=79415
196
197         Reviewed by Adam Barth.
198
199         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
200         (SCMDetectorTest.test_detect_scm_system):
201         * Scripts/webkitpy/common/checkout/scm/git.py:
202         (Git.find_checkout_root):
203         (Git.to_object_name):
204         * Scripts/webkitpy/common/checkout/scm/scm.py:
205         (SCM.__init__):
206         (SCM.in_working_directory):
207         * Scripts/webkitpy/common/checkout/scm/svn.py:
208         (SVN.find_uuid):
209         (SVN.find_checkout_root):
210
211 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
212
213         Unreviewed, rolling out r108685.
214         http://trac.webkit.org/changeset/108685
215         https://bugs.webkit.org/show_bug.cgi?id=79414
216
217         Broke Chromium builds (Requested by enne on #webkit).
218
219         * qmake/mkspecs/features/features.prf:
220
221 2012-02-23  Adam Barth  <abarth@webkit.org>
222
223         style-queue shouldn't spam bugs if it fails to update its working copy
224         https://bugs.webkit.org/show_bug.cgi?id=79412
225
226         Reviewed by Eric Seidel.
227
228         This patch moves style-queue over to the new PatchAnalysisTask
229         infrastructure, which is smarter about retrying patches when update
230         fails.
231
232         * Scripts/webkitpy/common/system/executive_mock.py:
233         (MockExecutive.run_and_throw_if_fail):
234         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
235         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
236         (UnableToApplyPatch):
237         (UnableToApplyPatch.__init__):
238         (PatchAnalysisTask.__init__):
239         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
240         (StyleQueueTaskDelegate):
241         (StyleQueueTaskDelegate.parent_command):
242         (StyleQueueTask):
243         (StyleQueueTask.validate):
244         (StyleQueueTask._check_style):
245         (StyleQueueTask._apply_watch_list):
246         (StyleQueueTask.run):
247         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
248         * Scripts/webkitpy/tool/commands/queues.py:
249         (StyleQueue):
250         (StyleQueue.should_proceed_with_work_item):
251         (StyleQueue.review_patch):
252         (StyleQueue.run_command):
253         (StyleQueue.command_passed):
254         (StyleQueue.command_failed):
255         (StyleQueue.expected_failures):
256         (StyleQueue.refetch_patch):
257         * Scripts/webkitpy/tool/commands/queues_unittest.py:
258         (StyleQueueTest.test_style_queue_with_style_exception):
259         (test_style_queue_with_watch_list_exception):
260
261 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
262
263         [Qt] Allow to use WebCore imagedecoders
264         https://bugs.webkit.org/show_bug.cgi?id=32410
265
266         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
267
268         Reviewed by Simon Hausmann.
269
270         * qmake/mkspecs/features/features.prf:
271
272 2012-02-23  Eric Seidel  <eric@webkit.org>
273
274         Remove old broken find_checkout_root tests now that find_checkout_root is gone
275         https://bugs.webkit.org/show_bug.cgi?id=79405
276
277         Reviewed by Adam Barth.
278
279         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
280         (SCMDetectorTest):
281         (SCMDetectorTest.test_find_checkout_root):
282         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
283         (SVNTestRepository.tear_down):
284
285 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
286
287         [Qt][WK2] Implement proxy authentication dialog.
288         https://bugs.webkit.org/show_bug.cgi?id=79350
289
290         Reviewed by Simon Hausmann.
291
292         * MiniBrowser/qt/MiniBrowser.qrc:
293         * MiniBrowser/qt/qml/BrowserWindow.qml:
294         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
295
296 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
297
298         [wx] Build fix, add recently added source dirs.
299
300         * waf/build/settings.py:
301
302 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
303
304         [Qt] Add support for touch cancellation
305         https://bugs.webkit.org/show_bug.cgi?id=79348
306
307         Reviewed by Kenneth Rohde Christiansen.
308
309         Added straight-forward touch cancellation event sending to Qt WK1 DRT
310         and WK2 WTR.
311
312         * DumpRenderTree/qt/EventSenderQt.cpp:
313         (EventSender::touchCancel):
314         (EventSender::cancelTouchPoint):
315         * DumpRenderTree/qt/EventSenderQt.h:
316         (EventSender):
317         * WebKitTestRunner/EventSenderProxy.h:
318         (EventSenderProxy):
319         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
320         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
321         (WTR::EventSendingController::touchCancel):
322         (WTR):
323         (WTR::EventSendingController::cancelTouchPoint):
324         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
325         (EventSendingController):
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
328         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
329         (WTR::EventSenderProxy::touchCancel):
330         (WTR):
331         (WTR::EventSenderProxy::cancelTouchPoint):
332
333 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
334
335         Unreviewed, rolling out r108626.
336         http://trac.webkit.org/changeset/108626
337         https://bugs.webkit.org/show_bug.cgi?id=79370
338
339         broke qt-wk2 bot, somehow the workaround does not work on the
340         bot (Requested by Ossy on #webkit).
341
342         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
343         (WTR::WrapperWindow::handleStatusChanged):
344         (WTR::PlatformWebView::resizeTo):
345
346 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
347
348         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
349         https://bugs.webkit.org/show_bug.cgi?id=78481
350
351         Reviewed by Gustavo Noronha Silva.
352
353         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
354         to create gdk press key event.
355         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
356         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
357
358         * DumpRenderTree/gtk/EventSender.cpp:
359         (scheduleAsynchronousClickCallback):
360         (createKeyPressEvent):
361         (sendKeyDown):
362         (keyDownCallback):
363         (sendAsynchronousKeyDown):
364         (scheduleAsynchronousKeyDownCallback):
365
366 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
367
368         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
369         https://bugs.webkit.org/show_bug.cgi?id=76546
370
371         Reviewed by Simon Hausmann.
372
373         Co-authored with Simon Hausmann.
374
375         Revert the workaround introduced in r107868 and reintroduce
376         the qml binding so we can test the code path that we are more
377         interested in. The reason that it did not work before is that
378         we don't have an active platform window which we now workaround
379         by propagating the resize through QWindowSystemInterface.
380
381         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
382         (WTR::WrapperWindow::handleStatusChanged):
383         (WTR::PlatformWebView::resizeTo):
384
385 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
386
387         Unreviewed, rolling out r108577.
388         http://trac.webkit.org/changeset/108577
389         https://bugs.webkit.org/show_bug.cgi?id=79359
390
391         It doesn't work as expected (Requested by Ossy on #webkit).
392
393         * DumpRenderTree/qt/EventSenderQt.cpp:
394         (EventSender::postEvent):
395         * DumpRenderTree/qt/EventSenderQt.h:
396         (EventSender):
397
398 2012-02-23  Philippe Normand  <pnormand@igalia.com>
399
400         [GTK] FullScreen signals
401         https://bugs.webkit.org/show_bug.cgi?id=76181
402
403         Reviewed by Martin Robinson.
404
405         Use the two new entering/leaving fullscreen signals to hide/show
406         the tool bar, the status bar and ask the user's permission before
407         entering fullscreen.
408
409         * GtkLauncher/main.c:
410         (webViewFullscreenMessageWindowClose):
411         (webViewWindowStateEvent):
412         (hide_widget):
413         (show_widget):
414         (webViewEnteringFullScreen):
415         (webViewLeavingFullScreen):
416         (createBrowser):
417         (createWindow):
418
419 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
420
421         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
422         https://bugs.webkit.org/show_bug.cgi?id=79076
423
424         Reviewed by Andreas Kling.
425
426         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
427         (builtDylibPathForName):
428
429 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
430
431         [Qt] Add eventSender.gestureTap
432         https://bugs.webkit.org/show_bug.cgi?id=66173
433
434         Reviewed by Kenneth Rohde Christiansen.
435
436         * DumpRenderTree/qt/EventSenderQt.cpp:
437         (EventSender::gestureTap):
438         * DumpRenderTree/qt/EventSenderQt.h:
439
440 2012-02-22  Brady Eidson  <beidson@apple.com>
441
442         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
443         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
444
445         Reviewed by Anders Carlsson.
446
447         Update our tools to the new form of the PageLoadClient.
448
449         * MiniBrowser/mac/BrowserWindowController.m:
450         (-[BrowserWindowController awakeFromNib]): 
451
452         * WebKitTestRunner/TestController.cpp:
453         (WTR::TestController::initialize):
454
455 2012-02-22  Daniel Bates  <dbates@webkit.org>
456
457         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
458         https://bugs.webkit.org/show_bug.cgi?id=79277
459
460         Reviewed by Adam Barth.
461
462         Pass command line argument no-saved-state to run-safari to disable Safari
463         state restoration for the session on OS 10.7.
464
465         * Scripts/webkitpy/layout_tests/port/mac.py:
466         (MacPort.show_results_html_file):
467         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
468         (test_show_results_html_file):
469
470 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
471
472         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
473         https://bugs.webkit.org/show_bug.cgi?id=77759
474
475         Reviewed by Tony Chang.
476
477         Fixes build with gcc 4.7.
478
479         r100432 added the include only for ANDROID; this changes the ifdef to
480         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
481         longer implicitly includes unistd.h from standard headers and other
482         unix platforms are likely to get gcc 4.7 as well in the future.
483
484         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
485
486 2012-02-22  Philippe Normand  <pnormand@igalia.com>
487
488         Unreviewed, rolling out r108522.
489         http://trac.webkit.org/changeset/108522
490         https://bugs.webkit.org/show_bug.cgi?id=76181
491
492         Broke 4 fullscreen tests on GTK.
493
494         * GtkLauncher/main.c:
495         (createBrowser):
496         (createWindow):
497
498 2012-02-20  Philippe Normand  <pnormand@igalia.com>
499
500         [GTK] FullScreen signals
501         https://bugs.webkit.org/show_bug.cgi?id=76181
502
503         Reviewed by Martin Robinson.
504
505         Use the two new entering/leaving fullscreen signals to hide/show
506         the tool bar, the status bar and ask the user's permission before
507         entering fullscreen.
508
509         * GtkLauncher/main.c:
510         (webViewFullscreenMessageWindowClose):
511         (webViewWindowStateEvent):
512         (hide_widget):
513         (show_widget):
514         (webViewEnteringFullScreen):
515         (webViewLeavingFullScreen):
516         (createBrowser):
517         (createWindow):
518
519 2012-02-22  Rob Flack  <flackr@chromium.org>
520
521         Update Linux ChromiumOS builders in flakiness dashboard.
522         https://bugs.webkit.org/show_bug.cgi?id=79238
523
524         Reviewed by Ojan Vafai.
525
526         * TestResultServer/static-dashboards/builders.js:
527
528 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
529
530         webkitpy: test_function_length_check_definition_huge_lines is slow
531         https://bugs.webkit.org/show_bug.cgi?id=79185
532
533         Reviewed by Adam Barth.
534
535         This test takes ~3 seconds to run, apparently because we're
536         running a test on a 10,000 line function :). Dropping the
537         function length to 640 still exercises the code path and
538         provides a 10x speedup.
539
540         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
541         (CppStyleTest):
542         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
543
544 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
545
546         webkitpy: speed up FileLockTest.test_lock_lifecycle
547         https://bugs.webkit.org/show_bug.cgi?id=79189
548
549         Reviewed by Adam Barth.
550
551         The unit test had a second lock trying to acquire a
552         lock already held, and a hard-coded timeout of one second.
553         I have changed the timeouts to a tenth of a second (which
554         is probably still fine) and changed the hard-spin on
555         the lock to a slow-spin every hundredth of a second.
556
557         * Scripts/webkitpy/common/system/file_lock.py:
558         (FileLock.acquire_lock):
559         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
560         (FileLockTest.setUp):
561         (FileLockTest.test_stuck_lock):
562
563 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
564
565         build-webkit should use environment variable at number of CPU
566         detection on all platform
567         https://bugs.webkit.org/show_bug.cgi?id=79227
568
569         Reviewed by Martin Robinson.
570
571         * Scripts/webkitdirs.pm:
572         (determineNumberOfCPUs):
573
574 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
575
576         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
577         https://bugs.webkit.org/show_bug.cgi?id=78960
578
579         Reviewed by Csaba Osztrogonác.
580
581         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
582         (LayoutTestController::overridePreference):
583
584 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
585
586         [chromium] Build WebKit with MEDIA_STREAM disabled.
587         https://bugs.webkit.org/show_bug.cgi?id=79214
588
589         Reviewed by Kent Tamura.
590
591         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
592         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
593         * DumpRenderTree/chromium/WebViewHost.cpp:
594         (WebViewHost::createMediaPlayer):
595         * DumpRenderTree/chromium/WebViewHost.h:
596         (WebViewHost):
597
598 2012-02-22  Zeno Albisser  <zeno@webkit.org>
599
600         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
601         https://bugs.webkit.org/show_bug.cgi?id=79124
602
603         WebKitTestRunnerPrefix.h should also be included
604         when building with clang.
605
606         Reviewed by Kenneth Rohde Christiansen.
607
608         * WebKitTestRunner/Target.pri:
609
610 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
611
612         <style scoped>: Add runtime-flag
613         https://bugs.webkit.org/show_bug.cgi?id=79074
614
615         Enable the runtime-flag for DRT. 
616
617         Reviewed by Dimitri Glazkov.
618
619         * DumpRenderTree/chromium/TestShell.cpp:
620         (TestShell::TestShell):
621
622 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
623
624         Unreviewed, rolling out r107351.
625         http://trac.webkit.org/changeset/107351
626         https://bugs.webkit.org/show_bug.cgi?id=53600
627
628         Several issues introduced in WebKitGTK+ API
629
630         * DumpRenderTree/gtk/DumpRenderTree.cpp:
631         (createWebView):
632         * GtkLauncher/main.c:
633         (createWebViewCb):
634         (createBrowser):
635         (createWindow):
636         (main):
637
638 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
639
640         JSC should be a triple-tier VM
641         https://bugs.webkit.org/show_bug.cgi?id=75812
642         <rdar://problem/10079694>
643
644         Reviewed by Gavin Barraclough.
645
646         Changed EFL's build system to include a new directory in JavaScriptCore.
647
648         * DumpRenderTree/efl/CMakeLists.txt:
649
650 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
651
652         [chromium] Fix image drag out on Chromium
653         https://bugs.webkit.org/show_bug.cgi?id=79158
654
655         Reviewed by Tony Chang.
656
657         * DumpRenderTree/chromium/EventSender.cpp:
658         (EventSender::dumpFilenameBeingDragged):
659         (EventSender::beginDragWithFiles):
660         * DumpRenderTree/chromium/WebViewHost.cpp:
661         (addDRTFakeFileToDataObject):
662
663 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
664
665         webkitpy: speed up hot filesystem_mock functions
666         https://bugs.webkit.org/show_bug.cgi?id=79159
667
668         Reviewed by Adam Barth.
669
670         Profiling run_webkit_tests_integrationtest.py revealed that
671         isdir(), normpath(), and join() are called a lot and were very
672         slow.This patch speeds them up substantially, shaving 20 seconds
673         off of the execution time.
674
675         * Scripts/webkitpy/common/system/filesystem_mock.py:
676         (MockFileSystem.isdir):
677         (MockFileSystem._slow_but_correct_join):
678         (MockFileSystem.join):
679         (MockFileSystem.listdir):
680         (MockFileSystem._slow_but_correct_normpath):
681         (MockFileSystem.normpath):
682         (MockFileSystem.write_binary_file):
683         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
684         (MockFileSystemTest.quick_check):
685         (MockFileSystemTest):
686         (MockFileSystemTest.test_join):
687         (MockFileSystemTest.test_normpath):
688         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
689         (get_test_config): Call write_binary_file() instead of updating
690           filesystem.files directly, so that we create directories as
691           needed.
692
693 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
694
695         nrwt: make the delay between starting workers configurable per-port
696         https://bugs.webkit.org/show_bug.cgi?id=79148
697
698         Reviewed by Eric Seidel.
699
700         Because of bug 79147, we have to sleep a bit in between starting
701         DRTs; however, doing so across the board slows down the Test
702         port. Making this configurable shaves 10 seconds off of
703         run_webkit_tests_integrationtest.py
704         
705         * Scripts/webkitpy/layout_tests/controllers/manager.py:
706         (Manager._run_tests):
707         * Scripts/webkitpy/layout_tests/port/base.py:
708         (Port.worker_startup_delay_secs):
709         * Scripts/webkitpy/layout_tests/port/test.py:
710         (TestPort.worker_startup_delay_secs):
711
712 2012-02-21  Jon Lee  <jonlee@apple.com>
713
714         Bring notifications support to WK1 mac
715         https://bugs.webkit.org/show_bug.cgi?id=78783
716         <rdar://problem/10610578>
717
718         Reviewed by Anders Carlsson.
719
720         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
721         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
722         (-[UIDelegate timerFired]):
723
724 2012-02-21  Kentaro Hara  <haraken@chromium.org>
725
726         Enable the IDL attribute checker in run-bindings-tests
727         https://bugs.webkit.org/show_bug.cgi?id=79091
728
729         Reviewed by Adam Barth.
730
731         We have enabled the IDL attribute checker in Chromium in r108322.
732         This patch enables the IDL attribute checker in run-bindings-tests.
733
734         No tests. I manually checked that [Custommm], [CallWith=],
735         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
736         run-bindings-tests failures.
737
738         * Scripts/webkitpy/bindings/main.py:
739         (BindingsTests.generate_supplemental_dependency):
740
741 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
742
743         Add rafaelw as a committer.
744
745         Unreviewed.
746
747         * Scripts/webkitpy/common/config/committers.py:
748
749 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
750
751         webkitpy: update names after deleting message_broker
752         https://bugs.webkit.org/show_bug.cgi?id=79000
753
754         Reviewed by Eric Seidel.
755
756         Part 3 of 3 in deleting message_broker.py; this change just
757         adjusts the names for the newly merged symbols so that they are
758         private as appropriate.
759
760         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
761         (get):
762         (_Broker):
763         (_BrokerConnection):
764         (_BrokerConnection.__init__):
765         (AbstractWorker.__init__):
766         (_ManagerConnection):
767         (_ManagerConnection.__init__):
768         (_WorkerConnection):
769         (_WorkerConnection.__init__):
770
771 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
772
773         webkitpy: merge message_broker.py into manager_worker_broker.py
774         https://bugs.webkit.org/show_bug.cgi?id=78999
775
776         Reviewed by Tony Chang.
777
778         This is pretty much a straight cut-and-paste of one file into
779         another (broken up so that docstrings and imports are in the
780         right place).
781
782         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
783         (BrokerClient):
784         (BrokerClient.is_done):
785         (BrokerClient.name):
786         (Broker):
787         (Broker.__init__):
788         (Broker.add_topic):
789         (Broker._get_queue_for_topic):
790         (Broker.post_message):
791         (Broker.run_message_loop):
792         (Broker.run_all_pending):
793         (Broker._run_loop):
794         (Broker._dispatch_message):
795         (_Message):
796         (_Message.loads):
797         (_Message.__init__):
798         (_Message.dumps):
799         (_Message.__repr__):
800         (BrokerConnection):
801         (BrokerConnection.__init__):
802         (BrokerConnection.run_message_loop):
803         (BrokerConnection.post_message):
804         (BrokerConnection.raise_exception):
805         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
806
807 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
808
809         webkitpy: prepare to delete message_broker.py
810         https://bugs.webkit.org/show_bug.cgi?id=78997
811
812         Reviewed by Eric Seidel.
813
814         This is part 1 of 3 changes to fix bug 78187. This change
815         prepares the code for merging message_broker.py into
816         manager_worker_broker.py; the tests in message_broker_unittest
817         are merged into manager_worker_broker_unittest, the symbols
818         needed by the tests are exported from manager_worker_broker.py,
819         and manager_worker_broker itself is updated to refer to the
820         symbols directly (without the module prefix).
821
822         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
823         (get):
824         (AbstractWorker):
825         (AbstractWorker.__init__):
826         (_ManagerConnection):
827         (_ManagerConnection.__init__):
828         (_WorkerConnection):
829         (_WorkerConnection.__init__):
830         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
831         (InterfaceTest.test_brokerclient_is_abstract):
832         (InterfaceTest.test_brokerclient_is_abstract.methods):
833         (MessageTest):
834         (MessageTest.test__no_body):
835         (MessageTest.test__body):
836         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
837
838 2012-02-21  Sam Weinig  <sam@webkit.org>
839
840         Attempt to fix the Snow Leopard build.
841
842         * DumpRenderTree/mac/Configurations/Base.xcconfig:
843         * MiniBrowser/Configurations/Base.xcconfig:
844         * TestWebKitAPI/Configurations/Base.xcconfig:
845         * WebKitTestRunner/Configurations/Base.xcconfig:
846
847 2012-02-21  Sam Weinig  <sam@webkit.org>
848
849         Use libc++ when building with Clang on Mac
850         https://bugs.webkit.org/show_bug.cgi?id=78981
851
852         Reviewed by Dan Bernstein.
853
854         * DumpRenderTree/mac/Configurations/Base.xcconfig:
855         * MiniBrowser/Configurations/Base.xcconfig:
856         * TestWebKitAPI/Configurations/Base.xcconfig:
857         * WebKitTestRunner/Configurations/Base.xcconfig:
858
859 2012-02-21  Adam Roben  <aroben@apple.com>
860
861         Roll out r108309, r108323, and r108326
862
863         They broke the 32-bit Lion build.
864
865         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
866
867         * DumpRenderTree/efl/CMakeLists.txt:
868
869 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
870
871         [Qt][WK2] Get rid of the dependency to QtWidgets
872         https://bugs.webkit.org/show_bug.cgi?id=76276
873
874         Reviewed by Simon Hausmann.
875
876         * MiniBrowser/qt/MiniBrowser.pro:
877         * MiniBrowser/qt/MiniBrowserApplication.cpp:
878         (MiniBrowserApplication::MiniBrowserApplication):
879         (MiniBrowserApplication::notify):
880         (MiniBrowserApplication::sendTouchEvent):
881         * MiniBrowser/qt/MiniBrowserApplication.h:
882         (MiniBrowserApplication):
883         * QtTestBrowser/locationedit.h:
884         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
885         (WTR::activateFonts):
886         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
887
888 2012-02-20  Adam Barth  <abarth@webkit.org>
889
890         mastercfg_unittest.py fails without simplejson
891         https://bugs.webkit.org/show_bug.cgi?id=79070
892
893         Reviewed by Csaba Osztrogonác.
894
895         Now that we require Python 2.6 (and higher) we can import json rather
896         than simplejson.  We still need to use the simplejson name because
897         that's what the master.cfg script expects.
898
899         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
900         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
901
902 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
903
904         JSC should be a triple-tier VM
905         https://bugs.webkit.org/show_bug.cgi?id=75812
906         <rdar://problem/10079694>
907
908         Reviewed by Gavin Barraclough.
909
910         Changed EFL's build system to include a new directory in JavaScriptCore.
911
912         * DumpRenderTree/efl/CMakeLists.txt:
913
914 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
915
916         Update pywebsocket to 0.7.2
917         https://bugs.webkit.org/show_bug.cgi?id=79066
918
919         This version includes vendor-prefixed deflate-frame extension support.
920
921         Reviewed by Kent Tamura.
922
923         * Scripts/webkitpy/thirdparty/__init__.py:
924         (AutoinstallImportHook._install_pywebsocket):
925
926 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
927
928         [UNIX] Plugin information fields are not interpreted as UTF-8
929         https://bugs.webkit.org/show_bug.cgi?id=78635
930
931         Reviewed by Gustavo Noronha Silva.
932
933         Interpret plugin metadata as UTF8 aways. This matches the behavior
934         of Chromium and the Totem plugin.
935
936         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
937         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
938
939 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
940
941         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
942         https://bugs.webkit.org/show_bug.cgi?id=78935
943
944         Reviewed by Gustavo Noronha Silva.
945
946         Move the TestNetscapePlugin headers to a more appropriate directory and update
947         the build files to match.
948
949         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
950         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
951         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
952         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
953         * GNUmakefile.am: Ditto.
954
955 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
956
957         Add a new API for the Vibration API(W3C).
958         https://bugs.webkit.org/show_bug.cgi?id=72010
959
960         Reviewed by Hajime Morita.
961
962         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
963
964 2012-02-20  János Badics  <dicska@gmail.com>
965
966         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
967         https://bugs.webkit.org/show_bug.cgi?id=71816
968
969         RunQtAPITests will notify if a timeout occurs during testing.
970         Added unittest to the master.cfg
971
972         Reviewed by Csaba Osztrogonác.
973
974         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
975         (RunQtAPITests.evaluateCommand):
976         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
977         (RunQtAPITestsTest):
978         (RunQtAPITestsTest.assertResults):
979         (RunQtAPITestsTest.test_timeout):
980         (test_success):
981         (test_failure):
982         (test_timeout_and_failure):
983
984 2012-02-20  Andy Wingo  <wingo@igalia.com>
985
986         Add wingo as a committer.
987
988         Unreviewed.
989
990         * Scripts/webkitpy/common/config/committers.py: Add myself to the
991         committers list.
992
993 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
994
995         [chromium] check that we're not running multiple modal dialogs at the same time
996         https://bugs.webkit.org/show_bug.cgi?id=78486
997
998         Reviewed by Kent Tamura.
999
1000         * DumpRenderTree/chromium/TestShell.cpp:
1001         (TestShell::TestShell):
1002         * DumpRenderTree/chromium/TestShell.h:
1003         (TestShell::setIsDisplayingModalDialog):
1004         (TestShell::isDisplayingModalDialog):
1005         (TestShell):
1006         * DumpRenderTree/chromium/WebViewHost.cpp:
1007         (WebViewHost::runModal):
1008
1009 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
1010
1011         Fix WebKit2GTK+ for 'make distcheck'.
1012
1013         Instead of conditionally including WebKit2 GNUmakefiles, always
1014         include them and conditionally activate the final targets.
1015
1016         * MiniBrowser/gtk/GNUmakefile.am:
1017         * WebKitTestRunner/GNUmakefile.am:
1018
1019 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1020
1021         Enable video option for EFL port in build-webkit.
1022         https://bugs.webkit.org/show_bug.cgi?id=79006
1023
1024         Reviewed by Daniel Bates.
1025
1026         * Scripts/build-webkit:
1027
1028 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
1029
1030         [EFL] Use modifier keys to execute pre-rendering.
1031         https://bugs.webkit.org/show_bug.cgi?id=77933
1032
1033         Reviewed by Chang Shu.
1034
1035         Use modifier key to execute pre-rendering instead of using reserved function keys.
1036
1037         * EWebLauncher/main.c:
1038         (on_key_down):
1039
1040 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1041
1042         Fix one more dangling reference to worker_connection.name, delete unused code.
1043
1044         Unreviewed, build fix.
1045
1046         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1047         (Manager.update):
1048         (_WorkerState.__init__):
1049
1050 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1051
1052         Add a change that should've been in r108005.
1053
1054         Unreviewed, build fix.
1055
1056         In the refactoring/cleanup in r108005 I should've changed the
1057         implementation of WorkerConnection to make it match BrokerClient
1058         (and everything else) so that objects had a name() method
1059         instead of a name property.
1060
1061         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1062         (Manager._run_tests):
1063         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1064         (_WorkerConnection.__init__):
1065         (_WorkerConnection.name):
1066         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1067         (_TestWorker.__init__):
1068         (_TestsMixin.name):
1069         (_TestsMixin.test_name):
1070         (_TestsMixin.test_cancel):
1071         (_TestsMixin.test_unknown_message):
1072
1073 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
1074
1075         webkitpy: remove webkitpy.common.array_stream
1076         https://bugs.webkit.org/show_bug.cgi?id=78952
1077
1078         Reviewed by Eric Seidel.
1079
1080         Turns out array_stream didn't really do anything that StringIO
1081         didn't do (at least as of Python 2.6). This change removes it
1082         and updates all of the callers. Where possible, I changed the
1083         test assertions in order to capture the intent more clearly,
1084         e.g., instead of calling self.assertTrue('foo' in stream.get()),
1085         we have self.assertContainsLine(stream, 'foo'), and instead of
1086         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
1087         the latter isn't that much more readable, but StringIO doesn't
1088         export an empty() method.
1089
1090         * Scripts/webkitpy/common/array_stream.py: Removed.
1091         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
1092         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1093         (passing_run):
1094         (run_and_capture):
1095         (StreamTestingMixin):
1096         (StreamTestingMixin.assertContains):
1097         (StreamTestingMixin.assertContainsLine):
1098         (StreamTestingMixin.assertEmpty):
1099         (StreamTestingMixin.assertNotEmpty):
1100         (LintTest):
1101         (LintTest.test_lint_test_files):
1102         (LintTest.test_lint_test_files__errors):
1103         (MainTest):
1104         (MainTest.test_child_process_1):
1105         (MainTest.test_child_processes_2):
1106         (MainTest.test_child_processes_min):
1107         (MainTest.test_help_printing):
1108         (MainTest.test_hung_thread):
1109         (MainTest.test_no_tests_found):
1110         (MainTest.test_no_tests_found_2):
1111         (MainTest.test_repeat_each_iterations_num_tests):
1112         (MainTest.test_test_list):
1113         (MainTest.test_unexpected_failures):
1114         (MainTest.test_worker_model__inline_with_child_processes):
1115         (MainTest.test_additional_platform_directory):
1116         (RebaselineTest):
1117         (RebaselineTest.assertBaselines):
1118         (RebaselineTest.test_reset_results):
1119         (RebaselineTest.test_missing_results):
1120         (RebaselineTest.test_new_baseline):
1121         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1122         (MeteredStream.update):
1123         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1124         (TestMeteredStream.test_regular):
1125         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1126         (TestUtilityFunctions.assertEmpty):
1127         (TestUtilityFunctions):
1128         (TestUtilityFunctions.assertNotEmpty):
1129         (TestUtilityFunctions.assertWritten):
1130         (TestUtilityFunctions.test_configure_logging):
1131         (Testprinter.assertEmpty):
1132         (Testprinter):
1133         (Testprinter.assertNotEmpty):
1134         (Testprinter.assertWritten):
1135         (Testprinter.reset):
1136         (Testprinter.get_printer):
1137         (Testprinter.test_help_printer):
1138         (Testprinter.do_switch_tests.do_helper):
1139         (Testprinter.test_print_one_line_summary):
1140         (Testprinter.test_print_test_result):
1141         (Testprinter.test_print_progress):
1142         (Testprinter.test_write_nothing):
1143         (Testprinter.test_write_misc):
1144         (Testprinter.test_write_everything):
1145         (Testprinter.test_write_verbose):
1146         (Testprinter.test_print_unexpected_results):
1147         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1148         (MainTest.assertWritten):
1149         (create_runner):
1150         (test_run_test_set):
1151         (test_run_test_set_kills_drt_per_run):
1152         (test_run_test_set_for_parser_tests):
1153         (test_run_test_set_with_json_output):
1154         (test_run_test_set_with_json_source):
1155         (test_run_test_set_with_multiple_repositories):
1156         (test_upload_json):
1157
1158 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1159
1160         [wx] Add the WebCore/page/scrolling directory to the build dirs.
1161
1162         * waf/build/settings.py:
1163
1164 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
1165
1166         [wx] Unreviewed build fix. Don't error out or hang if we have
1167         downloaded dependencies but server update check fails.
1168
1169         * waf/build/build_utils.py:
1170         (download_if_newer):
1171
1172 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1173
1174         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
1175         https://bugs.webkit.org/show_bug.cgi?id=69444
1176
1177         Reviewed by Tony Chang.
1178
1179         Currently if a test's image checksum doesn't match the checksum
1180         in the baseline, but the images themselves match according to
1181         ImageDiff, new-run-webkit-tests ignores the problem. This is
1182         probably bad, but it's not yet clear what the right thing to do
1183         is. This patch will log a warning to stderr, at least (but the
1184         test will still pass).
1185
1186         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1187         (SingleTestRunner._compare_image):
1188         (SingleTestRunner._run_reftest):
1189         * Scripts/webkitpy/layout_tests/port/test.py:
1190         (unit_test_list):
1191         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1192
1193 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1194
1195         NRWT does not report failure for a skipped test
1196         https://bugs.webkit.org/show_bug.cgi?id=78750
1197
1198         Reviewed by Eric Seidel.
1199
1200         If a test is listed in a Skipped file and you run it anyway
1201         with --force, and the test fails, currently NRWT will print
1202         "test ran as expected"; this is confusing, because you probably
1203         expect the test to fail and yet this might lead you to think the
1204         test passed. This patch changes the expected behavior to "PASS",
1205         so tests that fail will be reported.
1206
1207         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1208         (result_was_expected):
1209         (TestExpectationParser):
1210         (TestExpectationParser.expectation_for_skipped_test):
1211         (TestExpectations):
1212         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1213         (test_add_skipped_tests):
1214         * Scripts/webkitpy/layout_tests/port/test.py:
1215         (unit_test_list): Add some tests that are expected to be in a Skipped file.
1216         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
1217
1218 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1219
1220         webkitpy: fix test code after bug 78181
1221         https://bugs.webkit.org/show_bug.cgi?id=78870
1222
1223         Reviewed by Adam Barth.
1224
1225         I forgot to update the test code as per Tony's suggestion in
1226         bug 78181 (r108005). This change does that, and in doing so
1227         it revealed a subtle bug in _InlineWorkerConnection.run() that
1228         I am fixing as part of this (_alive would not be cleared if an
1229         exception was thrown).
1230
1231         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1232         (_InlineWorkerConnection.run):
1233         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1234         (_TestWorker.__init__):
1235         (_TestWorker.handle_stop):
1236         (_TestWorker.handle_test):
1237         (_TestWorker.run):
1238         (_TestsMixin.handle_exception):
1239         (_TestsMixin.test_unknown_message):
1240
1241 2012-02-17  Adam Roben  <aroben@apple.com>
1242
1243         Mac build fix after r108119
1244
1245         * DumpRenderTree/mac/DumpRenderTree.mm:
1246         (runThread):
1247         (runPthread):
1248         (testThreadIdentifierMap):
1249         Updated to match current WTF threading APIs.
1250
1251 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
1252
1253         revert r107147 - breaks webkit-patch on Mac SL
1254         https://bugs.webkit.org/show_bug.cgi?id=78866
1255
1256         Reviewed by Adam Barth.
1257
1258         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
1259         which is the version that ships on Mac SL. Reverting this
1260         change until we no longer have to worry about that version.
1261
1262         * Scripts/webkitpy/common/system/autoinstall.py:
1263         (AutoInstaller):
1264         (AutoInstaller._extract_all): Added a comment about SL.
1265         (AutoInstaller._unzip):
1266
1267 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
1268
1269         CSS regions enabled by default
1270         https://bugs.webkit.org/show_bug.cgi?id=78525
1271
1272         Reviewed by David Hyatt.
1273
1274         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
1275         CSSRegions are still enabled by default.
1276         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
1277
1278         * DumpRenderTree/chromium/LayoutTestController.cpp:
1279         (LayoutTestController::overridePreference):
1280         * DumpRenderTree/chromium/WebPreferences.cpp:
1281         (WebPreferences::reset):
1282         (WebPreferences::applyTo):
1283         * DumpRenderTree/chromium/WebPreferences.h:
1284         (WebPreferences):
1285         * DumpRenderTree/mac/DumpRenderTree.mm:
1286         (resetDefaultsToConsistentValues):
1287
1288 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
1289
1290         Some API tests erroneously use = instead of == (causing build failures)
1291         https://bugs.webkit.org/show_bug.cgi?id=78915
1292
1293         Reviewed by Sam Weinig.
1294
1295         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1296         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
1297         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
1298
1299 2012-02-17  Peter Beverloo  <peter@chromium.org>
1300
1301         [Chromium] Include TestShellLinux.cpp in the build for Android
1302         https://bugs.webkit.org/show_bug.cgi?id=78865
1303
1304         Reviewed by Eric Seidel.
1305
1306         Android will be re-using the TestShellLinux.cpp file. I already
1307         added this r104033, but it seems to have gotten lost in the
1308         recent refactorings.
1309
1310         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1311
1312 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1313
1314         Unreviewed, disable video build on EFL until it can be
1315         supported by EFL build bot.
1316
1317         * Scripts/build-webkit:
1318
1319 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1320
1321         [GTK] Implement zoom in/out in MiniBrowser
1322         https://bugs.webkit.org/show_bug.cgi?id=75253
1323
1324         Reviewed by Gustavo Noronha Silva.
1325
1326         * MiniBrowser/gtk/BrowserWindow.c:
1327         (browserWindowCanZoomIn):
1328         (browserWindowCanZoomOut):
1329         (browserWindowUpdateZoomActions):
1330         (webViewZoomLevelChanged):
1331         (zoomInCallback):
1332         (zoomOutCallback):
1333         (browser_window_init):
1334         (browserWindowConstructed):
1335
1336 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
1337
1338         layoutTestController.display() is flaky for SVG tests
1339         https://bugs.webkit.org/show_bug.cgi?id=78021
1340
1341         Reviewed by Adam Roben.
1342
1343         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
1344         Size the web view before running the test, not when dumping.
1345         All platforms handle this correctly now.
1346
1347         * DumpRenderTree/win/DumpRenderTree.cpp:
1348         (dump):
1349         (sizeWebViewForCurrentTest):
1350         (runTest):
1351
1352 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1353
1354         [GTK] Make install is broken when building without --enable-gtk-doc
1355         https://bugs.webkit.org/show_bug.cgi?id=78828
1356
1357         Reviewed by Martin Robinson.
1358
1359         * gtk/generate-gtkdoc:
1360         (rebase_installed_docs): Check documentation has been generated
1361         before trying to rebase it.
1362
1363 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
1364
1365         nrwt: simplify worker interface
1366         https://bugs.webkit.org/show_bug.cgi?id=78181
1367
1368         Reviewed by Tony Chang.
1369
1370         This change moves code in name(), is_done(), run(), and cancel()
1371         from Worker to AbstractWorker, since the logic is pretty much
1372         boilerplate code that any implementation would want to use.
1373
1374         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1375         (get.should):
1376         (AbstractWorker.__init__):
1377         (AbstractWorker):
1378         (AbstractWorker.name):
1379         (AbstractWorker.stop_handling_messages):
1380         (AbstractWorker.run):
1381         (AbstractWorker.is_done):
1382         (AbstractWorker.cancel):
1383         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1384         (Worker.__init__):
1385         (Worker.run):
1386         (Worker.handle_stop):
1387
1388 2012-02-16  Michael Saboff  <msaboff@apple.com>
1389
1390         ENH: Add ability to run subset of JavaScript layout tests with JSC
1391         https://bugs.webkit.org/show_bug.cgi?id=78764
1392
1393         Reviewed by Gavin Barraclough.
1394
1395         New simple test drive shell script that runs a defined
1396         list of javascript tests using jsc and the standalone-{pre,post}.js
1397         wrappers.
1398
1399         * Scripts/run-fast-jsc: Added.
1400
1401 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
1402
1403         Add new Qt performance tester bot to build.webkit.org
1404         https://bugs.webkit.org/show_bug.cgi?id=78795
1405
1406         Reviewed by Adam Roben.
1407
1408         * BuildSlaveSupport/build.webkit.org-config/config.json:
1409
1410 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1411
1412         Disable inspector on WinCE.
1413
1414         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
1415
1416         * Scripts/build-webkit:
1417
1418 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
1419
1420         WinCE build fix after r107656.
1421
1422         Disable FTPDIR on WinCE, since it does not compile there.
1423
1424         * Scripts/build-webkit:
1425
1426 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
1427
1428         Build fix after r107863.
1429
1430         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1431
1432 2012-02-15  Tony Chang  <tony@chromium.org>
1433
1434         [chromium] add linux dbg back to garden-o-matic
1435         https://bugs.webkit.org/show_bug.cgi?id=78752
1436
1437         Reviewed by Adam Barth.
1438
1439         This reflects the current linux debug bot name (there's only one bot).
1440         I'm also remove the mac clang builder since it doesn't exist (mac
1441         always uses clang now).
1442
1443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1444         * Scripts/webkitpy/layout_tests/port/builders.py:
1445
1446 2012-02-15  Sam Weinig  <sam@webkit.org>
1447
1448         Add style check for ctype functions that are generally frowned upon in WebKit
1449         https://bugs.webkit.org/show_bug.cgi?id=78748
1450
1451         Reviewed by Anders Carlsson.
1452
1453         Not every platform has DisallowCType.h to check for uses of the ctype.h
1454         functions, so add a style check for them as well.
1455
1456         * Scripts/webkitpy/style/checkers/cpp.py:
1457         (check_ctype_functions):
1458         (check_style):
1459         (CppChecker):
1460         Add check.
1461
1462         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1463         (WebKitStyleTest.test_ctype_fucntion):
1464         Add checker.
1465
1466 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
1467
1468         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
1469         https://bugs.webkit.org/show_bug.cgi?id=76546
1470
1471         Reviewed by Simon Hausmann.
1472
1473         Resize the web view programatically because the declarative property binding
1474         does not work. Seems like our qml environment is not initialized fully but it
1475         needs more investigation.
1476
1477         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1478         (WTR::WrapperWindow::handleStatusChanged):
1479         (WTR::PlatformWebView::resizeTo):
1480
1481 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
1482
1483         webkitpy: add a worker_args concept to start_worker()
1484         https://bugs.webkit.org/show_bug.cgi?id=78572
1485
1486         Reviewed by Tony Chang.
1487
1488         This change replaces the three NRWT-specific arguments passed
1489         through the broker to the worker with a generic WorkerArguments
1490         wrapper class and a separate set_inline_arguments() call that can
1491         be used to pass additional data to the worker when it is running
1492         in the same process as the manager (this is needed for testing).
1493         With the addition of set_inline_arguments() we also no longer
1494         need to pass an optional argument to the worker.run() call.
1495
1496         Note that this method is *only* implemented on inline workers,
1497         so calling this on a regular (child process) worker will result
1498         in a runtime error.
1499
1500         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1501         (Manager._run_tests):
1502         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1503         (AbstractWorker.__init__):
1504         (AbstractWorker.run):
1505         (_ManagerConnection.start_worker):
1506         (_InlineManager.start_worker):
1507         (_InlineManager.set_inline_arguments):
1508         (_InlineManager.run_message_loop):
1509         (_MultiProcessManager.start_worker): Reworked signature.
1510         (_WorkerConnection.__init__):
1511         (_InlineWorkerConnection.__init__):
1512         (_InlineWorkerConnection.set_inline_arguments): New method.
1513         (_InlineWorkerConnection):
1514         (_InlineWorkerConnection.run):
1515         (_Process.run):
1516         (_MultiProcessWorkerConnection.__init__):
1517         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1518         (_TestWorker.__init__):
1519         (_TestWorker.set_inline_arguments):
1520         (_TestWorker.handle_test):
1521         (_TestWorker.run):
1522         (_TestsMixin.test_cancel):
1523         (_TestsMixin.test_done):
1524         (_TestsMixin.test_unknown_message):
1525         (InlineBrokerTests): New class for more testing.
1526         (InlineBrokerTests.setUp):
1527         (InlineBrokerTests.test_inline_arguments): New test.
1528         (InterfaceTest.test_managerconnection_is_abstract):
1529         (InterfaceTest.test_workerconnection_is_abstract):
1530         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1531         (WorkerArguments):
1532         (WorkerArguments.__init__):
1533         (Worker.__init__):
1534         (Worker.set_inline_arguments):
1535         (Worker):
1536         (Worker.run):
1537         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1538         (WorkerTest.test_default_platform_in_worker):
1539
1540 2012-02-15  Adam Klein  <adamk@chromium.org>
1541
1542         Unreviewed, rolling out r107704.
1543         http://trac.webkit.org/changeset/107704
1544         https://bugs.webkit.org/show_bug.cgi?id=78486
1545
1546         Caused layout test crashes in debug builds.
1547
1548         Specific crashing tests:
1549
1550         fast/events/show-modal-dialog-onblur-onfocus.html
1551         fast/harness/show-modal-dialog.html
1552         inspector/console/console-long-eval-crash.html
1553
1554         * DumpRenderTree/chromium/TestShell.cpp:
1555         (TestShell::TestShell):
1556         * DumpRenderTree/chromium/TestShell.h:
1557         (TestShell):
1558         * DumpRenderTree/chromium/WebViewHost.cpp:
1559         (WebViewHost::runModal):
1560
1561 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
1562
1563         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
1564         https://bugs.webkit.org/show_bug.cgi?id=76347
1565
1566         Reviewed by Kenneth Rohde Christiansen.
1567
1568         * MiniBrowser/qt/MiniBrowser.qrc:
1569         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
1570         * MiniBrowser/qt/qml/BrowserWindow.qml:
1571         * MiniBrowser/qt/qml/DialogLineInput.qml:
1572
1573 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
1574
1575         [Qt] Fix WebGL in QtTestBrowser
1576
1577         Reviewed by Tor Arne Vestbø.
1578
1579         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
1580         the options for enabling GL we also pass them on properly.
1581
1582 2012-02-14  Sam Weinig  <sam@webkit.org>
1583
1584         Add #include of unistd.h on the mac for getcwd. 
1585
1586         Reviewed by Anders Carlsson.
1587
1588         This is necessary when building with libc++.
1589
1590         * WebKitTestRunner/TestInvocation.cpp:
1591
1592 2012-02-14  Sam Weinig  <sam@webkit.org>
1593
1594         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
1595         https://bugs.webkit.org/show_bug.cgi?id=78663
1596
1597         Reviewed by Anders Carlsson.
1598
1599         * DumpRenderTree/DumpRenderTreePrefix.h:
1600         * DumpRenderTree/cg/ImageDiffCG.cpp:
1601
1602 2012-02-14  Adam Barth  <abarth@webkit.org>
1603
1604         Implement an adb-based driver for the ChromiumAndroidPort
1605         https://bugs.webkit.org/show_bug.cgi?id=78627
1606
1607         Reviewed by Eric Seidel.
1608
1609         This driver mostly just wires up the ChromiumDriver through adb.  In
1610         some cases, it translates protocol elements, such as URIs, so that the
1611         rest of webkitpy is insulated from the "remoteness" of the target device.
1612
1613         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1614         (ChromiumAndroidPort.start_helper):
1615         (ChromiumAndroidPort._driver_class):
1616         (ChromiumAndroidPort._update_version):
1617         (ChromiumAndroidPort._get_stderr):
1618         (ChromiumAndroidPort):
1619         (ChromiumAndroidPort._get_last_stacktrace):
1620         (ChromiumAndroidPort._teardown_performance):
1621         (ChromiumAndroidDriver):
1622         (ChromiumAndroidDriver.__init__):
1623         (ChromiumAndroidDriver._start):
1624         (ChromiumAndroidDriver.run_test):
1625         (ChromiumAndroidDriver.stop):
1626         (ChromiumAndroidDriver._test_shell_command):
1627         (ChromiumAndroidDriver._write_command_and_read_line):
1628         (ChromiumAndroidDriver._output_image):
1629         (ChromiumAndroidDriver._has_crash_hint):
1630
1631 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1632
1633         webkitpy: the real_name() method in the Port class is no longer needed
1634         https://bugs.webkit.org/show_bug.cgi?id=78651
1635
1636         Reviewed by Eric Seidel.
1637
1638         The change in bug 78565 / r107718 made it no longer necessary
1639         (we can use options.platform instead).
1640
1641         * Scripts/webkitpy/layout_tests/port/base.py:
1642         (Port.name):
1643         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1644         (MockDRTPort.__init__):
1645
1646 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1647
1648         webkitpy: clean up options, port handling in manager_worker_broker
1649         https://bugs.webkit.org/show_bug.cgi?id=78568
1650
1651         Reviewed by Tony Chang.
1652
1653         manager_worker_broker no longer needs options or port objects
1654         directly, so we make them only be passed in start_worker().
1655
1656         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1657         (Manager._run_tests):
1658         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1659         (get):
1660         (_ManagerConnection.__init__):
1661         (_ManagerConnection.start_worker):
1662         (_InlineManager.__init__):
1663         (_InlineManager.start_worker):
1664         (_InlineManager.run_message_loop):
1665         (_MultiProcessManager.__init__):
1666         (_MultiProcessManager):
1667         (_MultiProcessManager.start_worker):
1668         (_InlineWorkerConnection.__init__):
1669         (_InlineWorkerConnection.run):
1670         (_Process.__init__):
1671         (_MultiProcessWorkerConnection.__init__):
1672         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1673         (make_broker):
1674         (_TestWorker.run):
1675         (_TestsMixin.test_cancel):
1676         (_TestsMixin.test_done):
1677         (_TestsMixin.test_unknown_message):
1678         (MultiProcessBrokerTests.setUp):
1679         (InterfaceTest.test_managerconnection_is_abstract):
1680         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
1681         (Broker.__init__):
1682
1683 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1684
1685         nrwt: add a unit test for regression introduced in bug 78565
1686         https://bugs.webkit.org/show_bug.cgi?id=78646
1687
1688         Reviewed by Tony Chang.
1689
1690         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
1691         (FakeConnection):
1692         (FakeConnection.run_message_loop):
1693         (FakeConnection.post_message):
1694         (WorkerTest):
1695         (WorkerTest.test_default_platform_in_worker):
1696
1697 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1698
1699         NRWT is broken for the default port
1700         https://bugs.webkit.org/show_bug.cgi?id=78640
1701     
1702         Reviewed by Tony Chang.
1703
1704         The change in r107718 (bug 78565) broke NRWT if you didn't
1705         specify any sort of --platform flag or equivalent. I didn't
1706         catch this because it's a full integration test (which we don't
1707         have an automated test for) and I missed this command line
1708         variant when testing interactively.
1709
1710         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1711         (Worker.run):
1712
1713 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
1714
1715         Last character display for passwords in Android.
1716         https://bugs.webkit.org/show_bug.cgi?id=78532
1717
1718         Reviewed by Adam Barth.
1719
1720         * DumpRenderTree/chromium/WebPreferences.cpp:
1721         (WebPreferences::applyTo):
1722
1723 2012-02-14  Adam Barth  <abarth@webkit.org>
1724
1725         Finish implementing start_helper for ChromiumAndroidPort
1726         https://bugs.webkit.org/show_bug.cgi?id=78582
1727
1728         Reviewed by Eric Seidel.
1729
1730         This patch contains the remaining odds and ends for the start_helper function.
1731
1732         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1733         (ChromiumAndroidPort.start_helper):
1734         (ChromiumAndroidPort._synchronize_datetime):
1735         (ChromiumAndroidPort):
1736         (ChromiumAndroidPort._check_version):
1737         (ChromiumAndroidPort._run_adb_command):
1738         (ChromiumAndroidPort._copy_device_file):
1739
1740 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
1741
1742         webkitpy: create ports in Workers, not in manager_worker_broker
1743         https://bugs.webkit.org/show_bug.cgi?id=78565
1744
1745         Reviewed by Tony Chang.
1746
1747         We will now create the Port object (if necessary) in the Worker
1748         directly, so that the manager_worker_broker module doesn't need
1749         all of this layout_test-specific logic. Part of the fixes for
1750         bug 78171.
1751
1752         These changes are all well-tested by the existing tests in
1753         run_webkit_tests_integrationtest.py.
1754
1755         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1756         (_Process.run):
1757         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1758         (Worker.__init__):
1759         (Worker.safe_init):
1760         (Worker.run):
1761         (Worker.cleanup):
1762         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1763         (parse_args):
1764         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
1765
1766 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
1767
1768         [chromium] check that we're not running multiple modal dialogs at the same time
1769         https://bugs.webkit.org/show_bug.cgi?id=78486
1770
1771         Reviewed by Kent Tamura.
1772
1773         * DumpRenderTree/chromium/TestShell.cpp:
1774         (TestShell::TestShell):
1775         * DumpRenderTree/chromium/TestShell.h:
1776         (TestShell::setIsDisplayingModalDialog):
1777         (TestShell::isDisplayingModalDialog):
1778         (TestShell):
1779         * DumpRenderTree/chromium/WebViewHost.cpp:
1780         (WebViewHost::runModal):
1781
1782 2012-02-14  Adam Barth  <abarth@webkit.org>
1783
1784         Enable the GPU codepath in the chromium-android port
1785         https://bugs.webkit.org/show_bug.cgi?id=78580
1786
1787         Reviewed by James Robinson.
1788
1789         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
1790         Android always uses the GPU codepath, so we set the GPU flags on the
1791         main chromium-android port instead.
1792
1793         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1794         (ChromiumAndroidPort.__init__):
1795
1796 2012-02-14  Adam Barth  <abarth@webkit.org>
1797
1798         NRWT should expose --adb-args flag for Android
1799         https://bugs.webkit.org/show_bug.cgi?id=78579
1800
1801         Reviewed by Eric Seidel.
1802
1803         This flag is already wired up to the ChromiumAndroidPort.
1804
1805         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1806         (parse_args):
1807
1808 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
1809
1810         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
1811         https://bugs.webkit.org/show_bug.cgi?id=78541
1812         <rdar://problem/10036695>
1813
1814         Reviewed by Kent Tamura.
1815
1816         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
1817         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
1818         After each test, reset to using new protocol.
1819
1820 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
1821
1822         Convert svg/animations to use SMIL methods for driving the timeline
1823         https://bugs.webkit.org/show_bug.cgi?id=78422
1824
1825         Reviewed by Dirk Schulze.
1826
1827         Remove no longer needed SVG specific animation sampling functionality from DRT.
1828         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
1829
1830         * DumpRenderTree/LayoutTestController.cpp:
1831         (LayoutTestController::staticFunctions):
1832         * DumpRenderTree/LayoutTestController.h:
1833         (LayoutTestController):
1834         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1835         * DumpRenderTree/chromium/LayoutTestController.cpp:
1836         (LayoutTestController::LayoutTestController):
1837         * DumpRenderTree/chromium/LayoutTestController.h:
1838         (LayoutTestController):
1839         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1840         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1841         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1842         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1843         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1844         (LayoutTestController):
1845         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1846         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1847
1848 2012-02-13  Rob Flack  <flackr@chromium.org>
1849
1850         Add Linux ChromiumOS test results to flakiness dashboard.
1851         https://bugs.webkit.org/show_bug.cgi?id=78495
1852
1853         Reviewed by Ojan Vafai.
1854
1855         * TestResultServer/static-dashboards/builders.js:
1856         * TestResultServer/static-dashboards/dashboard_base.js:
1857
1858 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
1859
1860         [GTK] Mutation Observers build is broken
1861         https://bugs.webkit.org/show_bug.cgi?id=78433
1862
1863         Reviewed by Martin Robinson.
1864
1865         Enabled mutation observers as a default feature for GTK port, too.
1866
1867         * Scripts/build-webkit:
1868
1869 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
1870
1871         Allow to configure ENABLE_FTPDIR in build-webkit
1872         https://bugs.webkit.org/show_bug.cgi?id=65098
1873
1874         Reviewed by Eric Seidel.
1875
1876         Allow to disable ENABLE_FTPDIR by command line.
1877         Remove ENABLE_FTPDIR from --minimal build
1878
1879         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
1880         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
1881         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
1882
1883 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
1884
1885         Add shinyak as committer.
1886
1887         Unreviewed.
1888
1889         * Scripts/webkitpy/common/config/committers.py:
1890
1891 2012-02-13  Adam Barth  <abarth@webkit.org>
1892
1893         Implement start/stop_helper for ChromiumAndroidPort
1894         https://bugs.webkit.org/show_bug.cgi?id=78558
1895
1896         Reviewed by Dirk Pranke.
1897
1898         These functions (and their dependencies) set up the Android device for
1899         testing.
1900
1901         This patch also includes a few tweaks on the previous patch recommended
1902         by dpranke.
1903
1904         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1905         (ChromiumAndroidPort.__init__):
1906         (ChromiumAndroidPort.start_helper):
1907         (ChromiumAndroidPort.stop_helper):
1908         (ChromiumAndroidPort._shut_down_http_server):
1909         (ChromiumAndroidPort):
1910         (ChromiumAndroidPort._push_executable):
1911         (ChromiumAndroidPort._push_fonts):
1912         (ChromiumAndroidPort._restore_system_font):
1913         (ChromiumAndroidPort._push_test_resources):
1914         (ChromiumAndroidPort._push_to_device):
1915         (ChromiumAndroidPort._pull_from_device):
1916         (ChromiumAndroidPort._kill_device_process):
1917         (ChromiumAndroidPort._setup_performance):
1918         (ChromiumAndroidPort._teardown_performance):
1919         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1920         (ChromiumAndroidPortTest):
1921         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1922         (PortTestCase):
1923         (PortTestCase.make_port):
1924         (PortTestCase.test_default_worker_model):
1925
1926 2012-02-13  Adam Barth  <abarth@webkit.org>
1927
1928         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
1929         https://bugs.webkit.org/show_bug.cgi?id=78550
1930
1931         Reviewed by Eric Seidel.
1932
1933         Much of this code just forwards to the "host" port, which seems like a
1934         reasonable thing to do.
1935
1936         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1937         (ChromiumAndroidPort.__init__):
1938         (ChromiumAndroidPort.stop_helper):
1939         (ChromiumAndroidPort):
1940         (ChromiumAndroidPort._build_path):
1941         (ChromiumAndroidPort._path_to_apache):
1942         (ChromiumAndroidPort._path_to_apache_config_file):
1943         (ChromiumAndroidPort._path_to_driver):
1944         (ChromiumAndroidPort._path_to_helper):
1945         (ChromiumAndroidPort._path_to_image_diff):
1946         (ChromiumAndroidPort._path_to_lighttpd):
1947         (ChromiumAndroidPort._path_to_lighttpd_modules):
1948         (ChromiumAndroidPort._path_to_lighttpd_php):
1949         (ChromiumAndroidPort._path_to_wdiff):
1950         (ChromiumAndroidPort._shut_down_http_server):
1951         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1952         (ChromiumAndroidPortTest):
1953         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1954         (PortTestCase):
1955         (PortTestCase.make_port):
1956         (PortTestCase.test_default_worker_model):
1957
1958 2012-02-13  Adam Barth  <abarth@webkit.org>
1959
1960         chromium_android.py should implement "virtual" methods from ChromiumPort
1961         https://bugs.webkit.org/show_bug.cgi?id=78545
1962
1963         Reviewed by Dirk Pranke.
1964
1965         This patch adds basic implementations that specialize a bunch of
1966         functions from ChromiumPort.
1967
1968         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1969         (ChromiumAndroidPort):
1970         (ChromiumAndroidPort.__init__):
1971         (ChromiumAndroidPort.default_child_processes):
1972         (ChromiumAndroidPort.baseline_search_path):
1973         (ChromiumAndroidPort.check_build):
1974         (ChromiumAndroidPort.check_sys_deps):
1975         (ChromiumAndroidPort.default_worker_model):
1976         (ChromiumAndroidPort.test_expectations):
1977         (ChromiumAndroidPort.start_http_server):
1978         (ChromiumAndroidPort.stop_http_server):
1979         (ChromiumAndroidPort.start_helper):
1980         (ChromiumAndroidPort.stop_helper):
1981
1982 2012-02-13  Adam Barth  <abarth@webkit.org>
1983
1984         Add a skeleton ChromiumAndroid port to webkitpy
1985         https://bugs.webkit.org/show_bug.cgi?id=78543
1986
1987         Reviewed by Eric Seidel.
1988
1989         This patch just adds an empty ChromiumAndroid port object to webkitpy
1990         and wires it up to the factory objects.  An actual implementation will
1991         follow.
1992
1993         * Scripts/webkitpy/layout_tests/port/chromium.py:
1994         (ChromiumPort):
1995         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
1996         (ChromiumAndroidPort):
1997         (ChromiumAndroidPort.__init__):
1998         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1999         (ChromiumPortTest.test_all_test_configurations):
2000         * Scripts/webkitpy/layout_tests/port/factory.py:
2001         (PortFactory):
2002
2003 2012-02-13  Adam Barth  <abarth@webkit.org>
2004
2005         NRWT's HTTP servers should support additional directories for resources
2006         https://bugs.webkit.org/show_bug.cgi?id=78528
2007
2008         Reviewed by Eric Seidel.
2009
2010         This functionality will be used by the Chromium-Android port.
2011
2012         * Scripts/webkitpy/layout_tests/port/base.py:
2013         (Port.to.start_http_server):
2014         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2015         (LayoutTestApacheHttpd.__init__):
2016         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2017         (Lighttpd.__init__):
2018         (Lighttpd._prepare_config):
2019
2020 2012-02-13  Ami Fischman  <fischman@chromium.org>
2021
2022         Add fischman as committer.
2023
2024         Unreviewed
2025
2026         * Scripts/webkitpy/common/config/committers.py:
2027
2028 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
2029
2030         [EFL] Drop support for the Curl network backend.
2031         https://bugs.webkit.org/show_bug.cgi?id=77874
2032
2033         Reviewed by Eric Seidel.
2034
2035         Nobody seems to be maintaining the Curl backend in WebCore, the
2036         EFL port developers all seem to be using the Soup backend and the
2037         port itself has many features which are only implemented for the
2038         latter.
2039
2040         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
2041         and always add the required include directories.
2042         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
2043         include directories and link to them.
2044
2045 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
2046
2047         [WebSocket] Update pywebsocket to 0.7.1
2048         https://bugs.webkit.org/show_bug.cgi?id=78484
2049
2050         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
2051
2052         Reviewed by Kent Tamura.
2053
2054         * Scripts/webkitpy/thirdparty/__init__.py:
2055         (AutoinstallImportHook._install_pywebsocket):
2056
2057 2012-02-12  Kangil Han  <kangil.han@samsung.com>
2058
2059         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
2060         https://bugs.webkit.org/show_bug.cgi?id=78091
2061
2062         Reviewed by Hajime Morita.
2063
2064         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
2065         This patch will activate around 1,900 test cases from skipped list in EFL port.
2066
2067         * DumpRenderTree/efl/EventSender.cpp:
2068         (textZoom):
2069         (pageZoom):
2070         (textZoomInCallback):
2071         (textZoomOutCallback):
2072         (zoomPageInCallback):
2073         (zoomPageOutCallback):
2074
2075 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
2076
2077         KeywordLookupGenerator.py script fails in some cases
2078         https://bugs.webkit.org/show_bug.cgi?id=77886
2079
2080         Reviewed by Benjamin Poulain.
2081
2082         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
2083         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
2084         (GlobalVariablesTest.test_path_rules_specifier):
2085
2086 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2087
2088         Add toText and isTextNode helpers in Text class.
2089         https://bugs.webkit.org/show_bug.cgi?id=78140
2090
2091         Unit test case for the new style checker introduced.
2092
2093         Reviewed by Adam Barth.
2094
2095         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2096         (CppStyleTest):
2097         (CppStyleTest.test_static_cast_readability): Added a unit test case.
2098
2099 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2100
2101         Enable features supported by EFL port in build-webkit.
2102         https://bugs.webkit.org/show_bug.cgi?id=78348
2103
2104         Reviewed by Ryosuke Niwa.
2105
2106         Sync build-webkit with OptionEfl.cmake, as some features enabled in
2107         OptionEfl.cmake are not enabled in build-webkit.
2108
2109         * Scripts/build-webkit:
2110
2111 2012-02-12  Joe Thomas  <joethomas@motorola.com>
2112
2113         Add toText and isTextNode helpers in Text class.
2114         https://bugs.webkit.org/show_bug.cgi?id=78140
2115
2116         Added a style checker to use toText rather than static_cast<Text*>.
2117
2118         Reviewed by Adam Barth.
2119
2120         * Scripts/webkitpy/style/checkers/cpp.py:
2121         (check_language): Style checker for static_cast<Text*>.
2122
2123 2012-02-12  Philippe Normand  <pnormand@igalia.com>
2124
2125         Unreviewed, disable Mutation observers build on GTK until it can
2126         actually build.
2127
2128         * Scripts/build-webkit:
2129
2130 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
2131
2132         Add back WTFURL to WebKit
2133         https://bugs.webkit.org/show_bug.cgi?id=77291
2134
2135         Reviewed by Adam Barth.
2136
2137         Add a flag to build-webkit to easily build WebKit with WTFURL.
2138
2139         * Scripts/build-webkit:
2140
2141 2012-02-10  Adam Klein  <adamk@chromium.org>
2142
2143         Enable MUTATION_OBSERVERS by default on all platforms
2144         https://bugs.webkit.org/show_bug.cgi?id=78196
2145
2146         Reviewed by Ojan Vafai.
2147
2148         * Scripts/build-webkit:
2149
2150 2012-02-10  Adam Barth  <abarth@webkit.org>
2151
2152         Move garden-o-matic's All Failures out of experimental
2153         https://bugs.webkit.org/show_bug.cgi?id=78395
2154
2155         Reviewed by Dimitri Glazkov.
2156
2157         Several folks have tried this feature and found it useful.
2158
2159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2160
2161 2012-02-10  Tim Horton  <timothy_horton@apple.com>
2162
2163         NRWT should categorize options in --help
2164         https://bugs.webkit.org/show_bug.cgi?id=76221
2165
2166         Reviewed by Eric Seidel.
2167         
2168         Use optparse's OptionGroup mechanism to logically group NRWT's options,
2169         providing a better experience when scanning all the options.
2170
2171         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2172         (parse_args):
2173
2174 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2175
2176         [Qt][WK2] Refactor on Qt5 Layout tests' structure
2177         https://bugs.webkit.org/show_bug.cgi?id=77450
2178
2179         Reviewed by Csaba Osztrogonác.
2180
2181         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
2182         to qt-5.0-wk2 and qt-5.0-wk1.
2183
2184         * Scripts/old-run-webkit-tests:
2185         (buildPlatformResultHierarchy):
2186         (readSkippedFiles):
2187         * Scripts/webkitpy/layout_tests/port/qt.py:
2188         (QtPort._wk2_port_name):
2189         (QtPort._skipped_file_search_paths):
2190         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2191         (QtPortTest.test_baseline_search_path):
2192         * Scripts/webkitpy/layout_tests/port/webkit.py:
2193         (WebKitPort._wk2_port_name):
2194
2195 2012-02-09  Philippe Normand  <pnormand@igalia.com>
2196
2197         [GTK] EWS command-line option to run the tests
2198         https://bugs.webkit.org/show_bug.cgi?id=78211
2199
2200         Reviewed by Adam Barth.
2201
2202         New --run-tests option (defaults to False) for the EWS commands.
2203
2204         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2205         (AbstractEarlyWarningSystem):
2206         (AbstractEarlyWarningSystem.__init__):
2207         (AbstractEarlyWarningSystem.review_patch):
2208         (ChromiumLinuxEWS):
2209         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2210         (EarlyWarningSytemTest._test_builder_ews):
2211
2212 2012-02-09  Eric Seidel  <eric@webkit.org>
2213
2214         Rename compare_text and compare_audio to make it clear that they're !=
2215         https://bugs.webkit.org/show_bug.cgi?id=78301
2216
2217         Reviewed by Adam Barth.
2218
2219         I also removed the maybe_create_directory function which was redundant.
2220
2221         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2222         (Manager.set_up_run):
2223         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2224         (TestResultWriter._make_output_directory):
2225         * Scripts/webkitpy/layout_tests/port/base.py:
2226         (Port.do_text_results_differ):
2227         (Port.do_audio_results_differ):
2228         (Port.diff_text):
2229         (Port.driver_name):
2230         (Port.skips_perf_test):
2231         * Scripts/webkitpy/layout_tests/port/win.py:
2232         (WinPort.do_text_results_differ):
2233         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2234         (WinPortTest.test_do_text_results_differ):
2235         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2236         (LayoutTestApacheHttpd.__init__):
2237         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2238         (HttpServerBase.__init__):
2239         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2240         (Rebaseliner._diff_baselines):
2241
2242 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2243
2244         [GTK] Add DRT support for modal dialogs
2245         https://bugs.webkit.org/show_bug.cgi?id=53600
2246
2247         Reviewed by Martin Robinson.
2248
2249         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
2250         Most significantly, when creating a new web view in GtkLauncher, the window
2251         of the web view opener is passed around. In DumpRenderTree, the window of
2252         the main web view is always considered as the opener. This is required so
2253         the modal dialog's toplevel can be made transient for the opener's toplevel.
2254
2255         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2256         (webViewRunModalDialog):
2257         (createWebView):
2258         * GtkLauncher/main.c:
2259         (createWebViewCb):
2260         (runModalDialogCb):
2261         (createBrowser):
2262         (createWindow):
2263         (main):
2264
2265 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
2266
2267         [Gtk] security/set-form-autocomplete-attribute.html fails
2268         https://bugs.webkit.org/show_bug.cgi?id=78261
2269
2270         Reviewed by Martin Robinson.
2271
2272         Use the new helper in DumpRenderTreeSupportGtk to properly
2273         test whether an element performs autocompletion.
2274
2275         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2276         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
2277
2278 2012-02-09  James Robinson  <jamesr@chromium.org>
2279
2280         [chromium] Enable mock scrollbars for compositing layout tests
2281         https://bugs.webkit.org/show_bug.cgi?id=78299
2282
2283         Reviewed by Dirk Pranke.
2284
2285         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
2286         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
2287         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
2288
2289         * DumpRenderTree/chromium/TestShell.cpp:
2290         (TestShell::runFileTest):
2291         * DumpRenderTree/chromium/WebPreferences.cpp:
2292         (WebPreferences::reset):
2293         (WebPreferences::applyTo):
2294         * DumpRenderTree/chromium/WebPreferences.h:
2295         (WebPreferences):
2296
2297 2012-02-09  Eric Seidel  <eric@webkit.org>
2298
2299         Remove more uses of "os" from our webkitpy code
2300         https://bugs.webkit.org/show_bug.cgi?id=78292
2301
2302         Reviewed by Adam Barth.
2303
2304         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2305         (MockCheckout.__init__):
2306         (MockCheckout.is_path_to_changelog):
2307         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2308         * Scripts/webkitpy/common/system/filesystem_mock.py:
2309         (MockFileSystem._split):
2310         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2311         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2312         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2313         * Scripts/webkitpy/layout_tests/port/webkit.py:
2314         * Scripts/webkitpy/tool/bot/queueengine.py:
2315         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2316         * Scripts/webkitpy/tool/commands/download.py:
2317         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2318         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2319         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2320         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
2321         * Scripts/webkitpy/tool/commands/upload.py:
2322         (CreateBug.prompt_for_bug_title_and_comment):
2323         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2324         * Scripts/webkitpy/tool/steps/attachtobug.py:
2325         (AttachToBug.run):
2326         * Scripts/webkitpy/tool/steps/checkstyle.py:
2327         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2328         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2329         * Scripts/webkitpy/tool/steps/editchangelog.py:
2330         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2331         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2332         (PrepareChangeLogTest.test_ensure_bug_url):
2333         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2334         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2335         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2336         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2337
2338 2012-02-09  Eric Seidel  <eric@webkit.org>
2339
2340         Remove the cr-mac-ews (it's long been dead)
2341         https://bugs.webkit.org/show_bug.cgi?id=78267
2342
2343         Reviewed by Adam Barth.
2344
2345         * QueueStatusServer/model/queues.py:
2346         (Queue):
2347         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2348         (ChromiumWindowsEWS):
2349         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2350         (EarlyWarningSytemTest._test_builder_ews):
2351         (EarlyWarningSytemTest._test_testing_ews):
2352
2353 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
2354
2355         some tests in webkitpy are being run three times
2356         https://bugs.webkit.org/show_bug.cgi?id=78283
2357
2358         Reviewed by Ryosuke Niwa.
2359
2360         It turns out that if you import a class derived from
2361         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
2362         the unittest framework treats it as if the class was defined in
2363         the file (as well in the original file). This led us to running
2364         the tests in ChangeLogTest three times.
2365
2366         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2367         (PrepareChangeLogTest):
2368         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2369         (_assert_message_for_revert_output):
2370
2371 2012-02-09  Adam Barth  <abarth@webkit.org>
2372
2373         Remove extraneous line in previous patch.  I forgot to remove this
2374         before landing.
2375
2376         * Scripts/webkitpy/layout_tests/port/driver.py:
2377         (DriverProxy.start):
2378
2379 2012-02-09  Adam Barth  <abarth@webkit.org>
2380
2381         run-perf-tests should have an option to pause before running tests so we can attach Instruments
2382         https://bugs.webkit.org/show_bug.cgi?id=78271
2383
2384         Reviewed by Ryosuke Niwa.
2385
2386         This lets me attach instruments to profile the performance of the test.
2387
2388         * Scripts/webkitpy/layout_tests/port/chromium.py:
2389         (ChromiumDriver.start):
2390         * Scripts/webkitpy/layout_tests/port/driver.py:
2391         (Driver.start):
2392         (DriverProxy.start):
2393         * Scripts/webkitpy/layout_tests/port/server_process.py:
2394         (ServerProcess.start):
2395         * Scripts/webkitpy/layout_tests/port/test.py:
2396         (TestDriver.start):
2397         * Scripts/webkitpy/layout_tests/port/webkit.py:
2398         (WebKitDriver.start):
2399         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2400         (get_tests_run.RecordingTestDriver.start):
2401         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2402         (PerfTestsRunner._parse_args):
2403         (PerfTestsRunner._run_tests_set):
2404         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2405         (start):
2406         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2407         (test_run_test_set_kills_drt_per_run):
2408         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
2409         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
2410
2411 2012-02-09  Adam Barth  <abarth@webkit.org>
2412
2413         run-perf-tests --chromium should run the chromium port
2414         https://bugs.webkit.org/show_bug.cgi?id=78266
2415
2416         Reviewed by Ryosuke Niwa.
2417
2418         This patch makes run-perf-tests work more like run-webkit-tests.
2419
2420         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2421         (PerfTestsRunner._parse_args):
2422
2423 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2424
2425         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2426         https://bugs.webkit.org/show_bug.cgi?id=77466
2427
2428         Reviewed by Dirk Pranke.
2429
2430         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2431         is set or if we should raise an error. A unit test was added.
2432
2433         * Scripts/webkitpy/layout_tests/port/qt.py:
2434         (QtPort.operating_system):
2435         (QtPort):
2436         (QtPort.check_sys_deps):
2437         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2438         (QtPortTest.test_operating_system):
2439         (QtPortTest):
2440         (QtPortTest.test_check_sys_deps):
2441
2442 2012-02-09  Eric Seidel  <eric@webkit.org>
2443
2444         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
2445         https://bugs.webkit.org/show_bug.cgi?id=78263
2446
2447         Reviewed by Adam Barth.
2448
2449         * Scripts/webkitpy/common/config/ports.py:
2450         (DeprecatedPort):
2451         (DeprecatedPort.name):
2452         (DeprecatedPort.flag):
2453         (DeprecatedPort.script_path):
2454         (DeprecatedPort.script_shell_command):
2455         (DeprecatedPort.port):
2456         (DeprecatedPort.makeArgs):
2457         (DeprecatedPort.update_webkit_command):
2458         (DeprecatedPort.check_webkit_style_command):
2459         (DeprecatedPort.prepare_changelog_command):
2460         (DeprecatedPort.build_webkit_command):
2461         (DeprecatedPort.run_javascriptcore_tests_command):
2462         (DeprecatedPort.run_webkit_unit_tests_command):
2463         (DeprecatedPort.run_webkit_tests_command):
2464         (DeprecatedPort.run_python_unittests_command):
2465         (DeprecatedPort.run_perl_unittests_command):
2466         (DeprecatedPort.layout_tests_results_path):
2467         (MacPort):
2468         (WinPort):
2469         (GtkPort):
2470         (GtkPort.build_webkit_command):
2471         (GtkPort.run_webkit_tests_command):
2472         (QtPort):
2473         (QtPort.build_webkit_command):
2474         (EflPort):
2475         (EflPort.build_webkit_command):
2476         (ChromiumPort):
2477         (ChromiumPort.update_webkit_command):
2478         (ChromiumPort.build_webkit_command):
2479         (ChromiumPort.run_webkit_tests_command):
2480         (ChromiumPort.run_javascriptcore_tests_command):
2481         (ChromiumXVFBPort):
2482         (ChromiumXVFBPort.run_webkit_tests_command):
2483         * Scripts/webkitpy/common/config/ports_unittest.py:
2484         (DeprecatedPortTest):
2485         (DeprecatedPortTest.test_mac_port):
2486         (DeprecatedPortTest.test_gtk_port):
2487         (DeprecatedPortTest.test_qt_port):
2488         (DeprecatedPortTest.test_chromium_port):
2489         (DeprecatedPortTest.test_chromium_xvfb_port):
2490         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2491         (AbstractEarlyWarningSystem.__init__):
2492         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2493         * Scripts/webkitpy/tool/main.py:
2494         (WebKitPatch):
2495         (WebKitPatch.handle_global_options):
2496         * Scripts/webkitpy/tool/steps/abstractstep.py:
2497         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2498         (StepsTest.test_runtests_args):
2499
2500 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
2501
2502         [chromium] always initialize makeArgs in buildChromiumNinja
2503         https://bugs.webkit.org/show_bug.cgi?id=78231
2504
2505         Reviewed by Tony Gentilcore.
2506
2507         * Scripts/webkitdirs.pm:
2508         (buildChromiumNinja):
2509
2510 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2511
2512         [GTK] Show url of current hovered link in MiniBrowser
2513         https://bugs.webkit.org/show_bug.cgi?id=78098
2514
2515         Reviewed by Martin Robinson.
2516
2517         * MiniBrowser/gtk/BrowserWindow.c:
2518         (webViewMouseTargetChanged): Check whether hit test result is a
2519         link and use the url to update the status bar text.
2520         (browserWindowConstructed): Connect to
2521         WebKitWebView::mouse-target-changed signal.
2522
2523 2012-02-09  Rob Buis  <rbuis@rim.com>
2524
2525         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2526         https://bugs.webkit.org/show_bug.cgi?id=78042
2527
2528         Reviewed by Antonio Gomes.
2529
2530         Upstream final part of our DRT implementation.
2531
2532         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
2533         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
2534         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
2535         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
2536         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
2537
2538 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
2539
2540         kill-old-processes should kill gcc and clang
2541         https://bugs.webkit.org/show_bug.cgi?id=78189
2542
2543         Reviewed by Eric Seidel.
2544
2545         Added a bunch of processes names of gcc and clang to the list.
2546
2547         * BuildSlaveSupport/kill-old-processes:
2548
2549 2012-02-07  MORITA Hajime  <morrita@google.com>
2550
2551         Replacement text should be available from the marker.
2552         https://bugs.webkit.org/show_bug.cgi?id=77934
2553
2554         Made the mock requestCheckingOfText() implementation to return
2555         a replacement text for each misspelled word if available.
2556
2557         Reviewed by Kent Tamura.
2558
2559         * DumpRenderTree/chromium/WebViewHost.cpp:
2560         (WebViewHost::finishLastTextCheck):
2561
2562 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2563
2564         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
2565         https://bugs.webkit.org/show_bug.cgi?id=78146
2566
2567         Reviewed by Ryosuke Niwa.
2568
2569         Our DumpRenderTree should support --no-timeout and --timeout options in order
2570         to be able to use run-perf-tests and have a Performance Bot.
2571         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
2572         and the necessary code to handle such command line arguments to our DumpRenderTree.
2573
2574         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2575         (WebCore::DumpRenderTree::setTimeout):
2576         (WebCore):
2577         (WebCore::DumpRenderTree::setShouldTimeout):
2578         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2579         (DumpRenderTree):
2580         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2581         (LayoutTestController::LayoutTestController):
2582         (LayoutTestController::waitUntilDone):
2583         (LayoutTestController::notifyDone):
2584         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2585         (LayoutTestController::setTimeout):
2586         (LayoutTestController::setShouldTimeout):
2587         (LayoutTestController):
2588         * DumpRenderTree/qt/main.cpp:
2589         (isOption):
2590         (printUsage):
2591         (main):
2592
2593 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2594
2595         Rubber-stamped by Martin Robinson.
2596
2597         * gtk/common.py:
2598         (get_build_path): Move test for current directory being a valid
2599         directory up so it takes precedence over WebKitBuild/Release and
2600         WebKitBuild/Debug when they exist as well.
2601
2602 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2603
2604         [GTK] doc rebasing does not respect DESTDIR
2605         https://bugs.webkit.org/show_bug.cgi?id=78177
2606
2607         Reviewed by Martin Robinson.
2608
2609         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
2610         calling it for rebasing.
2611         * gtk/generate-gtkdoc:
2612         (get_common_options): Handle the new --virtual-root option.
2613         * gtk/gtkdoc.py:
2614         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
2615         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
2616
2617 2012-02-08  Adam Barth  <abarth@webkit.org>
2618
2619         Remove Python 2.5 support from WebKit
2620         https://bugs.webkit.org/show_bug.cgi?id=71593
2621
2622         Reviewed by Eric Seidel.
2623
2624         This is the last vestige of our Python 2.5 support.
2625
2626         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2627         (AbstractQueueTest.test_log_from_script_error_for_upload):
2628
2629 2012-02-08  Adam Barth  <abarth@webkit.org>
2630
2631         version_check.py should inform users that we don't support Python 2.5 anymore
2632         https://bugs.webkit.org/show_bug.cgi?id=78179
2633
2634         Reviewed by Eric Seidel.
2635
2636         We don't support Python 2.5 anymore.
2637
2638         * Scripts/webkitpy/common/version_check.py:
2639
2640 2012-02-08  Adam Barth  <abarth@webkit.org>
2641
2642         test_configuration.py shouldn't re-implement itertools
2643         https://bugs.webkit.org/show_bug.cgi?id=78178
2644
2645         Reviewed by Eric Seidel.
2646
2647         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
2648         (TestConfigurationConverter.to_specifiers_list):
2649         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
2650         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
2651         (TestConfigurationConverter):
2652
2653 2012-02-08  Adam Barth  <abarth@webkit.org>
2654
2655         webkitpy should reply upon the multiprocessing package existing
2656         https://bugs.webkit.org/show_bug.cgi?id=78176
2657
2658         Reviewed by Eric Seidel.
2659
2660         Now that we don't support Python 2.5, this import can't fail.
2661
2662         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2663         (get):
2664         (_Process):
2665         (_Process.__init__):
2666         (_Process.run):
2667         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
2668         (FunctionTests.test_get__processes):
2669         (MultiProcessBrokerTests.setUp):
2670         * Scripts/webkitpy/layout_tests/port/base.py:
2671         (Port.__init__):
2672         (Port.default_worker_model):
2673         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2674         (ChromiumMacPort.check_build):
2675         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2676         (PortTestCase.test_default_worker_model):
2677         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2678
2679 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2680
2681         Unreviewed typo fix that makes docs build again for the gtk2-based
2682         library.
2683
2684         * gtk/generate-gtkdoc:
2685
2686 2012-02-08  Adam Barth  <abarth@webkit.org>
2687
2688         Don't re-implement ZipFile.extractall
2689         https://bugs.webkit.org/show_bug.cgi?id=78173
2690
2691         Reviewed by Eric Seidel.
2692
2693         We can use ZipFile.extractall now that we don't support Python 2.5.
2694
2695         * Scripts/webkitpy/common/system/autoinstall.py:
2696         (AutoInstaller._extract_targz):
2697         (AutoInstaller._unzip):
2698
2699 2012-02-08  Adam Barth  <abarth@webkit.org>
2700
2701         Remove the ospath compat shim from webkitpy
2702         https://bugs.webkit.org/show_bug.cgi?id=78170
2703
2704         Reviewed by Eric Seidel.
2705
2706         We no longer need this compat shim now that we don't support Python 2.5.
2707
2708         * Scripts/webkitpy/common/checkout/scm/git.py:
2709         * Scripts/webkitpy/common/checkout/scm/svn.py:
2710         * Scripts/webkitpy/common/system/filesystem.py:
2711         (FileSystem.relpath):
2712         * Scripts/webkitpy/common/system/filesystem_mock.py:
2713         (MockFileSystem.relpath):
2714         * Scripts/webkitpy/common/system/ospath.py: Removed.
2715         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
2716
2717 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2718
2719         Build fix attempt after r107053.
2720
2721         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2722         (test_collect_tests):
2723
2724 2012-02-08  Adam Barth  <abarth@webkit.org>
2725
2726         Remove simplejson because it's no longer used by webkitpy
2727         https://bugs.webkit.org/show_bug.cgi?id=78164
2728
2729         Reviewed by Eric Seidel.
2730
2731         All the importers of this code were removed in a previous patch.
2732
2733         * Scripts/webkitpy/thirdparty/simplejson: Removed.
2734         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
2735         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
2736         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
2737         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
2738         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
2739         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
2740         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
2741         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
2742         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
2743         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
2744
2745 2012-02-08  Adam Barth  <abarth@webkit.org>
2746
2747         webkitpy still imports simplejson
2748         https://bugs.webkit.org/show_bug.cgi?id=78161
2749
2750         Reviewed by Eric Seidel.
2751
2752         We no longer support Python 2.5, so we can rely upon Python's built-in
2753         JSON package.
2754
2755         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2756         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2757         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
2758         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2759         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2760         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2761         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2762         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2763         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2764         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2765         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2766
2767 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2768
2769         [GTK] Fails to build docs with non-standard build directories
2770         https://bugs.webkit.org/show_bug.cgi?id=78118
2771
2772         * gtk/common.py:
2773         (get_build_path): add comment to document changes done in r107098,
2774         as requested by the reviewer and forgotten by me.
2775
2776 2012-02-08  Adam Barth  <abarth@webkit.org>
2777
2778         Stop importing with_statement from the mysterious future
2779         https://bugs.webkit.org/show_bug.cgi?id=78156
2780
2781         Reviewed by Eric Seidel.
2782
2783         The future is now!  (Well, at least 2008, when Python 2.6 was released,
2784         is no longer the __future__.)
2785
2786         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2787         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2788         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2789         * Scripts/webkitpy/common/net/credentials_unittest.py:
2790         * Scripts/webkitpy/common/net/file_uploader.py:
2791         * Scripts/webkitpy/common/newstringio_unittest.py:
2792         * Scripts/webkitpy/common/system/autoinstall.py:
2793         * Scripts/webkitpy/common/system/crashlogs.py:
2794         * Scripts/webkitpy/common/system/fileset.py:
2795         * Scripts/webkitpy/common/system/filesystem.py:
2796         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2797         * Scripts/webkitpy/common/system/path.py:
2798         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
2799         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2800         * Scripts/webkitpy/layout_tests/port/base.py:
2801         (of):
2802         * Scripts/webkitpy/layout_tests/port/gtk.py:
2803         * Scripts/webkitpy/layout_tests/port/test.py:
2804         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2805         * Scripts/webkitpy/style/filereader_unittest.py:
2806         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2807         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2808         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2809         * Scripts/webkitpy/tool/commands/queues.py:
2810         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2811         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2812
2813 2012-02-08  Rob Buis  <rbuis@rim.com>
2814
2815         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2816         https://bugs.webkit.org/show_bug.cgi?id=78042
2817
2818         Reviewed by Antonio Gomes.
2819
2820         Upstream more parts of our DRT implementation.
2821
2822         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
2823         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
2824         * DumpRenderTree/blackberry/EventSender.cpp: Added.
2825         * DumpRenderTree/blackberry/EventSender.h: Added.
2826         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
2827         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
2828
2829 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
2830
2831         check-webkit-style failing with "Path does not exist."
2832         https://bugs.webkit.org/show_bug.cgi?id=77873
2833
2834         Reviewed by Ojan Vafai.
2835
2836         This change fixes the way the style checker determines which
2837         Port class to use for a given test_expectations.txt path; the
2838         previous version used a heuristic that didn't really work in the
2839         first place.
2840
2841         * Scripts/webkitpy/style/checkers/test_expectations.py:
2842         (TestExpectationsChecker._determine_port_from_expectations_path):
2843         (TestExpectationsChecker.__init__):
2844         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2845         (TestExpectationsTestCase._expect_port_for_expectations_path):
2846         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2847
2848 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
2849
2850         nrwt: make --skip-pixel-test-if-no-baseline option
2851         https://bugs.webkit.org/show_bug.cgi?id=70484
2852
2853         Reviewed by Dirk Pranke.
2854
2855         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2856         (SingleTestRunner.__init__):
2857         (SingleTestRunner._should_fetch_expected_checksum):
2858         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2859         (Worker.handle_test_list):
2860         * Scripts/webkitpy/layout_tests/models/test_input.py:
2861         (TestInput.__init__):
2862         * Scripts/webkitpy/layout_tests/port/webkit.py:
2863         (WebKitDriver.cmd_line):
2864         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2865         (_set_up_derived_options):
2866         (parse_args):
2867         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2868         (MainTest.test_skip_pixel_test_if_no_baseline_option):
2869         * WebKitTestRunner/TestController.cpp:
2870         (WTR::TestController::TestController):
2871         (WTR::TestController::initialize):
2872         (WTR::TestController::runTest):
2873         * WebKitTestRunner/TestController.h:
2874         (TestController):
2875         * WebKitTestRunner/TestInvocation.cpp:
2876         (WTR::TestInvocation::TestInvocation):
2877         (WTR::TestInvocation::setIsPixelTest):
2878         * WebKitTestRunner/TestInvocation.h:
2879         (WTR::TestInvocation::setSkipPixelTestOption):
2880         (TestInvocation):
2881
2882 2012-02-08  Rob Buis  <rbuis@rim.com>
2883
2884         [BlackBerry] Upstream DumpRenderTreeBlackBerry
2885         https://bugs.webkit.org/show_bug.cgi?id=78042
2886
2887         Reviewed by Antonio Gomes.
2888
2889         Add implementation for our DumpRenderTree solution.
2890
2891         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
2892         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
2893
2894 2012-02-08  Antti Koivisto  <antti@apple.com>
2895
2896         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
2897         https://bugs.webkit.org/show_bug.cgi?id=78080
2898
2899         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
2900         
2901         Add API test.
2902
2903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2904         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
2905         (TestWebKitAPI):
2906         (TestWebKitAPI::TEST):
2907
2908 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
2909
2910         [GTK] Fails to build docs with non-standard build directories
2911         https://bugs.webkit.org/show_bug.cgi?id=78118
2912
2913         Reviewed by Martin Robinson.
2914
2915         * gtk/common.py:
2916         (get_build_path): also try the current directory as a valid build
2917         dir, which makes non-standard build directories such as build-2.0
2918         and build-3.0 work
2919
2920 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2921
2922         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
2923         https://bugs.webkit.org/show_bug.cgi?id=78099
2924
2925         Reviewed by Martin Robinson.
2926
2927         * MiniBrowser/gtk/BrowserWindow.c:
2928         (webViewDecidePolicy): Check whether it's a link clicked with the
2929         middle mouse button and load the request in a new window.
2930         (browserWindowConstructed): Connect to
2931         WebKitWebView::decide-policy signal.
2932
2933 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
2934
2935         Revert a part of the change in r106687 as a build fix.
2936
2937         Since Chromium port doesn't checkout the entire WebKit trunk,
2938         we can't run "svn info" on webkit_base.
2939
2940         * Scripts/webkitpy/layout_tests/port/base.py:
2941         (Port.repository_paths):
2942
2943 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
2944
2945         run-perf-tests doesn't recognize paths that start with PerformanceTests
2946         https://bugs.webkit.org/show_bug.cgi?id=78012
2947
2948         Reviewed by Adam Barth.
2949
2950         Use resolve paths using filesystem.relpath before passing it to find_files.find.
2951
2952         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2953         (PerfTestsRunner):
2954         (PerfTestsRunner._collect_tests):
2955         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2956         (test_collect_tests):
2957         (test_collect_tests.add_file):
2958
2959 2012-02-07  Justin Novosad  <junov@chromium.org>
2960
2961         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
2962         https://bugs.webkit.org/show_bug.cgi?id=78039
2963
2964         Reviewed by Stephen White.
2965
2966         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
2967
2968         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2969         (main):
2970         * DumpRenderTree/chromium/TestShell.cpp:
2971         (TestShell::TestShell):
2972         (TestShell::resetWebSettings):
2973         (TestShell::runFileTest):
2974         * DumpRenderTree/chromium/TestShell.h:
2975         (TestShell::setDeferred2dCanvasEnabled):
2976         (TestShell):
2977         * DumpRenderTree/chromium/WebPreferences.cpp:
2978         (WebPreferences::reset):
2979         (WebPreferences::applyTo):
2980         * DumpRenderTree/chromium/WebPreferences.h:
2981         (WebPreferences):
2982
2983 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2984
2985         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
2986         https://bugs.webkit.org/show_bug.cgi?id=77928
2987
2988         Reviewed by Daniel Bates.
2989
2990         CMake has used *Programs* directory for executable. In addition, shared libraries are being
2991         built in source directory. It is better to set common places in order to maintain executable
2992         and libraries. *bin* is for executable and *lib* is for library.
2993
2994         * DumpRenderTree/efl/CMakeLists.txt:
2995         * EWebLauncher/CMakeLists.txt:
2996         * Scripts/run-launcher:
2997         * Scripts/webkitdirs.pm:
2998         (jscProductDir):
2999         * Scripts/webkitpy/layout_tests/port/efl.py:
3000         (EflPort._path_to_driver):
3001         (EflPort._path_to_image_diff):
3002
3003 2012-02-07  Adam Klein  <adamk@chromium.org>
3004
3005         Add JSC support for delivering mutations when the outermost script context exits
3006         https://bugs.webkit.org/show_bug.cgi?id=70289
3007
3008         Reviewed by Eric Seidel.
3009
3010         * DumpRenderTree/mac/EventSendingController.mm: Add support for
3011         eventSender.scheduleAsynchronousKeyDown.
3012         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3013         (+[EventSendingController webScriptNameForSelector:]):
3014         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
3015         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
3016         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
3017
3018 2012-02-07  Chris Rogers  <crogers@google.com>
3019
3020         Add Chris Rogers to reviewers section
3021         https://bugs.webkit.org/show_bug.cgi?id=78016
3022
3023         Reviewed by Adam Barth.
3024
3025         * Scripts/webkitpy/common/config/committers.py:
3026
3027 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
3028
3029         layoutTestController.display() is flaky for SVG tests
3030         https://bugs.webkit.org/show_bug.cgi?id=78021
3031
3032         Reviewed by Dan Bernstein.
3033
3034         Fix race condition in repaint rect tracking. When running a test using the repaint.js
3035         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
3036         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
3037         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
3038         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
3039         the repaint test already run, thus invalidating the previously tracked repaint rects.
3040
3041         * DumpRenderTree/mac/DumpRenderTree.mm:
3042         (dump):
3043         (runTest):
3044
3045 2012-02-07  Hans Wennborg  <hans@chromium.org>
3046
3047         Chromium: remove WebSpeechInputResult::set
3048         https://bugs.webkit.org/show_bug.cgi?id=77977
3049
3050         Reviewed by Darin Fisher.
3051
3052         It was renamed to assign() in r106475.
3053
3054         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
3055         (makeRectResult):
3056
3057 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3058
3059         [Qt] Give emulated touch-point a radius
3060         https://bugs.webkit.org/show_bug.cgi?id=77985
3061         
3062         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
3063
3064         Reviewed by Kenneth Rohde Christiansen.
3065
3066         * MiniBrowser/qt/BrowserWindow.cpp:
3067         (BrowserWindow::updateVisualMockTouchPoints):
3068         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3069         (MiniBrowserApplication::notify):
3070         * MiniBrowser/qt/qml/MockTouchPoint.qml:
3071
3072 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
3073
3074         [GTK] Include gdk-pixbuf in the jhbuild modules
3075         https://bugs.webkit.org/show_bug.cgi?id=77980
3076
3077         Reviewed by Gustavo Noronha Silva.
3078
3079         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
3080
3081 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
3082
3083         [Qt] Prevent early test termination with newer Qt 5
3084         https://bugs.webkit.org/show_bug.cgi?id=77945
3085
3086         Reviewed by Csaba Osztrogonác.
3087
3088         QTBUG-24120 tracks a regression in Qt that would make layout tests
3089         terminate early. This patch works around it in a Qt 4 + 5 safe manner
3090         by disabling the quitOnLastWindowClosed feature, which we don't want/need
3091         for DRT anyway.
3092
3093         * DumpRenderTree/qt/main.cpp:
3094         (main): Don't quit on last window closed.
3095
3096 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3097
3098         Fix some miscellaneous 'make dist' error for WebKitGTK+.
3099
3100         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
3101         files should not be distributed.
3102
3103 2012-02-02  Hajime Morrita  <morrita@chromium.org>
3104
3105         [PerformanceTests] Each Dromaeo test needs its landing html.
3106         https://bugs.webkit.org/show_bug.cgi?id=77504
3107
3108         Reviewed by Ryosuke Niwa.
3109
3110         Added an ignorable pattern which happens in some Dromaeo tests.
3111
3112         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3113         (PerfTestsRunner):
3114
3115 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
3116
3117         [GTK] Add missing pango include dir to fix build
3118         https://bugs.webkit.org/show_bug.cgi?id=77832
3119
3120         Reviewed by Martin Robinson.
3121
3122         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
3123
3124 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
3125
3126         [GTK] Fix remaining errors in GTK+ WebKit2 API
3127         https://bugs.webkit.org/show_bug.cgi?id=77890
3128
3129         Reviewed by Gustavo Noronha Silva.
3130
3131         Verify that WebKit2 GTK+ test files are not skipped during style checks.
3132         Skip soup_server_new when checking for NULL versus 0 usage.
3133
3134         * Scripts/webkitpy/style/checker_unittest.py:
3135         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3136         * Scripts/webkitpy/style/checkers/cpp.py:
3137         (check_for_null):
3138
3139 2012-02-06  Eric Seidel  <eric@webkit.org>
3140
3141         webkit-patch apply-from-bug should be able to apply non-reviewed patches
3142         https://bugs.webkit.org/show_bug.cgi?id=77883
3143
3144         Reviewed by Adam Barth.
3145
3146         This is very helpful if you use bugzilla as a replacement for git-stash.
3147         Makes it simpler to re-apply the patch w/o having to look up the patch id.
3148
3149         * Scripts/webkitpy/tool/commands/download.py:
3150         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3151         * Scripts/webkitpy/tool/commands/download_unittest.py:
3152         (DownloadCommandsTest.test_apply_from_bug):
3153
3154 2012-02-06  Philippe Normand  <pnormand@igalia.com>
3155
3156         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
3157         https://bugs.webkit.org/show_bug.cgi?id=77866
3158
3159         Reviewed by Martin Robinson.
3160
3161         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
3162         errors in some gstreamer source code files defining new GStreamer elements.
3163         * Scripts/webkitpy/style/checker_unittest.py:
3164         (GlobalVariablesTest.test_path_rules_specifier):
3165
3166 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3167
3168         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
3169         https://bugs.webkit.org/show_bug.cgi?id=77869
3170
3171         Reviewed by Philippe Normand.
3172
3173         * gtk/gtkdoc.py:
3174         (GTKDoc.rebase_installed_docs): Check html_dir exists.
3175
3176 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3177
3178         [Qt] Don't version QtWebKit.experimental.
3179         https://bugs.webkit.org/show_bug.cgi?id=77739
3180
3181         Reviewed by Tor Arne Vestbø.
3182
3183         * MiniBrowser/qt/qml/BrowserWindow.qml:
3184
3185 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3186
3187         [GTK] Fix several gtkdoc-fixxref warnings
3188         https://bugs.webkit.org/show_bug.cgi?id=77613
3189
3190         Reviewed by Martin Robinson.
3191
3192         * gtk/generate-gtkdoc:
3193         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
3194         of ignored files, since it's private.
3195         * gtk/gtkdoc.py:
3196         (GTKDoc._ignored_files_basenames): Helper function that returns a
3197         string with the list of ignored files basenames separated by a
3198         spaces, as expected by several gtkdoc commands.
3199         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
3200         --ignore-headers option.
3201         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
3202         --ignore-files option.
3203
3204 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3205
3206         [GTK] Fix xrefs after installing API documentation
3207         https://bugs.webkit.org/show_bug.cgi?id=77551
3208
3209         Reviewed by Martin Robinson.
3210
3211         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
3212         api docs.
3213         * gtk/common.py:
3214         (prefix_of_pkg_config_file): Get the prefix variable of the given
3215         pkg-config file.
3216         (gtk_version_of_pkg_config_file): Get the gtk version required by
3217         the given pkg-config file.
3218         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
3219         installed documentation.
3220         (get_gtkdoc_module_paths): Get paths where API doc is installed
3221         for the dependencies of the given pkg-config file.
3222         (get_common_xref_deps): Get API doc directories of dependencies
3223         common to WebKit1 and WebKit2.
3224         (get_webkit2_options): Add cross_reference_deps option.
3225         (get_webkit1_options): Ditto
3226         (rebase_installed_docs): Helper function to create a generator for
3227         the given pkg-config file and options and call rebase_installed_docs.
3228         * gtk/gtkdoc.py:
3229         (GTKDoc.__init__): Initialize cross_reference_deps.
3230         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
3231         dependencies.
3232         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
3233         links of installed documentation.
3234         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
3235         file.
3236
3237 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
3238
3239         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
3240         https://bugs.webkit.org/show_bug.cgi?id=77672
3241
3242         Reviewed by Dirk Pranke.
3243
3244         Test repetitions must be taken into account when working out
3245         the statistics shown by run-webkit-tests.
3246
3247         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3248         (Manager.prepare_lists_and_print_output):
3249         (Manager._print_result_summary):
3250         * Scripts/webkitpy/layout_tests/models/result_summary.py:
3251         (ResultSummary.__init__):
3252         (ResultSummary.add):
3253         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3254         (MainTest.test_repeat_each_iterations_num_tests):
3255
3256 2012-02-05  Dan Bernstein  <mitz@apple.com>
3257
3258         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
3259         https://bugs.webkit.org/show_bug.cgi?id=77823
3260
3261         Reviewed by Anders Carlsson.
3262
3263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3264         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3265
3266 2012-02-04  Dan Bernstein  <mitz@apple.com>
3267
3268         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
3269         https://bugs.webkit.org/show_bug.cgi?id=77822
3270
3271         Reviewed by Sam Weinig.
3272
3273         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3274         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
3275
3276 2012-02-04  Sam Weinig  <sam@webkit.org>
3277
3278         Add ability to send WKURLRequests in WebKit2 API user messages
3279         https://bugs.webkit.org/show_bug.cgi?id=77819
3280
3281         Reviewed by Anders Carlsson.
3282
3283         Add testing for round-tripping WKTypes from the UIProcess,
3284         to the WebProcess, and back.
3285
3286         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
3287           More can easily be added.
3288
3289         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3290         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
3291         (TestWebKitAPI):
3292         (WebKit2UserMessageRoundTripTest):
3293         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
3294         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
3295         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
3296         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
3297         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3298         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
3299         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
3300         (TestWebKitAPI::TEST_F):
3301         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
3302         (TestWebKitAPI):
3303         (UserMessageTest):
3304         (TestWebKitAPI::UserMessageTest::UserMessageTest):
3305         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
3306         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3307         (TestWebKitAPI::PlatformWebView::resizeTo):
3308         (TestWebKitAPI):
3309         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3310         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3311
3312 2012-02-04  Dan Bernstein  <mitz@apple.com>
3313
3314         <rdar://problem/10772406> WKPreferences instances cannot be copied
3315         https://bugs.webkit.org/show_bug.cgi?id=77816
3316
3317         Reviewed by Sam Weinig.
3318
3319         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3320         (TestWebKitAPI::TEST):
3321
3322 2012-02-04  Adam Barth  <abarth@webkit.org>
3323
3324         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
3325         https://bugs.webkit.org/show_bug.cgi?id=77802
3326
3327         Reviewed by Eric Seidel.
3328
3329         This patch refactors our directory grouping code into base.js where it
3330         can be shared between failures.js and notifications.js.  It then adds
3331         an Examine action to each group of failures that triggers the "results"
3332         view.
3333
3334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3339         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3340
3341 2012-02-04  Ojan Vafai  <ojan@chromium.org>
3342
3343         check-webkit-style is throwing an exception
3344         https://bugs.webkit.org/show_bug.cgi?id=77744
3345
3346         Reviewed by David Levin.
3347
3348         If the test_list is None, then we don't need to check for unsupported
3349         feature tests to skip.
3350
3351         * Scripts/webkitpy/layout_tests/port/webkit.py:
3352         (WebKitPort._has_test_in_directories):
3353         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3354         (test_skipped_tests_for_unsupported_features_empty_test_list):
3355
3356 2012-02-03  Adam Barth  <abarth@webkit.org>
3357
3358         List of all failures in garden-o-matic should actually list all the failures
3359         https://bugs.webkit.org/show_bug.cgi?id=77796
3360
3361         Reviewed by Eric Seidel.
3362
3363         This patch wires a bit more data into the new "All Failures" tab.  I've
3364         also iterated on how we enable this experimental feature.  The tab is
3365         still just a dumb list, but we'll make it smarter.
3366
3367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3371
3372 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3373
3374         Windows build fix after r106692.
3375
3376         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3377         (PortTest.test_reference_files):
3378
3379 2012-02-03  Beth Dakin  <bdakin@apple.com>
3380
3381         https://bugs.webkit.org/show_bug.cgi?id=77782
3382         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
3383         once on some pages with frames
3384         -and corresponding-
3385         <rdar://problem/10798474>
3386
3387         Reviewed by Sam Weinig.
3388
3389         One new test.
3390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3391         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
3392         (TestWebKitAPI):
3393         (TestWebKitAPI::didForceRepaint):
3394         (TestWebKitAPI::didFinishLoadForFrame):
3395         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
3396         (TestWebKitAPI::setPageLoaderClient):
3397         (TestWebKitAPI::TEST):
3398         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
3399         (TestWebKitAPI):
3400         (NewFirstVisuallyNonEmptyLayoutFramesTest):
3401         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
3402         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
3403         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
3404
3405 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3406
3407         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
3408         https://bugs.webkit.org/show_bug.cgi?id=77781
3409
3410         Reviewed by Eric Seidel.
3411
3412         This change fixes a couple of issues discovered while debugging
3413         test-webkitpy; both calling exit() instead of sys.exit() --
3414         which is discouraged in program code instead of the interpreter
3415         -- and a particular usage of outputcapture were stdin to get whacked
3416         and preventing debugging.
3417        
3418         This change introduces a couple of common _exit() methods that
3419         will standardize how webkit-patch exit's, in case we need to do
3420         something different in the future.
3421
3422         * Scripts/webkitpy/common/system/deprecated_logging.py:
3423         (error):
3424         * Scripts/webkitpy/common/system/outputcapture.py:
3425         (OutputCapture.assert_outputs):
3426         * Scripts/webkitpy/tool/bot/queueengine.py:
3427         (QueueEngine.exit_after_handled_error):
3428         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3429         (AbstractSequencedCommand.execute):
3430         * Scripts/webkitpy/tool/commands/queues.py:
3431         (StyleQueue.handle_script_error):
3432         * Scripts/webkitpy/tool/commands/upload.py:
3433         (MarkBugFixed.execute):
3434         * Scripts/webkitpy/tool/multicommandtool.py:
3435         (Command._exit):
3436         * Scripts/webkitpy/tool/steps/abstractstep.py:
3437         (AbstractStep._exit):
3438         * Scripts/webkitpy/tool/steps/checkstyle.py:
3439         (CheckStyle.run):
3440         * Scripts/webkitpy/tool/steps/commit.py:
3441         (Commit._check_test_expectations):
3442         * Scripts/webkitpy/tool/steps/confirmdiff.py:
3443         (ConfirmDiff.run):
3444
3445 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3446
3447         Perf bot build fix.
3448
3449         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3450         (PerfTestsRunner._generate_json):
3451
3452 2012-02-03  Adam Barth  <abarth@webkit.org>
3453
3454         Add a blank "Expected Failures" tab to garden-o-matic
3455         https://bugs.webkit.org/show_bug.cgi?id=77793
3456
3457         Reviewed by Eric Seidel.
3458
3459         This tab will help us explore and manage our expected failures.  The
3460         tab is hidden by default via a new "experimental features" flag.
3461
3462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
3467         (#unexpected):
3468         (#onebar.partytime #unexpected):
3469
3470 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3471
3472         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
3473         https://bugs.webkit.org/show_bug.cgi?id=77785
3474
3475         Fix the build bots.
3476         
3477         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
3478
3479         * Scripts/update-webkit-support-libs:
3480         (downloadExpectedVersionNumber):
3481
3482 2012-02-03  Lucas Forschler  <lforschler@apple.com>
3483
3484         Add a Mac Lion Performance bot.
3485         https://bugs.webkit.org/show_bug.cgi?id=77765
3486
3487         Reviewed by Adam Roben.
3488
3489         This will update the master configuration in the following ways:
3490             Add a new performance slave (apple-xseve-11)
3491             Add a new Factory to download a build and run perf tests.
3492             
3493         * BuildSlaveSupport/build.webkit.org-config/config.json:
3494         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3495         (DownloadAndPerfTestFactory):
3496         (DownloadAndPerfTestFactory.__init__):
3497
3498 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
3499
3500         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
3501         https://bugs.webkit.org/show_bug.cgi?id=77752
3502
3503         Reviewed by James Robinson.
3504
3505         Delete unneeded file accidentally checked in in r106481.
3506
3507         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
3508
3509 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3510
3511         Ref Tests should support plain SVG files
3512         https://bugs.webkit.org/show_bug.cgi?id=77685
3513
3514         Reviewed by Tony Chang.
3515
3516         Don't assume reference files always use .html as the extension.
3517         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
3518
3519         Also fix various bugs in MockFileSystem and TestPort.
3520
3521         * Scripts/webkitpy/common/system/filesystem_mock.py:
3522         (MockFileSystem.isdir):
3523         * Scripts/webkitpy/layout_tests/port/base.py:
3524         (Port.reference_files):
3525         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3526         (PortTest.test_is_test_file):
3527         (PortTest.test_reference_files):
3528         * Scripts/webkitpy/layout_tests/port/test.py:
3529         (TestInstance.__init__):
3530
3531 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3532
3533         perf-o-matic should store chromium svn revision
3534         https://bugs.webkit.org/show_bug.cgi?id=77725
3535
3536         Reviewed by Dirk Pranke.
3537
3538         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
3539         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
3540         is implemented in terms of newly added svn_revision.
3541
3542         * Scripts/webkitpy/common/checkout/scm/git.py:
3543         (Git.svn_revision):
3544         * Scripts/webkitpy/common/checkout/scm/scm.py:
3545         (SCM.head_svn_revision):
3546         (SCM):
3547         (SCM.svn_revision):
3548         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
3549         (MockSCM.svn_revision):
3550         * Scripts/webkitpy/common/checkout/scm/svn.py:
3551         (SVN.svn_revision):
3552         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3553         (JSONLayoutResultsGenerator.__init__):
3554         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3555         (JSONResultsGeneratorBase._insert_generic_metadata):
3556         * Scripts/webkitpy/layout_tests/port/base.py:
3557         (Port.repository_paths):
3558         * Scripts/webkitpy/layout_tests/port/chromium.py:
3559         (ChromiumPort.repository_paths):
3560         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3561         (PerfTestsRunner._generate_json):
3562         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3563         (test_run_test_set_with_json_output):
3564         (test_run_test_set_with_json_source):
3565         (test_run_test_set_with_multiple_repositories):
3566
3567 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3568
3569         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
3570         https://bugs.webkit.org/show_bug.cgi?id=77632
3571
3572         Reviewed by Kenneth Rohde Christiansen.
3573
3574         * MiniBrowser/qt/BrowserWindow.cpp:
3575         (BrowserWindow::BrowserWindow):
3576         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3577         (MiniBrowserApplication::sendTouchEvent):
3578         (MiniBrowserApplication::handleUserOptions):
3579         * MiniBrowser/qt/MiniBrowserApplication.h:
3580         (WindowOptions):
3581         (WindowOptions::WindowOptions):
3582         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3583         (WTR::PlatformWebView::PlatformWebView):
3584         * WebKitTestRunner/qt/main.cpp:
3585         (main):
3586         * qmake/mkspecs/features/default_post.prf:
3587
3588 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
3589
3590         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
3591         https://bugs.webkit.org/show_bug.cgi?id=77723
3592
3593         Reviewed by Tor Arne Vestbø.
3594
3595         * Tools.pro: Compile WTR again on all platforms with WK2.
3596
3597 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
3598
3599         Ensure that inspector disabled build works
3600         https://bugs.webkit.org/show_bug.cgi?id=77604
3601
3602         Reviewed by Tor Arne Vestbø.
3603
3604         * qmake/mkspecs/features/features.prf:
3605
3606 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
3607
3608         [chromium] add support for --makeargs to the ninja-based build
3609         https://bugs.webkit.org/show_bug.cgi?id=77688
3610
3611         Reviewed by Adam Barth.
3612
3613         * Scripts/webkitdirs.pm:
3614         (buildChromiumNinja):
3615
3616 2012-02-02  Eric Seidel  <eric@webkit.org>
3617
3618         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
3619         https://bugs.webkit.org/show_bug.cgi?id=75145
3620
3621         Reviewed by Dirk Pranke.
3622
3623         * Scripts/webkitpy/layout_tests/port/mac.py:
3624         (MacPort.default_child_processes):
3625         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3626         (test_operating_system):
3627         (test_default_child_processes):
3628
3629 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
3630
3631        nrwt shouldn't blow up when there are errors in test_expectations.txt
3632        https://bugs.webkit.org/show_bug.cgi?id=73603
3633
3634        Reviewed by Ojan Vafai.
3635
3636        This change removes the distinction between 'errors' and 'warnings'
3637        in the test expectations parser. Now, any problem is a
3638        'warning', and if we are linting the file, warnings become fatal (errors).
3639
3640         This will allow a normal run-webkit-tests run to proceed even if
3641         there are bad lines.
3642
3643         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3644         (ParseError.__init__):
3645         (ParseError.__str__):
3646         (ParseError.__repr__):
3647         (TestExpectationSerializer.to_string):
3648         (TestExpectationParser._parse_modifiers):
3649         (TestExpectationParser._parse_expectations):
3650         (TestExpectationParser._check_modifiers_against_expectations):
3651         (TestExpectationParser._tokenize):
3652         (TestExpectationLine.__init__):
3653         (TestExpectationLine.is_invalid):
3654         (TestExpectationsModel.add_expectation_line):
3655         (TestExpectationsModel._already_seen_better_match):
3656         (TestExpectations.__init__):
3657         (TestExpectations._report_warnings):
3658         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
3659         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3660         (assert_bad_expectations):
3661         (test_parse_warning):
3662         (test_overrides__duplicate):
3663         (ExpectationSyntaxTests.test_missing_expectation):
3664         (ExpectationSyntaxTests.test_missing_colon):
3665         (ExpectationSyntaxTests.test_too_many_colons):
3666         (ExpectationSyntaxTests.test_too_many_equals_signs):
3667         (ExpectationSyntaxTests.test_unrecognized_expectation):
3668         (SemanticTests.test_bug_format):
3669         (SemanticTests.test_bad_bugid):
3670         (SemanticTests.test_slow_and_timeout):
3671         (test_ambiguous):
3672         (test_more_modifiers):
3673         (test_order_in_file):
3674         (test_macro_overrides):
3675         (RebaseliningTest.assertRemove):
3676         (TestExpectationParserTests.test_tokenize_blank):
3677         (TestExpectationParserTests.test_tokenize_missing_colon):
3678         (TestExpectationParserTests.test_tokenize_extra_colon):
3679         (TestExpectationParserTests.test_tokenize_empty_comment):
3680         (TestExpectationParserTests.test_tokenize_comment):
3681         (TestExpectationParserTests.test_tokenize_missing_equal):
3682         (TestExpectationParserTests.test_tokenize_extra_equal):
3683         (TestExpectationParserTests.test_tokenize_valid):
3684         (TestExpectationParserTests.test_tokenize_valid_with_comment):
3685         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
3686         (TestExpectationSerializerTests.test_unparsed_to_string):
3687         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3688         (lint):
3689         * Scripts/webkitpy/style/checkers/test_expectations.py:
3690         (TestExpectationsChecker.check_test_expectations):
3691
3692 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3693
3694         Unreviewed, rolling out r106543.
3695         http://trac.webkit.org/changeset/106543
3696         https://bugs.webkit.org/show_bug.cgi?id=77671
3697
3698         Made tests less stable (Requested by rniwa on #webkit).
3699
3700         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3701         (PerfTestsRunner):
3702         (PerfTestsRunner.__init__):
3703         (PerfTestsRunner._run_tests_set):
3704         (PerfTestsRunner._run_single_test):
3705         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3706         (MainTest.TestDriver.run_test):
3707         (run_test):
3708
3709 2012-02-02  Beth Dakin  <bdakin@apple.com>
3710
3711         https://bugs.webkit.org/show_bug.cgi?id=77664
3712         Add API tests for didNewFirstVisuallyNonEmptyLayout
3713
3714         Reviewed by Darin Adler.