0f53680c911569ad37840e8c7a8880dfe2fe7457
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
2
3         Add a layout mode for computing fixed layout size from a minimum size
4         https://bugs.webkit.org/show_bug.cgi?id=144610
5         <rdar://problem/19790341>
6
7         Reviewed by Simon Fraser.
8
9         * MiniBrowser/mac/BrowserWindow.xib:
10         * MiniBrowser/mac/BrowserWindowController.h:
11         * MiniBrowser/mac/WK1BrowserWindowController.m:
12         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
13         * MiniBrowser/mac/WK2BrowserWindowController.m:
14         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
15         Add a optional toolbar item to toggle a minimum view size of 1024x0.
16
17 2015-05-05  Alex Christensen  <achristensen@webkit.org>
18
19         [Content Extensions] Release input NSString when finished copying it.
20         https://bugs.webkit.org/show_bug.cgi?id=144642
21
22         Reviewed by Brian Weinstein.
23
24         * WebKitTestRunner/mac/TestControllerMac.mm:
25         (WTR::TestController::platformConfigureViewForTest):
26         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
27
28 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
29
30         Unreviewed test fix after r183798.
31
32         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
33         (convertToDRTLabel): Mimic behavior of Mac accessibility output
34         so we can share results.
35
36 2015-05-05  Alex Christensen  <achristensen@webkit.org>
37
38         [Content Extensions] Use less memory to store the json input.
39         https://bugs.webkit.org/show_bug.cgi?id=144604
40
41         Reviewed by Benjamin Poulain.
42
43         * MiniBrowser/mac/ExtensionManagerWindowController.m:
44         (-[ExtensionManagerWindowController add:]):
45         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
46         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
47         * WebKitTestRunner/mac/TestControllerMac.mm:
48         (WTR::TestController::platformConfigureViewForTest):
49
50 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
51
52         Unreviewed. Make myself a WebKit reviewer.
53
54         * Scripts/webkitpy/common/config/contributors.json:
55
56 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
57
58         [GTK] r183783 breaks build
59         https://bugs.webkit.org/show_bug.cgi?id=144632
60
61         Reviewed by Martin Robinson.
62
63         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
64
65         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
66         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
67
68 2015-05-05  Alex Christensen  <achristensen@webkit.org>
69
70         [Content Extensions] Combine NFAs properly and free memory as we compile.
71         https://bugs.webkit.org/show_bug.cgi?id=144485
72
73         Reviewed by Benjamin Poulain.
74
75         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
76         (TestWebKitAPI::TEST_F):
77         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
78         Added tests for deep NFAs.
79
80 2015-05-04  Alex Christensen  <achristensen@webkit.org>
81
82         [Content Extensions] Use less memory when writing byte code to file
83         https://bugs.webkit.org/show_bug.cgi?id=144602
84
85         Reviewed by Darin Adler.
86
87         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
88
89 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
90
91         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
92         https://bugs.webkit.org/show_bug.cgi?id=144541
93
94         Reviewed by Žan Doberšek.
95
96         Add a test case to WorkQueue unit test, to check that sources of
97         asynchronous IO operations running in the WorkQueue thread are
98         dispatched by the WorkQueue main loop.
99
100         * TestWebKitAPI/PlatformGTK.cmake:
101         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
102         (TestWebKitAPI::TEST):
103
104 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
105
106         Correct '--show-webview' option for Tiled Drawing tests
107         https://bugs.webkit.org/show_bug.cgi?id=144621
108
109         Reviewed by Simon Fraser.
110
111         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
112         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
113
114         * WebKitTestRunner/mac/TestControllerMac.mm:
115         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
116         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
117
118 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
119
120         Large array shouldn't be slow
121         https://bugs.webkit.org/show_bug.cgi?id=144617
122
123         Reviewed by Geoffrey Garen.
124         
125         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
126         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
127         long-running. So, hash-map sort of belongs here.
128
129         * Scripts/run-jsc-benchmarks:
130
131 2015-05-04  Doug Russell  <d_russell@apple.com>
132
133         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
134         https://bugs.webkit.org/show_bug.cgi?id=144489
135
136         Reviewed by Chris Fleizach.
137
138         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
139         on the returned control.
140         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
141         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
142         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
143         Add support for setSelectedVisibleTextRange() in accessibility tests.
144
145         * DumpRenderTree/AccessibilityUIElement.cpp:
146         (setSelectedVisibleTextRangeCallback):
147         (AccessibilityUIElement::setSelectedVisibleTextRange):
148         (AccessibilityUIElement::getJSClass):
149         (AccessibilityUIElement::textMarkerForIndex): Deleted.
150         * DumpRenderTree/AccessibilityUIElement.h:
151         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
152         (AccessibilityUIElement::setSelectedVisibleTextRange):
153         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
154         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
155         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
156         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
157         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
159         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
160         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
161         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
162         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
163         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
164
165 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
166
167         [Win] Implement the "--show-webview" option for Windows
168         https://bugs.webkit.org/show_bug.cgi?id=144589
169
170         Reviewed by Alex Christensen.
171
172         Add another runtime flag (--show-webview) that causes DumpRenderTree
173         to draw its view on-screen, rather than the standard offscreen mode.
174
175         * DumpRenderTree/win/DumpRenderTree.cpp:
176         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
177         (initializeGlobalsFromCommandLineOptions): Recognize the new
178         command-line argument, and set the global 'showWebView' state if
179         appropriate.
180
181 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
182
183         Remove dead code from TestInvocationCairo.cpp
184         https://bugs.webkit.org/show_bug.cgi?id=144564
185
186         Reviewed by Gyuyoung Kim.
187
188         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
189
190         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
191         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
192
193 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
194
195         [GTK] Add libnotify in gtk install-dependencies
196         https://bugs.webkit.org/show_bug.cgi?id=144379
197
198         Reviewed by Csaba Osztrogonác.
199
200         * gtk/install-dependencies:
201
202 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
203
204         check-webkit-style fails due to system pylint
205         https://bugs.webkit.org/show_bug.cgi?id=144360
206
207         Reviewed by Darin Adler.
208
209         Make sure that the directory containing third party autoinstalled modules
210         is at the beginning of the search path, to avoid conflicts with other
211         versions of the same modules installed in the system (e.g. pylint).
212
213         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
214         modules directory to sys.path, instead of appending it.
215
216 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
217
218         Unreviewed, updated my list of email addresses.
219
220         * Scripts/webkitpy/common/config/contributors.json: Updated.
221
222 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
223
224         USE(...) macro should expect unprefixed variables
225         https://bugs.webkit.org/show_bug.cgi?id=144454
226
227         Reviewed by Daniel Bates.
228
229         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
230         * DumpRenderTree/config.h: Ditto.
231         * TestWebKitAPI/config.h: Ditto.
232
233 2015-05-01  Basile Clement  <basile_clement@apple.com>
234
235         Unreviewed. Add myself as a commiter in contributors.json.
236
237         * Scripts/webkitpy/common/config/contributors.json:
238
239 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
240
241         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
242         https://bugs.webkit.org/show_bug.cgi?id=144487
243
244         Reviewed by Ryosuke Niwa.
245
246         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
247         (BenchmarkRunner.merge): Fix bug.
248         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
249
250 2015-05-01  Brady Eidson  <beidson@apple.com>
251
252         Add API to disable meta refreshes.
253         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
254
255         Reviewed by Alexey Proskuryakov.
256
257         * DumpRenderTree/mac/DumpRenderTree.mm:
258         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
259
260 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
261
262         Provide a runtime flag to run-webkit-tests that shows the test view
263         https://bugs.webkit.org/show_bug.cgi?id=144079.
264
265         Unreviewed correction to r183651.
266
267         * WebKitTestRunner/TestController.cpp:
268         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
269         flag is included in the options dictionary passed to the PlatformWebView.
270
271 2015-05-01  Antti Koivisto  <antti@apple.com>
272
273         Remove network process load serialization code
274         https://bugs.webkit.org/show_bug.cgi?id=144448
275
276         Reviewed by Alexey Proskuryakov.
277
278         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
279         (WTR::InjectedBundle::beginTesting):
280         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
281         (WTR::TestRunner::setSerializeHTTPLoads):
282         (WTR::TestRunner::dispatchPendingLoadRequests):
283
284 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
285
286         [GTK] Add libhyphen-dev to the build dependencies
287         https://bugs.webkit.org/show_bug.cgi?id=144452
288
289         Reviewed by Martin Robinson.
290
291         * gtk/install-dependencies: Added hyphen as Fedora and Arch
292         dependencies.
293
294 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
295
296         Provide a runtime flag to run-webkit-tests that shows the test view
297         https://bugs.webkit.org/show_bug.cgi?id=144079.
298
299         Reviewed by Dean Jackson.
300
301         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
302         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
303         option:
304         
305         --additional-drt-flag="--show-webview"
306
307         * DumpRenderTree/mac/DumpRenderTree.mm:
308         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
309         '--show-webview' flag.
310         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
311         * WebKitTestRunner/Options.cpp:
312         (WTR::Options::Options):
313         (WTR::handleOptionShowWebView):
314         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
315         * WebKitTestRunner/Options.h:
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::TestController):
318         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
319         * WebKitTestRunner/TestController.h:
320         (WTR::TestController::shouldShowWebView):
321         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
322         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
323         options dictionary. If it is true, display the web view while running the test.
324
325 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
326
327         r183355 didn't trigger Mac tests
328         https://bugs.webkit.org/show_bug.cgi?id=144464
329
330         Reviewed by Simon Fraser.
331
332         Update badly neglected filters and unit tests.
333
334         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
335         (_should_file_trigger_build):
336         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
337         (ShouldBuildTest):
338         (ShouldBuildTest.test_should_build):
339
340 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
341
342         [GTK] Add libhyphen-dev to the build dependencies
343         https://bugs.webkit.org/show_bug.cgi?id=144452
344
345         Reviewed by Martin Robinson.
346
347         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
348         build dependencies.
349
350 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
351
352         [GTK] Testing dictionaries are not installed automatically
353         https://bugs.webkit.org/show_bug.cgi?id=144460
354
355         Reviewed by Carlos Garcia Campos.
356
357         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
358
359 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
360
361         Fix return code issue, check return code of safari process and dump results to log
362         https://bugs.webkit.org/show_bug.cgi?id=144436
363
364         Reviewed by Ryosuke Niwa.
365
366         * Scripts/run-benchmark:
367         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
368         (BenchmarkRunner.dump): Correct typo.
369         (BenchmarkRunner.wrap): Add results to console.
370         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
371         (OSXSafariDriver.prepareEnv):
372         (OSXSafariDriver.launchUrl):
373         (OSXSafariDriver.closeBrowsers):
374
375 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
376
377         Should no longer need to worry about very old versions of Xcode
378         https://bugs.webkit.org/show_bug.cgi?id=144437
379
380         Reviewed by Dan Bernstein.
381
382         * Scripts/check-for-exit-time-destructors:
383         * Scripts/check-for-global-initializers:
384         * Scripts/check-for-weak-vtables-and-externals:
385
386 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
387
388         REGRESSION(183583): [Mac] make without SDKROOT has issues
389         https://bugs.webkit.org/show_bug.cgi?id=144431
390
391         Reviewed by Dan Bernstein.
392
393         * Makefile:
394         * WebKitTestRunner/Makefile:
395         Assume an empty SDKROOT means an macosx variant, so only
396         enable settings if the SDKROOT is not empty and does not
397         contain "macosx".
398
399 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
400
401         Expand test infrastructure to support scrolling tests
402         https://bugs.webkit.org/show_bug.cgi?id=143684
403         <rdar://problem/20375516>
404
405         Reviewed by Simon Fraser.
406
407         * DumpRenderTree/mac/DumpRenderTree.mm:
408         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
409         reset before the next test run.
410         * WebKitTestRunner/TestController.cpp:
411         (WTR::TestController::resetStateToConsistentValues): Ditto."
412
413 2015-04-29  Alex Christensen  <achristensen@webkit.org>
414
415         Run javascriptcore tests on Windows without cygwin
416         https://bugs.webkit.org/show_bug.cgi?id=144419
417
418         Reviewed by Brent Fulgham.
419
420         * Scripts/run-javascriptcore-tests:
421         (runJSCStressTests):
422         Just call ruby, not /usr/bin/env ruby.
423
424 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
425
426         [GTK] Add --enable-shared option to LLVM to build mesa
427         https://bugs.webkit.org/show_bug.cgi?id=144393
428
429         Reviewed by Martin Robinson.
430
431         The updated mesa requires the shared LLVM libraries.
432         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
433         to LLVM configure script. It will provide shared libraries in addition to static libraries.
434
435         * gtk/jhbuild-optional.modules:
436
437 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
438
439         [GTK] Add support for automatic hyphenation
440         https://bugs.webkit.org/show_bug.cgi?id=44478
441
442         Reviewed by Carlos Garcia Campos.
443
444         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
445         all systems will use the same dictionaries for testing purposes.
446
447 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
448
449         Failure when building WebKit for appletvsimulator.
450         https://bugs.webkit.org/show_bug.cgi?id=144356
451
452         Reviewed by Alexey Proskuryakov.
453
454         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
455         make TVOS and WatchOS behave correctly.
456
457         * Makefile:
458         * WebKitTestRunner/Makefile:
459
460 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
461
462         Use-after-free when invalidating WKPageForceRepaint callback
463         https://bugs.webkit.org/show_bug.cgi?id=144401
464         rdar://problem/20741111
465
466         Reviewed by Tim Horton.
467
468         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
469
470         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
471         Don't do anything on error, because the context may be a stale pointer now.
472
473 2015-04-29  David Kilzer  <ddkilzer@apple.com>
474
475         check-webkit-style: Don't complain about returning value from Objective-C method call in header
476         <http://webkit.org/b/144395>
477
478         Reviewed by Andy Estes.
479
480         * Scripts/webkitpy/style/checkers/cpp.py:
481         (check_spacing): Update regex so 'return' is ignored if it
482         precedes the whitespace and bracket.  Change category name to
483         'whitespace/brackets'.  Add period to error message.
484         (CppChecker): Add 'whitespace/brackets' as a category.
485         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
486         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
487         'CppChecker.categories' since that's where the list lives now.
488         (CppStyleTest.test_spacing_before_brackets): Add tests for
489         'whitespace/brackets' issues and non-issues.
490
491 2015-04-29  Alex Christensen  <achristensen@webkit.org>
492
493         Fix WinCairo bot.
494
495         * Scripts/webkitdirs.pm:
496         (determinePassedConfiguration):
497         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
498
499 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
500
501         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
502         https://bugs.webkit.org/show_bug.cgi?id=132159
503
504         Reviewed by Darin Adler.
505
506         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
507         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
508
509         * DumpRenderTree/mac/DumpRenderTree.mm:
510         (fontWhitelist):
511         (adjustFonts):
512         (createWebViewAndOffscreenWindow):
513         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
514         (WTR::activateFonts):
515         * WebKitTestRunner/mac/TestControllerMac.mm:
516         (WTR::allowedFontFamilySet):
517         (WTR::systemHiddenFontFamilySet):
518         (WTR::generateWhitelist):
519         (WTR::TestController::platformInitializeContext):
520
521 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
522
523         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
524         https://bugs.webkit.org/show_bug.cgi?id=144155
525
526         Reviewed by Andreas Kling.
527
528         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
529         Make sure that test window is "visible" before each test. While there is no concrete
530         evidence that this is the problem indeed, the behavior is consistent with what would
531         happen for an invisible window. Also, WKTR obviously needs to do this to protect
532         against potential buggy tests that hide the window and don't show it.
533
534 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
535
536         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
537
538         Latest changes in the inspector UI made this test fail. We were
539         relying that the sidebar was always visible and the first 'li'
540         element of the inspector was the one containing the title. This is
541         no longer true, so better use document title that is not likely
542         to change.
543
544         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
545         (openRemoteDebuggingSession):
546
547 2015-04-29  Andres Gomez  <agomez@igalia.com>
548
549         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
550
551         * Scripts/webkitpy/common/config/contributors.json:
552
553 2015-04-29  Andres Gomez  <agomez@igalia.com>
554
555         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
556
557         * Scripts/webkitpy/common/config/watchlist:
558
559 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
560
561         [EFL] Allow to run the tests on the native X display
562         https://bugs.webkit.org/show_bug.cgi?id=144247
563
564         Reviewed by Gyuyoung Kim.
565
566         Added the USE_NATIVE_XDISPLAY option for the WTR.
567         We can select the Xorg driver if environment variable is set up before running the tests.
568
569         * Scripts/webkitpy/port/efl.py:
570         (EflPort._driver_class):
571
572 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
573
574         [GTK] Add libnotify-dev in gtk install-dependencies
575         https://bugs.webkit.org/show_bug.cgi?id=144379
576
577         Reviewed by Žan Doberšek.
578
579         * gtk/install-dependencies:
580
581 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
582
583         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
584         https://bugs.webkit.org/show_bug.cgi?id=143001
585
586         Reviewed by Gyuyoung Kim.
587
588         * WebKitTestRunner/TestController.cpp:
589         (WTR::shouldUseFixedLayout):
590
591 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
592
593         Increase stablility of run-benchmark script
594         https://bugs.webkit.org/show_bug.cgi?id=144361
595
596         Reviewed by Ryosuke Niwa.
597
598         * Scripts/run-benchmark:
599         (main):
600         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
601         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
602         (GenericBenchmarkBuilder.clean):
603         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
604         (BenchmarkRunner.__init__):
605         (BenchmarkRunner.execute):
606         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
607         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
608         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
609         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
610         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
611         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
612         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
613         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
614         (HTTPServerDriver.fetchResult):
615         (HTTPServerDriver):
616         (HTTPServerDriver.killServer): Add kill server interface.
617         (HTTPServerDriver.getReturnCode): Add get return code interface.
618         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
619         (SimpleHTTPServerDriver.serve):
620         (SimpleHTTPServerDriver.fetchResult):
621         (SimpleHTTPServerDriver):
622         (SimpleHTTPServerDriver.killServer):
623         (SimpleHTTPServerDriver.getReturnCode):
624         * Scripts/webkitpy/benchmark_runner/utils.py:
625         (forceRemove): Provide python version of 'rm -rf'.
626
627 2015-04-28  Sam Weinig  <sam@webkit.org>
628
629         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
630         https://bugs.webkit.org/show_bug.cgi?id=144363
631
632         Reviewed by Alex Christensen.
633
634         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
635         (TestWebKitAPI::createNFAs):
636         (TestWebKitAPI::TEST_F):
637         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
638         (TestWebKitAPI::countLiveNodes):
639         (TestWebKitAPI::createNFAs):
640         (TestWebKitAPI::buildDFAFromPatterns):
641         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
642
643 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
644
645         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
646         https://bugs.webkit.org/show_bug.cgi?id=144304
647
648         Reviewed by Geoffrey Garen.
649
650         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
651         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
652         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
653
654 2015-04-28  Commit Queue  <commit-queue@webkit.org>
655
656         Unreviewed, rolling out r183514.
657         https://bugs.webkit.org/show_bug.cgi?id=144359
658
659         It broke cloop test bots (Requested by mcatanzaro on #webkit).
660
661         Reverted changeset:
662
663         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
664         https://bugs.webkit.org/show_bug.cgi?id=144304
665         http://trac.webkit.org/changeset/183514
666
667 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
668
669         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
670         https://bugs.webkit.org/show_bug.cgi?id=144304
671
672         Reviewed by Geoffrey Garen.
673
674         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
675         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
676         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
677         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
678
679 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
680
681         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
682         https://bugs.webkit.org/show_bug.cgi?id=144319
683
684         Reviewed by Csaba Osztrogonác.
685
686         * TestWebKitAPI/CMakeLists.txt:
687         * TestWebKitAPI/PlatformEfl.cmake:
688
689 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
690
691         Fix common typo "targetting" => "targeting"
692         https://bugs.webkit.org/show_bug.cgi?id=144349
693
694         Reviewed by Daniel Bates.
695
696         * Scripts/webkitdirs.pm:
697         (execMacWebKitAppForDebugging):
698
699 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
700
701         [GTK][jhbuild] Mesa build failure with llvm 3.6
702         https://bugs.webkit.org/show_bug.cgi?id=144250
703
704         Reviewed by Žan Doberšek.
705
706         Bump the version of Mesa to 10.5.4
707
708         * gtk/jhbuild.modules:
709
710 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
711
712         Disable App Nap in WebKitTestRunner UI process
713         https://bugs.webkit.org/show_bug.cgi?id=144308
714
715         Reviewed by Daniel Bates.
716
717         * WebKitTestRunner/mac/main.mm:
718         (disableAppNapInUIProcess):
719         (main):
720
721 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
722
723         [GTK] Update JHBuild Mesa download directory
724         https://bugs.webkit.org/show_bug.cgi?id=144318
725
726         Update the download directory of Mesa module since the previous one
727         doesn't exist any more.
728
729         Reviewed by Žan Doberšek.
730
731         * gtk/jhbuild.modules:
732
733 2015-04-28  Commit Queue  <commit-queue@webkit.org>
734
735         Unreviewed, rolling out r183477.
736         https://bugs.webkit.org/show_bug.cgi?id=144334
737
738         Roll back the Mesa dependency bump in fear of uncaught
739         regressions while the testing bots are no-op. (Requested by
740         zdobersek on #webkit).
741
742         Reverted changeset:
743
744         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
745         https://bugs.webkit.org/show_bug.cgi?id=144250
746         http://trac.webkit.org/changeset/183477
747
748 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
749
750         [GTK][jhbuild] Mesa build failure with llvm 3.6
751         https://bugs.webkit.org/show_bug.cgi?id=144250
752
753         Reviewed by Žan Doberšek.
754
755         Bump the version of Mesa to 10.5.4
756
757         * gtk/jhbuild.modules:
758
759 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
760
761         Add '__init__.py' and fix known bug in benchmark runner.
762         https://bugs.webkit.org/show_bug.cgi?id=144296
763
764         Reviewed by Ryosuke Niwa
765
766         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
767         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
768         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
769         (BenchmarkRunner.__init__):
770         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
771         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
772         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
773
774 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
775
776         More build fix.
777
778         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
779         (-[AccessibilityNotificationHandler _notificationReceived:]):
780         Use -objectForKey:, not array subscript.
781
782 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
783
784         Catch unexpected exits in DumpRenderTree
785         https://bugs.webkit.org/show_bug.cgi?id=144288
786
787         Reviewed by Tim Horton.
788
789         * DumpRenderTree/mac/DumpRenderTree.mm:
790         (atexitFunction):
791         (DumpRenderTreeMain):
792
793 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
794
795         Build fix
796
797         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
798         (-[AccessibilityNotificationHandler _notificationReceived:]):
799         Use -objectForKey:, not array subscript.
800
801 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
802
803         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
804         https://bugs.webkit.org/show_bug.cgi?id=144155
805
806         Reviewed by Tim Horton.
807
808         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
809         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
810         and we clearly don't want App Nap while testing.
811
812 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
813
814         [CMake] Autogenerate cmakeconfig.h.cmake
815         https://bugs.webkit.org/show_bug.cgi?id=143997
816
817         Reviewed by Csaba Osztrogonác.
818
819         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
820         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
821
822 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
823
824         REGRESSION(r182879): Images and video can no longer be downloaded
825         https://bugs.webkit.org/show_bug.cgi?id=144267
826         <rdar://problem/20702844>
827
828         Reviewed by Simon Fraser.
829
830         Revise tests to check for proper download menu state.
831         1. Downloading a loal image should be disabled.
832         2. Downloading a local media file should be disabled.
833         3. Downloading non-downloadable media should be disabled.
834
835         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
836         (TestWebKitAPI::TEST):
837
838 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
839
840         Merge run-launcher into run-minibrowser
841         https://bugs.webkit.org/show_bug.cgi?id=141928
842
843         Reviewed by Darin Adler.
844
845         * Scripts/run-iexploder-tests:
846         (runSafariWithIExploder):
847         * Scripts/run-launcher: Removed.
848         * Scripts/run-minibrowser:
849         * Scripts/webkitdirs.pm:
850         (launcherPath):
851         * Scripts/webkitpy/port/efl.py:
852         (EflPort.show_results_html_file):
853         * Scripts/webkitpy/port/efl_unittest.py:
854         (EflPortTest.test_show_results_html_file):
855         * Scripts/webkitpy/port/gtk.py:
856         (GtkPort.print_leaks_summary):
857         (GtkPort.show_results_html_file):
858         (GtkPort): Deleted.
859         * Scripts/webkitpy/port/gtk_unittest.py:
860         (GtkPortTest.test_show_results_html_file):
861
862 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
863
864         [buildbot] Fix the output of perf-test buildstep on timeout
865         https://bugs.webkit.org/show_bug.cgi?id=144097
866
867         Reviewed by Ryosuke Niwa.
868
869         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
870         (RunAndUploadPerfTests.getText2):
871         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
872         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
873         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
874
875 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
876
877         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
878         https://bugs.webkit.org/show_bug.cgi?id=143874
879
880         Reviewed by Gyuyoung Kim.
881
882         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
883
884 2015-04-24  Philippe Normand  <pnormand@igalia.com>
885
886         [JHBuild] Move to upstream OpenWebRTC
887         https://bugs.webkit.org/show_bug.cgi?id=144145
888
889         Reviewed by Carlos Garcia Campos.
890
891         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
892         and add a new simple patch to gst-plugins-base, required for
893         OpenWebRTC build.
894         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
895         * gtk/jhbuild.modules: Ditto.
896         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
897
898 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
899
900         [ES6] Implement ES6 template literals
901         https://bugs.webkit.org/show_bug.cgi?id=142691
902
903         Reviewed by Darin Adler.
904
905         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
906
907         * Scripts/webkitperl/FeatureList.pm:
908
909 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
910
911         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
912         https://bugs.webkit.org/show_bug.cgi?id=144217
913
914         Reviewed by Darin Adler.
915
916         * WebKitTestRunner/PlatformEfl.cmake:
917
918 2015-04-26  Doug Russell  <d_russell@apple.com>
919
920         AX: richer text change notifications (142719)
921         https://bugs.webkit.org/show_bug.cgi?id=142719
922
923         Reviewed by Darin Adler.
924
925         Richer accessibility value change notifications. Introduce AXTextEditType,
926         postTextStateChangeNotification and postTextReplacementNotification to give assistive
927         tech apps more reliable context for responding to changes in web content. Also implement
928         a mechanism to post value changes in password form fields in coalesced ticks to thwart
929         analyzing the cadence of changes.
930
931         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
932         and an overload of postTextReplacementNotification to give assistive tech apps more
933         reliable context for responding to changes in web content selection. Also block posting
934         selection changes on password fields.
935
936         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
937         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
938         (-[AccessibilityNotificationHandler stopObserving]):
939         (-[AccessibilityNotificationHandler _notificationReceived:]):
940         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
941         (AccessibilityUIElement::removeNotificationListener):
942         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
943         (-[AccessibilityNotificationHandler _notificationReceived:]):
944         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
945         (WTR::AccessibilityUIElement::removeNotificationListener):
946
947 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
948
949         Add myself to contributors.json
950         https://bugs.webkit.org/show_bug.cgi?id=144204
951
952         Reviewed by Darin Adler.
953
954         * Scripts/webkitpy/common/config/contributors.json:
955
956 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
957
958         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
959         https://bugs.webkit.org/show_bug.cgi?id=144182
960
961         Reviewed by Simon Fraser.
962
963         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
964
965 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
966
967         https://bugs.webkit.org/show_bug.cgi?id=144038
968
969         Reviewed by Ryosuke Niwa
970
971         Add a script to run Speedometer and JetStream on a browser.
972
973         * Scripts/run-benchmark: Wrapper script to run benchmark.
974         (main):
975         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
976         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
977         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
978         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
979         (BenchmarkBuilderFactory):
980         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
981         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
982         (GenericBenchmarkBuilder):
983         (GenericBenchmarkBuilder.prepare):
984         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
985         (GenericBenchmarkBuilder._applyPatch):
986         (GenericBenchmarkBuilder.clean):
987         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
988         (JetStreamBenchmarkBuilder):
989         (JetStreamBenchmarkBuilder.prepare):
990         (JetStreamBenchmarkBuilder._runCreateScript):
991         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
992         (BenchmarkRunner):
993         (BenchmarkRunner.__init__):
994         (BenchmarkRunner.execute):
995         (BenchmarkRunner.dump):
996         (BenchmarkRunner.wrap):
997         (BenchmarkRunner.merge):
998         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
999         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
1000         (BrowserDriver):
1001         (BrowserDriver.prepareEnv):
1002         (BrowserDriver.launchUrl):
1003         (BrowserDriver.closeBrowser):
1004         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
1005         (BrowserDriverFactory):
1006         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
1007         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
1008         (OSXChromeDriver):
1009         (OSXChromeDriver.prepareEnv):
1010         (OSXChromeDriver.launchUrl):
1011         (OSXChromeDriver.closeBrowsers):
1012         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
1013         (OSXSafariDriver):
1014         (OSXSafariDriver.prepareEnv):
1015         (OSXSafariDriver.launchUrl):
1016         (OSXSafariDriver.closeBrowsers):
1017         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
1018         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
1019         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
1020         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
1021         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
1022         (GenericFactory):
1023         (GenericFactory.iterateGetItem):
1024         (GenericFactory.create):
1025         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
1026         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
1027         (ServerControl):
1028         (ServerControl.render_GET):
1029         (ServerControl.render_POST):
1030         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
1031         (HTTPServerDriver):
1032         (HTTPServerDriver.serve):
1033         (HTTPServerDriver.fetchResult):
1034         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
1035         (HTTPServerDriverFactory):
1036         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
1037         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
1038         (SimpleHTTPServerDriver):
1039         (SimpleHTTPServerDriver.depends):
1040         (SimpleHTTPServerDriver.__init__):
1041         (SimpleHTTPServerDriver.serve):
1042         (SimpleHTTPServerDriver.baseUrl):
1043         (SimpleHTTPServerDriver.fetchResult):
1044         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
1045         (ModuleNotFoundError):
1046         (loadModule):
1047         (getPathFromProjectRoot):
1048         (loadJSONFromFile):
1049         (TimeoutError):
1050         (timeout):
1051         (timeout.__init__):
1052         (timeout.handle_timeout):
1053         (timeout.__enter__):
1054         (timeout.__exit__):
1055
1056 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1057
1058         Unreviewed, rolling out r183303.
1059         https://bugs.webkit.org/show_bug.cgi?id=144181
1060
1061         Change was incorrect, broke builds (Requested by smfr on
1062         #webkit).
1063
1064         Reverted changeset:
1065
1066         "Fix the build."
1067         http://trac.webkit.org/changeset/183303
1068
1069 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
1070
1071         Fix the build.
1072
1073         * MiniBrowser/mac/WK2BrowserWindowController.m:
1074         (-[WK2BrowserWindowController initWithConfiguration:]):
1075
1076 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1077
1078         Disable ActionMenusPDFTest due to timeout on test bot
1079
1080         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1081         (TestWebKitAPI::TEST):
1082
1083 2015-04-24  Commit Queue  <commit-queue@webkit.org>
1084
1085         Unreviewed, rolling out r183266.
1086         https://bugs.webkit.org/show_bug.cgi?id=144164
1087
1088         Broke 32-bit build and a test. (Requested by ap on #webkit).
1089
1090         Reverted changeset:
1091
1092         "AX: richer text change notifications (142719)"
1093         https://bugs.webkit.org/show_bug.cgi?id=142719
1094         http://trac.webkit.org/changeset/183266
1095
1096 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1097
1098         REGRESSION: WebKit2.ActionMenusTest API test fails
1099         https://bugs.webkit.org/show_bug.cgi?id=144149
1100         <rdar://problem/20677770>
1101
1102         Reviewed by Tim Horton.
1103
1104         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
1105         as the 'ActionMenusPDFTest'.
1106         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1107         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
1108         to match the hit test on the 'action-menu-target.pdf' test file.
1109
1110 2015-04-24  Daniel Bates  <dabates@apple.com>
1111
1112         Cleanup: Use @memoized for property IOSSimulator.testing_device
1113         https://bugs.webkit.org/show_bug.cgi?id=141715
1114
1115         Reviewed by Darin Adler.
1116
1117         Simplify the caching of the result of IOSSimulator.testing_device
1118         and make the code more readable by making use of the @memoized declarator
1119         instead of explicitly managing a private instance variable,
1120         IOSSimulator._testing_device, for the cached result.
1121
1122         * Scripts/webkitpy/port/ios.py:
1123         (IOSPort.determine_full_port_name):
1124         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
1125         (IOSSimulatorPort):
1126         (IOSSimulatorPort.testing_device): No need to cache the created device object in
1127         IOSSimulatorPort._testing_device since we are marking this function @memoized.
1128         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
1129         of caching in local variable since we only make use of this value exactly once in this function.
1130         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
1131         been used since being added in r178622. So, we can remove this constructor since
1132         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
1133
1134 2015-04-24  Anders Carlsson  <andersca@apple.com>
1135
1136         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
1137         https://bugs.webkit.org/show_bug.cgi?id=144158
1138
1139         Reviewed by Beth Dakin.
1140
1141         * MiniBrowser/mac/WK2BrowserWindowController.m:
1142         (-[WK2BrowserWindowController initWithConfiguration:]):
1143
1144 2015-04-24  Doug Russell  <d_russell@apple.com>
1145
1146         AX: richer text change notifications (142719)
1147         https://bugs.webkit.org/show_bug.cgi?id=142719
1148
1149         Reviewed by Darin Adler.
1150
1151         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
1152
1153         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
1154
1155         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
1156         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1157         (-[AccessibilityNotificationHandler stopObserving]):
1158         (-[AccessibilityNotificationHandler _notificationReceived:]):
1159         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1160         (AccessibilityUIElement::removeNotificationListener):
1161         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1162         (-[AccessibilityNotificationHandler _notificationReceived:]):
1163         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1164         (WTR::AccessibilityUIElement::removeNotificationListener):
1165
1166 2015-04-24  Darin Adler  <darin@apple.com>
1167
1168         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
1169         https://bugs.webkit.org/show_bug.cgi?id=128007
1170
1171         Reviewed by Anders Carlsson.
1172
1173         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
1174         * DumpRenderTree/win/UIDelegate.h: Ditto.
1175
1176         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
1177         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
1178
1179         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1180
1181         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1182         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1183         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1184         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1185         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1186         (WebKitDOMDOMWindowTest::create): Ditto.
1187         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1188         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1189         of smart pointers to DelayedSIgnal objects.
1190         (uriChangedCallback): Ditto.
1191
1192 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1193
1194         [Mac] Unreviewed test fix.
1195         https://bugs.webkit.org/show_bug.cgi?id=144149
1196
1197         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1198         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1199         test.
1200
1201 2015-04-23  Darin Adler  <darin@apple.com>
1202
1203         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1204         https://bugs.webkit.org/show_bug.cgi?id=144090
1205
1206         Reviewed by Anders Carlsson.
1207
1208         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1209
1210 2015-04-23  Michael Saboff  <msaboff@apple.com>
1211
1212         lldb macro btjs sometimes can't get a frame description
1213         https://bugs.webkit.org/show_bug.cgi?id=144130
1214
1215         Reviewed by Filip Pizlo.
1216
1217         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1218         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1219         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1220
1221         * lldb/lldb_webkit.py:
1222         (btjs):
1223
1224 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1225
1226         Use less memory when compiling content extensions.
1227         https://bugs.webkit.org/show_bug.cgi?id=144051
1228
1229         Reviewed by Darin Adler and Benjamin Poulain.
1230
1231         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1232         (TestWebKitAPI::TEST_F):
1233         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1234         (TestWebKitAPI::countLiveNodes):
1235
1236 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1237
1238         [CMake] Clean up JSC JIT options
1239         https://bugs.webkit.org/show_bug.cgi?id=143998
1240
1241         Reviewed by Filip Pizlo.
1242
1243         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1244         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1245
1246 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1247
1248         [Mac] Extend action menus to support PDF
1249         https://bugs.webkit.org/show_bug.cgi?id=143895
1250         <rdar://problem/19003333>
1251
1252         Reviewed by Tim Horton.
1253
1254         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1255         of PDF content works.
1256
1257         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1258         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1259         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1260         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1261         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1262         Update to support PDF tests.
1263         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1264         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1265
1266 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1267
1268         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1269
1270         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1271         (beforeAll):
1272         (testWebViewAudioOnlyUserMediaPermissionRequests):
1273
1274 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1275
1276         Add myself to watchlist
1277         https://bugs.webkit.org/show_bug.cgi?id=144041
1278
1279         Reviewed by Alex Christensen.
1280
1281         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1282
1283         * Scripts/webkitpy/common/config/watchlist:
1284
1285 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1286
1287         [GTK] MiniBrowser should use NetworkProcess by default
1288         https://bugs.webkit.org/show_bug.cgi?id=143948
1289
1290         Reviewed by Sergio Villar Senin.
1291
1292         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1293         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1294
1295         * MiniBrowser/gtk/main.c:
1296         (main):
1297
1298 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1299
1300         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1301
1302         Unreviewed build fix.
1303
1304         * Scripts/prepare-ChangeLog:
1305         (get_function_line_ranges_for_cpp):
1306         Use grep instead of any to determine if a string is an element of an array.
1307
1308 2015-04-21  Anders Carlsson  <andersca@apple.com>
1309
1310         Fix block signatures
1311         https://bugs.webkit.org/show_bug.cgi?id=144002
1312
1313         Reviewed by Andreas Kling.
1314
1315         * MiniBrowser/mac/WK2BrowserWindowController.m:
1316         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1317
1318 2015-04-21  Philippe Normand  <pnormand@igalia.com>
1319
1320         [GTK] jhbuild should not use a branch for openwebrtc
1321         https://bugs.webkit.org/show_bug.cgi?id=143981
1322
1323         Reviewed by Carlos Garcia Campos.
1324
1325         * gtk/jhbuild.modules:
1326
1327 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
1328
1329         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1330
1331         Unreviewed build fix.
1332
1333         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1334         However, it has been exposed by List::MoreUtils since its inception. This patch uses
1335         the any function exposed by List::MoreUtils for greater compatibility.
1336
1337         * Scripts/prepare-ChangeLog:
1338         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1339         the any function in all of versions of Perl used by our infrastructure.
1340
1341 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1342
1343         Remove unnecessary logs when resetting tests.
1344
1345         * WebKitTestRunner/mac/TestControllerMac.mm:
1346         (WTR::TestController::platformResetPreferencesToConsistentValues):
1347         In r183020 I added some logs when compiling or removing content extensions fails.
1348         We often try to remove a content extension that does not exist, and that is not a problem.
1349
1350 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1351
1352         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1353         https://bugs.webkit.org/show_bug.cgi?id=143897
1354
1355         Reviewed by David Kilzer.
1356
1357         This is a speculative fix that addresses two issues:
1358
1359         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1360         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1361
1362         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1363         Before: (723, 729)
1364         After: (721, 720)
1365
1366         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1367         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1368
1369         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1370         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1371
1372         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1373
1374         2. Creating git diffs from HEAD and not origin/master by default.
1375
1376         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1377         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1378
1379         * Scripts/prepare-ChangeLog:
1380         (originalFile):
1381         Use HEAD instead of origin/master in default Git case.
1382
1383         (generateFunctionLists):
1384         Ensure that the end line is not less than the start line.
1385
1386         (extractLineRangeAfterChange):
1387         Set the end line to the start line if the end line is less than the start line.
1388
1389         (extractLineRangeBeforeChange):
1390         Ditto.
1391
1392 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1393
1394         Suppress warning in prepare-ChangeLog.
1395         https://bugs.webkit.org/show_bug.cgi?id=143882
1396
1397         Reviewed by David Kilzer.
1398
1399         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1400         instead of the deprecated smartmatch operator.
1401
1402         * Scripts/prepare-ChangeLog:
1403         Import the List::Util::any function.
1404
1405         (get_function_line_ranges_for_cpp):
1406         Use the any function instead of smartmatch.
1407
1408 2015-04-20  Anders Carlsson  <andersca@apple.com>
1409
1410         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1411         https://bugs.webkit.org/show_bug.cgi?id=143966
1412
1413         Reviewed by Dan Bernstein.
1414
1415         * MiniBrowser/mac/WK2BrowserWindowController.m:
1416         (dataTypes):
1417         (-[WK2BrowserWindowController fetchWebsiteData:]):
1418         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1419         (-[WK2BrowserWindowController clearWebsiteData:]):
1420
1421 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1422
1423         Fix content extension test flakiness.
1424         https://bugs.webkit.org/show_bug.cgi?id=143950
1425
1426         Reviewed by Brady Eidson.
1427
1428         * WebKitTestRunner/mac/TestControllerMac.mm:
1429         (WTR::TestController::platformResetPreferencesToConsistentValues):
1430         Remove the TestContentExtensions if it exists.
1431         (WTR::TestController::platformConfigureViewForTest):
1432         Log errors in case there are any.
1433
1434 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1435
1436         Properly report errors from _WKUserContentExtensionStore.
1437         https://bugs.webkit.org/show_bug.cgi?id=143808
1438
1439         Reviewed by Darin Adler.
1440
1441         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1442         (TEST_F):
1443
1444 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1445
1446         Add a rule for NetworkCache to watchlist file
1447         https://bugs.webkit.org/show_bug.cgi?id=143945
1448
1449         Reviewed by Sergio Villar Senin.
1450
1451         And add myself to the list of watchers.
1452
1453         * Scripts/webkitpy/common/config/watchlist:
1454
1455 2015-04-19  Darin Adler  <darin@apple.com>
1456
1457         Update RefPtr documentation and deprecation
1458         https://bugs.webkit.org/show_bug.cgi?id=143936
1459
1460         Reviewed by Andreas Kling.
1461
1462         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1463
1464 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1465
1466         Introduce bytecode intrinsics
1467         https://bugs.webkit.org/show_bug.cgi?id=143926
1468
1469         Reviewed by Filip Pizlo.
1470
1471         Change cpplint to accept emit_intrinsic_XXX.
1472
1473         * Scripts/webkitpy/style/checkers/cpp.py:
1474         (check_identifier_name_in_declaration):
1475
1476 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
1477
1478         Fix lldb_webkit.py to show StringImpls correctly
1479         https://bugs.webkit.org/show_bug.cgi?id=143920
1480
1481         Reviewed by Andreas Kling.
1482         
1483         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1484
1485         * lldb/lldb_webkit.py:
1486         (WTFStringImplProvider.is_8bit):
1487
1488 2015-04-17  Daniel Bates  <dabates@apple.com>
1489
1490         Not able to build WebKit against iOS Simulator 8.3 SDK
1491         https://bugs.webkit.org/show_bug.cgi?id=143883
1492
1493         Reviewed by David Kilzer.
1494
1495         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1496         so that Xcode uses them.
1497
1498         * Scripts/copy-webkitlibraries-to-product-directory:
1499
1500 2015-04-17  Beth Dakin  <bdakin@apple.com>
1501
1502         Force mouse events should go through normal mouse event handling code paths
1503         https://bugs.webkit.org/show_bug.cgi?id=143749
1504         -and corresponding-
1505         rdar://problem/20472895
1506
1507         Reviewed by Dean Jackson.
1508
1509         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1510         Since there is not a way to create an NSEventTypePressure from scratch, we 
1511         subclass NSEvent and override all of the critical methods.
1512
1513         * WebKitTestRunner/EventSenderProxy.h:
1514         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1515         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1516         (WTR::EventSendingController::mouseForceDown):
1517         (WTR::EventSendingController::mouseForceUp):
1518         (WTR::EventSendingController::mouseForceChanged):
1519         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1520         * WebKitTestRunner/TestController.cpp:
1521         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1522         * WebKitTestRunner/mac/EventSenderProxy.mm:
1523         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1524         (-[EventSenderPressureEvent timestamp]):
1525         (-[EventSenderPressureEvent type]):
1526         (-[EventSenderPressureEvent locationInWindow]):
1527         (-[EventSenderPressureEvent location]):
1528         (-[EventSenderPressureEvent stage]):
1529         (-[EventSenderPressureEvent pressure]):
1530         (-[EventSenderPressureEvent phase]):
1531         (-[EventSenderPressureEvent eventNumber]):
1532         (WTR::EventSenderProxy::mouseForceDown):
1533         (WTR::EventSenderProxy::mouseForceUp):
1534         (WTR::EventSenderProxy::mouseForceChanged):
1535
1536 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
1537
1538         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1539         https://bugs.webkit.org/show_bug.cgi?id=143885
1540
1541         Reviewed by Tim Horton.
1542
1543         Fixed a case where we have two builds with the same revision(s). An in order build
1544         is one for which the revision is strictly higher.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1547         (BuildbotQueue.prototype._checkForInOrderResult):
1548         (BuildbotQueue.prototype.compareIterationsByRevisions):
1549
1550 2015-04-17  Commit Queue  <commit-queue@webkit.org>
1551
1552         Unreviewed, rolling out r182912 and r182920.
1553         https://bugs.webkit.org/show_bug.cgi?id=143881
1554
1555         Build breakage in some configurations (Requested by ap on
1556         #webkit).
1557
1558         Reverted changesets:
1559
1560         "Force mouse events should go through normal mouse event
1561         handling code paths"
1562         https://bugs.webkit.org/show_bug.cgi?id=143749
1563         http://trac.webkit.org/changeset/182912
1564
1565         http://trac.webkit.org/changeset/182920
1566
1567 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1568
1569         [GTK] One more unreviewed fix after r182882.
1570
1571         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1572
1573 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1574
1575         [GTK] Unreviewed speculative clean build fix after r182882.
1576
1577         TestWebKitAPI's forwarding header generator depended on WeKit2's
1578         which generated SOUP related forwarding headers too.
1579
1580         This dependency isn't necessary and was removed by r182882 to make
1581         forwarding header generators parallelizable. But in this case
1582         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1583         should generate SOUP related forwarding headers too similar to EFL.
1584
1585         * TestWebKitAPI/PlatformGTK.cmake:
1586         * WebKitTestRunner/PlatformGTK.cmake:
1587
1588 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1589
1590         [SOUP] Redirect to non HTTP destination is broken
1591         https://bugs.webkit.org/show_bug.cgi?id=143866
1592
1593         Reviewed by Sergio Villar Senin.
1594
1595         Add a unit test to check that redirect to a data URI works.
1596
1597         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1598         (testRedirectToDataURI):
1599         (serverCallback):
1600         (beforeAll):
1601
1602 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1603
1604         Changes method of quitting iOS Simulator to be more correct.
1605         https://bugs.webkit.org/show_bug.cgi?id=143847
1606         <rdar://problem/20530344>
1607
1608         Reviewed by Darin Adler.
1609
1610         Fixes by addressing the app by ID rather than by name.
1611
1612         * Scripts/webkitdirs.pm:
1613         (quitIOSSimulator):
1614         * Scripts/webkitpy/port/ios.py:
1615         (IOSSimulatorPort.check_sys_deps):
1616
1617 2015-04-16  Anders Carlsson  <andersca@apple.com>
1618
1619         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1620         https://bugs.webkit.org/show_bug.cgi?id=143844
1621
1622         Reviewed by Dan Bernstein.
1623
1624         * MiniBrowser/mac/AppDelegate.m:
1625         (-[BrowserAppDelegate newPrivateWindow:]):
1626         * MiniBrowser/mac/WK2BrowserWindowController.m:
1627         (-[WK2BrowserWindowController initWithConfiguration:]):
1628         (-[WK2BrowserWindowController fetchWebsiteData:]):
1629         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1630         (-[WK2BrowserWindowController clearWebsiteData:]):
1631
1632 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1633
1634         32-bit build fix.
1635
1636         * WebKitTestRunner/mac/TestControllerMac.mm:
1637         (WTR::TestController::platformResetPreferencesToConsistentValues):
1638         (WTR::TestController::platformConfigureViewForTest):
1639         Added WK_API_ENABLED.
1640
1641 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1642
1643         Removed unused WKUserContentFilterRef.
1644         https://bugs.webkit.org/show_bug.cgi?id=143852
1645
1646         Reviewed by Sam Weinig.
1647
1648         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1649         * WebKitTestRunner/mac/TestControllerMac.mm:
1650         (WTR::TestController::platformResetPreferencesToConsistentValues):
1651         (WTR::TestController::platformConfigureViewForTest):
1652
1653 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1654
1655         Unreviewed. Adding myself as a commiter in contributers.json.
1656
1657         * Scripts/webkitpy/common/config/contributors.json:
1658
1659 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
1660
1661         It is very hard to attach a debugger to WebProcess to debug tests
1662         https://bugs.webkit.org/show_bug.cgi?id=143837
1663
1664         Reviewed by Chris Dumez.
1665
1666         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
1667         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
1668
1669         Now it disables all timeouts in tools, as is best for debugging tests.
1670
1671         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
1672         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
1673
1674         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
1675         now has the same functionality.
1676
1677 2015-04-16  Beth Dakin  <bdakin@apple.com>
1678
1679         Force mouse events should go through normal mouse event handling code paths
1680         https://bugs.webkit.org/show_bug.cgi?id=143749
1681         -and corresponding-
1682         rdar://problem/20472895
1683
1684         Reviewed by Dean Jackson.
1685
1686         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1687         Since there is not a way to create an NSEventTypePressure from scratch, we 
1688         subclass NSEvent and override all of the critical methods.
1689
1690         * WebKitTestRunner/EventSenderProxy.h:
1691         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1692         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1693         (WTR::EventSendingController::mouseForceDown):
1694         (WTR::EventSendingController::mouseForceUp):
1695         (WTR::EventSendingController::mouseForceChanged):
1696         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1697         * WebKitTestRunner/TestController.cpp:
1698         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1699         * WebKitTestRunner/mac/EventSenderProxy.mm:
1700         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1701         (-[EventSenderPressureEvent timestamp]):
1702         (-[EventSenderPressureEvent type]):
1703         (-[EventSenderPressureEvent locationInWindow]):
1704         (-[EventSenderPressureEvent location]):
1705         (-[EventSenderPressureEvent stage]):
1706         (-[EventSenderPressureEvent pressure]):
1707         (-[EventSenderPressureEvent phase]):
1708         (-[EventSenderPressureEvent eventNumber]):
1709         (WTR::EventSenderProxy::mouseForceDown):
1710         (WTR::EventSenderProxy::mouseForceUp):
1711         (WTR::EventSenderProxy::mouseForceChanged):
1712
1713 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1714
1715         [EFL] Bump LLVM to version 3.6.0 on X86_64
1716         https://bugs.webkit.org/show_bug.cgi?id=143604
1717
1718         Reviewed by Gyuyoung Kim.
1719
1720         * efl/jhbuild.modules:
1721         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
1722         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
1723         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
1724         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
1725
1726 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1727
1728         [EFL] Remove an unnecessary workaround from jhbuildrc
1729         https://bugs.webkit.org/show_bug.cgi?id=143823
1730
1731         Reviewed by Gyuyoung Kim.
1732
1733         * efl/jhbuildrc:
1734
1735 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1736
1737         [GTK] Run forwarding headers generator unconditionally
1738         https://bugs.webkit.org/show_bug.cgi?id=143819
1739
1740         Reviewed by Carlos Garcia Campos.
1741
1742         * TestWebKitAPI/PlatformGTK.cmake:
1743         * WebKitTestRunner/PlatformGTK.cmake:
1744
1745 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1746
1747         [EFL] Add gnutls to jhbuild.module
1748         https://bugs.webkit.org/show_bug.cgi?id=143777
1749
1750         Reviewed by Csaba Osztrogonác.
1751
1752         EFL port has required at least 3.0.0 version of gnutls since r176712.
1753         However some old linux distributions don't support 3.0.0 version. Besides
1754         other projects sometimes need to use lower version of gnutls.
1755
1756         This patch supports to download gnutls through jhbuild, and use it.
1757
1758         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
1759         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
1760
1761 2015-04-15  Mark Lam  <mark.lam@apple.com>
1762
1763         Remove obsolete VMInspector debugging tool.
1764         https://bugs.webkit.org/show_bug.cgi?id=143798
1765
1766         Reviewed by Michael Saboff.
1767
1768         * TestWebKitAPI/CMakeLists.txt:
1769         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1770         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1771         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1772         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
1773
1774 2015-04-15  Jer Noble  <jer.noble@apple.com>
1775
1776         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
1777
1778         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1779
1780 2015-04-15  Jer Noble  <jer.noble@apple.com>
1781
1782         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
1783
1784         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1785         (TestWebKitAPI::TEST_F):
1786
1787 2015-04-15  Chris Dumez  <cdumez@apple.com>
1788
1789         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
1790         https://bugs.webkit.org/show_bug.cgi?id=143779
1791
1792         Reviewed by Brent Fulgham.
1793
1794         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
1795         similarly to what is done on Mac / WK1. Without this, PageCache could
1796         stay enabled after page cache tests and cause weird behaviors.
1797
1798         * DumpRenderTree/win/DumpRenderTree.cpp:
1799         (resetWebPreferencesToConsistentValues):
1800
1801 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
1802
1803         Re-enable custom dilation for antialiased fonts
1804         https://bugs.webkit.org/show_bug.cgi?id=143738
1805
1806         Reviewed by Tim Horton.
1807         
1808         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
1809         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
1810         a private WebKit pref. This pref defaults to YES, enabling the feature by default
1811         in WK1 as we do for WK2.
1812
1813         * DumpRenderTree/mac/DumpRenderTree.mm:
1814         (resetWebPreferencesToConsistentValues):
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::TestController::resetPreferencesToConsistentValues):
1817
1818 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
1819
1820         Correct layering violation in DumpRenderTree Build
1821         https://bugs.webkit.org/show_bug.cgi?id=143732
1822
1823         Reviewed by Simon Fraser.
1824
1825         Correct a layering violation in DumpRenderTree by calling functions on the
1826         WebCoreTestSupport library, rather than attempting to work with WebCore
1827         types directly.
1828
1829         * DumpRenderTree/mac/EventSendingController.mm:
1830         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1831         than WebCore itself.,
1832         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1833
1834 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
1835
1836         Add a conservative DFA minimizer for the content extension matcher
1837         https://bugs.webkit.org/show_bug.cgi?id=143501
1838
1839         Reviewed by Alex Christensen.
1840
1841         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1842         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1843
1844 2015-04-14  Daniel Bates  <dabates@apple.com>
1845
1846         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1847         https://bugs.webkit.org/show_bug.cgi?id=143693
1848         <rdar://problem/20530316>
1849
1850         Reviewed by Tim Horton.
1851
1852         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1853         to use the fixed layout code on iOS at this time.
1854
1855         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1856
1857 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1858
1859         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1860         https://bugs.webkit.org/show_bug.cgi?id=143705
1861
1862         Unreviewed change to watchlist file.
1863
1864         * Scripts/webkitpy/common/config/watchlist:
1865
1866 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
1867
1868         [EFL] favicon wasn't updated for google.com sometimes.
1869         https://bugs.webkit.org/show_bug.cgi?id=141940
1870
1871         Reviewed by Gyuyoung Kim.
1872
1873         As elm_entry_utf8_to_markup can include additional characters, parameter for the
1874         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1875
1876         * MiniBrowser/efl/main.c:
1877         (on_url_changed):
1878
1879 2015-04-13  Tim Horton  <timothy_horton@apple.com>
1880
1881         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1882         https://bugs.webkit.org/show_bug.cgi?id=143560
1883         <rdar://problem/16302047>
1884
1885         Reviewed by Darin Adler.
1886
1887         * MiniBrowser/mac/BrowserWindowController.h:
1888         * MiniBrowser/mac/MainMenu.xib:
1889         * MiniBrowser/mac/WK1BrowserWindowController.m:
1890         (-[WK1BrowserWindowController setScale:]):
1891         * MiniBrowser/mac/WK2BrowserWindowController.m:
1892         (viewScaleForMenuItemTag):
1893         (-[WK2BrowserWindowController setScale:]):
1894         (-[WK2BrowserWindowController validateMenuItem:]):
1895         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1896         When in use, we resize the window so that the view fits correctly, and
1897         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
1898         layout size will not change when scaling down (but will update appropriately
1899         when the view is resized).
1900
1901 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1902
1903         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
1904         https://bugs.webkit.org/show_bug.cgi?id=138630
1905
1906         Reviewed by Tim Horton.
1907
1908         Make sure that we always load at least one in order productive iteration.
1909
1910         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1911         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1912         is done loading at least one iteration that wasn't an out of order build.
1913         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1914         when that's needed to check for out of order builds.
1915         (BuildbotQueue.prototype.update): Ditto.
1916         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1917         result, and if it does not, load more iterations.
1918         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1919         an in order iteration loaded too.
1920         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1921         corrected to always sort loaded iterations before unloaded ones.
1922
1923 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
1924
1925         Expand test infrastructure to support scrolling tests
1926         https://bugs.webkit.org/show_bug.cgi?id=143286
1927         <rdar://problem/20375516>
1928
1929         Reviewed by Simon Fraser.
1930
1931         Extend the WK1 and WK2 test programs to support two new EventSender commands:
1932         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1933         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1934         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1935         relevant rubberband, scroll, and scroll-snap animations are finished.
1936
1937         * DumpRenderTree/mac/EventSendingController.mm:
1938         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1939         and 'monitorWheelEvents'.
1940         (+[EventSendingController webScriptNameForSelector:]): Ditto.
1941         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1942         debugging test failures.
1943         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1944         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1945         function, then passes it to WebCore to be called once the test deferrals have been cleared.
1946         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1947         'callAfterScrollingCompletes' method.
1948         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1949         and 'monitorWheelEvents'.
1950         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1951         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1952         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1953         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1954         'callAfterScrollingComplates' method.
1955         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1956
1957 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1958
1959         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1960         https://bugs.webkit.org/show_bug.cgi?id=143656
1961
1962         Reviewed by Darin Adler.
1963
1964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1965         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1966
1967 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
1968
1969         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1970         https://bugs.webkit.org/show_bug.cgi?id=142387
1971
1972         Reviewed by Carlos Garcia Campos.
1973
1974         Running mixed content is blocked by default since r181134. Updated
1975         the test case to reflect the new default settings.
1976
1977         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1978         (testInsecureContent):
1979
1980 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1981
1982         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1983         https://bugs.webkit.org/show_bug.cgi?id=143667
1984
1985         Reviewed by Csaba Osztrogonác.
1986
1987         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1988         since r169017. Added $hardwareConcurrencySupport for it.
1989
1990         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1991
1992         * Scripts/webkitperl/FeatureList.pm:
1993
1994 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
1995
1996         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1997         https://bugs.webkit.org/show_bug.cgi?id=143664
1998
1999         Reviewed by Gyuyoung Kim.
2000
2001         * Scripts/webkitperl/FeatureList.pm:
2002
2003 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2004
2005         [EFL] Enable Media Source
2006         https://bugs.webkit.org/show_bug.cgi?id=143635
2007
2008         Reviewed by Csaba Osztrogonác.
2009
2010         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
2011
2012 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
2013
2014         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
2015         https://bugs.webkit.org/show_bug.cgi?id=143646
2016
2017         Reviewed by David Kilzer.
2018
2019         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2020         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2021
2022 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
2023
2024         Use en_US spell checker for tests on Mac instead of Multilingual
2025         https://bugs.webkit.org/show_bug.cgi?id=143641
2026
2027         Reviewed by Dan Bernstein.
2028
2029         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2030         While at it, override NSUserDictionaryReplacementItems, so that user replacements
2031         cannot affect tests.
2032
2033         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
2034         Made this more like WebKit1 version.
2035
2036 2015-04-10  Tim Horton  <timothy_horton@apple.com>
2037
2038         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
2039         https://bugs.webkit.org/show_bug.cgi?id=143576
2040
2041         Reviewed by Simon Fraser.
2042
2043         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
2044         (TEST):
2045         Adopt.
2046
2047 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2048
2049         Update my email address and expertise.
2050         https://bugs.webkit.org/show_bug.cgi?id=143586
2051
2052         Unreviewed, just update my info.
2053
2054         * Scripts/webkitpy/common/config/contributors.json:
2055
2056 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
2057
2058         Flakiness Dashboard not loading insecure content if loaded with https URL
2059         https://bugs.webkit.org/show_bug.cgi?id=143570
2060
2061         Reviewed by Alexey Proskuryakov.
2062
2063         * TestResultServer/app.yaml:
2064         * TestResultServer/static-dashboards/loader.js:
2065         Switch to https scheme.
2066
2067 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
2068
2069         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
2070         https://bugs.webkit.org/show_bug.cgi?id=142907
2071
2072         Reviewed by Carlos Garcia Campos.
2073
2074         * TestWebKitAPI/PlatformEfl.cmake:
2075         * TestWebKitAPI/PlatformGTK.cmake:
2076         * WebKitTestRunner/PlatformEfl.cmake:
2077         * WebKitTestRunner/PlatformGTK.cmake:
2078
2079 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2080
2081         [Mac] Unreviewed test fix after r182584
2082         https://bugs.webkit.org/show_bug.cgi?id=143452
2083
2084         Put both of these tests back to their original state now that the underlying
2085         problem is fixed.
2086
2087         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2088         (TestWebKitAPI::TEST):
2089         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2090         (TestWebKitAPI::TEST):
2091
2092 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
2093
2094         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
2095         https://bugs.webkit.org/show_bug.cgi?id=143553
2096
2097         Reviewed by Ryosuke Niwa.
2098         
2099         Remove the spurious printVMs left over from an earlier change.
2100
2101         * Scripts/run-jsc-benchmarks:
2102
2103 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2104
2105         [Mac] Unreviewed test fix after r182581
2106
2107         The behavior of control-left-click is controlled by a system preference.
2108         Our test bots have this turned off.
2109
2110         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
2111         (TestWebKitAPI::TEST):
2112         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
2113         (TestWebKitAPI::TEST):
2114
2115 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
2116
2117         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
2118         https://bugs.webkit.org/show_bug.cgi?id=143452
2119         <rdar://problem/20437483>
2120
2121         Reviewed by Tim Horton.
2122
2123         Add a new API test to confirm that Cocoa mouse button press events are properly
2124         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
2125
2126         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
2127         some registered event handlers that the expected button press and context menu
2128         events are received.
2129
2130         The WK1 unit test creates an NSEvent with the desired button press state, and then
2131         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
2132         We check the resulting PlatformMouseEvent for proper state.
2133
2134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
2135         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
2136         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2137         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
2138         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
2139         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
2140         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
2141         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2142         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
2143         mouse down events.
2144         * TestWebKitAPI/mac/PlatformWebViewMac.h:
2145
2146 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
2147
2148         [GTK] Add pango to jhbuild-optional.modules
2149         https://bugs.webkit.org/show_bug.cgi?id=143537
2150
2151         Reviewed by Martin Robinson.
2152
2153         * gtk/jhbuild-optional.modules: Add pango.
2154
2155 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2156
2157         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
2158         https://bugs.webkit.org/show_bug.cgi?id=143530
2159
2160         Reviewed by Žan Doberšek.
2161
2162         Assume that the default value for display (:0) is reserved and start checking on :1
2163         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
2164         and for X server named Xorg.bin (previous bug 1376599)
2165
2166         * Scripts/webkitpy/port/xvfbdriver.py:
2167         (XvfbDriver._next_free_display)
2168         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2169         (XvfbDriverTest.test_start_no_pixel_tests):
2170         (XvfbDriverTest.test_start_pixel_tests):
2171         (XvfbDriverTest.test_start_arbitrary_worker_number):
2172         (XvfbDriverTest.test_next_free_display):
2173         (XvfbDriverTest.test_start_next_worker):
2174 2015-04-08  Alex Christensen  <achristensen@webkit.org>
2175
2176         Block popups from content extensions.
2177         https://bugs.webkit.org/show_bug.cgi?id=143497
2178
2179         Reviewed by Brady Eidson.
2180
2181         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2182         (TestWebKitAPI::TEST_F):
2183         Added popup test.
2184
2185 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2186
2187         Add CMake build system for WinCairo port.
2188         https://bugs.webkit.org/show_bug.cgi?id=115944
2189
2190         Reviewed by Chris Dumez.
2191
2192         * CMakeLists.txt:
2193         * WinLauncher/CMakeLists.txt: Added.
2194
2195 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2196
2197         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2198         https://bugs.webkit.org/show_bug.cgi?id=143521
2199
2200         Reviewed by Martin Robinson.
2201
2202         Add a way to detect unexpected web process crashes to WebViewTest,
2203         and a test case to testDOMCache to trigger the crash.
2204
2205         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2206         (WebKitDOMNodeTest::testDOMCache):
2207         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2208         (testWebKitWebViewProcessCrashed):
2209         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2210         (WebViewTest::WebViewTest):
2211         (WebViewTest::webProcessCrashed):
2212         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2213
2214 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2215
2216         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2217         rdar://problem/20461342
2218
2219         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2220
2221 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2222
2223         Unreviewed, rolling out r182511.
2224         https://bugs.webkit.org/show_bug.cgi?id=143507
2225
2226         caused debug test failures (Requested by alexchristensen on
2227         #webkit).
2228
2229         Reverted changeset:
2230
2231         "Block popups from content extensions."
2232         https://bugs.webkit.org/show_bug.cgi?id=143497
2233         http://trac.webkit.org/changeset/182511
2234
2235 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2236
2237         Block popups from content extensions.
2238         https://bugs.webkit.org/show_bug.cgi?id=143497
2239
2240         Reviewed by Brady Eidson.
2241
2242         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2243         (TestWebKitAPI::TEST_F):
2244         Added popup test.
2245
2246 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2247
2248         Get the features.json files ready for open contributions
2249         https://bugs.webkit.org/show_bug.cgi?id=143436
2250
2251         Reviewed by Darin Adler.
2252
2253         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2254         (JSONFeaturesChecker.check):
2255         Extend the syntax checking a bit, but leave everything non-mandatory
2256         very loose until we figure what fields are important.
2257
2258 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2259
2260         Expose and test fixedLayoutSize via modern WebKit SPI
2261         https://bugs.webkit.org/show_bug.cgi?id=143500
2262
2263         Reviewed by Simon Fraser.
2264
2265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2266         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2267         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2268         (TEST):
2269         Add a test that verifies that fixedLayoutSize works at all, that
2270         it persists through a navigation, and that turning it back off reverts to
2271         laying out at the size of the view.
2272
2273 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2274
2275         Unreviewed. Add myself as a committer.
2276
2277         * Scripts/webkitpy/common/config/contributors.json:
2278
2279 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2280
2281         [Win] Bots complain about missing /etc/catalog
2282         https://bugs.webkit.org/show_bug.cgi?id=143484
2283
2284         Reviewed by Chris Dumez.
2285
2286         The libxml2 build on Mac, iOS, and Windows does not provide the set
2287         of default catalog files. We do not actually need these for our
2288         purposes, but we get warnings and some bot flakiness because they
2289         are not present.
2290
2291         We can avoid both problems the same way the Mac and iOS ports do,
2292         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2293         which avoid the warnings and bot problems.
2294
2295         * Scripts/webkitpy/port/win.py:
2296         (WinPort.setup_environ_for_server): Added.
2297
2298 2015-04-06  Sam Weinig  <sam@webkit.org>
2299
2300         Use content extensions in MiniBrowser.
2301         https://bugs.webkit.org/show_bug.cgi?id=143446
2302
2303         Reviewed by Alex Christensen.
2304
2305         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2306         * MiniBrowser/mac/AppDelegate.h:
2307         * MiniBrowser/mac/AppDelegate.m:
2308         (-[BrowserAppDelegate init]):
2309         (-[BrowserAppDelegate showExtensionsManager:]):
2310         (-[BrowserAppDelegate userContentContoller]):
2311         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2312         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2313         (-[ExtensionManagerWindowController init]):
2314         (-[ExtensionManagerWindowController windowDidLoad]):
2315         (-[ExtensionManagerWindowController add:]):
2316         (-[ExtensionManagerWindowController remove:]):
2317         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2318         * MiniBrowser/mac/MainMenu.xib:
2319
2320 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2321
2322         web-platform-tests server should retrieve the modules file relatively to its docroot path
2323         https://bugs.webkit.org/show_bug.cgi?id=142742
2324
2325         Reviewed by Darin Adler.
2326
2327         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2328         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2329
2330 2015-04-06  Commit Queue  <commit-queue@webkit.org>
2331
2332         Unreviewed, rolling out r182445.
2333         https://bugs.webkit.org/show_bug.cgi?id=143459
2334
2335         broke 32 bit build (Requested by alexchristensen on #webkit).
2336
2337         Reverted changeset:
2338
2339         "Use content extensions in MiniBrowser."
2340         https://bugs.webkit.org/show_bug.cgi?id=143446
2341         http://trac.webkit.org/changeset/182445
2342
2343 2015-04-06  Sam Weinig  <sam@webkit.org>
2344
2345         Use content extensions in MiniBrowser.
2346         https://bugs.webkit.org/show_bug.cgi?id=143446
2347
2348         Reviewed by Alex Christensen.
2349
2350         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2351         * MiniBrowser/mac/AppDelegate.h:
2352         * MiniBrowser/mac/AppDelegate.m:
2353         (-[BrowserAppDelegate init]):
2354         (-[BrowserAppDelegate showExtensionsManager:]):
2355         (-[BrowserAppDelegate userContentContoller]):
2356         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2357         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2358         (-[ExtensionManagerWindowController init]):
2359         (-[ExtensionManagerWindowController windowDidLoad]):
2360         (-[ExtensionManagerWindowController add:]):
2361         (-[ExtensionManagerWindowController remove:]):
2362         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2363         * MiniBrowser/mac/MainMenu.xib:
2364
2365 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2366
2367         [GTK] install-dependencies should prefer dnf to yum
2368         https://bugs.webkit.org/show_bug.cgi?id=143441
2369
2370         Reviewed by Martin Robinson.
2371
2372         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2373
2374         * gtk/install-dependencies:
2375
2376 2015-04-06  Andy Estes  <aestes@apple.com>
2377
2378         [iOS] 'make clean' fails in Tools/WebKitTestRunner
2379         https://bugs.webkit.org/show_bug.cgi?id=143455
2380
2381         Reviewed by Dan Bernstein.
2382
2383         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2384         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2385
2386         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2387
2388 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2389
2390         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2391         https://bugs.webkit.org/show_bug.cgi?id=143450
2392
2393         Reviewed by Anders Carlsson.
2394
2395         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2396         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2397         Also, removed unnecessary get() calls.
2398
2399 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2400
2401         Reduce the dependency on Flash in regression tests
2402         https://bugs.webkit.org/show_bug.cgi?id=143391
2403
2404         Reviewed by Anders Carlsson.
2405
2406         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2407         Only allow QuickTime and the test plug-in.
2408
2409 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2410
2411         W3C test importer should generate the modules installed dynamically to run wpt tests
2412         https://bugs.webkit.org/show_bug.cgi?id=142738
2413
2414         Reviewed by Ryosuke Niwa.
2415
2416         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2417         The implementation is done within TestDownloader and it is activated for the WPT repository.
2418         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2419
2420         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2421         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2422         * Scripts/webkitpy/w3c/test_downloader.py:
2423         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2424         (TestDownloader):
2425         (TestDownloader._git_submodules_description): Computes submodule description.
2426         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2427         * Scripts/webkitpy/w3c/test_importer.py:
2428         (TestImporter.do_import): Added the possibility to post process the tests.
2429         (TestImporter):
2430         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2431         (TestImporter.should_convert_test_harness_links): Updated according new options format.
2432         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2433         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
2434         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2435         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2436         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2437         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2438
2439 2015-04-05  Antti Koivisto  <antti@apple.com>
2440
2441         Bloom filter should support longer hashes
2442         https://bugs.webkit.org/show_bug.cgi?id=143419
2443
2444         Reviewed by Dan Bernstein.
2445
2446         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2447         (TestWebKitAPI::generateRandomDigests):
2448         (TestWebKitAPI::TEST):
2449
2450 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2451
2452         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2453         https://bugs.webkit.org/show_bug.cgi?id=143372
2454
2455         Reviewed by Darin Adler.
2456
2457         * Scripts/run-jsc-stress-tests:
2458
2459 2015-04-03  Antti Koivisto  <antti@apple.com>
2460
2461         Add non-counting bloom filter class
2462         https://bugs.webkit.org/show_bug.cgi?id=143366
2463
2464         Reviewed by Sam Weinig.
2465
2466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2467         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2468         (TestWebKitAPI::generateRandomHashes):
2469         (TestWebKitAPI::TEST):
2470
2471 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2472
2473         FTL JIT tests should fail if LLVM library isn't available
2474         https://bugs.webkit.org/show_bug.cgi?id=143374
2475
2476         Reviewed by Mark Lam.
2477
2478         * Scripts/run-jsc-stress-tests:
2479
2480 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2481
2482         [EFL] Speedup jhbuild with disable running autogen.sh
2483         https://bugs.webkit.org/show_bug.cgi?id=143369
2484
2485         Reviewed by Gyuyoung Kim.
2486
2487         * efl/jhbuild.modules:
2488
2489 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2490
2491         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2492         https://bugs.webkit.org/show_bug.cgi?id=143282
2493
2494         Reviewed by Daniel Bates.
2495
2496         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2497
2498 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2499
2500         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2501         https://bugs.webkit.org/show_bug.cgi?id=143240
2502         rdar://problem/19990425
2503
2504         Reviewed by Tim Horton.
2505
2506         * DumpRenderTree/mac/LayoutTestHelper.m:
2507         (colorProfileURLForDisplay):
2508         (saveDisplayColorProfiles):
2509         Gracefully handle it when the current profile cannot be retrieved, fixing at
2510         least one case when LayoutTestHelper couldn't start.
2511
2512         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2513         (Manager._set_up_run):
2514         (Manager._force_pixel_tests_if_needed):
2515         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2516         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2517         Return and check an error from start_helper().
2518
2519 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2520
2521         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2522         https://bugs.webkit.org/show_bug.cgi?id=143321
2523
2524         Reviewed by Alexey Proskuryakov.
2525
2526         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2527
2528 2015-04-01  Enrica Casucci  <enrica@apple.com>
2529
2530         Injected bundle messages should be at the page level.
2531         https://bugs.webkit.org/show_bug.cgi?id=143283
2532
2533         Reviewed by Alexey Proskuryakov.
2534
2535         Updating WebKitTestRunner to use the new page level messaging.
2536         The author of this patch is Tim Horton, I just finished it.
2537
2538         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2539         (WTR::EventSendingController::mouseDown):
2540         (WTR::EventSendingController::mouseUp):
2541         (WTR::EventSendingController::mouseMoveTo):
2542         (WTR::EventSendingController::leapForward):
2543         (WTR::EventSendingController::scheduleAsynchronousClick):
2544         (WTR::EventSendingController::keyDown):
2545         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2546         (WTR::EventSendingController::mouseScrollBy):
2547         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2548         (WTR::EventSendingController::continuousMouseScrollBy):
2549         (WTR::EventSendingController::addTouchPoint):
2550         (WTR::EventSendingController::updateTouchPoint):
2551         (WTR::EventSendingController::setTouchModifier):
2552         (WTR::EventSendingController::setTouchPointRadius):
2553         (WTR::EventSendingController::touchStart):
2554         (WTR::EventSendingController::touchMove):
2555         (WTR::EventSendingController::touchEnd):
2556         (WTR::EventSendingController::touchCancel):
2557         (WTR::EventSendingController::clearTouchPoints):
2558         (WTR::EventSendingController::releaseTouchPoint):
2559         (WTR::EventSendingController::cancelTouchPoint):
2560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2561         (WTR::InjectedBundle::didReceiveMessage):
2562         (WTR::InjectedBundle::didReceiveMessageToPage):
2563         (WTR::InjectedBundle::done):
2564         (WTR::InjectedBundle::outputText):
2565         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2566         (WTR::InjectedBundle::postAddChromeInputField):
2567         (WTR::InjectedBundle::postRemoveChromeInputField):
2568         (WTR::InjectedBundle::postFocusWebView):
2569         (WTR::InjectedBundle::postSetBackingScaleFactor):
2570         (WTR::InjectedBundle::postSetWindowIsKey):
2571         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2572         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2573         (WTR::InjectedBundle::setGeolocationPermission):
2574         (WTR::InjectedBundle::setMockGeolocationPosition):
2575         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2576         (WTR::InjectedBundle::setUserMediaPermission):
2577         (WTR::InjectedBundle::setCustomPolicyDelegate):
2578         (WTR::InjectedBundle::setHidden):
2579         (WTR::InjectedBundle::setCacheModel):
2580         (WTR::InjectedBundle::shouldProcessWorkQueue):
2581         (WTR::InjectedBundle::processWorkQueue):
2582         (WTR::InjectedBundle::queueBackNavigation):
2583         (WTR::InjectedBundle::queueForwardNavigation):
2584         (WTR::InjectedBundle::queueLoad):
2585         (WTR::InjectedBundle::queueLoadHTMLString):
2586         (WTR::InjectedBundle::queueReload):
2587         (WTR::InjectedBundle::queueLoadingScript):
2588         (WTR::InjectedBundle::queueNonLoadingScript):
2589         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2590         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2591         (WTR::TestRunner::setAuthenticationUsername):
2592         (WTR::TestRunner::setAuthenticationPassword):
2593         (WTR::TestRunner::secureEventInputIsEnabled):
2594         (WTR::TestRunner::setBlockAllPlugins):
2595         * WebKitTestRunner/TestController.cpp:
2596         (WTR::TestController::createWebViewWithOptions):
2597         (WTR::TestController::resetStateToConsistentValues):
2598         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2599         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2600         * WebKitTestRunner/TestController.h:
2601         * WebKitTestRunner/TestInvocation.cpp:
2602         (WTR::TestInvocation::invoke):
2603         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2604
2605 2015-04-01  Commit Queue  <commit-queue@webkit.org>
2606
2607         Unreviewed, rolling out r182174 and r182177.
2608         https://bugs.webkit.org/show_bug.cgi?id=143314
2609
2610         Try to correct EWS failures (Requested by bfulgham on
2611         #webkit).
2612
2613         Reverted changesets:
2614
2615         "Python SCM should be able to retrieve untracked files"
2616         https://bugs.webkit.org/show_bug.cgi?id=143135
2617         http://trac.webkit.org/changeset/182174
2618
2619         "[buildbot] clean-build script should remove untracked files
2620         and revert local changes too"
2621         https://bugs.webkit.org/show_bug.cgi?id=142400
2622         http://trac.webkit.org/changeset/182177
2623
2624 2015-04-01  Alex Christensen  <achristensen@webkit.org>
2625
2626         [Content Extensions] Properly handle regexes that match everything.
2627         https://bugs.webkit.org/show_bug.cgi?id=143281
2628
2629         Reviewed by Benjamin Poulain.
2630
2631         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2632         (TestWebKitAPI::testRequest):
2633         (TestWebKitAPI::makeBackend):
2634         (TestWebKitAPI::TEST_F):
2635         Removed duplicate code and added test.
2636
2637 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
2638
2639         Content Extensions: split the state machines to minimize prefix states
2640         https://bugs.webkit.org/show_bug.cgi?id=143253
2641
2642         Reviewed by Alex Christensen.
2643
2644         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2645         (TestWebKitAPI::TEST_F):
2646         (TestWebKitAPI::testPatternStatus):
2647
2648 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
2649
2650         Clean up Identifier factories to clarify the meaning of StringImpl*
2651         https://bugs.webkit.org/show_bug.cgi?id=143146
2652
2653         Reviewed by Filip Pizlo.
2654
2655         Simple API tests for StringImpl are added.
2656
2657         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2658         (TestWebKitAPI::TEST):
2659
2660 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
2661
2662         [EFL] Add AArch64 builder and tester bot to build.webkit.org
2663         https://bugs.webkit.org/show_bug.cgi?id=143092
2664
2665         Reviewed by Gyuyoung Kim.
2666
2667         * BuildSlaveSupport/build.webkit.org-config/config.json:
2668         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2669         (Factory.__init__):
2670         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2671
2672 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2673
2674         [buildbot] clean-build script should remove untracked files and revert local changes too
2675         https://bugs.webkit.org/show_bug.cgi?id=142400
2676
2677         Reviewed by Ryosuke Niwa.
2678
2679         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2680         A helper routine SCM.discard_untracked_files is added for that purpose.
2681
2682         * BuildSlaveSupport/clean-build:
2683         (main): Making call to Scripts/clean-webkit
2684         * Scripts/clean-webkit: Added.
2685         (main): Revert changes and delete untracked files.
2686         * Scripts/webkitpy/common/checkout/scm/scm.py:
2687         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2688         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2689         (SCMTest._shared_test_discard_untracked_files):
2690         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2691
2692 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2693
2694         Python SCM should be able to retrieve untracked files
2695         https://bugs.webkit.org/show_bug.cgi?id=143135
2696
2697         Reviewed by Ryosuke Niwa.
2698
2699         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2700         Ignored files may be included or not in this list according boolean passed to the function.
2701
2702         * Scripts/webkitpy/common/checkout/scm/git.py:
2703         (Git.untracked_files):
2704         * Scripts/webkitpy/common/checkout/scm/scm.py:
2705         (SCM.untracked_files):
2706         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2707         (SCMTest._shared_test_untracked_files):
2708         (test_untracked_files):
2709         (GitSVNTest.test_untracked_files):
2710         * Scripts/webkitpy/common/checkout/scm/svn.py:
2711         (SVN.untracked_files):
2712
2713 2015-03-30  Alex Christensen  <achristensen@webkit.org>
2714
2715         [Content Extensions] Correctly handle regular expressions matching everything
2716         https://bugs.webkit.org/show_bug.cgi?id=143235
2717
2718         Reviewed by Benjamin Poulain.
2719
2720         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2721         (TestWebKitAPI::checkCompilerError):
2722         (TestWebKitAPI::TEST_F):
2723         Test ContentExtensionErrors.
2724
2725 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
2726
2727         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
2728         https://bugs.webkit.org/show_bug.cgi?id=143241
2729         rdar://problem/20351297
2730
2731         Reviewed by Mark Lam.
2732
2733         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2734
2735 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2736
2737         [CMake][EFL] Remove redundant library link and include path
2738         https://bugs.webkit.org/show_bug.cgi?id=143221
2739
2740         Reviewed by Csaba Osztrogonác.
2741
2742         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
2743
2744 2015-03-30  Sam Weinig  <sam@webkit.org>
2745
2746         [Content Extensions] Flesh out the UserContentExtensionStore
2747         https://bugs.webkit.org/show_bug.cgi?id=143123
2748
2749         Reviewed by Benjamin Poulain.
2750
2751         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2752         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
2753         Add tests for _WKUserContentExtensionStore.
2754
2755 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2756
2757         Update install-dependencies Fedora packages after r181624
2758         https://bugs.webkit.org/show_bug.cgi?id=143215
2759
2760         Add json-glib, libv4l, openssl and pulseaudio development packages to
2761         the Fedora list providing we need them to build WebKit dependencies
2762         for this distribution.
2763
2764         Reviewed by Philippe Normand.
2765
2766         * gtk/install-dependencies:
2767
2768 2015-03-30  Commit Queue  <commit-queue@webkit.org>
2769
2770         Unreviewed, rolling out r182119.
2771         https://bugs.webkit.org/show_bug.cgi?id=143196
2772
2773         problem with syntax (Requested by youenn on #webkit).
2774
2775         Reverted changeset:
2776
2777         "[buildbot] clean-build script should remove untracked files
2778         and revert local changes too"
2779         https://bugs.webkit.org/show_bug.cgi?id=142400
2780         http://trac.webkit.org/changeset/182119
2781
2782 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
2783
2784         Start the features.json files
2785         https://bugs.webkit.org/show_bug.cgi?id=143207
2786
2787         Reviewed by Darin Adler.
2788
2789         I kept the style checking light. We'll have to figure
2790         what is the best format for each field.
2791
2792         * Scripts/webkitpy/style/checker.py:
2793         (CheckerDispatcher._create_checker):
2794         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2795         (JSONContributorsChecker.check):
2796         (JSONFeaturesChecker):
2797         (JSONFeaturesChecker.check):
2798
2799 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2800
2801         [buildbot] clean-build script should remove untracked files and revert local changes too
2802         https://bugs.webkit.org/show_bug.cgi?id=142400
2803
2804         Reviewed by Ryosuke Niwa.
2805
2806         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
2807
2808         * BuildSlaveSupport/clean-build:
2809         (main): Adding call to Tools/Scripts/clean-webkit.
2810         * Scripts/clean-webkit: Added.
2811         (main): Removes untracked and changed files.
2812         * Scripts/webkitpy/common/checkout/scm/git.py:
2813         (Git.untracked_files): Retrieves GIT untracked files.
2814         * Scripts/webkitpy/common/checkout/scm/scm.py:
2815         (SCM.untracked_files): Retrieves SVN untracked files.
2816         (SCM):
2817         (SCM.discard_untracked_files): Deletes untracked files/folders.
2818         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2819         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2820         (test_untracked_files):
2821         (GitSVNTest.test_untracked_files):
2822         * Scripts/webkitpy/common/checkout/scm/svn.py:
2823         (SVN.untracked_files):
2824
2825 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2826
2827         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
2828         https://bugs.webkit.org/show_bug.cgi?id=143138
2829
2830         Reviewed by Csaba Osztrogonác.
2831
2832         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2833         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2834
2835         * ImageDiff/CMakeLists.txt:
2836         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2837         * WebKitTestRunner/CMakeLists.txt: ditto.
2838
2839 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
2840
2841         Support building WTF on Windows without Cygwin
2842         https://bugs.webkit.org/show_bug.cgi?id=143084
2843
2844         Reviewed by Brent Fulgham.
2845
2846         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2847         This patch also migrates to using File::Spec->catfile() for directory separators.
2848
2849         * Scripts/update-webkit-dependency:
2850         (wanted):
2851         * Scripts/update-webkit-support-libs:
2852         (wanted):
2853         (downloadExpectedVersionNumber):
2854         (zipFileVersion):
2855         (toUnixPath): Deleted.
2856         * Scripts/webkitdirs.pm:
2857         (determineSourceDir):
2858         (windowsSourceSourceDir):
2859         (windowsLibrariesDir):
2860         (windowsOutputDir):
2861         (checkInstalledTools):
2862         (buildVisualStudioProject):
2863
2864 2015-03-27  Alex Christensen  <achristensen@webkit.org>
2865
2866         Fix WinCairo bot.
2867         https://bugs.webkit.org/show_bug.cgi?id=143086
2868
2869         Reviewed by Brent Fulgham.
2870
2871         * Scripts/webkitdirs.pm:
2872         (buildVisualStudioProject):
2873         (runSvnUpdateAndResolveChangeLogs):
2874         Use ActivePerl-friendly perl.
2875
2876 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2877
2878         URTBF after r182059 to fix the EFL build.
2879
2880         * TestWebKitAPI/CMakeLists.txt:
2881
2882 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
2883
2884         Layout test results URL loads in WK1 but not WK2 minibrowser
2885         https://bugs.webkit.org/show_bug.cgi?id=143117
2886
2887         Reviewed by Tim Horton.
2888
2889         * MiniBrowser/mac/WK2BrowserWindowController.m:
2890         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2891         everything.
2892         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2893
2894 2015-03-26  Jer Noble  <jer.noble@apple.com>
2895
2896         Add --allowed-host support to run-webkit-tests
2897         https://bugs.webkit.org/show_bug.cgi?id=142938
2898
2899         Reviewed by Brent Fulgham.
2900
2901         Accept --allowed-host arguments from run-webkit-tests and pass them through to
2902         DumpRenderTree and WebKitTestRunner.
2903
2904         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
2905         are placed in the wrong location. The argument is compared with each tests's path, and if a
2906         relative path or a path with '..' was used, results are placed alongside the test. Take the
2907         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2908
2909         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2910         (parse_args):
2911         * Scripts/webkitpy/port/base.py:
2912         (Port.__init__):
2913         (Port.allowed_hosts):
2914         * Scripts/webkitpy/port/driver.py:
2915         (Driver.cmd_line):
2916
2917 2015-03-26  Jer Noble  <jer.noble@apple.com>
2918
2919         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2920         https://bugs.webkit.org/show_bug.cgi?id=142931
2921
2922         Reviewed by Brent Fulgham.
2923
2924         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2925         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2926         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2927         runtime.
2928
2929         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2930         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2931
2932         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2933         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2934         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2935         the top loading frame from the page, as we do elsewhere in this class.
2936
2937         * DumpRenderTree/TestRunner.h:
2938         (TestRunner::allowedHosts):
2939         (TestRunner::setAllowedHosts):
2940         * DumpRenderTree/mac/DumpRenderTree.mm:
2941         (initializeGlobalsFromCommandLineOptions):
2942         (runTest):
2943         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2944         (isAllowedHost):
2945         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2946         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2947         (WTR::InjectedBundle::didReceiveMessage):
2948         (WTR::InjectedBundle::isAllowedHost):
2949         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2950         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2951         (WTR::isAllowedHost):
2952         (WTR::InjectedBundlePage::willSendRequestForFrame):
2953         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2954         * WebKitTestRunner/Options.cpp:
2955         (WTR::handleOptionAllowedHost):
2956         (WTR::OptionsHandler::OptionsHandler):
2957         * WebKitTestRunner/Options.h:
2958         * WebKitTestRunner/TestController.cpp:
2959         (WTR::TestController::initialize):
2960         (WTR::TestController::resetStateToConsistentValues):
2961         * WebKitTestRunner/TestController.h:
2962
2963 2015-03-26  Brady Eidson  <beidson@apple.com>
2964
2965         Apply ContentExtension actions after redirects.
2966         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2967
2968         Reviewed by Alex Christensen.
2969
2970         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2971         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2972           which is specifically interesting to a new test.
2973
2974 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2975
2976         [EFL] Disable building libseccomp on AArch64
2977         https://bugs.webkit.org/show_bug.cgi?id=143094
2978
2979         Reviewed by Gyuyoung Kim.
2980
2981         * efl/jhbuildrc:
2982
2983 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2984
2985         [jhbuild] git should use only 1 thread for cloning jhbuild
2986         https://bugs.webkit.org/show_bug.cgi?id=143095
2987
2988         Reviewed by Gyuyoung Kim.
2989
2990         * jhbuild/jhbuild-wrapper:
2991         (clone_jhbuild):
2992
2993 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2994
2995         Update prepare-ChangeLog to work with ES6 Class syntax
2996         https://bugs.webkit.org/show_bug.cgi?id=143069
2997
2998         Reviewed by Timothy Hatcher.
2999
3000         * Scripts/prepare-ChangeLog:
3001         (get_function_line_ranges_for_javascript):
3002         Better handle ES6 Class syntax.
3003
3004         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
3005         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
3006         (BaseClass):
3007         (DerivedClass):
3008         (DerivedClass.staticMethod):
3009         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
3010         (DerivedClass.prototype.method):
3011         (DerivedClass.prototype.get getter):
3012         (namespace.MyClass):
3013         (namespace.MyClass.staticMethod):
3014         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
3015         (namespace.MyClass.prototype.method):
3016         (namespace.MyClass.prototype.get getter):
3017         Proof!
3018
3019 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
3020
3021         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
3022         https://bugs.webkit.org/show_bug.cgi?id=142993
3023
3024         Reviewed by Mark Lam.
3025         
3026         Bunch of support for testing executable allocation failure.
3027
3028         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
3029         (fail):
3030         * Scripts/run-javascriptcore-tests:
3031         (runJSCStressTests):
3032         * Scripts/run-jsc-stress-tests:
3033
3034 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3035
3036         Fix Windows build from r181977.
3037
3038         Unreviewed.
3039
3040         * Scripts/update-webkit-dependency:
3041
3042 2015-03-25  Sam Weinig  <sam@webkit.org>
3043
3044         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
3045
3046         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3047         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3048
3049 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
3050
3051         Migrate update-webkit for Windows to not require Cygwin
3052         https://bugs.webkit.org/show_bug.cgi?id=143040
3053
3054         Reviewed by Brent Fulgham.
3055
3056         * Scripts/update-webkit-dependency:
3057         (wanted):
3058         (toUnixPath): Deleted.
3059         * Scripts/webkitdirs.pm:
3060         (fontExists):
3061         (checkInstalledTools):
3062         (setupAppleWinEnv):
3063
3064 2015-03-25  Sam Weinig  <sam@webkit.org>
3065
3066         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
3067         https://bugs.webkit.org/show_bug.cgi?id=143059
3068
3069         Reviewed by Alex Christensen.
3070
3071         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3072         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3073         Update for new interface of compileRuleList().
3074
3075 2015-03-25  Alex Christensen  <achristensen@webkit.org>
3076
3077         [Content Extensions] Add multi-DFA compiling and interpreting.
3078         https://bugs.webkit.org/show_bug.cgi?id=143010
3079
3080         Reviewed by Benjamin Poulain.
3081
3082         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3083         (TestWebKitAPI::testRequest):
3084         (TestWebKitAPI::TEST_F):
3085         Add some tests for ignore-previous-rules and large rulesets.
3086
3087 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
3088
3089         Mavericks WK1 still runs JSC tests
3090         https://bugs.webkit.org/show_bug.cgi?id=143035
3091
3092         Reviewed by Csaba Osztrogonác.
3093
3094         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
3095         with other bots.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
3098         accordingly.
3099
3100 2015-03-25  Commit Queue  <commit-queue@webkit.org>
3101
3102         Unreviewed, rolling out r181932.
3103         https://bugs.webkit.org/show_bug.cgi?id=143041
3104
3105         The test fails most of the time on bots (Requested by ap on
3106         #webkit).
3107
3108         Reverted changeset:
3109
3110         "[Content Extensions] Add multi-DFA compiling and
3111         interpreting."
3112         https://bugs.webkit.org/show_bug.cgi?id=143010
3113         http://trac.webkit.org/changeset/181932
3114
3115 2015-03-24  Alex Christensen  <achristensen@webkit.org>
3116
3117         [Content Extensions] Add multi-DFA compiling and interpreting.
3118         https://bugs.webkit.org/show_bug.cgi?id=143010
3119
3120         Reviewed by Benjamin Poulain.
3121
3122         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3123         (TestWebKitAPI::testRequest):
3124         (TestWebKitAPI::TEST_F):
3125         Add some tests for ignore-previous-rules and large rulesets.
3126
3127 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
3128
3129         Make URL filter patterns matching consistent and add a simple canonicalization step
3130         https://bugs.webkit.org/show_bug.cgi?id=142998
3131
3132         Reviewed by Alex Christensen.
3133
3134         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3135
3136 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
3137
3138         [EFL] Add OpenWebRTC in jhbuild
3139         https://bugs.webkit.org/show_bug.cgi?id=142778
3140
3141         Reviewed by Gyuyoung Kim.
3142
3143         Original patch by Philippe Normand <pnormand@igalia.com>
3144
3145         * efl/install-dependencies: Dependencies for OpenWebRTC.
3146         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
3147         the openwebrtc gst plugins.
3148
3149 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
3150
3151         Regression(r181257): WTF_WorkQueue.Simple is flaky
3152         https://bugs.webkit.org/show_bug.cgi?id=142560
3153
3154         Remove the check that the refCount has returned to one after the
3155         individual tasks have completed. It's too nondeterministic when
3156         the reference count will be reduced.
3157
3158         Reviewed by Alexey Proskuryakov
3159
3160         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3161         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
3162
3163 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3164
3165         [CMake][EFL] Put failure API test excutables into failure directory
3166         https://bugs.webkit.org/show_bug.cgi?id=142965
3167
3168         Reviewed by Csaba Osztrogonác.
3169
3170         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
3171
3172         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
3173         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
3174
3175 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
3176
3177         CSS Selectors: fix attribute case-insensitive matching of Contain and List
3178         https://bugs.webkit.org/show_bug.cgi?id=142932
3179
3180         Reviewed by Darin Adler.
3181
3182         Add tests for the new features and fix some existing tests using the 
3183         stringFromUTF8() utility recently added by Dhi.
3184
3185         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3186         (TestWebKitAPI::stringFromUTF8):
3187         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3188
3189 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3190
3191         [GTK] install-dependencies should install orc
3192         https://bugs.webkit.org/show_bug.cgi?id=142955
3193
3194         Reviewed by Martin Robinson.
3195
3196         Install orc, needed by openwebrtc
3197
3198         * gtk/install-dependencies:
3199
3200 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
3201
3202         Detect when url filter pattern with groups match the empty string
3203         https://bugs.webkit.org/show_bug.cgi?id=142930
3204
3205         Reviewed by Sam Weinig.
3206
3207         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3208
3209 2015-03-22  Anders Carlsson  <andersca@apple.com>
3210
3211         _WKWebsiteDataStore should clear WebSQL databases
3212         https://bugs.webkit.org/show_bug.cgi?id=142947
3213
3214         Reviewed by Sam Weinig.
3215
3216         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3217
3218         * MiniBrowser/mac/WK2BrowserWindowController.m:
3219         (-[WK2BrowserWindowController fetchWebsiteData:]):
3220         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3221         (-[WK2BrowserWindowController clearWebsiteData:]):
3222
3223 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
3224
3225         GCTimer should know keep track of nested GC phases
3226         https://bugs.webkit.org/show_bug.cgi?id=142675
3227
3228         Reviewed by Darin Adler.
3229
3230         Adds a tool to aid in parsing the GC phase timing output into a
3231         tree-like structure based on the parent-child relationships
3232         of nested GC phases.
3233
3234         * Scripts/parse-gc-phase-timings: Added.
3235         (Timing):
3236         (Timing.__init__):
3237         (Timing.__unicode__):
3238         (Timing.__str__):
3239         (Timing.__repr__):
3240         (parse_input):
3241         (print_timing_node):
3242         (print_timing_tree):
3243         (link_parents):
3244         (main):
3245
3246 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
3247
3248         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3249
3250         * Scripts/webkitpy/common/config/ews.json:
3251
3252 2015-03-20  Philippe Normand  <pnormand@igalia.com>
3253
3254         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3255         https://bugs.webkit.org/show_bug.cgi?id=142867
3256
3257         Rubber-stamped by Csaba Osztrogon.
3258
3259         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3260         a fixed revision for the openwebrtc-gst-plugins.
3261
3262 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3263
3264         Unreviewed build fix. Don't try to report stats for all benchmarks.
3265         Just report the geometric mean of preferred means.
3266
3267         * Scripts/run-jsc-benchmarks:
3268
3269 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3270
3271         run-jsc-benchmarks should only report preferred mean
3272         https://bugs.webkit.org/show_bug.cgi?id=142874
3273
3274         Reviewed by Geoffrey Garen.
3275
3276         Just collect statistics for the preferred mean.
3277
3278         * Scripts/run-jsc-benchmarks:
3279
3280 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3281
3282         [Content Extensions] Test regular expression parse failures.
3283         https://bugs.webkit.org/show_bug.cgi?id=142872
3284
3285         Reviewed by Benjamin Poulain.
3286
3287         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3288         (TestWebKitAPI::testPatternStatus):
3289         (TestWebKitAPI::TEST_F):
3290         Added tests for each parsing status.
3291
3292 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3293
3294         Fix API tests after r181754.
3295
3296         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3297         (TestWebKitAPI::testRequest):
3298
3299 2015-03-19  Brady Eidson  <beidson@apple.com>
3300
3301         Part of content extensions should apply css selectors
3302         https://bugs.webkit.org/show_bug.cgi?id=142604
3303
3304         Reviewed by Alex Christensen.
3305
3306         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3307         (WebCore::ContentExtensions::operator<<):
3308
3309 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
3310
3311         [Win] Activate tests on EWS
3312         https://bugs.webkit.org/show_bug.cgi?id=142850
3313
3314         Reviewed by Alexey Proskuryakov.
3315
3316         * Scripts/webkitpy/common/config/ews.json: Add me as
3317         the EWS bot watcher, and activate tests.
3318
3319 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
3320
3321         [GTK] Fix inspector userinterface related incremental build issue
3322         https://bugs.webkit.org/show_bug.cgi?id=142849
3323
3324         Reviewed by Carlos Garcia Campos.
3325
3326         * Scripts/webkitdirs.pm:
3327         (shouldRemoveCMakeCache):
3328
3329 2015-03-18  Alex Christensen  <achristensen@webkit.org>
3330
3331         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3332         https://bugs.webkit.org/show_bug.cgi?id=142799
3333
3334         Reviewed by Brady Eidson.
3335
3336         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3337         (TestWebKitAPI::testPattern):
3338         (TestWebKitAPI::TEST_F):
3339         Start testing regex failures.
3340
3341 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
3342
3343         Fix StringView typos after r181525 and r181558
3344         https://bugs.webkit.org/show_bug.cgi?id=142772
3345
3346         Reviewed by Darin Adler.
3347
3348         Add some tests in [1] to cover the StringView::startsWith, 
3349         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
3350         StringView::endsWithIgnoringASCIICase implementations.
3351
3352         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3353         (TestWebKitAPI::TEST):
3354
3355 2015-03-18  Dana Burkart  <dburkart@apple.com>
3356
3357         Remove extraneous import to fix the build.
3358
3359         Unreviewed.
3360
3361         * Scripts/webkitpy/port/driver.py:
3362
3363 2015-03-18  Dana Burkart  <dburkart@apple.com>
3364
3365         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
3366         https://bugs.webkit.org/show_bug.cgi?id=142547
3367
3368         Reviewed by Alexey Proskuryakov.
3369
3370         * Scripts/webkitpy/port/driver.py:
3371         (Driver._setup_environ_for_driver):
3372
3373 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
3374
3375         Tweak how AppleSystemFontOSSubversion default is added
3376         https://bugs.webkit.org/show_bug.cgi?id=142835
3377
3378         Reviewed by Dan Bernstein.
3379
3380         * DumpRenderTree/mac/DumpRenderTree.mm:
3381         (setDefaultsToConsistentValuesForTesting):
3382
3383 2015-03-18  Dan Bernstein  <mitz@apple.com>
3384
3385         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3386         https://bugs.webkit.org/show_bug.cgi?id=142815
3387
3388         Reviewed by Darin Adler.
3389
3390         * Scripts/prepare-ChangeLog:
3391         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3392         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3393         keep consuming the quoted text until the matching quotation mark is reached. Emit the
3394         warning only if a line ends without a backslash before the matching quotation mark was found.
3395
3396 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3397
3398         Remove unused "preprocessor" parameter to sub-CodeGenerators
3399         https://bugs.webkit.org/show_bug.cgi?id=142793
3400
3401         Reviewed by Darin Adler.
3402
3403         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3404         (new):
3405
3406 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3407
3408         [EFL] Bump gstreamer version to 1.4.4
3409         https://bugs.webkit.org/show_bug.cgi?id=142782
3410
3411         Reviewed by Philippe Normand.
3412
3413         * efl/jhbuild.modules:
3414         * efl/patches/gst-libav.patch:
3415         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3416         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3417
3418 2015-03-17  Tim Horton  <timothy_horton@apple.com>
3419
3420         Fix the iOS build.
3421
3422         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3423         (WTR::InjectedBundle::platformInitialize):
3424
3425 2015-03-17  Dean Jackson  <dino@apple.com>
3426
3427         check-webkit-style should allow "bool a : 1"
3428         https://bugs.webkit.org/show_bug.cgi?id=142794
3429
3430         Reviewed by Brent Fulgham.
3431
3432         We should allow member bitfields of the form:
3433
3434         bool m_var : 1;
3435
3436         It seems that Visual Studio 8 was the last compiler that
3437         wasn't happy about not using unsigned here. We already have
3438         about 500 cases (in WebCore) where people were ignoring this rule.
3439
3440         * Scripts/webkitpy/style/checkers/cpp.py:
3441         (check_language): Allow "bool".
3442         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3443         (CppStyleTest.test_enum_bitfields):
3444         (CppStyleTest.test_plain_integral_bitfields):
3445
3446 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
3447
3448         Compile character ranges targeting the same state as range check in the bytecode
3449         https://bugs.webkit.org/show_bug.cgi?id=142759
3450
3451         Reviewed by Alex Christensen.
3452
3453         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3454         (TestWebKitAPI::TEST_F):
3455
3456 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3457
3458         W3C test parser and converter should use test importer host
3459         https://bugs.webkit.org/show_bug.cgi?id=142729
3460
3461         Reviewed by Bem Jones-Bey.
3462
3463         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3464         This enables adding more TestImporter unit testing.
3465         This patch also ensures that the git object instantiated by TestDownloader is using the
3466         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3467
3468         * Scripts/webkitpy/common/system/filesystem_mock.py:
3469         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3470         * Scripts/webkitpy/w3c/test_downloader.py:
3471         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3472         (TestDownloader.checkout_test_repository): Making use of the new git function.
3473         * Scripts/webkitpy/w3c/test_importer.py:
3474         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3475         (TestImporter.import_tests): Adding host as parameter to the converter.
3476         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3477         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3478         (TestImporterTest):
3479         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
3480         * Scripts/webkitpy/w3c/test_parser.py:
3481         (TestParser.__init__): Adding host as parameter constructor.
3482
3483 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3484
3485         [GTK] WebKitDOM objects leaking
3486         https://bugs.webkit.org/show_bug.cgi?id=118788
3487
3488         Reviewed by Darin Adler and Sergio Villar Senin.
3489
3490         Update DOMObjectCache unit test to check that DOM objects are also
3491         released when new contents are loaded in the web view, and the old
3492         document is detached from the frame.
3493
3494         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3495         (testWebKitDOMObjectCache):
3496         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3497         (runTest):
3498
3499 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3500
3501         W3C test importer default import folder should be LayoutTests/imported/w3c
3502         https://bugs.webkit.org/show_bug.cgi?id=142728
3503
3504         Reviewed by Bem Jones-Bey.
3505
3506         * Scripts/webkitpy/w3c/test_importer.py:
3507         (parse_args): Updating the default destination option value to 'imported/w3c'.
3508
3509 2015-03-17  Philippe Normand  <pnormand@igalia.com>
3510
3511         [GTK] basic OpenWebRTC build support
3512         https://bugs.webkit.org/show_bug.cgi?id=142393
3513
3514         Reviewed by Carlos Garcia Campos.
3515
3516         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3517         is not the upstream OpenWebRTC repository. This temporary fork
3518         contains a few patches needed by WebKit for audio/video rendering.
3519
3520 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3521
3522         [CMake][EFL] Build test tools only for developer mode
3523         https://bugs.webkit.org/show_bug.cgi?id=142761
3524
3525         Reviewed by Csaba Osztrogonác.
3526
3527         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3528
3529         * CMakeLists.txt:
3530
3531 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
3532
3533         Remove never used "useLayerOnTop" bindings generator argument
3534         https://bugs.webkit.org/show_bug.cgi?id=142773
3535
3536         Reviewed by Darin Adler.
3537
3538         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3539         (new):
3540
3541 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
3542
3543         Enable ES6 classes by default
3544         https://bugs.webkit.org/show_bug.cgi?id=142774
3545
3546         Reviewed by Gavin Barraclough.
3547
3548         * Scripts/webkitperl/FeatureList.pm:
3549
3550 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3551
3552         Fix webkitpy tests after r181585.
3553
3554         Looks like "me" cannot be anyone's email, it's a special case.
3555
3556         * Scripts/webkitpy/common/config/contributors.json:
3557
3558 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3559
3560         Add tolerance to WebAudio tests
3561         https://bugs.webkit.org/show_bug.cgi?id=142676
3562
3563         Reviewed by Tim Horton.
3564
3565         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3566
3567         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3568         (TestResultWriter.create_audio_diff_and_write_result):
3569         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3570         (FailureAudio.write_failure):
3571         * Scripts/webkitpy/port/base.py:
3572         (Port.do_audio_results_differ):
3573         Diff audio failures.
3574
3575         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3576         tests to use real parseable WAV data, and got rid of base64, which there didn't
3577         seem to have been any reason for.
3578
3579 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3580
3581         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3582         https://bugs.webkit.org/show_bug.cgi?id=142720
3583
3584         Reviewed by Myles C. Maxfield.
3585
3586         Activate system copies of Microsoft fonts for the current process, thus overriding
3587         any other ones that could be preferred by the system otherwise.
3588
3589         * DumpRenderTree/mac/DumpRenderTree.mm:
3590         (activateSystemCoreWebFonts):
3591         (adjustFonts):
3592         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3593         (WTR::activateSystemCoreWebFonts):
3594         (WTR::activateFonts):
3595
3596 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3597
3598         Created Streams API watchlist
3599         https://bugs.webkit.org/show_bug.cgi?id=142684
3600
3601         Reviewed by Benjamin Poulain.
3602
3603         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
3604         watchlist and added Benjamin, Youenn and me to it.
3605
3606 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
3607
3608         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
3609         https://bugs.webkit.org/show_bug.cgi?id=142715
3610
3611         Reviewed by Brent Fulgham.
3612
3613         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3614         (TestWebKitAPI::TEST):
3615
3616 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
3617
3618         Change the exact attribute matching to be ASCII case-insensitive
3619         https://bugs.webkit.org/show_bug.cgi?id=142609
3620
3621         Reviewed by Darin Adler.
3622
3623         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3624         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3625
3626 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3627
3628         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
3629         https://bugs.webkit.org/show_bug.cgi?id=134764
3630
3631         Reviewed by Ryosuke Niwa.
3632
3633         TestDownloader is introduced to download W3C tests from the official
3634         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
3635         and https://github.com/w3c/csswg-test.git).
3636         TestDownloader clones the repositories and checkouts revisions of the tests
3637         defined in LayoutTests/imported/w3c/resources/TestRepositories.
3638
3639         Similarly to https://codereview.chromium.org/148173016,
3640         TestDownloader copies part of the files based on the rules
3641         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
3642
3643         TestDownloader is used by TestImporter when no source directory is provided.
3644
3645         * Scripts/webkitpy/w3c/test_downloader.py: Added.
3646         (TestDownloader):
3647         (TestDownloader.default_options):
3648         (TestDownloader.load_test_repositories):
3649         (TestDownloader.__init__):
3650         (TestDownloader.checkout_test_repository):
3651         (TestDownloader._init_paths_from_expectations):
3652         (TestDownloader._add_test_suite_paths):
3653         (TestDownloader._empty_directory):
3654         (TestDownloader.copy_tests):
3655         (TestDownloader.download_tests):
3656         * Scripts/webkitpy/w3c/test_importer.py:
3657         (main):
3658         (parse_args):
3659         (TestImporter.__init__):
3660         (TestImporter.do_import):
3661         (TestImporter.test_downloader):
3662         (TestImporter.find_importable_tests.should_keep_subdir):
3663         (TestImporter.should_convert_test_harness_links):
3664         (TestImporter.import_tests):
3665         (TestImporter.write_import_log):
3666
3667 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3668
3669         [Mavericks] Test snapshots are 1600x1200 on Retina devices
3670         https://bugs.webkit.org/show_bug.cgi?id=142630
3671
3672         Reviewed by Tim Horton.
3673
3674         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3675         Removed an ifdef that disabled the fix on Mavericks.
3676
3677 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3678
3679         Remove isWK2 cruft from webkitdirs.pm after r170426
3680         https://bugs.webkit.org/show_bug.cgi?id=142618
3681
3682         Reviewed by Daniel Bates.
3683
3684         * Scripts/webkitdirs.pm:
3685         (isWK2): Deleted.
3686
3687 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3688
3689         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
3690         https://bugs.webkit.org/show_bug.cgi?id=138687
3691
3692         Reviewed by Carlos Garcia Campos.
3693
3694         Always change cookie policy from UI process, as changing it from WebProcess doesn't
3695         affect other processes.
3696
3697         The implementation is imperfect, because the change happens asynchronously, but I
3698         don't expect it to be a problem in practice.
3699
3700         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3701         (WTR::InjectedBundle::beginTesting):
3702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3703         (WTR::TestRunner::setAlwaysAcceptCookies):
3704         * WebKitTestRunner/TestInvocation.cpp:
3705         (WTR::TestInvocation::invoke):
3706         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3707
3708 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3709
3710         [EFL] Enable building EFL 1.13 with NEON support
3711         https://bugs.webkit.org/show_bug.cgi?id=142619
3712
3713         Reviewed by Gyuyoung Kim.
3714
3715         * efl/jhbuild.modules:
3716
3717 2015-03-11  Alex Christensen  <achristensen@webkit.org>
3718
3719         [Content Extensions] Add resource type and load type triggers.
3720         https://bugs.webkit.org/show_bug.cgi?id=142422
3721
3722         Reviewed by Benjamin Poulain.
3723
3724         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3725         (TestWebKitAPI::testRequest):
3726         (TestWebKitAPI::mainDocumentRequest):
3727         (TestWebKitAPI::TEST_F):
3728         (TestWebKitAPI::testURL): Deleted.
3729
3730 2015-03-10  Sam Weinig  <sam@webkit.org>
3731
3732         Allow adding a button in input elements for auto fill related functionality
3733         <rdar://problem/19782066>
3734         https://bugs.webkit.org/show_bug.cgi?id=142564
3735
3736         Reviewed by Anders Carlsson.
3737
3738         * WebKitTestRunner/TestController.cpp:
3739         (WTR::TestController::createOtherPage):
3740         (WTR::TestController::createWebViewWithOptions):
3741         Update for new callback.
3742
3743 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
3744
3745         Add basic support for BOL and EOL assertions to the URL Filter parser
3746         https://bugs.webkit.org/show_bug.cgi?id=142568
3747
3748         Reviewed by Alex Christensen.
3749
3750         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3751         (TestWebKitAPI::TEST_F):
3752
3753 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3754
3755         [GTK] Add support for handling TLS errors to MiniBrowser
3756         https://bugs.webkit.org/show_bug.cgi?id=142576
3757
3758         Reviewed by Sergio Villar Senin.
3759
3760         It's useful for testing TLS errors handling itself, but also to
3761         allow ignoring TLS errors when testing.
3762
3763         * MiniBrowser/gtk/BrowserWindow.c:
3764         (webViewLoadFailedWithTLSerrors):
3765         (browserWindowConstructed):
3766
3767 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3768
3769         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
3770         https://bugs.webkit.org/show_bug.cgi?id=142569
3771
3772         Reviewed by David Hyatt.
3773
3774         Test Optional::valueOrCompute().
3775
3776         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3777         (TestWebKitAPI::TEST):
3778
3779 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3780
3781         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
3782         https://bugs.webkit.org/show_bug.cgi?id=126688
3783
3784         Reviewed by Gustavo Noronha Silva.
3785
3786         * CMakeLists.txt: Build testing tools only for developer builds,
3787         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
3788         * MiniBrowser/gtk/CMakeLists.txt: Only add
3789         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
3790         and add a rule to install the MiniBrowser.
3791         * MiniBrowser/gtk/main.c:
3792         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
3793         builds.
3794
3795 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
3796
3797         Add some DateMath tests to TestWebKitAPI
3798         https://bugs.webkit.org/show_bug.cgi?id=142565
3799
3800         Reviewed by Alexey Proskuryakov.
3801
3802         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
3803         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3804         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
3806         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
3807
3808 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
3809
3810         Regression(r181257): WTF_WorkQueue.Simple is flaky
3811         https://bugs.webkit.org/show_bug.cgi?id=142560
3812
3813         Unreviewed attempt to improve test stability.
3814
3815         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
3816         the WorkQueue a little later to redue flakiness.
3817
3818 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3819
3820         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
3821         https://bugs.webkit.org/show_bug.cgi?id=142555
3822
3823         Reviewed by Simon Fraser.
3824
3825         * DumpRenderTree/mac/DumpRenderTree.mm:
3826         (setDefaultsToConsistentValuesForTesting):
3827         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3828         (WTR::InjectedBundle::platformInitialize):
3829
3830 2015-03-10  Alex Christensen  <achristensen@webkit.org>
3831
3832         Use unsigned for HashSet size.
3833         https://bugs.webkit.org/show_bug.cgi?id=142518
3834
3835         Reviewed by Benjamin Poulain.
3836
3837         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3838         (TestWebKitAPI::TEST):
3839         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3840         (TestWebKitAPI::testInitialCapacity):
3841         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3842         (TestWebKitAPI::TEST):
3843
3844 2015-03-10  Daniel Bates  <dabates@apple.com>
3845
3846         [iOS] Add WebKitSystemInterface for iOS 8.2
3847         https://bugs.webkit.org/show_bug.cgi?id=142505
3848
3849         Rubber-stamped by Anders Carlsson.
3850
3851         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
3852         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
3853         copy-webkitlibraries-to-product-directory in r181286.
3854
3855         * Scripts/copy-webkitlibraries-to-product-directory:
3856
3857 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
3858
3859         Extend URL filter's Term definition to support groups/subpatterns
3860         https://bugs.webkit.org/show_bug.cgi?id=142519
3861
3862         Reviewed by Alex Christensen.
3863
3864         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3865         (TestWebKitAPI::testURL):
3866
3867 2015-03-06  Jer Noble  <jer.noble@apple.com>
3868
3869         Add an option to run-webkit-tests to override the LayoutTests/ directory
3870         https://bugs.webkit.org/show_bug.cgi?id=142418
3871
3872         Reviewed by David Kilzer.
3873
3874         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
3875         directory. The base port will parse the options during initialization and store the override
3876         location if present. layout_tests_dir() will return this overridden location if set.
3877
3878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3879         (parse_args):
3880         * Scripts/webkitpy/port/base.py:
3881         (Port.__init__):
3882         (Port.layout_tests_dir):
3883
3884 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
3885
3886         [CMake] Enable WorkQueue tests for CMake ports
3887         https://bugs.webkit.org/show_bug.cgi?id=142473
3888
3889         Reviewed by Darin Adler.
3890
3891         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
3892         the list of source files.
3893         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
3894         to the list of include directories for EFL.
3895
3896 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3897
3898         Attempt to fix timeouts on iOS Simulator layout tests
3899
3900         * Scripts/webkitpy/port/ios.py:
3901         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
3902         Simulator end after the first 50 tests time out.  Some analysis
3903         this past weekend shows that the 'Booted' status in the output
3904         of `xcrun simctl list` is not sufficient (and watching the test
3905         run shows that SpringBoard hasn't fully started to the point
3906         where it's displaying icons on the home screen).  The workaround
3907         until we have a better fix is to add an arbitrary timeout to let
3908         SpringBoard finish launching.  In practice, 15 seconds is
3909         probably enough, but 30 seconds should nearly always work.
3910
3911 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
3912
3913         Unreviewed. Add myself as a committer.
3914
3915         * Scripts/webkitpy/common/config/contributors.json:
3916
3917 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3918
3919         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3920
3921         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3922         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3923         an expectation that will fail if we hit the race condition.
3924         This test is inherently racy and will deadlock if the first job
3925         for queue2 takes the mutex lock before the second job for
3926         queue1.
3927
3928 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3929
3930         [Win] WTF::WorkQueue does not balance ref/deref properly
3931         https://bugs.webkit.org/show_bug.cgi?id=142471
3932
3933         Reviewed by Antti Koivisto.
3934
3935         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3936         (TestWebKitAPI::TEST): Check that the refcount is correct.
3937
3938 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3939
3940         Do not show passing test result on output of EFL layout test
3941         https://bugs.webkit.org/show_bug.cgi?id=142380
3942
3943         Reviewed by Darin Adler.
3944
3945         To show passing tests has caused inconvenience when we detect problem tests
3946         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3947         in order not to show passing tests in the output of EFL layout test.
3948
3949         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3950         (RunWebKitTests.start):
3951
3952 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3953
3954         Unreviewed build fix.
3955
3956         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3957         (TestWebKitAPI::TEST): Remove two unused variables.
3958
3959 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3960
3961         Add some WorkQueue tests to TestWebKitAPI
3962         https://bugs.webkit.org/show_bug.cgi?id=142447
3963
3964         Reviewed by Sam Weinig.
3965
3966         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3967         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3968         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3969         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3970         (TestWebKitAPI::simpleTest):
3971         (TestWebKitAPI::longTest):
3972         (TestWebKitAPI::thirdTest):
3973         (TestWebKitAPI::finishedTests):
3974         (TestWebKitAPI::TEST):
3975         (TestWebKitAPI::longTest2):
3976
3977 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3978
3979         Remove willDestroyFrame in WKBundlePageLoaderClient
3980         https://bugs.webkit.org/show_bug.cgi?id=142389
3981
3982         Reviewed by Anders Carlsson.
3983
3984         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3985         (WTR::InjectedBundlePage::InjectedBundlePage):
3986
3987 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
3988
3989         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3990         https://bugs.webkit.org/show_bug.cgi?id=142433
3991
3992         Reviewed by Darin Adler.
3993
3994         Include more TestWebKitAPI tests when building for Windows. Also
3995         fix a build error in MetaAllocator.cpp caused by one of the
3996         Microsoft headers #defining 'small'.
3997
3998         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3999         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
4000         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
4001
4002 2015-03-06  Sam Weinig  <sam@webkit.org>
4003
4004         [Content Extensions] Move compiling of content extensions to the UIProcess
4005         https://bugs.webkit.org/show_bug.cgi?id=142402
4006
4007         Reviewed by Benjamin Poulain.
4008
4009         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4010         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
4011         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
4012         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
4013         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
4014         (TestWebKitAPI::TEST_F):
4015         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
4016         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
4017         is now abstract).
4018
4019 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
4020
4021         [Win] Correct Windows build.
4022
4023         Rubberstamped by Michael Saboff
4024
4025         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
4026         in the GOTO labels.
4027
4028 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
4029
4030         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
4031         https://bugs.webkit.org/show_bug.cgi?id=142385
4032
4033         Reviewed by Sergio Villar Senin.
4034
4035         Use stack allocated GMainLoopSources to make sure they are
4036         cancelled automatically if the test finishes before they have
4037         been processed.
4038
4039         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
4040         (testWebViewSyncRequestOnMaxConns):
4041
4042 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
4043
4044         Remove Mountain Lion libraries since ML isn't supported
4045         https://bugs.webkit.org/show_bug.cgi?id=142332
4046
4047         Reviewed by Darin Adler.
4048
4049         * Scripts/copy-webkitlibraries-to-product-directory:
4050
4051 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
4052
4053         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
4054         https://bugs.webkit.org/show_bug.cgi?id=142083
4055
4056         Reviewed by Simon Fraser.
4057
4058         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
4059
4060         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
4061         (WebPlatformTestServer._copy_webkit_test_files):
4062
4063 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
4064
4065         setup-git-clone fails due to the failure to download python-irclib-0.4.8
4066         https://bugs.webkit.org/show_bug.cgi?id=141946
4067
4068         Reviewed by Ryosuke Niwa.
4069
4070         Check in ircbot.py and irclib.py to avoid network problems in the future.
4071
4072         * Scripts/webkitpy/common/net/irc/ircbot.py:
4073         * Scripts/webkitpy/thirdparty/__init__.py:
4074         (AutoinstallImportHook.find_module):
4075         (AutoinstallImportHook._install_irc): Deleted.
4076         * Scripts/webkitpy/thirdparty/__init___unittest.py:
4077         (ThirdpartyTest.test_imports):
4078         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
4079         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
4080         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
4081
4082 2015-03-06  David Kilzer  <ddkilzer@apple.com>
4083
4084         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
4085
4086         See also fix to config.json in r181097.
4087
4088         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4089         (WebKitBuildbot): Add missing "WK2" to the names of the perf
4090         bots.
4091
4092 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
4093
4094         run-jsc-stress-tests should determine the architecture from ELF binaries
4095         https://bugs.webkit.org/show_bug.cgi?id=142335
4096
4097         Reviewed by Darin Adler.
4098
4099         * Scripts/run-jsc-stress-tests:
4100
4101 2015-03-05  David Kilzer  <ddkilzer@apple.com>
4102
4103         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
4104         <http://webkit.org/b/142226>
4105
4106         Reviewed by Darin Adler.
4107
4108         * Scripts/webkitpy/port/ios.py:
4109         (IOSSimulatorPort.default_baseline_search_path): Switch the
4110         TestExpectations order of ios-simulator-wk2 from this:
4111           ios-simulator-wk2, wk2, ios-simulator
4112         To this:
4113           ios-simulator-wk2, ios-simualtor, wk2
4114
4115 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
4116
4117         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
4118         https://bugs.webkit.org/show_bug.cgi?id=142370
4119
4120         Reviewed by Dean Jackson.
4121
4122         * Scripts/webkitdirs.pm:
4123         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
4124         logs, one for warnings, the other for errors.
4125         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
4126         into the standard BuildOutput.htm document.
4127
4128 2015-03-05  David Kilzer  <ddkilzer@apple.com>
4129
4130         Dashboard has trouble parsing iOS test output
4131         <http://webkit.org/b/142364>
4132
4133         Reviewed by Alex Christensen.
4134
4135         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
4136         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
4137         Add fallback path to build a regex using 'matchString' so that
4138         it matches anywhere in the line.  In practice, 'matchString' is
4139         a prefix for the label following the number.
4140
4141 2015-03-05  Alex Christensen  <achristensen@webkit.org>
4142
4143         Fix linker warnings in TestWebKitAPI.
4144         https://bugs.webkit.org/show_bug.cgi?id=141912
4145
4146         Reviewed by David Kilzer.
4147
4148         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4149         Do not export TearDownTestCase or SetUpTestCase symbols.
4150
4151 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
4152
4153         [Win] Unreviewed EWS fix.
4154
4155         * Scripts/webkitdirs.pm:
4156         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
4157         the EWS output more usable.
4158
4159 2015-03-05  Chris Dumez  <cdumez@apple.com>
4160
4161         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
4162         https://bugs.webkit.org/show_bug.cgi?id=142350
4163
4164         Reviewed by Michael Saboff and Benjamin Poulain.
4165
4166         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
4167         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
4168
4169         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4170         (TestWebKitAPI::TEST):
4171
4172 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
4173
4174         [Win] Ensure build target directory exists when launching MSBuild
4175         https://bugs.webkit.org/show_bug.cgi?id=142360
4176
4177         Reviewed by Dean Jackson.
4178
4179         Create the build output directory (if it doesn't exist) before
4180         launching MSBuild so that it can immediately begin writing logs.
4181
4182         * Scripts/webkitdirs.pm:
4183         (buildVisualStudioProject):
4184
4185 2015-03-05  Chris Dumez  <cdumez@apple.com>
4186
4187         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
4188         https://bugs.webkit.org/show_bug.cgi?id=142325
4189
4190         Reviewed by Csaba Osztrogonác.
4191
4192         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
4193         As a result, "--webkit-test-runner / -2" parameters are replaced by
4194         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
4195         than WebKitTestRunner.
4196
4197         * BuildSlaveSupport/build.webkit.org-config/config.json:
4198         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4199         (RunWebKit1Tests):
4200         (RunWebKit1Tests.start):
4201         (RunWebKit1LeakTests):
4202         (RunWebKit1LeakTests.start):
4203         (RunAndUploadPerfTestsWebKit1):
4204         (RunAndUploadPerfTestsWebKit1.start):
4205         (TestFactory):
4206         (TestWebKit1LeaksFactory):
4207         (TestWebKit1LeaksFactory.__init__):
4208         (TestWebKit1Factory):
4209         (TestWebKit1AllButJSCFactory):
4210         (TestAllButJSCFactory):
4211         (BuildAndPerfTestWebKit1Factory):
4212         (BuildAndPerfTestWebKit1Factory.__init__):
4213         (BuildAndPerfTestFactory):
4214         (BuildAndPerfTestFactory.__init__):
4215         (DownloadAndPerfTestWebKit1Factory):
4216         (DownloadAndPerfTestWebKit1Factory.__init__):
4217         (DownloadAndPerfTestFactory):
4218         (DownloadAndPerfTestFactory.__init__):
4219         (RunWebKitLeakTests): Deleted.
4220         (RunWebKitLeakTests.start): Deleted.
4221         (RunWebKit2Tests): Deleted.
4222         (RunWebKit2Tests.start): Deleted.
4223         (RunAndUploadPerfTestsWebKit2): Deleted.
4224         (RunAndUploadPerfTestsWebKit2.start): Deleted.
4225         (TestLeaksFactory): Deleted.
4226         (TestLeaksFactory.__init__): Deleted.
4227         (TestWebKit2Factory): Deleted.
4228         (TestWebKit2AndJSCFactory): Deleted.
4229         (BuildAndPerfTestWebKit2Factory): Deleted.
4230         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
4231         (DownloadAndPerfTestWebKit2Factory): Deleted.
4232         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
4233         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4234         (parse_args):
4235         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4236         (PerfTestsRunner._parse_args):
4237         * Scripts/webkitpy/port/port_testcase.py:
4238         (PortTestCase.test_build_driver):
4239
4240 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
4241
4242         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
4243         https://bugs.webkit.org/show_bug.cgi?id=140845
4244
4245         Reviewed by David Kilzer.
4246
4247         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
4248         and generate suitable build commands to drive a full build from our
4249         existing solution files.
4250
4251         * Scripts/webkitdirs.pm:
4252         (msBuildInstallDir): Added.
4253         (determineConfigurationForVisualStudio): Revise to use MSBuild command
4254         line arguments to drive the build.
4255         (setupCygwinEnv): Warn user if MSBuild cannot be located.
4256         (buildVisualStudioProject): Revise to use MSBuild command line arguments
4257         to specify build architecture.
4258         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
4259         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
4260         bother looking for CoreUI or SafariTheme build logs.
4261
4262 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4263
4264         [buildbot] mastercfg_unittest.py should be runnable easily
4265         https://bugs.webkit.org/show_bug.cgi?id=142219
4266
4267         Reviewed by Chris Dumez.
4268
4269         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
4270         the last Twisted version works together with this buildbot version.
4271
4272         * Scripts/webkitpy/common/system/autoinstall.py:
4273         (AutoInstaller): Added prepend_to_search_path argument to be able
4274         to prefer autoinstalled package to system package.
4275         (AutoInstaller.__init__):
4276         (AutoInstaller._set_up_target_dir):
4277         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
4278         (AutoInstaller._prepare_package):
4279         (AutoInstaller._extract_targz): Renamed to _extract_tar.
4280         * Scripts/webkitpy/thirdparty/__init__.py:
4281         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
4282
4283 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
4284
4285         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
4286         https://bugs.webkit.org/show_bug.cgi?id=131162
4287
4288         Reviewed by Gyuyoung Kim.
4289
4290         * MiniBrowser/efl/main.c:
4291         (on_download_request):
4292         (on_download_finished):
4293         (on_download_failed):
4294         (window_create):
4295         Adapt download callbacks to new callback mechanism
4296
4297 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4298
4299         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
4300
4301         In r180927 we updated the libsoup version used by the jhbuild. In
4302         this new version the sniffer uses image/x-icon instead of
4303         image/vnd.microsoft.icon for blank.ico resource.
4304
4305         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
4306         (testWebResourceMimeType):
4307
4308 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4309
4310         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
4311         https://bugs.webkit.org/show_bug.cgi?id=142244
4312
4313         Reviewed by Sergio Villar Senin.
4314
4315         Check that the SSL server doesn't process any request in case of
4316         TLS errors when the policy is set to FAIL.
4317
4318         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
4319         (testTLSErrorsPolicy):
4320         (testTLSErrorsRedirect):
4321         (testTLSErrorsHTTPAuth):
4322         (testLoadFailedWithTLSErrors):
4323         (testSubresourceLoadFailedWithTLSErrors):
4324         (httpsServerCallback):
4325
4326 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
4327
4328         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
4329         https://bugs.webkit.org/show_bug.cgi?id=141154
4330
4331         Reviewed by Jer Noble.
4332
4333         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
4334
4335         For the sake of completeness WebKitTestRunner should specify temporary
4336         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
4337
4338         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
4339         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
4340         to get data storage paths. Only Mac port has an actual implementation of it.
4341         However, WebKitTestRunner overrides them in favour of unique temporary dir
4342         which is taken from libraryPathForTesting().
4343
4344         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
4345         is not implemented for EFL and GTK ports it returns an empty string.
4346         All default data folders besides MediaKeys are overridden in TestRunner
4347         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
4348         env variable.
4349
4350         GTK port does not enable encrypted keys by default so
4351         WebMediaKeyStorageManager::initialize() code path is never triggered.
4352
4353         * WebKitTestRunner/TestController.cpp:
4354         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
4355         WebKit ports.
4356
4357 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4358
4359         [buildbot] Add regression test to check which builder runs which tests
4360         https://bugs.webkit.org/show_bug.cgi?id=142166
4361
4362         Reviewed by Alexey Proskuryakov.
4363
4364         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4365         (BuildStepsConstructorTest.createTest):
4366         (BuildStepsTest):
4367         (BuildStepsTest.generateTests):
4368         (BuildStepsTest.createTest):
4369         (BuildStepsTest.createTest.doTest):
4370         (BuildStepsTest.test_unnecessary_expected_results):