[Qt][WK2] Convert touch-point area
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2
3         [Qt][WK2] Convert touch-point area
4         https://bugs.webkit.org/show_bug.cgi?id=84434
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Fix failing test after r114917 by also adding the new EventSender API
9         to WebKitTestRunner.
10
11         * WebKitTestRunner/EventSenderProxy.h:
12         (EventSenderProxy):
13         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
14         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
15         (WTR::EventSendingController::setTouchPointRadius):
16         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
17         (EventSendingController):
18         * WebKitTestRunner/TestController.cpp:
19         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
20         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
21         (WTR::EventSenderProxy::addTouchPoint):
22         (WTR::EventSenderProxy::updateTouchPoint):
23         (WTR::EventSenderProxy::setTouchPointRadius):
24         (WTR::EventSenderProxy::clearTouchPoints):
25
26 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
27
28         [Chromium] Unreviewed test expectations update.
29         https://bugs.webkit.org/show_bug.cgi?id=84726
30
31         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
32
33         * Scripts/webkitpy/test/test_finder.py:
34         (TestFinder._default_names):
35
36 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
37
38         [EFL] Enable Web Timing
39         https://bugs.webkit.org/show_bug.cgi?id=84705
40
41         Reviewed by Tony Gentilcore.
42
43         Enable web timing by default whenever build-webkit is used.
44
45         * Scripts/build-webkit:
46
47 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
48
49         Return value from executed script in Chromium.
50         https://bugs.webkit.org/show_bug.cgi?id=79851
51
52         Reviewed by Adam Barth.
53
54         Adding a function to LayoutTestController that evaluates a script in
55         an isolated wold an returns the result of the evaluation.
56
57         * DumpRenderTree/LayoutTestController.cpp:
58         (evaluateScriptInIsolatedWorldAndReturnValue):
59         (LayoutTestController::staticFunctions):
60         * DumpRenderTree/LayoutTestController.h:
61         (LayoutTestController):
62         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
63         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
64         * DumpRenderTree/chromium/LayoutTestController.cpp:
65         (LayoutTestController::LayoutTestController):
66         (LayoutTestController::setXSSAuditorEnabled):
67         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
68         * DumpRenderTree/chromium/LayoutTestController.h:
69         (LayoutTestController):
70         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
71         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
72         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
73         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
74         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
75         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
76         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
77         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
78         * DumpRenderTree/qt/LayoutTestControllerQt.h:
79         (LayoutTestController):
80         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
81         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
82         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
83         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
84
85 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
86
87         run-perf-tests fail intermittently with an exception
88         https://bugs.webkit.org/show_bug.cgi?id=83532
89
90         Reviewed by Ryosuke Niwa.
91
92         This bulletproofs port.get_option('child_processes')
93         against the case where the option wasn't set.
94
95         * Scripts/webkitpy/layout_tests/port/mac.py:
96         (MacPort._get_crash_log):
97         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
98         (test_get_crash_log):
99         (test_get_crash_log.fake_time_cb):
100
101 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
102
103         [Qt] Add desktop zooming support for QQuickWebView
104         https://bugs.webkit.org/show_bug.cgi?id=82337
105
106         Unreviewed typo fix after r114900.
107
108         * MiniBrowser/qt/BrowserWindow.cpp:
109         (BrowserWindow::BrowserWindow): Fix the mistyped
110         value of a zoom level.
111
112 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
113
114         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
115         https://bugs.webkit.org/show_bug.cgi?id=84580
116
117         Reviewed by Ojan Vafai.
118
119         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
120         Take the opportunity to get rid of the trick.
121
122         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
123         (ChromiumAndroidPort.start_helper):
124         (ChromiumAndroidPort._push_fonts):
125
126 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
127
128         test-webkitpy is failing
129         https://bugs.webkit.org/show_bug.cgi?id=84617
130
131         Reviewed by Eric Seidel.
132
133         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
134         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
135
136 2012-04-23  Ojan Vafai  <ojan@chromium.org>
137
138         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
139         of making the code more maintainable (e.g. being able to use qunit for testing).
140
141         * TestResultServer/static-dashboards/dashboard_base.js:
142         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
143         * TestResultServer/static-dashboards/flakiness_dashboard.html:
144         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
145         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
146         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
147
148 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
149
150         [Qt][WK2] Convert touch-point area.
151         https://bugs.webkit.org/show_bug.cgi?id=84434
152
153         Reviewed by Kenneth Rohde Christiansen.
154
155         Add feature to set touch-point radius for emitted touch-events.
156
157         * DumpRenderTree/qt/EventSenderQt.cpp:
158         (EventSender::addTouchPoint):
159         (EventSender::updateTouchPoint):
160         (EventSender::setTouchPointRadius):
161         (EventSender::clearTouchPoints):
162         * DumpRenderTree/qt/EventSenderQt.h:
163         (EventSender):
164
165 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
166
167         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
168         https://bugs.webkit.org/show_bug.cgi?id=84425
169
170         Reviewed by Antonio Gomes.
171
172         Use the new helper in DumpRenderTreeSupportEfl to properly
173         test whether an element performs autocompletion.
174
175         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
176         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
177
178 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
179
180         master.cfg cleanup, remove dead codes after r92792.
181         https://bugs.webkit.org/show_bug.cgi?id=84433
182
183         Relanding r114881 after typo fix in UploadBuiltProduct.
184
185         Reviewed by Ryosuke Niwa.
186
187         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
188
189 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
190
191         [EFL][DRT] Need to support requestAnimationFrame
192         https://bugs.webkit.org/show_bug.cgi?id=84585
193
194         Reviewed by Martin Robinson.
195
196         Making requestAnimationFrame() support a default on the EFL build.
197
198         * Scripts/build-webkit:
199
200 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
201
202         [Qt] Add desktop zooming support for QQuickWebView
203         https://bugs.webkit.org/show_bug.cgi?id=82337
204
205         Reviewed by Simon Hausmann.
206
207         Add zooming support for MiniBrowser to
208         test the new API.
209
210         * MiniBrowser/qt/BrowserWindow.cpp:
211         (BrowserWindow::BrowserWindow):
212         (BrowserWindow::zoomIn):
213         (BrowserWindow::zoomOut):
214         (BrowserWindow::keyPressEvent):
215         (BrowserWindow::wheelEvent):
216         * MiniBrowser/qt/BrowserWindow.h:
217         (BrowserWindow):
218
219 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
220
221         Unreviewed rolling out r114881, because it broke upload buildstep.
222
223         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
224         (ConfigureBuild.__init__):
225         (ConfigureBuild.start):
226         (CompileWebKit.start):
227         (UploadBuiltProduct):
228         (UploadBuiltProduct.determineExtraFeatures):
229         (Factory.__init__):
230         (BuildFactory.__init__):
231         (TestFactory.__init__):
232         (loadBuilderConfig):
233
234 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
235
236         master.cfg cleanup, remove dead codes after r92792.
237         https://bugs.webkit.org/show_bug.cgi?id=84433
238
239         Reviewed by Ryosuke Niwa.
240
241         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
242
243 2012-04-23  Milian Wolff  <mail@milianw.de>
244
245         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
246         https://bugs.webkit.org/show_bug.cgi?id=84327
247
248         Reviewed by Csaba Osztrogonác.
249
250         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
251         (WebCore::DumpRenderTree::dump):
252
253 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
254
255         [Gtk] Added MOZ_X11 build flag for TARGET_X11
256         https://bugs.webkit.org/show_bug.cgi?id=40785
257
258         Reviewed by Anders Carlsson.
259
260         * GNUmakefile.am:
261
262 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
263
264         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
265         https://bugs.webkit.org/show_bug.cgi?id=84544
266
267         Reviewed by Ryosuke Niwa.
268
269         Use the groupEnum parameter that is passed through to the onBuilderListLoad
270         function rather than an undefined attribute of the BuilderGroup object. This
271         makes it again possible to inspect builds on non-Chromium builders in the
272         test results server by not trying to always add Chromium revision links.
273
274         * TestResultServer/static-dashboards/builders.js:
275
276 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
277
278         [GTK] Revert changes that disabled Cairo fonts metrics hinting
279         https://bugs.webkit.org/show_bug.cgi?id=84502
280
281         Reviewed by Daniel Bates.
282
283         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
284         reference and pixel test results. This makes our font metrics a bit different
285         than the Mac port's, but it's a decent price to pay for consistent results.
286
287         * DumpRenderTree/gtk/DumpRenderTree.cpp:
288         (initializeGtkFontSettings):
289         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
290         (WTR::initializeGtkSettings):
291
292 2012-04-04  Jer Noble  <jer.noble@apple.com>
293
294         apple.com top navigation bar appears inside video during full screen exit animation
295         https://bugs.webkit.org/show_bug.cgi?id=83095
296
297         Reviewed by Eric Carlson.
298
299         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
300         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
301         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
302         from within LayoutTests.
303
304         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
305         * DumpRenderTree/LayoutTestController.cpp:
306         (setHasCustomFullScreenBehaviorCallback):
307         (LayoutTestController::staticFunctions):
308         * DumpRenderTree/LayoutTestController.h:
309         (LayoutTestController::setHasCustomFullScreenBehavior):
310         (LayoutTestController::hasCustomFullScreenBehavior):
311         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
312         (WTR::InjectedBundlePage::enterFullScreenForElement):
313         (WTR::InjectedBundlePage::exitFullScreenForElement):
314         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
315         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
316         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
317         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
318         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
319         * DumpRenderTree/chromium/LayoutTestController.cpp:
320         (LayoutTestController::LayoutTestController):
321         (LayoutTestController::reset):
322         * DumpRenderTree/chromium/LayoutTestController.h:
323         (LayoutTestController::setHasCustomFullScreenBehavior):
324         (LayoutTestController::hasCustomFullScreenBehavior):
325
326         Query the new methods before calling will/did/Enter/ExitFullScreen:
327         * DumpRenderTree/chromium/WebViewHost.cpp:
328         (WebViewHost::enterFullScreenNow):
329         (WebViewHost::exitFullScreenNow):
330         * DumpRenderTree/mac/UIDelegate.mm:
331         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
332         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
333
334 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
335
336         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
337         https://bugs.webkit.org/show_bug.cgi?id=72841
338
339         Reviewed by Dirk Pranke
340
341         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
342         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
343         and 'reference_files' fields to the TestInput objects, and use those flags
344         to select the right driver to use in the DriverProxy.
345
346         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
347         (SingleTestRunner.__init__):
348         (SingleTestRunner._driver_input):
349         (SingleTestRunner._run_reftest):
350         * Scripts/webkitpy/layout_tests/controllers/worker.py:
351         (Worker.handle_test_list):
352         (Worker._update_test_input):
353         * Scripts/webkitpy/layout_tests/models/test_input.py:
354         (TestInput):
355         (TestInput.__init__):
356         (TestInput.__repr__):
357         * Scripts/webkitpy/layout_tests/port/chromium.py:
358         (ChromiumDriver._wrapper_options):
359         (ChromiumDriver.run_test):
360         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
361         (ChromiumDriverTest.test_crash_log):
362         * Scripts/webkitpy/layout_tests/port/driver.py:
363         (DriverInput.__init__):
364         (Driver.__init__):
365         (DriverProxy.__init__):
366         (DriverProxy.run_test):
367         (DriverProxy.start):
368         (DriverProxy.cmd_line):
369         * Scripts/webkitpy/layout_tests/port/gtk.py:
370         (GtkDriver._start):
371         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
372         (MockDRT.run):
373         (MockDRT.input_from_line):
374         (MockDRT.output_for_test):
375         (MockDRT.write_test_output):
376         (MockChromiumDRT.input_from_line):
377         (MockChromiumDRT.output_for_test):
378         (MockChromiumDRT.write_test_output):
379         * Scripts/webkitpy/layout_tests/port/webkit.py:
380         (WebKitDriver.cmd_line):
381         (WebKitDriver.run_test):
382         * WebKitTestRunner/TestController.cpp:
383         (WTR::TestController::TestController):
384         (WTR::TestController::initialize):
385         (WTR::TestController::runTest):
386         * WebKitTestRunner/TestController.h:
387         (TestController):
388         * WebKitTestRunner/TestInvocation.cpp:
389         (WTR::TestInvocation::TestInvocation):
390         (WTR::TestInvocation::setIsPixelTest):
391         * WebKitTestRunner/TestInvocation.h:
392         (TestInvocation):
393
394 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
395
396         [EFL] Make it possible to define offline storage quota per origin
397         https://bugs.webkit.org/show_bug.cgi?id=84170
398
399         Improved LayoutTestController::setDatabaseQuota to set quota based on
400         origin which was causing some tests to fail. Also align the default
401         quota for testing (5MB) with others ports.
402
403         When dumpDatabaseCallbacks is set to true by, also dump some database
404         information when quota is exceed, which is also required by some tests.
405
406         Reviewed by Antonio Gomes.
407
408         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
409         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
410         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
411         (onExceededDatabaseQuota):
412         (drtViewAdd):
413         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
414         (LayoutTestController::setDatabaseQuota):
415
416 2012-04-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
417
418         [EFL] [DRT] Send double click event from EventSender
419         https://bugs.webkit.org/show_bug.cgi?id=82867
420
421         Reviewed by Daniel Bates.
422
423         Add support for EFL DumpRenderTree EventSender to send
424         double click events.
425
426         * DumpRenderTree/efl/EventSender.cpp:
427         (sendMouseEvent):
428
429 2012-04-20  Sergio Villar Senin  <svillar@igalia.com>
430
431         [GTK] Enable Web Timing
432         https://bugs.webkit.org/show_bug.cgi?id=42432
433
434         Reviewed by Gustavo Noronha Silva.
435
436         Build web timing by default whenever build-webkit is used.
437
438         * Scripts/build-webkit:
439
440 2012-04-20  Kamil Blank  <k.blank@samsung.com>
441
442         [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
443         https://bugs.webkit.org/show_bug.cgi?id=84430
444
445         Reviewed by Daniel Bates.
446
447         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
448         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
449
450 2012-04-20  Ryosuke Niwa  <rniwa@webkit.org>
451
452         REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
453         https://bugs.webkit.org/show_bug.cgi?id=84424
454
455         Reviewed by Mark Rowe.
456
457         Let Windows and Chromium have their own list of files to copy.
458
459         * BuildSlaveSupport/built-product-archive:
460         (removeDirectoryIfExists):
461         (copyBuildFiles):
462         (archiveBuiltProduct):
463
464 2012-04-20  Kamil Blank  <k.blank@samsung.com>
465
466         [EFL] Add setting API for author and user styles.
467         https://bugs.webkit.org/show_bug.cgi?id=82860
468
469         Reviewed by Daniel Bates.
470
471         Implementation of setAuthorAndUserStylesEnabled.
472
473         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
474         (LayoutTestController::setAuthorAndUserStylesEnabled):
475
476 2012-04-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
477
478         [EFL] Missing keycode translation for space key
479         https://bugs.webkit.org/show_bug.cgi?id=84153
480
481         Reviewed by Antonio Gomes.
482
483         Set keyname for space key before dispatching event.
484
485         * DumpRenderTree/efl/EventSender.cpp:
486         (keyNameFromJSValue):
487
488 2012-04-19  Carlos Garcia Campos  <cgarcia@igalia.com>
489
490         [GTK] Allow to use WebInspector in GtkLauncher
491         https://bugs.webkit.org/show_bug.cgi?id=84143
492
493         Reviewed by Martin Robinson.
494
495         * GNUmakefile.am: Add new files to compilation.
496         * GtkLauncher/LauncherInspectorWindow.c: Added.
497         (launcherInspectorWindowFinalize):
498         (launcher_inspector_window_init):
499         (launcher_inspector_window_class_init):
500         (inspectedURIChanged): Update the window title based on current
501         inspected URI.
502         (showInspectorWindow): Show inspector window.
503         (closeInspectorWindow): Hide inspector window.
504         (launcherInspectorWindowNew): Create an inspector window.
505         (launcherInspectorWindowGetWebView): Return the inspected web view.
506         * GtkLauncher/LauncherInspectorWindow.h: Added.
507         * GtkLauncher/main.c:
508         (inspectorInspectWebViewCb): Create an inspector window.
509         (createBrowser): Connect to inspect-web-view signal of the view
510         inspector.
511
512 2012-04-19  Jeremy Mao  <yujie.mao@intel.com>
513
514         Media Stream API: Piece of code cleanup for the chromium port
515         https://bugs.webkit.org/show_bug.cgi?id=84328
516
517         Reviewed by Kent Tamura.
518
519         WebUserMediaClientMock use an old requestUserMedia interface and
520         Replace it with the new interface.
521
522         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
523         (WebKit::WebUserMediaClientMock::requestUserMedia):
524         Remove the old requestUserMedia and replace it with the new.
525         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
526         (WebUserMediaClientMock):
527
528 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
529
530         [EFL] DRT console messages should contain only the file name part of local URIs
531         https://bugs.webkit.org/show_bug.cgi?id=84236
532
533         Reviewed by Kentaro Hara.
534
535         Process console messages before printing them in EFL's DumpRenderTree
536         them so that they contain only the file name part of local URIs. This
537         is what is expected by test cases.
538
539         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
540         (urlSuitableForTestResult):
541         (onConsoleMessage):
542
543 2012-04-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
544
545         [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
546         https://bugs.webkit.org/show_bug.cgi?id=84169
547
548         All databases were being created inside ~/.webkit which was causing
549         flaky tests when running multiple tests in parallel, specially timeouts
550         due to concurrency.
551
552         Reviewed by Eric Seidel.
553
554         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
555         (DumpRenderTreeChrome::initialize):
556
557 2012-04-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
558
559         [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
560         https://bugs.webkit.org/show_bug.cgi?id=82484
561
562         Reviewed by Martin Robinson.
563
564         Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
565
566         * efl/jhbuild.modules:
567         * gtk/jhbuild.modules:
568
569 2012-04-19  Lucas Forschler  <lforschler@apple.com>
570
571         Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
572         
573         * BuildSlaveSupport/build.webkit.org-config/config.json:
574
575 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
576
577         [EFL] dispatchDidCancelClientRedirect needs implementation
578         https://bugs.webkit.org/show_bug.cgi?id=83669
579
580         Reviewed by Antonio Gomes.
581
582         Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
583         and print out information that is expected by several test cases if
584         LayoutTestController's dumpFrameLoadCallback() returns true.
585
586         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
587         (DumpRenderTreeChrome::createView):
588         (DumpRenderTreeChrome::onFrameCreated):
589         (DumpRenderTreeChrome::onFrameRedirectCancelled):
590         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
591         (DumpRenderTreeChrome):
592
593 2012-04-18  Hironori Bono  <hbono@chromium.org>
594
595         Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
596         https://bugs.webkit.org/show_bug.cgi?id=83748
597
598         Reviewed by Ryosuke Niwa.
599
600         This change replaces a call for SpellChecker::didCheck() with one for
601         SpellChecker::didCheckCenceled() because didCheck() has been split into
602         didCheckSucceeded() and didCheckCanceled().
603
604         * DumpRenderTree/chromium/WebViewHost.cpp:
605         (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
606
607 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
608
609         Fix failure in test-webkitpy after r114583.
610
611         Unreviewed, build fix.
612
613         Updating the call site in r114583 w/o updating the test caused
614         the test to fail. Somehow I forgot to run the unit tests :(.
615
616         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
617         (ChromiumDriverTest.test_crash_log):
618
619 2012-04-18  Filip Pizlo  <fpizlo@apple.com>
620
621         JSC testing should have complete coverage over typed array types
622         https://bugs.webkit.org/show_bug.cgi?id=84302
623
624         Reviewed by Geoff Garen.
625         
626         Made run-fast-jsc print something and a newline if jsc threw an exception or
627         otherwise returned with an error code, but did not crash.
628
629         * Scripts/run-fast-jsc:
630
631 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
632
633         Fix crash in chromium.py after r114877.
634
635         Unreviewed, build fix.
636
637         Missed updating one call site for get_crash_log() :(.
638
639         * Scripts/webkitpy/layout_tests/port/chromium.py:
640         (ChromiumDriver.run_test):
641
642 2012-04-18  Philippe Normand  <pnormand@igalia.com>
643
644         [GTK] NRWT bails out if more than one X server runs on the machine
645         https://bugs.webkit.org/show_bug.cgi?id=84276
646
647         Reviewed by Dirk Pranke.
648
649         Set up GTK driver's Xvfb display number based on Xorg servers
650         currently running.
651
652         * Scripts/webkitpy/layout_tests/port/gtk.py:
653         (GtkDriver._start):
654         (GtkDriver._start.x_filter):
655
656 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
657
658         run-webkit-tests picked up an old crash log
659         https://bugs.webkit.org/show_bug.cgi?id=84196
660
661         Reviewed by Ryosuke Niwa.
662
663         Modify the crash log-finding code so that we can
664         limit our search to logs newer than X - this prevents
665         us from finding old crash logs for a given process/pid
666         combination even when the PIDs might've wrapped.
667  
668         Also fix a bug in filesystem_mock where files_under() would
669         return paths that didn't exist.
670
671         * Scripts/webkitpy/common/system/crashlogs.py:
672         (CrashLogs.find_newest_log):
673         (CrashLogs._find_newest_log_darwin):
674         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
675         (CrashLogsTest.test_find_log_darwin):
676         (CrashLogsTest.test_find_log_darwin.bad_read):
677         (CrashLogsTest):
678         * Scripts/webkitpy/common/system/filesystem_mock.py:
679         (MockFileSystem.files_under):
680         * Scripts/webkitpy/layout_tests/port/base.py:
681         (Port._get_crash_log):
682         * Scripts/webkitpy/layout_tests/port/gtk.py:
683         (GtkPort._get_crash_log):
684         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
685         * Scripts/webkitpy/layout_tests/port/mac.py:
686         (MacPort._get_crash_log):
687         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
688         (PortTestCase.test_get_crash_log):
689         * Scripts/webkitpy/layout_tests/port/webkit.py:
690         (WebKitDriver.run_test):
691
692 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
693
694         nrwt: support additional test expectations files
695         https://bugs.webkit.org/show_bug.cgi?id=84222
696
697         Reviewed by Ojan Vafai.
698
699         This patch adds an --additional-expectations flag that can be
700         used to point to more files that will override the default set
701         of expectations. This will allow us to remove the
702         'google_chrome' ports and eventually help to clean up override
703         handling in the chromium ports and unify expectations files and
704         Skipped files; this can also be used to specify overrides for
705         tests that run differently on a given machine.
706
707         * Scripts/webkitpy/layout_tests/port/base.py:
708         (Port.test_expectations_overrides):
709         * Scripts/webkitpy/layout_tests/port/chromium.py:
710         (ChromiumPort.test_expectations_overrides):
711         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
712         (parse_args):
713         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
714         (MainTest.test_additional_expectations):
715
716 2012-04-18  Jer Noble  <jer.noble@apple.com>
717
718         Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
719         https://bugs.webkit.org/show_bug.cgi?id=84177
720
721         Reviewed by Dirk Pranke.
722
723         Try to delete the pid file left by Apache in the case it was killed forcefully.
724
725         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
726         (LayoutTestApacheHttpd._stop_running_server):
727
728 2012-04-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
729
730         Clean-up WheelEvent Conversion.
731         https://bugs.webkit.org/show_bug.cgi?id=84243
732
733         Reviewed by Simon Hausmann.
734         
735         Calculate proper wheel-delta from pixel-delta given.
736
737         * DumpRenderTree/qt/EventSenderQt.cpp:
738         (EventSender::EventSender):
739         (EventSender::mouseScrollBy):
740         (EventSender::continuousMouseScrollBy):
741
742 2012-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
743
744         Unreviewed, rolling out r114506.
745         http://trac.webkit.org/changeset/114506
746         https://bugs.webkit.org/show_bug.cgi?id=84254
747
748         Seems to be making gtk's DumpRenderTree crash occasionally
749         (Requested by tomz on #webkit).
750
751         * DumpRenderTree/gtk/DumpRenderTree.cpp:
752         (resetDefaultsToConsistentValues):
753
754 2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
755
756         [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
757         https://bugs.webkit.org/show_bug.cgi?id=84229
758
759         CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
760         subsequent builds, stopping WebCore from being built ever again.
761
762         Instead of trying to emulate a build target using command line options,
763         just build the existing jsc target directly.
764
765         Reviewed by Rob Buis.
766
767         * Scripts/build-jsc:
768
769 2012-04-18  Simon Pena  <spena@igalia.com>
770
771         [GTK] r114021 triggered media flakyness
772         https://bugs.webkit.org/show_bug.cgi?id=83874
773
774         Reviewed by Philippe Normand.
775
776         Now that there is gtk API to update the
777         MediaPlaybackRequiresUserGesture property, set it to false from the
778         DumpRenderTree tool when resetting defaults to consistent values.
779
780         * DumpRenderTree/gtk/DumpRenderTree.cpp:
781         (resetDefaultsToConsistentValues):
782
783 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
784
785         Web Inspector: Disabling Inspector causes build failure on Windows
786         https://bugs.webkit.org/show_bug.cgi?id=83557
787
788         Reviewed by Pavel Feldman.
789
790         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
791         This change brings all such API calls under the guard.
792
793         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
794         (WTR::LayoutTestController::showWebInspector):
795         (WTR::LayoutTestController::closeWebInspector):
796         (WTR::LayoutTestController::evaluateInWebInspector):
797         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
798         * WebKitTestRunner/TestInvocation.cpp:
799         (WTR::TestInvocation::invoke):
800
801 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
802
803         [GTK] atk/textChangedNotifications API test fails
804         https://bugs.webkit.org/show_bug.cgi?id=84010
805
806         Unreviewed, unskipping test after bug being fixed by r114311.
807
808         * Scripts/run-gtk-tests:
809         (TestRunner): Unskip now passing test.
810
811 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
812
813         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
814         https://bugs.webkit.org/show_bug.cgi?id=84199
815
816         Reviewed by George Staikos.
817
818         Revert a part of the change master_32/SHA:fa0f8ee9 and use
819         WebPage::setUserScalable instead.
820
821         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
822         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
823
824 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
825
826         build-webkit: make ninja work with chromium linux
827         https://bugs.webkit.org/show_bug.cgi?id=84213
828
829         Reviewed by Eric Seidel.
830
831         Fix typos so that build-webkit will use ninja to
832         build chromium if a build.ninja file exists and is up-to-date.
833
834         * Scripts/webkitdirs.pm:
835         (determineIsChromiumNinja):
836
837 2012-04-17  Ojan Vafai  <ojan@chromium.org>
838
839         Add caching to the flakiness dashboard json files
840         https://bugs.webkit.org/show_bug.cgi?id=84198
841
842         Reviewed by Dirk Pranke.
843
844         * TestResultServer/handlers/testfilehandler.py:
845         (GetFile._get_file_list):
846         (GetFile._get_file_content):
847         (GetFile._get_file_content_from_key):
848         (GetFile._get_test_list_json):
849         (GetFile._serve_json):
850         Add a Last-Modified header and handle If-Modified-Since headers.
851         (GetFile.get):
852
853 2012-04-17  Anders Carlsson  <andersca@apple.com>
854
855         Need a client callback for when the user tries to interact with an already unresponsive page
856         https://bugs.webkit.org/show_bug.cgi?id=84201
857         <rdar://problem/11140862>
858
859         Reviewed by Andreas Kling.
860
861         Add new client functions.
862
863         * MiniBrowser/mac/BrowserWindowController.m:
864         (-[BrowserWindowController awakeFromNib]):
865         * WebKitTestRunner/TestController.cpp:
866         (WTR::TestController::initialize):
867
868 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
869
870         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
871         https://bugs.webkit.org/show_bug.cgi?id=84190
872
873         Reviewed by Ojan Vafai.
874
875         LayoutTestHelper would exit when the user typed ctrl-c, but we
876         would attempt to write to it to shut it down, generating an
877         IOError.
878
879         * Scripts/webkitpy/layout_tests/port/chromium.py:
880         (ChromiumPort.stop_helper):
881
882 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
883
884         rename --experimental-fully-parallel
885         https://bugs.webkit.org/show_bug.cgi?id=84188
886
887         Reviewed by Ojan Vafai.
888
889         I thought this was done long ago; rename
890         --experimental-fully-parallel to just --fully-parallel and
891         remove the --no- switch that AFAIK no one uses.
892
893         * Scripts/webkitpy/layout_tests/controllers/manager.py:
894         (Manager._run_tests):
895         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
896         (parse_args):
897
898 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
899
900         EFL's LayoutTestController does not implement callShouldCloseOnWebView
901         https://bugs.webkit.org/show_bug.cgi?id=82301
902
903         Reviewed by Martin Robinson.
904
905         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
906         calling shouldClose() on the FrameLoader, allowing the related test
907         to be removed from the skip list.
908
909         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
910         (LayoutTestController::callShouldCloseOnWebView):
911
912 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
913
914         [EFL] Add setting API to enable/disable XSSAuditor
915         https://bugs.webkit.org/show_bug.cgi?id=83281
916
917         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
918         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
919         'xss,detected' in DRT to enable a test, which is expecting a line containing
920         'didDetectXSS' in the output when reflected XSS is encountered in the page.
921
922         Reviewed by Antonio Gomes.
923
924         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
925         (DumpRenderTreeChrome::createView):
926         (DumpRenderTreeChrome::onFrameCreated):
927         (DumpRenderTreeChrome::onDidDetectXSS):
928         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
929         (DumpRenderTreeChrome):
930         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
931         (LayoutTestController::setXSSAuditorEnabled):
932
933 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
934
935         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
936         https://bugs.webkit.org/show_bug.cgi?id=77533
937
938         Reviewed by Simon Hausmann.
939
940         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
941         the corresponding parameter to the buildQMakeProjects function.
942
943         * Scripts/build-jsc:
944
945 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
946
947         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
948         https://bugs.webkit.org/show_bug.cgi?id=83030
949
950         Reviewed by Antonio Gomes.
951
952         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
953         in EFL's DumpRenderTree. Make use of the new frame argument passed to
954         the "load,started" and "load,finished" signals.
955
956         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
957         (DumpRenderTreeChrome::createView):
958         (DumpRenderTreeChrome::onLoadStarted):
959         (DumpRenderTreeChrome::processWork):
960         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
961         (DumpRenderTreeChrome::onWebViewOnloadEvent):
962         (DumpRenderTreeChrome::onInsecureContentRun):
963         (DumpRenderTreeChrome::onInsecureContentDisplayed):
964         (DumpRenderTreeChrome::onFrameCreated):
965         (DumpRenderTreeChrome::onFrameProvisionalLoad):
966         (DumpRenderTreeChrome::onFrameLoadCommitted):
967         (DumpRenderTreeChrome::onFrameLoadFinished):
968         (DumpRenderTreeChrome::onFrameLoadError):
969         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
970         (DumpRenderTreeChrome):
971
972 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
973
974         Unreviewed, rolling out r114376.
975         http://trac.webkit.org/changeset/114376
976         https://bugs.webkit.org/show_bug.cgi?id=84155
977
978         Wrong patch version committed, asked by the patch author.
979         (Requested by rakuco on #webkit).
980
981         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
982         (DumpRenderTreeChrome::createView):
983         (DumpRenderTreeChrome::processWork):
984         (DumpRenderTreeChrome::onLoadFinished):
985         (DumpRenderTreeChrome::onWillSendRequest):
986         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
987         (DumpRenderTreeChrome):
988
989 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
990
991         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
992         https://bugs.webkit.org/show_bug.cgi?id=83030
993
994         Reviewed by Antonio Gomes.
995
996         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
997         in EFL's DumpRenderTree.
998
999         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1000         (DumpRenderTreeChrome::createView):
1001         (DumpRenderTreeChrome::processWork):
1002         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
1003         (DumpRenderTreeChrome::onWebViewOnloadEvent):
1004         (DumpRenderTreeChrome::onInsecureContentRun):
1005         (DumpRenderTreeChrome::onInsecureContentDisplayed):
1006         (DumpRenderTreeChrome::onFrameCreated):
1007         (DumpRenderTreeChrome::onFrameProvisionalLoad):
1008         (DumpRenderTreeChrome::onFrameLoadCommitted):
1009         (DumpRenderTreeChrome::onFrameLoadFinished):
1010         (DumpRenderTreeChrome::onFrameLoadError):
1011         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1012         (DumpRenderTreeChrome):
1013
1014 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
1015
1016         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
1017         https://bugs.webkit.org/show_bug.cgi?id=83035
1018
1019         Reviewed by Simon Hausmann.
1020
1021         The force_static_libs_as_shared feature for the Qt port will remove
1022         hide_symbols from Qt's CONFIG in order to make them visible to other
1023         libraries again.
1024
1025         Due to an evaluation order problem in qmake, the flags for the C++ compiler
1026         that are set by adding hide_symbols to the CONFIG variables get applied
1027         to qmake's C++ compiler flags directly and hence trying to remove these
1028         later will not work and cause build failures when using the force_static_libs_as_shared
1029         feature of the Qt port.
1030
1031         This is fixed by removing the flags that hide the exports from the compiler flags directly.
1032
1033         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
1034
1035 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
1036
1037         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
1038         https://bugs.webkit.org/show_bug.cgi?id=84068
1039
1040         Reviewed by Eric Seidel.
1041
1042         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
1043         automatically creates the build directory if needed.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1046         (DownloadAndPerfTestFactory.__init__):
1047         (DownloadAndPerfTestWebKit2Factory.__init__):
1048
1049 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1050
1051         [GTK] Use configure instead of autogen.sh for gtk+
1052         https://bugs.webkit.org/show_bug.cgi?id=84112
1053
1054         Rubber-stamped by Martin Robinson.
1055
1056         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
1057         we don't want to depend on that for now, so run configure instead - we
1058         can, since we are using a tarball
1059
1060 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1061
1062         Unreviewed, rolling out r114322.
1063         http://trac.webkit.org/changeset/114322
1064         https://bugs.webkit.org/show_bug.cgi?id=84096
1065
1066         Didn't make the debug bot happy, so back out
1067
1068         * gtk/jhbuild.modules:
1069
1070 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1071
1072         [GTK] Try to fix debug bot by adding gobject-introspection to the build
1073         https://bugs.webkit.org/show_bug.cgi?id=84096
1074
1075         Unreviewed speculative build fix.
1076
1077         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
1078         an up-to-date introspection m4 for running autogen.
1079
1080 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1081
1082         [GTK] Add pango to jhbuild
1083         https://bugs.webkit.org/show_bug.cgi?id=84086
1084
1085         Unreviewed build fix.
1086
1087         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
1088         jhbuild environment. It's required for latest stable GTK+ and some
1089         systems may lack it.
1090
1091 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1092
1093         [GTK] fonts jhbuild module needs an empty clean target
1094         https://bugs.webkit.org/show_bug.cgi?id=84085
1095
1096         Rubber-stamped by Martin Robinson.
1097
1098         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
1099         includes a phony clean target that should make warnings and errors go
1100         away.
1101
1102 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
1103
1104         [GTK] Bump dependency on GTK+ 3.x to match reality
1105         https://bugs.webkit.org/show_bug.cgi?id=84060
1106
1107         Rubber-stamped by Martin Robinson.
1108
1109         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
1110         to their GNOME 3.4 versions.
1111         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
1112         is applied upstream.
1113
1114 2012-04-16  Vincent Scheib  <scheib@chromium.org>
1115
1116         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
1117
1118         Unreviewed.
1119
1120         * Scripts/webkitpy/common/config/committers.py:
1121
1122 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1123
1124         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
1125         https://bugs.webkit.org/show_bug.cgi?id=84031
1126
1127         Reviewed by Rob Buis.
1128
1129         Implemented interface function didReceiveAuthenticationChallenge in class
1130         DumpRenderTree.
1131
1132         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1133         (drtCredentialDescription):
1134         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
1135         (WebKit):
1136         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1137         (WebCore):
1138         (DumpRenderTree):
1139
1140 2012-04-16  Philippe Normand  <pnormand@igalia.com>
1141
1142         build-webkit --gtk --no-webkit2 builds WK2
1143         https://bugs.webkit.org/show_bug.cgi?id=83977
1144
1145         Reviewed by Martin Robinson.
1146
1147         * Scripts/build-webkit: Fixup ./configure option to disable
1148         WebKit2 build.
1149
1150 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1151
1152         [EFL] [DRT] Feeding key events with invalid keyName
1153         https://bugs.webkit.org/show_bug.cgi?id=83797
1154
1155         Keep the keyName valid within scope of KeyEventInfo to avoid
1156         feeding key events with invalid keyName.
1157
1158         Reviewed by Philippe Normand.
1159
1160         * DumpRenderTree/efl/EventSender.cpp:
1161         (KeyEventInfo::KeyEventInfo):
1162         (KeyEventInfo):
1163         (keyPadNameFromJSValue):
1164         (keyNameFromJSValue):
1165         (createKeyEventInfo):
1166         (sendKeyDown):
1167
1168 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
1169
1170         [Qt] Replace QtXmlPatterns usage with libxslt dependency
1171         <https://bugs.webkit.org/show_bug.cgi?id=76820>
1172
1173         Reviewed by Simon Hausmann.
1174
1175         The features.prf file was modified, in order to use libxml and libxslt by default.
1176         This modification only work at Qt5.
1177
1178         * qmake/config.tests/libxml2/libxml2.cpp: Added.
1179         (main):
1180         * qmake/config.tests/libxml2/libxml2.pro: Added.
1181         * qmake/config.tests/libxslt/libxslt.cpp: Added.
1182         (main):
1183         * qmake/config.tests/libxslt/libxslt.pro: Added.
1184         * qmake/mkspecs/features/features.prf:
1185         * qmake/sync.profile:
1186
1187 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
1188
1189         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
1190         https://bugs.webkit.org/show_bug.cgi?id=83862
1191
1192         Reviewed by Kenneth Rohde Christiansen.
1193
1194         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
1195         It doesn't work properly because of wrong parameter order in function call.
1196
1197         * EWebLauncher/main.c:
1198
1199 2012-04-16  Philippe Normand  <pnormand@igalia.com>
1200
1201         Unreviewed, GTK gardening.
1202
1203         * Scripts/run-gtk-tests:
1204         (TestRunner): Skip /webkit/atk/textChangedNotifications.
1205
1206 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1207
1208         Chromium perf bots should not build
1209         https://bugs.webkit.org/show_bug.cgi?id=83641
1210
1211         Reviewed by Eric Seidel.
1212
1213         Don't build on perf bots to improve the cycle time.
1214
1215         * BuildSlaveSupport/build.webkit.org-config/config.json:
1216
1217 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
1218
1219         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
1220         https://bugs.webkit.org/show_bug.cgi?id=81945
1221
1222         Reviewed by Dan Bernstein.
1223
1224         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
1225         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
1226         PageCache to be functional.
1227
1228         * WebKitTestRunner/TestController.cpp:
1229         (WTR::TestController::resetStateToConsistentValues):
1230
1231 2012-04-11  James Robinson  <jamesr@chromium.org>
1232
1233         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
1234         https://bugs.webkit.org/show_bug.cgi?id=83733
1235
1236         Reviewed by Adrienne Walker.
1237
1238         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
1239
1240         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1241         (main):
1242         * DumpRenderTree/chromium/TestShell.cpp:
1243         (TestShell::TestShell):
1244         (TestShell::resetWebSettings):
1245         * DumpRenderTree/chromium/TestShell.h:
1246         (TestShell):
1247         * DumpRenderTree/chromium/WebPreferences.cpp:
1248         (WebPreferences::reset):
1249         (WebPreferences::applyTo):
1250         * DumpRenderTree/chromium/WebPreferences.h:
1251         (WebPreferences):
1252
1253 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
1254
1255         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
1256         and also rebaseline the test results since we ignore the first run now.
1257
1258         * Scripts/webkitpy/performance_tests/perftest.py:
1259         (PageLoadingPerfTest.run):
1260         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1261         (TestPageLoadingPerfTest.test_run):
1262
1263 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1264
1265         Enable SVG page loading performance tests
1266         https://bugs.webkit.org/show_bug.cgi?id=83861
1267
1268         Reviewed by Adam Barth.
1269
1270         Add support for page loading tests. These are tests without any test running harnesses, and we use
1271         DriverOutput's test_timeout to measure the loading time.
1272
1273         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
1274
1275         * Scripts/webkitpy/performance_tests/perftest.py:
1276         (PerfTest.run):
1277         (PerfTest):
1278         (PerfTest.run_failed):
1279         (PerfTest.parse_output):
1280         (PerfTest.output_statistics):
1281         (ChromiumStylePerfTest.parse_output):
1282         (PageLoadingPerfTest): Added.
1283         (PageLoadingPerfTest.__init__):
1284         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
1285         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
1286         (MockPrinter):
1287         (MockPrinter.__init__):
1288         (MockPrinter.write):
1289         (MainTest):
1290         (MainTest.test_parse_output):
1291         (MainTest.test_parse_output_with_failing_line):
1292         (TestPageLoadingPerfTest):
1293         (TestPageLoadingPerfTest.assertWritten):
1294         (TestPageLoadingPerfTest.MockDriver):
1295         (TestPageLoadingPerfTest.MockDriver.__init__):
1296         (TestPageLoadingPerfTest.MockDriver.run_test):
1297         (TestPageLoadingPerfTest.test_run):
1298         (TestPageLoadingPerfTest.test_run_with_bad_output):
1299         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1300         (PerfTestsRunner):
1301         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
1302         (PerfTestsRunner._collect_tests):
1303         (PerfTestsRunner._run_tests_set):
1304         (PerfTestsRunner._run_single_test):
1305         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1306         (test_collect_tests_with_page_load_svg):
1307         (test_collect_tests_with_page_load_svg.add_file):
1308
1309 2012-04-10  Brady Eidson  <beidson@apple.com>
1310
1311         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
1312         Need WebKit2 API to notify whether history loads are in the page cache
1313
1314         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
1315         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
1316
1317         Reviewed by Darin Adler.
1318
1319         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
1320         (TestWebKitAPI::didFinishLoadForFrame):
1321         (TestWebKitAPI::willGoToBackForwardListItem):
1322         (TestWebKitAPI::setPageLoaderClient):
1323         (TestWebKitAPI::TEST):
1324         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
1325         (ShouldGoToBackForwardListItemTest):
1326         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
1327         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
1328         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
1329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1330
1331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1332         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
1333
1334 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1335
1336         Group EFL bots into a category on the buildbot master
1337         https://bugs.webkit.org/show_bug.cgi?id=82712
1338
1339         Reviewed by Adam Roben.
1340
1341         Creating a new category definition on the buildbot frontend.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1344         (loadBuilderConfig): Determine category for EFL bots
1345         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
1346
1347 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1348
1349         Unreviewed, rolling out r113714.
1350         http://trac.webkit.org/changeset/113714
1351         https://bugs.webkit.org/show_bug.cgi?id=83887
1352
1353         It is behaving strange on the bots and needs more
1354         investigation. (Requested by jeez_ on #webkit).
1355
1356         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1357         (WTR::PlatformWebView::PlatformWebView):
1358
1359 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1360
1361         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
1362         https://bugs.webkit.org/show_bug.cgi?id=83690
1363
1364         Reviewed by Tor Arne Vestbø.
1365
1366         Typing part of an email and pressing <TAB> will bash-complete it using the list in
1367         Tools/Scripts/webkitpy/common/config/committers.py
1368
1369         * Scripts/webkit-tools-completion.sh:
1370
1371 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1372
1373         [EFL] Add API for color chooser
1374         https://bugs.webkit.org/show_bug.cgi?id=83692
1375
1376         Enables INPUT_TYPE_COLOR by default on the EFL port.
1377
1378         Reviewed by Kenneth Rohde Christiansen.
1379
1380         * Scripts/build-webkit:
1381
1382 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1383
1384         Extract PerfTest class from PerfTestRunner
1385         https://bugs.webkit.org/show_bug.cgi?id=83847
1386
1387         Reviewed by Hajime Morita.
1388
1389         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
1390         that was previously represented by a tuple.
1391
1392         Also moved the logic to determine whether a given test is chromium style or not from run() to
1393         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
1394         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
1395         add new types of tests more easily.
1396
1397         * Scripts/webkitpy/performance_tests/perftest.py: Added.
1398         (PerfTest):
1399         (PerfTest.__init__):
1400         (PerfTest.test_name):
1401         (PerfTest.dirname):
1402         (PerfTest.path_or_url):
1403         (PerfTest._should_ignore_line_in_parser_test_result):
1404         (PerfTest.parse_output):
1405         (ChromiumStylePerfTest):
1406         (ChromiumStylePerfTest.__init__):
1407         (ChromiumStylePerfTest.parse_output):
1408         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1409         (PerfTestsRunner._collect_tests):
1410         (PerfTestsRunner.run):
1411         (PerfTestsRunner._run_tests_set):
1412         (PerfTestsRunner._run_single_test):
1413         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1414         (run_test):
1415         (_tests_for_runner):
1416         (test_run_test_set_with_json_output):
1417         (test_run_test_set_with_json_source):
1418         (test_run_test_set_with_multiple_repositories):
1419         (_collect_tests_and_sort_test_name):
1420         (test_collect_tests):
1421         (test_collect_tests_with_skipped_list):
1422
1423 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
1424
1425         [Qt] Fix WebKit1 build with V8
1426         https://bugs.webkit.org/show_bug.cgi?id=83322
1427
1428         Reviewed by Adam Barth.
1429
1430         * DumpRenderTree/qt/DumpRenderTree.pro:
1431         * qmake/mkspecs/features/default_post.prf:
1432         * qmake/mkspecs/features/default_pre.prf:
1433         * qmake/mkspecs/features/features.prf:
1434
1435 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
1436
1437         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
1438         https://bugs.webkit.org/show_bug.cgi?id=83583
1439
1440         Reviewed by Philippe Normand
1441
1442         Updated the unit test to ignore the hours and minutes of the
1443         localtime for time(0), since we can't easily guarantee which
1444         timezone we're in or what timezone rules were in effect on
1445         1/1/1970; this should be mostly fine since we can trust that
1446         time.localtime() will work, although there is the possibility
1447         that we'll screw up the time formatting of which field is the
1448         hours and which is the minutes.
1449
1450         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1451         (VerboseTest):
1452         (VerboseTest.test_basic):
1453         (VerboseTest.test_log_after_update):
1454
1455 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
1456
1457         Add an EFL Debug Buildbot to the master configuration
1458         https://bugs.webkit.org/show_bug.cgi?id=82711
1459
1460         Forgot to add EFL Linux Debug to scheduler.
1461
1462         Reviewed by Philippe Normand.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/config.json:
1465
1466 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
1467
1468         Add an EFL Debug Buildbot to the master configuration
1469         https://bugs.webkit.org/show_bug.cgi?id=82711
1470
1471         Reviewed by Philippe Normand.
1472
1473         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
1474
1475         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
1476
1477 2012-04-12  George Staikos  <staikos@webkit.org>
1478
1479         Enable the fullscreen API for BlackBerry.
1480         https://bugs.webkit.org/show_bug.cgi?id=83757
1481
1482         Reviewed by Antonio Gomes.
1483
1484         * Scripts/build-webkit:
1485
1486 2012-04-12  Simon Pena  <spena@igalia.com>
1487
1488         [GTK] Test runner crashes without recent versions of pulseaudio-utils
1489         https://bugs.webkit.org/show_bug.cgi?id=83774
1490
1491         Reviewed by Philippe Normand.
1492
1493         Besides checking that pactl is available, check also that its output
1494         is the expected one, and handle gracefully when it isn't, when
1495         trying to unload pulseaudio modules.
1496
1497         * Scripts/webkitpy/layout_tests/port/gtk.py:
1498         (GtkPort._unload_pulseaudio_module):
1499         (GtkPort._restore_pulseaudio_module):
1500
1501 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
1502
1503         [Qt] Use QRawFont when building with Qt 5
1504         https://bugs.webkit.org/show_bug.cgi?id=78001
1505
1506         Flip the QRawFont switch for Qt 5.
1507
1508         Reviewed by Simon Hausmann.
1509
1510         * qmake/mkspecs/features/features.prf:
1511
1512 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
1513
1514         Web Inspector: Disabling Inspector causes build failure on Windows
1515         https://bugs.webkit.org/show_bug.cgi?id=83557
1516
1517         Reviewed by Pavel Feldman.
1518
1519         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1520         This change brings all such API calls under the guard.
1521
1522         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1523         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1524         (WTR):
1525         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1526         (LayoutTestController):
1527         * WebKitTestRunner/TestInvocation.cpp:
1528         (WTR::TestInvocation::invoke):
1529
1530 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
1531
1532         Fix regression introduced in r113927.
1533
1534         Unreviewed, build fix.
1535
1536         I failed to rename skipped_tests() to skipped_layout_tests()
1537         everywhere it needed to be renamed. The unit tests didn't catch
1538         this because the TestPort was one of the places that didn't get
1539         renamed :(.
1540
1541         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1542         (Manager.parse_expectations):
1543         * Scripts/webkitpy/layout_tests/port/test.py:
1544         (TestPort.skipped_layout_tests):
1545         * Scripts/webkitpy/tool/commands/queries.py:
1546         (PrintExpectations._model):
1547
1548 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
1549
1550         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
1551         https://bugs.webkit.org/show_bug.cgi?id=47528
1552
1553         Reviewed by Adam Barth.
1554
1555         The skipped-ports command has been replaced by 'webkit-patch
1556         print-expectations', which offers the equivalent functionality
1557         via 'webkit-patch print-expectations --platform \* -t skip'
1558         (and other features, of course).
1559         
1560         This also allows me to fix a nasty layering violation where the
1561         chromium port had to know about the TestExpectations objects in
1562         order to implement the command properly.
1563
1564         Lastly, this allows me to rename skipped_tests() to
1565         skipped_layout_tests() to more consistent with
1566         skipped_perf_tests().
1567         
1568         This patch removes skips_layout_test() from the Port interface,
1569         because that can't be implemented without the port knowing about
1570         Expectations objects (and skipped-ports was the only thing using it).
1571
1572         * Scripts/webkitpy/layout_tests/port/base.py:
1573         (Port.skipped_layout_tests):
1574         (Port.skipped_perf_tests):
1575         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1576         (PortTest.test_default_configuration_notfound):
1577         * Scripts/webkitpy/layout_tests/port/chromium.py:
1578         (ChromiumPort.test_expectations_overrides):
1579         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1580         (ChromiumPortTest.test_path_to_image_diff):
1581         * Scripts/webkitpy/layout_tests/port/webkit.py:
1582         (WebKitPort.skipped_layout_tests):
1583         * Scripts/webkitpy/tool/commands/queries.py:
1584         (execute):
1585         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1586         (QueryCommandsTest.test_tree_status):
1587
1588 2012-04-11  Mark Rowe  <mrowe@apple.com>
1589
1590         Remove a fprintf from LayoutTestController.
1591
1592         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
1593         It was added for no apparent reason by Ryosuke in r113651.
1594
1595         * DumpRenderTree/LayoutTestController.cpp:
1596         (LayoutTestController::redirectionDestinationForURL):
1597
1598 2012-04-11  Nico Weber  <thakis@chromium.org>
1599
1600         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
1601         https://bugs.webkit.org/show_bug.cgi?id=83709
1602
1603         Reviewed by Anders Carlsson.
1604
1605         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1606         (handleEventCarbon):
1607
1608 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
1609
1610         Adding myself to committers.py
1611         https://bugs.webkit.org/show_bug.cgi?id=83711
1612
1613         Unreviewed update to committers.py.
1614
1615         * Scripts/webkitpy/common/config/committers.py:
1616
1617 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1618
1619         [EFL] LayoutTestController needs implementation of pageProperty
1620         https://bugs.webkit.org/show_bug.cgi?id=82449
1621
1622         Add missing implementation pageProperty to EFL's LayoutTestController
1623         in order to unskip printing/page-rule-selection.html
1624
1625         Reviewed by Antonio Gomes.
1626
1627         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1628         (LayoutTestController::pageProperty):
1629
1630 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1631
1632         Unreviewed, rolling out r113836.
1633         http://trac.webkit.org/changeset/113836
1634         https://bugs.webkit.org/show_bug.cgi?id=83705
1635
1636         Broke all the WebKit2 inspector tests (Requested by andersca
1637         on #webkit).
1638
1639         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1640         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1641         (WTR::LayoutTestController::showWebInspector):
1642         (WTR::LayoutTestController::closeWebInspector):
1643         (WTR::LayoutTestController::evaluateInWebInspector):
1644         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
1645         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1646         (LayoutTestController):
1647         * WebKitTestRunner/TestInvocation.cpp:
1648         (WTR::TestInvocation::invoke):
1649
1650 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
1651
1652         Web Inspector: Disabling Inspector causes build failure on Windows
1653         https://bugs.webkit.org/show_bug.cgi?id=83557
1654
1655         Reviewed by Pavel Feldman.
1656
1657         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1658         This change brings all such API calls under the guard.
1659
1660         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1661         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1662         (WTR):
1663         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1664         (LayoutTestController):
1665         * WebKitTestRunner/TestInvocation.cpp:
1666         (WTR::TestInvocation::invoke):
1667
1668 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
1669
1670         [Qt][WK2] Manage graphics buffers in the web process
1671         https://bugs.webkit.org/show_bug.cgi?id=78675
1672  
1673         Make graphics surface available only for Qt 5, attempting to fix
1674         the Qt-mac build.
1675
1676         Unreviewed build fix.
1677
1678         * qmake/mkspecs/features/features.prf:
1679
1680 2012-04-11  Philippe Normand  <pnormand@igalia.com>
1681
1682         Unreviewed, GTK NRWT follow-up fix after r113849.
1683
1684         * Scripts/webkitpy/layout_tests/port/gtk.py:
1685         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
1686
1687 2012-04-11  Simon Pena  <spena@igalia.com>
1688
1689         [GTK] media/event-attributes.html fails
1690         https://bugs.webkit.org/show_bug.cgi?id=71662
1691
1692         Reviewed by Philippe Normand.
1693
1694         PulseAudio's module "module-stream-restore" allows saving the volume
1695         of a stream, restoring it the next time it runs.
1696         This affects the tests, since DumpRenderTree's volume settings are
1697         saved between test runs, and tests relying on specific volume values
1698         would miss some volumeChange events (or get additional ones).
1699
1700         This patch hooks on the existing GtkPort setup_test_run method and
1701         creates a new clean_up_test_run method, so PulseAudio's module is
1702         unloaded (if found) before running the tests, and restored (if it
1703         was there previously) after they finished, ensuring the tests run in
1704         the right environment.
1705
1706         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1707         (Manager._clean_up_run): Invoke the port implementation of
1708         clean_up_test_run.
1709         * Scripts/webkitpy/layout_tests/port/base.py:
1710         (Port.clean_up_test_run): Add an empty implementation of
1711         clean_up_test_run.
1712         * Scripts/webkitpy/layout_tests/port/gtk.py:
1713         (GtkPort._unload_pulseaudio_module): Unloads the offending
1714         pulseaudio module, if found.
1715         (GtkPort):
1716         (GtkPort._restore_pulseaudio_module): Restores the offending
1717         pulseaudio module, if it was there previously.
1718         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
1719         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
1720
1721 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
1722
1723         Fix the build with gcc 4.7.0
1724         https://bugs.webkit.org/show_bug.cgi?id=83584
1725
1726         Reviewed by Alexey Proskuryakov.
1727
1728         * qmake/mkspecs/features/unix/default_post.prf:
1729         The -fuse-ld=gold option is not supported with upstream gcc.
1730
1731 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
1732
1733         Refactor PerfTestRunner to include file extensions in test names
1734         https://bugs.webkit.org/show_bug.cgi?id=83677
1735
1736         Reviewed by Hajime Morita.
1737
1738         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
1739
1740         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1741         (PerfTestsRunner._collect_tests):
1742         (PerfTestsRunner._run_tests_set):
1743         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
1744         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
1745         (PerfTestsRunner._run_single_test):
1746         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1747         (run_test):
1748         (_tests_for_runner):
1749         (test_run_test_set):
1750         (test_run_test_set_kills_drt_per_run):
1751         (test_run_test_pause_before_testing):
1752         (test_run_test_set_for_parser_tests):
1753         (test_collect_tests):
1754         (test_collect_tests_with_skipped_list):
1755
1756 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
1757
1758         Web Inspector: Disabling Inspector causes build failure on Windows
1759         https://bugs.webkit.org/show_bug.cgi?id=83557
1760
1761         Reviewed by Pavel Feldman.
1762
1763         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
1764         This change brings all such API calls under the guard.
1765
1766         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1767         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1768         (WTR):
1769         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1770         (LayoutTestController):
1771         * WebKitTestRunner/TestInvocation.cpp:
1772         (WTR::TestInvocation::invoke):
1773
1774 2012-04-10  Kent Tamura  <tkent@chromium.org>
1775
1776         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
1777
1778         * Scripts/webkitpy/common/config/watchlist:
1779         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
1780
1781 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1782
1783         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
1784         https://bugs.webkit.org/show_bug.cgi?id=82799
1785
1786         Reviewed by Ojan Vafai.
1787
1788         The tests we were skipping in _mark_interrupted_tests_as_skipped
1789         had incorrectly-constructed TestResults, and so they were not
1790         being treated as failures. The JSON generator doesn't record
1791         tests that are passed or skiped in incremental_results, so you
1792         couldn't tell these tests were being skipped at all.
1793
1794         This change changes _mark_interrupted_tests_as_skipped() to
1795         treat the skipped tests as failures; this is arguably still
1796         incorrect but is minimally invasive for now. We probably need to
1797         revisit how we are uploading information about tests that are
1798         skipped and passed altogether in a separate change.
1799
1800         This change also cleans up a couple of other nits that were
1801         unnecessary or broken in this same code path.
1802
1803         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1804         (Manager._mark_interrupted_tests_as_skipped):
1805         (Manager._upload_json_files): Deletes the check for
1806         chromium-mac-leopard (as it is no longer necessary).
1807         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1808         (JSONLayoutResultsGenerator.__init__): Here we were
1809         recalculating the failure type unnecessarily.
1810         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1811         (determine_result_type):
1812         (FailureEarlyExit): Adds a new failure type so we can tell what
1813         happened.
1814         (FailureEarlyExit.message):
1815         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1816         (MainTest.test_exit_after_n_failures_upload): Add more checks to
1817         ensure that we are recording the SKIP correctly; this is less
1818         than ideal, because we can't actually test the contents of
1819         incremental_results.json. We should fix that at some point.
1820
1821 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1822
1823         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
1824         https://bugs.webkit.org/show_bug.cgi?id=83401
1825
1826         Reviewed by Adam Barth.
1827
1828         Last patch in the series - no longer look in mac-leopard,
1829         mac-snowleopard, or mac-lion.
1830
1831         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1832         (ChromiumMacPort):
1833         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1834
1835 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1836
1837         webkit-patch: add a print-expectations command
1838         https://bugs.webkit.org/show_bug.cgi?id=83347
1839
1840         Reviewed by Adam Barth.
1841
1842         This command will print the expected results for a given set of
1843         tests on a given set of ports matching a given set of keywords.
1844
1845         Example output (printing all the tests not expected to pass, and their
1846         expected results, on a Mac):
1847
1848         $ webkit-patch print-expectations -x pass fast/html
1849         // For mac-snowleopard
1850         fast/html/details-open4.html = TEXT
1851         fast/html/details-open2.html = TEXT
1852         fast/html/details-no-summary4.html = TEXT
1853         fast/html/details-open-javascript.html = TEXT
1854         $
1855
1856         You can also print full test-expectatons.txt lines using --full and a
1857         CSV-style report (which can be useful for post-processing) using --csv.
1858
1859         It will replace the 'skipped-files' command (which will be
1860         removed in a subsequent patch) and is a more general (and
1861         cleaner and properly layered) solution.
1862
1863         Also add an update() command to MockOptions() to make overriding keywords easier.
1864
1865         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1866         (TestExpectationSerializer.to_string):
1867         (TestExpectationSerializer):
1868         (TestExpectationSerializer.to_csv):
1869         (TestExpectationSerializer._format_result):
1870         (TestExpectationLine.create_passing_expectation):
1871         (TestExpectationsModel.get_test_set_for_keyword):
1872         (TestExpectationsModel.has_keyword):
1873         (TestExpectations.model):
1874         * Scripts/webkitpy/tool/commands/queries.py:
1875         (execute):
1876         (PrintExpectations):
1877         (PrintExpectations.__init__):
1878         (PrintExpectations.execute):
1879         (PrintExpectations._filter_tests):
1880         (PrintExpectations._format_lines):
1881         (PrintExpectations._model):
1882         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1883         (TestPrintExpectations): Added.
1884         * Scripts/webkitpy/tool/mocktool.py:
1885         (MockOptions):
1886         (MockOptions.__init__):
1887         (MockOptions.update): Added.
1888
1889 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1890
1891         webkitpy: refactor handling of --platform and related options
1892         https://bugs.webkit.org/show_bug.cgi?id=83525
1893
1894         Reviewed by Adam Barth.
1895
1896         This change moves to centralize handling of --platform, --debug,
1897         --gtk, and other similar flags into a central place next to the
1898         code that actually uses those flags in PortFactory to get the
1899         right Port object.
1900
1901         * Scripts/webkitpy/layout_tests/port/__init__.py:
1902         * Scripts/webkitpy/layout_tests/port/factory.py:
1903         (port_options):
1904         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1905         (parse_args):
1906         * Scripts/webkitpy/tool/commands/queries.py:
1907         (PrintBaselines.__init__):
1908
1909 2012-04-10  Ojan Vafai  <ojan@chromium.org>
1910
1911         Add a chromeless view to the individual tests view
1912         https://bugs.webkit.org/show_bug.cgi?id=83541
1913
1914         Reviewed by Daniel Bates.
1915
1916         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
1917
1918         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1919         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1920         (testHtmlForIndividualTestOnAllBuilders):
1921         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
1922         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1923         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1924         (testHtmlForIndividualTests):
1925         (htmlEscape):
1926         (runTests):
1927
1928 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1929
1930         remove 'win' from chromium-win, chromium-linux fallback paths
1931         https://bugs.webkit.org/show_bug.cgi?id=83613
1932
1933         Reviewed by Ojan Vafai.
1934
1935         The chromium ports no longer need to look at the apple 'win'
1936         directory for baseline results.
1937
1938         Also remove the old '-gpu-' entries from the flakiness dashboard
1939         map since I'm touching lines nearby.
1940
1941         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1942         (ChromiumLinuxPort):
1943         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1944         (ChromiumWinPort):
1945         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1946
1947 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1948
1949         [Qt][WK2] Manage graphics buffers in the web process
1950         https://bugs.webkit.org/show_bug.cgi?id=78675
1951
1952         Enable graphics surfaces on Mac for Qt.
1953
1954         Reviewed by Kenneth Rohde Christiansen.
1955
1956         * qmake/mkspecs/features/features.prf:
1957
1958 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1959
1960         [CMake] Enable USE_FOLDERS property
1961         https://bugs.webkit.org/show_bug.cgi?id=83571
1962
1963         Reviewed by Daniel Bates.
1964
1965         Setting the FOLDER property on targets gives more structure
1966         to the generated Visual Studio solutions.
1967         This does not affect other CMake generators.
1968
1969         * DumpRenderTree/efl/CMakeLists.txt:
1970         * EWebLauncher/CMakeLists.txt:
1971         * WinCELauncher/CMakeLists.txt:
1972
1973 2012-04-10  David Dorwin  <ddorwin@chromium.org>
1974
1975         Add Encrypted Media Extensions methods to HTMLMediaElement
1976         https://bugs.webkit.org/show_bug.cgi?id=82971
1977
1978         Reviewed by Adam Barth.
1979
1980         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
1981         Implementation is based on v0.1 of the draft proposal at
1982         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
1983
1984         * DumpRenderTree/chromium/TestShell.cpp:
1985         (TestShell::TestShell):
1986
1987 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1988
1989         [EFL][DRT] Catch the "title,changed" signal
1990         https://bugs.webkit.org/show_bug.cgi?id=82174
1991
1992         Reviewed by Gustavo Noronha Silva.
1993
1994         EFL's DumpRenderTree now catches the "title,changed" signal, and
1995         prints out the needed information.
1996
1997         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1998         (DumpRenderTreeChrome::onTitleChanged):
1999
2000 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
2001
2002         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
2003         https://bugs.webkit.org/show_bug.cgi?id=82443
2004
2005         Reviewed by Philippe Normand.
2006
2007         EFL's DRT needs to support LayoutTestController's
2008         willSendRequestReturnsNull() and return NULL when expected. This
2009         allows for several tests to be removed from the skip list.
2010
2011         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2012         (DumpRenderTreeChrome::onWillSendRequest):
2013
2014 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2015
2016         [EFL] LayoutTestController needs implementation of addUserStyleSheet
2017         https://bugs.webkit.org/show_bug.cgi?id=82446
2018
2019         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
2020         so that we can unskip related tests from the skip list. 
2021
2022         Reviewed by Antonio Gomes.
2023
2024         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2025         (LayoutTestController::addUserStyleSheet): Implemented.
2026
2027 2012-04-10  Philip Rogers  <pdr@google.com>
2028
2029         Adding myself to committers.py!
2030
2031         Unreviewed update to committers.py.
2032
2033         * Scripts/webkitpy/common/config/committers.py:
2034
2035 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
2036
2037         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
2038         https://bugs.webkit.org/show_bug.cgi?id=82483
2039
2040         Reviewed by Kenneth Rohde Christiansen.
2041
2042         Set window title to default if there is no page title.
2043
2044         * MiniBrowser/qt/BrowserWindow.cpp:
2045         (BrowserWindow::BrowserWindow):
2046         (BrowserWindow::onTitleChanged):
2047         * MiniBrowser/qt/BrowserWindow.h:
2048         (BrowserWindow):
2049
2050 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2051
2052         [Qt][WK2] Implement PageClient::isViewWindowActive()
2053         https://bugs.webkit.org/show_bug.cgi?id=81143
2054
2055         Reviewed by Kenneth Rohde Christiansen.
2056
2057         Fix the WrapperWindow from our PlatformWebView
2058         so it correctly creates the platform related
2059         stuff for QWindow, which is not created unless
2060         QWindow::setVisible() or QWindow::show() are called.
2061
2062         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2063         (WTR::PlatformWebView::PlatformWebView):
2064
2065 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
2066
2067         [Qt][WK2] TestNetscapePlugin is broken
2068         https://bugs.webkit.org/show_bug.cgi?id=83024
2069
2070         Reviewed by Csaba Osztrogonác.
2071
2072         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2073         Fix X11 availability check. embedded is always true with QPA.
2074         * Tools.pro:
2075         Build the test plugin if plugins are enabled for WebKit2.
2076         * qmake/mkspecs/features/features.prf:
2077         * qmake/mkspecs/features/functions.prf:
2078         Added a convenience function to determine availability
2079         of X11 libraries.
2080
2081 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
2082
2083         [WIN] Fix build without precompiled header.
2084
2085         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
2086
2087 2012-04-10  Arko Saha  <arko@motorola.com>
2088
2089         Unreviewed: adding myself to committers.py.
2090
2091         * Scripts/webkitpy/common/config/committers.py:
2092
2093 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2094
2095         Unreviewed: adding myself to committers.py.
2096
2097         * Scripts/webkitpy/common/config/committers.py:
2098
2099 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
2100
2101         Unreviewed, rolling out r113656.
2102         http://trac.webkit.org/changeset/113656
2103         https://bugs.webkit.org/show_bug.cgi?id=83542
2104
2105         test is broken on chromium-win (Requested by simonjam on
2106         #webkit).
2107
2108         * DumpRenderTree/chromium/WebViewHost.cpp:
2109         (WebViewHost::dispatchIntent):
2110
2111 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
2112
2113         Update pywebsocket to 0.7.4.
2114         https://bugs.webkit.org/show_bug.cgi?id=83461
2115
2116         Reviewed by Kent Tamura.
2117
2118         This version supports TLS by using ssl in addition to pyOpenSSL.
2119         Other functional difrerences from 0.7.2 are:
2120          - strict Sec-WebSocket-Key validation conforming RFC 4648
2121          - compression ratio logging in debug
2122
2123         * Scripts/webkitpy/thirdparty/__init__.py:
2124         (AutoinstallImportHook._install_pywebsocket):
2125
2126 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2127
2128         add a webkit-patch print-baselines command
2129         https://bugs.webkit.org/show_bug.cgi?id=83348
2130
2131         Reviewed by Adam Barth.
2132
2133         This adds a simple 'print-baselines' command to webkit-patch
2134         that can be used in one of two forms: to print where the
2135         baselines for a given test (or set of tests) on a single port
2136         will be found, or to generate a report for multiple ports.
2137
2138         Example of the former:
2139
2140         $ webkit-patch print-baselines fast/html/keygen.html
2141         // For mac-snowleopard
2142         platform/mac/fast/html/keygen-expected.txt
2143         platform/mac/fast/html/keygen-expected.png
2144         $
2145
2146         The latter is most useful for finding out which fallback dirs are
2147         used by which ports for which tests, for example,
2148         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
2149         No example output is given because the reports are pretty wordy :).
2150
2151         * Scripts/webkitpy/layout_tests/port/base.py:
2152         (Port.baseline_extensions): Added.
2153         (Port.expected_baseline_dict): Added.
2154         * Scripts/webkitpy/tool/commands/queries.py:
2155         (PrintBaselines):
2156         (PrintBaselines.__init__):
2157         (PrintBaselines.execute):
2158         (PrintBaselines._print_baselines):
2159         (PrintBaselines._platform_for_path):
2160
2161 2012-04-09  Florin Malita  <fmalita@chromium.org>
2162
2163         Unreviewed: adding myself to committers.py.
2164
2165         * Scripts/webkitpy/common/config/committers.py:
2166
2167 2012-04-09  Ming Xie  <mxie@rim.com>
2168
2169         [BlackBerry] Allow simulator to use GLES2 acceleration
2170         https://bugs.webkit.org/show_bug.cgi?id=81672
2171
2172         Reviewed by Rob Buis.
2173
2174         * Scripts/webkitdirs.pm:
2175         (blackberryCMakeArguments):
2176
2177 2012-04-09  Dana Jansens  <danakj@chromium.org>
2178
2179         Mark myself as a committer
2180         https://bugs.webkit.org/show_bug.cgi?id=83510
2181
2182         Reviewed by Adrienne Walker.
2183
2184         * Scripts/webkitpy/common/config/committers.py:
2185
2186 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2187
2188         nrwt is failing to upload test results on the chromium-mac-leopard bots
2189         https://bugs.webkit.org/show_bug.cgi?id=83230
2190
2191         Unreviewed, build fix.
2192
2193         It looks like the change in r113399 to use the per-request
2194         timeout variable didn't actually work, so I am removing the
2195         timeout code altogether and counting on the idea that upload
2196         just isn't likely to take that long and the timeouts and
2197         retransmits are largely unused and largely unnecessary. We'll
2198         see if this breaks anywhere else.
2199
2200         * Scripts/webkitpy/common/net/file_uploader.py:
2201         (FileUploader.__init__):
2202         (FileUploader._upload_data.callback):
2203         (FileUploader):
2204
2205 2012-04-09  Rob Buis  <rbuis@rim.com>
2206
2207         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
2208         https://bugs.webkit.org/show_bug.cgi?id=83469
2209
2210         Reviewed by Dirk Schulze.
2211
2212         Remove WTF:: prefixes and fix a warning with the length variable.
2213
2214         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2215         (jsStringRefToWebCoreString):
2216         (LayoutTestController::execCommand):
2217         (LayoutTestController::isCommandEnabled):
2218         (LayoutTestController::setUserStyleSheetLocation):
2219         (LayoutTestController::counterValueForElementById):
2220         (LayoutTestController::overridePreference):
2221         (LayoutTestController::setMockGeolocationError):
2222         (LayoutTestController::findString):
2223
2224 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
2225
2226         Build fix for WinCE after r113570.
2227
2228         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
2229
2230 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
2231
2232         Subscribe eric.carlson@apple.com to Media-related changes
2233         https://bugs.webkit.org/show_bug.cgi?id=83421
2234
2235         Reviewed by Dan Bernstein.
2236
2237         * Scripts/webkitpy/common/config/watchlist:
2238
2239 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
2240
2241         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
2242         https://bugs.webkit.org/show_bug.cgi?id=83412
2243
2244         Reviewed by David Levin.
2245
2246         Accept NULL as an argument for gtk_style_context_get_style, because it's
2247         used as a sentinel in a variable argument list. 
2248
2249         * Scripts/webkitpy/style/checkers/cpp.py:
2250         (check_for_null): Add an exception.
2251         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2252         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
2253
2254 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
2255
2256         webkitpy: use the filesystem object properly in fileuploader
2257         https://bugs.webkit.org/show_bug.cgi?id=83326
2258
2259         Reviewed by Adam Barth.
2260
2261         We should be using the filesystem object rather than the codecs
2262         object.
2263
2264         * Scripts/webkitpy/common/net/file_uploader.py:
2265         (FileUploader.upload_as_multipart_form_data):
2266
2267 2012-04-09  Eric Seidel  <eric@webkit.org>
2268
2269         Enable webkit_unit_tests for commit queue and EWS while tracking failures
2270         https://bugs.webkit.org/show_bug.cgi?id=83329
2271
2272         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
2273
2274         line 62, in _create_unit_test_results
2275          return UnitTestResults.results_from_string(results_xml)
2276          NameError: global name 'UnitTestResults' is not defined
2277
2278         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2279         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2280         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2281
2282 2012-04-08  Adam Barth  <abarth@webkit.org>
2283
2284         The port object is missing unit_tests_results_path
2285         https://bugs.webkit.org/show_bug.cgi?id=83448
2286
2287         Unreviewed.
2288
2289         This is causing the cr-linux-ews to throw an exception.
2290
2291         * Scripts/webkitpy/common/config/ports.py:
2292         (DeprecatedPort.unit_tests_results_path):
2293
2294 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
2295
2296         [CMake] Cleanup WTF include directories
2297         https://bugs.webkit.org/show_bug.cgi?id=82716
2298
2299         Reviewed by Eric Seidel.
2300
2301         * DumpRenderTree/efl/CMakeLists.txt:
2302         * WinCELauncher/CMakeLists.txt:
2303
2304 2012-04-07  Rob Buis  <rbuis@rim.com>
2305
2306         [BlackBerry] Add Battery Status API support
2307         https://bugs.webkit.org/show_bug.cgi?id=82615
2308
2309         Reviewed by George Staikos.
2310
2311         Enable BATTERY_STATUS.
2312
2313         * Scripts/build-webkit:
2314
2315 2012-04-06  Ami Fischman  <fischman@chromium.org>
2316
2317         Subscribe feature-media-reviews@c.o to Media-related changes.
2318         https://bugs.webkit.org/show_bug.cgi?id=83397
2319
2320         Reviewed by David Levin.
2321
2322         * Scripts/webkitpy/common/config/committers.py:
2323         * Scripts/webkitpy/common/config/watchlist:
2324
2325 2012-04-06  Adrienne Walker  <enne@google.com>
2326
2327         [chromium] Add virtual test suite for threaded compositing
2328         https://bugs.webkit.org/show_bug.cgi?id=82263
2329
2330         Reviewed by James Robinson.
2331
2332         Add compositing/visibility as a virtual test suites to test threaded
2333         compositing with. This is a reasonable smoke test of 9 tests, none of
2334         which have any expectations in the non-threaded case.
2335
2336         To fix many of the remaining tests in this virtual test suite, there
2337         will need to be some serious refactoring to merge the conflict between
2338         the way CCScheduler wants to draw frames and the way DRT also wants to
2339         control things. So, in the short term, enable a few simple tests that
2340         are known to be passing.
2341
2342         * Scripts/webkitpy/layout_tests/port/chromium.py:
2343         (ChromiumPort.virtual_test_suites):
2344
2345 2012-04-06  Enrica Casucci  <enrica@apple.com>
2346
2347         Provide Obj-C private API to simplify markup.
2348         https://bugs.webkit.org/show_bug.cgi?id=83334
2349         <rdar://problem/11033861>
2350
2351         Reviewed by Sam Weinig.
2352
2353         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2354         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
2355         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
2356         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
2357
2358 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
2359
2360         new-run-webkit-tests: fix bugs in 'mock' drt implementation
2361         https://bugs.webkit.org/show_bug.cgi?id=83341
2362
2363         Reviewed by Eric Seidel.
2364
2365         The current implementation crashed in some circumstances for
2366         reference tests and files that were missing expected results.
2367         This patch fixes those cases and adds more unit tests; it is a
2368         precursor to adding unit tests each port that actually uses this
2369         code, in order to get better coverage of the port/*
2370         implementations.
2371
2372         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2373         (parse_options):
2374         (MockDRT.input_from_line):
2375         (MockDRT.output_for_test):
2376         (MockDRT.run_one_test):
2377         (MockChromiumDRT.input_from_line):
2378         (MockChromiumDRT.output_for_test):
2379         (MockChromiumDRT.run_one_test):
2380         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2381         (MockDRTTest.make_input_output):
2382         (MockDRTTest.expected_output):
2383         (MockDRTTest):
2384         (MockDRTTest.assertTest):
2385         (MockDRTTest.test_missing_image):
2386         (MockDRTTest.test_missing_text):
2387         (MockDRTTest.test_reftest_match):
2388         (MockDRTTest.test_reftest_mismatch):
2389         (MockChromiumDRTTest.expected_output):
2390
2391 2012-04-06  James Robinson  <jamesr@chromium.org>
2392
2393         Enable webkit_unit_tests for commit queue and EWS while tracking failures
2394         https://bugs.webkit.org/show_bug.cgi?id=83329
2395
2396         Reviewed by Adam Barth.
2397
2398         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
2399         the commit queue and EWS can reject patches that cause regressions.
2400
2401         * Scripts/webkitpy/common/config/ports.py:
2402         (ChromiumPort.run_webkit_unit_tests_command):
2403         * Scripts/webkitpy/common/config/ports_mock.py:
2404         (MockPort.unit_tests_results_path):
2405         * Scripts/webkitpy/common/net/layouttestresults.py:
2406         (LayoutTestResults.__init__):
2407         (LayoutTestResults.failing_tests):
2408         (LayoutTestResults):
2409         (LayoutTestResults.add_unit_test_failures):
2410         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
2411         (UnitTestResults):
2412         (UnitTestResults.results_from_string):
2413         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
2414         (UnitTestResultsTest):
2415         (UnitTestResultsTest.test_nostring):
2416         (UnitTestResultsTest.test_emptystring):
2417         (UnitTestResultsTest.test_nofailures):
2418         (test_onefailure):
2419         (test_multiple_failures_per_test):
2420         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2421         (MockCommitQueue.test_results):
2422         (MockCommitQueue.archive_last_test_results):
2423         (FailingTestCommitQueue.test_results):
2424         (test_flaky_test_failure):
2425         (test_failed_archive):
2426         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2427         (LayoutTestResultsReader._create_unit_test_results):
2428         (LayoutTestResultsReader.results):
2429         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2430         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2431         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2432         (PatchAnalysisTaskDelegate.test_results):
2433         (PatchAnalysisTaskDelegate.archive_last_test_results):
2434         (PatchAnalysisTask._test):
2435         (PatchAnalysisTask._build_and_test_without_patch):
2436         (PatchAnalysisTask._test_patch):
2437         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2438         (AbstractEarlyWarningSystem.test_results):
2439         (AbstractEarlyWarningSystem.archive_last_test_results):
2440         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2441         (EarlyWarningSytemTest._test_testing_ews):
2442         * Scripts/webkitpy/tool/commands/queues.py:
2443         (CommitQueue.test_results):
2444         (CommitQueue.archive_last_test_results):
2445         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2446         (CommitQueueTest.test_commit_queue):
2447         (test_rollout):
2448         (test_manual_reject_during_processing):
2449         * Scripts/webkitpy/tool/steps/runtests.py:
2450         (RunTests.run):
2451         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2452         (RunTestsTest.test_webkit_run_unit_tests):
2453
2454 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
2455
2456         Enable MediaSource feature for DumpRenderTree so
2457         MediaSource LayoutTests will pass for Chromium.
2458         https://bugs.webkit.org/show_bug.cgi?id=83053
2459
2460         Reviewed by Dimitri Glazkov.
2461
2462         * DumpRenderTree/chromium/TestShell.cpp:
2463         (TestShell::TestShell):
2464
2465 2012-04-06  George Staikos  <staikos@webkit.org>
2466
2467         Turn on vibration support for BlackBerry.
2468
2469         Reviewed by Rob Buis.
2470
2471         * Scripts/build-webkit:
2472
2473 2012-04-06  Dan Bernstein  <mitz@apple.com>
2474
2475         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
2476
2477         Reviewed by Sam Weinig.
2478
2479         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
2480
2481 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
2482
2483         nrwt is failing to upload test results on the chromium-mac-leopard bots
2484         https://bugs.webkit.org/show_bug.cgi?id=83230
2485
2486         Reviewed by Ojan Vafai.
2487
2488         This should fix things properly; FileUploader() was setting the
2489         socket default timeout value, and apparently that doesn't work
2490         properly with urllib. Also, the class had a bad try/finally
2491         block that was causing the exceptions to be swallowed :(.
2492
2493         * Scripts/webkitpy/common/net/file_uploader.py:
2494         (FileUploader.__init__):
2495         (FileUploader._upload_data.callback):
2496         (FileUploader):
2497         (FileUploader._upload_data):
2498         * Scripts/webkitpy/common/net/networktransaction.py:
2499         (NetworkTimeout.__str__):
2500         (NetworkTransaction.run):
2501         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2502         (JSONResultsGeneratorBase.upload_json_files):
2503
2504 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
2505
2506         [Qt] Correct <wtf/*.h> include paths.
2507         https://bugs.webkit.org/show_bug.cgi?id=83270
2508
2509         Reviewed by Eric Seidel.
2510
2511         Modify the #include declerations so that the
2512         wtf types are included using the full path.
2513
2514         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2515
2516 2012-04-05  Philippe Normand  <pnormand@igalia.com>
2517
2518         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
2519         https://bugs.webkit.org/show_bug.cgi?id=83176
2520
2521         Reviewed by Tony Chang.
2522
2523         Refactored the test to use os.path.join() to specify the
2524         core_pattern value of the empty crash log mock.
2525
2526         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2527         (GtkPortTest):
2528         (GtkPortTest.assertLinesEqual):
2529         (GtkPortTest.test_get_crash_log):
2530         (_mock_gdb_output):
2531
2532 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
2533
2534         [Qt] Fix includes after QtDeclarative -> QtQML renaming
2535         https://bugs.webkit.org/show_bug.cgi?id=82195
2536
2537         Relanding r112651, because Qt5 is updated everywhere.
2538
2539         * MiniBrowser/qt/BrowserWindow.cpp:
2540         (BrowserWindow::updateVisualMockTouchPoints):
2541         * MiniBrowser/qt/main.cpp:
2542         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2543         (WTR::WrapperWindow::handleStatusChanged):
2544         * qmake/mkspecs/features/unix/default_post.prf:
2545
2546 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
2547
2548         [Qt] WK1/WK2 layout test results are diverging
2549         https://bugs.webkit.org/show_bug.cgi?id=82720
2550
2551         The resolving of default font families was altered in Qt5.
2552         This directly affects the font picked by DRT for layout
2553         tests. Since we want to keep the Qt4 and Qt5 results in line,
2554         we can trick DRT in picking the same font as before for now.
2555
2556         Reviewed by Csaba Osztrogonác.
2557
2558         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
2559         (WebKit::initializeTestFonts):
2560
2561 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
2562
2563         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
2564         https://bugs.webkit.org/show_bug.cgi?id=82592
2565
2566         Reviewed by David Levin.
2567
2568         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
2569
2570         * DumpRenderTree/chromium/EventSender.cpp:
2571         (EventSender::beginDragWithFiles):
2572
2573 2012-04-04  Tim Horton  <timothy_horton@apple.com>
2574
2575         [mac] WKTR should always keep its windows offscreen
2576         https://bugs.webkit.org/show_bug.cgi?id=83244
2577         <rdar://problem/11188764>
2578
2579         Reviewed by Simon Fraser.
2580
2581         We don't want to allow windows onto the main display; intercept attempts to
2582         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
2583
2584         Also keep around and respond with a new "fake" origin, in case someone is
2585         expecting it to change (I couldn't find any tests that expected this, however).
2586
2587         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2588         (-[WebKitTestRunnerWindow setFrameOrigin:]):
2589         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
2590         (-[WebKitTestRunnerWindow setFrame:display:]):
2591         (-[WebKitTestRunnerWindow frame]):
2592
2593 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
2594
2595         Fix typo introduced in r113271.
2596
2597         Unreviewed, build fix.
2598
2599         * Scripts/webkitpy/common/net/file_uploader.py:
2600         (FileUploader._upload_data.callback):
2601         (FileUploader):
2602
2603 2012-04-04  Scott Graham  <scottmg@google.com>
2604
2605         [Chromium, DRT] Bounds check indices on gamepadController
2606         https://bugs.webkit.org/show_bug.cgi?id=83192
2607
2608         Invalid test data would cause bad array accesses. Add simple checks to
2609         ignore such invalid data.
2610
2611         Reviewed by Kent Tamura.
2612
2613         * DumpRenderTree/chromium/GamepadController.cpp:
2614         (GamepadController::connect):
2615         (GamepadController::disconnect):
2616         (GamepadController::setId):
2617         (GamepadController::setButtonCount):
2618         (GamepadController::setButtonData):
2619         (GamepadController::setAxisCount):
2620         (GamepadController::setAxisData):
2621
2622 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
2623
2624         nrwt is failing to upload test results on the chromium-mac-leopard bots
2625         https://bugs.webkit.org/show_bug.cgi?id=83230
2626
2627         Reviewed by Ojan Vafai.
2628
2629         More debugging info and a possible fix - stop messing with the
2630         default network timeout, and don't swallow URLErrors.
2631
2632         * Scripts/webkitpy/common/net/file_uploader.py:
2633         (FileUploader._upload_data):
2634         * Scripts/webkitpy/common/net/networktransaction.py:
2635         (NetworkTransaction.run):
2636         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2637         (JSONResultsGeneratorBase.upload_json_files):
2638
2639 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
2640
2641         nrwt is failing to upload test results on the chromium-mac-leopard bots
2642         https://bugs.webkit.org/show_bug.cgi?id=83230
2643
2644         Reviewed by Ojan Vafai.
2645
2646         * Scripts/webkitpy/common/net/file_uploader.py:
2647         (FileUploader.__init__):
2648         (FileUploader._upload_data.callback):
2649         (FileUploader):
2650         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2651         (Manager._upload_json_files):
2652         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2653         (JSONResultsGeneratorBase.upload_json_files):
2654
2655 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2656
2657         WKTR needs to implement layoutTestController.setPageVisibility()
2658         https://bugs.webkit.org/show_bug.cgi?id=69554
2659
2660         Reviewed by Simon Fraser.
2661
2662         This patch implements the layoutTestController.setPageVisibility
2663         so WKTR supports the Page Visibility API implementation by using InjectedBundle
2664         to set the visibility state directly to Page.
2665
2666         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2667         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2668         (WTR::LayoutTestController::setPageVisibility):
2669         (WTR):
2670         (WTR::LayoutTestController::resetPageVisibility):
2671         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2672         (LayoutTestController):
2673
2674 2012-04-04  Adam Barth  <abarth@webkit.org>
2675
2676         [Chromium] TestWebKitAPI links in WebCore twice
2677         https://bugs.webkit.org/show_bug.cgi?id=83177
2678
2679         Reviewed by Dimitri Glazkov.
2680
2681         This is causing link errors in the Windows component build. This patch
2682         moves the dependencies a bit lower down in the dependency diagram in
2683         the hopes of removing the duplicate symbols.
2684
2685         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2686
2687 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
2688
2689         [EFL][DRT] Catch the "resource,request,willsend" signal
2690         https://bugs.webkit.org/show_bug.cgi?id=82192
2691
2692         Reviewed by Gustavo Noronha Silva.
2693
2694         EFL's DumpRenderTree now catches the "resource,request,willsend"
2695         signal in order to implement the "Blocked access to external URL"
2696         behavior and avoid potential network-related timeouts in the tests.
2697
2698         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2699         (DumpRenderTreeChrome::createView):
2700         (DumpRenderTreeChrome::onWillSendRequest):
2701         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2702         (DumpRenderTreeChrome):
2703
2704 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
2705
2706         [EFL][DRT] Correct <wtf/*.h> include paths.
2707         https://bugs.webkit.org/show_bug.cgi?id=83168
2708
2709         Reviewed by Eric Seidel.
2710
2711         Modify the #include declarations so that the 
2712         wtf types are included using the full path.
2713
2714         * DumpRenderTree/efl/DumpRenderTree.cpp:
2715
2716 2012-04-04  Philippe Normand  <pnormand@igalia.com>
2717
2718         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
2719         https://bugs.webkit.org/show_bug.cgi?id=83176
2720
2721         Reviewed by Tony Chang.
2722
2723         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2724         (test_get_crash_log): Skip the test on non-linux platforms.
2725
2726 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2727
2728         [EFL] DRT support for computedStyleIncludingVisitedInfo
2729         https://bugs.webkit.org/show_bug.cgi?id=82190
2730
2731         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
2732         LayoutTestController so that we can unskip related tests from the skip list.
2733
2734         Reviewed by Antonio Gomes.
2735
2736         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2737         (LayoutTestController::computedStyleIncludingVisitedInfo):
2738
2739 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
2740
2741         Unreviewed; update my email address once again in the committers
2742         and watch list.
2743
2744         * Scripts/webkitpy/common/config/committers.py: Prefer my
2745         webkit.org email over my FreeBSD.org one.
2746         * Scripts/webkitpy/common/config/watchlist: Ditto.
2747
2748 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2749
2750         [Qt][WK2] QtWebKit2 should support Page Visibility API
2751         https://bugs.webkit.org/show_bug.cgi?id=81164
2752
2753         Reviewed by Kenneth Rohde Christiansen.
2754
2755         Enabling Page Visiblity API for Qt WebKit2.
2756
2757         * qmake/mkspecs/features/features.prf:
2758
2759 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
2760
2761         [Qt][WK2] Make the WebView a subclass of Flickable
2762         https://bugs.webkit.org/show_bug.cgi?id=83033
2763
2764         Reviewed by Kenneth Rohde Christiansen.
2765
2766         Remove workaround in MiniBrowser and the ScrollIndicator
2767         now that the WebView is a Flickable.
2768
2769         * MiniBrowser/qt/MiniBrowser.pro:
2770         * MiniBrowser/qt/qml/BrowserWindow.qml:
2771         * MiniBrowser/qt/qml/ScrollIndicator.qml:
2772         * WebKitTestRunner/Target.pri:
2773
2774 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
2775
2776         REGRESSION(r113144): It made run-webkit-tests always fail
2777         https://bugs.webkit.org/show_bug.cgi?id=83142
2778
2779         Unreviewed trivial fix after r113144.
2780
2781         * Scripts/run-webkit-tests:
2782
2783 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2784
2785         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
2786         double quotations on Windows. Use system instead.
2787
2788         Hopefully, this won't break anything.
2789
2790         * Scripts/run-webkit-tests:
2791
2792 2012-04-03  Keishi Hattori  <keishi@webkit.org>
2793
2794         Disable ENABLE_DATALIST for now
2795         https://bugs.webkit.org/show_bug.cgi?id=82871
2796
2797         Reviewed by Kent Tamura.
2798
2799         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
2800
2801 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2802
2803         Sigh... this isn't going well. I can't even reproduce this issue locally.
2804         Another speculative fix.
2805
2806         * Scripts/run-webkit-tests:
2807
2808 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2809
2810         I don't know why I'm so sloppy today. Another build fix.
2811
2812         * Scripts/run-webkit-tests:
2813
2814 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2815
2816         Hopefully the last build fix for Chromium Windows.
2817
2818         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
2819
2820         * Scripts/run-webkit-tests:
2821
2822 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
2823
2824         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
2825         https://bugs.webkit.org/show_bug.cgi?id=83076
2826
2827         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
2828
2829         Add logic to the apple mac and chromium mac code to not use
2830         too many workers; it looks like the xserves (and possibly mac
2831         pros) count hyperthreaded cores when they really shouldn't and
2832         we end up using too many workers at a time; this leads to tests
2833         thrashing and timing out.
2834
2835         This change is a temporary fix to make the bots happy while I
2836         look into more profiling and other fixes.
2837
2838         * Scripts/webkitpy/layout_tests/port/mac.py:
2839         (ChromiumMacPort.default_child_processes):
2840
2841         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2842         (ChromiumMacPort.default_child_processes):
2843
2844 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2845
2846         WebKitTestRunner's EventSender is leaky
2847         https://bugs.webkit.org/show_bug.cgi?id=83099
2848
2849         Reviewed by Beth Dakin.
2850         
2851         Fix leaks of WKNumbers by using the adoptWK idiom, and make
2852         all the code consistent.
2853
2854         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2855         (WTR::EventSendingController::mouseDown):
2856         (WTR::EventSendingController::mouseUp):
2857         (WTR::EventSendingController::mouseMoveTo):
2858         (WTR::EventSendingController::leapForward):
2859         (WTR::EventSendingController::keyDown):
2860         (WTR::EventSendingController::mouseScrollBy):
2861         (WTR::EventSendingController::addTouchPoint):
2862         (WTR::EventSendingController::updateTouchPoint):
2863         (WTR::EventSendingController::setTouchModifier):
2864         (WTR::EventSendingController::releaseTouchPoint):
2865         (WTR::EventSendingController::cancelTouchPoint):
2866
2867 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2868
2869         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
2870
2871         * Scripts/run-webkit-tests:
2872         (useNewRunWebKitTests):
2873
2874 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2875
2876         kill-old-processes should kill apache2 and httpd
2877         https://bugs.webkit.org/show_bug.cgi?id=83065
2878
2879         Reviewed by Tony Chang.
2880
2881         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
2882
2883         * BuildSlaveSupport/kill-old-processes:
2884
2885 2012-04-03  Tony Chang  <tony@chromium.org>
2886
2887         run the same test steps on test only bots as on build-and-test bots
2888         https://bugs.webkit.org/show_bug.cgi?id=83090
2889
2890         Reviewed by Ryosuke Niwa.
2891
2892         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2893         (TestFactory.__init__):
2894
2895 2012-04-03  Ami Fischman  <fischman@chromium.org>
2896
2897         Add a Media watchlist.
2898         https://bugs.webkit.org/show_bug.cgi?id=83071
2899
2900         Reviewed by David Levin.
2901
2902         * Scripts/webkitpy/common/config/watchlist:
2903
2904 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2905
2906         Fix large leak in WebKitTestRunner
2907         https://bugs.webkit.org/show_bug.cgi?id=83084
2908
2909         Reviewed by Beth Dakin.
2910         
2911         Fix a leak of the bimap backing store created when doing pixel and
2912         ref tests. This leak was causing serious thrash on the test bots.
2913         
2914         We don't need to allocate memory for CGBitmapContextCreate(); if we
2915         pass NULL, it will allocate and manage its own backing store.
2916
2917         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2918         (WTR::createCGContextFromImage):
2919
2920 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2921
2922         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
2923
2924         * BuildSlaveSupport/built-product-archive:
2925         (unzipArchive):
2926
2927 2012-04-03  Ojan Vafai  <ojan@chromium.org>
2928
2929         Give more human friendly error message when builders fail to load or have stale data.
2930         https://bugs.webkit.org/show_bug.cgi?id=83058
2931
2932         Reviewed by Eric Seidel.
2933
2934         * TestResultServer/static-dashboards/dashboard_base.js:
2935         (addError):
2936         (addBuilderLoadErrors):
2937         (handleLocationChange):
2938         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2939
2940 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2941
2942         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
2943
2944         * BuildSlaveSupport/built-product-archive:
2945         (extractBuiltProduct):
2946
2947 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2948
2949         Yet another build fix after r113067. Don't trigger Chromium testers right away
2950         since they're now triggered by builders.
2951
2952         * BuildSlaveSupport/build.webkit.org-config/config.json:
2953
2954 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2955
2956         Another build fix after r113067 for Mac port.
2957         It turned out that archiving the entire build directory doesn't work.
2958
2959         * BuildSlaveSupport/built-product-archive:
2960         (createZipManually):
2961         (createZip):
2962         (archiveBuiltProduct):
2963
2964 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
2965
2966         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
2967         https://bugs.webkit.org/show_bug.cgi?id=82643
2968
2969         Update LayoutTestController to accomodate the new find API.
2970         It now provides caseSensitive functionality to DRT.
2971
2972         Internal Review by Andy Chen.
2973
2974         Reviewed by Rob Buis.
2975
2976         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2977         (LayoutTestController::findString):
2978
2979 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2980
2981         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
2982         because download-built-product creates the build directory as needed.
2983
2984         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
2985
2986         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2987         (TestFactory.__init__):
2988
2989 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2990
2991         Build fix after r113067. Don't delete the build directory.
2992
2993         * BuildSlaveSupport/built-product-archive:
2994         (extractBuiltProduct):
2995
2996 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2997
2998         Load all builder lists from the buildbot json
2999         https://bugs.webkit.org/show_bug.cgi?id=82998
3000
3001         Reviewed by Adam Barth.
3002
3003         Also, remove an unnecessary list of test types. Now we don't hard-code
3004         builder names anywhere and we only have a single hard-coded list of
3005         test types.
3006
3007         * TestResultServer/static-dashboards/builders.js:
3008         (BuilderMaster.prototype.logPath):
3009         (BuilderMaster.prototype.builderJsonPath):
3010         (requestBuilderList.xhr.onload):
3011         (requestBuilderList.xhr.onerror):
3012         (isChromiumDepsFyiGpuTestRunner):
3013         (isChromiumTipOfTreeGpuTestRunner):
3014         (isChromiumDepsGTestRunner):
3015         (isChromiumDepsCrosGTestRunner):
3016         (isChromiumTipOfTreeGTestRunner):
3017         (onBuilderListLoad):
3018         (loadBuildersList):
3019         * TestResultServer/static-dashboards/dashboard_base.js:
3020         (parseCrossDashboardParameters):
3021         (currentBuilderGroupCategory):
3022         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3023         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3024         (testHtmlForTestsWithExpectationsButNoFailures):
3025         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
3026         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
3027         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
3028         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
3029         * TestResultServer/static-dashboards/timeline_explorer.html:
3030
3031 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
3032
3033         Chromium testers should extract builds instead of building on their own
3034         https://bugs.webkit.org/show_bug.cgi?id=82996
3035
3036         Reviewed by Tony Chang.
3037
3038         Make Chromium builders triggger Chromium testers and make testers download and extract builds
3039         from the buildbot master instead of building binaries on their own.
3040
3041         Add download-built-product to wrap curl used in the download-built-product step since Windows
3042         does not provide "curl" natively.
3043
3044         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
3045         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
3046         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3047         (DownloadBuiltProduct): Call download-built-product instead of curl.
3048         * BuildSlaveSupport/built-product-archive:
3049         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
3050         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
3051         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
3052         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
3053         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
3054         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
3055
3056 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
3057
3058         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
3059         https://bugs.webkit.org/show_bug.cgi?id=82473
3060
3061         Reviewed by Philippe Normand.
3062
3063         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
3064         was ever run.
3065
3066         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
3067         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
3068
3069 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3070
3071         [EFL] DRT support for setInteractiveFormValidationEnabled
3072         https://bugs.webkit.org/show_bug.cgi?id=82050
3073
3074         Enable interactive form validation and unskip tests from the
3075         skip list.
3076
3077         Reviewed by Antonio Gomes.
3078
3079         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3080         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3081
3082 2012-04-03  Philippe Normand  <pnormand@igalia.com>
3083
3084         Unreviewed, another test-webkitpy fix-up after r113037.
3085
3086         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
3087         crash dump depending on current environment.
3088
3089 2012-04-03  Philippe Normand  <pnormand@igalia.com>
3090
3091         Unreviewed, test-webkitpy build fix after r113037.
3092
3093         * Scripts/webkitpy/layout_tests/port/gtk.py:
3094         (GtkPort._get_crash_log):
3095
3096 2012-04-03  Philippe Normand  <pnormand@igalia.com>
3097
3098         [GTK] crash log reports support
3099         https://bugs.webkit.org/show_bug.cgi?id=81659
3100
3101         Reviewed by Martin Robinson.
3102
3103         Removed the daemontools crashmon/xvfb scripts and implemented the crash
3104         log reporting in the NRWT Gtk port. To get proper crash logs one
3105         needs to set the core pattern like this:
3106         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
3107         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
3108         environment variable.
3109
3110         * BuildSlaveSupport/gtk/README:
3111         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
3112         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
3113         * BuildSlaveSupport/gtk/crashmon/run: Removed.
3114         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3115         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
3116         * BuildSlaveSupport/gtk/xvfb/run: Removed.
3117         * Scripts/new-run-webkit-tests:
3118         * Scripts/webkitpy/layout_tests/port/gtk.py:
3119         (GtkDriver.stop):
3120         (GtkPort.show_results_html_file):
3121         (GtkPort):
3122         (GtkPort._get_gdb_output):
3123         (GtkPort._get_crash_log):
3124         (GtkPort._get_crash_log.match_filename):
3125         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3126         (GtkPortTest):
3127         (test_show_results_html_file):
3128         (assertLinesEqual):
3129         (_mock_gdb_output):
3130         (test_get_crash_log):
3131
3132 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3133
3134         Enable and connect the WebInspectorServer with WebKit2 pages.
3135         https://bugs.webkit.org/show_bug.cgi?id=73094
3136
3137         Reviewed by Simon Hausmann.
3138
3139         Enable developer extras on pages in MiniBrowser for Qt.
3140
3141         * MiniBrowser/qt/qml/BrowserWindow.qml:
3142
3143 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
3144
3145         [EFL] LayoutTestController needs implementation of setDefersLoading
3146         https://bugs.webkit.org/show_bug.cgi?id=82890
3147
3148         Reviewed by Philippe Normand.
3149
3150         Implement setDefersLoading() in EFL's LayoutTestController so that the
3151         corresponding test case can be removed from the skip list.
3152
3153         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3154         (LayoutTestController::setDefersLoading):
3155
3156 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
3157
3158         [EFL] LayoutTestController needs implementation of goBack
3159         https://bugs.webkit.org/show_bug.cgi?id=81914
3160
3161         Reviewed by Philippe Normand.
3162
3163         Implement goBack() in EFL's LayoutTestController by calling
3164         ewk_frame_back().
3165
3166         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3167         (LayoutTestController::goBack):
3168
3169 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
3170
3171         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
3172         https://bugs.webkit.org/show_bug.cgi?id=82589
3173
3174         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
3175         in order to unskip printing/page-format-data.html
3176
3177         Reviewed by Philippe Normand.
3178
3179         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3180         (LayoutTestController::pageSizeAndMarginsInPixels):
3181
3182 2012-04-03  Simon Pena  <spena@igalia.com>
3183
3184         [GTK] DRT missing didRunInsecureContent notification
3185         https://bugs.webkit.org/show_bug.cgi?id=59367
3186
3187         Reviewed by Philippe Normand.
3188
3189         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
3190         the main WebFrame or any other WebFrame created later. Added
3191         "didRunInsecureContent" notification in the callback in order to
3192         get the LayoutTests passing.
3193
3194         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
3195         to WebFrame's "insecure-content-run" signal and add
3196         didRunInsecureContent notification in the callback to get the
3197         LayoutTests passing.
3198         (didRunInsecureContent):
3199         (createWebView):
3200
3201 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3202
3203         rebaseline-server: Make it possible to not launch a browser with the server.
3204         https://bugs.webkit.org/show_bug.cgi?id=82999
3205
3206         Reviewed by Adam Barth.
3207
3208         Add the `--no-show-results' option, which lets one decide not to
3209         launch a web browser when running the rebaseline server.  This is
3210         especially useful if the default browser is not the wanted one, or
3211         if the rebaseline server page is already open.
3212
3213         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
3214         (AbstractLocalServerCommand.__init__):
3215         (AbstractLocalServerCommand.execute):
3216
3217 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3218
3219         EFL's LayoutTestController disableImageLoading implementation.
3220         https://bugs.webkit.org/show_bug.cgi?id=82848
3221
3222         Reviewed by Hajime Morita.
3223
3224         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3225         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3226         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3227         (LayoutTestController::disableImageLoading):
3228
3229 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
3230
3231         [EFL] LayoutTestController needs implementation of isPageBoxVisible
3232         https://bugs.webkit.org/show_bug.cgi?id=82591
3233
3234         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
3235         in order to unskip printing/page-format-data.html
3236
3237         Reviewed by Hajime Morita.
3238
3239         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3240         (LayoutTestController::isPageBoxVisible):
3241
3242 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
3243
3244         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
3245         https://bugs.webkit.org/show_bug.cgi?id=82962
3246
3247         Reviewed by Dirk Pranke.
3248
3249         Ensure that _build_path() returns an absolute path.
3250
3251         Eric Seidel also had to deploy MockConfig in a bunch of places
3252         in order to correct previous testing errors where we were
3253         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
3254         was a real path.  The real Config object calls run_command("webkit-build-directory")
3255         to read the WebKit build directory from the webkitdirs.pm perl code.
3256         MockConfig abstracts this away and always returns "/mock-build" during
3257         testing.  This change is much larger than one would think necessary
3258         because of needing to deploy this MockConfig class.
3259
3260         * Scripts/webkitpy/layout_tests/port/webkit.py:
3261         (WebKitPort._build_path):
3262
3263 2012-04-02  Ojan Vafai  <ojan@chromium.org>
3264
3265         Fix snafu in r112971. We were never calling parseParameter for builder.
3266
3267         * TestResultServer/static-dashboards/dashboard_base.js:
3268
3269 2012-04-02  Ojan Vafai  <ojan@chromium.org>
3270
3271         Generate the lists of all layout test builders from the buildbot json
3272         https://bugs.webkit.org/show_bug.cgi?id=82924
3273
3274         Reviewed by Mihai Parparita.
3275
3276         In order to make this work, cleaned up a lot of existing technical debt.
3277         -Got rid of expectations builder. This concept is outdated and just dead code.
3278         -Split hash parameter parsing into two functions. One for dashboard_base
3279         (crossDashboardParameters) and one for the specific dashboard html file
3280         (dashboardSpecificParameters). In the old world, parseParameters needed to
3281         be called twice and depended on it's own output the first time through.
3282         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
3283         doesn't depend on the output of crossDashboardParameters.
3284         -Lots of variable/method renames due to the above.
3285         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
3286         for that dashboard.
3287
3288         * TestResultServer/static-dashboards/aggregate_results.html:
3289         * TestResultServer/static-dashboards/builders.js:
3290         (BuilderGroup):
3291         (BuilderGroup.prototype.setup):
3292         (jsonRequest.xhr.onload):
3293         (jsonRequest.xhr.onerror):
3294         (isWebkitTestRunner):
3295         (isChromiumWebkitTipOfTreeTestRunner):
3296         (isChromiumWebkitDepsTestRunner):
3297         (generateBuildersFromBuilderList):
3298         (onLayoutTestBuilderListLoad):
3299         (onErrorLoadingBuilderList):
3300         (loadBuildersList):
3301         * TestResultServer/static-dashboards/dashboard_base.js:
3302         (handleValidHashParameterWrapper):
3303         (queryHashAsMap):
3304         (parseParameter):
3305         (parseCrossDashboardParameters):
3306         (parseDashboardSpecificParameters):
3307         (parseParameters):
3308         (diffStates):
3309         (defaultValue):
3310         (isLayoutTestResults):
3311         (isGPUTestResults):
3312         (currentBuilderGroupCategory):
3313         (currentBuilderGroup):
3314         (initBuilders):
3315         Now that we've split parameter parseing, these methods no longer need
3316         to take an optional state. They can always just use the global cross-dashboard state.
3317
3318         (pathToBuilderResultsFile):
3319         (appendJSONScriptElementFor):
3320         (appendJSONScriptElements):
3321         (handleResourceLoadError):
3322         (haveJsonFilesLoaded):
3323         (combinedDashboardState):
3324         (setQueryParameter):
3325         (permaLinkURLHash):
3326         (toggleQueryParameter):
3327         (queryParameterValue):
3328         (selectHTML):
3329         (htmlForTestTypeSwitcher):
3330         (g_handleBuildersListLoaded):
3331         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3332         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3333         (testPlatformAndBuildType):
3334         (testSubstringList):
3335         (testHtmlForTestTypeSwitcherGroup):
3336         (testLookupVirtualTestSuite):
3337         (testBaseTest):
3338         (generateBuildersFromBuilderListHelper):
3339         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
3340         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
3341         (assertObjectsDeepEqual):
3342         (testQueryHashAsMap):
3343         (testDiffStates):
3344         * TestResultServer/static-dashboards/timeline_explorer.html:
3345         * TestResultServer/static-dashboards/treemap.html:
3346
3347 2012-04-02  Tony Chang  <tony@chromium.org>
3348
3349         check-webkit-style errors when removing .png files
3350         https://bugs.webkit.org/show_bug.cgi?id=82933
3351
3352         Reviewed by David Levin.
3353
3354         * Scripts/webkitpy/style/patchreader.py:
3355         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
3356         * Scripts/webkitpy/style/patchreader_unittest.py:
3357         (test_check_patch_with_png_deletion):
3358
3359 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3360
3361         Unreviewed, rolling out r112948.
3362         http://trac.webkit.org/changeset/112948
3363         https://bugs.webkit.org/show_bug.cgi?id=82961
3364
3365         Someone else already checked in a similar change (Requested by
3366         sundiamonde on #webkit).
3367
3368         * Scripts/webkitpy/layout_tests/port/webkit.py:
3369         (WebKitDriver._start):
3370
3371 2012-04-02  Adam Barth  <abarth@webkit.org>
3372
3373         garden-o-matic isn't able to rebaseline audio failures
3374         https://bugs.webkit.org/show_bug.cgi?id=82957
3375
3376         Reviewed by Chris Rogers.
3377
3378         This patch just adds "wav" to the list of test suffixes and updates the
3379         unit tests to show that we're rebaselining audio tests results now too.
3380
3381         * Scripts/webkitpy/tool/commands/rebaseline.py:
3382         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3383         (test_rebaseline_updates_expectations_file):
3384
3385 2012-04-02  Adam Barth  <abarth@webkit.org>
3386
3387         garden-o-matic should let you listen to audio failures
3388         https://bugs.webkit.org/show_bug.cgi?id=82953
3389
3390         Reviewed by Chris Rogers.
3391
3392         Now that we've actually got an audio failure on the bots, we can clean
3393         up the last stray bugs.  This patch doesn't have any tests because I'm
3394         lame.
3395
3396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3399         (.):
3400
3401 2012-04-02  Stephanie Lewis  <slewis@apple.com>
3402
3403         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
3404         https://bugs.webkit.org/show_bug.cgi?id=82552
3405
3406         Reviewed by Dirk Pranke.
3407
3408         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
3409
3410         * Scripts/webkitpy/layout_tests/port/webkit.py:
3411         (WebKitDriver._start):
3412
3413 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
3414
3415         NRWT is not printing out the builder it's uploading JSON files for
3416         https://bugs.webkit.org/show_bug.cgi?id=82834
3417
3418         Reviewed by Ojan Vafai.
3419
3420         Handle log messages of the form log.info("%s", arg) properly ...
3421         I didn't even know you could do that :).
3422
3423         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3424         (_LogHandler.emit):
3425         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3426         (RegularTest.test_log_args):
3427         (VerboseTest.test_log_args):
3428
3429 2012-04-02  Tim Horton  <timothy_horton@apple.com>
3430
3431         [mac] LayoutTestHelper crashes if there is no main display
3432         https://bugs.webkit.org/show_bug.cgi?id=82944
3433         <rdar://problem/11162954>
3434
3435         Reviewed by Simon Fraser.
3436
3437         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
3438         a null dictionary, so we shouldn't go ahead and try to read from it.
3439
3440         * DumpRenderTree/mac/LayoutTestHelper.m:
3441         (installLayoutTestColorProfile):
3442
3443 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
3444
3445         [Qt][WK2] Set up plugin process on Unix
3446         https://bugs.webkit.org/show_bug.cgi?id=72121
3447
3448         Reviewed by Simon Hausmann.
3449
3450         * qmake/mkspecs/features/features.prf: Reenable plugins
3451         and turn on plugin process.
3452
3453 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3454
3455         Unreviewed, rolling out r112868, r112879, and r112881.
3456         http://trac.webkit.org/changeset/112868
3457         http://trac.webkit.org/changeset/112879
3458         http://trac.webkit.org/changeset/112881
3459         https://bugs.webkit.org/show_bug.cgi?id=82901
3460
3461         "Build fail on bots." (Requested by kbalazs on #webkit).
3462
3463         * MiniBrowser/gtk/GNUmakefile.am:
3464         * qmake/mkspecs/features/features.prf:
3465
3466 2012-04-02  Philippe Normand  <pnormand@igalia.com>
3467
3468         [GTK] Enable shadow-dom in build-webkit.
3469
3470         Rubber-stamped by Gustavo Noronha Silva.
3471
3472         * Scripts/build-webkit: Enable shadow-dom build, this is need to
3473         have a working build currently.
3474
3475 2012-04-02  Andreas Kling  <kling@webkit.org>
3476
3477         Adding Zalan Bujtas to committers list.
3478
3479         * Scripts/webkitpy/common/config/committers.py:
3480
3481 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
3482
3483         [Qt][WK2] Set up plugin process on Unix
3484         https://bugs.webkit.org/show_bug.cgi?id=72121
3485
3486         Reviewed by Simon Hausmann.
3487
3488         * qmake/mkspecs/features/features.prf: Reenable plugins
3489         and turn on plugin process.
3490
3491 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
3492
3493         Unreviewed, rolling out r112651.
3494         http://trac.webkit.org/changeset/112651
3495         https://bugs.webkit.org/show_bug.cgi?id=82887
3496
3497         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
3498
3499         * MiniBrowser/qt/BrowserWindow.cpp:
3500         (BrowserWindow::updateVisualMockTouchPoints):
3501         * MiniBrowser/qt/main.cpp:
3502         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3503         (WTR::WrapperWindow::handleStatusChanged):
3504         * qmake/mkspecs/features/unix/default_post.prf:
3505
3506 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3507
3508         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
3509         https://bugs.webkit.org/show_bug.cgi?id=82877
3510
3511         Reviewed by Philippe Normand.
3512
3513         * Scripts/run-gtk-tests:
3514         (TestRunner.run_tests): Use replace instead of lstrip to remove
3515         the programs_path from the full path of unit tests.
3516
3517 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3518
3519         Unreviewed. Skip flaky unit tests.
3520
3521         * Scripts/run-gtk-tests:
3522         (TestRunner):
3523
3524 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
3525
3526         webkitpy rebaseline.
3527
3528         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3529         (test_run_test_set_with_json_output):
3530         (test_run_test_set_with_json_source):
3531
3532 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
3533
3534         perf-o-matic should store test results' units
3535         https://bugs.webkit.org/show_bug.cgi?id=82852
3536
3537         Reviewed by Kentaro Hara.
3538
3539         Include units in the results JSON.
3540
3541         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3542         (PerfTestsRunner._process_chromium_style_test_result):
3543         (PerfTestsRunner._process_parser_test_result):
3544
3545 2012-04-01  Tony Tseung  <tseung@apple.com>
3546
3547         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
3548         composite fonts from existing physical fonts.
3549         <rdar://problem/10717370>
3550         https://bugs.webkit.org/show_bug.cgi?id=82810
3551             
3552         A new test font of this kind as been added to the test tools for running the webkit-tests
3553
3554         Reviewed by Dan Bernstein.
3555
3556         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3557         Added new dependency SampleFont.sfont
3558         
3559         * DumpRenderTree/fonts/SampleFont.sfont: Added.
3560         
3561         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3562         * DumpRenderTree/mac/DumpRenderTree.mm:
3563         (allowedFontFamilySet):
3564         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
3565         
3566         (activateTestingFonts):
3567         Added the registration of the Composite Font Referene sample font
3568         
3569         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3570         (WTR::allowedFontFamilySet):
3571         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
3572
3573         (WTR::activateFonts):
3574         Added the registration of the Composite Font Referene sample font
3575
3576         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3577         Added new dependency SampleFont.sfont
3578
3579         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
3580
3581 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3582
3583         Support the Network Information API
3584         https://bugs.webkit.org/show_bug.cgi?id=73528
3585
3586         Reviewed by Adam Barth.
3587
3588         Add network information API feature to build script.
3589
3590         * Scripts/build-webkit:
3591
3592 2012-03-31  Ojan Vafai  <ojan@chromium.org>
3593
3594         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
3595         https://bugs.webkit.org/show_bug.cgi?id=82839
3596
3597         Reviewed by Adam Barth.
3598
3599         Also, update various hard-coded lists for WIN7 and Lion ports.
3600         This is necessary since the new list of builders grabbed off the
3601         buildbot includes Lion.
3602
3603         * TestResultServer/static-dashboards/builders.js:
3604         (generateWebkitBuildersFromBuilderList):
3605         (xhr.onreadystatechange):
3606         Don't use dashboard_base's request method to avoid layering violation.
3607
3608         * TestResultServer/static-dashboards/dashboard_base.js:
3609         (parseParameters):
3610         (initBuilders):
3611         (haveJsonFilesLoaded):
3612         (g_handleBuildersListLoaded):
3613         Block loading the JSON files for each builder until we actually have a list of builders.
3614
3615         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3616         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3617         (testPlatformAndBuildType):
3618         (testGenerateWebkitBuildersFromBuilderList):
3619         * TestResultServer/static-dashboards/timeline_explorer.html:
3620         * TestResultServer/static-dashboards/treemap.html:
3621         Delay generating the page until the builder list has loaded.
3622
3623 2012-03-31  Ojan Vafai  <ojan@chromium.org>
3624
3625         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
3626         https://bugs.webkit.org/show_bug.cgi?id=82799
3627
3628         Reviewed by Eric Seidel.
3629
3630         If we don't run a test, mark it as skipped.
3631
3632         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3633         (Manager._mark_interrupted_tests_as_skipped):
3634         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
3635         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3636         (ManagerTest.test_interrupt_if_at_failure_limits):
3637
3638 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
3639
3640         One more build fix after r112781 for Chromium Windows.
3641         Don't copy zip .idb files.
3642
3643         * BuildSlaveSupport/built-product-archive:
3644         (copyBuildFiles):
3645
3646 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
3647
3648         Yet another build fix after r112781 for Chromium Windows.
3649         Run webkit-build-directory by perl explicitly.
3650
3651         * BuildSlaveSupport/built-product-archive:
3652         (determineWebKitBuildDirectory):
3653
3654 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
3655
3656         Fix the syntax error in master.cfg after r112734.
3657
3658         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3659         (unitTestsSupported):
3660
3661 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
3662
3663         Another build fix after r112781.
3664
3665         * BuildSlaveSupport/built-product-archive:
3666         (createZip):
3667
3668 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
3669
3670         Build fix after r112781.
3671
3672         * BuildSlaveSupport/built-product-archive:
3673         (createZipManually):
3674         (createZip):
3675
3676 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
3677
3678         Chromium bots should upload archived built files
3679         https://bugs.webkit.org/show_bug.cgi?id=82666
3680
3681         Reviewed by Tony Chang.
3682
3683         * BuildSlaveSupport/build.webkit.org-config/config.json:
3684         * BuildSlaveSupport/built-product-archive:
3685         (main):
3686         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
3687         call out to webkit-build-directory.
3688         (removeDirectoryIfExists): Extracted.
3689         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
3690         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
3691         (createZipManually.addToArchive):
3692         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
3693         (archiveBuiltProduct): Add support for Chromium port.
3694         * Scripts/webkit-build-directory: Add support for --platform options.
3695
3696 2012-03-30  Dan Bernstein  <mitz@apple.com>
3697
3698         Reverted r112767, because it caused many vertical text tests to fail.
3699
3700         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3701         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
3702         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3703         * DumpRenderTree/mac/DumpRenderTree.mm:
3704         (allowedFontFamilySet):
3705         (activateTestingFonts):
3706         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3707         (WTR::allowedFontFamilySet):
3708         (WTR::activateFonts):
3709         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: