https://bugs.webkit.org/show_bug.cgi?id=117514
[WebKit-https.git] / Tools / ChangeLog
1 2013-06-11  Alex Christensen  <achristensen@apple.com>
2
3         https://bugs.webkit.org/show_bug.cgi?id=117514
4         Removed extra Xcode code coverage flags.
5
6         Reviewed by Sam Weinig.
7
8         * Scripts/webkitdirs.pm:
9         (XcodeCoverageSupportOptions):
10
11 2013-06-11  Brent Fulgham  <bfulgham@apple.com>
12
13         [Windows] Implement 'attributeValue' accessor to support testing
14         https://bugs.webkit.org/show_bug.cgi?id=117513
15
16         Reviewed by Anders Carlsson.
17
18         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
19         (comparableObject): Move earlier in file.
20         (findAccessibleObjectById): New implemenation.
21         (AccessibilityController::accessibleElementById): New implementation.
22
23 2013-06-11  Csaba Osztrogonác  <ossy@webkit.org>
24
25         Make WTR use its own temporary directory for application cache
26         https://bugs.webkit.org/show_bug.cgi?id=117143
27
28         Reviewed by Alexey Proskuryakov.
29
30         * WebKitTestRunner/TestController.cpp:
31         (WTR::TestController::initialize):
32
33 2013-06-10  Alexey Proskuryakov  <ap@apple.com>
34
35         https://bugs.webkit.org/show_bug.cgi?id=117449
36         Remove dead code for storing fonts in __DATA section
37
38         Reviewed by Dan Bernstein.
39
40         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
41         Don't copy font resources to __DATA, as we don't have any code that reads them
42         from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
43
44         * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
45         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
46         Removed comments suggesting that we want to restore the old solution.
47
48 2013-06-10  Bear Travis  <betravis@adobe.com>
49
50         [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
51         https://bugs.webkit.org/show_bug.cgi?id=117162
52
53         Reviewed by Alexandru Chiculita.
54
55         Adding the WebCore/rendering/shapes directory to the include list.
56
57         * DumpRenderTree/efl/CMakeLists.txt:
58
59 2013-06-09  Brent Fulgham  <bfulgham@apple.com>
60
61         [Windows] Unreviewed test correction:  Prevent DumpRenderTree crashes
62         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
63         (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
64         happends in some of the 'accessibility' test cases.
65
66 2013-06-08  peavo@outlook.com  <peavo@outlook.com>
67
68         [WinCairo] TestWebKitAPI fails to link.
69         https://bugs.webkit.org/show_bug.cgi?id=117345
70
71         Reviewed by Brent Fulgham.
72
73         Need to link with WTF.lib.
74
75         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
76
77 2013-06-07  Roger Fong  <roger_fong@apple.com>
78
79         Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
80
81         Rubberstamped by Ryousuke Niwa.
82
83         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
84         (RunTest.test_build_check):
85
86 2013-06-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
87
88         [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
89         https://bugs.webkit.org/show_bug.cgi?id=117315
90
91         Reviewed by Benjamin Poulain.
92
93         Qt doesn't use the default values specified on FeatureList since r44681,
94         this patch just remove a bit of noise.
95
96         * Scripts/webkitperl/FeatureList.pm:
97
98 2013-06-07  Jungsik Tae  <davidtlay88@gmail.com>
99
100         [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
101         https://bugs.webkit.org/show_bug.cgi?id=115890
102
103         Reviewed by Christophe Dumez.
104
105         When user clicks HTML5 input type color,
106         color selector window is created on browser object by using elm_colorchooser_add().
107         It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
108         The evas_object_color_set() sets a color value returning to browser.
109
110         * MiniBrowser/efl/main.c:
111         (window_free): When we delete parent window, deleting the colorpicker object.
112         (on_color_changed): Change color of rectangle to show color selected by user.
113         (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
114         (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
115         (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
116         (on_color_picker_dismiss): Delete colorpicker object.
117         (on_color_picker_request): Create colorpicker window object.
118         (window_create):
119
120 2013-06-06  Yuki Sekiguchi  <yuki.sekiguchi@access-company.com>
121
122         svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
123         https://bugs.webkit.org/show_bug.cgi?id=111066
124
125         Reviewed by Daniel Bates.
126
127         Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
128
129         ParseGitDiffHeader() should support the path which line has space characters.
130         To support this, I changed parsing algorithm like the following:
131         - When the diff have prefix, we consider next characters after "b/" as part of a file path.
132         - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
133
134         We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
135
136         If the path has a tab, the patch(1) command thinks file path is characters before the tab.
137         I added a dummy tab and revision when we convert git diff to svn diff.
138
139         * Scripts/VCSUtils.pm:
140         (parseGitDiffHeader):
141         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
142         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
143         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
144           - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
145
146 2013-06-06  Simon Fraser  <simon.fraser@apple.com>
147
148         Add a menu item to MiniBrowser to toggle Transparent windows
149         https://bugs.webkit.org/show_bug.cgi?id=117316
150
151         Reviewed by Anders Carlsson.
152         
153         Add a menu item that toggles "Transparent window" mode, which is exposed
154         via private WebKit API and WebKit2 API.
155
156         * MiniBrowser/mac/BrowserWindowController.h:
157         * MiniBrowser/mac/MainMenu.xib:
158         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
159         * MiniBrowser/mac/WK1BrowserWindowController.m:
160         (-[WK1BrowserWindowController validateMenuItem:]):
161         (-[WK1BrowserWindowController toggleTransparentWindow:]):
162         * MiniBrowser/mac/WK2BrowserWindowController.m:
163         (-[WK2BrowserWindowController validateMenuItem:]):
164         (-[WK2BrowserWindowController toggleTransparentWindow:]):
165         (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
166         when testing.
167
168 2013-06-06  Roger Fong  <roger_fong@apple.com>
169
170         Stop copying AAS binaries into build folder.
171         https://bugs.webkit.org/show_bug.cgi?id=117319.
172
173         Rubberstamped by Darin Adler.
174
175         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
176
177 2013-06-06  Hugo Parente Lima  <hugo.lima@openbossa.org>
178
179         Aligning build-webkit command line switch names to the WebKit flag names
180         https://bugs.webkit.org/show_bug.cgi?id=117254
181
182         Reviewed by Laszlo Gombos.
183
184         * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
185
186 2013-06-06  Chris Fleizach  <cfleizach@apple.com>
187
188         AX: iOS ignores ARIA progressbar elements
189         https://bugs.webkit.org/show_bug.cgi?id=116727
190
191         Reviewed by David Kilzer.
192
193         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
194         (AccessibilityUIElement::minValue):
195         (AccessibilityUIElement::maxValue):
196
197 2013-06-06  peavo@outlook.com  <peavo@outlook.com>
198
199         [WinCairo] Fix build-webkit to build WinCairo under VS2010.
200         https://bugs.webkit.org/show_bug.cgi?id=117255
201
202         Reviewed by Daniel Bates.
203
204         Need to update configuration names according to solution file.
205
206         * Scripts/webkitdirs.pm:
207         (determineConfiguration):
208         (determinePassedConfiguration):
209
210 2013-06-06  Ryosuke Niwa  <rniwa@webkit.org>
211
212         Remove run-performance-tests
213         https://bugs.webkit.org/show_bug.cgi?id=117285
214
215         Reviewed by Andreas Kling.
216         
217         Remove the script since it's not used anywhere.
218
219         * BuildSlaveSupport/run-performance-tests: Removed.
220
221 2013-06-05  Bear Travis  <betravis@adobe.com>
222
223         [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
224         https://bugs.webkit.org/show_bug.cgi?id=117172
225
226         Reviewed by Alexandru Chiculita.
227
228         Adding the CSS_SHAPES compile flag.
229
230         * Scripts/webkitperl/FeatureList.pm:
231         * qmake/mkspecs/features/features.pri:
232
233 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
234
235         [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
236         to UNIX-style they will not execute properly.
237
238         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
239         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
240
241 2013-06-05  Roger Fong  <roger_fong@apple.com>
242
243         Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
244
245         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
246         (RunWebKitTests.start):
247
248 2013-06-05  Brent Fulgham  <bfulgham@apple.com>
249
250         [Windows] Switch to NRWT
251         https://bugs.webkit.org/show_bug.cgi?id=117200
252
253         Reviewed by Anders Carlsson.
254
255         * Scripts/run-webkit-tests:
256         (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
257
258 2013-06-05  Dominik Röttsches  <dominik.rottsches@intel.com>
259
260         Unreviewed name fix after r150662
261
262         My firstname got duplicated when fixing bug 116737.
263
264         * Scripts/webkitpy/common/config/contributors.json:
265
266 2013-06-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
267
268         Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
269         https://bugs.webkit.org/show_bug.cgi?id=117244
270
271         Reviewed by Daniel Bates.
272
273         Fixed a regression introduced by r151196: not only does webkit.org
274         still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
275         infrastructure used by ports such as GTK+ and EFL also use on it for
276         things such as jhbuild.
277
278         While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
279         both environment variables.
280
281         * Scripts/webkitdirs.pm:
282         (determineBaseProductDir):
283
284 2013-06-05  Wojciech Bielawski  <w.bielawski@samsung.com>
285
286         [GTK] Forwarding headers not generated for incremental build
287         https://bugs.webkit.org/show_bug.cgi?id=117198
288
289         Reviewed by Carlos Garcia Campos.
290
291         * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
292
293 2013-06-05  Andras Becsi  <andras.becsi@digia.com>
294
295         [Qt][WK2] Fix layout testing with Qt 5.1
296         https://bugs.webkit.org/show_bug.cgi?id=117203
297
298         Reviewed by Jocelyn Turcotte.
299
300         With Qt 5.1 synchronous requests via QNetworkAccessManager do not
301         go into loading state but directly call handler functions for
302         finished state instead of relying on a connection.
303         Our wrapper QQuickView uses a data URI scheme to create the root
304         item for testing which results in a synchronous request when loading
305         the QML data, therefore the state of the QQuickWindow immediately
306         becomes Ready.
307         Since the final initialization of the root item depended on the
308         emission of QQuickView::statusChanged(QQuickView::Ready) we ended
309         up with a partially initialized wrapper window, thus most of our
310         layout tests were failing.
311         For compatibility with pre-5.1 Qt versions keep the old behaviour
312         in case the WrapperWindow is not ready in the constructor yet.
313
314         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
315         (WTR::WrapperWindow::WrapperWindow):
316         * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
317         (TestWebKitAPI::WrapperWindow::WrapperWindow):
318
319 2013-06-05  Dariusz Frankiewicz  <d.frankiewic@samsung.com>
320
321         Bad value in tests counter at new-run-webkit-tests
322         in --debug-rwt-logging mode
323         https://bugs.webkit.org/show_bug.cgi?id=116858
324
325         Reviewed by Dirk Pranke.
326
327         Fix by moving counter incrementation, from after printing line,
328         to before printing. Also changed variable name.
329
330         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
331         (LayoutTestRunner.run_tests):
332         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
333         (FakePrinter):
334         * Scripts/webkitpy/layout_tests/views/printing.py:
335         (Printer.__init__):
336         (Printer._test_status_line):
337         (Printer.print_started_test):
338         (Printer.print_finished_test):
339         * Scripts/webkitpy/test/printer.py:
340         (Printer.__init__):
341         (Printer.print_finished_test):
342         (Printer._test_line):
343         (Printer.print_result):
344
345 2013-06-05  Zan Dobersek  <zdobersek@igalia.com>
346
347         Move MemoryInfo under window.internals
348         https://bugs.webkit.org/show_bug.cgi?id=117197
349
350         Reviewed by Ryosuke Niwa.
351
352         * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
353         the Automake build
354         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
355         testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
356
357 2013-06-03  Roger Fong  <roger_fong@apple.com>
358
359         Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
360         <rdar://problem/14042021>.
361
362         Reviewed by Brent Fulgham.
363
364         * Scripts/build-api-tests:
365         * Scripts/build-dumprendertree:
366         * Scripts/build-webkit:
367         * Scripts/update-webkit-dependency:
368         * Scripts/update-webkit-support-libs:
369         * Scripts/webkitdirs.pm:
370         (determineBaseProductDir):
371         (setupAppleWinEnv):
372         (setupCygwinEnv):
373
374 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
375
376         [Windows] NRWT is not putting crash logs in proper place (corrections)
377         https://bugs.webkit.org/show_bug.cgi?id=117212
378
379         Reviewed by Dirk Pranke.
380
381         * Scripts/webkitpy/common/system/crashlogs.py:
382         (CrashLogs.__init__): Accept a result directory argument in constructor.
383         (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
384         (CrashLogs._find_newest_log_win): No longer use 'port' argument.
385         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
386         (CrashLogsTest.test_find_log_win): Simplify test.
387         * Scripts/webkitpy/common/system/executive.py:
388         (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
389         * Scripts/webkitpy/port/win.py:
390         (WinPort._get_crash_log): No longer require 'port' argument.
391
392 2013-06-04  Ryosuke Niwa  <rniwa@webkit.org>
393
394         Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
395
396         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
397
398 2013-06-04  Greg Hughes  <ghughes@apple.com>
399
400         Add "VisibleOnly" key to search predicate
401         https://bugs.webkit.org/show_bug.cgi?id=115491
402
403         Reviewed by Chris Fleizach.
404
405         Added support for accessibility clients to use the search predicate to find only visible elements
406
407         * DumpRenderTree/AccessibilityUIElement.cpp:
408         (uiElementForSearchPredicateCallback):
409         * DumpRenderTree/AccessibilityUIElement.h:
410         (AccessibilityUIElement):
411         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
412         (AccessibilityUIElement::uiElementForSearchPredicate):
413         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
414         (AccessibilityUIElement::uiElementForSearchPredicate):
415         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
416         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
417         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
418         (AccessibilityUIElement):
419         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
420         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
421         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
422
423 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
424
425         [Windows] Unreviewed build fix.  The last check-in lost CR/LF endings on the batch file,
426         causing build failure.
427
428         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
429         DOS-style CR/LF endings.
430
431 2013-06-04  Brent Fulgham  <bfulgham@apple.com>
432
433         [Windows] Unreviewed test correction.
434
435         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
436         QuartzCore dll's, which are needed by TestWebKitAPI.
437         * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
438         with VS2010 will run when linked against VS2005 support libraries.
439
440 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
441
442         Automatically generate WorkerContext constructor attributes
443         https://bugs.webkit.org/show_bug.cgi?id=117183
444
445         Reviewed by Kentaro Hara.
446
447         Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
448         tests.
449
450         * Scripts/webkitpy/bindings/main.py:
451         (BindingsTests.generate_supplemental_dependency):
452         (BindingsTests.main):
453
454 2013-06-04  Ryuan Choi  <ryuan.choi@samsung.com>
455
456         [EFL] File dialog of MiniBrowser have broken background.
457         https://bugs.webkit.org/show_bug.cgi?id=117189
458
459         Reviewed by Christophe Dumez.
460
461         * MiniBrowser/efl/main.c:
462         (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
463
464 2013-06-04  Christophe Dumez  <ch.dumez@sisa.samsung.com>
465
466         [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
467         https://bugs.webkit.org/show_bug.cgi?id=117184
468
469         Reviewed by Gyuyoung Kim.
470
471         Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
472         that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
473
474         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
475         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
476         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
477
478 2013-06-03  Simon Pena  <simon.pena@samsung.com>
479
480         validate-committer-lists script is now outdated and does not work
481         https://bugs.webkit.org/show_bug.cgi?id=115860
482
483         Reviewed by Brent Fulgham.
484
485         The script validate-committer-lists was outdated, still using the deprecated log
486         system and having the old addresses for the mailing lists, as well as still referring
487         to committers.py, after this was renamed to contributors.json. This patch fixes that
488         so it can be used again.
489
490         * Scripts/validate-committer-lists: Replace calls to log and error with the
491         new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
492         to committers.py, which should be contributors.json.
493         (CommitterListFromMailingList):
494         (CommitterListFromMailingList.check_for_emails_missing_from_list):
495         (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
496         (CommitterListFromGit._fill_in_emails_for_old_logins):
497         (CommitterListFromGit.print_committers_missing_from_committer_list):
498
499 2013-06-03  Dirk Pranke  <dpranke@chromium.org>
500
501         add a script to dump the tests run most recently by a given worker
502         https://bugs.webkit.org/show_bug.cgi?id=116571
503
504         Reviewed by Brent Fulgham.
505
506         The tests_run*.txt results files in layout-test-results/ were removed
507         in r137356, in favor of collecting more data about how the tests were
508         run and compressing it and storing it in stats.json. However, it was
509         nice to just be able to look at a flat text file.
510
511         This script will extract the tests run by a given worker from a
512         given stats.json file, and should help to address that.
513
514         * Scripts/dump-webkit-tests-run: Added.
515         (main):
516         (convert_trie_to_flat_paths):
517
518 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
519
520         [Windows] NRWT is not putting crash logs in proper place
521         https://bugs.webkit.org/show_bug.cgi?id=117098
522
523         Reviewed by Ryosuke Niwa.
524
525         Provide windows-specific overloads for various Port features needed to create and capture
526         crash logs.  This change makes it possible to view crash logs (when created) as part of the
527         summary report at the end of the NRWT run.
528
529         * Scripts/webkitpy/common/system/crashlogs.py:
530         (CrashLogs.find_newest_log): Add support for win32 crash logs
531         (CrashLogs._find_newest_log_win): Added
532         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
533         (make_mock_crash_report_win): Added
534         (CrashLogsTest.test_find_log_win): Added.
535         * Scripts/webkitpy/common/system/executive.py:
536         (Executive.running_pids): Add support for Cygwin win32 crash logs
537         * Scripts/webkitpy/common/system/executive_mock.py:
538         (MockExecutive.__init__):
539         * Scripts/webkitpy/common/system/filesystem_unittest.py:
540         (RealFileSystemTest.test_read_and_write_file): Add tests for
541         malformed ascii/utf8 handling (i.e., Windows log files)
542         * Scripts/webkitpy/port/base.py:
543         (Port.find_system_pid): Added
544         * Scripts/webkitpy/port/server_process.py:
545         (ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs
546         * Scripts/webkitpy/port/win.py:
547         (WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
548         for user to hit enter.
549         (WinPort._get_crash_log): Added
550         (WinPort.look_for_new_crash_logs): Added
551         (WinPort.find_system_pid): Added
552         * Scripts/webkitpy/port/win_unittest.py:
553         (WinPortTest.test_get_crash_log): Added test
554
555 2013-06-03  Eduardo Lima Mitev  <elima@igalia.com>
556
557         [EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
558         https://bugs.webkit.org/show_bug.cgi?id=116726
559
560         Reviewed by Gyuyoung Kim.
561
562         Current version of ATK in efl-ews environment is 2.4.0 and is taken from
563         the platform (it is not listed in jhbuild moduleset). That version is
564         old-ish and contain deprecated symbols and missing API, that are blocking
565         patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
566         moduleset, which is the same version the gtk port uses.
567
568         See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
569         why this is needed.
570
571         * efl/jhbuild.modules: Adds ATK module as dependency
572
573 2013-06-03  Erik van Pienbroek  <epienbro@fedoraproject.org>
574
575         [GTK] Respect PKG_CONFIG env variable when generating gtk-doc
576         https://bugs.webkit.org/show_bug.cgi?id=117168
577
578         Reviewed by Martin Robinson.
579
580         The tool generate-gtkdoc internally calls pkg-config.
581         When cross-compiling it shouldn't use pkg-config, but
582         it should use the pkg-config which was detected by
583         the ./configure script (for example this can be
584         i686-w64-mingw32-pkg-config when cross-compiling)
585
586         * GNUmakefile.am:
587         * gtk/gtkdoc.py:
588         (PkgConfigGTKDoc.__init__):
589
590 2013-06-03  Brent Fulgham  <bfulgham@apple.com>
591
592         [Windows] Unreviewed build fix.
593
594         * TestWebKitAPI/win/main.cpp: Embed proper manifest information to
595         allow VS2010 builds to use VS2005 runtime libraries as needed.
596
597 2013-06-03  Roger Fong  <roger_fong@apple.com>
598
599         Nuke VS2005 files from the tree.
600         <rdar://problem/14042021>.
601
602         Rubberstamped by Brent Fulgham.
603
604         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def: Removed.
605         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Removed.
606         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Removed.
607         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Removed.
608         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Removed.
609         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Removed.
610         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Removed.
611         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Removed.
612         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Removed.
613         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Removed.
614         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Removed.
615         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Removed.
616         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Removed.
617         * DumpRenderTree/win/DumpRenderTree.vcproj: Removed.
618         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Removed.
619         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Removed.
620         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Removed.
621         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Removed.
622         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Removed.
623         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Removed.
624         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Removed.
625         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Removed.
626         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Removed.
627         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Removed.
628         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Removed.
629         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Removed.
630         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Removed.
631         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Removed.
632         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Removed.
633         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Removed.
634         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Removed.
635         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Removed.
636         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Removed.
637         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Removed.
638         * DumpRenderTree/win/ImageDiff.vcproj: Removed.
639         * DumpRenderTree/win/ImageDiffCommon.vsprops: Removed.
640         * DumpRenderTree/win/ImageDiffDebug.vsprops: Removed.
641         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Removed.
642         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Removed.
643         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Removed.
644         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Removed.
645         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Removed.
646         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Removed.
647         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Removed.
648         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Removed.
649         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Removed.
650         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Removed.
651         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Removed.
652         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Removed.
653         * DumpRenderTree/win/ImageDiffProduction.vsprops: Removed.
654         * DumpRenderTree/win/ImageDiffRelease.vsprops: Removed.
655         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Removed.
656         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Removed.
657         * Scripts/pdevenv: Removed.
658         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Removed.
659         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Removed.
660         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Removed.
661         * WebKitLauncherWin: Removed.
662         * WebKitLauncherWin/Resource.h: Removed.
663         * WebKitLauncherWin/WebKitLauncherWin.cpp: Removed.
664         * WebKitLauncherWin/WebKitLauncherWin.rc: Removed.
665         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Removed.
666         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Removed.
667         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Removed.
668         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Removed.
669         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Removed.
670         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Removed.
671         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Removed.
672         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Removed.
673         * WebKitLauncherWin/webkit.ico: Removed.
674         * WinLauncher/WinLauncher.ico: Removed.
675         * WinLauncher/WinLauncher.rc: Removed.
676         * WinLauncher/WinLauncher.vcproj: Removed.
677         * WinLauncher/WinLauncherCommon.vsprops: Removed.
678         * WinLauncher/WinLauncherDebug.vsprops: Removed.
679         * WinLauncher/WinLauncherDebugAll.vsprops: Removed.
680         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Removed.
681         * WinLauncher/WinLauncherLauncher.rc: Removed.
682         * WinLauncher/WinLauncherLauncher.vcproj: Removed.
683         * WinLauncher/WinLauncherLauncherCommon.vsprops: Removed.
684         * WinLauncher/WinLauncherLauncherDebug.vsprops: Removed.
685         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Removed.
686         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Removed.
687         * WinLauncher/WinLauncherLauncherProduction.vsprops: Removed.
688         * WinLauncher/WinLauncherLauncherRelease.vsprops: Removed.
689         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Removed.
690         * WinLauncher/WinLauncherLauncherResource.h: Removed.
691         * WinLauncher/WinLauncherPostBuild.cmd: Removed.
692         * WinLauncher/WinLauncherPreBuild.cmd: Removed.
693         * WinLauncher/WinLauncherProduction.vsprops: Removed.
694         * WinLauncher/WinLauncherRelease.vsprops: Removed.
695         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Removed.
696         * WinLauncher/small.ico: Removed.
697         * record-memory-win: Removed.
698         * record-memory-win/main.cpp: Removed.
699         * record-memory-win/record-memory-win-common.vsprops: Removed.
700         * record-memory-win/record-memory-win.vcproj: Removed.
701         * record-memory-win/record-memory-winDebug.vsprops: Removed.
702         * record-memory-win/record-memory-winDebugAll.vsprops: Removed.
703         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Removed.
704         * record-memory-win/record-memory-winProduction.vsprops: Removed.
705         * record-memory-win/record-memory-winRelease.vsprops: Removed.
706         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Removed.
707
708 2013-06-03  Chris Fleizach  <cfleizach@apple.com>
709
710         AX: MathML multiscripts not exposed in Accessibility
711         https://bugs.webkit.org/show_bug.cgi?id=115069
712
713         Reviewed by Tim Horton.
714
715         Add methods to help output components of math multiscripts for accessibility.
716
717         * DumpRenderTree/AccessibilityUIElement.cpp:
718         (mathPostscriptsDescriptionCallback):
719         (mathPrescriptsDescriptionCallback):
720         (AccessibilityUIElement::getJSClass):
721         * DumpRenderTree/AccessibilityUIElement.h:
722         (AccessibilityUIElement):
723         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
724         (convertMathMultiscriptPairsToString):
725         (AccessibilityUIElement::mathPostscriptsDescription):
726         (AccessibilityUIElement::mathPrescriptsDescription):
727         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
728         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
729         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
730         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
731         (AccessibilityUIElement):
732         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
733         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
734         (WTR::_convertMathMultiscriptPairsToString):
735         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
736         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
737
738 2013-06-03  Commit Queue  <commit-queue@webkit.org>
739
740         Unreviewed, rolling out r151109.
741         http://trac.webkit.org/changeset/151109
742         https://bugs.webkit.org/show_bug.cgi?id=117145
743
744         "Plugins in WK2 aren't implemented yet." (Requested by
745         jturcotte on #webkit).
746
747         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
748         * qmake/mkspecs/features/features.prf:
749         * qmake/mkspecs/features/unix/default_pre.prf:
750
751 2013-05-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
752
753         [Qt] Re-enable plugins on Mac.
754         https://bugs.webkit.org/show_bug.cgi?id=116622
755
756         Reviewed by Tor Arne Vestbø.
757
758         Plugins on Mac were only enabled if !embedded but the later was set if
759         QPA is enabled, which is the default since Qt 5.0.
760
761         Remove references to 'embedded' and fix various build issues,
762         PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
763         months.
764
765         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
766         * qmake/mkspecs/features/features.prf:
767         * qmake/mkspecs/features/unix/default_pre.prf:
768
769 2013-06-03  Krzysztof Czech  <k.czech@samsung.com>
770
771         [GTK][WK2] accessibility/placeholder.html is failing
772         https://bugs.webkit.org/show_bug.cgi?id=106344
773
774         Reviewed by Gyuyoung Kim.
775
776         Adds support for retrieving attribute value.
777
778         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
779         (WTR::coreAttributeToAtkAttribute):
780         (WTR::AccessibilityUIElement::stringAttributeValue):
781
782 2013-06-01  Tim Horton  <timothy_horton@apple.com>
783
784         Add a preferred email address and "expertise" for me.
785
786         * Scripts/webkitpy/common/config/contributors.json:
787
788 2013-05-31  Roger Fong  <roger_fong@apple.com>
789
790         Unreviewed. Make windows test bots search in the correct directory for build output.
791
792         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
793         (RunWebKitTests.start):
794         * Scripts/webkitdirs.pm:
795         (determineConfigurationProductDir):
796
797 2013-05-31  Roger Fong  <roger_fong@apple.com>
798
799         Unreviewed. Windows build fix...
800
801         * BuildSlaveSupport/built-product-archive:
802         (createZip):
803
804 2013-05-31  Roger Fong  <roger_fong@apple.com>
805
806         Unreviewed. Windows build fix. One more time!
807
808         * BuildSlaveSupport/built-product-archive:
809         (archiveBuiltProduct):
810         (extractBuiltProduct):
811
812 2013-05-31  Roger Fong  <roger_fong@apple.com>
813
814         Unreviewed. Windows build fix.
815
816         * Scripts/build-webkit:
817
818 2013-05-31  Roger Fong  <roger_fong@apple.com>
819
820         Unreviewed. Windows build fix.
821
822         * Scripts/build-webkit:
823
824 2013-05-31  Roger Fong  <roger_fong@apple.com>
825
826         Make build-webkit output VCExpress 2010 build logs properly.
827         https://bugs.webkit.org/show_bug.cgi?id=117096
828
829         Reviewed by Brent Fulgham.
830
831         Make it so that output from VCExpress is always printed to console.
832         Get build log results from AssembleBuildLogs project output.
833         We don't need those old VCExpress scripts anymore either. 
834
835         * Scripts/build-webkit:
836         * Scripts/print-msvc-project-dependencies: Removed.
837         * Scripts/print-vse-failure-logs: Removed.
838
839 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
840
841         [Windows] Use WinLauncher to display LayoutTest results
842         https://bugs.webkit.org/show_bug.cgi?id=117085
843
844         Reviewed by Oliver Hunt.
845
846         * Scripts/webkitdirs.pm:
847         (runSafari): Use WinLauncher to display content
848         * WinLauncher/WinLauncher.cpp:
849         (dllLauncherEntryPoint): Check for URL argument.
850
851 2013-05-31  Roger Fong  <roger_fong@apple.com>
852
853         Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
854
855         * win/AssembleBuildLogs/AssembleLogs.cmd:
856
857 2013-05-31  Commit Queue  <commit-queue@webkit.org>
858
859         Unreviewed, rolling out r151022.
860         http://trac.webkit.org/changeset/151022
861         https://bugs.webkit.org/show_bug.cgi?id=117084
862
863         Also breaks build by introducing duplicate symbols (Requested
864         by bfulgham on #webkit).
865
866         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
867
868 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
869
870         [Windows] Unreviewed build fix to NRWT
871
872         * Scripts/webkitpy/port/win.py:
873         (WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.
874
875 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
876
877         [Windows] Unreviewed build fix after r151012
878
879         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on
880         WTF library to support SHA tests
881
882 2013-05-31  Brent Fulgham  <bfulgham@apple.com>
883
884         [Windows] Unreviewed build fix after r151012
885
886         * TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide
887         snprintf definition for Windows.
888
889 2013-05-31  Zan Dobersek  <zdobersek@igalia.com>
890
891         Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
892         https://bugs.webkit.org/show_bug.cgi?id=116445
893
894         Reviewed by Benjamin Poulain.
895
896         Add the MD5 and SHA1 unit tests that were previously located inside WTF.
897
898         * TestWebKitAPI/CMakeLists.txt:
899         * TestWebKitAPI/GNUmakefile.am:
900         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
901         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
902         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
903         * TestWebKitAPI/Tests/WTF/MD5.cpp: Added.
904         (TestWebKitAPI):
905         (TestWebKitAPI::expectMD5):
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.
908         (TestWebKitAPI):
909         (TestWebKitAPI::expectSHA1):
910         (TestWebKitAPI::TEST):
911         * TestWebKitAPI/Tests/WTF/WTF.pro:
912         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
913
914 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
915
916         [Windows] Unreviewed build correction.
917
918         * Scripts/webkitpy/port/win.py:
919         (WinPort.create_debugger_command_file): The directory needs to be
920         a string, not a temporary directory object.
921
922 2013-05-30  Brent Fulgham  <bfulgham@apple.com>
923
924         [Windows] NRWT doesn't save crash logs on Apple's Windows port.
925         https://bugs.webkit.org/show_bug.cgi?id=76935
926
927         Reviewed by Ryosuke Niwa.
928
929         Extend the WinPort class with commands to set and clean up various registry
930         values needed to invoke the correct debugger to get crash files.
931
932         * Scripts/webkitpy/port/win.py:
933         (WinPort): Added global caches for registry keys and settings
934         (WinPort._ntsd_location): Added
935         (WinPort.create_debugger_command_file): Added
936         (WinPort.read_registry_string): Added
937         (WinPort.write_registry_string): Added
938         (WinPort.setup_crash_log_saving): Added
939         (WinPort.restore_crash_log_saving): Added
940         (WinPort.setup_test_run): Added overload to add registry settings.
941         (WinPort.clean_up_test_run): Added overload to clean up registry settings.
942
943 2013-05-30  Roger Fong  <roger_fong@apple.com>
944
945         Get rid of JavaScript exports file on AppleWin port.
946         https://bugs.webkit.org/show_bug.cgi?id=117050.
947
948         Reviewed by Darin Adler.
949
950         Start linking in WTF.lib now that it's a shared library.
951
952         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
953         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
954         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
955
956 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
957
958         Web Inspector: tests in PerformanceTests/inspector/ are timing out
959         https://bugs.webkit.org/show_bug.cgi?id=77024
960
961         Reviewed by Andreas Kling.
962
963         Remove inspector performance tests since they have been disabled for ages,
964         and they don't use the standard parser-style performance output.
965
966         It's adding a lot of code complexity to our infrastructure.
967
968         * Scripts/webkitpy/performance_tests/perftest.py:
969         (SingleProcessPerfTest.__init__):
970         (PerfTestFactory):
971         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
972         (TestPerfTestFactory.test_regular_test):
973         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
974         (TestDriver.run_test):
975         (MainTest.run_test):
976         (MainTest._tests_for_runner):
977         (MainTest.test_run_test_set_kills_drt_per_run):
978         (MainTest._test_run_with_json_output):
979         (MainTest):
980         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
981
982 2013-05-30  Ryosuke Niwa  <rniwa@webkit.org>
983
984         Remove requires_http_server as Chromium Android was the only port that needed this
985         https://bugs.webkit.org/show_bug.cgi?id=117018
986
987         Reviewed by Benjamin Poulain.
988
989         Removed the unused code that existed for Chromium Android port.
990
991         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
992         (LayoutTestRunner.run_tests):
993         (LayoutTestRunner._handle_finished_test_list):
994         * Scripts/webkitpy/layout_tests/controllers/manager.py:
995         (Manager._run_tests):
996         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
997         (PerfTestsRunner._collect_tests):
998         (PerfTestsRunner.run):
999         * Scripts/webkitpy/port/base.py:
1000         (Port.to.start_helper):
1001         * Scripts/webkitpy/port/base_unittest.py:
1002         (PortTest.test_build_path):
1003
1004 2013-05-29  Ruth Fong  <ruth_fong@apple.com>
1005
1006         prepare-Changelog should not be generating namespace-only or class-name-only lines like "(WebCore):"
1007         https://bugs.webkit.org/show_bug.cgi?id=113221
1008
1009         Reviewed by Ryosuke Niwa.
1010
1011         Teach prepare-Changelog to not list the names of modified namespaces, 
1012         classes, or structs in C++ files. Thus, if a change is made 
1013         within a namespace/class/struct yet outside a function, it will 
1014         not be reflected in the ChangeLog entry. 
1015         See https://bugs.webkit.org/show_bug.cgi?id=113221#c8 
1016         for more details on how ChangeLog entries are affected.
1017
1018         * Scripts/prepare-ChangeLog:
1019         (get_function_line_ranges_for_cpp): 
1020         (delete_namespaces_from_ranges_for_cpp): Added.
1021         (is_function_in_namespace): Added.
1022         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Updated
1023         to reflect revised definition of a function (i.e. excludes namespaces, classes, structs)
1024
1025 2013-05-29  Praveen R Jadhav  <praveen.j@samsung.com>
1026
1027         Cleanup AudioSourceNode.idl from WebKit build.
1028         https://bugs.webkit.org/show_bug.cgi?id=116905.
1029
1030         Reviewed by Darin Adler.
1031
1032         AudioSourceNode.idl is not part of WebAudio Specifications anymore.
1033         AudioNode is inherited directly in all the audio source nodes.
1034
1035         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1036
1037 2013-05-29  Andrew Lo  <anlo@rim.com>
1038
1039         Add Andrew Lo to contributors.json
1040         https://bugs.webkit.org/show_bug.cgi?id=116981
1041
1042         Reviewed by Rob Buis.
1043
1044         Adding Andrew Lo to contributors.json.
1045
1046         * Scripts/webkitpy/common/config/contributors.json:
1047
1048 2013-05-29  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1049
1050         Unreviewed. Adding myself as a committer.
1051
1052         * Scripts/webkitpy/common/config/contributors.json:
1053
1054 2013-05-29  Marcelo Lira  <marcelo.lira@openbossa.org>
1055
1056         [WK2][CoordinatedGraphics][EFL] WKViewUserViewportToContents() function doesn't do what it says
1057         https://bugs.webkit.org/show_bug.cgi?id=116683
1058
1059         Reviewed by Noam Rosenthal.
1060
1061         A coordinates conversion test for WKViewUserViewportToContents was
1062         added to WebKit2 API tests.
1063
1064         * TestWebKitAPI/PlatformEfl.cmake:
1065         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Added.
1066         (TestWebKitAPI):
1067         (TestWebKitAPI::TEST):
1068
1069 2013-05-29  Yong Li  <yong.li.webkit@outlook.com>
1070
1071         Unreviewed. Update my info.
1072
1073         * Scripts/webkitpy/common/config/contributors.json:
1074
1075 2013-05-29  Dongseong Hwang  <dongseong.hwang@intel.com>
1076
1077         Unreviewed. Add myself as committer in contributors.json.
1078
1079         * Scripts/webkitpy/common/config/contributors.json:
1080
1081 2013-05-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1082
1083         Unreviewed. Fix make distcheck.
1084
1085         * TestWebKitAPI/GNUmakefile.am: Add WebCoreLayer.a to
1086         DISTCLEANFILES.
1087
1088 2013-05-29  Mary Wu  <mawu@blackberry.com>
1089
1090         Unreviewed: update my email address in contributors.json.
1091
1092         * Scripts/webkitpy/common/config/contributors.json:
1093
1094 2013-05-29  Kalyan Kondapally  <kalyan.kondapally@intel.com>
1095
1096         Unreviewed: Adding myself to committers list.
1097
1098         * Scripts/webkitpy/common/config/contributors.json:
1099
1100 2013-05-28  Arpita Bahuguna  <a.bah@samsung.com>
1101
1102         Unreviewed: Adding myself to committers list.
1103
1104         * Scripts/webkitpy/common/config/contributors.json:
1105
1106 2013-05-28  Brent Fulgham  <bfulgham@webkit.org>
1107
1108         [Windows] Many CSS2.1 tests fail under NRWT.
1109         https://bugs.webkit.org/show_bug.cgi?id=75707
1110
1111         Reviewed by Darin Adler.
1112
1113         * DumpRenderTree/win/DumpRenderTree.cpp:
1114         (findFontFallback): Added
1115         (addFontFallbackIfPresent): Added
1116         (removeFontFallbackIfPresent): Added
1117         (runTest): Set up/remove font fallbacks when needed.
1118
1119 2013-05-28  Brent Fulgham  <bfulgham@apple.com>
1120
1121         [Windows] NRWT reports failure for 'mac' test cases.
1122         https://bugs.webkit.org/show_bug.cgi?id=116698
1123
1124         Reviewed by Ryosuke Niwa.
1125
1126         The Windows port falls back to the Mac port for many test results,
1127         and so adds the mac and mac-wk2 to its set of fallbacks.
1128         Unfortunately, NRWT thinks that this means that tests in these
1129         folders should be executed, resulting in many failures on
1130         Windows.
1131
1132         This change overloads the '_tests_for_other_platforms' method
1133         to return a subset of the result fallback list so that we do
1134         not attempt to execute Mac tests on Windows.
1135
1136         * Scripts/webkitpy/port/base.py:
1137         (Port.test_search_path): Added. Defaults to just calling the
1138         baseline_search_path method, which is how most ports behave.
1139         (Port._test_for_other_platforms): Modified to call the new
1140         test_search_path method.
1141
1142         * Scripts/webkitpy/port/win.py:
1143         (WinPort.test_search_path): Added custom overload. Strips
1144         out mac-specific test paths.
1145
1146 2013-05-28  Martin Robinson  <mrobinson@igalia.com>
1147
1148         Fix GTK+ CMake build
1149
1150         * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
1151         library target is simply "WebKit2."
1152
1153 2013-05-28  Zan Dobersek  <zdobersek@igalia.com>
1154
1155         [webkitpy] Explicitly specify the reference file extensions
1156         https://bugs.webkit.org/show_bug.cgi?id=116333
1157
1158         Reviewed by Benjamin Poulain.
1159
1160         Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
1161         between valid reference files required by reftests and text baselines that have the same extension as
1162         potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
1163         that were until this change recognized as reference files).
1164
1165         Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
1166
1167         * Scripts/webkitpy/port/base.py:
1168         (Port.reference_files): Iterate through the _supported_reference_extensions set.
1169         (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
1170         _supported_reference_extensions set, containing the extensions allowed for reference files.
1171         (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
1172         (Port._has_supported_extension): Use _supported_test_extensions.
1173         * Scripts/webkitpy/port/base_unittest.py:
1174         (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
1175         Port.is_reference_html_file method.
1176
1177 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1178
1179         Yet another WKR build fix. Sorry for the mess. It seems like I can't win today :(
1180
1181         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1182         (NewCommitBot.next_work_item):
1183
1184 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1185
1186         WKR and webkitbot build fixes.
1187
1188         * Scripts/webkitpy/tool/bot/irc_command.py:
1189         (RollChromiumDEPS.execute):
1190         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1191         (NewCommitBot.next_work_item):
1192
1193 2013-05-26  Ryosuke Niwa  <rniwa@webkit.org>
1194
1195         roll-chromium-deps doesn't repeat the full name.
1196
1197         Rubber-stamped by Andreas Kling.
1198
1199         * Scripts/webkitpy/tool/bot/irc_command.py:
1200         (RollChromiumDEPS.execute):
1201
1202 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1203
1204         Revert another erroneous change.
1205
1206         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1207         (NewCommitBot.next_work_item):
1208
1209 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1210
1211         Revert an erroneous change.
1212
1213         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1214         (SheriffBot):
1215
1216 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1217
1218         Some build fixes for WKR and webkitbot.
1219
1220         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1221         (IRCBotTest.test_help):
1222         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1223         (Agent):
1224         (Agent.__init__):
1225         (Agent.name):
1226         (NewCommitBot):
1227         (NewCommitBot.begin_work_queue):
1228         (NewCommitBot.next_work_item):
1229         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1230         (SheriffBot):
1231
1232 2013-05-25  Ryosuke Niwa  <rniwa@webkit.org>
1233
1234         Teach webkitbot and WKR how to respond to yt?
1235         https://bugs.webkit.org/show_bug.cgi?id=116775
1236
1237         Reviewed by Andreas Kling.
1238
1239         * Scripts/webkitpy/tool/bot/irc_command.py:
1240         (Hi): Fixed the usage string.
1241         (Hi.execute): Made it more generic so that it works in WKR.
1242         (YouThere): Added.
1243         (YouThere.execute): Added.
1244         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1245
1246 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1247
1248         Try to fix the EFL build.
1249         
1250         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1251         (TestRunner::setPageVisibility):
1252
1253 2013-05-25  Simon Fraser  <simon.fraser@apple.com>
1254
1255         Unprefix Page Visibility API
1256         https://bugs.webkit.org/show_bug.cgi?id=102340
1257
1258         Reviewed by Tim Horton.
1259         
1260         Rename "preview" state to "unloaded" state, and adjust the tests
1261         to test for it.
1262
1263         * DumpRenderTree/mac/TestRunnerMac.mm:
1264         (TestRunner::setPageVisibility):
1265         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
1266         (TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
1267         (TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
1268         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
1269         (TestWebKitAPI::didRunStep4InStateUnloaded):
1270         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
1271         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1272         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
1273         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1274         (WTR::TestRunner::setPageVisibility):
1275
1276 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1277
1278         Unreviewed build fix. Don't use new NRWT logic needed
1279         by Windows yet. Activate (and fix test) when we cut over.
1280
1281         * Scripts/webkitpy/port/driver.py:
1282         (Driver._setup_environ_for_driver):
1283         (Driver._start):
1284
1285 2013-05-24  Brent Fulgham  <bfulgham@apple.com>
1286
1287         [Windows] Expose database storage and cache locations via preferences.
1288         https://bugs.webkit.org/show_bug.cgi?id=116729
1289
1290         Reviewed by Tim Horton.
1291
1292         Update DumpRenderTree to use CFPreferences to control where WebKit
1293         stores its local databases, URL caches, etc.
1294
1295         * DumpRenderTree/win/DumpRenderTree.cpp:
1296         (libraryPathForDumpRenderTree): Added.
1297         (dllLauncherEntryPoint): Set up DRT-specific cache locations.
1298         * Scripts/webkitpy/port/base.py:
1299         (Port._driver_tempdir): Added (to allow port-specific overload).
1300         (Port._driver_tempdir_for_environment): Ditto
1301         * Scripts/webkitpy/port/driver.py:
1302         (Driver._setup_environ_for_driver): Use new overload to set
1303         environment variable.
1304         (Driver._start): Use new overload for temp directory location.
1305         * Scripts/webkitpy/port/win.py:
1306         (WinPort._driver_tempdir_for_environment): New overload to supply
1307         Windows path to DumpRenderTree environment (while still using
1308         cygwin paths for internal operations.
1309
1310 2013-05-24  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1311
1312         Remove custom code for webkitAudioContext global constructor getter
1313         https://bugs.webkit.org/show_bug.cgi?id=116530
1314
1315         Reviewed by Geoffrey Garen.
1316
1317         Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
1318         WebAudio feature instead of public ewk_view API since that API was
1319         removed.
1320
1321         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1322         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1323         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1324         (TestRunner::overridePreference):
1325
1326 2013-05-24  Bem Jones-Bey  <bjonesbe@adobe.com>
1327
1328         Make team.html have each contributor's area of expertise
1329         https://bugs.webkit.org/show_bug.cgi?id=116737
1330
1331         Reviewed by Benjamin Poulain.
1332
1333         * Scripts/webkitpy/common/config/contributors.json:
1334         Add expertise to each contributor, taken from http://trac.webkit.org/wiki/WebKit%20Team
1335         
1336         Changed formatting of the file because the lines are getting way to
1337         long, and I generated this, so it's easier if the formatting of the
1338         file is regular.
1339
1340 2013-05-24  Simon Pena  <simon.pena@samsung.com>
1341
1342         Update WTF::Vector pretty printers
1343         https://bugs.webkit.org/show_bug.cgi?id=116719
1344
1345         Reviewed by Anders Carlsson.
1346
1347         After r148891, WTF::Vector pretty printers were left outdated, as
1348         the WTF::Vector was made to extend a VectorBuffer, instead of keeping
1349         one as a member. This patch updates the pretty printers so they work
1350         again. 
1351
1352         * gdb/webkit.py:
1353         (WTFVectorPrinter.children):
1354         (WTFVectorPrinter.to_string):
1355
1356 2013-05-24  Steve Falkenburg  <sfalken@apple.com>
1357
1358         Update prepareConsistentTestingEnvironment to use a non-deprecated API.
1359         https://bugs.webkit.org/show_bug.cgi?id=116710
1360
1361         Reviewed by Mark Rowe.
1362
1363         * DumpRenderTree/mac/DumpRenderTree.mm:
1364         (prepareConsistentTestingEnvironment): Use beginActivityWithOptions instead of beginSuspensionOfSystemBehaviors.
1365
1366 2013-05-23  Lauro Neto  <lauro.neto@openbossa.org>
1367
1368         Add missing dependencies to deps script.
1369
1370         [GTK] Missing packages in install-dependencies script.
1371         https://bugs.webkit.org/show_bug.cgi?id=116632
1372
1373         Reviewed by Martin Robinson.
1374
1375         * gtk/install-dependencies:
1376
1377 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1378
1379         [Windows] Unreviewed change for NRWT support.
1380
1381         * Scripts/webkitpy/port/win.py:
1382         (WinPort.default_child_processes): Added a default implementation
1383         that limits NRWT to a single instance.
1384
1385 2013-05-23  Brent Fulgham  <bfulgham@apple.com>
1386
1387         Remove meaningless "test_uses_apache" from Python test cases.
1388         https://bugs.webkit.org/show_bug.cgi?id=38756
1389
1390         Reviewed by Ryosuke Niwa.
1391
1392         * Scripts/webkitpy/port/port_testcase.py:
1393         (PortTestCase.test_driver_cmd_line): Remove the meaningless
1394         "test_uses_apache" test case from the Python test infrastructure.
1395         It was hard-coded to true, even though not all ports use
1396         Apache.
1397
1398 2013-05-23  Brent Fulgham  <bfulgham@webkit.org>
1399
1400         [Windows] Update new-run-webkit-tests for Windows port.
1401         https://bugs.webkit.org/show_bug.cgi?id=38756
1402
1403         Reviewed by Ryosuke Niwa.
1404
1405         * Scripts/new-run-webkit-httpd:
1406         (run): Switch from 'chromium' to 'win'
1407         * Scripts/webkitpy/port/win.py:
1408         (WinPort): Add support methods for lighttpd server.
1409         (WinPort._uses_apache):
1410         (WinPort._path_to_lighttpd):
1411         (WinPort._path_to_lighttpd_modules):
1412         (WinPort._path_to_lighttpd_php):
1413
1414 2013-05-23  Patrick Gansterer  <paroga@webkit.org>
1415
1416         Make default bug links in buildbot clickable
1417         https://bugs.webkit.org/show_bug.cgi?id=116673
1418
1419         Reviewed by Ryosuke Niwa.
1420
1421         Use changecommentlink of html.WebStatus to make the links clickable.
1422
1423         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1424
1425 2013-05-22  Ryosuke Niwa  <rniwa@webkit.org>
1426
1427         REGRESSION(r150491): WebKit2.DOMWindowExtensionNoCache fails
1428         https://bugs.webkit.org/show_bug.cgi?id=116595
1429
1430         Temporarily skip this test.
1431
1432         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1433         (TestWebKitAPI::TEST):
1434
1435 2013-05-22  Alex Christensen  <achristensen@apple.com>
1436
1437         Unreviewed.  Added myself to contributors.json.
1438
1439         * Scripts/webkitpy/common/config/contributors.json:
1440         Added myself.
1441
1442 2013-05-22  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1443
1444         [EFL][WK2] Add sub menus to MiniBrowser
1445         https://bugs.webkit.org/show_bug.cgi?id=114728
1446
1447         Reviewed by Christophe Dumez.
1448
1449         Elementary Ctxpopup widget API does not provide support for submenu item.
1450         To implement ewk submenus in Minibrowser, Ctxpopup has to be replaced with
1451         Elementary Menu widget.
1452
1453         * MiniBrowser/efl/main.c:
1454         (_Browser_Window):
1455         (on_window_resize):
1456         (window_free):
1457         (context_menu_item_selected_cb):
1458         (context_menu_populate):
1459         (on_context_menu_show):
1460         (on_context_menu_hide):
1461         (window_create):
1462
1463 2013-05-22  Andrzej Badowski  <a.badowski@samsung.com>
1464
1465         [EFL] Add command line option to MiniBrowser to set cookies policy.
1466         https://bugs.webkit.org/show_bug.cgi?id=115028
1467
1468         Reviewed by Christophe Dumez.
1469
1470         Add command line option to MiniBrowser EFL to set cookies policy:
1471         -p parameter with value from (always, never, no-third-party) respectively (EWK_COOKIE_ACCEPT_POLICY_ALWAYS,
1472         EWK_COOKIE_ACCEPT_POLICY_NEVER, EWK_COOKIE_ACCEPT_POLICY_NO_THIRD_PARTY).
1473
1474         * MiniBrowser/efl/main.c:
1475         (elm_main):
1476
1477 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1478
1479         REGRESSION(r150369): WebKit2WillLoadTest tests are failing
1480         https://bugs.webkit.org/show_bug.cgi?id=116585
1481
1482         Reviewed by Alexey Proskuryakov.
1483
1484         willLoadURLRequest and willLoadDataRequest require the API version 6.
1485
1486         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1487
1488 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1489
1490         REGRESSION(r150393): editing/inserting/typing-at-end-of-line.html fails
1491         https://bugs.webkit.org/show_bug.cgi?id=116516
1492
1493         Reviewed by Alexey Proskuryakov.
1494
1495         Reset states in DumpRenderTree. The fix for WebKitTestRunner should be implemented in the bug 116577.
1496
1497         * DumpRenderTree/mac/DumpRenderTree.mm:
1498         (createWebViewAndOffscreenWindow): Match the ordering.
1499         (resetWebViewToConsistentStateBeforeTesting): Reset text replacement states.
1500
1501 2013-05-21  Alexey Proskuryakov  <ap@apple.com>
1502
1503         <rdar://problem/13929704> [WK2] WebKitTestRunner always crashes on exit
1504         https://bugs.webkit.org/show_bug.cgi?id=116568
1505
1506         Reviewed by Anders Carlsson.
1507
1508         * WebKitTestRunner/WebNotificationProvider.cpp:
1509         (WTR::WebNotificationProvider::~WebNotificationProvider):
1510         * WebKitTestRunner/WebNotificationProvider.h:
1511         When the provider is destroyed, it should no longer be registered with the manager.
1512
1513         * WebKitTestRunner/GeolocationProviderMock.cpp:
1514         (WTR::GeolocationProviderMock::~GeolocationProviderMock):
1515         * WebKitTestRunner/GeolocationProviderMock.h:
1516         I wasn't seeing a crash here, but this code has the same issue as notification
1517         provider, so applying the same fix.
1518
1519         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1520         Close icon database. I started seeing ASSERT(!isOpen()) in WebCore IconDatabase
1521         destructor having fixed the above.
1522
1523 2013-05-21  Commit Queue  <commit-queue@webkit.org>
1524
1525         Unreviewed, rolling out r150386 and r150397.
1526         http://trac.webkit.org/changeset/150386
1527         http://trac.webkit.org/changeset/150397
1528         https://bugs.webkit.org/show_bug.cgi?id=116572
1529
1530         Broke a test; Alex is going to try again later. (Requested by
1531         thorton on #webkit).
1532
1533         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1534         (WTR::pathSuitableForTestResult):
1535         (WTR::dumpRequestDescriptionSuitableForTestResult):
1536         (WTR::dumpResponseDescriptionSuitableForTestResult):
1537         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1538         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1539         (WTR::InjectedBundlePage::willSendRequestForFrame):
1540         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1541         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1542         (InjectedBundlePage):
1543
1544 2013-05-21  Ryosuke Niwa  <rniwa@webkit.org>
1545
1546         Fix a python unittest after r149419. We need to support Python 2.6 on Windows.
1547
1548         * Scripts/webkitpy/tool/commands/suggestnominations.py:
1549         (AbstractCommitLogCommand._recent_commit_messages):
1550
1551 2013-05-21  Martin Robinson  <mrobinson@igalia.com>
1552
1553         [GTK] [CMake] Add support for building WebKit2
1554         https://bugs.webkit.org/show_bug.cgi?id=116372
1555
1556         Reviewed by Gustavo Noronha Silva.
1557
1558         * CMakeLists.txt: Do not build WebKitTestRunner yet for WebKitGTK+.
1559         * MiniBrowser/gtk/CMakeLists.txt: Added.
1560
1561 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1562
1563         Revert r149635, it was too optimistic.
1564
1565         Rubber-stamped by Andreas Kling.
1566
1567         We are not at the point where we can always use more descriptive macros instead of PLATFORM()
1568         #ifdefs in WebCore code outside of WebCore/platform.
1569
1570         * Scripts/webkitpy/style/checkers/cpp.py:
1571         (check_invalid_increment):
1572         (process_line):
1573         (CppChecker):
1574         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1575         (CppStyleTest.test_plain_integral_bitfields):
1576
1577 2013-05-21  Jer Noble  <jer.noble@apple.com>
1578
1579         Unreviewed; fix lldb synthetic representation of WTF::Vector after r148891.
1580
1581         * lldb/lldb_webkit.py:
1582         (WTFVectorProvider.num_children):
1583         (WTFVectorProvider.get_child_index):
1584         (WTFVectorProvider.get_child_at_index):
1585         (WTFVectorProvider.update):
1586
1587 2013-05-21  Jessie Berlin  <jberlin@apple.com>
1588
1589         Expose a way to know when forms are added to a page or when form controls are added to a form
1590         in the injected bundle
1591         https://bugs.webkit.org/show_bug.cgi?id=116334
1592
1593         Reviewed by Alexey Proskuryakov.
1594
1595         Add tests for the new callbacks.
1596
1597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1598         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1599
1600         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1601         (TestWebKitAPI::nullJavaScriptCallback):
1602         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1603         being passed in for the callback.
1604         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1605         After receiving the message that didAssociateFormControls callback was invoked from adding
1606         the form in the onload handler, tell the page to add a password field to the form, which
1607         should also invoke didAssociateFormControls callback.
1608         (TestWebKitAPI::setInjectedBundleClient):
1609         Register to receive messages.
1610         (TestWebKitAPI::TEST):
1611         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1612         been invoked for both adding the form and for adding a password field to the form.
1613
1614         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1615         (TestWebKitAPI::shouldNotifyOnFormChanges):
1616         Return true so the didAssociateFormControls callback is invoked.
1617         (TestWebKitAPI::didAssociateFormControls):
1618         Tell the UI process.
1619         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1620         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1621         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1622
1623         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1624         Add a form in response to the onload event. Add a button that will add the password field
1625         for manual testing.
1626
1627 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1628
1629         [GTK][WK2] accessibility/label-for-control-hittest.html is failing
1630         https://bugs.webkit.org/show_bug.cgi?id=106341
1631
1632         Reviewed by Martin Robinson.
1633
1634         Adds support for retrieving accessibility element at exact point.
1635
1636         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1637         (WTR::AccessibilityUIElement::elementAtPoint):
1638
1639 2013-05-21  Krzysztof Czech  <k.czech@samsung.com>
1640
1641         [ATK] [WebKit2] AccessibilityUIElement often leaks its AtkObject
1642         https://bugs.webkit.org/show_bug.cgi?id=112913
1643
1644         Reviewed by Martin Robinson.
1645
1646         AccessibilityUIElement is often created by passing new reference to AtkObject (transfer full).
1647         AccessibilityUIElement::~AccessibilityUIElement does not decrement the reference of the element,
1648         so the leak appears.
1649
1650         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1651         (WTR):
1652         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1653         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1654         (WTR::AccessibilityController::rootElement):
1655         (WTR):
1656         (WTR::AccessibilityController::focusedElement):
1657         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1658         (WTR::checkElementState):
1659         (WTR::indexRangeInTable):
1660         (WTR::alterCurrentValue):
1661         (WTR::AccessibilityUIElement::getChildren):
1662         (WTR::AccessibilityUIElement::getChildrenWithRange):
1663         (WTR::AccessibilityUIElement::childrenCount):
1664         (WTR::AccessibilityUIElement::indexOfChild):
1665         (WTR::AccessibilityUIElement::titleUIElement):
1666         (WTR::AccessibilityUIElement::parentElement):
1667         (WTR::AccessibilityUIElement::allAttributes):
1668         (WTR::AccessibilityUIElement::role):
1669         (WTR::AccessibilityUIElement::title):
1670         (WTR::AccessibilityUIElement::description):
1671         (WTR::AccessibilityUIElement::orientation):
1672         (WTR::AccessibilityUIElement::stringValue):
1673         (WTR::AccessibilityUIElement::language):
1674         (WTR::AccessibilityUIElement::x):
1675         (WTR::AccessibilityUIElement::y):
1676         (WTR::AccessibilityUIElement::width):
1677         (WTR::AccessibilityUIElement::height):
1678         (WTR::AccessibilityUIElement::intValue):
1679         (WTR::AccessibilityUIElement::minValue):
1680         (WTR::AccessibilityUIElement::maxValue):
1681         (WTR::AccessibilityUIElement::isEnabled):
1682         (WTR::AccessibilityUIElement::isFocused):
1683         (WTR::AccessibilityUIElement::isSelected):
1684         (WTR::AccessibilityUIElement::isExpanded):
1685         (WTR::AccessibilityUIElement::isChecked):
1686         (WTR::AccessibilityUIElement::rowCount):
1687         (WTR::AccessibilityUIElement::columnCount):
1688         (WTR::AccessibilityUIElement::rowIndexRange):
1689         (WTR::AccessibilityUIElement::columnIndexRange):
1690         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1691         (WTR::AccessibilityUIElement::increment):
1692         (WTR::AccessibilityUIElement::decrement):
1693         (WTR::AccessibilityUIElement::press):
1694         (WTR::AccessibilityUIElement::documentEncoding):
1695         (WTR::AccessibilityUIElement::documentURI):
1696         (WTR::AccessibilityUIElement::isFocusable):
1697         (WTR::AccessibilityUIElement::isSelectable):
1698         (WTR::AccessibilityUIElement::isMultiSelectable):
1699         (WTR::AccessibilityUIElement::isVisible):
1700
1701 2013-05-20  Lucas Forschler  <lforschler@apple.com>
1702
1703     Rollout 150398.
1704     
1705 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1706
1707         [GTK] Fix concatenations of string literals that are not C++11-compliant
1708         https://bugs.webkit.org/show_bug.cgi?id=116449
1709
1710         Reviewed by Martin Robinson.
1711
1712         Fix the problematic concatenations of string literals so they are compilable under the C++11 standard. This
1713         is simply a matter of separating the string and the string literal that are being concatenated with a space.
1714
1715         * ImageDiff/gtk/ImageDiff.cpp:
1716         (printImage):
1717
1718 2013-05-20  Zan Dobersek  <zdobersek@igalia.com>
1719
1720         [GTK] Pass GTEST_HAS_RTTI=0 cppflag to TestWebKitAPI programs at compilation-time
1721         https://bugs.webkit.org/show_bug.cgi?id=116450
1722
1723         Reviewed by Martin Robinson.
1724
1725         The -fno-rtti flag is used when compiling C++ source code throughout the project. The TestWebKitAPI
1726         programs fail to compile because of this when using the C++11 standard as the GTest headers assume by
1727         default that the RTTI support is available. This can be turned off by passing GTEST_HAS_RTTI=0 to the
1728         TestWebKitAPI programs when compiling them.
1729
1730         * TestWebKitAPI/GNUmakefile.am:
1731
1732 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1733
1734         Remove DriverProxy._running_drivers from webkitpy.layout_tests.port
1735         https://bugs.webkit.org/show_bug.cgi?id=116492
1736
1737         Reviewed by Dirk Pranke.
1738
1739         Merge https://chromium.googlesource.com/chromium/blink/+/1af2f0be5a1746784ff114952f29f7b8fa9895f3.
1740
1741         The DriverProxy class had the concept of keeping a pool of started DRTs around (indexed by command line)
1742         so that we didn't necessarily need to restart DRT when the command line for a test changed (e.g., when
1743         starting to run tests in a virtual suite). However, the pool was per-worker (so not shared across the machine)
1744         and we didn't cap the number of processes started, so we would end up with a whole bunch of DRTs (3x-4x
1745         the number of workers started). If anything, this seemed to make the tests slightly slower and probably added
1746         to memory pressure on the machine.
1747
1748         This change removes the pool code; now we'll simply restart DRT when the command line changes. With this change,
1749         we can actually fold the restarting code into Driver itself (and get rid of DriverProxy), but I'll leave that
1750         for a subsequent patch just to make things easier to follow.
1751
1752         * Scripts/webkitpy/port/driver.py:
1753         (DriverProxy.__init__):
1754         (DriverProxy.run_test):
1755         (DriverProxy.has_crashed):
1756         (DriverProxy.stop):
1757
1758 2013-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1759
1760         Change EFL Linux 64-bit Release with EFL Linux 64-bit Release WK1
1761         https://bugs.webkit.org/show_bug.cgi?id=116423
1762
1763         Reviewed by Ryosuke Niwa.
1764
1765         EFL Linux 64-bit Release starts to support WK1's build and layout test from now on.
1766
1767         * BuildSlaveSupport/build.webkit.org-config/config.json:
1768
1769 2013-05-20  Seokju Kwon  <seokju.kwon@gmail.com>
1770
1771         Remove remaining link-prerender code
1772         https://bugs.webkit.org/show_bug.cgi?id=116429
1773
1774         Reviewed by Darin Adler.
1775
1776         Link prerendering code was removed in r150356.
1777
1778         * Scripts/webkitperl/FeatureList.pm:
1779         * qmake/mkspecs/features/features.pri:
1780
1781 2013-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1782
1783         commit-queue should check for oops in changelog entries
1784         https://bugs.webkit.org/show_bug.cgi?id=116395
1785
1786         Reviewed by Martin Robinson.
1787
1788         Make changelog validation fail when it contains oops!.
1789
1790         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1791         (CommitQueueTask._validate_changelog):
1792         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1793         (CommitQueueTaskTest._run_through_task):
1794         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1795         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1796         (ValidateChangeLogs.options):
1797         (ValidateChangeLogs._check_changelog_diff):
1798         (ValidateChangeLogs._changelog_contains_oops):
1799         (ValidateChangeLogs.run):
1800         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1801         (ValidateChangeLogsTest._assert_start_line_produces_output):
1802         (ValidateChangeLogsTest.test_check_changelog_diff):
1803         (ValidateChangeLogsTest):
1804         (ValidateChangeLogsTest.test_changelog_contains_oops):
1805
1806 2013-05-20  Jessie Berlin  <jberlin@apple.com>
1807
1808         Expose a way to know when forms are added to a page or when form controls are added to a form
1809         in the injected bundle
1810         https://bugs.webkit.org/show_bug.cgi?id=116334
1811
1812         Reviewed by Alexey Proskuryakov.
1813
1814         Add tests for the new callbacks.
1815
1816         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1817         Add DidAssociateFormControls/_Bundle.cpp and associate-form-controls.html
1818
1819         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp: Added.
1820         (TestWebKitAPI::nullJavaScriptCallback):
1821         A "null" callback to handle the fact that WKPageRunJavaScriptInMainFrame cannot handle null
1822         being passed in for the callback.
1823         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1824         After receiving the message that didAssociateFormControls callback was invoked from adding
1825         the form in the onload handler, tell the page to add a password field to the form, which
1826         should also invoke didAssociateFormControls callback.
1827         (TestWebKitAPI::setInjectedBundleClient):
1828         Register to receive messages.
1829         (TestWebKitAPI::TEST):
1830         Load associate-form-controls.html and wait until the didAssociateFormControls callback has
1831         been invoked for both adding the form and for adding a password field to the form.
1832
1833         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp: Added.
1834         (TestWebKitAPI::shouldNotifyOnFormChanges):
1835         Return true so the didAssociateFormControls callback is invoked.
1836         (TestWebKitAPI::didAssociateFormControls):
1837         Tell the UI process.
1838         (TestWebKitAPI::DidAssociateFormControlsTest::DidAssociateFormControlsTest):
1839         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
1840         Register for the shouldNotifyOnFormChanges and didAssociateFormControls callbacks.
1841
1842         * TestWebKitAPI/Tests/WebKit2/associate-form-controls.html: Added.
1843         Add a form in response to the onload event. Add a button that will add the password field
1844         for manual testing.
1845
1846 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1847
1848         [EFL][JHBUILD] Make sure eet is built before evas
1849         https://bugs.webkit.org/show_bug.cgi?id=116440
1850
1851         Reviewed by Gyuyoung Kim.
1852
1853         Mark eet as a dependency of evas since evas requires eet to enable some of its
1854         functionality.
1855
1856         * efl/jhbuild.modules:
1857
1858 2013-05-20  Alex Christensen  <achristensen@apple.com>
1859
1860         WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
1861         https://bugs.webkit.org/show_bug.cgi?id=116125
1862
1863         Reviewed by Tim Horton.
1864
1865         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1866         (WTR::pathSuitableForTestResult):
1867         Changed string operations to match _drt_descriptionSuitableForTestResult.
1868         (WTR::dumpRequestDescriptionSuitableForTestResult):
1869         (WTR::dumpResponseDescriptionSuitableForTestResult):
1870         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1871         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1872         (WTR::InjectedBundlePage::willSendRequestForFrame):
1873         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1874         Pass the main frame's URL to pathSuitableForTestResult.
1875         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1876         Added WKBundlePageRef to willPerformClientRedirectForFrame.
1877
1878 2013-05-20  Dirk Pranke  <dpranke@chromium.org>
1879
1880         fix w3c test importer unit tests after r150324
1881         https://bugs.webkit.org/show_bug.cgi?id=116459
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         This patch fixes the unit tests to not actually call out to
1886         'hg' (by using a mock executive) and also changes the real
1887         directory we crawl from Source/WebCore/css to
1888         Tools/Scripts/webkitpy/w3c to run much more quickly. We should
1889         still change this to a mock filesystem, but that's a separate change.
1890
1891         * Scripts/webkitpy/w3c/test_importer.py:
1892         (main):
1893         (TestImporter.__init__):
1894         (TestImporter.load_changeset):
1895         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1896         (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
1897         (TestImporterTest.test_import_dir_with_no_tests):
1898
1899 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1900
1901         Unreviewed EFL build fix.
1902
1903         Fix linking errors due to undefined symbols on Ubuntu 13.04.
1904
1905         * DumpRenderTree/efl/CMakeLists.txt:
1906         * EWebLauncher/CMakeLists.txt:
1907         * MiniBrowser/efl/CMakeLists.txt:
1908
1909 2013-05-20  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1910
1911         [EFL] Reenabled INDEXED_DATABASE after r150344
1912         https://bugs.webkit.org/show_bug.cgi?id=116430
1913
1914         Reviewed by Gyuyoung Kim.
1915
1916         Reenable INDEXED_DATABASE flag for EFL port now that WebKit2
1917         build was fixed in r150344.
1918
1919         * Scripts/webkitperl/FeatureList.pm:
1920
1921 2013-05-19  Ryuan Choi  <ryuan.choi@samsung.com>
1922
1923         [EFL] init/shutdown should be paired in EWebLauncher
1924         https://bugs.webkit.org/show_bug.cgi?id=116427
1925
1926         Reviewed by Christophe Dumez.
1927
1928         Added ecore_file_shutdown() for cleanup of ecore_file.
1929         Removed edje_init and ecore_evas_init because it was in ewk_init().
1930
1931         * EWebLauncher/main.c:
1932         (main):
1933
1934 2013-05-19  Jinwoo Song  <jinwoo7.song@samsung.com>
1935
1936         [EFL] Add command line option to MiniBrowser to set user agent
1937         https://bugs.webkit.org/show_bug.cgi?id=116387
1938
1939         Reviewed by Christophe Dumez.
1940
1941         We need this option to compare the rendering differences according to different user agents.
1942
1943         * MiniBrowser/efl/main.c:
1944         (window_create):
1945         (elm_main):
1946
1947 2013-05-19  Zan Dobersek  <zdobersek@igalia.com>
1948
1949         Unreviewed, addressing test-webkitpy failures after r150317.
1950
1951         * Scripts/webkitpy/w3c/test_converter.py:
1952         (W3CTestConverter.read_webkit_prefixed_css_property_list): CssPropertyNames.in doesn't exist, but CSSPropertyNames.in does.
1953
1954 2013-05-18  Patrick Gansterer  <paroga@webkit.org>
1955
1956         [CMake] Replace *_LIBRARY_NAME with *_OUTPUT_NAME
1957         https://bugs.webkit.org/show_bug.cgi?id=114554
1958
1959         Reviewed by Gyuyoung Kim.
1960
1961         Using variables as target names is very uncommon in CMake.
1962         The usual way to specify the name of the resulting binary
1963         is to set the OUTPUT_NAME target property.
1964
1965         * DumpRenderTree/efl/CMakeLists.txt:
1966         * EWebLauncher/CMakeLists.txt:
1967         * ImageDiff/CMakeLists.txt:
1968         * MiniBrowser/efl/CMakeLists.txt:
1969         * TestWebKitAPI/CMakeLists.txt:
1970         * WebKitTestRunner/CMakeLists.txt:
1971         * WebKitTestRunner/PlatformEfl.cmake:
1972         * WinCELauncher/CMakeLists.txt:
1973
1974 2013-05-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1975
1976         Unreviewed EFL build fix.
1977
1978         Temporarily disabled INDEXED_DATABASE at compile-time as it breaks
1979         WK2 build after r150305.
1980
1981         * Scripts/webkitperl/FeatureList.pm:
1982
1983 2013-05-18  Alberto Garcia  <agarcia@igalia.com>
1984
1985         [GTK] Parallel build fails if gtk-doc is enabled
1986         https://bugs.webkit.org/show_bug.cgi?id=116227
1987
1988         Reviewed by Martin Robinson.
1989
1990         * GNUmakefile.am:
1991         Don't use the 'all' target to generate the documentation.
1992         The prerequisites of this target must be files that need to be
1993         built _before_ the actual compilation of WebKit starts. Since the
1994         documentation depends on WebKit being built first, this means in
1995         practice that the code will be built in parallel with the
1996         generation of its dependencies, potentially making the build fail.
1997
1998 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
1999
2000         Don't run hg.
2001
2002         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2003         (TestImporterTest):
2004
2005 2013-05-17  Dirk Pranke  <dpranke@chromium.org>
2006
2007         Create a script to import W3C tests
2008         https://bugs.webkit.org/show_bug.cgi?id=111513
2009
2010         Reviewed by Ryosuke Niwa.
2011
2012         This patch attempts to re-land the 'import-w3c-tests'
2013         script and accompanying modules.  The tests and code have
2014         been cleaned up so that we do not log anything to stdout/stderr
2015         while running the tests (thanks to outputcapture) and do not
2016         write into the source tree while running the tests, and much
2017         but not all of the code has been converted over to using the webkitpy
2018
2019         * Scripts/import-w3c-tests: Added.
2020         * Scripts/webkitpy/w3c/__init__.py: Added.
2021         * Scripts/webkitpy/w3c/test_converter.py: Added.
2022         (W3CTestConverter):
2023         (W3CTestConverter.__init__):
2024         (W3CTestConverter.path_from_webkit_root):
2025         (W3CTestConverter.read_webkit_prefixed_css_property_list):
2026         (W3CTestConverter.convert_for_webkit):
2027         (W3CTestConverter.convert_css):
2028         (W3CTestConverter.convert_html):
2029         (W3CTestConverter.convert_testharness_paths):
2030         (W3CTestConverter.convert_prefixed_properties):
2031         (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2032         (W3CTestConverter.replace_tag):
2033         * Scripts/webkitpy/w3c/test_converter_unittest.py: Added.
2034         (W3CTestConverterTest):
2035         (W3CTestConverterTest.fake_dir_path):
2036         (W3CTestConverterTest.test_read_prefixed_property_list):
2037         (W3CTestConverterTest.test_convert_for_webkit_nothing_to_convert):
2038         (test_convert_for_webkit_harness_only):
2039         (test_convert_for_webkit_properties_only):
2040         (test_convert_for_webkit_harness_and_properties):
2041         (test_convert_test_harness_paths):
2042         (test_convert_prefixed_properties):
2043         (verify_conversion_happened):
2044         (verify_no_conversion_happened):
2045         (verify_test_harness_paths):
2046         (verify_prefixed_properties):
2047         (generate_test_content):
2048         * Scripts/webkitpy/w3c/test_importer.py: Added.
2049         (main):
2050         (parse_args):
2051         (validate_import_directory):
2052         (TestImporter):
2053         (TestImporter.__init__):
2054         (TestImporter.path_from_webkit_root):
2055         (TestImporter.do_import):
2056         (TestImporter.load_changeset):
2057         (TestImporter.find_importable_tests):
2058         (TestImporter.import_tests):
2059         (TestImporter.setup_destination_directory):
2060         (TestImporter.update_test_status):
2061         (TestImporter.remove_deleted_files):
2062         (TestImporter.write_import_log):
2063         * Scripts/webkitpy/w3c/test_importer_unittest.py: Added.
2064         (TestImporterTest):
2065         (TestImporterTest.test_import_dir_with_no_tests):
2066         * Scripts/webkitpy/w3c/test_parser.py: Added.
2067         (TestParser):
2068         (TestParser.__init__):
2069         (TestParser.load_file):
2070         (TestParser.analyze_test):
2071         (TestParser.reference_links_of_type):
2072         (TestParser.is_jstest):
2073         (TestParser.support_files):
2074         * Scripts/webkitpy/w3c/test_parser_unittest.py: Added.
2075         (TestParserTest):
2076         (TestParserTest.test_analyze_test_reftest_one_match):
2077         (test_analyze_test_reftest_multiple_matches):
2078         (test_analyze_test_reftest_match_and_mismatch):
2079         (test_analyze_test_reftest_with_ref_support_Files):
2080         (test_analyze_jstest):
2081         (test_analyze_pixel_test_all_true):
2082         (test_analyze_pixel_test_all_false):
2083         (test_analyze_non_html_file):
2084
2085 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2086
2087         Leaks builders exit early frequently
2088         https://bugs.webkit.org/show_bug.cgi?id=116355
2089
2090         Reviewed by Stephanie Lewis.
2091
2092         Throttle the number of processes to use, and also bump up the number of crashes/timeouts
2093         we tolerate from 20 to 50.
2094
2095         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2096         (RunWebKitTests.start):
2097         * Scripts/webkitpy/port/mac.py:
2098         (MacPort.default_child_processes):
2099
2100 2013-05-17  Peter Gal  <galpeter@inf.u-szeged.hu>
2101
2102         Remove chrome-channels command from the webkit-patch
2103         https://bugs.webkit.org/show_bug.cgi?id=116303
2104
2105         Reviewed by Ryosuke Niwa.
2106
2107         * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
2108         * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
2109         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
2110         * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
2111         * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
2112         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
2113
2114 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2115
2116         filter-build-webkit: Don't filter out the location of the missing symbol when linking fails
2117         Part 3 of 3: <http://webkit.org/b/116247>
2118
2119         Reviewed by Benjamin Poulain.
2120
2121         * Scripts/filter-build-webkit: Change while() loop to for() loop
2122         to track $previousLine, then pass $previousLine into
2123         shouldIgnoreLine().
2124         (shouldIgnoreLine): Add $previousLine argument. Do not skip a
2125         line that begins with four spaces if the previous line is a
2126         linker error message.
2127         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
2128         - Add "Ignored: " to test descriptions to document expected
2129           behavior.
2130         - Add comment blocks for various groups of tests.
2131         - Expand "Build settings" tests since we're changing the code in
2132           shouldIgnoreLine() that ignores those lines.
2133         - Add tests for undefined symbols error message.
2134         (description): Add.  Extract from global code.
2135
2136 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2137
2138         Add tests for shouldIgnoreLine() in filter-build-webkit
2139         Part 2 of 3: <http://webkit.org/b/116247>
2140
2141         Reviewed by Benjamin Poulain.
2142
2143         * Scripts/filter-build-webkit:
2144         (shouldIgnoreLine): Add.  Extract code from global scope into
2145         subroutine to make it testable.
2146         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
2147         Tests shouldIgnoreLine() using output from a real build
2148         transcript.
2149
2150 2013-05-17  Ryosuke Niwa  <rniwa@webkit.org>
2151
2152         Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org
2153         https://bugs.webkit.org/show_bug.cgi?id=116341
2154
2155         Reviewed by Brady Eidson.
2156
2157         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2158
2159 2013-05-17  Brent Fulgham  <bfulgham@apple.com>
2160
2161         [Windows] Don't use pdevenv when building with VS2010.
2162         https://bugs.webkit.org/show_bug.cgi?id=116338.
2163
2164         Reviewed by Adam Roben.
2165
2166         * Scripts/webkitdirs.pm:
2167         (setupCygwinEnv): Check if we are using VS2005, and only use
2168         the 'pdevenv' hack if we are. Otherwise, just build with
2169         our standard project since it uses VS2010+'s native
2170         parallel building features.
2171
2172 2013-05-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2173
2174         Unreviewed. Disable accelerated compositing until we figure out why it does not work
2175         properly in the 64 bits release bot.
2176
2177         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2178         (resetDefaultsToConsistentValues):
2179
2180 2013-05-17  David Kilzer  <ddkilzer@apple.com>
2181
2182         Make filter-build-webkit testable using LoadAsModule
2183         Part 1 of 3: <http://webkit.org/b/116247>
2184
2185         Reviewed by Benjamin Poulain.
2186
2187         * Scripts/filter-build-webkit: Change global variables that are
2188         used in subroutines from 'my' to 'our' to make it possible to
2189         evaluate the script in a package context in LoadAsModule.pm.
2190
2191 2013-05-14  Sam Weinig  <sam@webkit.org>
2192
2193         Add variants of the loading APIs that take user data and a way for the injected bundle to find out about them
2194         https://bugs.webkit.org/show_bug.cgi?id=116132
2195
2196         Reviewed by Anders Carlsson.
2197
2198         Adds "WithUserData" versions of all the load APIs and two new WKBundlePageLoaderClient functions,
2199         willLoadURLRequest and willLoadDataRequest to let the bundle access them.
2200
2201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2202         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Added.
2203         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp: Added.
2204         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2205
2206 2013-05-16  Seokju Kwon  <seokju.kwon@gmail.com>
2207
2208         [EFL] inspector-protocol/page/javascriptDialogEvents.html is failing
2209         https://bugs.webkit.org/show_bug.cgi?id=114781
2210
2211         Reviewed by Christophe Dumez.
2212
2213         Add run_before_unload_confirm and
2214         Print the log message with "CONFIRM NAVIGATION: " in console.
2215
2216         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2217         (onBeforeUnloadConfirm):
2218         (drtViewAdd):
2219
2220 2013-05-16  Peter Gal  <galpeter@inf.u-szeged.hu>
2221
2222         Fix Analyze ChangeLog's entry processing
2223         https://bugs.webkit.org/show_bug.cgi?id=116219
2224
2225         Reviewed by Ryosuke Niwa.
2226
2227         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
2228         (ChangeLogAnalyzer._analyze_entries): Fix the counter initialization.
2229
2230 2013-05-16  Hyungchan Kim  <hyungchan2.kim@lge.com>
2231
2232         [Qt] UrlLoader::loadNext is broken in MiniBrowser
2233         https://bugs.webkit.org/show_bug.cgi?id=116099
2234
2235         Reviewed by Jocelyn Turcotte.
2236
2237         QQuickWebView's 3 signals(loadStarted, loadSucceeded, loadFailed)
2238         are not available any more. So, UrlLoader::loadNext was broken
2239         because it failed to connect to those signals.
2240
2241         * MiniBrowser/qt/UrlLoader.cpp:
2242         (UrlLoader::UrlLoader):
2243         (UrlLoader::loadingChanged):
2244         * MiniBrowser/qt/UrlLoader.h:
2245         (UrlLoader):
2246
2247 2013-05-16  Lamarque V. Souza  <Lamarque.Souza@basyskom.com>
2248
2249         [WebSocket] Update pywebsocket to r760
2250         https://bugs.webkit.org/show_bug.cgi?id=115863
2251
2252         Reviewed by Alexey Proskuryakov.
2253
2254         Version r760 supports a newer draft of message compression.
2255         We need this update to finish the permessage compression patch in
2256         bug 98840. This patch also fixes failing unit tests after the update.
2257
2258         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py:
2259         (StreamBase._read):
2260         (StreamBase._read.of):
2261         (StreamBase._write):
2262         (StreamBase.receive_bytes):
2263         (StreamBase._read_until):
2264         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
2265         (parse_frame):
2266         (StreamOptions.__init__):
2267         (Stream.__init__):
2268         (Stream._receive_frame_as_frame_object):
2269         (Stream._get_message_from_frame):
2270         (Stream._process_close_message):
2271         (Stream.close_connection):
2272         (Stream.get_last_received_opcode):
2273         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
2274         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
2275         (Dispatcher.do_extra_handshake):
2276         (Dispatcher.transfer_data):
2277         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
2278         (ExtensionProcessorInterface.__init__):
2279         (ExtensionProcessorInterface.request):
2280         (ExtensionProcessorInterface):
2281         (ExtensionProcessorInterface.name):
2282         (ExtensionProcessorInterface.check_consistency_with_other_processors):
2283         (ExtensionProcessorInterface.set_active):
2284         (ExtensionProcessorInterface.is_active):
2285         (ExtensionProcessorInterface._get_extension_response_internal):
2286         (ExtensionProcessorInterface.get_extension_response):
2287         (ExtensionProcessorInterface._setup_stream_options_internal):
2288         (ExtensionProcessorInterface.setup_stream_options):
2289         (_log_outgoing_compression_ratio):
2290         (_log_incoming_compression_ratio):
2291         (_parse_window_bits):
2292         (_AverageRatioCalculator):
2293         (_AverageRatioCalculator.__init__):
2294         (_AverageRatioCalculator.add_original_bytes):
2295         (_AverageRatioCalculator.add_result_bytes):
2296         (_AverageRatioCalculator.get_average_ratio):
2297         (DeflateFrameExtensionProcessor):
2298         (DeflateFrameExtensionProcessor.__init__):
2299         (DeflateFrameExtensionProcessor._get_extension_response_internal):
2300         (DeflateFrameExtensionProcessor._setup_stream_options_internal):
2301         (DeflateFrameExtensionProcessor._outgoing_filter):
2302         (DeflateFrameExtensionProcessor._incoming_filter):
2303         (CompressionExtensionProcessorBase.for):
2304         (CompressionExtensionProcessorBase.__init__):
2305         (CompressionExtensionProcessorBase._get_extension_response_internal):
2306         (CompressionExtensionProcessorBase._setup_stream_options_internal):
2307         (PerFrameCompressExtensionProcessor):
2308         (PerMessageDeflateExtensionProcessor):
2309         (PerMessageDeflateExtensionProcessor.__init__):
2310         (PerMessageDeflateExtensionProcessor._get_extension_response_internal):
2311         (PerMessageDeflateExtensionProcessor._setup_stream_options_internal):
2312         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits):
2313         (PerMessageDeflateExtensionProcessor.set_c2s_max_window_bits.adds):
2314         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover):
2315         (PerMessageDeflateExtensionProcessor.set_c2s_no_context_takeover.adds):
2316         (PerMessageDeflateExtensionProcessor.set_bfinal):
2317         (PerMessageDeflateExtensionProcessor.enable_outgoing_compression):
2318         (PerMessageDeflateExtensionProcessor.disable_outgoing_compression):
2319         (_PerMessageDeflateFramer):
2320         (_PerMessageDeflateFramer.__init__):
2321         (_PerMessageDeflateFramer.set_compress_outgoing_enabled):
2322         (_PerMessageDeflateFramer._process_incoming_message):
2323         (_PerMessageDeflateFramer._process_outgoing_message):
2324         (_PerMessageDeflateFramer.setup_stream_options):
2325         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter):
2326         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.__init__):
2327         (_PerMessageDeflateFramer.setup_stream_options._OutgoingMessageFilter.filter):
2328         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter):
2329         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.__init__):
2330         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.decompress_next_message):
2331         (_PerMessageDeflateFramer.setup_stream_options._IncomingMessageFilter.filter):
2332         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter):
2333         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.__init__):
2334         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
2335         (_PerMessageDeflateFramer.setup_stream_options._OutgoingFrameFilter.filter):
2336         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter):
2337         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.__init__):
2338         (_PerMessageDeflateFramer.setup_stream_options._IncomingFrameFilter.filter):
2339         (PerMessageCompressExtensionProcessor):
2340         (PerMessageCompressExtensionProcessor._lookup_compression_processor):
2341         (MuxExtensionProcessor.__init__):
2342         (MuxExtensionProcessor.check_consistency_with_other_processors):
2343         (MuxExtensionProcessor):
2344         (MuxExtensionProcessor._get_extension_response_internal):
2345         (MuxExtensionProcessor._setup_stream_options_internal):
2346         (MuxExtensionProcessor.set_quota):
2347         (MuxExtensionProcessor.quota):
2348         (MuxExtensionProcessor.set_extensions):
2349         (MuxExtensionProcessor.extensions):
2350         (is_compression_extension):
2351         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
2352         (validate_subprotocol):
2353         (parse_host_header):
2354         (format_header):
2355         (check_request_line):
2356         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
2357         (Handshaker.do_handshake):
2358         (Handshaker._create_handshake_response):
2359         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py:
2360         (_validate_subprotocol):
2361         (_check_header_lines):
2362         (_build_location):
2363         (Handshaker.do_handshake):
2364         (Handshaker._set_subprotocol):
2365         (Handshaker._set_location):
2366         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
2367         (_create_dispatcher):
2368         (headerparserhandler):
2369         * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py:
2370         (_create_add_channel_response):
2371         (_create_drop_channel):
2372         (_create_flow_control):
2373         (_create_new_channel_slot):
2374         (_create_fallback_new_channel_slot):
2375         (_MuxFramePayloadParser._read_number):
2376         (_MuxFramePayloadParser._read_size_and_contents):
2377         (_MuxFramePayloadParser._read_flow_control):
2378         (_MuxFramePayloadParser._read_new_channel_slot):
2379         (_LogicalConnection.__init__):
2380         (_LogicalConnection.write):
2381         (_LogicalConnection.on_write_data_done):
2382         (_LogicalConnection):
2383         (_LogicalConnection.on_writer_done):
2384         (_InnerMessage):
2385         (_InnerMessage.__init__):
2386         (_InnerMessageBuilder):
2387         (_InnerMessageBuilder.that):
2388         (_InnerMessageBuilder.__init__):
2389         (_InnerMessageBuilder._handle_first):
2390         (_InnerMessageBuilder._process_first_fragmented_control):
2391         (_InnerMessageBuilder._process_first_fragmented_message):
2392         (_InnerMessageBuilder._handle_fragmented_control):
2393         (_InnerMessageBuilder._reassemble_fragmented_control):
2394         (_InnerMessageBuilder._handle_fragmented_message):
2395         (_InnerMessageBuilder._reassemble_fragmented_message):
2396         (_InnerMessageBuilder.build):
2397         (_LogicalStream.__init__):
2398         (_LogicalStream._create_inner_frame):
2399         (_LogicalStream._write_inner_frame):
2400         (_LogicalStream.replenish_send_quota):
2401         (_LogicalStream.send_message):
2402         (_LogicalStream._receive_frame):
2403         (_LogicalStream._get_message_from_frame):
2404         (_LogicalStream.stop_sending):
2405         (_PhysicalConnectionWriter.__init__):
2406         (_PhysicalConnectionWriter._write_data):
2407         (_PhysicalConnectionWriter.run):
2408         (_PhysicalConnectionWriter.stop):
2409         (_Worker.run):
2410         (_MuxHandshaker.__init__):
2411         (_MuxHandshaker._create_stream):
2412         (_MuxHandshaker._create_handshake_response):
2413         (_HandshakeDeltaBase.create_headers):
2414         (_MuxHandler.start):
2415         (_MuxHandler.wait_until_done):
2416         (_MuxHandler.notify_write_data_done):
2417         (_MuxHandler._process_drop_channel):
2418         (_MuxHandler._process_logical_frame):
2419         (_MuxHandler.notify_reader_done):
2420         (_MuxHandler):
2421         (_MuxHandler.notify_writer_done):
2422         (_MuxHandler.fail_physical_connection):
2423         (_MuxHandler.fail_logical_channel):
2424         (use_mux):
2425         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
2426         (_StandaloneRequest.get_uri):
2427         (_StandaloneRequest.get_unparsed_uri):
2428         (_StandaloneRequest):
2429         (_StandaloneRequest.is_https):
2430         (_import_ssl):
2431         (_import_pyopenssl):
2432         (_StandaloneSSLConnection.for):
2433         (_StandaloneSSLConnection):
2434         (_StandaloneSSLConnection.__getattribute__):
2435         (_StandaloneSSLConnection.__setattr__):
2436         (_StandaloneSSLConnection.makefile):
2437         (_StandaloneSSLConnection.shutdown):
2438         (_StandaloneSSLConnection.recv):
2439         (WebSocketServer.__init__):
2440         (WebSocketServer._create_sockets):
2441         (WebSocketServer.handle_error):
2442         (WebSocketServer.get_request):
2443         (WebSocketServer.get_request.default_callback):
2444         (WebSocketRequestHandler.parse_request):
2445         (_build_option_parser):
2446         (_main):
2447         (_main.if):
2448         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
2449         (RepeatedXorMasker.__init__):
2450         (RepeatedXorMasker._mask_using_swig):
2451         (RepeatedXorMasker):
2452         (RepeatedXorMasker._mask_using_array):
2453         (_Deflater.compress_and_finish):
2454         (_RFC1979Deflater.filter):
2455         (DeflateSocket.send):
2456
2457 2013-05-16  Jonathan Liu  <net147@gmail.com>
2458
2459         Fix testing if program exists in PATH
2460         https://bugs.webkit.org/show_bug.cgi?id=116216
2461
2462         Reviewed by Jocelyn Turcotte.
2463
2464         functions.prf incorrectly uses win_cmd_shell to test whether to
2465         add .exe to the executable name when checking if it exists in
2466         the PATH environment variable. This works correctly when
2467         building using Windows Command Prompt but not under MSYS shell.
2468
2469         To resolve this, check the win32 platform scope instead of
2470         win_cmd_shell so that it correctly adds .exe to the executable
2471         name on Windows regardless of the shell used when testing if
2472         it exists in PATH.
2473
2474         * qmake/mkspecs/features/functions.prf:
2475
2476 2013-05-16  Ryosuke Niwa  <rniwa@webkit.org>
2477
2478         Fix the hard-coded names of EWS bots that run tests.
2479
2480         * Scripts/webkitpy/tool/commands/queues.py:
2481         (CommitQueue.did_pass_testing_ews):
2482
2483 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2484
2485         [GTK] Build Xvfb with jhbuild
2486         https://bugs.webkit.org/show_bug.cgi?id=115907
2487
2488         Reviewed by Martin Robinson.
2489
2490         Build our own Xvfb so that we can avoid problems with the system Xvfb
2491         relying on symbols not present in our jhbuilt libraries such as pixman,
2492         and also to ensure we have the fix for a GLX module crasher.
2493
2494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2495         (resetDefaultsToConsistentValues): enable accelerated compositing.
2496         * gtk/install-dependencies: list packages required for building Xvfb.
2497         * gtk/jhbuild.modules: add xserver as a jhbuild module.
2498         * gtk/patches/xserver-remove-bogus-dependencies.patch: Added.
2499         * gtk/patches/xserver-fix-glx-init.patch: Added. Fixes a crash while
2500         initializing the GLX module for Xvfb.
2501
2502 2013-05-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2503
2504         [jhbuild] Should remove the sources directory as well when cleaning
2505         https://bugs.webkit.org/show_bug.cgi?id=116229
2506
2507         Reviewed by Martin Robinson.
2508
2509         * Scripts/update-webkit-libs-jhbuild:
2510         (cleanJhbuild): remove the Source directory as well when cleaning.
2511
2512 2013-05-15  Dominik Röttsches  <dominik.rottsches@intel.com>
2513
2514         [EFL] Remove Intel Wk2 Buildbots from Master
2515         https://bugs.webkit.org/show_bug.cgi?id=116149
2516
2517         Removing Intel maintained EFL Wk2 bots except the handle for efl-linux-slave-2
2518         since Gyuyoung Kim from Samsung plans to take over and maintain it.
2519
2520         Reviewed by Benjamin Poulain.
2521
2522         * BuildSlaveSupport/build.webkit.org-config/config.json:
2523
2524 2013-05-15  Brent Fulgham  <bfulgham@apple.com>
2525
2526         [Windows] Update various build tools to understand VS2010 environment.
2527         https://bugs.webkit.org/show_bug.cgi?id=116169.
2528
2529         Reviewed by Anders Carlsson.
2530
2531         * Scripts/build-api-tests: Identify VS2010 environment.
2532         * Scripts/build-dumprendertree: Ditto.
2533         * Scripts/build-webkit: Ditto.
2534         * Scripts/webkitdirs.pm:
2535         (dieIfWindowsPlatformSDKNotInstalled): Update to recognize a wider
2536         range of acceptable SDK's.
2537
2538 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2539
2540         Allow http tests on Arch Linux
2541         https://bugs.webkit.org/show_bug.cgi?id=116155
2542
2543         Reviewed by Ryosuke Niwa.
2544
2545         * Scripts/webkitpy/port/base.py:
2546         (Port._is_arch_based): Added check for /etc/arch-release file.
2547         (Port._apache_config_file_name_for_platform): Call the check.
2548         * Scripts/webkitpy/port/port_testcase.py:
2549         (test_linux_distro_detection): Testcase added.
2550
2551 2013-05-15  Peter Gal  <galpeter@inf.u-szeged.hu>
2552
2553         Remove a leftover v8 file from the watchlist
2554         https://bugs.webkit.org/show_bug.cgi?id=116158
2555
2556         Reviewed by Csaba Osztrogonác.
2557
2558         * Scripts/webkitpy/common/config/watchlist: Removed a v8 entry from the watchlist.
2559
2560 2013-05-15  Alberto Garcia  <agarcia@igalia.com>
2561
2562         [GTK] Fails to build while generating gtkdoc
2563         https://bugs.webkit.org/show_bug.cgi?id=115612
2564
2565         Reviewed by Philippe Normand.
2566
2567         Fix typo in the prerequisites of docs-build.stamp.
2568
2569         * GNUmakefile.am:
2570
2571 2013-05-15  Zan Dobersek  <zdobersek@igalia.com>
2572
2573         Unreviewed, fixing the current test-webkitpy failure.
2574
2575         * Scripts/webkitpy/port/mac_unittest.py:
2576         (test_setup_environ_for_server): Adjusting the expected DYLD_INSERT_LIBRARIES environment variable value
2577         in webkitpy.port.mac_unittest.test_setup_environ_for_server after r150089.
2578
2579 2013-05-14  Jaehun Lim  <ljaehun.lim@samsung.com>
2580
2581         Fix build after r150090.
2582         https://bugs.webkit.org/show_bug.cgi?id=116129
2583
2584         Unreviewed build fix after r150090.
2585
2586         * WebKitTestRunner/TestInvocation.cpp:
2587         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2588
2589 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2590
2591         [Windows, others] Unreviewed build fix after r150090.
2592
2593         * DumpRenderTree/TestRunner.cpp:
2594         (getSecureEventInputIsEnabledCallback): IsSecureEventInputEnabled
2595         doesn't exist on other platforms.
2596
2597 2013-05-14  Brent Fulgham  <bfulgham@webkit.org>
2598
2599         [Windows] Expunge pthreads2VC.dll from DumpRenderTree Project
2600         https://bugs.webkit.org/show_bug.cgi?id=115889
2601
2602         Reviewed by Benjamin Poulain.
2603
2604         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
2605         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2606
2607 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2608
2609         [Windows] Identify proper run environment for scripts.
2610         https://bugs.webkit.org/show_bug.cgi?id=116114
2611
2612         Reviewed by David Kilzer.
2613
2614         Determine (based on Visual Studio version) which path to use for
2615         executables (bin versus bin32).
2616
2617         * Scripts/webkitdirs.pm:
2618         (determineVisualStudioInstallDir): Added.
2619         (determineVisualStudioVersion): Added.
2620         (determineConfigurationProductDir): Modified to choose proper bin
2621         or bin32 directory.
2622         (visualStudioVersion): Added
2623         (setupCygwinEnv): Modified to use new determineVisualStudioInstallDir
2624
2625 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2626
2627         [Mac] Add tests for secure event input
2628         https://bugs.webkit.org/show_bug.cgi?id=116121
2629
2630         Reviewed by Mark Rowe.
2631
2632         * DumpRenderTree/TestRunner.cpp:
2633         (getSecureEventInputIsEnabledCallback):
2634         (TestRunner::staticValues):
2635         Expose an accessor for current secure event input state.
2636
2637         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2638         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2639         (WTR::TestRunner::secureEventInputIsEnabled):
2640         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2641         * WebKitTestRunner/TestInvocation.cpp:
2642         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2643         Expose an accessor for current secure event input state. This has to be done in
2644         UI process, as this is where it's changed by WebKit.
2645
2646 2013-05-14  Alexey Proskuryakov  <ap@apple.com>
2647
2648         [Mac] Add a testing shim for secure event input functions
2649         https://bugs.webkit.org/show_bug.cgi?id=116122
2650
2651         Reviewed by Mark Rowe.
2652
2653         * Scripts/webkitpy/port/mac.py: (MacPort.setup_environ_for_server):
2654         Inject WebCore testing shim library to override system framework functions.
2655
2656 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2657
2658         [Windows] Switch to embedded manifest commands for launcher executables.
2659         https://bugs.webkit.org/show_bug.cgi?id=116109
2660
2661         Reviewed by Darin Adler.
2662
2663         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Remove the
2664         now-unused WinLauncher.exe.manifest file.
2665         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2666         * win/DLLLauncher/DLLLauncherMain.cpp: Add embedded manifest command
2667         when building with VS2010 or newer.
2668
2669 2013-05-14  Brent Fulgham  <bfulgham@apple.com>
2670
2671         [Windows] Update ORWT to know about the Windows 8 SDK and Debug Tools.
2672         https://bugs.webkit.org/show_bug.cgi?id=116079
2673
2674         Reviewed by David Kilzer.
2675
2676         * Scripts/old-run-webkit-tests:
2677         (setUpWindowsCrashLogSaving): Locate ntsd.exe and use it.
2678
2679 2013-05-14  Zan Dobersek  <zdobersek@igalia.com>
2680
2681         [GTK] Move generated ColorData.cpp, WebKitFontFamilyNames.(cpp|h) build targets into libPlatform
2682         https://bugs.webkit.org/show_bug.cgi?id=115921
2683
2684         Reviewed by Gustavo Noronha Silva.
2685
2686         * GNUmakefile.am: Add platform_cppflags to the list of CPPFLAGS for libWebCoreInternals and DumpRenderTree.
2687         * TestWebKitAPI/GNUmakefile.am: Add platform_cppflags to the list of TestGtk CPPFLAGS.
2688
2689 2013-05-13  Alex Christensen  <achristensen@apple.com>
2690
2691         Added testRunner.setPrinting.
2692         https://bugs.webkit.org/show_bug.cgi?id=42693
2693         rdar://problem/8213845
2694
2695         Reviewed by Darin Adler.
2696
2697         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2698         Added setPrinting JavaScript function.
2699         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2700         (WTR::InjectedBundlePage::dump):
2701         Dump the external representation for printing if setPrinting has been called.
2702         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2703         (WTR::TestRunner::isPrinting): Added.
2704         (WTR::TestRunner::setPrinting): Added.
2705         Added and initialized m_isPrinting member boolean.
2706
2707 2013-05-13  Csaba Osztrogonác  <ossy@webkit.org>
2708
2709         [webkitpy] Make FileInfo.repository_name support SVN version > 1.6
2710         https://bugs.webkit.org/show_bug.cgi?id=116016
2711
2712         Reviewed by Dirk Pranke.
2713
2714         Same fix as in the upstream style checker, but without hg support.
2715         ( http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py )
2716
2717         * Scripts/webkitpy/style/checkers/cpp.py:
2718         (FileInfo.repository_name):
2719
2720 2013-05-13  Zan Dobersek  <zdobersek@igalia.com>
2721
2722         [GTK] Use WebCore layer archives for TestWebCore, WebKitPluginProcess
2723         https://bugs.webkit.org/show_bug.cgi?id=115918
2724
2725         Reviewed by Gustavo Noronha Silva.
2726
2727         Due to layer violations and circular dependencies the TestWebCores requires for the libraries containing
2728         the built code of the intertwining Platform and WebCore layers to be specified multiple times when linking.
2729         This can be avoided by packing the two layers' archives into one big archive, named after the WebCore layer
2730         due to no clear boundary between it and the Platform layer. The big archive can then be specified only once
2731         when linking, simplifying the code and suppressing all the layering violations so they do not cause build
2732         problems.
2733
2734         First the libtool libraries that the WebCore layer (as required by the TestWebCore) depends on are specified.
2735         These are then used as dependencies for the archive creation rule as well as the list from which the archive
2736         file paths are constructed and then used to dump the member files from these archives. The member files are
2737         then added to the big archive. The latter is added to the list of libraries the TestWebCore requires to
2738         successfully link.
2739
2740         * TestWebKitAPI/GNUmakefile.am:
2741
2742 2013-05-13  Anders Carlsson  <andersca@apple.com>
2743
2744         Remove UnusedParam.h
2745         https://bugs.webkit.org/show_bug.cgi?id=116029
2746
2747         Reviewed by Andreas Kling.
2748
2749         Stop including UnusedParam.h.
2750
2751         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2752         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2753
2754 2013-05-12  Commit Queue  <commit-queue@webkit.org>
2755
2756         Unreviewed, rolling out r149955.
2757         http://trac.webkit.org/changeset/149955
2758         https://bugs.webkit.org/show_bug.cgi?id=115990
2759
2760         Broke lots of tests (Requested by smfr on #webkit).
2761
2762         * Scripts/webkitpy/port/mac.py:
2763
2764 2013-05-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2765
2766         [GTK] Remove unnecessary GTK_CHECK_VERSION #ifdefs
2767         https://bugs.webkit.org/show_bug.cgi?id=115914
2768
2769         Reviewed by Martin Robinson.
2770
2771         * GtkLauncher/main.c:
2772         (createToolbar):
2773         * MiniBrowser/gtk/BrowserWindow.c:
2774         (_BrowserWindow):
2775         (browserWindowSetStatusText):
2776         (fullScreenMessageTimeoutCallback):
2777         (webViewEnterFullScreen):
2778         (webViewLeaveFullScreen):
2779         (browserWindowFinalize):
2780         (browserWindowConstructed):
2781         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2782         (WTR::EventSenderProxy::mouseScrollBy):
2783         (WTR::EventSenderProxy::continuousMouseScrollBy):
2784
2785 2013-05-11  Anders Carlsson  <andersca@apple.com>
2786
2787         Crash when terminating a process that has not been fully launched
2788         https://bugs.webkit.org/show_bug.cgi?id=115962
2789         <rdar://problem/13660916>
2790
2791         Reviewed by Andreas Kling.
2792
2793         Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
2794         before the process has had a chance to be fully launched.
2795
2796         * TestWebKitAPI/GNUmakefile.am:
2797         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2798         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
2799         (TestWebKitAPI):
2800         (TestWebKitAPI::didFinishLoadForFrame):
2801         (TestWebKitAPI::TEST):
2802         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
2803
2804 2013-05-10  Laszlo Gombos  <l.gombos@samsung.com>
2805
2806         Remove Mac OS X Leopard (10.5) support
2807         https://bugs.webkit.org/show_bug.cgi?id=107964
2808
2809         Reviewed by Ryosuke Niwa.
2810
2811         Removed the code for 10.5 and removed if-def for 10.6.
2812
2813         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2814         (convertMIMEType):
2815         (createXMLStringFromWebArchiveData):
2816         * DumpRenderTree/mac/TestRunnerMac.mm:
2817         (TestRunner::authenticateSession):
2818         (TestRunner::setTextDirection):
2819         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
2820         (convertMIMEType):
2821         (createXMLStringFromWebArchiveData):
2822
2823 2013-05-10  Brent Fulgham  <bfulgham@apple.com>
2824
2825         [Windows] Allow VS2010 Build to use VS2005 Support Libraries
2826         https://bugs.webkit.org/show_bug.cgi?id=115935
2827
2828         Reviewed by Jer Noble.
2829
2830         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
2831         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
2832         to the new manifest file.
2833         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
2834
2835 2013-05-10  Jacky Jiang  <zhajiang@blackberry.com>
2836
2837         Fix some compiler warnings (miscellaneous)
2838         https://bugs.webkit.org/show_bug.cgi?id=80790
2839
2840         Reviewed by Rob Buis.
2841
2842         Fix the following warnings for BlackBerry:
2843         DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
2844         used as truth value [-Wparentheses].
2845
2846         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2847         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2848
2849 2013-05-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2850
2851         [WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
2852         https://bugs.webkit.org/show_bug.cgi?id=115928
2853
2854         Reviewed by Kenneth Rohde Christiansen.
2855
2856         WKViewSetThemePath was moved to WKViewEfl.h.
2857
2858         * TestWebKitAPI/efl/PlatformWebView.cpp:
2859
2860 2013-05-10  Andreas Kling  <akling@apple.com>
2861
2862         I accidentally the Java testing.
2863
2864         * Scripts/webkitpy/port/mac.py:
2865
2866 2013-05-10  Brian Holt  <brian.holt@samsung.com>
2867
2868         [GTK] Module Cairo fails to build under jhbuild
2869         https://bugs.webkit.org/show_bug.cgi?id=115854
2870
2871         Reviewed by Martin Robinson.
2872
2873         Make cairo depend on glib in jhbuild.modules.
2874
2875         * gtk/jhbuild.modules:
2876
2877 2013-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
2878
2879         [GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
2880         https://bugs.webkit.org/show_bug.cgi?id=115904
2881
2882         Reviewed by Martin Robinson.
2883
2884         * ImageDiff/gtk/ImageDiff.cpp:
2885         (main):
2886
2887 2013-05-10  Balazs Kelemen  <kbalazs@webkit.org>
2888
2889         Add my new address to contributors.json. (Unreviewed)
2890
2891         * Scripts/webkitpy/common/config/contributors.json:
2892
2893 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2894
2895         Unreviewed. Move myself to the reviewers list.
2896
2897         * Scripts/webkitpy/common/config/contributors.json:
2898
2899 2013-05-10  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2900
2901         Unreviewed. Add my email to a few watchlists.
2902
2903         * Scripts/webkitpy/common/config/watchlist:
2904
2905 2013-05-10  Simon Pena  <simon.pena@samsung.com>
2906
2907         Unicode support missing from string representation of Contributors in committers.py
2908         https://bugs.webkit.org/show_bug.cgi?id=115859
2909
2910         Reviewed by Darin Adler.
2911
2912         Contributors, in committers.py, provided a string representation in __str__ which
2913         didn't support unicode characters, so printing a contributor would fail in that case.
2914         This patch implements __unicode__ and makes __str__ use it to represent a contributor.
2915         The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
2916
2917         * Scripts/webkitpy/common/config/committers.py: Move the existing string representation
2918         to the newly implemented method __unicode__, and make __str__ display its utf-8 encoded
2919         representation.
2920         (Contributor.__str__):
2921         (Contributor):
2922         (Contributor.__unicode__):
2923         * Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
2924         a contributor with unicode characters can be represented as a string.
2925         (CommittersTest):
2926         (CommittersTest.test_contributor_encoding):
2927
2928 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
2929
2930         [WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
2931         https://bugs.webkit.org/show_bug.cgi?id=92371
2932
2933         Reviewed by Brent Fulgham.
2934
2935         Use JavaScriptThreading.cpp where the same functionality is
2936         implemented too. This reduces the dependency on the pthread
2937         library. Also replace assert() with WebKit ASSERT().
2938
2939         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2940         * DumpRenderTree/win/DumpRenderTree.cpp:
2941         (dumpHistoryItem):
2942         (dumpBackForwardList):
2943         * DumpRenderTree/win/DumpRenderTree.vcproj:
2944
2945 2013-05-09  Patrick Gansterer  <paroga@webkit.org>
2946
2947         [DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
2948         https://bugs.webkit.org/show_bug.cgi?id=92505
2949
2950         Reviewed by Brent Fulgham.
2951
2952         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2953         * DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
2954         (javaScriptThreadsMutex):
2955         (javaScriptThreads):
2956         (runJavaScriptThread):
2957         (startJavaScriptThreads):
2958         (stopJavaScriptThreads):
2959         * DumpRenderTree/pthreads: Removed.
2960         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
2961
2962 2013-05-09  Mario Sanchez Prada  <mario.prada@samsung.com>
2963
2964         Unreviewed. Update Simon Pena email on his behalf.
2965
2966         * Scripts/webkitpy/common/config/contributors.json:
2967
2968 2013-05-09  Christophe Dumez  <ch.dumez@sisa.samsung.com>
2969
2970         Add support for [NoInterfaceObject] Web IDL extended attribute
2971         https://bugs.webkit.org/show_bug.cgi?id=115714
2972
2973         Reviewed by Kentaro Hara.
2974
2975         Update BindingsTests.generate_supplemental_dependency() to pass an
2976         additional windowConstructorsFile argument to preprocess-idls.pl.
2977
2978         * Scripts/webkitpy/bindings/main.py:
2979         (BindingsTests.generate_supplemental_dependency):
2980         (BindingsTests.main):
2981
2982 2013-05-09  ChangSeok Oh  <changseok.oh@collabora.com>
2983
2984         [GTK][AC] Buildfix after r149694
2985         https://bugs.webkit.org/show_bug.cgi?id=115797
2986
2987         Reviewed by Gustavo Noronha Silva.
2988
2989         Add CLUTTER_LIBS for linking TestWebCore.
2990
2991         * TestWebKitAPI/GNUmakefile.am:
2992
2993 2013-05-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2994
2995         [EFL] Remove unnecessary pkgs in EFL jhbuild
2996         https://bugs.webkit.org/show_bug.cgi?id=114908
2997
2998         Reviewed by Laszlo Gombos.
2999
3000         p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
3001         handle them using jhbuild. We can reduce build time when using --update-efl.
3002
3003         * efl/jhbuild.modules:
3004
3005 2013-05-08  Seokju Kwon  <seokju.kwon@gmail.com>
3006
3007         [EFL] Disable SHADOW DOM feature in FeatureList.pm
3008         https://bugs.webkit.org/show_bug.cgi?id=115834
3009
3010         Reviewed by Gyuyoung Kim.
3011
3012         * Scripts/webkitperl/FeatureList.pm:
3013
3014 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3015
3016         Add Scheduler for Mac MtnLion 32bit Release builder.
3017         
3018         Unreviewed.
3019         
3020         * BuildSlaveSupport/build.webkit.org-config/config.json:
3021
3022 2013-05-08  Denis Nomiyama  <d.nomiyama@samsung.com>
3023
3024         Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
3025         https://bugs.webkit.org/show_bug.cgi?id=115808
3026
3027         Reviewed by Darin Adler.
3028
3029         The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
3030         was left outdated after r127191, when the m_string member was changed
3031         from UString to String. This patch calls the right pretty printer for it.
3032
3033         * gdb/webkit.py:
3034         (JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
3035         WTFImplPrettyPrinter.
3036
3037 2013-05-08  Andy Estes  <aestes@apple.com>
3038
3039         [WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
3040         https://bugs.webkit.org/show_bug.cgi?id=115790
3041
3042         Reviewed by Alexey Proskuryakov.
3043
3044         Added two API tests:
3045
3046         1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
3047         2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
3048
3049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3050         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
3051         (TestWebKitAPI):
3052         (TestWebKitAPI::TEST):
3053         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
3054         (TestWebKitAPI):
3055         (TestWebKitAPI::decidePolicyForNavigationAction):
3056         (CustomProtocolInvalidSchemeTest):
3057         (TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
3058
3059 2013-05-08  Lucas Forschler  <lforschler@apple.com>
3060
3061         Teach buildbot how to compile 32-bit on Mac.
3062
3063         Reviewed by Ryosuke Niwa.
3064
3065         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3066         (CompileWebKit.start):
3067         (ExtractTestResultsAndLeaks):
3068
3069 2013-05-08  Eli Fidler  <efidler@blackberry.com>
3070
3071         [BlackBerry] Fix usage of BlackBerry::Platform::String
3072         https://bugs.webkit.org/show_bug.cgi?id=115781
3073
3074         Reviewed by Rob Buis.
3075
3076         BlackBerry PRs 304193 and 327181
3077         Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
3078
3079         We currently have a problem where we're passing UTF-8 encoded data into
3080         the char* constructors of BlackBerry::Platform::String. This means the string
3081         thinks its data is not UTF-8.
3082
3083         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3084         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3085         (BlackBerry::WebKit::dumpHistoryItem):
3086         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3087         (TestRunner::setUserStyleSheetLocation):
3088         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
3089         (LoadHTMLStringItem::invoke):
3090
3091 2013-05-08  Alberto Garcia  <agarcia@igalia.com>
3092
3093         Tools: add new BlackBerry include dirs.
3094         https://bugs.webkit.org/show_bug.cgi?id=115514
3095
3096         Reviewed by Rob Buis.
3097
3098         iType include dirs are missing, and HarfBuzz needs to be fixed.
3099
3100         * Scripts/webkitdirs.pm:
3101         (blackberryCMakeArguments):
3102
3103 2013-05-08  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
3104
3105         [GTK] Plumb the Automake build system for the Battery Status API feature
3106         https://bugs.webkit.org/show_bug.cgi?id=115718
3107
3108         Reviewed by Martin Robinson.
3109
3110         * Scripts/webkitdirs.pm:
3111         (buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
3112         through the --(enable|disable)-battery-status flag passed to configure.
3113
3114 2013-05-08  Ryosuke Niwa  <rniwa@webkit.org>
3115
3116         new-run-webkit-websocketserver doesn't work after Chromium removal
3117         https://bugs.webkit.org/show_bug.cgi?id=115816
3118
3119         Reviewed by Joseph Pecoraro.
3120
3121         Fix the bug by instantiating the correct port object.
3122
3123         * Scripts/new-run-webkit-websocketserver:
3124         (main):
3125
3126 2013-05-07  Lucas Forschler  <lforschler@apple.com>
3127
3128         Configure buildbot for 32bit builder.
3129         https://bugs.webkit.org/show_bug.cgi?id=115769
3130         
3131         Reviewed by Ryosuke Niwa.
3132
3133         * BuildSlaveSupport/build.webkit.org-config/config.json:
3134
3135 2013-05-08  Brent Fulgham  <bfulgham@webkit.org>
3136
3137         Unreviewed. Update to show my apple.com address.
3138
3139         * Scripts/webkitpy/common/config/contributors.json: Added
3140         my apple.com e-mail address.
3141
3142 2013-05-08  David Kilzer  <ddkilzer@apple.com>
3143
3144         BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
3145
3146         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3147         (concatenateAttributeAndValue): Switch to appendVector().
3148
3149 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3150
3151         [Qt][WTR] Fix the build on Mac after r149692
3152
3153         Unreviewed build fix.
3154
3155         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3156         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3157
3158 2013-05-08  Mario Sanchez Prada  <mario.prada@samsung.com>
3159
3160         Unreviewed. Added Anton Obzhirov to the list of contributors and myself
3161         to the watchlist for Accessibility.
3162
3163         * Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
3164         * Scripts/webkitpy/common/config/watchlist: Added myself.
3165
3166 2013-05-08  Andras Becsi  <andras.becsi@digia.com>
3167
3168         [Qt] Build fails with clang
3169         https://bugs.webkit.org/show_bug.cgi?id=115741
3170
3171         Reviewed by Benjamin Poulain.
3172
3173         Since r149112 std::move is used in AtomicString for compilers that
3174         support rvalue references and this requires a standard library
3175         implementing c++11 move semantics.
3176         We only explicitely require c++11 for WebKit2, but since clang supports
3177         rvalue references the build of subtargets using AtomicString fails because
3178         of missing std::move.
3179         It is safe to add CONFIG += c++11 for the whole project when using clang
3180         since we explicitely disable c++11 for ANGLE that had probems with libc++.
3181
3182         * qmake/mkspecs/features/unix/default_pre.prf:
3183
3184 2013-05-08  Darin Adler  <darin@apple.com>
3185
3186         Fix one more place that needed to use adoptCF/NS
3187         https://bugs.webkit.org/show_bug.cgi?id=115778
3188
3189         Reviewed by Benjamin Poulain.
3190
3191         Not sure why I missed this code last time, but found a bit more code that needs
3192         to switch to the newer style adoptCF/NS.
3193
3194         * WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
3195         (convertWebResourceDataToString): Use adoptCF.
3196         (convertWebResourceResponseToDictionary): Ditto.
3197         (createXMLStringFromWebArchiveData): Ditto.
3198         * WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
3199         (createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
3200
3201 2013-05-08  Commit Queue  <commit-queue@webkit.org>
3202
3203         Unreviewed, rolling out r149271.
3204         http://trac.webkit.org/changeset/149271
3205         https://bugs.webkit.org/show_bug.cgi?id=115780
3206
3207         The mangled symbols are now enforced through LDFLAGS
3208         (Requested by zdobersek on #webkit).
3209
3210         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
3211
3212 2013-05-08  Zan Dobersek  <zdobersek@igalia.com>
3213
3214         [Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
3215         https://bugs.webkit.org/show_bug.cgi?id=115636
3216
3217         Reviewed by Ryosuke Niwa.
3218
3219         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3220         (showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
3221         through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
3222         while Chromium-specific, can't be removed just yet as there's more code that uses it.
3223
3224 2013-05-06  Darin Adler  <darin@apple.com>
3225
3226         Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
3227         https://bugs.webkit.org/show_bug.cgi?id=115657
3228
3229         Reviewed by Sam Weinig.
3230
3231         This is similar to my last set of changes, but covers code that I missed with
3232         global replace using the Safari Xcode workspace.
3233
3234         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3235         (convertWebResourceDataToString):
3236         (convertWebResourceResponseToDictionary):
3237         (createXMLStringFromWebArchiveData):
3238         * DumpRenderTree/cg/ImageDiffCG.cpp:
3239         (createImageFromStdin):
3240         (createDifferenceImage):
3241         (main):
3242         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3243         (printPNG):
3244         (dumpBitmap):
3245         * DumpRenderTree/cg/PixelDumpSupportCG.h:
3246         (BitmapContext::BitmapContext):
3247         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
3248         (-[MockWebNotificationProvider init]):
3249         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3250         (createBitmapContext):
3251         * DumpRenderTree/mac/TestRunnerMac.mm:
3252         (TestRunner::addDisallowedURL):
3253         (TestRunner::applicationCacheDiskUsageForOrigin):
3254         (TestRunner::localStorageDiskUsageForOrigin):
3255         (TestRunner::clearApplicationCacheForOrigin):
3256         (TestRunner::deleteLocalStorageForOrigin):
3257         (TestRunner::copyDecodedHostName):
3258         (TestRunner::copyEncodedHostName):
3259         (TestRunner::queueLoad):
3260         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
3261         (TestRunner::setMockGeolocationPositionUnavailableError):
3262         (TestRunner::setUserStyleSheetLocation):
3263         (TestRunner::setValueForUser):
3264         (TestRunner::overridePreference):
3265         (TestRunner::setPersistentUserStyleSheetLocation):
3266         (TestRunner::execCommand):
3267         (TestRunner::findString):
3268         (TestRunner::isCommandEnabled):
3269         (TestRunner::addOriginAccessWhitelistEntry):
3270         (TestRunner::removeOriginAccessWhitelistEntry):
3271         (TestRunner::addUserScript):
3272         (TestRunner::addUserStyleSheet):
3273         (TestRunner::evaluateInWebInspector):
3274         (TestRunner::evaluateScriptInIsolatedWorld):
3275         (TestRunner::apiTestNewWindowDataLoadBaseURL):
3276         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
3277         (TestRunner::authenticateSession):
3278         (TestRunner::grantWebNotificationPermission):
3279         (TestRunner::denyWebNotificationPermission):
3280         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3281         (createCFURLResponseFromResponseData):
3282         * DumpRenderTree/mac/WorkQueueItemMac.mm:
3283         (LoadItem::invoke):
3284         (LoadHTMLStringItem::invoke):
3285         (ScriptItem::invoke):
3286         * DumpRenderTree/win/DumpRenderTree.cpp:
3287         (substringFromIndex):
3288         (urlSuitableForTestResult):
3289         (lastPathComponent):
3290         (sharedCFURLCache):
3291         * DumpRenderTree/win/ImageDiffCairo.cpp:
3292         (createImageFromStdin):
3293         (main):
3294         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3295         (createBitmapContextFromWebView):
3296         * DumpRenderTree/win/TestRunnerWin.cpp:
3297         (TestRunner::setUserStyleSheetLocation):
3298         (TestRunner::setPersistentUserStyleSheetLocation):
3299         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3300         (TestWebKitAPI::TEST):
3301         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
3302         (TestWebKitAPI::TEST):
3303         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
3304         (TestWebKitAPI::TEST):
3305         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3306         (TestWebKitAPI::TEST):
3307         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
3308         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3309         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
3310         (TestWebKitAPI::createWindow):
3311         (TestWebKitAPI::TEST):
3312         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
3313         (TestWebKitAPI::TEST):
3314         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
3315         (TestWebKitAPI::AcceptsFirstMouse::runTest):
3316         * TestWebKitAPI/Tests/mac/AttributedString.mm:
3317         (TestWebKitAPI::TEST):
3318         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
3319         (TestWebKitAPI::TEST):
3320         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
3321         (TestWebKitAPI::TEST):
3322         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
3323         (TestWebKitAPI::TEST):
3324         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
3325         (TestWebKitAPI::TEST):
3326         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
3327         (TestWebKitAPI::TEST):
3328         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
3329         (TestWebKitAPI::TEST):
3330         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
3331         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
3332         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
3333         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
3334         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3335         (TestWebKitAPI::TEST):
3336         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3337         (TestWebKitAPI::TEST):
3338         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3339         (TestWebKitAPI::TEST):
3340         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
3341         (TestWebKitAPI::TEST):
3342         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3343         (TestWebKitAPI::TEST):
3344         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
3345         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
3346         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
3347         (TestWebKitAPI::TEST):
3348         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3349         (TestWebKitAPI::TEST):
3350         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3351         (TestWebKitAPI::TEST):
3352         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3353         (TestWebKitAPI::TEST):
3354         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
3355         (TestWebKitAPI::TEST):
3356         * TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
3357         (TestWebKitAPI::TEST):
3358         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3361         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3362         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
3363         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
3364         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
3365         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
3366         (WTR::testPathFromURL):
3367         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
3368         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3369         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3370         (WTR::createCGContextFromImage):
3371         (WTR::dumpBitmap):
3372         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3373         * WebKitTestRunner/mac/EventSenderProxy.mm:
3374         (WTR::EventSenderProxy::mouseScrollBy):
3375         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3376         (WTR::PlatformWebView::windowSnapshotImage):
3377         * WebKitTestRunner/win/TestControllerWin.cpp:
3378         (WTR::TestController::initializeTestPluginDirectory):
3379         Use adoptCF and adoptNS.
3380
3381 2013-05-07  Alex Christensen  <achristensen@apple.com>
3382
3383         Fix a memory leak introduced in r149692
3384         https://bugs.webkit.org/show_bug.cgi?id=115766
3385
3386         Reviewed by Mark Rowe.
3387
3388         In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any 
3389         matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
3390
3391         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3392         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3393         Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
3394
3395 2013-05-07  Darin Adler  <darin@apple.com>
3396
3397         [Win] Fix storage leak in Windows DumpRenderTree
3398         https://bugs.webkit.org/show_bug.cgi?id=115651
3399
3400         Reviewed by Sam Weinig.
3401
3402         * DumpRenderTree/win/DumpRenderTree.cpp:
3403         (lastPathComponent): Added a missing call to adoptCF.
3404
3405 2013-05-07  Alex Christensen  <achristensen@apple.com>
3406
3407         fixed a memory leak introduced by bug 42324 by using a RetainPtr
3408         https://bugs.webkit.org/show_bug.cgi?id=115760
3409
3410         Reviewed by Tim Horton.
3411
3412         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3413         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3414         fixed memory leak, added UNUSED_PARAM macros
3415
3416 2013-05-07  Alex Christensen  <achristensen@apple.com>
3417
3418         WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
3419         https://bugs.webkit.org/show_bug.cgi?id=42324
3420         <rdar://problem/8193633>
3421
3422         Reviewed by Tim Horton.
3423
3424         * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3425         Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
3426         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3427         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
3428         Added dumpDOMAsWebArchive code that is called when dumping.        
3429         (WTR::InjectedBundlePage::dump):
3430         Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
3431         * Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3432         (InjectedBundlePage):
3433         Added dumpDOMAsWebArchive declaration.
3434         * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
3435         (WTR::TestRunner::dumpDOMAsWebArchive):
3436         Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
3437         * Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3438         Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
3439         * Tools/WebKitTestRunner/cf: Added.
3440         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
3441         Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
3442         (convertMIMEType):
3443         (convertWebResourceDataToString):
3444         (normalizeHTTPResponseHeaderFields):
3445         (normalizeWebResourceURL):
3446         (convertWebResourceResponseToDictionary):
3447         (compareResourceURLs):
3448         (createXMLStringFromWebArchiveData):
3449         * Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
3450         Copied from Tools/DumpRenderTree/cf for used symbol declarations.
3451         * Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
3452         Copied from Tools/DumpRenderTree/mac for used functions.
3453         (createCFURLResponseFromResponseData):
3454         (supportedNonImageMIMETypes):
3455
3456 2013-05-07  Alex Christensen  <achristensen@apple.com>
3457
3458         Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
3459         https://bugs.webkit.org/show_bug.cgi?id=115745
3460
3461         Reviewed by Tim Horton.
3462
3463         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3464         (compareResourceURLs):
3465         Updated style.
3466
3467 2013-05-06  Ryosuke Niwa  <rniwa@webkit.org>
3468
3469         Add an 'isReadOnly' member to IDL parse tree structure
3470         https://bugs.webkit.org/show_bug.cgi?id=115704
3471
3472         Reviewed by Kentaro Hara.
3473
3474         Use newly added isReadOnly attribute.
3475
3476         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3477         (_generateHeaderFile):
3478         (_generateImplementationFile):
3479         (_staticValuesGetterImplementation):
3480
3481 2013-05-07  Anders Carlsson  <andersca@apple.com>
3482
3483         Remove AlwaysInline.h from WTF
3484         https://bugs.webkit.org/show_bug.cgi?id=115727
3485
3486         Reviewed by Brent Fulgham.
3487
3488         The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
3489         to keep AlwaysInline.h around anymore.
3490
3491         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3492         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3493
3494 2013-05-07  Andras Becsi  <andras.becsi@digia.com>
3495
3496         [Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
3497         https://bugs.webkit.org/show_bug.cgi?id=114808
3498
3499         Reviewed by Jocelyn Turcotte.
3500
3501         QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
3502         (https://codereview.qt-project.org/#change,54234)
3503
3504         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3505         (WTR::WrapperWindow::handleStatusChanged):
3506
3507 2013-05-06  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3508
3509         Unreviewed. Add my email to EFL and BindingsScripts watchlists.
3510
3511         * Scripts/webkitpy/common/config/watchlist:
3512
3513 2013-05-06  Kangil Han  <kangil.han@samsung.com>
3514
3515         [EFL][WK1][PerformanceTests] Adopt --no-timeout option implementation to DumpRenderTree
3516         https://bugs.webkit.org/show_bug.cgi?id=115645
3517
3518         Reviewed by Gyuyoung Kim.
3519
3520         To run performance tests in wk1, we need --no-timeout option implementation.
3521         So adopt it from gtk+ port.
3522
3523         * DumpRenderTree/efl/DumpRenderTree.cpp:
3524         (shouldSetWaitToDumpWatchdog):
3525         (parseCommandLineOptions):
3526         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
3527         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3528         (TestRunner::setWaitToDump):
3529
3530 2013-05-06  Commit Queue  <commit-queue@webkit.org>
3531
3532         Unreviewed, rolling out r149547.
3533         http://trac.webkit.org/changeset/149547
3534         https://bugs.webkit.org/show_bug.cgi?id=115682
3535
3536         Added unittests that fail on bots and spits out text into
3537         stdout (Requested by rniwa on #webkit).
3538
3539         * Scripts/import-w3c-tests: Removed.
3540         * Scripts/webkitpy/w3c/__init__.py: Removed.
3541         * Scripts/webkitpy/w3c/test_converter.py: Removed.
3542         * Scripts/webkitpy/w3c/test_converter_unittest.py: Removed.
3543         * Scripts/webkitpy/w3c/test_importer.py: Removed.
3544         * Scripts/webkitpy/w3c/test_importer_unittest.py: Removed.
3545         * Scripts/webkitpy/w3c/test_parser.py: Removed.
3546         * Scripts/webkitpy/w3c/test_parser_unittest.py: Removed.
3547
3548 2013-05-03  Gustavo Noronha Silva  <gns@gnome.org>
3549
3550         [jhbuild] bump jhbuild version to take advantage of new improvements
3551         https://bugs.webkit.org/show_bug.cgi?id=115558
3552
3553         Reviewed by Martin Robinson.
3554
3555         One of the important improvements is jhbuild no longer fetches git
3556         repositories if they are already at the expected revision, which should
3557         make the EWS bots more robust to git servers unavailability.
3558
3559         * jhbuild/jhbuild-wrapper: bump jhbuild to 496974221c3a8ac4fbbc3b0a577c71cac224130d.
3560
3561 2013-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
3562
3563         [GTK] Add webkit_uri_scheme_request_finish_error
3564         https://bugs.webkit.org/show_bug.cgi?id=94316
3565
3566         Reviewed by Anders Carlsson.
3567
3568         * MiniBrowser/gtk/main.c:
3569         (miniBrowserErrorQuark): Add function to create a global quark for
3570         MiniBrowser.
3571         (aboutURISchemeRequestCallback): Update MiniBrowser to use the new
3572         function webkit_uri_scheme_request_finish_error().
3573
3574 2013-05-06  Mike Lattanzio  <mlattanzio@blackberry.com>
3575
3576         [BlackBerry] Enable and Expose Text Autosizing through BlackBerry::WebKit::WebSettings
3577         https://bugs.webkit.org/show_bug.cgi?id=113808
3578
3579         Reviewed by Rob Buis.
3580
3581         Modify FeatureList.pm and set ENABLE_TEXT_AUTOSIZING to default
3582         to true for BlackBerry.
3583
3584         * Scripts/webkitperl/FeatureList.pm:
3585
3586 2013-05-06  Jessie Berlin  <jberlin@apple.com>
3587
3588         check-webkit-style should complain about a layering violation if platform-specific guards are
3589         used in WebCore outside of the platform directory
3590         https://bugs.webkit.org/show_bug.cgi?id=115567
3591
3592         Reviewed by Benjamin Poulain.
3593
3594         * Scripts/webkitpy/style/checkers/cpp.py:
3595         (check_for_webcore_platform_layering_violation):
3596         If the file is in WebCore but not in platform and contains #if PLATFORM(SOMETHING), emit an error.
3597         (process_line):
3598         Add the check_for_webcore_platform_layering_violation.
3599         (CppChecker):
3600         List the new check.
3601
3602         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3603         (CppStyleTest.test_webcore_platform_layering_violation):
3604         Add tests.
3605
3606 2013-05-06  David Kilzer  <ddkilzer@apple.com>
3607
3608         webkit-patch: fix 'upload' command with Bugzilla 4.2.5
3609         <http://webkit.org/b/115667>
3610
3611         Reviewed by Dirk Pranke.
3612
3613         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3614         (Bugzilla._check_create_bug_response): Update regex to work with
3615         Bugzilla 3.2.3 and 4.2.5.
3616         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3617         (test__check_create_bug_response): Add new test that covers both
3618         old and new <title> variations.
3619
3620 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3621
3622         [Flakiness Dashboard] Stop decoding SnowLeopard builder names into platforms
3623         https://bugs.webkit.org/show_bug.cgi?id=115661
3624
3625         Reviewed by Ryosuke Niwa.
3626
3627         The Apple Mac Snow Leopard builders are no long present so there's no need to try to decode such
3628         builders into the APPLE_MAC_SNOW_LEOPARD platforms. Instead, check for the Mountain Lion builders
3629         and decode their names into the APPLE_MAC_MOUNTAIN_LION platforms.
3630
3631         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3632         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3633
3634 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3635
3636         [Flakiness Dashboard] Remove everything Chromium from the builders.json-generating script
3637         https://bugs.webkit.org/show_bug.cgi?id=114603
3638
3639         Reviewed by Ryosuke Niwa.
3640
3641         * TestResultServer/generate_builders_json.py:
3642         (insert_builder_and_test_data): Only process the 'layout-tests' steps, but force the name that's used
3643         to represent these to be 'layout-test', for backwards compatibility.
3644         (main): Remove all the build.chromium.org masters.
3645         * TestResultServer/generate_builders_json_unittest.py: Clean up the Chromium-related test cases and update other ones.
3646         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3647         (GenerateBuildersJsonTest):
3648         (GenerateBuildersJsonTest.test_generate_json_data):
3649         * TestResultServer/static-dashboards/builders.jsonp: Updated after changes to the script, now only lists the
3650         test-running builders from the webkit.org master.
3651
3652 2013-05-06  Zan Dobersek  <zdobersek@igalia.com>
3653