Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
[WebKit-https.git] / Tools / ChangeLog
1 2017-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         Unreviewed, guard iOS 11-dependent UIPasteboardTests to be iOS 11+ only
4
5         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
6
7 2017-07-05  Matt Lewis  <jlewis3@apple.com>
8
9         Unreviewed, rolling out r219128.
10
11         Spoke with engineer who originally submitted, Patch for APi
12         test to follow.
13
14         Reverted changeset:
15
16         "Unreviewed, rolling out r219070."
17         https://bugs.webkit.org/show_bug.cgi?id=174082
18         http://trac.webkit.org/changeset/219128
19
20 2017-07-05  Matt Lewis  <jlewis3@apple.com>
21
22         Unreviewed, rolling out r219070.
23
24         This revision caused consistent failures of the API test
25         UIPasteboardTests.DoNotPastePlainTextAsURL on iOS.
26
27         Reverted changeset:
28
29         "Pasting single words copied to UIPasteboard inserts URLs in
30         editable areas"
31         https://bugs.webkit.org/show_bug.cgi?id=174082
32         http://trac.webkit.org/changeset/219070
33
34 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
35
36         Remove unused EFL logo from bot watcher dashboard
37         https://bugs.webkit.org/show_bug.cgi?id=174136
38
39         Reviewed by Alexey Proskuryakov.
40
41         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL.png: Removed.
42         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/EFL@2x.png: Removed.
43
44 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
45
46         [GTK] Add more GTK bots to dashboard
47         https://bugs.webkit.org/show_bug.cgi?id=174129
48
49         Reviewed by Carlos Alberto Lopez Perez.
50
51         We have a bunch of GTK bots that I never look at because they're not on the dashboard. Add
52         them.
53
54         This also changes the sort order to put WPE above GTK so that it's not buried under all the
55         less-essential GTK bots.
56
57         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
58         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
59         (WebKitBuildbot):
60
61 2017-07-04  Michael Catanzaro  <mcatanzaro@igalia.com>
62
63         [WPE] Add WPE to bot watcher dashboard
64         https://bugs.webkit.org/show_bug.cgi?id=174119
65
66         Reviewed by Alexey Proskuryakov.
67
68         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/CREDIT: Added.
69         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE.png: Added.
70         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WPE@2x.png: Added.
71         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
72         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
73         (WebKitBuildbot):
74         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
75         (table.queue-grid tr.platform.linux-wpe img.logo):
76
77 2017-07-03  Lucas Forschler  <lforschler@apple.com>
78
79         https://bugs.webkit.org/show_bug.cgi?id=174105
80         
81         Reviewed by Stephanie Lewis.
82
83         * BuildSlaveSupport/built-product-archive:
84         (main): Add a -minify parser option
85         (createZip): Pass along the optional Minify argument if requested
86         (minifySource): This will trim down archives, logic limited to Mac platform.
87
88 2017-07-03  Matt Rajca  <mrajca@apple.com>
89
90         Add/remove appropriate media element behavior restrictions when updateWebsitePolicies is called
91         https://bugs.webkit.org/show_bug.cgi?id=174103
92
93         Reviewed by Alex Christensen.
94
95         Added an API test.
96
97         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Expose a pause method.
98         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
99         (TEST): Added test.
100         * TestWebKitAPI/cocoa/TestWKWebView.h:
101         * TestWebKitAPI/cocoa/TestWKWebView.mm:
102         (-[TestWKWebView stringByEvaluatingJavaScript:]): Don't simulate a user gesture when invoking the script.
103
104 2017-07-03  Matt Lewis  <jlewis3@apple.com>
105
106         Unreviewed, rolling out r219103.
107
108         Caused multiple build failures.
109
110         Reverted changeset:
111
112         "Remove copy of ICU headers from WebKit"
113         https://bugs.webkit.org/show_bug.cgi?id=116407
114         http://trac.webkit.org/changeset/219103
115
116 2017-07-03  Myles C. Maxfield  <mmaxfield@apple.com>
117
118         Remove copy of ICU headers from WebKit
119         https://bugs.webkit.org/show_bug.cgi?id=116407
120
121         Reviewed by Alex Christensen.
122
123         Use WTF's copy of ICU headers.
124
125         * DumpRenderTree/mac/Configurations/Base.xcconfig:
126         * TestWebKitAPI/Configurations/Base.xcconfig:
127         * WebKitTestRunner/Configurations/Base.xcconfig:
128
129 2017-07-03  Brady Eidson  <beidson@apple.com>
130
131         Switch all WebKit API related to favicons from WebIconDatabase over to new WebCore::IconLoader mechanism.
132         https://bugs.webkit.org/show_bug.cgi?id=174073
133
134         Reviewed by Andy Estes.
135
136         * DumpRenderTree/mac/TestRunnerMac.mm:
137         (TestRunner::setIconDatabaseEnabled): Call new SPI for this setting instead of WebIconDatabase stuff.
138
139         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm:
140         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
141
142 2017-07-03  Matt Lewis  <jlewis3@apple.com>
143
144         Unreviewed, rolling out r219083.
145
146         The revision caused an API failure on all testing platforms.
147
148         Reverted changeset:
149
150         "[MediaStream] Protect request and web view during gUM client
151         callback"
152         https://bugs.webkit.org/show_bug.cgi?id=174096
153         http://trac.webkit.org/changeset/219083
154
155 2017-07-03  Jonathan Bedard  <jbedard@apple.com>
156
157         webkitpy: Properly number duplicated crashlogs
158         https://bugs.webkit.org/show_bug.cgi?id=172002
159
160         Reviewed by Aakash Jain.
161
162         * Scripts/webkitpy/common/system/crashlogs.py:
163         (CrashLogs._find_all_logs_darwin): Number multiple crash logs for a single process with
164         an increasing integer.
165         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
166         (CrashLogsTest.create_crash_logs_darwin): Create duplicated crashlog for testing.
167         (CrashLogsTest.test_find_all_log_darwin): Now 7 Darwin logs instead of 5.
168         (CrashLogsTest.test_duplicate_log_darwin): Test that duplicated logs are correctly numbered.
169
170 2017-07-03  Ryosuke Niwa  <rniwa@webkit.org>
171
172         WebContent processes crash when the network process crashes with pending connection requests
173         https://bugs.webkit.org/show_bug.cgi?id=174065
174         <rdar://problem/30359835>
175
176         Reviewed by Tim Horton.
177
178         Add a API to ensure UI process tries to relaunch a new network process when the network process
179         crashes with pending network connection requests.
180
181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
182         * TestWebKitAPI/Tests/WebKit2/NetworkProcessCrashWithPendingConnection.mm: Added.
183         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
184         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
185         (-[TestNavigationDelegate webViewWebContentProcessDidTerminate:]): Added.
186
187 2017-07-03  Eric Carlson  <eric.carlson@apple.com>
188
189         [MediaStream] Protect request and web view during gUM client callback
190         https://bugs.webkit.org/show_bug.cgi?id=174096
191         <rdar://problem/32833102>
192
193         Reviewed by Youenn Fablet.
194
195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
196         * TestWebKitAPI/Tests/WebKit2/GetUserMediaNavigation.mm: New test.
197
198 2017-07-03  Andy Estes  <aestes@apple.com>
199
200         [Xcode] Add an experimental setting to build with ccache
201         https://bugs.webkit.org/show_bug.cgi?id=173875
202
203         Reviewed by Tim Horton.
204
205         On systems that already have ccache(1) installed, this patch adds experimental support for
206         it to Xcode builds. It can be enabled with the WK_USE_CCACHE build setting.
207
208         When ccache is enabled, CC is overridden to invoke Tools/ccache/ccache-clang. This script
209         finds the "-isysroot" argument to determine the active SDK, uses xcrun(1) and the SDK to
210         find the toolchain from which to run clang, and then invokes ccache with the required
211         arguments.
212
213         ccache is invoked with CCACHE_SLOPPINESS="pch_defines,time_macros", which is required for
214         precompiled headers to work properly [1].
215
216         LDPLUSPLUS is overridden to invoke Tools/ccache/ccache-clang++. It behaves the same as
217         ccache-clang, except it tells ccache to execute clang++ instead of clang. This is important
218         during linking.
219         
220         [1] https://ccache.samba.org/manual.html#_precompiled_headers
221
222         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Included ccache.xcconfig.
223         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
224         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
225         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
226         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Ditto.
227         * ccache/README.md: Added.
228         * ccache/ccache-clang: Added.
229         * ccache/ccache-clang++: Added.
230         * ccache/ccache.xcconfig: Added. Overrides CC and LDPLUSPLUS when WK_USE_CACHE=YES.
231
232 2017-07-03  Alex Christensen  <achristensen@webkit.org>
233
234         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
235         https://bugs.webkit.org/show_bug.cgi?id=174051
236
237         Reviewed by Tim Horton.
238
239         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
240         (TestWebKitAPI::TEST_F):
241
242 2017-07-03  Matt Lewis  <jlewis3@apple.com>
243
244         Unreviewed, rolling out r219024.
245
246         This patch cause 3 didferent test to fail.
247
248         Reverted changeset:
249
250         "REGRESSION(r215096) Queries of URLs with non-special schemes
251         should not percent-encode single quotes"
252         https://bugs.webkit.org/show_bug.cgi?id=174051
253         http://trac.webkit.org/changeset/219024
254
255 2017-07-03  Chris Dumez  <cdumez@apple.com>
256
257         Drop ResourceLoadStatisticsStore's statisticsLock
258         https://bugs.webkit.org/show_bug.cgi?id=174080
259
260         Reviewed by Brent Fulgham.
261
262         Port WebKitTestRunner to new Asynchronous Cocoa SPI.
263
264         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
265         (WTR::TestController::isStatisticsPrevalentResource):
266         (WTR::TestController::isStatisticsHasHadUserInteraction):
267         (WTR::TestController::isStatisticsGrandfathered):
268
269 2017-07-03  Wenson Hsieh  <wenson_hsieh@apple.com>
270
271         Pasting single words copied to UIPasteboard inserts URLs in editable areas
272         https://bugs.webkit.org/show_bug.cgi?id=174082
273         <rdar://problem/33046992>
274
275         Reviewed by Tim Horton.
276
277         Adds 3 new unit tests to UIPasteboardTests to test cases of pasting plain text and URLs.
278
279         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
280         (TestWebKitAPI::setUpWebViewForPasteboardTests):
281         (TestWebKitAPI::TEST):
282
283 2017-07-02  Brady Eidson  <beidson@apple.com>
284
285         Add API test for all parts of WebKit1 API related to favicons.
286         https://bugs.webkit.org/show_bug.cgi?id=174069
287
288         Reviewed by Andy Estes.
289
290         These two API tests cover all WebKit1 API related to icons.
291         
292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
293         * TestWebKitAPI/Tests/mac/WebViewIconLoading.mm: Added.
294         (mainResourceData):
295         (defaultFaviconData):
296         (customFaviconData):
297         (imageFromData):
298         (+[IconLoadingProtocol canInitWithRequest:]):
299         (+[IconLoadingProtocol canonicalRequestForRequest:]):
300         (-[IconLoadingProtocol startLoading]):
301         (-[IconLoadingProtocol stopLoading]):
302         (-[IconLoadingFrameLoadDelegate webView:didReceiveIcon:forFrame:]):
303         (-[MainFrameIconKVO observeValueForKeyPath:ofObject:change:context:]):
304         (TestWebKitAPI::TEST):
305
306 2017-07-01  Dan Bernstein  <mitz@apple.com>
307
308         [iOS] Remove code only needed when building for iOS 9.x
309         https://bugs.webkit.org/show_bug.cgi?id=174068
310
311         Reviewed by Tim Horton.
312
313         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
314         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
315         (WTR::initializeWebViewConfiguration):
316         * WebKitTestRunner/ios/HIDEventGenerator.mm:
317         (-[HIDEventGenerator _createIOHIDEventType:]):
318
319 2017-07-01  Brady Eidson  <beidson@apple.com>
320
321         When setting a custom cookie storage location on a WKWebsiteDataStore, cookies aren't actually removed.
322         <rdar://problem/32410662> and https://bugs.webkit.org/show_bug.cgi?id=174035
323
324         Reviewed by Alex Christensen.
325
326         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
327
328 2017-07-01  Dan Bernstein  <mitz@apple.com>
329
330         [macOS] Remove code only needed when building for OS X Yosemite
331         https://bugs.webkit.org/show_bug.cgi?id=174067
332
333         Reviewed by Tim Horton.
334
335         * DumpRenderTree/mac/Configurations/Base.xcconfig:
336         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
337         * DumpRenderTree/mac/DumpRenderTree.mm:
338         (setDefaultsToConsistentValuesForTesting):
339         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
340         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
341         * MiniBrowser/Configurations/Base.xcconfig:
342         * MiniBrowser/Configurations/DebugRelease.xcconfig:
343         * TestWebKitAPI/Configurations/Base.xcconfig:
344         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
345         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
346         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
347         (TestWebKitAPI::TEST_F):
348         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
349         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:
350         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
351         (TestWebKitAPI::TEST_F):
352         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
353         (TestWebKitAPI::TEST):
354         * WebKitTestRunner/Configurations/Base.xcconfig:
355         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
356         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
357         (WTR::InjectedBundle::platformInitialize):
358         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
359         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
360
361 2017-07-01  Chris Dumez  <cdumez@apple.com>
362
363         Replace ResourceLoadStatisticsStore C API with Cocoa SPI
364         https://bugs.webkit.org/show_bug.cgi?id=174060
365
366         Reviewed by Brent Fulgham.
367
368         Port WebKitTestRunner over to the new Cocoa SPI.
369
370         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
371         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
372         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
373         Drop calls to the WKResourceLoadStatisticsStore C API here. Those were
374         no-ops since this code runs in the WebContent process, not the
375         UIProcess.
376
377         * WebKitTestRunner/TestController.cpp:
378         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
379
380 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
381
382         Unreviewed mac build fix.
383
384         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
385         (TestWebKitAPI::TEST):
386
387 2017-06-30  Megan Gardner  <megan_gardner@apple.com>
388
389         Add API to get WKActivatedElementInfo
390         https://bugs.webkit.org/show_bug.cgi?id=174001
391         <rdar://problem/29165518>
392         
393         Tests for now SPI to get activatedElementInfo.
394
395         Reviewed by Tim Horton.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm: Added.
399         (TestWebKitAPI::TEST):
400
401 2017-06-30  Chris Dumez  <cdumez@apple.com>
402
403         Move store logic from WebResourceLoadStatisticsManager to WebResourceLoadStatisticsStore
404         https://bugs.webkit.org/show_bug.cgi?id=174038
405
406         Reviewed by Brent Fulgham.
407
408         Fix typo in API name.
409
410         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
411         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
412         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
413         * WebKitTestRunner/InjectedBundle/TestRunner.h:
414         * WebKitTestRunner/TestController.cpp:
415         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
416         * WebKitTestRunner/TestController.h:
417         * WebKitTestRunner/TestInvocation.cpp:
418         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
419
420 2017-06-30  Alex Christensen  <achristensen@webkit.org>
421
422         REGRESSION(r215096) Queries of URLs with non-special schemes should not percent-encode single quotes
423         https://bugs.webkit.org/show_bug.cgi?id=174051
424         <rdar://problem/33002846>
425
426         Reviewed by Tim Horton.
427
428         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
429         (TestWebKitAPI::TEST_F):
430
431 2017-06-30  Daniel Bates  <dabates@apple.com>
432
433         API::FrameInfo should know the web page that contains the frame; add API property webView to WKFrameInfo
434         https://bugs.webkit.org/show_bug.cgi?id=165160
435         <rdar://problem/29451999>
436
437         Reviewed by Brady Eidson.
438
439         Add tests to ensure that -[WKFrameInfo webView] is computed correctly for the source and target frame
440         for navigations and window creation.
441
442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
443         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm: Added. Derived from file ShouldOpenExternalURLsInNewWindowActions.mm.
444         (-[DecidePolicyForNavigationActionController webView:decidePolicyForNavigationAction:decisionHandler:]):
445         (-[DecidePolicyForNavigationActionController webView:didFinishNavigation:]):
446         (-[DecidePolicyForNavigationActionController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
447         (TEST):
448
449 2017-06-29  Jer Noble  <jer.noble@apple.com>
450
451         Make Legacy EME API controlled by RuntimeEnabled setting.
452         https://bugs.webkit.org/show_bug.cgi?id=173994
453
454         Reviewed by Sam Weinig.
455
456         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
457
458 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
459
460         Follow-up fix for r218996
461
462         Unreviewed infrastructure fix.
463
464         Repeated calls to 'ios_version' make the log noisy, memoize the function.
465
466         * Scripts/webkitpy/port/ios_simulator.py:
467         (IOSSimulatorPort): Memoize ios_version().
468
469 2017-06-30  Wenson Hsieh  <wenson_hsieh@apple.com>
470
471         [iOS DnD] Drag caret rect is incorrectly computed when dropping in editable content in iframes
472         https://bugs.webkit.org/show_bug.cgi?id=174017
473         <rdar://problem/32959782>
474
475         Reviewed by Simon Fraser.
476
477         Add a new test verifying that the drag caret is visually contained within the bounds of an iframe. Before these
478         changes, the caret would appear outside of the iframe.
479
480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
481         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-in-iframe.html: Added.
482         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
483         (checkDragCaretRectIsContainedInRect):
484         (TestWebKitAPI::TEST):
485         * TestWebKitAPI/ios/DataInteractionSimulator.h:
486         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
487         (-[DataInteractionSimulator _resetSimulatedState]):
488         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
489         (-[DataInteractionSimulator _advanceProgress]):
490         (-[DataInteractionSimulator lastKnownDragCaretRect]):
491
492 2017-06-30  Jonathan Bedard  <jbedard@apple.com>
493
494         Add support for different versions of iOS when loading test expectations
495         https://bugs.webkit.org/show_bug.cgi?id=173774
496         <rdar://problem/32951132>
497
498         Rubber-stamped by Aakash Jain.
499
500         When running layout tests, we should support multiple version of iOS the same way we do Mac.
501
502         * Scripts/webkitpy/port/ios.py:
503         (IOSPort.default_baseline_search_path): Add ios-<major version> test expectation.
504         (IOSPort.test_expectations_file_position): Added new file expectations, increment expected file position.
505         (IOSPort.ios_version): iOS ports must define a function to retrieve the iOS version.
506         * Scripts/webkitpy/port/ios_device.py:
507         (IOSDevicePort.ios_version): Ask connected devices for implementation.
508         * Scripts/webkitpy/port/ios_device_unittest.py:
509         (IOSDeviceTest.test_additional_platform_directory): Skip test until bug 173775 is finished.
510         (IOSDeviceTest.test_baseline_searchpath): Ditto.
511         (IOSDeviceTest.test_expectations_ordering): Ditto.
512         * Scripts/webkitpy/port/ios_simulator.py:
513         (IOSSimulatorPort.ios_version): If a runtime is specified, ask the runtime for the iOS version. Otherwise,
514         ask the platform.
515
516 2017-06-30  Jacobo Aragunde Pérez  <jaragunde@igalia.com>
517
518         Fontconfig build breaks with glibc 2.15+
519         https://bugs.webkit.org/show_bug.cgi?id=174019
520
521         Reviewed by Carlos Alberto Lopez Perez.
522
523         Apply patch by Khem Raj adapted to fontconfig 2.11.1.
524
525         * wpe/jhbuild.modules:
526         * wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Added.
527
528 2017-06-29  Wenson Hsieh  <wenson_hsieh@apple.com>
529
530         [iOS DnD] Web content process crashes when the selection is moved far offscreen in dragstart
531         https://bugs.webkit.org/show_bug.cgi?id=174010
532         <rdar://problem/32597802>
533
534         Reviewed by Tim Horton.
535
536         Adds a new API test to ensure that we don't crash trying to dereference a null RefPtr when the TextIndicator
537         snapshot fails for any reason.
538
539         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
540         * TestWebKitAPI/Tests/WebKit2Cocoa/dragstart-change-selection-offscreen.html: Added.
541         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
542         (TestWebKitAPI::TEST):
543
544 2017-06-29  Chris Fleizach  <cfleizach@apple.com>
545
546         AX: Cannot call setValue() on contenteditable or ARIA text controls
547         https://bugs.webkit.org/show_bug.cgi?id=173520
548
549         Reviewed by Ryosuke Niwa.
550
551         Add setValue() method to WKTR (already existed in DRT).
552
553         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
554         (WTR::AccessibilityUIElement::setValue):
555         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
556         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
557         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
558         (WTR::AccessibilityUIElement::setValue):
559
560 2017-06-28  Simon Fraser  <simon.fraser@apple.com>
561
562         getBoundingClientRect returns wrong value for combination of page zoom and scroll
563         https://bugs.webkit.org/show_bug.cgi?id=173841
564         rdar://problem/32983841
565
566         Reviewed by Dean Jackson.
567
568         Make "Zoom In" and "Zoom Out" work correctly in the WebKit1 window. Previously they
569         always did text zooming.
570
571         * MiniBrowser/mac/WK1BrowserWindowController.m:
572         (-[WK1BrowserWindowController zoomIn:]):
573         (-[WK1BrowserWindowController zoomOut:]):
574         (-[WK1BrowserWindowController canResetZoom]):
575         (-[WK1BrowserWindowController resetZoom:]):
576
577 2017-06-29  John Wilander  <wilander@apple.com>
578
579         Fix for intermittent Layout Test fail http/tests/loading/resourceLoadStatistics/telemetry-generation.html
580         https://bugs.webkit.org/show_bug.cgi?id=173940
581         <rdar://problem/33018125>
582
583         Reviewed by Brent Fulgham.
584
585         This change allows the TestController to turn off
586         regular resource load statistics telemetry submission
587         and to manually control when telemetry is calculated
588         and submitted.
589
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::TestController::initialize):
592             Turns off automatic resource load statistics telemetry submission.
593
594 2017-06-29  Commit Queue  <commit-queue@webkit.org>
595
596         Unreviewed, rolling out r218512.
597         https://bugs.webkit.org/show_bug.cgi?id=173981
598
599         "It changes the behavior of the JS API's JSEvaluateScript
600         which breaks TurboTax" (Requested by saamyjoon on #webkit).
601
602         Reverted changeset:
603
604         "test262: Completion values for control flow do not match the
605         spec"
606         https://bugs.webkit.org/show_bug.cgi?id=171265
607         http://trac.webkit.org/changeset/218512
608
609 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
610
611         Add WebKitSystemInterface for iOS 11
612         https://bugs.webkit.org/show_bug.cgi?id=173936
613
614         Reviewed by Lucas Forschler.
615
616         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
617
618 2017-06-28  Keith Miller  <keith_miller@apple.com>
619
620         VMTraps has some races
621         https://bugs.webkit.org/show_bug.cgi?id=173941
622
623         Reviewed by Michael Saboff.
624
625         Add new testing mode for testing the Watchdog with our stress
626         tests.
627
628         * Scripts/run-jsc-stress-tests:
629
630 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
631
632         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
633         https://bugs.webkit.org/show_bug.cgi?id=173877
634
635         Reviewed by Brady Eidson.
636
637         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
638         the next tests.
639
640         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
641         (testGetFavicon):
642
643 2017-06-28  Tim Horton  <timothy_horton@apple.com>
644
645         MobileSafari was constantly using 10-15% CPU viewing a PDF
646         https://bugs.webkit.org/show_bug.cgi?id=173944
647         <rdar://problem/33039910>
648
649         Reviewed by Simon Fraser.
650
651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
652         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
653         Add a test that we ever call the stable presentation update callback
654         when we have a WKPDFView up, instead of infinitely looping.
655
656 2017-06-28  Alex Christensen  <achristensen@webkit.org>
657
658         Prevent displaying URLs with small capital letters
659         https://bugs.webkit.org/show_bug.cgi?id=173949
660         <rdar://problem/32952058>
661
662         Reviewed by Brent Fulgham.
663
664         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
665         (TestWebKitAPI::TEST):
666
667 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
668
669         Unreviewed test fix.
670
671         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
672
673         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
674
675 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
676
677         Teach ResourceLoadStatistics to recognize changes in the file system
678         https://bugs.webkit.org/show_bug.cgi?id=173800
679         <rdar://problem/32937842>
680
681         Reviewed by Chris Dumez.
682
683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
684         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
685         (TestWebKitAPI::FileMonitorTest::tempFilePath):
686         (TestWebKitAPI::handleFileModification):
687         (TestWebKitAPI::handleFileDeletion):
688         (TestWebKitAPI::resetTestState):
689         (TestWebKitAPI::TEST_F):
690
691 2017-06-28  Brady Eidson  <beidson@apple.com>
692
693         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
694         https://bugs.webkit.org/show_bug.cgi?id=173874
695
696         Reviewed by Alex Christensen.
697
698         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
699
700 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
701
702         Unreviewed, adding Don Olmstead to contributors.json
703
704         * Scripts/webkitpy/common/config/contributors.json:
705
706 2017-06-28  Alex Christensen  <achristensen@webkit.org>
707
708         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
709         https://bugs.webkit.org/show_bug.cgi?id=173886
710         <rdar://problem/32543191>
711
712         Reviewed by Andy Estes.
713
714         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
715         (ParsedRange::ParsedRange):
716         (-[TestSchemeHandler initWithVideoData:]):
717         (-[TestSchemeHandler webView:startURLSchemeTask:]):
718         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
719         (TEST):
720
721 2017-06-27  JF Bastien  <jfbastien@apple.com>
722
723         WebAssembly: running out of executable memory should throw OoM
724         https://bugs.webkit.org/show_bug.cgi?id=171537
725         <rdar://problem/32963338>
726
727         Reviewed by Saam Barati.
728
729         * Scripts/run-jsc-stress-tests: add a configuration which runs the
730         tests under limited executable memory and avoids non-WebAssembly
731         code generation so that we more reliably run out of executable
732         memory in WebAssembly.
733
734 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
735
736         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
737         https://bugs.webkit.org/show_bug.cgi?id=173854
738         <rdar://problem/32236827>
739
740         Reviewed by Ryosuke Niwa and Tim Horton.
741
742         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
743
744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
745         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
746         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
747         (TestWebKitAPI::TEST):
748
749 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
750
751         [PAL] Add symbol export macros for PAL
752         https://bugs.webkit.org/show_bug.cgi?id=171519
753
754         Reviewed by Konstantin Tokarev.
755
756         * DumpRenderTree/config.h:
757         * TestWebKitAPI/CMakeLists.txt:
758         * TestWebKitAPI/config.h:
759         * WebKitTestRunner/config.h:
760
761 2017-06-27  John Wilander  <wilander@apple.com>
762
763         Resource Load Statistics: Add telemetry
764         https://bugs.webkit.org/show_bug.cgi?id=173499
765         <rdar://problem/32826094>
766
767         Reviewed by Brent Fulgham.
768
769         Adds three new testRunner functions:
770         - installStatisticsDidRunTelemetryCallback()
771         - statisticsFireTelemetryHandler()
772         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
773
774         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
775         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
776         (WTR::InjectedBundle::didReceiveMessageToPage):
777         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
778         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
779         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
780         (WTR::TestRunner::statisticsFireTelemetryHandler):
781         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
782         * WebKitTestRunner/InjectedBundle/TestRunner.h:
783         * WebKitTestRunner/TestController.cpp:
784         (WTR::TestController::resetStateToConsistentValues):
785         (WTR::TestController::statisticsFireTelemetryHandler):
786         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
787         * WebKitTestRunner/TestController.h:
788         * WebKitTestRunner/TestInvocation.cpp:
789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
790
791 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
792
793         Add missing includes to fix compilation error on FreeBSD
794         https://bugs.webkit.org/show_bug.cgi?id=172919
795
796         Reviewed by Mark Lam.
797
798         * ImageDiff/cairo/PlatformImageCairo.cpp:
799
800 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
801
802         Unreviewed, rolling out r218783.
803
804         Causing accessibility/mac/setting-attributes-is-
805         asynchronous.html to crash consistently on mac-wk2 Debug
806
807         Reverted changeset:
808
809         "AX: Cannot call setValue() on contenteditable or ARIA text
810         controls"
811         https://bugs.webkit.org/show_bug.cgi?id=173520
812         http://trac.webkit.org/changeset/218783
813
814 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
815
816         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
817         https://bugs.webkit.org/show_bug.cgi?id=173825
818
819         Reviewed by Saam Barati.
820
821         * DumpRenderTree/JavaScriptThreading.cpp:
822         (runJavaScriptThread):
823         (startJavaScriptThreads):
824         * DumpRenderTree/mac/DumpRenderTree.mm:
825         (runThread):
826         (runPthread):
827         (testThreadIdentifierMap):
828
829 2017-06-26  David Kilzer  <ddkilzer@apple.com>
830
831         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
832         <https://webkit.org/b/173837>
833
834         Reviewed by Geoffrey Garen.
835
836         The clang static analyzer can't reason about objects that are
837         assigned to a delegate as +1 retained, and then released
838         later in a different method when the delegate is cleared.
839
840         Instead, use a common idiom where the object setting the
841         delegate retains it as an instance variable on initialization.
842         Then the same object clears the delegate and releases its
843         instance variable during teardown.
844
845         Also add EXPECT_TRUE() tests to make sure the delegate objects
846         match before teardown.
847
848         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
849         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
850         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
851         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
852         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
853         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
854
855 2017-06-26  David Kilzer  <ddkilzer@apple.com>
856
857         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
858         <https://webkit.org/b/173836>
859
860         Reviewed by Brady Eidson.
861
862         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
863         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
864         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
865         objects in this test.
866
867 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
868
869         [ATK] Add support for aria-details and aria-errormessage
870         https://bugs.webkit.org/show_bug.cgi?id=172588
871
872         Reviewed by Chris Fleizach.
873
874         Add additional methods to test ARIA properties which are exposed via
875         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
876         to versions which support the details and error-message relation types.
877
878         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
879         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
880         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
881         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
882         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
883         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
884         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
885         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
886         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
887         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
888         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
889         * gtk/jhbuild.modules:
890
891 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
892
893         Unreviewed. Add libfii to GTK+ install dependencies script.
894
895         * gtk/install-dependencies:
896
897 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
898
899         Unreviewed, rolling out r215190.
900
901         Broke product select element on GNOME Bugzilla
902
903         Reverted changeset:
904
905         "[GTK] Misplaced right click menu on web page due to
906         deprecated gtk_menu_popup()"
907         https://bugs.webkit.org/show_bug.cgi?id=170553
908         http://trac.webkit.org/changeset/215190
909
910 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
911
912         Remove Reflect.enumerate
913         https://bugs.webkit.org/show_bug.cgi?id=173806
914
915         Reviewed by Yusuke Suzuki.
916
917         * Scripts/run-jsc-stress-tests:
918
919 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
920
921         AX: Cannot call setValue() on contenteditable or ARIA text controls
922         https://bugs.webkit.org/show_bug.cgi?id=173520
923
924         Reviewed by Ryosuke Niwa.
925
926         Add setValue() method to WKTR (already existed in DRT).
927
928         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
929         (WTR::AccessibilityUIElement::setValue):
930         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
931         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
932         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
933         (WTR::AccessibilityUIElement::setValue):
934
935 2017-06-23  Keith Miller  <keith_miller@apple.com>
936
937         Switch VMTraps to use halt instructions rather than breakpoint instructions
938         https://bugs.webkit.org/show_bug.cgi?id=173677
939
940         Reviewed by JF Bastien.
941
942         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
943         (TEST):
944
945 2017-06-23  Youenn Fablet  <youenn@apple.com>
946
947         Set getUserMedia permission to true by default on WTR
948         https://bugs.webkit.org/show_bug.cgi?id=173610
949
950         Reviewed by Alex Christensen.
951
952         Adding a way to reset the getUserMedia permission to pending.
953
954         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
955         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
956         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
957         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
958         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
959         (WTR::TestRunner::setUserMediaPermissionAsUnset):
960         * WebKitTestRunner/InjectedBundle/TestRunner.h:
961         * WebKitTestRunner/TestController.cpp:
962         (WTR::TestController::resetStateToConsistentValues):
963         (WTR::TestController::setUserMediaPermissionAsUnset):
964         * WebKitTestRunner/TestController.h:
965         * WebKitTestRunner/TestInvocation.cpp:
966         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
967
968 2017-06-23  Alex Christensen  <achristensen@webkit.org>
969
970         Add SPI to WKURLSchemeTask for redirection
971         https://bugs.webkit.org/show_bug.cgi?id=173730
972
973         Reviewed by Brady Eidson.
974
975         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
976         (-[SchemeHandler webView:startURLSchemeTask:]):
977         (-[SchemeHandler webView:stopURLSchemeTask:]):
978         (TEST):
979         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
980         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
981         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
982         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
983         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
984
985 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
986
987         [WPE] Use JSC API to send script messages from web extension in tests
988         https://bugs.webkit.org/show_bug.cgi?id=173757
989
990         Reviewed by Žan Doberšek.
991
992         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
993         to run postMessage().
994
995         Fixes: /wpe/WebKitSecurityManager/file-xhr
996                /wpe/WebKitConsoleMessage/console-api
997                /wpe/WebKitConsoleMessage/js-exception
998                /wpe/WebKitConsoleMessage/network-error
999                /wpe/WebKitConsoleMessage/security-error
1000
1001         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1002         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
1003         (beforeAll): Ditto.
1004         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1005         (testWebContextSecurityFileXHR): Ditto.
1006         (beforeAll): Ditto.
1007         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1008         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
1009         (pageCreatedCallback): Remove ifdefs.
1010
1011 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1012
1013         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
1014
1015         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
1016         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
1017         doesn't exist yet in WPE.
1018
1019         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1020         (testWebViewJavaScriptDialogs):
1021         (testWebViewWindowProperties):
1022
1023 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1024
1025         [GTK] Upgrade pixman and cairo in jhbuild
1026         https://bugs.webkit.org/show_bug.cgi?id=173710
1027
1028         Reviewed by Carlos Alberto Lopez Perez.
1029
1030         * gtk/jhbuild.modules:
1031
1032 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1033
1034         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
1035         https://bugs.webkit.org/show_bug.cgi?id=173711
1036
1037         Reviewed by Carlos Alberto Lopez Perez.
1038
1039         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
1040         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
1041
1042         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1043         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
1044
1045 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1046
1047         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
1048         <https://webkit.org/b/173721>
1049
1050         Reviewed by Joseph Pecoraro.
1051
1052         Use RetainPtr<> to create NSMutableDictionary and NSNumber
1053         objects to fix leaks and to avoid the autoreleasepool.
1054
1055         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
1056         (TEST):
1057
1058 2017-06-22  Matt Lewis  <jlewis3@apple.com>
1059
1060         Unreviewed, rolling out r218633.
1061
1062         The test is failing frequently on Sierra Debug and Windows
1063
1064         Reverted changeset:
1065
1066         "AX: Cannot call setValue() on contenteditable or ARIA text
1067         controls"
1068         https://bugs.webkit.org/show_bug.cgi?id=173520
1069         http://trac.webkit.org/changeset/218633
1070
1071 2017-06-22  David Kilzer  <ddkilzer@apple.com>
1072
1073         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
1074         <https://webkit.org/b/173690>
1075
1076         Reviewed by Chris Dumez.
1077
1078         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
1079         ownership of malloc()-ed memory, then frees it when it's
1080         released.  These tests were passing global variables into the
1081         method, which is not malloc()-ed memory, which violates the API
1082         contract.
1083
1084         The fix is to switch to use
1085         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
1086         NO for the last argument.
1087
1088         Caught by the clang static analyzer.
1089
1090         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1091         (TEST):
1092         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1093         (TEST):
1094
1095 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1096
1097         [GTK] Upgrade Harfbuzz to version 1.4.2
1098         https://bugs.webkit.org/show_bug.cgi?id=173592
1099
1100         Reviewed by Carlos Alberto Lopez Perez.
1101
1102         * gtk/jhbuild.modules:
1103
1104 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1105
1106         [WPE] Update WPEBackend-mesa
1107         https://bugs.webkit.org/show_bug.cgi?id=173705
1108
1109         Reviewed by Carlos Alberto Lopez Perez.
1110
1111         A crash has been fixed, needed for unit tests to work.
1112
1113         * wpe/jhbuild.modules:
1114
1115 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1116
1117         Remove unused coordinated graphics C API
1118         https://bugs.webkit.org/show_bug.cgi?id=173706
1119
1120         Reviewed by Žan Doberšek.
1121
1122         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
1123         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
1124         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
1125         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
1126         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
1127         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
1128
1129 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1130
1131         [WPE] Build glib API tests
1132         https://bugs.webkit.org/show_bug.cgi?id=173702
1133
1134         Reviewed by Žan Doberšek.
1135
1136         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
1137         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
1138         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
1139         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
1140         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
1141         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
1142         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
1143         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
1144         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
1145         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
1146         and implement the missing features.
1147
1148         * CMakeLists.txt:
1149         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
1150         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1151         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1152         (testAutomationSessionRequestSession):
1153         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
1154         (testWebKitWebViewSessionState):
1155         (testWebKitWebViewSessionStateWithFormData):
1156         (testWebKitWebViewNavigationAfterSessionRestore):
1157         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
1158         (beforeAll):
1159         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1160         (testCookieManagerEphemeral):
1161         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
1162         (testBlobDownload):
1163         (beforeAll):
1164         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1165         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
1166         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1167         (testProcessPerWebView):
1168         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1169         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1170         (testWebViewCreateNavigationData):
1171         (testWebViewJavaScriptDialogs):
1172         (testWebViewWindowProperties):
1173         (testWebViewMouseTarget):
1174         (testWebViewGeolocationPermissionRequests):
1175         (testWebViewUserMediaPermissionRequests):
1176         (testWebViewAudioOnlyUserMediaPermissionRequests):
1177         (testWebViewFileChooserRequest):
1178         (beforeAll):
1179         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1180         (beforeAll):
1181         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1182         (testPrivateBrowsing):
1183         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
1184         (testFindControllerHide):
1185         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
1186         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1187         (testWebKitSettings):
1188         (beforeAll):
1189         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1190         (testWebViewNewWithUserContentManager):
1191         (beforeAll):
1192         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
1193         (testWebContextEphemeral):
1194         (testWebContextProxySettings):
1195         (beforeAll):
1196         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1197         (testWebViewWebContext):
1198         (testWebViewWebContextLifetime):
1199         (testWebViewEphemeral):
1200         (testWebViewSettings):
1201         (testWebViewCanShowMIMEType):
1202         (testWebViewPageVisibility):
1203         (testWebViewIsPlayingAudio):
1204         (beforeAll):
1205         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1206         (testWebsiteDataEphemeral):
1207         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1208         (documentLoadedCallback):
1209         (pageCreatedCallback):
1210         (methodCallCallback):
1211         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
1212         * TestWebKitAPI/glib/CMakeLists.txt:
1213         * TestWebKitAPI/glib/PlatformGTK.cmake:
1214         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1215         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1216         (main):
1217         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1218         (Test::adoptView):
1219         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1220         (WebKitTestBus::run):
1221         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
1222         (WebViewTest::~WebViewTest):
1223         (WebViewTest::initializeWebView):
1224         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
1225         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
1226         (WebViewTest::platformDestroy):
1227         (WebViewTest::platformInitializeWebView):
1228         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1229         (WebViewTest::resizeView):
1230         (WebViewTest::hideView):
1231         (parentWindowMapped):
1232         (WebViewTest::showInWindow):
1233         (WebViewTest::showInWindowAndWaitUntilMapped):
1234         (WebViewTest::mouseMoveTo):
1235         (WebViewTest::clickMouseButton):
1236         (WebViewTest::emitPopupMenuSignal):
1237         (WebViewTest::keyStroke):
1238         (WebViewTest::doMouseButtonEvent):
1239         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
1240         (WebViewTest::platformDestroy):
1241         (WebViewTest::platformInitializeWebView):
1242         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
1243         (WebViewTest::resizeView):
1244         (WebViewTest::hideView):
1245         (WebViewTest::mouseMoveTo):
1246         (WebViewTest::clickMouseButton):
1247         (WebViewTest::keyStroke):
1248
1249 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1250
1251         [GTK] Move WebKit2 GLib API tests to glib directories
1252         https://bugs.webkit.org/show_bug.cgi?id=173642
1253
1254         Reviewed by Žan Doberšek.
1255
1256         * CMakeLists.txt:
1257         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
1258         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
1259         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
1260         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
1261         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
1262         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
1263         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
1264         (testWebKitConsoleMessageNetworkError):
1265         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
1266         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
1267         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
1268         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
1269         (testLoadFromGResource):
1270         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
1271         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
1272         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
1273         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
1274         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
1275         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
1276         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
1277         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
1278         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
1279         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
1280         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
1281         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
1282         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
1283         (testWebViewRunJavaScript):
1284         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
1285         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
1286         (registerGResource):
1287         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
1288         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
1289         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
1290         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
1291         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
1292         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
1293         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
1294         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
1295         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
1296         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
1297         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
1298         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
1299         * TestWebKitAPI/glib/CMakeLists.txt: Added.
1300         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
1301         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
1302         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
1303         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
1304         (registerGResource):
1305         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
1306         (Test::getResourcesDir):
1307         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
1308         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
1309         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
1310         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
1311         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
1312         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
1313
1314 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1315
1316         [WPE] Add initial web extensions API
1317         https://bugs.webkit.org/show_bug.cgi?id=173640
1318
1319         Reviewed by Žan Doberšek.
1320
1321         Add style checker exceptions for WPE web extensions API files.
1322
1323         * Scripts/webkitpy/style/checker.py:
1324
1325 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1326
1327         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
1328         https://bugs.webkit.org/show_bug.cgi?id=173659
1329         <rdar://problem/32879788>
1330
1331         Reviewed by Tim Horton.
1332
1333         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
1334
1335         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
1336
1337         Augment this test page to log dragend and dragstart events on the drag source as well.
1338
1339         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1340         (checkStringArraysAreEqual):
1341         (TestWebKitAPI::TEST):
1342
1343 2017-06-21  Antoine Quint  <graouts@apple.com>
1344
1345         Ensure DRT always logs rAF suspension debugging code
1346         https://bugs.webkit.org/show_bug.cgi?id=173681
1347
1348         Reviewed by Tim "Mr. T" Horton.
1349
1350         * DumpRenderTree/mac/DumpRenderTree.mm:
1351         (resetWebPreferencesToConsistentValues):
1352
1353 2017-06-21  Chris Dumez  <cdumez@apple.com>
1354
1355         Allow constructing a WTF:Function from a function pointer
1356         https://bugs.webkit.org/show_bug.cgi?id=173660
1357
1358         Reviewed by Alex Christensen.
1359
1360         Add API test coverage.
1361
1362         * TestWebKitAPI/Tests/WTF/Function.cpp:
1363         (TestWebKitAPI::returnThree):
1364         (TestWebKitAPI::returnFour):
1365         (TestWebKitAPI::returnPassedValue):
1366         (TestWebKitAPI::TEST):
1367
1368 2017-06-21  Antoine Quint  <graouts@apple.com>
1369
1370         Add logging to identify when the Page suspends scripted animations
1371         https://bugs.webkit.org/show_bug.cgi?id=173626
1372
1373         Reviewed by Tim Horton.
1374
1375         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
1376
1377         * DumpRenderTree/mac/DumpRenderTree.mm:
1378         (resetWebPreferencesToConsistentValues):
1379
1380 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
1381
1382         AX: Cannot call setValue() on contenteditable or ARIA text controls
1383         https://bugs.webkit.org/show_bug.cgi?id=173520
1384
1385         Reviewed by Ryosuke Niwa.
1386
1387         Add setValue() method to WKTR (already existed in DRT).
1388
1389         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1390         (WTR::AccessibilityUIElement::setValue):
1391         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1392         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1393         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1394         (WTR::AccessibilityUIElement::setValue):
1395
1396 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
1397
1398         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
1399         as one of the dependencies required to build the product.
1400
1401         Rubber-stamped by Carlos Garcia Campos.
1402
1403         * gtk/install-dependencies:
1404         * wpe/install-dependencies:
1405
1406 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
1407
1408         Disable font variations on macOS Sierra and iOS 10
1409         https://bugs.webkit.org/show_bug.cgi?id=173618
1410         <rdar://problem/32879164>
1411
1412         Reviewed by Jon Lee.
1413
1414         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1415
1416 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
1417
1418         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
1419         https://bugs.webkit.org/show_bug.cgi?id=173578
1420         <rdar://problem/32825028>
1421
1422         Reviewed by Tim Horton.
1423
1424         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
1425         a custom popover does not cause dragging to fail when the popover is presented.
1426
1427         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1428         (-[DataInteractionSimulator _advanceProgress]):
1429
1430 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1431
1432         [WPE] Add initial implementation of glib API
1433         https://bugs.webkit.org/show_bug.cgi?id=173546
1434
1435         Reviewed by Žan Doberšek.
1436
1437         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
1438         include WPE glib API files.
1439
1440         * Scripts/webkitperl/FeatureList.pm:
1441         * Scripts/webkitpy/style/checker.py:
1442         * Scripts/webkitpy/style/checkers/cpp.py:
1443         (check_identifier_name_in_declaration):
1444
1445 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1446
1447         [GTK] Upgrade to ICU to version 57.1
1448         https://bugs.webkit.org/show_bug.cgi?id=173538
1449
1450         Reviewed by Žan Doberšek.
1451
1452         * gtk/jhbuild.modules:
1453
1454 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1455
1456         [GTK] Remove unneeded modules from the jhbuild
1457         https://bugs.webkit.org/show_bug.cgi?id=170540
1458
1459         Reviewed by Michael Catanzaro.
1460
1461         We are building libxslt and libffi that we don't really need to build from sources.
1462
1463         * gtk/jhbuild.modules:
1464
1465 2017-06-19  Frederic Wang  <fwang@igalia.com>
1466
1467         [Mac] Add an experimental feature setting for async frame scrolling
1468         https://bugs.webkit.org/show_bug.cgi?id=173359
1469
1470         Reviewed by Simon Fraser.
1471
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
1474         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
1475         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1476         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
1477
1478 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
1479
1480         Unreviewed, adding myself to contributors.json
1481
1482         * Scripts/webkitpy/common/config/contributors.json:
1483
1484 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
1485
1486         test262: Completion values for control flow do not match the spec
1487         https://bugs.webkit.org/show_bug.cgi?id=171265
1488
1489         Reviewed by Saam Barati.
1490
1491         * Scripts/run-jsc-stress-tests:
1492         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
1493
1494 2017-06-19  Zalan Bujtas  <zalan@apple.com>
1495
1496         Opening certain mails brings up a mail that grows indefinitely.
1497         https://bugs.webkit.org/show_bug.cgi?id=173562
1498         <rdar://problem/32766579>
1499
1500         Reviewed by Tim Horton.
1501
1502         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
1503         (TEST):
1504
1505 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
1506
1507         [iOS DnD] Support .zip archives for file uploads via drag and drop
1508         https://bugs.webkit.org/show_bug.cgi?id=173511
1509         <rdar://problem/32521025>
1510
1511         Reviewed by Tim Horton.
1512
1513         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
1514         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
1515
1516         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1517         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
1518         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1519         (testZIPArchive):
1520         (TestWebKitAPI::TEST):
1521
1522 2017-06-18  Darin Adler  <darin@apple.com>
1523
1524         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
1525         https://bugs.webkit.org/show_bug.cgi?id=173526
1526
1527         Reviewed by Sam Weinig.
1528
1529         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
1530         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1531
1532         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
1533         tests for assignment before destruction ones.
1534
1535         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
1536         as a function, so it can be used in WTF::Function tests.
1537
1538         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
1539         Added tests for swap and for assignment before deref.
1540
1541         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
1542         to inline everything. Also removed the unnecessary clearing of the log every time
1543         the DerivedRefLogger constructor is called.
1544         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
1545
1546         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
1547         Added tests for assignment before deref and similar for releaseNonNull.
1548
1549 2017-06-19  Sam Weinig  <sam@webkit.org>
1550
1551         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
1552         https://bugs.webkit.org/show_bug.cgi?id=173513
1553
1554         Reviewed by Alex Christensen.
1555
1556         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1557         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1558         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
1559
1560 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
1561
1562         [Win] fast/dom/assign-to-window-status.html is flaky.
1563         https://bugs.webkit.org/show_bug.cgi?id=173512
1564
1565         Reviewed by Alex Christensen.
1566
1567         We should not dump status callbacks when test is done.
1568
1569         * DumpRenderTree/win/UIDelegate.cpp:
1570         (UIDelegate::setStatusText):
1571
1572 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1573
1574         [WPE][JHBuild] Update WPEBackend-mesa
1575         https://bugs.webkit.org/show_bug.cgi?id=173433
1576
1577         Unreviewed.
1578
1579         Update WPEBackend-mesa back (like it was done originally in r218344)
1580         after fixing the issue with the DISPLAY environment variables that
1581         caused the crashes.
1582
1583         * wpe/jhbuild.modules:
1584
1585 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1586
1587         Rename unit test file after r218482
1588         https://bugs.webkit.org/show_bug.cgi?id=173483
1589
1590         Unreviewed.
1591
1592         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
1593
1594 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1595
1596         Unreviewed. Fix wrong style checker condition added in r218487.
1597
1598         * Scripts/webkitpy/style/checkers/cpp.py:
1599         (check_identifier_name_in_declaration):
1600
1601 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
1602
1603         Missing <functional> includes make builds fail with GCC 7.x
1604         https://bugs.webkit.org/show_bug.cgi?id=173544
1605
1606         Unreviewed gardening.
1607
1608         Fix compilation with GCC 7.
1609
1610         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1611         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1612
1613 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1614
1615         [GTK] Move GTK+ API files that could be shared to glib dirs
1616         https://bugs.webkit.org/show_bug.cgi?id=173545
1617
1618         Reviewed by Žan Doberšek.
1619
1620         Update paths of GTK+ API in watchlist and style checker.
1621
1622         * Scripts/webkitpy/common/config/watchlist:
1623         * Scripts/webkitpy/style/checker.py:
1624         * Scripts/webkitpy/style/checkers/cpp.py:
1625         (check_identifier_name_in_declaration):
1626
1627 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1628
1629         Port setup_environ_for_server should not set environment variables related with the driver.
1630         https://bugs.webkit.org/show_bug.cgi?id=173483
1631
1632         Reviewed by Carlos Garcia Campos.
1633
1634         The port setup_environ_for_server() should not set environment variables
1635         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1636         This varibles should be only set on the driver setup_environ_for_test().
1637
1638         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1639         into the test environment even when running the tests with a driver
1640         that is not the Xorg or Xvfb one.
1641
1642         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1643         (Port.to.setup_environ_for_server):
1644         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1645         (Driver._setup_environ_for_driver):
1646         * Scripts/webkitpy/port/driver_unittest.py:
1647         (DriverTest.test_setup_environ_for_test):
1648         (DriverTest):
1649         (DriverTest.test_setup_environ_base_vars):
1650         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1651         (GtkPort.setup_environ_for_server):
1652         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1653         (WaylandDriverTest):
1654         (WaylandDriverTest.make_driver):
1655         (WaylandDriverTest.make_environment):
1656         (WaylandDriverTest.test_checkdriver):
1657         (WaylandDriverTest.test_environment_needed_variables):
1658         (WaylandDriverTest.test_environment_forbidden_variables):
1659         (WaylandDriverTest.test_environment_optional_variables):
1660         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1661         (WaylandDriver.check_driver):
1662         (WaylandDriver._setup_environ_for_test):
1663         * Scripts/webkitpy/port/xorgdriver.py:
1664         (XorgDriver.check_driver):
1665         (XorgDriver._setup_environ_for_test):
1666         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1667         (XorgDriverTest):
1668         (XorgDriverTest.make_driver):
1669         (XorgDriverTest.make_environment):
1670         (XorgDriverTest.test_checkdriver):
1671         (XorgDriverTest.test_environment_needed_variables):
1672         (XorgDriverTest.test_environment_forbidden_variables):
1673         (XorgDriverTest.test_environment_optional_variables):
1674         * Scripts/webkitpy/port/xvfbdriver.py:
1675         (XvfbDriver._setup_environ_for_test):
1676         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1677         (XvfbDriverTest.assertDriverStartSuccessful):
1678
1679
1680 2017-05-14 Frederic Wang  <fwang@igalia.com>
1681
1682         Add heuristic to avoid flattening "fullscreen" iframes
1683         https://bugs.webkit.org/show_bug.cgi?id=171914
1684
1685         Reviewed by Simon Fraser.
1686
1687         * DumpRenderTree/mac/DumpRenderTree.mm:
1688         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1689
1690 2017-06-18  Chris Dumez  <cdumez@apple.com>
1691
1692         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1693         https://bugs.webkit.org/show_bug.cgi?id=173522
1694         <rdar://problem/31185739>
1695
1696         Reviewed by Darin Adler.
1697
1698         Add API test for re-entering Function's assignment operators.
1699
1700         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1701         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1702         (TestWebKitAPI::TestObject::TestObject):
1703         (TestWebKitAPI::TestObject::~TestObject):
1704         (TestWebKitAPI::TestObject::operator()):
1705         (TestWebKitAPI::TEST):
1706
1707 2017-06-16  Dan Bernstein  <mitz@apple.com>
1708
1709         [Cocoa] Some declarations have missing or incorrect availability attributes
1710         https://bugs.webkit.org/show_bug.cgi?id=173508
1711
1712         Reviewed by Tim Horton.
1713
1714         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1715         (TestWebKitAPI::TEST): Updated for renames.
1716
1717 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1718
1719         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1720         https://bugs.webkit.org/show_bug.cgi?id=173366
1721         <rdar://problem/32767014>
1722
1723         Reviewed by Tim Horton.
1724
1725         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1726         change in behavior.
1727
1728         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1729         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1730         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1731         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1732         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1733         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1734         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1735         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1736         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1737         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1738         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1739         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1740         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1741         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1742         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1743         (-[MockDragDropSession initWithItems:location:window:]):
1744         (-[MockDragDropSession allowsMoveOperation]):
1745         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1746         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1747         (-[MockDragDropSession canLoadObjectsOfClass:]):
1748         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1749         (-[MockDragDropSession items]):
1750         (-[MockDragDropSession setItems:]):
1751         (-[MockDragDropSession locationInView:]):
1752         (-[MockDataOperationSession initWithProviders:location:window:]):
1753         (-[MockDataOperationSession session]):
1754         (-[MockDataOperationSession isLocal]):
1755         (-[MockDataOperationSession progress]):
1756         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1757         (-[MockDataOperationSession progressIndicatorStyle]):
1758         (-[MockDataOperationSession operationMask]):
1759         (-[MockDataOperationSession localDragSession]):
1760         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1761         (-[MockDataOperationSession canCreateItemsOfClass:]):
1762         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1763         (-[MockDataInteractionSession initWithWindow:]):
1764         (-[MockDataInteractionSession localOperationMask]):
1765         (-[MockDataInteractionSession externalOperationMask]):
1766         (-[MockDataInteractionSession session]):
1767         (-[DataInteractionSimulator _advanceProgress]):
1768
1769 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1770
1771         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1772         https://bugs.webkit.org/show_bug.cgi?id=173431
1773
1774         Reviewed by Darin Adler.
1775
1776         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1777         (TestWebKitAPI::TEST):
1778
1779 2017-06-16  Chris Dumez  <cdumez@apple.com>
1780
1781         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1782         https://bugs.webkit.org/show_bug.cgi?id=173472
1783         <rdar://problem/28858817>
1784
1785         Reviewed by Brady Eidson.
1786
1787         Add API test coverage.
1788
1789         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1790         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1791         (TEST):
1792
1793 2017-06-16  Brady Eidson  <beidson@apple.com>
1794
1795         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1796         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1797
1798         Reviewed by Daniel Bates.
1799
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1801
1802 2017-06-16  Chris Dumez  <cdumez@apple.com>
1803
1804         DRT fails to reset page visibility between tests
1805         https://bugs.webkit.org/show_bug.cgi?id=173485
1806
1807         Reviewed by Alexey Proskuryakov.
1808
1809         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1810         Fix this to address flakiness.
1811
1812         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1813         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1814         The test became flaky without the DRT change and was no longer flaky with the DRT
1815         change.
1816
1817         WebKitTestRunner already does this.
1818
1819         * DumpRenderTree/mac/DumpRenderTree.mm:
1820         (resetWebViewToConsistentStateBeforeTesting):
1821
1822 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1823
1824         Implement basic authentication in MiniBrowser
1825         https://bugs.webkit.org/show_bug.cgi?id=173443
1826
1827         Reviewed by Tim Horton.
1828
1829         * MiniBrowser/mac/WK2BrowserWindowController.m:
1830         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1831
1832 2017-06-16  Jer Noble  <jer.noble@apple.com>
1833
1834         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1835         https://bugs.webkit.org/show_bug.cgi?id=173398
1836         <rdar://problem/32592961>
1837
1838         Reviewed by Eric Carlson.
1839
1840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1841         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1842         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1843         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1844         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1845         (TestWebKitAPI::TEST):
1846         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1847
1848 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1849
1850         Unreviewed, rolling out r218375.
1851
1852         The API test MediaStreamTrackDetached is still timing out
1853         after the patch
1854
1855         Reverted changeset:
1856
1857         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1858         reports no recording to WebKit clients"
1859         https://bugs.webkit.org/show_bug.cgi?id=173398
1860         http://trac.webkit.org/changeset/218375
1861
1862 2017-06-15  Jer Noble  <jer.noble@apple.com>
1863
1864         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1865         https://bugs.webkit.org/show_bug.cgi?id=173398
1866         <rdar://problem/32592961>
1867
1868         Reviewed by Eric Carlson.
1869
1870         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1871         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1872         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1873         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1874         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1875         (TestWebKitAPI::TEST):
1876         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1877
1878 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1879
1880         Unreviewed, rolling out r218365.
1881
1882         The revision caused API timeouts on all builds.
1883
1884         Reverted changeset:
1885
1886         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1887         reports no recording to WebKit clients"
1888         https://bugs.webkit.org/show_bug.cgi?id=173398
1889         http://trac.webkit.org/changeset/218365
1890
1891 2017-06-15  Jer Noble  <jer.noble@apple.com>
1892
1893         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1894         https://bugs.webkit.org/show_bug.cgi?id=173398
1895         <rdar://problem/32592961>
1896
1897         Reviewed by Eric Carlson.
1898
1899         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1900         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1901         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1902         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1903         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1904         (TestWebKitAPI::TEST):
1905         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1906
1907 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1908
1909         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1910         https://bugs.webkit.org/show_bug.cgi?id=173433
1911
1912         Unreviewed.
1913
1914         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1915
1916 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1917
1918         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1919         https://bugs.webkit.org/show_bug.cgi?id=173061
1920
1921         Reviewed by Žan Doberšek.
1922
1923         Launch dyz <https://github.com/Igalia/dyz> with the script
1924         run-minibrowser for the wpe port. It is now built as part of the
1925         WPE dependencies with JHBuild.
1926
1927         * Scripts/run-minibrowser:
1928         * Scripts/webkitdirs.pm:
1929         (launcherPath):
1930         (launcherName):
1931         * wpe/install-dependencies: Luajit is needed for building dyz.
1932         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1933
1934 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1935
1936         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1937         https://bugs.webkit.org/show_bug.cgi?id=173338
1938         <rdar://problem/32777720>
1939
1940         Reviewed by Tim Horton.
1941
1942         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1943         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1944         these remaining items on drop.
1945
1946         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1947         (TestWebKitAPI::TEST):
1948         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1949         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1950
1951         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1952
1953         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1954
1955 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1956
1957         [Win] Crash in accessibility layout test.
1958         https://bugs.webkit.org/show_bug.cgi?id=173401
1959
1960         Reviewed by Brent Fulgham.
1961
1962         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1963         member will be automatically released when the _variant_t object goes out of scope if the vt member
1964         does not equal VT_UNKNOWN | VT_BYREF.
1965         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1966
1967         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1968         (AccessibilityUIElement::titleUIElement):
1969
1970 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1971
1972         [GTK] Add API to allow overriding popup menus
1973         https://bugs.webkit.org/show_bug.cgi?id=172905
1974
1975         Reviewed by Michael Catanzaro.
1976
1977         Add a unit test to check the new API.
1978
1979         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1980         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1981         (OptionMenuTest::OptionMenuTest):
1982         (OptionMenuTest::~OptionMenuTest):
1983         (OptionMenuTest::destroyMenu):
1984         (OptionMenuTest::showOptionMenuCallback):
1985         (OptionMenuTest::menuCloseCallback):
1986         (OptionMenuTest::showOptionMenu):
1987         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1988         (OptionMenuTest::close):
1989         (OptionMenuTest::activateItem):
1990         (OptionMenuTest::selectItem):
1991         (testOptionMenuSimple):
1992         (testOptionMenuGroups):
1993         (testOptionMenuActivate):
1994         (testOptionMenuSelect):
1995         (beforeAll):
1996         (afterAll):
1997
1998 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1999
2000         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
2001         https://bugs.webkit.org/show_bug.cgi?id=173399
2002
2003         Reviewed by Per Arne Vollan.
2004
2005         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
2006         Curl port needs to do nothing because libcurl doesn't have disk cache.
2007
2008         * DumpRenderTree/win/DumpRenderTree.cpp:
2009         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
2010         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
2011
2012 2017-06-14  Tomas Popela  <tpopela@redhat.com>
2013
2014         [GTK] integer expression expected if running Tools/gtk/install-dependencies
2015         https://bugs.webkit.org/show_bug.cgi?id=173356
2016
2017         Reviewed by Michael Catanzaro.
2018
2019         Use the correct operator to compare the strings.
2020
2021         * gtk/install-dependencies:
2022
2023 2017-06-14  Commit Queue  <commit-queue@webkit.org>
2024
2025         Unreviewed, rolling out r218285.
2026         https://bugs.webkit.org/show_bug.cgi?id=173391
2027
2028         API test fails on iOS (Requested by alexchristensen on
2029         #webkit).
2030
2031         Reverted changeset:
2032
2033         "Add SPI for immediate injection of user scripts"
2034         https://bugs.webkit.org/show_bug.cgi?id=173342
2035         http://trac.webkit.org/changeset/218285
2036
2037 2017-06-14  Chris Dumez  <cdumez@apple.com>
2038
2039         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
2040         https://bugs.webkit.org/show_bug.cgi?id=173384
2041         <rdar://problem/32723779>
2042
2043         Reviewed by Dan Bernstein.
2044
2045         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2046         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
2047         Add API test coverage.
2048
2049         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2050         (TestWebKitAPI::Util::sleep):
2051         Update implementation of Util::sleep() so that we actually run the run loop.
2052         Otherwise, we don't process events while sleeping.
2053
2054 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2055
2056         Add SPI for immediate injection of user scripts
2057         https://bugs.webkit.org/show_bug.cgi?id=173342
2058         <rdar://problem/29202285>
2059
2060         Reviewed by Brady Eidson.
2061
2062         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2063         (waitForMessage):
2064         (TEST):
2065
2066 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
2067
2068         Add WPE to the flakiness dashboard
2069         https://bugs.webkit.org/show_bug.cgi?id=173365
2070
2071         Reviewed by Carlos Alberto Lopez Perez.
2072
2073         * TestResultServer/static-dashboards/builders.jsonp:
2074         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2075         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2076         (resetGlobals):
2077         * TestResultServer/static-dashboards/loader_unittests.js:
2078
2079 2017-06-14  Brady Eidson  <beidson@apple.com>
2080
2081         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
2082         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
2083
2084         Reviewed by Alex Christensen.
2085
2086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
2088         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
2089         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
2090         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
2091         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
2092         (TEST):
2093
2094 2017-06-14  Tim Horton  <timothy_horton@apple.com>
2095
2096         WKContentViewEditingActions API test always fails
2097         https://bugs.webkit.org/show_bug.cgi?id=173374
2098
2099         Reviewed by Wenson Hsieh.
2100
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2102         (TEST):
2103         selectAll isn't working, because canPerformAction for selectAll returns NO
2104         if selectionIsNone (which is true in the non-contenteditable case).
2105         Instead, make use of r218180's test page, which knows how to select itself.
2106         Also, reset the pasteboard at the beginning of the test to reduce confusion
2107         (I landed the test broken because my simulator had the correct text
2108         stuck in its pasteboard).
2109
2110 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
2111
2112         Configure screen scale for running layout tests on plus devices
2113         https://bugs.webkit.org/show_bug.cgi?id=173319
2114
2115         Reviewed by Tim Horton.
2116
2117         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2118         * DumpRenderTree/mac/DumpRenderTree.mm:
2119         (dumpRenderTree): Set screen scale to 2.0.
2120         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
2121         add _setScale for UIScreen.
2122         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
2123         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2124         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
2125         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
2126         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
2127         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
2128         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
2129         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
2130         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
2131         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
2132
2133 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
2134
2135         Add iOS 11 support to the bot watcher's dashboard
2136         https://bugs.webkit.org/show_bug.cgi?id=173369
2137
2138         Reviewed by Lucas Forschler.
2139
2140         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
2143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2146
2147 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2148
2149         [GTK][WPE] Raise the timeout values for layout tests
2150         https://bugs.webkit.org/show_bug.cgi?id=173368
2151
2152         Reviewed by Carlos Garcia Campos.
2153
2154         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
2155         When running under valgrind a 10x multiplier is applied.
2156
2157         * Scripts/webkitpy/port/gtk.py:
2158         (GtkPort.default_timeout_ms):
2159         * Scripts/webkitpy/port/gtk_unittest.py:
2160         (GtkPortTest.test_default_timeout_ms):
2161         * Scripts/webkitpy/port/wpe.py:
2162         (WPEPort.default_timeout_ms):
2163         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
2164         (WPEPortTest):
2165         (WPEPortTest.make_port):
2166         (WPEPortTest.test_default_timeout_ms):
2167         (WPEPortTest.test_get_crash_log):
2168
2169 2017-06-14  Alex Christensen  <achristensen@webkit.org>
2170
2171         Test persistent WKHTTPCookieStorages on iOS.
2172         https://bugs.webkit.org/show_bug.cgi?id=173284
2173
2174         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2175         (TEST):
2176         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
2177
2178 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
2179
2180         [Win] DRT should not use disk cache.
2181         https://bugs.webkit.org/show_bug.cgi?id=173361
2182
2183         Reviewed by Darin Adler.
2184
2185         Like on macOS/iOS, DRT on Windows should only use memory cache.
2186
2187         * DumpRenderTree/win/DumpRenderTree.cpp:
2188         (setDefaultsToConsistentValuesForTesting):
2189         (prepareConsistentTestingEnvironment):
2190
2191 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
2192
2193         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
2194         https://bugs.webkit.org/show_bug.cgi?id=171668
2195
2196         Reviewed by Jer Noble.
2197
2198         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
2199         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
2200         Infinity when the double value passed as argument is greater than 2^64.
2201
2202         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
2203         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
2204         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
2205         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
2206         method. No behavior change for rational MediaTime.
2207
2208         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
2209         (TestWebKitAPI::TEST):
2210
2211 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2212
2213         Test persistent WKHTTPCookieStorages on iOS
2214         https://bugs.webkit.org/show_bug.cgi?id=173284
2215         <rdar://problem/32260156>
2216
2217         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2218         (TEST):
2219
2220 2017-06-13  Matt Rajca  <mrajca@apple.com>
2221
2222         WebsitePolicies: let clients select specific autoplay quirks
2223         https://bugs.webkit.org/show_bug.cgi?id=173343
2224
2225         Reviewed by Alex Christensen.
2226
2227         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2228         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2229         (TEST): Updated tests.
2230
2231 2017-06-13  Daniel Bates  <dabates@apple.com>
2232
2233         Implement W3C Secure Contexts Draft Specification
2234         https://bugs.webkit.org/show_bug.cgi?id=158121
2235         <rdar://problem/26012994>
2236
2237         Reviewed by Brent Fulgham.
2238
2239         Part 4
2240
2241         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
2242         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
2243         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
2244
2245         * DumpRenderTree/TestOptions.h:
2246         * DumpRenderTree/TestOptions.mm:
2247         (TestOptions::TestOptions):
2248         * DumpRenderTree/mac/DumpRenderTree.mm:
2249         (setWebPreferencesForTestOptions):
2250         * DumpRenderTree/win/DumpRenderTree.cpp:
2251         (enableExperimentalFeatures):
2252         * WebKitTestRunner/TestController.cpp:
2253         (WTR::TestController::resetPreferencesToConsistentValues):
2254         (WTR::updateTestOptionsFromTestHeader):
2255         * WebKitTestRunner/TestOptions.h:
2256         (WTR::TestOptions::hasSameInitializationOptions):
2257
2258 2017-06-13  Alex Christensen  <achristensen@webkit.org>
2259
2260         Test persistent WKHTTPCookieStorages on iOS
2261         https://bugs.webkit.org/show_bug.cgi?id=173284
2262         <rdar://problem/32260156>
2263
2264         Reviewed by Alexey Proskuryakov.
2265
2266         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
2267         (TEST):
2268
2269 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2270
2271         [GTK] Blob download doesn't work
2272         https://bugs.webkit.org/show_bug.cgi?id=172442
2273
2274         Reviewed by Carlos Alberto Lopez Perez.
2275
2276         Add a unit test to check blob downloads.
2277
2278         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2279         (testBlobDownload):
2280         (beforeAll):
2281
2282 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2283
2284         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
2285         https://bugs.webkit.org/show_bug.cgi?id=173316
2286
2287         Reviewed by Alex Christensen.
2288
2289         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
2290
2291         * gtk/manifest.txt.in:
2292
2293 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
2296         https://bugs.webkit.org/show_bug.cgi?id=173315
2297
2298         Reviewed by Darin Adler.
2299
2300         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
2301         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
2302         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
2303         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
2304         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
2305         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
2306         WKGeolocationManagerRef is not destroyed.
2307
2308         * WebKitTestRunner/GeolocationProviderMock.cpp:
2309         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2310         * WebKitTestRunner/GeolocationProviderMock.h:
2311
2312 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2313
2314         Unable to paste text that was copied from a page into the universal search field
2315         https://bugs.webkit.org/show_bug.cgi?id=173293
2316         <rdar://problem/32440918>
2317
2318         Reviewed by Ryosuke Niwa.
2319
2320         Adds 2 new unit tests for copying plain and rich selected web content.
2321         See WebCore and WebKit ChangeLogs for more detail.
2322
2323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2324         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
2325         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
2326         (TestWebKitAPI::dataForPasteboardType):
2327         (TestWebKitAPI::setUpWebViewForPasteboardTests):
2328         (TestWebKitAPI::TEST):
2329
2330 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
2331
2332         AX: [ATK] Implement missing AtkRelation types
2333         https://bugs.webkit.org/show_bug.cgi?id=155494
2334
2335         Reviewed by Darin Adler.
2336
2337         Add additional methods to test ARIA properties which are exposed via
2338         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
2339
2340         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2341         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2342         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2343         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2344         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2345         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2346         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2347         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2348         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2349         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2350         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2351         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
2352         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
2353         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
2354         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
2355         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
2356         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
2357         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
2358
2359 2017-06-12  Daniel Bates  <dabates@apple.com>
2360
2361         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
2362         https://bugs.webkit.org/show_bug.cgi?id=173286
2363         <rdar://problem/32726102>
2364
2365         Reviewed by Brent Fulgham.
2366
2367         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2368         (TestWebKitAPI::TEST_F):
2369
2370 2017-06-12  Lucas Forschler  <lforschler@apple.com>
2371
2372         <rdar://problem/32683422>
2373         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
2374
2375         Reviewed by Conrad Schultz.
2376
2377         * Scripts/copy-webkitlibraries-to-product-directory:
2378
2379 2017-06-12  Tim Horton  <timothy_horton@apple.com>
2380
2381         [iOS] Cmd-C doesn't copy text from WKWebView
2382         https://bugs.webkit.org/show_bug.cgi?id=173277
2383         <rdar://problem/32396742>
2384
2385         Reviewed by Dan Bernstein.
2386
2387         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2388         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
2389         Add a test ensuring that -copy on WKContentView will cause text to be copied.
2390
2391 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
2392
2393         [WebCrypto] Remove experimental feature flag of SubtleCrypto
2394         https://bugs.webkit.org/show_bug.cgi?id=173197
2395         <rdar://problem/32688148>
2396
2397         Reviewed by Brent Fulgham.
2398
2399         * DumpRenderTree/mac/DumpRenderTree.mm:
2400         (enableExperimentalFeatures):
2401         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2402         (WTR::InjectedBundle::beginTesting):
2403         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2404         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
2405         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2406
2407 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2408
2409         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
2410         https://bugs.webkit.org/show_bug.cgi?id=173238
2411         <rdar://problem/31943370>
2412
2413         Reviewed by Ryosuke Niwa and Tim Horton.
2414
2415         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
2416         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
2417         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
2418
2419         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2420         (TestWebKitAPI::TEST):
2421         * TestWebKitAPI/ios/DataInteractionSimulator.h:
2422         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
2423         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
2424         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
2425
2426 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2427
2428         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
2429         https://bugs.webkit.org/show_bug.cgi?id=173225
2430         <rdar://problem/32713144>
2431
2432         Reviewed by Tim Horton.
2433
2434         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
2435         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
2436
2437         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2438         (TestWebKitAPI::TEST):
2439
2440 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
2441
2442         Return correct process names for iOS on-device testing
2443         https://bugs.webkit.org/show_bug.cgi?id=173263
2444
2445         Reviewed by Alex Christensen.
2446
2447         When running tests on iOS devices, process names do not end with '.Development'
2448         as they do on Mac and iOS simulator.
2449
2450         * WebKitTestRunner/TestController.cpp:
2451         (WTR::TestController::webProcessName): Return correct process name without '.Development'
2452         for iOS on-device testing.
2453         (WTR::TestController::networkProcessName): Ditto.
2454         (WTR::TestController::databaseProcessName): Ditto.
2455
2456 2017-06-12  Chris Dumez  <cdumez@apple.com>
2457
2458         Regression(r217867): Legacy SessionHistoryEntryData format should not change
2459         https://bugs.webkit.org/show_bug.cgi?id=173267
2460         <rdar://problem/32701257>
2461
2462         Reviewed by Simon Fraser.
2463
2464         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
2465         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
2466         though as this covers the crash that r217867 was fixing.
2467
2468         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
2469         (TestWebKitAPI::createSessionStateData):
2470         (TestWebKitAPI::TEST):
2471         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
2472
2473 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2474
2475         [GTK] Stop dismissing menus attached to the web view for every injected event
2476         https://bugs.webkit.org/show_bug.cgi?id=172708
2477
2478         Reviewed by Alex Christensen.
2479
2480         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
2481         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
2482         events while the menu is open.
2483
2484         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2485         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
2486         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2487         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
2488
2489 2017-06-12  Miguel Gomez  <magomez@igalia.com>
2490
2491         [GTK][WPE] Enable GStreamer GL on development builds
2492         https://bugs.webkit.org/show_bug.cgi?id=173248
2493
2494         Enable GStreamer GL for GTK and WPE.
2495
2496         Reviewed by Carlos Garcia Campos.
2497
2498         * Scripts/webkitperl/FeatureList.pm:
2499
2500 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2501
2502         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
2503
2504         Notifications are no longer cleared on page navigation.
2505
2506         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2507         (testWebViewNotification):
2508
2509 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2510
2511         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
2512
2513         DBus interface and object path names were updated in r217831.
2514
2515         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
2516
2517 2017-06-10  Dan Bernstein  <mitz@apple.com>
2518
2519         Reverted r218056 because it made the IDE reindex constantly.
2520
2521         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2522         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2523         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2524         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2525         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2526         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2527         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2528         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2529
2530 2017-06-10  Dan Bernstein  <mitz@apple.com>
2531
2532         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
2533         https://bugs.webkit.org/show_bug.cgi?id=173223
2534
2535         Reviewed by Sam Weinig.
2536
2537         The rebuilds were happening due to a difference in the compiler options that the IDE and
2538         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
2539         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
2540         specify an appropriate path in CLANG_INDEX_STORE_PATH.
2541
2542         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2543         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2544         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
2545         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2546         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
2547         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2548         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2549         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2550
2551 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
2552
2553         webkitpy: Reduce polling in ServerProcess
2554         https://bugs.webkit.org/show_bug.cgi?id=173116
2555
2556         Reviewed by Ryosuke Niwa.
2557
2558         We should be smarter about polling. We do not need to poll every time a line is read from
2559         stdout and stderr since lines are usually read from cached data. We should only poll
2560         when extracting that cached data from stdout and stderr.
2561
2562         * Scripts/webkitpy/port/driver.py:
2563         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
2564         and on ServerProcess to poll the process if not data is available in stdout and stderr.
2565         * Scripts/webkitpy/port/driver_unittest.py:
2566         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
2567         ServerProcess.
2568         * Scripts/webkitpy/port/server_process.py:
2569         (ServerProcess._read): Allow for data to be read from _output even if the process has
2570         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
2571         * Scripts/webkitpy/port/server_process_mock.py:
2572         (MockServerProcess): Add number_of_times_polled.
2573         (MockServerProcess.poll): Increment number_of_times_polled.
2574         (MockServerProcess.has_crashed): Poll before returning crash state.
2575         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
2576         just like a ServerProcess would.
2577         (MockServerProcess.read_stdout): Ditto.
2578         * Scripts/webkitpy/port/server_process_unittest.py:
2579         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
2580         process from ending before stdout and stderr are read. This is the reason this test was flakey.
2581         (TestServerProcess):
2582         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
2583         the processes is polled.
2584         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
2585         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
2586
2587 2017-06-10  Andy Estes  <aestes@apple.com>
2588
2589         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
2590         https://bugs.webkit.org/show_bug.cgi?id=173190
2591         <rdar://problem/31360659>
2592
2593         Reviewed by Brady Eidson.
2594         
2595         Added a release assert that tries to create a proper test failure if the web process crashes.
2596
2597         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2598         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
2599
2600 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
2601
2602         [iOS DnD] Add a hook to perform two-step drops in editable content
2603         https://bugs.webkit.org/show_bug.cgi?id=172992
2604         <rdar://problem/32590174>
2605
2606         Reviewed by Tim Horton.
2607
2608         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2609         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2610                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2611
2612         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2613         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2614         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2615
2616         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2617         be overridden. Currently, this is overridden to just return true.
2618
2619         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2620         (TestWebKitAPI::TEST):
2621         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2622         (WTR::InjectedBundlePage::InjectedBundlePage):
2623
2624 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2625
2626         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2627         https://bugs.webkit.org/show_bug.cgi?id=173103
2628
2629         Reviewed by Xabier Rodriguez-Calvar.
2630
2631         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2632         when building the WPE port through build-webkit.
2633
2634 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2635
2636         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2637         https://bugs.webkit.org/show_bug.cgi?id=173136
2638
2639         Reviewed by Xabier Rodriguez-Calvar.
2640
2641         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2642
2643 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2644
2645         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2646         https://bugs.webkit.org/show_bug.cgi?id=173098
2647
2648         Reviewed by Žan Doberšek.
2649
2650         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2651         assuming that all tests containing forms define ids for the form elements like
2652         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2653
2654         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2655         (formControlsAssociatedCallback):
2656
2657 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2658
2659         webkitpy: Run sample/spindump on iOS devices
2660         https://bugs.webkit.org/show_bug.cgi?id=171881
2661         <rdar://problem/32084602>
2662
2663         Reviewed by Daniel Bates.
2664
2665         * Scripts/webkitpy/port/darwin.py:
2666         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2667         requires sudo to run spindump.
2668         * Scripts/webkitpy/port/ios_device.py:
2669         (IOSDevicePort.look_for_new_samples): Deleted.
2670         (IOSDevicePort.sample_process): Deleted.
2671         * Scripts/webkitpy/port/ios_device_unittest.py:
2672         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2673         (IOSDeviceTest.test_spindump):
2674         (IOSDeviceTest.test_sample_process):
2675         (IOSDeviceTest.test_sample_process_exception):
2676         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2677         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2678
2679 2017-06-08  Keith Miller  <keith_miller@apple.com>
2680
2681         WebAssembly: We should only create wrappers for functions that can be exported
2682         https://bugs.webkit.org/show_bug.cgi?id=173088
2683
2684         Reviewed by Saam Barati.
2685
2686         Add quick mode for wasm tests.
2687
2688         * Scripts/run-jsc-stress-tests:
2689
2690 2017-06-08  Darin Adler  <darin@apple.com>
2691
2692         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2693         https://bugs.webkit.org/show_bug.cgi?id=173106
2694
2695         Reviewed by Sam Weinig.
2696
2697         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2698         destroyed last.
2699         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2700         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2701
2702 2017-06-07  Dan Bernstein  <mitz@apple.com>
2703
2704         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2705         https://bugs.webkit.org/show_bug.cgi?id=173086
2706
2707         Reviewed by Andy Estes.
2708
2709         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2710         (TEST):
2711
2712 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2713
2714         Add High Sierra support to WebKit tools
2715         https://bugs.webkit.org/show_bug.cgi?id=173080
2716
2717         Rubber-stamped by Daniel Bates.
2718
2719         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2721         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2722         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2723         Added dashboard support.
2724
2725         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2726         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2727         Trigger the right build queues on check-in.
2728
2729         * Scripts/webkitpy/common/system/platforminfo.py:
2730         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2731         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2732         * Scripts/webkitpy/port/mac.py:
2733         * Scripts/webkitpy/port/mac_unittest.py:
2734         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2735         Added cases for Sierra, and updated tests for new baseline search paths.
2736
2737 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2738
2739         Unreviewed, rolling out r217902.
2740
2741         This change appears to have caused imported/w3c/web-platform-
2742         tests/fetch/api/cors tests to fail on El Capitan.
2743
2744         Reverted changeset:
2745
2746         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2747         https://bugs.webkit.org/show_bug.cgi?id=172930
2748         http://trac.webkit.org/changeset/217902
2749
2750 2017-06-07  Daniel Bates  <dabates@apple.com>
2751
2752         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2753         https://bugs.webkit.org/show_bug.cgi?id=172930
2754         <rdar://problem/32570201>
2755
2756         Reviewed by Youenn Fablet.
2757
2758         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2759         that is conditioned on the page being delivered over a secure protocol. One example of such
2760         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2761
2762         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2763         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2764         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2765
2766         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2767         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2768         to the Web Platform Tests HTTPS server.
2769         * Scripts/webkitpy/port/base.py:
2770         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2771         * Scripts/webkitpy/port/driver.py:
2772         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2773         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2774         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2775         indicate that they should be considered private instance variables.
2776         (Driver.is_web_platform_test): Update code for renamed instance variables.
2777         (Driver):
2778         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2779         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2780         determine the base URL to use to access the test.
2781         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2782         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2783
2784 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2785
2786         Support removal of authentication data through the Website data store API.
2787         https://bugs.webkit.org/show_bug.cgi?id=171217
2788
2789         Reviewed by Brady Eidson.
2790
2791         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2792         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2793         (WTR::InjectedBundle::didReceiveMessageToPage):
2794         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2795         (WTR::TestRunner::removeAllSessionCredentials):
2796         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2797         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2798         * WebKitTestRunner/TestController.h:
2799         * WebKitTestRunner/TestInvocation.cpp:
2800         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2801         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2802         * WebKitTestRunner/TestInvocation.h:
2803         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2804         (WTR::TestController::removeAllSessionCredentials):
2805
2806 2017-06-07  Charlie Turner  <cturner@igalia.com>
2807
2808         Add Charlie Turner as contributor
2809         https://bugs.webkit.org/show_bug.cgi?id=173055
2810
2811         Reviewed by Carlos Alberto Lopez Perez.
2812
2813         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2814         of webkit-patch upload, which reordered some fields and removed a newline.
2815
2816         * Scripts/webkitpy/common/config/contributors.json:
2817
2818 2017-06-06  Chris Dumez  <cdumez@apple.com>
2819
2820         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2821         https://bugs.webkit.org/show_bug.cgi?id=173033
2822         <rdar://problem/32591099>
2823
2824         Reviewed by Simon Fraser.
2825
2826         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2827         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2828
2829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2830         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2831         (TestWebKitAPI::didFinishLoadForFrame):
2832         (TestWebKitAPI::setPageLoaderClient):
2833         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2834         (TestWebKitAPI::TEST):
2835
2836 2017-06-06  Andy Estes  <aestes@apple.com>
2837
2838         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2839         https://bugs.webkit.org/show_bug.cgi?id=172849
2840         <rdar://problem/32567454>
2841
2842         Reviewed by Darin Adler.
2843
2844         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2845         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2846         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2847         (TestWebKitAPI::TEST):
2848
2849 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2850
2851         [preload] Conditional support for media preloading and align media `as` values.
2852         https://bugs.webkit.org/show_bug.cgi?id=172501
2853
2854         Reviewed by Dean Jackson.
2855
2856         Turn on media preloading preference for tests.
2857
2858         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2859         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2860         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2861
2862 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2863
2864         webkitpy: Return correct process names from SimulatorProcess
2865         https://bugs.webkit.org/show_bug.cgi?id=172940
2866
2867         Reviewed by Aakash Jain.
2868
2869         * Scripts/webkitpy/port/darwin.py:
2870         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2871         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2872         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2873         * Scripts/webkitpy/port/driver.py:
2874         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2875         _server_process.name() will not return the correct process name for iOS.
2876         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2877         (Driver._read_block): Ditto.
2878         * Scripts/webkitpy/port/driver_unittest.py:
2879         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2880         process_name() instead of name().
2881         * Scripts/webkitpy/port/server_process.py:
2882         (ServerProcess._start): Use process_name() instead of name().
2883         (ServerProcess.stop): Ditto.
2884         (ServerProcess.name): Deleted.
2885         * Scripts/webkitpy/port/simulator_process.py:
2886         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2887
2888 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2889
2890         test-webkitpy: stop forking unsafely from within a spawned process
2891         https://bugs.webkit.org/show_bug.cgi?id=172774
2892
2893         Reviewed by Darin Adler.
2894
2895         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2896         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2897         it's going to be used.
2898         (Builder.force_build):
2899
2900 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2901
2902         webkitpy: Process crash-logs for iOS devices
2903         https://bugs.webkit.org/show_bug.cgi?id=171976
2904         <rdar://problem/32134551>
2905
2906         Reviewed by David Kilzer.
2907
2908         When running layout tests on an iOS device, crash logs should be processed.
2909         Implement crash log searching and parsing for iOS devices.
2910
2911         * Scripts/webkitpy/common/system/crashlogs.py:
2912         (CrashLogs): Moved process regular expression for Darwin to class variable.
2913         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2914         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2915         (CrashLogs.find_all_logs): Ditto.
2916         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2917         Do not assume that a Darwin crash log starts with the process.
2918         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2919         shared code for parsing Darwin crash logs.
2920         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2921         object so that crash logs already on the system before testing are not parsed.
2922         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2923         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2924         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2925         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2926         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2927         * Scripts/webkitpy/common/system/systemhost.py:
2928         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2929         systems is just the crashlog, use this behavior by default.
2930         * Scripts/webkitpy/common/system/systemhost_mock.py:
2931         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2932         systems is just the crashlog, use this behavior by default.
2933         * Scripts/webkitpy/port/apple.py:
2934         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2935         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2936         the system before testing begins
2937         * Scripts/webkitpy/port/base.py:
2938         (Port._get_crash_log): Pass optional target host when getting crash logs.
2939         * Scripts/webkitpy/port/darwin.py:
2940         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2941         CrashLogs object.
2942         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2943         logs to be skipped to CrashLogs object.
2944         * Scripts/webkitpy/port/darwin_testcase.py:
2945         (DarwinTest.test_get_crash_log): Removed unused local function.
2946         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2947         * Scripts/webkitpy/port/device.py:
2948         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2949         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2950         * Scripts/webkitpy/port/driver.py:
2951         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2952         * Scripts/webkitpy/port/gtk.py:
2953         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2954         * Scripts/webkitpy/port/ios.py: Ditto.
2955         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2956         to be skipped for each host.
2957         * Scripts/webkitpy/port/ios_device.py:
2958         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2959         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2960         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2961         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2962         host is specified. Else, search all connected devices for the specified crash-log.
2963         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2964         * Scripts/webkitpy/port/ios_device_unittest.py:
2965         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2966         (IOSDeviceTest.test_get_crash_log): Ditto.
2967         * Scripts/webkitpy/port/simulator_process.py:
2968         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2969         * Scripts/webkitpy/port/win.py:
2970         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2971         logs to be skipped to CrashLogs object.
2972         * Scripts/webkitpy/port/wpe.py:
2973         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2974
2975 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2976
2977         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2978         <https://webkit.org/b/172804>
2979
2980         Reviewed by Darin Adler.
2981
2982         WTF_ATTRIBUTE_PRINTF() only works outside the current
2983         compilation unit if it's on the declaration, not the
2984         implementation, of a function or class method.
2985
2986         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2987         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2988         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2989         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2990         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2991         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2992         - Remove redundant CRASH() macro definition.  Use the one from
2993           <wtf/Assertions.h> instead.
2994
2995 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2996
2997         Move Resource Timing / User Timing from experimental features into main preferences
2998         https://bugs.webkit.org/show_bug.cgi?id=172950
2999
3000         Reviewed by Darin Adler.
3001
3002         * DumpRenderTree/mac/DumpRenderTree.mm:
3003         (enableExperimentalFeatures):
3004         (resetWebPreferencesToConsistentValues):
3005         * DumpRenderTree/win/DumpRenderTree.cpp:
3006         (enableExperimentalFeatures):
3007         (resetWebPreferencesToConsistentValues):
3008         * WebKitTestRunner/TestController.cpp:
3009         (WTR::TestController::resetPreferencesToConsistentValues):
3010         Move out no longer experimental features to the main list.
3011
3012 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3013
3014         [WPE] Add an install-dependencies script
3015         https://bugs.webkit.org/show_bug.cgi?id=172948
3016
3017         Reviewed by Žan Doberšek.
3018
3019         It is based on the gtk/install-dependencies script.
3020         Includes support for Debian based distrubutions, Fedora and Arch.
3021         It has been tested on a minimal Debian 9 chroot.
3022
3023         * wpe/install-dependencies: Added.
3024
3025 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
3026
3027         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
3028         https://bugs.webkit.org/show_bug.cgi?id=172891
3029         <rdar://problem/32204540>
3030
3031         Reviewed by Darin Adler.
3032
3033         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
3034         contenteditable. See WebCore ChangeLog for more details.
3035
3036         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3037         (TestWebKitAPI::TEST):
3038
3039 2017-06-05  Daniel Bates  <dabates@apple.com>
3040
3041         webkitpy: Abstract Executive class
3042         https://bugs.webkit.org/show_bug.cgi?id=172928
3043         <rdar://problem/32569531>
3044
3045         Reviewed by Ryosuke Niwa.
3046
3047         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
3048         This will make it straightforward to create additional derived classes that
3049         adhere to the same interface, say for iOS on-device testing.
3050
3051         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
3052         (AbstractExecutive):
3053         (AbstractExecutive.run_and_throw_if_fail):
3054         (AbstractExecutive.cpu_count):
3055         (AbstractExecutive.interpreter_for_script):
3056         (AbstractExecutive.shell_command_for_script):
3057         (AbstractExecutive.kill_process):
3058         (AbstractExecutive.check_running_pid):
3059         (AbstractExecutive.running_pids):
3060         (AbstractExecutive.wait_newest):
3061         (AbstractExecutive.wait_limited):
3062         (AbstractExecutive.interrupt):
3063         (AbstractExecutive.default_error_handler):
3064         (AbstractExecutive.ignore_error):
3065         (AbstractExecutive._stringify_args):
3066         (AbstractExecutive.command_for_printing):
3067         (AbstractExecutive.run_command):
3068         (AbstractExecutive.popen):
3069         (AbstractExecutive.run_in_parallel):
3070         * Scripts/webkitpy/common/system/executive.py:
3071         (Executive):
3072         (Executive.cpu_count):
3073         (Executive.running_pids):
3074         (Executive.kill_all):
3075         (Executive._compute_stdin):
3076         (Executive.interpreter_for_script): Deleted.
3077         (Executive.shell_command_for_script): Deleted.
3078         (Executive.wait_newest): Deleted.
3079         (Executive.wait_limited): Deleted.
3080         (Executive.default_error_handler): Deleted.
3081         (Executive.ignore_error): Deleted.
3082         (Executive.command_for_printing): Deleted.
3083
3084 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
3085
3086         webkitpy: Add iOS to platform
3087         https://bugs.webkit.org/show_bug.cgi?id=172931
3088
3089         Reviewed by Daniel Bates.
3090
3091         * Scripts/webkitpy/common/system/platforminfo.py:
3092         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
3093         (PlatformInfo.is_ios): Added.
3094         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
3095         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3096         (MockPlatformInfo.is_ios): Added.
3097
3098 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3099
3100         [WPE][JHBuild] Switch github repository from git:// to https://
3101         https://bugs.webkit.org/show_bug.cgi?id=172921
3102
3103         Reviewed by Alex Christensen.
3104
3105         * wpe/jhbuild.modules:
3106
3107 2017-06-05  Tim Horton  <timothy_horton@apple.com>
3108
3109         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
3110         https://bugs.webkit.org/show_bug.cgi?id=172887
3111         <rdar://problem/32546061>
3112
3113         Reviewed by Sam Weinig.
3114
3115         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3116         (WTR::UIScriptController::applyAutocorrection):
3117         applyAutocorrection can call its completion handler synchronously,
3118         which makes UIScriptController unhappy (see bug 172884).
3119
3120 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
3121
3122         webkitpy: Add contextmanager to disable logging for a block
3123         https://bugs.webkit.org/show_bug.cgi?id=172876
3124
3125         Reviewed by Daniel Bates.
3126
3127         Add a context manager which will use an OutputCapture object to capture logging
3128         in a block and hold it in a variable.
3129
3130         * Scripts/webkitpy/common/system/outputcapture.py:
3131         (OutputCaptureScope):
3132         (OutputCaptureScope.__init__): Construct with OutputCapture object.
3133         (OutputCaptureScope.__enter__): Begin capturing output. 
3134         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
3135         output and retain the resulting log.
3136         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3137         (OutputCaptureTest.test_output_capture_scope): Added.
3138
3139 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3140
3141         Cleanup FrameView::autoSizeIfEnabled.
3142         https://bugs.webkit.org/show_bug.cgi?id=172889
3143         <rdar://problem/32550783>
3144
3145         Reviewed by Tim Horton.
3146
3147         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
3148         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
3149         (TEST):
3150
3151 2017-06-02  Chris Dumez  <cdumez@apple.com>
3152
3153         ResourceLoadStatistics are not using unique paths during test runs
3154         https://bugs.webkit.org/show_bug.cgi?id=172861
3155         <rdar://problem/32442251>
3156
3157         Reviewed by Darin Adler.
3158
3159         Make sure WebKitTestRunner sets a temporary path for saving resource
3160         load statistics.
3161
3162         * WebKitTestRunner/TestController.cpp:
3163         (WTR::TestController::generateContextConfiguration):
3164
3165 2017-06-02  Brady Eidson  <beidson@apple.com>
3166
3167         Prevent scheme handlers from handling all built-in URL schemes.
3168         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
3169
3170         Reviewed by Andy Estes.
3171
3172         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
3173
3174 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
3175
3176         [JSCOnly] Build static jsc.exe on Windows
3177         https://bugs.webkit.org/show_bug.cgi?id=172833
3178
3179         Reviewed by Konstantin Tokarev.
3180
3181         * CMakeLists.txt:
3182         * Scripts/build-jsc:
3183
3184 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3185
3186         Disable ViewportSizeForViewportUnits tests on iOS.
3187         https://bugs.webkit.org/show_bug.cgi?id=172872
3188
3189         Reviewed by Tim Horton.
3190
3191         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
3192
3193 2017-06-02  Zalan Bujtas  <zalan@apple.com>
3194
3195         Allow clients to override viewport size for CSS viewport units.
3196         https://bugs.webkit.org/show_bug.cgi?id=172838
3197         <rdar://problem/32523441>
3198
3199         Reviewed by Tim Horton.
3200
3201         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3202         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
3203         (TEST):
3204
3205 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
3206
3207         Get <chrono> out of StdLibExtras.h
3208         https://bugs.webkit.org/show_bug.cgi?id=172744
3209
3210         Reviewed by Zalan Bujtas.
3211
3212         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3213
3214 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
3215
3216         [WPE] Enable SUBTLE_CRYPTO
3217         https://bugs.webkit.org/show_bug.cgi?id=172756
3218
3219         Reviewed by Michael Catanzaro.
3220
3221         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
3222         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
3223         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
3224         exhausting entropy when running the crypto layout tests.
3225
3226 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3227
3228         [GTK] Bump GTK+ and its dependencies in jhbuild
3229         https://bugs.webkit.org/show_bug.cgi?id=171918
3230
3231         Reviewed by Carlos Alberto Lopez Perez.
3232
3233         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3234         (WTR::initializeGtkSettings):
3235         * gtk/jhbuild.modules:
3236         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
3237         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
3238
3239 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3240
3241         [GTK] Bump wayland and weston in jhbuild
3242         https://bugs.webkit.org/show_bug.cgi?id=171921
3243
3244         Reviewed by Carlos Alberto Lopez Perez.
3245
3246         * gtk/jhbuild.modules:
3247         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
3248
3249 2017-06-01  Andy Estes  <aestes@apple.com>
3250
3251         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
3252         https://bugs.webkit.org/show_bug.cgi?id=172828
3253
3254         Reviewed by Beth Dakin.
3255
3256         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3257
3258 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3259
3260         webkitpy: Remove unneeded simulator teardown
3261         https://bugs.webkit.org/show_bug.cgi?id=171891
3262
3263         Reviewed by Aakash Jain.
3264
3265         * Scripts/webkitpy/port/ios_simulator.py:
3266         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
3267         for communication between Python and WebKitTestRunner/DumpRenderTree.
3268
3269 2017-06-01  Keith Miller  <keith_miller@apple.com>
3270
3271         Undo rollout in r217638 with bug fix
3272         https://bugs.webkit.org/show_bug.cgi?id=172824
3273
3274         Unreviewed, reland patch with unused set_state code removed.
3275
3276         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3277         (runThreadMessageTest):
3278         (TEST):
3279
3280 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
3281
3282         webkitpy: Do not send 0 or -1 as a pid to kill_process
3283         https://bugs.webkit.org/show_bug.cgi?id=172818
3284
3285         Reviewed by Darin Adler.
3286
3287         Sending a signal to process 0 will result in all processes in the group receiving 
3288         the signal. Sending a signal to process -1 will result in all non-system processes
3289         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
3290         should consider these cases
3291
3292         * Scripts/webkitpy/common/system/executive.py:
3293         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
3294         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
3295         never be running, although os.kill may succeed.
3296         * Scripts/webkitpy/port/simulator_process.py:
3297         (SimulatorProcess.stop): Do not kill process if it is undefined.
3298
3299 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
3300
3301         JSC EWS bot does not run on WTF only patches
3302         https://bugs.webkit.org/show_bug.cgi?id=172777
3303         rdar://problem/32495975
3304
3305         Reviewed by Aakash Jain.
3306
3307         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
3308         (CheckPatchRelevance): Add a missing comma.
3309
3310 2017-05-31  Commit Queue  <commit-queue@webkit.org>
3311
3312         Unreviewed, rolling out r217611 and r217631.
3313         https://bugs.webkit.org/show_bug.cgi?id=172785
3314
3315         "caused wasm-hashset-many.html to become flaky." (Requested by
3316         keith_miller on #webkit).
3317
3318         Reverted changesets:
3319
3320         "Reland r216808, underlying lldb bug has been fixed."
3321         https://bugs.webkit.org/show_bug.cgi?id=172759
3322         http://trac.webkit.org/changeset/217611
3323
3324         "Use dispatch queues for mach exceptions"
3325         https://bugs.webkit.org/show_bug.cgi?id=172775
3326         http://trac.webkit.org/changeset/217631
3327
3328 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3329
3330         EWS bots should reboot themselves more frequently
3331         https://bugs.webkit.org/show_bug.cgi?id=172402
3332
3333         Reviewed by Alexey Proskuryakov.
3334
3335         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
3336
3337         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
3338
3339 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
3340
3341         Reallocate hardware for iOS bots.
3342         https://bugs.webkit.org/show_bug.cgi?id=172657
3343
3344         Reviewed by Alexey Proskuryakov.
3345
3346         * BuildSlaveSupport/build.webkit.org-config/config.json:
3347
3348 2017-05-31  Andy Estes  <aestes@apple.com>
3349
3350         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
3351         https://bugs.webkit.org/show_bug.cgi?id=172366
3352
3353         Reviewed by Daniel Bates.
3354
3355         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3356
3357 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
3358
3359         Unreviewed, add Jiewen Tan as a reviewer
3360
3361         * Scripts/webkitpy/common/config/contributors.json:
3362
3363 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
3364
3365         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
3366         https://bugs.webkit.org/show_bug.cgi?id=172770
3367
3368         Reviewed by Michael Catanzaro.
3369
3370         * MiniBrowser/gtk/BrowserWindow.c:
3371         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
3372         which caused the body of the if-clause to be accidentally empty.
3373
3374 2017-05-31  Keith Miller  <keith_miller@apple.com>
3375
3376         Reland r216808, underlying lldb bug has been fixed.
3377         https://bugs.webkit.org/show_bug.cgi?id=172759
3378
3379         Unreviewed, relanding old patch. See: rdar://problem/31183352
3380
3381         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
3382         (runThreadMessageTest):
3383         (TEST):
3384
3385 2017-05-31  Matt Lewis  <jlewis3@apple.com>
3386
3387         Unreviewed, rolling out r217603.
3388
3389         This patch broke the internal builds.
3390
3391         Reverted changeset:
3392
3393         "Get <chrono> out of StdLibExtras.h"
3394         https://bugs.webkit.org/show_bug.cgi?id=172744
3395         http://trac.webkit.org/changeset/217603
3396
3397 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
3398
3399         Make ResourceLoadStatistics testing more reliable
3400         https://bugs.webkit.org/show_bug.cgi?id=172730
3401         <rdar://problem/32028373>
3402
3403         Reviewed by Andy Estes.
3404
3405         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
3406         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
3407
3408         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3409         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
3410
3411 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3412
3413         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
3414         https://bugs.webkit.org/show_bug.cgi?id=172757
3415
3416         Reviewed by Xabier Rodriguez-Calvar.
3417
3418         When needed, add the jhbuild wrapper at the beginning of the array
3419         that will be invoked to execute the run-jsc-stress-test or testapi
3420         commands.
3421
3422         * Scripts/run-javascriptcore-tests:
3423         (runJSCStressTests):
3424         * Scripts/webkitdirs.pm:
3425         (shouldUseJhbuild):
3426
3427 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
3428
3429         Get <chrono> out of StdLibExtras.h
3430         https://bugs.webkit.org/show_bug.cgi?id=172744
3431
3432         Reviewed by Saam Barati.
3433
3434         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3435
3436 2017-05-30  Tim Horton  <timothy_horton@apple.com>
3437
3438         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
3439         https://bugs.webkit.org/show_bug.cgi?id=172735
3440         <rdar://problem/32015977>
3441
3442         Reviewed by Enrica Casucci.
3443
3444         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3445         (WTR::UIScriptController::applyAutocorrection):
3446         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3447         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3448         (WTR::UIScriptController::applyAutocorrection):
3449         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3450         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3451         (WTR::UIScriptController::applyAutocorrection):
3452         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
3453         because I don't know how to tap the button in the autocorrection bar from a test.
3454
3455 2017-05-30  Daniel Bates  <dabates@apple.com>
3456
3457         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
3458         https://bugs.webkit.org/show_bug.cgi?id=172671
3459
3460         Reviewed by Alex Christensen.
3461
3462         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
3463         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
3464
3465         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
3466         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
3467         to trigger a navigation to test it.
3468         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
3469         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
3470
3471 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
3472
3473         webkitpy: Start servers before setting-up for testing
3474         https://bugs.webkit.org/show_bug.cgi?id=172176
3475         <rdar://problem/32225538>
3476
3477         Reviewed by Alexey Proskuryakov.
3478
3479         On-device testing requires that servers are started before ports set-up their
3480         test environments.
3481
3482         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3483         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
3484         Servers are unconditionally stopped on exit.
3485         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
3486         Manager now stops servers.
3487         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
3488         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
3489         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3490         (Manager.__init__): Delay construction of the test runner until we can determine
3491         if servers need to be started.
3492         (Manager.run): Determine if servers need to be started and construct the test runner.
3493         Shut servers down when the test run is finished.
3494         (Manager._run_tests): Move the determination of servers to run into Manager.run.
3495         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3496         (is_wpt_server_running): Server is not running if no config is found.
3497         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
3498         (PyWebSocket.is_running): Check if this WebSocket server is running.
3499         * Scripts/webkitpy/port/base.py:
3500         (Port.__init__): Define secure WebSocket server.
3501         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
3502
3503 2017-05-30  Daniel Bates  <dabates@apple.com>
3504
3505         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
3506         https://bugs.webkit.org/show_bug.cgi?id=172603
3507         <rdar://problem/32471306>
3508
3509         Reviewed by Brady Eidson.
3510
3511         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
3512         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
3513         unloading is initiated for a page that registered a onbeforeunload handler.
3514
3515         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
3516         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
3517         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
3518
3519         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
3520         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
3521         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
3522         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
3523
3524         * MiniBrowser/mac/WK2BrowserWindowController.m:
3525         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3526         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
3527         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
3528         (sawDialog):
3529         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3530         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3531         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3532
3533 2017-05-30  Alex Christensen  <achristensen@webkit.org>
3534
3535         Update libwebrtc configuration
3536         https://bugs.webkit.org/show_bug.cgi?id=172727
3537
3538         Reviewed by Geoffrey Garen.
3539
3540         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3541
3542 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
3543
3544         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
3545         https://bugs.webkit.org/show_bug.cgi?id=172702
3546
3547         Reviewed by Alex Christensen.
3548
3549         EGL PlatformDisplay needs to be shut down before existing a
3550         program on Windows.
3551
3552         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
3553         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
3554         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3555         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
3556
3557 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
3558
3559         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
3560         https://bugs.webkit.org/show_bug.cgi?id=172709
3561
3562         Reviewed by Brent Fulgham.
3563
3564         Exit fullscreen mode after a fullscreen test.
3565
3566         * DumpRenderTree/win/DumpRenderTree.cpp:
3567         (resetWebViewToConsistentStateBeforeTesting):
3568
3569 2017-05-30  Antti Koivisto  <antti@apple.com>
3570
3571         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
3572         https://bugs.webkit.org/show_bug.cgi?id=172713
3573
3574         Reviewed by Zalan Bujtas.
3575
3576         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3577         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
3578
3579             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
3580             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
3581             because on Mac WK1 it may get invoked from middle of a layout.
3582
3583             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
3584
3585 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3586
3587         Add a WPE EWS queue
3588         https://bugs.webkit.org/show_bug.cgi?id=172693
3589
3590         Reviewed by Carlos Garcia Campos.
3591
3592         * QueueStatusServer/config/queues.py:
3593         * QueueStatusServer/model/queues.py: Capitalize the name of the
3594         port on the tooltip of the bubbles. Do the same for the GTK port.
3595         (Queue.display_name):
3596         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
3597         for the GTK+ EWS also. Set for both ports as watcher the alias
3598         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
3599         * Scripts/webkitpy/common/config/ports.py:
3600         (DeprecatedPort.port):
3601         (WpePort):
3602         (WpePort.build_webkit_command):
3603         (WpePort.run_webkit_tests_command):
3604         * Scripts/webkitpy/common/config/ports_unittest.py:
3605         (DeprecatedPortTest):
3606         (DeprecatedPortTest.test_wpe_port):
3607         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3608         (test_ews_name):
3609
3610 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
3611
3612         Unreviewed. Bumping the WPEBackend-mesa dependency version.
3613
3614         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
3615         priorities for IPC communication.
3616
3617 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3618