0cf692f6796d1eb712860018ee68f3a84abdb970
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-20  Ojan Vafai  <ojan@chromium.org>
2
3         Change the final place where we use version 3 of the results json output
4         https://bugs.webkit.org/show_bug.cgi?id=72838
5
6         Reviewed by Adam Barth.
7
8         This converts the json from being a flat map of test name --> results
9         to being hierarchical by directory. This will make the json files 
10         considerably smaller.
11
12         Also cleaned up some functions that were returning/checking boolean values
13         that were always True.
14
15         * TestResultServer/model/jsonresults.py:
16         * TestResultServer/model/jsonresults_unittest.py:
17
18 2011-11-20  Ojan Vafai  <ojan@chromium.org>
19
20         Include the master name when querying the test results server.
21         This will soon be required since leaving the master name out mean
22         that multiple files could match the query.
23
24         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
25
26 2011-11-19  Ojan Vafai  <ojan@chromium.org>
27
28         Fix jsonp callback code to add the callback if json content
29         is not jsonp.
30         * TestResultServer/handlers/testfilehandler.py:
31
32 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
33
34         Modify dashboard_base.js to optionally accept version 4 results json.
35
36         Reviewed by Ojan Vafai.
37
38         * TestResultServer/static-dashboards/dashboard_base.js:
39         (ADD_RESULTS):
40         (flattenTrie):
41         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
42         (testFlattenTrie):
43
44 2011-11-19  Ojan Vafai  <ojan@chromium.org>
45
46         Stop storing results files as jsonp in the test results server
47         https://bugs.webkit.org/show_bug.cgi?id=72814
48
49         Reviewed by Adam Barth.
50
51         * TestResultServer/model/jsonresults.py:
52         * TestResultServer/model/jsonresults_unittest.py:
53
54 2011-11-19  Ojan Vafai  <ojan@chromium.org>
55
56         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
57         https://bugs.webkit.org/show_bug.cgi?id=72813
58
59         Reviewed by Adam Barth.
60
61         Once this lands, we can start storing pure json in the test results server and then
62         we can delete the code with all the FIXMEs added here.
63
64         * Scripts/webkitpy/layout_tests/controllers/manager.py:
65         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
66         Only add jsonp for full_results.json.
67         * TestResultServer/model/jsonresults.py:
68         * TestResultServer/model/jsonresults_unittest.py:
69         Accept pure json uploads.
70         * TestResultServer/static-dashboards/dashboard_base.js:
71         (appendJSONScriptElementFor):
72         Use the callback parameter so that the server can start returning pure json if it's left out.
73
74 2011-11-19  Ojan Vafai  <ojan@chromium.org>
75
76         Allow json NRWT downloads to be pure json and not jsonp
77         https://bugs.webkit.org/show_bug.cgi?id=72809
78
79         Reviewed by Adam Barth.
80
81         I'm moving the server to storing and serving up raw json instead of jsonp.
82         You can still get the jsonp by passing a "callback" parameter, but there's no
83         need for run-webkit-tests to get jsonp when all it wants is the raw json.
84
85         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
86         Make the wrapper stripping only happen if the json is actually wrapped.
87         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
88
89 2011-11-18  Daniel Bates  <dbates@rim.com>
90
91         Add CMake build infrastructure for the BlackBerry port
92         https://bugs.webkit.org/show_bug.cgi?id=72768
93
94         Reviewed by Antonio Gomes.
95
96         Add optional --blackberry command line argument to build-webkit to build the
97         BlackBerry port.
98
99         * Scripts/build-webkit:
100         * Scripts/webkitdirs.pm:
101         (determineBaseProductDir):
102         (argumentsForConfiguration):
103         (builtDylibPathForName):
104         (determineIsQt):
105         (isBlackBerry): Added.
106         (determineIsBlackBerry): Added.
107         (blackberryTargetArchitecture): Added.
108         (isAppleWebKit):
109
110 2011-11-18  James Robinson  <jamesr@chromium.org>
111
112         Unreviewed, rolling out r100835.
113         http://trac.webkit.org/changeset/100835
114         https://bugs.webkit.org/show_bug.cgi?id=72778
115
116         Broke some page scale tests
117
118         * DumpRenderTree/chromium/EventSender.cpp:
119         (EventSender::scalePageBy):
120
121 2011-11-18  Adam Barth  <abarth@webkit.org>
122
123         Prepare to move manual-tests out of WebCore
124         https://bugs.webkit.org/show_bug.cgi?id=72782
125
126         Reviewed by Eric Seidel.
127
128         Update this file to refer to the new location of ManualTests.
129
130         * Scripts/webkitpy/common/config/build.py:
131
132 2011-11-18  James Robinson  <jamesr@chromium.org>
133
134         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
135         https://bugs.webkit.org/show_bug.cgi?id=72778
136
137         Reviewed by Kenneth Russell.
138
139         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
140
141         * DumpRenderTree/chromium/EventSender.cpp:
142         (EventSender::scalePageBy):
143
144 2011-11-18  Scott Graham  <scottmg@chromium.org>
145
146         IDL changes for gamepad support
147         https://bugs.webkit.org/show_bug.cgi?id=71753
148
149         Reviewed by Adam Barth.
150
151         Runtime enable gamepad in chromium test shell.
152
153         * DumpRenderTree/chromium/TestShell.cpp:
154         (TestShell::TestShell):
155
156 2011-10-27  Darin Fisher  <darin@chromium.org>
157
158         [chromium] Improve fullscreen API
159         https://bugs.webkit.org/show_bug.cgi?id=70477
160
161         Reviewed by Adam Barth.
162
163         Implement enter/exitFullScreen.  The implementation is asynchronous,
164         via postDelayedTask, to simulate how the browser actually behaves.
165
166         * DumpRenderTree/chromium/WebViewHost.cpp:
167         (WebViewHost::enterFullScreen):
168         (WebViewHost::exitFullScreen):
169         (WebViewHost::setAddressBarURL):
170         (WebViewHost::enterFullScreenNow):
171         (WebViewHost::exitFullScreenNow):
172         * DumpRenderTree/chromium/WebViewHost.h:
173
174 2011-11-18  Adam Roben  <aroben@apple.com>
175
176         Ignore an ANGLE leak that is not WebKit's fault
177
178         * Scripts/old-run-webkit-tests:
179         (countAndPrintLeaks):
180         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
181         (LeakDetector._callstacks_to_exclude_from_leaks):
182         Added ScanFromString to the call stacks to exclude on all OS versions.
183
184 2011-11-18  Adam Roben  <aroben@apple.com>
185
186         Ignore another Lion-specific leak that is not WebKit's fault
187
188         * Scripts/old-run-webkit-tests:
189         (countAndPrintLeaks):
190         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
191         (LeakDetector._callstacks_to_exclude_from_leaks):
192         Added SecTransformExecute to the call stacks to exclude.
193
194 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
195
196         [Qt] Enable WebSocket hybi tests
197         https://bugs.webkit.org/show_bug.cgi?id=72687
198
199         Reviewed by Simon Hausmann.
200
201         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
202
203         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
204         (WebCore::WebPage::resetSettings):
205         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
206         (LayoutTestController::overridePreference):
207
208 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
209
210         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
211         https://bugs.webkit.org/show_bug.cgi?id=72707
212
213         Reviewed by Philippe Normand.
214
215         Make new-run-webkit-tests use the right path to locate the test
216         plugin used by WebKitTestRunner.
217
218         * Scripts/webkitpy/layout_tests/port/gtk.py:
219
220 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
221
222         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
223         https://bugs.webkit.org/show_bug.cgi?id=72697
224
225         Reviewed by Kenneth Rohde Christiansen.
226
227         * Tools.pro: Make WTR linux only for the moment.
228         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
229         * WebKitTestRunner/Target.pri: Ditto.
230         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
231         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
232
233 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
234
235         [Qt] Change default size of the MiniBrowser
236
237         Reviewed by Simon Hausmann.
238
239         As we lay out desktop pages using the width of 980, change our default
240         size to 980x735 so that we are not scaling down by default.
241
242         * MiniBrowser/qt/MiniBrowserApplication.h:
243         (WindowOptions::WindowOptions):
244
245 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
246
247         [EFL] Clean up the use of DATA_DIR in the buildsystem
248         https://bugs.webkit.org/show_bug.cgi?id=72681
249
250         Reviewed by Daniel Bates.
251
252         Instead of adding -DDATA_DIR in all scopes, only define it in
253         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
254         it.
255
256         We can then define DATA_DIR to the generated theme directory for
257         EWebLauncher, since it's what we want here.
258
259         * CMakeListsEfl.txt:
260
261 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
262
263         [EFL] Move platform includes last in DRT's include directories.
264         https://bugs.webkit.org/show_bug.cgi?id=72684
265
266         Reviewed by Daniel Bates.
267
268         This is the first step in fixing the build when a platform include (in
269         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
270         is included instead of WebKit's.
271
272         * DumpRenderTree/efl/CMakeLists.txt:
273
274 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
275
276         fuzzy_match doesn't recognize "Dan B" or "hyatt"
277         https://bugs.webkit.org/show_bug.cgi?id=72636
278
279         Reviewed by Eric Seidel.
280
281         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
282         and user names of email addreses such as rniwa in rniwa@webkit.org.
283
284         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
285
286         * Scripts/webkitpy/common/config/committers.py:
287         * Scripts/webkitpy/common/config/committers_unittest.py:
288
289 2011-11-17  Eric Seidel  <eric@webkit.org>
290
291         Remove support for running check-webkit-style w/o a webkit checkout
292         https://bugs.webkit.org/show_bug.cgi?id=72678
293
294         Reviewed by Adam Barth.
295
296         After talking to Dave Levin we've decided to remove this
297         code.  I know of no users of check-webkit-style w/o a webkit checkout
298         and this needlessly adds complexity.
299
300         * Scripts/webkitpy/style/main.py:
301
302 2011-11-17  Eric Seidel  <eric@webkit.org>
303
304         Remove more direct uses of os.path
305         https://bugs.webkit.org/show_bug.cgi?id=72677
306
307         Reviewed by Adam Barth.
308
309         Remove more uses of os.path, including refactoring
310         CommitterValidator to use a Host object instead of
311         manual hacks to emulate what SCM and FileSystem provide.
312
313         * Scripts/webkitpy/common/checkout/changelog.py:
314         * Scripts/webkitpy/common/config/committervalidator.py:
315         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
316         * Scripts/webkitpy/common/system/filesystem_mock.py:
317          - Turns out none of our unittests actually looked at this path.
318            now I've made it be a valid path.
319         * Scripts/webkitpy/tool/bot/feeders.py:
320         * Scripts/webkitpy/tool/commands/queues.py:
321
322 2011-11-17  Eric Seidel  <eric@webkit.org>
323
324         Teach TextFileReader about FileSystem
325         https://bugs.webkit.org/show_bug.cgi?id=72673
326
327         Reviewed by Adam Barth.
328
329         Unfortunately TextFileReader doesn't use FileSystem
330         everywhere yet, so we can't move the unittests to
331         using MockFileSystem, but we're close.
332
333         * Scripts/webkitpy/style/filereader.py:
334         * Scripts/webkitpy/style/filereader_unittest.py:
335         * Scripts/webkitpy/style/main.py:
336
337 2011-11-17  Eric Seidel  <eric@webkit.org>
338
339         Give check-webkit-style a Host
340         https://bugs.webkit.org/show_bug.cgi?id=72670
341
342         Reviewed by Adam Barth.
343
344         * Scripts/webkitpy/common/checkout/scm/detection.py:
345         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
346          - We don't run these unittests, but this one was looking for the wrong exception.
347         * Scripts/webkitpy/style/main.py:
348         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
349          - This was create a new scm object even though it already had one?
350
351 2011-11-17  Eric Seidel  <eric@webkit.org>
352
353         Move check-webkit-style change_directory code to more modern mocks
354         https://bugs.webkit.org/show_bug.cgi?id=72664
355
356         Reviewed by Adam Barth.
357
358         * Scripts/check-webkit-style:
359         * Scripts/webkitpy/style/main.py:
360         * Scripts/webkitpy/style/main_unittest.py:
361
362 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
363
364         [GTK] enable ref tests
365         https://bugs.webkit.org/show_bug.cgi?id=72601
366
367         Re-enable ref tests. Run the driver under evenly numbered display if performing
368         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
369         being run in an already used Xvfb instance if pixel tests are disabled.
370
371         Reviewed by Tony Chang.
372
373         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
374         after the process is killed
375
376 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
377
378         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
379         https://bugs.webkit.org/show_bug.cgi?id=72620
380
381         Reviewed by David Levin.
382
383         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
384         adding the suffix the cpp file. One example of false positive
385         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
386
387         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
388         basename contains the cpp's basename.
389         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
390
391 2011-11-17  Eric Seidel  <eric@webkit.org>
392
393         Move check-webkit-style's guts into webkitpy/style/main.py
394         https://bugs.webkit.org/show_bug.cgi?id=72657
395
396         Reviewed by Adam Barth.
397
398         * Scripts/check-webkit-style:
399         * Scripts/webkitpy/style/main.py:
400
401 2011-11-17  Eric Seidel  <eric@webkit.org>
402
403         new-run-webkit-tests is locale dependent
404         https://bugs.webkit.org/show_bug.cgi?id=68691
405
406         Reviewed by Adam Barth.
407
408         Make NRWT use a clean environment, just like ORWT did.
409
410         * Scripts/webkitpy/layout_tests/port/base.py:
411         * Scripts/webkitpy/layout_tests/port/chromium.py:
412         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
413         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
414         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
415         * Scripts/webkitpy/layout_tests/port/efl.py:
416         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
417         * Scripts/webkitpy/layout_tests/port/mac.py:
418         * Scripts/webkitpy/layout_tests/port/qt.py:
419         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
420         * Scripts/webkitpy/layout_tests/port/webkit.py:
421         * Scripts/webkitpy/layout_tests/port/win.py:
422
423 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
424
425         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
426         https://bugs.webkit.org/show_bug.cgi?id=72615
427
428         Reviewed by James Robinson.
429
430         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
431
432 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
433
434         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
435         https://bugs.webkit.org/show_bug.cgi?id=72595
436
437         Reviewed by Noam Rosenthal.
438
439         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
440         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
441         ensure the registration of the DRTNode JS bindings.
442         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
443         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
444         registration of QWebElement (now done implicitly through QWebPage ->
445         QtWebElementRunTime::initialize code path)
446
447 2011-11-17  Adam Roben  <aroben@apple.com>
448
449         Fix a crash-inducing typo I introduced in r100648
450
451         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
452         handling a crashing test
453
454         Reviewed by Adam Barth.
455
456         * Scripts/webkitpy/layout_tests/port/chromium.py:
457         (ChromiumDriver.run_test): Get the driver name from the port.
458
459         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
460         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
461         right crashed process name.
462
463 2011-11-17  Adam Roben  <aroben@apple.com>
464
465         Fix NRWT's parsing of the number of excluded leaks
466
467         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
468         leaks were excluded
469
470         Reviewed by Adam Barth.
471
472         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
473         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
474         regular expression match, not the entire matched string.
475
476         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
477         (LeakDetectorTest): Added some example output that shows how things look when leaks are
478         excluded.
479         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
480         correctly.
481
482 2011-11-17  Adam Roben  <aroben@apple.com>
483
484         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
485
486         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
487         when web process crashes, but WebProcess crash log should get saved instead
488
489         Reviewed by Eric Seidel.
490
491         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
492         (write_test_result): Simplified a little to share more code between the case where we
493         crashed when running the test and where we crashed when checking the expected rendering for
494         a reftest. Changed to pass the crashed process name down to write_crash_report.
495         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
496         along to CrashLogs.find_newest_log rather than always using the driver name.
497
498         * Scripts/webkitpy/layout_tests/port/chromium.py:
499         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
500         crashed.
501
502         * Scripts/webkitpy/layout_tests/port/test.py:
503         (TestInstance.__init__): Initialize new web_process_crash attribute.
504         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
505         test this patch adds.
506         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
507         specifies that the driver crashed or the web process crashed.
508
509         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
510         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
511         which we pretend the web process crashed rather than the driver process.
512
513         (MainTest.test_run_singly_actually_runs_tests):
514         (MainTest.test_unexpected_failures):
515         (EndToEndTest.test_end_to_end):
516         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
517
518 2011-11-17  Tony Chang  <tony@chromium.org>
519
520         [chromium] stop spamming features warning on every build
521         https://bugs.webkit.org/show_bug.cgi?id=72629
522
523         Reviewed by Ojan Vafai.
524
525         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
526         $mediaStreamSupport is on by default for chromium, make the default
527         for $blobSupport also on.
528
529         * Scripts/build-webkit:
530
531 2011-11-17  Adam Roben  <aroben@apple.com>
532
533         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
534
535         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
536         that are supposed to be ignored
537
538         Reviewed by Adam Barth.
539
540         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
541         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
542         required when passing arguments via the shell (which we aren't doing here). It is not
543         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
544
545         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
546         (LeakDetectorTest.test_leaks_args): Updated expectations.
547
548 2011-11-17  Philippe Normand  <pnormand@igalia.com>
549
550         Unreviewed, run-bindings-tests fix after r91028.
551
552         * Scripts/run-bindings-tests: Use scm.detection module.
553
554 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
555
556         Silence a warning about control reaching the end of a non-void function
557         https://bugs.webkit.org/show_bug.cgi?id=72616
558
559         Reviewed by Tony Gentilcore.
560
561         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
562         (AccessibilityUIElement::verticalScrollbar):
563
564 2011-11-17  Adam Roben  <aroben@apple.com>
565
566         Ignore some leaks in frameworks we link against on Lion
567
568         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
569         aren't WebKit's fault
570
571         Reviewed by Antti Koivisto.
572
573         * Scripts/old-run-webkit-tests:
574         (countAndPrintLeaks):
575         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
576         (LeakDetector._callstacks_to_exclude_from_leaks):
577         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
578
579         * Scripts/webkitpy/layout_tests/port/mac.py:
580         (MacPort.is_lion): Added.
581
582         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
583         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
584         methods.
585
586 2011-11-17  Philippe Normand  <pnormand@igalia.com>
587
588         [GTK] Disable ref tests
589         https://bugs.webkit.org/show_bug.cgi?id=72599
590
591         Reviewed by Xan Lopez.
592
593         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
594         tests to avoid massive flakiness.
595
596 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
597
598         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
599
600         A new extension object has been added to QQuickWebView (the same approach should be used
601         for other API classes that need experimental APIs). The QML extension mechanism is then
602         built on top of the experimental object.
603
604         https://bugs.webkit.org/show_bug.cgi?id=72522
605
606         Reviewed by Simon Hausmann.
607
608         * MiniBrowser/qt/BrowserWindow.cpp:
609         (BrowserWindow::BrowserWindow):
610         (BrowserWindow::webView):
611         * MiniBrowser/qt/BrowserWindow.h:
612         * MiniBrowser/qt/UrlLoader.cpp:
613         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
614         * qmake/mkspecs/features/default_post.prf:
615         * qmake/mkspecs/features/default_pre.prf:
616         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
617         * qmake/mkspecs/features/qtwebkit.prf:
618
619 2011-11-17  Adam Barth  <abarth@webkit.org>
620
621         Move test_results_uploader.py out of layout_package
622         https://bugs.webkit.org/show_bug.cgi?id=72590
623
624         Reviewed by Eric Seidel.
625
626         Most of the lines of code in this file are wrong, but I've restrained
627         myself and only changed a few of them to generalized this class to the
628         common package.
629
630         This is part of a series of patches to remove layout_package.
631
632         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
633         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
634         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
635
636 2011-11-17  Adam Barth  <abarth@webkit.org>
637
638         Unreviewed. Fix style nits in printing.py.
639
640         * Scripts/webkitpy/layout_tests/views/printing.py:
641
642 2011-11-17  Adam Barth  <abarth@webkit.org>
643
644         Minor style nits in run_webkit_tests.py
645         https://bugs.webkit.org/show_bug.cgi?id=72583
646
647         Reviewed by Eric Seidel.
648
649         This patch just fixes some minor style issues as I work my way back
650         into this code.
651
652         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
653
654 2011-11-17  Adam Barth  <abarth@webkit.org>
655
656         Move test_result_writer out of layout_package
657         https://bugs.webkit.org/show_bug.cgi?id=72586
658
659         Rubber-stamped by Eric Seidel.
660
661         This is part of a series of patches to remove layout_package.
662
663         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
664         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
665         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
666         * Scripts/webkitpy/tool/commands/rebaseline.py:
667
668 2011-11-17  Adam Barth  <abarth@webkit.org>
669
670         svn-apply shouldn't magically move files into Source anymore
671         https://bugs.webkit.org/show_bug.cgi?id=72579
672
673         Reviewed by Eric Seidel.
674
675         The Source directory has existed for long enough that we don't need
676         svn-apply to magically re-write old-style patches anymore.
677
678         * Scripts/VCSUtils.pm:
679         (parseGitDiffHeader):
680         (parseSvnDiffHeader):
681
682 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
683
684         Add a list of contribution areas
685         https://bugs.webkit.org/show_bug.cgi?id=72566
686
687         Reviewed by Eric Seidel.
688
689         Added ContributionAreas class.
690
691         * Scripts/webkitpy/common/config/contributionareas.py: Added.
692         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
693
694 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
695
696         Refactor ChangeLogTest.test_parse_reviewer_text
697         https://bugs.webkit.org/show_bug.cgi?id=72572
698
699         Reviewed by Eric Seidel.
700
701         Refactored the test code by introduing two helper functions.
702
703         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
704
705 2011-11-16  Eric Seidel  <eric@webkit.org>
706
707         Add SCMDetector object to make scm detection mockable
708         https://bugs.webkit.org/show_bug.cgi?id=72247
709
710         Reviewed by Adam Barth.
711
712         I think SCM detection may eventually be rolled into Checkout,
713         but this patch at least makes it possible to mock code-paths
714         which rely on scm detection.
715         In the process of replacing callers of these free-functions
716         I found that one of the functions was no longer used,
717         and that one of the callers could instead just use the SCM
718         object it already had access to through port.host.scm().
719         I also discovered that I was not calling Host._initialize_scm()
720         and thus host.scm() was always returning None!
721
722         * Scripts/check-webkit-style:
723         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
724         * Scripts/webkitpy/common/checkout/deps.py:
725         * Scripts/webkitpy/common/checkout/scm/__init__.py:
726         * Scripts/webkitpy/common/checkout/scm/detection.py:
727         * Scripts/webkitpy/common/checkout/scm/git.py:
728         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
729         * Scripts/webkitpy/common/checkout/scm/svn.py:
730         * Scripts/webkitpy/common/host.py:
731         * Scripts/webkitpy/common/host_mock.py:
732         * Scripts/webkitpy/layout_tests/controllers/manager.py:
733         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
734         * Scripts/webkitpy/layout_tests/port/base.py:
735         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
736         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
737         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
738         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
739
740 2011-11-16  Mark Rowe  <mrowe@apple.com>
741
742         Fix the build.
743
744         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
745         Apply the workaround that we use in other projects to WebKitTestRunner.
746
747         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
748         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
749         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
750
751 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
752
753         [Qt] Fix build after WTR AX support
754         https://bugs.webkit.org/show_bug.cgi?id=72560
755
756         Reviewed by Geoffrey Garen.
757
758         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
759         * WebKitTestRunner/InjectedBundle/Target.pri:
760
761 2011-11-16  Tony Chang  <tony@chromium.org>
762
763         repurpose the flexbox bot for grid layout
764         https://bugs.webkit.org/show_bug.cgi?id=72557
765
766         Reviewed by Ryosuke Niwa.
767
768         Since new flexbox is enabled everywhere, we don't need this bot
769         anymore.  However, work on grid layout has begun, so we can use this
770         bot to compile with ENABLE_CSS_GRID_LAYOUT.
771
772         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
773         the bot on the waterfall, I will change the slave config to enable
774         the compile flag and tests.
775
776 2011-11-11  Adrienne Walker  <enne@google.com>
777
778         [chromium] Expose mock scrollbars to window.internals
779         https://bugs.webkit.org/show_bug.cgi?id=72195
780
781         Reviewed by James Robinson.
782
783         Because mock scrollbars are a global setting, reset between runs.
784
785         * DumpRenderTree/chromium/WebPreferences.cpp:
786         (WebPreferences::applyTo):
787
788 2011-11-16  James Robinson  <jamesr@chromium.org>
789
790         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
791         https://bugs.webkit.org/show_bug.cgi?id=72562
792
793         Reviewed by Dirk Pranke.
794
795         * DumpRenderTree/chromium/TestShell.cpp:
796         (TestShell::runFileTest):
797
798 2011-11-16  Tony Chang  <tony@chromium.org>
799
800         [NRWT] speculative fix for multiple subprocess test on cygwin
801         https://bugs.webkit.org/show_bug.cgi?id=72518
802
803         Reviewed by Adam Barth.
804
805         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
806             tries to emulate posix fd behavior.
807         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
808
809 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
810
811         Revert r100509; change was committed twice (first time as r100491).
812         Unreviewed, build fix.
813
814         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
815
816 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
817
818         Run a dummy test in the gpu configurations if there's nothing to do.
819         https://bugs.webkit.org/show_bug.cgi?id=72498
820
821         Reviewed by James Robinson.
822
823         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
824
825 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
826
827         contributors_by_fuzzy_match is super slow
828         https://bugs.webkit.org/show_bug.cgi?id=72540
829
830         Reviewed by Eric Seidel.
831
832         Make contributors_by_name do case insensitive search using a dictionary.
833
834         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
835         because that's the most common case.
836
837         * Scripts/webkitpy/common/config/committers.py:
838         * Scripts/webkitpy/common/config/committers_unittest.py:
839
840 2011-11-16  David Levin  <levin@chromium.org>
841
842         check-webkit-style should recognize functions even if they have OVERRIDE after them.
843         https://bugs.webkit.org/show_bug.cgi?id=72515
844
845         Reviewed by Adam Barth.
846
847         * Scripts/webkitpy/style/checkers/cpp.py:
848         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
849
850 2011-11-16  Tony Chang  <tony@chromium.org>
851
852         [NRWT] refactor drivers to require pixel_tests param
853         https://bugs.webkit.org/show_bug.cgi?id=72517
854
855         Reviewed by Ojan Vafai.
856
857         No tests, just a refactoring.
858
859         * Scripts/webkitpy/layout_tests/port/chromium.py:
860         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
861         * Scripts/webkitpy/layout_tests/port/webkit.py:
862         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
863
864 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
865
866         Run a dummy test in the gpu configurations if there's nothing to do.
867         https://bugs.webkit.org/show_bug.cgi?id=72498
868
869         Reviewed by James Robinson.
870
871         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
872
873 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
874
875         WebKitTestRunner needs to support accessibility-related DRT APIs
876         https://bugs.webkit.org/show_bug.cgi?id=42131
877
878         Reviewed by Beth Dakin.
879
880         Port the AX code in DRT to WKTestRunner by using IDL.
881
882         * DumpRenderTree/AccessibilityUIElement.cpp:
883         (horizontalScrollbarCallback):
884         (verticalScrollbarCallback):
885         (AccessibilityUIElement::horizontalScrollbar):
886         (AccessibilityUIElement::verticalScrollbar):
887         (AccessibilityUIElement::getJSClass):
888         * DumpRenderTree/AccessibilityUIElement.h:
889         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
890         (AccessibilityUIElement::horizontalScrollbar):
891         (AccessibilityUIElement::verticalScrollbar):
892         * WebKitTestRunner/DerivedSources.make:
893         * WebKitTestRunner/GNUmakefile.am:
894         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
895         (WTR::AccessibilityController::create):
896         (WTR::AccessibilityController::AccessibilityController):
897         (WTR::AccessibilityController::~AccessibilityController):
898         (WTR::AccessibilityController::makeWindowObject):
899         (WTR::AccessibilityController::wrapperClass):
900         (WTR::AccessibilityController::rootElement):
901         (WTR::AccessibilityController::focusedElement):
902         (WTR::AccessibilityController::elementAtPoint):
903         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
904         (WTR::AccessibilityController::logFocusEvents):
905         (WTR::AccessibilityController::logValueChangeEvents):
906         (WTR::AccessibilityController::logScrollingStartEvents):
907         (WTR::AccessibilityController::logAccessibilityEvents):
908         (WTR::AccessibilityController::addNotificationListener):
909         (WTR::AccessibilityController::notificationReceived):
910         (WTR::AccessibilityController::resetToConsistentState):
911         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
912         (WTR::AccessibilityTextMarker::create):
913         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
914         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
915         (WTR::AccessibilityTextMarker::platformTextMarker):
916         (WTR::AccessibilityTextMarker::wrapperClass):
917         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
918         (WTR::AccessibilityTextMarker::isEqual):
919         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
920         (WTR::AccessibilityTextMarkerRange::create):
921         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
922         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
923         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
924         (WTR::AccessibilityTextMarkerRange::wrapperClass):
925         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
926         (WTR::AccessibilityTextMarkerRange::isEqual):
927         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
928         (WTR::AccessibilityUIElement::create):
929         (WTR::AccessibilityUIElement::wrapperClass):
930         (WTR::AccessibilityUIElement::isValid):
931         (WTR::AccessibilityUIElement::AccessibilityUIElement):
932         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
933         (WTR::AccessibilityUIElement::isEqual):
934         (WTR::AccessibilityUIElement::elementAtPoint):
935         (WTR::AccessibilityUIElement::childAtIndex):
936         (WTR::AccessibilityUIElement::indexOfChild):
937         (WTR::AccessibilityUIElement::childrenCount):
938         (WTR::AccessibilityUIElement::titleUIElement):
939         (WTR::AccessibilityUIElement::parentElement):
940         (WTR::AccessibilityUIElement::takeFocus):
941         (WTR::AccessibilityUIElement::takeSelection):
942         (WTR::AccessibilityUIElement::addSelection):
943         (WTR::AccessibilityUIElement::removeSelection):
944         (WTR::AccessibilityUIElement::allAttributes):
945         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
946         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
947         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
948         (WTR::AccessibilityUIElement::attributesOfChildren):
949         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
950         (WTR::AccessibilityUIElement::increment):
951         (WTR::AccessibilityUIElement::decrement):
952         (WTR::AccessibilityUIElement::showMenu):
953         (WTR::AccessibilityUIElement::press):
954         (WTR::AccessibilityUIElement::stringAttributeValue):
955         (WTR::AccessibilityUIElement::uiElementAttributeValue):
956         (WTR::AccessibilityUIElement::numberAttributeValue):
957         (WTR::AccessibilityUIElement::boolAttributeValue):
958         (WTR::AccessibilityUIElement::isAttributeSupported):
959         (WTR::AccessibilityUIElement::isAttributeSettable):
960         (WTR::AccessibilityUIElement::isActionSupported):
961         (WTR::AccessibilityUIElement::role):
962         (WTR::AccessibilityUIElement::subrole):
963         (WTR::AccessibilityUIElement::roleDescription):
964         (WTR::AccessibilityUIElement::title):
965         (WTR::AccessibilityUIElement::description):
966         (WTR::AccessibilityUIElement::language):
967         (WTR::AccessibilityUIElement::stringValue):
968         (WTR::AccessibilityUIElement::accessibilityValue):
969         (WTR::AccessibilityUIElement::helpText):
970         (WTR::AccessibilityUIElement::orientation):
971         (WTR::AccessibilityUIElement::x):
972         (WTR::AccessibilityUIElement::y):
973         (WTR::AccessibilityUIElement::width):
974         (WTR::AccessibilityUIElement::height):
975         (WTR::AccessibilityUIElement::intValue):
976         (WTR::AccessibilityUIElement::minValue):
977         (WTR::AccessibilityUIElement::maxValue):
978         (WTR::AccessibilityUIElement::valueDescription):
979         (WTR::AccessibilityUIElement::insertionPointLineNumber):
980         (WTR::AccessibilityUIElement::selectedTextRange):
981         (WTR::AccessibilityUIElement::isEnabled):
982         (WTR::AccessibilityUIElement::isRequired):
983         (WTR::AccessibilityUIElement::isFocused):
984         (WTR::AccessibilityUIElement::isFocusable):
985         (WTR::AccessibilityUIElement::isSelected):
986         (WTR::AccessibilityUIElement::isSelectable):
987         (WTR::AccessibilityUIElement::isMultiSelectable):
988         (WTR::AccessibilityUIElement::setSelectedChild):
989         (WTR::AccessibilityUIElement::selectedChildrenCount):
990         (WTR::AccessibilityUIElement::selectedChildAtIndex):
991         (WTR::AccessibilityUIElement::isExpanded):
992         (WTR::AccessibilityUIElement::isChecked):
993         (WTR::AccessibilityUIElement::isVisible):
994         (WTR::AccessibilityUIElement::isOffScreen):
995         (WTR::AccessibilityUIElement::isCollapsed):
996         (WTR::AccessibilityUIElement::isIgnored):
997         (WTR::AccessibilityUIElement::hasPopup):
998         (WTR::AccessibilityUIElement::hierarchicalLevel):
999         (WTR::AccessibilityUIElement::clickPointX):
1000         (WTR::AccessibilityUIElement::clickPointY):
1001         (WTR::AccessibilityUIElement::documentEncoding):
1002         (WTR::AccessibilityUIElement::documentURI):
1003         (WTR::AccessibilityUIElement::url):
1004         (WTR::AccessibilityUIElement::speak):
1005         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1006         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1007         (WTR::AccessibilityUIElement::attributesOfColumns):
1008         (WTR::AccessibilityUIElement::attributesOfRows):
1009         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1010         (WTR::AccessibilityUIElement::attributesOfHeader):
1011         (WTR::AccessibilityUIElement::indexInTable):
1012         (WTR::AccessibilityUIElement::rowIndexRange):
1013         (WTR::AccessibilityUIElement::columnIndexRange):
1014         (WTR::AccessibilityUIElement::rowCount):
1015         (WTR::AccessibilityUIElement::columnCount):
1016         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1017         (WTR::AccessibilityUIElement::disclosedByRow):
1018         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1019         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1020         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1021         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1022         (WTR::AccessibilityUIElement::ariaDropEffects):
1023         (WTR::AccessibilityUIElement::lineForIndex):
1024         (WTR::AccessibilityUIElement::rangeForLine):
1025         (WTR::AccessibilityUIElement::boundsForRange):
1026         (WTR::AccessibilityUIElement::setSelectedTextRange):
1027         (WTR::AccessibilityUIElement::stringForRange):
1028         (WTR::AccessibilityUIElement::attributedStringForRange):
1029         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1030         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1031         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1032         (WTR::AccessibilityUIElement::horizontalScrollbar):
1033         (WTR::AccessibilityUIElement::verticalScrollbar):
1034         (WTR::AccessibilityUIElement::addNotificationListener):
1035         (WTR::AccessibilityUIElement::removeNotificationListener):
1036         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1037         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1038         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1039         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1040         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1041         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1042         (WTR::AccessibilityUIElement::textMarkerForPoint):
1043         (WTR::AccessibilityUIElement::previousTextMarker):
1044         (WTR::AccessibilityUIElement::nextTextMarker):
1045         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1046         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
1047         (WTR::AccessibilityUIElement::platformUIElement):
1048         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
1049         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
1050         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
1051         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
1052         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1053         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1054         (WTR::InjectedBundle::beginTesting):
1055         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1056         (WTR::InjectedBundle::accessibilityController):
1057         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1058         (WTR::InjectedBundlePage::didClearWindowForFrame):
1059         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1060         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
1061         (WTR::LayoutTestController::platformName):
1062         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
1063         (WTR::AccessibilityTextMarker::isEqual):
1064         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
1065         (WTR::AccessibilityTextMarkerRange::isEqual):
1066         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
1067         (+[NSString stringWithJSStringRef:]):
1068         (-[NSString createJSStringRef]):
1069         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
1070         (-[AccessibilityNotificationHandler dealloc]):
1071         (-[AccessibilityNotificationHandler _notificationReceived:]):
1072         (-[AccessibilityNotificationHandler setCallback:]):
1073         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1074         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1075         (WTR::AccessibilityUIElement::isEqual):
1076         (WTR::descriptionOfValue):
1077         (WTR::attributesOfElement):
1078         (WTR::concatenateAttributeAndValue):
1079         (WTR::convertNSArrayToVector):
1080         (WTR::descriptionOfElements):
1081         (WTR::AccessibilityUIElement::getLinkedUIElements):
1082         (WTR::AccessibilityUIElement::getDocumentLinks):
1083         (WTR::AccessibilityUIElement::getChildren):
1084         (WTR::AccessibilityUIElement::getChildrenWithRange):
1085         (WTR::AccessibilityUIElement::childrenCount):
1086         (WTR::AccessibilityUIElement::elementAtPoint):
1087         (WTR::AccessibilityUIElement::indexOfChild):
1088         (WTR::AccessibilityUIElement::childAtIndex):
1089         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1090         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1091         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1092         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1093         (WTR::AccessibilityUIElement::selectedChildAtIndex):
1094         (WTR::AccessibilityUIElement::selectedChildrenCount):
1095         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1096         (WTR::AccessibilityUIElement::titleUIElement):
1097         (WTR::AccessibilityUIElement::parentElement):
1098         (WTR::AccessibilityUIElement::disclosedByRow):
1099         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
1100         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
1101         (WTR::AccessibilityUIElement::attributesOfChildren):
1102         (WTR::AccessibilityUIElement::allAttributes):
1103         (WTR::AccessibilityUIElement::stringAttributeValue):
1104         (WTR::AccessibilityUIElement::numberAttributeValue):
1105         (WTR::AccessibilityUIElement::uiElementAttributeValue):
1106         (WTR::AccessibilityUIElement::boolAttributeValue):
1107         (WTR::AccessibilityUIElement::isAttributeSettable):
1108         (WTR::AccessibilityUIElement::isAttributeSupported):
1109         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
1110         (WTR::AccessibilityUIElement::role):
1111         (WTR::AccessibilityUIElement::subrole):
1112         (WTR::AccessibilityUIElement::roleDescription):
1113         (WTR::AccessibilityUIElement::title):
1114         (WTR::AccessibilityUIElement::description):
1115         (WTR::AccessibilityUIElement::orientation):
1116         (WTR::AccessibilityUIElement::stringValue):
1117         (WTR::AccessibilityUIElement::language):
1118         (WTR::AccessibilityUIElement::helpText):
1119         (WTR::AccessibilityUIElement::x):
1120         (WTR::AccessibilityUIElement::y):
1121         (WTR::AccessibilityUIElement::width):
1122         (WTR::AccessibilityUIElement::height):
1123         (WTR::AccessibilityUIElement::clickPointX):
1124         (WTR::AccessibilityUIElement::clickPointY):
1125         (WTR::AccessibilityUIElement::intValue):
1126         (WTR::AccessibilityUIElement::minValue):
1127         (WTR::AccessibilityUIElement::maxValue):
1128         (WTR::AccessibilityUIElement::valueDescription):
1129         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1130         (WTR::AccessibilityUIElement::isActionSupported):
1131         (WTR::AccessibilityUIElement::isEnabled):
1132         (WTR::AccessibilityUIElement::isRequired):
1133         (WTR::AccessibilityUIElement::isFocused):
1134         (WTR::AccessibilityUIElement::isSelected):
1135         (WTR::AccessibilityUIElement::isExpanded):
1136         (WTR::AccessibilityUIElement::isChecked):
1137         (WTR::AccessibilityUIElement::hierarchicalLevel):
1138         (WTR::AccessibilityUIElement::speak):
1139         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1140         (WTR::AccessibilityUIElement::ariaDropEffects):
1141         (WTR::AccessibilityUIElement::lineForIndex):
1142         (WTR::AccessibilityUIElement::rangeForLine):
1143         (WTR::AccessibilityUIElement::boundsForRange):
1144         (WTR::AccessibilityUIElement::stringForRange):
1145         (WTR::AccessibilityUIElement::attributedStringForRange):
1146         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1147         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1148         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1149         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1150         (WTR::AccessibilityUIElement::attributesOfColumns):
1151         (WTR::AccessibilityUIElement::attributesOfRows):
1152         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1153         (WTR::AccessibilityUIElement::attributesOfHeader):
1154         (WTR::AccessibilityUIElement::rowCount):
1155         (WTR::AccessibilityUIElement::columnCount):
1156         (WTR::AccessibilityUIElement::indexInTable):
1157         (WTR::AccessibilityUIElement::rowIndexRange):
1158         (WTR::AccessibilityUIElement::columnIndexRange):
1159         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1160         (WTR::AccessibilityUIElement::horizontalScrollbar):
1161         (WTR::AccessibilityUIElement::verticalScrollbar):
1162         (WTR::AccessibilityUIElement::selectedTextRange):
1163         (WTR::AccessibilityUIElement::setSelectedTextRange):
1164         (WTR::AccessibilityUIElement::increment):
1165         (WTR::AccessibilityUIElement::decrement):
1166         (WTR::AccessibilityUIElement::showMenu):
1167         (WTR::AccessibilityUIElement::press):
1168         (WTR::AccessibilityUIElement::setSelectedChild):
1169         (WTR::AccessibilityUIElement::accessibilityValue):
1170         (WTR::AccessibilityUIElement::documentEncoding):
1171         (WTR::AccessibilityUIElement::documentURI):
1172         (WTR::AccessibilityUIElement::url):
1173         (WTR::AccessibilityUIElement::addNotificationListener):
1174         (WTR::AccessibilityUIElement::removeNotificationListener):
1175         (WTR::AccessibilityUIElement::isFocusable):
1176         (WTR::AccessibilityUIElement::isSelectable):
1177         (WTR::AccessibilityUIElement::isMultiSelectable):
1178         (WTR::AccessibilityUIElement::isVisible):
1179         (WTR::AccessibilityUIElement::isOffScreen):
1180         (WTR::AccessibilityUIElement::isCollapsed):
1181         (WTR::AccessibilityUIElement::isIgnored):
1182         (WTR::AccessibilityUIElement::hasPopup):
1183         (WTR::AccessibilityUIElement::takeFocus):
1184         (WTR::AccessibilityUIElement::takeSelection):
1185         (WTR::AccessibilityUIElement::addSelection):
1186         (WTR::AccessibilityUIElement::removeSelection):
1187         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1188         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1189         (WTR::AccessibilityUIElement::previousTextMarker):
1190         (WTR::AccessibilityUIElement::nextTextMarker):
1191         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1192         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1193         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1194         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1195         (WTR::AccessibilityUIElement::textMarkerForPoint):
1196         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1197         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1198         (WTR::LayoutTestController::platformName):
1199         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1200         (WTR::LayoutTestController::platformName):
1201         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1202         (WTR::LayoutTestController::platformName):
1203         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1204         * WebKitTestRunner/win/InjectedBundle.vcproj:
1205
1206 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1207
1208         [Qt] Fix use of config.tests
1209
1210         We were checking @buildArgs to determine if the optional argument was
1211         passed or not, but this is not the right way to do that in Perl. The
1212         right way is to not use a prototype for the function, and to pass
1213         the list as a reference (to avoid list expansion). That way we can
1214         check the number of arguments, and choose the right code path based
1215         on that.
1216
1217         We were also missing a default-value of 0 for any feature that's not
1218         set in features.prf.
1219
1220         Reviewed by Kenneth Rohde Christiansen.
1221
1222         * Scripts/build-webkit:
1223         * Scripts/webkitdirs.pm:
1224         (qtFeatureDefaults):
1225         (buildQMakeProject):
1226
1227 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1228
1229         [Qt] Prospective fix for broken plugin tests
1230
1231         Don't hide symbols for the NPAPI test plugin
1232
1233         Rubber-stamped by Andreas Kling.
1234
1235         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1236
1237 2011-11-16  Adam Roben  <aroben@apple.com>
1238
1239         Move filenames/line numbers off to the right edge in Leaks Viewer
1240
1241         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1242         because filenames/line numbers are right next to function names
1243
1244         Reviewed by Andreas Kling.
1245
1246         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1247         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1248         function name. Use the filename as the profile node's URL (we don't have enough info to
1249         compute a real URL currently) and the line number as the profile node's line number so the
1250         Inspector code will put them on the right side of the callstack graph.
1251
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1253         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1254         passed here, just filenames.
1255
1256         (WebInspector.linkifyURLAsNode):
1257         (WebInspector.linkifyResourceAsNode):
1258         Copied and slightly modified from inspector.js.
1259
1260 2011-11-16  Adam Roben  <aroben@apple.com>
1261
1262         Make Leaks Viewer load builds from the new Lion Leaks bot
1263
1264         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1265
1266         Reviewed by Andreas Kling.
1267
1268         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1269         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1270         SnowLeopard one.
1271
1272 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1273
1274         [EFL] Clean up the offline apps-related functions in ewk_settings.
1275         https://bugs.webkit.org/show_bug.cgi?id=72132
1276
1277         Reviewed by Kenneth Rohde Christiansen.
1278
1279         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1280         prefixes for code that is related only to the HTML5 app cache
1281         features.
1282
1283         Use `ewk_settings_application_cache' and
1284         `ewk_view_setting_application_cache' instead.
1285
1286         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1287         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1288
1289 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1290
1291         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1292
1293         Reviewed by Tor Arne Vestbø.
1294
1295         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1296         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1297         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1298         removes the .so.0.0.0 and just produces .so.
1299
1300 2011-11-16  Peter Beverloo  <peter@chromium.org>
1301
1302         Explicitly include unistd.h in TestNetscapePlugIn
1303         https://bugs.webkit.org/show_bug.cgi?id=72385
1304
1305         This is needed for the sleep() call in the indicateTestFailure method,
1306         which seems to be implicitly available for other platforms. This is not
1307         the case on Android.
1308
1309         Reviewed by Steve Block.
1310
1311         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1312
1313 2011-11-16  Peter Beverloo  <peter@chromium.org>
1314
1315         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1316         https://bugs.webkit.org/show_bug.cgi?id=72384
1317
1318         Update to Android NDK r7, which was released last Friday. This adds
1319         support for RTTI and the -mimplicit-it gcc flag, which are required to
1320         respectively build ICU and Skia.
1321
1322         Reviewed by Steve Block.
1323
1324         * Scripts/update-webkit-chromium:
1325         * Scripts/webkitdirs.pm:
1326         (buildChromiumMakefile):
1327
1328 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1329
1330         Unreviewed, rolling out r100266.
1331         http://trac.webkit.org/changeset/100266
1332
1333         Broke WTR.
1334
1335         * qmake/mkspecs/features/default_post.prf:
1336
1337 2011-11-16  Eric Seidel  <eric@webkit.org>
1338
1339         check-webkit-style broken by r99773: "Could not determine the port"
1340         https://bugs.webkit.org/show_bug.cgi?id=72275
1341
1342         Reviewed by Adam Barth.
1343
1344         I will continue engaging hacks, until windows improves.
1345
1346         * Scripts/webkitpy/common/host.py:
1347          - Host uses self.executive instead of self._executive like Port does.
1348          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1349
1350 2011-11-16  Eric Seidel  <eric@webkit.org>
1351
1352         check-webkit-style broken by r99773: "Could not determine the port"
1353         https://bugs.webkit.org/show_bug.cgi?id=72275
1354
1355         Reviewed by Adam Barth.
1356
1357         Engage windows hacks harder.
1358
1359         This is a speculative fix for ChromiumWin.  We're now
1360         creating an SCM object much earlier, so we need to
1361         engage our "awesome" windows hacks earlier.
1362
1363         * Scripts/webkitpy/common/host.py:
1364         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1365
1366 2011-11-15  Darin Adler  <darin@apple.com>
1367
1368         DRT's uiElementAttributeValueCallback function is leaky
1369         https://bugs.webkit.org/show_bug.cgi?id=72453
1370
1371         Reviewed by Dan Bernstein.
1372
1373         * DumpRenderTree/AccessibilityUIElement.cpp:
1374         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1375
1376 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1377
1378         Implement edit-distance based reviewer recognition algorithm
1379         https://bugs.webkit.org/show_bug.cgi?id=72351
1380
1381         Reviewed by Eric Seidel.
1382
1383         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1384         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1385         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1386         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1387
1388         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1389         the edit distance is implemented in edit_distance.py.
1390
1391         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1392         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1393
1394         * Scripts/webkitpy/common/checkout/changelog.py:
1395         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1396         * Scripts/webkitpy/common/config/committers.py:
1397         * Scripts/webkitpy/common/config/committers_unittest.py:
1398         * Scripts/webkitpy/common/editdistance.py: Added.
1399         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1400         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1401         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1402
1403 2011-11-15  Tony Chang  <tony@chromium.org>
1404
1405         Skip a failing webkitpy test on cygwin.
1406
1407         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1408
1409 2011-11-15  Sam Weinig  <sam@webkit.org>
1410
1411         TestWebKitAPI should not put its resources in the root products directory
1412         https://bugs.webkit.org/show_bug.cgi?id=72446
1413
1414         Reviewed by Anders Carlsson.
1415
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1418         directory.
1419
1420         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1421         (TEST_F):
1422         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1423         (TestWebKitAPI::TEST):
1424         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1425         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1426         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1427         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1428         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1429         (TestWebKitAPI::Util::createURLForResource):
1430         Update calls to retrieve files from the bundle to look in the newly
1431         created subdirectory.
1432
1433 2011-11-15  Tony Chang  <tony@chromium.org>
1434
1435         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1436
1437         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1438
1439 2011-11-15  Tony Chang  <tony@chromium.org>
1440
1441         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1442         earlier.
1443
1444         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1445         * Scripts/webkitpy/layout_tests/port/webkit.py:
1446
1447 2011-11-15  James Robinson  <jamesr@chromium.org>
1448
1449         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1450         https://bugs.webkit.org/show_bug.cgi?id=72444
1451
1452         Reviewed by Adam Barth.
1453
1454         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1455
1456 2011-11-15  Tony Chang  <tony@chromium.org>
1457
1458         Unreviewed, better fix for ref tests failures on SL Intel bot.
1459         Revert the previous change and return None if pixel results from
1460         either the test page or the expected page is missing.
1461
1462         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1463         * Scripts/webkitpy/layout_tests/port/webkit.py:
1464
1465 2011-11-15  James Robinson  <jamesr@chromium.org>
1466
1467         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1468         https://bugs.webkit.org/show_bug.cgi?id=72402
1469
1470         Reviewed by Dirk Pranke.
1471
1472         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1473         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1474         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1475         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1476         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1477         compositing enabled.
1478
1479         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1480         patch should not impact any tests.
1481
1482         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1483         (main):
1484         * DumpRenderTree/chromium/TestShell.cpp:
1485         (TestShell::TestShell):
1486         (TestShell::resetWebSettings):
1487         * DumpRenderTree/chromium/TestShell.h:
1488         (TestShell::setAcceleratedCompositingForVideoEnabled):
1489         * DumpRenderTree/chromium/WebPreferences.cpp:
1490         (WebPreferences::reset):
1491         (WebPreferences::applyTo):
1492         * DumpRenderTree/chromium/WebPreferences.h:
1493         * Scripts/webkitpy/layout_tests/port/chromium.py:
1494         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1495         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1496
1497 2011-11-15  Tony Chang  <tony@chromium.org>
1498
1499         Unreviewed, try to fix ref tests failures on SL Intel bot.
1500         It looks like ImageDiff isn't returning an image diff.
1501
1502         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1503
1504 2011-11-15  Tony Chang  <tony@chromium.org>
1505
1506         Unreviewed fix of ref-tests on GTK+.
1507         If a driver is never started, _xvfb_process is never set.
1508
1509         * Scripts/webkitpy/layout_tests/port/gtk.py:
1510
1511 2011-11-14  Tony Chang  <tony@chromium.org>
1512
1513         [NRWT] Reftests should run even when pixel tests are disabled.
1514         https://bugs.webkit.org/show_bug.cgi?id=60605
1515
1516         Reviewed by Dirk Pranke.
1517
1518         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1519             Also add an assert to make sure we get image hashes back when running ref tests.
1520         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1521         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1522         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1523         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1524             of starting a pixel driver if needed.  It handles the logic of sending the test
1525             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1526         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1527         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1528         * Scripts/webkitpy/layout_tests/port/webkit.py:
1529         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1530         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1531
1532 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1533
1534         Don't use File::Slurp for run-leaks unit tests
1535         <http://webkit.org/b/72356>
1536
1537         Reviewed by Daniel Bates.
1538
1539         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1540         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1541         Extracted common package logic into RunLeaks.pm.  Fixed call to
1542         RunLeaks::parseLeaksOutput().
1543         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1544         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1545
1546 2011-11-15  Peter Kasting  <pkasting@google.com>
1547
1548         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1549         https://bugs.webkit.org/show_bug.cgi?id=72349
1550
1551         Reviewed by Adam Roben.
1552
1553         * Scripts/VCSUtils.pm:
1554         (isSVNDirectory):
1555
1556 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1557
1558         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1559
1560         Reviewed by Tor Arne Vestbø.
1561
1562         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1563         magic here where we handle all TEMPLATE = lib .pro files.
1564
1565 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1566
1567         [Qt] Unreviewed prospective --minimal build fix.
1568
1569         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1570         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1571
1572 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1573
1574         [Qt] Unreviewed --minimal build fix.
1575
1576         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1577         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1578         to make moc's preprocessor abort.
1579
1580 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1581
1582         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1583         https://bugs.webkit.org/show_bug.cgi?id=72156
1584
1585         Reviewed by Daniel Bates.
1586
1587         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1588         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1589
1590         * Scripts/build-webkit:
1591         * Scripts/webkitdirs.pm:
1592         (generateBuildSystemFromCMakeProject):
1593
1594 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1595
1596         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1597         https://bugs.webkit.org/show_bug.cgi?id=72340
1598
1599         Reviewed by Eric Seidel.
1600
1601         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1602         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1603
1604         * Scripts/webkitpy/common/checkout/changelog.py:
1605         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1606
1607 2011-11-14  Eric Seidel  <eric@webkit.org>
1608
1609         check-webkit-style broken by r99773: "Could not determine the port"
1610         https://bugs.webkit.org/show_bug.cgi?id=72275
1611
1612         Reviewed by Adam Barth.
1613
1614         The TestExpectationsChecker was using a generic try/except block
1615         which caught all exceptions, so we didn't notice that failing
1616         to pass a Host to PortFactory was causing an exception in port instantiation.
1617         I've factored out the "lookup the port" logic into a separate function
1618         which I've now unittested.  This should fix the bug and prevent
1619         others like it from occuring the the future.
1620
1621         * Scripts/webkitpy/style/checkers/test_expectations.py:
1622         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1623
1624 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1625
1626         Add --css-grid-layout to build-webkit and the build systems
1627         https://bugs.webkit.org/show_bug.cgi?id=72320
1628
1629         Reviewed by Ojan Vafai.
1630
1631         * Scripts/build-webkit:
1632         Added the option.
1633
1634 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1635
1636         Unreviewed, rolling out r100192.
1637         http://trac.webkit.org/changeset/100192
1638         https://bugs.webkit.org/show_bug.cgi?id=72328
1639
1640         Caused infinite tests to fail (Requested by abarth on
1641         #webkit).
1642
1643         * Scripts/webkitpy/layout_tests/port/base.py:
1644         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1645
1646 2011-11-14  Tony Chang  <tony@chromium.org>
1647
1648         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1649         https://bugs.webkit.org/show_bug.cgi?id=72196
1650
1651         Reviewed by Ojan Vafai.
1652
1653         * Scripts/build-webkit:
1654
1655 2011-11-14  John Yani  <vanuan@gmail.com>
1656
1657         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1658         Override LOCALE to en_US.
1659
1660         Reviewed by Eric Seidel.
1661
1662         * Scripts/webkitpy/layout_tests/port/base.py:
1663
1664 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1665
1666         [Chromium] build-webkit silently drops the features flags
1667         https://bugs.webkit.org/show_bug.cgi?id=72293
1668
1669         Reviewed by Tony Chang.
1670
1671         Chromium still ignores @features but now we give a warning!
1672
1673         * Scripts/build-webkit: Check if one of the features is different
1674         from the default and print a warning in this case.
1675
1676 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1677
1678         run-leaks does not work on Lion?
1679         <http://webkit.org/b/71059>
1680         <rdar://problem/10428527>
1681
1682         Reviewed by Adam Roben.
1683
1684         The output of leaks(1) changed again in Lion to move the
1685         "leaks Report Version: 2.0" line from the first line of the
1686         output to just above the "Process " lines that run-leaks is
1687         interested in parsing.  This required using a more generic
1688         algorithm to find the start of the "Process " lines.
1689
1690         * Scripts/run-leaks:
1691         (parseLeaksOutput): Make the code to skip headers more generic.
1692         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1693         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1694         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1695
1696 2011-11-14  Lei Zhang  <thestig@chromium.org>
1697
1698         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1699         https://bugs.webkit.org/show_bug.cgi?id=72088
1700
1701         Reviewed by Tony Chang.
1702
1703         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1704
1705 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1706
1707         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1708         https://bugs.webkit.org/show_bug.cgi?id=72147
1709
1710         Reviewed by Adam Barth.
1711
1712         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1713
1714 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1715
1716         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1717
1718         Reviewed by Simon Hausmann.
1719
1720         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1721
1722 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1723
1724         [Qt] Disable plugins on X11 for WK2
1725
1726         Reviewed by Kenneth Rohde Christiansen.
1727
1728         Currently plugins are in-process and they crash in the likely case of
1729         a plugin installation that uses Qt 4, which beautifully clashes with the
1730         Qt 5 based QtWebProcess.
1731
1732         * qmake/mkspecs/features/features.prf:
1733
1734 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1735
1736         [Qt] Add support for config tests for Qt 5
1737
1738         This allows us to build and run configure-tests at build
1739         time to determine if a given platform feature is available.
1740
1741         Reviewed by Simon Hausmann.
1742
1743         * Scripts/build-webkit:
1744         * Scripts/webkitdirs.pm:
1745         (qtFeatureDefaults):
1746         * qmake/configure.pro: Added.
1747         * qmake/mkspecs/features/features.prf:
1748         * qmake/sync.profile: Added.
1749
1750 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1751
1752         [Qt] Remove the QStyle dependency in Qt's mobile theme
1753         https://bugs.webkit.org/show_bug.cgi?id=67773
1754
1755         This refactoring splits up RenderThemeQt with two
1756         subclasses, a QStyle-backed one, and a Mobile version
1757         that uses the old mobile theme for now.
1758
1759         QStyle availability is detected at compile time, and
1760         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1761         environment variable.
1762
1763         Reviewed by Simon Hausmann.
1764
1765         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1766         (WTR::activateFonts):
1767         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1768         based on availability of QtWidgets.
1769         * qmake/mkspecs/features/webcore.prf: cleanup.
1770
1771 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1772
1773         Unreviewed, rolling out r100116.
1774         http://trac.webkit.org/changeset/100116
1775
1776         r100104 was rolled out, so no longer needed
1777
1778         * Scripts/run-bindings-tests:
1779
1780 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1781
1782         Unreviewed, rolling out r100104.
1783         http://trac.webkit.org/changeset/100104
1784         https://bugs.webkit.org/show_bug.cgi?id=72247
1785
1786         broke windows builds
1787
1788         * Scripts/check-webkit-style:
1789         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1790         * Scripts/webkitpy/common/checkout/deps.py:
1791         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1792         * Scripts/webkitpy/common/checkout/scm/detection.py:
1793         * Scripts/webkitpy/common/checkout/scm/git.py:
1794         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1795         * Scripts/webkitpy/common/checkout/scm/svn.py:
1796         * Scripts/webkitpy/common/host.py:
1797         * Scripts/webkitpy/common/host_mock.py:
1798         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1799         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1800         * Scripts/webkitpy/layout_tests/port/base.py:
1801         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1802         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1803         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1804         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1805
1806 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1807
1808         Unreviewed, build fix after r100104. run-binding-tests broke.
1809
1810         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1811
1812 2011-11-13  Eric Seidel  <eric@webkit.org>
1813
1814         Add SCMDetector object to make scm detection mockable
1815         https://bugs.webkit.org/show_bug.cgi?id=72247
1816
1817         Reviewed by Adam Barth.
1818
1819         I think SCM detection may eventually be rolled into Checkout,
1820         but this patch at least makes it possible to mock code-paths
1821         which rely on scm detection.
1822         In the process of replacing callers of these free-functions
1823         I found that one of the functions was no longer used,
1824         and that one of the callers could instead just use the SCM
1825         object it already had access to through port.host.scm().
1826         I also discovered that I was not calling Host._initialize_scm()
1827         and thus host.scm() was always returning None!
1828
1829         * Scripts/check-webkit-style:
1830         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1831         * Scripts/webkitpy/common/checkout/deps.py:
1832         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1833         * Scripts/webkitpy/common/checkout/scm/detection.py:
1834         * Scripts/webkitpy/common/checkout/scm/git.py:
1835         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1836         * Scripts/webkitpy/common/checkout/scm/svn.py:
1837         * Scripts/webkitpy/common/host.py:
1838         * Scripts/webkitpy/common/host_mock.py:
1839         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1840         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1841         * Scripts/webkitpy/layout_tests/port/base.py:
1842         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1843         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1844         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1845         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1846
1847 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1848
1849         command line control of webcore log channels in chromium DumpRenderTree
1850         https://bugs.webkit.org/show_bug.cgi?id=72126
1851         
1852         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1853         what chromium takes.
1854
1855         Reviewed by Kent Tamura.
1856
1857         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1858         (main):
1859
1860 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1861
1862         [Qt] Fix minor config typo in the build tool documentation
1863         https://bugs.webkit.org/show_bug.cgi?id=72194
1864
1865         Reviewed by Andreas Kling.
1866
1867         * qmake/README:
1868
1869 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1870
1871         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1872         https://bugs.webkit.org/show_bug.cgi?id=49257
1873
1874         Adds the remaining missing layout test functionality for printing.
1875
1876         Reviewed by Darin Fisher.
1877
1878         * DumpRenderTree/chromium/LayoutTestController.cpp:
1879         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1880         (parsePageNumber): Method to parse JS arguments for a page number
1881         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1882         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1883         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1884         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1885         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1886
1887 2011-11-11  Darin Adler  <darin@apple.com>
1888
1889         Remove all releaseRef implementations except for RetainPtr
1890         https://bugs.webkit.org/show_bug.cgi?id=71423
1891
1892         Reviewed by Julien Chaffraix.
1893
1894         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1895         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1896
1897 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1898
1899         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1900         https://bugs.webkit.org/show_bug.cgi?id=72090
1901
1902         Reviewed by Eric Seidel.
1903
1904         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1905         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1906
1907         yay! r100002.
1908
1909         * Scripts/webkitpy/common/checkout/changelog.py:
1910         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1911
1912 2011-11-11  Tony Chang  <tony@chromium.org>
1913
1914         Remove --force from gclient sync.  The bots seem to have made it past
1915         the update step.
1916
1917         * Scripts/update-webkit:
1918
1919 2011-11-11  Tony Chang  <tony@chromium.org>
1920
1921         Add --force to gclient sync. Once the cq bots cycle, we can remove
1922         this since it slows down the normal sync.
1923
1924         * Scripts/update-webkit:
1925
1926 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1927
1928         When --force is used, also use --reset
1929         https://bugs.webkit.org/show_bug.cgi?id=72129
1930
1931         Reviewed by Dimitri Glazkov.
1932
1933         * Scripts/update-webkit-chromium:
1934
1935 2011-11-11  Tony Chang  <tony@chromium.org>
1936
1937         allow two chromium drivers to run at the same time in NRWT
1938         https://bugs.webkit.org/show_bug.cgi?id=72067
1939
1940         Reviewed by Dirk Pranke.
1941
1942         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1943             posix prevents the subprocesses from sharing the same fd for stdin.
1944             Sharing the same fd prevents us from closing the files unless all references
1945             to the fd are closed.
1946         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1947             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1948             the timeout override. It looks like it regressed in r95875.
1949
1950 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1951
1952         Unreviewed, rolling out r99964.
1953         http://trac.webkit.org/changeset/99964
1954         https://bugs.webkit.org/show_bug.cgi?id=72124
1955
1956         Broke too many Qt tests (Requested by tronical_ on #webkit).
1957
1958         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1959         (WTR::activateFonts):
1960         * qmake/mkspecs/features/features.prf:
1961         * qmake/mkspecs/features/webcore.prf:
1962
1963 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1964
1965         [Qt] Remove the QStyle dependency in Qt's mobile theme
1966         https://bugs.webkit.org/show_bug.cgi?id=67773
1967
1968         This refactoring splits up RenderThemeQt with two
1969         subclasses, a QStyle-backed one, and a Mobile version
1970         that uses the old mobile theme for now.
1971
1972         QStyle availability is detected at compile time, and
1973         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1974         environment variable.
1975
1976         Reviewed by Simon Hausmann.
1977
1978         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1979         (WTR::activateFonts):
1980         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1981         based on availability of QtWidgets.
1982         * qmake/mkspecs/features/webcore.prf: cleanup.
1983
1984 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1985
1986         [Qt] Add missing include to PlatformWebViewQt
1987
1988         Reviewed by Simon Hausmann.
1989
1990         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1991
1992 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1993
1994         [Qt] Fix incremental builds on Windows after buildsystem refactor
1995
1996         The qmake rules to ensure that we run make on the derived sources
1997         before running qmake on the target were inside a unix-scope, which
1998         resulted in flakey builds on Windows.
1999
2000         We now generate a rule on all platforms that ensures that "make qmake"
2001         will always run make on the derived sources. In addition, on platforms
2002         that have GNU make (where "make incremental" does not run "make qmake",
2003         but only "make"), we add a similar rule that ensures that any time the
2004         target makefile is regenerated we first run qmake and make on the derived
2005         sources. This rule relies on GNU make's order-only-prerequisites to
2006         not trigger a qmake-run of the target every time we run make.
2007
2008         https://bugs.webkit.org/show_bug.cgi?id=71778
2009
2010         Reviewed by Simon Hausmann.
2011
2012         * qmake/mkspecs/features/functions.prf:
2013
2014 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2015
2016         [Qt][WK2] Remove QWebNavigationController
2017         https://bugs.webkit.org/show_bug.cgi?id=72113
2018
2019         Reviewed by Andreas Kling.
2020
2021         Adapt to the move of the QWebNavigationController functions/properties to
2022         QQuickWebView.
2023
2024         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2025         * MiniBrowser/qt/qml/BrowserWindow.qml:
2026
2027 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2028
2029         [Qt] Build system tweak
2030
2031         Reviewed by Tor Arne Vestbø.
2032
2033         Be a good qmake citizen, return true from our linkStaticLibrary
2034         "test" function.
2035
2036         * qmake/mkspecs/features/functions.prf:
2037
2038 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
2039
2040         [Qt] Add support for QT += webkit-private
2041
2042         Reviewed by Tor Arne Vestbø.
2043
2044         * qmake/qt_webkit.pri: Declare private headers.
2045
2046 2011-11-11  Philippe Normand  <pnormand@igalia.com>
2047
2048         Unreviewed, build fix attempt after r99907. Since that revision
2049         GTK layout tests were not running at all...
2050
2051         * Scripts/webkitpy/layout_tests/port/gtk.py:
2052
2053 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
2054
2055         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
2056         https://bugs.webkit.org/show_bug.cgi?id=72001
2057
2058         Reviewed by Dirk Pranke.
2059
2060         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2061
2062 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
2063
2064         bencher script should support remote benchmarking
2065         https://bugs.webkit.org/show_bug.cgi?id=71618
2066
2067         Rubber-stamped by Geoff Garen.
2068         
2069         Added the following features:
2070         
2071         - Benchmark report tells you the hostname and machine model (according to
2072           'sysctl hw.model') of the machine you did the run on, and svn revision number
2073           (according to 'svn info') of the VMs you're testing.
2074         
2075         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
2076           acceptable, in addition to just host, in which case your username is used)
2077           and it automatically packages the build directories of the VMs you're testing,
2078           sends them to the remote machine along with your copy of the bencher script
2079           and all of the options you passed.  This pretty much seamlessly allows you
2080           to run a set of benchmarks on any machine that is sufficiently compatible with
2081           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
2082           must now include a tempPath setting that tells bencher where to put files
2083           when that machine is used as a slave in a remote benchmarking run.
2084           
2085         - Added yet another way of specifying which benchmarks to run. This was sort of
2086           necessary for --remote to work as expected. Previously, you either said what
2087           suites to exclude (for example --exclude-sunspider) or that you only wanted
2088           to run one suite to the exclusion of others (--sunspider-only). But it's
2089           often better to just be able to specify the list of suites you want. This is
2090           now supported. You can say, for example, --v8 --sunspider, which means, just
2091           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
2092           still supported.
2093
2094         * Scripts/bencher:
2095
2096 2011-11-10  Tony Chang  <tony@chromium.org>
2097
2098         Lazily start DRT instances in NRWT
2099         https://bugs.webkit.org/show_bug.cgi?id=72038
2100
2101         Reviewed by Eric Seidel.
2102
2103         Just a refactoring, no new tests.
2104
2105         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2106         * Scripts/webkitpy/layout_tests/port/chromium.py:
2107         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2108         * Scripts/webkitpy/layout_tests/port/test.py:
2109         * Scripts/webkitpy/layout_tests/port/webkit.py:
2110
2111 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
2112
2113         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
2114         https://bugs.webkit.org/show_bug.cgi?id=72057
2115
2116         Reviewed by Eric Seidel.
2117
2118         Make the regular expression more explicit.
2119
2120         * Scripts/webkitpy/common/checkout/changelog.py:
2121         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2122
2123 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2124
2125         [Qt] X11 plugins need to be reworked for Qt5
2126         https://bugs.webkit.org/show_bug.cgi?id=70023
2127
2128         Reviewed by Simon Hausmann.
2129
2130         Rework our basic plugin support in a way that does
2131         not need a bridge between Qt and X. The solution is
2132         based on getting the content drawed by the plugin
2133         from the server as an image and creating a QImage
2134         from it.
2135
2136         * qmake/mkspecs/features/features.prf: Enable X11
2137         plugins if Qt is built with the xcb-xlib backend.
2138
2139 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2140
2141         [Qt] Fix keyboard related layout tests after API refactoring
2142
2143         Reviewed by Tor Arne Vestbø.
2144
2145         Send key events to the handling page item, not the view.
2146
2147         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2148         (WTR::PlatformWebView::sendEvent):
2149         (WTR::PlatformWebView::postEvent):
2150
2151 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2152
2153         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2154         https://bugs.webkit.org/show_bug.cgi?id=71940
2155
2156         Reviewed by Philippe Normand.
2157
2158         * GNUmakefile.am:
2159         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2160         ENABLE_* variables are part of the environment.
2161
2162 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2163
2164         [Qt] Fix focus related layout tests after API refactoring
2165
2166         Reviewed by Tor Arne Vestbø.
2167
2168         Make sure the focus is set on the page now, not on the view
2169         (which doesn't actually handle the focus).
2170
2171         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2172         (WTR::WrapperWindow::WrapperWindow):
2173         (WTR::WrapperWindow::handleStatusChanged):
2174
2175 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2176
2177         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2178         https://bugs.webkit.org/show_bug.cgi?id=71355
2179
2180         Reviewed by Kenneth Rohde Christiansen.
2181
2182         Make MiniBrowser and WebKitTestRunner work again after the
2183         merge.
2184
2185         * MiniBrowser/qt/BrowserWindow.cpp:
2186         (BrowserWindow::BrowserWindow):
2187         (BrowserWindow::webView):
2188         * MiniBrowser/qt/MiniBrowser.pro:
2189         * MiniBrowser/qt/MiniBrowser.qrc:
2190         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2191         * MiniBrowser/qt/main.cpp:
2192         * MiniBrowser/qt/qml/BrowserWindow.qml:
2193         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2194         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2195         * WebKitTestRunner/PlatformWebView.h:
2196         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2197         (WTR::PlatformWebView::PlatformWebView):
2198
2199 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2200
2201         [Qt] Change semantics of the haveQt() function to match API promises
2202
2203         Having Qt 5 does not imply that we have Qt 4, from an API point of
2204         view, as a major version can in theory break BC/SC. Our minimum
2205         version of Qt 4 will always be the latest released version of Qt 4,
2206         so the only place we should use haveQt(4, x) is when checking for
2207         the minimum requirements.
2208
2209         Reviewed by Simon Hausmann.
2210
2211         * qmake/mkspecs/features/default_pre.prf:
2212         * qmake/mkspecs/features/features.prf:
2213         * qmake/mkspecs/features/functions.prf:
2214
2215 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2216
2217         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2218         https://bugs.webkit.org/show_bug.cgi?id=69411
2219
2220         Reviewed by Martin Robinson.
2221
2222         * WebKitTestRunner/EventSenderProxy.h:
2223         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2224         * WebKitTestRunner/TestController.cpp:
2225         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2226         use the EventSender instead of WebProcess Event Simulation.
2227         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2228         (WTR::WTREventQueueItem::WTREventQueueItem):
2229         (WTR::EventSenderProxy::EventSenderProxy):
2230         (WTR::getMouseButtonModifiers):
2231         (WTR::eventSenderButtonToGDKButton):
2232         (WTR::EventSenderProxy::createMouseButtonEvent):
2233         (WTR::EventSenderProxy::updateClickCountForButton):
2234         (WTR::EventSenderProxy::replaySavedEvents):
2235         (WTR::EventSenderProxy::sendOrQueueEvent):
2236         (WTR::webkitModifiersToGDKModifiers):
2237         (WTR::getGDKKeySymForKeyRef):
2238         (WTR::EventSenderProxy::keyDown):
2239         (WTR::EventSenderProxy::mouseDown):
2240         (WTR::EventSenderProxy::mouseUp):
2241         (WTR::EventSenderProxy::mouseMoveTo):
2242         (WTR::EventSenderProxy::mouseScrollBy):
2243         (WTR::EventSenderProxy::leapForward):
2244
2245 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2246
2247         [Qt] Enable exports and constructor functions in static libs
2248
2249         Reviewed by Tor Arne Vestbø.
2250
2251         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2252         mac/win32-msvc equivalents when linking static libraries into a shared
2253         library or executable.
2254
2255 2011-11-09  Hayato Ito  <hayato@chromium.org>
2256
2257         [NRWT] Make results.html aware of reference filename in reftests.
2258         https://bugs.webkit.org/show_bug.cgi?id=71574
2259
2260         Reviewed by Ryosuke Niwa.
2261
2262         If a reference filename is different from the default one, include that in result summary
2263         so results.html can link to the correct reference file.
2264
2265         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2266         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2267
2268 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2269
2270         [wx] Unreviewed build fix. Update project files and
2271         add LTC stubs for new methods.
2272
2273         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2274         (LayoutTestController::addChromeInputField):
2275         (LayoutTestController::removeChromeInputField):
2276         (LayoutTestController::focusWebView):
2277         (LayoutTestController::setBackingScaleFactor):
2278         * waf/build/settings.py:
2279
2280 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2281
2282         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2283
2284         * wx/install-unix-extras:
2285
2286 2011-11-09  Eric Seidel  <eric@webkit.org>
2287
2288         Remove the concept of platform-dependent unittests
2289         https://bugs.webkit.org/show_bug.cgi?id=71963
2290
2291         Unreviewed.  Fix test-webkitpy on cygwin.
2292
2293         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2294
2295 2011-11-09  Dana Jansens  <danakj@chromium.org>
2296
2297         Add cc-bugs group to watch changes in chromium graphics
2298         https://bugs.webkit.org/show_bug.cgi?id=71690
2299
2300         Reviewed by David Levin.
2301
2302         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2303         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2304         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2305         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2306
2307 2011-11-09  Eric Seidel  <eric@webkit.org>
2308
2309         Remove more platform-dependent unittests
2310         https://bugs.webkit.org/show_bug.cgi?id=71971
2311
2312         Reviewed by Adam Barth.
2313
2314         Tests which only run on a couple platforms will break.
2315         All tests should run on all platforms where possible.
2316
2317         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2318         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2319         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2320         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2321
2322 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2323
2324         Merge in results to the test results server even if build numbers conflict
2325         https://bugs.webkit.org/show_bug.cgi?id=71967
2326
2327         Reviewed by Tony Chang.
2328
2329         This was initially meant to be a sanity check that we don't
2330         enter duplicate runs, but it turns out that we can reasonably get
2331         in these situations when a builder is clobbered (e.g. the build
2332         numbers start over again from 0).
2333
2334         * TestResultServer/model/jsonresults.py:
2335         * TestResultServer/model/jsonresults_unittest.py:
2336
2337 2011-11-09  Eric Seidel  <eric@webkit.org>
2338
2339         Remove the concept of platform-dependent unittests
2340         https://bugs.webkit.org/show_bug.cgi?id=71963
2341
2342         Reviewed by Adam Barth.
2343
2344         These have been the source of never-ending sadness.
2345         We'd change behavior and forget to update results in
2346         some unittests because they were only run on certain platforms.
2347         This change removes a large source of these platform-dependent
2348         unittests, which was caused by the port_maker stuff.
2349
2350         It's possible that this change will break test-webkitpy
2351         on some platforms, but that will be a one-time cost.
2352         I will fix the breakage by removing the platform-dependantness
2353         of any such broken tests.
2354
2355         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2356         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2357         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2358         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2359         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2360         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2361         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2362         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2363         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2364         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2365         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2366         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2367         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2368
2369 2011-11-09  Eric Seidel  <eric@webkit.org>
2370
2371         Make the Port object have a Host
2372         https://bugs.webkit.org/show_bug.cgi?id=71961
2373
2374         Reviewed by Adam Barth.
2375
2376         This has been a long time coming.
2377         Now that Port has a Host object, it's very easy
2378         to write unittests which use a properly mocked Port.
2379         Soon we will remove the executive, filesystem and user
2380         members of Port and get everything through the Host.
2381
2382         Note how in many callsites we're actually removing
2383         explicit mocks, since we're now always going to get the
2384         correct Executive/User/FileSystem from the
2385         Host and callsites don't need to be careful to pass each one.
2386
2387         This is prep-work for adding a new Environment member to
2388         Host and needing to be able to access the Environment
2389         member from Port functions w/o needing to pass an Environment
2390         object (or appropriate Mock) every place we create a Port object.
2391         Now that we have a single Host object to reach out through, its
2392         simple to add additional functionality (like Environment) while
2393         keeping our unittests properly mocked.
2394
2395         * Scripts/webkitpy/common/host.py:
2396         * Scripts/webkitpy/common/net/credentials_unittest.py:
2397         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2398         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2399         * Scripts/webkitpy/layout_tests/port/apple.py:
2400         * Scripts/webkitpy/layout_tests/port/base.py:
2401         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2402         * Scripts/webkitpy/layout_tests/port/chromium.py:
2403         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2404         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2405         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2406         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2407         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2408         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2409         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2410         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2411         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2412         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2413         * Scripts/webkitpy/layout_tests/port/efl.py:
2414         * Scripts/webkitpy/layout_tests/port/factory.py:
2415         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2416         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2417         * Scripts/webkitpy/layout_tests/port/gtk.py:
2418         * Scripts/webkitpy/layout_tests/port/mac.py:
2419         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2420         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2421         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2422         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2423         * Scripts/webkitpy/layout_tests/port/qt.py:
2424         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2425         * Scripts/webkitpy/layout_tests/port/test.py:
2426         * Scripts/webkitpy/layout_tests/port/webkit.py:
2427         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2428         * Scripts/webkitpy/layout_tests/port/win.py:
2429         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2430         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2431         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2432         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2433         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2434
2435 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2436
2437         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2438         https://bugs.webkit.org/show_bug.cgi?id=71561
2439
2440         Reviewed by Dimitri Glazkov.
2441
2442         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2443         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2444
2445 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2446
2447         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2448         https://bugs.webkit.org/show_bug.cgi?id=66772
2449
2450         Reviewed by Simon Fraser.
2451
2452         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2453         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2454
2455         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2456         in the FrameLoadDelegate and print the output in response to the notification.
2457
2458         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2459         (-[FrameLoadDelegate init]):
2460         (-[FrameLoadDelegate dealloc]):
2461         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2462
2463 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2464
2465         [GTK][DRT] window internals object is not reset after each test
2466         https://bugs.webkit.org/show_bug.cgi?id=71890
2467
2468         Reviewed by Martin Robinson.
2469
2470         Call WebCoreTestSupport::resetInternalsObject without going
2471         through DumpRenderTreeSupport.
2472
2473         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2474         (runTest):
2475
2476 2011-11-09  Beth Dakin  <bdakin@apple.com>
2477
2478         Build fix.
2479
2480         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2481         (AccessibilityUIElement::uiElementAttributeValue):
2482
2483 2011-11-09  Beth Dakin  <bdakin@apple.com>
2484
2485         Speculative build fix.
2486
2487         * DumpRenderTree/AccessibilityUIElement.h:
2488
2489 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2490
2491         Unreviewed build fix.
2492
2493         * DumpRenderTree/AccessibilityUIElement.cpp:
2494         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2495         A bad merge added this check that is making the bots sad.
2496
2497 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2498
2499         AX: crash when accessing selectedTab in a tab list
2500         https://bugs.webkit.org/show_bug.cgi?id=70938
2501
2502         Reviewed by Beth Dakin.
2503
2504         Add the ability to retrieve an element through an arbitrary attribute.
2505
2506         * DumpRenderTree/AccessibilityUIElement.cpp:
2507         (uiElementAttributeValueCallback):
2508         (AccessibilityUIElement::uiElementAttributeValue):
2509         (AccessibilityUIElement::getJSClass):
2510         * DumpRenderTree/AccessibilityUIElement.h:
2511         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2512         (AccessibilityUIElement::uiElementAttributeValue):
2513
2514 2011-11-09  Andy Wingo  <wingo@igalia.com>
2515
2516         Add webkitdirs.pm:getArchitecture implementation for GTK
2517         https://bugs.webkit.org/show_bug.cgi?id=71370
2518
2519         Reviewed by Xan Lopez.
2520
2521         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2522         implementation for ports using autotools, so that a vanilla
2523         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2524         to build-jsc on x86-64 machines.
2525
2526 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2527
2528         Unreviewed, rolling out r99707.
2529         http://trac.webkit.org/changeset/99707
2530
2531         Re-enable until we can disable it together with tests in one
2532         shot.
2533
2534         * qmake/mkspecs/features/features.prf:
2535
2536 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2537
2538         [Qt] Disable use of QtUiTools if the library/module is not found
2539
2540         We rely on the lookup order of prf files to inject our own uitools.prf
2541         that will verify that QtUiTools is in fact present before allowing the
2542         CONFIG += uitools to have any effect.
2543
2544         Reviewed by Simon Hausmann.
2545
2546         * DumpRenderTree/qt/DumpRenderTree.pro:
2547         * QtTestBrowser/QtTestBrowser.pro:
2548         * qmake/mkspecs/features/uitools.prf: Added.
2549
2550 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2551
2552         Unreviewed, rolling out r99701.
2553         http://trac.webkit.org/changeset/99701
2554
2555         Breaks Qt mac build
2556
2557         * qmake/mkspecs/features/functions.prf:
2558
2559 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2560
2561         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2562
2563         Reviewed by Tor Arne Vestbø.
2564
2565         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2566         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2567         is not up to the task of full XSLT support, so we should disable it.
2568
2569 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2570
2571         [Qt] Enable exports and constructor functions in static libs
2572
2573         Reviewed by Tor Arne Vestbø.
2574
2575         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2576         mac/win32-msvc equivalents when linking static libraries into a shared
2577         library or executable.
2578
2579 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2580
2581         [GTK][DRT] window internals object is not reset after each test
2582         https://bugs.webkit.org/show_bug.cgi?id=71890
2583
2584         Reviewed by Xan Lopez.
2585
2586         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2587         (runTest): reset the Internals object after each test.
2588
2589 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2590
2591         [Qt] Detect presence of QtUiTools and enable it only when available
2592
2593         The disable_uitools option was a workaround for missing detection.
2594
2595         Reviewed by Simon Hausmann.
2596
2597         * QtTestBrowser/QtTestBrowser.pro:
2598         * qmake/mkspecs/features/default_post.prf:
2599         * qmake/mkspecs/features/default_pre.prf:
2600
2601 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2602
2603         [Qt] Don't override config for the build_pass of debug_and_release
2604
2605         Qmake will parse the profile once for each configuration (debug and
2606         release), with the build_pass option set. In that situation we don't
2607         want to override what qmake is setting explicitly, otherwise the
2608         debug-step will end up hitting all the release-scopes.
2609
2610         Reviewed by Simon Hausmann.
2611
2612         * qmake/mkspecs/features/default_pre.prf:
2613
2614 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2615
2616         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2617
2618         * qmake/mkspecs/features/functions.prf:
2619
2620 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2621
2622         [Qt] Centralize duplicated code for linking the static libs
2623
2624         Reviewed by Tor Arne Vestbø.
2625
2626         * qmake/mkspecs/features/functions.prf:
2627         * qmake/mkspecs/features/javascriptcore.prf:
2628         * qmake/mkspecs/features/webcore.prf:
2629         * qmake/mkspecs/features/webkit2.prf:
2630
2631 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2632
2633         [Qt] Build system cleanup
2634         https://bugs.webkit.org/show_bug.cgi?id=71815
2635
2636         Reviewed by Kenneth Rohde Christiansen.
2637
2638         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2639         static library.
2640         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2641         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2642
2643 2011-11-08  Hayato Ito  <hayato@chromium.org>
2644
2645         [NRWT] Make single_test_runner aware of reference filename of test_input.
2646         https://bugs.webkit.org/show_bug.cgi?id=71567
2647
2648         Reviewed by Ryosuke Niwa.
2649
2650         Make single_test_runner honor a reference filename of given test_input so that
2651         we can use any file as reference html, instead of depending on implicit naming convention.
2652         The typical use case is to support w3c reftests.
2653
2654         No tests since no functional changes until there is a client.
2655         Test should be easily written with future clients.
2656
2657         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2658         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2659         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2660         * Scripts/webkitpy/layout_tests/models/test_input.py:
2661
2662 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2663
2664         https://bugs.webkit.org/show_bug.cgi?id=71839
2665         Update the leaks bot OS to Lion.
2666         Update the config.json to reflect the update.
2667
2668         Reviewed by Stephanie Lewis.
2669
2670         * BuildSlaveSupport/build.webkit.org-config/config.json:
2671
2672 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2673
2674         Unreviewed, rolling out r99626.
2675         http://trac.webkit.org/changeset/99626
2676         https://bugs.webkit.org/show_bug.cgi?id=71866
2677
2678         "C++ exceptions cannot be disabled without influencing the
2679         Objective-C exceptions" (Requested by benjaminp on #webkit).
2680
2681         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2682
2683 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2684
2685         [Mac] Disable C++ exceptions from DumpRenderTree
2686         https://bugs.webkit.org/show_bug.cgi?id=71834
2687
2688         Reviewed by Darin Adler.
2689
2690         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2691         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2692         which leads to crashes long after the exception was raised.
2693
2694         This patch disabled C++ exceptions in order to catch the problems where
2695         they happen when a C++ exception is raised.
2696
2697         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2698
2699 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2700
2701         Moved myself to the reviewer list (yay!).
2702
2703         * Scripts/webkitpy/common/config/committers.py:
2704
2705 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2706
2707         Added myself as a committer.
2708
2709         * Scripts/webkitpy/common/config/committers.py:
2710
2711 2011-11-08  Andy Wingo  <wingo@igalia.com>
2712
2713         Skip some ECMAScript tests that fail on Linux in some time zones.
2714         https://bugs.webkit.org/show_bug.cgi?id=71371
2715
2716         Reviewed by Martin Robinson.
2717
2718         * Scripts/run-javascriptcore-tests: Skip some more tests.
2719
2720 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2721
2722         [Qt] Unreviewed trivial fix after build system refactoring.
2723
2724         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2725
2726 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2727
2728         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2729
2730         If a pro file needs to access the OBJECTS_DIR it should use the
2731         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2732         after defaults_post has been processed.
2733
2734         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2735         the command line will override whatever we set in defaults_pre.
2736
2737         Reviewed by Simon Hausmann.
2738
2739         * qmake/mkspecs/features/default_post.prf:
2740         * qmake/mkspecs/features/default_pre.prf:
2741
2742 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2743
2744         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2745
2746         Reviewed by Simon Hausmann.
2747
2748         * qmake/mkspecs/features/default_post.prf:
2749
2750 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2751
2752         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2753         https://bugs.webkit.org/show_bug.cgi?id=71680
2754
2755         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2756         complete urls in MiniBrowser.
2757
2758         Reviewed by Tor Arne Vestbø.
2759
2760         * MiniBrowser/qt/BrowserWindow.cpp:
2761         (BrowserWindow::BrowserWindow):
2762         (BrowserWindow::load):
2763         * MiniBrowser/qt/qml/BrowserWindow.qml:
2764         * MiniBrowser/qt/utils.cpp:
2765         (Utils::urlFromUserInput):
2766         * MiniBrowser/qt/utils.h:
2767         (Utils::Utils):
2768
2769 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2770
2771         Added myself as a committer.
2772
2773         * Scripts/webkitpy/common/config/committers.py:
2774
2775 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2776
2777         Unreviewed webkitpy test fix after r99512.
2778
2779         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2780         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2781
2782 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2783
2784         Added myself as a committer.
2785
2786         * Scripts/webkitpy/common/config/committers.py:
2787
2788 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2789
2790         Unreviewed, rolling out r99470.
2791         http://trac.webkit.org/changeset/99470
2792         https://bugs.webkit.org/show_bug.cgi?id=71740
2793
2794         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2795
2796         * Scripts/webkitpy/common/config/watchlist:
2797
2798 2011-11-07  Tony Chang  <tony@chromium.org>
2799
2800         [chromium] update flakiness dashboard to reflect current bots
2801
2802         Reviewed by Ojan Vafai.
2803
2804         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2805             bots and merged linux debug bots into a single bot.
2806         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2807         (setupExpectationsTest):
2808
2809 2011-11-07  Dana Jansens  <danakj@chromium.org>
2810
2811         Add cc-bugs group to watch changes in chromium graphics
2812         https://bugs.webkit.org/show_bug.cgi?id=71690
2813
2814         Reviewed by James Robinson.
2815
2816         * Scripts/webkitpy/common/config/watchlist:
2817
2818 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2819
2820         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2821         https://bugs.webkit.org/show_bug.cgi?id=70912
2822
2823         Reviewed by Ojan Vafai.
2824
2825         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2826         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2827
2828 2011-11-07  Eric Seidel  <eric@webkit.org>
2829
2830         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2831         https://bugs.webkit.org/show_bug.cgi?id=62199
2832
2833         Reviewed by Dirk Pranke.
2834
2835         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2836         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2837         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2838
2839 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2840
2841         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2842         https://bugs.webkit.org/show_bug.cgi?id=71485
2843
2844         Reviewed by Darin Fisher.
2845
2846         * DumpRenderTree/chromium/EventSender.cpp:
2847         (EventSender::scalePageBy):
2848         * DumpRenderTree/chromium/TestShell.cpp:
2849         (TestShell::resetTestController):
2850
2851 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2852
2853         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2854
2855         Allows us to not package up the whole Source/JavaScriptCore directory for the
2856         buildbots.
2857
2858         Reviewed-by Simon Hausmann.
2859
2860         * BuildSlaveSupport/built-product-archive:
2861         * Scripts/webkitdirs.pm:
2862         (jscProductDir):
2863
2864 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2865
2866         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2867
2868         Reviewed-by Simon Hausmann.
2869
2870         * qmake/mkspecs/features/default_post.prf:
2871
2872 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2873
2874         [Qt] Sanitize qmake paths correctly before comparing
2875
2876         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2877         which caused us to always generate derived webcore sources, but never build
2878         them. The bug has been fixed, and we now also sanitize paths for the injected
2879         bundle derived sources.
2880
2881         Reviewed by Simon Hausmann.
2882
2883         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2884         * qmake/mkspecs/features/functions.prf:
2885
2886 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2887
2888         [Qt] Print right order for changing feature defines
2889
2890         Reviewed by Simon Hausmann.
2891
2892         * Scripts/webkitdirs.pm:
2893         (buildQMakeProject):
2894
2895 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2896
2897         [Qt] Unreviewed trivial fix after build system refactoring.
2898
2899         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2900
2901 2011-11-06  Eric Seidel  <eric@webkit.org>
2902
2903         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2904         https://bugs.webkit.org/show_bug.cgi?id=66078
2905
2906         Unreviewed.  Add an assert about the type of "args"
2907         to our Executive Mocks and fix a piece of code
2908         from this patch which was hitting that assert
2909         when executing for real.
2910
2911         * Scripts/webkitpy/common/system/executive_mock.py:
2912         * Scripts/webkitpy/layout_tests/port/webkit.py:
2913
2914 2011-11-06  Eric Seidel  <eric@webkit.org>
2915
2916         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2917         https://bugs.webkit.org/show_bug.cgi?id=71629
2918
2919         Reviewed by Adam Barth.
2920
2921         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2922
2923 2011-11-06  Eric Seidel  <eric@webkit.org>
2924
2925         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2926         https://bugs.webkit.org/show_bug.cgi?id=66078
2927
2928         Reviewed by Adam Barth.
2929
2930         The runtime feature detection was fixed to work in bug 64472.
2931         In this bug I moved the symbol-based feature detection from
2932         popen() to Executive.run_command and cleaned up the callers
2933         and unittests to make sure that we're correctly parsing the
2934         nm output correctly.  The old code happened to work even though
2935         the runtime-features path was using "str in list" and the
2936         symbol features path was using "str in str" and it just happened
2937         to do what we wanted to.  Now runtime features and symbol feature
2938         blacklists are computed separately (and with better documentation).
2939
2940         This system remains confusing, partially because these are black-lists
2941         which are amended to whatever static blacklist may exist for the
2942         port as part of a Skipped list file.
2943
2944         For example, notice how the runtime feature list only has directory
2945         blacklists for a couple features.  If all features are off,
2946         how do we skip enough tests with only 2 entries in the blacklist map?
2947         The answer is that Windows is the only port to use runtime feature
2948         detection, and the win/Skipped file turns off all the other features
2949         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2950         which use symbol-based feature detection turn of mathml, wcss, etc
2951         using the blacklists found in _missing_symbol_to_skipped_tests.
2952
2953         I also noticed a couple places where we still referenced xhtmlmp
2954         even though support for such has been removed from WebKit.  Removed those.
2955
2956         This should result in no functional change.
2957
2958         * Scripts/webkitpy/layout_tests/port/gtk.py:
2959          - Use self._filesystem instead of os.path
2960         * Scripts/webkitpy/layout_tests/port/webkit.py:
2961         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2962
2963 2011-11-06  Dan Bernstein  <mitz@apple.com>
2964
2965         Made show-pretty-diff work when the input path contains spaces.
2966
2967         Reviewed by Anders Carlsson.
2968
2969         * Scripts/show-pretty-diff:
2970
2971 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2972
2973         [chromium] Use the security origin instead of the URL when checking notification permissions
2974         https://bugs.webkit.org/show_bug.cgi?id=71590
2975
2976         Reviewed by Adam Barth.
2977
2978         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2979         (NotificationPresenter::checkPermission):
2980         * DumpRenderTree/chromium/NotificationPresenter.h:
2981
2982 2011-11-05  Darin Adler  <darin@apple.com>
2983
2984         Fix a small leak in Mac version of LayoutTestController
2985         https://bugs.webkit.org/show_bug.cgi?id=71615
2986
2987         Reviewed by Mark Rowe.
2988
2989         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2990         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
2991         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
2992
2993 2011-11-04  Eric Seidel  <eric@webkit.org>
2994
2995         Upgrade to the latest Mechanize
2996         https://bugs.webkit.org/show_bug.cgi?id=71594
2997
2998         Reviewed by Adam Barth.
2999
3000         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
3001         Mechanize is no longer two separate libraries, so importing it is much simpler.
3002
3003         * Scripts/webkitpy/thirdparty/__init__.py:
3004
3005 2011-11-04  Stephen Chenney  <schenney@chromium.org>
3006
3007         Crash in ScrollAnimator.cpp
3008         https://bugs.webkit.org/show_bug.cgi?id=69865
3009
3010         The code in ScrollAnimator assumes that horizontal per-page mouse
3011         wheel events cannot happen, which is not true. This patch adds layout
3012         tests for all paging wheel event situations and fixes the broken
3013         horizontal case.
3014
3015         Reviewed by Anders Carlsson
3016
3017         * DumpRenderTree/chromium/EventSender.cpp:
3018         (EventSender::handleMouseWheel): Added the ability to specify that a
3019         mouse wheel event should be paging.
3020
3021 2011-11-04  Eric Seidel  <eric@webkit.org>
3022
3023         Remove deprecated free functions in port.factory
3024         https://bugs.webkit.org/show_bug.cgi?id=71494
3025
3026         Unreviewed.  Fix exception when running new-run-webkit-httpd.
3027
3028         * Scripts/new-run-webkit-httpd:
3029
3030 2011-11-04  Adam Roben  <aroben@apple.com>
3031
3032         Remove Leopard-specific code from build.webkit.org
3033
3034         We don't have any Leopard bots anymore.
3035
3036         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
3037
3038         Reviewed by Mark Rowe.
3039
3040         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
3041         and StopATSServer steps.
3042         (unitTestsSupported): Removed check for mac-leopard.
3043         (TestFactory.__init__): Removed Leopard-specific steps.
3044
3045 2011-11-04  Eric Seidel  <eric@webkit.org>
3046
3047         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
3048         https://bugs.webkit.org/show_bug.cgi?id=71549
3049
3050         Reviewed by Adam Barth.
3051
3052         Several members of Host didn't really belong there
3053         and were instead specific to WebKitPatch, so I've moved
3054         them up onto that class.
3055
3056         * Scripts/webkitpy/common/host.py:
3057         * Scripts/webkitpy/common/host_mock.py:
3058         * Scripts/webkitpy/tool/main.py:
3059         * Scripts/webkitpy/tool/mocktool.py:
3060         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3061
3062 2011-11-04  Tony Chang  <tony@chromium.org>
3063
3064         garden-o-matic: bring back party time!
3065         https://bugs.webkit.org/show_bug.cgi?id=71582
3066
3067         Reviewed by Adam Barth.
3068
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
3073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
3074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
3075
3076 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
3077
3078         [EFL] DRT: Fix the order of the items in the dumped history list.
3079         https://bugs.webkit.org/show_bug.cgi?id=71562
3080
3081         It did not make much sense to hold the history list in a map, as we do not need
3082         the keys. And the printed items must be sorted by target, which is more easily
3083         done with a vector.
3084
3085         Should make tests such as http/tests/navigation/error404-frames.html pass.
3086
3087         Reviewed by Antonio Gomes.
3088
3089         * DumpRenderTree/efl/DumpHistoryItem.cpp:
3090         (compareHistoryItemsByTarget):
3091         (dumpHistoryItem):
3092
3093 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
3094
3095         [Qt] Remove ENABLE_SQLITE from qmake files
3096         https://bugs.webkit.org/show_bug.cgi?id=71546
3097
3098         Reviewed by Simon Hausmann.
3099
3100         * qmake/mkspecs/features/features.prf:
3101         * qmake/mkspecs/features/webcore.prf:
3102
3103 2011-11-04  Adam Barth  <abarth@webkit.org>
3104
3105         watchlist for WebIDL shouldn't trigger on Internals.idl
3106         https://bugs.webkit.org/show_bug.cgi?id=70657
3107
3108         Reviewed by David Levin.
3109
3110         Internals.idl isn't part of the Web-facing IDL in the project.
3111
3112         * Scripts/webkitpy/common/config/watchlist:
3113
3114 2011-11-04  Anders Carlsson  <andersca@apple.com>
3115
3116         Fix WKTR crash when running NPN_ConvertPoint test.
3117
3118         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
3119
3120         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3121         (ConvertPoint::NPP_SetWindow):
3122
3123 2011-11-04  Anders Carlsson  <andersca@apple.com>
3124
3125         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3126         https://bugs.webkit.org/show_bug.cgi?id=71570
3127
3128         Reviewed by Simon Fraser.
3129
3130         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3131         (PluginTest::NPP_SetWindow):
3132         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3133         Remove the NPP parameter from NPP_SetWindow.
3134
3135         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3136         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3137         Remove the NPP parameter from NPP_SetWindow.
3138
3139         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3140         (PassDifferentNPPStruct::NPP_SetWindow):
3141         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3142
3143         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3144         (ConvertPoint::NPP_SetWindow):
3145         Run the test from NPP_SetWindow and call notifyDone() when done.
3146
3147         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3148         (NPP_SetWindow):
3149         Remove unnecessary parameter.
3150
3151 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3152
3153         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3154
3155         Rubber-stamped by Tor Arne Vestbø.
3156
3157         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3158         changed slightly after the refactoring.
3159
3160 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3161
3162         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3163
3164         Reviewed by Simon Hausmann.
3165
3166         * qmake/mkspecs/features/default_pre.prf:
3167
3168 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3169
3170         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3171
3172         Reviewed by Simmon Hausmann.
3173
3174         * qmake/mkspecs/features/default_pre.prf:
3175
3176 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3177
3178         [Qt] Disable STDIN check before cleaning build dir
3179
3180         It didn't work on the bots.
3181
3182         Reviewed by Ossy.
3183
3184         * Scripts/webkitdirs.pm:
3185
3186 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3187
3188         [Qt] Don't build all of webkit when running build-jsc
3189
3190         In case the whole webkit project was built, but we then subsequently
3191         want to build only JSC, we need to run make in the proper subdirectory.
3192
3193         This also means the incremental target needs to be added to all
3194         makefiles.
3195
3196         Reviewed by Simmon Hausmann.
3197
3198         * Scripts/webkitdirs.pm:
3199         (buildQMakeProject):
3200         * qmake/mkspecs/features/default_post.prf:
3201
3202 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3203
3204         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3205
3206         Reviewed by Tor Arne Vestbø.
3207
3208         * Scripts/webkitdirs.pm:
3209         (jscProductDir): jsc path changed.
3210
3211 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3212
3213         [Qt] Error out early if trying to build against Qt < 4.8
3214
3215         Reviewed by Simon Hausmann.
3216
3217         * qmake/mkspecs/features/default_pre.prf:
3218
3219 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3220
3221         Fix run-launcher for Qt and Gtk.
3222
3223         Rubber-stamped by Tor Arne Vestbø.
3224
3225         * Scripts/webkitdirs.pm:
3226         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3227
3228 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3229
3230         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3231
3232         Reviewed by Simon Hausmann.
3233
3234         * Scripts/build-webkit:
3235
3236 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3237
3238         [GTK] Use web view title as window title in MiniBrowser
3239         https://bugs.webkit.org/show_bug.cgi?id=71544
3240
3241         Reviewed by Philippe Normand.
3242
3243         * MiniBrowser/gtk/BrowserWindow.c:
3244         (webViewURIChanged): Removed extra space.
3245         (webViewTitleChanged): Set window title using
3246         webkit_web_view_get_title().
3247         (browser_window_init): Set initial default window title.
3248         (browserWindowConstructed): Connect to WebView notify::title
3249         signal.
3250
3251 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3252
3253         [Qt] Refactor and clean up the qmake build system
3254
3255         The qmake build system has accumulated a bit of cruft and redundancy
3256         over time. There's also a fairly tight coupling between how to build
3257         the various targets, and _what_ to build, making it harder to add new
3258         rules or sources. This patch aims to elevate these issues somewhat.
3259
3260         This is a short-list of the changes:
3261
3262           * The rules for how to build targets are now mostly contained as
3263             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3264             allows us to do pre- and post-processing of each project file,
3265             which helps to clean up the actual project files.
3266
3267           * Derived sources are no longer generated as a separate make-step
3268             but is part of each target's project file as a subdir. Makefile
3269             rules are used to ensure that we run make on the derived sources
3270             before running qmake on the actual target makefile. This makes
3271             it easier to keep a proper dependency between derived sources
3272             and the target.
3273
3274           * We use GNU make and the compiler to generate dependencies on
3275             UNIX-based systems running Qt 5. This allows us to lessen the
3276             need to run qmake, which should reduce compile time.
3277
3278           * WebKit2 is now build by default if building with Qt 5. It can
3279             be disabled by passing --no-webkit2 to build-webkit.
3280
3281         The result of these changes are hopefully a cleaner and easier
3282         build system to modify, and faster build times due to no longer
3283         running qmake on every single build. It's also a first step
3284         towards possibly generating the list of sources using another
3285         build system.
3286
3287         https://bugs.webkit.org/show_bug.cgi?id=71222
3288
3289         Reviewed by Simon Hausmann.
3290
3291         * DerivedSources.pro: Removed.
3292         * DumpRenderTree/qt/DumpRenderTree.pro:
3293         * DumpRenderTree/qt/ImageDiff.pro:
3294         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3295         * MiniBrowser/qt/MiniBrowser.pro:
3296         * QtTestBrowser/QtTestBrowser.pro:
3297         * QtTestBrowser/launcherwindow.cpp:
3298         (LauncherWindow::initializeView):
3299         (LauncherWindow::createChrome):
3300         (LauncherWindow::screenshot):
3301         * QtTestBrowser/launcherwindow.h:
3302         (WindowOptions::WindowOptions):
3303         * Scripts/build-webkit:
3304         (unlinkZeroFiles):
3305         * Scripts/webkitdirs.pm:
3306         (qtFeatureDefaults):
3307         (promptUser):
3308         (buildQMakeProject):
3309         * Tools.pro:
3310         * WebKitTestRunner/DerivedSources.pri: Added.
3311         * WebKitTestRunner/DerivedSources.pro: Removed.
3312         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3313         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3314         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3315         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3316         * WebKitTestRunner/Target.pri: Added.
3317         * WebKitTestRunner/WebKitTestRunner.pro:
3318         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3319         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3320         * qmake/README: Added.
3321         * qmake/mkspecs/features/default_post.prf: Added.
3322         * qmake/mkspecs/features/default_pre.prf: Added.
3323         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3324         * qmake/mkspecs/features/functions.prf: Added.
3325         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3326         * qmake/mkspecs/features/mac/default_post.prf: Added.
3327         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3328         * qmake/mkspecs/features/minimal_qt.prf: Added.
3329         * qmake/mkspecs/features/qtwebkit.prf: Added.
3330         * qmake/mkspecs/features/rpath.prf: Added.
3331         * qmake/mkspecs/features/unix/default_post.prf: Added.
3332         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3333         * qmake/mkspecs/features/valgrind.prf: Added.
3334         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3335         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3336         * qmake/mkspecs/features/win32/default_post.prf: Added.
3337         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3338         * qmake/syncqt-4.8: Added.
3339         (showUsage):
3340         ():
3341         (copyFile):
3342         (symlinkFile):
3343
3344 2011-11-04  Eric Seidel  <eric@webkit.org>
3345
3346         Remove deprecated free functions in port.factory
3347         https://bugs.webkit.org/show_bug.cgi?id=71494
3348
3349         Unreviewed.  Fixing exception seen when running test-webkitpy.
3350
3351         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3352         unittest, since that script is nearly ready to be deleted.  But I added
3353         it back at the last second and failed to run the tests. :(
3354         This fixes the exception the bots were seeing.
3355
3356         * Scripts/webkitpy/style/checkers/test_expectations.py:
3357         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3358         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3359
3360 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3361
3362         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3363         https://bugs.webkit.org/show_bug.cgi?id=71163
3364
3365         Reviewed by Ryosuke Niwa.
3366
3367         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3368         (WebPreferences::applyTo):
3369
3370 2011-11-03  Eric Seidel  <eric@webkit.org>
3371
3372         Remove deprecated free functions in port.factory
3373         https://bugs.webkit.org/show_bug.cgi?id=71494
3374
3375         Reviewed by Adam Barth.
3376
3377         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3378         free functions in factory.py.  To remove these required fixing all callsites
3379         to use MockHost, Host, or PortFactory where appropriate.  After this change
3380         we're only left with a handfull of places where we inappropraitely use a
3381         real Executive, FileSystem or User object during unittesting.
3382
3383         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3384          - These PortFactory overrides were from an earlier edition of my previous patch
3385            in the end, I removed MockPortFactory so all tests ended up with this same
3386            real PortFactory() with a MockHost.  This was simply redundent code.
3387         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3388          - Use MockHost to get a mocked-out PortFactory.
3389         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3390          - This code has no access to a Host object, so we just use a default PortFactory
3391            for now.  This will still incorrectly create real Executive/FileSystem objects
3392            durring unittesting, which is wrong. :(
3393         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3394          - Use a MockHost to get a mocked PortFactory.
3395         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3396          - Use a MockHost to get a mocked PortFactory.
3397         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3398          - ditto.
3399         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3400          - ditto.
3401         * Scripts/webkitpy/layout_tests/port/__init__.py:
3402          - factory.get no longer exists.  Yay!
3403         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3404          - Use a MockHost to get a mocked PortFactory.
3405            To do this efficiently, I created a helper function
3406            and combined all these (mostly redundant) tests into one test
3407            with several calls to the helper function.
3408         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3409          - Pass MockUser and MockExecutive in these port testing subclasses.
3410          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3411         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3412          - Awesome windows hacks should only happen on win32.  Once we started
3413            using MockExecutives these 'svn help' commands started printing in
3414            other tests, which is how I found this bug.
3415         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3416          - DryRunPort has no Host, so just use a PortFactory() directly.
3417            This will do the wrong thing if we're unittesting the DryRun port
3418            but it's no worse than the existing code.
3419         * Scripts/webkitpy/layout_tests/port/factory.py:
3420          - Remove the free functions.
3421          - Fix argument overriding to be able to override None.
3422         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3423          - Use a mocked-out PortFactory during testing.
3424         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3425          - Pass MockExecutive and MockUser to these manual Port instantiations.
3426         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3427          - No access to a Host object here, so just using PortFactory directly.
3428            This is wrong, but no more wrong than the existing code was.
3429         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3430          - Use a MockHost to get a mocked out PortFactory.
3431         * Scripts/webkitpy/layout_tests/port/test.py:
3432          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3433         * Scripts/webkitpy/layout_tests/port/win.py:
3434          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3435            now that we're actually passing MockExecutive to most Port instantiations during testing.
3436         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3437          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3439          - Host is the future.
3440         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3441          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3442            we don't need to pass MockUser explicitly, it does that automatically for us.
3443         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3444          - Use a MockHost to get a mocked out PortFactory.
3445         * Scripts/webkitpy/style/checkers/test_expectations.py:
3446          - We don't have access to a Host object, so using PortFactory() directly.
3447         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3448          - Remove unused variable.
3449         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3450          - Host isn't accessible here, so using PortFactory() directly, which
3451            although unfortunate is no worse than before.
3452         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3453          - Testing is much easier when you don't need to hack global state...
3454         * Scripts/webkitpy/tool/commands/expectations.py:
3455          - Use the port_factory on the tool.
3456         * Scripts/webkitpy/tool/commands/rebaseline.py:
3457          - ditto.
3458         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3459          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3460            the arguments in the right order.  Fixing that made it use a MockFileSystem
3461            (like it had been trying to), which then required us to actually populate
3462            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3463         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3464          - Get the port_factory from the tool.
3465         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3466          - Ditto.
3467         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3468          - Use a MockHost to get a mocked out Port object.
3469
3470 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3471
3472         [EFL] DRT: Allow choosing which backing store to use.
3473         https://bugs.webkit.org/show_bug.cgi?id=70532
3474
3475         Reviewed by Antonio Gomes.
3476
3477         This change makes it possible to change the backing store used by DRT
3478         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3479         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3480
3481         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3482         (DumpRenderTreeChrome::createView):
3483         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3484         (shouldUseSingleBackingStore):
3485         (chooseAndInitializeAppropriateSmartClass):
3486         (drtViewAdd):
3487         * DumpRenderTree/efl/DumpRenderTreeView.h:
3488
3489 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3490
3491         JS Test Harness: Remove more link tags
3492         https://bugs.webkit.org/show_bug.cgi?id=71339
3493
3494         Reviewed by Ojan Vafai.
3495
3496         * Scripts/make-new-script-test:
3497         (writeTestFile): Don't output <link>
3498
3499 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3500
3501         Reviewed by Martin Robinson.
3502
3503         [GTK] arguments passed to build-jsc are not taken into account
3504         https://bugs.webkit.org/show_bug.cgi?id=58333
3505
3506         * Scripts/build-jsc:
3507
3508 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3509
3510         [GTK] Show url of history items in a status bar in MiniBrowser
3511         https://bugs.webkit.org/show_bug.cgi?id=71474
3512
3513         Reviewed by Martin Robinson.
3514
3515         * MiniBrowser/gtk/BrowserWindow.c:
3516         (browserWindowSetStatusText): Set status text and show/hide the
3517         status label.
3518         (resetStatusText): Reset status text when history menu is hidden.
3519         (browserWindowHistoryItemSelected): Show url of currently selected
3520         history item.
3521         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3522         menu to reset the status text.
3523         (browserWindowConstructed): Use GtkOverlay if available to show
3524         status text.
3525
3526 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3527
3528         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3529         https://bugs.webkit.org/show_bug.cgi?id=71466
3530
3531         Reviewed by Martin Robinson.
3532
3533         * MiniBrowser/gtk/BrowserWindow.c:
3534         (browserWindowHistoryItemActivated): Go to selected back formard
3535         list item using webkit_web_view_go_to_back_forward_list_item()
3536         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3537         given GList of WebKitBackForwardListItems.
3538         (browserWindowUpdateNavigationActions): Enable/disable back and
3539         forward buttons depending on whether it's possible to go
3540         back/forward. Create a menu for back and forward toolbar buttons.
3541         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3542         (browserWindowConstructed): Connect to WebKitBackForwardList
3543         changed signal.
3544
3545 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3546
3547         [Qt] Remove Maemo specific code paths
3548         https://bugs.webkit.org/show_bug.cgi?id=71476
3549
3550         Reviewed by Kenneth Rohde Christiansen.
3551
3552         * QtTestBrowser/launcherwindow.cpp:
3553         (LauncherWindow::~LauncherWindow):
3554         (LauncherWindow::init):
3555         (LauncherWindow::showLinkHover):
3556         (LauncherWindow::selectElements):
3557         (LauncherWindow::showFPS):
3558         (LauncherWindow::updateFPS):
3559         * QtTestBrowser/launcherwindow.h:
3560         (WindowOptions::WindowOptions):
3561         * QtTestBrowser/locationedit.cpp:
3562         * QtTestBrowser/locationedit.h:
3563
3564 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3565
3566         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3567         https://bugs.webkit.org/show_bug.cgi?id=71461
3568
3569         Reviewed by Martin Robinson.
3570
3571         * MiniBrowser/gtk/BrowserWindow.c:
3572         (resetEntryProgress): Reset the entry progress after a while when
3573         load has been completed.
3574         (webViewLoadProgressChanged): Update location entry progress.
3575         (browserWindowConstructed): Connect to WebView
3576         notify::estimated-load-progress signal.
3577
3578 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3579
3580         [GTK] Remove WebKit2 C API from MiniBrowser
3581         https://bugs.webkit.org/show_bug.cgi?id=71459
3582
3583         Reviewed by Martin Robinson.
3584
3585         Use the GTK+ API instead to add minimum functionality. The other
3586         features will be ported to GTK+ API in following patches.
3587
3588         * MiniBrowser/gtk/BrowserWindow.c:
3589         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3590         (goBackCallback): Use webkit_web_view_go_back().
3591         (goForwardCallback): Use webkit_web_view_go_forward().
3592         (webViewURIChanged): Update location entry with current uri using
3593         webkit_web_view_get_uri().
3594         (browserWindowFinalize):
3595         (browserWindowGetProperty):
3596         (browserWindowSetProperty):
3597         (browser_window_init):
3598         (browserWindowConstructed): Connect to notify::uri signal of
3599         WebView to be notified when the URI changes.
3600         (browser_window_class_init):
3601         (browser_window_new): Use WebKitWebView.
3602         (browser_window_get_view): Use WebKitWebView
3603         * MiniBrowser/gtk/BrowserWindow.h:
3604         * MiniBrowser/gtk/GNUmakefile.am:
3605         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3606         * MiniBrowser/gtk/main.c:
3607         (loadURI): Use webkit_web_view_new().
3608         (main):
3609
3610 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3611
3612         [Qt] Unable to start MiniBrowser after run-webkit-tests
3613         https://bugs.webkit.org/show_bug.cgi?id=71469
3614
3615         Reviewed by Csaba Osztrogonác.
3616
3617         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3618         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3619         line arguments.
3620
3621 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3622
3623         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3624         https://bugs.webkit.org/show_bug.cgi?id=71445
3625
3626         Reviewed by Martin Robinson.
3627
3628         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3629         (initializeFonts): set directoriesDescription only when needed.
3630         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3631         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3632         refactored the font files loading code to avoid copy/pastes, ease
3633         maintenance and future font directories additions.
3634
3635 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3636
3637         [GTK] Remove GtkLauncher2
3638         https://bugs.webkit.org/show_bug.cgi?id=71449
3639
3640         Reviewed by Martin Robinson.
3641
3642         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3643         made sense when we wanted to implement the exactly same wk1 API
3644         for wk2. Now the code would require an ifdef for most the api, so
3645         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3646         GTK+ API.
3647
3648         * GNUmakefile.am:
3649         * GtkLauncher/main.c:
3650         (notifyProgressCb):
3651         (closeWebViewCb):
3652         (createBrowser):
3653         (addWebSettingsGroupToContext):
3654         (main):
3655
3656 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3657
3658         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3659         https://bugs.webkit.org/show_bug.cgi?id=71359
3660
3661         Reviewed by Martin Robinson.
3662
3663         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3664         (initializeFonts): Add the new font path for Debian fonts and
3665         refactored the font files loading code to avoid copy/pastes, ease
3666         maintenance and future font directories additions.
3667
3668 2011-11-02  Eric Seidel  <eric@webkit.org>
3669
3670         Move Mocks into _mock files near their implementations
3671         https://bugs.webkit.org/show_bug.cgi?id=71425
3672
3673         Reviewed by Adam Barth.
3674
3675         This entire change is splitting mocktool.py into separate _mock.py files
3676         and placing them next to their real implementations.
3677
3678         I also deleted MockPortFactory (since it was wrong) and was just hiding
3679         the fact that the "skipped-ports" command was broken (and has been for a long time).
3680         So I made MockHost use a real PortFactory (passed a MockHost) and changed
3681         the skipped-ports implementation to use modern PortFactory methods.
3682
3683         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3684         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
3685         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3686         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3687         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
3688         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3689         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3690         * Scripts/webkitpy/common/host.py:
3691         * Scripts/webkitpy/common/host_mock.py: Added.
3692         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
3693         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3694         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
3695         * Scripts/webkitpy/common/net/credentials_unittest.py:
3696         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3697         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3698         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3699         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3700         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3701         * Scripts/webkitpy/common/system/executive.py:
3702         * Scripts/webkitpy/common/system/executive_mock.py:
3703         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3704         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3705         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3706         * Scripts/webkitpy/common/system/workspace_unittest.py:
3707         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3708         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3709         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3710         * Scripts/webkitpy/layout_tests/port/__init__.py:
3711         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3712         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3713         * Scripts/webkitpy/layout_tests/port/factory.py:
3714         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3715         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3716         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3717         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3718         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3719         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3720         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3721         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3722         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3723         * Scripts/webkitpy/test/main.py:
3724         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3725         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3726         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3727         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3728         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3729         * Scripts/webkitpy/tool/mocktool.py:
3730         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3731
3732 2011-11-02  Dan Bernstein  <mitz@apple.com>
3733
3734         Fixed the build and removed another copy to ColorBits.ttf.
3735
3736         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3737         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3738         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
3739
3740 2011-11-02  Dan Bernstein  <mitz@apple.com>
3741
3742         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
3743         https://bugs.webkit.org/show_bug.cgi?id=71424
3744
3745         Reviewed by Sam Weinig.
3746
3747         Removed the ColorBits font and the code to register it in the process
3748         running the tests. The font was only used by the aforementioned test,
3749         which is now being removed.
3750
3751         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
3752         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
3753         * DumpRenderTree/mac/DumpRenderTree.mm:
3754         (allowedFontFamilySet):
3755         (activateTestingFonts):
3756         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3757         (WTR::inititializeFontConfigSetting):
3758         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3759         (WTR::allowedFontFamilySet):
3760         (WTR::activateFonts):
3761
3762 2011-11-02  Dan Bernstein  <mitz@apple.com>
3763
3764         Fix an intermittent hang in RenderedImageFromDOMRange.
3765
3766         Reviewed by Anders Carlsson.
3767
3768         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3769         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
3770         immediately if there are no sources by passing a date in the distant past.
3771
3772 2011-11-02  Adam Roben  <aroben@apple.com>
3773
3774         Add git-add-reviewer
3775
3776         I've been using this script for a while to add reviewers to git commits in my local
3777         repository before pushing them to the Subversion repository. Basic usage is:
3778
3779         git-add-reviewer HEAD^ "Joe Schmoe"
3780         or
3781         git-add-reviewer -i trunk
3782
3783         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
3784         git commits
3785
3786         Reviewed by Sam Weinig.
3787
3788         * Scripts/git-add-reviewer: Added.
3789         (top level): Parse options, check that the working tree is clean, then run in either
3790         interactive or non-interactive mode as appropriate.
3791         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
3792         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
3793         editor exits, we check out the commit just before the earliest one we're modifying. Then
3794         for each commit, we check it out, update the reviewer, and amend the commit to contain the
3795         new reviewer. Finally, we update the branch that was originally checked out to point to the
3796         last amended commit.
3797         (nonInteractive): Check out the commit to modify, write the current commit message to the
3798         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
3799         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
3800         a usage message and exit.
3801         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
3802         and index are clean.
3803         (fail): Print out the specified error message, if any, and return false. This function is
3804         used as a return value in various error cases throughout the script.
3805         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
3806         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
3807         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
3808         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
3809
3810         (addReviewerToChangeLog):
3811         (addReviewerToCommitMessage):
3812         These just call through to addReviewerToFile.
3813
3814         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
3815         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
3816         temp file, then move the temp file over the original file and stage it for the next commit.
3817         (head): Returns the name of the currently-checked-out branch.
3818         (isAncestor): Returns true if the first commit is an ancestor of the second.
3819         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
3820         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
3821         (resetToCommit): Checks out the given commit, throwing away any local changes.
3822         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
3823         the specified file.
3824         (rebaseOntoHead): Rebases the specified branch onto HEAD.
3825         (checkout): Checks out the given commit.
3826         (getConfigValue): Reads the specified config variable from git-config.
3827
3828 2011-11-02  Dean Jackson  <dino@apple.com>
3829
3830         Add ENABLE_CSS_SHADERS flag
3831         https://bugs.webkit.org/show_bug.cgi?id=71394
3832
3833         Reviewed by Sam Weinig.
3834
3835         * Scripts/build-webkit:
3836
3837 2011-10-31  Eric Seidel  <eric@webkit.org>
3838
3839         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
3840         https://bugs.webkit.org/show_bug.cgi?id=71237
3841
3842         Reviewed by Adam Barth.
3843
3844         Calling the static version of factory.get() with proper mocking
3845         requires passsing an explict filesystem, executive, etc.
3846         So instead, we use a PortFactory instance and pass it a Host pointer.
3847         I had to add a MockHost since we'd not needed a non-host tool before now.
3848
3849         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3850         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3851         * Scripts/webkitpy/tool/commands/rebaseline.py:
3852         * Scripts/webkitpy/tool/mocktool.py:
3853
3854 2011-11-02  Anders Carlsson  <andersca@apple.com>
3855
3856         Update for the WebKit2 API fixage.
3857
3858         * MiniBrowser/mac/BrowserWindowController.m:
3859         (-[BrowserWindowController awakeFromNib]):
3860         * WebKitTestRunner/TestController.cpp:
3861         (WTR::TestController::initialize):
3862
3863 2011-11-02  Anders Carlsson  <andersca@apple.com>
3864
3865         Fix build.
3866
3867         Add new functions to the page loader client.
3868
3869         * MiniBrowser/mac/BrowserWindowController.m:
3870         (-[BrowserWindowController awakeFromNib]):
3871         * WebKitTestRunner/TestController.cpp:
3872         (WTR::TestController::initialize):
3873
3874 2011-11-02  Dan Bernstein  <mitz@apple.com>
3875
3876         <rdar://problem/10336700> Add API to get rendered text image without having to select it
3877         https://bugs.webkit.org/show_bug.cgi?id=71407
3878
3879         Reviewed by Simon Fraser.
3880
3881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3882         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
3883         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
3884         (TestWebKitAPI::TEST):
3885
3886 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
3887
3888         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
3889         https://bugs.webkit.org/show_bug.cgi?id=71351
3890
3891         Reviewed by Darin Adler.
3892
3893         Add the delimiter "/" at the end of the path instead of adding +1 when using
3894         the path.
3895
3896         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3897         (-[NSURL _drt_descriptionSuitableForTestResult]):
3898
3899 2011-11-02  Tom Sepez  <tsepez@chromium.org>
3900
3901         XSSAuditor is silent
3902         https://bugs.webkit.org/show_bug.cgi?id=70973
3903
3904         Reviewed by Adam Barth.
3905
3906         * DumpRenderTree/chromium/WebViewHost.cpp:
3907         (WebViewHost::didDetectXSS):
3908         * DumpRenderTree/chromium/WebViewHost.h:
3909         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3910         (-[FrameLoadDelegate webView:didDetectXSS:]):
3911         * MiniBrowser/mac/BrowserWindowController.m:
3912         (didDetectXSSForFrame):
3913         (-[BrowserWindowController awakeFromNib]):
3914         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3915         (WTR::InjectedBundlePage::InjectedBundlePage):
3916         (WTR::InjectedBundlePage::didDetectXSSForFrame):
3917         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3918
3919 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
3920
3921         [Qt] REGRESSION: 5 editing tests fail
3922         https://bugs.webkit.org/show_bug.cgi?id=71117
3923
3924         Reviewed by Andreas Kling.
3925
3926         Make sure that the view is properly focused, in order to get the
3927         didBeginEditing DRT calls.
3928
3929         This requires activating the window (the call will result in a FocusIn
3930         event to the window as well as setting QGuiApplication::focusWindow())
3931         as well as enabling the focus on the view item. The signature of
3932         setFocus has changed to take a boolean.
3933
3934         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3935         (WTR::WrapperWindow::handleStatusChanged):
3936
3937 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
3938
3939         [chromium] Add per-script font preferences support in overridePreference
3940         https://bugs.webkit.org/show_bug.cgi?id=71110
3941
3942         This allows a layout test to do something like:
3943
3944         // Set standard font for Arabic to Ahem.
3945         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
3946
3947         This should make writing a layout test for per-script fonts easier.
3948
3949         This change only affects the Chromium DumpRenderTree, but the other
3950         platforms should probably also have a similar change eventually.
3951
3952         Reviewed by Tony Chang.
3953
3954         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
3955         font preferences to overridePreference
3956         (LayoutTestController::cppVariantToWebStringArray):
3957         (setFontMap):
3958         (LayoutTestController::overridePreference):
3959         * DumpRenderTree/chromium/LayoutTestController.h:
3960         * DumpRenderTree/chromium/WebPreferences.cpp:
3961         (setStandardFontFamilyWrapper):
3962         (setFixedFontFamilyWrapper):
3963         (setSerifFontFamilyWrapper):
3964         (setSansSerifFontFamilyWrapper):
3965         (setCursiveFontFamilyWrapper):
3966         (setFantasyFontFamilyWrapper):
3967         (applyFontMap):
3968         (WebPreferences::applyTo):
3969         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
3970         preference members
3971         (WebPreferences::UScriptCodeHashTraits::emptyValue):
3972         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
3973         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
3974
3975 2011-11-02  Elliot Poger  <epoger@google.com>
3976
3977         until use_skia=1 by default on mac, default port should be chromium-cg-mac
3978         https://bugs.webkit.org/show_bug.cgi?id=71312
3979
3980         Reviewed by Adam Barth.
3981
3982         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3983         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3984         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3985
3986 2011-11-02  Stephen Chenney  <schenney@chromium.org>
3987
3988         printing layout test failures after r98634
3989         https://bugs.webkit.org/show_bug.cgi?id=71080
3990
3991         Reviewed by Kent Tamura
3992
3993         * DumpRenderTree/chromium/WebViewHost.cpp:
3994         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
3995         matches that for Skia.
3996
3997 2011-11-01  Sam Weinig  <sam@webkit.org>
3998
3999         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
4000         https://bugs.webkit.org/show_bug.cgi?id=71346
4001
4002         Reviewed by Dan Bernstein.
4003
4004         * Scripts/webkit-tools-completion.sh:
4005         Add "-o default" which allows for completing files in addition to the word list.
4006
4007 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
4008
4009         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
4010         https://bugs.webkit.org/show_bug.cgi?id=71310
4011
4012         Reviewed by Kenneth Rohde Christiansen.
4013
4014         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
4015         define works in EventSendingController.idl
4016         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
4017         handlers.
4018         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
4019         required by tests.
4020         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
4021         ui process.
4022         (WTR::EventSendingController::addTouchPoint):
4023         (WTR::EventSendingController::updateTouchPoint):
4024         (WTR::EventSendingController::setTouchModifier):
4025         (WTR::EventSendingController::touchStart):
4026         (WTR::EventSendingController::touchMove):
4027         (WTR::EventSendingController::touchEnd):
4028         (WTR::EventSendingController::clearTouchPoints):
4029         (WTR::EventSendingController::releaseTouchPoint):
4030         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
4031         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
4032         defines.
4033         * WebKitTestRunner/TestController.cpp:
4034         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
4035         touch messages to the EventSenderProxy.
4036         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
4037         (WTR::EventSenderProxy::EventSenderProxy):
4038         (WTR::EventSenderProxy::addTouchPoint):
4039         (WTR::EventSenderProxy::updateTouchPoint):
4040         (WTR::EventSenderProxy::setTouchModifier):
4041         (WTR::EventSenderProxy::touchStart):
4042         (WTR::EventSenderProxy::touchMove):
4043         (WTR::EventSenderProxy::touchEnd):
4044         (WTR::EventSenderProxy::clearTouchPoints):
4045         (WTR::EventSenderProxy::releaseTouchPoint):
4046         (WTR::EventSenderProxy::sendTouchEvent):
4047         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
4048
4049 2011-11-01  Sam Weinig  <sam@webkit.org>
4050
4051         resolve-ChangeLogs --help should be faster.
4052
4053         Reviewed by Adam Roben.
4054
4055         * Scripts/resolve-ChangeLogs:
4056         (usageAndExit):
4057         Add a call to usageAndExit() before doing work to find unmerged changelogs
4058         if --help or something illegal is provided on the command line.
4059
4060 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
4061
4062         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
4063         https://bugs.webkit.org/show_bug.cgi?id=71342
4064
4065         Reviewed by Darin Adler.
4066
4067         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
4068         [NSString substringFromIndex:] with an index out of the string range.
4069
4070         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
4071         from the root of the disk.
4072         The problem was hidden because the exception are catched when calling the delegate.
4073
4074         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
4075         in a subdirectory of the main frame.
4076
4077         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
4078         (-[NSURL _drt_descriptionSuitableForTestResult]):
4079
4080 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
4081
4082         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
4083         https://bugs.webkit.org/show_bug.cgi?id=71318
4084
4085         Reviewed by James Robinson.
4086         
4087         Fixed a typo for --enable-hardware-gpu flag.
4088
4089         * Scripts/webkitpy/layout_tests/port/chromium.py:
4090
4091 2011-11-01  Elliot Poger  <epoger@google.com>
4092
4093         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
4094         https://bugs.webkit.org/show_bug.cgi?id=71286
4095
4096         Reviewed by Stephen White.
4097
4098         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4099
4100 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
4101
4102         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
4103         https://bugs.webkit.org/show_bug.cgi?id=71299
4104
4105         Reviewed by Andreas Kling.
4106
4107         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
4108         build to enable WebCoreTestSupport::injectInternalsObject.
4109         (WTR::InjectedBundlePage::didClearWindowForFrame):
4110         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
4111
4112 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4113
4114         [Qt] Merge common desktop and touch view APIs under a base class.
4115         https://bugs.webkit.org/show_bug.cgi?id=71280
4116
4117         Reviewed by Andreas Kling.
4118
4119         Remove unneded forwarding logic for TouchWebView since those properties are
4120         now in the view just as the desktop web view.
4121
4122         * MiniBrowser/qt/qml/TouchView.qml:
4123
4124 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4125
4126         check-webkit-style: Allow names starting with "_q_".
4127         https://bugs.webkit.org/show_bug.cgi?id=70625
4128
4129         Reviewed by Tor Arne Vestbø.
4130
4131         Used by the Qt port as the standard prefix for private slots.
4132
4133         * Scripts/webkitpy/style/checkers/cpp.py:
4134         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4135
4136 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
4137
4138         [Qt][WK2] Fix valgrind error about uninitialized variable
4139         https://bugs.webkit.org/show_bug.cgi?id=71273
4140
4141         Reviewed by Kenneth Christiansen.
4142
4143         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4144         (MiniBrowserApplication::notify): Initialize isPrimary.
4145
4146 2011-10-31  Adam Roben  <aroben@apple.com>
4147
4148         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
4149
4150         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
4151         leaky builds
4152
4153         Reviewed by Anders Carlsson.
4154
4155         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
4156         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
4157         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
4158         total of N bytes!").
4159
4160 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
4161
4162         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
4163         https://bugs.webkit.org/show_bug.cgi?id=71228
4164
4165         Reviewed by Antonio Gomes.
4166
4167         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4168         (DumpRenderTreeChrome::createNewWindow):
4169         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4170
4171 2011-10-31  Eric Seidel  <eric@webkit.org>
4172
4173         webkitpy tests depend too much on the user's environment
4174         https://bugs.webkit.org/show_bug.cgi?id=71234
4175
4176         Reviewed by Dirk Pranke.
4177
4178         This change just makes a bunch of our older tests use
4179         more modern mocking to avoid trying to launch processes
4180         or read from the user's filesystem during unittesting.
4181
4182         I found many of these by adding an assert in Executive.run_command
4183         that we were not unittesting.  I can't add that assert always
4184         as there are some valid uses of Executive during unittesting.
4185         Once I fix more of these, I may find a way to add such an assert conditionally.
4186
4187         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4188         * Scripts/webkitpy/common/net/credentials_unittest.py:
4189         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4190         * Scripts/webkitpy/layout_tests/port/base.py:
4191         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4192
4193 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4194
4195         [Qt] MiniBrowser doesn't resize as the size is always overridden
4196         https://bugs.webkit.org/show_bug.cgi?id=71212
4197
4198         Reviewed by Simon Hausmann.
4199
4200         Remove call overriden the size.
4201
4202         * MiniBrowser/qt/main.cpp:
4203         (main):
4204
4205 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
4206
4207         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
4208         http://trac.webkit.org/changeset/98819
4209         http://trac.webkit.org/changeset/98823
4210         http://trac.webkit.org/changeset/98825
4211         http://trac.webkit.org/changeset/98830
4212         https://bugs.webkit.org/show_bug.cgi?id=71199
4213
4214         Broke Chromium Windows bot (Requested by rniwa on #webkit).
4215
4216         * Scripts/webkitpy/layout_tests/port/base.py:
4217         * Scripts/webkitpy/layout_tests/port/chromium.py:
4218         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4219         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4220         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4221         * Scripts/webkitpy/layout_tests/port/efl.py:
4222         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4223         * Scripts/webkitpy/layout_tests/port/mac.py:
4224         * Scripts/webkitpy/layout_tests/port/qt.py:
4225         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
4226         * Scripts/webkitpy/layout_tests/port/webkit.py:
4227         * Scripts/webkitpy/layout_tests/port/win.py:
4228
4229 2011-10-30  Eric Seidel  <eric@webkit.org>
4230
4231         new-run-webkit-tests is locale dependent
4232         https://bugs.webkit.org/show_bug.cgi?id=68691
4233
4234         Unreviewed.
4235
4236         This is a temporary hack until someone from the cr-win port
4237         can take a look and determine which environment variable
4238         lighttpd is missing.
4239
4240         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4241
4242 2011-10-30  Eric Seidel  <eric@webkit.org>
4243
4244         new-run-webkit-tests is locale dependent
4245         https://bugs.webkit.org/show_bug.cgi?id=68691
4246
4247         Unreviewed.  I would have preferred to have this reviewed,
4248         but relevant reviewers are asleep and bots are broken.
4249
4250         This was a regression from moving to a clean environment.
4251         ChromiumWin (and possibly other ports), need the "PATH"
4252         environment copied over.  This wasn't caught in my testing
4253         because although we had unittests to cover this, they
4254         weren't being run on anything but windows.  The vast majority
4255         of this change is just fixing the unittests to use our
4256         modern MockFileSystem/MockUser/MockExecutive so they can
4257         be run on any system (and removing the platform checks from
4258         the unittests so they are run everywhere).
4259
4260         The actual fix is the single line "PATH" string added to base.py.
4261         The rest of this change is just fixing the Chromium port unittests
4262         to run on all systems (including changing the Chromium port to
4263         use FileSystem.path_to_module instead of __file__).
4264
4265         * Scripts/webkitpy/layout_tests/port/base.py:
4266         * Scripts/webkitpy/layout_tests/port/chromium.py:
4267         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4268         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4269         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4270         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4271
4272 2011-10-29  Eric Seidel  <eric@webkit.org>
4273
4274         new-run-webkit-tests is locale dependent