0c31d99d2857b9910a5ac04d5c2af054b6862417
[WebKit-https.git] / Tools / ChangeLog
1 2013-01-16  Eric Seidel  <eric@webkit.org>
2
3         Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
4         https://bugs.webkit.org/show_bug.cgi?id=106036
5
6         Reviewed by Darin Adler.
7
8         * Scripts/webkitpy/webkitpy.pyproj: Removed.
9         * Scripts/webkitpy/webkitpy.sln: Removed.
10
11 2013-01-16  Chris Hopman  <cjhopman@chromium.org>
12
13         [Chromium] Remove hardcoded chromium_*.jar in gyp files
14         https://bugs.webkit.org/show_bug.cgi?id=104049
15
16         Reviewed by Eric Seidel.
17
18         Targets with dependencies (direct/indirect) on a java target receive
19         the chromium_*.jar paths in the variable input_jars_paths. Targets
20         should use that rather than hardcoding where they think the jar will
21         be. These can be passed directly to ant as INPUT_JARS_PATHS rather
22         than as --jars to generate_native_test.py.
23
24         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
25         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
26
27 2013-01-16  Dan Carney  <dcarney@google.com>
28
29         [chromium] move setMockDeviceOrientation to TestRunner library
30         https://bugs.webkit.org/show_bug.cgi?id=106895
31
32         Reviewed by Jochen Eisinger.
33
34         * DumpRenderTree/chromium/DRTTestRunner.cpp:
35         (DRTTestRunner::DRTTestRunner):
36         * DumpRenderTree/chromium/DRTTestRunner.h:
37         (DRTTestRunner):
38         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
39         (WebKit):
40         (WebTestRunner::WebTestDelegate::setDeviceOrientation):
41         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
42         (WebTestRunner::TestRunner::TestRunner):
43         (WebTestRunner::TestRunner::setMockDeviceOrientation):
44         (WebTestRunner):
45         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
46         (TestRunner):
47         * DumpRenderTree/chromium/WebViewHost.cpp:
48         (WebViewHost::setDeviceOrientation):
49         * DumpRenderTree/chromium/WebViewHost.h:
50         (WebViewHost):
51
52 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
53
54         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
55         https://bugs.webkit.org/show_bug.cgi?id=106904
56
57         Reviewed by Adam Barth.
58
59         * DumpRenderTree/chromium/DRTTestRunner.cpp:
60         (DRTTestRunner::DRTTestRunner):
61         (DRTTestRunner::notifyDone):
62         (DRTTestRunner::reset):
63         * DumpRenderTree/chromium/DRTTestRunner.h:
64         (DRTTestRunner):
65         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
66         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
67         (WebTestRunner::WebTestDelegate::setFocus):
68         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
69         (WebTestRunner::WebTestDelegate::pathToLocalResource):
70         (WebTestRunner::WebTestDelegate::setLocale):
71         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
72         (WebTestRunner::TestRunner::TestRunner):
73         (WebTestRunner::TestRunner::reset):
74         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
75         (WebTestRunner):
76         (WebTestRunner::TestRunner::setWindowIsKey):
77         (WebTestRunner::TestRunner::pathToLocalResource):
78         (WebTestRunner::TestRunner::setBackingScaleFactor):
79         (WebTestRunner::TestRunner::setPOSIXLocale):
80         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
81         (WebTestRunner::TestRunner::taskList):
82         (TestRunner):
83         * DumpRenderTree/chromium/WebViewHost.cpp:
84         (WebViewHost::setDeviceScaleFactor):
85         (WebViewHost::setFocus):
86         (WebViewHost::setAcceptAllCookies):
87         (WebViewHost::pathToLocalResource):
88         (WebViewHost::setLocale):
89         * DumpRenderTree/chromium/WebViewHost.h:
90         (WebViewHost):
91
92 2013-01-16  Sergio Villar Senin  <svillar@igalia.com>
93
94         [GTK] build-webkit fails if the jhbuild wrapper is not used
95         https://bugs.webkit.org/show_bug.cgi?id=106769
96
97         Reviewed by Martin Robinson.
98
99         Return an empty array instead of "" in
100         jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
101         will not be recognized as a valid command when the returned array
102         is directly passed to perl's system() call.
103
104         * Scripts/webkitdirs.pm:
105         (jhbuildWrapperPrefixIfNeeded):
106
107 2013-01-16  Jochen Eisinger  <jochen@chromium.org>
108
109         [chromium] add title text direction attribute to TestRunner
110         https://bugs.webkit.org/show_bug.cgi?id=106907
111
112         Reviewed by Adam Barth.
113
114         * DumpRenderTree/chromium/DRTTestRunner.cpp:
115         (DRTTestRunner::DRTTestRunner):
116         (DRTTestRunner::reset):
117         * DumpRenderTree/chromium/DRTTestRunner.h:
118         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
119         (WebTestRunner::WebTestRunner::setTitleTextDirection):
120         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
121         (WebTestRunner::TestRunner::TestRunner):
122         (WebTestRunner::TestRunner::reset):
123         (WebTestRunner::TestRunner::setTitleTextDirection):
124         (WebTestRunner):
125         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
126         (TestRunner):
127         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
128         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
129         * DumpRenderTree/chromium/WebViewHost.cpp:
130         (WebViewHost::didReceiveTitle):
131
132 2013-01-16  Jussi Kukkonen  <jussi.kukkonen@intel.com>
133
134         NRWT still confused about test count with --repeat-each and --iterations
135         https://bugs.webkit.org/show_bug.cgi?id=106562
136
137         Reviewed by Dirk Pranke.
138
139         Fix the printed unique test count and skipped count. This
140         seems to have broken in r127688 ("NRWT lies about the number
141         of tests that it's skipping when used with --repeat-each").
142
143         Also add a test for print_found()
144
145         * Scripts/webkitpy/layout_tests/views/printing.py:
146         (Printer.print_found):
147         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
148         (Testprinter.test_details):
149         (Testprinter):
150         (Testprinter.test_found):
151
152 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
153
154         Unreviewed follow-up to r139769.
155
156         Note that omitting the WebKit1 code from the build now
157         works for GTK as well.
158
159         * Scripts/build-webkit:
160
161 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
162
163         test-webkitpy: truncate output to the terminal width when necessary
164         https://bugs.webkit.org/show_bug.cgi?id=106973
165
166         Reviewed by Ojan Vafai.
167
168         this implements the same logic for test-webkitpy that we have
169         for run-webkit-tests (and ninja).
170
171         No tests written as this is exercised by running test-webkitpy itself.
172
173         * Scripts/webkitpy/test/printer.py:
174         (Printer.configure):
175         (Printer._test_line):
176
177 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
178
179         remove extraneous output in test-webkitpy
180         https://bugs.webkit.org/show_bug.cgi?id=106971
181
182         Reviewed by Ojan Vafai.
183
184         We weren't ignoring or capturing the echoed output from
185         these two tests, and getting noise in the logs as a result.
186
187         * Scripts/webkitpy/common/system/executive_unittest.py:
188         (ExecutiveTest.test_auto_stringify_args):
189         (ExecutiveTest.test_popen_args):
190
191 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
192
193         webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
194         https://bugs.webkit.org/show_bug.cgi?id=106974
195
196         Reviewed by Ryosuke Niwa.
197
198         I forgot to stub out the call to check to ensure that the ports were
199         available, so this test could fail if something was listening on 8000 or
200         8443 on the machine.
201
202         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
203         (TestHttpServer.test_win32_start_and_stop):
204
205 2013-01-15  Levi Weintraub  <leviw@chromium.org>
206
207         Unreviewed, rolling out r139792.
208         http://trac.webkit.org/changeset/139792
209         https://bugs.webkit.org/show_bug.cgi?id=106970
210
211         Broke the windows build.
212
213         * DumpRenderTree/chromium/DRTTestRunner.cpp:
214         (DRTTestRunner::DRTTestRunner):
215         (DRTTestRunner::notifyDone):
216         (DRTTestRunner::reset):
217         (DRTTestRunner::setAlwaysAcceptCookies):
218         (DRTTestRunner::setWindowIsKey):
219         (DRTTestRunner::pathToLocalResource):
220         (DRTTestRunner::setPOSIXLocale):
221         (InvokeCallbackTask):
222         (InvokeCallbackTask::InvokeCallbackTask):
223         (InvokeCallbackTask::runIfValid):
224         (DRTTestRunner::setBackingScaleFactor):
225         * DumpRenderTree/chromium/DRTTestRunner.h:
226         (DRTTestRunner):
227         (DRTTestRunner::taskList):
228         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
229         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
230         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
231         (WebTestRunner::TestRunner::TestRunner):
232         (WebTestRunner::TestRunner::reset):
233         (WebTestRunner::TestRunner::setDatabaseQuota):
234         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
235         (TestRunner):
236         * DumpRenderTree/chromium/WebViewHost.cpp:
237         (WebViewHost::setPendingExtraData):
238         (WebViewHost::setDeviceScaleFactor):
239         * DumpRenderTree/chromium/WebViewHost.h:
240         (WebViewHost):
241
242 2013-01-15  Ryosuke Niwa  <rniwa@webkit.org>
243
244         Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
245
246         * Scripts/webkitpy/common/config/ports.py:
247         (MacWK2Port):
248
249 2013-01-15  Alan Cutter  <alancutter@chromium.org>
250
251         Extend sheriffbot's "help" command to be able to get help on individual commands
252         https://bugs.webkit.org/show_bug.cgi?id=106629
253
254         Reviewed by Eric Seidel.
255
256         Added a help command to sheriffbot.
257         Fixed some style issues and ordered the commands alphabetically.
258
259         * Scripts/webkitpy/tool/bot/irc_command.py:
260         (IRCCommand):
261         (IRCCommand.execute):
262         (IRCCommand.usage):
263         (IRCCommand.help):
264         (CreateBug):
265         (CreateBug.execute):
266         (Help):
267         (Help.execute):
268         (Help._post_command_help):
269         (Hi):
270         (Hi.execute):
271         (Restart):
272         (RollChromiumDEPS):
273         (RollChromiumDEPS._parse_args):
274         (RollChromiumDEPS._expand_irc_nickname):
275         (RollChromiumDEPS.execute):
276         (Rollout):
277         (Rollout._extract_revisions):
278         (Rollout.execute):
279         (Sheriffs):
280         (Sheriffs.execute):
281         (Whois):
282         (Whois.execute):
283         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
284         (IRCBotTest.test_help):
285
286 2013-01-15  Enrica Casucci  <enrica@apple.com>
287
288         Add a new set of WebKit2 APIs for text search and
289         search results management.
290         https://bugs.webkit.org/show_bug.cgi?id=106834.
291         <rdar://problem/12597159>
292
293         Added new test for the new WebKit2 API for
294         text search.
295         
296         Reviewed by Simon Fraser.
297
298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
299         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm: Added.
300
301 2013-01-15  Levi Weintraub  <leviw@chromium.org>
302
303         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
304         https://bugs.webkit.org/show_bug.cgi?id=106904
305
306         Reverting 139794. It broke the build. It appears that a header file,
307         WebTextDirection.h, was left out.
308
309         * DumpRenderTree/chromium/DRTTestRunner.cpp:
310         (DRTTestRunner::DRTTestRunner):
311         (DRTTestRunner::reset):
312         * DumpRenderTree/chromium/DRTTestRunner.h:
313         (DRTTestRunner::setTitleTextDirection):
314         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
315         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
316         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
317         (WebTestRunner::TestRunner::TestRunner):
318         (WebTestRunner::TestRunner::reset):
319         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
320         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
321         (TestRunner):
322         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
323         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
324         * DumpRenderTree/chromium/WebViewHost.cpp:
325         (WebViewHost::didReceiveTitle):
326
327 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
328
329         [chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
330         https://bugs.webkit.org/show_bug.cgi?id=106904
331
332         Reviewed by Adam Barth.
333
334         * DumpRenderTree/chromium/DRTTestRunner.cpp:
335         (DRTTestRunner::DRTTestRunner):
336         (DRTTestRunner::notifyDone):
337         (DRTTestRunner::reset):
338         * DumpRenderTree/chromium/DRTTestRunner.h:
339         (DRTTestRunner):
340         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
341         (WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
342         (WebTestRunner::WebTestDelegate::setFocus):
343         (WebTestRunner::WebTestDelegate::setAcceptAllCookies):
344         (WebTestRunner::WebTestDelegate::pathToLocalResource):
345         (WebTestRunner::WebTestDelegate::setLocale):
346         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
347         (WebTestRunner::TestRunner::TestRunner):
348         (WebTestRunner::TestRunner::reset):
349         (WebTestRunner::TestRunner::setAlwaysAcceptCookies):
350         (WebTestRunner):
351         (WebTestRunner::TestRunner::setWindowIsKey):
352         (WebTestRunner::TestRunner::pathToLocalResource):
353         (WebTestRunner::TestRunner::setBackingScaleFactor):
354         (WebTestRunner::TestRunner::setPOSIXLocale):
355         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
356         (WebTestRunner::TestRunner::taskList):
357         (TestRunner):
358         * DumpRenderTree/chromium/WebViewHost.cpp:
359         (WebViewHost::setDeviceScaleFactor):
360         (WebViewHost::setFocus):
361         (WebViewHost::setAcceptAllCookies):
362         (WebViewHost::pathToLocalResource):
363         (WebViewHost::setLocale):
364         * DumpRenderTree/chromium/WebViewHost.h:
365         (WebViewHost):
366
367 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
368
369         Tests with WontFix expectation are (indirectly) skipped
370         https://bugs.webkit.org/show_bug.cgi?id=105860
371
372         Reviewed by Dirk Pranke.
373
374         Only skip the WontFix expectation if there are no other layout test
375         expectations (like Failure, ImageOnlyFailure) listed for the test.
376         This makes it possible to run an expected failure for which there
377         is no reason or interest to fix. There are some ports that would like
378         to exercise this behavior as well as specific test cases that should use
379         such expectations.
380
381         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
382         (TestExpectationParser._tokenize_line): Only add the SKIP modifier for a
383         WONTFIX test if there are no expectations listed. The warning is adjusted
384         to reflect the new behavior.
385         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Add
386         and adjust test cases for these changes.
387         (ExpectationSyntaxTests.test_wontfix):
388         (SemanticTests.test_skip_and_wontfix):
389
390 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
391
392         [chromium] add title text direction attribute to TestRunner
393         https://bugs.webkit.org/show_bug.cgi?id=106907
394
395         Reviewed by Adam Barth.
396
397         * DumpRenderTree/chromium/DRTTestRunner.cpp:
398         (DRTTestRunner::DRTTestRunner):
399         (DRTTestRunner::reset):
400         * DumpRenderTree/chromium/DRTTestRunner.h:
401         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
402         (WebTestRunner::WebTestRunner::setTitleTextDirection):
403         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
404         (WebTestRunner::TestRunner::TestRunner):
405         (WebTestRunner::TestRunner::reset):
406         (WebTestRunner::TestRunner::setTitleTextDirection):
407         (WebTestRunner):
408         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
409         (TestRunner):
410         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
411         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
412         * DumpRenderTree/chromium/WebViewHost.cpp:
413         (WebViewHost::didReceiveTitle):
414
415 2013-01-15  Dirk Pranke  <dpranke@chromium.org>
416
417         nrwt: change the default # of locked shards on chromium_win to 1
418         https://bugs.webkit.org/show_bug.cgi?id=106938
419
420         Reviewed by Eric Seidel.
421
422         It looks like LigHTTPd might be buggy or unstable if we are
423         running multiple http tests in parallel; see
424         http://code.google.com/p/chromium/issues/detail?id=169530 for more
425         context as well. This change will stop running http tests in parallel
426         and we can see if this fixes things.
427
428         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
429         (ChromiumWinPort.default_max_locked_shards):
430         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
431         (ChromiumWinTest.test_path_to_image_diff):
432         (ChromiumWinTest):
433         (ChromiumWinTest.test_default_max_locked_shards):
434
435 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
436
437         [chromium] move WebDatabase related methods to TestRunner library
438         https://bugs.webkit.org/show_bug.cgi?id=106905
439
440         Reviewed by Adam Barth.
441
442         * DumpRenderTree/chromium/DRTTestRunner.cpp:
443         (DRTTestRunner::DRTTestRunner):
444         (DRTTestRunner::reset):
445         * DumpRenderTree/chromium/DRTTestRunner.h:
446         (DRTTestRunner):
447         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
448         (WebTestRunner::WebTestDelegate::clearAllDatabases):
449         (WebTestRunner::WebTestDelegate::setDatabaseQuota):
450         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
451         (WebTestRunner::TestRunner::TestRunner):
452         (WebTestRunner::TestRunner::reset):
453         (WebTestRunner::TestRunner::clearAllDatabases):
454         (WebTestRunner):
455         (WebTestRunner::TestRunner::setDatabaseQuota):
456         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
457         (TestRunner):
458         * DumpRenderTree/chromium/WebViewHost.cpp:
459         (WebViewHost::clearAllDatabases):
460         (WebViewHost::setDatabaseQuota):
461         * DumpRenderTree/chromium/WebViewHost.h:
462         (WebViewHost):
463
464 2013-01-15  Tim 'mithro' Ansell  <mithro@mithis.com>
465
466         Renaming CleanWorkingDirectory step to DiscardLocalChanges to make
467         functionality match the name.
468         https://bugs.webkit.org/show_bug.cgi?id=106870
469
470         Reviewed by Adam Barth.
471
472         * Scripts/webkitpy/tool/commands/download.py:
473         (Clean):
474         (Update):
475         (Build):
476         (BuildAndTest):
477         (CheckStyle):
478         (BuildAttachment):
479         (BuildAndTestAttachment):
480         (AbstractPatchApplyingCommand):
481         (ApplyWatchList):
482         (AbstractPatchLandingCommand):
483         (CreateRollout):
484         * Scripts/webkitpy/tool/steps/__init__.py:
485         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
486         (CleanWorkingDirectory.options):
487         (CleanWorkingDirectory.run):
488         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
489         * Scripts/webkitpy/tool/steps/discardlocalchanges.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
490         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py.
491
492 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
493
494         [Autotools] Add support for WebKit2-only builds
495         https://bugs.webkit.org/show_bug.cgi?id=106889
496
497         Reviewed by Gustavo Noronha Silva.
498
499         * GNUmakefile.am: Only build the GtkLauncher and DumpRenderTree if building WebKit1.
500         * Scripts/build-webkit: Pass along the information on whether to build WebKit1 when
501         building the GTK port through build-webkit.
502         * Scripts/webkitdirs.pm:
503         (buildAutotoolsProject): Add the --disable-webkit1 configuration flag to the build
504         arguments when not building WebKit1.
505         (buildGtkProject): Pass along the information on whether to build WebKit1 when building
506         through the Autotools build system.
507
508 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
509
510         [GTK] Enable Performance Timeline, Resource Timing, Navigation Timing features
511         https://bugs.webkit.org/show_bug.cgi?id=106197
512
513         Reviewed by Martin Robinson.
514
515         * Scripts/webkitperl/FeatureList.pm: Add the configuration options for all three
516         features. Enable them on GTK, meaning they will be enabled in development builds
517         (i.e. when building with build-webkit).
518
519 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
520
521         [GTK] Enable CSS Image Resolution feature
522         https://bugs.webkit.org/show_bug.cgi?id=99038
523
524         Reviewed by Gustavo Noronha Silva.
525
526         Enable the CSS Image Resolution feature for the development
527         builds of the GTK port.
528
529         * Scripts/webkitperl/FeatureList.pm:
530
531 2013-01-15  Zan Dobersek  <zandobersek@gmail.com>
532
533         [GTK] Stop passing the unstable features flag to configure script when using build-webkit
534         https://bugs.webkit.org/show_bug.cgi?id=106579
535
536         Reviewed by Gustavo Noronha Silva.
537
538         The --enable-unstable-features flag is not required to be passed anymore
539         to the configure script as it was removed in r138252.
540
541         * Scripts/webkitdirs.pm:
542         (buildAutotoolsProject):
543
544 2013-01-15  Tony Chang  <tony@chromium.org>
545
546         [chromium] Unreviewed, fix a bug where we don't properly shutdown lighttpd.
547
548         * Scripts/webkitpy/layout_tests/servers/http_server.py:
549         (Lighttpd._check_and_kill): Pass /pid so taskkill.exe doesn't error out on us.
550         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
551         (TestHttpServer.test_win32_start_and_stop):
552
553 2013-01-15  Joshua Bell  <jsbell@chromium.org>
554
555         Unreviewed. Adding Michael Pruett as contributor.
556
557         * Scripts/webkitpy/common/config/committers.py:
558
559 2013-01-15  Victor Carbune  <victor@rosedu.org>
560
561         Unreviewed. Update my email addresses.
562
563         * Scripts/webkitpy/common/config/committers.py:
564
565 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
566
567         [GTK] Waiting on the gdb process will lead to deadlock
568         https://bugs.webkit.org/show_bug.cgi?id=106906
569
570         Reviewed by Philippe Normand.
571
572         Use communicate() rather than wait() on the Popen object that's running the gdb
573         command. This avoids the deadlock that occurs on the GTK builders.
574
575         * Scripts/webkitpy/layout_tests/port/gtk.py:
576         (GtkPort._get_gdb_output):
577
578 2013-01-15  Zan Dobersek  <zdobersek@igalia.com>
579
580         [GTK] Limit the number of frames printed out when backtracing with gdb
581         https://bugs.webkit.org/show_bug.cgi?id=106901
582
583         Reviewed by Philippe Normand.
584
585         Printing an unlimited number of frames when dumping the gdb backtracing
586         output can cause timeouts in the builders. This patch limits the number
587         of frames that are printed out to 1024.
588
589         * Scripts/webkitpy/layout_tests/port/gtk.py:
590         (GtkPort._get_gdb_output):
591
592 2013-01-15  Andras Becsi  <andras.becsi@digia.com>
593
594         [Qt] Fix ImageDiff's image format conversion
595         https://bugs.webkit.org/show_bug.cgi?id=106880
596
597         Reviewed by Csaba Osztrogonác.
598
599         Besides actually doing the conversion this also silences the suspicious warning:
600         "ignoring return value of function declared with warn_unused_result attribute".
601
602         * ImageDiff/qt/ImageDiff.cpp:
603         (main): QImage::convertToFormat, contrary to the assumed behaviour, returns a
604         copy of the image in the given format and does not alter the image itself.
605
606 2013-01-15  Jochen Eisinger  <jochen@chromium.org>
607
608         [chromium] move remaining methods that just set a boolean flag to TestRunner library
609         https://bugs.webkit.org/show_bug.cgi?id=106823
610
611         Reviewed by Darin Fisher.
612
613         * DumpRenderTree/chromium/DRTTestRunner.cpp:
614         (DRTTestRunner::DRTTestRunner):
615         (DRTTestRunner::reset):
616         * DumpRenderTree/chromium/DRTTestRunner.h:
617         (DRTTestRunner):
618         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
619         (WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
620         (WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
621         (WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
622         (WebTestRunner::WebTestRunner::testRepaint):
623         (WebTestRunner::WebTestRunner::sweepHorizontally):
624         (WebTestRunner::WebTestRunner::isPrinting):
625         (WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
626         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
627         (WebTestRunner::TestRunner::TestRunner):
628         (WebTestRunner::TestRunner::reset):
629         (WebTestRunner::TestRunner::shouldDumpBackForwardList):
630         (WebTestRunner):
631         (WebTestRunner::TestRunner::deferMainResourceDataLoad):
632         (WebTestRunner::TestRunner::shouldDumpSelectionRect):
633         (WebTestRunner::TestRunner::testRepaint):
634         (WebTestRunner::TestRunner::sweepHorizontally):
635         (WebTestRunner::TestRunner::isPrinting):
636         (WebTestRunner::TestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
637         (WebTestRunner::TestRunner::dumpBackForwardList):
638         (WebTestRunner::TestRunner::setDeferMainResourceDataLoad):
639         (WebTestRunner::TestRunner::dumpSelectionRect):
640         (WebTestRunner::TestRunner::repaintSweepHorizontally):
641         (WebTestRunner::TestRunner::setPrinting):
642         (WebTestRunner::TestRunner::setShouldStayOnPageAfterHandlingBeforeUnload):
643         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
644         (TestRunner):
645
646 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
647
648         nrwt: stub out show_results_html for mock ports
649         https://bugs.webkit.org/show_bug.cgi?id=106848
650
651         Reviewed by Ojan Vafai.
652
653         We were accidentally using the underlying ports'
654         show_results_html_file() implementation, which would, unsurprisingly,
655         fail in many cases (e.g., running mock-efl on the mac).
656
657         No test added since we don't generally add tests for the mock
658         implementation.
659
660         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
661         (MockDRTPort.show_results_html_file):
662
663 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
664
665         Changing clean_working_directory/clean_local_commits and related
666         functions to have consistent naming.
667
668         https://bugs.webkit.org/show_bug.cgi?id=104198
669
670         Reviewed by Adam Barth.
671
672         * Scripts/webkitpy/common/checkout/scm/git.py:
673         * Scripts/webkitpy/common/checkout/scm/scm.py:
674         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
675         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
676         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
677         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
678
679 2013-01-14  Alan Cutter  <alancutter@chromium.org>
680
681         Fix EWS GCE build scripts to detect which zone is available
682         https://bugs.webkit.org/show_bug.cgi?id=106524
683
684         Reviewed by Adam Barth.
685
686         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
687         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
688         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
689         * EWSTools/GoogleComputeEngine/findzone.sh: Added.
690
691 2013-01-14  Tim 'mithro' Ansell  <mithro@mithis.com>
692
693         Adding an error string to AmbiguousCommitError.
694         https://bugs.webkit.org/show_bug.cgi?id=106846
695
696         Reviewed by Adam Barth.
697
698         * Scripts/webkitpy/common/checkout/scm/git.py:
699         (AmbiguousCommitError.__init__):
700
701 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
702
703         kill whole lighttpd process tree for chromium win
704         https://bugs.webkit.org/show_bug.cgi?id=106838
705
706         Reviewed by Tony Chang.
707
708         Land a speculative fix for lighttpd.exe hanging on some chromium bots;
709         I think a test is causing a httpd server child process to wedge and
710         killing the parent httpd server process isn't sufficient to ensure
711         that the children are also killed.
712
713         * Scripts/webkitpy/layout_tests/servers/http_server.py:
714         (Lighttpd._check_and_kill):
715         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
716         (TestHttpServer.test_start_cmd):
717         (TestHttpServer):
718         (TestHttpServer.test_win32_start_and_stop):
719         (TestHttpServer.test_win32_start_and_stop.wait_for_action):
720         (TestHttpServer.test_win32_start_and_stop.mock_returns):
721         (TestHttpServer.test_win32_start_and_stop.mock_returns.return_value_thunk):
722
723 2013-01-14  Nico Weber  <thakis@chromium.org>
724
725         [chromium] Enable `update-webkit --chromium --ninja` on windows
726         https://bugs.webkit.org/show_bug.cgi?id=106836
727
728         Reviewed by Eric Seidel.
729
730         After running this, build-webkit --chromium will use ninja to build.
731         Apparently there are some minor issues with that still, so it's
732         not quite ready for use yet.
733
734         * Scripts/webkitdirs.pm:
735         (determineIsChromiumNinja):
736         (buildChromium):
737
738 2013-01-14  Dirk Pranke  <dpranke@chromium.org>
739
740         nrwt: use the same search path for baselines and TestExpectations on apple mac
741         https://bugs.webkit.org/show_bug.cgi?id=105599
742
743         Reviewed by Ryosuke Niwa.
744
745         Bug 105583 revealed some confusion due to the fact that the Apple
746         Mac port used a different list of directories to search for baselines
747         and TestExpectations files (actually, pretty much every port does).
748
749         It seems like a good idea to use the same list for both by default, but
750         making this happen will affect every port in slightly different ways, so
751         we'll try this on the Apple Mac port first.
752
753         Note that the effective changes for this are that:
754         1) The apple mac port will look in platform/wk2 for baselines where
755         it didn't before (it will look after looking in mac-wk2 but before
756         the non-wk2 dirs)
757         2) The apple mac-snowleopard port will use the expectations in
758         mac-lion as well as the expectations in mac-snowleopard, although
759         I'm not even sure if mac-snowleopard is still supported ...
760
761         * Scripts/webkitpy/layout_tests/port/mac.py:
762         (MacPort.default_baseline_search_path):
763         (MacPort.expectations_files):
764         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
765         (test_baseline_search_path):
766
767 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
768
769         AX: Need to implement ColorWellRole
770         https://bugs.webkit.org/show_bug.cgi?id=106756
771
772         Reviewed by Chris Fleizach.
773
774         Returns a string representation of the value of a color
775         when the role is Color Well, to make it easy to write layout
776         tests for color controls.
777
778         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
779
780 2013-01-14  Dominic Mazzoni  <dmazzoni@google.com>
781
782         Chromium: Error in AccessibilityUIElement::intValueGetterCallback
783         https://bugs.webkit.org/show_bug.cgi?id=106682
784
785         Reviewed by Chris Fleizach.
786
787         Modify Chromium's DRT implementation of intValue to return a
788         different value depending on the role.
789
790         There are actually platform-specific differences in what should
791         be returned in the "value" of an object, so Chromium normally keeps
792         these separate (i.e. valueForRange, headingLevel, hierarchicalLevel, etc.)
793         but this is a fine simplification to make cross-platform tests easier.
794
795         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
796         (WebTestRunner::AccessibilityUIElement::intValueGetterCallback):
797
798 2013-01-14  Jochen Eisinger  <jochen@chromium.org>
799
800         [chromium] move remaining methods to dump WebViewClient callbacks to TestRunner library
801         https://bugs.webkit.org/show_bug.cgi?id=106785
802
803         Reviewed by Adam Barth.
804
805         * DumpRenderTree/chromium/DRTTestRunner.cpp:
806         (DRTTestRunner::DRTTestRunner):
807         (DRTTestRunner::reset):
808         * DumpRenderTree/chromium/DRTTestRunner.h:
809         (DRTTestRunner):
810         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
811         (WebTestProxyBase):
812         (WebTestRunner::WebTestProxy::setStatusText):
813         (WebTestRunner::WebTestProxy::didStopLoading):
814         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
815         (WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
816         (WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
817         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
818         (WebTestRunner::TestRunner::TestRunner):
819         (WebTestRunner::TestRunner::reset):
820         (WebTestRunner::TestRunner::shouldDumpStatusCallbacks):
821         (WebTestRunner):
822         (WebTestRunner::TestRunner::shouldDumpProgressFinishedCallback):
823         (WebTestRunner::TestRunner::dumpWindowStatusChanges):
824         (WebTestRunner::TestRunner::dumpProgressFinishedCallback):
825         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
826         (TestRunner):
827         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
828         (WebTestRunner::WebTestProxyBase::setStatusText):
829         (WebTestRunner):
830         (WebTestRunner::WebTestProxyBase::didStopLoading):
831         * DumpRenderTree/chromium/WebViewHost.cpp:
832         (WebViewHost::didStopLoading):
833         * DumpRenderTree/chromium/WebViewHost.h:
834         (WebViewHost):
835
836 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
837
838         Web Inspector: devtools front-end doesn't have focus in TestShell
839         https://bugs.webkit.org/show_bug.cgi?id=106778
840
841         Reviewed by Pavel Feldman.
842
843         Focus devTools window after loadURL method.
844
845         * DumpRenderTree/chromium/TestShell.cpp:
846         (TestShell::runFileTest):
847
848 2013-01-14  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
849
850         [EFL][jhbuild] Build the GStreamer-related dependencies with the "configure" script
851         https://bugs.webkit.org/show_bug.cgi?id=106573
852
853         Reviewed by Philippe Normand.
854
855         Similarly to what's been described in bug 106569, we're building
856         from release tarballs, so there's no reason to regenerate the
857         autoconf-related stuff with autogen.sh, especially since we might
858         run into trouble with automake 1.13 and deprecated macros.
859
860         * efl/jhbuild.modules:
861
862 2013-01-14  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
863
864         [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg
865         https://bugs.webkit.org/show_bug.cgi?id=104909
866
867         Reviewed by Simon Hausmann.
868
869         To be able to build redistribuable binary packages, Qt's configure switches
870         -qt-libpng and -qt-libjpeg are used to avoid having the binaries trying to
871         dynamically link to optional system libraries.
872         QtWebKit is doing its own configure checks for those libraries, thus adding a
873         runtime dependency that might not be fulfilled if the packager's machine had
874         those libraries while the user's machine won't.
875
876         Since in most cases where WebKit will want to use those system libraries, Qt will
877         also be using them, remove these configure tests from WebKit.
878
879         * qmake/config.tests/libjpeg/libjpeg.cpp: Removed.
880         * qmake/config.tests/libjpeg/libjpeg.pro: Removed.
881         * qmake/config.tests/libpng/libpng.cpp: Removed.
882         * qmake/config.tests/libpng/libpng.pro: Removed.
883         * qmake/mkspecs/features/features.prf:
884
885 2013-01-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
886
887         [EFL][jhbuild] Bump the EFL dependencies in jhbuild to 1.7.5.
888         https://bugs.webkit.org/show_bug.cgi?id=106574
889
890         Reviewed by Laszlo Gombos.
891
892         Rely on a more recent stable release, which includes support for
893         Lua 5.2 in Edje and other assorted minor fixes.
894
895         While here, also use the "configure" script to build the libraries
896         instead of relying on autogen.sh, which is not really needed with
897         a release tarball and may have problems with automake 1.13.
898
899         * efl/jhbuild.modules:
900
901 2013-01-14  Andrey Lushnikov  <lushnikov@chromium.org>
902
903         Web Inspector: fix DRT to deliver simulated events to devtools front-end
904         https://bugs.webkit.org/show_bug.cgi?id=106650
905
906         Reviewed by Pavel Feldman.
907
908         Add separated m_devToolsTestInterfaces object to testShell which is
909         bind to devTools webview.
910
911         * DumpRenderTree/chromium/TestShell.cpp:
912         (TestShell::initialize):
913         (TestShell::createMainWindow):
914         (TestShell::~TestShell):
915         (TestShell::showDevTools):
916         (TestShell::resetTestController):
917         (TestShell::bindJSObjectsToWindow):
918         (TestShell::createNewWindow):
919         * DumpRenderTree/chromium/TestShell.h:
920         (TestShell):
921
922 2013-01-14  Alan Cutter  <alancutter@chromium.org>
923
924         Sheriffbot command aliases need test cases
925         https://bugs.webkit.org/show_bug.cgi?id=106754
926
927         Reviewed by Eric Seidel.
928
929         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
930         (SheriffBotTest.test_command_aliases):
931
932 2013-01-13  Alan Cutter  <alancutter@chromium.org>
933
934         Allow users to misspell the "sheriffs" command in sheriffbot
935         https://bugs.webkit.org/show_bug.cgi?id=106628
936
937         Reviewed by Steve Block.
938
939         * Scripts/webkitpy/tool/bot/irc_command.py:
940
941 2013-01-13  Alan Cutter  <alancutter@chromium.org>
942
943         Make "gardeners" an alias for "sheriffs" in sherrifbot
944         https://bugs.webkit.org/show_bug.cgi?id=106627
945
946         Reviewed by Eric Seidel.
947
948         * Scripts/webkitpy/tool/bot/irc_command.py:
949
950 2013-01-13  Dirk Pranke  <dpranke@chromium.org>
951
952         [chromium] webkitpy-test: executive.py stringify_args error on the release test bot
953         https://bugs.webkit.org/show_bug.cgi?id=105380
954
955         Reviewed by Eric Seidel.
956
957         Fix a regression introduced in r137692 where we were double-encoding
958         the arguments to popen(); this was only an issue on windows, where
959         we would try to encode something to mbcs, then try to encode it
960         to unicode as if the input as ascii.
961
962         * Scripts/webkitpy/common/system/executive.py:
963         (Executive.run_command):
964
965 2013-01-13  Alan Cutter  <alancutter@chromium.org>
966
967         State who told sheriffbot to roll the Chromium deps and to what revision
968         https://bugs.webkit.org/show_bug.cgi?id=106626
969
970         Reviewed by Eric Seidel.
971
972         Added optional argument to post-chromium-deps-roll so Sheriffbot can specify ChangeLog message.
973
974         * Scripts/webkitpy/tool/bot/irc_command.py:
975         (RollChromiumDEPS._expand_irc_nickname):
976         (RollChromiumDEPS.execute):
977         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
978         (IRCCommandTest.test_roll_chromium_deps):
979         * Scripts/webkitpy/tool/bot/sheriff.py:
980         (Sheriff.post_chromium_deps_roll):
981         * Scripts/webkitpy/tool/commands/roll.py:
982         (RollChromiumDEPS._prepare_state):
983         (PostChromiumDEPSRoll):
984         (PostChromiumDEPSRoll._prepare_state):
985         * Scripts/webkitpy/tool/commands/roll_unittest.py:
986         (PostRollCommandsTest.test_prepare_state):
987         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
988         (PrepareChangeLogForDEPSRoll.run):
989
990 2013-01-13  Alan Cutter  <alancutter@chromium.org>
991
992         Add Alan Cutter as contributor
993         https://bugs.webkit.org/show_bug.cgi?id=106747
994
995         Reviewed by Eric Seidel.
996
997         * Scripts/webkitpy/common/config/committers.py:
998
999 2013-01-13  Jonathan Liu  <net147@gmail.com>
1000
1001         Fix CONFIG missing link_pkgconfig on Windows
1002         https://bugs.webkit.org/show_bug.cgi?id=106647
1003
1004         Some libraries (e.g. libxslt, libxml2 and sqlite3) fail to link
1005         properly on Windows because they are added to PKGCONFIG but
1006         CONFIG does not contain link_pkgconfig.
1007
1008         This is because link_pkgconfig is added in unix/default_pre.prf
1009         which is only used for UNIX platforms. To fix this, move it to
1010         the general default_pre.prf.
1011
1012         Reviewed by Simon Hausmann.
1013
1014         * qmake/mkspecs/features/default_pre.prf:
1015         * qmake/mkspecs/features/unix/default_pre.prf:
1016
1017 2013-01-12  Nico Weber  <thakis@chromium.org>
1018
1019         nrwt/chromium: Don't prefer chromium over webkit build directories
1020         https://bugs.webkit.org/show_bug.cgi?id=105597
1021
1022         Reviewed by Dirk Pranke.
1023
1024         Rely on the new timestamp logic instead. Requested by dpranke in
1025         https://bugs.webkit.org/show_bug.cgi?id=105498
1026
1027         * Scripts/webkitpy/layout_tests/port/chromium.py:
1028         (ChromiumPort._static_build_path):
1029         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1030         (ChromiumLinuxPortTest.test_build_path):
1031         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1032         (ChromiumMacPortTest.test_build_path):
1033         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1034         (ChromiumWinTest.test_build_path):
1035
1036 2013-01-12  Nico Weber  <thakis@chromium.org>
1037
1038         Use ninja by default on Linux for build-webkit --chromium, bot edition
1039         https://bugs.webkit.org/show_bug.cgi?id=104434
1040
1041         Reviewed by Eric Seidel.
1042
1043         r139557 changed update-webkit to pick ninja by default on linux, but
1044         the bots run update-webkit-chromium directly so they didn't see this.
1045         Move the default for ninja into update-webkit-chromium so that it's
1046         picked up by the bots, and let update-webkit forward non-default
1047         options to there.
1048
1049         This way, the default is in one place only and both developers (who
1050         usually use update-webkit which then shells out to
1051         updat-webkit-chromium) and bots (which use update-webkit-chromium
1052         directly) see the same behavior.
1053
1054         * Scripts/update-webkit:
1055         * Scripts/update-webkit-chromium:
1056
1057 2013-01-12  Nico Weber  <thakis@chromium.org>
1058
1059         Make ninja the default build system on Linux for build-webkit --chromium
1060         https://bugs.webkit.org/show_bug.cgi?id=104434
1061
1062         Reviewed by Eric Seidel.
1063
1064         * Scripts/update-webkit:
1065
1066 2013-01-12  Alan Cutter  <alancutter@chromium.org>
1067
1068         Migrate the remaining bots in EC2 to Google Compute Engine
1069         https://bugs.webkit.org/show_bug.cgi?id=106005
1070
1071         Reviewed by Eric Seidel.
1072
1073         Updated bot scripts for launching feeder-queue, style-queue and sheriffbot on GCE.
1074
1075         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Copied from Tools/EWSTools/build-repo.sh.
1076         * EWSTools/boot.sh:
1077         * EWSTools/build-repo.sh:
1078         * EWSTools/start-queue.sh:
1079
1080 2013-01-12  Jochen Eisinger  <jochen@chromium.org>
1081
1082         [chromium] move inspector related methods to TestRunner library
1083         https://bugs.webkit.org/show_bug.cgi?id=106654
1084
1085         Reviewed by Adam Barth.
1086
1087         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1088         (DRTTestRunner::DRTTestRunner):
1089         * DumpRenderTree/chromium/DRTTestRunner.h:
1090         (DRTTestRunner):
1091         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1092         (WebTestRunner::WebTestDelegate::showDevTools):
1093         (WebTestRunner::WebTestDelegate::closeDevTools):
1094         (WebTestRunner::WebTestDelegate::evaluateInWebInspector):
1095         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1096         (WebTestRunner::TestRunner::TestRunner):
1097         (WebTestRunner::TestRunner::showWebInspector):
1098         (WebTestRunner):
1099         (WebTestRunner::TestRunner::closeWebInspector):
1100         (WebTestRunner::TestRunner::evaluateInWebInspector):
1101         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1102         (TestRunner):
1103         * DumpRenderTree/chromium/WebViewHost.cpp:
1104         (WebViewHost::showDevTools):
1105         (WebViewHost::closeDevTools):
1106         (WebViewHost::evaluateInWebInspector):
1107         * DumpRenderTree/chromium/WebViewHost.h:
1108         (WebViewHost):
1109
1110 2013-01-11  Julie Parent  <jparent@chromium.org>
1111
1112         Builder should not be a valid parameter for stats dashboard
1113         https://bugs.webkit.org/show_bug.cgi?id=106698
1114
1115         Reviewed by Dirk Pranke.
1116         
1117         Since builder is a dashboard specific parameter, dashboard_base
1118         should not be handling it in handleValidHashParameterWrapper, rather,
1119         each specific dashboard should in its handleValidHashParameter function.
1120     
1121         Note that the FIXME in dashboard_base about this was actually wrong -
1122         we don't want to move it to g_crossDashboardState, because it isn't
1123         actually cross dashboard state.
1124         
1125         In fact, flakiness and treemap have the code in 
1126         handleValidHashParameter, but it is currently dead code because 
1127         dashboard_base gets to it first.
1128         
1129         Added the proper handling to timeline_explorer, since builder is
1130         valid there.
1131
1132         * TestResultServer/static-dashboards/dashboard_base.js:
1133         * TestResultServer/static-dashboards/timeline_explorer.html:
1134
1135 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1136
1137         REGRESSION: buildbot mangles error messages with timestamps run-webkit-tests outputs
1138         https://bugs.webkit.org/show_bug.cgi?id=106688
1139
1140         Reviewed by Eric Seidel.
1141
1142         Update the regular expression used to strip the garbage at the beginning.
1143
1144         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1145         (RunWebKitTests.nrwt_log_message_regexp):
1146
1147 2013-01-11  Pratik Solanki  <psolanki@apple.com>
1148
1149         TestRunner leaks when running tests
1150         https://bugs.webkit.org/show_bug.cgi?id=106683
1151
1152         Reviewed by Simon Fraser.
1153
1154         Remove extra ref() that we missed out on deleting when refactoring window.layoutTestController
1155         to window.testRunner in r124705. This caused the TestRunner object to be leaked when running
1156         tests.
1157
1158         * DumpRenderTree/TestRunner.cpp:
1159         (TestRunner::makeWindowObject):
1160
1161 2013-01-11  Julie Parent  <jparent@chromium.org>
1162
1163         Dashboard Cleanup: Add isLoadingComplete to the loader.Loader object.
1164         https://bugs.webkit.org/show_bug.cgi?id=106247
1165
1166         Old code nulled out the loader instance when it completed loading and
1167         then later used the fact that it was null to determine if it had loaded
1168         or not.  This is not only unintuitive, but it also prevents using the
1169         loader object later on.
1170         
1171         Added new method, used it, added unit test for it.
1172         
1173         Reviewed by Dirk Pranke.
1174
1175         * TestResultServer/static-dashboards/dashboard_base.js:
1176         (resourceLoadingComplete):
1177         (handleLocationChange):
1178         * TestResultServer/static-dashboards/loader.js:
1179         (.):
1180         * TestResultServer/static-dashboards/loader_unittests.js:
1181
1182 2013-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1183
1184         Try CRLF to LF change in r139407 again.
1185
1186         * BuildSlaveSupport/delete-stale-build-files:
1187         (main):
1188         (webkitBuildDirectory):
1189         * BuildSlaveSupport/kill-old-processes:
1190         (main):
1191
1192 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1193
1194         [GTK] Disable the unit tests timeout when running from make check
1195         https://bugs.webkit.org/show_bug.cgi?id=106670
1196
1197         Reviewed by Philippe Normand.
1198
1199         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
1200
1201 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1202
1203         Yet another unreviewed fix after r139431.
1204
1205         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
1206         the correct order.
1207
1208 2013-01-11  Dan Carney  <dcarney@google.com>
1209
1210         [chromium] move some whitespace and resize related methods to TestRunner library
1211         https://bugs.webkit.org/show_bug.cgi?id=106655
1212
1213         Reviewed by Jochen Eisinger.
1214
1215         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1216         (DRTTestRunner::DRTTestRunner):
1217         * DumpRenderTree/chromium/DRTTestRunner.h:
1218         (DRTTestRunner):
1219         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1220         (WebKit):
1221         (WebTestRunner::WebTestDelegate::setClientWindowRect):
1222         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
1223         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
1224         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1225         (WebTestRunner::TestRunner::TestRunner):
1226         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
1227         (WebTestRunner):
1228         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
1229         (WebTestRunner::TestRunner::enableAutoResizeMode):
1230         (WebTestRunner::TestRunner::disableAutoResizeMode):
1231         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1232         (TestRunner):
1233         * DumpRenderTree/chromium/WebViewHost.cpp:
1234         (WebViewHost::setClientWindowRect):
1235         * DumpRenderTree/chromium/WebViewHost.h:
1236         (WebViewHost):
1237
1238 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1239
1240         Unreviewed. Update my e-mail addresses.
1241
1242         * Scripts/webkitpy/common/config/committers.py:
1243
1244 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1245
1246         Another unreviewed fix after r139431.
1247
1248         In a way, this is also a generic bug fix, since previously isEfl()
1249         would fail when called from run-efl-tests and we thus did not use
1250         jhbuild to run our tests. This now resulted in us calling
1251         "jhbuild-wrapper run" without specifying a platform.
1252
1253         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
1254         to work.
1255
1256 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1257
1258         [Qt][WK1] Web Audio support
1259         https://bugs.webkit.org/show_bug.cgi?id=106651
1260
1261         Reviewed by Jocelyn Turcotte.
1262
1263         Implements support for dumping audio data in DumpRenderTree.
1264
1265         Adds WebAudio to toggleable features in QtTestBrowser.
1266
1267         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
1268         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
1269
1270         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1271         (WebCore::DumpRenderTree::dump):
1272         * DumpRenderTree/qt/TestRunnerQt.cpp:
1273         (TestRunner::reset):
1274         (TestRunner::overridePreference):
1275         (TestRunner::setAudioData):
1276         * DumpRenderTree/qt/TestRunnerQt.h:
1277         (TestRunner::shouldDumpAsAudio):
1278         (TestRunner::audioData):
1279         (TestRunner):
1280         * QtTestBrowser/launcherwindow.cpp:
1281         (LauncherWindow::applyPrefs):
1282         (LauncherWindow::createChrome):
1283         (LauncherWindow::toggleWebAudio):
1284         * QtTestBrowser/launcherwindow.h:
1285         (WindowOptions::WindowOptions):
1286         (WindowOptions):
1287         (LauncherWindow):
1288         * qmake/mkspecs/features/features.prf:
1289         * qmake/mkspecs/features/features.pri:
1290
1291 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1292
1293         Unreviewed jhbuild-related fix after r139431.
1294
1295         * Scripts/webkitpy/layout_tests/port/efl.py:
1296         (EflPort.__init__): Pass a string to set_option_default(), since
1297         shlex.split() will be called on it later.
1298
1299 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1300
1301         Unreviewed typo fixes after r139431.
1302
1303         * Scripts/run-javascriptcore-tests:
1304
1305 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1306
1307         [jhbuild] Remove the "run-with-jhbuild" scripts.
1308         https://bugs.webkit.org/show_bug.cgi?id=106572
1309
1310         Reviewed by Martin Robinson.
1311
1312         Both ports which use jhbuild were mostly duplicating the
1313         `run-with-jhbuild' script in their own directories for no clear reason.
1314
1315         The script itself was just a thin wrapper around the `jhbuild-wrapper',
1316         so just start using that directly and get rid of a useless middle man.
1317
1318         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
1319         instead.
1320
1321         * Scripts/run-javascriptcore-tests:
1322         * Scripts/run-launcher:
1323         * Scripts/webkitdirs.pm:
1324         (runAutogenForAutotoolsProjectIfNecessary):
1325         (buildAutotoolsProject):
1326         (jhbuildWrapperPrefixIfNeeded):
1327         (generateBuildSystemFromCMakeProject):
1328         (buildCMakeGeneratedProject):
1329         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1330         (run):
1331         * Scripts/webkitpy/layout_tests/port/efl.py:
1332         (EflPort.__init__):
1333         (EflPort._image_diff_command):
1334         * efl/run-with-jhbuild: Removed.
1335         * gtk/run-with-jhbuild: Removed.
1336
1337 2013-01-11  Alan Cutter  <alancutter@chromium.org>
1338
1339         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
1340         https://bugs.webkit.org/show_bug.cgi?id=106636
1341
1342         Reviewed by Adam Barth.
1343
1344         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
1345
1346         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1347         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1348         * EWSTools/screen-config:
1349         * EWSTools/start-queue.sh:
1350
1351 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1352
1353         kill-old-processes and delete-stale-build-files use CRLF linebreaks
1354         https://bugs.webkit.org/show_bug.cgi?id=106622
1355
1356         Reviewed by Simon Fraser.
1357
1358         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
1359         Also escape clang\+\+ correctly in kill-old-processes.
1360
1361         * BuildSlaveSupport/delete-stale-build-files:
1362         * BuildSlaveSupport/kill-old-processes:
1363
1364 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1365
1366         Build fix after r139357. It was missing a comma.
1367
1368         * QueueStatusServer/model/queues.py:
1369         (Queue):
1370
1371 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1372
1373         Fixing AuthenticationError when running test-webkitpy as a non-committer.
1374         https://bugs.webkit.org/show_bug.cgi?id=106420
1375
1376         Reviewed by Eric Seidel.
1377
1378         * Scripts/webkitpy/common/checkout/scm/git.py:
1379         (Git.push_local_commits_to_server):
1380         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1381         * Scripts/webkitpy/common/checkout/scm/svn.py:
1382         (SVNRepository):
1383         (SVNRepository.has_authorization_for_realm):
1384
1385 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1386
1387         [EFL][jhbuild] Use tarballs for gstreamer instead of git
1388         https://bugs.webkit.org/show_bug.cgi?id=106552
1389
1390         Reviewed by Laszlo Gombos.
1391
1392         Use tarballs for gstreamer instead of git in EFL's jhbuild
1393         to work around intermittent network issues on our build
1394         bots. Tarballs are fully cached and require no network
1395         operation if their checksum matches.
1396
1397         * efl/jhbuild.modules:
1398
1399 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1400
1401         Add Mac WK2 EWS bots
1402         https://bugs.webkit.org/show_bug.cgi?id=106590
1403
1404         Reviewed by Adam Barth.
1405
1406         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
1407         Also add a deprecated MacWK2Port class.
1408
1409         * QueueStatusServer/model/queues.py:
1410         (Queue):
1411         * Scripts/webkitpy/common/config/ports.py:
1412         (DeprecatedPort.port):
1413         (MacWK2Port):
1414         (MacWK2Port.run_webkit_tests_command):
1415         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1416         (MacEWS):
1417         (MacWK2EWS):
1418         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1419         (_test_ewses):
1420
1421 2013-01-10  Dan Carney  <dcarney@google.com>
1422
1423         [chromium] move webpermissionclient related methods to TestRunner library
1424         https://bugs.webkit.org/show_bug.cgi?id=106548
1425
1426         Reviewed by Jochen Eisinger.
1427
1428         * DumpRenderTree/DumpRenderTree.gypi:
1429         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1430         (DRTTestRunner::DRTTestRunner):
1431         (DRTTestRunner::reset):
1432         * DumpRenderTree/chromium/DRTTestRunner.h:
1433         (DRTTestRunner):
1434         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1435         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
1436         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1437         (WebKit):
1438         (WebTestRunner::WebTestRunner::webPermissions):
1439         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1440         (WebTestRunner::TestRunner::TestRunner):
1441         (WebTestRunner::TestRunner::setDelegate):
1442         (WebTestRunner):
1443         (WebTestRunner::TestRunner::reset):
1444         (WebTestRunner::TestRunner::webPermissions):
1445         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
1446         (WebTestRunner::TestRunner::setImagesAllowed):
1447         (WebTestRunner::TestRunner::setScriptsAllowed):
1448         (WebTestRunner::TestRunner::setStorageAllowed):
1449         (WebTestRunner::TestRunner::setPluginsAllowed):
1450         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
1451         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
1452         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1453         (WebTestRunner):
1454         (TestRunner):
1455         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
1456         (WebTestRunner):
1457         (WebTestRunner::WebPermissions::WebPermissions):
1458         (WebTestRunner::WebPermissions::~WebPermissions):
1459         (WebTestRunner::WebPermissions::allowImage):
1460         (WebTestRunner::WebPermissions::allowScriptFromSource):
1461         (WebTestRunner::WebPermissions::allowStorage):
1462         (WebTestRunner::WebPermissions::allowPlugins):
1463         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
1464         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
1465         (WebTestRunner::WebPermissions::setImagesAllowed):
1466         (WebTestRunner::WebPermissions::setScriptsAllowed):
1467         (WebTestRunner::WebPermissions::setStorageAllowed):
1468         (WebTestRunner::WebPermissions::setPluginsAllowed):
1469         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
1470         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
1471         (WebTestRunner::WebPermissions::setDelegate):
1472         (WebTestRunner::WebPermissions::setDumpCallbacks):
1473         (WebTestRunner::WebPermissions::reset):
1474         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
1475         (WebTestRunner):
1476         (WebPermissions):
1477         * DumpRenderTree/chromium/TestShell.cpp:
1478         (TestShell::initialize):
1479         (TestShell::resetTestController):
1480         (TestShell::createNewWindow):
1481         * DumpRenderTree/chromium/TestShell.h:
1482         (TestShell):
1483         * DumpRenderTree/chromium/WebViewHost.cpp:
1484         (WebViewHost::normalizeLayoutTestURL):
1485         * DumpRenderTree/chromium/WebViewHost.h:
1486         (WebViewHost):
1487
1488 2013-01-10  Alan Cutter  <alancutter@chromium.org>
1489
1490         Split EWS tool cold-boot.sh into modular components
1491         https://bugs.webkit.org/show_bug.cgi?id=106527
1492
1493         Reviewed by Adam Barth.
1494
1495         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
1496         Updated GCE bot build scripts to match.
1497         Unable to test scripts directly as they depend on being in the repository to work!
1498
1499         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1500         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1501         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
1502         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
1503         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
1504
1505 2013-01-10  Julie Parent  <jparent@chromium.org>
1506
1507         Dashboard Cleanup: Do not generate the page if we are about to reload.
1508         https://bugs.webkit.org/show_bug.cgi?id=106584
1509
1510         Reviewed by Dirk Pranke.
1511
1512         Move the logic to determine if we should generate the page into
1513         parseParameters() since that is where we have the knowledge to
1514         determine it, and return that value to handleLocationChange, 
1515         rather than passing the changed parameters back to handleLocationChange
1516         and having it make the decision.
1517         
1518         This is logically equivalent, save one case: when we are about to do
1519         a reload, we know that there is no reason to generate the page.  Old
1520         code was causing an extra page generation in this case.
1521         
1522         * TestResultServer/static-dashboards/dashboard_base.js:
1523         (parseParameters):
1524         (handleLocationChange):
1525
1526 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1527
1528         [jhbuild] Use the "configure" script to build glib
1529         https://bugs.webkit.org/show_bug.cgi?id=106569
1530
1531         Reviewed by Martin Robinson.
1532
1533         So far both EFL and GTK have been using autogen.sh to build glib.
1534         While that does work most of the time, it's not really needed since
1535         we are downloading and building stable releases from tarballs.
1536         Additionally, autogen.sh fails to work with automake 1.13 due to the
1537         usage of some macros that have been removed (this has already been
1538         fixed in glib master).
1539
1540         * efl/jhbuild.modules:
1541         * gtk/jhbuild.modules:
1542
1543 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1544
1545         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1546         (Missed a couple)
1547         https://bugs.webkit.org/show_bug.cgi?id=106536
1548
1549         Reviewed by Eric Seidel.
1550
1551         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1552
1553 2013-01-10  Tony Chang  <tony@chromium.org>
1554
1555         Speed up supplemental dependency computation
1556         https://bugs.webkit.org/show_bug.cgi?id=106503
1557
1558         Reviewed by Adam Barth.
1559
1560         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
1561
1562         * WebKitTestRunner/CMakeLists.txt:
1563
1564 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
1565
1566         Remove the ENABLE_ANIMATION_API feature define occurences
1567         https://bugs.webkit.org/show_bug.cgi?id=106544
1568
1569         Reviewed by Simon Fraser.
1570
1571         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
1572         feature define handling still lingers in various build systems and configurations
1573         but is of no use, so it should be removed.
1574
1575         * Scripts/webkitperl/FeatureList.pm:
1576         * qmake/mkspecs/features/features.pri:
1577
1578 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1579
1580         [GTK] Add support for loading web process extensions
1581         https://bugs.webkit.org/show_bug.cgi?id=105631
1582
1583         Reviewed by Gustavo Noronha Silva.
1584
1585         * MiniBrowser/gtk/GNUmakefile.am:
1586         * MiniBrowser/gtk/main.c:
1587         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
1588         bundle lib from build dir.
1589         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
1590         located in WebProcess/InjectedBundle/API/gtk.
1591         * gtk/generate-gtkdoc:
1592         (get_webkit2_options): Scan also files in
1593         WebProcess/InjectedBundle/API/gtk to generate API docs.
1594         (get_webkit2_options.injected_bundle_src_path): Helper function to
1595         build paths in WebProcess/InjectedBundle/API/gtk.
1596
1597 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1598
1599         [EFL][WK2] Writing immediately to created windows (open) fails
1600         https://bugs.webkit.org/show_bug.cgi?id=105276
1601
1602         Reviewed by Kenneth Rohde Christiansen.
1603
1604         Do not reset 'about:blank' url for the new pages in mini browser.
1605
1606         * MiniBrowser/efl/main.c:
1607         (window_create):
1608
1609 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1610
1611         Changing tests to be consistent and use self.scm rather then recreating the scm object.
1612         https://bugs.webkit.org/show_bug.cgi?id=106536
1613
1614         Reviewed by Eric Seidel.
1615
1616         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1617
1618 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
1619
1620         Converting to unittest2 so we can use assertItemsEqual, making tests
1621         not dependent on order of items.
1622         https://bugs.webkit.org/show_bug.cgi?id=106532
1623
1624         Before:
1625         Ran 1733 tests in 38.385s
1626         FAILED (failures=1, errors=22)
1627
1628         After:
1629         Ran 1733 tests in 32.298s
1630         FAILED (failures=0, errors=22)
1631
1632         Reviewed by Eric Seidel.
1633
1634         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1635         * Scripts/webkitpy/thirdparty/__init__.py:
1636         (AutoinstallImportHook._install_unittest2):
1637
1638 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
1639
1640         [EFL] Add gstreamer 1.0.5 to jhbuild
1641         https://bugs.webkit.org/show_bug.cgi?id=106178
1642
1643         Reviewed by Laszlo Gombos.
1644
1645         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
1646
1647         * efl/jhbuild.modules:
1648
1649 2013-01-09  Alan Cutter  <alancutter@chromium.org>
1650
1651         Updated parameters in GCE build scripts so they now work.
1652         https://bugs.webkit.org/show_bug.cgi?id=106523
1653
1654         Reviewed by Adam Barth.
1655
1656         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
1657         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
1658         * EWSTools/cold-boot.sh:
1659
1660 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
1661
1662         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
1663         https://bugs.webkit.org/show_bug.cgi?id=106520
1664
1665         Reviewed by James Robinson.
1666
1667         Part of a larger refactoring series. See tracking bug 82948.
1668
1669         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1670         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1671
1672 2013-01-09  Julie Parent  <jparent@chromium.org>
1673
1674         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
1675         https://bugs.webkit.org/show_bug.cgi?id=106514
1676
1677         This is old code, as these can no longer get out of sync.
1678         permmaLinkURLHash is generated from currentState, which is set only
1679         from the location.  The commment about how these can get out of sync
1680         refers to a function that no longer exists.
1681         
1682         Reviewed by Dirk Pranke.
1683
1684         * TestResultServer/static-dashboards/dashboard_base.js:
1685         (handleLocationChange):
1686
1687 2013-01-09  Julie Parent  <jparent@chromium.org>
1688
1689         Dashboard Cleanup: Reload the page as soon as we know we need to.
1690         https://bugs.webkit.org/show_bug.cgi?id=106515
1691
1692         No need to continue parsing all of the data once we know that
1693         we need to do a reload.
1694         
1695         Reviewed by Dirk Pranke.
1696
1697         * TestResultServer/static-dashboards/dashboard_base.js:
1698         (parseParameters):
1699
1700 2013-01-09  Eric Seidel  <eric@webkit.org>
1701
1702         run-perf-tests --chromium-android --profile should show symbols for the kernel
1703         https://bugs.webkit.org/show_bug.cgi?id=106498
1704
1705         Reviewed by Adam Barth.
1706
1707         Turns out this was easy, once I finally read the output from "perf report".
1708         It appears there may be a bug in "perf record" on android, as it complains
1709         about not being able to read from /proc/kallsyms even when
1710         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
1711         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
1712         but rather just flip it to 0 long enough to grab the /proc/kallsyms
1713         and then flip it back to whatever the device had.
1714
1715         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
1716         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
1717         to symbol names.  Its world-readable, but will return all 0s if you
1718         don't have permission to see the kernel symbols.  kptr_restrict
1719         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
1720         1 is only a specific group, and 2 is "no one, not even root".
1721         By default kptr_restrict is 2 on Android it seems.
1722         More kptr_restrict docs: http://lwn.net/Articles/420403/
1723
1724         I also took this opportunity to clean up how the perf record command
1725         was built for use/display in AndroidPerf.profile_after_exit and
1726         change to always using long-form names for the arguments (to hopefully help readability).
1727
1728         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1729         (AndroidPerf.__init__):
1730         (profile_after_exit):
1731         (ChromiumAndroidDriver.__init__):
1732         (ChromiumAndroidDriver._update_kallsyms_cache):
1733         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1734
1735 2013-01-09  Julie Parent  <jparent@chromium.org>
1736
1737         Dashboard cleanup: remove dead code.
1738         https://bugs.webkit.org/show_bug.cgi?id=106509
1739
1740         Reviewed by Dirk Pranke.
1741
1742         * TestResultServer/static-dashboards/dashboard_base.js:
1743         (parseParameters):
1744
1745 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
1746
1747         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
1748         https://bugs.webkit.org/show_bug.cgi?id=105638
1749
1750         Reviewed by Martin Robinson.
1751
1752         The test was failing for two reasons:
1753         - AccessibilityRenderObject::correspondingLabelForControlElement() was
1754           not ignoring the ARIA labelled-by property
1755         - AccessibilityController::accessibleElementById() was not implemented
1756
1757         Because getting an element by ID cannot be done in the UIProcess, the
1758         decision was made to expose the element's ID as an accessible attribute
1759         of the object.
1760
1761         In addition, fixing the bug in AccessibilityRenderObject made it possible
1762         to eliminate the Gtk platform-specific expectations for another test.
1763
1764         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1765         (childElementById): Added. Walks the tree looking for the AtkObject
1766         Attribute which exposes the HTML element's ID.
1767         (AccessibilityController::accessibleElementById): Implemented.
1768         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1769         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
1770         when there is no title, as is done with the Mac port.
1771         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1772         (WTR):
1773         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1774         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
1775         Attribute which exposes the HTML element's ID.
1776         (WTR):
1777         (WTR::AccessibilityController::accessibleElementById): Implemented.
1778         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1779         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
1780         even when there is no title, as is done with the Mac port.
1781
1782 2013-01-09  Gregg Tavares  <gman@google.com>
1783
1784         Add Gregg Tavares as a committer
1785         https://bugs.webkit.org/show_bug.cgi?id=106492
1786
1787         Unreviewed.
1788
1789         * Scripts/webkitpy/common/config/committers.py:
1790
1791 2013-01-09  Roger Fong  <roger_fong@apple.com>
1792
1793         Enable seamless iFrames for Windows DRT.
1794         https://bugs.webkit.org/show_bug.cgi?id=106468.
1795
1796         Rubberstamped by Timothy Horton.
1797
1798         * DumpRenderTree/win/DumpRenderTree.cpp:
1799         (resetDefaultsToConsistentValues):
1800
1801 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
1802
1803         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
1804         https://bugs.webkit.org/show_bug.cgi?id=93979
1805
1806         Reviewed by Benjamin Poulain.
1807
1808         Implement eventSender.scheduleAsynchronousKeyDown() in
1809         WebKitTestRunner.
1810
1811         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1812         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1813         (WTR::createKeyDownMessageBody):
1814         (WTR::EventSendingController::keyDown):
1815         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1816         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1817         (EventSendingController):
1818         * WebKitTestRunner/TestController.cpp:
1819         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
1820         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1821         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1822         * WebKitTestRunner/TestController.h:
1823         (TestController):
1824
1825 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
1826
1827         [chromium] move resource load callback dumping to TestRunner library
1828         https://bugs.webkit.org/show_bug.cgi?id=106449
1829
1830         Reviewed by Adam Barth.
1831
1832         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1833         (DRTTestRunner::DRTTestRunner):
1834         (DRTTestRunner::reset):
1835         * DumpRenderTree/chromium/DRTTestRunner.h:
1836         (DRTTestRunner):
1837         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1838         (WebKit):
1839         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
1840         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1841         (WebKit):
1842         (WebTestProxyBase):
1843         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
1844         (WebTestRunner::WebTestProxy::willRequestResource):
1845         (WebTestRunner::WebTestProxy::willSendRequest):
1846         (WebTestRunner::WebTestProxy::didReceiveResponse):
1847         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
1848         (WebTestRunner::WebTestProxy::didFailResourceLoad):
1849         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1850         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
1851         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
1852         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
1853         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1854         (WebTestRunner::TestRunner::TestRunner):
1855         (WebTestRunner::TestRunner::reset):
1856         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
1857         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
1858         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
1859         (WebTestRunner):
1860         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
1861         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
1862         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
1863         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1864         (TestRunner):
1865         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1866         (WebTestRunner::WebTestProxyBase::reset):
1867         (WebTestRunner):
1868         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1869         (WebTestRunner::WebTestProxyBase::willRequestResource):
1870         (WebTestRunner::WebTestProxyBase::willSendRequest):
1871         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
1872         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
1873         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
1874         * DumpRenderTree/chromium/WebViewHost.cpp:
1875         (WebViewHost::willSendRequest):
1876         (WebViewHost::makeURLErrorDescription):
1877         (WebViewHost::reset):
1878         * DumpRenderTree/chromium/WebViewHost.h:
1879         (WebViewHost):
1880
1881 2013-01-09  Dan Carney  <dcarney@google.com>
1882
1883         [chromium] move dumpcreateview methods to testrunner library
1884         https://bugs.webkit.org/show_bug.cgi?id=106434
1885
1886         Reviewed by Adam Barth.
1887
1888         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1889         (DRTTestRunner::DRTTestRunner):
1890         (DRTTestRunner::reset):
1891         * DumpRenderTree/chromium/DRTTestRunner.h:
1892         (DRTTestRunner):
1893         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1894         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
1895         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1896         (WebTestRunner::TestRunner::TestRunner):
1897         (WebTestRunner::TestRunner::reset):
1898         (WebTestRunner::TestRunner::shouldDumpCreateView):
1899         (WebTestRunner):
1900         (WebTestRunner::TestRunner::dumpCreateView):
1901         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1902         (TestRunner):
1903
1904 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
1905
1906         webkitpy cleanup: Merge additional_comment_text into comment_text
1907         https://bugs.webkit.org/show_bug.cgi?id=106421
1908
1909         Reviewed by Adam Barth.
1910
1911         * Scripts/webkitpy/common/config/committervalidator.py:
1912         (CommitterValidator.reject_patch_from_commit_queue):
1913         (CommitterValidator.reject_patch_from_review_queue):
1914         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1915         (Bugzilla.set_flag_on_attachment):
1916         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1917         (MockBugzilla.set_flag_on_attachment):
1918         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1919         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1920         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1921         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1922
1923 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1924
1925         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
1926         https://bugs.webkit.org/show_bug.cgi?id=106464
1927
1928         Reviewed by Martin Robinson.
1929
1930         Current version in jhbuild.modules (2.26.0) is giving trouble to
1931         when trying to build WebKitGTK from scratch, due to a segmentation
1932         fault error in gdk-pixbuf-query-loader during the 'make'
1933         phase. Raising the version to 2.26.5 fixes this issue.
1934
1935         * gtk/jhbuild.modules: Version raised, checksums updated.
1936
1937 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
1938
1939         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
1940         https://bugs.webkit.org/show_bug.cgi?id=90968.
1941
1942         Reviewed by Csaba Osztrogonác.
1943
1944         Added functionality in DRT and WTR to use any timeout value while running
1945         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
1946         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
1947         to indicate whether the current port supports setting timeout value
1948         per test (it's False by default; I enabled it only on Qt).
1949         Also corrected a typo in driver.py
1950
1951         * DumpRenderTree/DumpRenderTree.h:
1952         (TestCommand::TestCommand):
1953         (TestCommand):
1954         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1955         (parseInputLine):
1956         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1957         (WebCore::DumpRenderTree::processLine):
1958         * Scripts/webkitpy/layout_tests/port/base.py:
1959         (Port.supports_per_test_timeout):
1960         * Scripts/webkitpy/layout_tests/port/driver.py:
1961         (Driver.run_test):
1962         (Driver._command_from_driver_input):
1963         * Scripts/webkitpy/layout_tests/port/qt.py:
1964         (QtPort.supports_per_test_timeout):
1965         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1966         (WTR::InjectedBundle::InjectedBundle):
1967         (WTR::InjectedBundle::didReceiveMessage):
1968         (WTR::InjectedBundle::beginTesting):
1969         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1971         (WTR::TestRunner::setCustomTimeout):
1972         (WTR):
1973         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1974         (TestRunner):
1975         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
1976         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1977         * WebKitTestRunner/TestController.cpp:
1978         (WTR::TestController::TestController):
1979         (WTR::TestController::getCustomTimeout):
1980         (WTR):
1981         (WTR::TestCommand::TestCommand):
1982         (TestCommand):
1983         (WTR::parseInputLine):
1984         (WTR::TestController::runTest):
1985         (WTR::TestController::runUntil):
1986         * WebKitTestRunner/TestController.h:
1987         (TestController):
1988         * WebKitTestRunner/TestInvocation.cpp:
1989         (WTR::TestInvocation::TestInvocation):
1990         (WTR::TestInvocation::setCustomTimeout):
1991         (WTR):
1992         (WTR::TestInvocation::invoke):
1993         * WebKitTestRunner/TestInvocation.h:
1994         (TestInvocation):
1995
1996 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1997
1998         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
1999         https://bugs.webkit.org/show_bug.cgi?id=106290
2000
2001         Reviewed by Martin Robinson.
2002
2003         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
2004         the macro isn't enabled.
2005
2006         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2007
2008 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
2009
2010         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
2011         https://bugs.webkit.org/show_bug.cgi?id=103653
2012
2013         Reviewed by Anders Carlsson.
2014
2015         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
2016         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
2017         client callback.
2018
2019         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
2020         methods to the JavaScript API.
2021         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2022         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
2023         (WTR::TestRunner::setAuthenticationUsername): Ditto.
2024         (WTR::TestRunner::setAuthenticationPassword): Ditto.
2025         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2026         (TestRunner): Added new declarations for the above.
2027         * WebKitTestRunner/TestController.cpp:
2028         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
2029         callback.
2030         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
2031         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
2032         the authentication information passed from the InjectedBundle.
2033         * WebKitTestRunner/TestController.h:
2034         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
2035         to communicate with the TestController.
2036         (WTR::TestController::setAuthenticationUsername): Ditto.
2037         (WTR::TestController::setAuthenticationPassword): Ditto.
2038         (TestController):
2039         * WebKitTestRunner/TestInvocation.cpp:
2040         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
2041         information from the InjectedBundle.
2042         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
2043         text to the TestInvocation text output.
2044         * WebKitTestRunner/TestInvocation.h:
2045         (TestInvocation): Added declaration for new method.
2046
2047 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
2048
2049         Add myself as a watcher for Web Geolocation
2050
2051         Unreviewed.
2052
2053         * Scripts/webkitpy/common/config/watchlist:
2054
2055 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2056
2057         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
2058         https://bugs.webkit.org/show_bug.cgi?id=106364
2059
2060         Reviewed by Eric Seidel.
2061
2062         When the setup_test_run method is called on the subclasses of the base Port
2063         interface, the parent method should also be called via super(), despite the
2064         parent method not doing anything at the moment.
2065
2066         The according calls to super() are required in the ChromiumPort, EflPort
2067         and GtkPort implementations.
2068
2069         * Scripts/webkitpy/layout_tests/port/chromium.py:
2070         (ChromiumPort.setup_test_run):
2071         * Scripts/webkitpy/layout_tests/port/efl.py:
2072         (EflPort.setup_test_run):
2073         * Scripts/webkitpy/layout_tests/port/gtk.py:
2074         (GtkPort.setup_test_run):
2075
2076 2013-01-08  Julie Parent  <jparent@chromium.org>
2077
2078         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
2079         https://bugs.webkit.org/show_bug.cgi?id=106356
2080
2081         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
2082         dashboard_base, assigned by Loader, and used only by dashboard_base to
2083         create error messages.  Moved the variables to be privates on the Loader
2084         object, moved error message creation to _getLoadingErrorMessages on the
2085         Loader object, and now pass the errors back to dashboard base via the
2086         resourceLoadingComplete callback.
2087         
2088         Also removed the now unused clearError function, it was only being used
2089         by unit tests to clean up global state.
2090         
2091         Reviewed by Dirk Pranke.
2092
2093         * TestResultServer/static-dashboards/dashboard_base.js:
2094         (resourceLoadingComplete):
2095         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2096         * TestResultServer/static-dashboards/loader.js:
2097         (.):
2098         * TestResultServer/static-dashboards/loader_unittests.js:
2099
2100 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2101
2102         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
2103         https://bugs.webkit.org/show_bug.cgi?id=106354
2104
2105         Reviewed by Eric Seidel.
2106
2107         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
2108         instead of those two inheriting from it. Also add a mock object of the
2109         sanitizer that's used in unit tests.
2110
2111         * Scripts/webkitpy/layout_tests/port/efl.py:
2112         (EflPort):
2113         (EflPort.__init__):
2114         (EflPort.setup_test_run):
2115         (EflPort.clean_up_test_run):
2116         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
2117         importing order.
2118         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2119         * Scripts/webkitpy/layout_tests/port/gtk.py:
2120         (GtkPort):
2121         (GtkPort.__init__):
2122         (GtkPort.setup_test_run):
2123         (GtkPort.clean_up_test_run):
2124         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
2125         importing order.
2126         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
2127         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
2128         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
2129         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
2130         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
2131         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
2132         (PulseAudioSanitizerMock.unload_pulseaudio_module):
2133         (PulseAudioSanitizerMock.restore_pulseaudio_module):
2134
2135 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
2136
2137         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
2138         https://bugs.webkit.org/show_bug.cgi?id=106324
2139
2140         Reviewed by Adam Barth.
2141
2142         Since the frame load callbacks are part of the WebFrameClient, the
2143         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
2144         methods.
2145
2146         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2147         (DRTTestRunner::DRTTestRunner):
2148         (DRTTestRunner::reset):
2149         * DumpRenderTree/chromium/DRTTestRunner.h:
2150         (DRTTestRunner):
2151         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2152         (WebTestInterfaces):
2153         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
2154         (WebKit):
2155         (WebTestProxyBase):
2156         (WebTestRunner):
2157         (WebTestRunner::WebTestProxy::WebTestProxy):
2158         (WebTestProxy):
2159         (WebTestRunner::WebTestProxy::didInvalidateRect):
2160         (WebTestRunner::WebTestProxy::didScrollRect):
2161         (WebTestRunner::WebTestProxy::scheduleComposite):
2162         (WebTestRunner::WebTestProxy::scheduleAnimation):
2163         (WebTestRunner::WebTestProxy::setWindowRect):
2164         (WebTestRunner::WebTestProxy::show):
2165         (WebTestRunner::WebTestProxy::didAutoResize):
2166         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
2167         (WebTestRunner::WebTestProxy::startDragging):
2168         (WebTestRunner::WebTestProxy::shouldBeginEditing):
2169         (WebTestRunner::WebTestProxy::shouldEndEditing):
2170         (WebTestRunner::WebTestProxy::shouldInsertNode):
2171         (WebTestRunner::WebTestProxy::shouldInsertText):
2172         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
2173         (WebTestRunner::WebTestProxy::shouldDeleteRange):
2174         (WebTestRunner::WebTestProxy::shouldApplyStyle):
2175         (WebTestRunner::WebTestProxy::didBeginEditing):
2176         (WebTestRunner::WebTestProxy::didChangeSelection):
2177         (WebTestRunner::WebTestProxy::didChangeContents):
2178         (WebTestRunner::WebTestProxy::didEndEditing):
2179         (WebTestRunner::WebTestProxy::registerIntentService):
2180         (WebTestRunner::WebTestProxy::dispatchIntent):
2181         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
2182         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
2183         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
2184         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
2185         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
2186         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
2187         (WebTestRunner::WebTestProxy::didReceiveTitle):
2188         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
2189         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
2190         (WebTestRunner::WebTestProxy::didFailLoad):
2191         (WebTestRunner::WebTestProxy::didFinishLoad):
2192         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
2193         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
2194         (WebTestRunner::WebTestProxy::didRunInsecureContent):
2195         (WebTestRunner::WebTestProxy::didDetectXSS):
2196         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2197         (WebTestRunner::WebTestRunner::setTestIsRunning):
2198         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
2199         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
2200         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2201         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
2202         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
2203         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2204         (WebTestRunner::TestRunner::TestRunner):
2205         (WebTestRunner::TestRunner::reset):
2206         (WebTestRunner::TestRunner::setTestIsRunning):
2207         (WebTestRunner):
2208         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
2209         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
2210         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
2211         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
2212         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
2213         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
2214         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
2215         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
2216         (WebTestRunner::TestRunner::dumpTitleChanges):
2217         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2218         (TestRunner):
2219         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2220         (WebTestInterfaces::Internal):
2221         (WebTestRunner::WebTestInterfaces::Internal::webView):
2222         (WebTestRunner::WebTestInterfaces::Internal::Internal):
2223         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
2224         (WebTestRunner):
2225         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
2226         (WebTestRunner::WebTestInterfaces::setWebView):
2227         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
2228         (WebTestRunner::WebTestInterfaces::webView):
2229         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2230         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
2231         (WebTestRunner):
2232         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
2233         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
2234         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
2235         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
2236         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
2237         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
2238         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
2239         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
2240         (WebTestRunner::WebTestProxyBase::didFailLoad):
2241         (WebTestRunner::WebTestProxyBase::didFinishLoad):
2242         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
2243         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
2244         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
2245         (WebTestRunner::WebTestProxyBase::didDetectXSS):
2246         * DumpRenderTree/chromium/TestShell.cpp:
2247         (TestShell::runFileTest):
2248         (TestShell::testFinished):
2249         * DumpRenderTree/chromium/TestShell.h:
2250         (TestShell):
2251         * DumpRenderTree/chromium/WebViewHost.cpp:
2252         (WebViewHost::didStartProvisionalLoad):
2253         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
2254         (WebViewHost::didFailProvisionalLoad):
2255         (WebViewHost::didCommitProvisionalLoad):
2256         (WebViewHost::didReceiveTitle):
2257         (WebViewHost::didFailLoad):
2258         (WebViewHost::didFinishLoad):
2259         * DumpRenderTree/chromium/WebViewHost.h:
2260         (WebViewHost):
2261
2262 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2263
2264         [GTK] Lower the default timeout value for WebKitTestRunner
2265         https://bugs.webkit.org/show_bug.cgi?id=106353
2266
2267         Reviewed by Dirk Pranke.
2268
2269         The default timeout value for WebKitTestRunner should be lowered.
2270         The current value (80 seconds) is irrational and just leads to producing
2271         text failures for layout tests that genuinely time out. This just leads
2272         to more deviation from the GTK WK1 port in terms of test expectations.
2273
2274         The value used is the same as when running the DumpRenderTree, that's
2275         6 seconds in release builds and 12 seconds in debug builds.
2276
2277         * Scripts/webkitpy/layout_tests/port/gtk.py:
2278         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2279         (GtkPortTest.test_default_timeout_ms):
2280
2281 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2282
2283         test-webkitpy shows failure output on my linux box
2284         https://bugs.webkit.org/show_bug.cgi?id=101261
2285
2286         Reviewed by Eric Seidel.
2287
2288         Mock out the PulseAudioSanitizer methods when creating testing instances
2289         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
2290         PulseAudio output when the sanitizer was trying to unload modules which
2291         were already unloaded by another unit test that was being run in parallel.
2292
2293         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2294         (EflPortTest):
2295         (EflPortTest.make_port):
2296         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2297         (GtkPortTest):
2298         (GtkPortTest.make_port):
2299
2300 2013-01-08  Julie Parent  <jparent@chromium.org>
2301
2302         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
2303         https://bugs.webkit.org/show_bug.cgi?id=106254
2304
2305         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
2306         only to figure out if we should call addBuilderLoadErrors during
2307         handleLocationChange, which was called when the loader completed and on
2308         any hash change, but we only ever wanted to call addBuilderLoadErrors
2309         on the initial loader load.  Moved the call of addBuilderLoadErrors to
2310         resourceLoadingComplete rather than handleLocationChange, so now we
2311         only call it when we want to, and the check can go away completely.
2312
2313         Reviewed by Dirk Pranke.
2314
2315         * TestResultServer/static-dashboards/dashboard_base.js:
2316         (addBuilderLoadErrors):
2317         (resourceLoadingComplete):
2318         (handleLocationChange):
2319         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2320
2321 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
2322
2323         Add aboxhall@chromium.org to accessibility watchlist.
2324
2325         Unreviewed.
2326
2327         * Scripts/webkitpy/common/config/watchlist:
2328
2329 2013-01-08  Dan Winship  <danw@gnome.org>
2330
2331         Add Apache 2.4 support for Fedora 18
2332         https://bugs.webkit.org/show_bug.cgi?id=104478
2333
2334         Reviewed by Martin Robinson.
2335
2336         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
2337         need a separate config.
2338
2339         * Scripts/webkitpy/layout_tests/port/base.py:
2340         (Port._apache_version):
2341         (Port._apache_config_file_name_for_platform):
2342         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2343         * Scripts/run-webkit-httpd:
2344         * Scripts/webkitperl/httpd.pm:
2345         (getApacheVersion):
2346         (getDefaultConfigForTestDirectory):
2347         (getHTTPDConfigPathForTestDirectory):
2348
2349 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2350
2351         Make the override-feature-defines script compatible with Python v3
2352         https://bugs.webkit.org/show_bug.cgi?id=105742
2353
2354         Reviewed by Martin Robinson.
2355
2356         Instead of printing output through a statement, use the print function and format
2357         the output using the str.format method. This makes the script runnable with Python v3.
2358
2359         * gtk/override-feature-defines:
2360         (adjust_feature_defines_makefile):
2361
2362 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
2363
2364         [Qt] Fix libxml2 config test
2365         https://bugs.webkit.org/show_bug.cgi?id=106317
2366
2367         Reviewed by Simon Hausmann.
2368
2369         Don't assume standard include/libxml2, libxml-2.0.pc should know
2370         where it's headers are.
2371
2372         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
2373
2374 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
2375
2376         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
2377         https://bugs.webkit.org/show_bug.cgi?id=106195
2378
2379         Reviewed by Philippe Normand.
2380
2381         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
2382         to make the Python code compatible with Python 3. This includes modifying
2383         print statements, exception handling, dictionary iteration and
2384         byte-sequence-to-string conversion.
2385
2386         * gtk/common.py:
2387         (get_build_path):
2388         (pkg_config_file_variable):
2389         (gtk_version_of_pkg_config_file):
2390         * gtk/generate-gtkdoc:
2391         (print_missing_api):
2392         * gtk/gtkdoc.py:
2393         (GTKDoc.__init__):
2394         (GTKDoc._run_command):
2395
2396 2013-01-02  Steve Block  <steveblock@chromium.org>
2397
2398         Add chromium.org email address for Steve Block.
2399
2400         Unreviewed.
2401
2402         * Scripts/webkitpy/common/config/committers.py:
2403
2404 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
2405
2406         Rationalize closure call heuristics and profiling
2407         https://bugs.webkit.org/show_bug.cgi?id=106270
2408
2409         Reviewed by Oliver Hunt.
2410         
2411         Add ability to use display-profiler-output via a pipe, and add the ability to dump
2412         all generated code ('display *' or 'd *').
2413
2414         * Scripts/display-profiler-output:
2415
2416 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2417
2418         Sorted more xcodeproj files.
2419
2420         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2421         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2422         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
2423
2424 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2425
2426         Sorted xcodeproj files.
2427
2428         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2429         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2430
2431 2013-01-07  Dan Bernstein  <mitz@apple.com>
2432
2433         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
2434         https://bugs.webkit.org/show_bug.cgi?id=106261
2435
2436         Reviewed by Simon Fraser.
2437
2438         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
2439
2440         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2441         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
2442         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
2443         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
2444         (TestWebKitAPI):
2445         (TestWebKitAPI::TEST):
2446
2447 2013-01-07  Ojan Vafai  <ojan@chromium.org>
2448
2449         Add the Apple MountainLion bots to garden-o-matic.
2450         Eventually, we really should move away from hardcoding
2451         the list of bots.
2452
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2454
2455 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2456
2457         [chromium] move web audio related methods to testrunner library
2458         https://bugs.webkit.org/show_bug.cgi?id=106211
2459
2460         Reviewed by Adam Barth.
2461
2462         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2463         (DRTTestRunner::DRTTestRunner):
2464         (DRTTestRunner::reset):
2465         * DumpRenderTree/chromium/DRTTestRunner.h:
2466         (DRTTestRunner):
2467         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2468         (WebKit):
2469         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
2470         (WebTestRunner::WebTestRunner::audioData):
2471         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2472         (WebTestRunner::TestRunner::TestRunner):
2473         (WebTestRunner::TestRunner::reset):
2474         (WebTestRunner::TestRunner::shouldDumpAsAudio):
2475         (WebTestRunner):
2476         (WebTestRunner::TestRunner::audioData):
2477         (WebTestRunner::TestRunner::setAudioData):
2478         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2479         (TestRunner):
2480         * DumpRenderTree/chromium/TestShell.cpp:
2481         (TestShell::dump):
2482
2483 2013-01-07  Mike West  <mkwst@chromium.org>
2484
2485         Make the IFRAME_SEAMLESS flag runtime-enabled.
2486         https://bugs.webkit.org/show_bug.cgi?id=106213
2487
2488         Reviewed by Ojan Vafai.
2489
2490         * DumpRenderTree/chromium/TestShell.cpp:
2491         (TestShell::TestShell):
2492         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2493         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2495         (resetDefaultsToConsistentValues):
2496         * DumpRenderTree/mac/DumpRenderTree.mm:
2497         (resetDefaultsToConsistentValues):
2498         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2499         (WebCore::WebPage::resetSettings):
2500         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2501         (WTR::InjectedBundle::beginTesting):
2502             Ensure that seamless IFrames are enabled for layout tests in each of
2503             the ports that support seamless IFrames.
2504
2505 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
2506
2507         [chromium] move dumpAsText and friends to the TestRunner library
2508         https://bugs.webkit.org/show_bug.cgi?id=106222
2509
2510         Reviewed by Adam Barth.
2511
2512         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
2513
2514         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2515         (DRTTestRunner::DRTTestRunner):
2516         (DRTTestRunner::reset):
2517         * DumpRenderTree/chromium/DRTTestRunner.h:
2518         (DRTTestRunner):
2519         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2520         (WebTestRunner::WebTestRunner::shouldDumpAsText):
2521         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
2522         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
2523         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
2524         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
2525         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
2526         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2527         (WebTestRunner::TestRunner::TestRunner):
2528         (WebTestRunner::TestRunner::reset):
2529         (WebTestRunner::TestRunner::shouldDumpAsText):
2530         (WebTestRunner):
2531         (WebTestRunner::TestRunner::setShouldDumpAsText):
2532         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
2533         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
2534         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
2535         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
2536         (WebTestRunner::TestRunner::dumpAsText):
2537         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
2538         (WebTestRunner::TestRunner::dumpChildFramesAsText):
2539         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2540         (TestRunner):
2541
2542 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2543
2544         Build fix attempt after r138810.
2545
2546         Apparently python 2.6 is really bad at floating point computation.
2547
2548         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2549         (MainTest.test_run_memory_test):
2550
2551 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
2552
2553         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
2554         https://bugs.webkit.org/show_bug.cgi?id=106172
2555
2556         Reviewed by Tony Chang.
2557
2558         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
2559         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
2560         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
2561         test on perf-o-matic and perf. test's results page.
2562
2563         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
2564
2565         * Scripts/webkitpy/performance_tests/perftest.py:
2566         (PerfTestMetric): Added.
2567         (PerfTestMetric.__init__): Added.
2568         (PerfTestMetric.metric): Added.
2569         (PerfTestMetric.has_values): Added.
2570         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
2571         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
2572         conversions to be done on the client side (perf-o-matic and results page).
2573         (PerfTestMetric.append): Added.
2574         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
2575         a result for this metric.
2576         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
2577         (PerfTestMetric.compute_statistics): Moved from PerfTest.
2578
2579         (PerfTest._create_driver): Extracted from PerfTest.run.
2580         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
2581         as needed.
2582         (PerfTest._run_with_driver):
2583         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
2584         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
2585         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
2586
2587         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
2588         from other perf tests, there isn't much point in sharing the code here.
2589
2590         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
2591         statistics for the measured values.
2592
2593         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2594         (TestPerfTestMetric): Added.
2595         (TestPerfTestMetric.test_init_set_missing_unit): Added.
2596         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
2597         (TestPerfTestMetric.test_has_values): Added.
2598         (TestPerfTestMetric.test_append): Added.
2599         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
2600         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
2601
2602         (TestPerfTest._assert_results_are_correct): Updated as needed.
2603         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
2604         in PerfTest.run now after generating the results dictionary.
2605         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
2606
2607 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
2608
2609         Support size_t multiplication and division operators on LayoutUnit
2610         https://bugs.webkit.org/show_bug.cgi?id=83848
2611
2612         Reviewed by Emil A Eklund.
2613
2614         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2615         Added some simple tests for the new operators using size_t.
2616
2617 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2618
2619         [Qt] run-webkit-tests cleanup for parallel NRWT
2620         https://bugs.webkit.org/show_bug.cgi?id=106220
2621
2622         Reviewed by Dirk Pranke.
2623
2624         * Scripts/run-webkit-tests:
2625         (useNewRunWebKitTests):
2626         * Scripts/webkitpy/layout_tests/port/qt.py:
2627         (QtPort):
2628         (QtPort.default_child_processes):
2629
2630 2013-01-07  Philippe Normand  <pnormand@igalia.com>
2631
2632         Create a GStreamerAudio watchlist and add myself to it.
2633
2634         Unreviewed.
2635
2636         * Scripts/webkitpy/common/config/watchlist:
2637
2638 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
2639
2640         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
2641         Also removed the empty mac directory.
2642
2643         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
2644         * BuildSlaveSupport/download-built-product: Added property svn:executable.
2645         * BuildSlaveSupport/mac: Removed.
2646         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
2647
2648 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2649
2650         Add a script to delete stale zero-byte build files
2651         https://bugs.webkit.org/show_bug.cgi?id=106131
2652
2653         Reviewed by Tony Chang.
2654
2655         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
2656
2657         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2658         (DeleteStaleBuildFiles): Added.
2659         (Factory.__init__): Add DeleteStaleBuildFiles step.
2660         * BuildSlaveSupport/delete-stale-build-files: Added.
2661         (main): Delete zero-byte files except ones intentionally generated by our build process.
2662         (webkitBuildDirectory): Copied from build-product-archive.
2663
2664 2013-01-04  Michael Pruett  <michael@68k.org>
2665
2666         [GTK] Fix build error on GTK due to r138836
2667         https://bugs.webkit.org/show_bug.cgi?id=106154
2668
2669         Reviewed by Kentaro Hara.
2670
2671         * GNUmakefile.am:
2672
2673 2013-01-04  Dan Bernstein  <mitz@apple.com>
2674
2675         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
2676         https://bugs.webkit.org/show_bug.cgi?id=106121
2677
2678         Reviewed by Adele Peterson.
2679
2680         Added test for -[DOMTHMLTableCellElement _cellAbove].
2681
2682         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2683         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
2684         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
2685         (TestWebKitAPI):
2686         (TestWebKitAPI::expectCellAboveCell):
2687         (TestWebKitAPI::TEST):
2688         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
2689
2690 2013-01-04  Eric Seidel  <eric@webkit.org>
2691
2692         FlakyTestReporter should be re-enabled and taught how to post patches
2693         https://bugs.webkit.org/show_bug.cgi?id=103839
2694
2695         Reviewed by Adam Barth.
2696
2697         This moves LayoutTestResultsReader off of the DeprecatedPort object.
2698         It also adds a real Port object to the EWS and CommitQueue objects
2699         using a new PatchProcessingQueue superclass.
2700         PatchProcessingQueue doesn't seem to be the cleanest insertion point
2701         but works for this purpose.
2702         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
2703         to resolve a FIXME.
2704
2705         This required some hacks/shiming between the non-specific "old"
2706         port names which the EWS system is currently using, and the new
2707         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
2708
2709         Hopefully this will fix the flaky test reporter and results uploading.
2710         Certainly it's another small step towards getting rid of the old ports.py
2711         infrastructure and making the NRWT Port class common webkitpy infrastructure.
2712
2713         Now that DeprecatedPort is no longer used for the results directory
2714         I removed all the explicit results-dir code which webkit-patch was using
2715         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
2716
2717         * Scripts/webkitpy/common/config/ports.py:
2718         (DeprecatedPort.run_perl_unittests_command):
2719         * Scripts/webkitpy/common/config/ports_mock.py:
2720         (MockPort.name):
2721         * Scripts/webkitpy/common/system/outputcapture.py:
2722         (OutputCapture.assert_outputs):
2723         * Scripts/webkitpy/layout_tests/port/apple.py:
2724         (ApplePort.determine_full_port_name):
2725         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2726         (LayoutTestResultsReader.__init__):
2727         (LayoutTestResultsReader):
2728         (LayoutTestResultsReader._read_file_contents):
2729         (LayoutTestResultsReader._create_layout_test_results):
2730         (LayoutTestResultsReader._create_unit_test_results):
2731         (LayoutTestResultsReader.results):
2732         (LayoutTestResultsReader.archive):
2733         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2734         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2735         (LayoutTestResultsReaderTest.test_create_unit_test_results):
2736         (test_missing_unit_test_results_path):
2737         (test_layout_test_results):
2738         (test_archive_last_layout_test_results):
2739         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2740         (AbstractEarlyWarningSystem):
2741         (AbstractEarlyWarningSystem.__init__):
2742         (AbstractEarlyWarningSystem.begin_work_queue):
2743         (AbstractEarlyWarningSystem.run_command):
2744         * Scripts/webkitpy/tool/commands/queues.py:
2745         (AbstractPatchQueue.work_item_log_path):
2746         (PatchProcessingQueue):
2747         (PatchProcessingQueue._new_port_name_from_old):
2748         (PatchProcessingQueue.begin_work_queue):
2749         (PatchProcessingQueue._upload_results_archive_for_patch):
2750         (CommitQueue):
2751         (CommitQueue.begin_work_queue):
2752         (CommitQueue.run_command):
2753         (AbstractReviewQueue):
2754         (AbstractReviewQueue.__init__):
2755         (AbstractReviewQueue.begin_work_queue):
2756         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2757         (AbstractPatchQueueTest.test_next_patch):
2758         (PatchProcessingQueueTest):
2759         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
2760         * Scripts/webkitpy/tool/steps/runtests.py:
2761         (RunTests.run):
2762         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2763
2764 2013-01-04  Dana Jansens  <danakj@chromium.org>
2765
2766         [chromium] Remove lost-compositor-context layout tests
2767         https://bugs.webkit.org/show_bug.cgi?id=106089
2768
2769         Reviewed by James Robinson.
2770
2771         Remove the loseCompositorContext() test function.
2772
2773         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2774         (WebTestRunner::TestRunner::TestRunner):
2775         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2776         (TestRunner):
2777
2778 2013-01-04  Adam Klein  <adamk@chromium.org>
2779
2780         Remove ENABLE_MUTATION_OBSERVERS #define
2781         https://bugs.webkit.org/show_bug.cgi?id=105459
2782
2783         Reviewed by Ryosuke Niwa.
2784
2785         * Scripts/webkitperl/FeatureList.pm:
2786         * qmake/mkspecs/features/features.pri:
2787
2788 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
2789
2790         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
2791         https://bugs.webkit.org/show_bug.cgi?id=106078
2792
2793         Reviewed by Tony Chang.
2794
2795         This patch updates values for individual iterations in dummy performance tests used in
2796         perftest_unittest.py and perftest_integrationtest.py so that they match up with
2797         statistics such as stdev and median reported in those tests. This change is required
2798         to resolve the bug 97510.
2799
2800         This patch also refactors integration tests by extracting *TestData classes that
2801         centralizes the definitions of each dummy performance test's text (DRT output),
2802         runner output, and parsed results (JSON) so that we may share more data between
2803         python tests.
2804
2805         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2806         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
2807         Use self.assertAlmostEqual when comparing the standard deviation.
2808         (MainTest.test_parse_output):
2809         (test_parse_output_with_failing_line):
2810         (test_parse_output_with_description): Use _assert_results_are_correct.
2811         (test_parse_output_with_subtests): Ditto.
2812
2813         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2814         (InspectorPassTestData): Extracted from tests below.
2815         (EventTargetWrapperTestData): Ditto.
2816         (SomeParserTestData): Ditto.
2817         (MemoryTestData): Ditto.
2818         (TestDriver.run_test): Moved test definitions out of the method.
2819         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
2820         (MainTest._load_output_json): Extracted from create_runner.
2821         (MainTest.create_runner):
2822         (MainTest.test_run_test_set_for_parser_tests):
2823         (MainTest.test_run_memory_test):
2824         (MainTest._test_run_with_json_output):
2825         (MainTest.test_run_with_json_output):
2826         (MainTest.test_run_with_description):
2827         (MainTest.test_run_generates_json_by_default):
2828         (MainTest.test_run_merges_output_by_default):
2829         (MainTest.test_run_respects_reset_results):
2830         (MainTest.test_run_generates_and_show_results_page):
2831         (MainTest.test_run_with_slave_config_json):
2832         (MainTest.test_run_with_multiple_repositories):
2833
2834 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
2835
2836         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
2837         https://bugs.webkit.org/show_bug.cgi?id=106045
2838
2839         Reviewed by Carlos Garcia Campos.
2840
2841         Update test results to confirm that compositions without preedits do not trigger
2842         a composition confirmation.
2843
2844         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2845         (TestWebKitAPI::verifyCanceledComposition):
2846
2847 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
2848
2849         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
2850         https://bugs.webkit.org/show_bug.cgi?id=105958
2851
2852         Reviewed by Alexey Proskuryakov.
2853
2854         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
2855
2856         * WebKitTestRunner/mac/EventSenderProxy.mm:
2857         (KeyMappingEntry):
2858         (WTR):
2859         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
2860
2861 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
2862
2863         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
2864         https://bugs.webkit.org/show_bug.cgi?id=106073
2865
2866         Reviewed by Ryosuke Niwa.
2867
2868         Check that the element being compared to is not nil. 
2869         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
2870         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
2871         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it 
2872         sometimes before on parallel WebKitTestRunner runs.
2873
2874         * DumpRenderTree/AccessibilityUIElement.cpp:
2875         (AccessibilityUIElement::isEqual):
2876         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2877         (WTR::AccessibilityUIElement::isEqual):
2878
2879 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
2880
2881         Downloads can be flaky, so try downloading multiple times.
2882         https://bugs.webkit.org/show_bug.cgi?id=105976
2883
2884         Reviewed by Eric Seidel.
2885
2886         * Scripts/webkitpy/common/system/autoinstall.py:
2887         (AutoInstaller._download_to_stream):
2888
2889 2013-01-03  Eric Seidel  <eric@webkit.org>
2890
2891         Rename Tool.port to deprecated_port in preparation for removing more callers
2892         https://bugs.webkit.org/show_bug.cgi?id=106076
2893
2894         Reviewed by Ryosuke Niwa.
2895
2896         This resolves a long-standing FIXME to rename this method. :)
2897
2898         * Scripts/webkitpy/tool/bot/botinfo.py:
2899         (BotInfo.summary_text):
2900         * Scripts/webkitpy/tool/bot/irc_command.py:
2901         (Rollout._update_working_copy):
2902         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2903         (LayoutTestResultsReader._create_layout_test_results):
2904         (LayoutTestResultsReader._create_unit_test_results):
2905         (LayoutTestResultsReader._results_directory):
2906         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2907         (test_missing_unit_test_results_path):
2908         * Scripts/webkitpy/tool/main.py:
2909         (WebKitPatch.deprecated_port):
2910         * Scripts/webkitpy/tool/mocktool.py:
2911         (MockTool.deprecated_port):
2912         * Scripts/webkitpy/tool/steps/build.py:
2913         (Build.build):
2914         * Scripts/webkitpy/tool/steps/checkstyle.py:
2915         (CheckStyle.run):
2916         * Scripts/webkitpy/tool/steps/commit.py:
2917         (Commit._check_test_expectations):
2918         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2919         (PrepareChangeLog.run):
2920         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
2921         (PrepareChangeLogForDEPSRoll.run):
2922         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2923         (PrepareChangeLogForRevert.run):
2924         * Scripts/webkitpy/tool/steps/runtests.py:
2925         (RunTests.run):
2926         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2927         (StepsTest.test_runtests_args):
2928         * Scripts/webkitpy/tool/steps/update.py:
2929         (Update._update_command):
2930
2931 2013-01-03  Eric Seidel  <eric@webkit.org>
2932
2933         Add myself to the webkitpy watchlist.
2934
2935         Unreviewed.
2936
2937         * Scripts/webkitpy/common/config/watchlist:
2938
2939 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
2940
2941         Cleanup perftest* tests and add a test for computing statistics
2942         https://bugs.webkit.org/show_bug.cgi?id=105685
2943
2944         Reviewed by Eric Seidel.
2945
2946         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
2947         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
2948
2949         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
2950
2951         * Scripts/webkitpy/performance_tests/perftest.py:
2952         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
2953         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
2954         accurate result for the mean.
2955         (PageLoadingPerfTest.run_single):
2956         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2957         (MainTest.test_compute_statistics):
2958         (MainTest.test_compute_statistics.compute_statistics): Added.
2959         (TestPageLoadingPerfTest.test_run): floatify values.
2960         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
2961         correctly recognizes them as integers.
2962
2963         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
2964         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
2965         (TestDriver): Moved out of MainTest.
2966         (MainTest): Got rid of assertWritten and all unit tests.
2967         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
2968         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2969         (MainTest.test_run_test_set_for_parser_tests):
2970         (MainTest.test_run_memory_test):
2971         (MainTest._test_run_with_json_output):
2972         (MainTest.test_run_generates_json_by_default):
2973         (MainTest.test_run_merges_output_by_default):
2974         (MainTest.test_run_respects_reset_results):
2975         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
2976         parsing output JSON files. Just verify that the output path is correct instead.
2977         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2978         (MainTest): Removed all integration tests.
2979         (MainTest.create_runner): Simplified.
2980
2981 2013-01-03  Julie Parent  <jparent@chromium.org>
2982
2983         Dashboard cleanup: remove usage of global g_defaultBuilderName
2984         https://bugs.webkit.org/show_bug.cgi?id=106043
2985
2986         Use now public defaultBuilder() from the BuilderGroup, rather
2987         than global variable.
2988
2989         Also eliminates the setup() and initBuilders() functions since we
2990         no longer need to track the global.
2991
2992         Reviewed by Adam Barth.
2993
2994         * TestResultServer/static-dashboards/builders.js:
2995         (BuilderGroup.prototype.defaultBuilder):
2996         (BuilderGroup.prototype.master):
2997         * TestResultServer/static-dashboards/dashboard_base.js:
2998         (parseParameters):
2999         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3000         (updateDefaultBuilderState):
3001         * TestResultServer/static-dashboards/loader.js:
3002         (.):
3003         * TestResultServer/static-dashboards/loader_unittests.js:
3004
3005 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3006
3007         Disable an intermittently failing unit test for now.
3008         The failure is tracked by the bug 106051.
3009
3010         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
3011         (TestWebKitAPI::TEST):
3012
3013 2013-01-03  Dan Bernstein  <mitz@apple.com>
3014
3015         No way to obtain a DOMNode given a JS wrapper for a Node
3016         https://bugs.webkit.org/show_bug.cgi?id=106033
3017
3018         Added a test for +[DOMNode _nodeFromJSWrapper:].
3019
3020         Reviewed by Sam Weinig.
3021
3022         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3023         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
3024         (TestWebKitAPI):
3025         (TestWebKitAPI::TEST):
3026
3027 2013-01-03  Emil A Eklund  <eae@chromium.org>
3028
3029         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
3030         https://bugs.webkit.org/show_bug.cgi?id=105961
3031
3032         Reviewed by Levi Weintraub.
3033         
3034         Add tests for LayoutUnit::ceil and floor.
3035
3036         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
3037         (TestWebKitAPI::TEST):
3038         (TestWebKitAPI):
3039
3040 2013-01-03  Julie Parent  <jparent@chromium.org>
3041
3042         Add unit test for default builder for the dashboards.
3043         https://bugs.webkit.org/show_bug.cgi?id=105972
3044
3045         Reviewed by Dirk Pranke.
3046
3047         * TestResultServer/static-dashboards/loader_unittests.js:
3048
3049 2013-01-03  Tony Chang  <tony@chromium.org>
3050
3051         Generate internal.settings from Settings.in
3052         https://bugs.webkit.org/show_bug.cgi?id=104740
3053
3054         Reviewed by Adam Barth.
3055
3056         * GNUmakefile.am: Compile new generated files on GTK+.
3057         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3058         with both extra_sources and add_output_to_sources=false will still
3059         compile the files in extra_sources. This makes it possible to compile
3060         InternalSettingsGenerated.cpp and not be confused by
3061         InternalSettingsGenerated.idl.
3062
3063 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
3064
3065         [style] WebIDL-reflecting uppercase enums reported as style violation
3066         https://bugs.webkit.org/show_bug.cgi?id=105832
3067
3068         Reviewed by Tony Chang.
3069
3070         Recognize the enum as WebIDL-reflecting one if there's a comment present that
3071         indicates this. In enums spanning over multiple lines, the comment is expected
3072         on the first line. In enums placed in one line, the comment is expected at the
3073         end of that line.
3074
3075         WebIDL-reflecting enum values are required to be written in uppercase and as such
3076         violate the common rule of these values being written in InterCaps. Annotating
3077         enums this way makes it possible to avoid false style violation reports.
3078
3079         The comment is of form '// Web(?:Kit)?IDL enum'.
3080
3081         * Scripts/webkitpy/style/checkers/cpp.py:
3082         (_EnumState.__init__):
3083         (_EnumState.process_clean_line):
3084         (check_enum_casing):
3085         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3086         (NoNonVirtualDestructorsTest.test_enum_casing):
3087
3088 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
3089
3090         Adding favicon.ico to the garden-o-matic.
3091         https://bugs.webkit.org/show_bug.cgi?id=105982
3092
3093         Reviewed by Adam Barth.
3094
3095         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
3097
3098 2013-01-03  Jonathan Liu  <net147@gmail.com>
3099
3100         [Qt] Fix library linking order
3101         https://bugs.webkit.org/show_bug.cgi?id=105818
3102
3103         Some Qt libraries are linked before the private static libraries
3104         that depend on them which results in QtWebKit failing to link.
3105
3106         Copy Qt module dependencies from QT to QT_PRIVATE when creating
3107         module to ensure the Qt libraries are linked after the private
3108         static libraries that depend on them.
3109
3110         Reviewed by Tor Arne Vestbø.
3111
3112         * qmake/mkspecs/features/default_post.prf:
3113
3114 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
3115
3116         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
3117         https://bugs.webkit.org/show_bug.cgi?id=102209
3118
3119         Reviewed by Gyuyoung Kim.
3120
3121         Set tooltip on the elm_window instead of ewk_view, and add delay to
3122         show the tooltip window.
3123
3124         Setting tooltip on the ewk_view makes elementary error message because
3125         ewk_view is not an elementary widget. To remove the error message,
3126         tooltip should be set on the elm_window.
3127
3128         Most browsers show the tooltip after a mouse pointer stays on an
3129         element object that has tooltip text.
3130         But elm_tooltip widget itself doesn't have delay or handle mouse
3131         events to show/hide.
3132
3133         So additional codes are added to show/hide tooltip widget along with
3134         mouse events.
3135           1) When a mouse pointer stays for a second on an element which has
3136              tooltip text, then tooltip widget is displayed.
3137           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
3138              widget.
3139
3140         * MiniBrowser/efl/main.c:
3141         (_Tooltip_Information):
3142         (_Browser_Window):
3143         (on_tooltip_show):
3144         (window_tooltip_hide):
3145         (window_tooltip_update):
3146         (on_mouse_in):
3147         (on_mouse_move):
3148         (on_mouse_out):
3149         (window_free):
3150         (on_tooltip_text_set):
3151         (on_tooltip_text_unset):
3152         (window_create):
3153
3154 2013-01-02  Tony Chang  <tony@chromium.org>
3155
3156         Unreviewed, rolling out r138661.
3157         http://trac.webkit.org/changeset/138661
3158         https://bugs.webkit.org/show_bug.cgi?id=104740
3159
3160         Compile problems on EFL
3161
3162         * GNUmakefile.am:
3163         * qmake/mkspecs/features/default_post.prf:
3164
3165 2013-01-02  Tony Chang  <tony@chromium.org>
3166
3167         Generate internal.settings from Settings.in
3168         https://bugs.webkit.org/show_bug.cgi?id=104740
3169
3170         Reviewed by Adam Barth.
3171
3172         * GNUmakefile.am: Compile new generated files on GTK+.
3173         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
3174         with both extra_sources and add_output_to_sources=false will still
3175         compile the files in extra_sources. This makes it possible to compile
3176         InternalSettingsGenerated.cpp and not be confused by
3177         InternalSettingsGenerated.idl.
3178
3179 2013-01-02  Adam Barth  <abarth@webkit.org>
3180
3181         Remove old-run-webkit-tests support from webkitpy
3182         https://bugs.webkit.org/show_bug.cgi?id=105619
3183
3184         Reviewed by Eric Seidel.
3185
3186         This patch removes support for webkitpy parsing the
3187         old-run-webkit-tests results format. There doesn't seem to be any
3188         reason to keep this code around anymore now that most bots have
3189         switched to new-run-webkit-tests.
3190
3191         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3192         (Builder.fetch_layout_test_results):
3193         * Scripts/webkitpy/common/net/layouttestresults.py:
3194         (path_for_layout_test):
3195         (LayoutTestResults.results_from_string):
3196         (LayoutTestResults):
3197         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3198         (LayoutTestResultsTest.test_results_from_string):
3199         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3200         (test_flaky_test_failure):
3201         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3202         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
3203         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3204         (PatchAnalysisTask._test_patch):
3205         * Scripts/webkitpy/tool/commands/queuestest.py:
3206         (QueuesTest.assert_queue_outputs):
3207
3208 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
3209
3210         [Qt][WK2] Add simple UI to find text from page
3211         https://bugs.webkit.org/show_bug.cgi?id=96481
3212
3213         Reviewed by Jocelyn Turcotte.
3214
3215         Find bar that slides between navigation bar and WebView.
3216
3217         * MiniBrowser/qt/BrowserWindow.cpp:
3218         (BrowserWindow::toggleFind):
3219         * MiniBrowser/qt/BrowserWindow.h:
3220         (BrowserWindow):
3221         * MiniBrowser/qt/MiniBrowser.qrc:
3222         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3223         (MiniBrowserApplication::notify):
3224         * MiniBrowser/qt/icons/find.png: Added.
3225         * MiniBrowser/qt/qml/BrowserWindow.qml:
3226
3227 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
3228
3229         Regression(r138603): Caused 2 webkitpy tests to fail
3230         https://bugs.webkit.org/show_bug.cgi?id=105913
3231
3232         Reviewed by Kentaro Hara.
3233
3234         Fix 2 webkitpy tests that started to fail after
3235         r138603.
3236
3237         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3238         (IRCCommandTest._sheriff_test_data_url): Make sure the
3239         returned test file URL is valid no matter what the
3240         current working directory is.
3241         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3242         (IRCBotTest.test_help): Add "sheriffs" command to the
3243         list of available commands.
3244
3245 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
3246
3247         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
3248         https://bugs.webkit.org/show_bug.cgi?id=105897
3249
3250         Reviewed by Alexey Proskuryakov.
3251
3252         Dump in WebKitTestRunner the message that is expected by layout tests
3253         when the missing plugin button is clicked.
3254
3255         * WebKitTestRunner/TestController.cpp:
3256         (WTR::TestController::createWebViewWithOptions):
3257         (WTR::TestController::unavailablePluginButtonClicked):
3258         (WTR):
3259         * WebKitTestRunner/TestController.h:
3260         (TestController):
3261
3262 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
3263
3264         [EFL] Enable MHTML feature
3265         https://bugs.webkit.org/show_bug.cgi?id=105815
3266
3267         Reviewed by Laszlo Gombos.
3268
3269         Enable MHTML feature for EFL port by default.
3270
3271         * Scripts/webkitperl/FeatureList.pm:
3272
3273 2013-01-01  Alan Cutter  <alancutter@chromium.org>
3274
3275         sheriff-bot should know who the gardeners/sheriffs are
3276         https://bugs.webkit.org/show_bug.cgi?id=105698
3277
3278         Reviewed by Eric Seidel.
3279
3280         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
3281
3282         * Scripts/webkitpy/tool/bot/irc_command.py:
3283         (Current):
3284         (Current._retrieve_webkit_sheriffs):
3285         (Current.execute):
3286         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3287         (IRCCommandTest.test_current):
3288         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
3289         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
3290         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
3291         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
3292         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
3293
3294 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3295
3296         [GTK] Move ImageDiff to the Tools directory root
3297         https://bugs.webkit.org/show_bug.cgi?id=105421
3298
3299         Reviewed by Kenneth Rohde Christiansen.
3300
3301         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
3302         * GNUmakefile.am:
3303         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
3304
3305 2012-12-30  Mike West  <mkwst@chromium.org>
3306
3307         Add myself to watchlists for CSP and console logs.
3308         https://bugs.webkit.org/show_bug.cgi?id=105874
3309
3310         Reviewed by Dirk Pranke.
3311
3312         Because I really, really, really need more email.
3313
3314         * Scripts/webkitpy/common/config/committers.py:
3315             Add mkwst+watchlist@chromium.org as a contributor.
3316         * Scripts/webkitpy/common/config/watchlist:
3317             Create watchlist categories for 1) the various mechanisms used to
3318             generate console messages, and 2) CSP usage and files.
3319
3320 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3321
3322         [EFL] Enable TEMPLATE_ELEMENT feature
3323         https://bugs.webkit.org/show_bug.cgi?id=105865
3324         
3325         Reviewed by Laszlo Gombos.
3326
3327         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
3328
3329 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
3330
3331         Unreviewed GTK gardening of the unit tests.
3332
3333         Skip the TestInspectorServer unit test that's timing out completely.
3334
3335         * Scripts/run-gtk-tests:
3336         (TestRunner):
3337
3338 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3339
3340         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
3341         https://bugs.webkit.org/show_bug.cgi?id=105855
3342
3343         Reviewed by Vsevolod Vlasov.
3344
3345         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
3346         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
3347
3348         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3349         (ReportMemoryUsageVisitor):
3350         (clang::AddMemberCallVisitor::VisitCallExpr):
3351         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3352         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
3353
3354 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
3355
3356         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
3357         https://bugs.webkit.org/show_bug.cgi?id=105852
3358
3359         Reviewed by Alexander Pavlov.
3360
3361         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3362         (clang):
3363         (AddMemberCallVisitor):
3364         (ReportMemoryUsageVisitor):
3365         (clang::ReportMemoryUsageAction::ParseArgs):
3366         (clang::AddMemberCallVisitor::VisitCallExpr):
3367         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
3368         (clang::ReportMemoryUsageVisitor::emitWarning):
3369         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
3370         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
3371         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
3372
3373 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
3374
3375         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
3376         https://bugs.webkit.org/show_bug.cgi?id=105835
3377
3378         Reviewed by Dirk Pranke.
3379
3380         The BeautifulSoup module is a third-party import and as such we don't have much control
3381         over its testing. Because of that it should be omitted from code coverage checking.
3382
3383         * Scripts/webkitpy/test/main.py:
3384         (Tester._run_tests):
3385
3386 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
3387
3388         [GTK][WK2] Add support for IME Composition
3389         https://bugs.webkit.org/show_bug.cgi?id=65093
3390
3391         Reviewed by Carlos Garcia Campos.
3392
3393         Update unit tests for GtkInputMethodFilter to note whether or not an event
3394         was a fake event synthesized for composition purposes. This is now used
3395         for WebKit2.
3396
3397         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
3398         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
3399         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
3400         (TestWebKitAPI::TEST):
3401         * gtk/generate-gtkdoc:
3402         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
3403         generation.
3404
3405 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
3406
3407         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
3408         https://bugs.webkit.org/show_bug.cgi?id=105800
3409
3410         Reviewed by Yury Semikhatsky.
3411
3412         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
3413         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
3414         (clang):
3415
3416 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
3417
3418         Create a GTK build system watchlist and add myself to it
3419         https://bugs.webkit.org/show_bug.cgi?id=105769
3420
3421         Reviewed by Dirk Pranke.
3422
3423         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
3424         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
3425         omitted on purpose due to relatively high change rate they are exposed to.
3426
3427         The new watchlist would be of use to me as the GTK build system recently went
3428         through a series of changes that included a changed policy on adding configuration
3429         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
3430         mailing list about this change will be published later, but I'd also like to be
3431         notified of any pending changes to these files just so I can check the changes are
3432         in compliance with the new policy.
3433
3434         * Scripts/webkitpy/common/config/watchlist:
3435
3436 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
3437
3438         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
3439         As example ..../DevTools/src/third_party/WebKit
3440
3441         * Scripts/webkitpy/common/webkit_finder.py:
3442         (WebKitFinder.webkit_base):
3443
3444 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
3445
3446         [EFL][WK2] Refactor snapshot taking code
3447         https://bugs.webkit.org/show_bug.cgi?id=105687
3448
3449         Reviewed by Kenneth Rohde Christiansen.
3450
3451         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
3452         since the function was renamed to follow naming style.
3453
3454         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3455         (WTR::PlatformWebView::windowSnapshotImage):
3456
3457 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
3458
3459         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
3460         https://bugs.webkit.org/show_bug.cgi?id=105725
3461
3462         Reviewed by Yury Semikhatsky.
3463
3464         MemberType value names were adjusted according to Style Guide.
3465         Existing tests were extended with link type validation.
3466
3467         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3468
3469 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
3470
3471         [BlackBerry] DRT - Crashed when running pixels tests
3472         https://bugs.webkit.org/show_bug.cgi?id=105711
3473
3474         RIM PR 270003
3475
3476         Reviewed by George Staikos.
3477
3478         Calling window->post() here will result in buffer swapping which is
3479         only allowed in UI thread now, and I found we don't need to call it
3480         for GL renderer.
3481
3482         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
3483         (createBitmapContextFromWebView):
3484
3485 2012-12-22  Dan Winship  <danw@gnome.org>
3486
3487         Add a patch to fix libxml2 2.9.0 regression
3488         https://bugs.webkit.org/show_bug.cgi?id=104494
3489
3490         Reviewed by Martin Robinson.
3491
3492         * gtk/jhbuild.modules:
3493         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
3494
3495 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3496
3497         Unreviewed update of status to reviewer.
3498
3499         * Scripts/webkitpy/common/config/committers.py:
3500
3501 2012-12-23  Philippe Normand  <pnormand@igalia.com>
3502
3503         [GTK][jhbuild] Bump GStreamer to 1.0.4
3504         https://bugs.webkit.org/show_bug.cgi?id=105640
3505
3506         Reviewed by Martin Robinson.
3507
3508         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
3509
3510 2012-12-21  Nico Weber  <thakis@chromium.org>
3511
3512         chromium: webkit-build-directory doesn't handle ninja output dirs
3513         https://bugs.webkit.org/show_bug.cgi?id=105671
3514
3515         Reviewed by Daniel Bates.
3516
3517         Teach webkit-build-directory to detect the ninja build directory.
3518
3519         * Scripts/webkitdirs.pm:
3520         (determineBaseProductDir):
3521         (determineIsChromiumNinja):
3522
3523 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
3524
3525         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
3526         https://bugs.webkit.org/show_bug.cgi?id=95477
3527
3528         Reviewed by Sam Weinig.
3529
3530         Co-authored by Jia Pu.
3531
3532         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
3533         we can have consistent autocorrection behavior when running tests.
3534
3535         * DumpRenderTree/mac/DumpRenderTree.mm:
3536         (resetDefaultsToConsistentValues):
3537         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3538         (WTR::InjectedBundle::platformInitialize):
3539
3540 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
3541
3542         [GTK] Add WebKit1-specific TestExpectations file
3543         https://bugs.webkit.org/show_bug.cgi?id=97562
3544
3545         Reviewed by Dirk Pranke.
3546
3547         Implement the expectations_files method inside the GtkPort class that
3548         returns the list of the TestExpectations files the current test configuration
3549         requires. The method is implemented in a similar way as on the EFL port.
3550         A unit test is also added.
3551
3552         * Scripts/webkitpy/layout_tests/port/gtk.py:
3553         (GtkPort._search_paths):
3554         (GtkPort):
3555         (GtkPort.expectations_files):
3556         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3557         (GtkPortTest.test_expectations_files):
3558
3559 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3560
3561         [EFL] Enable feature option for the CSS sticky position
3562         https://bugs.webkit.org/show_bug.cgi?id=105630
3563
3564         Reviewed by Kenneth Rohde Christiansen.
3565
3566         Enable CSS sticky position feature by default for the
3567         EFL port. This feature option was added in r138252.
3568
3569         No new tests. Existing layout tests pass.
3570
3571         * Scripts/webkitperl/FeatureList.pm:
3572
3573 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
3574
3575         [WK2] REGRESSION(r138232): It made 4 tests timeout
3576         https://bugs.webkit.org/show_bug.cgi?id=105623
3577
3578         Reviewed by Kenneth Rohde Christiansen.
3579
3580         r138232 changed functionality so that empty text output
3581         no longer leads to a dump() call, which leads to a timeout.
3582         Instead do a text dump if there is text output or if there
3583         is no audio output.
3584
3585         * WebKitTestRunner/TestInvocation.cpp:
3586         (WTR::TestInvocation::dumpResults):
3587
3588 2012-12-21  Zeno Albisser  <zeno@webkit.org>
3589
3590         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
3591         https://bugs.webkit.org/show_bug.cgi?id=105309
3592
3593         On Windows the library name is Qt5WebKitWidgets as well.
3594         So r138136 should not have adjusted the library name for Windows.
3595
3596         Reviewed by Simon Hausmann.
3597
3598         * Scripts/webkitdirs.pm:
3599         (builtDylibPathForName):
3600
3601 2012-12-21  Zeno Albisser  <zeno@webkit.org>
3602
3603         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
3604         https://bugs.webkit.org/show_bug.cgi?id=105424
3605
3606         This change will allow us to run a very specific
3607         subset of the available LayoutTests on a mac buildbot.
3608         The new baseline search path for mac will look as follows:
3609         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
3610
3611         Reviewed by Dirk Pranke.
3612
3613         * Scripts/webkitpy/layout_tests/port/qt.py:
3614         (QtPort._search_paths):
3615         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3616         (QtPortTest):
3617
3618 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3619
3620         [EFL] Build break with latest EFL libraries.
3621         https://bugs.webkit.org/show_bug.cgi?id=104827
3622
3623         Reviewed by Laszlo Gombos.
3624
3625         The eo EFL package is introduced and evas and ecore use it since 1.8.
3626         While introducing Eo, EFL changed several structures of Evas and Ecore
3627         from own specific class to Eo.
3628
3629         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
3630         Ecore_Timer to build with latest EFL libraries.
3631
3632         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
3633         * EWebLauncher/CMakeLists.txt: Ditto.
3634         * MiniBrowser/efl/CMakeLists.txt: Ditto.
3635         * ImageDiff/PlatformEfl.cmake: Ditto.
3636         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
3637         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
3638         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
3639         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
3640         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
3641
3642 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
3643
3644         TestExpectation fallback is broken
3645         https://bugs.webkit.org/show_bug.cgi?id=105583
3646
3647         Reviewed by Ryosuke Niwa.
3648
3649         When I added support for the -wk2 in port names, it looks
3650         like I broke the way we computed the list of TestExpectations
3651         files so that the implementation-version directory was left out :(.
3652         Fixed and cleaned up the tests.
3653
3654         * Scripts/webkitpy/layout_tests/port/base.py:
3655         (Port.expectations_files):
3656         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3657         (TestWebKitPort.__init__):
3658         (PortTestCase.test_skipped_directories_for_symbols):
3659         (test_skipped_directories_for_features):
3660         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
3661         (test_skipped_tests_for_unsupported_features_empty_test_list):
3662         (test_skipped_layout_tests):
3663         (test_expectations_files):
3664
3665 2012-12-20  Anders Carlsson  <andersca@apple.com>
3666
3667         Don't include WebKit2 headers when building TestWebKitAPI on windows
3668         https://bugs.webkit.org/show_bug.cgi?id=105582
3669
3670         Reviewed by Tim Horton.
3671
3672         * TestWebKitAPI/config.h:
3673         * TestWebKitAPI/win/main.cpp:
3674
3675 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
3676
3677         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
3678         https://bugs.webkit.org/show_bug.cgi?id=105370
3679
3680         Reviewed by Simon Fraser.
3681
3682         Re-enable the test.
3683
3684         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
3685         (TestWebKitAPI::TEST):
3686
3687 2012-12-20  Nico Weber  <thakis@chromium.org>
3688
3689         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
3690         https://bugs.webkit.org/show_bug.cgi?id=105498
3691
3692         Reviewed by Dirk Pranke.
3693
3694         Use the newest binary available rather than an than always picking one
3695         build directory over another based on iteration order.
3696
3697         * Scripts/webkitpy/layout_tests/port/chromium.py:
3698         (ChromiumPort._static_build_path):
3699         Check for timestamps.
3700         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3701         (ChromiumMacPortTest.test_build_path_timestamps):
3702         Test that out / xcodebuild selection happens based on timestamps
3703         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3704         (ChromiumWinPortTest.test_build_path_timestamps):
3705         Test that out / build selection happens based on timestamps
3706
3707 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
3708
3709         Lots of sticky tests failing in WK2
3710         https://bugs.webkit.org/show_bug.cgi?id=105464
3711
3712         Reviewed by Beth Dakin.
3713
3714         WebKitTestRunner had a race between snapshotting in the UI process,
3715         and resettting after the test in the web process. InjectedBundle::done()
3716         was a bad place to call page()->resetAfterTest(), because of this race;
3717         it could reset the scroll position before the UI snapshot had been obtained.
3718         
3719         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
3720         for the "Reset" message which will come in before the next test.
3721
3722         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3723         (WTR::InjectedBundle::didReceiveMessage):
3724         (WTR::InjectedBundle::done):
3725
3726 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
3727
3728         DFG speculation checks that take JumpList should consolidate OSRExits
3729         https://bugs.webkit.org/show_bug.cgi?id=105401
3730
3731         Reviewed by Oliver Hunt.
3732
3733         Update the profiler to understand that an OSR exit may have multiple
3734         candidate exit sites.
3735
3736         * Scripts/display-profiler-output:
3737
3738 2012-12-20  Eric Seidel  <eric@webkit.org>
3739
3740         EWSes do not need to dump build/test logs when things pass
3741         https://bugs.webkit.org/show_bug.cgi?id=105402
3742
3743         Reviewed by Dirk Pranke.
3744
3745         When we were first writing the commit-queue and EWS system
3746         and running them locally, we thought it was important to see the
3747         build/test output as it happened.  Now these queues have been running
3748         for years, and we don't use this feature anymore.  So this patch
3749         makes us stop tee-ing the output directly to stdout, and instead
3750         only print any output from commands when they fail.
3751
3752         I also added some logging when we execute each command
3753         since we are no longer printing the command output itself.
3754         This should make it much easier to see errors with the EWS
3755         system itself, now that all the passing-build output is removed.
3756
3757         This required updating a zillion unittests, since we have a bunch of
3758         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
3759         already approximating this behavior by using a "logging" Executive.
3760         I disabled logging in those cases to avoid redundant logging in those tests.
3761
3762         * Scripts/webkitpy/common/system/executive.py:
3763         (Executive.command_for_printing):
3764         (Executive.run_command):
3765         * Scripts/webkitpy/common/system/executive_mock.py:
3766         (MockExecutive.command_for_printing):
3767         (MockExecutive.run_command):
3768         * Scripts/webkitpy/common/system/executive_unittest.py:
3769         (ExecutiveTest.test_auto_stringify_args):
3770         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3771         (EarlyWarningSytemTest._default_expected_logs):
3772         (_test_ews):
3773         (_test_ewses):
3774         * Scripts/webkitpy/tool/commands/queues.py:
3775         (AbstractQueue.run_webkit_patch):
3776         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3777         (AbstractQueueTest._assert_run_webkit_patch):
3778         (CommitQueueTest.test_commit_queue):
3779         (test_rollout):
3780         (test_rollout_lands):
3781         (test_manual_reject_during_processing):
3782         (StyleQueueTest.test_style_queue_with_style_exception):
3783         (test_style_queue_with_watch_list_exception):
3784
3785 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
3786
3787         AX: support clickPoint in DRT for chromium
3788         https://bugs.webkit.org/show_bug.cgi?id=97359
3789
3790         Reviewed by Chris Fleizach.
3791
3792         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
3793         several more tests can pass.
3794
3795         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
3796         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
3797         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
3798         (WebTestRunner):
3799         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
3800         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
3801         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
3802         (AccessibilityUIElement):
3803
3804 2012-12-20  Dan Bernstein  <mitz@apple.com>
3805
3806         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
3807         https://bugs.webkit.org/show_bug.cgi?id=99268
3808
3809         Reviewed by Alexey Proskuryakov.
3810
3811         * Scripts/prepare-ChangeLog:
3812         (generateNewChangeLogs): Removed the "Additional information of the change" line.
3813
3814 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3815
3816         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
3817
3818         * Scripts/run-gtk-tests:
3819         (TestRunner):
3820
3821 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3822
3823         [Qt] Move ImageDiff to the Tools directory root
3824         https://bugs.webkit.org/show_bug.cgi?id=105420
3825
3826         Reviewed by Tor Arne Vestbø.
3827
3828         Moved ImageDiff from outside DumpRenderTree because it is also a
3829         dependency when running pixel tests for WebKit2.
3830
3831         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
3832         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
3833         * Tools.pro:
3834
3835 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
3836
3837         [GTK] Remove the --enable-unstable-features configuration option
3838         https://bugs.webkit.org/show_bug.cgi?id=105327
3839
3840         Reviewed by Martin Robinson.
3841
3842         Add a missing feature option for the CSS sticky position feature.
3843
3844         * Scripts/webkitperl/FeatureList.pm:
3845
3846 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
3847
3848         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
3849
3850         * Scripts/run-gtk-tests:
3851         (TestRunner):
3852
3853 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
3854
3855         [EFL] MiniBrowser does not play Infinite Gangnam Style
3856         https://bugs.webkit.org/show_bug.cgi?id=103531
3857
3858         Reviewed by Kenneth Rohde Christiansen.
3859
3860         For EFL we would like this feature to be built by default.
3861
3862         * Scripts/webkitperl/FeatureList.pm:
3863
3864 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
3865
3866         [Qt] EWS bots should call qmake always
3867         https://bugs.webkit.org/show_bug.cgi?id=90049
3868
3869         Reviewed by Simon Hausmann.
3870
3871         * Scripts/webkitdirs.pm:
3872         (buildQMakeProjects):
3873
3874 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
3875
3876         [chromium] fix stray printf in TestRunner's WebTestProxy
3877         https://bugs.webkit.org/show_bug.cgi?id=105515
3878
3879         Reviewed by Ryosuke Niwa.
3880
3881         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3882         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3883
3884 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
3885
3886         [WK2] WebAudio WKTR support
3887         https://bugs.webkit.org/show_bug.cgi?id=95084
3888
3889         Reviewed by Kenneth Rohde Christiansen.
3890
3891         Implementing audio data dump support for WebKitTestRunner,
3892         by adding the API to the IDL, enabling IPC for transferring
3893         the audio data as bytebuffer and dumping it according
3894         to run-webkit-tests script's expectations.
3895         This enables audio testing on WebKit2 ports.
3896         Based on initial wip-patch from Philippe Normand - thanks.
3897
3898         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
3899         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
3900         (WTR::TestRunner::setAudioData):
3901         (WTR):
3902         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
3903         (TestRunner):
3904         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
3905         (WTR::InjectedBundle::done):
3906         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
3907         (WTR::InjectedBundle::setAudioResult):
3908         (InjectedBundle):
3909         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3910         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
3911         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
3912         (WTR::TestInvocation::dumpResults):
3913         (WTR):
3914         (WTR::TestInvocation::dumpAudio):
3915         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
3916         * WebKitTestRunner/TestInvocation.h:
3917         (TestInvocation):
3918
3919 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
3920
3921         [GTK] Count failed and timed out tests separately
3922         https://bugs.webkit.org/show_bug.cgi?id=105448
3923
3924         Reviewed by Carlos Garcia Campos.
3925
3926         Display the number of tests that fail, time out and are skipped
3927         separately in the buildbot page.
3928
3929         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3930         (RunGtkAPITests.commandComplete):
3931         (RunGtkAPITests.evaluateCommand):
3932         (RunGtkAPITests.getText2):
3933         * Scripts/run-gtk-tests:
3934         (TestRunner.run_tests):
3935
3936 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
3937
3938         PerfTest.parse_output does too much
3939         https://bugs.webkit.org/show_bug.cgi?id=105391
3940
3941         Reviewed by Tony Chang.
3942
3943         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
3944         Also moved the code to output test results into PerfTest._run_with_driver.
3945
3946         * Scripts/webkitpy/performance_tests/perftest.py:
3947         (PerfTest.__init__): Added _description.
3948         (PerfTest.description): Added.
3949         (PerfTest._run_with_driver): Moved the code to output test description and test results.
3950         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
3951         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
3952         respectively. Also removed the code that allowed some tests to omit values since all tests report each
3953         iteration now since r136492.
3954         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
3955         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
3956         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
3957         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
3958         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
3959         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
3960         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3961         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
3962         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
3963         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
3964         so that it's not string-concatenated with the next line.
3965         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
3966         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
3967
3968 2012-12-19  Alexis Menard  <alexis@webkit.org>
3969
3970         Implement CSS parsing for CSS transitions unprefixed.
3971         https://bugs.webkit.org/show_bug.cgi?id=104804
3972
3973         Reviewed by Dean Jackson.
3974
3975         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
3976         to cover the work of unprefixing Transforms, Animations and 
3977         Transitions. It will let the possibility of each ports to turn it off 
3978         in their release branches until we're confident that these CSS 
3979         properties are ready to be unprefixed.
3980
3981         * Scripts/webkitperl/FeatureList.pm:
3982         * qmake/mkspecs/features/features.pri:
3983
3984 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
3985
3986         2 clampTo unit tests are failing
3987         https://bugs.webkit.org/show_bug.cgi?id=105253
3988
3989         Reviewed by Emil A Eklund.
3990
3991         Removed clampToUnsigned as it was actually testing exactly what
3992         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
3993         to precision loss (fix suggested by Emil).
3994
3995         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3996
3997 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3998
3999         [EFL] Move ImageDiff to the Tools directory root
4000         https://bugs.webkit.org/show_bug.cgi?id=105305
4001
4002         Reviewed by Laszlo Gombos.
4003
4004         We previously moved this directory from the DRT directory to
4005         efl/ImageDiff. The major reason for doing so was because ImageDiff does
4006         not depend on DumpRenderTree but for legacy reasons was living inside the
4007         DRT folder, even though it is needed when running pixel tests for WK2.
4008
4009         Now we are moving to Tool directory root as other ports agreed to do the same.
4010
4011         * CMakeLists.txt:
4012         * ImageDiff/CMakeLists.txt: Added.
4013         * ImageDiff/PlatformEfl.cmake: Added.
4014         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
4015         * efl/ImageDiff/CMakeLists.txt: Removed.
4016
4017 2012-12-19  Zeno Albisser  <zeno@webkit.org>
4018
4019         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
4020         https://bugs.webkit.org/show_bug.cgi?id=105309
4021
4022         The version number is only used as a part
4023         of the library name on Linux.
4024
4025         Reviewed by Kenneth Rohde Christiansen.
4026
4027         * Scripts/webkitdirs.pm:
4028         (builtDylibPathForName):
4029
4030 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
4031
4032         [GTK] Tests that time out are not considered as failures.
4033         https://bugs.webkit.org/show_bug.cgi?id=105318
4034
4035         Reviewed by Martin Robinson.
4036
4037         Fix parsing of the GTK API tests log files.
4038
4039         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4040         (RunGtkAPITests.commandComplete):
4041
4042 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
4043
4044         Unreviewed, rolling out r138061.
4045         https://bugs.webkit.org/show_bug.cgi?id=105396
4046
4047         Original patch:
4048         http://trac.webkit.org/changeset/138061
4049         https://bugs.webkit.org/show_bug.cgi?id=97359
4050
4051         It is crashing on Debug bots
4052
4053         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
4054         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
4055         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
4056         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
4057         (AccessibilityUIElement):
4058
4059 2012-12-18  Alice Liu  <alice.liu@apple.com>
4060
4061         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
4062         Add SPI to WebKit1 WebFrame for hit testing
4063
4064         Reviewed by Dan Bernstein.
4065
4066         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
4067         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
4068         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
4069         Then hit-tests at three points, expecting to hit the two divs and body element. 
4070
4071 2012-12-18  Alice Liu  <alice.liu@apple.com>
4072
4073         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
4074         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
4075
4076         Reviewed by Anders Carlsson.
4077
4078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
4079         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
4080         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
4081         Loads html with a single div element. In an isolated world, creates a property on that node.
4082         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
4083             - Existence of the isolated property in the isolated world.
4084             - Existence of the standard property in the standard world.
4085             - Non-existence of the isolated property in the standard world.
4086             - Non-existence of the standard property in the isolated world.
4087
4088 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
4089
4090         Disable the SimplifyMarkup API test, wich asserts in debug builds.
4091         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
4092         
4093         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
4094         (TestWebKitAPI::TEST):
4095
4096 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
4097
4098         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
4099         https://bugs.webkit.org/show_bug.cgi?id=104279
4100
4101         Reviewed by David Kilzer.
4102
4103         Add a build phase script that checks a framework's header files for
4104         Platform.h and Compiler.h macros. Also add some tests for the script.
4105
4106         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
4107         Script to be used in build phases to check for inappropriate macros in headers.
4108
4109         * Scripts/test-webkitruby: Added.
4110         Script that can be used to run all webkitruby tests.
4111
4112         * Scripts/test-webkit-scripts:
4113         Also run the ruby tests.
4114
4115         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
4116         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
4117         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
4118         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
4119         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
4120         Tests for the new script.
4121
4122 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
4123
4124         AX: support clickPoint in DRT for chromium
4125         https://bugs.webkit.org/show_bug.cgi?id=97359
4126
4127         Reviewed by Chris Fleizach.
4128
4129         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
4130         several more tests can pass.
4131
4132         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
4133         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
4134         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
4135         (WebTestRunner):
4136         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
4137         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
4138         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
4139         (AccessibilityUIElement):
4140
4141 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
4142
4143         Build fix after r138045.
4144
4145         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4146         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
4147         is not explicitly specified. The condition was backwards but never matched so we
4148         always ran the test regardless of whether it's listed in the skipped list or not.
4149         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4150         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
4151
4152 2012-12-18  Emil A Eklund  <eae@chromium.org>
4153
4154         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
4155         https://bugs.webkit.org/show_bug.cgi?id=105332
4156         
4157         Reviewed by Levi Weintraub.
4158         
4159         Create new test suite for LayoutUnit tests as the KURL tests are
4160         of the incompatible TEST_F type.
4161
4162         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
4163         (TestWebKitAPI):
4164         (TestWebKitAPI::TEST_F):
4165
4166 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
4167
4168         Running a skipped test with run-perf-tests could alert the user
4169         https://bugs.webkit.org/show_bug.cgi?id=105219
4170
4171         Reviewed by Eric Seidel.
4172
4173         Force run skipped performance tests explicitly specified in the command line.
4174         Also warn the user when the specified paths don't exist.
4175
4176         * Scripts/webkitpy/layout_tests/port/base.py:
4177         (Port.relative_test_filename):
4178         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4179         (PerfTestsRunner._parse_args):
4180         (PerfTestsRunner._collect_tests):
4181         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4182         (test_collect_tests_with_skipped_list_and_files):
4183
4184 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
4185
4186         Chrome Android java output is too verbose
4187         https://bugs.webkit.org/show_bug.cgi?id=105247
4188
4189         Reviewed by Tony Chang.
4190
4191         Pass -quiet to ant to suppress extraneous output.
4192
4193         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4194         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
4195
4196 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
4197
4198         Consider removing --pause-before-testing option
4199         https://bugs.webkit.org/show_bug.cgi?id=105248
4200
4201         Reviewed by Eric Seidel.
4202
4203         Remove --pause-before-testing option.
4204
4205         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
4206         (DriverProxy.start): Removed.
4207         * Scripts/webkitpy/performance_tests/perftest.py:
4208         (PerfTest.__init__):
4209         (PerfTest.test_path): Renamed from path_or_url.
4210         (PerfTest.run):
4211         (PerfTest): Removed "driver" argument.
4212         (PerfTest._run_with_driver):
4213         (PerfTest.run_single):
4214         (ChromiumStylePerfTest.__init__):
4215         (PageLoadingPerfTest.__init__):
4216         (PageLoadingPerfTest.run_single):
4217         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
4218         (ReplayPerfTest.__init__):
4219         (ReplayPerfTest.prepare):
4220         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
4221         (TestPageLoadingPerfTest.test_run):
4222         (TestPageLoadingPerfTest.test_run_with_memory_output):
4223         (TestPageLoadingPerfTest.test_run_with_bad_output):
4224         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4225         (PerfTestsRunner._parse_args):
4226         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
4227         (PerfTestsRunner._run_single_test): Removed "driver" argument.
4228         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4229         (run_test):
4230         (test_run_test_pause_before_testing): Removed.
4231
4232 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
4233
4234         [GTK] Tests that time out are not considered as failures.
4235         https://bugs.webkit.org/show_bug.cgi?id=105318
4236
4237         Reviewed by Martin Robinson.
4238
4239         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4240         (RunGtkAPITests.commandComplete):
4241         Consider log lines that end with TIMEOUT as errors.
4242
4243         * Scripts/run-gtk-tests:
4244         (TestRunner.run_tests):
4245         Consider timeouts as failures when returning the number of failed
4246         tests.
4247
4248 2012-12-18  Pravin D  <pravin.d@samsung.com>
4249
4250         Unreviewed, adding secondary email.
4251
4252         * Scripts/webkitpy/common/config/committers.py:
4253
4254 2012-12-18  Pravin D  <pravin.d@samsung.com>
4255
4256         Unreviewed, promoting myself to committer's list.
4257
4258         * Scripts/webkitpy/common/config/committers.py:
4259
4260 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4261
4262         [EFL] ImageDiff does not build on WebKit2 only builds
4263         https://bugs.webkit.org/show_bug.cgi?id=105288
4264
4265         Reviewed by Kenneth Rohde Christiansen.
4266
4267         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
4268         the folder with things which are EFL-specific.
4269
4270         ImageDiff will be built by default now regardless of WebKit API flavor
4271         you choose.
4272
4273         * CMakeLists.txt:
4274         * DumpRenderTree/efl/CMakeLists.txt:
4275         * efl/ImageDiff/CMakeLists.txt: Added.
4276         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
4277
4278 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4279
4280         [EFL][WK2] When creating new windows, use the opener's context
4281         https://bugs.webkit.org/show_bug.cgi?id=105283
4282
4283         Reviewed by Laszlo Gombos.
4284
4285         Use the context of the opener if exists.
4286
4287         * MiniBrowser/efl/main.c:
4288         (on_key_down):
4289         (on_window_create):
4290         (window_create):
4291         (elm_main):
4292
4293 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4294
4295