Migrate update-webkit for Windows to not require Cygwin
[WebKit-https.git] / Tools / ChangeLog
1 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         Migrate update-webkit for Windows to not require Cygwin
4         https://bugs.webkit.org/show_bug.cgi?id=143040
5
6         Reviewed by Brent Fulgham.
7
8         * Scripts/update-webkit-dependency:
9         (wanted):
10         (toUnixPath): Deleted.
11         * Scripts/webkitdirs.pm:
12         (fontExists):
13         (checkInstalledTools):
14         (setupAppleWinEnv):
15
16 2015-03-25  Sam Weinig  <sam@webkit.org>
17
18         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
19         https://bugs.webkit.org/show_bug.cgi?id=143059
20
21         Reviewed by Alex Christensen.
22
23         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
24         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
25         Update for new interface of compileRuleList().
26
27 2015-03-25  Alex Christensen  <achristensen@webkit.org>
28
29         [Content Extensions] Add multi-DFA compiling and interpreting.
30         https://bugs.webkit.org/show_bug.cgi?id=143010
31
32         Reviewed by Benjamin Poulain.
33
34         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
35         (TestWebKitAPI::testRequest):
36         (TestWebKitAPI::TEST_F):
37         Add some tests for ignore-previous-rules and large rulesets.
38
39 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
40
41         Mavericks WK1 still runs JSC tests
42         https://bugs.webkit.org/show_bug.cgi?id=143035
43
44         Reviewed by Csaba Osztrogonác.
45
46         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
47         with other bots.
48
49         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
50         accordingly.
51
52 2015-03-25  Commit Queue  <commit-queue@webkit.org>
53
54         Unreviewed, rolling out r181932.
55         https://bugs.webkit.org/show_bug.cgi?id=143041
56
57         The test fails most of the time on bots (Requested by ap on
58         #webkit).
59
60         Reverted changeset:
61
62         "[Content Extensions] Add multi-DFA compiling and
63         interpreting."
64         https://bugs.webkit.org/show_bug.cgi?id=143010
65         http://trac.webkit.org/changeset/181932
66
67 2015-03-24  Alex Christensen  <achristensen@webkit.org>
68
69         [Content Extensions] Add multi-DFA compiling and interpreting.
70         https://bugs.webkit.org/show_bug.cgi?id=143010
71
72         Reviewed by Benjamin Poulain.
73
74         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
75         (TestWebKitAPI::testRequest):
76         (TestWebKitAPI::TEST_F):
77         Add some tests for ignore-previous-rules and large rulesets.
78
79 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
80
81         Make URL filter patterns matching consistent and add a simple canonicalization step
82         https://bugs.webkit.org/show_bug.cgi?id=142998
83
84         Reviewed by Alex Christensen.
85
86         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
87
88 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
89
90         [EFL] Add OpenWebRTC in jhbuild
91         https://bugs.webkit.org/show_bug.cgi?id=142778
92
93         Reviewed by Gyuyoung Kim.
94
95         Original patch by Philippe Normand <pnormand@igalia.com>
96
97         * efl/install-dependencies: Dependencies for OpenWebRTC.
98         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
99         the openwebrtc gst plugins.
100
101 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
102
103         Regression(r181257): WTF_WorkQueue.Simple is flaky
104         https://bugs.webkit.org/show_bug.cgi?id=142560
105
106         Remove the check that the refCount has returned to one after the
107         individual tasks have completed. It's too nondeterministic when
108         the reference count will be reduced.
109
110         Reviewed by Alexey Proskuryakov
111
112         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
113         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
114
115 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
116
117         [CMake][EFL] Put failure API test excutables into failure directory
118         https://bugs.webkit.org/show_bug.cgi?id=142965
119
120         Reviewed by Csaba Osztrogonác.
121
122         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
123
124         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
125         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
126
127 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
128
129         CSS Selectors: fix attribute case-insensitive matching of Contain and List
130         https://bugs.webkit.org/show_bug.cgi?id=142932
131
132         Reviewed by Darin Adler.
133
134         Add tests for the new features and fix some existing tests using the 
135         stringFromUTF8() utility recently added by Dhi.
136
137         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
138         (TestWebKitAPI::stringFromUTF8):
139         * TestWebKitAPI/Tests/WTF/StringView.cpp:
140
141 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
142
143         [GTK] install-dependencies should install orc
144         https://bugs.webkit.org/show_bug.cgi?id=142955
145
146         Reviewed by Martin Robinson.
147
148         Install orc, needed by openwebrtc
149
150         * gtk/install-dependencies:
151
152 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
153
154         Detect when url filter pattern with groups match the empty string
155         https://bugs.webkit.org/show_bug.cgi?id=142930
156
157         Reviewed by Sam Weinig.
158
159         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
160
161 2015-03-22  Anders Carlsson  <andersca@apple.com>
162
163         _WKWebsiteDataStore should clear WebSQL databases
164         https://bugs.webkit.org/show_bug.cgi?id=142947
165
166         Reviewed by Sam Weinig.
167
168         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
169
170         * MiniBrowser/mac/WK2BrowserWindowController.m:
171         (-[WK2BrowserWindowController fetchWebsiteData:]):
172         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
173         (-[WK2BrowserWindowController clearWebsiteData:]):
174
175 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
176
177         GCTimer should know keep track of nested GC phases
178         https://bugs.webkit.org/show_bug.cgi?id=142675
179
180         Reviewed by Darin Adler.
181
182         Adds a tool to aid in parsing the GC phase timing output into a
183         tree-like structure based on the parent-child relationships
184         of nested GC phases.
185
186         * Scripts/parse-gc-phase-timings: Added.
187         (Timing):
188         (Timing.__init__):
189         (Timing.__unicode__):
190         (Timing.__str__):
191         (Timing.__repr__):
192         (parse_input):
193         (print_timing_node):
194         (print_timing_tree):
195         (link_parents):
196         (main):
197
198 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
199
200         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
201
202         * Scripts/webkitpy/common/config/ews.json:
203
204 2015-03-20  Philippe Normand  <pnormand@igalia.com>
205
206         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
207         https://bugs.webkit.org/show_bug.cgi?id=142867
208
209         Rubber-stamped by Csaba Osztrogon.
210
211         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
212         a fixed revision for the openwebrtc-gst-plugins.
213
214 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
215
216         Unreviewed build fix. Don't try to report stats for all benchmarks.
217         Just report the geometric mean of preferred means.
218
219         * Scripts/run-jsc-benchmarks:
220
221 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
222
223         run-jsc-benchmarks should only report preferred mean
224         https://bugs.webkit.org/show_bug.cgi?id=142874
225
226         Reviewed by Geoffrey Garen.
227
228         Just collect statistics for the preferred mean.
229
230         * Scripts/run-jsc-benchmarks:
231
232 2015-03-19  Alex Christensen  <achristensen@webkit.org>
233
234         [Content Extensions] Test regular expression parse failures.
235         https://bugs.webkit.org/show_bug.cgi?id=142872
236
237         Reviewed by Benjamin Poulain.
238
239         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
240         (TestWebKitAPI::testPatternStatus):
241         (TestWebKitAPI::TEST_F):
242         Added tests for each parsing status.
243
244 2015-03-19  Alex Christensen  <achristensen@webkit.org>
245
246         Fix API tests after r181754.
247
248         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
249         (TestWebKitAPI::testRequest):
250
251 2015-03-19  Brady Eidson  <beidson@apple.com>
252
253         Part of content extensions should apply css selectors
254         https://bugs.webkit.org/show_bug.cgi?id=142604
255
256         Reviewed by Alex Christensen.
257
258         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
259         (WebCore::ContentExtensions::operator<<):
260
261 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
262
263         [Win] Activate tests on EWS
264         https://bugs.webkit.org/show_bug.cgi?id=142850
265
266         Reviewed by Alexey Proskuryakov.
267
268         * Scripts/webkitpy/common/config/ews.json: Add me as
269         the EWS bot watcher, and activate tests.
270
271 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
272
273         [GTK] Fix inspector userinterface related incremental build issue
274         https://bugs.webkit.org/show_bug.cgi?id=142849
275
276         Reviewed by Carlos Garcia Campos.
277
278         * Scripts/webkitdirs.pm:
279         (shouldRemoveCMakeCache):
280
281 2015-03-18  Alex Christensen  <achristensen@webkit.org>
282
283         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
284         https://bugs.webkit.org/show_bug.cgi?id=142799
285
286         Reviewed by Brady Eidson.
287
288         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
289         (TestWebKitAPI::testPattern):
290         (TestWebKitAPI::TEST_F):
291         Start testing regex failures.
292
293 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
294
295         Fix StringView typos after r181525 and r181558
296         https://bugs.webkit.org/show_bug.cgi?id=142772
297
298         Reviewed by Darin Adler.
299
300         Add some tests in [1] to cover the StringView::startsWith, 
301         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
302         StringView::endsWithIgnoringASCIICase implementations.
303
304         * TestWebKitAPI/Tests/WTF/StringView.cpp:
305         (TestWebKitAPI::TEST):
306
307 2015-03-18  Dana Burkart  <dburkart@apple.com>
308
309         Remove extraneous import to fix the build.
310
311         Unreviewed.
312
313         * Scripts/webkitpy/port/driver.py:
314
315 2015-03-18  Dana Burkart  <dburkart@apple.com>
316
317         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
318         https://bugs.webkit.org/show_bug.cgi?id=142547
319
320         Reviewed by Alexey Proskuryakov.
321
322         * Scripts/webkitpy/port/driver.py:
323         (Driver._setup_environ_for_driver):
324
325 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
326
327         Tweak how AppleSystemFontOSSubversion default is added
328         https://bugs.webkit.org/show_bug.cgi?id=142835
329
330         Reviewed by Dan Bernstein.
331
332         * DumpRenderTree/mac/DumpRenderTree.mm:
333         (setDefaultsToConsistentValuesForTesting):
334
335 2015-03-18  Dan Bernstein  <mitz@apple.com>
336
337         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
338         https://bugs.webkit.org/show_bug.cgi?id=142815
339
340         Reviewed by Darin Adler.
341
342         * Scripts/prepare-ChangeLog:
343         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
344         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
345         keep consuming the quoted text until the matching quotation mark is reached. Emit the
346         warning only if a line ends without a backslash before the matching quotation mark was found.
347
348 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
349
350         Remove unused "preprocessor" parameter to sub-CodeGenerators
351         https://bugs.webkit.org/show_bug.cgi?id=142793
352
353         Reviewed by Darin Adler.
354
355         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
356         (new):
357
358 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
359
360         [EFL] Bump gstreamer version to 1.4.4
361         https://bugs.webkit.org/show_bug.cgi?id=142782
362
363         Reviewed by Philippe Normand.
364
365         * efl/jhbuild.modules:
366         * efl/patches/gst-libav.patch:
367         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
368         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
369
370 2015-03-17  Tim Horton  <timothy_horton@apple.com>
371
372         Fix the iOS build.
373
374         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
375         (WTR::InjectedBundle::platformInitialize):
376
377 2015-03-17  Dean Jackson  <dino@apple.com>
378
379         check-webkit-style should allow "bool a : 1"
380         https://bugs.webkit.org/show_bug.cgi?id=142794
381
382         Reviewed by Brent Fulgham.
383
384         We should allow member bitfields of the form:
385
386         bool m_var : 1;
387
388         It seems that Visual Studio 8 was the last compiler that
389         wasn't happy about not using unsigned here. We already have
390         about 500 cases (in WebCore) where people were ignoring this rule.
391
392         * Scripts/webkitpy/style/checkers/cpp.py:
393         (check_language): Allow "bool".
394         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
395         (CppStyleTest.test_enum_bitfields):
396         (CppStyleTest.test_plain_integral_bitfields):
397
398 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
399
400         Compile character ranges targeting the same state as range check in the bytecode
401         https://bugs.webkit.org/show_bug.cgi?id=142759
402
403         Reviewed by Alex Christensen.
404
405         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
406         (TestWebKitAPI::TEST_F):
407
408 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
409
410         W3C test parser and converter should use test importer host
411         https://bugs.webkit.org/show_bug.cgi?id=142729
412
413         Reviewed by Bem Jones-Bey.
414
415         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
416         This enables adding more TestImporter unit testing.
417         This patch also ensures that the git object instantiated by TestDownloader is using the
418         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
419
420         * Scripts/webkitpy/common/system/filesystem_mock.py:
421         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
422         * Scripts/webkitpy/w3c/test_downloader.py:
423         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
424         (TestDownloader.checkout_test_repository): Making use of the new git function.
425         * Scripts/webkitpy/w3c/test_importer.py:
426         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
427         (TestImporter.import_tests): Adding host as parameter to the converter.
428         * Scripts/webkitpy/w3c/test_importer_unittest.py:
429         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
430         (TestImporterTest):
431         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
432         * Scripts/webkitpy/w3c/test_parser.py:
433         (TestParser.__init__): Adding host as parameter constructor.
434
435 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
436
437         [GTK] WebKitDOM objects leaking
438         https://bugs.webkit.org/show_bug.cgi?id=118788
439
440         Reviewed by Darin Adler and Sergio Villar Senin.
441
442         Update DOMObjectCache unit test to check that DOM objects are also
443         released when new contents are loaded in the web view, and the old
444         document is detached from the frame.
445
446         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
447         (testWebKitDOMObjectCache):
448         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
449         (runTest):
450
451 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
452
453         W3C test importer default import folder should be LayoutTests/imported/w3c
454         https://bugs.webkit.org/show_bug.cgi?id=142728
455
456         Reviewed by Bem Jones-Bey.
457
458         * Scripts/webkitpy/w3c/test_importer.py:
459         (parse_args): Updating the default destination option value to 'imported/w3c'.
460
461 2015-03-17  Philippe Normand  <pnormand@igalia.com>
462
463         [GTK] basic OpenWebRTC build support
464         https://bugs.webkit.org/show_bug.cgi?id=142393
465
466         Reviewed by Carlos Garcia Campos.
467
468         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
469         is not the upstream OpenWebRTC repository. This temporary fork
470         contains a few patches needed by WebKit for audio/video rendering.
471
472 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
473
474         [CMake][EFL] Build test tools only for developer mode
475         https://bugs.webkit.org/show_bug.cgi?id=142761
476
477         Reviewed by Csaba Osztrogonác.
478
479         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
480
481         * CMakeLists.txt:
482
483 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
484
485         Remove never used "useLayerOnTop" bindings generator argument
486         https://bugs.webkit.org/show_bug.cgi?id=142773
487
488         Reviewed by Darin Adler.
489
490         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
491         (new):
492
493 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
494
495         Enable ES6 classes by default
496         https://bugs.webkit.org/show_bug.cgi?id=142774
497
498         Reviewed by Gavin Barraclough.
499
500         * Scripts/webkitperl/FeatureList.pm:
501
502 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
503
504         Fix webkitpy tests after r181585.
505
506         Looks like "me" cannot be anyone's email, it's a special case.
507
508         * Scripts/webkitpy/common/config/contributors.json:
509
510 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
511
512         Add tolerance to WebAudio tests
513         https://bugs.webkit.org/show_bug.cgi?id=142676
514
515         Reviewed by Tim Horton.
516
517         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
518
519         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
520         (TestResultWriter.create_audio_diff_and_write_result):
521         * Scripts/webkitpy/layout_tests/models/test_failures.py:
522         (FailureAudio.write_failure):
523         * Scripts/webkitpy/port/base.py:
524         (Port.do_audio_results_differ):
525         Diff audio failures.
526
527         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
528         tests to use real parseable WAV data, and got rid of base64, which there didn't
529         seem to have been any reason for.
530
531 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
532
533         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
534         https://bugs.webkit.org/show_bug.cgi?id=142720
535
536         Reviewed by Myles C. Maxfield.
537
538         Activate system copies of Microsoft fonts for the current process, thus overriding
539         any other ones that could be preferred by the system otherwise.
540
541         * DumpRenderTree/mac/DumpRenderTree.mm:
542         (activateSystemCoreWebFonts):
543         (adjustFonts):
544         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
545         (WTR::activateSystemCoreWebFonts):
546         (WTR::activateFonts):
547
548 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
549
550         Created Streams API watchlist
551         https://bugs.webkit.org/show_bug.cgi?id=142684
552
553         Reviewed by Benjamin Poulain.
554
555         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
556         watchlist and added Benjamin, Youenn and me to it.
557
558 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
559
560         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
561         https://bugs.webkit.org/show_bug.cgi?id=142715
562
563         Reviewed by Brent Fulgham.
564
565         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
566         (TestWebKitAPI::TEST):
567
568 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
569
570         Change the exact attribute matching to be ASCII case-insensitive
571         https://bugs.webkit.org/show_bug.cgi?id=142609
572
573         Reviewed by Darin Adler.
574
575         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
576         * TestWebKitAPI/Tests/WTF/StringView.cpp:
577
578 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
579
580         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
581         https://bugs.webkit.org/show_bug.cgi?id=134764
582
583         Reviewed by Ryosuke Niwa.
584
585         TestDownloader is introduced to download W3C tests from the official
586         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
587         and https://github.com/w3c/csswg-test.git).
588         TestDownloader clones the repositories and checkouts revisions of the tests
589         defined in LayoutTests/imported/w3c/resources/TestRepositories.
590
591         Similarly to https://codereview.chromium.org/148173016,
592         TestDownloader copies part of the files based on the rules
593         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
594
595         TestDownloader is used by TestImporter when no source directory is provided.
596
597         * Scripts/webkitpy/w3c/test_downloader.py: Added.
598         (TestDownloader):
599         (TestDownloader.default_options):
600         (TestDownloader.load_test_repositories):
601         (TestDownloader.__init__):
602         (TestDownloader.checkout_test_repository):
603         (TestDownloader._init_paths_from_expectations):
604         (TestDownloader._add_test_suite_paths):
605         (TestDownloader._empty_directory):
606         (TestDownloader.copy_tests):
607         (TestDownloader.download_tests):
608         * Scripts/webkitpy/w3c/test_importer.py:
609         (main):
610         (parse_args):
611         (TestImporter.__init__):
612         (TestImporter.do_import):
613         (TestImporter.test_downloader):
614         (TestImporter.find_importable_tests.should_keep_subdir):
615         (TestImporter.should_convert_test_harness_links):
616         (TestImporter.import_tests):
617         (TestImporter.write_import_log):
618
619 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
620
621         [Mavericks] Test snapshots are 1600x1200 on Retina devices
622         https://bugs.webkit.org/show_bug.cgi?id=142630
623
624         Reviewed by Tim Horton.
625
626         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
627         Removed an ifdef that disabled the fix on Mavericks.
628
629 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
630
631         Remove isWK2 cruft from webkitdirs.pm after r170426
632         https://bugs.webkit.org/show_bug.cgi?id=142618
633
634         Reviewed by Daniel Bates.
635
636         * Scripts/webkitdirs.pm:
637         (isWK2): Deleted.
638
639 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
640
641         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
642         https://bugs.webkit.org/show_bug.cgi?id=138687
643
644         Reviewed by Carlos Garcia Campos.
645
646         Always change cookie policy from UI process, as changing it from WebProcess doesn't
647         affect other processes.
648
649         The implementation is imperfect, because the change happens asynchronously, but I
650         don't expect it to be a problem in practice.
651
652         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
653         (WTR::InjectedBundle::beginTesting):
654         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
655         (WTR::TestRunner::setAlwaysAcceptCookies):
656         * WebKitTestRunner/TestInvocation.cpp:
657         (WTR::TestInvocation::invoke):
658         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
659
660 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
661
662         [EFL] Enable building EFL 1.13 with NEON support
663         https://bugs.webkit.org/show_bug.cgi?id=142619
664
665         Reviewed by Gyuyoung Kim.
666
667         * efl/jhbuild.modules:
668
669 2015-03-11  Alex Christensen  <achristensen@webkit.org>
670
671         [Content Extensions] Add resource type and load type triggers.
672         https://bugs.webkit.org/show_bug.cgi?id=142422
673
674         Reviewed by Benjamin Poulain.
675
676         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
677         (TestWebKitAPI::testRequest):
678         (TestWebKitAPI::mainDocumentRequest):
679         (TestWebKitAPI::TEST_F):
680         (TestWebKitAPI::testURL): Deleted.
681
682 2015-03-10  Sam Weinig  <sam@webkit.org>
683
684         Allow adding a button in input elements for auto fill related functionality
685         <rdar://problem/19782066>
686         https://bugs.webkit.org/show_bug.cgi?id=142564
687
688         Reviewed by Anders Carlsson.
689
690         * WebKitTestRunner/TestController.cpp:
691         (WTR::TestController::createOtherPage):
692         (WTR::TestController::createWebViewWithOptions):
693         Update for new callback.
694
695 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
696
697         Add basic support for BOL and EOL assertions to the URL Filter parser
698         https://bugs.webkit.org/show_bug.cgi?id=142568
699
700         Reviewed by Alex Christensen.
701
702         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
703         (TestWebKitAPI::TEST_F):
704
705 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
706
707         [GTK] Add support for handling TLS errors to MiniBrowser
708         https://bugs.webkit.org/show_bug.cgi?id=142576
709
710         Reviewed by Sergio Villar Senin.
711
712         It's useful for testing TLS errors handling itself, but also to
713         allow ignoring TLS errors when testing.
714
715         * MiniBrowser/gtk/BrowserWindow.c:
716         (webViewLoadFailedWithTLSerrors):
717         (browserWindowConstructed):
718
719 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
720
721         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
722         https://bugs.webkit.org/show_bug.cgi?id=142569
723
724         Reviewed by David Hyatt.
725
726         Test Optional::valueOrCompute().
727
728         * TestWebKitAPI/Tests/WTF/Optional.cpp:
729         (TestWebKitAPI::TEST):
730
731 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
732
733         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
734         https://bugs.webkit.org/show_bug.cgi?id=126688
735
736         Reviewed by Gustavo Noronha Silva.
737
738         * CMakeLists.txt: Build testing tools only for developer builds,
739         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
740         * MiniBrowser/gtk/CMakeLists.txt: Only add
741         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
742         and add a rule to install the MiniBrowser.
743         * MiniBrowser/gtk/main.c:
744         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
745         builds.
746
747 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
748
749         Add some DateMath tests to TestWebKitAPI
750         https://bugs.webkit.org/show_bug.cgi?id=142565
751
752         Reviewed by Alexey Proskuryakov.
753
754         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
755         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
756         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
757         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
758         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
759
760 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
761
762         Regression(r181257): WTF_WorkQueue.Simple is flaky
763         https://bugs.webkit.org/show_bug.cgi?id=142560
764
765         Unreviewed attempt to improve test stability.
766
767         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
768         the WorkQueue a little later to redue flakiness.
769
770 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
771
772         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
773         https://bugs.webkit.org/show_bug.cgi?id=142555
774
775         Reviewed by Simon Fraser.
776
777         * DumpRenderTree/mac/DumpRenderTree.mm:
778         (setDefaultsToConsistentValuesForTesting):
779         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
780         (WTR::InjectedBundle::platformInitialize):
781
782 2015-03-10  Alex Christensen  <achristensen@webkit.org>
783
784         Use unsigned for HashSet size.
785         https://bugs.webkit.org/show_bug.cgi?id=142518
786
787         Reviewed by Benjamin Poulain.
788
789         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
790         (TestWebKitAPI::TEST):
791         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
792         (TestWebKitAPI::testInitialCapacity):
793         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
794         (TestWebKitAPI::TEST):
795
796 2015-03-10  Daniel Bates  <dabates@apple.com>
797
798         [iOS] Add WebKitSystemInterface for iOS 8.2
799         https://bugs.webkit.org/show_bug.cgi?id=142505
800
801         Rubber-stamped by Anders Carlsson.
802
803         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
804         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
805         copy-webkitlibraries-to-product-directory in r181286.
806
807         * Scripts/copy-webkitlibraries-to-product-directory:
808
809 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
810
811         Extend URL filter's Term definition to support groups/subpatterns
812         https://bugs.webkit.org/show_bug.cgi?id=142519
813
814         Reviewed by Alex Christensen.
815
816         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
817         (TestWebKitAPI::testURL):
818
819 2015-03-06  Jer Noble  <jer.noble@apple.com>
820
821         Add an option to run-webkit-tests to override the LayoutTests/ directory
822         https://bugs.webkit.org/show_bug.cgi?id=142418
823
824         Reviewed by David Kilzer.
825
826         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
827         directory. The base port will parse the options during initialization and store the override
828         location if present. layout_tests_dir() will return this overridden location if set.
829
830         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
831         (parse_args):
832         * Scripts/webkitpy/port/base.py:
833         (Port.__init__):
834         (Port.layout_tests_dir):
835
836 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
837
838         [CMake] Enable WorkQueue tests for CMake ports
839         https://bugs.webkit.org/show_bug.cgi?id=142473
840
841         Reviewed by Darin Adler.
842
843         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
844         the list of source files.
845         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
846         to the list of include directories for EFL.
847
848 2015-03-09  David Kilzer  <ddkilzer@apple.com>
849
850         Attempt to fix timeouts on iOS Simulator layout tests
851
852         * Scripts/webkitpy/port/ios.py:
853         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
854         Simulator end after the first 50 tests time out.  Some analysis
855         this past weekend shows that the 'Booted' status in the output
856         of `xcrun simctl list` is not sufficient (and watching the test
857         run shows that SpringBoard hasn't fully started to the point
858         where it's displaying icons on the home screen).  The workaround
859         until we have a better fix is to add an arbitrary timeout to let
860         SpringBoard finish launching.  In practice, 15 seconds is
861         probably enough, but 30 seconds should nearly always work.
862
863 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
864
865         Unreviewed. Add myself as a committer.
866
867         * Scripts/webkitpy/common/config/contributors.json:
868
869 2015-03-09  David Kilzer  <ddkilzer@apple.com>
870
871         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
872
873         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
874         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
875         an expectation that will fail if we hit the race condition.
876         This test is inherently racy and will deadlock if the first job
877         for queue2 takes the mutex lock before the second job for
878         queue1.
879
880 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
881
882         [Win] WTF::WorkQueue does not balance ref/deref properly
883         https://bugs.webkit.org/show_bug.cgi?id=142471
884
885         Reviewed by Antti Koivisto.
886
887         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
888         (TestWebKitAPI::TEST): Check that the refcount is correct.
889
890 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
891
892         Do not show passing test result on output of EFL layout test
893         https://bugs.webkit.org/show_bug.cgi?id=142380
894
895         Reviewed by Darin Adler.
896
897         To show passing tests has caused inconvenience when we detect problem tests
898         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
899         in order not to show passing tests in the output of EFL layout test.
900
901         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
902         (RunWebKitTests.start):
903
904 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
905
906         Unreviewed build fix.
907
908         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
909         (TestWebKitAPI::TEST): Remove two unused variables.
910
911 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
912
913         Add some WorkQueue tests to TestWebKitAPI
914         https://bugs.webkit.org/show_bug.cgi?id=142447
915
916         Reviewed by Sam Weinig.
917
918         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
919         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
921         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
922         (TestWebKitAPI::simpleTest):
923         (TestWebKitAPI::longTest):
924         (TestWebKitAPI::thirdTest):
925         (TestWebKitAPI::finishedTests):
926         (TestWebKitAPI::TEST):
927         (TestWebKitAPI::longTest2):
928
929 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
930
931         Remove willDestroyFrame in WKBundlePageLoaderClient
932         https://bugs.webkit.org/show_bug.cgi?id=142389
933
934         Reviewed by Anders Carlsson.
935
936         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
937         (WTR::InjectedBundlePage::InjectedBundlePage):
938
939 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
940
941         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
942         https://bugs.webkit.org/show_bug.cgi?id=142433
943
944         Reviewed by Darin Adler.
945
946         Include more TestWebKitAPI tests when building for Windows. Also
947         fix a build error in MetaAllocator.cpp caused by one of the
948         Microsoft headers #defining 'small'.
949
950         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
951         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
952         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
953
954 2015-03-06  Sam Weinig  <sam@webkit.org>
955
956         [Content Extensions] Move compiling of content extensions to the UIProcess
957         https://bugs.webkit.org/show_bug.cgi?id=142402
958
959         Reviewed by Benjamin Poulain.
960
961         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
962         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
963         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
964         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
965         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
966         (TestWebKitAPI::TEST_F):
967         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
968         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
969         is now abstract).
970
971 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
972
973         [Win] Correct Windows build.
974
975         Rubberstamped by Michael Saboff
976
977         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
978         in the GOTO labels.
979
980 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
981
982         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
983         https://bugs.webkit.org/show_bug.cgi?id=142385
984
985         Reviewed by Sergio Villar Senin.
986
987         Use stack allocated GMainLoopSources to make sure they are
988         cancelled automatically if the test finishes before they have
989         been processed.
990
991         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
992         (testWebViewSyncRequestOnMaxConns):
993
994 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
995
996         Remove Mountain Lion libraries since ML isn't supported
997         https://bugs.webkit.org/show_bug.cgi?id=142332
998
999         Reviewed by Darin Adler.
1000
1001         * Scripts/copy-webkitlibraries-to-product-directory:
1002
1003 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
1004
1005         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
1006         https://bugs.webkit.org/show_bug.cgi?id=142083
1007
1008         Reviewed by Simon Fraser.
1009
1010         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
1011
1012         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1013         (WebPlatformTestServer._copy_webkit_test_files):
1014
1015 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1016
1017         setup-git-clone fails due to the failure to download python-irclib-0.4.8
1018         https://bugs.webkit.org/show_bug.cgi?id=141946
1019
1020         Reviewed by Ryosuke Niwa.
1021
1022         Check in ircbot.py and irclib.py to avoid network problems in the future.
1023
1024         * Scripts/webkitpy/common/net/irc/ircbot.py:
1025         * Scripts/webkitpy/thirdparty/__init__.py:
1026         (AutoinstallImportHook.find_module):
1027         (AutoinstallImportHook._install_irc): Deleted.
1028         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1029         (ThirdpartyTest.test_imports):
1030         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
1031         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
1032         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
1033
1034 2015-03-06  David Kilzer  <ddkilzer@apple.com>
1035
1036         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
1037
1038         See also fix to config.json in r181097.
1039
1040         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1041         (WebKitBuildbot): Add missing "WK2" to the names of the perf
1042         bots.
1043
1044 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
1045
1046         run-jsc-stress-tests should determine the architecture from ELF binaries
1047         https://bugs.webkit.org/show_bug.cgi?id=142335
1048
1049         Reviewed by Darin Adler.
1050
1051         * Scripts/run-jsc-stress-tests:
1052
1053 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1054
1055         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
1056         <http://webkit.org/b/142226>
1057
1058         Reviewed by Darin Adler.
1059
1060         * Scripts/webkitpy/port/ios.py:
1061         (IOSSimulatorPort.default_baseline_search_path): Switch the
1062         TestExpectations order of ios-simulator-wk2 from this:
1063           ios-simulator-wk2, wk2, ios-simulator
1064         To this:
1065           ios-simulator-wk2, ios-simualtor, wk2
1066
1067 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1068
1069         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
1070         https://bugs.webkit.org/show_bug.cgi?id=142370
1071
1072         Reviewed by Dean Jackson.
1073
1074         * Scripts/webkitdirs.pm:
1075         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
1076         logs, one for warnings, the other for errors.
1077         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
1078         into the standard BuildOutput.htm document.
1079
1080 2015-03-05  David Kilzer  <ddkilzer@apple.com>
1081
1082         Dashboard has trouble parsing iOS test output
1083         <http://webkit.org/b/142364>
1084
1085         Reviewed by Alex Christensen.
1086
1087         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1088         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1089         Add fallback path to build a regex using 'matchString' so that
1090         it matches anywhere in the line.  In practice, 'matchString' is
1091         a prefix for the label following the number.
1092
1093 2015-03-05  Alex Christensen  <achristensen@webkit.org>
1094
1095         Fix linker warnings in TestWebKitAPI.
1096         https://bugs.webkit.org/show_bug.cgi?id=141912
1097
1098         Reviewed by David Kilzer.
1099
1100         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1101         Do not export TearDownTestCase or SetUpTestCase symbols.
1102
1103 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1104
1105         [Win] Unreviewed EWS fix.
1106
1107         * Scripts/webkitdirs.pm:
1108         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
1109         the EWS output more usable.
1110
1111 2015-03-05  Chris Dumez  <cdumez@apple.com>
1112
1113         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
1114         https://bugs.webkit.org/show_bug.cgi?id=142350
1115
1116         Reviewed by Michael Saboff and Benjamin Poulain.
1117
1118         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
1119         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
1120
1121         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1122         (TestWebKitAPI::TEST):
1123
1124 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1125
1126         [Win] Ensure build target directory exists when launching MSBuild
1127         https://bugs.webkit.org/show_bug.cgi?id=142360
1128
1129         Reviewed by Dean Jackson.
1130
1131         Create the build output directory (if it doesn't exist) before
1132         launching MSBuild so that it can immediately begin writing logs.
1133
1134         * Scripts/webkitdirs.pm:
1135         (buildVisualStudioProject):
1136
1137 2015-03-05  Chris Dumez  <cdumez@apple.com>
1138
1139         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
1140         https://bugs.webkit.org/show_bug.cgi?id=142325
1141
1142         Reviewed by Csaba Osztrogonác.
1143
1144         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
1145         As a result, "--webkit-test-runner / -2" parameters are replaced by
1146         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
1147         than WebKitTestRunner.
1148
1149         * BuildSlaveSupport/build.webkit.org-config/config.json:
1150         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1151         (RunWebKit1Tests):
1152         (RunWebKit1Tests.start):
1153         (RunWebKit1LeakTests):
1154         (RunWebKit1LeakTests.start):
1155         (RunAndUploadPerfTestsWebKit1):
1156         (RunAndUploadPerfTestsWebKit1.start):
1157         (TestFactory):
1158         (TestWebKit1LeaksFactory):
1159         (TestWebKit1LeaksFactory.__init__):
1160         (TestWebKit1Factory):
1161         (TestWebKit1AllButJSCFactory):
1162         (TestAllButJSCFactory):
1163         (BuildAndPerfTestWebKit1Factory):
1164         (BuildAndPerfTestWebKit1Factory.__init__):
1165         (BuildAndPerfTestFactory):
1166         (BuildAndPerfTestFactory.__init__):
1167         (DownloadAndPerfTestWebKit1Factory):
1168         (DownloadAndPerfTestWebKit1Factory.__init__):
1169         (DownloadAndPerfTestFactory):
1170         (DownloadAndPerfTestFactory.__init__):
1171         (RunWebKitLeakTests): Deleted.
1172         (RunWebKitLeakTests.start): Deleted.
1173         (RunWebKit2Tests): Deleted.
1174         (RunWebKit2Tests.start): Deleted.
1175         (RunAndUploadPerfTestsWebKit2): Deleted.
1176         (RunAndUploadPerfTestsWebKit2.start): Deleted.
1177         (TestLeaksFactory): Deleted.
1178         (TestLeaksFactory.__init__): Deleted.
1179         (TestWebKit2Factory): Deleted.
1180         (TestWebKit2AndJSCFactory): Deleted.
1181         (BuildAndPerfTestWebKit2Factory): Deleted.
1182         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
1183         (DownloadAndPerfTestWebKit2Factory): Deleted.
1184         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
1185         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1186         (parse_args):
1187         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1188         (PerfTestsRunner._parse_args):
1189         * Scripts/webkitpy/port/port_testcase.py:
1190         (PortTestCase.test_build_driver):
1191
1192 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
1193
1194         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
1195         https://bugs.webkit.org/show_bug.cgi?id=140845
1196
1197         Reviewed by David Kilzer.
1198
1199         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
1200         and generate suitable build commands to drive a full build from our
1201         existing solution files.
1202
1203         * Scripts/webkitdirs.pm:
1204         (msBuildInstallDir): Added.
1205         (determineConfigurationForVisualStudio): Revise to use MSBuild command
1206         line arguments to drive the build.
1207         (setupCygwinEnv): Warn user if MSBuild cannot be located.
1208         (buildVisualStudioProject): Revise to use MSBuild command line arguments
1209         to specify build architecture.
1210         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
1211         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
1212         bother looking for CoreUI or SafariTheme build logs.
1213
1214 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1215
1216         [buildbot] mastercfg_unittest.py should be runnable easily
1217         https://bugs.webkit.org/show_bug.cgi?id=142219
1218
1219         Reviewed by Chris Dumez.
1220
1221         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
1222         the last Twisted version works together with this buildbot version.
1223
1224         * Scripts/webkitpy/common/system/autoinstall.py:
1225         (AutoInstaller): Added prepend_to_search_path argument to be able
1226         to prefer autoinstalled package to system package.
1227         (AutoInstaller.__init__):
1228         (AutoInstaller._set_up_target_dir):
1229         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
1230         (AutoInstaller._prepare_package):
1231         (AutoInstaller._extract_targz): Renamed to _extract_tar.
1232         * Scripts/webkitpy/thirdparty/__init__.py:
1233         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
1234
1235 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
1236
1237         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
1238         https://bugs.webkit.org/show_bug.cgi?id=131162
1239
1240         Reviewed by Gyuyoung Kim.
1241
1242         * MiniBrowser/efl/main.c:
1243         (on_download_request):
1244         (on_download_finished):
1245         (on_download_failed):
1246         (window_create):
1247         Adapt download callbacks to new callback mechanism
1248
1249 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1250
1251         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
1252
1253         In r180927 we updated the libsoup version used by the jhbuild. In
1254         this new version the sniffer uses image/x-icon instead of
1255         image/vnd.microsoft.icon for blank.ico resource.
1256
1257         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1258         (testWebResourceMimeType):
1259
1260 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1261
1262         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
1263         https://bugs.webkit.org/show_bug.cgi?id=142244
1264
1265         Reviewed by Sergio Villar Senin.
1266
1267         Check that the SSL server doesn't process any request in case of
1268         TLS errors when the policy is set to FAIL.
1269
1270         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1271         (testTLSErrorsPolicy):
1272         (testTLSErrorsRedirect):
1273         (testTLSErrorsHTTPAuth):
1274         (testLoadFailedWithTLSErrors):
1275         (testSubresourceLoadFailedWithTLSErrors):
1276         (httpsServerCallback):
1277
1278 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
1279
1280         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
1281         https://bugs.webkit.org/show_bug.cgi?id=141154
1282
1283         Reviewed by Jer Noble.
1284
1285         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
1286
1287         For the sake of completeness WebKitTestRunner should specify temporary
1288         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
1289
1290         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
1291         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1292         to get data storage paths. Only Mac port has an actual implementation of it.
1293         However, WebKitTestRunner overrides them in favour of unique temporary dir
1294         which is taken from libraryPathForTesting().
1295
1296         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
1297         is not implemented for EFL and GTK ports it returns an empty string.
1298         All default data folders besides MediaKeys are overridden in TestRunner
1299         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
1300         env variable.
1301
1302         GTK port does not enable encrypted keys by default so
1303         WebMediaKeyStorageManager::initialize() code path is never triggered.
1304
1305         * WebKitTestRunner/TestController.cpp:
1306         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
1307         WebKit ports.
1308
1309 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
1310
1311         [buildbot] Add regression test to check which builder runs which tests
1312         https://bugs.webkit.org/show_bug.cgi?id=142166
1313
1314         Reviewed by Alexey Proskuryakov.
1315
1316         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1317         (BuildStepsConstructorTest.createTest):
1318         (BuildStepsTest):
1319         (BuildStepsTest.generateTests):
1320         (BuildStepsTest.createTest):
1321         (BuildStepsTest.createTest.doTest):
1322         (BuildStepsTest.test_unnecessary_expected_results):
1323
1324 2015-03-04  Commit Queue  <commit-queue@webkit.org>
1325
1326         Unreviewed, rolling out r181054.
1327         https://bugs.webkit.org/show_bug.cgi?id=142320
1328
1329         Broke the api tests (Requested by sundiamonde on #webkit).
1330
1331         Reverted changeset:
1332
1333         "Fix linker warnings in TestWebKitAPI."
1334         https://bugs.webkit.org/show_bug.cgi?id=141912
1335         http://trac.webkit.org/changeset/181054
1336
1337 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1338
1339         Fix linker warnings in TestWebKitAPI.
1340         https://bugs.webkit.org/show_bug.cgi?id=141912
1341
1342         Reviewed by David Kilzer.
1343
1344         * TestWebKitAPI/Configurations/Base.xcconfig:
1345         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
1346
1347 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
1348
1349         [Mac] Set SystemUIFontSelect in DRT and WKTR
1350         https://bugs.webkit.org/show_bug.cgi?id=142303
1351
1352         Reviewed by Myles C. Maxfield.
1353
1354         * DumpRenderTree/mac/DumpRenderTree.mm:
1355         (setDefaultsToConsistentValuesForTesting):
1356         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1357         (WTR::InjectedBundle::platformInitialize):
1358
1359 2015-03-04  Chris Dumez  <cdumez@apple.com>
1360
1361         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1362         https://bugs.webkit.org/show_bug.cgi?id=142314
1363         <rdar://problem/20046835>
1364
1365         Reviewed by Ryosuke Niwa.
1366
1367         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
1368         to get WK2 code coverage.
1369
1370         * BuildSlaveSupport/build.webkit.org-config/config.json:
1371
1372 2015-03-04  Alex Christensen  <achristensen@webkit.org>
1373
1374         Move content extensions test to properly named directory.
1375         https://bugs.webkit.org/show_bug.cgi?id=142299
1376
1377         Reviewed by Tim Horton.
1378
1379         * WebKitTestRunner/mac/TestControllerMac.mm:
1380         (WTR::TestController::platformConfigureViewForTest):
1381
1382 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1383
1384         W3C test importer should use filesystem instead of os.walk
1385         https://bugs.webkit.org/show_bug.cgi?id=142085
1386
1387         Reviewed by Bem Jones-Bey.
1388
1389         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
1390         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
1391         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
1392
1393         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
1394         Added a unit test to check that test importer is now black-box testable using a Mock system.
1395
1396         * Scripts/webkitpy/common/system/filesystem.py:
1397         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
1398         (FileSystem.dirs_under.filter_all):
1399         * Scripts/webkitpy/common/system/filesystem_mock.py:
1400         (MockFileSystem.dirs_under):
1401         (MockFileSystem.dirs_under.filter_all):
1402         (MockFileSystem.getsize):
1403         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
1404         (MockFileSystemTest.test_dirs_under):
1405         (MockFileSystemTest.test_dirs_under.filter_dir):
1406         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1407         (RealFileSystemTest.test_sep):
1408         (RealFileSystemTest):
1409         (RealFileSystemTest.test_dirs_under):
1410         (RealFileSystemTest.test_dirs_under.filter_this_dir):
1411         * Scripts/webkitpy/w3c/test_importer.py:
1412         (TestImporter.do_import):
1413         (TestImporter.find_importable_tests.should_keep_subdir):
1414         (TestImporter.find_importable_tests):
1415         (TestImporter.should_keep_subdir): Deleted.
1416         (TestImporter.should_skip_file): Deleted.
1417         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1418         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
1419
1420 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
1421
1422         [WebEditingTester] Add support for the find and replace bar
1423         https://bugs.webkit.org/show_bug.cgi?id=142247
1424
1425         Reviewed by Enrica Casucci.
1426
1427         While it's not hooked up yet in WKWebView, adding support for the
1428         find bar to WebEditingTester will help us implement that functionality.
1429
1430         * WebEditingTester/AppDelegate.h:
1431         * WebEditingTester/AppDelegate.m:
1432         (-[WebEditingAppDelegate performTextFinderAction:]):
1433         * WebEditingTester/MainMenu.xib:
1434         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
1435
1436         * WebEditingTester/WK2WebDocumentController.m:
1437         (-[WK2WebDocumentController awakeFromNib]):
1438         (-[WK2WebDocumentController performTextFinderAction:]):
1439         (-[WK2WebDocumentController findBarView]):
1440         (-[WK2WebDocumentController setFindBarView:]):
1441         (-[WK2WebDocumentController isFindBarVisible]):
1442         (-[WK2WebDocumentController setFindBarVisible:]):
1443         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
1444         (-[WK2WebDocumentController layout]):
1445         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
1446         pointing at the WKWebView (currently nothing will work, but the bar will
1447         show up). Install and uninstall the bar as needed.
1448
1449         * WebEditingTester/WebDocument.xib:
1450         Don't use a full-size content view. There's no need, and it makes find
1451         bar layout harder.
1452
1453         * WebEditingTester/WebDocumentController.h:
1454         * WebEditingTester/WebDocumentController.m:
1455         (-[WebDocumentController performTextFinderAction:]):
1456
1457 2015-03-03  Sam Weinig  <sam@webkit.org>
1458
1459         [Content Extensions] Split parsing and compiling of content extensions into their own files
1460         https://bugs.webkit.org/show_bug.cgi?id=142259
1461
1462         Reviewed by Anders Carlsson.
1463
1464         Add basic unit test for the content filter compiler.
1465
1466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1467         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
1468         (WebCore::ContentExtensions::operator<<):
1469         (TestWebKitAPI::ContentFilterTest::SetUp):
1470         (TestWebKitAPI::TEST_F):
1471
1472 2015-03-04  Matthew Mirman  <mmirman@apple.com>
1473
1474         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
1475         https://bugs.webkit.org/show_bug.cgi?id=142230
1476
1477         Reviewed by Csaba Osztrogonác.
1478
1479         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1480         (TestFactory):
1481         (TestFactory.getProduct): Added
1482         (TestFactory.__init__): moved downloader to getProduct
1483         (BuildAndTestFactory):        
1484         (BuildAndTestFactory.getProduct): Added
1485         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
1486         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
1487
1488 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
1489
1490         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
1491         https://bugs.webkit.org/show_bug.cgi?id=142225
1492
1493         Reviewed by Carlos Garcia Campos.
1494
1495         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1496         (testWebViewWebContextLifetime):
1497         (beforeAll):
1498
1499 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1500
1501         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
1502         <http://webkit.org/b/142243>
1503
1504         Reviewed by Alexey Proskuryakov.
1505
1506         * WebKitTestRunner/TestController.cpp:
1507         (WTR::TestController::webProcessName):
1508         (WTR::TestController::networkProcessName):
1509         - Return the same process name on iOS and Mac because they both
1510           use the same process name for local engineering builds.
1511
1512 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1513
1514         check-webkit-style: Add exception for FrameworkSoftLink.h header order
1515         <http://webkit.org/b/141872>
1516
1517         Reviewed by Alex Christensen.
1518
1519         * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
1520         semi-colons in various places and fix whitespace.
1521         (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
1522         constants.
1523         (_IncludeState.__init__): Add self._visited_soft_link_section
1524         boolean state variable.
1525         (_IncludeState.visited_soft_link_section): Getter for
1526         self._visited_soft_link_section.
1527         (_IncludeState.check_next_include_order): Update state machine
1528         for soft-link headers.  Add check that soft-link headers always
1529         appear last.
1530         (_classify_include): Add check for soft-link header type.
1531         (check_include_line): Return early if there is a soft-link
1532         header error.
1533
1534         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1535         (OrderOfIncludesTest.test_public_primary_header): Add tests for
1536         including soft-link headers.
1537         (OrderOfIncludesTest.test_classify_include): Add test for
1538         _SOFT_LINK_HEADER type.
1539
1540 2015-03-03  Alexey Proskuryakov  <ap@apple.com>
1541
1542         build.webkit.org/dashboard: Don't repeatedly handle each test type
1543         https://bugs.webkit.org/show_bug.cgi?id=142211
1544
1545         Reviewed by Tim Horton and Matt Hanson.
1546
1547         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1548         (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
1549         (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
1550         (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
1551         (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
1552         (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
1553         (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
1554         Removed functions that build a link to test step results. The buildbot provides
1555         these links in JSON.
1556
1557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1558         (BuildbotIteration): Put failing tests into an array, instead of named variables.
1559         (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
1560         We can easily add them to the map as needed.
1561         (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
1562         (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
1563         to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
1564         and then build a BuildbotTestResults object, which was strange.
1565         (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
1566
1567         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1568         Corrected an unrelated assertion that was buggy, and kept firing.
1569
1570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1571         (BuildbotTestResults):
1572         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
1573         (BuildbotTestResults.prototype._parseResults):
1574         (BuildbotTestResults.prototype.addFullLayoutTestResults):
1575         Moved the code for parsing JSON results for a single step here.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1578         (BuildbotTesterQueueView.prototype._testStepFailureDescription):
1579         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
1580         (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
1581         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
1582         (BuildbotTesterQueueView.prototype.update): Deleted.
1583         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
1584         Updated for the new data structures. One behavior change is that we now display individual
1585         counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
1586         test failures, 3 platform api test failures".
1587
1588 2015-03-03  Matthew Mirman  <mmirman@apple.com>
1589
1590         JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
1591         https://bugs.webkit.org/show_bug.cgi?id=142094
1592
1593         Reviewed by Csaba Osztrogonác.
1594
1595         * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
1596         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1597         (TestFactory):
1598         (TestFactory.__init__): Made running of JSC tests conditional.
1599         (TestAllButJSCFactory):
1600         (TestJSCFactory): Added.
1601         (TestJSCFactory.__init__):
1602         (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
1603
1604 2015-03-03  David Kilzer  <ddkilzer@apple.com>
1605
1606         `build-webkit --help` is wrong about how to build for the iOS simulator
1607         <http://webkit.org/b/142223>
1608
1609         Reviewed by Csaba Osztrogonác.
1610
1611         * Scripts/build-webkit: Fix help.
1612
1613 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1614
1615         Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
1616
1617         * gtk/jhbuild.modules:
1618
1619 2015-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1620
1621         [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
1622         https://bugs.webkit.org/show_bug.cgi?id=141508
1623
1624         Reviewed by Sergio Villar Senin.
1625
1626         Add a unit test to check that synchronous XHRs load even if the
1627         maximum connection limits are reached.
1628
1629         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1630         (testWebViewSyncRequestOnMaxConns):
1631         (serverCallback):
1632         (beforeAll):
1633         * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
1634
1635 2015-03-02  Alexey Proskuryakov  <ap@apple.com>
1636
1637         Update the name of ASan build step.
1638
1639         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1640
1641 2015-03-02  Jer Noble  <jer.noble@apple.com>
1642
1643         [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
1644         https://bugs.webkit.org/show_bug.cgi?id=142121
1645
1646         Reviewed by Simon Fraser.
1647
1648         Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
1649         that the initial and final screen rects for the web content are as expected.
1650
1651         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1652         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
1653         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
1654         (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
1655         (runJavaScriptAlert):
1656         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1657         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
1658         (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
1659         (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
1660         (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
1661         (TestWebKitAPI::TEST_F):
1662
1663 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1664
1665         LayoutTestRealy: Prepend __XPC_ to the key, not the value!
1666
1667         Follow-up fix for:
1668
1669         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1670         <http://webkit.org/b/142145>
1671
1672         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1673         (-[LTRelayController _environmentVariables]): Fix think-o.
1674
1675 2015-03-01  David Kilzer  <ddkilzer@apple.com>
1676
1677         LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
1678         <http://webkit.org/b/142145>
1679
1680         Reviewed by Simon Fraser.
1681
1682         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1683         (-[LTRelayController _environmentVariables]): Add.
1684         (-[LTRelayController launchApp]): Use -_environmentVariables.
1685
1686 2015-02-28  David Kilzer  <ddkilzer@apple.com>
1687
1688         [iOS] Stop running webkit-build-directory on every layout test
1689
1690         This was originally fixed by David Farler for Bug 135409 in
1691         r172602.
1692
1693         * Scripts/webkitpy/port/ios.py:
1694         (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
1695         run webkit-build-directory every time it's called.
1696
1697 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1698
1699         W3C importer should use filesystem instead of shutil/host
1700         https://bugs.webkit.org/show_bug.cgi?id=142012
1701
1702         Reviewed by Bem Jones-Bey.
1703
1704         Removed direct use of python shutil and os, except for os.walk which will require its own fix.
1705
1706         * Scripts/webkitpy/w3c/test_importer.py:
1707         (main):
1708         (TestImporter.do_import):
1709         (TestImporter.find_importable_tests):
1710         (TestImporter.import_tests):
1711         (TestImporter.remove_deleted_files):
1712         (TestImporter.write_import_log):
1713
1714 2015-02-28  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1715
1716         W3C test importer should use filesystem to read and write files
1717         https://bugs.webkit.org/show_bug.cgi?id=142084
1718
1719         Reviewed by Bem Jones-Bey.
1720
1721         Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
1722
1723         * Scripts/webkitpy/w3c/test_importer.py:
1724         (TestImporter.import_tests):
1725         (TestImporter.remove_deleted_files):
1726         (TestImporter.write_import_log):
1727
1728 2015-02-27  Sam Weinig  <sam@webkit.org>
1729
1730         Add WebKit2 SPI to create a DOM File object
1731         https://bugs.webkit.org/show_bug.cgi?id=142109
1732
1733         Reviewed by Tim Horton.
1734
1735         Add a test for WKBundleFileHandleRef.
1736
1737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1738         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
1739         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1740         (TestWebKitAPI::didFinishLoadForFrame):
1741         (TestWebKitAPI::TEST):
1742         * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
1743         (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
1744         * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
1745
1746 2015-02-27  Michael Saboff  <msaboff@apple.com>
1747
1748         Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
1749         https://bugs.webkit.org/show_bug.cgi?id=142112
1750
1751         Reviewed by Filip Pizlo.
1752
1753         Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
1754         <someDir> as the library path.
1755
1756         * Scripts/run-jsc-benchmarks:
1757
1758 2015-02-27  Alex Christensen  <achristensen@webkit.org>
1759
1760         [WinCairo] Unreviewed build fix.
1761
1762         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
1763         Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
1764
1765 2015-02-27  Anders Carlsson  <andersca@apple.com>
1766
1767         Add infrastructure for handling website data in the network process
1768         https://bugs.webkit.org/show_bug.cgi?id=142092
1769
1770         Reviewed by Andreas Kling.
1771
1772         Add a menu item that will fetch all website data, delete the returned data records, and
1773         fetch all website data again so we can confirm that it's all empty.
1774
1775         * MiniBrowser/mac/WK2BrowserWindowController.m:
1776         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1777
1778 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1779
1780         [Win] Remove remaining SafariTheme cruft
1781         https://bugs.webkit.org/show_bug.cgi?id=142075
1782
1783         Reviewed by Anders Carlsson.
1784
1785         Remove reference to SafariTheme-switching preference.
1786
1787         * DumpRenderTree/win/DumpRenderTree.cpp:
1788         (resetWebPreferencesToConsistentValues):
1789         (prepareConsistentTestingEnvironment):
1790
1791 2015-02-26  Doug Russell  <d_russell@apple.com>
1792
1793         AX: Expose caret browsing preference to accessibility API
1794         https://bugs.webkit.org/show_bug.cgi?id=141862
1795
1796         Reviewed by Chris Fleizach.
1797
1798         Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
1799         Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
1800
1801         * DumpRenderTree/AccessibilityUIElement.cpp:
1802         (setBoolAttributeValueCallback):
1803         (selectedTextMarkerRangeCallback):
1804         (resetSelectedTextMarkerRangeCallback):
1805         (AccessibilityUIElement::setBoolAttributeValue):
1806         (AccessibilityUIElement::selectedTextMarkerRange):
1807         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1808         (AccessibilityUIElement::getJSClass):
1809         * DumpRenderTree/AccessibilityUIElement.h:
1810         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1811         (AccessibilityUIElement::setBoolAttributeValue):
1812         (AccessibilityUIElement::selectedTextMarkerRange):
1813         (AccessibilityUIElement::resetSelectedTextMarkerRange):
1814         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1815         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1816         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1817         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1818         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1819         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1820         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1821         (WTR::AccessibilityUIElement::setBoolAttributeValue):
1822         (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1823         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1824
1825 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1826
1827         [Win] Remove WebKitExportGenerator project (and related)
1828         https://bugs.webkit.org/show_bug.cgi?id=142035
1829
1830         Reviewed by Dean Jackson.
1831
1832         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1833         build log from WebKitExportGenerator.
1834
1835 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1836
1837         [EFL] Bump EFL version to 1.13.0
1838         https://bugs.webkit.org/show_bug.cgi?id=141708
1839
1840         Reviewed by Gyuyoung Kim.
1841
1842         * efl/jhbuild.modules:
1843
1844 2015-02-26  Sam Weinig  <sam@webkit.org>
1845
1846         Check in missing WebEditingTester.xcconfig file.
1847
1848         * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1849
1850 2015-02-26  Csaba Osztrogonác  <ossy@webkit.org>
1851
1852         [webkitpy] Remove skipped file related crufts
1853         https://bugs.webkit.org/show_bug.cgi?id=142046
1854
1855         Reviewed by Ryosuke Niwa.
1856
1857         * Scripts/webkitpy/port/base.py:
1858         (Port.skipped_layout_tests):
1859         (Port._tests_from_skipped_file_contents): Deleted.
1860         (Port): Deleted.
1861         (Port._expectations_from_skipped_files): Deleted.
1862         * Scripts/webkitpy/port/mac_unittest.py:
1863         (MacTest.test_default_timeout_ms):
1864         (MacTest): Deleted.
1865         (test_tests_from_skipped_file_contents): Deleted.
1866
1867 2015-02-26  Brent Fulgham  <bfulgham@apple.com>
1868
1869         [Win] Unreviewed WinCairo build fix after r180653.
1870
1871         TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1872
1873         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1874         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1875         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1876         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1877         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1878
1879 2015-02-25  Brent Fulgham  <bfulgham@apple.com>
1880
1881         [Win] Use WEBCORE_EXPORT instead of Definition file
1882         https://bugs.webkit.org/show_bug.cgi?id=141734
1883
1884         Reviewed by Alex Christensen.
1885
1886         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1887         Use a precompiled header so we can define our export macros properly.
1888         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1889         Visual studio automatic update stuff.
1890         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1891         Set up Precompiled Header use for project..
1892         * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1893         * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1894         declarations for building DumpRenderTree as a client of
1895         WebCore/WebKit.
1896
1897 2015-02-25  Mark Lam  <mark.lam@apple.com>
1898
1899         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1900         <https://webkit.org/b/141672>
1901
1902         Reviewed by Alexey Proskuryakov.
1903
1904         ASan does not like the fact that we memcpy the stack for GC scans.  So,
1905         we're working around this by using our own memcpy (asanUnsafeMemcpy)
1906         implementation that we can tell ASan to ignore.
1907
1908         Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1909         which isn't effective for working around this issue. 
1910
1911         * asan/webkit-asan-ignore.txt:
1912
1913 2015-02-25  Benjamin Poulain  <bpoulain@apple.com>
1914
1915         CodeBlock crashes when dumping op_push_name_scope
1916         https://bugs.webkit.org/show_bug.cgi?id=141953
1917
1918         Reviewed by Filip Pizlo.
1919
1920         * Scripts/run-jsc-stress-tests:
1921
1922 2015-02-25  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1923
1924         W3C test importer should use argparse instead of optparse
1925         https://bugs.webkit.org/show_bug.cgi?id=142013
1926
1927         Reviewed by Bem Jones-Bey.
1928
1929         * Scripts/webkitpy/w3c/test_importer.py:
1930         (main): Updating according argparse.
1931         (parse_args): Moving from optparse to argparse.
1932
1933 2015-02-25  Brady Eidson  <beidson@apple.com>
1934
1935         Get rid of TestInvocation::pathOrURL
1936         https://bugs.webkit.org/show_bug.cgi?id=142021
1937
1938         Reviewed by Tim Horton.
1939
1940         The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1941         but most code that uses it expected an absolute path.
1942
1943         This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1944
1945         * WebKitTestRunner/TestController.cpp:
1946         (WTR::TestController::updateWebViewSizeForTest):
1947         (WTR::TestController::updateWindowScaleForTest):
1948         (WTR::shouldUseFixedLayout):
1949         (WTR::TestController::updateLayoutTypeForTest):
1950
1951         * WebKitTestRunner/TestInvocation.cpp:
1952         (WTR::TestInvocation::TestInvocation):
1953         (WTR::TestInvocation::urlContains):
1954         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1955         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1956         (WTR::TestInvocation::invoke):
1957         (WTR::shouldLogFrameLoadDelegates): Deleted.
1958         (WTR::shouldLogHistoryClientCallbacks): Deleted.
1959         * WebKitTestRunner/TestInvocation.h:
1960         (WTR::TestInvocation::pathOrURL): Deleted.
1961
1962         * WebKitTestRunner/ios/TestControllerIOS.mm:
1963         (WTR::shouldMakeViewportFlexible):
1964         (WTR::TestController::platformConfigureViewForTest):
1965
1966         * WebKitTestRunner/mac/TestControllerMac.mm:
1967         (WTR::shouldUseThreadedScrolling):
1968         (WTR::TestController::platformConfigureViewForTest):
1969
1970 2015-02-25  Brady Eidson  <beidson@apple.com>
1971
1972         Layout test support for user content filters
1973         https://bugs.webkit.org/show_bug.cgi?id=142018
1974
1975         Reviewed by Tim Horton.
1976
1977         * WebKitTestRunner/TestController.cpp:
1978         (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1979
1980         * WebKitTestRunner/mac/TestControllerMac.mm:
1981         (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1982           file before loading the test itself.
1983
1984 2015-02-24  Sam Weinig  <sam@webkit.org>
1985
1986         Convert WebEditingTester to use xcconfig files
1987         https://bugs.webkit.org/show_bug.cgi?id=141879
1988
1989         Reviewed by Darin Adler.
1990
1991         Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1992
1993         * WebEditingTester/Configurations: Added.
1994         * WebEditingTester/Configurations/Base.xcconfig: Added.
1995         * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1996         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1997
1998 2015-02-24  Andy Estes  <aestes@apple.com>
1999
2000         Teach MiniBrowser how to disable per-window web processes
2001         https://bugs.webkit.org/show_bug.cgi?id=141988
2002
2003         Reviewed by Darin Adler.
2004
2005         * MiniBrowser/mac/AppDelegate.m:
2006         (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
2007         * MiniBrowser/mac/SettingsController.h:
2008         * MiniBrowser/mac/SettingsController.m:
2009         (-[SettingsController _populateMenu]): Added a new Settings menu item.
2010         (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
2011         (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
2012         (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
2013
2014 2015-02-24  Alexey Proskuryakov  <ap@apple.com>
2015
2016         Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
2017         https://bugs.webkit.org/show_bug.cgi?id=141889
2018
2019         Reviewed by Darin Adler.
2020
2021         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2022
2023 2015-02-24  Yusuke Suzuki  <utatane.tea@gmail.com>
2024
2025         REGRESSION(r179429): Can't type comments in Facebook
2026         https://bugs.webkit.org/show_bug.cgi?id=141859
2027
2028         Reviewed by Brent Fulgham.
2029
2030         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2031
2032         * DumpRenderTree/mac/DumpRenderTree.mm:
2033         (resetWebPreferencesToConsistentValues):
2034         * DumpRenderTree/win/DumpRenderTree.cpp:
2035         (resetWebPreferencesToConsistentValues):
2036         * WebKitTestRunner/TestController.cpp:
2037         (WTR::TestController::resetPreferencesToConsistentValues):
2038
2039 2015-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2040
2041         Crash loading local file with WebPageProxy::loadAlternateHTMLString
2042         https://bugs.webkit.org/show_bug.cgi?id=141867
2043
2044         Reviewed by Anders Carlsson.
2045
2046         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2047         (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
2048         be shared with the new test.
2049         (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
2050         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
2051         (testLoadAlternateHTMLForLocalPage):
2052         (beforeAll):
2053
2054 2015-02-24  David Kilzer  <ddkilzer@apple.com>
2055
2056         [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
2057         <http://webkit.org/b/141900>
2058
2059         Reviewed by Myles C. Maxfield.
2060
2061         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2062         (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
2063         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
2064         - Rename to share code with iOS.
2065         - Add USE(APPKIT) around AppKit-specific headers and code.
2066         - Fix a check-webkit-style warning.
2067         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
2068         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2069         - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
2070         - Remove ios/ActivateFontsIOS.mm.
2071         - Fix InjectedBundle/cocoa group to represent the directory on
2072           disk.  Includes a change to InjectedBundlePageCocoa.mm.
2073
2074 2015-02-23  Commit Queue  <commit-queue@webkit.org>
2075
2076         Unreviewed, rolling out r180547 and r180550.
2077         https://bugs.webkit.org/show_bug.cgi?id=141957
2078
2079         Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
2080
2081         Reverted changesets:
2082
2083         "REGRESSION(r179429): Can't type comments in Facebook"
2084         https://bugs.webkit.org/show_bug.cgi?id=141859
2085         http://trac.webkit.org/changeset/180547
2086
2087         "Constructor returning null should construct an object instead
2088         of null"
2089         https://bugs.webkit.org/show_bug.cgi?id=141640
2090         http://trac.webkit.org/changeset/180550
2091
2092 2015-02-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2093
2094         REGRESSION(r179429): Can't type comments in Facebook
2095         https://bugs.webkit.org/show_bug.cgi?id=141859
2096
2097         Reviewed by Geoffrey Garen.
2098
2099         Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
2100
2101         * DumpRenderTree/mac/DumpRenderTree.mm:
2102         (resetWebPreferencesToConsistentValues):
2103         * WebKitTestRunner/TestController.cpp:
2104         (WTR::TestController::resetPreferencesToConsistentValues):
2105
2106 2015-02-23  KwangHyuk Kim  <hyuki.kim@samsung.com>
2107
2108         [EFL] fix eo errors
2109         https://bugs.webkit.org/show_bug.cgi?id=141909
2110
2111         Reviewed by Gyuyoung Kim.
2112
2113         Fix eo errors that occur whenever minibrowser is launched.
2114         - elm_obj_entry_text_style_user_push can only be applied for elm_entry
2115         - elm_obj_win_resize_object_add's first parameter should be elm_win
2116
2117         * MiniBrowser/efl/main.c:
2118         (window_create):
2119
2120 2015-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2121
2122         Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
2123
2124         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2125         (TestWebKitAPI::TEST):
2126
2127 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2128
2129         WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
2130         https://bugs.webkit.org/show_bug.cgi?id=141935
2131
2132         Reviewed by Myles C. Maxfield.
2133
2134         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2135         (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
2136         tests for assigning from nullptr.
2137
2138 2015-02-23  Brent Fulgham  <bfulgham@apple.com>
2139
2140         WTF::WeakPtr should have a 'forget' method.
2141         https://bugs.webkit.org/show_bug.cgi?id=141923
2142
2143         Reviewed by Myles C. Maxfield.
2144
2145         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2146         (TestWebKitAPI::TEST): Added 'Forget' tests case.
2147
2148 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2149
2150         build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
2151         https://bugs.webkit.org/show_bug.cgi?id=141920
2152
2153         Reviewed by Tim Horton.
2154
2155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2156         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2157         Do the same thing as we do for regular green bubbles.
2158
2159 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2160
2161         Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
2162         https://bugs.webkit.org/show_bug.cgi?id=141925
2163
2164         Reviewed by Tim Horton.
2165
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2167         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2168
2169 2015-02-23  Anders Carlsson  <andersca@apple.com>
2170
2171         Add API for fetching website data records to _WKWebsiteDataStore
2172         https://bugs.webkit.org/show_bug.cgi?id=141926
2173
2174         Reviewed by Beth Dakin.
2175
2176         * MiniBrowser/mac/MainMenu.xib:
2177         * MiniBrowser/mac/WK2BrowserWindowController.m:
2178         (-[WK2BrowserWindowController fetchWebsiteData:]):
2179         Add menu item to fetch and dump website data.
2180
2181 2015-02-23  David Kilzer  <ddkilzer@apple.com>
2182
2183         [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
2184         <http://webkit.org/b/141884>
2185
2186         Reviewed by Alexey Proskuryakov.
2187
2188         * Scripts/webkitpy/port/leakdetector.py:
2189         (LeakDetector._callstacks_to_exclude_from_leaks): Remove
2190         snowleopard, lion and older leaks.  Add known leak for
2191         mavericks, but check Port.operating_system before calling
2192         Port.is_mavericks.
2193         * Scripts/webkitpy/port/mac.py:
2194         (MacPort.is_snowleopard): Delete.
2195         (MacPort.is_lion): Delete.
2196         (MacPort.is_mavericks): Add.
2197
2198 2015-02-23  Alexey Proskuryakov  <ap@apple.com>
2199
2200         build.webkit.org/dashboard should filter out commits to other branches
2201         https://bugs.webkit.org/show_bug.cgi?id=140362
2202
2203         Reviewed by Tim Horton.
2204
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2206         (BuildbotQueue):
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2208         (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
2209         (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
2210         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
2211         (BuildbotQueueView.prototype.revisionContentForIteration):
2212         (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
2213         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
2214         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2216         (Trac.prototype.get oldestRecordedRevisionNumber):
2217         (Trac.prototype.commitsOnBranch):
2218         (Trac.prototype._xmlTimelineURL):
2219         (Trac.prototype._convertCommitInfoElementToObject):
2220         (Trac.prototype._update):
2221         (Trac.prototype.startPeriodicUpdates):
2222         (Trac.prototype.loadMoreHistoricalData):
2223         (Trac.prototype.update): Deleted.
2224
2225 2015-02-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2226
2227         Tests don't work on some bots: Failed to stop wptwk
2228         https://bugs.webkit.org/show_bug.cgi?id=141235
2229
2230         Reviewed by Ryosuke Niwa.
2231
2232         Logging of server subprocesses in launcher script.
2233         Killing of server subprocesses when stopping/before starting.
2234         Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
2235
2236         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2237         (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown. 
2238         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2239         (WebPlatformTestServer.__init__):
2240         (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
2241         (WebPlatformTestServer):
2242         (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
2243         (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown. 
2244         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2245         (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
2246         (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
2247         (TestWebPlatformTestServer):
2248         (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
2249
2250 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2251
2252         [WebEditingTester] Allow dropping HTML files on the app
2253         https://bugs.webkit.org/show_bug.cgi?id=141834
2254
2255         Reviewed by Simon Fraser.
2256
2257         * WebEditingTester/AppDelegate.m:
2258         (-[WebEditingAppDelegate openDocument:]):
2259         (-[WebEditingAppDelegate application:openFile:]):
2260         Implement application:openFile:, factoring file loading code out of openDocument.
2261
2262         * WebEditingTester/Info.plist:
2263         Register as an editor for HTML files.
2264
2265         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2266         Enrica is not an organization.
2267
2268 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2269
2270         [WebEditingTester] Expand "WK" to "WebKit" in a few places
2271         https://bugs.webkit.org/show_bug.cgi?id=141833
2272
2273         Reviewed by Anders Carlsson.
2274
2275         * WebEditingTester/AppDelegate.h:
2276         * WebEditingTester/AppDelegate.m:
2277         (-[WebEditingAppDelegate newEditor:]):
2278         (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
2279         (-[WebEditingAppDelegate validateMenuItem:]):
2280         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2281         (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
2282         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2283         (-[WebEditingAppDelegate showOperations:]): Deleted.
2284         * WebEditingTester/MainMenu.xib:
2285         The WK abbreviation is unnaturally grating in menu items for some reason.
2286
2287 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2288
2289         [WebEditingTester] Add a custom protocol for loading canned content
2290         https://bugs.webkit.org/show_bug.cgi?id=141830
2291
2292         Reviewed by Enrica Casucci.
2293
2294         Add a canned:// protocol handler, which can be used to emulate behaviors
2295         in WebKit client apps (like Mail) that use custom protocol handlers,
2296         which can have important effects on editing (mostly, the URLs are only
2297         valid inside of the client application, but not when copied/dragged out).
2298
2299         For now, we only support two canned files:
2300
2301             canned://dice is a PNG of dice (stolen from LayoutTests/)
2302             canned://text is the string "canned text" served as text/html
2303
2304         In the future we could support things like very large (generated) files,
2305         progressive loading, etc. to further simulate conditions in other apps.
2306
2307         * WebEditingTester/AppDelegate.m:
2308         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2309         Register the protocol with CFNetwork, and the scheme with WebKit2.
2310
2311         * WebEditingTester/Canned Content/dice.png: Added.
2312         * WebEditingTester/CannedContent.h: Added.
2313         * WebEditingTester/CannedContent.m: Added.
2314         (-[CannedContent initWithRequest:cachedResponse:client:]):
2315         (+[CannedContent canonicalRequestForRequest:]):
2316         (+[CannedContent canInitWithRequest:]):
2317         We only want to handle canned:// URLs.
2318
2319         (-[CannedContent startLoading]):
2320         For now, immediately load the two files we know about.
2321         Otherwise, immediately fail the load.
2322
2323         (-[CannedContent stopLoading]):
2324         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2325
2326 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2327
2328         [WebEditingTester] Implement an open panel
2329         https://bugs.webkit.org/show_bug.cgi?id=141829
2330
2331         Reviewed by Simon Fraser.
2332
2333         * WebEditingTester/AppDelegate.m:
2334         (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
2335         (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
2336         (-[WebEditingAppDelegate openDocument:]):
2337         Add an open panel (with radio buttons to pick which WebKit to open with).
2338         Loads the file as an HTML string.
2339
2340 2015-02-20  Simon Fraser  <simon.fraser@apple.com>
2341
2342         [WebEditingTester] @properties, dot syntax, and remember the window position
2343         https://bugs.webkit.org/show_bug.cgi?id=141843
2344
2345         Reviewed by Tim Horton.
2346         
2347         Modernize a bit with more dot syntax, use @property for the web views,
2348         and give the main window an Autosave name so it remembers the widow position.
2349
2350         * WebEditingTester/WK1WebDocumentController.m:
2351         (-[WK1WebDocumentController awakeFromNib]):
2352         (-[WK1WebDocumentController loadHTMLString:]):
2353         * WebEditingTester/WK2WebDocumentController.m:
2354         (-[WK2WebDocumentController awakeFromNib]):
2355         * WebEditingTester/WebDocument.xib:
2356
2357 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2358
2359         [WebEditingTester] Hook up key equivalents for new window action
2360         https://bugs.webkit.org/show_bug.cgi?id=141828
2361
2362         Reviewed by Enrica Casucci.
2363
2364         * WebEditingTester/AppDelegate.h:
2365         * WebEditingTester/AppDelegate.m:
2366         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2367         (-[WebEditingAppDelegate newEditor:]):
2368         (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
2369         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2370         (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
2371         (defaultConfiguration): Deleted.
2372         (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
2373         Move WKWebViewConfiguration setup into WK2WebDocumentController.
2374         Remove unused application termination code.
2375         Update new-window menu item key equivalents when launching and when
2376         changing the use-WebKit2-by-default setting.
2377         Make WebDocumentController subclasses all initialized the same way,
2378         and use that to factor out alloc/init.
2379         Rename loadContent to loadHTMLString for future use.
2380
2381         * WebEditingTester/MainMenu.xib:
2382         Add default key equivalents.
2383         Cmd-N will always make the default kind of window (controlled by the pref).
2384         Cmd-Opt-N will always make the other kind.
2385         The menu items are configured as alternates so they only show up if you
2386         press alt (just like in MiniBrowser).
2387
2388         * WebEditingTester/WK1WebDocumentController.m:
2389         (-[WK1WebDocumentController loadHTMLString:]):
2390         (-[WK1WebDocumentController loadContent]): Deleted.
2391         * WebEditingTester/WK2WebDocumentController.h:
2392         * WebEditingTester/WK2WebDocumentController.m:
2393         (defaultConfiguration):
2394         (-[WK2WebDocumentController awakeFromNib]):
2395         (-[WK2WebDocumentController loadHTMLString:]):
2396         (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
2397         (-[WK2WebDocumentController dealloc]): Deleted.
2398         * WebEditingTester/WebDocumentController.h:
2399         * WebEditingTester/WebDocumentController.m:
2400         (-[WebDocumentController init]):
2401         (-[WebDocumentController initWithWindow:]):
2402         (+[WebDocumentController defaultEditingSource]):
2403         (-[WebDocumentController loadHTMLString:]):
2404         (-[WebDocumentController windowDidLoad]): Deleted.
2405         (-[WebDocumentController defaultEditingSource]): Deleted.
2406         (-[WebDocumentController applicationTerminating]): Deleted.
2407         (-[WebDocumentController loadContent]): Deleted.
2408
2409 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2410
2411         [WebEditingTester] ARC-ify WebEditingTester
2412         https://bugs.webkit.org/show_bug.cgi?id=141827
2413
2414         Reviewed by Sam Weinig.
2415
2416         * WebEditingTester/AppDelegate.m:
2417         (-[WebEditingAppDelegate showOperations:]):
2418         * WebEditingTester/EditingOperations.m:
2419         (editingOperations):
2420         * WebEditingTester/WK1WebDocumentController.m:
2421         (-[WK1WebDocumentController dealloc]): Deleted.
2422         * WebEditingTester/WK2WebDocumentController.m:
2423         (-[WK2WebDocumentController dealloc]): Deleted.
2424         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2425         Turn on ARC and remove a few retain/release/autorelease calls.
2426         We don't need to implement dealloc in either document controller
2427         because WebView and WKWebView's UIDelegate property does not hold a
2428         strong reference.
2429
2430 2015-02-20  Timothy Horton  <timothy_horton@apple.com>
2431
2432         [WebEditingTester] Factor out list of editing operations
2433         https://bugs.webkit.org/show_bug.cgi?id=141826
2434
2435         Reviewed by Sam Weinig.
2436
2437         * WebEditingTester/AppDelegate.m:
2438         (-[WebEditingAppDelegate showOperations:]):
2439         * WebEditingTester/EditingOperations.h: Added.
2440         * WebEditingTester/EditingOperations.m: Added.
2441         (editingOperations):
2442         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
2443         Move EditingOperations array to its own file, and make it an NSArray
2444         instead of a C array. Adjust accordingly in showOperations:.
2445
2446 2015-02-20  Michael Saboff  <msaboff@apple.com>
2447
2448         DFG JIT needs to check for stack overflow at the start of Program and Eval execution
2449         https://bugs.webkit.org/show_bug.cgi?id=141676
2450
2451         Reviewed by Filip Pizlo.
2452
2453         Set the newly added --maximumEvalCacheableSourceLength option for eager test runs.  This is needed
2454         to allow the eval out of stack tests to tier up.  Without this option, we don't cache the likely
2455         large string expression that we want to eval.
2456
2457         * Scripts/run-jsc-stress-tests:
2458
2459 2015-02-19  Daniel Bates  <dabates@apple.com>
2460
2461         REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
2462         https://bugs.webkit.org/show_bug.cgi?id=141815
2463         <rdar://problem/19893933>
2464
2465         Reviewed by Simon Fraser.
2466
2467         Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
2468         was booted by iOS Simulator in a previous run of run-webkit-test.
2469
2470         * Scripts/webkitpy/port/ios.py:
2471         (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
2472         (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
2473         testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
2474
2475 2015-02-19  David Kilzer  <ddkilzer@apple.com>
2476
2477         check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
2478         <http://webkit.org/b/141799>
2479
2480         Reviewed by Alex Christensen.
2481
2482         * Scripts/webkitpy/style/checkers/cpp.py:
2483         (_IncludeState.check_next_include_order): Don't emit a warning
2484         if the primary header exists and the source file name ends with
2485         "SoftLink.cpp".  Add 'filename' argument to method.
2486         (check_include_line): Pass in 'filename'.
2487
2488         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2489         (OrderOfIncludesTest.test_check_next_include_order__no_config):
2490         (OrderOfIncludesTest.test_check_next_include_order__no_self):
2491         (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
2492         (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
2493         (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
2494         - Add test filename arguments for calls to
2495           check_next_include_order().
2496         (OrderOfIncludesTest.test_primary_header): Add test for a file
2497         name ending in "SoftLink.cpp".
2498
2499 2015-02-18  Enrica Casucci  <enrica@apple.com>
2500
2501         Add new tool to test editable Webviews.
2502         https://bugs.webkit.org/show_bug.cgi?id=141772
2503
2504         Reviewed by Tim Horton.
2505
2506         Adding WebEditingTester, a Cocoa application to
2507         test WK1 and Wk2 views in editable mode.
2508
2509         * WebEditingTester: Added.
2510         * WebEditingTester/AppDelegate.h: Added.
2511         * WebEditingTester/AppDelegate.m: Added.
2512         (-[WebEditingAppDelegate init]):
2513         (defaultConfiguration):
2514         (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
2515         (-[WebEditingAppDelegate applicationWillTerminate:]):
2516         (-[WebEditingAppDelegate newEditor:]):
2517         (-[WebEditingAppDelegate showOperations:]):
2518         (-[WebEditingAppDelegate useWebKit2ByDefault]):
2519         (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
2520         (-[WebEditingAppDelegate validateMenuItem:]):
2521         * WebEditingTester/Info.plist: Added.
2522         * WebEditingTester/MainMenu.xib: Added.
2523         * WebEditingTester/WK1WebDocumentController.h: Added.
2524         * WebEditingTester/WK1WebDocumentController.m: Added.
2525         (-[WK1WebDocumentController awakeFromNib]):
2526         (-[WK1WebDocumentController loadContent]):
2527         (-[WK1WebDocumentController dealloc]):
2528         (-[WK1WebDocumentController pasteAsMarkup:]):
2529         * WebEditingTester/WK2WebDocumentController.h: Added.
2530         * WebEditingTester/WK2WebDocumentController.m: Added.
2531         (-[WK2WebDocumentController initWithConfiguration:]):
2532         (-[WK2WebDocumentController pasteAsMarkup:]):
2533         (-[WK2WebDocumentController awakeFromNib]):
2534         (-[WK2WebDocumentController dealloc]):
2535         (-[WK2WebDocumentController loadContent]):
2536         * WebEditingTester/WebDocument.xib: Added.
2537         * WebEditingTester/WebDocumentController.h: Added.
2538         * WebEditingTester/WebDocumentController.m: Added.
2539         (-[WebDocumentController initWithWindow:]):
2540         (-[WebDocumentController windowDidLoad]):
2541         (-[WebDocumentController defaultEditingSource]):
2542         (-[WebDocumentController applicationTerminating]):
2543         (-[WebDocumentController loadContent]):
2544         * WebEditingTester/WebEditingTester.xcodeproj: Added.
2545         * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
2546         * WebEditingTester/main.m: Added.
2547         (main):
2548
2549 2015-02-18  Csaba Osztrogonác  <ossy@webkit.org>
2550
2551         Run JSC tests on ARM EFL bots
2552         https://bugs.webkit.org/show_bug.cgi?id=141165
2553
2554         Reviewed by Alexey Proskuryakov.
2555
2556         * BuildSlaveSupport/build.webkit.org-config/config.json:
2557         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2558         (RunJavaScriptCoreTests.countFailures):
2559         (RunRemoteJavaScriptCoreTests):
2560         (RunRemoteJavaScriptCoreTests.start):
2561         (BuildAndRemoteJSCTestsFactory):
2562         (BuildAndRemoteJSCTestsFactory.__init__):
2563
2564 2015-02-18  Alexey Proskuryakov  <ap@apple.com>
2565
2566         Streamline unexported function build fixes
2567         https://bugs.webkit.org/show_bug.cgi?id=141761
2568
2569         Reviewed by Alex Christensen.
2570
2571         * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
2572         We don't need to ignore symbols that are not exported due to the .unexp file.
2573
2574 2015-02-18  Timothy Horton  <timothy_horton@apple.com>
2575
2576         Remove more references to WebCore.exp.in
2577         https://bugs.webkit.org/show_bug.cgi?id=141747
2578
2579         Reviewed by Alexey Proskuryakov.
2580
2581         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2582         (ShouldBuildTest):
2583
2584 2015-02-17  Myles C. Maxfield  <mmaxfield@apple.com>
2585
2586         Windows test results should not fall back to mac-mountainlion after r180176
2587         https://bugs.webkit.org/show_bug.cgi?id=141719
2588
2589         Reviewed by Brent Fulgham.
2590
2591         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2592         (_should_file_trigger_build):
2593         * Scripts/webkitpy/port/win.py:
2594         (WinPort.default_baseline_search_path):
2595         * Scripts/webkitpy/port/win_unittest.py:
2596         (WinPortTest.test_baseline_search_path):
2597
2598 2015-02-17  Daniel Bates  <dabates@apple.com>
2599
2600         [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
2601         https://bugs.webkit.org/show_bug.cgi?id=141718
2602
2603         Reviewed by Alex Christensen.
2604
2605         We should only run layout tests if simctl can successfully boot and shutdown the testing device.
2606
2607         * Scripts/webkitpy/port/ios.py:
2608         (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
2609         Log a error and return False if we are unable to boot the simulator device so that the caller can take
2610         appropriate action, say exit(3) before running any layout tests.
2611         * Scripts/webkitpy/xcode/simulator.py:
2612         (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
2613         with the specified UDID.
2614         (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
2615         with the specified UDID can successfully boot and shut down. We make at most two attempts to
2616         boot and shut down the device, erasing the device between tries so as to restore the device
2617         to a known good state.
2618
2619 2015-02-17  Daniel Bates  <dabates@apple.com>
2620
2621         run_webkit_tests.py should not know about iOS Simulator details
2622         https://bugs.webkit.org/show_bug.cgi?id=141711
2623
2624         Reviewed by Alex Christensen.
2625
2626         Run_webkit_tests.py should only parse the iOS-specific command
2627         line options --runtime and --device-type. Let the port-specific
2628         logic in ios.py validate the parsed options and instantiate
2629         internal data structures.
2630
2631         Currently run_webkit_tests.py parses the iOS-specific command
2632         line options --runtime and --device-type, validates them, and
2633         instantiates internal data structures from the parsed strings.
2634         Instead the validation logic and instantiation of internal
2635         data structures should be handled by the iOS port object.
2636
2637         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2638         (_set_up_derived_options): Remove logic to validate --runtime and --device-type
2639         and instantiate internal data structures for them.
2640         * Scripts/webkitpy/port/driver.py:
2641         (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
2642         and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
2643         respectively.
2644         * Scripts/webkitpy/port/ios.py: Sort the list of imports.
2645         (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
2646         object from --runtime, if specified. Otherwise, instantiates a Runtime
2647         object for the latest installed iphonesimulator SDK version.
2648         (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
2649         object from --device-type, if specified. Otherwise, instantiates
2650         a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
2651         machine, respectively.
2652         (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
2653         runtime is available to use.
2654         (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
2655         and simulator_runtime for the iOS Simulator device type and runtime, respectively.
2656         * Scripts/webkitpy/xcode/simulator.py:
2657         (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
2658         with a runtime identifier for the specified iOS version.
2659
2660 2015-02-17  Dana Burkart  <dburkart@apple.com>
2661
2662         ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
2663         https://bugs.webkit.org/show_bug.cgi?id=141672
2664
2665         Reviewed by David Kilzer.
2666
2667         * asan/webkit-asan-ignore.txt:
2668
2669 2015-02-17  Alex Christensen  <achristensen@webkit.org>
2670
2671         Remove WebCore.exp.in and clean up.
2672         https://bugs.webkit.org/show_bug.cgi?id=141491
2673
2674         Reviewed by Andreas Kling.
2675
2676         * Scripts/sort-export-file: Removed.
2677         * Scripts/webkitpy/style/checker.py:
2678         (_all_categories):
2679         (FileType):
2680         (CheckerDispatcher._file_type):
2681         (CheckerDispatcher._create_checker):
2682         Don't check if the export files are sorted.
2683         * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
2684         * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
2685
2686 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2687
2688         Unreviewed. Fix GTK+ make distcheck.
2689
2690         Do not exclude bmalloc directory from the tarball.
2691
2692         * gtk/manifest.txt.in:
2693
2694 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2695
2696         Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
2697
2698         I forgot to add the return of a bool function.
2699
2700         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2701         (WebKitDOMNodeTest::testDOMCache):
2702
2703 2015-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2704
2705         [GTK] GObject DOM bindings object are cached forever
2706         https://bugs.webkit.org/show_bug.cgi?id=141558
2707
2708         Reviewed by Sergio Villar Senin.
2709
2710         Add checks for all DOM objects to ensure they are not leaked. Also
2711         add a dedicated test for the DOM Object Cache.
2712
2713         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
2714         (WebKitDOMNodeFilterTest::testTreeWalker):
2715         (WebKitDOMNodeFilterTest::testNodeIterator):
2716         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2717         (WebKitDOMNodeTest::testHierarchyNavigation):
2718         (WebKitDOMNodeTest::testInsertion):
2719         (WebKitDOMNodeTest::testTagNames):
2720         (WebKitDOMNodeTest::testDOMCache):
2721         (registerTests):
2722         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
2723         (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
2724         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
2725         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
2726         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2727         (testWebKitDOMObjectCache):
2728         (beforeAll):
2729         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2730         (documentLoadedCallback):
2731
2732 2015-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
2733
2734         [GTK] WebKitFrame objects are never released
2735         https://bugs.webkit.org/show_bug.cgi?id=141641
2736
2737         Reviewed by Martin Robinson.
2738
2739         Add a way to check GObjects leaks for WebProcess tests and check
2740         WebKitFrame objects are not leaked.
2741
2742         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
2743         (WebKitFrameTest::testMainFrame):
2744         (WebKitFrameTest::testURI):
2745         (WebKitFrameTest::testJavaScriptContext):
2746         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2747         (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
2748         (runTest):
2749         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2750
2751 2015-02-16  Tim Horton  <timothy_horton@apple.com>
2752
2753         Fix the MiniBrowser build with newer clang
2754
2755         * MiniBrowser/mac/SettingsController.m:
2756         (-[SettingsController _toggleBooleanDefault:]):
2757         * MiniBrowser/mac/WK1BrowserWindowController.m:
2758         (-[WK1BrowserWindowController windowWillClose:]):
2759         * MiniBrowser/mac/WK2BrowserWindowController.m:
2760         (-[WK2BrowserWindowController windowWillClose:]):
2761         NSApp is id and clang gets confused about which -delegate we're talking about.
2762
2763 2015-02-16  Antti Koivisto  <antti@apple.com>
2764
2765         Develop/Disable Caches does not properly disable disk cache
2766         https://bugs.webkit.org/show_bug.cgi?id=141636
2767
2768         Reviewed by Anders Carlsson.
2769
2770         Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
2771         the network process too.
2772
2773         This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
2774
2775         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2776         (WTR::InjectedBundle::beginTesting):
2777         (WTR::InjectedBundle::setCacheModel):
2778         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2779         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2780
2781             Forward to TestController.
2782
2783         (WTR::TestRunner::setCacheModel):
2784         * WebKitTestRunner/TestInvocation.cpp:
2785         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2786
2787 2015-02-16  Andrzej Badowski  <a.badowski@samsung.com>
2788
2789         Unreviewed. Add myself as a committer.
2790
2791         * Scripts/webkitpy/common/config/contributors.json:
2792
2793 2015-02-15  David Kilzer  <ddkilzer@apple.com>
2794
2795         REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
2796         <http://webkit.org/b/141607>
2797
2798         * Scripts/check-for-weak-vtables-and-externals: Ignore weak
2799         externals in Source/WebCore/Configurations/WebCore.unexp when
2800         building with Xcode 5.x.
2801         (readXcode5SymbolsToIgnore): Add.
2802
2803 2015-02-15  KwangHyuk Kim  <hyuki.kim@samsung.com>
2804
2805         [EFL] fix Evas GL engine error.
2806         https://bugs.webkit.org/show_bug.cgi?id=141621
2807
2808         Reviewed by Gyuyoung Kim.
2809
2810         As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2811
2812         * MiniBrowser/efl/main.c:
2813         (elm_main):
2814
2815 2015-02-14  Csaba Osztrogonác  <ossy@webkit.org>
2816
2817         [buildbot] Enable run-api-tests on release Mac bots
2818         https://bugs.webkit.org/show_bug.cgi?id=141518
2819
2820         Reviewed by Darin Adler.
2821
2822         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2823         (RunUnitTests):
2824         (BuildFactory.__init__):
2825         (TestFactory.__init__):
2826         (BuildAndTestFactory.__init__):
2827         (RunUnitTests.start): Deleted.
2828         (unitTestsSupported): Deleted.
2829
2830 2015-02-13  Anders Carlsson  <andersca@apple.com>
2831
2832         Add a move constructor and move assignment operator to Deque
2833         https://bugs.webkit.org/show_bug.cgi?id=141571
2834
2835         Reviewed by Andreas Kling.
2836
2837         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2838         (TestWebKitAPI::TEST):
2839
2840 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2841
2842         run-jsc-stress-tests --remote should skip profiler tests
2843         https://bugs.webkit.org/show_bug.cgi?id=141470
2844
2845         Reviewed by Filip Pizlo.
2846
2847         * Scripts/run-jsc-stress-tests:
2848
2849 2015-02-13  Anders Carlsson  <andersca@apple.com>
2850
2851         Add an initializer list constructor to Deque
2852         https://bugs.webkit.org/show_bug.cgi?id=141565
2853
2854         Reviewed by Andreas Kling.
2855
2856         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2857         (TestWebKitAPI::TEST):
2858
2859 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2860
2861         [buildbot] Remove buildJSCTool cruft from master.cfg
2862         https://bugs.webkit.org/show_bug.cgi?id=141513
2863
2864         Reviewed by Alexey Proskuryakov.
2865
2866         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2867         (RunJavaScriptCoreTests):
2868         (RunJavaScriptCoreTests.start):
2869         (RunWebKitTests):
2870         (RunWebKitTests.start):
2871         (TestFactory.__init__):
2872         (TestLeaksFactory.__init__):
2873         (RunJavaScriptCoreTests.__init__): Deleted.
2874         (RunWebKitTests.__init__): Deleted.
2875
2876 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2877
2878         Unreviewed, remove empty directories.
2879
2880         * DumpRenderTree/gtk: Removed.
2881         * DumpRenderTree/gtk/fonts: Removed.
2882         * DumpRenderTree/unix: Removed.
2883         * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2884         * GtkLauncher: Removed.
2885         * TestWebKitAPI/Tests/WebKitGtk: Removed.
2886         * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2887         * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2888         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2889
2890 2015-02-13  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2893         https://bugs.webkit.org/show_bug.cgi?id=141519
2894
2895         Reviewed by Alexey Proskuryakov.
2896
2897         * Scripts/build-webkittestrunner:
2898
2899 2015-02-12  Alex Christensen  <achristensen@webkit.org>
2900
2901         Removed empty directory.
2902
2903         * WinCELauncher: Removed.
2904
2905 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2906
2907         run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2908         https://bugs.webkit.org/show_bug.cgi?id=141202
2909
2910         Reviewed by Darin Adler.
2911
2912         * Scripts/run-jsc-stress-tests:
2913
2914 2015-02-12  Brent Fulgham  <bfulgham@apple.com>
2915
2916         [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2917         https://bugs.webkit.org/show_bug.cgi?id=141517
2918
2919         Reviewed by Anders Carlsson.
2920
2921         We do not need to locate or use the DLL's that came with Safari, so stop
2922         failing when we cannot find them. Also remove some old Qt cruft from this
2923         script.
2924
2925         * BuildSlaveSupport/built-product-archive:
2926         (archiveBuiltProduct): 
2927         (extractBuiltProduct):
2928
2929 2015-02-11  Brent Fulgham  <bfulgham@apple.com>
2930
2931         [Win] [64-bit] Work around MSVC2013 Runtime Bug
2932         https://bugs.webkit.org/show_bug.cgi?id=141498
2933         <rdar://problem/19803642>
2934
2935         Reviewed by Anders Carlsson.
2936
2937         Disable FMA3 instruction use in the MSVC math library to
2938         work around a VS2013 runtime crash. We can remove this
2939         workaround when we switch to VS2015.
2940
2941         * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2942         disable FMA3 support.
2943         * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2944         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2945         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2946         * Scripts/webkitperl/httpd.pm: Ditto.
2947         * TestWebKitAPI/win/main.cpp: Ditto.
2948         * WinLauncher/Common.cpp: Ditto.
2949         * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2950
2951 2015-02-12  Csaba Osztrogonác  <ossy@webkit.org>
2952
2953         run-jsc-stress-tests should accept remote host config from JSON file
2954         https://bugs.webkit.org/show_bug.cgi?id=141509
2955
2956         Reviewed by Michael Saboff.
2957
2958         * Scripts/run-javascriptcore-tests:
2959         (runJSCStressTests):
2960         * Scripts/run-jsc-stress-tests:
2961
2962 2015-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2963
2964         [GTK] Add API to allow overriding the default color chooser implementation
2965         https://bugs.webkit.org/show_bug.cgi?id=98935
2966
2967         Reviewed by Gustavo Noronha Silva.
2968
2969         Add a color chooser implementation for MiniBrowser using
2970         GtkPopover when the GTK+ version is recent enough.
2971         And a test case to check the new color chooser API.
2972
2973         * MiniBrowser/gtk/BrowserWindow.c:
2974         (colorChooserRGBAChanged):
2975         (popoverColorClosed):
2976         (colorChooserRequestFinished):
2977         (runColorChooserCallback):
2978         (browserWindowConstructed):
2979         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2980         (testWebViewColorChooserRequest):
2981         (beforeAll):
2982
2983 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2984
2985         Make run-jsc-stress-tests --remote work with make-based runner
2986         https://bugs.webkit.org/show_bug.cgi?id=141079
2987
2988         Reviewed by Darin Adler.
2989
2990         * Scripts/run-javascriptcore-tests:
2991         (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2992         * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2993         except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2994         to avoid code duplication.
2995
2996 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
2997
2998         run-jsc-stress tests should detect the number of processors on the remote machine too
2999         https://bugs.webkit.org/show_bug.cgi?id=141196
3000
3001         Reviewed by Darin Adler.
3002
3003         * Scripts/run-javascriptcore-tests:
3004         (runJSCStressTests): Pass through the --child-processes argument.
3005         * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
3006         to detect the number of local and remote processors with the same algorithm.
3007         Additionally introduced $numChildProcesses to emphasize it isn't necessarily
3008         same as $numProcessors.
3009
3010 2015-02-11  Csaba Osztrogonác  <ossy@webkit.org>
3011
3012         run-jsc-stress-tests should pass JSC_timeout to remote hosts
3013         https://bugs.webkit.org/show_bug.cgi?id=141164
3014
3015         Reviewed by Darin Adler.
3016
3017         Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
3018
3019         * Scripts/run-jsc-stress-tests:
3020
3021 2015-02-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3022
3023         [GTK] Add default color chooser implementation using GtkColorChooserDialog
3024         https://bugs.webkit.org/show_bug.cgi?id=141392
3025
3026         Reviewed by Gustavo Noronha Silva.
3027
3028         Enable INPUT_TYPE_COLOR by default for GTK+ port.
3029
3030         * Scripts/webkitperl/FeatureList.pm:
3031
3032 2015-02-09  Csaba Osztrogonác  <ossy@webkit.org>
3033
3034         run-jsc-stress-tests shell test runner should run tests in fixed order
3035         https://bugs.webkit.org/show_bug.cgi?id=141383
3036
3037         Reviewed by Darin Adler.
3038
3039         * Scripts/jsc-stress-test-helpers/shell-runner.sh:
3040
3041 2015-02-08  Chris Fleizach  <cfleizach@apple.com>
3042
3043         AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
3044         https://bugs.webkit.org/show_bug.cgi?id=140485
3045
3046         Reviewed by Anders Carlsson.
3047
3048         Implement takeFocus() as a way to set focus through accessibility wrappers.
3049
3050         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3051         (AccessibilityUIElement::takeFocus):
3052         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3053         (WTR::AccessibilityUIElement::takeFocus):
3054
3055 2015-02-08  Darin Adler  <darin@apple.com>
3056
3057         Remove the SVG instance tree
3058         https://bugs.webkit.org/show_bug.cgi?id=140602
3059
3060         Reviewed by Dean Jackson.
3061
3062         * Scripts/check-for-global-initializers: Removed special case for
3063         SVGElementInstance.o.
3064
3065 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3066
3067         [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
3068         <http://webkit.org/b/141365>
3069
3070         Reviewed by Daniel Bates.
3071
3072         * Scripts/webkitpy/xcode/simulator.py:
3073         (Simulator): Add unavailable_version_re precompiled regex.
3074         (Simulator._parse_devices): Check for unavailable versions and
3075         ignore them if found when parsing the output of
3076         `xcrun simctl list`.
3077         * Scripts/webkitpy/xcode/simulator_unittest.py:
3078         (test_unavailable_devices): Add test with output from
3079         `xcrun simctl list` with unavailable runtimes that fails before
3080         the fix.
3081
3082 2015-02-07  Chris Dumez  <cdumez@apple.com>
3083
3084         Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
3085         https://bugs.webkit.org/show_bug.cgi?id=141321
3086
3087         Reviewed by Darin Adler.
3088
3089         Use new Vector::removeFirstMatching() / removeAllMatching() methods.
3090
3091 2015-02-07  David Kilzer  <ddkilzer@apple.com>
3092
3093         [iOS] Make Simulator class testable
3094         <http://webkit.org/b/141358>
3095
3096         Rubber-stamped by Darin Adler.
3097
3098         * Scripts/webkitpy/common/system/platforminfo.py:
3099         (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
3100         command to here from Simulator.refresh() in xcode/simulator.py
3101         so that the output of the command can be mocked.
3102
3103         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3104         (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
3105         to None.
3106         (MockPlatformInfo.xcode_simctl_list): Add method that returns
3107         self.expected_xcode_simctl_list expectation.
3108
3109         * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
3110         and license header.
3111         (Simulator.__init__): Add optional 'host' parameter to make it
3112         possible to pass in a mock object for testing.  Set self._host
3113         to 'host' parameter or create Host() object.
3114         (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
3115         method.
3116
3117         * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
3118         for current code.
3119         (SimulatorTest):
3120         (SimulatorTest.setUp):
3121         (SimulatorTest._set_expected_xcrun_simctl_list):
3122         (SimulatorTest.test_simulator_device_types):
3123         (test_invalid_device_types_header):
3124         (test_invalid_runtimes_header):
3125         (test_invalid_devices_header):
3126
3127 2015-02-07  Csaba Osztrogonác  <ossy@webkit.org>
3128
3129         run-jsc-stress-tests --remote should use the default ssh port
3130         https://bugs.webkit.org/show_bug.cgi?id=141287
3131
3132         Reviewed by Darin Adler.
3133
3134         * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
3135
3136 2015-02-06  Dana Burkart  <dburkart@apple.com>
3137
3138         dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
3139         https://bugs.webkit.org/show_bug.cgi?id=141349
3140
3141         Reviewed by Alexey Proskuryakov.
3142
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3144         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3145         (BuildbotTesterQueueView.prototype.update):
3146
3147 2015-02-06  Alexey Proskuryakov  <ap@apple.com>
3148
3149         Report network process crashes during layout tests
3150         https://bugs.webkit.org/show_bug.cgi?id=139646
3151
3152         Reviewed by Anders Carlsson.
3153
3154         * WebKitTestRunner/TestController.cpp:
3155         (WTR::TestController::initialize):
3156         (WTR::TestController::networkProcessName):
3157         (WTR::TestController::networkProcessDidCrash):
3158         * WebKitTestRunner/TestController.h:
3159
3160 2015-02-06  Csaba Osztrogonác  <ossy@webkit.org>
3161
3162         run-jsc-stress-tests --remote should create remote directory before copying the bundle
3163         https://bugs.webkit.org/show_bug.cgi?id=141329
3164
3165         Reviewed by Michael Saboff.
3166
3167         * Scripts/run-jsc-stress-tests:
3168
3169 2015-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3170
3171         [GTK] Remove WebKitWebView::close-notification signal
3172         https://bugs.webkit.org/show_bug.cgi?id=141330
3173
3174         Reviewed by Gustavo Noronha Silva.
3175
3176         Update notifications unit tests according to the API changes, and
3177         add a test case to check that onclose event is fired when a
3178         notification is closed by the user.
3179
3180         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3181         (testWebViewNotification):
3182
3183 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3184
3185         Dashboard doesn't consider building ASan a productive step
3186         https://bugs.webkit.org/show_bug.cgi?id=141312
3187
3188         Reviewed by Simon Fraser.
3189
3190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3191
3192 2015-02-05  Daniel Bates  <dabates@apple.com>
3193
3194         [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
3195         https://bugs.webkit.org/show_bug.cgi?id=141306
3196
3197         Reviewed by Alexey Proskuryakov.
3198
3199         The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
3200         corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
3201         existent runtime.
3202
3203         * Scripts/webkitpy/xcode/simulator.py:
3204         (Runtime.from_identifier):
3205
3206 2015-02-05  Daniel Bates  <dabates@apple.com>
3207
3208         LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
3209         https://bugs.webkit.org/show_bug.cgi?id=139746
3210         <rdar://problem/19283658>
3211
3212         Reviewed by Alexey Proskuryakov.
3213
3214         Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
3215         if the simulator device is not in state Booted.
3216
3217         Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
3218         launching/relaunching the iOS Simulator app and a simulator app can only be installed
3219         on a device that is in the Booted state. LayoutTestRelay may run before the
3220         device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
3221         We should defer executing LayoutTestRelay until the simulator device booted by
3222         iOS Simulator is in the Booted state.
3223
3224         * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
3225         Simulator methods with the module name, simulator.
3226         (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
3227         after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
3228         before launching iOS Simulator to boot it.
3229         (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
3230         (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
3231         * Scripts/webkitpy/xcode/simulator.py:
3232         (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
3233         the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
3234         interested in the state of the device are more likely interested in the current state of the device as
3235         opposed to the state of the device when the Device object was created.
3236         (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
3237         (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
3238         from both this function and Simulator.device_state().
3239         (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
3240         (Simulator.DeviceState): Added; class of constants.
3241         (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
3242         device is in the specified state.
3243         (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
3244         (Simulator.device_directory): Added.
3245         (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
3246
3247 2015-02-05  Alexey Proskuryakov  <ap@apple.com>
3248
3249         Disable retries on Mac debug testers
3250         https://bugs.webkit.org/show_bug.cgi?id=141296
3251
3252         Reviewed by Simon Fraser.
3253
3254         * BuildSlaveSupport/build.webkit.org-config/config.json:
3255
3256 2015-02-05  Dan Bernstein  <mitz@apple.com>
3257
3258         Need a way to force $xcodeSDK in webkitdirs.pm
3259         https://bugs.webkit.org/show_bug.cgi?id=141291
3260
3261         Reviewed by Anders Carlsson.
3262
3263         * Scripts/webkitdirs.pm:
3264         (setXcodeSDK): Added.
3265
3266 2015-02-05  Youenn Fablet  <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
3267
3268         [Streams API] Implement a barebone ReadableStream interface
3269         https://bugs.webkit.org/show_bug.cgi?id=141045
3270
3271         Reviewed by Benjamin Poulain.
3272
3273         * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
3274
3275 2015-02-04  Joseph Pecoraro  <pecoraro@apple.com>
3276
3277         filter-build-webkit: reduce more unfiltered output
3278         https://bugs.webkit.org/show_bug.cgi?id=141282
3279
3280         Reviewed by Daniel Bates.
3281
3282         * Scripts/filter-build-webkit:
3283         Report CompileDTraceScript and Preprocess lines as successful.
3284
3285 2015-02-04  Dana Burkart  <dburkart@apple.com>
3286
3287         Botwatcher's Dashboard is cramped
3288         https://bugs.webkit.org/show_bug.cgi?id=140273
3289
3290         Reviewed by Alexey Proskuryakov.
3291
3292         Add a heading key which will allow for arbitrary headings in builder queues.
3293
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3295         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3296         (BuildbotBuilderQueueView.prototype.update):
3297         (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
3298         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3299         (BuildbotIteration.prototype._parseData):
3300         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3301         (BuildbotLeaksQueueView.prototype.update):
3302         (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
3303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
3304         (BuildbotPerformanceQueueView.prototype.update):
3305         (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3307         (BuildbotQueue):
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3309         (BuildbotQueueView.prototype._unauthorizedAccess):
3310         (BuildbotQueueView.prototype._appendBuild):
3311         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3312         (BuildbotTestResults):
3313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3314         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3315         (BuildbotTesterQueueView.prototype.update):
3316         (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
3317
3318 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
3319
3320         WKTR should not use -mainScreen to pick a color profile
3321         https://bugs.webkit.org/show_bug.cgi?id=141265
3322
3323         Reviewed by Tim Horton.
3324         
3325         -[NSScreen mainScreen] depends on the active window, so use the first screen
3326         (which is the one we put the window on anyway).
3327         
3328         Do some cleanup in DRT that makes the code look similar.
3329
3330         * DumpRenderTree/mac/DumpRenderTree.mm:
3331         (createWebViewAndOffscreenWindow):
3332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3333         (WTR::PlatformWebView::PlatformWebView):
3334
3335 2015-02-04  Simon Fraser  <simon.fraser@apple.com>
3336
3337         LayoutTestHelper should set the color profile of all displays
3338         https://bugs.webkit.org/show_bug.cgi?id=141260
3339
3340         Reviewed by Tim Horton.
3341         
3342         WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
3343         which is the screen with the active window. Make things more robust by changing
3344         the colorspace of all displays, not just the main screen, when running layout tests.
3345
3346         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
3347         * DumpRenderTree/mac/LayoutTestHelper.m: 
3348         (originalColorProfileURLs):
3349         (colorProfileURLForDisplay):
3350         (displayUUIDStrings):
3351         (saveDisplayColorProfiles):
3352         (setDisplayColorProfile):
3353         (restoreDisplayColorProfiles):
3354         (installLayoutTestColorProfile):
3355         (restoreUserColorProfile):
3356         (main):        
3357         Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
3358         toll-free bridged, sadly). Use the map to restore all profiles on exit.
3359         Convert to use more Obj-C types.
3360
3361 2015-02-04  Daniel Bates  <dabates@apple.com>
3362
3363         test-webkitpy fails on Mac without iphoneos SDK
3364         https://bugs.webkit.org/show_bug.cgi?id=141255
3365         <rdar://problem/19619691>
3366
3367         I inadvertently committed the wrong exception message. Fix up the exception message
3368         to instruct a person to install the iOS SDK when it cannot be found.
3369
3370         * Scripts/webkitpy/port/ios.py:
3371         (IOSPort.determine_full_port_name):
3372
3373 2015-02-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3374
3375         W3C test importer should sort the list of files when generating the w3c-import.log
3376         https://bugs.webkit.org/show_bug.cgi?id=141156
3377
3378         Reviewed by Bem Jones-Bey.
3379
3380         Sort explicitly the list of imported files written in the w3c-import.log.
3381         Removed logging of the import date.
3382
3383         * Scripts/webkitpy/w3c/test_importer.py:
3384         (TestImporter.write_import_log):
3385
3386 2015-02-04  Daniel Bates  <dabates@apple.com>
3387
3388         test-webkitpy fails on Mac without iphoneos SDK
3389         https://bugs.webkit.org/show_bug.cgi?id=141255
3390         <rdar://problem/19619691>
3391
3392         Reviewed by David Kilzer and Alexey Proskuryakov.
3393
3394         Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
3395         should not require the iphoneos SDK to be installed to run the webkitpy tests.
3396
3397         * Scripts/webkitpy/common/system/platforminfo.py:
3398         (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
3399         installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
3400         to standard output if the SDK is installed to return the empty string if the SDK is
3401         not installed.
3402         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3403         (MockPlatformInfo.xcode_sdk_version): Added.
3404         * Scripts/webkitpy/port/ios.py:
3405         (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
3406         to get the version of the iphoneos SDK, if installed.
3407
3408 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3409
3410         run-webkit-tests doesn't always capture ASan violation reports
3411         https://bugs.webkit.org/show_bug.cgi?id=141231
3412
3413         Reviewed by Darin Adler.
3414
3415         * Scripts/webkitpy/port/driver.py:
3416         (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
3417         by the driver already (as is the case with ASan violations, which are printed to
3418         stderr).
3419         (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
3420         report.
3421         (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
3422         a separate variable for reporting.
3423
3424 2015-02-03  Ryosuke Niwa  <rniwa@webkit.org>
3425
3426         [webkitpy] Add platform specific Skipped file mechanism for performance tests
3427         https://bugs.webkit.org/show_bug.cgi?id=141152
3428
3429         Reviewed by Csaba Osztrogonác.
3430
3431         Support a test-expectation-like syntax in performance tests' skipped files.
3432         e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
3433
3434         * Scripts/webkitpy/port/base.py:
3435         (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
3436
3437         * Scripts/webkitpy/port/base_unittest.py:
3438         (PortTest.test_skipped_perf_tests): Test the new syntax.
3439
3440 2015-02-04  Alexey Proskuryakov  <ap@apple.com>
3441
3442         When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
3443         https://bugs.webkit.org/show_bug.cgi?id=141236
3444
3445         Reviewed by Sam Weinig.
3446
3447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
3448         (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
3449
3450 2015-02-04  Chris Dumez  <cdumez@apple.com>
3451
3452         Add removeFirst(value) / removeAll(value) methods to WTF::Vector
3453         https://bugs.webkit.org/show_bug.cgi?id=141192
3454
3455         Reviewed by Benjamin Poulain.
3456
3457         Add API tests for Vector::removeFirst(value) and
3458         Vector::removeAll(value).
3459
3460         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3461         (TestWebKitAPI::TEST):
3462
3463 2015-02-03  Tim Horton  <timothy_horton@apple.com>
3464
3465         Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
3466         https://bugs.webkit.org/show_bug.cgi?id=141217
3467
3468         Reviewed by Sam Weinig.
3469
3470         * WebKitTestRunner/TestController.cpp:
3471         (WTR::copyWebCryptoMasterKey):
3472         (WTR::TestController::createOtherPage):
3473         (WTR::TestController::createWebViewWithOptions):
3474         (WTR::TestController::ensureViewSupportsOptions):
3475         (WTR::TestController::didCommitNavigation):
3476         (WTR::TestController::didFinishNavigation):
3477         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
3478         (WTR::TestController::didReceiveAuthenticationChallenge):
3479         (WTR::TestController::decidePolicyForPluginLoad):
3480         (WTR::TestController::decidePolicyForNavigationAction):
3481         (WTR::TestController::decidePolicyForNavigationResponse):
3482         (WTR::TestController::didCommitLoadForFrame): Deleted.
3483         (WTR::TestController::didFinishLoadForFrame): Deleted.
3484         * WebKitTestRunner/TestController.h:
3485         Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
3486
3487 2015-02-03  Dhi Aurrahman  <diorahman@rockybars.com>
3488
3489         Unreviewed. Add myself as a committer.
3490
3491         * Scripts/webkitpy/common/config/contributors.json:
3492
3493 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3494
3495         [Win] Unreviewed test fix.
3496
3497         * DumpRenderTree/win/PolicyDelegate.cpp:
3498         (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
3499         so was not matching expected output.
3500
3501 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3502
3503         Unreviewed. Moving myself to the committer section at last.
3504
3505         * Scripts/webkitpy/common/config/contributors.json:
3506
3507 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3508
3509         [Win] Tests fail because DRT reports '(null)' instead of an empty string
3510         https://bugs.webkit.org/show_bug.cgi?id=141205
3511
3512         Reviewed by Anders Carlsson.
3513
3514         * DumpRenderTree/win/HistoryDelegate.cpp:
3515         (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
3516         properly so that we match expected DumpRenderTree output.
3517
3518 2015-02-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3519
3520         [GTK] TestWebKitAccessibility is not skipped
3521         https://bugs.webkit.org/show_bug.cgi?id=141179
3522
3523         Reviewed by Carlos Garcia Campos.
3524
3525         Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
3526         skipped, and it apparently works reliably on the bots.
3527
3528         * Scripts/run-gtk-tests:
3529         (TestRunner):
3530
3531 2015-02-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3532
3533         run-perf-tests: allow to specify a wrapper command.
3534         https://bugs.webkit.org/show_bug.cgi?id=141172
3535
3536         Reviewed by Ryosuke Niwa.
3537
3538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3539         (parse_args): Update text to indicate is also valid for WTR.
3540         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3541         (PerfTestsRunner._parse_args): Add wrapper command.
3542
3543 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3544
3545         [Win] Correct version parsing warning in update-webkit
3546         https://bugs.webkit.org/show_bug.cgi?id=141200
3547
3548         Reviewed by Anders Carlsson.
3549
3550         * Scripts/webkitdirs.pm:
3551         (setupAppleWinEnv): Strip out any specific version build level
3552         from the Cygwin version information.
3553   
3554
3555 2015-02-03  Brent Fulgham  <bfulgham@apple.com>
3556
3557         [Win] Attempt to improve the reliability of HTTP service
3558         https://bugs.webkit.org/show_bug.cgi?id=141191
3559
3560         Reviewed by Darin Adler.
3561
3562         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3563         (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
3564         (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
3565         when stopping the service doesn't do so on its own (for Windows runs).
3566
3567 2015-02-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3568
3569         Web platform test server should not need to create __init__.py files
3570         https://bugs.webkit.org/show_bug.cgi?id=141030
3571
3572         Reviewed by Ryosuke Niwa.
3573
3574         W3C TestImporter ensures that copied __init__.py files are not empty.
3575         If needed, a comment is inserted in __init__.py files.
3576         Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
3577
3578         * Scripts/webkitpy/common/system/filesystem.py:
3579         (FileSystem.getsize):
3580         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
3581         (TestWebPlatformTestServer.test_start_cmd):
3582         (TestWebPlatformTestServer):
3583         (TestWebPlatformTestServer.test_import_web_platform_test_modules):
3584         * Scripts/webkitpy/w3c/test_importer.py:
3585         (TestImporter.import_tests):
3586
3587 2015-01-26  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3588
3589         Unreviewed. Moving myself to the committer section.
3590
3591         * Scripts/webkitpy/common/config/contributors.json:
3592
3593 2015-02-02  Saam Barati  <saambarati1@gmail.com>
3594
3595         Create tests for JSC's Control Flow Profiler
3596         https://bugs.webkit.org/show_bug.cgi?id=141123
3597
3598         Reviewed by Filip Pizlo.
3599
3600         * Scripts/run-javascriptcore-tests:
3601         (runJSCStressTests):
3602         * Scripts/run-jsc-stress-tests:
3603
3604 2015-02-02  Csaba Osztrogonác  <ossy@webkit.org>
3605
3606         Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
3607         https://bugs.webkit.org/show_bug.cgi?id=141158
3608
3609         Reviewed by Darin Adler.
3610
3611         * Scripts/run-jsc-stress-tests:
3612
3613 2015-02-02  Michael Catanzaro  <mcatanzaro@igalia.com>
3614
3615         [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
3616         https://bugs.webkit.org/show_bug.cgi?id=141142
3617
3618         Reviewed by Carlos Garcia Campos.
3619
3620         * MiniBrowser/gtk/BrowserWindow.c:
3621         (browser_window_init): Quit on Ctrl+W or Ctrl+Q
3622
3623 2015-02-01  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3624
3625         Web platform test server is not always launching properly on Mac EWS bots
3626         https://bugs.webkit.org/show_bug.cgi?id=141141
3627
3628         Unreviewed.
3629
3630         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3631         (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
3632
3633 2015-01-31  Sam Weinig  <sam@webkit.org>
3634
3635         Remove even more Mountain Lion support
3636         https://bugs.webkit.org/show_bug.cgi?id=141124
3637
3638         Reviewed by Alexey Proskuryakov.
3639
3640         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3641         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3642         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3643         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3644         * DumpRenderTree/mac/DumpRenderTree.mm:
3645         (activateTestingFonts):
3646         (prepareConsistentTestingEnvironment):
3647         * DumpRenderTree/mac/EventSendingController.mm:
3648         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
3649         (-[EventSendingController contextClick]):
3650         * DumpRenderTree/mac/TextInputController.m:
3651         * LayoutTestRelay/Configurations/Base.xcconfig:
3652         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3653         * MiniBrowser/Configurations/Base.xcconfig:
3654         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3655         * MiniBrowser/mac/WK2BrowserWindowController.m:
3656         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3657         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3658         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3659         * TestWebKitAPI/Configurations/Base.xcconfig:
3660         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3661         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3662         (-[DownloadDelegate _downloadDidFinish:]):
3663         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
3664         (TestWebKitAPI::TEST):
3665         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3666         (TestWebKitAPI::InjectedB