Handle recovery on "timestamp-looking" lines in the WebVTT parser
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-21  Darin Adler  <darin@apple.com>
2
3         Remove use of deprecatedCharacters in WebKit API tests
4         https://bugs.webkit.org/show_bug.cgi?id=130602
5
6         Reviewed by Antti Koivisto.
7
8         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
9         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
10         (TestWebKitAPI::expectEmpty): Use characters8.
11         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
12
13         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
14         Removed the test that is entirely about 16-bit conversion since that's basically a test of
15         the deprecatedCharacters function itself, which we are about to delete.
16
17 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
18
19         [webkitpy] Fix has_valid_reviewer()
20         https://bugs.webkit.org/show_bug.cgi?id=130589
21
22         Reviewed by Csaba Osztrogonác.
23
24         * Scripts/webkitpy/common/checkout/changelog.py:
25         (ChangeLogEntry.has_valid_reviewer):
26         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
27         (test_has_valid_reviewer):
28         * Scripts/webkitpy/common/config/committers.py:
29         (CommitterList._reviewer_only):
30         (CommitterList.committer_by_name):
31         (CommitterList.reviewer_by_email):
32         (CommitterList):
33         (CommitterList.reviewer_by_name):
34
35 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
36
37         Add cache support for jhbuild
38         https://bugs.webkit.org/show_bug.cgi?id=130588
39
40         Reviewed by Csaba Osztrogonác.
41
42         * jhbuild/jhbuildrc_common.py:
43         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
44
45 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
46
47         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
48         https://bugs.webkit.org/show_bug.cgi?id=130504
49
50         Reviewed by Martin Robinson.
51
52         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
53         CMake if not specified.
54         * Scripts/webkitdirs.pm:
55         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
56         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
57
58 2014-03-21  Andreas Kling  <akling@apple.com>
59
60         RetainPtr API test should use CFArray instead of CFString for testing.
61         <rdar://problem/16384899>
62
63         Unreviewed bot fix.
64
65         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
66         (TestWebKitAPI::TEST):
67         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
68         (TestWebKitAPI::TEST):
69
70 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
71
72         Move to using std::unique_ptr for EFL objects.
73         https://bugs.webkit.org/show_bug.cgi?id=129853
74
75         Reviewed by Gyuyoung Kim.
76
77         EflUniquePtr is a template alias of std::unique_ptr
78         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
79         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
80
81         * DumpRenderTree/efl/DumpRenderTree.cpp:
82         (main):
83         * ImageDiff/efl/ImageDiff.cpp:
84         (initEfl):
85         (main):
86
87 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
88
89         Unreviewed buildfix after r165983 for non Cocoa platforms
90
91         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
92
93         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
94         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
95         * WebKitTestRunner/TestController.cpp:
96
97 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
98
99         [GTK][CMake] Add support for building with Clang
100         https://bugs.webkit.org/show_bug.cgi?id=130260
101
102         Reviewed by Martin Robinson.
103
104         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
105         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
106         included GTest framework headers.
107         * gtk/generate-gtkdoc:
108         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
109         in case of using Clang since that is now set by the CMake rule.
110
111 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
112
113         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
114         https://bugs.webkit.org/show_bug.cgi?id=130476
115
116         Reviewed by Anders Carlsson.
117         
118         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
119
120         * MiniBrowser/mac/WK1BrowserWindowController.m:
121         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
122         Remove log.
123         * MiniBrowser/mac/WK2BrowserWindowController.m:
124         (-[WK2BrowserWindowController awakeFromNib]):
125         (-[WK2BrowserWindowController validateMenuItem:]):
126         (-[WK2BrowserWindowController reload:]):
127         Hook up reload.
128         (-[WK2BrowserWindowController toggleZoomMode:]):
129         (-[WK2BrowserWindowController resetZoom:]):
130         (-[WK2BrowserWindowController canResetZoom]):
131         (-[WK2BrowserWindowController currentZoomFactor]):
132         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
133         (-[WK2BrowserWindowController canZoomIn]):
134         (-[WK2BrowserWindowController canZoomOut]):
135
136 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
137
138         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
139         https://bugs.webkit.org/show_bug.cgi?id=130463
140
141         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
142
143 2014-03-18  Samuel White  <samuel_white@apple.com>
144
145         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
146         https://bugs.webkit.org/show_bug.cgi?id=130250
147
148         Reviewed by Chris Fleizach.
149
150         Added ability to toggle enhanced accessibility on and off to support tests that require it.
151
152         * DumpRenderTree/AccessibilityController.cpp:
153         (enableEnhancedAccessibilityCallback):
154         (getEnhancedAccessibilityEnabledCallback):
155         (AccessibilityController::getJSClass):
156         * DumpRenderTree/AccessibilityController.h:
157         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
158         (AccessibilityController::enableEnhancedAccessibility):
159         (AccessibilityController::enhancedAccessibilityEnabled):
160         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
161         (AccessibilityController::enableEnhancedAccessibility):
162         (AccessibilityController::enhancedAccessibilityEnabled):
163         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
164         (AccessibilityController::enableEnhancedAccessibility):
165         (AccessibilityController::enhancedAccessibilityEnabled):
166         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
167         (AccessibilityController::enableEnhancedAccessibility):
168         (AccessibilityController::enhancedAccessibilityEnabled):
169         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
170         (WTR::AccessibilityController::enableEnhancedAccessibility):
171         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
172         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
173         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
174
175 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
176
177         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
178         yet).
179
180         * Scripts/webkitpy/common/config/contributors.json:
181
182 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
183
184         Web Inspector: Remove stale ReportMemoryUsagePlugin
185         https://bugs.webkit.org/show_bug.cgi?id=130405
186
187         Reviewed by Andreas Kling.
188
189         This clang plugin looks like it was used for the old Inspector memory
190         instrumentation that was removed. So the tool can be removed.
191
192         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
193         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
194         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
195         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
196
197 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
198
199         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
200         https://bugs.webkit.org/show_bug.cgi?id=130220
201
202         Reviewed by Csaba Osztrogonác.
203
204         * Scripts/webkitpy/common/checkout/changelog.py:
205         (ChangeLog.set_reviewer):
206         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
207         (test_set_reviewer):
208
209 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
210
211         More FTL enabling.
212
213         Rubber stamped by Dan Bernstein.
214
215         * Tools/Scripts/build-webkit:
216
217 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
218
219         Renable pagination mode in WK2 MiniBrowser
220         https://bugs.webkit.org/show_bug.cgi?id=130374
221
222         Reviewed by Anders Carlsson.
223         
224         Put the implementation of togglePaginationMode: back, and correctly
225         enable the menu item.
226
227         * MiniBrowser/mac/WK2BrowserWindowController.m:
228         (-[WK2BrowserWindowController validateMenuItem:]):
229         (-[WK2BrowserWindowController isPaginated]):
230         (-[WK2BrowserWindowController togglePaginationMode:]):
231
232 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
233
234         Add --reset option to Tools/Scripts/set-webkit-configuration script
235         https://bugs.webkit.org/show_bug.cgi?id=130401
236
237         Reviewed by Csaba Osztrogonác.
238
239         * Scripts/set-webkit-configuration:
240
241 2014-03-18  Alberto Garcia  <berto@igalia.com>
242
243         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
244         https://bugs.webkit.org/show_bug.cgi?id=130388
245
246         Reviewed by Sergio Villar Senin.
247
248         * Scripts/webkitdirs.pm:
249         (shouldRemoveCMakeCache): make sure that the build directory
250         exists before attempting to create a file in it.
251
252 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
253
254         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
255         https://bugs.webkit.org/show_bug.cgi?id=130336
256
257         Reviewed by Gyuyoung Kim.
258
259         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
260         requires a space between literal and string macro [-Wliteral-suffix]'
261         warning treated as error.
262
263         This patch applies a solution from r162448 to the EFL port.
264
265         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
266         * efl/jhbuild.modules: Added appropriate patch section.
267
268 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
269
270         webkitpy test rebaseline.
271
272         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
273         (MainTest.test_default_args):
274
275 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
276
277         --profile should imply --test-runner-count=1 in run-perf-tests
278         https://bugs.webkit.org/show_bug.cgi?id=130375
279
280         Reviewed by Benjamin Poulain.
281
282         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
283
284         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
285         (PerfTestsRunner._parse_args): Use -1 as the default value.
286         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
287         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
288         should be 1.
289
290 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
291
292         Address some style nits.
293
294         * MiniBrowser/mac/WK2BrowserWindowController.m:
295
296 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
297
298         Add transparent window support back into MiniBrowser
299         https://bugs.webkit.org/show_bug.cgi?id=130363
300
301         Reviewed by Anders Carlsson.
302         
303         Re-enable transparent window support for WK2.
304
305         * MiniBrowser/mac/WK2BrowserWindowController.m:
306         (-[WK2BrowserWindowController validateMenuItem:]):
307         (-[WK2BrowserWindowController toggleTransparentWindow:]):
308
309 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
310
311         Fix the 32-bit build; make the open panel make a WK1 window.
312
313         * MiniBrowser/mac/AppDelegate.m:
314         (-[BrowserAppDelegate openDocument:]):
315
316 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
317
318         Convert MiniBrowser to use WKWebView API
319         https://bugs.webkit.org/show_bug.cgi?id=130061
320
321         Reviewed by Anders Carlsson.
322         
323         Convert the MiniBrowser WK2 window to use WebKit2 API as much
324         as possible.
325         
326         Some functionality was removed temporarily:
327             - text zoom, page zoom
328             - reload
329             - pagination mode
330             - transparent window
331             - dumping source
332             - window.open support
333             - beforeUnload panel
334             - find in page
335
336         * MiniBrowser/mac/AppDelegate.h:
337         * MiniBrowser/mac/AppDelegate.m:
338         (-[BrowserAppDelegate init]):
339         (-[BrowserAppDelegate newWindow:]):
340         (-[BrowserAppDelegate applicationWillTerminate:]):
341         (-[BrowserAppDelegate openDocument:]):
342         * MiniBrowser/mac/WK2BrowserWindowController.h:
343         * MiniBrowser/mac/WK2BrowserWindowController.m:
344         (-[WK2BrowserWindowController awakeFromNib]):
345         (-[WK2BrowserWindowController dealloc]):
346         (-[WK2BrowserWindowController fetch:]):
347         (-[WK2BrowserWindowController validateMenuItem:]):
348         (-[WK2BrowserWindowController reload:]):
349         (-[WK2BrowserWindowController goBack:]):
350         (-[WK2BrowserWindowController goForward:]):
351         (-[WK2BrowserWindowController toggleZoomMode:]):
352         (-[WK2BrowserWindowController resetZoom:]):
353         (-[WK2BrowserWindowController canResetZoom]):
354         (-[WK2BrowserWindowController dumpSourceToConsole:]):
355         (-[WK2BrowserWindowController togglePaginationMode:]):
356         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
357         (-[WK2BrowserWindowController windowShouldClose:]):
358         (-[WK2BrowserWindowController applicationTerminating]):
359         (-[WK2BrowserWindowController currentZoomFactor]):
360         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
361         (-[WK2BrowserWindowController toggleTransparentWindow:]):
362         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
363         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
364         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
365         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
366         (-[WK2BrowserWindowController find:]):
367         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
368         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
369         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
370         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
371         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
372         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
373         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
374         * WebKitTestRunner/PlatformWebView.h:
375         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
376         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
377
378 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
379
380         Use RunLoop objects through references instead of pointers
381         https://bugs.webkit.org/show_bug.cgi?id=130313
382
383         Reviewed by Andreas Kling.
384
385         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
386         return RunLoop reference instead of a pointer.
387
388         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
389         (loadedCallback):
390         (clickedCallback):
391
392 2014-03-17  Tim Horton  <timothy_horton@apple.com>
393
394         sort-export-file --help doesn't work (missing 'use')
395         https://bugs.webkit.org/show_bug.cgi?id=130338
396
397         Reviewed by Anders Carlsson.
398
399         * Scripts/sort-export-file:
400         Add a missing 'use', and fix a typo in an error message.
401
402 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
403
404         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
405         https://bugs.webkit.org/show_bug.cgi?id=130155
406
407         Reviewed by Philippe Normand.
408
409         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
410
411 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
412
413         [GTK] MiniBrowser fails to load injected bundle lib
414         https://bugs.webkit.org/show_bug.cgi?id=130332
415
416         Reviewed by Anders Carlsson.
417
418         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
419
420         * MiniBrowser/gtk/main.c:
421         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
422         process is spawn.
423
424 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
425
426         [EFL] Enable TOUCH_SLIDER macro
427         https://bugs.webkit.org/show_bug.cgi?id=130185
428
429         Reviewed by Gyuyoung Kim.
430
431         * Scripts/webkitperl/FeatureList.pm:
432
433 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
434
435         [GTK][CMake] Build with -fno-rtti
436         https://bugs.webkit.org/show_bug.cgi?id=130261
437
438         Reviewed by Martin Robinson.
439
440         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
441         defined to 0 to prevent typeid use in included GTest headers.
442
443 2014-03-16  Brian Burg  <bburg@apple.com>
444
445         Web Inspector: vended backend commands file should be generated as part of the build
446         https://bugs.webkit.org/show_bug.cgi?id=130110
447
448         Reviewed by Timothy Hatcher.
449
450         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
451
452 2014-03-16  Diego Pino García  <dpino@igalia.com>
453
454         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
455         https://bugs.webkit.org/show_bug.cgi?id=128999
456
457         Reviewed by Philippe Normand.
458
459         * MiniBrowser/gtk/BrowserWindow.c:
460         (reloadPage):
461         (reloadPageIgnoringCache):
462         (browser_window_init):
463
464 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
465
466         [GTK] Improve ninja detection in webkitdirs.pm
467         https://bugs.webkit.org/show_bug.cgi?id=129902
468
469         Reviewed by Daniel Bates.
470
471         * Scripts/webkitdirs.pm:
472         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
473         us to look for ninja-build as well.
474
475 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
476
477         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
478         https://bugs.webkit.org/show_bug.cgi?id=130276
479         <rdar://problem/16266927>
480         
481         Reviewed by Simon Fraser.
482
483         * BuildSlaveSupport/build-launcher-app:
484         * BuildSlaveSupport/build-launcher-dmg:
485         * DumpRenderTree/DumpRenderTree.h:
486         * DumpRenderTree/DumpRenderTreePrefix.h:
487         * DumpRenderTree/GCController.cpp:
488         * DumpRenderTree/GCController.h:
489         * DumpRenderTree/JavaScriptThreading.cpp:
490         * DumpRenderTree/JavaScriptThreading.h:
491         * DumpRenderTree/PixelDumpSupport.cpp:
492         * DumpRenderTree/PixelDumpSupport.h:
493         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
494         * DumpRenderTree/TestRunner.cpp:
495         * DumpRenderTree/TestRunner.h:
496         * DumpRenderTree/WorkQueue.cpp:
497         * DumpRenderTree/WorkQueue.h:
498         * DumpRenderTree/WorkQueueItem.h:
499         * DumpRenderTree/atk/AccessibilityCallbacks.h:
500         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
501         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
502         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
503         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
504         * DumpRenderTree/cg/PixelDumpSupportCG.h:
505         * DumpRenderTree/efl/EditingCallbacks.cpp:
506         * DumpRenderTree/efl/EditingCallbacks.h:
507         * DumpRenderTree/efl/EventSender.cpp:
508         * DumpRenderTree/efl/EventSender.h:
509         * DumpRenderTree/efl/GCControllerEfl.cpp:
510         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
511         * DumpRenderTree/efl/TestRunnerEfl.cpp:
512         * DumpRenderTree/gtk/DumpRenderTree.cpp:
513         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
514         * DumpRenderTree/gtk/EditingCallbacks.cpp:
515         * DumpRenderTree/gtk/EditingCallbacks.h:
516         * DumpRenderTree/gtk/EventSender.cpp:
517         * DumpRenderTree/gtk/EventSender.h:
518         * DumpRenderTree/gtk/GCControllerGtk.cpp:
519         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
520         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
521         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
522         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
523         * DumpRenderTree/gtk/TextInputController.cpp:
524         * DumpRenderTree/gtk/TextInputController.h:
525         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
526         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
527         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
528         * DumpRenderTree/mac/AppleScriptController.h:
529         * DumpRenderTree/mac/AppleScriptController.m:
530         * DumpRenderTree/mac/CheckedMalloc.cpp:
531         * DumpRenderTree/mac/CheckedMalloc.h:
532         * DumpRenderTree/mac/DumpRenderTree.mm:
533         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
534         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
535         * DumpRenderTree/mac/DumpRenderTreeMac.h:
536         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
537         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
538         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
539         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
540         * DumpRenderTree/mac/EditingDelegate.h:
541         * DumpRenderTree/mac/EditingDelegate.mm:
542         * DumpRenderTree/mac/EventSendingController.h:
543         * DumpRenderTree/mac/EventSendingController.mm:
544         * DumpRenderTree/mac/FrameLoadDelegate.h:
545         * DumpRenderTree/mac/FrameLoadDelegate.mm:
546         * DumpRenderTree/mac/GCControllerMac.mm:
547         * DumpRenderTree/mac/MockWebNotificationProvider.h:
548         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
549         * DumpRenderTree/mac/NavigationController.h:
550         * DumpRenderTree/mac/NavigationController.m:
551         * DumpRenderTree/mac/ObjCController.h:
552         * DumpRenderTree/mac/ObjCController.m:
553         * DumpRenderTree/mac/ObjCPlugin.h:
554         * DumpRenderTree/mac/ObjCPlugin.m:
555         * DumpRenderTree/mac/ObjCPluginFunction.h:
556         * DumpRenderTree/mac/ObjCPluginFunction.m:
557         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
558         * DumpRenderTree/mac/PolicyDelegate.h:
559         * DumpRenderTree/mac/PolicyDelegate.mm:
560         * DumpRenderTree/mac/ResourceLoadDelegate.h:
561         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
562         * DumpRenderTree/mac/TestRunnerMac.mm:
563         * DumpRenderTree/mac/TextInputController.h:
564         * DumpRenderTree/mac/TextInputController.m:
565         * DumpRenderTree/mac/UIDelegate.h:
566         * DumpRenderTree/mac/UIDelegate.mm:
567         * DumpRenderTree/mac/WorkQueueItemMac.mm:
568         * DumpRenderTree/win/DRTDataObject.cpp:
569         * DumpRenderTree/win/DRTDataObject.h:
570         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
571         * DumpRenderTree/win/DRTDropSource.cpp:
572         * DumpRenderTree/win/DRTDropSource.h:
573         * DumpRenderTree/win/DraggingInfo.h:
574         * DumpRenderTree/win/DumpRenderTree.cpp:
575         * DumpRenderTree/win/DumpRenderTreeWin.h:
576         * DumpRenderTree/win/EditingDelegate.cpp:
577         * DumpRenderTree/win/EditingDelegate.h:
578         * DumpRenderTree/win/EventSender.cpp:
579         * DumpRenderTree/win/EventSender.h:
580         * DumpRenderTree/win/FrameLoadDelegate.cpp:
581         * DumpRenderTree/win/FrameLoadDelegate.h:
582         * DumpRenderTree/win/GCControllerWin.cpp:
583         * DumpRenderTree/win/HistoryDelegate.cpp:
584         * DumpRenderTree/win/HistoryDelegate.h:
585         * DumpRenderTree/win/MD5.cpp:
586         * DumpRenderTree/win/MD5.h:
587         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
588         * DumpRenderTree/win/PolicyDelegate.cpp:
589         * DumpRenderTree/win/PolicyDelegate.h:
590         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
591         * DumpRenderTree/win/ResourceLoadDelegate.h:
592         * DumpRenderTree/win/TestRunnerWin.cpp:
593         * DumpRenderTree/win/TextInputController.cpp:
594         * DumpRenderTree/win/TextInputController.h:
595         * DumpRenderTree/win/TextInputControllerWin.cpp:
596         * DumpRenderTree/win/UIDelegate.cpp:
597         * DumpRenderTree/win/UIDelegate.h:
598         * DumpRenderTree/win/WorkQueueItemWin.cpp:
599         * EWebLauncher/main.c:
600         * GtkLauncher/main.c:
601         * ImageDiff/efl/ImageDiff.cpp:
602         * ImageDiff/gtk/ImageDiff.cpp:
603         * MiniBrowser/gtk/main.c:
604         * Scripts/SpacingHeuristics.pm:
605         * Scripts/VCSUtils.pm:
606         * Scripts/bisect-builds:
607         * Scripts/build-dumprendertree:
608         * Scripts/build-jsc:
609         * Scripts/build-webkit:
610         * Scripts/check-dom-results:
611         * Scripts/check-for-exit-time-destructors:
612         * Scripts/check-for-global-initializers:
613         * Scripts/commit-log-editor:
614         * Scripts/compare-timing-files:
615         * Scripts/debug-minibrowser:
616         * Scripts/debug-safari:
617         * Scripts/do-file-rename:
618         * Scripts/find-extra-includes:
619         * Scripts/generate-coverage-data:
620         * Scripts/make-script-test-wrappers:
621         * Scripts/malloc-tree:
622         * Scripts/old-run-webkit-tests:
623         * Scripts/parse-malloc-history:
624         * Scripts/report-include-statistics:
625         * Scripts/resolve-ChangeLogs:
626         * Scripts/run-bindings-tests:
627         * Scripts/run-iexploder-tests:
628         * Scripts/run-javascriptcore-tests:
629         * Scripts/run-jsc:
630         * Scripts/run-launcher:
631         * Scripts/run-leaks:
632         * Scripts/run-mangleme-tests:
633         * Scripts/run-minibrowser:
634         * Scripts/run-pageloadtest:
635         * Scripts/run-regexp-tests:
636         * Scripts/run-safari:
637         * Scripts/run-sunspider:
638         * Scripts/run-webkit-app:
639         * Scripts/sampstat:
640         * Scripts/set-webkit-configuration:
641         * Scripts/sort-Xcode-project-file:
642         * Scripts/sort-export-file:
643         * Scripts/split-file-by-class:
644         * Scripts/sunspider-compare-results:
645         * Scripts/svn-apply:
646         * Scripts/svn-create-patch:
647         * Scripts/svn-unapply:
648         * Scripts/test-webkit-scripts:
649         * Scripts/update-javascriptcore-test-results:
650         * Scripts/update-webkit:
651         * Scripts/update-webkit-auxiliary-libs:
652         * Scripts/update-webkit-dependency:
653         * Scripts/update-webkit-localizable-strings:
654         * Scripts/update-webkit-support-libs:
655         * Scripts/update-webkit-wincairo-libs:
656         * Scripts/webkit-build-directory:
657         * Scripts/webkitdirs.pm:
658         (installedSafariPath):
659         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
660         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
661         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
662         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
663         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
664         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
665         * Scripts/webkitperl/features.pm:
666         * Scripts/webkitperl/httpd.pm:
667         * Scripts/webkitpy/bindings/main.py:
668         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
669         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
670         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
671         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
672         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
673         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
674         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
675         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
676         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
677         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
678         * WebKitTestRunner/PixelDumpSupport.cpp:
679         * WebKitTestRunner/PixelDumpSupport.h:
680         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
681         * WinLauncher/WinLauncher.cpp:
682         * WinLauncher/WinLauncher.h:
683         * WinLauncher/stdafx.cpp:
684         * WinLauncher/stdafx.h:
685
686 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
687
688         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
689         https://bugs.webkit.org/show_bug.cgi?id=130265
690
691         Reviewed by Michael Saboff.
692
693         * Scripts/build-webkit:
694         * Scripts/copy-webkitlibraries-to-product-directory:
695
696 2014-03-14  Landry Breuil  <landry@openbsd.org>
697
698         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
699         Also allow to set MAKE in the environment.
700         https://bugs.webkit.org/show_bug.cgi?id=129991
701
702         Reviewed by Andreas Kling.
703
704         * Scripts/webkitdirs.pm:
705         (determineArchitecture):
706         (determineNumberOfCPUs):
707         (isBSD):
708         (buildAutotoolsProject):
709         * Scripts/webkitpy/common/system/platforminfo.py:
710         (PlatformInfo.__init__):
711         (PlatformInfo.is_openbsd):
712         (PlatformInfo):
713         (PlatformInfo.is_netbsd):
714         (PlatformInfo._determine_os_name):
715
716 2014-03-14  Dean Jackson  <dino@apple.com>
717
718         Remove libWebKitSystemInterfaceLion.a
719         https://bugs.webkit.org/show_bug.cgi?id=130254
720
721         Reviewed by Geoffrey Garen and Andreas Kling.
722
723         No need to copy the Lion libraries into the build.
724
725         * Scripts/copy-webkitlibraries-to-product-directory:
726
727 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
728
729         [EFL][MiniBrowser] Revise help messages of command line parameters
730         https://bugs.webkit.org/show_bug.cgi?id=130222
731
732         Reviewed by Csaba Osztrogonác.
733
734         Correct the default value description and make help messages to be consistent.
735
736         * MiniBrowser/efl/main.c:
737
738 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
739
740         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
741         https://bugs.webkit.org/show_bug.cgi?id=129612
742
743         Reviewed by Darin Adler.
744
745         For new code use static NeverDestroyed<T> instead.
746
747         * DumpRenderTree/JavaScriptThreading.cpp:
748         (javaScriptThreadsMutex):
749         (javaScriptThreads):
750         * DumpRenderTree/efl/EventSender.cpp:
751         (touchPointList):
752         (delayedEventQueue):
753         * DumpRenderTree/win/FrameLoadDelegate.cpp:
754         (delegatesWithDelayedWork):
755         * Scripts/check-for-exit-time-destructors:
756         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
757         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
758         (testsMap):
759
760 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
761
762         [EFL][WK2] Fix compilation warning in Minibrowser
763         https://bugs.webkit.org/show_bug.cgi?id=130132
764
765         Reviewed by Csaba Osztrogonác.
766
767         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
768
769         * MiniBrowser/efl/main.c:
770         (on_download_request):
771
772 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
773
774         FTL should support IsBlah
775         https://bugs.webkit.org/show_bug.cgi?id=130202
776
777         Reviewed by Geoffrey Garen.
778         
779         Running existing JSRegress tests with noInline gives us coverage for these
780         changes. Chances are, this will also give coverage for other interesting things
781         as well.
782
783         * Scripts/run-jsc-stress-tests:
784
785 2014-03-12  Brian Burg  <bburg@apple.com>
786
787         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
788         https://bugs.webkit.org/show_bug.cgi?id=129744
789
790         Reviewed by Timothy Hatcher.
791
792         * DumpRenderTree/TestRunner.cpp:
793         (evaluateInWebInspectorCallback):
794         * DumpRenderTree/TestRunner.h:
795         * DumpRenderTree/efl/TestRunnerEfl.cpp:
796         (TestRunner::evaluateInWebInspector):
797         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
798         (TestRunner::evaluateInWebInspector):
799         * DumpRenderTree/mac/TestRunnerMac.mm:
800         (TestRunner::evaluateInWebInspector):
801         * DumpRenderTree/win/TestRunnerWin.cpp:
802         (TestRunner::evaluateInWebInspector):
803         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
804         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
805         (WTR::TestRunner::evaluateInWebInspector):
806         * WebKitTestRunner/InjectedBundle/TestRunner.h:
807
808 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
809
810         [GTK] build-webkit shouldn't show error message when ninja isn't installed
811         https://bugs.webkit.org/show_bug.cgi?id=130129
812
813         Reviewed by Csaba Osztrogonác.
814
815         * Scripts/webkitdirs.pm:
816         (canUseNinja): Redirecting stderr to /dev/null
817
818 2014-03-13  Andres Gomez  <agomez@igalia.com>
819
820         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
821         https://bugs.webkit.org/show_bug.cgi?id=130092
822
823         Reviewed by Csaba Osztrogonác.
824
825         Added "python-dev" as dependency for deb based distros. It is
826         already present for rpm based distros. This dependency will allow
827         libxml2 to generate its python bindings, needed by gtk-doc.
828
829         * gtk/install-dependencies:
830
831 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
832
833         Unreviewed. Fix GTK+ cmake build after r165488.
834
835         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
836
837 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
840         https://bugs.webkit.org/show_bug.cgi?id=130014
841
842         Reviewed by Martin Robinson.
843
844         Include cmake or autotools config header.
845
846         * MiniBrowser/gtk/BrowserDownloadsBar.c:
847         * MiniBrowser/gtk/BrowserSearchBar.c:
848         * MiniBrowser/gtk/BrowserWindow.c:
849         * MiniBrowser/gtk/main.c:
850
851 2014-03-12  Commit Queue  <commit-queue@webkit.org>
852
853         Unreviewed, rolling out r165471.
854         https://bugs.webkit.org/show_bug.cgi?id=130139
855
856         Didn't really fix the issue and broke another bot (Requested
857         by mrobinson on #webkit).
858
859         Reverted changeset:
860
861         "[CMake] Newer versions of CMake cannot find older versions of
862         Freetype"
863         https://bugs.webkit.org/show_bug.cgi?id=130107
864         http://trac.webkit.org/changeset/165471
865
866 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
867
868         It should be possible to build WebKit with FTL on iOS
869         https://bugs.webkit.org/show_bug.cgi?id=130116
870
871         Reviewed by Dan Bernstein.
872
873         * Scripts/build-webkit:
874         * Scripts/copy-webkitlibraries-to-product-directory:
875
876 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
877
878         [Win] Remove use of QTSDK
879         https://bugs.webkit.org/show_bug.cgi?id=130049
880
881         Reviewed by Darin Adler.
882
883         * DumpRenderTree/win/DumpRenderTree.cpp:
884         (initialize): Remove QuickTime code.
885         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
886         building QTMovieWin.
887
888 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
889
890         [GTK][CMAKE] Too verbose build output
891         https://bugs.webkit.org/show_bug.cgi?id=130076
892
893         Reviewed by Carlos Garcia Campos.
894
895         Instead of building with cmake --build which isn't smart about pretty printing and
896         colors, we build with a script which calls the proper build command.
897
898         * Scripts/webkitdirs.pm:
899         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
900         the CMake configuration pass.
901
902 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
903
904         [CMake] Newer versions of CMake cannot find older versions of Freetype
905         https://bugs.webkit.org/show_bug.cgi?id=130107
906
907         Reviewed by Gustavo Noronha Silva.
908
909         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
910         to CMake during jhbuild initialization.
911
912 2014-03-12  Zalan Bujtas  <zalan@apple.com>
913
914         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
915         https://bugs.webkit.org/show_bug.cgi?id=129961
916
917         Reviewed by Simon Fraser.
918
919         Now scaled content can go through the window capturing mechanism too for compositing content.
920         AppleMagnifiedMode is redundant.
921
922         * DumpRenderTree/mac/DumpRenderTree.mm:
923         (setDefaultsToConsistentValuesForTesting):
924         (runTest):
925         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
926         (createBitmapContextFromWebView):
927         * WebKitTestRunner/PlatformWebView.h:
928         * WebKitTestRunner/cg/TestInvocationCG.cpp:
929         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
930         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
931         (WTR::PlatformWebView::didInitializeClients):
932         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
933         (WTR::PlatformWebView::forceWindowFramesChanged):
934         * WebKitTestRunner/mac/main.mm:
935         (setDefaultsToConsistentValuesForTesting):
936
937 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
938
939         Unreviewed. Add myself as a committer.
940
941         * Scripts/webkitpy/common/config/contributors.json:
942
943 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
944
945         Unreviewed build fix on the EFL port when used lower version of ATK
946
947         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
948         (WTR::AccessibilityUIElement::y): Fixed typo.
949
950 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
951
952         Some images are blank in the rebaseline server UI
953         https://bugs.webkit.org/show_bug.cgi?id=130104
954
955         Reviewed by Tim Horton.
956
957         Let the server check for images in the 'retries' directory
958         if it can't find an image otherwise.
959
960         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
961         (RebaselineHTTPRequestHandler.test_result):
962
963 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
964
965         [GTK][CMake] --update-gtk has no effect
966         https://bugs.webkit.org/show_bug.cgi?id=130088
967
968         Reviewed by Philippe Normand.
969
970         * Scripts/webkitdirs.pm:
971         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
972         as an argument.
973
974 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
975
976         Add "System Font" to the list of whitelisted DRT fonts
977         https://bugs.webkit.org/show_bug.cgi?id=130046
978
979         Reviewed by Darin Adler.
980
981         * DumpRenderTree/mac/DumpRenderTree.mm:
982         (allowedFontFamilySet):
983         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
984
985 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
986
987         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
988         https://bugs.webkit.org/show_bug.cgi?id=130064
989
990         Reviewed by Philippe Normand.
991
992         * efl/jhbuildrc: Remove duplicated code.
993         * gtk/jhbuildrc: Remove duplicated code.
994         * jhbuild/jhbuildrc_common.py:
995         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
996         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
997         and is apparently necessary for GTK+.
998
999 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1000
1001         check-webkit-style failed to complain about missing braces
1002         https://bugs.webkit.org/show_bug.cgi?id=34189
1003
1004         Reviewed by Ryosuke Niwa.
1005
1006         * Scripts/webkitpy/style/checkers/cpp.py:
1007         (check_braces):
1008         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1009         (WebKitStyleTest.test_braces):
1010
1011 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1012
1013         Remove Qt cruft from style checker.
1014         https://bugs.webkit.org/show_bug.cgi?id=130085
1015
1016         Reviewed by Csaba Osztrogonác.
1017
1018         There is no 'foreach' keyword in c++. That was a Qt feature
1019         added in: http://trac.webkit.org/changeset/46113
1020         Qt was removed from WebKit, so we should remove the checks
1021         of this keyword from check-webkit-style scripts.
1022
1023         * Scripts/webkitpy/style/checkers/cpp.py:
1024         (check_spacing_for_function_call):
1025         (check_spacing):
1026         (check_braces):
1027         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1028         (CppStyleTest.test_mismatching_spaces_in_parens):
1029         (CppStyleTest.test_spacing_for_fncall):
1030         (WebKitStyleTest.test_braces):
1031
1032 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1033
1034         [GTK] update-webkitgtk-libs needs itstool
1035         https://bugs.webkit.org/show_bug.cgi?id=130082
1036
1037         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1038         itstool is a dependency of building gtk-doc from version 1.19, so it should
1039         be added to Tools/gtk/install-dependencies script, too.
1040
1041         Reviewed by Philippe Normand.
1042
1043         * gtk/install-dependencies:
1044
1045 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1046
1047         webkitbot rollout ChangeLogs should be nicer
1048         https://bugs.webkit.org/show_bug.cgi?id=122654
1049
1050         Reviewed by Csaba Osztrogonác.
1051
1052         Added bug urls and descriptions of rolled out patches to the rollout changelog
1053         if they are present in the original changelog. Additionally removed the list of
1054         changed files and functions.
1055
1056         * Scripts/webkitpy/common/checkout/changelog.py:
1057         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1058         * Scripts/webkitpy/common/checkout/checkout.py:
1059         (Checkout._changelog_data_for_revision): Store bug description.
1060         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1061         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1062         (CheckoutTest.test_commit_info_for_revision):
1063         * Scripts/webkitpy/common/checkout/commitinfo.py:
1064         (CommitInfo.bug_description): Added.
1065         (CommitInfo.to_json):
1066         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1067         (CommitInfoTest.test_commit_info_creation):
1068         * Scripts/webkitpy/tool/commands/download.py:
1069         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1070         out patches for creating rollout changelog.
1071         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1072         caused the regression is stored in state["bug_blocked"] now.
1073         * Scripts/webkitpy/tool/commands/download_unittest.py:
1074         (test_prepare_rollout):
1075         (test_create_rollout_multiple_revision):
1076         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1077         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1078         rolled out patches to the changelog.
1079         (PrepareChangeLogForRevert.run):
1080         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1081         (UpdateChangeLogsForRevertTest):
1082         (test_message_for_revert):
1083         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1084         (ReopenBugAfterRollout.run):
1085
1086 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1087
1088         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1089         https://bugs.webkit.org/show_bug.cgi?id=130021
1090
1091         Reviewed by Mario Sanchez Prada.
1092
1093         Replace deprecated functions to use new API from ATK 2.11.90.
1094
1095         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1096         (AccessibilityUIElement::x):
1097         (AccessibilityUIElement::y):
1098         (AccessibilityUIElement::width):
1099         (AccessibilityUIElement::height):
1100         (AccessibilityUIElement::clickPointX):
1101         (AccessibilityUIElement::clickPointY):
1102         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1103         (WTR::AccessibilityUIElement::x):
1104         (WTR::AccessibilityUIElement::y):
1105         (WTR::AccessibilityUIElement::width):
1106         (WTR::AccessibilityUIElement::height):
1107         (WTR::AccessibilityUIElement::clickPointX):
1108         (WTR::AccessibilityUIElement::clickPointY):
1109
1110 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1111
1112         [ATK] Expose aria-posinset and aria-setsize through object attributes
1113         https://bugs.webkit.org/show_bug.cgi?id=130011
1114
1115         Reviewed by Chris Fleizach.
1116
1117         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1118
1119         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1120         (AccessibilityUIElement::numberAttributeValue):
1121         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1122         (WTR::AccessibilityUIElement::numberAttributeValue):
1123
1124 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1125
1126         [Win] Unreviewed build fix.
1127
1128         Some bad Windows code was committed at some point that prevents the Apple Windows port
1129         from finding its runtime dependencies reliably.
1130
1131         * win/DLLLauncher/DLLLauncherMain.cpp:
1132         (appleApplicationSupportDirectory): Restored this function.
1133         (modifyPath): Update to use appleApplicationSupportDirectory function.
1134
1135 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1136
1137         Let the user define the full address of the performance-site-server for uploading results
1138         https://bugs.webkit.org/show_bug.cgi?id=129819
1139
1140         Reviewed by Ryosuke Niwa.
1141
1142         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1143         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1144         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1145         protocol for now, in order to avoid breaking the perf bots.
1146
1147         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1148         (_upload_json):
1149         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1150         (MainTest.test_upload_json):
1151
1152 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1153
1154         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1155         https://bugs.webkit.org/show_bug.cgi?id=130023
1156
1157         Reviewed by Dean Jackson.
1158
1159         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1160         /SAFESEH flag to DLL launcher process.
1161
1162 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1163
1164         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1165         https://bugs.webkit.org/show_bug.cgi?id=129980
1166
1167         Reviewed by Carlos Garcia Campos.
1168
1169         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1170
1171 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1172
1173         [GTK] Remove the WebView source-mode WebKit1 test
1174         https://bugs.webkit.org/show_bug.cgi?id=129976
1175
1176         Reviewed by Carlos Garcia Campos.
1177
1178         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1179
1180 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1181
1182         Unreviewed build fix for GTKbuild after the switch to CMake
1183
1184         * gtk/common.py:
1185         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1186         test-only bot doesn't have any build files.
1187
1188 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1189
1190         [GTK] built-product-archive does not handle GTK+ CMake build
1191         https://bugs.webkit.org/show_bug.cgi?id=129941
1192
1193         * BuildSlaveSupport/built-product-archive:
1194         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1195         the CMake build.
1196
1197 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1198
1199         [GTK] Include CMake into install-dependencies script
1200         https://bugs.webkit.org/show_bug.cgi?id=129909
1201
1202         Reviewed by Martin Robinson.
1203
1204         As since r165267 buid-webkit uses CMake by default, the dependency
1205         with 'cmake' package should be introduced.
1206
1207         * gtk/install-dependencies: Ditto.
1208
1209 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1210
1211         REGRESSION(165267): Broke a webkitpy unit tests
1212         https://bugs.webkit.org/show_bug.cgi?id=129904
1213
1214         Reviewed by Jon Honeycutt.
1215
1216         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1217         (GtkPort._is_cmake_build):
1218
1219 2014-03-07  Andres Gomez  <agomez@igalia.com>
1220
1221         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1222         https://bugs.webkit.org/show_bug.cgi?id=129893
1223
1224         Reviewed by Martin Robinson.
1225
1226         Added "git-svn" as dependency for deb based distros and,
1227         additionally, "subversion" for rpm based distros.
1228
1229         * gtk/install-dependencies:
1230
1231 2014-03-07  Roger Fong  <roger_fong@apple.com>
1232
1233         Remove dummy setSystemWebGLLoadPolicy client method.
1234         https://bugs.webkit.org/show_bug.cgi?id=129873.
1235
1236         Reviewed by Dean Jackson.
1237
1238         * WebKitTestRunner/TestController.cpp:
1239         (WTR::TestController::createWebViewWithOptions):
1240
1241 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1242
1243         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1244         https://bugs.webkit.org/show_bug.cgi?id=129886
1245
1246         Reviewed by Mark Lam.
1247
1248         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1249         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1250         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1251         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1252         make it through when in non-verbose mode.
1253
1254 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1255
1256         [GTK] buid-webkit should use CMake by default
1257         https://bugs.webkit.org/show_bug.cgi?id=129855
1258
1259         Reviewed by Carlos Garcia Campos.
1260
1261         Make the CMake build the default GTK+ build when using build-webkit. This will
1262         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1263         so that we have --gtk and --gtkautotools.
1264
1265         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1266         * Scripts/webkitpy/port/gtk.py: Ditto.
1267
1268 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1269
1270         [CMake] [GTK] Build with ninja when it is available
1271         https://bugs.webkit.org/show_bug.cgi?id=129805
1272
1273         Reviewed by Philippe Normand.
1274
1275         * Scripts/webkitdirs.pm:
1276         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1277         if it's available on the system.
1278         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1279         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1280
1281 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1282
1283         If the FTL is build-time enabled then it should be run-time enabled.
1284
1285         Rubber stamped by Geoffrey Garen.
1286
1287         * Scripts/run-jsc-stress-tests:
1288
1289 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1290
1291         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1292         https://bugs.webkit.org/show_bug.cgi?id=129837
1293
1294         Reviewed by Michael Saboff.
1295
1296         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1297         The fix is to use find instead of ls like we do in shell-runner.sh.
1298
1299         * Scripts/run-jsc-stress-tests:
1300
1301 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1302
1303         filter-build-webkit should not strip .o
1304         https://bugs.webkit.org/show_bug.cgi?id=129614
1305
1306         Reviewed by Dean Jackson.
1307
1308         This makes it much easier to jump from the failing output at
1309         the end back up to the compile errors earlier in the output.
1310
1311         * Scripts/filter-build-webkit:
1312
1313 2014-03-06  Anders Carlsson  <andersca@apple.com>
1314
1315         Build WebKit2 before building WebKit
1316         https://bugs.webkit.org/show_bug.cgi?id=129831
1317         <rdar://problem/15920020>
1318
1319         Reviewed by Dan Bernstein.
1320
1321         * Scripts/build-webkit:
1322         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1323
1324 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1325
1326         make-3.82 fails to build on ARM/Linux
1327         https://bugs.webkit.org/show_bug.cgi?id=107926
1328
1329         Reviewed by Martin Robinson.
1330
1331         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1332         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1333         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1334         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1335
1336         * gtk/patches/make-3.82-arg-list-length.patch:
1337
1338 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1339
1340         [GTK] Close the page when the view is disposed instead of when finalized
1341         https://bugs.webkit.org/show_bug.cgi?id=129783
1342
1343         Reviewed by Sergio Villar Senin.
1344
1345         Add test case but disabled for now because it's affetected by bug #129684.
1346
1347         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1348         (testProcessPerWebView):
1349
1350 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1351
1352         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1353         https://bugs.webkit.org/show_bug.cgi?id=129738
1354
1355         Reviewed by Sergio Villar Senin.
1356
1357         The problem is that we are calling g_object_unref() for the
1358         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1359         view only increases the reference counter when the settings is not
1360         the same it currently has. We should release our reference once.
1361
1362         * MiniBrowser/gtk/main.c:
1363         (createBrowserWindow):
1364         (main):
1365
1366 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1367
1368         [GTK][CMake] Tarball is created with wrong tarball paths
1369         https://bugs.webkit.org/show_bug.cgi?id=129496
1370
1371         Reviewed by Daniel Bates.
1372
1373         * gtk/make-dist.py:
1374         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1375         landing the original patch with some suggestions from the reviewer. With the
1376         checks corrected, the tarball path is constructed properly.
1377
1378 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1379
1380         Unreviewed. Update my email in contributors.json
1381
1382         * Scripts/webkitpy/common/config/contributors.json:
1383
1384 2014-03-05  Dean Jackson  <dino@apple.com>
1385
1386         [WebGL] Use WKSI to see what the system policy for WebGL is
1387         https://bugs.webkit.org/show_bug.cgi?id=129722
1388         <rdar://problem/15790542>
1389
1390         Reviewed by Tim Horton.
1391
1392         Dummy entry for setSystemWebGLLoadPolicy.
1393
1394         * WebKitTestRunner/TestController.cpp:
1395         (WTR::TestController::createWebViewWithOptions):
1396
1397 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1398
1399         [GTK][CMake] Generate documentation for the DOM bindings
1400         https://bugs.webkit.org/show_bug.cgi?id=126211
1401
1402         Reviewed by Carlos Garcia Campos.
1403
1404         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1405         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1406         * gtk/generate-webkitdom-doc-files: Removed.
1407         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1408         that it can be called by generate-gtkdoc.
1409
1410 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1411
1412         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1413         https://bugs.webkit.org/show_bug.cgi?id=129380
1414
1415         Reviewed by Philippe Normand.
1416
1417         * Scripts/webkitdirs.pm:
1418         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1419         skipping CMake execution.
1420
1421 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1422
1423         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1424         https://bugs.webkit.org/show_bug.cgi?id=129651
1425
1426         Reviewed by Philippe Normand.
1427
1428         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1429
1430 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1431
1432         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1433         https://bugs.webkit.org/show_bug.cgi?id=129637
1434
1435         Reviewed by Carlos Garcia Campos.
1436
1437         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1438         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1439         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1440         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1441         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1442         (TestFactory.__init__): Add the test for GTK+.
1443         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1444
1445 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1446
1447         [ATK] Expose missing functionalities of AtkTableCell to AT
1448         https://bugs.webkit.org/show_bug.cgi?id=129492
1449
1450         Reviewed by Mario Sanchez Prada.
1451
1452         Reducing some code by using new API of AtkTableCell.
1453
1454         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1455         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1456
1457 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1458
1459         Preparing to run layout tests on Wincairo.
1460         https://bugs.webkit.org/show_bug.cgi?id=129709
1461
1462         Reviewed by Brent Fulgham.
1463
1464         * Scripts/webkitdirs.pm:
1465         (setPathForRunningWebKitApp):
1466         Add GStreamer directory for WinCairo running layout tests.
1467         * win/DLLLauncher/DLLLauncherMain.cpp:
1468         (modifyPath):
1469         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1470
1471 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1472
1473         [GTK] Simplify the GObject DOM bindings API break check into one step
1474         https://bugs.webkit.org/show_bug.cgi?id=129571
1475
1476         Reviewed by Carlos Garcia Campos.
1477
1478         * GNUmakefile.am: Add the API break check to 'make check.'
1479         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1480         * gtk/check-gdom-symbols: Removed.
1481         * gtk/webkitdom.py: Added.
1482         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1483         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1484
1485 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1486
1487         Add Jeremy Jones to the contributors list as a contributor.
1488
1489         * Scripts/webkitpy/common/config/contributors.json:
1490
1491 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1492
1493         Unreviewed. Update contact email.
1494         https://bugs.webkit.org/show_bug.cgi?id=129610
1495
1496         * Scripts/webkitpy/common/config/contributors.json:
1497
1498 2014-03-02  Brian Burg  <bburg@apple.com>
1499
1500         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1501         https://bugs.webkit.org/show_bug.cgi?id=129460
1502
1503         Reviewed by Dan Bernstein.
1504
1505         Don't unconditionally open the inspector before running an inspector test.
1506         Instead, the test should request that the inspector open when it's ready.
1507
1508         This change was lost during a rebase, but is the same change made to
1509         DumpRenderTree.
1510
1511         * WebKitTestRunner/TestInvocation.cpp:
1512         (WTR::TestInvocation::invoke): 
1513
1514 2014-03-02  Darin Adler  <darin@apple.com>
1515
1516         Split TextIteratorBehavior into a separate header
1517         https://bugs.webkit.org/show_bug.cgi?id=129578
1518
1519         Reviewed by Sam Weinig.
1520
1521         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1522         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1523         task easy, but the remove is still a bit of a pain.
1524
1525 2014-03-02  Darin Adler  <darin@apple.com>
1526
1527         Sort Mac platform export files so they merge better
1528         https://bugs.webkit.org/show_bug.cgi?id=129581
1529
1530         Reviewed by Sam Weinig.
1531
1532         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1533         Mac export files in a "canonical" order for this project.
1534
1535 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1536
1537         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1538         https://bugs.webkit.org/show_bug.cgi?id=129438
1539
1540         Reviewed by Simon Fraser.
1541
1542         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1543         offscreen window. It makes testing subpixel rendering and positioning possible.
1544
1545         Both the offscreen window's and WebKit's scaling are set accordingly.
1546
1547         * DumpRenderTree/mac/DumpRenderTree.mm:
1548         (createWebViewAndOffscreenWindow): cleanup
1549         (destroyWebViewAndOffscreenWindow): cleanup
1550         (dumpRenderTree):
1551         (changeWindowScaleIfNeeded):
1552         (runTest):
1553         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1554         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1555         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
1556         * WebKitTestRunner/PlatformWebView.h:
1557         * WebKitTestRunner/TestInvocation.cpp:
1558         (WTR::changeWindowScaleIfNeeded):
1559         (WTR::TestInvocation::invoke):
1560         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1561         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1562         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1563         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1564         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1565         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1566         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1567         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1568
1569 2014-02-28  Anders Carlsson  <andersca@apple.com>
1570
1571         Remove logging.
1572
1573         Reviewed by Dan Bernstein.
1574
1575         * MiniBrowser/mac/WK2BrowserWindowController.m:
1576         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
1577
1578 2014-02-28  Daniel Bates  <dabates@apple.com>
1579
1580         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
1581         https://bugs.webkit.org/show_bug.cgi?id=129163
1582
1583         Reviewed by David Kilzer.
1584
1585         Fixes an issue where DumpRenderTree Perl Support may build with the specified
1586         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
1587         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
1588         bundle.
1589
1590         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
1591         which is specified either explicitly when building with MAKE(1) or implicitly by
1592         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
1593         the OS X SDK and toolchain since the built products are only applicable to OS X.
1594
1595         * DumpRenderTree/ios/PerlSupport/Makefile:
1596
1597 2014-02-28  Commit Queue  <commit-queue@webkit.org>
1598
1599         Unreviewed, rolling out r164859.
1600         http://trac.webkit.org/changeset/164859
1601         https://bugs.webkit.org/show_bug.cgi?id=129483
1602
1603         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
1604         #webkit).
1605
1606         * DumpRenderTree/mac/DumpRenderTree.mm:
1607         (createWebViewAndOffscreenWindow):
1608         (dumpRenderTree):
1609         (runTest):
1610         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1611         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1612         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
1613         * WebKitTestRunner/PlatformWebView.h:
1614         * WebKitTestRunner/TestInvocation.cpp:
1615         (WTR::TestInvocation::invoke):
1616         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1617         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1618         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1619         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1620         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1621
1622 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1623
1624         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1625         https://bugs.webkit.org/show_bug.cgi?id=129438
1626
1627         Reviewed by Simon Fraser.
1628
1629         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1630         offscreen window. It makes testing subpixel rendering and positioning possible.
1631
1632         Both the offscreen window's and WebKit's scaling are set accordingly.
1633
1634         * DumpRenderTree/mac/DumpRenderTree.mm:
1635         (createWebViewAndOffscreenWindow): unrelated cleanup.
1636         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
1637         (dumpRenderTree):
1638         (changeOffscreenWindowScaleIfNeeded):
1639         (runTest):
1640         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1641         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1642         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
1643         * WebKitTestRunner/PlatformWebView.h:
1644         * WebKitTestRunner/TestInvocation.cpp:
1645         (WTR::changeOffscreenWindowScaleIfNeeded):
1646         (WTR::TestInvocation::invoke):
1647         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1648         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
1649
1650 2014-02-27  Brian Burg  <bburg@apple.com>
1651
1652         Web Inspector: model tests should use a special Test.html inspector page
1653         https://bugs.webkit.org/show_bug.cgi?id=129190
1654
1655         Reviewed by Timothy Hatcher.
1656
1657         Remove code that immediately opens the Web Inspector based on the file path of the test.
1658         Instead, the test page should request that the inspector open inside its `test()` method.
1659
1660         This change is necessary because otherwise, the inspector would be opened too early for
1661         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
1662         will get loaded instead of the minimal test page.
1663
1664         * DumpRenderTree/efl/DumpRenderTree.cpp:
1665         (createTestRunner):
1666         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1667         (runTest):
1668         * DumpRenderTree/mac/DumpRenderTree.mm:
1669         (runTest):
1670         * DumpRenderTree/win/DumpRenderTree.cpp:
1671         (runTest):
1672
1673 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1674
1675         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
1676         https://bugs.webkit.org/show_bug.cgi?id=127076
1677
1678         Reviewed by Anders Carlsson.
1679
1680         Avoid match for :: as start of a member initialization list. Modify expression to match
1681         after a colon either non-colon character or end of line.
1682
1683         * Scripts/webkitpy/style/checkers/cpp.py:
1684         (check_member_initialization_list):
1685         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1686         (WebKitStyleTest.test_member_initialization_list):
1687
1688 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
1689
1690         Unreviewed. Update my email addresses in contributors.json.
1691
1692         * Scripts/webkitpy/common/config/contributors.json:
1693
1694 2014-02-27  Alberto Garcia  <berto@igalia.com>
1695
1696         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
1697         https://bugs.webkit.org/show_bug.cgi?id=128927
1698
1699         Reviewed by Philippe Normand.
1700
1701         Encode manually the data for sys.{stdout,stderr}.write.
1702
1703         * gtk/gtkdoc.py:
1704         (GTKDoc._run_command):
1705
1706 2014-02-27  Andres Gomez  <agomez@igalia.com>
1707
1708         Unreviewed. Add myself to watchlists
1709
1710         * Scripts/webkitpy/common/config/watchlist: Add myself to
1711         watchlists.
1712
1713 2014-02-27  Andres Gomez  <agomez@igalia.com>
1714
1715         Unreviewed, rolling out r164790.
1716         http://trac.webkit.org/changeset/164790
1717
1718         Revert r164790 because of erroneous commit log
1719
1720         * Scripts/webkitpy/common/config/watchlist:
1721
1722 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
1723
1724         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
1725         https://bugs.webkit.org/show_bug.cgi?id=129250
1726
1727         Reviewed by Mario Sanchez Prada.
1728
1729         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
1730         Implementing methods so that we could test column/row headers represented as an array of cells.
1731
1732         * DumpRenderTree/AccessibilityUIElement.cpp:
1733         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1734         (AccessibilityUIElement::columnHeaders):
1735         (AccessibilityUIElement::rowHeaders):
1736         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
1737         (AccessibilityUIElement::columnHeaders):
1738         (AccessibilityUIElement::rowHeaders):
1739         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1740         (WTR::AccessibilityUIElement::rowHeaders):
1741         (WTR::AccessibilityUIElement::columnHeaders):
1742         * efl/jhbuild.modules:
1743         * gtk/jhbuild.modules:
1744
1745 2014-02-27  Andres Gomez  <agomez@igalia.com>
1746
1747         Unreviewed. Add myself to watchlists
1748
1749         * Scripts/webkitpy/common/config/watchlist: Add myself to
1750         watchlists.
1751
1752 2014-02-27  Andres Gomez  <agomez@igalia.com>
1753
1754         Unreviewed. Add myself as a committer.
1755
1756         * Scripts/webkitpy/common/config/contributors.json:
1757
1758 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1759
1760         Unreviewed. Add Víctor Jáquez and myself to watchlists
1761
1762         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
1763         myself to watchlists.
1764
1765 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
1766
1767         Unreviewed. Add myself as a committer.
1768
1769         * Scripts/webkitpy/common/config/contributors.json:
1770
1771 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
1772
1773         Unreviewed. Moved myself to the list of committers.
1774
1775         * Scripts/webkitpy/common/config/contributors.json:
1776
1777 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1778
1779         [GTK] Reduplicate common.top_level_path in scripts
1780         https://bugs.webkit.org/show_bug.cgi?id=129291
1781
1782         Reviewed by Philippe Normand.
1783
1784         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
1785         path manipulation and weird dependencies on the jhbuild infrastructure.
1786
1787         * Scripts/run-gtk-tests: Use common again.
1788         (TestRunner._setup_testing_environment): Ditto.
1789         * gtk/check-gdom-symbols: Ditto.
1790         * gtk/common.py:
1791         (top_level_path): Re-add top_level_path..
1792         (get_build_path): Use the builtin top_level_path again.
1793         * gtk/find-make-dist-errors: Use common again.
1794         (get_missing_headers): Ditto.
1795         * gtk/generate-inspector-gresource-manifest.py: Ditto.
1796
1797 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1798
1799         runscript: line 42: /bin/ls: Argument list too long
1800         https://bugs.webkit.org/show_bug.cgi?id=129376
1801
1802         Reviewed by Michael Saboff.
1803
1804         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
1805         We should use find instead, which generates the list of files rather than expanding them all on 
1806         the command line and spitting them back out.
1807
1808         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
1809
1810 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1811
1812         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
1813         https://bugs.webkit.org/show_bug.cgi?id=129377
1814
1815         Reviewed by Csaba Osztrogonác.
1816
1817         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
1818
1819 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
1820
1821         [GTK] Re-enable gtk-doc in EWS
1822         https://bugs.webkit.org/show_bug.cgi?id=128369
1823
1824         Reviewed by Carlos Garcia Campos.
1825
1826         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1827
1828         * Scripts/webkitpy/common/config/ports.py:
1829         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1830         (GtkWK2Port.build_webkit_command): Ditto.
1831         * Scripts/webkitpy/common/config/ports_unittest.py:
1832         (DeprecatedPortTest.test_gtk_port): Ditto.
1833         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1834
1835 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
1836
1837         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
1838         https://bugs.webkit.org/show_bug.cgi?id=129319
1839
1840         Reviewed by Carlos Garcia Campos.
1841
1842         * gtk/generate-gtkdoc:
1843         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
1844
1845 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
1846
1847         Unreviewed. Add myself as a committer.
1848
1849         * Scripts/webkitpy/common/config/contributors.json:
1850
1851 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
1852
1853         [CSS Grid Layout] Add ENABLE flag
1854         https://bugs.webkit.org/show_bug.cgi?id=129153
1855
1856         Reviewed by Simon Fraser.
1857
1858         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
1859         all ports for developer builds.
1860
1861         * Scripts/webkitperl/FeatureList.pm:
1862
1863 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
1864
1865         Added myself as a committer.
1866
1867         Unreviewed.
1868
1869         * Scripts/webkitpy/common/config/contributors.json:
1870
1871 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1872
1873         Unreviewed. Moved myself to the list of committers.
1874
1875         * Scripts/webkitpy/common/config/contributors.json:
1876
1877 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1878
1879         Move myself to the committers list.
1880
1881         Unreviewed.
1882
1883         * Scripts/webkitpy/common/config/contributors.json:
1884
1885 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
1886
1887         Unreviewed. Add myself as a committer.
1888
1889         * Scripts/webkitpy/common/config/contributors.json:
1890
1891 2014-02-25  Commit Queue  <commit-queue@webkit.org>
1892
1893         Unreviewed, rolling out r164639.
1894         http://trac.webkit.org/changeset/164639
1895         https://bugs.webkit.org/show_bug.cgi?id=129302
1896
1897         gtk-doc still have problems in EWS (Requested by rego on
1898         #webkit).
1899
1900         * Scripts/webkitpy/common/config/ports.py:
1901         (GtkPort.build_webkit_command):
1902         (GtkWK2Port.build_webkit_command):
1903         * Scripts/webkitpy/common/config/ports_unittest.py:
1904         (DeprecatedPortTest.test_gtk_port):
1905         (DeprecatedPortTest.test_gtk_wk2_port):
1906
1907 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
1908
1909         [GTK] Re-enable gtk-doc in EWS
1910         https://bugs.webkit.org/show_bug.cgi?id=128369
1911
1912         Reviewed by Carlos Garcia Campos.
1913
1914         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
1915
1916         * Scripts/webkitpy/common/config/ports.py:
1917         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
1918         (GtkWK2Port.build_webkit_command): Ditto.
1919         * Scripts/webkitpy/common/config/ports_unittest.py:
1920         (DeprecatedPortTest.test_gtk_port): Ditto.
1921         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
1922
1923 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1924
1925         [GTK] Mark view source mode methods as deprecated
1926         https://bugs.webkit.org/show_bug.cgi?id=128920
1927
1928         Reviewed by Martin Robinson.
1929
1930         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1931         (beforeAll): Remove view mode test.
1932
1933 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
1934
1935         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
1936         https://bugs.webkit.org/show_bug.cgi?id=128417
1937
1938         Reviewed by Carlos Garcia Campos.
1939
1940         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
1941         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
1942         a makefile. This allows accepting a header list from the build system, which can be used
1943         to dynamically build a list of ignored files. We can ignore any source file that doesn't
1944         have a corresponding header file on the header list. 
1945         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
1946         source directories to gtkdoc-scan.
1947
1948 2014-02-24  Anders Carlsson  <andersca@apple.com>
1949
1950         Add a DefaultVisitedLinkProvider and route visited link actions through it
1951         https://bugs.webkit.org/show_bug.cgi?id=129285
1952
1953         Reviewed by Dan Bernstein.
1954
1955         * MiniBrowser/mac/AppDelegate.m:
1956         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1957         Set a shared history so we'll get visited link tracking.
1958
1959         * MiniBrowser/mac/WK1BrowserWindowController.m:
1960         (-[WK1BrowserWindowController awakeFromNib]):
1961         Set a group name.
1962
1963 2014-02-24  Dan Bernstein  <mitz@apple.com>
1964
1965         iOS build fix after r164577.
1966
1967         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1968         (AccessibilityUIElement::selectedChildrenCount):
1969         (AccessibilityUIElement::selectedChildAtIndex):
1970
1971 2014-02-24  David Kilzer  <ddkilzer@apple.com>
1972
1973         [ASan] Remove methods from ignore list that no longer cause crashes
1974         <http://webkit.org/b/129257>
1975
1976         Reviewed by Anders Carlsson.
1977
1978         * asan/webkit-asan-ignore.txt: Remove old methods.
1979
1980 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1981
1982         Extract common parts from jhbuildrc files.
1983         https://bugs.webkit.org/show_bug.cgi?id=125986
1984
1985         Reviewed by Csaba Osztrogonác.
1986
1987         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
1988
1989         * Scripts/run-gtk-tests:
1990         (TestRunner._setup_testing_environment):
1991         * efl/common.py: Removed.
1992         * efl/jhbuildrc:
1993         * gtk/check-gdom-symbols:
1994         * gtk/common.py:
1995         (binary_build_path):
1996         (get_build_path):
1997         * gtk/find-make-dist-errors:
1998         (get_missing_headers):
1999         * gtk/generate-gtkdoc:
2000         (get_webkit2_options):
2001         (get_webkit1_options.src_path):
2002         (get_webkit1_options):
2003         (get_webkitdom_options.src_path):
2004         (get_webkitdom_options):
2005         * gtk/generate-inspector-gresource-manifest.py:
2006         * gtk/jhbuildrc:
2007         * jhbuild/jhbuildrc_common.py: Added.
2008         (script_path):
2009         (top_level_path):
2010         (init):
2011
2012 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2013
2014         Unreviewed. Fix code indentation and spacing.
2015
2016         * Scripts/webkitpy/style/checkers/js.py:
2017         (SingleQuoteChecker.check):
2018
2019 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2020
2021         [ATK] Wrong selected element at a given index in a list box.
2022         https://bugs.webkit.org/show_bug.cgi?id=129039
2023
2024         Reviewed by Chris Fleizach.
2025
2026         Added missing implementation and proposed some new function for testing selection
2027         in a list boxes.
2028
2029         * DumpRenderTree/AccessibilityUIElement.cpp:
2030         (setSelectedChildAtIndexCallback):
2031         (removeSelectionAtIndexCallback):
2032         (AccessibilityUIElement::getJSClass):
2033         * DumpRenderTree/AccessibilityUIElement.h:
2034         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2035         (AccessibilityUIElement::selectedChildrenCount):
2036         (AccessibilityUIElement::selectedChildAtIndex):
2037         (AccessibilityUIElement::setSelectedChildAtIndex):
2038         (AccessibilityUIElement::removeSelectionAtIndex):
2039         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2040         (AccessibilityUIElement::selectedChildrenCount):
2041         (AccessibilityUIElement::selectedChildAtIndex):
2042         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2043         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2044         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2045         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2046         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2047         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2048         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2049         (WTR::AccessibilityUIElement::selectedChildrenCount):
2050         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2051         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2052
2053 2014-02-23  Diego Pino García  <dpino@igalia.com>
2054
2055         [GTK] Fix build after Web Inspector code reorganization (r164543)
2056         https://bugs.webkit.org/show_bug.cgi?id=129231
2057
2058         Reviewed by Dean Jackson.
2059
2060         * gtk/generate-inspector-gresource-manifest.py:
2061         Modify paths to Web Inspector code.
2062
2063 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2064
2065         [GTK] generate-gtkdoc should use argparse
2066         https://bugs.webkit.org/show_bug.cgi?id=128418
2067
2068         Reviewed by Carlos Garcia Campos.
2069
2070         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2071         to all functions, and guard the main routine with a __name__ == __main__ check.
2072
2073 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2074
2075         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2076         https://bugs.webkit.org/show_bug.cgi?id=129191
2077
2078         Reviewed by Anders Carlsson.
2079
2080         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2081         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2082         name of the directory is "lib" and not "libs". Instead we should use the CMake
2083         variable specifically assigned to this task.
2084
2085 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2086
2087         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2088         <http://webkit.org/b/129209>
2089
2090         Reviewed by Geoffrey Garen.
2091
2092         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2093         ignore list to make ASan builds usable again.  Follow-up
2094         investigation is tracked by <rdar://problem/16055903>.
2095
2096 2014-02-20  David Farler  <dfarler@apple.com>
2097
2098         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2099         https://bugs.webkit.org/show_bug.cgi?id=128622
2100
2101         Reviewed by Simon Fraser.
2102
2103         With this change, we now have layout tests running in both DumpRenderTree
2104         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2105         simulator.
2106
2107         * Scripts/old-run-webkit-tests:
2108         In general, make any specific reference to DumpRenderTree
2109         able to refer to WebKitTestRunner wherever possible:
2110         - Rename functions to remove DRT-specific naming.
2111         - Name FIFOs after the tool that is being used.
2112         -- Clean up FIFO creation code
2113         Other necessary changes:
2114         - Allow use of an ios-sim-wk2 platform.
2115         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2116         * WebKitTestRunner/TestController.cpp:
2117         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2118         (WTR::TestController::TestController):
2119         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2120         Copy the injected bundle into the app bundle.
2121
2122 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2123
2124         run-webkit-httpd fails to find httpd configuation file.
2125
2126         Reviewed by Ryosuke Niwa.
2127
2128         * Scripts/webkitperl/httpd.pm:
2129         (getHTTPDConfigPathForTestDirectory):
2130
2131 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2132
2133         Fix TimeRanges layering violations
2134         https://bugs.webkit.org/show_bug.cgi?id=128717
2135
2136         Reviewed by Jer Noble.
2137
2138         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2139         (TestWebKitAPI::TEST):
2140
2141 2014-02-21  Diego Pino García  <dpino@igalia.com>
2142
2143         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2144         https://bugs.webkit.org/show_bug.cgi?id=128422
2145
2146         Reviewed by Joseph Pecoraro.
2147
2148         * Scripts/webkitpy/style/checkers/js.py:
2149         (JSChecker.__init__):
2150         (JSChecker.check):
2151         (SingleQuoteChecker):
2152         (SingleQuoteChecker.__init__):
2153         (SingleQuoteChecker.check):
2154         * Scripts/webkitpy/style/checkers/js_unittest.py:
2155         (JSTestCase.assertError.error_for_test):
2156         (JSTestCase.assertError):
2157         (JSTestCase.test_no_error):
2158         (JSTestCase.test_error):
2159
2160 == Rolled over to ChangeLog-2014-02-20 ==