Simplify building with ASan
[WebKit-https.git] / Tools / ChangeLog
1 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
2
3         Simplify building with ASan
4         https://bugs.webkit.org/show_bug.cgi?id=139916
5
6         Reviewed by Mark Rowe.
7
8         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
9         We could also update Configuration file format, but that's a little scary because
10         of how many places in code read it.
11
12         * Scripts/webkitdirs.pm:
13         (determineASanIsEnabled): Read it from ASan configuration file.
14         (argumentsForConfiguration): Added a FIXME.
15         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
16         (XcodeOptions): Pass the options needed for ASan.
17
18         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
19         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
20         that automatically.
21
22 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
23
24         TestWebKitAPI build is broken when ASan is enabled
25         https://bugs.webkit.org/show_bug.cgi?id=139902
26
27         Reviewed by Darin Adler.
28
29         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
30         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
31         Inherit linker flags from DebugRelease, which respects ASAN.
32
33 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
34
35         Sort the Xcode project file.
36
37         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
38
39 2014-12-22  Lucas Forschler  <lforschler@apple.com>
40
41         Update apple-mac-114 to bot629.
42         
43         Unreviewed.
44         
45         * BuildSlaveSupport/build.webkit.org-config/config.json:
46
47 2014-12-22  Lucas Forschler  <lforschler@apple.com>
48
49         Replace Apple bot104 with bot124.
50         
51         Unreviewed.
52         
53         * BuildSlaveSupport/build.webkit.org-config/config.json:
54
55 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
56
57         URTBF after r177639.
58
59         * TestWebKitAPI/CMakeLists.txt:
60
61 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
62
63         [EFL] MiniBrowser steals web view's focus
64         https://bugs.webkit.org/show_bug.cgi?id=139482
65
66         Reviewed by Gyuyoung Kim.
67
68         Although we set focus on ewk_view while MiniBrowser initialization
69         Ecore steals it in a favor of main window. As a result
70         focused element on web page is unable to receive events.
71
72         * MiniBrowser/efl/main.c:
73         (window_create):
74         Prevent window from stealing web view's focus on start up.
75
76 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
77
78         [Win] Revise DRT logic to match Mac.
79
80         Rubberstamped by Anders Carlsson.
81
82         Update the Windows logic to perform initialization of preferences and WebKit
83         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
84         the same circumstances as the Mac version.
85
86         * DumpRenderTree/win/DumpRenderTree.cpp:
87         (dump):
88         (resetWebPreferencesToConsistentValues):
89         (setDefaultsToConsistentValuesForTesting):
90         (resetWebViewToConsistentStateBeforeTesting):
91         (sizeWebViewForCurrentTest):
92         (runTest):
93         (createWebViewAndOffscreenWindow):
94         (allocateGlobalControllers):
95         (prepareConsistentTestingEnvironment):
96         (main):
97         (resetDefaultsToConsistentValues): Deleted.
98
99 2014-12-19  Roger Fong  <roger_fong@apple.com>
100
101         Unreviewed. Rollout r177605.
102
103         * EWSTools/start-queue-win.sh:
104
105 2014-12-19  Roger Fong  <roger_fong@apple.com>
106
107         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
108
109         * EWSTools/start-queue-win.sh:
110
111 2014-12-19  Daniel Bates  <dabates@apple.com>
112
113         [iOS] Add WebKitSystemInterface for iOS 8.1
114         https://bugs.webkit.org/show_bug.cgi?id=139831
115
116         Reviewed by Alexey Proskuryakov.
117
118         Implement support in copy-webkitlibraries-to-product-directory to copy
119         WebKitSystemInterface for iOS to the product directory and have build-webkit
120         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
121
122         * Scripts/build-webkit:
123         * Scripts/copy-webkitlibraries-to-product-directory:
124
125 2014-12-19  Daniel Bates  <dabates@apple.com>
126
127         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
128         https://bugs.webkit.org/show_bug.cgi?id=139829
129
130         Reviewed by Alexey Proskuryakov.
131
132         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
133         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
134         expects the Xcode SDK to be specified using the --sdk-name command line argument.
135
136         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
137         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
138         logic to both avoid duplicating effort and make the command line options for
139         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
140         with the approach used in other WebKit tools.
141
142         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
143         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
144         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
145
146         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
147         improve the readability of the code.
148         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
149         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
150         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
151         be included in a library.
152         (unpackIfNecessary): Modified to call executeRanlib().
153
154 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
155
156         REGRESSION (177368): Some tests started to immediately time out
157         https://bugs.webkit.org/show_bug.cgi?id=139826
158
159         Reviewed by Daniel Bates.
160
161         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
162         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
163         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
164         ends in a load failure, we don't dump, so we used to leak the timer.
165         
166         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
167         Added a comment.
168
169 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
170
171         [Win] Add accessor for serializing HTTP loads
172         https://bugs.webkit.org/show_bug.cgi?id=139817
173
174         Reviewed by Mark Lam.
175
176         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
177         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
178         remove some redundant code from the destructor.
179
180 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
181
182         Clean up a fix for performance test bot failing to build
183         https://bugs.webkit.org/show_bug.cgi?id=139818
184
185         Reviewed by Csaba Osztrogonác.
186
187         The "_1" in step name was annoying.
188
189         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
190         (CleanBuildIfScheduled.start):
191         (RunAndUploadPerfTests):
192         (DownloadAndPerfTestFactory.__init__):
193         (DownloadAndPerfTestWebKit2Factory.__init__):
194         (CleanBuildUnconditionally): Deleted.
195         (CleanBuildUnconditionally.start): Deleted.
196
197 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
198
199         REGRESSION(r177535): It broke the GTK performance bot
200         https://bugs.webkit.org/show_bug.cgi?id=139811
201
202         Reviewed by Carlos Garcia Campos.
203
204         Trigger clean build only on mac platform.
205
206         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
207         (DownloadAndPerfTestFactory.__init__):
208         (DownloadAndPerfTestWebKit2Factory.__init__):
209
210 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
211
212         Unreviewed, moved myself to the list of committers.
213
214         * Scripts/webkitpy/common/config/contributors.json:
215
216 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
217
218         [Win] Update DumpRenderTree to more closely match Mac version
219         https://bugs.webkit.org/show_bug.cgi?id=139799
220
221         Reviewed by Tim Horton.
222
223         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
224         (AccessibilityController::accessibleElementById): Correct
225         use of BSTR to avoid leak.
226         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
227         update to match Mac version more closely.
228         (dumpFramesAsText):
229         (dump):
230         (resetDefaultsToConsistentValues):
231         (resetWebViewToConsistentStateBeforeTesting):
232         (sizeWebViewForCurrentTest):
233         (runTest):
234         (openWindows):
235         (windowToWebViewMap):
236         (createWebViewAndOffscreenWindow):
237         (sharedCFURLCache):
238         (initializeGlobalsFromCommandLineOptions):
239         (main):
240         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
241         (TestRunner::addDisallowedURL):
242         (TestRunner::applicationCacheDiskUsageForOrigin):
243         (TestRunner::syncLocalStorage):
244         (TestRunner::localStorageDiskUsageForOrigin):
245         (TestRunner::observeStorageTrackerNotifications):
246         (TestRunner::clearApplicationCacheForOrigin):
247         (TestRunner::originsWithApplicationCache):
248         (TestRunner::deleteAllLocalStorage):
249         (TestRunner::setStorageDatabaseIdleInterval):
250         (TestRunner::closeIdleLocalStorageDatabases):
251         (TestRunner::originsWithLocalStorage):
252         (TestRunner::deleteLocalStorageForOrigin):
253         (TestRunner::copyDecodedHostName):
254         (TestRunner::copyEncodedHostName):
255         (TestRunner::keepWebHistory):
256         (TestRunner::numberOfPendingGeolocationPermissionRequests):
257         (TestRunner::setAppCacheMaximumSize):
258         (TestRunner::setCustomPolicyDelegate):
259         (TestRunner::goBack):
260         (TestRunner::setDefersLoading):
261         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
262         (TestRunner::setMockDeviceOrientation):
263         (TestRunner::setMockGeolocationPosition):
264         (TestRunner::setMockGeolocationPositionUnavailableError):
265         (TestRunner::setIconDatabaseEnabled):
266         (TestRunner::setMainFrameIsFirstResponder):
267         (TestRunner::setSpatialNavigationEnabled):
268         (TestRunner::setPluginsEnabled):
269         (TestRunner::setAutomaticLinkDetectionEnabled):
270         (TestRunner::setUseDashboardCompatibilityMode):
271         (TestRunner::dispatchPendingLoadRequests):
272         (TestRunner::findString):
273         (TestRunner::setCacheModel):
274         (TestRunner::apiTestNewWindowDataLoadBaseURL):
275         (TestRunner::setWebViewEditable):
276         (TestRunner::authenticateSession):
277         (TestRunner::abortModal):
278         (TestRunner::setSerializeHTTPLoads):
279         (TestRunner::addChromeInputField):
280         (TestRunner::removeChromeInputField):
281         (TestRunner::focusWebView):
282         (TestRunner::setBackingScaleFactor):
283         (TestRunner::grantWebNotificationPermission):
284         (TestRunner::denyWebNotificationPermission):
285         (TestRunner::removeAllWebNotificationPermissions):
286         (TestRunner::simulateWebNotificationClick):
287
288 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
289
290         Add strong typing to RefCounter interface, return value as a bool.
291         https://bugs.webkit.org/show_bug.cgi?id=139776
292
293         Reviewed by Geoff Garen.
294
295         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
296         This means there is no compile time type checking to prevent mistakes. Update the count()
297         method to token<>(), templated on type used to identify the token being returned.
298         Calls to token<T>() will return a result of type RefCounter::Token<T>.
299
300         There are a few problems with the fact the counter will return you an exact count of the
301         number of outstanding tokens:
302           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
303             to do so if the value is only readable as a boolean.
304           - It is desirable to provide the value as an argument to the callback, however to make
305             this useful for integer values it is also necessary to indicate the direction of change
306             (0->1 is often interesting where 2->1 is not).
307           - There is a mismatch between the precision of returning a count, and the inherent
308             imprecision of a token based mechanism, where it may be difficult to guarantee
309             absolutely no unnecessary refcount churn, and thus unintentional counter values.
310
311         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
312         (TestWebKitAPI::TEST):
313             - update API test.
314
315 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
316
317         Disable retries on Mac Release WK2 testers
318         https://bugs.webkit.org/show_bug.cgi?id=139798
319
320         Reviewed by Simon Fraser.
321
322         * BuildSlaveSupport/build.webkit.org-config/config.json:
323
324 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
325
326         Perf tests frequently fail saying "build not up to date"
327         https://bugs.webkit.org/show_bug.cgi?id=139786
328
329         Illegitimately yet authoritatively reviewed by Lucas Forschler.
330
331         Undo the rest of the first fix, and implement the behavior differently.
332
333         is_clean isn't automatically forwarded from config.json to properties.
334
335         * BuildSlaveSupport/build.webkit.org-config/config.json:
336         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
337         (CleanBuildUnconditionally):
338         (CleanBuildUnconditionally.start):
339         (DownloadAndPerfTestFactory.__init__):
340         (DownloadAndPerfTestWebKit2Factory.__init__):
341
342 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
343
344         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
345         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
346         found nothing.
347
348         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
349         (BuildAndPerfTestFactory):
350         (BuildAndPerfTestWebKit2Factory):
351
352 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
353
354         Perf tests frequently fail saying "build not up to date"
355         https://bugs.webkit.org/show_bug.cgi?id=139786
356
357         Reviewed by Ryosuke Niwa.
358
359         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
360         directory to get rid of stale precompiled headers, and let it rebuild
361         DumpRenderTree each time, that's fast.
362
363         Also, removed unused "build and perf test" code.
364
365         * BuildSlaveSupport/build.webkit.org-config/config.json:
366
367 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
368
369         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
370
371         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
372         it easier to see what steps are missing when running under Windows.
373
374         * DumpRenderTree/win/TestRunnerWin.cpp:
375         (TestRunner::callShouldCloseOnWebView):
376         (TestRunner::clearAllApplicationCaches):
377         (TestRunner::applicationCacheDiskUsageForOrigin):
378         (TestRunner::syncLocalStorage):
379         (TestRunner::localStorageDiskUsageForOrigin):
380         (TestRunner::observeStorageTrackerNotifications):
381         (TestRunner::clearApplicationCacheForOrigin):
382         (TestRunner::originsWithApplicationCache):
383         (TestRunner::clearAllDatabases):
384         (TestRunner::deleteAllLocalStorage):
385         (TestRunner::setStorageDatabaseIdleInterval):
386         (TestRunner::closeIdleLocalStorageDatabases):
387         (TestRunner::originsWithLocalStorage):
388         (TestRunner::deleteLocalStorageForOrigin):
389         (TestRunner::numberOfPendingGeolocationPermissionRequests):
390         (jsStringRefToWString):
391         (TestRunner::setAppCacheMaximumSize):
392         (TestRunner::setDatabaseQuota):
393         (TestRunner::goBack):
394         (TestRunner::setDefersLoading):
395         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
396         (TestRunner::setAutomaticLinkDetectionEnabled):
397         (TestRunner::dispatchPendingLoadRequests):
398         (TestRunner::overridePreference):
399         (TestRunner::removeAllVisitedLinks):
400         (TestRunner::waitForPolicyDelegate):
401         (TestRunner::resetPageVisibility):
402         (TestRunner::setPageVisibility):
403         (TestRunner::grantWebNotificationPermission):
404         (TestRunner::denyWebNotificationPermission):
405         (TestRunner::removeAllWebNotificationPermissions):
406         (TestRunner::simulateWebNotificationClick):
407         (TestRunner::simulateLegacyWebNotificationClick):
408
409 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
410
411         [Win] Correct Windows tests after Bug 139149 (edit)
412         https://bugs.webkit.org/show_bug.cgi?id=139781
413
414         Reviewed by Anders Carlsson.
415
416         * DumpRenderTree/win/TestRunnerWin.cpp:
417         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
418         interface.
419
420 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
421
422         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
423         https://bugs.webkit.org/show_bug.cgi?id=139748
424
425         Reviewed by Daniel Bates.
426         
427         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
428         have all been updated.
429
430         * Scripts/webkitpy/port/factory.py:
431         (platform_options):
432
433 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
434
435         Build more of TestWebKitAPI for iOS
436         https://bugs.webkit.org/show_bug.cgi?id=139747
437
438         Reviewed by Daniel Bates.
439         
440         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
441         which excluded some tests that should be run for iOS.
442         
443         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
444         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
445         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
446         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
447         
448         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
449         to share code between Mac and iOS.
450
451         * TestWebKitAPI/Configurations/Base.xcconfig:
452         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
453         * TestWebKitAPI/InjectedBundleController.cpp:
454         * TestWebKitAPI/InjectedBundleMain.cpp:
455         * TestWebKitAPI/JavaScriptTest.cpp:
456         * TestWebKitAPI/PlatformUtilities.cpp:
457         * TestWebKitAPI/PlatformUtilities.h:
458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
459         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
460         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
461         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
462         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
463         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
464         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
465         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
466         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
467         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
468         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
469         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
470         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
471         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
472         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
473         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
474         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
475         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
476         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
477         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
478         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
479         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
480         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
481         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
482         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
483         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
484         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
485         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
486         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
487         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
488         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
489         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
490         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
491         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
492         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
493         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
494         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
495         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
496         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
497         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
498         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
499         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
500         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
501         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
502         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
503         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
504         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
505         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
506         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
507         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
508         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
509         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
510         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
511         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
512         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
513         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
514         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
515         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
516         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
517         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
518         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
519         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
520         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
521         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
522         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
523         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
524         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
525         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
526         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
527         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
528         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
529         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
530         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
531         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
532         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
533         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
534         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
535         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
536         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
537         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
538         (TestWebKitAPI::TEST):
539         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
540         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
541         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
542         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
543         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
544         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
545         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
546         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
547         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
548         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
549         (TEST):
550         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
551         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
552         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
553         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
554         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
555         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
556         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
557         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
558         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
559         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
560         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
561         (TestWebKitAPI::Util::run):
562         (TestWebKitAPI::Util::sleep):
563         (TestWebKitAPI::Util::toSTD):
564         * TestWebKitAPI/config.h:
565         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
566         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
567         (TestWebKitAPI::Util::run): Deleted.
568         (TestWebKitAPI::Util::sleep): Deleted.
569         (TestWebKitAPI::Util::toSTD): Deleted.
570
571 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
572
573         [GTK] Add support for FTL JIT on ARM64
574         https://bugs.webkit.org/show_bug.cgi?id=139677
575
576         Reviewed by Csaba Osztrogonác.
577
578         * gtk/jhbuild-optional.modules:
579         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
580         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
581
582 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
583
584         [GTK] Implement webkit_web_view_is_playing_audio()
585         https://bugs.webkit.org/show_bug.cgi?id=138918
586
587         Reviewed by Carlos Garcia Campos.
588
589         Add test case case for webkit_web_view_is_playing_audio() and the
590         WebKitWebView::is-playing-audio property.
591
592         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
593         (urlForResource): Utility function to get URLs pointing to resources
594         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
595         (testWebViewIsPlayingAudio): Added.
596         (beforeAll):
597         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
598         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
599         API tests resources directory, or the WebKit2 C API tests resources
600         directory. The default value of the flag is to use the WebKit2 GTK
601         one, to avoid having to change existing tests.
602         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
603         (isPlayingAudioChanged): Added.
604         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
605         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
606
607 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
608
609         [GTK] [EFL] Enable per_test_timeout
610         https://bugs.webkit.org/show_bug.cgi?id=139771
611
612         Reviewed by Csaba Osztrogonác.
613
614         This is needed to make WKTR use either the default port timeout, or the
615         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
616         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
617
618         * Scripts/webkitpy/port/efl.py:
619         (EflPort.supports_per_test_timeout): Enabled.
620         * Scripts/webkitpy/port/gtk.py:
621         (GtkPort.supports_per_test_timeout): Enabled.
622
623 2014-12-17  Lucas Forschler  <lforschler@apple.com>
624
625         Move Apple buildbot slaves to their new home.
626         
627         Reviewed by Roger Fong.
628
629         * BuildSlaveSupport/build.webkit.org-config/config.json:
630
631 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
632
633         REGRESSION (r177363): Gtk and Efl testing is broken
634         https://bugs.webkit.org/show_bug.cgi?id=139734
635
636         Reviewed by Simon Fraser.
637
638         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
639         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
640         affected both script and tool timeout. This is still the right place for this logic,
641         but it would be a larger refactoring than I can do right now.
642
643         * Scripts/webkitpy/port/base.py:
644         (Port.supports_per_test_timeout): Added a FIXME.
645         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
646         to avoid making tests take more time.
647
648         * Scripts/webkitpy/port/driver.py:
649         (Driver.run_test): Adjust script timeout here.
650         (Driver._check_for_driver_timeout): Fix the timeout detection.
651         (Driver._read_block): Actually use the timeout detection code.
652
653         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
654         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
655
656         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
657         Update results for the new default.
658
659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
660         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
661         actually a good one.
662
663 2014-12-17  Commit Queue  <commit-queue@webkit.org>
664
665         Unreviewed, rolling out r177456.
666         https://bugs.webkit.org/show_bug.cgi?id=139749
667
668         Broke webkitpy and Mac tests (Requested by ap on #webkit).
669
670         Reverted changeset:
671
672         "REGRESSION (r177363): Gtk and Efl testing is broken"
673         https://bugs.webkit.org/show_bug.cgi?id=139734
674         http://trac.webkit.org/changeset/177456
675
676 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
677
678         REGRESSION (r177363): Gtk and Efl testing is broken
679         https://bugs.webkit.org/show_bug.cgi?id=139734
680
681         Reviewed by Simon Fraser.
682
683         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
684         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
685         affected both script and tool timeout. This is still the right place for this logic,
686         but it would be a larger refactoring than I can do right now.
687
688         * Scripts/webkitpy/port/base.py:
689         (Port.supports_per_test_timeout): Added a FIXME.
690         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
691         to avoid making tests take more time.
692
693         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
694
695         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
696         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
697
698 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
699
700         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
701         https://bugs.webkit.org/show_bug.cgi?id=139725
702
703         Reviewed by Martin Robinson.
704
705         The timeout is already in milliseconds, so we don't need to do any conversion.
706
707         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
708         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
709
710 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
711
712         [EFL]Fix build warning in MiniBrowser
713         https://bugs.webkit.org/show_bug.cgi?id=139723
714
715         Reviewed by Darin Adler.
716
717         The warning is caused by the compiler wanting the first argument to be a
718         string literal, not a dynamically created string.
719
720         * MiniBrowser/efl/main.c:
721         (quit):
722
723 2014-12-16  Sam Weinig  <sam@webkit.org>
724
725         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
726         https://bugs.webkit.org/show_bug.cgi?id=139718
727
728         Reviewed by Mark Rowe.
729
730         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
731         files into a static lib which the command line utility can link link against.
732         This will allow us to create a TestWebKitAPI.app that can run on iOS.
733
734         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
735         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
736         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
737
738 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
739
740         Sort out timeout implementations in DRT and WKTR
741         https://bugs.webkit.org/show_bug.cgi?id=139671
742
743         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
744         with the tool.
745
746         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
747         (RunTest.test_hung_thread):
748
749 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
750
751         Sort out timeout implementations in DRT and WKTR
752         https://bugs.webkit.org/show_bug.cgi?id=139671
753
754         Reviewed by Simon Fraser.
755
756         Test timeout implementation had many deficiencies, please see the bug for details.
757         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
758         [ Slow ] modifiers should work a lot better.
759
760         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
761         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
762         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
763         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
764         DumpRenderTree already read the --timeout option from command line, and webkitpy
765         was already configured to pass it on Mac and iOS. Let's actually use it.
766         TestCommand already had the same 30 second default, so this doesn't change behavior
767         when DRT is ran manually without the option.
768         Windows DumpRenderTree will need to be fixed separately (that's easy).
769
770         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
771         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
772         slightly better to use stderr in both, as this is an out of band message, but
773         that's a larger refactoring, and the difference is minimal in practice.
774
775         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
776         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
777         different. We want the tool to reliably detect timeouts that can be detected, and
778         not race with the script for that.
779
780         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
781         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
782         is honored inmore cases, that could make tests run slower.
783         * Scripts/webkitpy/port/driver.py:
784         (Driver.__init__):
785         (Driver.run_test):
786         (Driver.cmd_line):
787         (Driver._check_for_driver_timeout):
788         Detect tests that have the timeout output, and make these have the proper Timeout result.
789
790         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
791         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
792
793         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
794         (WTR::TestRunner::setCustomTimeout): Deleted.
795         * WebKitTestRunner/InjectedBundle/TestRunner.h:
796         (WTR::TestRunner::setCustomTimeout):
797         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
798         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
799         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
800         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
801         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
802         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
803         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
804         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
805         Updated to use a timeout passed from UI process, which used to be ignored.
806
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::TestController::TestController):
809         (WTR::TestController::runUntil):
810         (WTR::TestController::getCustomTimeout): Deleted.
811         * WebKitTestRunner/TestController.h:
812         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
813         Changed default message timeouts to match new run-webkit-tests timeout. These don't
814         affect ports where timeout is passed per test (shouldn't they all be like that?).
815
816         * WebKitTestRunner/TestInvocation.cpp:
817         (WTR::TestInvocation::invoke):
818         (WTR::TestInvocation::setCustomTimeout): Deleted.
819         * WebKitTestRunner/TestInvocation.h:
820         (WTR::TestInvocation::setCustomTimeout):
821         (WTR::TestInvocation::customTimeout):
822         Ditto.
823
824 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
825
826         [EFL] Add logging domain for MiniBrowser
827         https://bugs.webkit.org/show_bug.cgi?id=139642
828
829         Reviewed by Gyuyoung Kim.
830
831         Similarly to EWebKit2, provide logging facility for MiniBrowser
832         based on Eina Log module to have a convenient way to display
833         all/subset/none messages for EFL based libraries and MiniBrowser.
834
835         Usage:
836         1. Disable all messages:
837            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
838
839         2. Enable all messages:
840            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
841
842         3. Enable MiniBrowser and EWebkit2 messages only:
843            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
844
845         More information and examples you can find here:
846         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
847
848         * MiniBrowser/efl/main.c:
849         (on_mouse_wheel):
850         (on_window_resize):
851         (save_page_contents_callback):
852         (script_execute_callback):
853         (on_key_down):
854         (on_download_request):
855         (on_download_finished):
856         (on_download_failed):
857         (quit):
858         (on_refresh_button_clicked):
859         (on_stop_button_clicked):
860         (navigation_button_longpress_process):
861         (on_popup_menu_item_clicked):
862         (popup_menu_populate):
863         (on_popup_menu_show):
864         (on_window_create):
865         (context_menu_item_selected_cb):
866         (context_menu_populate):
867         (on_context_menu_show):
868         (on_context_menu_hide):
869         (on_navigation_policy_decision):
870         (window_create):
871         (parse_cookies_policy):
872         (elm_main):
873         (has_scheme):
874         (list_item_label_get):
875         (on_popup_menu_hide):
876         (on_window_close):
877         (on_home_button_clicked):
878         Replace locally info() macro with newly introduced
879         one which uses Eina Log module. There is no logic change.
880
881 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
882
883         [EFL] FTL JIT not working on ARM64
884         https://bugs.webkit.org/show_bug.cgi?id=139295
885
886         Reviewed by Michael Saboff.
887
888         Added patches for llvm to add ARM64 support for FTL JIT
889
890         * efl/jhbuild.modules:
891         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
892         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
893
894 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
895
896         Move Said to the committers section.
897
898         * Scripts/webkitpy/common/config/contributors.json:
899
900 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
901
902         Implement Data Detectors immediate actions for WebKit2
903         https://bugs.webkit.org/show_bug.cgi?id=139617
904         <rdar://problem/19198539>
905
906         Reviewed by Beth Dakin.
907
908         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
909         (TestWebKitAPI::TEST):
910         Temporarily disable the action menu tests while the
911         underlying code is in flux.
912
913 2014-12-14  Andreas Kling  <akling@apple.com>
914
915         Replace PassRef with Ref/Ref&& across the board.
916         <https://webkit.org/b/139587>
917
918         Reviewed by Darin Adler.
919
920         * TestWebKitAPI/Tests/WTF/Ref.cpp:
921         (TestWebKitAPI::passWithRef):
922         (TestWebKitAPI::TEST):
923         (TestWebKitAPI::passWithPassRef): Deleted.
924         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
925         (TestWebKitAPI::TEST):
926         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
927         (TestWebKitAPI::TEST):
928         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
929         (TestWebKitAPI::createTestValue):
930
931 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
932
933         [EFL] MiniBrowser's window_create may return NULL
934         https://bugs.webkit.org/show_bug.cgi?id=139585
935
936         Reviewed by Gyuyoung Kim.
937
938         Move NULL checking before using object which window_create
939         returns.
940
941         * MiniBrowser/efl/main.c:
942         (elm_main):
943
944 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
945
946         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
947         https://bugs.webkit.org/show_bug.cgi?id=73030
948
949         Reviewed by Anders Carlsson.
950
951         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
952         database to empty to avoid having it fetch default favicons at random times.
953         DumpRenderTree also disables it, and also it has a way for tests to temporarily
954         enable it.
955
956 2014-12-12  Lucas Forschler  <lforschler@apple.com>
957
958         Update Apple owned build slaves after infrastructure update.
959         
960         Reviewed by Ryosuke Niwa.
961
962         * BuildSlaveSupport/build.webkit.org-config/config.json:
963
964 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
965
966         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
967         https://bugs.webkit.org/show_bug.cgi?id=139537
968
969         Reviewed by Carlos Garcia Campos.
970
971         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
972         of get_dependencies_path().
973         * jhbuild/jhbuildutils.py:
974         (get_dependencies_path): Fix the function to return the new
975         dependencies path: DependenciesPORT.
976         (enter_jhbuild_environment_if_available): Pass the port name
977         when invoking get_dependencies_path().
978
979 2014-12-10  Lucas Forschler  <lforschler@apple.com>
980
981         Update Apple owned build slaves.
982         
983         Rubber-stamped by Dana Burkart.
984         
985         * BuildSlaveSupport/build.webkit.org-config/config.json:
986
987 2014-12-10  Daniel Bates  <dabates@apple.com>
988
989         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
990         timeout instead of test failure
991         https://bugs.webkit.org/show_bug.cgi?id=139525
992
993         Reviewed by Zalan Bujtas.
994
995         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
996         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
997         output.
998
999         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
1000         for the WebThread to spin its run loop before dumping its output. A test that
1001         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
1002         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
1003         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
1004         because run-webkit-tests may terminate a DumpRenderTree.app process when it
1005         exceeds its process time limit (defaults to 35ms) regardless of whether such
1006         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
1007
1008         * Scripts/webkitpy/port/ios.py:
1009         (IOSSimulatorPort.default_timeout_ms):
1010
1011 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1012
1013         [GTK][WK2] Add HTML5 Notifications support
1014         https://bugs.webkit.org/show_bug.cgi?id=61140
1015
1016         Reviewed by Carlos Garcia Campos.
1017
1018         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
1019         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1020         (testWebViewNotification):
1021         (beforeAll):
1022         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
1023         (permissionRequestDialogCallback):
1024         (webViewDecidePermissionRequest):
1025         (geolocationRequestDialogCallback): Deleted.
1026
1027 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
1028
1029         Fix webkitpy test expectation
1030
1031         Not sure what I messed up, but TOTAL_SKIPS was not right.
1032
1033         * Scripts/webkitpy/port/test.py:
1034
1035 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
1036
1037         Remove virtual test support from webkitpy
1038         https://bugs.webkit.org/show_bug.cgi?id=139427
1039
1040         Reviewed by Alexey Proskuryakov.
1041
1042         It seems that the only concrete client of virtual tests is the unit tests :D
1043
1044         This patch tries to clean as much useless code as possible.
1045
1046         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1047         (RunTest.test_tolerance):
1048         (RunTest.test_virtual): Deleted.
1049         * Scripts/webkitpy/layout_tests/views/printing.py:
1050         (Printer._print_test_trace):
1051         * Scripts/webkitpy/port/base.py:
1052         (Port.expected_filename):
1053         (Port.tests):
1054         (Port.test_isfile):
1055         (Port.test_isdir):
1056         (Port.sample_process):
1057         (Port.find_system_pid):
1058         (Port.test_expectations_file_position):
1059         (Port.virtual_test_suites): Deleted.
1060         (Port): Deleted.
1061         (Port.populated_virtual_test_suites): Deleted.
1062         (Port._virtual_tests): Deleted.
1063         (Port.lookup_virtual_test_base): Deleted.
1064         (Port.lookup_virtual_test_args): Deleted.
1065         (VirtualTestSuite): Deleted.
1066         (VirtualTestSuite.__init__): Deleted.
1067         (VirtualTestSuite.__repr__): Deleted.
1068         * Scripts/webkitpy/port/base_unittest.py:
1069         (PortTest.test_test_exists):
1070         (PortTest.test_test_isfile):
1071         (PortTest.test_test_isdir):
1072         (PortTest.test_tests):
1073         * Scripts/webkitpy/port/driver.py:
1074         (DriverProxy.run_test): Deleted.
1075         * Scripts/webkitpy/port/test.py:
1076         (TestPort._skipped_tests_for_unsupported_features):
1077         (TestPort.all_baseline_variants):
1078         (TestPort.virtual_test_suites): Deleted.
1079         * Scripts/webkitpy/tool/commands/queries.py:
1080         (PrintBaselines.__init__):
1081         (PrintBaselines.execute):
1082         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1083         (PrintBaselinesTest.test_basic):
1084         (PrintBaselinesTest.test_multiple):
1085         (PrintBaselinesTest.test_csv):
1086
1087 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
1088
1089         Blink Merge: Remove 'http_lock' code from webkitpy
1090         https://bugs.webkit.org/show_bug.cgi?id=136722
1091
1092         Reviewed by Alexey Proskuryakov.
1093
1094         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
1095         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
1096
1097         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1098         (LayoutTestRunner.__init__):
1099         (LayoutTestRunner.run_tests):
1100         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
1101         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
1102         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1103         (FakePrinter.flush):
1104         (LayoutTestRunnerTests._runner):
1105         (LayoutTestRunnerTests._run_tests):
1106         (LayoutTestRunnerTests.test_servers_started):
1107         (LockCheckingRunner): Deleted.
1108         (LockCheckingRunner.__init__): Deleted.
1109         (LockCheckingRunner.handle_finished_list): Deleted.
1110         (LayoutTestRunnerTests.test_http_locking): Deleted.
1111         * Scripts/webkitpy/port/base.py:
1112         (Port.__init__):
1113         (Port.to.http_server_supports_ipv6):
1114         (Port.to.stop_websocket_server):
1115         (Port.to.acquire_http_lock): Deleted.
1116         (Port.to.release_http_lock): Deleted.
1117         * Scripts/webkitpy/port/http_lock.py: Removed.
1118         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
1119         * Scripts/webkitpy/port/ios.py:
1120         (IOSSimulatorPort.show_results_html_file):
1121         (IOSSimulatorPort.acquire_http_lock): Deleted.
1122         (IOSSimulatorPort): Deleted.
1123         (IOSSimulatorPort.release_http_lock): Deleted.
1124         * Scripts/webkitpy/port/mac.py:
1125         (MacPort.show_results_html_file):
1126         (MacPort): Deleted.
1127         (MacPort.acquire_http_lock): Deleted.
1128         (MacPort.release_http_lock): Deleted.
1129         * Scripts/webkitpy/port/mock_drt.py:
1130         (MockDRTPort.start_websocket_server):
1131         (MockDRTPort.stop_websocket_server):
1132         (MockDRTPort.acquire_http_lock): Deleted.
1133         (MockDRTPort.release_http_lock): Deleted.
1134         * Scripts/webkitpy/port/mock_drt_unittest.py:
1135         (MockDRTPortTest.test_uses_apache):
1136         (MockDRTPortTest.integration_test_http_lock): Deleted.
1137         * Scripts/webkitpy/port/port_testcase.py:
1138         (PortTestCase.assert_servers_are_up):
1139         (PortTestCase.integration_test_http_lock): Deleted.
1140         * Scripts/webkitpy/port/test.py:
1141         (TestPort.start_websocket_server):
1142         (TestPort.stop_websocket_server):
1143         (TestPort.acquire_http_lock): Deleted.
1144         (TestPort.release_http_lock): Deleted.
1145
1146 2014-12-09  Alberto Garcia  <berto@igalia.com>
1147
1148         convertToUTF8String converts null string to empty string
1149         https://bugs.webkit.org/show_bug.cgi?id=133904
1150
1151         Reviewed by Carlos Garcia Campos.
1152
1153         Test that trying to get the value of a non-existent attribute
1154         returns 0 instead of an empty string.
1155
1156         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1157         (WebKitDOMNodeTest::testInsertion):
1158
1159 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1160
1161         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
1162         https://bugs.webkit.org/show_bug.cgi?id=139070
1163
1164         Reviewed by Carlos Garcia Campos.
1165
1166         * gtk/jhbuild.modules:
1167
1168 2014-12-08  Tim Horton  <timothy_horton@apple.com>
1169
1170         Add action menu tests
1171         https://bugs.webkit.org/show_bug.cgi?id=139156
1172
1173         Reviewed by Dean Jackson.
1174
1175         * TestWebKitAPI/PlatformWebView.h:
1176         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1177         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1178         Add a mechanism allowing tests to provide their own WKView subclass.
1179
1180         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1181         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
1182         Add a file with lots of menu targets.
1183
1184         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
1185         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1186         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
1187         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
1188         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
1189
1190         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
1191
1192         (TestWebKitAPI::didFinishLoadForFrameCallback):
1193         (TestWebKitAPI::didFinishDownloadCallback):
1194         (TestWebKitAPI::didCreateDownloadDestinationCallback):
1195         Watch downloads and ensure that they match the content we expect.
1196
1197         (TestWebKitAPI::watchPasteboardForString):
1198         (TestWebKitAPI::watchPasteboardForImage):
1199         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
1200         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
1201         (TestWebKitAPI::javaScriptStringCallback):
1202         (TestWebKitAPI::javaScriptBoolCallback):
1203         (TestWebKitAPI::callJavaScriptReturningString):
1204         (TestWebKitAPI::callJavaScriptReturningBool):
1205         (TestWebKitAPI::watchEditableAreaForString):
1206         (TestWebKitAPI::waitForVideoReady):
1207         (TestWebKitAPI::retrieveSelection):
1208         (TestWebKitAPI::retrieveSelectionInElement):
1209         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
1210         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
1211         Add many helpers for testing, especially to make asynchronous things synchronous.
1212
1213         (TestWebKitAPI::windowPointForTarget):
1214         (TestWebKitAPI::inset8):
1215         Hard-code points in action-menu-targets.html for hit testing.
1216
1217         (TestWebKitAPI::TEST):
1218         Add a suite of tests for WebKit2 action menus.
1219
1220         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
1221         (TestWebKitAPI::createActionContextForPhoneNumber):
1222         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
1223         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
1224         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
1225         (TestWebKitAPI::ActionMenuTest::drawRect):
1226         (TestWebKitAPI::ActionMenuTest::didCreatePage):
1227         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
1228         so that we can test that infrastructure.
1229
1230 2014-12-08  Philippe Normand  <pnormand@igalia.com>
1231
1232         [GTK] UserMedia Permission Request API
1233         https://bugs.webkit.org/show_bug.cgi?id=136449
1234
1235         Reviewed by Carlos Garcia Campos.
1236
1237         The GTK version of the MiniBrowser has gained UserMedia permission
1238         request support.
1239
1240         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
1241         requires user permission to access audio/video devices.
1242         (permissionRequestDialogCallback):
1243         (webViewDecidePermissionRequest):
1244         (geolocationRequestDialogCallback): Deleted.
1245
1246 2014-12-08  Anders Carlsson  <andersca@apple.com>
1247
1248         Add a stubbed out method for clearing out the website data store
1249         https://bugs.webkit.org/show_bug.cgi?id=139404
1250
1251         Reviewed by Antti Koivisto.
1252
1253         Add a debug menu item for testing clearing of website data.
1254
1255         * MiniBrowser/mac/MainMenu.xib:
1256         * MiniBrowser/mac/WK2BrowserWindowController.m:
1257         (-[WK2BrowserWindowController clearWebsiteData:]):
1258
1259 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
1260
1261         Update style checker to deal with "const override"
1262         https://bugs.webkit.org/show_bug.cgi?id=139371
1263
1264         Reviewed by Csaba Osztrogonác.
1265
1266         check-webkit-style shouldn't complain about an open brace to start a
1267         line after a function definition with const override.
1268
1269         * Scripts/webkitpy/style/checkers/cpp.py:
1270         (check_braces):
1271         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1272         (CppStyleTest.test_brace_at_begin_of_line):
1273
1274 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1275
1276         [GTK] Fix GObject DOM bindings API break tests after r176920
1277         https://bugs.webkit.org/show_bug.cgi?id=139368
1278
1279         Reviewed by Gustavo Noronha Silva.
1280
1281         Remove the @version from the symbol name before comparing.
1282
1283         * gtk/check-for-webkitdom-api-breaks:
1284         (read_expected_api):
1285
1286 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1287
1288         Remove the option to automatically update the GObject DOM bindings symbols file
1289         https://bugs.webkit.org/show_bug.cgi?id=139366
1290
1291         Reviewed by Martin Robinson.
1292
1293         It's currently broken, because symbols now need to be in a
1294         specific order. Now that the symbols file only contains stable
1295         API, it's not a problem to manually update it every time new API
1296         is added.
1297
1298         * gtk/check-for-webkitdom-api-breaks:
1299         (read_expected_api):
1300         (check_api):
1301         (write_expected_api): Deleted.
1302
1303 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1304
1305         [GTK] Use GMainLoopSource in WebKitTestRunner
1306         https://bugs.webkit.org/show_bug.cgi?id=138831
1307
1308         Reviewed by Sergio Villar Senin.
1309
1310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1311         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1312         (WTR::TestRunner::platformInitialize):
1313         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1314         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1315         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1316         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1317         (WTR::TestController::notifyDone):
1318         (WTR::TestController::platformRunUntil):
1319         (WTR::cancelTimeout): Deleted.
1320
1321 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1322
1323         [GTK] Missing API detected in GObject DOM bindings after r176630
1324         https://bugs.webkit.org/show_bug.cgi?id=139201
1325
1326         Reviewed by Gustavo Noronha Silva.
1327
1328         Handle deprecated symbols again when generating the GObject DOM
1329         bindings documentation.
1330
1331         * gtk/webkitdom.py:
1332         (WebKitDOMDocGenerator):
1333         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
1334         (WebKitDOMDocGenerator.generate):
1335         (WebKitDOMDocGeneratorSections.__init__):
1336         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
1337         (WebKitDOMDocGeneratorSections.write_section):
1338
1339 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
1340
1341         [EFL][jhbuild] Fix libsoup build with clang
1342         https://bugs.webkit.org/show_bug.cgi?id=139088
1343
1344         Reviewed by Gyuyoung Kim.
1345
1346         * efl/jhbuild.modules:
1347         * efl/patches/soup-clang-warning-fix1.patch: Added.
1348         * efl/patches/soup-clang-warning-fix2.patch: Added.
1349
1350 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
1351
1352         [Mac] DumpRenderTree sets storage directory incorrectly
1353         https://bugs.webkit.org/show_bug.cgi?id=139347
1354
1355         Reviewed by Dan Bernstein.
1356
1357         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1358         Don't use user defaults to pass per-instance paths, as user defaults are shared
1359         across all instances.
1360
1361 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
1362
1363         AX: I cannot activate links on the mobile version of news.google.com
1364         https://bugs.webkit.org/show_bug.cgi?id=139330
1365
1366         Reviewed by Simon Fraser.
1367
1368         Implement press for iOS.
1369
1370         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1371         (AccessibilityUIElement::press):
1372
1373 2014-12-05  Daniel Bates  <dabates@apple.com>
1374
1375         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
1376         https://bugs.webkit.org/show_bug.cgi?id=139326
1377
1378         Reviewed by Anders Carlsson.
1379
1380         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
1381         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
1382         using the same scale factor as used in WebKit.
1383
1384         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1385         (createBitmapContextFromWebView):
1386
1387 2014-12-05  Anders Carlsson  <andersca@apple.com>
1388
1389         REGRESSION (r176677): All tests crash on Windows
1390         https://bugs.webkit.org/show_bug.cgi?id=139321
1391
1392         Reviewed by Alexey Proskuryakov.
1393
1394         * DumpRenderTree/win/DumpRenderTree.cpp:
1395         (runTest):
1396         Don't call CFRelease on the url while we have an outstanding pointer to its string,
1397         and use the right number of bytes when allocating the testURL buffer.
1398
1399 2014-12-05  Daniel Bates  <dabates@apple.com>
1400
1401         [iOS] DumpRenderTree produces many reference test mismatches
1402         https://bugs.webkit.org/show_bug.cgi?id=139314
1403
1404         Reviewed by Simon Fraser.
1405
1406         Fixes an issue where the scale factor used to render the snapshot taken by
1407         DumpRenderTree may differ from the device scale factor. In particular, the
1408         scale factor used to render a snapshot of a test may differ from the scale
1409         factor used to render the snapshot of its expected result.
1410
1411         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
1412         snapshot the UIWebBrowserView. This SPI always render using a scale factor
1413         of one when the backing store for the LegacyTileLayer objects were out-of-
1414         date regardless of the device scale factor. Instead we should use UIImage
1415         and CALayer API to perform the snapshot with respect to the device scale
1416         factor.
1417
1418         Additionally write iOS pixel dump support logic in terms of existing
1419         DumpRenderTree abstractions so as to support generating and comparing
1420         pixel dump checksums as well as make the iOS code more consistent with
1421         the logic used by other ports.
1422
1423         * DumpRenderTree/PixelDumpSupport.cpp:
1424         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
1425         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1426         (BitmapContext::createFromUIImage): Added.
1427         (BitmapContext::pixelData): Added.
1428         (BitmapContext::BitmapContext): Added.
1429         (computeMD5HashStringForBitmapContext): Added.
1430         (dumpBitmap): Added.
1431         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
1432         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
1433
1434 2014-12-05  Anders Carlsson  <andersca@apple.com>
1435
1436         Give all web pages a website data store
1437         https://bugs.webkit.org/show_bug.cgi?id=139317
1438
1439         Reviewed by Tim Horton.
1440
1441         * MiniBrowser/mac/AppDelegate.m:
1442         (-[BrowserAppDelegate newPrivateWindow:]):
1443         Don't release the controller - it's implicitly retained by the window.
1444
1445 2014-12-05  Daniel Bates  <dabates@apple.com>
1446
1447         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
1448         https://bugs.webkit.org/show_bug.cgi?id=137581
1449         <rdar://problem/18642906>
1450
1451         Reviewed by Simon Fraser.
1452
1453         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
1454         of the test that proceeded the currently running test.
1455
1456         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1457         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
1458         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
1459         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
1460
1461 2014-12-05  Jer Noble  <jer.noble@apple.com>
1462
1463         [WTF] MediaTime should support round-tripping from and to doubles.
1464         https://bugs.webkit.org/show_bug.cgi?id=139248
1465
1466         Reviewed by Eric Carlson.
1467
1468         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
1469         the MediaTimes after this change.
1470
1471         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1472         (WTF::operator<<):
1473         (TestWebKitAPI::TEST):
1474         * lldb/lldb_webkit.py:
1475         (WTFMediaTime_SummaryProvider):
1476         (WTFMediaTimeProvider.timeValueAsDouble):
1477         (WTFMediaTimeProvider.isIndefinite):
1478         (WTFMediaTimeProvider):
1479         (WTFMediaTimeProvider.hasDoubleValue):
1480
1481 2014-12-05  Anders Carlsson  <andersca@apple.com>
1482
1483         Add a private browsing mode to MiniBrowser
1484         https://bugs.webkit.org/show_bug.cgi?id=139308
1485
1486         Reviewed by Sam Weinig.
1487
1488         * MiniBrowser/mac/AppDelegate.m:
1489         (defaultConfiguration):
1490         (-[BrowserAppDelegate newWindow:]):
1491         (-[BrowserAppDelegate newPrivateWindow:]):
1492         * MiniBrowser/mac/MainMenu.xib:
1493         * MiniBrowser/mac/WK2BrowserWindowController.h:
1494         * MiniBrowser/mac/WK2BrowserWindowController.m:
1495         (-[WK2BrowserWindowController awakeFromNib]):
1496         (-[WK2BrowserWindowController initWithConfiguration:]):
1497         (-[WK2BrowserWindowController dealloc]):
1498         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1499
1500 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1501
1502         Run http tests parallel
1503         https://bugs.webkit.org/show_bug.cgi?id=138958
1504
1505         Reviewed by Daniel Bates.
1506
1507         Remove the concept of "locked shard". Now http tests are just like any other tests.
1508         We start HTTP and WebSocket servers at the start if we need them, and terminate them
1509         when done with all the tests (not when the last http test runs, which is unnecessarily
1510         unpredictable).
1511
1512         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
1513         patch, they used to take over 15 minutes.
1514
1515         As part of the fix, we no longer pass the number of servers to Apache. I don't
1516         think that these parameters did what we wanted them to do; Apache handles the load
1517         just fine without them.
1518
1519         The change applies to all platforms. I fixed everything I could find on Mac, and
1520         Ossy told me that he's been running http tests in parallel for a long time. If
1521         there is increased instability for some ports, it will need to be fixed - there is
1522         generally nothing special about http tests at this point, and most code is
1523         cross-platform in WebKit2.
1524
1525         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1526         (LayoutTestRunner.__init__):
1527         (LayoutTestRunner.run_tests):
1528         (LayoutTestRunner.start_servers_with_lock):
1529         (LayoutTestRunner._handle_started_test):
1530         (Worker.handle):
1531         (Sharder.__init__):
1532         (Sharder.shard_tests):
1533         (Sharder._shard_every_file):
1534         (Sharder._shard_by_directory):
1535         (LayoutTestRunner._handle_finished_test_list): Deleted.
1536         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
1537         (Sharder._shard_in_two): Deleted.
1538         (Sharder): Deleted.
1539         (Sharder._resize_shards): Deleted.
1540         (Sharder._resize_shards.divide_and_round_up): Deleted.
1541         (Sharder._resize_shards.extract_and_flatten): Deleted.
1542         (Sharder._resize_shards.split_at): Deleted.
1543         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1544         (FakePrinter.print_workers_and_shards):
1545         (LayoutTestRunnerTests.test_servers_started.start_http_server):
1546         (LayoutTestRunnerTests.test_servers_started):
1547         (SharderTests.get_shards):
1548         (SharderTests.test_shard_by_dir):
1549         (SharderTests.test_shard_every_file):
1550         (SharderTests): Deleted.
1551         (SharderTests.test_shard_in_two): Deleted.
1552         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
1553         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
1554         (SharderTests.test_multiple_locked_shards): Deleted.
1555         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1556         (ManagerTest.test_needs_servers.get_manager):
1557         (ManagerTest.integration_test_needs_servers.get_manager):
1558         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1559         (ManagerTest):
1560         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1561         (_set_up_derived_options):
1562         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1563         (RunTest.test_batch_size):
1564         (RunTest.test_max_locked_shards): Deleted.
1565         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1566         (LayoutTestApacheHttpd.__init__):
1567         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
1568         (TestLayoutTestApacheHttpd.test_start_cmd):
1569         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1570         (Lighttpd.__init__):
1571         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1572         (HttpServerBase.__init__):
1573         * Scripts/webkitpy/layout_tests/views/printing.py:
1574         (Printer.print_workers_and_shards):
1575         * Scripts/webkitpy/port/base.py:
1576         (Port.default_child_processes):
1577         (Port.to.start_http_server):
1578         (Port.default_max_locked_shards): Deleted.
1579         * Scripts/webkitpy/port/port_testcase.py:
1580         (PortTestCase.make_port):
1581         (PortTestCase.test_default_max_locked_shards): Deleted.
1582         * Scripts/webkitpy/port/test.py:
1583         (TestPort.start_http_server):
1584
1585 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
1586
1587         Don't lock perf tests in run-webkit-tests
1588         https://bugs.webkit.org/show_bug.cgi?id=139264
1589
1590         Reviewed by Daniel Bates.
1591
1592         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1593         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1594         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1595         * Scripts/webkitpy/layout_tests/models/test_input.py:
1596         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1597
1598 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
1599
1600         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
1601         https://bugs.webkit.org/show_bug.cgi?id=139243
1602
1603         Reviewed by Anders Carlsson.
1604
1605         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
1606         chance to allow untrusted certificates.
1607
1608         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
1609         Set up more client objects for secondary windows. We may be able to share some of the
1610         code with main view creation function, but it's not exactly the same (notably, we
1611         do not focus a secondary window when it's done loading).
1612
1613 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
1614
1615         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
1616         https://bugs.webkit.org/show_bug.cgi?id=139071
1617
1618         Reviewed by Chris Fleizach.
1619
1620         Add string value for ATK_ROLE_STATIC in roleToString.
1621
1622         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1623
1624 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
1625
1626         check-webkit-style is confused by ternary expression inside first member initializer
1627         https://bugs.webkit.org/show_bug.cgi?id=136442
1628
1629         Reviewed by Csaba Osztrogonác.
1630
1631         * Scripts/webkitpy/style/checkers/cpp.py:
1632         (check_member_initialization_list):
1633
1634 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1635
1636         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
1637         https://bugs.webkit.org/show_bug.cgi?id=139220
1638
1639         Reviewed by Philippe Normand.
1640
1641         * gtk/jhbuild.modules:
1642         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
1643
1644 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1645
1646         Remove unused JSC runtime options
1647         https://bugs.webkit.org/show_bug.cgi?id=133070
1648
1649         Reviewed by Csaba Osztrogonác.
1650
1651         * Scripts/run-jsc-stress-tests:
1652
1653 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1654
1655         [EFL] Add subtle crypto to the build system
1656         https://bugs.webkit.org/show_bug.cgi?id=138612
1657
1658         Reviewed by Csaba Osztrogonác.
1659
1660         * Scripts/webkitperl/FeatureList.pm:
1661
1662 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
1663
1664         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
1665         https://bugs.webkit.org/show_bug.cgi?id=139005
1666
1667         Reviewed by Chris Fleizach.
1668
1669         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1670         Add mapping for ATK_ROLE_CAPTION to roleToString
1671
1672 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1673
1674         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
1675         https://bugs.webkit.org/show_bug.cgi?id=139149
1676
1677         Reviewed by Anders Carlsson.
1678
1679         WebKit2 already cleared application caches between runs (although it wasn't entirely
1680         effective without WebCore changes in this patch).
1681
1682         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
1683
1684         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
1685         function is not implemented on Windows, see below).
1686
1687         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
1688         Ameded a FIXME.
1689
1690 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
1691
1692         Generalize PageActivityAssertionToken
1693         https://bugs.webkit.org/show_bug.cgi?id=139106
1694
1695         Reviewed by Sam Weinig.
1696
1697         Add an API test for WTF::RefCounter.
1698
1699         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1700         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
1701         (TestWebKitAPI::TEST):
1702             - added RefCounter test.
1703
1704 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
1705
1706         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
1707         https://bugs.webkit.org/show_bug.cgi?id=139174
1708
1709         Reviewed by Simon Fraser.
1710
1711         * DumpRenderTree/TestRunner.cpp:
1712         * DumpRenderTree/TestRunner.h:
1713         Renamed testPathOrURL to testURL, because this variable always contains a URL.
1714
1715         * DumpRenderTree/mac/DumpRenderTree.mm:
1716         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
1717         (testPathFromURL): Moved from FrameLoadDelegate.mm.
1718         (runTest): Set crash reporter information here, as we know the exact test URL.
1719
1720         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1721         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
1722         reporter information here.
1723
1724         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1725         * DumpRenderTree/mac/TestRunnerMac.mm:
1726         Updated for testPathOrURL renaming.
1727
1728         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1729         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
1730         test URL until load starts, so save it into TestRunner now. A new TestRunner object
1731         is created for each test.
1732
1733         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1734         (WTR::TestRunner::testURL):
1735         (WTR::TestRunner::setTestURL):
1736         Make TestRunner know the test name. For now, it's good enough to have it once load
1737         starts, but if we ever need it earlier, we can send it with BeginTest message.
1738
1739         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1740         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1741         Use test URL, not currently loading URL for CrashReporter.
1742
1743         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
1744         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
1745         (WebKit1 already had it right).
1746
1747         * DumpRenderTree/win/DumpRenderTree.cpp:
1748         (sizeWebViewForCurrentTest):
1749         (runTest):
1750         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1751         (ResourceLoadDelegate::willSendRequest):
1752         Changed Windows DumpRenderTree to also use URL in TestRunner.
1753
1754 2014-12-02  Daniel Bates  <dabates@apple.com>
1755
1756         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
1757         https://bugs.webkit.org/show_bug.cgi?id=139143
1758
1759         Reviewed by David Kilzer.
1760
1761         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
1762         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
1763         crashes. Run-webkit-tests will record as crashing the test associated with the
1764         DumpRenderTree instance that wrote that string.
1765
1766         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
1767         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
1768         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
1769         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
1770         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
1771         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
1772         about a crash.
1773
1774         Additionally, update the crash message format written to standard error when LayoutTestRelay
1775         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
1776         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
1777         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
1778         when they crash in their test machinery logic/UI process code.
1779
1780         * DumpRenderTree/mac/DumpRenderTree.mm:
1781         (writeCrashedMessageOnFatalError): Added.
1782         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
1783         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
1784         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1785         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
1786         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
1787         the crash logs for WebKitTestRunner/DumpRenderTree.app.
1788         * Scripts/webkitpy/port/driver.py:
1789         (Driver.__init__): Update comment.
1790         (Driver._check_for_driver_crash): Ditto.
1791         * Scripts/webkitpy/port/ios.py:
1792         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
1793         regular expression. This constant is used as an optimization to avoid compiling the same
1794         regular expression across invocations of _get_crash_log().
1795         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
1796         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
1797         closer to where they are used.
1798
1799 2014-12-01  Anders Carlsson  <andersca@apple.com>
1800
1801         Remove WKBundleRemoveAllVisitedLinks
1802         https://bugs.webkit.org/show_bug.cgi?id=139163
1803
1804         Reviewed by Sam Weinig.
1805
1806         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
1807
1808         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1809         (WTR::InjectedBundle::beginTesting):
1810         * WebKitTestRunner/TestInvocation.cpp:
1811         (WTR::TestInvocation::invoke):
1812
1813 2014-12-02  Anders Carlsson  <andersca@apple.com>
1814
1815         Fix Windows build.
1816
1817         * DumpRenderTree/win/DumpRenderTree.cpp:
1818         (setAlwaysAcceptCookies):
1819
1820 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1821
1822         [EFL] Remove edbus dependency from jhbuild
1823         https://bugs.webkit.org/show_bug.cgi?id=139130
1824
1825         Reviewed by Gyuyoung Kim.
1826
1827         After http://trac.webkit.org/changeset/176555 we
1828         don't need it anymore.
1829
1830         * efl/jhbuild.modules:
1831
1832 2014-12-02  Philippe Normand  <pnormand@igalia.com>
1833
1834         [jhbuild] wrong Dependencies path
1835         https://bugs.webkit.org/show_bug.cgi?id=139176
1836
1837         Reviewed by Martin Robinson.
1838
1839         * Scripts/webkitpy/port/base.py:
1840         (Port._should_use_jhbuild):
1841
1842 2014-12-02  Philippe Normand  <pnormand@igalia.com>
1843
1844         [GStreamer] Bump internal jhbuild versions to 1.4.4
1845         https://bugs.webkit.org/show_bug.cgi?id=138866
1846
1847         Reviewed by Carlos Garcia Campos.
1848
1849         * gtk/jhbuild.modules:
1850         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1851         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1852         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1853
1854 2014-12-01  Commit Queue  <commit-queue@webkit.org>
1855
1856         Unreviewed, rolling out r176566.
1857         https://bugs.webkit.org/show_bug.cgi?id=139124
1858
1859         It broke the GTK performance tests. (Requested by clopez on
1860         #webkit).
1861
1862         Reverted changeset:
1863
1864         "[GTK] Use GMainLoopSource in WebKitTestRunner"
1865         https://bugs.webkit.org/show_bug.cgi?id=138831
1866         http://trac.webkit.org/changeset/176566
1867
1868 2014-11-29  Anders Carlsson  <andersca@apple.com>
1869
1870         Crash when calling WKPageClose on the originated page from within createNewPage callback
1871         https://bugs.webkit.org/show_bug.cgi?id=139099
1872         <rdar://problem/19052564>
1873
1874         Reviewed by Sam Weinig.
1875
1876         Add a test.
1877
1878         * TestWebKitAPI/PlatformWebView.h:
1879         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1880         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
1881         (TestWebKitAPI::runJavaScriptAlert):
1882         (TestWebKitAPI::createNewPage):
1883         (TestWebKitAPI::TEST):
1884         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
1885         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1886         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1887
1888 2014-11-28  Commit Queue  <commit-queue@webkit.org>
1889
1890         Unreviewed, rolling out r176564.
1891         https://bugs.webkit.org/show_bug.cgi?id=139093
1892
1893         massive failures on release test bot (Requested by philn on
1894         #webkit).
1895
1896         Reverted changeset:
1897
1898         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
1899         https://bugs.webkit.org/show_bug.cgi?id=138866
1900         http://trac.webkit.org/changeset/176564
1901
1902 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1903
1904         [GTK] Use GMainLoopSource in WebKitTestRunner
1905         https://bugs.webkit.org/show_bug.cgi?id=138831
1906
1907         Reviewed by Sergio Villar Senin.
1908
1909         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1910         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1911         (WTR::TestRunner::platformInitialize):
1912         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1913         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1914         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
1915         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1916         (WTR::TestController::notifyDone):
1917         (WTR::TestController::platformRunUntil):
1918         (WTR::cancelTimeout): Deleted.
1919
1920 2014-11-24  Philippe Normand  <pnormand@igalia.com>
1921
1922         [GStreamer] Bump internal jhbuild versions to 1.4.4
1923         https://bugs.webkit.org/show_bug.cgi?id=138866
1924
1925         Reviewed by Carlos Garcia Campos.
1926
1927         * gtk/jhbuild.modules:
1928         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
1929         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
1930         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
1931
1932 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1933
1934         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
1935         https://bugs.webkit.org/show_bug.cgi?id=138834
1936
1937         Reviewed by Sergio Villar Senin.
1938
1939         It makes everyting simpler and the tests run faster too, since we
1940         don't need to spawn the private bus and wait until the DBus name
1941         is registered. The web extension registers a new JavaSCript class
1942         with a status method to run the tests, similar to the DBus
1943         method. In the UI process side, tests use webkit_web_view_run_java_script()
1944         instead of sending a DBus message.
1945
1946         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1947         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1948         (WebKitDOMNodeFilterTest::create):
1949         (WebKitDOMNodeFilterTest::testTreeWalker):
1950         (WebKitDOMNodeFilterTest::testNodeIterator):
1951         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
1952         (WebKitDOMNodeFilterTest::runTest): Deleted.
1953         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1954         (WebKitDOMNodeTest::create):
1955         (WebKitDOMNodeTest::testHierarchyNavigation):
1956         (WebKitDOMNodeTest::testInsertion):
1957         (WebKitDOMNodeTest::testTagNames):
1958         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
1959         (WebKitDOMNodeTest::runTest): Deleted.
1960         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1961         (WebKitDOMXPathNSResolverTest::create):
1962         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1963         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1964         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
1965         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
1966         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1967         (WebKitFrameTest::create):
1968         (WebKitFrameTest::testMainFrame):
1969         (WebKitFrameTest::testURI):
1970         (WebKitFrameTest::testJavaScriptContext):
1971         (WebKitFrameTest::webPageFromArgs): Deleted.
1972         (WebKitFrameTest::runTest): Deleted.
1973         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1974         (testWebKitDOMNodeHierarchyNavigation):
1975         (testWebKitDOMNodeInsertion):
1976         (testWebKitDOMNodeTagNames):
1977         (beforeAll):
1978         (afterAll):
1979         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
1980         (runTest):
1981         (beforeAll):
1982         (afterAll):
1983         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
1984         (testWebKitDOMXPathNSResolverNative):
1985         (testWebKitDOMXPathNSResolverCustom):
1986         (beforeAll):
1987         (afterAll):
1988         (runTest): Deleted.
1989         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
1990         (webkitFrameTestRun):
1991         (beforeAll):
1992         (afterAll):
1993         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1994         (testsMap):
1995         (WebProcessTest::add):
1996         (WebProcessTest::create):
1997         (runTest):
1998         (windowObjectClearedCallback):
1999         (webkit_web_extension_initialize):
2000         (methodCallCallback): Deleted.
2001         (webkit_web_extension_initialize_with_user_data): Deleted.
2002         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
2003         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
2004         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
2005         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2006         (WebViewTest::runWebProcessTest):
2007         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2008
2009 2014-11-28  Csaba Osztrogonác  <ossy@webkit.org>
2010
2011         [EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
2012         https://bugs.webkit.org/show_bug.cgi?id=139086
2013
2014         Reviewed by Gyuyoung Kim.
2015
2016         * efl/jhbuild.modules:
2017         * efl/patches/libseccomp-pick-up-CC.patch: Added.
2018
2019 2014-11-28  Bartlomiej Gajda  <b.gajda@samsung.com>
2020
2021         [EFL] Add warning if CMake version is too old for building with ninja.
2022         https://bugs.webkit.org/show_bug.cgi?id=139055
2023
2024         Reviewed by Gyuyoung Kim.
2025
2026         CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
2027         that version in their repositories.
2028
2029         * efl/install-dependencies:
2030
2031 2014-11-28  Andrzej Badowski  <a.badowski@samsung.com>
2032
2033         [ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
2034         https://bugs.webkit.org/show_bug.cgi?id=139044
2035
2036         Reviewed by Chris Fleizach.
2037
2038         ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
2039         The proposed solution will enable the use of this method for the object table.
2040         Existing test shows the result.
2041
2042         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2043         (WTR::AccessibilityUIElement::columnHeaders):
2044
2045 2014-11-27  Ryuan Choi  <ryuan.choi@navercorp.com>
2046
2047         [EFL] Remove E_Dbus dependency
2048         https://bugs.webkit.org/show_bug.cgi?id=136355
2049
2050         Reviewed by Gyuyoung Kim.
2051
2052         * MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
2053
2054 2014-11-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2055
2056         [EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
2057         https://bugs.webkit.org/show_bug.cgi?id=139047
2058
2059         Reviewed by Carlos Garcia Campos.
2060
2061         * efl/jhbuild.modules:
2062         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
2063         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
2064         * gtk/jhbuild-optional.modules:
2065         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
2066         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
2067
2068 2014-11-25  Tanay C  <tanay.c@samsung.com>
2069
2070         [GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
2071         https://bugs.webkit.org/show_bug.cgi?id=138090
2072
2073         Reviewed by Carlos Garcia Campos.
2074
2075         * MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll
2076         (browserWindowZoomIn): Added.
2077         (browserWindowZoomOut): Added.
2078         (scrollEventCallback): Added.
2079         (zoomInCallback): Modified.
2080         (zoomOutCallback): Modified.
2081         (browserWindowConstructed): Modified.
2082
2083 2014-11-25  Csaba Osztrogonác  <ossy@webkit.org>
2084
2085         [EFL] REGRESSION(r176514): It made performance tests fail
2086         https://bugs.webkit.org/show_bug.cgi?id=139037
2087
2088         Reviewed by Gyuyoung Kim.
2089
2090         * Scripts/webkitpy/port/efl.py:
2091         (EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.
2092         * efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so
2093         only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.
2094
2095 2014-11-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2096
2097         [GTK] update-webkitgtk-libs fails to build fontconfig
2098         https://bugs.webkit.org/show_bug.cgi?id=139032
2099
2100         Reviewed by Martin Robinson.
2101
2102         On Fedora, if docbook-utils is installed but docbook-utils-pdf is not,
2103         fontconfig will try to generate documentation and fail.
2104
2105         * gtk/install-dependencies:
2106
2107 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2108
2109         Unreviewed. Fix GTK+ make distcheck.
2110
2111         * gtk/manifest.txt: Remove deleted files.
2112
2113 2014-11-24  Krzysztof Czech  <k.czech@samsung.com>
2114
2115         [EFL] Utilize Eail library to support accessibility in EFL
2116         https://bugs.webkit.org/show_bug.cgi?id=137742
2117
2118         Reviewed by Gyuyoung Kim.
2119
2120         Eail, atk-bridge, at-spi2 are not mandatory modules for webkit-efl. They are rather optional.
2121
2122         * efl/jhbuild-optional.modules: Added.
2123         * efl/jhbuild.modules:
2124
2125 2014-11-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2126
2127         [GTK] WebKitWebView is created with the wrong web context when using webkit_web_view_new_with_related_view()
2128         https://bugs.webkit.org/show_bug.cgi?id=139023
2129
2130         Reviewed by Sergio Villar Senin.
2131
2132         Rename WebKitWebView/default-context as WebKitWebView/web-context
2133         and check we are always using the right context for new web views.
2134
2135         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2136         (testWebViewWebContext):
2137         (beforeAll):
2138         (testWebViewDefaultContext): Deleted.
2139
2140 2014-11-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2141
2142         [GTK] Add API to override the default local storage directory
2143         https://bugs.webkit.org/show_bug.cgi?id=138828
2144
2145         Reviewed by Gustavo Noronha Silva.
2146
2147         Add test to check that the local storage directory is created at
2148         the path given on construction.
2149
2150         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2151         (testWebContextConfiguration):
2152         (beforeAll):
2153         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2154         (Test::Test):
2155         (Test::~Test): Deleted.
2156
2157 2014-11-21  Zalan Bujtas  <zalan@apple.com>
2158
2159         Simple line layout: Add "show simple line layout debug borders" setting to MiniBrowser.
2160         https://bugs.webkit.org/show_bug.cgi?id=138981
2161
2162         Reviewed by Simon Fraser.
2163
2164         * MiniBrowser/mac/SettingsController.h:
2165         * MiniBrowser/mac/SettingsController.m:
2166         (-[SettingsController _populateMenu]):
2167         (-[SettingsController validateMenuItem:]):
2168         (-[SettingsController toggleSimpleLineLayoutDebugBordersEnabled:]):
2169         (-[SettingsController simpleLineLayoutDebugBordersEnabled]):
2170         * MiniBrowser/mac/WK1BrowserWindowController.m:
2171         (-[WK1BrowserWindowController didChangeSettings]):
2172         * MiniBrowser/mac/WK2BrowserWindowController.m:
2173         (-[WK2BrowserWindowController didChangeSettings]):
2174
2175 2014-11-21  Csaba Osztrogonác  <ossy@webkit.org>
2176
2177         Remove http lock code from webkitperl
2178         https://bugs.webkit.org/show_bug.cgi?id=138959
2179
2180         Reviewed by Alexey Proskuryakov.
2181
2182         * Scripts/webkitperl/httpd.pm:
2183         (cleanUp):
2184         (extractLockNumber): Deleted.
2185         (getLockFiles): Deleted.
2186         (getNextAvailableLockNumber): Deleted.
2187         (getLockNumberForCurrentRunning): Deleted.
2188         (waitForHTTPDLock): Deleted.
2189         (scheduleHttpTesting): Deleted.
2190         (getWaitTime): Deleted.
2191
2192 2014-11-20  Hunseop Jeong  <hs85.jeong@samsung.com>
2193
2194         [EFL] The option value of fixed layout is false in MiniBrowser
2195         https://bugs.webkit.org/show_bug.cgi?id=138830
2196
2197         Reviewed by Gyuyoung Kim.
2198
2199         Changed the option value of fixed layout to EINA_TRUE in MiniBrowser.
2200
2201         * MiniBrowser/efl/main.c:
2202
2203 2014-11-20  Adrian Perez de Castro  <aperez@igalia.com>
2204
2205         [GTK] Provide convenience API in DOM bindings to post messages to user message handlers
2206         https://bugs.webkit.org/show_bug.cgi?id=138871
2207
2208         Reviewed by Carlos Garcia Campos.
2209
2210         Add a test case for the convenience API for posting user messages
2211         added to the DOM bindings.
2212
2213         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2214         (testUserContentManagerMessageFromConvenienceDOMBindings):
2215         (beforeAll):
2216         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2217         (documentLoadedCallback):
2218
2219 2014-11-19  Dana Burkart  <dburkart@apple.com>
2220
2221         Work around the fact that different masters may have different names for their codebases.
2222         https://bugs.webkit.org/show_bug.cgi?id=138878
2223
2224         Reviewed by Mark Rowe.
2225
2226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2227         (parseRevisionProperty): Changed.
2228         Take a "fallback key" in addition to the primary key, so we can deal with inconsistencies in
2229         opensource / internal codebase naming convention.
2230
2231 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2232
2233         AX: Screen braille input doesn't work on forms.
2234         https://bugs.webkit.org/show_bug.cgi?id=138804
2235
2236         Unreviewed build fix.
2237
2238         * DumpRenderTree/AccessibilityUIElement.cpp:
2239         (AccessibilityUIElement::setValue):
2240
2241 2014-11-19  Chris Fleizach  <cfleizach@apple.com>
2242
2243         AX: Screen braille input doesn't work on forms.
2244         https://bugs.webkit.org/show_bug.cgi?id=138804
2245
2246         Reviewed by Mario Sanchez Prada.
2247
2248         Add a method to setValue through the AX API in DRT.
2249
2250         * DumpRenderTree/AccessibilityUIElement.cpp:
2251         (setValueCallback):
2252         (AccessibilityUIElement::getJSClass):
2253         * DumpRenderTree/AccessibilityUIElement.h:
2254         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2255         (AccessibilityUIElement::setValue):
2256         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2257         (AccessibilityUIElement::setValue):
2258
2259 2014-11-18  Csaba Osztrogonác  <ossy@webkit.org>
2260
2261         Remove the WinCairo buildbot
2262         https://bugs.webkit.org/show_bug.cgi?id=138805
2263
2264         Reviewed by Alex Christensen.
2265
2266         * BuildSlaveSupport/build.webkit.org-config/config.json:
2267         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2268         (appendCustomBuildFlags):
2269         * BuildSlaveSupport/test-result-archive:
2270         (archiveTestResults):
2271
2272 2014-11-18  Daniel Bates  <dabates@apple.com>
2273
2274         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2275         SPI are not available in public SDK
2276         https://bugs.webkit.org/show_bug.cgi?id=138802
2277
2278         Reviewed by David Kilzer.
2279
2280         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2281
2282         * DumpRenderTree/mac/CheckedMalloc.cpp:
2283
2284 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2285
2286         Unreviewed. Fix after /webkit2/WebKitWebView/default-context r176256.
2287
2288         Forgot to fix this test before landing.
2289
2290         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2291         (testWebViewDefaultContext):
2292
2293 2014-11-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2294
2295         [GTK] Add API to create a WebKitWebContext
2296         https://bugs.webkit.org/show_bug.cgi?id=138826
2297
2298         Reviewed by Gustavo Noronha Silva.
2299
2300         Use a different WebKitWebContext for every test to ensure test
2301         cases are independent to each other. Tests using DBus to
2302         communicate with the injected bundle extension now use a unique
2303         name for the well known DBus name.
2304
2305         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2306         (beforeAll): Remove comment about the order of the tests and
2307         move the success test before the failed one now that tests don't
2308         depend on each others.
2309         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2310         (beforeAll): Remove call to set the web extensions directory,
2311         since this is now done for all test in the Test constructor.
2312         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2313         (beforeAll): Do not create a temporary directory, a temporary data
2314         directory is now created for all tests.
2315         (afterAll):
2316         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
2317         (testWebKitDOMNodeHierarchyNavigation): Pass the web extension ID
2318         to the web process test runner.
2319         (testWebKitDOMNodeInsertion): Ditto.
2320         (testWebKitDOMNodeTagNames): Ditto.
2321         (beforeAll): Remove call to set the web extensions directory.
2322         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
2323         (runTest): Pass the web extension ID to the web process test runner.
2324         (beforeAll): Remove call to set the web extensions directory.
2325         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
2326         (runTest): Pass the web extension ID to the web process test runner.
2327         (beforeAll): Remove call to set the web extensions directory.
2328         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2329         (createFileAtDestination): Use Test::dataDirectory() as base dir
2330         for temporary files.
2331         (beforeAll): Do not create a temporary directory.
2332         (afterAll):
2333         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
2334         (webkitFrameTestRun): Pass the web extension ID to the web process
2335         test runner.
2336         (beforeAll): Remove call to set the web extensions directory.
2337         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
2338         (beforeAll): Remove call to set the web extensions directory.
2339         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
2340         (testProcessPerWebView): Use local member instead of global variable.
2341         (testMultiprocessWebViewCreateReadyClose): Ditto.
2342         (beforeAll): Do not connect to initialize-web-extensions, Test now
2343         connects to the signal for all tests and calls a virtual method
2344         that test can override.
2345         (afterAll):
2346         (initializeWebExtensions): Deleted.
2347         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2348         (testPrintOperationPrint): Use Test::dataDirectory() as base dir
2349         for temporary files.
2350         (beforeAll): Do not create a temporary directory.
2351         (afterAll):
2352         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
2353         (beforeAll): Remove call to set the web extensions directory.
2354         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
2355         (beforeAll): Remove comment about the tests order.
2356         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2357         (testWebExtensionGetTitle): Build the DBus service name using the
2358         web extension ID.
2359         (testDocumentLoadedSignal): Ditto.
2360         (testWebKitWebViewProcessCrashed): Ditto.
2361         (testWebExtensionIsolatedWorld): Ditto.
2362         (beforeAll): Remove initialization-user-data test, since now all
2363         tests are passing user data to the web extension.
2364         (testWebExtensionInitializationUserData): Deleted.
2365         (initializeWebExtensions): Deleted.
2366         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2367         (testSetDirectory): Use the web context member inherited from Test.
2368         (testClearDatabase): Ditto.
2369         (testGetFaviconURI): Ditto.
2370         (beforeAll): Do not create a temporary directory.
2371         (afterAll):
2372         (webkitFaviconDatabaseFinalizedCallback): Deleted.
2373         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2374         (UserContentManagerTest::UserContentManagerTest):
2375         (beforeAll): Remove call to set the web extensions directory.
2376         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2377         (testWebContextDefault): Check also that a newly create web
2378         context is not the default web context.
2379         (testWebContextSpellChecker): Use the web context member inherited
2380         from Test.
2381         (testWebContextLanguages): Ditto.
2382         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2383         (methodCallCallback): Remove GetInitializationUserData method.
2384         (webkit_web_extension_initialize_with_user_data): Always create
2385         the DBus name using the user data provided.
2386         (makeBusName): Deleted.
2387         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2388         (webkit_web_extension_initialize_with_user_data): Create the DBus
2389         name using the user data provided.
2390         (webkit_web_extension_initialize): Deleted.
2391         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
2392         (Test::dataDirectory): Return the temporary data directory.
2393         (removeNonEmptyDirectory): Also remove directories recursively.
2394         (main): Remove the disk cache directory initialization, since this
2395         is now done in the Test constructor.
2396         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2397         (Test::initializeWebExtensionsCallback): Call the virtual method
2398         initializeWebExtensions()
2399         (Test::Test): Create a new WebKitWebContext and initialize it.
2400         (Test::~Test): Disconnect initialize-web-extensions signal.
2401         (Test::initializeWebExtensions): Set the web extensions directory
2402         and user data.
2403         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
2404         (WebProcessTestRunner::~WebProcessTestRunner): Use nullptr.
2405         (WebProcessTestRunner::runTest): Build the DBus proxy using a
2406         unique name created with the Test web extension ID.
2407         (WebProcessTestRunner::proxy): Deleted.
2408         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h:
2409         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2410         (WebViewTest::WebViewTest): Create the web view with the Test web
2411         context.
2412         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h: Add optional user
2413         content manager parameter to the constructor.
2414
2415 2014-11-18  ChangSeok Oh  <changseok.oh@collabora.com>
2416
2417         [GTK] Mesa build fails over llvm-3.5
2418         https://bugs.webkit.org/show_bug.cgi?id=138825
2419
2420         Reviewed by Gustavo Noronha Silva.
2421
2422         OwningPtr.h have been removed in llvm-3.5. Instread we should use std::unique_ptr for mesa build.
2423
2424         * gtk/jhbuild.modules:
2425         * gtk/patches/mesa-gallivm-Fix-build-after-LLVM-commit-211259.patch: Added.
2426
2427 2014-11-17  Daniel Bates  <dabates@apple.com>
2428
2429         Unreviewed, rolling out r176232.
2430
2431         Broke the Mac build. Will investigate offline.
2432
2433         Reverted changeset:
2434
2435         "[iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions,
2436         MobileGestalt"
2437         https://bugs.webkit.org/show_bug.cgi?id=138802
2438         http://trac.webkit.org/changeset/176232
2439
2440 2014-11-17  Daniel Bates  <dabates@apple.com>
2441
2442         [iOS] Libdispatch, Dyld, IOKit, Mach, NSPointerFunctions, MobileGestalt
2443         SPI are not available in public SDK
2444         https://bugs.webkit.org/show_bug.cgi?id=138802
2445
2446         Reviewed by David Kilzer.
2447
2448         Include header MachVMSPI.h instead of including the private header mach/mach_vm.h.
2449
2450         * DumpRenderTree/mac/CheckedMalloc.cpp:
2451
2452 2014-11-17  Jake Nielsen  <jacob_nielsen@apple.com>
2453
2454         Having 30+ flaky failures breaks EWS
2455         https://bugs.webkit.org/show_bug.cgi?id=138743
2456
2457         Reviewed by Alexey Proskuryakov.
2458
2459         Adds tests to ensure that the problem has been solved.
2460         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2461         (test_first_failure_limit):
2462         (test_first_failure_limit_with_some_tree_redness):
2463         (test_second_failure_limit):
2464         (test_tree_failure_limit_with_patch_that_potentially_fixes_some_redness):
2465         (test_first_and_second_failure_limit):
2466         (test_first_and_clean_failure_limit):
2467         (test_first_second_and_clean_failure_limit):
2468         (test_very_red_tree_retry): Deleted.
2469         Really this was renamed to test_first_second_and_clean_failure_limit.
2470         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2471         Makes the appropriate changes to PatchAnalysisTask to make sure that
2472         even when the first test run hits the failure limit, it will still try
2473         a second run.
2474         (PatchAnalysisTask._results_failed_different_tests):
2475         (PatchAnalysisTask._test_patch):
2476         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try): Deleted.
2477
2478 2014-11-17  Ting-Wei Lan  <lantw44@gmail.com>
2479
2480         [GTK] Add library search paths from LDFLAGS before pkg-config --libs
2481         https://bugs.webkit.org/show_bug.cgi?id=136018
2482
2483         Reviewed by Carlos Garcia Campos.
2484
2485         It is possible that the order of -L arguments in the output of
2486         pkg-config is wrong, which causes the linker to find the wrong
2487         version (usually older version) of libraries when running
2488         gtkdoc-scangobj.
2489
2490         * gtk/gtkdoc.py:
2491         (GTKDoc._run_gtkdoc_scangobj):
2492
2493 2014-11-17  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2494
2495         Bump EFL version to 1.12.0
2496         https://bugs.webkit.org/show_bug.cgi?id=138733
2497
2498         Reviewed by Gyuyoung Kim.
2499
2500         * efl/jhbuild.modules:
2501
2502 2014-11-16  Joanmarie Diggs  <jdiggs@igalia.com>
2503
2504         AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
2505         https://bugs.webkit.org/show_bug.cgi?id=138771
2506
2507         Reviewed by Chris Fleizach.
2508
2509         Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
2510
2511         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2512
2513 2014-11-15  Joanmarie Diggs  <jdiggs@igalia.com>
2514
2515         AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
2516         https://bugs.webkit.org/show_bug.cgi?id=138767
2517
2518         Reviewed by Chris Fleizach.
2519
2520         Add mappings for ATK_ROLE_AUDIO and ATK_ROLE_VIDEO to roleToString().
2521
2522         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2523
2524 2014-11-14  Alexey Proskuryakov  <ap@apple.com>
2525
2526         Add shortcut macros to Mac TestExpectations
2527         https://bugs.webkit.org/show_bug.cgi?id=138729
2528
2529         Reviewed by Simon Fraser.
2530
2531         * Scripts/webkitpy/port/mac.py: (MacPort.configuration_specifier_macros):
2532         Add version macros for current OS versions.
2533
2534 2014-11-13  Alexey Proskuryakov  <ap@apple.com>
2535
2536         https://bugs.webkit.org/show_bug.cgi?id=138628
2537         A patch that doesn't apply is stuck in commit queue
2538
2539         Rubber-stamped by David Kilzer.
2540
2541         This also hopefully fixes other issues:
2542         - a patch that has cq+ flag set by a non-committer kills commit queue;
2543         - EWS never reports failing tests, and keeps spinning instead.
2544
2545         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2546         (Bugzilla.set_flag_on_attachment):
2547         (Bugzilla.obsolete_attachment):
2548         Apply the fix from r174797 to more places.
2549
2550 2014-11-13  Dan Bernstein  <mitz@apple.com>
2551
2552         Policy client not called for navigations through the page cache
2553         https://bugs.webkit.org/show_bug.cgi?id=138703
2554
2555         Reviewed by Alexey Proskuryakov.
2556
2557         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2558         (-[DecidePolicyForPageCacheNavigationDelegate webView:didFinishNavigation:]):
2559         (-[DecidePolicyForPageCacheNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2560
2561 2014-11-13  Joanmarie Diggs  <jdiggs@igalia.com>
2562
2563         AX: [ATK] Do not return ATK_ROLE_UNKNOWN for null or otherwise invalid accessible objects
2564         https://bugs.webkit.org/show_bug.cgi?id=137867
2565
2566         Reviewed by Chris Fleizach.
2567
2568         Add ATK_ROLE_INVALID to roleToString. Remove the null AtkRole check in
2569         AccessibilityUIElement::role: ATK_ROLE_INVALID = 0, and we need to be
2570         able to test for the presence of ATK_ROLE_INVALID.
2571
2572         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2573         (WTR::AccessibilityUIElement::role):
2574
2575 2014-11-13  Juergen Ributzka  <juergen@apple.com>
2576
2577         Update the "combineModules" script to handel more LLVM metadata.
2578         https://bugs.webkit.org/show_bug.cgi?id=138514
2579
2580         Reviewed by Filip Pizlo.
2581
2582         * ReducedFTL/combineModules.rb:
2583
2584 2014-11-13  Myles C. Maxfield  <mmaxfield@apple.com>
2585
2586         Allow constructing a base PassRef with a derived Ref
2587         https://bugs.webkit.org/show_bug.cgi?id=138701
2588
2589         Reviewed by Andreas Kling
2590
2591         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2592         (TestWebKitAPI::passWithPassRef):
2593         (TestWebKitAPI::passWithPassRefPtr):
2594         (TestWebKitAPI::TEST):
2595
2596 2014-11-05  Ada Chan  <adachan@apple.com>
2597
2598         Implement new plug-in API for muting plug-ins
2599         https://bugs.webkit.org/show_bug.cgi?id=138105
2600
2601         Reviewed by Anders Carlsson.
2602
2603         Add a new plug-in test for the mute API.
2604
2605         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2606         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SetMuted.cpp: Added.
2607         (SetMuted::SetMuted):
2608         (SetMuted::isMuted):
2609         (SetMuted::cachedIsMuted):
2610         (SetMuted::ScriptableObject::hasProperty):
2611         (SetMuted::ScriptableObject::getProperty):
2612         (SetMuted::ScriptableObject::pluginTest):
2613         (SetMuted::NPP_New):
2614         (SetMuted::NPP_GetValue):
2615         (SetMuted::NPP_SetValue):
2616
2617 2014-11-12  Philippe Normand  <pnormand@igalia.com>
2618
2619         Unreviewed, GTK gardening.
2620
2621         * Scripts/run-gtk-tests:
2622         (TestRunner): Skip the UserMediaBasic test because it depends on
2623         constraints validation which is going to be fixed in bug #136449.
2624
2625 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2626
2627         [GTK] Expose user script messages to GObject DOM bindings
2628         https://bugs.webkit.org/show_bug.cgi?id=138411
2629
2630         Reviewed by Philippe Normand.
2631
2632         Add a test case to check that user script messages sent using the
2633         DOM bindings API are also received in the UI process.
2634
2635         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
2636         (UserScriptMessageTest::waitUntilMessageReceived):
2637         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2638         (testUserContentManagerScriptMessageFromDOMBindings):
2639         (beforeAll):
2640         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2641         (documentLoadedCallback):
2642
2643 2014-11-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2644
2645         Unreviewed. Fix GTK+ clean build after r175930.
2646
2647         Partial rollout of r175930 to not build the new unit test that
2648         broke clean builds in GTK+ port.
2649
2650         * TestWebKitAPI/PlatformGTK.cmake:
2651
2652 2014-09-01  Philippe Normand  <pnormand@igalia.com>
2653
2654         [WK2] UserMediaClient support
2655         https://bugs.webkit.org/show_bug.cgi?id=123158
2656
2657         Reviewed by Benjamin Poulain.
2658
2659         Simple API test for the UserMedia permission request API. The
2660         required test infrastructure is also added, inspired by the
2661         Geolocation infrastructure.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: New API test for UserMedia
2664         Permission request.
2665         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp: Added.
2666         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack):
2667         (TestWebKitAPI::TEST):
2668         * TestWebKitAPI/Tests/WebKit2/getUserMedia.html: Added.
2669         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new
2670         helper method to set the permission request result without user interaction.
2671         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
2672         (WTR::InjectedBundle::setUserMediaPermission):
2673         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Ditto.
2674         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
2675         (WTR::TestRunner::setUserMediaPermission):
2676         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
2677         * WebKitTestRunner/TestController.cpp:
2678         (WTR::decidePolicyForUserMediaPermissionRequest): Permission
2679         request handler.
2680         (WTR::TestController::createOtherPage): Enable the new UserMedia
2681         permission request handler.
2682         (WTR::TestController::createWebViewWithOptions): Ditto.
2683         (WTR::TestController::resetPreferencesToConsistentValues): Enable
2684         MediaStream support, this is needed for getUserMedia.
2685         (WTR::TestController::resetStateToConsistentValues): clear
2686         UserMedia permissions list and flags.
2687         (WTR::TestController::setUserMediaPermission): Set permission
2688         request result and distpatch it.
2689         (WTR::TestController::handleUserMediaPermissionRequest): Save
2690         request and dispatch it.
2691         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
2692         Dispatch cached permission requests.
2693         * WebKitTestRunner/TestController.h:
2694         * WebKitTestRunner/TestInvocation.cpp:
2695         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2696
2697 2014-11-11  David Kilzer  <ddkilzer@apple.com>
2698
2699         webkit-patch --suggest-reviewers is broken with newer versions of git
2700         <http://webkit.org/b/138627>
2701
2702         Reviewed by Michael Saboff with feedback from Daniel Bates.
2703
2704         * Scripts/webkitpy/common/checkout/scm/git.py:
2705         (Git._changes_files_for_commit): Strip blank lines instead of
2706         assuming there is always a blank line at the beginning of the
2707         list.
2708
2709 2014-11-11  Alexey Proskuryakov  <ap@apple.com>
2710
2711         DRT and WKTR touch disk cache
2712         https://bugs.webkit.org/show_bug.cgi?id=138622
2713
2714         Reviewed by Geoffrey Garen.
2715
2716         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
2717         Set a shared cache before calling -_switchNetworkLoaderToNewTestingSession, not after,
2718         because this function uses the shared cache.
2719
2720         * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitializeContext):
2721         Create an empty shared cache to prevent a default one from being created on disk.
2722
2723 2014-10-07  Sergio Villar Senin  <svillar@igalia.com>
2724
2725         [CSS Grid Layout] Limit the size of explicit/implicit grid
2726         https://bugs.webkit.org/show_bug.cgi?id=136217
2727
2728         Reviewed by Andreas Kling.
2729
2730         Added a new unit test for the CSS parser. Right now it only checks
2731         that we properly clamp the maximum number of tracks on a grid to a
2732         maximum of 1 million.
2733
2734         * TestWebKitAPI/CMakeLists.txt:
2735         * TestWebKitAPI/PlatformEfl.cmake:
2736         * TestWebKitAPI/PlatformGTK.cmake:
2737         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2738         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp: Added.
2739         (TestWebKitAPI::computeNumberOfTracks): Helper function.
2740         (TestWebKitAPI::TEST): Added a
2741         CSSPropertyParserTest.GridTrackLimits test case.
2742
2743 2014-11-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2744
2745         webkitpy test fix after r175867
2746         https://bugs.webkit.org/show_bug.cgi?id=138607
2747
2748         Reviewed by Philippe Normand.
2749
2750         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2751         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2752
2753 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2754
2755         webkitpy: demangle C++ symbols from crash log stderr
2756         https://bugs.webkit.org/show_bug.cgi?id=138565
2757
2758         Reviewed by Alexey Proskuryakov.
2759
2760         * Scripts/webkitpy/port/linux_get_crash_log.py:
2761         (GDBCrashLogGenerator.generate_crash_log): Process stderr output
2762         with c++filt.
2763
2764 2014-11-10  Philippe Normand  <pnormand@igalia.com>
2765
2766         [GTK] fix up the GDB backtrace report tool
2767         https://bugs.webkit.org/show_bug.cgi?id=138564
2768
2769         Reviewed by Carlos Garcia Campos.
2770
2771         * Scripts/webkitpy/port/gtk.py:
2772         (GtkPort._get_crash_log): Match the process name reported by the
2773         driver with the GTK port WebProcess executable filename.
2774         * Scripts/webkitpy/port/linux_get_crash_log.py:
2775         (GDBCrashLogGenerator._get_gdb_output): Invoke gdb for the crashed
2776         program.
2777         (GDBCrashLogGenerator.generate_crash_log): Use %E in the core
2778         pattern to workaround the 16 characters size limit of %e.
2779
2780 2014-11-10  Conrad Shultz  <conrad_shultz@apple.com>
2781
2782         Unreviewed, moved myself to the list of committers.
2783
2784         * Scripts/webkitpy/common/config/contributors.json:
2785
2786 2014-11-10  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2787
2788         [EFL] Fix the test font path after r175555.
2789
2790         Reviewed by Csaba Osztrogonác.
2791
2792         * WebKitTestRunner/PlatformEfl.cmake: Dependencies -> DependenciesEFL
2793
2794 2014-11-10  Akos Kiss  <akiss@inf.u-szeged.hu>
2795
2796         Fix the exception fuzz helper to generate targets in the correct range
2797         https://bugs.webkit.org/show_bug.cgi?id=138544
2798
2799         Reviewed by Filip Pizlo.
2800
2801         Currently, the script generates exception fuzz targets in the range of
2802         0..($checkCount-1). However, target 0 is never hit, while target 1 is
2803         always outside of the outermost try block of the tests, which therefore
2804         prints unexpected output and results in false failures when fired at.
2805         Additionally, target $checkCount is never generated.
2806
2807         This patch fixes the script to generate targets in the range of
2808         2..$checkCount.
2809
2810         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
2811
2812 2014-11-09  Csaba Osztrogonác  <ossy@webkit.org>
2813
2814         make-passwords-json.py should generarate everything needed for testing
2815         https://bugs.webkit.org/show_bug.cgi?id=138503
2816
2817         Reviewed by Ryosuke Niwa.
2818
2819         * BuildSlaveSupport/build.webkit.org-config/make_passwords_json.py:
2820         Renamed from make-passwords-json.py to be able included from mastercfg_unittest.py.
2821         Additionally generate auth.json, credentials.cfg and committers.cfg too.
2822         (create_mock_slave_passwords_dict): Moved from mastercfg_unittest.py
2823         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2824         (BuildBotConfigLoader._mock_open): Use make_passwords_json.create_mock_slave_passwords_dict() to avoid duplication.
2825         (BuildBotConfigLoader._create_mock_passwords_dict): Deleted.
2826
2827 2014-11-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2828
2829         [GTK] generate-gtkdoc should ignore invalid files
2830         https://bugs.webkit.org/show_bug.cgi?id=138542
2831
2832         Reviewed by Darin Adler.
2833
2834         * gtk/generate-gtkdoc:
2835         (files_to_ignore.file_should_be_ignored): Return True to ignore
2836         invalid files.
2837
2838 2014-11-08  Alexey Proskuryakov  <ap@apple.com>
2839
2840         Delete cookies between tests
2841         https://bugs.webkit.org/show_bug.cgi?id=138528
2842
2843         Reviewed by Sam Weinig.
2844
2845         * DumpRenderTree/mac/DumpRenderTree.mm:
2846         (resetWebPreferencesToConsistentValues):
2847         * WebKitTestRunner/TestController.cpp:
2848         (WTR::TestController::resetPreferencesToConsistentValues):
2849         Do it.
2850
2851         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2852         (WTR::InjectedBundle::beginTesting):
2853         Added a FIXME.
2854
2855 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2856
2857         [GTK] Run layout tests using the network process
2858         https://bugs.webkit.org/show_bug.cgi?id=138428
2859
2860         Reviewed by Martin Robinson.
2861
2862         Shared secondary process is the default in the GTK+ port, but we
2863         should run the tests using the network process to ensure
2864         everything works with the network process. In the future, the
2865         shared secondary process model might be a special case of multiple
2866         processes with 1 as maximum number of processes, but always using
2867         the network process.
2868
2869         * WebKitTestRunner/TestController.cpp:
2870         (WTR::TestController::initialize):
2871
2872 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2873
2874         [GTK] Allow to create a view with a related page in WTR
2875         https://bugs.webkit.org/show_bug.cgi?id=138501
2876
2877         Reviewed by Martin Robinson.
2878
2879         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
2880         (TestWebKitAPI::PlatformWebView::PlatformWebView): Pass nullptr as
2881         related page to WKViewCreate.
2882         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2883         (WTR::PlatformWebView::PlatformWebView): Pass the given related
2884         page to WKViewCreate.
2885
2886 2014-11-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2887
2888         WTR crashes after running a test when NetworkProcess enabled
2889         https://bugs.webkit.org/show_bug.cgi?id=138500
2890
2891         Reviewed by Alexey Proskuryakov.
2892
2893         WebNotificationProvider destructor is calling
2894         WKNotificationManagerSetProvider, but m_notificationManager is
2895         null because removeNotificationManager was already called.
2896
2897         * WebKitTestRunner/WebNotificationProvider.cpp:
2898         (WTR::WebNotificationProvider::~WebNotificationProvider): Check
2899         m_notificationManager is not null before calling WKNotificationManagerSetProvider.
2900
2901 2014-11-06  Jake Nielsen  <jacob_nielsen@apple.com>
2902
2903         Remove duplicate code from PatchAnalysisTask._test_patch and fix bug
2904         regarding incorrect call to PatchAnalysisTask.report_failure
2905         https://bugs.webkit.org/show_bug.cgi?id=138229
2906
2907         Reviewed by Daniel Bates.
2908
2909         * Scripts/webkitpy/common/net/layouttestresults.py:
2910         Makes sure test_results returns a list.
2911         (LayoutTestResults.test_results):
2912         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2913         Makes unit tests also check to make sure
2914         task.results_from_patch_test_run() and
2915         task.results_from_test_run_without_patch return instances of
2916         LayoutTestResults.
2917         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
2918         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2919         Condenses duplicate code into _should_defer_patch_or_throw, and
2920         removes the now-unused _clean_tree_results member.
2921         (PatchAnalysisTask.__init__):
2922         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
2923         (PatchAnalysisTask._should_defer_patch_or_throw):
2924         (PatchAnalysisTask._test_patch):
2925         (PatchAnalysisTask.results_from_patch_test_run):
2926         (PatchAnalysisTask.results_from_test_run_without_patch): Deleted.
2927         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2928         Removes needless call to results_from_test_run_without_patch
2929         (AbstractEarlyWarningSystem._failing_tests_message):
2930         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2931         Changes order of test failure messages to be in the order that they
2932         appear.
2933         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2934         * Scripts/webkitpy/tool/commands/queues.py:
2935         Removes needless call to results_from_test_run_without_patch.
2936         (CommitQueue._failing_tests_message):
2937         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2938         (MockCommitQueueTask.results_from_test_run_without_patch): Deleted.
2939
2940 2014-11-06  Ryuan Choi  <ryuan.choi@navercorp.com>
2941
2942         Unreviewed. Reorder my e-mail addresses in contributors.json
2943
2944         * Scripts/webkitpy/common/config/contributors.json:
2945
2946 2014-11-06  Matthew Hanson  <matthew_hanson@apple.com>
2947
2948         Remove code that prepends a leading 'r' to the first argument of _run_git_svn_find_rev
2949         https://bugs.webkit.org/show_bug.cgi?id=138475
2950
2951         Reviewed by Ryosuke Niwa.
2952
2953         The change in https://trac.webkit.org/175603 introduced broke compatibility with svn_revision_from_git_commit.
2954         This patch reverts the part of that change that broke compatibility. In addition, this patch adds a comment to
2955         explain that SVN revisions require a leading 'r', moves an existing comment to a more appropriate location and
2956         renames the positional argument to better reflect that it can represent either an SVN revision or a Git tree-ish.
2957
2958         * Scripts/webkitpy/common/checkout/scm/git.py:
2959         (Git._run_git_svn_find_rev):
2960         Add comment mentioning that svn_revisions need to begin with 'r'.
2961         Move comment (explaining that git svn find-rev exits with code 0 when no match is found) to a more appropriate location.
2962         Rename the argument 'revision' to 'revision_or_treeish' to reflect the dual form that argument can take.
2963         Remove code that coerced the revision/treeish into a string and prepended an 'r'.
2964
2965 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2966
2967         [GTK] Add context menu API to Web Process Extensions
2968         https://bugs.webkit.org/show_bug.cgi?id=138311
2969
2970         Reviewed by Gustavo Noronha Silva.
2971
2972         Add tests cases for WebKitWebPage::context-menu signal.
2973
2974         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
2975         (testContextMenuWebExtensionMenu):
2976         (testContextMenuWebExtensionNode):
2977         (beforeAll):
2978         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2979         (serializeContextMenu):
2980         (serializeNode):
2981         (contextMenuCallback):
2982         (pageCreatedCallback):
2983
2984 2014-11-06  Commit Queue  <commit-queue@webkit.org>
2985
2986         Unreviewed, rolling out r175690.
2987         https://bugs.webkit.org/show_bug.cgi?id=138460
2988
2989         We are not ready to run layout tests using the network process
2990         yet (Requested by KaL on #webkit).
2991
2992         Reverted changeset:
2993
2994         "[GTK] Run layout tests using the network process"
2995         https://bugs.webkit.org/show_bug.cgi?id=138428
2996         http://trac.webkit.org/changeset/175690
2997
2998 2014-11-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2999
3000         [GTK] Run layout tests using the network process
3001         https://bugs.webkit.org/show_bug.cgi?id=138428
3002
3003         Reviewed by Martin Robinson.
3004
3005         Shared secondary process is the default in the GTK+ port, but we
3006         should run the tests using the network process to ensure
3007         everything works with the network process. In the future, the
3008         shared secondary process model might be a special case of multiple
3009         processes with 1 as maximum number of processes, but always using
3010         the network process.
3011
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::TestController::initialize):
3014
3015 2014-11-05  Dan Bernstein  <mitz@apple.com>
3016
3017         Remove the unused deletion UI feature
3018         https://bugs.webkit.org/show_bug.cgi?id=138442
3019
3020         Rubber-stamped by Alexey Proskuryakov.
3021
3022         * DumpRenderTree/mac/EditingDelegate.mm:
3023         (-[EditingDelegate webView:shouldShowDeleteInterfaceForElement:]): Deleted implementation of
3024         delegate method that’s been removed.
3025
3026 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
3027
3028         fast/dom/remove-body-during-body-replacement2.html fails on WK2
3029         https://bugs.webkit.org/show_bug.cgi?id=138334
3030
3031         Reviewed by Anders Carlsson.
3032
3033         Reset focus to main frame between tests. DumpRenderTree does this via -makeFirstResponder
3034         calls, which works because each frame is an NSView in WK1. WK2 makes equivalent
3035         -makeFirstResponder calls, which may or may not be needed for other reasons, but
3036         it also needs to reset internal focus explicitly.
3037
3038         It's not clear if this is the right long-term fix or a workaround for a WebKit bug.
3039         WebKit behavior appears wrong, but it matches Firefox.
3040
3041         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3042         (WTR::InjectedBundlePage::resetAfterTest):
3043
3044 2014-11-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3045
3046         [GTK] Add WebKitWebResource::failed-with-tls-errors signal
3047         https://bugs.webkit.org/show_bug.cgi?id=137862
3048
3049         Reviewed by Gustavo Noronha Silva.
3050
3051         Add a test case to check that WebKitWebResource::failed-with-tls-errors
3052         is emitted when a subresource load fails due to TLS errors.
3053
3054         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3055         (TLSSubresourceTest::resourceLoadStartedCallback):
3056         (TLSSubresourceTest::TLSSubresourceTest):
3057         (TLSSubresourceTest::subresourceFailedCallback):
3058         (TLSSubresourceTest::subresourceFailedWithTLSErrorsCallback):
3059         (TLSSubresourceTest::subresourceLoadStarted):
3060         (TLSSubresourceTest::subresourceFailedWithTLSErrors):
3061         (TLSSubresourceTest::waitUntilSubresourceLoadFail):
3062         (testSubresourceLoadFailedWithTLSErrors):
3063         (httpsServerCallback):
3064         (httpServerCallback):
3065         (beforeAll):
3066
3067 2014-11-05  Alexey Proskuryakov  <ap@apple.com>
3068
3069         Build fix for some compiler versions.
3070
3071         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: (TestWebKitAPI::TEST): Compiler was
3072         unhappy because this is a getter, and these shouldn't have side effects.
3073
3074 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3075
3076         Add a method for performing cherrypick-merges.
3077         https://bugs.webkit.org/show_bug.cgi?id=138375
3078
3079         Reviewed by Ryosuke Niwa.
3080
3081         Adds support for cherrypick-merges.
3082
3083         * Scripts/webkitpy/common/checkout/scm/git.py:
3084         (Git.cherrypick_merge): Added.
3085
3086 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3087
3088         Add a way to ascertain the SVN URL associated with a Git branch.
3089         https://bugs.webkit.org/show_bug.cgi?id=138374
3090
3091         Reviewed by Ryosuke Niwa.
3092
3093         The svn_url method returns the SVN URL associated with the current Git branch.
3094
3095         * Scripts/webkitpy/common/checkout/scm/git.py:
3096         (Git.svn_url): Added.
3097
3098 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3099
3100         Add the ability to search for modifications that are staged for commit.
3101         https://bugs.webkit.org/show_bug.cgi?id=138373
3102
3103         Reviewed by Ryosuke Niwa and Daniel Bates.
3104
3105         This makes is easy to do identify files that require merge post-processing,
3106         in addition to stand-alone utility.
3107
3108         * Scripts/webkitpy/common/checkout/scm/git.py:
3109         (Git.modifications_staged_for_commit): Added.
3110
3111 2014-11-04  Matthew Hanson  <matthew_hanson@apple.com>
3112
3113         Add a branch keyword argument to _run_git_svn_find_rev.
3114         https://bugs.webkit.org/show_bug.cgi?id=138372
3115
3116         Reviewed by Ryosuke Niwa.
3117
3118         The addition of this keyword argument allows clients to determine the Git hash
3119         of commits made on an SVN branch, provided that branch has been fetched locally.
3120
3121         * Scripts/webkitpy/common/checkout/scm/git.py:
3122         (Git._run_git_svn_find_rev):
3123         Add a branch keyword argument that is added to the end of the command, if present.
3124
3125 2014-11-04  Chris Dumez  <cdumez@apple.com>
3126
3127         Add ptr() method to Ref class
3128         https://bugs.webkit.org/show_bug.cgi?id=138361
3129
3130         Reviewed by Darin Adler.
3131
3132         Use the new Ref::ptr() method.
3133
3134         * TestWebKitAPI/Tests/WTF/Ref.cpp:
3135         (TestWebKitAPI::TEST):
3136
3137 2014-11-04  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3138
3139         [jhbuild] Make it possible to build GTK/EFL in same repository
3140         https://bugs.webkit.org/show_bug.cgi?id=137448
3141
3142         Reviewed by Martin Robinson.
3143
3144         * Scripts/webkitdirs.pm:
3145         (getJhbuildPath):
3146         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp:
3147         (getPlatformFontsPath):
3148         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3149         (WTR::getFontsPath):
3150         * jhbuild/jhbuild-wrapper:
3151         (determine_platform):
3152         (install_jhbuild):
3153         * jhbuild/jhbuildrc_common.py:
3154         (init):
3155
3156 2014-11-04  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
3157
3158         [EFL] Bump LLVM to version 3.5.0
3159         https://bugs.webkit.org/show_bug.cgi?id=138312
3160
3161         Reviewed by Csaba Osztrogonác.
3162
3163         * efl/jhbuild.modules:
3164         * efl/patches/llvm-elf-add-stackmaps.patch: Added.
3165         * efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Added.
3166
3167 2014-11-03  Simon Fraser  <simon.fraser@apple.com>
3168
3169         Add page overlays that show regions with mouseWheel event handlers, and the non-fast-scrollable region, and code to toggle them in MiniBrowser WK2
3170         https://bugs.webkit.org/show_bug.cgi?id=138257
3171
3172         Reviewed by Tim Horton.
3173         
3174         Add a "Debug Overlays" submenu item under "WebKit2-only Settings" which allows
3175         the user to toggle region page overlays on and off. Two overlays are available,
3176         for the non-fast scrollable region, and the region of element with wheel
3177         event handlers.
3178
3179         * MiniBrowser/mac/SettingsController.h:
3180         * MiniBrowser/mac/SettingsController.m:
3181         (-[SettingsController _populateMenu]):
3182         (-[SettingsController validateMenuItem:]):
3183         (-[SettingsController nonFastScrollableRegionOverlayVisible]):
3184         (-[SettingsController wheelEventHandlerRegionOverlayVisible]):
3185         (-[SettingsController preferenceKeyForRegionOverlayTag:]):
3186         (-[SettingsController toggleDebugOverlay:]):
3187         (-[SettingsController debugOverlayVisible:]):
3188         * MiniBrowser/mac/WK2BrowserWindowController.m:
3189         (-[WK2BrowserWindowController didChangeSettings]):
3190
3191 2014-11-03  Alexey Proskuryakov  <ap@apple.com>
3192
3193         REGRESSION (Subpixel layout): Bubbles don't fit in Bugzilla review page
3194         https://bugs.webkit.org/show_bug.cgi?id=138323
3195
3196         Reviewed by Zalan Bujtas.
3197
3198         * QueueStatusServer/templates/statusbubble.html: Round the sizes up, not down.
3199
3200 2014-11-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3201
3202         [ninja] Don't remove response files for verbose builds
3203         https://bugs.webkit.org/show_bug.cgi?id=137816
3204
3205         Reviewed by Csaba Osztrogonác.
3206
3207         * Scripts/webkitdirs.pm:
3208         (determineNinjaVersion):
3209         (buildCMakeGeneratedProject):
3210
3211 2014-11-02  Akos Kiss  <akiss@inf.u-szeged.hu>
3212
3213         [GTK] Fix the build of FTL JIT
3214         https://bugs.webkit.org/show_bug.cgi?id=138298
3215
3216         Reviewed by Carlos Garcia Campos.
3217
3218         * gtk/jhbuild-optional.modules:
3219         Bump up LLVM version to 3.5.0 release and apply patches.
3220         * gtk/patches/llvm-elf-add-stackmaps.patch:
3221         Added. Adds .llvm_stackmaps section to ELF files. Backported from LLVM
3222         trunk.
3223         * gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch:
3224         Added. Ensures that PC-relative relocations in EH frames are not
3225         truncated to 32 bits on x86_64.
3226
3227 2014-10-31  Michael Saboff  <msaboff@apple.com>
3228
3229         No way to specify target os or architecture when using the --no-copy option with run-jsc-stress-tests
3230         https://bugs.webkit.org/show_bug.cgi?id=138268
3231
3232         Reviewed by Andreas Kling.
3233
3234         Added a --arch and --os option to set or override the values that are
3235         normally computed based on examining the JavaScriptCore we want to test.
3236
3237         * Scripts/run-jsc-stress-tests:
3238
3239 2014-10-31  Dan Bernstein  <mitz@apple.com>
3240
3241         llvmForJSC build emits a linker warning that it can't find usr/local/LLVMForJavaScriptCore/lib under the build directory
3242         https://bugs.webkit.org/show_bug.cgi?id=138259
3243
3244         Reviewed by Geoff Garen.
3245
3246         * Scripts/copy-webkitlibraries-to-product-directory: Create this directory even if it’s
3247         going to be empty to silence the warning.
3248
3249 2014-10-31  Adrian Perez de Castro  <aperez@igalia.com>
3250
3251         [GTK] Support script message handlers WebKitUserContentManager
3252         https://bugs.webkit.org/show_bug.cgi?id=133730
3253
3254         Reviewed by Carlos Garcia Campos.
3255
3256         Support user script message handlers in WebKitUserContentManager.
3257         This needs building with ENABLE_USER_MESSAGE_HANDLERS, for which
3258         an option is added to the CMake build files. The option is disabled
3259         globally by default, and the WebKitGTK port enables it. On the API
3260         level, two new methods to register and unregister names are provided
3261         in the "window.webkit" namespace, and on message reception the
3262         "WebKitUserContentManager::script-message-received" signal is
3263         emitted, using the registered names as signal detail.
3264
3265         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3266         Add test case for user script message handlers.
3267         (scriptMessageReceived):
3268         (testUserContentManagerScriptMessageReceived):
3269         (beforeAll):
3270
3271 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3272
3273         bisect-builds should support WebKit clients other than Safari
3274         https://bugs.webkit.org/show_bug.cgi?id=138225
3275
3276         This patch adds support for bisecting WebKit nightly builds with clients other than Safari.
3277
3278         The -a / --application optional argument allows the user to specify which application (or application bundle)
3279         should be run against the WebKit nightly builds.
3280
3281         Reviewed by David Kilzer.
3282
3283         * Scripts/bisect-builds:
3284         Swap out $safariPath for the more general $applicationPath
3285         Leave --safari-path as a commandline option for backwards compatibility
3286         (mountAndRunNightly):
3287         Use File::Spec->cat correctly (one directory per argument)
3288         Use open --wait-apps instead of running the target application directly
3289
3290 2014-10-30  Dana Burkart  <dburkart@apple.com>
3291
3292         <rdar://problem/18821260> Perpare for the mysterious future
3293
3294         Reviewed by Lucas Forschler.
3295
3296         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3297         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3298         * LayoutTestRelay/Configurations/Base.xcconfig:
3299         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3300         * MiniBrowser/Configurations/Base.xcconfig:
3301         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3302         * TestWebKitAPI/Configurations/Base.xcconfig:
3303         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3304         * WebKitLauncher/Configurations/Base.xcconfig:
3305         * WebKitTestRunner/Configurations/Base.xcconfig:
3306         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3307
3308 2014-10-30  Matthew Hanson  <matthew_hanson@apple.com>
3309
3310         Update safariVersion to safariVersionString
3311         https://bugs.webkit.org/show_bug.cgi?id=138193
3312
3313         The preceding change updated safariVersion to safariVersionString for the "4 Public Beta" check in OS X 10.5.x,
3314         but it should have also been done for the "4 Public Beta" check in OS X 10.4.x.
3315
3316         Rubber-stamped by David Kilzer.
3317
3318         * Scripts/bisect-builds:
3319         (makeNightlyList):
3320         Compare safariVersionString to a string literal, instead of safariVersion.
3321
3322 2014-10-30  Rohit Kumar  <kumar.rohit@samsung.com>
3323
3324         [GTK] Minibrowser : Add window fullscreen support for Minibrowser
3325         https://bugs.webkit.org/show_bug.cgi?id=137775
3326
3327         Reviewed by Carlos Garcia Campos.
3328
3329         * MiniBrowser/gtk/BrowserWindow.c:
3330         (toggleFullScreen): Callback to toggle window fullscreen on pressing F11 key.
3331         (browser_window_init):
3332
3333 2014-10-29  Jake Nielsen  <jacob_nielsen@apple.com>
3334
3335         CommitQueue and EWS should reject any patches that result in consistent test
3336         failures that aren't present on the tree.
3337         https://bugs.webkit.org/show_bug.cgi?id=138184
3338
3339         Reviewed by Alexey Proskuryakov.
3340
3341         * Scripts/webkitpy/layout_tests/models/test_results.py:
3342         Adds a simple hashing function to allow for set operations to handle
3343         TestResult objects properly.
3344         (TestResult.__hash__):
3345         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3346         Adds one unit test, and modifies others to agree with the notion that
3347         patches that introduce new test failures (but also have flakyness)
3348         should be rejected rather than spin.
3349         (MockCommitQueue.report_flaky_tests):
3350         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3351         (test_double_flaky_test_failure):
3352         (test_two_flaky_tests):
3353         (test_very_flaky_patch):
3354         (test_very_flaky_patch_with_some_tree_redness):
3355         (test_different_test_failures):
3356         (test_different_test_failures_with_some_tree_redness):
3357         (test_different_test_failures_with_some_tree_redness_and_some_fixes):
3358         (test_mildly_flaky_patch):
3359         (test_mildly_flaky_patch_with_some_tree_redness):
3360         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3361         Makes PatchAnalysisTask reject said patches.
3362         (PatchAnalysisTask._test_patch):
3363
3364 2014-10-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3365
3366         WinCairoRequirements.zip cannot be downloaded from dropbox
3367         https://bugs.webkit.org/show_bug.cgi?id=138113
3368
3369         Reviewed by Alexey Proskuryakov.
3370
3371         * Scripts/update-webkit-dependency: Removing --sslv3 option from curl
3372
3373 2014-10-29  Matthew Hanson  <matthew_hanson@apple.com>
3374
3375         bisect-builds should filter out nightlies that predate the introduction of an OS X operating system
3376         https://bugs.webkit.org/show_bug.cgi?id=138193
3377
3378         This patch restricts the set of nightles to bisect to only those nightlies that ship with frameworks
3379         for the target OS (only support for OS X Yosemite, Mavericks and Mountain Lion was added.)
3380
3381         It also does a bit of refactoring, including distinguishing between versions and version strings and
3382         saving versions to local variables instead of using eval in each conditional.
3383
3384         Reviewed by David Kilzer.
3385
3386         * Scripts/bisect-builds:
3387         (makeNightlyList):
3388         Restrict the set of nightlies to r174650 and above when running Yosemite.
3389         Restrict the set of nightlies to r157846 and above when running Mavericks.
3390         Restrict the set of nightlies to r122421 and above when running Mountain Lion.
3391
3392 2014-10-29  Csaba Osztrogonác  <ossy@webkit.org>
3393
3394         [EFL] build-webkit should try harder to avoid re-running cmake
3395         https://bugs.webkit.org/show_bug.cgi?id=137949
3396
3397         Reviewed by Martin Robinson.
3398
3399         * Scripts/webkitdirs.pm:
3400         (shouldRemoveCMakeCache): Don't remove CMakeCache unconditionally for EFL.
3401         (generateBuildSystemFromCMakeProject): Comment fix after r174681.
3402
3403 2014-10-28  Daniel Bates  <dabates@apple.com>
3404
3405         Unify logic in RunTests.run() to run the Python unit tests
3406         https://bugs.webkit.org/show_bug.cgi?id=138160
3407
3408         Reviewed by Martin Robinson.
3409
3410         Unify the interactive and non-interactive code path for running the Python unit tests
3411         in step RunTests so as to remove duplicate code to compute the the path to the script
3412         test-webkitpy and log an informative message ("Running Python unit tests") to the console.
3413
3414         No new tests since no functionality was changed.
3415
3416         * Scripts/webkitpy/port/base.py:
3417         (Port.python_unittest_results_directory):
3418         * Scripts/webkitpy/tool/steps/runtests.py:
3419         (RunTests.run):
3420
3421 2014-10-28  Jake Nielsen  <jacob_nielsen@apple.com>
3422
3423         Make runtest.py call test-webkitpy with the --json flag when in
3424         non-interactive mode.
3425         https://bugs.webkit.org/show_bug.cgi?id=137667
3426
3427         Reviewed by Daniel Bates.
3428
3429         * Scripts/webkitpy/port/base.py:
3430         Adds the python_unittest_results_directory method.
3431         (Port.python_unittest_results_directory):
3432         * Scripts/webkitpy/tool/steps/runtests.py:
3433         Changes RunTests to call test-webkitpy with the --json flag if the
3434         --non-interactive flag is set.
3435         (RunTests):
3436         (RunTests.run):
3437
3438 2014-10-28  Rebecca Hauck  <rhauck@adobe.com>
3439
3440         import-w3c-tests should use re.escape() wherever it's handling file paths
3441         https://bugs.webkit.org/show_bug.cgi?id=137934
3442
3443         This patch adds re.escape() to a few places where we're doing string
3444         conversions. This prevents errors when attribute values coincidentally
3445         have character sequences that can be interpreted as regular expressions.
3446
3447         Reviewed by Bem Jones-Bey.
3448
3449         * Scripts/webkitpy/w3c/test_converter.py:
3450         (_W3CTestConverter.convert_attributes_if_needed):
3451
3452 2014-10-28  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3453
3454         [EFL] Remove an unused include from Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
3455         https://bugs.webkit.org/show_bug.cgi?id=138130
3456
3457         Reviewed by Csaba Osztrogonác.
3458
3459         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3460
3461 2014-10-25  Raniere Silva  <raniere@ime.unicamp.br>
3462
3463         Fix link to Arch Linux Wiki
3464         https://bugs.webkit.org/show_bug.cgi?id=138010
3465
3466         Reviewed by Benjamin Poulain.
3467
3468         * gtk/install-dependencies:
3469
3470 2014-10-25  Alexey Proskuryakov  <ap@apple.com>
3471
3472         Test regressions are not detected when image result is missing
3473         https://bugs.webkit.org/show_bug.cgi?id=138070
3474
3475         Reviewed by Simon Fraser.
3476
3477         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3478         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3479         Count these as regressions, not as flaky tests.
3480
3481         * Scripts/webkitpy/port/test.py:
3482         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3483         Test it.
3484
3485 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
3486
3487         Add Conrad Shultz to the contributors list.
3488
3489         * Scripts/webkitpy/common/config/contributors.json:
3490
3491 2014-10-24  Dan Bernstein  <mitz@apple.com>
3492
3493         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
3494         https://bugs.webkit.org/show_bug.cgi?id=138046
3495
3496         Reviewed by Alexey Proskuryakov.
3497
3498         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3499         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
3500         401. Otherwise, we’ll retry normally in 45 seconds.
3501
3502 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
3503
3504         [GTK] Implement is_selected method on WebKitHitTestResult
3505         https://bugs.webkit.org/show_bug.cgi?id=137110
3506
3507         Reviewed by Tim Horton.
3508
3509         Add tests for new context SELECTION on WebKitHitTestResult.
3510
3511         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3512         (testContextMenuDefaultMenu):
3513         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3514         (testWebViewMouseTarget):
3515
3516 2014-10-23  Roger Fong  <roger_fong@apple.com>
3517
3518         [Win] Skip failing JSC tests following r175078
3519         https://bugs.webkit.org/show_bug.cgi?id=130967.
3520
3521         * Scripts/run-javascriptcore-tests:
3522
3523 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3524
3525         commitqueuetask_unittest.py should be made more concise.
3526         https://bugs.webkit.org/show_bug.cgi?id=137985
3527
3528         Reviewed by Alexey Proskuryakov.
3529
3530         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3531         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
3532         (MockCommitQueue.__init__):
3533         (MockCommitQueue.report_flaky_tests):
3534         (MockCommitQueue):
3535         (MockCommitQueue.get_reported_flaky_tests):
3536         (MockSimpleTestPlanCommitQueue.__init__):
3537         (MockSimpleTestPlanCommitQueue.run_command):
3538         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
3539         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3540         (test_land_failure):
3541         (test_failed_archive):
3542         (test_double_flaky_test_failure):
3543         (test_test_failure):
3544         (test_red_test_failure):
3545         (test_very_red_tree_retry):
3546         (test_red_tree_patch_rejection):
3547         (test_one_flaky_test):
3548         (test_tree_more_red_than_patch):
3549         (MockCommitQueue.test_results): Deleted.
3550         (test_simple_flaky_test_failure): Deleted.
3551         (_expect_validate): Deleted.
3552         (_expect_validate.MockDelegate): Deleted.
3553         (_expect_validate.MockDelegate.refetch_patch): Deleted.
3554         (_expect_validate.MockDelegate.expected_failures): Deleted.
3555         (_mock_patch): Deleted.
3556         (test_validate): Deleted.
3557         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3558         Fixes a bug that slipped through the cracks prior to this change.
3559         (PatchAnalysisTask._test_patch):
3560
3561 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
3562
3563         Flakiness dashboard should support OS X Yosemite
3564         https://bugs.webkit.org/show_bug.cgi?id=137986
3565
3566         Reviewed by Ryosuke Niwa.
3567
3568         * TestResultServer/app.yaml:
3569         * TestResultServer/static-dashboards/builders.jsonp:
3570         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3571
3572 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3573
3574         commitqueuetask should include more tests to ensure that the behavior
3575         of PatchAnalysisTask._test_patch() is well defined
3576         https://bugs.webkit.org/show_bug.cgi?id=137977
3577
3578         Reviewed by Alexey Proskuryakov.
3579
3580         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3581         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
3582         and more readable to define tests that are meant to test the behaviour
3583         of PatchAnalysisTask._test_patch(), and adds several unit tests.
3584         (FailingTestCommitQueue.test_results):
3585         (PatchAnalysisResult):
3586         (MockSimpleTestPlanCommitQueue):
3587         (MockSimpleTestPlanCommitQueue.__init__):
3588         (MockSimpleTestPlanCommitQueue.run_command):
3589         (MockSimpleTestPlanCommitQueue._mock_test_result):
3590         (MockSimpleTestPlanCommitQueue.test_results):
3591         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
3592         (test_flaky_test_failure):
3593         (test_failed_archive):
3594         (test_two_flaky_tests):
3595         (test_one_flaky_test):
3596         (test_very_flaky_patch):
3597         (test_very_flaky_patch_with_some_tree_redness):
3598         (test_different_test_failures):
3599         (test_different_test_failures_with_some_tree_redness):
3600         (test_mildly_flaky_patch):
3601         (test_mildly_flaky_patch_with_some_tree_redness):
3602         (test_tree_more_red_than_patch):
3603
3604 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
3605
3606         PatchAnalysisTask._test_patch() needs refactoring
3607         https://bugs.webkit.org/show_bug.cgi?id=137904
3608
3609         Reviewed by Alexey Proskuryakov.
3610
3611         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3612         Fixes several small bugs, and makes minor changes to accomodate the
3613         changes in PatchAnalysisTask.
3614         (MockCommitQueue.refetch_patch):
3615         (MockCommitQueue.test_results):
3616         (test_flaky_test_failure):
3617         (test_failed_archive):
3618         (test_very_red_tree_retry):
3619         (_expect_validate.MockDelegate.refetch_patch):
3620         (MockCommitQueue.expected_failures): Deleted.