Add WebKitSystemInterface for iOS 11
[WebKit-https.git] / Tools / ChangeLog
1 2017-06-29  Jonathan Bedard  <jbedard@apple.com>
2
3         Add WebKitSystemInterface for iOS 11
4         https://bugs.webkit.org/show_bug.cgi?id=173936
5
6         Reviewed by Lucas Forschler.
7
8         * Scripts/copy-webkitlibraries-to-product-directory: Copy iOS 11 WebKitSystemInterface libraries. 
9
10 2017-06-28  Keith Miller  <keith_miller@apple.com>
11
12         VMTraps has some races
13         https://bugs.webkit.org/show_bug.cgi?id=173941
14
15         Reviewed by Michael Saboff.
16
17         Add new testing mode for testing the Watchdog with our stress
18         tests.
19
20         * Scripts/run-jsc-stress-tests:
21
22 2017-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
23
24         [GTK][WPE] Implement API::IconLoadingClient and rework WebKitFaviconDatabase to use IconDatabase directly
25         https://bugs.webkit.org/show_bug.cgi?id=173877
26
27         Reviewed by Brady Eidson.
28
29         Update favicons unit test to ensure we wait until the database is updated in testGetFavicon() before starting
30         the next tests.
31
32         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
33         (testGetFavicon):
34
35 2017-06-28  Tim Horton  <timothy_horton@apple.com>
36
37         MobileSafari was constantly using 10-15% CPU viewing a PDF
38         https://bugs.webkit.org/show_bug.cgi?id=173944
39         <rdar://problem/33039910>
40
41         Reviewed by Simon Fraser.
42
43         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
44         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewStablePresentationUpdateCallback.mm:
45         Add a test that we ever call the stable presentation update callback
46         when we have a WKPDFView up, instead of infinitely looping.
47
48 2017-06-28  Alex Christensen  <achristensen@webkit.org>
49
50         Prevent displaying URLs with small capital letters
51         https://bugs.webkit.org/show_bug.cgi?id=173949
52         <rdar://problem/32952058>
53
54         Reviewed by Brent Fulgham.
55
56         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
57         (TestWebKitAPI::TEST):
58
59 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
60
61         Unreviewed test fix.
62
63         Disable the file monitor tests on iOS because the 'system' API is unavailable on that platform.
64
65         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: 
66
67 2017-06-28  Brent Fulgham  <bfulgham@apple.com>
68
69         Teach ResourceLoadStatistics to recognize changes in the file system
70         https://bugs.webkit.org/show_bug.cgi?id=173800
71         <rdar://problem/32937842>
72
73         Reviewed by Chris Dumez.
74
75         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
76         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp: Added.
77         (TestWebKitAPI::FileMonitorTest::tempFilePath):
78         (TestWebKitAPI::handleFileModification):
79         (TestWebKitAPI::handleFileDeletion):
80         (TestWebKitAPI::resetTestState):
81         (TestWebKitAPI::TEST_F):
82
83 2017-06-28  Brady Eidson  <beidson@apple.com>
84
85         DocumentLoader should always notify the client if there are pending icon loads when the load is stopped.
86         https://bugs.webkit.org/show_bug.cgi?id=173874
87
88         Reviewed by Alex Christensen.
89
90         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
91
92 2017-06-28  Don Olmstead  <don.olmstead@sony.com>
93
94         Unreviewed, adding Don Olmstead to contributors.json
95
96         * Scripts/webkitpy/common/config/contributors.json:
97
98 2017-06-28  Alex Christensen  <achristensen@webkit.org>
99
100         WebsitePolicies given with navigation policy for redirects should apply to the provisional document
101         https://bugs.webkit.org/show_bug.cgi?id=173886
102         <rdar://problem/32543191>
103
104         Reviewed by Andy Estes.
105
106         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
107         (ParsedRange::ParsedRange):
108         (-[TestSchemeHandler initWithVideoData:]):
109         (-[TestSchemeHandler webView:startURLSchemeTask:]):
110         (-[TestSchemeHandler webView:stopURLSchemeTask:]):
111         (TEST):
112
113 2017-06-27  JF Bastien  <jfbastien@apple.com>
114
115         WebAssembly: running out of executable memory should throw OoM
116         https://bugs.webkit.org/show_bug.cgi?id=171537
117         <rdar://problem/32963338>
118
119         Reviewed by Saam Barati.
120
121         * Scripts/run-jsc-stress-tests: add a configuration which runs the
122         tests under limited executable memory and avoids non-WebAssembly
123         code generation so that we more reliably run out of executable
124         memory in WebAssembly.
125
126 2017-06-27  Wenson Hsieh  <wenson_hsieh@apple.com>
127
128         [iOS DnD] Support dragging out of contenteditable areas without a prior selection
129         https://bugs.webkit.org/show_bug.cgi?id=173854
130         <rdar://problem/32236827>
131
132         Reviewed by Ryosuke Niwa and Tim Horton.
133
134         Adds a new test to check that an image can be dragged out of a contenteditable and dropped.
135
136         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
137         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-target.html: Added.
138         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
139         (TestWebKitAPI::TEST):
140
141 2017-06-27  Don Olmstead  <don.olmstead@sony.com>
142
143         [PAL] Add symbol export macros for PAL
144         https://bugs.webkit.org/show_bug.cgi?id=171519
145
146         Reviewed by Konstantin Tokarev.
147
148         * DumpRenderTree/config.h:
149         * TestWebKitAPI/CMakeLists.txt:
150         * TestWebKitAPI/config.h:
151         * WebKitTestRunner/config.h:
152
153 2017-06-27  John Wilander  <wilander@apple.com>
154
155         Resource Load Statistics: Add telemetry
156         https://bugs.webkit.org/show_bug.cgi?id=173499
157         <rdar://problem/32826094>
158
159         Reviewed by Brent Fulgham.
160
161         Adds three new testRunner functions:
162         - installStatisticsDidRunTelemetryCallback()
163         - statisticsFireTelemetryHandler()
164         - setStatisticsNotifyPagesWhenTelemetryWasCaptured()
165
166         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
167         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
168         (WTR::InjectedBundle::didReceiveMessageToPage):
169         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
170         (WTR::TestRunner::installStatisticsDidRunTelemetryCallback):
171         (WTR::TestRunner::statisticsDidRunTelemetryCallback):
172         (WTR::TestRunner::statisticsFireTelemetryHandler):
173         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
174         * WebKitTestRunner/InjectedBundle/TestRunner.h:
175         * WebKitTestRunner/TestController.cpp:
176         (WTR::TestController::resetStateToConsistentValues):
177         (WTR::TestController::statisticsFireTelemetryHandler):
178         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
179         * WebKitTestRunner/TestController.h:
180         * WebKitTestRunner/TestInvocation.cpp:
181         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
182
183 2017-06-27  Ting-Wei Lan  <lantw44@gmail.com>
184
185         Add missing includes to fix compilation error on FreeBSD
186         https://bugs.webkit.org/show_bug.cgi?id=172919
187
188         Reviewed by Mark Lam.
189
190         * ImageDiff/cairo/PlatformImageCairo.cpp:
191
192 2017-06-26  Jonathan Bedard  <jbedard@apple.com>
193
194         Unreviewed, rolling out r218783.
195
196         Causing accessibility/mac/setting-attributes-is-
197         asynchronous.html to crash consistently on mac-wk2 Debug
198
199         Reverted changeset:
200
201         "AX: Cannot call setValue() on contenteditable or ARIA text
202         controls"
203         https://bugs.webkit.org/show_bug.cgi?id=173520
204         http://trac.webkit.org/changeset/218783
205
206 2017-06-26  Yusuke Suzuki  <utatane.tea@gmail.com>
207
208         [WTF] Drop Thread::create(obsolete things) API since we can use lambda
209         https://bugs.webkit.org/show_bug.cgi?id=173825
210
211         Reviewed by Saam Barati.
212
213         * DumpRenderTree/JavaScriptThreading.cpp:
214         (runJavaScriptThread):
215         (startJavaScriptThreads):
216         * DumpRenderTree/mac/DumpRenderTree.mm:
217         (runThread):
218         (runPthread):
219         (testThreadIdentifierMap):
220
221 2017-06-26  David Kilzer  <ddkilzer@apple.com>
222
223         [TestWebKitAPI] Fix false-positive bad release warnings found by clang static analyzer
224         <https://webkit.org/b/173837>
225
226         Reviewed by Geoffrey Garen.
227
228         The clang static analyzer can't reason about objects that are
229         assigned to a delegate as +1 retained, and then released
230         later in a different method when the delegate is cleared.
231
232         Instead, use a common idiom where the object setting the
233         delegate retains it as an instance variable on initialization.
234         Then the same object clears the delegate and releases its
235         instance variable during teardown.
236
237         Also add EXPECT_TRUE() tests to make sure the delegate objects
238         match before teardown.
239
240         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
241         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
242         (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
243         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
244         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
245         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::teardownView):
246
247 2017-06-26  David Kilzer  <ddkilzer@apple.com>
248
249         [TestWebKitAPI] REGRESSION (r218750): Fix leak of NSURLResponse in WKURLSchemeHandler-1.mm
250         <https://webkit.org/b/173836>
251
252         Reviewed by Brady Eidson.
253
254         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
255         (-[RedirectSchemeHandler webView:startURLSchemeTask:]): Use
256         adoptNS() to fix the leak.  Also use auto/adoptNS() for other
257         objects in this test.
258
259 2017-06-26  Joanmarie Diggs  <jdiggs@igalia.com>
260
261         [ATK] Add support for aria-details and aria-errormessage
262         https://bugs.webkit.org/show_bug.cgi?id=172588
263
264         Reviewed by Chris Fleizach.
265
266         Add additional methods to test ARIA properties which are exposed via
267         AtkRelation. Also bump minimum versions of at-spi2-core and at-spi2-atk
268         to versions which support the details and error-message relation types.
269
270         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
271         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
272         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
273         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
274         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
275         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
276         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
277         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
278         (WTR::AccessibilityUIElement::ariaDetailsReferencingElementAtIndex):
279         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
280         (WTR::AccessibilityUIElement::ariaErrorMessageReferencingElementAtIndex):
281         * gtk/jhbuild.modules:
282
283 2017-06-26  Carlos Garcia Campos  <cgarcia@igalia.com>
284
285         Unreviewed. Add libfii to GTK+ install dependencies script.
286
287         * gtk/install-dependencies:
288
289 2017-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
290
291         Unreviewed, rolling out r215190.
292
293         Broke product select element on GNOME Bugzilla
294
295         Reverted changeset:
296
297         "[GTK] Misplaced right click menu on web page due to
298         deprecated gtk_menu_popup()"
299         https://bugs.webkit.org/show_bug.cgi?id=170553
300         http://trac.webkit.org/changeset/215190
301
302 2017-06-24  Joseph Pecoraro  <pecoraro@apple.com>
303
304         Remove Reflect.enumerate
305         https://bugs.webkit.org/show_bug.cgi?id=173806
306
307         Reviewed by Yusuke Suzuki.
308
309         * Scripts/run-jsc-stress-tests:
310
311 2017-06-24  Chris Fleizach  <cfleizach@apple.com>
312
313         AX: Cannot call setValue() on contenteditable or ARIA text controls
314         https://bugs.webkit.org/show_bug.cgi?id=173520
315
316         Reviewed by Ryosuke Niwa.
317
318         Add setValue() method to WKTR (already existed in DRT).
319
320         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
321         (WTR::AccessibilityUIElement::setValue):
322         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
323         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
324         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
325         (WTR::AccessibilityUIElement::setValue):
326
327 2017-06-23  Keith Miller  <keith_miller@apple.com>
328
329         Switch VMTraps to use halt instructions rather than breakpoint instructions
330         https://bugs.webkit.org/show_bug.cgi?id=173677
331
332         Reviewed by JF Bastien.
333
334         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
335         (TEST):
336
337 2017-06-23  Youenn Fablet  <youenn@apple.com>
338
339         Set getUserMedia permission to true by default on WTR
340         https://bugs.webkit.org/show_bug.cgi?id=173610
341
342         Reviewed by Alex Christensen.
343
344         Adding a way to reset the getUserMedia permission to pending.
345
346         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
347         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
348         (WTR::InjectedBundle::setUserMediaPermissionAsUnset):
349         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
350         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
351         (WTR::TestRunner::setUserMediaPermissionAsUnset):
352         * WebKitTestRunner/InjectedBundle/TestRunner.h:
353         * WebKitTestRunner/TestController.cpp:
354         (WTR::TestController::resetStateToConsistentValues):
355         (WTR::TestController::setUserMediaPermissionAsUnset):
356         * WebKitTestRunner/TestController.h:
357         * WebKitTestRunner/TestInvocation.cpp:
358         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
359
360 2017-06-23  Alex Christensen  <achristensen@webkit.org>
361
362         Add SPI to WKURLSchemeTask for redirection
363         https://bugs.webkit.org/show_bug.cgi?id=173730
364
365         Reviewed by Brady Eidson.
366
367         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
368         (-[SchemeHandler webView:startURLSchemeTask:]):
369         (-[SchemeHandler webView:stopURLSchemeTask:]):
370         (TEST):
371         (-[RedirectSchemeHandler webView:startURLSchemeTask:]):
372         (-[RedirectSchemeHandler webView:stopURLSchemeTask:]):
373         (-[RedirectSchemeHandler webView:didReceiveServerRedirectForProvisionalNavigation:]):
374         (-[RedirectSchemeHandler webView:decidePolicyForNavigationResponse:decisionHandler:]):
375         (-[RedirectSchemeHandler userContentController:didReceiveScriptMessage:]):
376
377 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
378
379         [WPE] Use JSC API to send script messages from web extension in tests
380         https://bugs.webkit.org/show_bug.cgi?id=173757
381
382         Reviewed by Žan Doberšek.
383
384         The GTK+ uses DOM bindings to send the messages. We can just build the message string and use JSEvaluateScript
385         to run postMessage().
386
387         Fixes: /wpe/WebKitSecurityManager/file-xhr
388                /wpe/WebKitConsoleMessage/console-api
389                /wpe/WebKitConsoleMessage/js-exception
390                /wpe/WebKitConsoleMessage/network-error
391                /wpe/WebKitConsoleMessage/security-error
392
393         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
394         (testWebKitConsoleMessageSecurityError): Remove ifdefs.
395         (beforeAll): Ditto.
396         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
397         (testWebContextSecurityFileXHR): Ditto.
398         (beforeAll): Ditto.
399         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
400         (consoleMessageSentCallback): Use JSEvaluateScript in WPE. We need to escape the '"' in the message string.
401         (pageCreatedCallback): Remove ifdefs.
402
403 2017-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
404
405         Unreviewed. Fix WPE /wpe/WebKitWebView/javascript-dialogs and /wpe/WebKitWebView/window-properties
406
407         Skip onbeforeunload dialog tests for now in WPE since we don't have a implemention for
408         simulateUserInteraction(). And do not expect changes in "geometry" property of WebKitWindowProperties that
409         doesn't exist yet in WPE.
410
411         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
412         (testWebViewJavaScriptDialogs):
413         (testWebViewWindowProperties):
414
415 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
416
417         [GTK] Upgrade pixman and cairo in jhbuild
418         https://bugs.webkit.org/show_bug.cgi?id=173710
419
420         Reviewed by Carlos Alberto Lopez Perez.
421
422         * gtk/jhbuild.modules:
423
424 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
425
426         REGRESSION(r218686): [GTK] Several unit tests are failing after r218686 in the bots
427         https://bugs.webkit.org/show_bug.cgi?id=173711
428
429         Reviewed by Carlos Alberto Lopez Perez.
430
431         I can't reproduce it locally, but it's complaining about a g_setenv() and I only added one in r218686 to recover
432         the XDG_RUNTIME_DIR, because it's required by Wayland to work. So, I guess that env var is not set in the bots.
433
434         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
435         (WebKitTestBus::run): Ensure value is not nullptr before calling g_setenv().
436
437 2017-06-22  David Kilzer  <ddkilzer@apple.com>
438
439         REGRESSION (r218419): 7 leaks in PluginLoadClientPolicies.mm
440         <https://webkit.org/b/173721>
441
442         Reviewed by Joseph Pecoraro.
443
444         Use RetainPtr<> to create NSMutableDictionary and NSNumber
445         objects to fix leaks and to avoid the autoreleasepool.
446
447         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm:
448         (TEST):
449
450 2017-06-22  Matt Lewis  <jlewis3@apple.com>
451
452         Unreviewed, rolling out r218633.
453
454         The test is failing frequently on Sierra Debug and Windows
455
456         Reverted changeset:
457
458         "AX: Cannot call setValue() on contenteditable or ARIA text
459         controls"
460         https://bugs.webkit.org/show_bug.cgi?id=173520
461         http://trac.webkit.org/changeset/218633
462
463 2017-06-22  David Kilzer  <ddkilzer@apple.com>
464
465         [TestWebKitAPI] Fix misuse of -[NSData dataWithBytesNoCopy:length:] with global variables
466         <https://webkit.org/b/173690>
467
468         Reviewed by Chris Dumez.
469
470         Per documentation, -[NSData dataWithBytesNoCopy:length:] takes
471         ownership of malloc()-ed memory, then frees it when it's
472         released.  These tests were passing global variables into the
473         method, which is not malloc()-ed memory, which violates the API
474         contract.
475
476         The fix is to switch to use
477         -[NSData dataWithBytesNoCopy:length:freeWhenDone:] and to pass
478         NO for the last argument.
479
480         Caught by the clang static analyzer.
481
482         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
483         (TEST):
484         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
485         (TEST):
486
487 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
488
489         [GTK] Upgrade Harfbuzz to version 1.4.2
490         https://bugs.webkit.org/show_bug.cgi?id=173592
491
492         Reviewed by Carlos Alberto Lopez Perez.
493
494         * gtk/jhbuild.modules:
495
496 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
497
498         [WPE] Update WPEBackend-mesa
499         https://bugs.webkit.org/show_bug.cgi?id=173705
500
501         Reviewed by Carlos Alberto Lopez Perez.
502
503         A crash has been fixed, needed for unit tests to work.
504
505         * wpe/jhbuild.modules:
506
507 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
508
509         Remove unused coordinated graphics C API
510         https://bugs.webkit.org/show_bug.cgi?id=173706
511
512         Reviewed by Žan Doberšek.
513
514         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Removed.
515         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp: Removed.
516         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewRestoreZoomAndScrollBackForward.cpp: Removed.
517         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp: Removed.
518         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward1.html: Removed.
519         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/backforward2.html: Removed.
520
521 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
522
523         [WPE] Build glib API tests
524         https://bugs.webkit.org/show_bug.cgi?id=173702
525
526         Reviewed by Žan Doberšek.
527
528         Many of the tests pass without problems, others need to be investigated, and some others are known issues. The
529         main difference between the GTK+ and WPE WebKitWebView is that in GTK+ it's a GtkWidget, so initially
530         unowned. The tests assume that webkit_web_view_new methods return a floating reference. This patch adds
531         Test::adoptView() method that returns a GRefPtr<WebKitWebView> with a different implementation in GTK+ and
532         WPE. In the case of GTK+, it sinks the floating reference, while in WPE it simply adopts the reference. Another
533         difference is that in GTK+ the web view is initially hidden and needs to be added to a window to make it
534         visible. Also, some tests need the web view to be realized to work, and others need that the view is added to a
535         toplevel window, instead of a popup window. All those things are not needed at all in WPE. I've added several
536         #ifdefs with FIXME comments for the things that we know don't work in WPE yet, for example, because we haven't
537         implemented the methods to send events to the web view. Those will be removed eventually when we fix the issues
538         and implement the missing features.
539
540         * CMakeLists.txt:
541         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp:
542         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
543         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
544         (testAutomationSessionRequestSession):
545         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp:
546         (testWebKitWebViewSessionState):
547         (testWebKitWebViewSessionStateWithFormData):
548         (testWebKitWebViewNavigationAfterSessionRestore):
549         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp:
550         (beforeAll):
551         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
552         (testCookieManagerEphemeral):
553         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
554         (testBlobDownload):
555         (beforeAll):
556         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
557         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
558         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
559         (testProcessPerWebView):
560         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
561         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
562         (testWebViewCreateNavigationData):
563         (testWebViewJavaScriptDialogs):
564         (testWebViewWindowProperties):
565         (testWebViewMouseTarget):
566         (testWebViewGeolocationPermissionRequests):
567         (testWebViewUserMediaPermissionRequests):
568         (testWebViewAudioOnlyUserMediaPermissionRequests):
569         (testWebViewFileChooserRequest):
570         (beforeAll):
571         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
572         (beforeAll):
573         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
574         (testPrivateBrowsing):
575         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp:
576         (testFindControllerHide):
577         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp:
578         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
579         (testWebKitSettings):
580         (beforeAll):
581         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
582         (testWebViewNewWithUserContentManager):
583         (beforeAll):
584         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
585         (testWebContextEphemeral):
586         (testWebContextProxySettings):
587         (beforeAll):
588         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
589         (testWebViewWebContext):
590         (testWebViewWebContextLifetime):
591         (testWebViewEphemeral):
592         (testWebViewSettings):
593         (testWebViewCanShowMIMEType):
594         (testWebViewPageVisibility):
595         (testWebViewIsPlayingAudio):
596         (beforeAll):
597         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
598         (testWebsiteDataEphemeral):
599         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
600         (documentLoadedCallback):
601         (pageCreatedCallback):
602         (methodCallCallback):
603         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
604         * TestWebKitAPI/glib/CMakeLists.txt:
605         * TestWebKitAPI/glib/PlatformGTK.cmake:
606         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
607         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
608         (main):
609         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
610         (Test::adoptView):
611         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
612         (WebKitTestBus::run):
613         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
614         (WebViewTest::~WebViewTest):
615         (WebViewTest::initializeWebView):
616         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
617         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp: Added.
618         (WebViewTest::platformDestroy):
619         (WebViewTest::platformInitializeWebView):
620         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
621         (WebViewTest::resizeView):
622         (WebViewTest::hideView):
623         (parentWindowMapped):
624         (WebViewTest::showInWindow):
625         (WebViewTest::showInWindowAndWaitUntilMapped):
626         (WebViewTest::mouseMoveTo):
627         (WebViewTest::clickMouseButton):
628         (WebViewTest::emitPopupMenuSignal):
629         (WebViewTest::keyStroke):
630         (WebViewTest::doMouseButtonEvent):
631         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h.
632         (WebViewTest::platformDestroy):
633         (WebViewTest::platformInitializeWebView):
634         (WebViewTest::quitMainLoopAfterProcessingPendingEvents):
635         (WebViewTest::resizeView):
636         (WebViewTest::hideView):
637         (WebViewTest::mouseMoveTo):
638         (WebViewTest::clickMouseButton):
639         (WebViewTest::keyStroke):
640
641 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
642
643         [GTK] Move WebKit2 GLib API tests to glib directories
644         https://bugs.webkit.org/show_bug.cgi?id=173642
645
646         Reviewed by Žan Doberšek.
647
648         * CMakeLists.txt:
649         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Removed.
650         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Removed.
651         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp.
652         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp.
653         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp.
654         * TestWebKitAPI/Tests/WebKitGLib/TestBackForwardList.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp.
655         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp.
656         (testWebKitConsoleMessageNetworkError):
657         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp.
658         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp.
659         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp.
660         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp.
661         (testLoadFromGResource):
662         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp.
663         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp.
664         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp.
665         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp.
666         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp.
667         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp.
668         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFindController.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp.
669         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitPolicyClient.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp.
670         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSecurityOrigin.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp.
671         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp.
672         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp.
673         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp.
674         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp.
675         (testWebViewRunJavaScript):
676         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp.
677         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp.
678         (registerGResource):
679         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp.
680         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h.
681         * TestWebKitAPI/Tests/WebKitGLib/resources/blank.ico: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico.
682         * TestWebKitAPI/Tests/WebKitGLib/resources/boring.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html.
683         * TestWebKitAPI/Tests/WebKitGLib/resources/link-title.js: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js.
684         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg.
685         * TestWebKitAPI/Tests/WebKitGLib/resources/simple.json: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json.
686         * TestWebKitAPI/Tests/WebKitGLib/resources/test-cert.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem.
687         * TestWebKitAPI/Tests/WebKitGLib/resources/test-key.pem: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem.
688         * TestWebKitAPI/Tests/WebKitGLib/resources/test.pdf: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf.
689         * TestWebKitAPI/Tests/WebKitGLib/resources/track.ogg: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Gtk/resources/track.ogg.
690         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml: Added.
691         * TestWebKitAPI/glib/CMakeLists.txt: Added.
692         * TestWebKitAPI/glib/PlatformGTK.cmake: Added.
693         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp.
694         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h.
695         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp.
696         (registerGResource):
697         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h.
698         (Test::getResourcesDir):
699         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp.
700         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h.
701         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp.
702         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h.
703         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp.
704         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h: Renamed from Tools/TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h.
705
706 2017-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         [WPE] Add initial web extensions API
709         https://bugs.webkit.org/show_bug.cgi?id=173640
710
711         Reviewed by Žan Doberšek.
712
713         Add style checker exceptions for WPE web extensions API files.
714
715         * Scripts/webkitpy/style/checker.py:
716
717 2017-06-21  Wenson Hsieh  <wenson_hsieh@apple.com>
718
719         [iOS DnD] [WK2] Cancelling a drag interaction using the ObjC SPI causes subsequent dragging to fail
720         https://bugs.webkit.org/show_bug.cgi?id=173659
721         <rdar://problem/32879788>
722
723         Reviewed by Tim Horton.
724
725         Adds a new test to verify that a lift cancelled within the UI process does not cause subsequent dragging to fail.
726
727         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html:
728
729         Augment this test page to log dragend and dragstart events on the drag source as well.
730
731         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
732         (checkStringArraysAreEqual):
733         (TestWebKitAPI::TEST):
734
735 2017-06-21  Antoine Quint  <graouts@apple.com>
736
737         Ensure DRT always logs rAF suspension debugging code
738         https://bugs.webkit.org/show_bug.cgi?id=173681
739
740         Reviewed by Tim "Mr. T" Horton.
741
742         * DumpRenderTree/mac/DumpRenderTree.mm:
743         (resetWebPreferencesToConsistentValues):
744
745 2017-06-21  Chris Dumez  <cdumez@apple.com>
746
747         Allow constructing a WTF:Function from a function pointer
748         https://bugs.webkit.org/show_bug.cgi?id=173660
749
750         Reviewed by Alex Christensen.
751
752         Add API test coverage.
753
754         * TestWebKitAPI/Tests/WTF/Function.cpp:
755         (TestWebKitAPI::returnThree):
756         (TestWebKitAPI::returnFour):
757         (TestWebKitAPI::returnPassedValue):
758         (TestWebKitAPI::TEST):
759
760 2017-06-21  Antoine Quint  <graouts@apple.com>
761
762         Add logging to identify when the Page suspends scripted animations
763         https://bugs.webkit.org/show_bug.cgi?id=173626
764
765         Reviewed by Tim Horton.
766
767         Turn the new logging on for WK1/DRT since the issue we're trying to pinpoint only occurs on WK1 bots.
768
769         * DumpRenderTree/mac/DumpRenderTree.mm:
770         (resetWebPreferencesToConsistentValues):
771
772 2017-06-21  Chris Fleizach  <cfleizach@apple.com>
773
774         AX: Cannot call setValue() on contenteditable or ARIA text controls
775         https://bugs.webkit.org/show_bug.cgi?id=173520
776
777         Reviewed by Ryosuke Niwa.
778
779         Add setValue() method to WKTR (already existed in DRT).
780
781         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
782         (WTR::AccessibilityUIElement::setValue):
783         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
784         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
785         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
786         (WTR::AccessibilityUIElement::setValue):
787
788 2017-06-21  Zan Dobersek  <zdobersek@igalia.com>
789
790         List libtasn1 packages in GTK+ and WPE install-dependencies scripts
791         as one of the dependencies required to build the product.
792
793         Rubber-stamped by Carlos Garcia Campos.
794
795         * gtk/install-dependencies:
796         * wpe/install-dependencies:
797
798 2017-06-20  Myles C. Maxfield  <mmaxfield@apple.com>
799
800         Disable font variations on macOS Sierra and iOS 10
801         https://bugs.webkit.org/show_bug.cgi?id=173618
802         <rdar://problem/32879164>
803
804         Reviewed by Jon Lee.
805
806         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
807
808 2017-06-20  Wenson Hsieh  <wenson_hsieh@apple.com>
809
810         [iOS DnD] [WK2] Remove custom logic for disambiguating long press action sheet gestures and drag lift
811         https://bugs.webkit.org/show_bug.cgi?id=173578
812         <rdar://problem/32825028>
813
814         Reviewed by Tim Horton.
815
816         Slight tweak to ensure that DataInteractionTests.CustomActionSheetPopover still passes and verifies that showing
817         a custom popover does not cause dragging to fail when the popover is presented.
818
819         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
820         (-[DataInteractionSimulator _advanceProgress]):
821
822 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
823
824         [WPE] Add initial implementation of glib API
825         https://bugs.webkit.org/show_bug.cgi?id=173546
826
827         Reviewed by Žan Doberšek.
828
829         Disable geolocation because WPE doesn't implement any provider and update the style checker exceptions to
830         include WPE glib API files.
831
832         * Scripts/webkitperl/FeatureList.pm:
833         * Scripts/webkitpy/style/checker.py:
834         * Scripts/webkitpy/style/checkers/cpp.py:
835         (check_identifier_name_in_declaration):
836
837 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
838
839         [GTK] Upgrade to ICU to version 57.1
840         https://bugs.webkit.org/show_bug.cgi?id=173538
841
842         Reviewed by Žan Doberšek.
843
844         * gtk/jhbuild.modules:
845
846 2017-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
847
848         [GTK] Remove unneeded modules from the jhbuild
849         https://bugs.webkit.org/show_bug.cgi?id=170540
850
851         Reviewed by Michael Catanzaro.
852
853         We are building libxslt and libffi that we don't really need to build from sources.
854
855         * gtk/jhbuild.modules:
856
857 2017-06-19  Frederic Wang  <fwang@igalia.com>
858
859         [Mac] Add an experimental feature setting for async frame scrolling
860         https://bugs.webkit.org/show_bug.cgi?id=173359
861
862         Reviewed by Simon Fraser.
863
864         * DumpRenderTree/mac/DumpRenderTree.mm:
865         (enableExperimentalFeatures): Do not enable async frame scrolling for now.
866         (resetWebPreferencesToConsistentValues): Disable async frame scrolling by default.
867         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
868         (WTR::InjectedBundle::beginTesting): Initalize to async frame scrolling to false.
869
870 2017-06-19  Guillaume Emont  <guijemont@igalia.com>
871
872         Unreviewed, adding myself to contributors.json
873
874         * Scripts/webkitpy/common/config/contributors.json:
875
876 2017-06-19  Joseph Pecoraro  <pecoraro@apple.com>
877
878         test262: Completion values for control flow do not match the spec
879         https://bugs.webkit.org/show_bug.cgi?id=171265
880
881         Reviewed by Saam Barati.
882
883         * Scripts/run-jsc-stress-tests:
884         Include a :failDueToOutdatedOrBadTest to mark failures with justification.
885
886 2017-06-19  Zalan Bujtas  <zalan@apple.com>
887
888         Opening certain mails brings up a mail that grows indefinitely.
889         https://bugs.webkit.org/show_bug.cgi?id=173562
890         <rdar://problem/32766579>
891
892         Reviewed by Tim Horton.
893
894         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
895         (TEST):
896
897 2017-06-19  Wenson Hsieh  <wenson_hsieh@apple.com>
898
899         [iOS DnD] Support .zip archives for file uploads via drag and drop
900         https://bugs.webkit.org/show_bug.cgi?id=173511
901         <rdar://problem/32521025>
902
903         Reviewed by Tim Horton.
904
905         Adds tests for dropping .zip archives into a JavaScript-based file upload area, as well as into a file input.
906         Also verifies that URLs are not handled as file drops. See WebCore ChangeLog for more details.
907
908         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
909         * TestWebKitAPI/Tests/WebKit2Cocoa/compressed-files.zip: Added.
910         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
911         (testZIPArchive):
912         (TestWebKitAPI::TEST):
913
914 2017-06-18  Darin Adler  <darin@apple.com>
915
916         Fix Ref to deref before assignment, add tests for this to RefPtr, Ref, Function
917         https://bugs.webkit.org/show_bug.cgi?id=173526
918
919         Reviewed by Sam Weinig.
920
921         * TestWebKitAPI/CMakeLists.txt: Added Function.cpp.
922         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
923
924         * TestWebKitAPI/Tests/WTF/Function.cpp: Added. Contains basic tests and some
925         tests for assignment before destruction ones.
926
927         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Added a () operator so this can be used
928         as a function, so it can be used in WTF::Function tests.
929
930         * TestWebKitAPI/Tests/WTF/Ref.cpp: Use EXPECT macros insead of ASSERT.
931         Added tests for swap and for assignment before deref.
932
933         * TestWebKitAPI/Tests/WTF/RefLogger.cpp: Stopped using inlining; no good reason
934         to inline everything. Also removed the unnecessary clearing of the log every time
935         the DerivedRefLogger constructor is called.
936         * TestWebKitAPI/Tests/WTF/RefLogger.h: Ditto.
937
938         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Use EXPECT macros instead of ASSERT.
939         Added tests for assignment before deref and similar for releaseNonNull.
940
941 2017-06-19  Sam Weinig  <sam@webkit.org>
942
943         [WebIDL] Properly model buffer source / typed arrays as their own IDL types
944         https://bugs.webkit.org/show_bug.cgi?id=173513
945
946         Reviewed by Alex Christensen.
947
948         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
949         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
950         Replace IsNonPointerType subroutine with IsPrimitiveType so we can remove IsNonPointerType.
951
952 2017-06-19  Per Arne Vollan  <pvollan@apple.com>
953
954         [Win] fast/dom/assign-to-window-status.html is flaky.
955         https://bugs.webkit.org/show_bug.cgi?id=173512
956
957         Reviewed by Alex Christensen.
958
959         We should not dump status callbacks when test is done.
960
961         * DumpRenderTree/win/UIDelegate.cpp:
962         (UIDelegate::setStatusText):
963
964 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
965
966         [WPE][JHBuild] Update WPEBackend-mesa
967         https://bugs.webkit.org/show_bug.cgi?id=173433
968
969         Unreviewed.
970
971         Update WPEBackend-mesa back (like it was done originally in r218344)
972         after fixing the issue with the DISPLAY environment variables that
973         caused the crashes.
974
975         * wpe/jhbuild.modules:
976
977 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
978
979         Rename unit test file after r218482
980         https://bugs.webkit.org/show_bug.cgi?id=173483
981
982         Unreviewed.
983
984         * Scripts/webkitpy/port/waylanddriver_unittest.py: Renamed from Tools/Scripts/webkitpy/port/wayland_unittest.py.
985
986 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
987
988         Unreviewed. Fix wrong style checker condition added in r218487.
989
990         * Scripts/webkitpy/style/checkers/cpp.py:
991         (check_identifier_name_in_declaration):
992
993 2017-06-19  Adrian Perez de Castro  <aperez@igalia.com>
994
995         Missing <functional> includes make builds fail with GCC 7.x
996         https://bugs.webkit.org/show_bug.cgi?id=173544
997
998         Unreviewed gardening.
999
1000         Fix compilation with GCC 7.
1001
1002         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1003         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1004
1005 2017-06-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1006
1007         [GTK] Move GTK+ API files that could be shared to glib dirs
1008         https://bugs.webkit.org/show_bug.cgi?id=173545
1009
1010         Reviewed by Žan Doberšek.
1011
1012         Update paths of GTK+ API in watchlist and style checker.
1013
1014         * Scripts/webkitpy/common/config/watchlist:
1015         * Scripts/webkitpy/style/checker.py:
1016         * Scripts/webkitpy/style/checkers/cpp.py:
1017         (check_identifier_name_in_declaration):
1018
1019 2017-06-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1020
1021         Port setup_environ_for_server should not set environment variables related with the driver.
1022         https://bugs.webkit.org/show_bug.cgi?id=173483
1023
1024         Reviewed by Carlos Garcia Campos.
1025
1026         The port setup_environ_for_server() should not set environment variables
1027         that depend on the type of driver (like DISPLAY or GDK_BACKEND).
1028         This varibles should be only set on the driver setup_environ_for_test().
1029
1030         This causes that (for example) the variable DISPLAY or XAUTHORITY leaks
1031         into the test environment even when running the tests with a driver
1032         that is not the Xorg or Xvfb one.
1033
1034         * Scripts/webkitpy/port/base.py: Stop setting XAUTHORITY and DISPLAY here.
1035         (Port.to.setup_environ_for_server):
1036         * Scripts/webkitpy/port/driver.py: Remove unneded WEBKIT_OUTPUTDIR that is already set on base.py
1037         (Driver._setup_environ_for_driver):
1038         * Scripts/webkitpy/port/driver_unittest.py:
1039         (DriverTest.test_setup_environ_for_test):
1040         (DriverTest):
1041         (DriverTest.test_setup_environ_base_vars):
1042         * Scripts/webkitpy/port/gtk.py: Stop setting GDK_BACKEND here and do that on the driver (Xvfb).
1043         (GtkPort.setup_environ_for_server):
1044         * Scripts/webkitpy/port/wayland_unittest.py: Added.
1045         (WaylandDriverTest):
1046         (WaylandDriverTest.make_driver):
1047         (WaylandDriverTest.make_environment):
1048         (WaylandDriverTest.test_checkdriver):
1049         (WaylandDriverTest.test_environment_needed_variables):
1050         (WaylandDriverTest.test_environment_forbidden_variables):
1051         (WaylandDriverTest.test_environment_optional_variables):
1052         * Scripts/webkitpy/port/waylanddriver.py: Allow the driver to run also with WAYLAND_SOCKET.
1053         (WaylandDriver.check_driver):
1054         (WaylandDriver._setup_environ_for_test):
1055         * Scripts/webkitpy/port/xorgdriver.py:
1056         (XorgDriver.check_driver):
1057         (XorgDriver._setup_environ_for_test):
1058         * Scripts/webkitpy/port/xorgdriver_unittest.py: Added.
1059         (XorgDriverTest):
1060         (XorgDriverTest.make_driver):
1061         (XorgDriverTest.make_environment):
1062         (XorgDriverTest.test_checkdriver):
1063         (XorgDriverTest.test_environment_needed_variables):
1064         (XorgDriverTest.test_environment_forbidden_variables):
1065         (XorgDriverTest.test_environment_optional_variables):
1066         * Scripts/webkitpy/port/xvfbdriver.py:
1067         (XvfbDriver._setup_environ_for_test):
1068         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1069         (XvfbDriverTest.assertDriverStartSuccessful):
1070
1071
1072 2017-05-14 Frederic Wang  <fwang@igalia.com>
1073
1074         Add heuristic to avoid flattening "fullscreen" iframes
1075         https://bugs.webkit.org/show_bug.cgi?id=171914
1076
1077         Reviewed by Simon Fraser.
1078
1079         * DumpRenderTree/mac/DumpRenderTree.mm:
1080         (resetWebPreferencesToConsistentValues): Use WebKitFrameFlatteningDisabled.
1081
1082 2017-06-18  Chris Dumez  <cdumez@apple.com>
1083
1084         Crash when re-entering MediaDevicesEnumerationRequest::cancel()
1085         https://bugs.webkit.org/show_bug.cgi?id=173522
1086         <rdar://problem/31185739>
1087
1088         Reviewed by Darin Adler.
1089
1090         Add API test for re-entering Function's assignment operators.
1091
1092         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1093         * TestWebKitAPI/Tests/WTF/Function.cpp: Added.
1094         (TestWebKitAPI::TestObject::TestObject):
1095         (TestWebKitAPI::TestObject::~TestObject):
1096         (TestWebKitAPI::TestObject::operator()):
1097         (TestWebKitAPI::TEST):
1098
1099 2017-06-16  Dan Bernstein  <mitz@apple.com>
1100
1101         [Cocoa] Some declarations have missing or incorrect availability attributes
1102         https://bugs.webkit.org/show_bug.cgi?id=173508
1103
1104         Reviewed by Tim Horton.
1105
1106         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm:
1107         (TestWebKitAPI::TEST): Updated for renames.
1108
1109 2017-06-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1110
1111         [iOS DnD] Upstream iOS drag and drop implementation into OpenSource WebKit
1112         https://bugs.webkit.org/show_bug.cgi?id=173366
1113         <rdar://problem/32767014>
1114
1115         Reviewed by Tim Horton.
1116
1117         Move test pages and pieces of DataInteractionSimulator hidden behind WebKitAdditions into TestWebKitAPI. No
1118         change in behavior.
1119
1120         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1122         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
1123         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
1124         * TestWebKitAPI/Tests/WebKit2Cocoa/contenteditable-and-textarea.html: Added.
1125         * TestWebKitAPI/Tests/WebKit2Cocoa/div-and-large-image.html: Added.
1126         * TestWebKitAPI/Tests/WebKit2Cocoa/file-uploading.html: Added.
1127         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
1128         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
1129         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
1130         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-target-div.html: Added.
1131         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-operation.html: Added.
1132         * TestWebKitAPI/Tests/WebKit2Cocoa/prevent-start.html: Added.
1133         * TestWebKitAPI/Tests/WebKit2Cocoa/textarea-to-input.html: Added.
1134         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1135         (-[MockDragDropSession initWithItems:location:window:]):
1136         (-[MockDragDropSession allowsMoveOperation]):
1137         (-[MockDragDropSession isRestrictedToDraggingApplication]):
1138         (-[MockDragDropSession hasItemsConformingToTypeIdentifiers:]):
1139         (-[MockDragDropSession canLoadObjectsOfClass:]):
1140         (-[MockDragDropSession canLoadObjectsOfClasses:]):
1141         (-[MockDragDropSession items]):
1142         (-[MockDragDropSession setItems:]):
1143         (-[MockDragDropSession locationInView:]):
1144         (-[MockDataOperationSession initWithProviders:location:window:]):
1145         (-[MockDataOperationSession session]):
1146         (-[MockDataOperationSession isLocal]):
1147         (-[MockDataOperationSession progress]):
1148         (-[MockDataOperationSession setProgressIndicatorStyle:]):
1149         (-[MockDataOperationSession progressIndicatorStyle]):
1150         (-[MockDataOperationSession operationMask]):
1151         (-[MockDataOperationSession localDragSession]):
1152         (-[MockDataOperationSession hasItemsConformingToTypeIdentifier:]):
1153         (-[MockDataOperationSession canCreateItemsOfClass:]):
1154         (-[MockDataOperationSession loadObjectsOfClass:completion:]):
1155         (-[MockDataInteractionSession initWithWindow:]):
1156         (-[MockDataInteractionSession localOperationMask]):
1157         (-[MockDataInteractionSession externalOperationMask]):
1158         (-[MockDataInteractionSession session]):
1159         (-[DataInteractionSimulator _advanceProgress]):
1160
1161 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1162
1163         Show punycode to user if a URL has dotless i or j followed by diacritic dot
1164         https://bugs.webkit.org/show_bug.cgi?id=173431
1165
1166         Reviewed by Darin Adler.
1167
1168         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1169         (TestWebKitAPI::TEST):
1170
1171 2017-06-16  Chris Dumez  <cdumez@apple.com>
1172
1173         [WK2] Add WKProcessPool SPI to efficiently reset all plugin load client policies
1174         https://bugs.webkit.org/show_bug.cgi?id=173472
1175         <rdar://problem/28858817>
1176
1177         Reviewed by Brady Eidson.
1178
1179         Add API test coverage.
1180
1181         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1182         * TestWebKitAPI/Tests/WebKit2Cocoa/PluginLoadClientPolicies.mm: Added.
1183         (TEST):
1184
1185 2017-06-16  Brady Eidson  <beidson@apple.com>
1186
1187         REGRESSION (r218015) IconLoaders for already-cached resources expect to be asynchronous, no longer are.
1188         <rdar://problem/32817519> and https://bugs.webkit.org/show_bug.cgi?id=173478
1189
1190         Reviewed by Daniel Bates.
1191
1192         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm:
1193
1194 2017-06-16  Chris Dumez  <cdumez@apple.com>
1195
1196         DRT fails to reset page visibility between tests
1197         https://bugs.webkit.org/show_bug.cgi?id=173485
1198
1199         Reviewed by Alexey Proskuryakov.
1200
1201         DRT fails to reset page visibility between tests and relies on tests calling testRunner.resetPageVisibility().
1202         Fix this to address flakiness.
1203
1204         I confirmed this by commenting out the call to testRunner.resetPageVisibility() in
1205         fast/events/page-visibility-onvisibilitychange.html and running the test in a loop.
1206         The test became flaky without the DRT change and was no longer flaky with the DRT
1207         change.
1208
1209         WebKitTestRunner already does this.
1210
1211         * DumpRenderTree/mac/DumpRenderTree.mm:
1212         (resetWebViewToConsistentStateBeforeTesting):
1213
1214 2017-06-16  Alex Christensen  <achristensen@webkit.org>
1215
1216         Implement basic authentication in MiniBrowser
1217         https://bugs.webkit.org/show_bug.cgi?id=173443
1218
1219         Reviewed by Tim Horton.
1220
1221         * MiniBrowser/mac/WK2BrowserWindowController.m:
1222         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1223
1224 2017-06-16  Jer Noble  <jer.noble@apple.com>
1225
1226         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1227         https://bugs.webkit.org/show_bug.cgi?id=173398
1228         <rdar://problem/32592961>
1229
1230         Reviewed by Eric Carlson.
1231
1232         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1233         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1234         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1235         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1236         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1237         (TestWebKitAPI::TEST):
1238         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1239
1240 2017-06-16  Matt Lewis  <jlewis3@apple.com>
1241
1242         Unreviewed, rolling out r218375.
1243
1244         The API test MediaStreamTrackDetached is still timing out
1245         after the patch
1246
1247         Reverted changeset:
1248
1249         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1250         reports no recording to WebKit clients"
1251         https://bugs.webkit.org/show_bug.cgi?id=173398
1252         http://trac.webkit.org/changeset/218375
1253
1254 2017-06-15  Jer Noble  <jer.noble@apple.com>
1255
1256         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1257         https://bugs.webkit.org/show_bug.cgi?id=173398
1258         <rdar://problem/32592961>
1259
1260         Reviewed by Eric Carlson.
1261
1262         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1263         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1264         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1265         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1266         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1267         (TestWebKitAPI::TEST):
1268         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1269
1270 2017-06-15  Matt Lewis  <jlewis3@apple.com>
1271
1272         Unreviewed, rolling out r218365.
1273
1274         The revision caused API timeouts on all builds.
1275
1276         Reverted changeset:
1277
1278         "[WebRTC] Removing a MediaStreamTrack from a MediaStream
1279         reports no recording to WebKit clients"
1280         https://bugs.webkit.org/show_bug.cgi?id=173398
1281         http://trac.webkit.org/changeset/218365
1282
1283 2017-06-15  Jer Noble  <jer.noble@apple.com>
1284
1285         [WebRTC] Removing a MediaStreamTrack from a MediaStream reports no recording to WebKit clients
1286         https://bugs.webkit.org/show_bug.cgi?id=173398
1287         <rdar://problem/32592961>
1288
1289         Reviewed by Eric Carlson.
1290
1291         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1292         * TestWebKitAPI/Tests/WebKit2/MediaStreamTrackDetached.mm: Added.
1293         (-[MediaStreamTrackDetachedUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
1294         (-[MediaStreamTrackDetachedUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
1295         (-[MediaStreamTrackDetachedUIDelegate _webView:mediaCaptureStateDidChange:]):
1296         (TestWebKitAPI::TEST):
1297         * TestWebKitAPI/Tests/WebKit2/mediastreamtrack-detached.html: Added.
1298
1299 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1300
1301         REGRESSION(r218344): [WPE] Thousands of layout test crashes
1302         https://bugs.webkit.org/show_bug.cgi?id=173433
1303
1304         Unreviewed.
1305
1306         * wpe/jhbuild.modules: Revert the update of WPEBackend-mesa.
1307
1308 2017-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1309
1310         [WPE] The run-minibrowser script should allow to execute also a WPE launcher
1311         https://bugs.webkit.org/show_bug.cgi?id=173061
1312
1313         Reviewed by Žan Doberšek.
1314
1315         Launch dyz <https://github.com/Igalia/dyz> with the script
1316         run-minibrowser for the wpe port. It is now built as part of the
1317         WPE dependencies with JHBuild.
1318
1319         * Scripts/run-minibrowser:
1320         * Scripts/webkitdirs.pm:
1321         (launcherPath):
1322         (launcherName):
1323         * wpe/install-dependencies: Luajit is needed for building dyz.
1324         * wpe/jhbuild.modules: Add dyz and update the revision for WPEBackend-mesa.
1325
1326 2017-06-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1327
1328         Using -[WebItemProviderPasteboard setItemProviders:] to swap out item providers before a drop breaks item provider loading
1329         https://bugs.webkit.org/show_bug.cgi?id=173338
1330         <rdar://problem/32777720>
1331
1332         Reviewed by Tim Horton.
1333
1334         Adds new unit tests to ensure that -_webView:willPerformDropWithSession: can be used to filter out drag items
1335         used by WebKit when handling a drop. These tests ensure that WebItemProviderPasteboard is still able to handle
1336         these remaining items on drop.
1337
1338         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1339         (TestWebKitAPI::TEST):
1340         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1341         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1342
1343         Add -overridePerformDropBlock, which can be set to provide custom handling of dropped items.
1344
1345         (-[DataInteractionSimulator _webView:willPerformDropWithSession:]):
1346
1347 2017-06-15  Per Arne Vollan  <pvollan@apple.com>
1348
1349         [Win] Crash in accessibility layout test.
1350         https://bugs.webkit.org/show_bug.cgi?id=173401
1351
1352         Reviewed by Brent Fulgham.
1353
1354         We should not manually release the punkVal IUnknown member in a _variant_t object, since the punkVal
1355         member will be automatically released when the _variant_t object goes out of scope if the vt member
1356         does not equal VT_UNKNOWN | VT_BYREF.
1357         See https://msdn.microsoft.com/en-us/library/windows/desktop/ms221165(v=vs.85).aspx. 
1358
1359         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1360         (AccessibilityUIElement::titleUIElement):
1361
1362 2017-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1363
1364         [GTK] Add API to allow overriding popup menus
1365         https://bugs.webkit.org/show_bug.cgi?id=172905
1366
1367         Reviewed by Michael Catanzaro.
1368
1369         Add a unit test to check the new API.
1370
1371         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1372         * TestWebKitAPI/Tests/WebKit2Gtk/TestOptionMenu.cpp: Added.
1373         (OptionMenuTest::OptionMenuTest):
1374         (OptionMenuTest::~OptionMenuTest):
1375         (OptionMenuTest::destroyMenu):
1376         (OptionMenuTest::showOptionMenuCallback):
1377         (OptionMenuTest::menuCloseCallback):
1378         (OptionMenuTest::showOptionMenu):
1379         (OptionMenuTest::clickAtPositionAndWaitUntilOptionMenuShown):
1380         (OptionMenuTest::close):
1381         (OptionMenuTest::activateItem):
1382         (OptionMenuTest::selectItem):
1383         (testOptionMenuSimple):
1384         (testOptionMenuGroups):
1385         (testOptionMenuActivate):
1386         (testOptionMenuSelect):
1387         (beforeAll):
1388         (afterAll):
1389
1390 2017-06-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1391
1392         [WinCairo] DumpRenderTree.cpp: error C3861: 'CFURLCacheCreate': identifier not found
1393         https://bugs.webkit.org/show_bug.cgi?id=173399
1394
1395         Reviewed by Per Arne Vollan.
1396
1397         OpenCFLite doesn't have CFURLCacheCreate and CFURLCacheSetSharedURLCache.
1398         Curl port needs to do nothing because libcurl doesn't have disk cache.
1399
1400         * DumpRenderTree/win/DumpRenderTree.cpp:
1401         (prepareConsistentTestingEnvironment): Call CFURLCacheCreate() and
1402         CFURLCacheSetSharedURLCache() only if USE(CFURLCONNECTION).
1403
1404 2017-06-14  Tomas Popela  <tpopela@redhat.com>
1405
1406         [GTK] integer expression expected if running Tools/gtk/install-dependencies
1407         https://bugs.webkit.org/show_bug.cgi?id=173356
1408
1409         Reviewed by Michael Catanzaro.
1410
1411         Use the correct operator to compare the strings.
1412
1413         * gtk/install-dependencies:
1414
1415 2017-06-14  Commit Queue  <commit-queue@webkit.org>
1416
1417         Unreviewed, rolling out r218285.
1418         https://bugs.webkit.org/show_bug.cgi?id=173391
1419
1420         API test fails on iOS (Requested by alexchristensen on
1421         #webkit).
1422
1423         Reverted changeset:
1424
1425         "Add SPI for immediate injection of user scripts"
1426         https://bugs.webkit.org/show_bug.cgi?id=173342
1427         http://trac.webkit.org/changeset/218285
1428
1429 2017-06-14  Chris Dumez  <cdumez@apple.com>
1430
1431         WebKit falsely reports that a web process is unresponsive if you close a page shortly after stopping a load
1432         https://bugs.webkit.org/show_bug.cgi?id=173384
1433         <rdar://problem/32723779>
1434
1435         Reviewed by Dan Bernstein.
1436
1437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1438         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimer.cpp: Added.
1439         Add API test coverage.
1440
1441         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
1442         (TestWebKitAPI::Util::sleep):
1443         Update implementation of Util::sleep() so that we actually run the run loop.
1444         Otherwise, we don't process events while sleeping.
1445
1446 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1447
1448         Add SPI for immediate injection of user scripts
1449         https://bugs.webkit.org/show_bug.cgi?id=173342
1450         <rdar://problem/29202285>
1451
1452         Reviewed by Brady Eidson.
1453
1454         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1455         (waitForMessage):
1456         (TEST):
1457
1458 2017-06-14  Claudio Saavedra  <csaavedra@igalia.com>
1459
1460         Add WPE to the flakiness dashboard
1461         https://bugs.webkit.org/show_bug.cgi?id=173365
1462
1463         Reviewed by Carlos Alberto Lopez Perez.
1464
1465         * TestResultServer/static-dashboards/builders.jsonp:
1466         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1467         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1468         (resetGlobals):
1469         * TestResultServer/static-dashboards/loader_unittests.js:
1470
1471 2017-06-14  Brady Eidson  <beidson@apple.com>
1472
1473         WKIconLoadingDelegate never gets asked about the default favicon if touch/touch-precomposed icons are in the <head>
1474         <rdar://problem/32614328> and https://bugs.webkit.org/show_bug.cgi?id=173376
1475
1476         Reviewed by Alex Christensen.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKit2Cocoa/IconLoadingDelegate.mm: Added.
1480         (-[IconLoadingDelegate webView:shouldLoadIconWithParameters:completionHandler:]):
1481         (-[IconLoadingSchemeHandler initWithData:mimeType:]):
1482         (-[IconLoadingSchemeHandler webView:startURLSchemeTask:]):
1483         (-[IconLoadingSchemeHandler webView:stopURLSchemeTask:]):
1484         (TEST):
1485
1486 2017-06-14  Tim Horton  <timothy_horton@apple.com>
1487
1488         WKContentViewEditingActions API test always fails
1489         https://bugs.webkit.org/show_bug.cgi?id=173374
1490
1491         Reviewed by Wenson Hsieh.
1492
1493         * TestWebKitAPI/Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1494         (TEST):
1495         selectAll isn't working, because canPerformAction for selectAll returns NO
1496         if selectionIsNone (which is true in the non-contenteditable case).
1497         Instead, make use of r218180's test page, which knows how to select itself.
1498         Also, reset the pasteboard at the beginning of the test to reduce confusion
1499         (I landed the test broken because my simulator had the correct text
1500         stuck in its pasteboard).
1501
1502 2017-06-14  Jonathan Bedard  <jbedard@apple.com>
1503
1504         Configure screen scale for running layout tests on plus devices
1505         https://bugs.webkit.org/show_bug.cgi?id=173319
1506
1507         Reviewed by Tim Horton.
1508
1509         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1510         * DumpRenderTree/mac/DumpRenderTree.mm:
1511         (dumpRenderTree): Set screen scale to 2.0.
1512         * TestRunnerShared/spi/UIKitTestSPI.h: Copied from Tools/WebKitTestRunner/ios/UIKitSPI.h,
1513         add _setScale for UIScreen.
1514         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Include UIKitTestSPI.h in project.
1515         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1516         * WebKitTestRunner/ios/HIDEventGenerator.h: Ditto.
1517         * WebKitTestRunner/ios/HIDEventGenerator.mm: Ditto.
1518         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Ditto.
1519         * WebKitTestRunner/ios/TestControllerIOS.mm: Ditto.
1520         (WTR::TestController::platformInitialize): Set screen scale to 2.0.
1521         * WebKitTestRunner/ios/UIKitSPI.h: Moved to TestRunnerShared/spi/UIKitTestSPI.h.
1522         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Import UIKitTestSPI.h instead of UIKitSPI.h.
1523         * WebKitTestRunner/ios/mainIOS.mm: Ditto.
1524
1525 2017-06-14  Alexey Proskuryakov  <ap@apple.com>
1526
1527         Add iOS 11 support to the bot watcher's dashboard
1528         https://bugs.webkit.org/show_bug.cgi?id=173369
1529
1530         Reviewed by Lucas Forschler.
1531
1532         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11.png: Added.
1533         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11@2x.png: Added.
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator.png: Added.
1535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS11Simulator@2x.png: Added.
1536         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1538
1539 2017-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1540
1541         [GTK][WPE] Raise the timeout values for layout tests
1542         https://bugs.webkit.org/show_bug.cgi?id=173368
1543
1544         Reviewed by Carlos Garcia Campos.
1545
1546         Raise the values to 15 seconds in Release builds and 30 seconds (2x) in Debug builds.
1547         When running under valgrind a 10x multiplier is applied.
1548
1549         * Scripts/webkitpy/port/gtk.py:
1550         (GtkPort.default_timeout_ms):
1551         * Scripts/webkitpy/port/gtk_unittest.py:
1552         (GtkPortTest.test_default_timeout_ms):
1553         * Scripts/webkitpy/port/wpe.py:
1554         (WPEPort.default_timeout_ms):
1555         * Scripts/webkitpy/port/wpe_unittest.py: Copied from Tools/Scripts/webkitpy/port/gtk_unittest.py.
1556         (WPEPortTest):
1557         (WPEPortTest.make_port):
1558         (WPEPortTest.test_default_timeout_ms):
1559         (WPEPortTest.test_get_crash_log):
1560
1561 2017-06-14  Alex Christensen  <achristensen@webkit.org>
1562
1563         Test persistent WKHTTPCookieStorages on iOS.
1564         https://bugs.webkit.org/show_bug.cgi?id=173284
1565
1566         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1567         (TEST):
1568         Make the bots green again for now. There's still a problem, and I'll investigate and fix.
1569
1570 2017-06-14  Per Arne Vollan  <pvollan@apple.com>
1571
1572         [Win] DRT should not use disk cache.
1573         https://bugs.webkit.org/show_bug.cgi?id=173361
1574
1575         Reviewed by Darin Adler.
1576
1577         Like on macOS/iOS, DRT on Windows should only use memory cache.
1578
1579         * DumpRenderTree/win/DumpRenderTree.cpp:
1580         (setDefaultsToConsistentValuesForTesting):
1581         (prepareConsistentTestingEnvironment):
1582
1583 2017-06-14  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1584
1585         MediaSource duration attribute should not be equal to Infinity when set to a value greater than 2^64
1586         https://bugs.webkit.org/show_bug.cgi?id=171668
1587
1588         Reviewed by Jer Noble.
1589
1590         MediaSource duration attribute is a double represented in MediaSource by a MediaTime instance created with
1591         MediaTime::CreateWithDouble(). This method implements an overflow control mechanism which sets MediaTime to
1592         Infinity when the double value passed as argument is greater than 2^64.
1593
1594         This patch removes the overflow control mechanism when time value is represented as a double. This patch also
1595         modifies the behavior of mathematical operations between a double MediaTime and rational MediaTime: the rational
1596         MediaTime is converted to a double before applying the operation. Double MediaTime precision is the same as for
1597         double. Overflow mechanisms still apply to the conversion of a double MediaTime to rational with setTimescale()
1598         method. No behavior change for rational MediaTime.
1599
1600         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Add tests to check operation results between double and rational MediaTime.
1601         (TestWebKitAPI::TEST):
1602
1603 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1604
1605         Test persistent WKHTTPCookieStorages on iOS
1606         https://bugs.webkit.org/show_bug.cgi?id=173284
1607         <rdar://problem/32260156>
1608
1609         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1610         (TEST):
1611
1612 2017-06-13  Matt Rajca  <mrajca@apple.com>
1613
1614         WebsitePolicies: let clients select specific autoplay quirks
1615         https://bugs.webkit.org/show_bug.cgi?id=173343
1616
1617         Reviewed by Alex Christensen.
1618
1619         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1620         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1621         (TEST): Updated tests.
1622
1623 2017-06-13  Daniel Bates  <dabates@apple.com>
1624
1625         Implement W3C Secure Contexts Draft Specification
1626         https://bugs.webkit.org/show_bug.cgi?id=158121
1627         <rdar://problem/26012994>
1628
1629         Reviewed by Brent Fulgham.
1630
1631         Part 4
1632
1633         Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
1634         Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
1635         to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
1636
1637         * DumpRenderTree/TestOptions.h:
1638         * DumpRenderTree/TestOptions.mm:
1639         (TestOptions::TestOptions):
1640         * DumpRenderTree/mac/DumpRenderTree.mm:
1641         (setWebPreferencesForTestOptions):
1642         * DumpRenderTree/win/DumpRenderTree.cpp:
1643         (enableExperimentalFeatures):
1644         * WebKitTestRunner/TestController.cpp:
1645         (WTR::TestController::resetPreferencesToConsistentValues):
1646         (WTR::updateTestOptionsFromTestHeader):
1647         * WebKitTestRunner/TestOptions.h:
1648         (WTR::TestOptions::hasSameInitializationOptions):
1649
1650 2017-06-13  Alex Christensen  <achristensen@webkit.org>
1651
1652         Test persistent WKHTTPCookieStorages on iOS
1653         https://bugs.webkit.org/show_bug.cgi?id=173284
1654         <rdar://problem/32260156>
1655
1656         Reviewed by Alexey Proskuryakov.
1657
1658         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
1659         (TEST):
1660
1661 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1662
1663         [GTK] Blob download doesn't work
1664         https://bugs.webkit.org/show_bug.cgi?id=172442
1665
1666         Reviewed by Carlos Alberto Lopez Perez.
1667
1668         Add a unit test to check blob downloads.
1669
1670         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1671         (testBlobDownload):
1672         (beforeAll):
1673
1674 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1675
1676         [GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
1677         https://bugs.webkit.org/show_bug.cgi?id=173316
1678
1679         Reviewed by Alex Christensen.
1680
1681         It's not really possible to run layout tests from the tarball, so it's better not to include those files.
1682
1683         * gtk/manifest.txt.in:
1684
1685 2017-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1686
1687         [WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
1688         https://bugs.webkit.org/show_bug.cgi?id=173315
1689
1690         Reviewed by Darin Adler.
1691
1692         This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
1693         somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
1694         returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
1695         freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
1696         WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
1697         destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
1698         WKGeolocationManagerRef is not destroyed.
1699
1700         * WebKitTestRunner/GeolocationProviderMock.cpp:
1701         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1702         * WebKitTestRunner/GeolocationProviderMock.h:
1703
1704 2017-06-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1705
1706         Unable to paste text that was copied from a page into the universal search field
1707         https://bugs.webkit.org/show_bug.cgi?id=173293
1708         <rdar://problem/32440918>
1709
1710         Reviewed by Ryosuke Niwa.
1711
1712         Adds 2 new unit tests for copying plain and rich selected web content.
1713         See WebCore and WebKit ChangeLogs for more detail.
1714
1715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716         * TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
1717         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
1718         (TestWebKitAPI::dataForPasteboardType):
1719         (TestWebKitAPI::setUpWebViewForPasteboardTests):
1720         (TestWebKitAPI::TEST):
1721
1722 2017-06-13  Joanmarie Diggs  <jdiggs@igalia.com>
1723
1724         AX: [ATK] Implement missing AtkRelation types
1725         https://bugs.webkit.org/show_bug.cgi?id=155494
1726
1727         Reviewed by Darin Adler.
1728
1729         Add additional methods to test ARIA properties which are exposed via
1730         AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
1731
1732         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1733         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1734         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1735         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1736         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1737         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1738         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1739         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1740         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1741         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1742         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1743         (WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
1744         (WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
1745         (WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
1746         (WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
1747         (WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
1748         (WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
1749         (WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
1750
1751 2017-06-12  Daniel Bates  <dabates@apple.com>
1752
1753         Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
1754         https://bugs.webkit.org/show_bug.cgi?id=173286
1755         <rdar://problem/32726102>
1756
1757         Reviewed by Brent Fulgham.
1758
1759         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1760         (TestWebKitAPI::TEST_F):
1761
1762 2017-06-12  Lucas Forschler  <lforschler@apple.com>
1763
1764         <rdar://problem/32683422>
1765         Teach copy-webkitlibraries-to-product-directory script about updated libraries.
1766
1767         Reviewed by Conrad Schultz.
1768
1769         * Scripts/copy-webkitlibraries-to-product-directory:
1770
1771 2017-06-12  Tim Horton  <timothy_horton@apple.com>
1772
1773         [iOS] Cmd-C doesn't copy text from WKWebView
1774         https://bugs.webkit.org/show_bug.cgi?id=173277
1775         <rdar://problem/32396742>
1776
1777         Reviewed by Dan Bernstein.
1778
1779         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1780         * Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
1781         Add a test ensuring that -copy on WKContentView will cause text to be copied.
1782
1783 2017-06-12  Jiewen Tan  <jiewen_tan@apple.com>
1784
1785         [WebCrypto] Remove experimental feature flag of SubtleCrypto
1786         https://bugs.webkit.org/show_bug.cgi?id=173197
1787         <rdar://problem/32688148>
1788
1789         Reviewed by Brent Fulgham.
1790
1791         * DumpRenderTree/mac/DumpRenderTree.mm:
1792         (enableExperimentalFeatures):
1793         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1794         (WTR::InjectedBundle::beginTesting):
1795         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1796         (WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
1797         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1798
1799 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1800
1801         [iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
1802         https://bugs.webkit.org/show_bug.cgi?id=173238
1803         <rdar://problem/31943370>
1804
1805         Reviewed by Ryosuke Niwa and Tim Horton.
1806
1807         Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
1808         element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
1809         of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
1810
1811         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1812         (TestWebKitAPI::TEST):
1813         * TestWebKitAPI/ios/DataInteractionSimulator.h:
1814         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
1815         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
1816         (-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
1817
1818 2017-06-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1819
1820         WebItemProviderPasteboard should call its completion block immediately after a synchronous load
1821         https://bugs.webkit.org/show_bug.cgi?id=173225
1822         <rdar://problem/32713144>
1823
1824         Reviewed by Tim Horton.
1825
1826         Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
1827         cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
1828
1829         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1830         (TestWebKitAPI::TEST):
1831
1832 2017-06-12  Jonathan Bedard  <jbedard@apple.com>
1833
1834         Return correct process names for iOS on-device testing
1835         https://bugs.webkit.org/show_bug.cgi?id=173263
1836
1837         Reviewed by Alex Christensen.
1838
1839         When running tests on iOS devices, process names do not end with '.Development'
1840         as they do on Mac and iOS simulator.
1841
1842         * WebKitTestRunner/TestController.cpp:
1843         (WTR::TestController::webProcessName): Return correct process name without '.Development'
1844         for iOS on-device testing.
1845         (WTR::TestController::networkProcessName): Ditto.
1846         (WTR::TestController::databaseProcessName): Ditto.
1847
1848 2017-06-12  Chris Dumez  <cdumez@apple.com>
1849
1850         Regression(r217867): Legacy SessionHistoryEntryData format should not change
1851         https://bugs.webkit.org/show_bug.cgi?id=173267
1852         <rdar://problem/32701257>
1853
1854         Reviewed by Simon Fraser.
1855
1856         Restrict test to stop covering saving / restore of scrollRestoration via the legacy
1857         SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
1858         though as this covers the crash that r217867 was fixing.
1859
1860         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
1861         (TestWebKitAPI::createSessionStateData):
1862         (TestWebKitAPI::TEST):
1863         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
1864
1865 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1866
1867         [GTK] Stop dismissing menus attached to the web view for every injected event
1868         https://bugs.webkit.org/show_bug.cgi?id=172708
1869
1870         Reviewed by Alex Christensen.
1871
1872         It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
1873         that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
1874         events while the menu is open.
1875
1876         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1877         (WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
1878         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1879         (WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
1880
1881 2017-06-12  Miguel Gomez  <magomez@igalia.com>
1882
1883         [GTK][WPE] Enable GStreamer GL on development builds
1884         https://bugs.webkit.org/show_bug.cgi?id=173248
1885
1886         Enable GStreamer GL for GTK and WPE.
1887
1888         Reviewed by Carlos Garcia Campos.
1889
1890         * Scripts/webkitperl/FeatureList.pm:
1891
1892 2017-06-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1893
1894         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
1895
1896         Notifications are no longer cleared on page navigation.
1897
1898         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1899         (testWebViewNotification):
1900
1901 2017-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1902
1903         Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
1904
1905         DBus interface and object path names were updated in r217831.
1906
1907         * TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
1908
1909 2017-06-10  Dan Bernstein  <mitz@apple.com>
1910
1911         Reverted r218056 because it made the IDE reindex constantly.
1912
1913         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1914         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1915         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1916         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1917         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1918         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1919         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1920         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1921
1922 2017-06-10  Dan Bernstein  <mitz@apple.com>
1923
1924         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
1925         https://bugs.webkit.org/show_bug.cgi?id=173223
1926
1927         Reviewed by Sam Weinig.
1928
1929         The rebuilds were happening due to a difference in the compiler options that the IDE and
1930         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
1931         xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
1932         specify an appropriate path in CLANG_INDEX_STORE_PATH.
1933
1934         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1935         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1936         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1937         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1938         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
1939         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1940         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1941         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1942
1943 2017-06-10  Jonathan Bedard  <jbedard@apple.com>
1944
1945         webkitpy: Reduce polling in ServerProcess
1946         https://bugs.webkit.org/show_bug.cgi?id=173116
1947
1948         Reviewed by Ryosuke Niwa.
1949
1950         We should be smarter about polling. We do not need to poll every time a line is read from
1951         stdout and stderr since lines are usually read from cached data. We should only poll
1952         when extracting that cached data from stdout and stderr.
1953
1954         * Scripts/webkitpy/port/driver.py:
1955         (Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
1956         and on ServerProcess to poll the process if not data is available in stdout and stderr.
1957         * Scripts/webkitpy/port/driver_unittest.py:
1958         (DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
1959         ServerProcess.
1960         * Scripts/webkitpy/port/server_process.py:
1961         (ServerProcess._read): Allow for data to be read from _output even if the process has
1962         crashed. Only poll the process if data needs to be extracted from stdout or stderr. 
1963         * Scripts/webkitpy/port/server_process_mock.py:
1964         (MockServerProcess): Add number_of_times_polled.
1965         (MockServerProcess.poll): Increment number_of_times_polled.
1966         (MockServerProcess.has_crashed): Poll before returning crash state.
1967         (MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
1968         just like a ServerProcess would.
1969         (MockServerProcess.read_stdout): Ditto.
1970         * Scripts/webkitpy/port/server_process_unittest.py:
1971         (TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
1972         process from ending before stdout and stderr are read. This is the reason this test was flakey.
1973         (TestServerProcess):
1974         (TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
1975         the processes is polled.
1976         (TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
1977         data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
1978
1979 2017-06-10  Andy Estes  <aestes@apple.com>
1980
1981         [QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
1982         https://bugs.webkit.org/show_bug.cgi?id=173190
1983         <rdar://problem/31360659>
1984
1985         Reviewed by Brady Eidson.
1986         
1987         Added a release assert that tries to create a proper test failure if the web process crashes.
1988
1989         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
1990         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
1991
1992 2017-06-09  Wenson Hsieh  <wenson_hsieh@apple.com>
1993
1994         [iOS DnD] Add a hook to perform two-step drops in editable content
1995         https://bugs.webkit.org/show_bug.cgi?id=172992
1996         <rdar://problem/32590174>
1997
1998         Reviewed by Tim Horton.
1999
2000         Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
2001         Tests:  DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
2002                 DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
2003
2004         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2005         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2006         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
2007
2008         Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
2009         be overridden. Currently, this is overridden to just return true.
2010
2011         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2012         (TestWebKitAPI::TEST):
2013         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2014         (WTR::InjectedBundlePage::InjectedBundlePage):
2015
2016 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2017
2018         [WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
2019         https://bugs.webkit.org/show_bug.cgi?id=173103
2020
2021         Reviewed by Xabier Rodriguez-Calvar.
2022
2023         * Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
2024         when building the WPE port through build-webkit.
2025
2026 2017-06-09  Zan Dobersek  <zdobersek@igalia.com>
2027
2028         [WPE] Enable MEDIA_SOURCE for build-webkit builds
2029         https://bugs.webkit.org/show_bug.cgi?id=173136
2030
2031         Reviewed by Xabier Rodriguez-Calvar.
2032
2033         * Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
2034
2035 2017-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2036
2037         [GTK] Use API::FormClient instead of the C API in WebKitFormClient
2038         https://bugs.webkit.org/show_bug.cgi?id=173098
2039
2040         Reviewed by Žan Doberšek.
2041
2042         Fix memory leak and runtime warning when running /webkit2/WebKitWebView/submit-form. The web extension is
2043         assuming that all tests containing forms define ids for the form elements like
2044         /webkit2/WebKitWebExtension/form-controls-associated-signal does.
2045
2046         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
2047         (formControlsAssociatedCallback):
2048
2049 2017-06-08  Jonathan Bedard  <jbedard@apple.com>
2050
2051         webkitpy: Run sample/spindump on iOS devices
2052         https://bugs.webkit.org/show_bug.cgi?id=171881
2053         <rdar://problem/32084602>
2054
2055         Reviewed by Daniel Bates.
2056
2057         * Scripts/webkitpy/port/darwin.py:
2058         (DarwinPort.sample_process): Only add sudo prefix if the platform is Mac, which
2059         requires sudo to run spindump.
2060         * Scripts/webkitpy/port/ios_device.py:
2061         (IOSDevicePort.look_for_new_samples): Deleted.
2062         (IOSDevicePort.sample_process): Deleted.
2063         * Scripts/webkitpy/port/ios_device_unittest.py:
2064         (IOSDeviceTest): iOS devices use 'ios' and their os_name.
2065         (IOSDeviceTest.test_spindump):
2066         (IOSDeviceTest.test_sample_process):
2067         (IOSDeviceTest.test_sample_process_exception):
2068         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2069         (IOSSimulatorTest): iOS Simulators run on Mac and use 'mac' as their os_name.
2070
2071 2017-06-08  Keith Miller  <keith_miller@apple.com>
2072
2073         WebAssembly: We should only create wrappers for functions that can be exported
2074         https://bugs.webkit.org/show_bug.cgi?id=173088
2075
2076         Reviewed by Saam Barati.
2077
2078         Add quick mode for wasm tests.
2079
2080         * Scripts/run-jsc-stress-tests:
2081
2082 2017-06-08  Darin Adler  <darin@apple.com>
2083
2084         WTF tests have incorrect RefLogger lifetimes making it impossible to test with Address Sanitizer
2085         https://bugs.webkit.org/show_bug.cgi?id=173106
2086
2087         Reviewed by Sam Weinig.
2088
2089         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp: Define RefLogger objects first, so they are
2090         destroyed last.
2091         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Ditto.
2092         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
2093
2094 2017-06-07  Dan Bernstein  <mitz@apple.com>
2095
2096         [Cocoa] additionalReadAccessAllowedURLs doesn’t preserve non-Latin1 paths
2097         https://bugs.webkit.org/show_bug.cgi?id=173086
2098
2099         Reviewed by Andy Estes.
2100
2101         * TestWebKitAPI/Tests/WebKit2Cocoa/AdditionalReadAccessAllowedURLs.mm:
2102         (TEST):
2103
2104 2017-06-07  Alexey Proskuryakov  <ap@apple.com>
2105
2106         Add High Sierra support to WebKit tools
2107         https://bugs.webkit.org/show_bug.cgi?id=173080
2108
2109         Rubber-stamped by Daniel Bates.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra.png: Added.
2112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/HighSierra@2x.png: Added.
2113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2115         Added dashboard support.
2116
2117         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2118         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2119         Trigger the right build queues on check-in.
2120
2121         * Scripts/webkitpy/common/system/platforminfo.py:
2122         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2123         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2124         * Scripts/webkitpy/port/mac.py:
2125         * Scripts/webkitpy/port/mac_unittest.py:
2126         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2127         Added cases for Sierra, and updated tests for new baseline search paths.
2128
2129 2017-06-07  Ryan Haddad  <ryanhaddad@apple.com>
2130
2131         Unreviewed, rolling out r217902.
2132
2133         This change appears to have caused imported/w3c/web-platform-
2134         tests/fetch/api/cors tests to fail on El Capitan.
2135
2136         Reverted changeset:
2137
2138         "Teach run-webkit-tests how to run HTTPS Web Platform Tests"
2139         https://bugs.webkit.org/show_bug.cgi?id=172930
2140         http://trac.webkit.org/changeset/217902
2141
2142 2017-06-07  Daniel Bates  <dabates@apple.com>
2143
2144         Teach run-webkit-tests how to run HTTPS Web Platform Tests
2145         https://bugs.webkit.org/show_bug.cgi?id=172930
2146         <rdar://problem/32570201>
2147
2148         Reviewed by Youenn Fablet.
2149
2150         Some web platform tests need to be run from an HTTPS server in order to exercise functionality
2151         that is conditioned on the page being delivered over a secure protocol. One example of such
2152         a test is LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/secure_context/crypto-subtle-secure-context-available.https.sub.html.
2153
2154         Ideally we should look to use wptrunner to run Web Platform Tests. For now, modify run-webkit-tests
2155         to access web platform tests from an HTTPS server when the filename of the test contains ".https.".
2156         This makes run-webkit-test match the behavior of wptrunner: <https://github.com/w3c/web-platform-tests/blob/7ce469d1c46dd45aacfe1b408bf2ad36a630e089/tools/manifest/item.py#L42>.
2157
2158         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2159         (https_base_url): Parses the Web Platform Tests JSON configuration and returns the base URL
2160         to the Web Platform Tests HTTPS server.
2161         * Scripts/webkitpy/port/base.py:
2162         (Port.to.web_platform_test_server_https_base_url): Turns around and calls https_base_url().
2163         * Scripts/webkitpy/port/driver.py:
2164         (Driver.__init__): Caches the base URL to the Web Platform Tests HTTPS server. Also rename
2165         instance variables web_platform_test_server_doc_root, web_platform_test_server_base_url to
2166         _web_platform_test_server_doc_root and _web_platform_test_server_base_url, respectively to
2167         indicate that they should be considered private instance variables.
2168         (Driver.is_web_platform_test): Update code for renamed instance variables.
2169         (Driver):
2170         (Driver._web_platform_test_base_url_for_test): Returns the URL to access the specified test.
2171         (Driver.test_to_uri): Modified to use Driver._web_platform_test_base_url_for_test() to
2172         determine the base URL to use to access the test.
2173         (Driver.uri_to_test): Added logic to compute the filesystem local test name from a Web
2174         Platform Tests HTTPS URL. Also updated code for renamed instance variables.
2175
2176 2017-06-07  Per Arne Vollan  <pvollan@apple.com>
2177
2178         Support removal of authentication data through the Website data store API.
2179         https://bugs.webkit.org/show_bug.cgi?id=171217
2180
2181         Reviewed by Brady Eidson.
2182
2183         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2184         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2185         (WTR::InjectedBundle::didReceiveMessageToPage):
2186         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2187         (WTR::TestRunner::removeAllSessionCredentials):
2188         (WTR::TestRunner::callDidRemoveAllSessionCredentialsCallback):
2189         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2190         * WebKitTestRunner/TestController.h:
2191         * WebKitTestRunner/TestInvocation.cpp:
2192         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2193         (WTR::TestInvocation::didRemoveAllSessionCredentials):
2194         * WebKitTestRunner/TestInvocation.h:
2195         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2196         (WTR::TestController::removeAllSessionCredentials):
2197
2198 2017-06-07  Charlie Turner  <cturner@igalia.com>
2199
2200         Add Charlie Turner as contributor
2201         https://bugs.webkit.org/show_bug.cgi?id=173055
2202
2203         Reviewed by Carlos Alberto Lopez Perez.
2204
2205         I also ran the Tools/Scripts/validate-committer-lists --canonicalize command at the suggestion
2206         of webkit-patch upload, which reordered some fields and removed a newline.
2207
2208         * Scripts/webkitpy/common/config/contributors.json:
2209
2210 2017-06-06  Chris Dumez  <cdumez@apple.com>
2211
2212         RELEASE_ASSERT(static_cast<size_t>(enumerationValue) < WTF_ARRAY_LENGTH(values)) hit in convertEnumerationToJS<WebCore::History::ScrollRestoration>()
2213         https://bugs.webkit.org/show_bug.cgi?id=173033
2214         <rdar://problem/32591099>
2215
2216         Reviewed by Simon Fraser.
2217
2218         Add API test coverage to make sure History's scrollRestoration is properly saved / restored via the
2219         WKPageCopySessionState() / WKPageRestoreFromSessionState() C API.
2220
2221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2222         * TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp: Added.
2223         (TestWebKitAPI::didFinishLoadForFrame):
2224         (TestWebKitAPI::setPageLoaderClient):
2225         (TestWebKitAPI::createSessionStateDataContainingScrollRestoration):
2226         (TestWebKitAPI::TEST):
2227
2228 2017-06-06  Andy Estes  <aestes@apple.com>
2229
2230         REGRESSION (r199558): WKWebView upload file which name contains Chinese character results in garbled code
2231         https://bugs.webkit.org/show_bug.cgi?id=172849
2232         <rdar://problem/32567454>
2233
2234         Reviewed by Darin Adler.
2235
2236         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2237         * TestWebKitAPI/Tests/WebKit2Cocoa/RunOpenPanel.mm: Added.
2238         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
2239         (TestWebKitAPI::TEST):
2240
2241 2017-06-06  Yoav Weiss  <yoav@yoav.ws>
2242
2243         [preload] Conditional support for media preloading and align media `as` values.
2244         https://bugs.webkit.org/show_bug.cgi?id=172501
2245
2246         Reviewed by Dean Jackson.
2247
2248         Turn on media preloading preference for tests.
2249
2250         * DumpRenderTree/mac/DumpRenderTree.mm: Turn on media preloading preference.
2251         * DumpRenderTree/win/DumpRenderTree.cpp: Turn on media preloading preference.
2252         * WebKitTestRunner/TestController.cpp: Turn on media preloading preference.
2253
2254 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2255
2256         webkitpy: Return correct process names from SimulatorProcess
2257         https://bugs.webkit.org/show_bug.cgi?id=172940
2258
2259         Reviewed by Aakash Jain.
2260
2261         * Scripts/webkitpy/port/darwin.py:
2262         (DarwinPort.plist_data_from_bundle): Share plist access code for accessing different plist entries.
2263         (DarwinPort.app_identifier_from_bundle): Use plist_data_from_bundle.
2264         (DarwinPort.app_executable_from_bundle): Access name of app executable from provided app bundle.
2265         * Scripts/webkitpy/port/driver.py:
2266         (Driver.has_crashed): Use _server_process.process_name() instead of _server_process.name() since
2267         _server_process.name() will not return the correct process name for iOS.
2268         (Driver._check_for_driver_crash_or_unresponsiveness): Ditto.
2269         (Driver._read_block): Ditto.
2270         * Scripts/webkitpy/port/driver_unittest.py:
2271         (DriverTest.test_check_for_driver_crash.FakeServerProcess.process_name): Update since Driver uses
2272         process_name() instead of name().
2273         * Scripts/webkitpy/port/server_process.py:
2274         (ServerProcess._start): Use process_name() instead of name().
2275         (ServerProcess.stop): Ditto.
2276         (ServerProcess.name): Deleted.
2277         * Scripts/webkitpy/port/simulator_process.py:
2278         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2279
2280 2017-06-06  Dean Johnson  <dean_johnson@apple.com>
2281
2282         test-webkitpy: stop forking unsafely from within a spawned process
2283         https://bugs.webkit.org/show_bug.cgi?id=172774
2284
2285         Reviewed by Darin Adler.
2286
2287         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2288         (Builder.__init__): We don't use mechanize.Browser() as part of testing, so only initialize it when
2289         it's going to be used.
2290         (Builder.force_build):
2291
2292 2017-06-06  Jonathan Bedard  <jbedard@apple.com>
2293
2294         webkitpy: Process crash-logs for iOS devices
2295         https://bugs.webkit.org/show_bug.cgi?id=171976
2296         <rdar://problem/32134551>
2297
2298         Reviewed by David Kilzer.
2299
2300         When running layout tests on an iOS device, crash logs should be processed.
2301         Implement crash log searching and parsing for iOS devices.
2302
2303         * Scripts/webkitpy/common/system/crashlogs.py:
2304         (CrashLogs): Moved process regular expression for Darwin to class variable.
2305         (CrashLogs.__init__): Accept optional list of crash logs to ignore.
2306         (CrashLogs.find_newest_log): Add iOS as a potential platform.
2307         (CrashLogs.find_all_logs): Ditto.
2308         (CrashLogs._parse_darwin_crash_log): Share code for parsing of Darwin crash logs.
2309         Do not assume that a Darwin crash log starts with the process.
2310         (CrashLogs._find_newest_log_darwin): Remove .app in process name for iOS, use
2311         shared code for parsing Darwin crash logs.
2312         (CrashLogs._find_newest_log_darwin.is_crash_log): Skip crash logs passed into this
2313         object so that crash logs already on the system before testing are not parsed.
2314         (CrashLogs._find_newest_log_win.is_crash_log): Ditto.
2315         (CrashLogs._find_all_logs_darwin.is_crash_log): Ditto.
2316         (CrashLogs._find_all_logs_darwin): Use shared code for parsing Darwin crash logs.
2317         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2318         (make_mock_crash_report_darwin): Crash logs may not have their process on the first line.
2319         * Scripts/webkitpy/common/system/systemhost.py:
2320         (SystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2321         systems is just the crashlog, use this behavior by default.
2322         * Scripts/webkitpy/common/system/systemhost_mock.py:
2323         (MockSystemHost.symbolicate_crash_log_if_needed): The symbolicated crash log for most
2324         systems is just the crashlog, use this behavior by default.
2325         * Scripts/webkitpy/port/apple.py:
2326         (ApplePort): Add a dictionary mapping hosts to a list of crash logs to be skipped.
2327         (ApplePort.setup_test_run): Set the list of crash logs to be skipped to the crash logs on
2328         the system before testing begins
2329         * Scripts/webkitpy/port/base.py:
2330         (Port._get_crash_log): Pass optional target host when getting crash logs.
2331         * Scripts/webkitpy/port/darwin.py:
2332         (DarwinPort._look_for_all_crash_logs_in_log_dir): Pass list of crash logs to be skipped to
2333         CrashLogs object.
2334         (DarwinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2335         logs to be skipped to CrashLogs object.
2336         * Scripts/webkitpy/port/darwin_testcase.py:
2337         (DarwinTest.test_get_crash_log): Removed unused local function.
2338         (DarwinTest.test_get_crash_log.fake_time_cb): Deleted.
2339         * Scripts/webkitpy/port/device.py:
2340         (Device.symbolicate_crash_log_if_needed): If the platform device has a function with this
2341         name, call it. Otherwise, assume the default behavior and read the file at the provided path.
2342         * Scripts/webkitpy/port/driver.py:
2343         (Driver._get_crash_log): Pass optional target host when getting crash logs.
2344         * Scripts/webkitpy/port/gtk.py:
2345         (GtkPort._get_crash_log): Pass optional target host when getting crash logs.
2346         * Scripts/webkitpy/port/ios.py: Ditto.
2347         (IOSPort.setup_test_run): Each device is treated as an independent host. Set the list of crash logs
2348         to be skipped for each host.
2349         * Scripts/webkitpy/port/ios_device.py:
2350         (IOSDevicePort.path_to_crash_logs): Consult apple_additions for the path to crash logs.
2351         (IOSDevicePort._look_for_all_crash_logs_in_log_dir): Search every connected device for
2352         crash logs and pass list of crash logs to ignore to each instance of CrashLogs.
2353         (IOSDevicePort._get_crash_log): Search the specified target host for a crash log if a target
2354         host is specified. Else, search all connected devices for the specified crash-log.
2355         (IOSDevicePort.look_for_new_crash_logs): Deleted.
2356         * Scripts/webkitpy/port/ios_device_unittest.py:
2357         (IOSDeviceTest.test_crashlog_path): Without apple_additions, an exception should be raised.
2358         (IOSDeviceTest.test_get_crash_log): Ditto.
2359         * Scripts/webkitpy/port/simulator_process.py:
2360         (SimulatorProcess.process_name): Check the provided bundle for the process name.
2361         * Scripts/webkitpy/port/win.py:
2362         (WinPort._get_crash_log): Pass optional target host when getting crash logs, pass list of crash
2363         logs to be skipped to CrashLogs object.
2364         * Scripts/webkitpy/port/wpe.py:
2365         (WPEPort._get_crash_log): Pass optional target host when getting crash logs.
2366
2367 2017-06-06  David Kilzer  <ddkilzer@apple.com>
2368
2369         Move WTF_ATTRIBUTE_PRINTF() from implementation to declaration
2370         <https://webkit.org/b/172804>
2371
2372         Reviewed by Darin Adler.
2373
2374         WTF_ATTRIBUTE_PRINTF() only works outside the current
2375         compilation unit if it's on the declaration, not the
2376         implementation, of a function or class method.
2377
2378         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2379         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2380         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2381         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2382         - Move WTF_ATTRIBUTE_PRINTF() macro to declaration.
2383         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2384         - Remove redundant CRASH() macro definition.  Use the one from
2385           <wtf/Assertions.h> instead.
2386
2387 2017-06-06  Joseph Pecoraro  <pecoraro@apple.com>
2388
2389         Move Resource Timing / User Timing from experimental features into main preferences
2390         https://bugs.webkit.org/show_bug.cgi?id=172950
2391
2392         Reviewed by Darin Adler.
2393
2394         * DumpRenderTree/mac/DumpRenderTree.mm:
2395         (enableExperimentalFeatures):
2396         (resetWebPreferencesToConsistentValues):
2397         * DumpRenderTree/win/DumpRenderTree.cpp:
2398         (enableExperimentalFeatures):
2399         (resetWebPreferencesToConsistentValues):
2400         * WebKitTestRunner/TestController.cpp:
2401         (WTR::TestController::resetPreferencesToConsistentValues):
2402         Move out no longer experimental features to the main list.
2403
2404 2017-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2405
2406         [WPE] Add an install-dependencies script
2407         https://bugs.webkit.org/show_bug.cgi?id=172948
2408
2409         Reviewed by Žan Doberšek.
2410
2411         It is based on the gtk/install-dependencies script.
2412         Includes support for Debian based distrubutions, Fedora and Arch.
2413         It has been tested on a minimal Debian 9 chroot.
2414
2415         * wpe/install-dependencies: Added.
2416
2417 2017-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2418
2419         Refactor -[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:] to check readable types
2420         https://bugs.webkit.org/show_bug.cgi?id=172891
2421         <rdar://problem/32204540>
2422
2423         Reviewed by Darin Adler.
2424
2425         Adds 2 new API tests to exercise data interaction of HTML data and an attributed string into a rich
2426         contenteditable. See WebCore ChangeLog for more details.
2427
2428         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2429         (TestWebKitAPI::TEST):
2430
2431 2017-06-05  Daniel Bates  <dabates@apple.com>
2432
2433         webkitpy: Abstract Executive class
2434         https://bugs.webkit.org/show_bug.cgi?id=172928
2435         <rdar://problem/32569531>
2436
2437         Reviewed by Ryosuke Niwa.
2438
2439         Adds an AbstractExecutive class and makes Executive extend AbstractExecutive.
2440         This will make it straightforward to create additional derived classes that
2441         adhere to the same interface, say for iOS on-device testing.
2442
2443         * Scripts/webkitpy/common/system/abstractexecutive.py: Added.
2444         (AbstractExecutive):
2445         (AbstractExecutive.run_and_throw_if_fail):
2446         (AbstractExecutive.cpu_count):
2447         (AbstractExecutive.interpreter_for_script):
2448         (AbstractExecutive.shell_command_for_script):
2449         (AbstractExecutive.kill_process):
2450         (AbstractExecutive.check_running_pid):
2451         (AbstractExecutive.running_pids):
2452         (AbstractExecutive.wait_newest):
2453         (AbstractExecutive.wait_limited):
2454         (AbstractExecutive.interrupt):
2455         (AbstractExecutive.default_error_handler):
2456         (AbstractExecutive.ignore_error):
2457         (AbstractExecutive._stringify_args):
2458         (AbstractExecutive.command_for_printing):
2459         (AbstractExecutive.run_command):
2460         (AbstractExecutive.popen):
2461         (AbstractExecutive.run_in_parallel):
2462         * Scripts/webkitpy/common/system/executive.py:
2463         (Executive):
2464         (Executive.cpu_count):
2465         (Executive.running_pids):
2466         (Executive.kill_all):
2467         (Executive._compute_stdin):
2468         (Executive.interpreter_for_script): Deleted.
2469         (Executive.shell_command_for_script): Deleted.
2470         (Executive.wait_newest): Deleted.
2471         (Executive.wait_limited): Deleted.
2472         (Executive.default_error_handler): Deleted.
2473         (Executive.ignore_error): Deleted.
2474         (Executive.command_for_printing): Deleted.
2475
2476 2017-06-05  Jonathan Bedard  <jbedard@apple.com>
2477
2478         webkitpy: Add iOS to platform
2479         https://bugs.webkit.org/show_bug.cgi?id=172931
2480
2481         Reviewed by Daniel Bates.
2482
2483         * Scripts/webkitpy/common/system/platforminfo.py:
2484         PlatformInfo.__init__): Use platform_module.release() as the os_version for iOS device.
2485         (PlatformInfo.is_ios): Added.
2486         (PlatformInfo._determine_os_name): A platform name of 'ios' means that the os name is 'ios'.
2487         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2488         (MockPlatformInfo.is_ios): Added.
2489
2490 2017-06-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2491
2492         [WPE][JHBuild] Switch github repository from git:// to https://
2493         https://bugs.webkit.org/show_bug.cgi?id=172921
2494
2495         Reviewed by Alex Christensen.
2496
2497         * wpe/jhbuild.modules:
2498
2499 2017-06-05  Tim Horton  <timothy_horton@apple.com>
2500
2501         ASSERTION FAILED: m_currentScriptCallbackID in UIScriptContext::requestUIScriptCompletion(JSStringRef) running fast/events/ios/autocorrect-with-range-selection.html
2502         https://bugs.webkit.org/show_bug.cgi?id=172887
2503         <rdar://problem/32546061>
2504
2505         Reviewed by Sam Weinig.
2506
2507         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2508         (WTR::UIScriptController::applyAutocorrection):
2509         applyAutocorrection can call its completion handler synchronously,
2510         which makes UIScriptController unhappy (see bug 172884).
2511
2512 2017-06-03  Jonathan Bedard  <jbedard@apple.com>
2513
2514         webkitpy: Add contextmanager to disable logging for a block
2515         https://bugs.webkit.org/show_bug.cgi?id=172876
2516
2517         Reviewed by Daniel Bates.
2518
2519         Add a context manager which will use an OutputCapture object to capture logging
2520         in a block and hold it in a variable.
2521
2522         * Scripts/webkitpy/common/system/outputcapture.py:
2523         (OutputCaptureScope):
2524         (OutputCaptureScope.__init__): Construct with OutputCapture object.
2525         (OutputCaptureScope.__enter__): Begin capturing output. 
2526         (OutputCaptureScope.__exit__): Restore output and save captured output to a variable.
2527         output and retain the resulting log.
2528         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2529         (OutputCaptureTest.test_output_capture_scope): Added.
2530
2531 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2532
2533         Cleanup FrameView::autoSizeIfEnabled.
2534         https://bugs.webkit.org/show_bug.cgi?id=172889
2535         <rdar://problem/32550783>
2536
2537         Reviewed by Tim Horton.
2538
2539         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2540         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]): progression.
2541         (TEST):
2542
2543 2017-06-02  Chris Dumez  <cdumez@apple.com>
2544
2545         ResourceLoadStatistics are not using unique paths during test runs
2546         https://bugs.webkit.org/show_bug.cgi?id=172861
2547         <rdar://problem/32442251>
2548
2549         Reviewed by Darin Adler.
2550
2551         Make sure WebKitTestRunner sets a temporary path for saving resource
2552         load statistics.
2553
2554         * WebKitTestRunner/TestController.cpp:
2555         (WTR::TestController::generateContextConfiguration):
2556
2557 2017-06-02  Brady Eidson  <beidson@apple.com>
2558
2559         Prevent scheme handlers from handling all built-in URL schemes.
2560         <rdar://problem/32404790> and https://bugs.webkit.org/show_bug.cgi?id=172869
2561
2562         Reviewed by Andy Estes.
2563
2564         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
2565
2566 2017-06-02  Stephan Szabo  <stephan.szabo@am.sony.com>
2567
2568         [JSCOnly] Build static jsc.exe on Windows
2569         https://bugs.webkit.org/show_bug.cgi?id=172833
2570
2571         Reviewed by Konstantin Tokarev.
2572
2573         * CMakeLists.txt:
2574         * Scripts/build-jsc:
2575
2576 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2577
2578         Disable ViewportSizeForViewportUnits tests on iOS.
2579         https://bugs.webkit.org/show_bug.cgi?id=172872
2580
2581         Reviewed by Tim Horton.
2582
2583         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm:
2584
2585 2017-06-02  Zalan Bujtas  <zalan@apple.com>
2586
2587         Allow clients to override viewport size for CSS viewport units.
2588         https://bugs.webkit.org/show_bug.cgi?id=172838
2589         <rdar://problem/32523441>
2590
2591         Reviewed by Tim Horton.
2592
2593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2594         * TestWebKitAPI/Tests/WebKit2/ViewportSizeForViewportUnits.mm: Added.
2595         (TEST):
2596
2597 2017-06-02  Simon Fraser  <simon.fraser@apple.com>
2598
2599         Get <chrono> out of StdLibExtras.h
2600         https://bugs.webkit.org/show_bug.cgi?id=172744
2601
2602         Reviewed by Zalan Bujtas.
2603
2604         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2605
2606 2017-06-02  Zan Dobersek  <zdobersek@igalia.com>
2607
2608         [WPE] Enable SUBTLE_CRYPTO
2609         https://bugs.webkit.org/show_bug.cgi?id=172756
2610
2611         Reviewed by Michael Catanzaro.
2612
2613         * Scripts/webkitperl/FeatureList.pm: Set ENABLE_SUBTLE_CRYPTO to 1 for WPE.
2614         * wpe/jhbuild.modules: Add libgpg-error and libgcrypt dependencies.
2615         * wpe/patches/libgcrypt-use-only-dev-urandom-for-testing.patch: Added. Prevents
2616         exhausting entropy when running the crypto layout tests.
2617
2618 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2619
2620         [GTK] Bump GTK+ and its dependencies in jhbuild
2621         https://bugs.webkit.org/show_bug.cgi?id=171918
2622
2623         Reviewed by Carlos Alberto Lopez Perez.
2624
2625         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2626         (WTR::initializeGtkSettings):
2627         * gtk/jhbuild.modules:
2628         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Removed.
2629         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch: Removed.
2630
2631 2017-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2632
2633         [GTK] Bump wayland and weston in jhbuild
2634         https://bugs.webkit.org/show_bug.cgi?id=171921
2635
2636         Reviewed by Carlos Alberto Lopez Perez.
2637
2638         * gtk/jhbuild.modules:
2639         * gtk/patches/weston-libweston-include-weston-egl-ext.h-in-drm-x11-and-wa.patch: Added.
2640
2641 2017-06-01  Andy Estes  <aestes@apple.com>
2642
2643         REGRESSION (r217626): ENABLE_APPLE_PAY_SESSION_V3 was disabled by mistake
2644         https://bugs.webkit.org/show_bug.cgi?id=172828
2645
2646         Reviewed by Beth Dakin.
2647
2648         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2649
2650 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2651
2652         webkitpy: Remove unneeded simulator teardown
2653         https://bugs.webkit.org/show_bug.cgi?id=171891
2654
2655         Reviewed by Aakash Jain.
2656
2657         * Scripts/webkitpy/port/ios_simulator.py:
2658         (IOSSimulatorPort.clean_up_test_run): Remove FIFO deletion since TCP is used
2659         for communication between Python and WebKitTestRunner/DumpRenderTree.
2660
2661 2017-06-01  Keith Miller  <keith_miller@apple.com>
2662
2663         Undo rollout in r217638 with bug fix
2664         https://bugs.webkit.org/show_bug.cgi?id=172824
2665
2666         Unreviewed, reland patch with unused set_state code removed.
2667
2668         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2669         (runThreadMessageTest):
2670         (TEST):
2671
2672 2017-06-01  Jonathan Bedard  <jbedard@apple.com>
2673
2674         webkitpy: Do not send 0 or -1 as a pid to kill_process
2675         https://bugs.webkit.org/show_bug.cgi?id=172818
2676
2677         Reviewed by Darin Adler.
2678
2679         Sending a signal to process 0 will result in all processes in the group receiving 
2680         the signal. Sending a signal to process -1 will result in all non-system processes
2681         receiving the signal. Both Executive.kill_process and Executive.check_running_pid
2682         should consider these cases
2683
2684         * Scripts/webkitpy/common/system/executive.py:
2685         (Executive.kill_process): Throw exception if pid is undefined, 0 or negative.
2686         (Executive.check_running_pid): An undefined pid, pid 0 or a negative pid will
2687         never be running, although os.kill may succeed.
2688         * Scripts/webkitpy/port/simulator_process.py:
2689         (SimulatorProcess.stop): Do not kill process if it is undefined.
2690
2691 2017-05-31  Alexey Proskuryakov  <ap@apple.com>
2692
2693         JSC EWS bot does not run on WTF only patches
2694         https://bugs.webkit.org/show_bug.cgi?id=172777
2695         rdar://problem/32495975
2696
2697         Reviewed by Aakash Jain.
2698
2699         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
2700         (CheckPatchRelevance): Add a missing comma.
2701
2702 2017-05-31  Commit Queue  <commit-queue@webkit.org>
2703
2704         Unreviewed, rolling out r217611 and r217631.
2705         https://bugs.webkit.org/show_bug.cgi?id=172785
2706
2707         "caused wasm-hashset-many.html to become flaky." (Requested by
2708         keith_miller on #webkit).
2709
2710         Reverted changesets:
2711
2712         "Reland r216808, underlying lldb bug has been fixed."
2713         https://bugs.webkit.org/show_bug.cgi?id=172759
2714         http://trac.webkit.org/changeset/217611
2715
2716         "Use dispatch queues for mach exceptions"
2717         https://bugs.webkit.org/show_bug.cgi?id=172775
2718         http://trac.webkit.org/changeset/217631
2719
2720 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2721
2722         EWS bots should reboot themselves more frequently
2723         https://bugs.webkit.org/show_bug.cgi?id=172402
2724
2725         Reviewed by Alexey Proskuryakov.
2726
2727         Instead of rebooting once a day, EWS bots will reboot after running 10 iterations.
2728
2729         * EWSTools/start-queue-mac.sh: Remove the restriction placed on the time that the bot will perform a reboot.
2730
2731 2017-05-31  Ryan Haddad  <ryanhaddad@apple.com>
2732
2733         Reallocate hardware for iOS bots.
2734         https://bugs.webkit.org/show_bug.cgi?id=172657
2735
2736         Reviewed by Alexey Proskuryakov.
2737
2738         * BuildSlaveSupport/build.webkit.org-config/config.json:
2739
2740 2017-05-31  Andy Estes  <aestes@apple.com>
2741
2742         Rename ENABLE_APPLE_PAY_DELEGATE to ENABLE_APPLE_PAY_SESSION_V3 and bump the supported version number
2743         https://bugs.webkit.org/show_bug.cgi?id=172366
2744
2745         Reviewed by Daniel Bates.
2746
2747         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2748
2749 2017-05-31  Jiewen Tan  <jiewen_tan@apple.com>
2750
2751         Unreviewed, add Jiewen Tan as a reviewer
2752
2753         * Scripts/webkitpy/common/config/contributors.json:
2754
2755 2017-05-31  Adrian Perez de Castro  <aperez@igalia.com>
2756
2757         [GTK] MiniBrowser's browser_window_get_or_create_web_view_for_automation never creates new windows
2758         https://bugs.webkit.org/show_bug.cgi?id=172770
2759
2760         Reviewed by Michael Catanzaro.
2761
2762         * MiniBrowser/gtk/BrowserWindow.c:
2763         (browser_window_get_or_create_web_view_for_automation): Removed stray semicolon
2764         which caused the body of the if-clause to be accidentally empty.
2765
2766 2017-05-31  Keith Miller  <keith_miller@apple.com>
2767
2768         Reland r216808, underlying lldb bug has been fixed.
2769         https://bugs.webkit.org/show_bug.cgi?id=172759
2770
2771         Unreviewed, relanding old patch. See: rdar://problem/31183352
2772
2773         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
2774         (runThreadMessageTest):
2775         (TEST):
2776
2777 2017-05-31  Matt Lewis  <jlewis3@apple.com>
2778
2779         Unreviewed, rolling out r217603.
2780
2781         This patch broke the internal builds.
2782
2783         Reverted changeset:
2784
2785         "Get <chrono> out of StdLibExtras.h"
2786         https://bugs.webkit.org/show_bug.cgi?id=172744
2787         http://trac.webkit.org/changeset/217603
2788
2789 2017-05-31  Brent Fulgham  <bfulgham@apple.com>
2790
2791         Make ResourceLoadStatistics testing more reliable
2792         https://bugs.webkit.org/show_bug.cgi?id=172730
2793         <rdar://problem/32028373>
2794
2795         Reviewed by Andy Estes.
2796
2797         When we tell the UIProcess (WebKitTestRunner) to notify the system about statistics update notifications,
2798         we also need to tell the WebProcess to do so, too, or else the test system doesn't get messages.
2799
2800         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2801         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2802
2803 2017-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2804
2805         [GTK][WPE] run-javascriptcore-tests should use the jhbuild
2806         https://bugs.webkit.org/show_bug.cgi?id=172757
2807
2808         Reviewed by Xabier Rodriguez-Calvar.
2809
2810         When needed, add the jhbuild wrapper at the beginning of the array
2811         that will be invoked to execute the run-jsc-stress-test or testapi
2812         commands.
2813
2814         * Scripts/run-javascriptcore-tests:
2815         (runJSCStressTests):
2816         * Scripts/webkitdirs.pm:
2817         (shouldUseJhbuild):
2818
2819 2017-05-31  Simon Fraser  <simon.fraser@apple.com>
2820
2821         Get <chrono> out of StdLibExtras.h
2822         https://bugs.webkit.org/show_bug.cgi?id=172744
2823
2824         Reviewed by Saam Barati.
2825
2826         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2827
2828 2017-05-30  Tim Horton  <timothy_horton@apple.com>
2829
2830         Keyboard autocorrections do not apply with an active selection (but keyboard acts like they did)
2831         https://bugs.webkit.org/show_bug.cgi?id=172735
2832         <rdar://problem/32015977>
2833
2834         Reviewed by Enrica Casucci.
2835
2836         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2837         (WTR::UIScriptController::applyAutocorrection):
2838         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2839         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2840         (WTR::UIScriptController::applyAutocorrection):
2841         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2842         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2843         (WTR::UIScriptController::applyAutocorrection):
2844         Expose applyAutocorrection to UIScriptController. Use a WKTesting method
2845         because I don't know how to tap the button in the autocorrection bar from a test.
2846
2847 2017-05-30  Daniel Bates  <dabates@apple.com>
2848
2849         Add unit test for WebKit2 C SPI runBeforeUnloadConfirmPanel()
2850         https://bugs.webkit.org/show_bug.cgi?id=172671
2851
2852         Reviewed by Alex Christensen.
2853
2854         We should add a unit test to ensure we do not regress the WKPageUIClient runBeforeUnloadConfirmPanel() callback.
2855         For completeness, the callback runBeforeUnloadConfirmPanel() existed since inception of WKPageUIClient (WKPageUIClientV0).
2856
2857         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2858         (TestWebKitAPI::analyzeDialogArguments): Test the runBeforeUnloadConfirmPanel() callback last as we need
2859         to trigger a navigation to test it.
2860         (TestWebKitAPI::runBeforeUnloadConfirmPanel): Added.
2861         (TestWebKitAPI::createNewPage): Wire up the runBeforeUnloadConfirmPanel callback.
2862
2863 2017-05-30  Jonathan Bedard  <jbedard@apple.com>
2864
2865         webkitpy: Start servers before setting-up for testing
2866         https://bugs.webkit.org/show_bug.cgi?id=172176
2867         <rdar://problem/32225538>
2868
2869         Reviewed by Alexey Proskuryakov.
2870
2871         On-device testing requires that servers are started before ports set-up their
2872         test environments.
2873
2874         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2875         (LayoutTestRunner.__init__): Start servers when initializing LayoutTestRunner.
2876         Servers are unconditionally stopped on exit.
2877         (LayoutTestRunner.run_tests): Move the starting of servers to the initializer. The
2878         Manager now stops servers.
2879         (LayoutTestRunner.start_servers): Set flag to indicate servers are running.
2880         (LayoutTestRunner.stop_servers): Check flag, only shutdown servers if they are shutdown.
2881         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2882         (Manager.__init__): Delay construction of the test runner until we can determine
2883         if servers need to be started.
2884         (Manager.run): Determine if servers need to be started and construct the test runner.
2885         Shut servers down when the test run is finished.
2886         (Manager._run_tests): Move the determination of servers to run into Manager.run.
2887         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2888         (is_wpt_server_running): Server is not running if no config is found.
2889         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2890         (PyWebSocket.is_running): Check if this WebSocket server is running.
2891         * Scripts/webkitpy/port/base.py:
2892         (Port.__init__): Define secure WebSocket server.
2893         (Port.to.is_websocket_server_running): Check if WebSocket servers are defined.
2894
2895 2017-05-30  Daniel Bates  <dabates@apple.com>
2896
2897         [WK2] Add runBeforeUnloadConfirmPanel WKUIDelegate SPI; support onbeforeunload confirm panel in MiniBrowser
2898         https://bugs.webkit.org/show_bug.cgi?id=172603
2899         <rdar://problem/32471306>
2900
2901         Reviewed by Brady Eidson.
2902
2903         Implement the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: delegate
2904         method in MiniBrowser to show a confirm panel as to whether to allow the unloading of the page when
2905         unloading is initiated for a page that registered a onbeforeunload handler.
2906
2907         Modify TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm to test that the -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:
2908         is called. Also fix style nit; pass YES instead of true to avoid implicit conversion from bool to BOOL
2909         when invoking the completion handler in -_webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:.
2910
2911         Until we fix <https://bugs.webkit.org/show_bug.cgi?id=172614> the unit test in TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm
2912         for -_webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler: is only run on Mac
2913         as we do not have the infrastructure to simulate a click/tap on iOS and a click/tap on the page that
2914         registered an onbeforeunload handler is required to show a confirm panel when the page will be unloaded.
2915
2916         * MiniBrowser/mac/WK2BrowserWindowController.m:
2917         (-[WK2BrowserWindowController _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2918         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html:
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm:
2920         (sawDialog):
2921         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2922         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2923         (-[ModalAlertsUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2924
2925 2017-05-30  Alex Christensen  <achristensen@webkit.org>
2926
2927         Update libwebrtc configuration
2928         https://bugs.webkit.org/show_bug.cgi?id=172727
2929
2930         Reviewed by Geoffrey Garen.
2931
2932         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2933
2934 2017-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
2935
2936         [WinCairo] TestWebKitAPI: ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY
2937         https://bugs.webkit.org/show_bug.cgi?id=172702
2938
2939         Reviewed by Alex Christensen.
2940
2941         EGL PlatformDisplay needs to be shut down before existing a
2942         program on Windows.
2943
2944         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp:
2945         (TestWebKitAPI::ScaleWebView::TearDown): Call shutDownWebKit().
2946         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
2947         (TestWebKitAPI::WebViewDestruction::TearDown): Ditto.
2948
2949 2017-05-30  Per Arne Vollan  <pvollan@apple.com>
2950
2951         [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
2952         https://bugs.webkit.org/show_bug.cgi?id=172709
2953
2954         Reviewed by Brent Fulgham.
2955
2956         Exit fullscreen mode after a fullscreen test.
2957
2958         * DumpRenderTree/win/DumpRenderTree.cpp:
2959         (resetWebViewToConsistentStateBeforeTesting):
2960
2961 2017-05-30  Antti Koivisto  <antti@apple.com>
2962
2963         ASSERTION FAILED: !needsLayout() in com.apple.WebCore: WebCore::FrameView::paintContents in fast/events/tabindex-focus-blur-all.html on WK1
2964         https://bugs.webkit.org/show_bug.cgi?id=172713
2965
2966         Reviewed by Zalan Bujtas.
2967
2968         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2969         (-[ResourceLoadDelegate webView:plugInFailedWithError:dataSource:]):
2970
2971             Remove forced display from plugin resource load delegate. It is testing some long-obsolete
2972             Safari WK1 behavior. Forcing display from this resource load delegate will hit the assertion
2973             because on Mac WK1 it may get invoked from middle of a layout.
2974
2975             Painting code skips out after the assert so it doesn't indicate unsafe access of any sort.
2976
2977 2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2978
2979         Add a WPE EWS queue
2980         https://bugs.webkit.org/show_bug.cgi?id=172693
2981
2982         Reviewed by Carlos Garcia Campos.
2983
2984         * QueueStatusServer/config/queues.py:
2985         * QueueStatusServer/model/queues.py: Capitalize the name of the
2986         port on the tooltip of the bubbles. Do the same for the GTK port.
2987         (Queue.display_name):
2988         * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
2989         for the GTK+ EWS also. Set for both ports as watcher the alias
2990         bugs-noreply@webkitgtk.org that maintainers of both ports follow.
2991         * Scripts/webkitpy/common/config/ports.py:
2992         (DeprecatedPort.port):
2993         (WpePort):
2994         (WpePort.build_webkit_command):
2995         (WpePort.run_webkit_tests_command):
2996         * Scripts/webkitpy/common/config/ports_unittest.py:
2997         (DeprecatedPortTest):
2998         (DeprecatedPortTest.test_wpe_port):
2999         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3000         (test_ews_name):
3001
3002 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
3003
3004         Unreviewed. Bumping the WPEBackend-mesa dependency version.
3005
3006         * wpe/jhbuild.modules: Use the latest version that uses proper GLib
3007         priorities for IPC communication.
3008
3009 2017-05-27  Yusuke Suzuki  <utatane.tea@gmail.com>
3010
3011         [JSC] Map and Set constructors should have fast path for cloning
3012         https://bugs.webkit.org/show_bug.cgi?id=172413
3013
3014         Reviewed by Saam Barati.
3015
3016         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3017         (TestWebKitAPI::TEST):
3018
3019 2017-05-27  Zalan Bujtas  <zalan@apple.com>
3020
3021         enclosingIntRect returns a rect with -1 width/height when the input FloatRect overflows integer.
3022         https://bugs.webkit.org/show_bug.cgi?id=172676
3023
3024         Reviewed by Simon Fraser.
3025
3026         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3027         (TestWebKitAPI::TEST):
3028
3029 2017-05-26  Zalan Bujtas  <zalan@apple.com>
3030
3031         TestWebKitAPI: EnclosingIntRect and RoundedIntRect should use EXPECT_EQ.
3032         https://bugs.webkit.org/show_bug.cgi?id=172674
3033
3034         Reviewed by Simon Fraser.
3035
3036         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
3037         (TestWebKitAPI::TEST):
3038
3039 2017-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3040
3041         Add test resources back into TestWebKitAPI Copy Resources phase
3042
3043         Rubber-stamped by Beth Dakin.
3044
3045         Add two files back into the Copy Resources phase after they were unintentionally
3046         removed in r217447 and r217496.
3047
3048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3049
3050 2017-05-26  Beth Dakin  <bdakin@apple.com>
3051
3052         Media documents inside iframes should not get controls in the TouchBar unless the 
3053         video is playing
3054         https://bugs.webkit.org/show_bug.cgi?id=172620
3055         -and corresponding-
3056         rdar://problem/32165477
3057
3058         Reviewed by Jon Lee.
3059
3060         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3061         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3062         (TestWebKitAPI::TEST):
3063         * TestWebKitAPI/Tests/WebKit2Cocoa/offscreen-iframe-of-media-document.html: Added.
3064
3065 2017-05-25  Joseph Pecoraro  <pecoraro@apple.com>
3066
3067         _WKUserStyleSheet and WKUserScript leak string data
3068         https://bugs.webkit.org/show_bug.cgi?id=172583
3069         <rdar://problem/32395209>
3070
3071         Reviewed by Sam Weinig.
3072
3073         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3074         We should not have been adopting an autoreleased object.
3075
3076 2017-05-25  Myles C. Maxfield  <mmaxfield@apple.com>
3077
3078         [WK1] iframes in layer-backed NSViews are not cleared between successive draws
3079         https://bugs.webkit.org/show_bug.cgi?id=172554
3080         <rdar://problem/31247133>
3081
3082         Reviewed by Simon Fraser.
3083
3084         Previously, there was no way to make DumpRenderTree's views layer-backed. Unfortunately,
3085         simply setting [WebView setWantsLayer:] is insufficient; turning it on and then off again
3086         leaves some state around inside the NSWindow which isn't easily cleaned up. Instead,
3087         we should just tear down and rebuild the window whenever we need a layer-backed WebView.
3088         We can also use the "webkit-test-runner" header comment to trigger this new layer-backed
3089         codepath.
3090
3091         * DumpRenderTree/TestOptions.h:
3092         * DumpRenderTree/TestOptions.mm:
3093         (TestOptions::TestOptions):
3094         (TestOptions::webViewIsCompatibleWithOptions):
3095         * DumpRenderTree/mac/DumpRenderTree.mm:
3096         (shouldIgnoreWebCoreNodeLeaks):
3097         (allowedFontFamilySet):
3098         (-[DRTMockScroller rectForPart:]):
3099         (-[DRTMockScroller drawKnob]):
3100         (-[DRTMockScroller drawRect:]):
3101         (createWebViewAndOffscreenWindow):
3102         (initializeGlobalsFromCommandLineOptions):
3103         (prepareConsistentTestingEnvironment):
3104         (dumpRenderTree):
3105         (dumpAudio):
3106         (dumpHistoryItem):
3107         (dumpBackForwardListForWebView):
3108         (resetWebViewToConsistentStateBeforeTesting):
3109         (WebThreadLockAfterDelegateCallbacksHaveCompleted):
3110         (runTest):
3111
3112 2017-05-25  Sam Weinig  <sam@webkit.org>
3113
3114         [WebIDL] Use the term 'operation' more consistently
3115         https://bugs.webkit.org/show_bug.cgi?id=172601
3116
3117         Reviewed by Chris Dumez.
3118
3119         We were using the term 'operation', a WebIDL term for function-like
3120         constructs, inconsistently in the code generator. Now, when we use
3121         'operation' when referring to the IDL concept (usually the object the
3122         parser produces) and 'function' when referring to code being generated.
3123
3124         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
3125         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3126
3127 2017-05-25  Jer Noble  <jer.noble@apple.com>
3128
3129         Unreviewed build fix after r217447; only run test where JSC's ObjC API is available.
3130
3131         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
3132
3133 2017-05-25  Jer Noble  <jer.noble@apple.com>
3134
3135         System sleeps while playing to wireless target, ending stream.
3136         https://bugs.webkit.org/show_bug.cgi?id=172541
3137
3138         Reviewed by Eric Carlson.
3139
3140         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3141         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.html: Added.
3142         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Added.
3143         (-[MediaPlaybackSleepAssertionLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3144         (-[MediaPlaybackSleepAssertionPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
3145         (TestWebKitAPI::simulateKeyDown):
3146         (TestWebKitAPI::hasAssertionType):
3147         (TestWebKitAPI::TEST):
3148
3149 2017-05-25  Commit Queue  <commit-queue@webkit.org>
3150
3151         Unreviewed, rolling out r217423 and r217424.
3152         https://bugs.webkit.org/show_bug.cgi?id=172607
3153
3154         These caused an api failure on all testers. (Requested by
3155         mlewis13 on #webkit).
3156
3157         Reverted changesets:
3158
3159         "REGRESSION (r216977): 4 leaks introduced in new
3160         WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test"
3161         https://bugs.webkit.org/show_bug.cgi?id=172558
3162         http://trac.webkit.org/changeset/217423
3163
3164         "REGRESSION (r217423): Fix last-second typo in 'auto'"
3165         http://trac.webkit.org/changeset/217424
3166
3167 2017-05-25  Joanmarie Diggs  <jdiggs@igalia.com>
3168
3169         [ATK] Expose doc-footnote ARIA role with ATK_ROLE_FOOTNOTE
3170         https://bugs.webkit.org/show_bug.cgi?id=172355
3171
3172         Reviewed by Chris Fleizach.
3173
3174         Add map ATK_ROLE_FOOTNOTE to "AXFootnote" and bump jhbuild minimum
3175         versions of atk, at-spi2-core, and at-spi2-atk to 2.25.2 (the earliest
3176         releases which support the new platform footnote accessibility role.
3177
3178         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3179         * gtk/jhbuild.modules:
3180
3181 2017-05-25  David Kilzer  <ddkilzer@apple.com>
3182
3183         REGRESSION (r217423): Fix last-second typo in 'auto'
3184
3185         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3186         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix typo.
3187
3188 2017-05-24  David Kilzer  <ddkilzer@apple.com>
3189
3190         REGRESSION (r216977): 4 leaks introduced in new WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test
3191         <https://webkit.org/b/172558>
3192
3193         Reviewed by Sam Weinig.
3194
3195         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3196         (WebKit2_WKHTTPCookieStoreWithoutProcessPool_Test): Fix the leaks.
3197
3198 2017-05-24  Don Olmstead  <don.olmstead@am.sony.com>
3199
3200         [CMake] Consolidate CMake code related to Cairo
3201         https://bugs.webkit.org/show_bug.cgi?id=172568
3202
3203         Reviewed by Alex Christensen.
3204
3205         * DumpRenderTree/config.h:
3206         * TestWebKitAPI/config.h:
3207
3208 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3209
3210         Plumb additional image metadata to item providers when beginning data interaction on an image
3211         https://bugs.webkit.org/show_bug.cgi?id=172536
3212         <rdar://problem/32371300>
3213
3214         Reviewed by Beth Dakin.
3215
3216         Tweak existing image data interaction tests to check for suggested name and estimated size on the generated
3217         source item providers.
3218
3219         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3220         (checkSuggestedNameAndEstimatedSize):
3221         (TestWebKitAPI::TEST):
3222
3223 2017-05-24  Per Arne Vollan  <pvollan@apple.com>
3224
3225         [Win] Create unique network storage session for each DRT.
3226         https://bugs.webkit.org/show_bug.cgi?id=172540
3227
3228         Reviewed by Brent Fulgham.
3229
3230         During layout testing, each DRT instance should have its own network storage session.
3231
3232         * DumpRenderTree/win/DumpRenderTree.cpp:
3233         (prepareConsistentTestingEnvironment):
3234
3235 2017-05-24  Wenson Hsieh  <wenson_hsieh@apple.com>
3236
3237         Respect image UTIs when writing to item providers when beginning data interaction on an image
3238         https://bugs.webkit.org/show_bug.cgi?id=172436
3239         <rdar://problem/31786569>
3240
3241         Reviewed by Beth Dakin.
3242
3243         Tweaks existing unit tests and adds a new test for image data interaction. See WebCore ChangeLog for more
3244         details.
3245
3246         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3247         * TestWebKitAPI/Tests/WebKit2Cocoa/apple.gif: Added.
3248         * TestWebKitAPI/Tests/WebKit2Cocoa/gif-and-file-input.html: Added.
3249
3250         Create a new test page containing a GIF and a file input.
3251
3252         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3253         (checkTypeIdentifierIsRegisteredAtIndex):
3254         (TestWebKitAPI::TEST):
3255
3256 2017-05-23  Per Arne Vollan  <pvollan@apple.com>
3257
3258         [Win] Increase test timeout for slow tests.
3259         https://bugs.webkit.org/show_bug.cgi?id=172449
3260
3261         Reviewed by Alexey Proskuryakov.
3262
3263         Instead of using a fixed timeout of 30 seconds for all tests, we should use the
3264         timeout member in the TestRunner class.
3265
3266         * DumpRenderTree/win/TestRunnerWin.cpp:
3267         (TestRunner::setWaitToDump):
3268
3269 2017-05-15  Matt Rajca  <mrajca@apple.com>
3270
3271         Replace autoplay events that fire at navigation with a DidAutoplayMediaPastThreshold event.
3272         https://bugs.webkit.org/show_bug.cgi?id=172138
3273
3274         Reviewed by Alex Christensen.
3275
3276         Added API tests.
3277
3278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3279         * TestWebKitAPI/Tests/WebKit2/js-autoplay-audio.html: Added.
3280         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
3281         (TEST):
3282         * TestWebKitAPI/Tests/WebKit2Cocoa/silence-long.m4a: Added.
3283
3284 2017-05-23  Simon Fraser  <simon.fraser@apple.com>
3285
3286         Stop consulting -viewsNeedDisplay when doing layer flushing in WebKit1
3287         https://bugs.webkit.org/show_bug.cgi?id=172522
3288         rdar://problem/31071812
3289
3290         Reviewed by Sam Weinig.
3291
3292         Remove NSWindowStyleMaskFullSizeContentView which is no longer referenced in code.
3293         We set this in the .xib file now.
3294
3295         * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3296
3297 2017-05-22  Simon Fraser  <simon.fraser@apple.com>
3298
3299         Snapshotting via -renderInContext: should do synchronous image decodes
3300         https://bugs.webkit.org/show_bug.cgi?id=172485
3301         rdar://problem/32276146
3302
3303         Reviewed by Tim Horton.
3304
3305         New API test.
3306
3307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3308         * TestWebKitAPI/Tests/WebKit/ios/SnapshotViaRenderInContext.mm: Added.
3309         (-[RenderInContextWebViewDelegate webViewDidFinishLoad:]):
3310         (-[RenderInContextWebViewDelegate webView:didFailLoadWithError:]):
3311         (TestWebKitAPI::getPixelIndex):
3312         (TestWebKitAPI::TEST):
3313
3314 2017-05-23  Myles C. Maxfield  <mmaxfield@apple.com>
3315
3316         Remove dead ENABLE(FONT_LOAD_EVENTS) code
3317         https://bugs.webkit.org/show_bug.cgi?id=172517
3318
3319         Rubber-stamped by Simon Fraser.
3320
3321         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3322
3323 2017-05-23  Wenson Hsieh  <wenson_hsieh@apple.com>
3324
3325         Multiple links should be inserted separately when performing data interaction
3326         https://bugs.webkit.org/show_bug.cgi?id=172489
3327         <rdar://problem/31510832>
3328
3329         Reviewed by Dan Bernstein.
3330
3331         Adds a new test that performs data interaction in a contenteditable with multiple items containing URLs.
3332
3333         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3334         (TestWebKitAPI::TEST):
3335
3336 2017-05-23  Tim Horton  <timothy_horton@apple.com>
3337
3338         REGRESSION: API test WebKit2.WKObject is failing
3339         https://bugs.webkit.org/show_bug.cgi?id=172497
3340         <rdar://problem/31694641>
3341
3342         Reviewed by Geoff Garen.
3343
3344         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
3345         (TestWebKitAPI::TEST):
3346         Add a test that ensures that we pretend to at least be *some* kind of
3347         NSString, which my first fix would not have passed.
3348
3349 2017-05-23  youenn fablet  <youenn@apple.com>
3350
3351         There should be an easy way to run HTTP/WPT served tests on a browser
3352         https://bugs.webkit.org/show_bug.cgi?id=172068
3353
3354         Reviewed by Sam Weinig.
3355
3356         Adding a new script open-layout-test to open a layout-test in a
3357         browser and making sure it is served as done through run-webkit-tests.
3358         In case tests should be run using a server, detecting whether the
3359         server are running. If not, calling run-webkit-httpd to run the
3360         servers and open the URL in a browser.
3361         Otherwise, open directly the URL.
3362
3363         Adding an option in run-webkit-httpd to open an URL after having
3364         started the servers.
3365
3366         Adding the --no-http-servers option in run-webkit-tests to not start any HTTP server.
3367         This allows running run-webkit-httpd once and not having to restart
3368         servers everytime a test should be served.
3369
3370         Moving most of run-webkit-httpd logic in its own python file to reuse
3371         it in open-layout-test script.
3372
3373         Adding routines to check whether HTTP and WPT servers are running.
3374
3375         * Scripts/open-layout-test: Added.
3376         (parse_args):
3377         (main):
3378         * Scripts/run-webkit-httpd:
3379         (main):
3380         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
3381         (LayoutTestFinder.find_tests):
3382         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3383         (LayoutTestRunner.run_tests):
3384         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3385         (parse_args):
3386         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3387         (HttpServerBase._is_server_running_on_all_ports):
3388         (HttpServerBase):
3389         (HttpServerBase._is_running_on_port):
3390         (HttpServerBase._check_that_all_ports_are_available):
3391         (is_http_server_running):
3392         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py: Copied from Tools/Scripts/run-webkit-httpd.
3393         (parse_args):
3394         (main):
3395         (run_server):
3396         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3397         (is_wpt_server_running):
3398         * Scripts/webkitpy/port/base.py:
3399         (Port.to.is_http_server_running):
3400         (Port.to):
3401         (Port.to.is_wpt_server_running):
3402         (Port.to.start_web_platform_test_server):
3403         * Scripts/webkitpy/port/driver.py:
3404         (DriverProxy.is_web_platform_test):
3405         (DriverProxy):
3406         (DriverProxy.is_webkit_specific_web_platform_test):
3407
3408 2017-05-23  Emilio Cobos Álvarez  <ecobos@igalia.com>
3409
3410         Add a RuntimeEnabledFeature for display: contents, defaulted to false.
3411         https://bugs.webkit.org/show_bug.cgi?id=171984
3412
3413         Reviewed by Antti Koivisto.
3414
3415         * DumpRenderTree/mac/DumpRenderTree.mm:
3416         (enableExperimentalFeatures):
3417         * WebKitTestRunner/TestController.cpp:
3418         (WTR::TestController::resetPreferencesToConsistentValues):
3419
3420 2017-05-20  Alex Christensen  <achristensen@webkit.org>
3421
3422         REGRESSION(r215686): O(n^2) algorithm in CachedRawResource::addDataBuffer
3423         https://bugs.webkit.org/show_bug.cgi?id=172406
3424         <rdar://32109532>
3425
3426         Reviewed by Brady Eidson.
3427
3428         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
3429         (TestWebKitAPI::checkBuffer):
3430         (TestWebKitAPI::TEST_F):
3431
3432 2017-05-22  Jason Marcell  <jmarcell@apple.com>
3433
3434         Do not enter Subversion-specific logic when parsing Git-based Trac data.
3435         https://bugs.webkit.org/show_bug.cgi?id=172433
3436         <rdar://problem/32234188>
3437
3438         Reviewed by Alexey Proskuryakov.
3439
3440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3441         (Trac.prototype._convertCommitInfoElementToObject):
3442
3443 2017-05-22  Tim Horton  <timothy_horton@apple.com>
3444
3445         ExplicitSnapshotsChangeUponNavigation API test often fails
3446         https://bugs.webkit.org/show_bug.cgi?id=172475
3447         <rdar://problem/31688322>
3448
3449         Reviewed by Simon Fraser.
3450
3451         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3452         (-[TestWKWebView _setUpTestWindow:]):
3453         Make TestWKWebView's window layer-backed. This is now the default,
3454         and it's also easy to accidentally write a test that depends on it
3455         (for example, ExplicitSnapshotsChangeUponNavigation adds an NSBox,
3456         which becomes layer backed, just like the WKWebView, but with no
3457         common layer-backed ancestor).
3458
3459 2017-05-22  youenn fablet  <youenn@apple.com>
3460
3461         Resync web-platform-tests up to 8df7c9c215678328212f232ce0b5270c505a8563
3462         https://bugs.webkit.org/show_bug.cgi?id=172426
3463
3464         Reviewed by Chris Dumez.
3465
3466         * Scripts/webkitpy/w3c/test_importer.py:
3467         (TestImporter.remove_deleted_files): Outputting warning when trying to delete a file that no longer exists.
3468
3469 2017-05-22  Konstantin Tokarev  <annulen@yandex.ru>
3470
3471         Unreviewed, change my status to reviewer and fill "expertise" field
3472
3473         * Scripts/webkitpy/common/config/contributors.json:
3474
3475 2017-05-22  Tomas Popela  <tpopela@redhat.com>
3476
3477         Remove some of the EFL port leftovers
3478         https://bugs.webkit.org/show_bug.cgi?id=172440
3479
3480         Reviewed by Carlos Garcia Campos.
3481
3482         * BuildSlaveSupport/built-product-archive:
3483         (archiveBuiltProduct):
3484         (extractBuiltProduct):
3485         * BuildSlaveSupport/test-result-archive:
3486         (archiveTestResults):
3487         * ImageDiff/PlatformEfl.cmake: Removed.
3488         * Scripts/run-efl-tests: Removed.
3489         * Scripts/webkit-build-directory:
3490         * Scripts/webkitpy/common/config/contributionareas.py:
3491         * Scripts/webkitpy/common/config/watchlist:
3492         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3493         (parse_args):
3494         (_set_up_derived_options):
3495         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3496         (PerfTestsRunner.__init__):
3497         * Scripts/webkitpy/style/checker.py:
3498         * Scripts/webkitpy/style/checker_unittest.py:
3499         (GlobalVariablesTest.test_path_rules_specifier):
3500         * gtk/manifest.txt.in:
3501         * jhbuild/jhbuild-wrapper:
3502
3503 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3504
3505         Unreviewed. Do not include WPE files in GTK+ tarballs.
3506
3507         * gtk/manifest.txt.in:
3508
3509 2017-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3510
3511         [GTK] Add webkit_context_menu_item_new_from_gaction
3512         https://bugs.webkit.org/show_bug.cgi?id=159631
3513
3514         Reviewed by Michael Catanzaro.
3515
3516         Update context menu tests to check the new GAction API.
3517
3518         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3519         (testContextMenuPopulateMenu):
3520
3521 2017-05-21  Michael Catanzaro  <mcatanzaro@igalia.com>
3522
3523         [GTK] Remove Firefox user agent quirk for Google domains
3524         https://bugs.webkit.org/show_bug.cgi?id=171941
3525
3526         Reviewed by Carlos Garcia Campos.
3527
3528         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3529         (TestWebKitAPI::TEST):
3530         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk): Deleted.
3531
3532 2017-05-20  Ting-Wei Lan  <lantw44@gmail.com>
3533
3534         [GTK] gtkdoc-fixxref needs --module argument to work
3535         https://bugs.webkit.org/show_bug.cgi?id=172415
3536
3537         Reviewed by Michael Catanzaro.
3538
3539         * gtk/gtkdoc.py:
3540         (GTKDoc._run_gtkdoc_fixxref):
3541
3542 2017-05-20  Alexey Proskuryakov  <ap@apple.com>
3543
3544         make-new-script-test should create tests that use js-test.js, not js-test-pre.js
3545         https://bugs.webkit.org/show_bug.cgi?id=172416
3546
3547         Reviewed by Daniel Bates.
3548
3549         * Scripts/make-new-script-test:
3550
3551 2017-05-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3552
3553         [Win] error LNK2005: WebCore::JSNode::checkSubClassPatchpoint() already defined in WebKit.lib
3554         https://bugs.webkit.org/show_bug.cgi?id=172267
3555
3556         Reviewed by Per Arne Vollan.
3557
3558         TestWebCoreLib and TestWebKitLib have linked both WebCore and WebKit.
3559         TestWebCoreLib should link only with WebCore. And, TestWebKitLib
3560         should link only with WebKit.
3561
3562         Unfortunately, there is a layer violation at the moment.
3563         WebCore::Image::loadPlatformResource needs loadResourceIntoBuffer
3564         in WebKit. This change contains a stub of loadResourceIntoBuffer
3565         in TestWebCoreLib for the workaround.
3566
3567         * TestWebKitAPI/PlatformWin.cmake: Do not link WebKit to
3568         TestWebCoreLib. Do not link WebCore to TestWebKitLib.
3569         * TestWebKitAPI/win/TestWebCoreStubs.cpp: Added.
3570         (loadResourceIntoBuffer): Added a stub.
3571
3572 2017-05-19  Simon Fraser  <simon.fraser@apple.com>
3573
3574         Fix dump-class-layout to handle different file architectures
3575         https://bugs.webkit.org/show_bug.cgi?id=172392
3576
3577         Reviewed by Zalan Bujtas.
3578
3579         Instead of using lldb.LLDB_ARCH_DEFAULT by default, run 'file' on the binary
3580         and use the first architecture reported. Also add a "--architecture" argument
3581         to allow the user to specify an architecture.
3582
3583         * Scripts/dump-class-layout:
3584         (import_lldb):
3585         (verify_type_recursive):
3586         (get_first_file_architecture):
3587         (dump_class):
3588         (main):
3589         (find_build_directory): Deleted.
3590
3591 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3592
3593         Unreviewed infrastructure fix.
3594
3595         * Scripts/webkitpy/port/ios_simulator.py:
3596         (IOSSimulatorPort._create_devices): Ignore failure to open Simulator.app.
3597
3598 2017-05-19  Jonathan Bedard  <jbedard@apple.com>
3599
3600         webkitpy: Use simctl boot to run multiple simulators at once
3601         https://bugs.webkit.org/show_bug.cgi?id=172374
3602
3603         Reviewed by Alexey Proskuryakov.
3604
3605         * Scripts/webkitpy/common/system/platforminfo.py:
3606         (PlatformInfo.xcode_version): Return the current version of Xcode.
3607         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3608         (MockPlatformInfo.xcode_version): Return version 8.0 for testing.
3609         * Scripts/webkitpy/port/ios_simulator.py:
3610         (IOSSimulatorPort.use_multiple_simulator_apps): Return true if we need to
3611         run multiple Simulator.app instances.
3612         (IOSSimulatorPort._create_simulators): Only copy the simulator app for older
3613         versions of Xcode.
3614         (IOSSimulatorPort._create_devices): Use 'simctl boot' directly unless using
3615         an older version of Xcode.
3616
3617 2017-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
3618
3619         Unreviewed, fix the build on the latest internal SDK.
3620
3621         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3622         (TestWebKitAPI::TEST):
3623
3624 2017-05-19  Filip Pizlo  <fpizlo@apple.com>
3625
3626         arrayProtoPrivateFuncConcatMemcpy needs to be down with firstArray being undecided
362