095603785afb13a05a012b9dfb228464b3ab2129
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] WebDriver: wayland display no used in wayland bot
4         https://bugs.webkit.org/show_bug.cgi?id=181851
5
6         Reviewed by Carlos Alberto Lopez Perez.
7
8         We need to handle the additionalArguments property in the WebDriverTests step.
9
10         * BuildSlaveSupport/build.webkit.org-config/steps.py:
11         (RunWebDriverTests.start):
12
13 2018-01-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
14
15         [GTK] TERM environment variable is not passed to the test driver.
16         https://bugs.webkit.org/show_bug.cgi?id=181847
17
18         Rubber-stamped by by Carlos Garcia Campos.
19
20         * Scripts/webkitpy/port/base.py:
21         (Port.to.setup_environ_for_server):
22
23 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         WebDriver: run-webdriver-tests is crashing in the bots when creating results json file
26         https://bugs.webkit.org/show_bug.cgi?id=181844
27
28         Reviewed by Carlos Alberto Lopez Perez.
29
30         We always try to create the directory where to store the json file, but when the filename is given directly,
31         like in the bots, the current dir is used.
32
33         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
34         (WebDriverTestRunner.dump_results_to_json_file): Do not try to create the directory if dirname() returns an
35         empty string.
36
37 2018-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
38
39         [GTK] WebDriver tests are running outside the jhbuild env
40         https://bugs.webkit.org/show_bug.cgi?id=181842
41
42         Reviewed by Žan Doberšek.
43
44         We need to enter jhbuild env in run-webdriver-tests.
45
46         * Scripts/run-webdriver-tests:
47
48 2018-01-18  Carlos Garcia Campos  <cgarcia@igalia.com>
49
50         [GTK] Run WebDriver tests in the bots
51         https://bugs.webkit.org/show_bug.cgi?id=181787
52
53         Reviewed by Michael Catanzaro.
54
55         Add a step to run WebDriver tests in the GTK test bots. The new step is not GTK specific, but only added to the
56         factory for the GTK port for now.
57
58         * BuildSlaveSupport/build.webkit.org-config/factories.py:
59         (TestFactory.__init__):
60         * BuildSlaveSupport/build.webkit.org-config/steps.py:
61         (RunWebDriverTests):
62         (RunWebDriverTests.start):
63         (RunWebDriverTests.commandComplete):
64         (RunWebDriverTests.evaluateCommand):
65         (RunWebDriverTests.getText):
66         (RunWebDriverTests.getText2):
67
68 2018-01-18  Basuke Suzuki  <Basuke.Suzuki@sony.com>
69
70         [WinCairo] Pass correct url for http test to test driver.
71         https://bugs.webkit.org/show_bug.cgi?id=181814
72
73         Reviewed by Alex Christensen.
74
75         * Scripts/webkitpy/port/driver.py:
76         (Driver):
77         (Driver.http_test_path_to_uri):
78         (Driver.is_secure_path):
79         (Driver.http_base_url):
80         (Driver.uri_to_test):
81
82 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
83
84         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
85
86         * BuildSlaveSupport/build.webkit.org-config/config.json:
87
88 2018-01-18  Dan Bernstein  <mitz@apple.com>
89
90         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
91         https://bugs.webkit.org/show_bug.cgi?id=181803
92
93         Reviewed by Tim Horton.
94
95         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
96         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
97         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
98         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
99         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
100         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
101         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
102         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
103         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
104           helpers.
105         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
106           settings useful for defining settings that depend on the target macOS version.
107         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
108         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
109
110 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
111
112         Remove Opensource El Capitan queues from buildbot
113         https://bugs.webkit.org/show_bug.cgi?id=181712
114
115         Reviewed by Aakash Jain.
116
117         * BuildSlaveSupport/build.webkit.org-config/config.json:
118         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
119         (WebKitBuildbot):
120         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
121
122 2018-01-18  Chris Dumez  <cdumez@apple.com>
123
124         Service Workers restored from persistent storage have 'redundant' state
125         https://bugs.webkit.org/show_bug.cgi?id=181749
126         <rdar://problem/36556486>
127
128         Reviewed by Youenn Fablet.
129
130         Add API test coverage.
131
132         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
133         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
134
135 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
136
137         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
138         https://bugs.webkit.org/show_bug.cgi?id=176796
139
140         Reviewed by Chris Fleizach.
141
142         Add sanity check that we have a URL before calling g_strstr_len().
143
144         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
145         (WTR::AccessibilityUIElement::url):
146
147 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
148
149         Add triggers for Sierra test262 and perf queues
150         https://bugs.webkit.org/show_bug.cgi?id=181799
151
152         Reviewed by Aakash Jain.
153
154         * BuildSlaveSupport/build.webkit.org-config/config.json:
155
156 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
157
158         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
159         https://bugs.webkit.org/show_bug.cgi?id=181783
160         <rdar://problem/35785445>
161
162         Reviewed by Ryosuke Niwa.
163
164         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
165         copying an image contains a relevant title.
166
167         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
168         (TestWebKitAPI::TEST):
169         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
170         * TestWebKitAPI/ios/UIKitSPI.h:
171
172 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
173
174         WebDriver: ignore the driver in selenium test names when getting expectations
175         https://bugs.webkit.org/show_bug.cgi?id=181738
176
177         Reviewed by Carlos Alberto Lopez Perez.
178
179         In selenium tests, the driver is added as a parameter to every test which results in tests names like
180         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
181         driver name in the test expectations file, so we need to remove it when querying the expectations.
182
183         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
184         (TestExpectationsMarker.__init__): Save the param to ignore.
185         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
186         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
187         (run): Pass param to ignore to TestExpectationsMarker().
188         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
189         (WebDriverSeleniumExecutor.__init__): Save the driver name.
190         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
191
192 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
193
194         [GTK][WPE] Show unit tests unexpectedly passing in the bots
195         https://bugs.webkit.org/show_bug.cgi?id=181726
196
197         Reviewed by Michael Catanzaro.
198
199         Now that we have the info, let's show it also in the bots.
200
201         * BuildSlaveSupport/build.webkit.org-config/steps.py:
202         (RunGLibAPITests.commandComplete):
203
204 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
205
206         Fix broken unittest after r227048
207         https://bugs.webkit.org/show_bug.cgi?id=181760
208
209         Reviewed by Aakash Jain.
210
211
212 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
213
214         WEBKIT_FRAMEWORK should not modify file-global include directories
215         https://bugs.webkit.org/show_bug.cgi?id=181656
216
217         Reviewed by Konstantin Tokarev.
218
219         * TestWebKitAPI/PlatformWPE.cmake:
220         * TestWebKitAPI/glib/CMakeLists.txt:
221
222 2018-01-17  Alicia Boya García  <aboya@igalia.com>
223
224         Unreviewed, mark Alicia as committer in contributors.json
225
226         * Scripts/webkitpy/common/config/contributors.json:
227
228 2018-01-17  Youenn Fablet  <youenn@apple.com>
229
230         Put fetch Request.keepalive behind a runtime flag
231         https://bugs.webkit.org/show_bug.cgi?id=181592
232
233         Reviewed by Chris Dumez.
234
235         * DumpRenderTree/mac/DumpRenderTree.mm:
236         (enableExperimentalFeatures):
237         * DumpRenderTree/win/DumpRenderTree.cpp:
238         (enableExperimentalFeatures):
239         * WebKitTestRunner/TestController.cpp:
240         (WTR::TestController::resetPreferencesToConsistentValues):
241
242 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
243
244         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
245         https://bugs.webkit.org/show_bug.cgi?id=181637
246         <rdar://problem/36508471>
247
248         Reviewed by Tim Horton.
249
250         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
251         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
252
253         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
254         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
255         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
256
257         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
258         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
259
260         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
261         (webViewForTestingAttachments):
262         (-[TestWKWebView tagsInBody]):
263         (-[TestWKWebView expectElementTagsInOrder:]):
264         (-[TestWKWebView expectElementTag:toComeBefore:]):
265
266         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
267         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
268
269         (TestWebKitAPI::TEST):
270         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
271         (WTR::InjectedBundlePage::InjectedBundlePage):
272
273 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
274
275         WebDriver: add support for test expectations
276         https://bugs.webkit.org/show_bug.cgi?id=180420
277
278         Reviewed by Carlos Alberto Lopez Perez.
279
280         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
281
282         * Scripts/run-webdriver-tests: Get the retval from process_results().
283         * Scripts/webkitpy/thirdparty/__init__.py:
284         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
285         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
286         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
287         (TestExpectationsMarker.__init__): Initialize expectations.
288         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
289         (run): Create and use TestExpectationsMarker plugin.
290         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
291         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
292         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
293         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
294         (WebDriverTestRunner.run): Do not count results here.
295         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
296         amount of failures. Printing the test summary while processing results will be made optional in a follow up
297         patch.
298         (WebDriverTestRunner.process_results.report): Return the amount of failures.
299         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
300         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
301         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
302         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
303         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
304         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
305         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
306         (WebDriverTestRunnerW3C._scan_directory): Ditto.
307         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
308         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
309         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
310
311 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
312
313         Unreviewed WPE gardening. Mark some known unit test failures.
314
315         * TestWebKitAPI/glib/TestExpectations.json:
316
317 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
318
319         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
320         https://bugs.webkit.org/show_bug.cgi?id=181724
321
322         Reviewed by Philippe Normand.
323
324         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
325         reason to use different names. This way we can refer to the same test names for both and we can share the
326         expectations in the TestExpectations.json file.
327
328         * TestWebKitAPI/glib/TestExpectations.json:
329         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
330
331 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
332
333         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
334
335         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
336         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
337
338         * glib/api_test_runner.py:
339         (TestRunner._run_test_glib):
340         (TestRunner._run_google_test):
341
342 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
343
344         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
345         https://bugs.webkit.org/show_bug.cgi?id=179914
346
347         Reviewed by Žan Doberšek.
348
349         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
350         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
351         all symbols listed in the script are present in the library.
352
353         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
354         (bss_symbols):
355         * Scripts/check-for-invalid-symbols-in-version-script: Added.
356         (script_symbols):
357         * Scripts/make-dist:
358         (Distcheck.build):
359         (Distcheck):
360         (Distcheck.check_symbols):
361         (Distcheck.check):
362
363 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
364
365         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
366         https://bugs.webkit.org/show_bug.cgi?id=181722
367
368         Reviewed by Žan Doberšek.
369
370         I forgot to pass the parameters to run() when restarting.
371
372         * glib/glib_test_runner.py:
373         (GLibTestRunner.run):
374
375 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
376
377         [CMake] Remove WebCoreDerivedSources library target
378         https://bugs.webkit.org/show_bug.cgi?id=181664
379
380         Reviewed by Carlos Garcia Campos.
381
382         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
383         * TestWebKitAPI/PlatformWin.cmake: Ditto.
384
385 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
386
387         Move Debug Test262, Release Test262 and Performance queues to Sierra
388         https://bugs.webkit.org/show_bug.cgi?id=181692
389
390         Unreviewed
391
392 2018-01-16  Zach Li  <zachli@apple.com>
393
394         Add pop-up policy support in website policies.
395         https://bugs.webkit.org/show_bug.cgi?id=181544.
396         rdar://problem/30521400.
397
398         Reviewed by Alex Christensen.
399
400         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
401         Added pop-up-check.html.
402
403         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
404
405         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
406         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
407         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
408         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
409         (TEST):
410
411 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
412
413         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
414         https://bugs.webkit.org/show_bug.cgi?id=181638
415         <rdar://problem/36508702>
416
417         Reviewed by Dan Bernstein.
418
419         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
420         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
421
422         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
423         (-[AttachmentUpdateObserver init]):
424         (-[AttachmentUpdateObserver sourceForIdentifier:]):
425         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
426         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
427         (TestWebKitAPI::TEST):
428         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
429
430 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
431
432         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
433
434         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
435
436         * glib/api_test_runner.py:
437         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
438         * glib/glib_test_runner.py:
439         (GLibTestRunner.run): Use given env.
440
441 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
442
443         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
444         https://bugs.webkit.org/show_bug.cgi?id=181676
445
446         Reviewed by Carlos Alberto Lopez Perez.
447
448         The option was removed in r226967.
449
450         * BuildSlaveSupport/build.webkit.org-config/steps.py:
451         (RunGtkAPITests):
452         (RunWPEAPITests):
453
454 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
455
456         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
457
458         The bots are still passing that option and the step is failing because it was removed in r226967.
459
460         * glib/api_test_runner.py:
461         (add_options):
462
463 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
464
465         [GTK][WPE] Improve the way glib tests are run
466         https://bugs.webkit.org/show_bug.cgi?id=181674
467
468         Reviewed by Žan Doberšek.
469
470         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
471         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
472         tests failing due to an expected assert in the test and unexpected crashes.
473         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
474         not showing the subtest name in stdout in case of timeouts.
475         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
476         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
477         of every test case.
478
479         * glib/api_test_runner.py:
480         (TestRunner._run_test_glib): Use GLibTestRunner.
481         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
482         (add_options):
483         * glib/glib_test_runner.py: Added.
484         (TestTimeout):
485         (Message):
486         (Message.__init__):
487         (Message.create):
488         (Message.create.read_unsigned):
489         (Message.create.read_double):
490         (Message.create.read_string):
491         (GLibTestRunner):
492         (GLibTestRunner.__init__):
493         (GLibTestRunner._process_data):
494         (GLibTestRunner._process_message):
495         (GLibTestRunner._read_from_pipe):
496         (GLibTestRunner._read_from_stderr):
497         (GLibTestRunner._start_timeout):
498         (GLibTestRunner._start_timeout._alarm_handler):
499         (GLibTestRunner._stop_timeout):
500         (GLibTestRunner._subtest_start):
501         (GLibTestRunner._subtest_message):
502         (GLibTestRunner._subtest_stderr):
503         (GLibTestRunner._subtest_end):
504         (GLibTestRunner.run):
505
506 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
507
508         Unreviewed, add Thibault to contributors.json
509
510         It's a bit weird to add someone here before their first contribution, but this affects
511         Bugzilla autocomplete, and that is serious business.
512
513         * Scripts/webkitpy/common/config/contributors.json:
514
515 2018-01-15  JF Bastien  <jfbastien@apple.com>
516
517         Remove makePoisonedUnique
518         https://bugs.webkit.org/show_bug.cgi?id=181630
519         <rdar://problem/36498623>
520
521         Reviewed by Mark Lam.
522
523         Update tests.
524
525         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
526         (TestWebKitAPI::TEST):
527         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
528         (TestWebKitAPI::TEST):
529
530 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
531
532         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
533         https://bugs.webkit.org/show_bug.cgi?id=181476
534
535         Reviewed by Michael Catanzaro.
536
537         Update to xorg-server 1.19.6 which depends on libxfont2, and change
538         the lists of packages to install libxfont2-devel (or equivalent).
539
540         * gtk/install-dependencies:
541         * gtk/jhbuild.modules:
542
543 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
544
545         [GTK][WPE] Add support for unit test expectations
546         https://bugs.webkit.org/show_bug.cgi?id=181589
547
548         Reviewed by Michael Catanzaro.
549
550         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
551         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
552         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
553         script itself is not a good idea either.
554
555         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
556         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
557         convenient methods to query them.
558
559         * Scripts/run-gtk-tests:
560         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
561         * Scripts/run-wpe-tests:
562         (WPETestRunner): Ditto.
563         * Scripts/webkitpy/common/test_expectations.py: Added.
564         (TestExpectations):
565         (TestExpectations.__init__):
566         (TestExpectations._port_name_for_expected):
567         (TestExpectations._expected_value):
568         (TestExpectations.skipped_tests):
569         (TestExpectations.skipped_subtests):
570         (TestExpectations._expectation_value):
571         (TestExpectations.is_slow):
572         (TestExpectations.get_expectation):
573         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
574         (MockTestExpectations):
575         (MockTestExpectations.__init__):
576         (MockTestExpectations.is_skip):
577         (ExpectationsTest):
578         (assert_exp):
579         (assert_not_exp):
580         (assert_bad_exp):
581         (assert_skip):
582         (test_basic):
583         (test_skip):
584         (test_flaky):
585         (test_build_type):
586         * TestWebKitAPI/glib/TestExpectations.json: Added.
587         * glib/api_test_runner.py:
588         (TestRunner): Remove SkippedTest implementation.
589         (TestRunner.__init__): Create a TestExpectations.
590         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
591         (TestRunner._should_run_test_program): Ditto.
592         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
593         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
594         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
595         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
596         (TestRunner.run_tests.report): Helper to write report to stdout.
597
598 2018-01-13  Mark Lam  <mark.lam@apple.com>
599
600         Replace all use of ConstExprPoisoned with Poisoned.
601         https://bugs.webkit.org/show_bug.cgi?id=181542
602         <rdar://problem/36442138>
603
604         Reviewed by JF Bastien.
605
606         1. Converted tests to using new uintptr_t& poison type.
607         2. Added tests for Poisoned comparison operators.
608
609         * TestWebKitAPI/CMakeLists.txt:
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
611         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
612         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
613         (TestWebKitAPI::TEST):
614         (TestWebKitAPI::initializeTestPoison): Deleted.
615         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
616         (TestWebKitAPI::TEST):
617         (TestWebKitAPI::passWithRef):
618         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
619         (TestWebKitAPI::TEST):
620         (TestWebKitAPI::f1):
621         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
622         (TestWebKitAPI::TEST):
623         (TestWebKitAPI::poisonedPtrFoo):
624         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
625         (TestWebKitAPI::TEST):
626         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
627         (TestWebKitAPI::TEST):
628
629 2018-01-13  David Kilzer  <ddkilzer@apple.com>
630
631         check-webkit-style: false positive for [whitespace/braces] with os_log format string
632         <https://webkit.org/b/181606>
633
634         Reviewed by Darin Adler.
635
636         * Scripts/webkitpy/style/checkers/cpp.py:
637         (check_spacing): Modify regular expression to ignore
638         os_log format strings like '%{public}'.
639         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
640         (CppStyleTest.test_spacing_before_braces): Add os_log
641         format string test.
642
643 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
644
645         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
646         https://bugs.webkit.org/show_bug.cgi?id=181626
647
648         Reviewed by Joseph Pecoraro.
649
650         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
651         Additionally, write a new API test covering the change in r226915.
652
653         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
654         (webViewForTestingAttachments):
655         (TestWebKitAPI::TEST):
656
657 2018-01-12  Alex Christensen  <achristensen@webkit.org>
658
659         History state should be updated during client redirects with asynchronous policy decisions
660         https://bugs.webkit.org/show_bug.cgi?id=181358
661         <rdar://problem/35547689>
662
663         Reviewed by Andy Estes.
664
665         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
666         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
667         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
668         (TEST):
669
670 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
671
672         webkitpy: Refactor simulator code (Part 4)
673         https://bugs.webkit.org/show_bug.cgi?id=180555
674         <rdar://problem/36131381>
675
676         Reviewed by Aakash Jain.
677
678         Move new_simulated_device.py to simulated_device.py.
679
680         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
681         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
682         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
683         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
684         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
685
686 2018-01-12  Alex Christensen  <achristensen@webkit.org>
687
688         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
689         https://bugs.webkit.org/show_bug.cgi?id=181595
690
691         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
692         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
693         I change the < and > to $ to make this test pass and continue to test what it used to.
694
695         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
696         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
697         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
698
699 2018-01-11  Keith Miller  <keith_miller@apple.com>
700
701         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
702         https://bugs.webkit.org/show_bug.cgi?id=181573
703
704         Reviewed by Simon Fraser.
705
706         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
707
708 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
709
710         [WebAuthN] Import a CBOR coder from Chromium
711         https://bugs.webkit.org/show_bug.cgi?id=181522
712         <rdar://problem/36055729>
713
714         Reviewed by Brent Fulgham.
715
716         This patch also imports all unit tests into our API tests to ensure all
717         workarounds and modification against the original codebase doesn't change
718         any original functionalities.
719
720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
721         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
722         (TestWebKitAPI::TEST):
723         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
724         (TestWebKitAPI::TEST):
725         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
726         (TestWebKitAPI::eq):
727         Workarounds applied.
728         (TestWebKitAPI::TEST):
729
730 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
731
732         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
733         https://bugs.webkit.org/show_bug.cgi?id=181538
734         <rdar://problem/36440580>
735
736         Reviewed by Aakash Jain.
737
738         When disambiguating a device type, it is possible that the provided device type is sufficiently
739         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
740         will result in a failure to disambiguate the type.
741
742         * Scripts/webkitpy/xcode/new_simulated_device.py:
743         (SimulatedDeviceManager._disambiguate_device_type):
744
745 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
746
747         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
748         https://bugs.webkit.org/show_bug.cgi?id=181136
749         <rdar://problem/36116604>
750
751         Reviewed by Chris Dumez.
752
753         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
754         browsing sessions.
755
756         * Scripts/run-gtk-tests:
757         (GtkTestRunner): Unskip test now that it passes.
758         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
759         (TEST): Add new WebsiteDataStoreEphemeral test.
760
761 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
762
763         Unreviewed, rolling out r226816.
764
765         This change broke LayoutTests on the bots.
766
767         Reverted changeset:
768
769         "run-webkit-tests fails when there is a curly brace in Xcode
770         build output"
771         https://bugs.webkit.org/show_bug.cgi?id=181254
772         https://trac.webkit.org/changeset/226816
773
774 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
775
776         webkitpy: Fix flakey webserver tests
777         https://bugs.webkit.org/show_bug.cgi?id=181555
778         <rdar://problem/36448273>
779
780         Reviewed by Aakash Jain.
781
782         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
783         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
784         determine if a specific server is running.
785
786 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
787
788         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
789         https://bugs.webkit.org/show_bug.cgi?id=181561
790         <rdar://problem/36452652>
791
792         Reviewed by Aakash Jain.
793
794         BeautifulSoup.find may return None, this case should be gracefully handled.
795
796         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
797         (BugzillaQueries._parse_result_count):
798         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
799
800 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
801
802         run-webkit-tests fails when there is a curly brace in Xcode build output
803         https://bugs.webkit.org/show_bug.cgi?id=181254
804
805         Reviewed by Daniel Bates.
806
807         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
808         (MeteredStream.write):
809
810 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
811
812         webkitpy: Reimplement simulator code (Part 3)
813         https://bugs.webkit.org/show_bug.cgi?id=180555
814         <rdar://problem/36131381>
815
816         Reviewed by Aakash Jain.
817
818         Remove old simulator code.
819
820         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
821         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
822         * Scripts/webkitpy/xcode/simulator.py: Removed.
823         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
824
825 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
826
827         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
828         https://bugs.webkit.org/show_bug.cgi?id=181337
829         <rdar://problem/36324813>
830
831         Reviewed by Tim Horton.
832
833         Add 3 new API tests for attachment element dragging.
834
835         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
836         (-[TestWKWebView expectElementTag:toComeBefore:]):
837         (-[NSItemProvider expectType:withData:]):
838         (TestWebKitAPI::TEST):
839
840 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
841
842         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
843         https://bugs.webkit.org/show_bug.cgi?id=179621
844         <rdar://problem/35589585>
845
846         Unreviewed infrastructure fix.
847
848         * Scripts/webkitpy/port/mac.py:
849         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
850         list if we are the VERSION_MAX, which usually corresponds with future.
851
852 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
853
854         CodeBlocks should be in IsoSubspaces
855         https://bugs.webkit.org/show_bug.cgi?id=180884
856
857         Reviewed by Saam Barati.
858         
859         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
860         shouldn't take a long time due to benchmarks we don't optimize for.
861         
862         * Scripts/run-jsc-benchmarks:
863
864 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
865
866         Test gardening for GTK.
867         https://bugs.webkit.org/show_bug.cgi?id=181477
868
869         Unreviewed test gardening.
870
871         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
872         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
873
874 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
875
876         Add the new JSCOnly bot to the scheduler.
877         https://bugs.webkit.org/show_bug.cgi?id=181487
878
879         Unreviewed follow-up patch after r226729
880
881         On r226729 I missed to add the new JSCOnly bot the default scheduler.
882         This is needed to make the bot automatically pick each commit for testing.
883
884         * BuildSlaveSupport/build.webkit.org-config/config.json:
885
886 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
887
888         [Attachment Support] Support dragging attachment elements out as files on iOS
889         https://bugs.webkit.org/show_bug.cgi?id=181199
890         <rdar://problem/36299316>
891
892         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
893
894         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
895         attachment API tests.
896
897         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
898         (-[NSItemProvider expectType:withData:]):
899         (TestWebKitAPI::TEST):
900
901         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
902         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
903         -expectType:withData: helper to inspect the item providers created from the drag source.
904
905         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/ios/DataInteractionSimulator.h:
908         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
909         (-[MockDragSession localContext]):
910         (-[MockDragSession setLocalContext:]):
911         (-[DataInteractionSimulator _resetSimulatedState]):
912         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
913         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
914         (-[DataInteractionSimulator _advanceProgress]):
915         (-[DataInteractionSimulator endDataTransfer]):
916
917         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
918         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
919         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
920         MockDragSession to hold on to a localContext.
921
922 2018-01-11  Ali Juma  <ajuma@chromium.org>
923
924         Unreviewed. Add Ali Juma as contributor
925
926         * Scripts/webkitpy/common/config/contributors.json:
927
928 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
929
930         Unreviewed. Update Selenium WebDriver imported tests.
931
932         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
933         environment variables.
934
935         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
936         (collect): Reorder the arguments to make pytest happy.
937         (run): Ditto.
938         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
939         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
940
941 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
942
943         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
944         https://bugs.webkit.org/show_bug.cgi?id=181492
945         <rdar://problem/36359679>
946
947         Reviewed by Alexey Proskuryakov. 
948
949 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
950
951         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
952         https://bugs.webkit.org/show_bug.cgi?id=181475
953
954         Reviewed by Michael Catanzaro.
955
956         * gtk/install-dependencies: Update package list for Arch Linux, extend
957         message shown at end of installation with additional tips.
958
959 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
960
961         REGRESSION(r222507): Composition highlight doesn't render when using IME
962         https://bugs.webkit.org/show_bug.cgi?id=181485
963         <rdar://problem/35896516>
964
965         Reviewed by Ryosuke Niwa.
966
967         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
968         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
969         allow rendering composition backgrounds (see InlineTextBox::paint).
970
971         * DumpRenderTree/ios/TextInputControllerIOS.m:
972         (+[TextInputController isSelectorExcludedFromWebScript:]):
973         (+[TextInputController webScriptNameForSelector:]):
974         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
975         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
976         * DumpRenderTree/mac/TextInputControllerMac.m:
977         (+[TextInputController isSelectorExcludedFromWebScript:]):
978         (+[TextInputController webScriptNameForSelector:]):
979         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
980         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
981         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
982         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
983         (WTR::TextInputController::setMarkedText):
984         * WebKitTestRunner/InjectedBundle/TextInputController.h:
985
986 2018-01-10  JF Bastien  <jfbastien@apple.com>
987
988         Poison small JSObject derivatives which only contain pointers
989         https://bugs.webkit.org/show_bug.cgi?id=181483
990         <rdar://problem/36407127>
991
992         Reviewed by Mark Lam.
993
994         Test the new move-assign and move-copy from unique_ptr, as well as
995         nullptr_t ctors.
996
997         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
998         (TestWebKitAPI::TEST):
999         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
1000         (TestWebKitAPI::TEST):
1001         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
1002         (TestWebKitAPI::TEST):
1003
1004 2018-01-10  Chris Dumez  <cdumez@apple.com>
1005
1006         Multiple http/wpt/beacon/contentextensions/ test are flaky.
1007         https://bugs.webkit.org/show_bug.cgi?id=179256
1008         <rdar://problem/35401978>
1009
1010         Reviewed by Alex Christensen.
1011
1012         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
1013         instance gets its own folder to avoid conflicts and flakiness.
1014
1015         * WebKitTestRunner/mac/TestControllerMac.mm:
1016         (WTR::TestController::platformConfigureViewForTest):
1017
1018 2018-01-10  Tim Horton  <timothy_horton@apple.com>
1019
1020         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
1021         https://bugs.webkit.org/show_bug.cgi?id=181269
1022         <rdar://problem/35110344>
1023
1024         Reviewed by Simon Fraser.
1025
1026         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1027         (WTR::UIScriptController::beginBackSwipe):
1028         (WTR::UIScriptController::completeBackSwipe):
1029         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1030         (WTR::UIScriptController::beginBackSwipe):
1031         (WTR::UIScriptController::completeBackSwipe):
1032         (WTR::UIScriptController::overridePreference):
1033         (WTR::UIScriptController::replaceTextAtRange):
1034         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1035         (WTR::PlatformWebView::setNavigationGesturesEnabled):
1036         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1037         (WTR::UIScriptController::beginBackSwipe):
1038         (WTR::UIScriptController::completeBackSwipe):
1039         Implement beginBackSwipe and completeBackSwipe on iOS (they already
1040         exist on Mac) in terms of the new WKWebView testing SPI.
1041
1042 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1043
1044         REGRESSION (r226715): ignore WARNING output in linter tests
1045         https://bugs.webkit.org/show_bug.cgi?id=181486
1046         <rdar://problem/36408847>
1047
1048         Reviewed by Aakash Jain.
1049
1050         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
1051
1052         * Scripts/webkitpy/common/system/outputcapture.py:
1053         (OutputCapture.__init__): Pass logging level to be captured.
1054         * Scripts/webkitpy/style/main_unittest.py:
1055         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
1056         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
1057         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
1058         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
1059         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
1060         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
1061         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
1062         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
1063
1064 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1065
1066         Add a JSCOnly MIPS buildbot
1067         https://bugs.webkit.org/show_bug.cgi?id=181487
1068
1069         Reviewed by Michael Catanzaro.
1070
1071         Add the new bot configs definitions for the master and update the unit tests.
1072
1073         * BuildSlaveSupport/build.webkit.org-config/config.json:
1074         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1075
1076 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1077
1078         REGRESSION (r226715): don't re-check number of simulators in child processes
1079         https://bugs.webkit.org/show_bug.cgi?id=181484
1080         <rdar://problem/36407151>
1081
1082         Reviewed by Aakash Jain.
1083
1084         * Scripts/webkitpy/port/ios_simulator.py:
1085         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1086         are already initialized.
1087
1088 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1089
1090         Unreviewed, rolling out r226667 and r226673.
1091         https://bugs.webkit.org/show_bug.cgi?id=181488
1092
1093         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1094
1095         Reverted changesets:
1096
1097         "CodeBlocks should be in IsoSubspaces"
1098         https://bugs.webkit.org/show_bug.cgi?id=180884
1099         https://trac.webkit.org/changeset/226667
1100
1101         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1102         https://bugs.webkit.org/show_bug.cgi?id=180884
1103         https://trac.webkit.org/changeset/226673
1104
1105 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1106
1107         Follow-up fix to r226715
1108         https://bugs.webkit.org/show_bug.cgi?id=180555
1109         <rdar://problem/36131381>
1110
1111         Unreviewed infrastructure fix.
1112
1113         * Scripts/webkitpy/xcode/new_simulated_device.py:
1114         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1115         of delete.
1116
1117 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1118
1119         webkitpy: Refactor simulator code (Part 2)
1120         https://bugs.webkit.org/show_bug.cgi?id=180555
1121         <rdar://problem/36131381>
1122
1123         Reviewed by Aakash Jain.
1124
1125         The patch leverages the SimulatedDeviceManager when running layout tests.
1126         This patch is primarily code removal, since much of the IOSSimulatorPort
1127         was dedicated to managing simulators. The removed code is either now owned by the
1128         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1129         boot multiple simulators which was made obsolete in Xcode 9.
1130
1131         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1132         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1133         strip those spaces.
1134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1135         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1136         * Scripts/webkitpy/port/ios.py:
1137         (IOSPort.__init__): The _current_device idiom is no longer required since the
1138         SimulatedDeviceManager keeps track of any previously booted devices.
1139         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1140         through the array of managed devices.
1141         (IOSPort.using_multiple_devices): Deleted.
1142         * Scripts/webkitpy/port/ios_device.py:
1143         (IOSDevicePort.using_multiple_devices): Deleted.
1144         * Scripts/webkitpy/port/ios_simulator.py:
1145         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1146         class strings so they can be parsed by the DeviceType class.
1147         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1148         the number of simulators currently booted, the number of child processes specified
1149         and the maximum number of simulators supported by this system.
1150         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1151         devices owned by the SimulatedDeviceManager.
1152         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1153         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1154         the maximum number of supported simulators on this system.
1155         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1156         request for each child process and send this list to the SimulatedDeviceManager to
1157         initialize the devices.
1158         (IOSSimulatorPort.clean_up_test_run):
1159         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1160         specified version of iOS.
1161         (IOSSimulatorPort.reset_preferences):
1162         (IOSSimulatorPort.simulator_runtime): Deleted.
1163         (IOSSimulatorPort.simulator_device_type): Deleted.
1164         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1165         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1166         (IOSSimulatorPort._create_simulators): Deleted.
1167         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1168         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1169         (IOSSimulatorPort.using_multiple_devices): Deleted.
1170         (IOSSimulatorPort._create_device): Deleted.
1171         (IOSSimulatorPort.get_simulator_path): Deleted.
1172         (IOSSimulatorPort._createSimulatorApps): Deleted.
1173         (IOSSimulatorPort._createSimulatorApp): Deleted.
1174         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1175         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1176         maximum number of simulators run on this system.
1177         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1178         * Scripts/webkitpy/xcode/new_simulated_device.py:
1179         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1180
1181 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1182
1183         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1184         https://bugs.webkit.org/show_bug.cgi?id=181474
1185
1186         Reviewed by Carlos Alberto Lopez Perez.
1187
1188         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1189         name as the name.
1190
1191         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1192         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1193         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1194
1195 2018-01-09  Andy Estes  <aestes@apple.com>
1196
1197         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1198         https://bugs.webkit.org/show_bug.cgi?id=181459
1199
1200         Reviewed by Dan Bernstein.
1201
1202         * ImageDiff/cg/Configurations/Base.xcconfig:
1203
1204 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1205
1206         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1207         https://bugs.webkit.org/show_bug.cgi?id=181374
1208
1209         Reviewed by Simon Fraser.
1210
1211         The test requires Palatino.
1212
1213         * DumpRenderTree/mac/DumpRenderTree.mm:
1214         (allowedFontFamilySet):
1215         * WebKitTestRunner/mac/TestControllerMac.mm:
1216         (WTR::allowedFontFamilySet):
1217
1218 2018-01-09  Saam Barati  <sbarati@apple.com>
1219
1220         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1221         https://bugs.webkit.org/show_bug.cgi?id=181449
1222
1223         Reviewed by JF Bastien.
1224
1225         This allows me to Cmd+f in my terminal to search for things without
1226         having the results become misaligned.
1227
1228         * Scripts/display-profiler-output:
1229
1230 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1231
1232         [webkitpy] PlatformInfo should have default argument for casual use
1233         https://bugs.webkit.org/show_bug.cgi?id=180827
1234
1235         Reviewed by David Kilzer.
1236
1237         PlatformInfo should be the only way to check platform specific thing instead
1238         of sys.platform or other various checks. If there is something you want to check,
1239         it should be placed in PlatformInfo.
1240
1241         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1242         sys, platform and Executive(). They are straight forward and should be handled
1243         by default arguments. Then we can instantiate PlatformInfo more casual.
1244
1245         * Scripts/webkitpy/common/system/platforminfo.py:
1246         (PlatformInfo): Use relative module path import
1247         (PlatformInfo.__init__):
1248         (PlatformInfo.executive): Lazy instantiation of Executive()
1249         (PlatformInfo.total_bytes_memory): Accessing via above property
1250         (PlatformInfo.xcode_sdk_version): Ditto
1251         (PlatformInfo.xcode_simctl_list): Ditto
1252         (PlatformInfo.xcode_version): Ditto
1253         (PlatformInfo._win_version_str): Ditto
1254         * Scripts/webkitpy/common/system/systemhost.py:
1255         (SystemHost.__init__):
1256         * Scripts/webkitpy/common/system/user.py:
1257         (User.__init__):
1258
1259 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1260
1261         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1262         https://bugs.webkit.org/show_bug.cgi?id=176443
1263
1264         Reviewed by Darin Adler.
1265
1266         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1267         (TEST):
1268
1269 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1270
1271         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1272         https://bugs.webkit.org/show_bug.cgi?id=181394
1273
1274         Reviewed by Darin Adler.
1275
1276         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1277         as the second parameter instead of ios(WK_IOS_TBA). This generally
1278         builds for iOS on EWS but not when using the public SDK. See r224057,
1279         r223207 and r226211 for example. This patch adds a basic style check
1280         for that macro to prevent this kind of mistake.
1281
1282         * Scripts/webkitpy/style/checkers/cpp.py:
1283         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1284         (check_style): Run new style check.
1285         (CppChecker): Add build type for the new style check.
1286         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1287         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1288
1289 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1290
1291         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1292         https://bugs.webkit.org/show_bug.cgi?id=181420
1293         <rdar://problem/36365827>
1294
1295         Reviewed by Alex Christensen.
1296
1297         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1298         of corresponding _WKAttachments.
1299
1300         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1301         (TestWebKitAPI::TEST):
1302
1303 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1304
1305         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1306         https://bugs.webkit.org/show_bug.cgi?id=181410
1307         <rdar://problem/36167199>
1308
1309         Reviewed by Wenson Hsieh.
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1312         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1313         (TEST):
1314
1315 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1316
1317         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1318         https://bugs.webkit.org/show_bug.cgi?id=181408
1319         <rdar://problem/35884960>
1320
1321         Reviewed by Tim Horton.
1322
1323         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1324         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1325
1326 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1327
1328         [Attachment Support] Expose file name and content type of WKAttachment
1329         https://bugs.webkit.org/show_bug.cgi?id=181390
1330         <rdar://problem/36336837>
1331
1332         Reviewed by Tim Horton.
1333
1334         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1335
1336         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1337         (-[_WKAttachment synchronouslyRequestInfo:]):
1338         (-[_WKAttachment synchronouslyRequestData:]):
1339
1340         Reimplement this in terms of -synchronouslyRequestInfo:.
1341
1342         (-[_WKAttachment expectRequestedDataToBe:]):
1343         (TestWebKitAPI::TEST):
1344
1345 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1346
1347         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1348         https://bugs.webkit.org/show_bug.cgi?id=181365
1349         <rdar://problem/36340647>
1350
1351         Reviewed by Tim Horton.
1352
1353         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1354         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1355         detail.
1356
1357         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1358         (TestWebKitAPI::TEST):
1359
1360 2018-01-08  Youenn Fablet  <youenn@apple.com>
1361
1362         navigator.onLine does not work inside service workers
1363         https://bugs.webkit.org/show_bug.cgi?id=181079
1364         <rdar://problem/36178606>
1365
1366         Reviewed by Darin Adler.
1367
1368         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1369         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1370
1371 2018-01-07  Saam Barati  <sbarati@apple.com>
1372
1373         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1374         https://bugs.webkit.org/show_bug.cgi?id=181372
1375
1376         Reviewed by Filip Pizlo.
1377
1378         Adding these sorting modes makes it easier to analyze functions
1379         that recompile a lot and exit a lot.
1380
1381         * Scripts/display-profiler-output:
1382
1383 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1384
1385         Unreviewed, remove my Cisco email from contributors.json
1386
1387         * Scripts/webkitpy/common/config/contributors.json:
1388
1389 2018-01-05  JF Bastien  <jfbastien@apple.com>
1390
1391         WebAssembly: poison JS object's secrets
1392         https://bugs.webkit.org/show_bug.cgi?id=181339
1393         <rdar://problem/36325001>
1394
1395         Reviewed by Mark Lam.
1396
1397         Update tests for swap(Poisoned<k, T>, T*)
1398
1399         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1400         (TestWebKitAPI::TEST):
1401         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1402         (TestWebKitAPI::TEST):
1403         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1404         (TestWebKitAPI::TEST):
1405
1406 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1407
1408         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1409         https://bugs.webkit.org/show_bug.cgi?id=181359
1410
1411         Reviewed by Tim Horton.
1412
1413         Ensure that these tests still pass using older SDKs.
1414
1415         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1416         (TestWebKitAPI::TEST):
1417
1418 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1419
1420         Rebase API test after r226469
1421         https://bugs.webkit.org/show_bug.cgi?id=181308
1422
1423         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1424         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1425         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1426
1427 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1428
1429         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1430         https://bugs.webkit.org/show_bug.cgi?id=181217
1431
1432         Reviewed by Tim Horton.
1433
1434         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1435         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1436         (TEST):
1437
1438 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1439
1440         Add WKBundleFrameCreateFrameHandle
1441         https://bugs.webkit.org/show_bug.cgi?id=181232
1442         <rdar://problem/35926696>
1443
1444         Reviewed by Tim Horton.
1445
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1448         (mouseDidMoveOverElement):
1449         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1450         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1451         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1452         (TEST):
1453
1454 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1455
1456         iOS: Build fix after r226432.
1457         
1458         Unreviewed. Stop duplicating speakAs symbols for iOS.
1459
1460         * DumpRenderTree/AccessibilityUIElement.cpp:
1461         (AccessibilityUIElement::speakAs):
1462
1463 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1464
1465         Unreviewed, added myself as WebKit reviewer
1466
1467         * Scripts/webkitpy/common/config/contributors.json:
1468
1469 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1470
1471         WPE: Build fix after r226432.
1472
1473         Unreviewed. Rename ::speak() to ::speakAs().
1474         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1475         (WTR::AccessibilityUIElement::speakAs):
1476         (WTR::AccessibilityUIElement::speak): Deleted.
1477
1478 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1479
1480         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1481         https://bugs.webkit.org/show_bug.cgi?id=180361
1482
1483         Reviewed by Zalan Bujtas.
1484
1485         * DumpRenderTree/AccessibilityUIElement.cpp:
1486         (speakAsCallback):
1487         (AccessibilityUIElement::speakAs):
1488         (AccessibilityUIElement::getJSClass):
1489         (speakCallback): Deleted.
1490         (AccessibilityUIElement::speak): Deleted.
1491         * DumpRenderTree/AccessibilityUIElement.h:
1492         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1493         (AccessibilityUIElement::speakAs):
1494         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1495         (AccessibilityUIElement::speakAs):
1496         (AccessibilityUIElement::speak): Deleted.
1497         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1498         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1499         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1500         (WTR::AccessibilityUIElement::speakAs):
1501         (WTR::AccessibilityUIElement::speak): Deleted.
1502         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1503         (WTR::AccessibilityUIElement::speakAs):
1504         (WTR::AccessibilityUIElement::speak): Deleted.
1505
1506 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1507
1508         REGRESSION (r226395): test-webkitperl test expectations incorrect
1509         https://bugs.webkit.org/show_bug.cgi?id=181307
1510         <rdar://problem/36306558>
1511
1512         Rubber-stamped by Aakash Jain.
1513
1514         r226395 added two lines towards the beginning of
1515         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1516         numbers in the test expectations need to update.
1517
1518         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1519
1520 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1521
1522         WKWebView loses minimum layout size overrides that happen while the process is terminated
1523         https://bugs.webkit.org/show_bug.cgi?id=181306
1524         <rdar://problem/34398288>
1525
1526         Reviewed by Dan Bernstein.
1527
1528         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1529         (TEST):
1530         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1531         while the process is terminated results in the page getting the correct
1532         minimum layout size.
1533
1534 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1535
1536         [MediaStream] Add Mock screen capture source
1537         https://bugs.webkit.org/show_bug.cgi?id=181291
1538         <rdar://problem/36298164>
1539
1540         Reviewed by Dean Jackson.
1541
1542         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1543         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1544         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1545
1546 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1547
1548         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1549
1550         Reviewed by Ling Ho.
1551
1552         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1553
1554 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1555
1556         [Attachment Support] Create attachment elements when dropping files on iOS
1557         https://bugs.webkit.org/show_bug.cgi?id=181192
1558         <rdar://problem/36280945>
1559
1560         Reviewed by Tim Horton.
1561
1562         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1563         switch is enabled. See below for more details.
1564
1565         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1566         (-[NSItemProvider registerData:type:]):
1567         (platformCopyPNG):
1568         (TestWebKitAPI::TEST):
1569         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1570
1571         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1572         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1573         kUTTypeRTF instead.
1574
1575         (TestWebKitAPI::TEST):
1576
1577         Tests a few cases of inserting attachment elements via drop:
1578         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1579             Instead of inserting the contents as inline web content, this should generate attachment elements.
1580         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1581             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1582             back to inserting the content as an attachment.
1583         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1584             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1585             or at the end).
1586
1587         * TestWebKitAPI/cocoa/TestWKWebView.h:
1588         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1589         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1590
1591         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1592         -stringByEvaluatingJavaScript to just turn around and call this.
1593
1594         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1595
1596 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1597
1598         Replace hard-coded paths in shebangs with #!/usr/bin/env
1599         https://bugs.webkit.org/show_bug.cgi?id=181040
1600
1601         Reviewed by Alex Christensen.
1602
1603         * BuildSlaveSupport/build-launcher-app:
1604         * BuildSlaveSupport/build-launcher-dmg:
1605         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1606         * BuildSlaveSupport/built-product-archive:
1607         * BuildSlaveSupport/clean-build:
1608         * BuildSlaveSupport/delete-stale-build-files:
1609         * BuildSlaveSupport/download-built-product:
1610         * BuildSlaveSupport/gtk/buildbot/log/run:
1611         * BuildSlaveSupport/gtk/buildbot/run:
1612         * BuildSlaveSupport/gtk/pulseaudio/run:
1613         * BuildSlaveSupport/kill-old-processes:
1614         * BuildSlaveSupport/test-result-archive:
1615         * BuildSlaveSupport/win/kill-old-processes:
1616         * Scripts/SpacingHeuristics.pm:
1617         * Scripts/add-include:
1618         * Scripts/build-api-tests:
1619         * Scripts/build-dumprendertree:
1620         * Scripts/build-imagediff:
1621         * Scripts/build-jsc:
1622         * Scripts/build-webkit:
1623         * Scripts/build-webkittestrunner:
1624         * Scripts/check-Xcode-source-file-types:
1625         * Scripts/check-dom-results:
1626         * Scripts/check-for-exit-time-destructors:
1627         * Scripts/check-for-global-initializers:
1628         * Scripts/check-for-inappropriate-objc-class-names:
1629         * Scripts/check-for-weak-vtables-and-externals:
1630         * Scripts/clean-header-guards:
1631         * Scripts/compare-timing-files:
1632         * Scripts/configure-xcode-for-ios-development:
1633         * Scripts/copy-webkitlibraries-to-product-directory:
1634         * Scripts/create-exports:
1635         * Scripts/debug-minibrowser:
1636         * Scripts/debug-safari:
1637         * Scripts/debug-test-runner:
1638         * Scripts/do-file-rename:
1639         * Scripts/do-webcore-rename:
1640         * Scripts/dump-webkit-tests-run:
1641         * Scripts/ensure-valid-python:
1642         * Scripts/execAppWithEnv:
1643         * Scripts/extract-localizable-js-strings:
1644         * Scripts/filter-build-webkit:
1645         * Scripts/find-extra-includes:
1646         * Scripts/fix-blink-patch:
1647         * Scripts/generate-coverage-data:
1648         * Scripts/git-add-reviewer:
1649         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1650         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1651         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1652         * Scripts/make-new-script-test:
1653         * Scripts/make-script-test-wrappers:
1654         * Scripts/package-root:
1655         * Scripts/parse-malloc-history:
1656         * Scripts/report-include-statistics:
1657         * Scripts/resolve-ChangeLogs:
1658         * Scripts/run-api-tests:
1659         * Scripts/run-bindings-tests:
1660         * Scripts/run-content-extension-tester:
1661         * Scripts/run-iexploder-tests:
1662         * Scripts/run-javascriptcore-tests:
1663         * Scripts/run-jsc:
1664         * Scripts/run-leaks:
1665         * Scripts/run-mangleme-tests:
1666         * Scripts/run-minibrowser:
1667         * Scripts/run-pageloadtest:
1668         * Scripts/run-regexp-tests:
1669         * Scripts/run-safari:
1670         * Scripts/run-sunspider:
1671         * Scripts/run-test-runner:
1672         * Scripts/run-webkit-app:
1673         * Scripts/run-webkit-httpd:
1674         * Scripts/run-webkit-websocketserver:
1675         * Scripts/set-webkit-configuration:
1676         * Scripts/show-pretty-diff:
1677         * Scripts/sort-Xcode-project-file:
1678         * Scripts/split-file-by-class:
1679         * Scripts/sunspider-compare-results:
1680         * Scripts/svn-apply:
1681         * Scripts/svn-unapply:
1682         * Scripts/test-webkit-scripts:
1683         * Scripts/test-webkitperl:
1684         * Scripts/update-iexploder-cssproperties:
1685         * Scripts/update-javascriptcore-test-results:
1686         * Scripts/update-webkit:
1687         * Scripts/update-webkit-auxiliary-libs:
1688         * Scripts/update-webkit-dependency:
1689         * Scripts/update-webkit-libs-jhbuild:
1690         * Scripts/update-webkit-localizable-strings:
1691         * Scripts/update-webkit-support-libs:
1692         * Scripts/update-webkitgtk-libs:
1693         * Scripts/update-webkitwpe-libs:
1694         * Scripts/webkit-build-directory:
1695         * Scripts/webkitperl/LoadAsModule.pm:
1696         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1697         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1698         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1699         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1700         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1701         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1702         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1703         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1704         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1705         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1706         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1707         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1708         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1709         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1710         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1711         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1712         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1713         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1714         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1715         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1716         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1717         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1718         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1719         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1720         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1721         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1722         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1723         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1724         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1725         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1726         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1727         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1728         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1729         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1730         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1731         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1732         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1733         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1734         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1735         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1736         * ccache/ccache-clang:
1737         * ccache/ccache-clang++:
1738         * ccache/ccache-wrapper:
1739         * gtk/install-dependencies:
1740         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1741         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1742         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1743         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1744         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1745         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1746         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1747         * iExploder/iexploder-1.7.2/src/webserver.rb:
1748         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1749         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1750         * wpe/install-dependencies:
1751
1752 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1753
1754         filter-build-webkit filters out useful compiler error lines
1755         https://bugs.webkit.org/show_bug.cgi?id=179864
1756
1757         Reviewed by Tim Horton.
1758
1759         Don't filter out lines that contain information about build errors by always showing lines
1760         after a line that contains "note:" or "error:".
1761
1762         * Scripts/filter-build-webkit:
1763         (shouldShowSubsequentLine):
1764         (shouldIgnoreLine):
1765
1766 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1767
1768         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1769         https://bugs.webkit.org/show_bug.cgi?id=173915
1770
1771         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1772         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1773         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1774         empty string in this case.
1775
1776         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1777         (emitFormSubmissionEvent):
1778
1779 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1780
1781         [GTK] Add web process API to detect when form is submitted via JavaScript
1782         https://bugs.webkit.org/show_bug.cgi?id=173915
1783
1784         Reviewed by Carlos Garcia Campos.
1785
1786         Test it.
1787
1788         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1789         (FormSubmissionTest::FormSubmissionTest):
1790         (FormSubmissionTest::~FormSubmissionTest):
1791         (FormSubmissionTest::testFormSubmissionResult):
1792         (FormSubmissionTest::willSendDOMEventCallback):
1793         (FormSubmissionTest::willCompleteCallback):
1794         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1795         (testWebExtensionFormSubmissionSteps):
1796         (beforeAll):
1797         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1798         (DelayedSignal::DelayedSignal):
1799         (emitFormSubmissionEvent):
1800         (handleFormSubmissionCallback):
1801         (willSubmitFormCallback):
1802         (pageCreatedCallback):
1803
1804 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1805
1806         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1807         https://bugs.webkit.org/show_bug.cgi?id=181251
1808
1809         * Scripts/run-gtk-tests:
1810         (GtkTestRunner):
1811
1812 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1813
1814         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1815         https://bugs.webkit.org/show_bug.cgi?id=181136
1816
1817         * Scripts/run-gtk-tests:
1818         (GtkTestRunner):
1819
1820 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1821
1822         [macOS, iOS] Adopt new secure coding APIs in WebKit
1823         https://bugs.webkit.org/show_bug.cgi?id=181085
1824         <rdar://problem/34837397>
1825
1826         Reviewed by Tim Horton.
1827
1828         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1829         capable of supporting NSSecureCoding, so pass through the current coding routines.
1830
1831         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1832         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1833         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1834         routines if necessary.
1835         (TEST): Updated for NSSecureCoding.
1836         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1837         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1838
1839 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1840
1841         Remove std::chrono completely
1842         https://bugs.webkit.org/show_bug.cgi?id=181186
1843
1844         Reviewed by Alex Christensen.
1845
1846         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1847         (WTR::TestController::platformRunUntil):
1848
1849 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1850
1851         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1852         https://bugs.webkit.org/show_bug.cgi?id=181231
1853
1854         Reviewed by Alex Christensen.
1855
1856         Implement TestController APIs needed by ResourceLoadStatistics tests.
1857
1858         * WebKitTestRunner/TestController.cpp:
1859         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1860         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1861
1862 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1863
1864         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1865         https://bugs.webkit.org/show_bug.cgi?id=181219
1866
1867         Reviewed by Wenson Hsieh.
1868
1869         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1870
1871 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1872
1873         Add a WebAuthentication runtime feature flag
1874         https://bugs.webkit.org/show_bug.cgi?id=181220
1875         <rdar://problem/36055305>
1876
1877         Reviewed by Brent Fulgham.
1878
1879         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1880
1881         * DumpRenderTree/TestOptions.h:
1882         * DumpRenderTree/TestOptions.mm:
1883         (TestOptions::TestOptions):
1884         * DumpRenderTree/mac/DumpRenderTree.mm:
1885         (enableExperimentalFeatures):
1886         (setWebPreferencesForTestOptions):
1887         * WebKitTestRunner/TestController.cpp:
1888         (WTR::TestController::resetPreferencesToConsistentValues):
1889         (WTR::updateTestOptionsFromTestHeader):
1890         * WebKitTestRunner/TestOptions.h:
1891         (WTR::TestOptions::hasSameInitializationOptions const):
1892
1893 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1894
1895         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1896         https://bugs.webkit.org/show_bug.cgi?id=181143
1897         <rdar://problem/36200381>
1898
1899         Reviewed by Tim Horton.
1900
1901         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1902         attachment elements are enabled.
1903
1904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1905         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1906         (TestWebKitAPI::TEST):
1907
1908 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1909
1910         Update Credential Management API for WebAuthentication
1911         https://bugs.webkit.org/show_bug.cgi?id=181082
1912         <rdar://problem/36055239>
1913
1914         Reviewed by Brent Fulgham.
1915
1916         Enable Credential Management API for testing.
1917
1918         * DumpRenderTree/TestOptions.h:
1919         * WebKitTestRunner/TestOptions.h:
1920
1921 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1922
1923         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1924         https://bugs.webkit.org/show_bug.cgi?id=168194
1925
1926         Reviewed by Carlos Garcia Campos.
1927
1928         Fix an assertion and unskip the test. The order that form controls are associated is not
1929         guaranteed.
1930
1931         * Scripts/run-gtk-tests:
1932         (GtkTestRunner):
1933         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1934         (didAssociateFormControlsCallback):
1935
1936 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1937
1938         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1939         https://bugs.webkit.org/show_bug.cgi?id=180897
1940         <rdar://problem/35535328>
1941
1942         Reviewed by Brent Fulgham.
1943
1944         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1945
1946         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1947         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1948         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1949         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1950         (websiteDataStoreTestWebView):
1951         (TEST):
1952
1953 == Rolled over to ChangeLog-2018-01-01 ==