0918c04d62e31e64db96a0b21f6df66228996c4a
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
2
3         Fix the update_webgl_conformance_tests.py script in order to enable it
4         to detect the SCM being used correctly.
5         https://bugs.webkit.org/show_bug.cgi?id=77462
6
7         Reviewed by Kenneth Russell.
8
9         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
10         (default_out_dir):
11
12 2012-01-31  Eric Seidel  <eric@webkit.org>
13
14         webkit-patch apply-from-bug should work regardless of your CWD
15         https://bugs.webkit.org/show_bug.cgi?id=77482
16
17         Reviewed by Adam Barth.
18
19         webkit-patch only ever works with patches made from the root
20         directory.  We should pass the CWD to svn-apply in the case
21         where we're running not from the webkit root.  I believe
22         this used to work in the past and regressed.
23
24         * Scripts/webkitpy/common/checkout/checkout.py:
25         (Checkout.apply_patch):
26         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
27         (CheckoutTest.test_apply_patch):
28
29 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
30
31         Unreviewed, rolling out r106302.
32         http://trac.webkit.org/changeset/106302
33         https://bugs.webkit.org/show_bug.cgi?id=77472
34
35         Broke building DRT before running the tests (Requested by ojan
36         on #webkit).
37
38         * Scripts/webkit-build-directory:
39         * Scripts/webkitpy/layout_tests/port/config.py:
40         (Config.build_directory):
41         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
42         (main):
43         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
44         (ConfigTest.assert_configuration):
45         (ConfigTest.test_build_directory.mock_webkit_build_directory):
46         (ConfigTest.test_build_directory):
47         (ConfigTest.test_default_configuration__notfound):
48         * Scripts/webkitpy/layout_tests/port/webkit.py:
49         (WebKitPort._build_path):
50
51 2012-01-31  Antoine Labour  <piman@chromium.org>
52
53         Merge WebGraphicsContext3D creation and initialization, and move it to
54         WebViewClient.
55         https://bugs.webkit.org/show_bug.cgi?id=76593
56
57         Reviewed by Darin Fisher.
58
59         * DumpRenderTree/chromium/TestWebPlugin.cpp:
60         (TestWebPlugin::TestWebPlugin):
61         (TestWebPlugin::initialize):
62         * DumpRenderTree/chromium/TestWebPlugin.h:
63         * DumpRenderTree/chromium/WebViewHost.cpp:
64         (WebViewHost::createGraphicsContext3D):
65         (WebViewHost::createPlugin):
66         * DumpRenderTree/chromium/WebViewHost.h:
67
68 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
69
70         [GTK] build-webkit warning.
71         https://bugs.webkit.org/show_bug.cgi?id=77411
72
73         Reviewed by Philippe Normand.
74
75         * Scripts/webkitdirs.pm:
76         (isCrossCompilation):
77
78 2012-01-31  Dan Bernstein  <mitz@apple.com>
79
80         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
81
82         Reviewed by Anders Carlsson.
83
84         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
85
86 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
87
88         If the QTDIR environment variable is set, the build system fails to compile WinCairo
89         https://bugs.webkit.org/show_bug.cgi?id=77112
90
91         Reviewed by Daniel Bates.
92
93         * Scripts/webkitdirs.pm:
94         (determineIsQt):
95
96 2012-01-31  Adam Roben  <aroben@apple.com>
97
98         Only call -typingAttributes on WebViews, not WebHTMLViews
99
100         Looks like this case was just missed in r105908.
101
102         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
103
104         Reviewed by Antti Koivisto.
105
106         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
107         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
108         earlier.
109
110 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
111
112         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
113         https://bugs.webkit.org/show_bug.cgi?id=77221
114
115         Reviewed by Kenneth Rohde Christiansen.
116
117         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
118
119         * MiniBrowser/qt/MiniBrowserApplication.cpp:
120         (MiniBrowserApplication::sendTouchEvent):
121
122 2012-01-26  Hans Wennborg  <hans@chromium.org>
123
124         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
125         https://bugs.webkit.org/show_bug.cgi?id=77083
126
127         Reviewed by Darin Fisher.
128
129         Add MockWebSpeechInputController which provides a mock implementation
130         of the WebSpeechInputController interface, and use that in
131         DumpRenderTree.
132
133         * DumpRenderTree/DumpRenderTree.gypi:
134         * DumpRenderTree/chromium/LayoutTestController.cpp:
135         (LayoutTestController::addMockSpeechInputResult):
136         * DumpRenderTree/chromium/LayoutTestController.h:
137         ():
138         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
139         (MockWebSpeechInputController::create):
140         (MockWebSpeechInputController::addMockRecognitionResult):
141         (MockWebSpeechInputController::clearResults):
142         (MockWebSpeechInputController::startRecognition):
143         (MockWebSpeechInputController::cancelRecognition):
144         (MockWebSpeechInputController::stopRecording):
145         (MockWebSpeechInputController::MockWebSpeechInputController):
146         (MockWebSpeechInputController::speechTaskFired):
147         (MockWebSpeechInputController::SpeechTask::SpeechTask):
148         (MockWebSpeechInputController::SpeechTask::stop):
149         (MockWebSpeechInputController::SpeechTask::runIfValid):
150         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
151         (WebKit):
152         (MockWebSpeechInputController):
153         (MockWebSpeechInputController::taskList):
154         (SpeechTask):
155         * DumpRenderTree/chromium/TestShell.cpp:
156         * DumpRenderTree/chromium/WebViewHost.cpp:
157         (WebViewHost::speechInputController):
158         * DumpRenderTree/chromium/WebViewHost.h:
159         (WebKit):
160         (WebViewHost::speechInputControllerMock):
161         (WebViewHost):
162         ():
163
164 2012-01-31  Hajime Morrita  <morrita@chromium.org>
165
166         [PerformanceTests] Add landing html for Dromaeo dom-query test
167         https://bugs.webkit.org/show_bug.cgi?id=77329
168
169         Reviewed by Ryosuke Niwa.
170
171         Added some more ignorable output patterns to allow warnings
172         from a third party test suite.
173
174         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
175         (PerfTestsRunner):
176         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
177
178 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
179
180         [wx] Unreviewed. Update download URLs to new domain.
181         
182         * waf/build/build_utils.py:
183         (update_wx_deps):
184
185 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
186
187         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
188         to the list of build directories.
189         
190         * waf/build/settings.py:
191
192 2012-01-30  Kentaro Hara  <haraken@chromium.org>
193
194         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
195         output an empty method name (i.e. "()")
196         https://bugs.webkit.org/show_bug.cgi?id=77336
197
198         Reviewed by Darin Adler.
199
200         r105797 tried to detect a change outside methods, but it causes a bug that
201         prepare-ChangeLog can output an empty method name, like this:
202
203             * foo/bar/baz.cpp:
204             (method1):
205             ():
206             (method2):
207
208         This is because the cpp parser in prepare-ChangeLog cannot distinguish
209         '{' as the beginning of a method with '{' as the beginning of an array definition
210         at the top level.
211
212             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
213
214             void func() { // This '{' is the beginning of a method.
215                 ...;
216             }
217
218         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
219
220         * Scripts/prepare-ChangeLog:
221         (get_function_line_ranges_for_cpp): Modified as described above.
222         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
223         an empty method name. Ideally this should not happen but may happen, since the
224         parsers are not perfect.
225         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
226         (NameSpace7):
227         (NameSpace8):
228         (Class109):
229         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
230
231 2012-01-30  Ojan Vafai  <ojan@chromium.org>
232
233         run-webkit-tests calls out to webkit-build-directory twice
234         https://bugs.webkit.org/show_bug.cgi?id=77248
235
236         Reviewed by Dirk Pranke.
237
238         This reduces to calls to webkit-build-directory to one call and
239         saves 500ms for run-webkit-tests over a single file.
240
241         * Scripts/webkit-build-directory:
242         If called with no arguments, print out both the top-level directory and the 
243         configuration directory.
244
245         * Scripts/webkit-build-directory:
246         * Scripts/webkitpy/layout_tests/port/config.py:
247         (Config.build_directory):
248         When called with no arguments, get and cache both the top-level and configuration directories.
249
250         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
251         (main):
252         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
253         (ConfigTest.assert_configuration):
254         (ConfigTest.test_build_directory.mock_webkit_build_directory):
255         (ConfigTest.test_build_directory):
256         (ConfigTest.test_default_configuration__notfound):
257         * Scripts/webkitpy/layout_tests/port/webkit.py:
258         (WebKitPort._build_path):
259         Cache the root directory in the options object so that other users
260         of the options object don't need to call out to webkit-build-directory.
261
262 2012-01-30  Ojan Vafai  <ojan@chromium.org>
263
264         Parsing test_expecations.txt + Skipped lists takes too long
265         https://bugs.webkit.org/show_bug.cgi?id=77059
266
267         Reviewed by Dirk Pranke.
268
269         This saves ~100ms on the Apple Mac port.
270         -memoize a bunch of path methods.
271         -Avoid doing multiple disk accesses per line.
272         -Parse the skipped list directly instead of turning it into a test_expecations.txt
273         formatting string and parsing that.
274
275         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
276         (TestExpectationParser):
277         (TestExpectationParser.expectation_for_skipped_test):
278         (TestExpectationParser._parse_line):
279         (TestExpectationParser._collect_matching_tests):
280         (TestExpectations.__init__):
281         (TestExpectations._add_skipped_tests):
282         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
283         (test_add_skipped_tests):
284         (test_add_skipped_tests_duplicate):
285         * Scripts/webkitpy/layout_tests/port/base.py:
286         (Port):
287         (Port.test_isfile):
288         (Port.normalize_test_name):
289         (Port.layout_tests_dir):
290         (Port.abspath_for_test):
291         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
292
293 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
294
295         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
296         
297         * Scripts/webkitpy/common/config/watchlist:
298
299 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
300
301         Unreviewed build fix following bug#76855
302
303         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
304         ():
305         (TestWebKitAPI::TEST_F):
306
307 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
308
309         [Qt] WKTR: Use a software rendering pipiline when running tests.
310         https://bugs.webkit.org/show_bug.cgi?id=76708
311
312         Reviewed by Kenneth Rohde Christiansen.
313
314         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
315         (WTR::WrapperWindow::WrapperWindow):
316         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
317
318 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
319
320         [Qt] Store build config immediately instead of waiting for a successfull build
321
322         Otherwise we will not pick up changes to the config if the build is aborted,
323         for example due to build errors or if the user pressed Ctrl+Z. We now write
324         the new config before starting a build, but still defer to write the SVN
325         revision once the build completes successfully.
326
327         Reviewed by Ossy.
328
329         * Scripts/webkitdirs.pm:
330         (buildQMakeProjects):
331
332 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
333
334         [Qt] Add "New Window" button to the Qt MiniBrowser
335         https://bugs.webkit.org/show_bug.cgi?id=77281
336
337         Reviewed by Tor Arne Vestbø.
338
339         * MiniBrowser/qt/BrowserWindow.cpp:
340         (BrowserWindow::BrowserWindow):
341         * MiniBrowser/qt/MiniBrowser.qrc:
342         * MiniBrowser/qt/icons/plus.png: Added.
343         * MiniBrowser/qt/qml/BrowserWindow.qml:
344
345 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
346
347         Unreviewed rolling out r106222.
348
349         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
350         (SingleTestRunner.__init__):
351         * Scripts/webkitpy/layout_tests/controllers/worker.py:
352         (Worker.handle_test_list):
353         * Scripts/webkitpy/layout_tests/models/test_input.py:
354         (TestInput.__init__):
355         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
356         (_set_up_derived_options):
357         (parse_args):
358         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
359         (MainTest.test_repeat_each):
360         * WebKitTestRunner/TestInvocation.cpp:
361         (WTR::TestInvocation::setIsPixelTest):
362
363 2012-01-30  Hans Wennborg  <hans@chromium.org>
364
365         Unreviewed, rolling out r106219.
366         http://trac.webkit.org/changeset/106219
367         https://bugs.webkit.org/show_bug.cgi?id=77083
368
369         This broke Chromium's test_shell.
370
371         * DumpRenderTree/DumpRenderTree.gypi:
372         * DumpRenderTree/chromium/LayoutTestController.cpp:
373         (LayoutTestController::addMockSpeechInputResult):
374         * DumpRenderTree/chromium/LayoutTestController.h:
375         (WebKit):
376         (LayoutTestController):
377         ():
378         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
379         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
380         * DumpRenderTree/chromium/TestShell.cpp:
381         * DumpRenderTree/chromium/WebViewHost.cpp:
382         (WebViewHost::speechInputController):
383         * DumpRenderTree/chromium/WebViewHost.h:
384         (WebKit):
385         (WebViewHost::speechInputControllerMock):
386         (WebViewHost):
387         ():
388
389 2012-01-26  Hans Wennborg  <hans@chromium.org>
390
391         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
392         https://bugs.webkit.org/show_bug.cgi?id=77083
393
394         Reviewed by Darin Fisher.
395
396         Add MockWebSpeechInputController which provides a mock implementation
397         of the WebSpeechInputController interface, and use that in
398         DumpRenderTree.
399
400         * DumpRenderTree/DumpRenderTree.gypi:
401         * DumpRenderTree/chromium/LayoutTestController.cpp:
402         (LayoutTestController::addMockSpeechInputResult):
403         * DumpRenderTree/chromium/LayoutTestController.h:
404         ():
405         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
406         (MockWebSpeechInputController::create):
407         (MockWebSpeechInputController::addMockRecognitionResult):
408         (MockWebSpeechInputController::clearResults):
409         (MockWebSpeechInputController::startRecognition):
410         (MockWebSpeechInputController::cancelRecognition):
411         (MockWebSpeechInputController::stopRecording):
412         (MockWebSpeechInputController::MockWebSpeechInputController):
413         (MockWebSpeechInputController::speechTaskFired):
414         (MockWebSpeechInputController::SpeechTask::SpeechTask):
415         (MockWebSpeechInputController::SpeechTask::stop):
416         (MockWebSpeechInputController::SpeechTask::runIfValid):
417         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
418         (WebKit):
419         (MockWebSpeechInputController):
420         (MockWebSpeechInputController::taskList):
421         (SpeechTask):
422         * DumpRenderTree/chromium/TestShell.cpp:
423         * DumpRenderTree/chromium/WebViewHost.cpp:
424         (WebViewHost::speechInputController):
425         * DumpRenderTree/chromium/WebViewHost.h:
426         (WebKit):
427         (WebViewHost::speechInputControllerMock):
428         (WebViewHost):
429         ():
430
431 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
432
433         Unreviewed, rolling out r106109.
434         http://trac.webkit.org/changeset/106109
435         https://bugs.webkit.org/show_bug.cgi?id=77302
436
437         It made tests crash (Requested by Ossy_weekend on #webkit).
438
439         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
440         (WTR::WrapperWindow::WrapperWindow):
441         (WTR::PlatformWebView::PlatformWebView):
442
443 2012-01-28  Nico Weber  <thakis@chromium.org>
444
445         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
446         https://bugs.webkit.org/show_bug.cgi?id=77243
447
448         Reviewed by Adam Barth.
449
450         * Scripts/update-webkit:
451         * Scripts/webkitdirs.pm:
452         (isChromiumNinja):
453         (determineIsChromiumNinja):
454         (buildChromiumNinja):
455         (buildChromium):
456
457 2012-01-27  Kentaro Hara  <haraken@chromium.org>
458
459         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
460         https://bugs.webkit.org/show_bug.cgi?id=77241
461
462         Reviewed by Ryosuke Niwa.
463
464         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
465         in a method in some namespace or class is treated as a method.
466         This patch fixes the bug.
467
468             class C {
469                 void func()
470                 {
471                     if (1) {    // This should not be treated as a method.
472                     }
473                 }
474             };
475
476         * Scripts/prepare-ChangeLog:
477         (get_function_line_ranges_for_cpp):
478         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
479         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
480         (Class108):
481         (Class108::func35):
482
483 2012-01-27  Enrica Casucci  <enrica@apple.com>
484
485         Followup to http://trac.webkit.org/changeset/106171.
486         Dan Bernstein pointed out correctly that I should
487         have used copy instead of initWithString.
488
489         Reviewed by Dan Bernstein.
490
491         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
492         (-[LocalPasteboard initWithName:]):
493
494 2012-01-27  Enrica Casucci  <enrica@apple.com>
495
496         DRT pasteboard object should return the correct pasteboard name.
497         https://bugs.webkit.org/show_bug.cgi?id=77260
498         
499         Currently the name property always returns nil.
500         Adding a memeber variable to store the pasteboard name and return its
501         value from the name method instead of returning nil always.
502
503         Reviewed by Dan Bernstein.
504
505         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
506         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
507         (-[LocalPasteboard initWithName:]):
508         (-[LocalPasteboard name]):
509
510 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
511
512         [GTK] [WK2] Implement the policy client
513         https://bugs.webkit.org/show_bug.cgi?id=76343
514
515         Reviewed by Gustavo Noronha Silva.
516
517         * gtk/generate-gtkdoc:
518         (get_webkit2_options): Update the list of skipped source files to include all clients.
519
520 2012-01-27  Ada Chan  <adachan@apple.com>
521
522         Add test for WKBundleFrameGetParentFrame().
523         https://bugs.webkit.org/show_bug.cgi?id=77161
524
525         Reviewed by Anders Carlsson.
526
527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
528         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
529         (TestWebKitAPI):
530         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
531         (TestWebKitAPI::setInjectedBundleClient):
532         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
533         Make sure the check is successful.
534         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
535         (TestWebKitAPI):
536         (ParentFrameTest):
537         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
538         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
539         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
540         to the test controller.
541         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
542
543 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
544
545         [Gtk] DumpRenderTree lacks --no-timeout command line option
546         https://bugs.webkit.org/show_bug.cgi?id=77196
547
548         Reviewed by Martin Robinson.
549
550         Add the --no-timeout command line option and reorganize
551         watchdog code to make running DumpRenderTree without
552         timeout possible.
553
554         * DumpRenderTree/gtk/DumpRenderTree.cpp:
555         (setWaitToDumpWatchdog):
556         (shouldSetWaitToDumpWatchdog):
557         (initializeGlobalsFromCommandLineOptions):
558         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
559         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
560         (waitToDumpWatchdogFired):
561         (LayoutTestController::setWaitToDump):
562
563 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
564
565         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
566         https://bugs.webkit.org/show_bug.cgi?id=77122
567
568         Reviewed by Kenneth Rohde Christiansen.
569
570         * MiniBrowser/qt/MiniBrowserApplication.cpp:
571         (MiniBrowserApplication::MiniBrowserApplication):
572
573 2012-01-27  Zeno Albisser  <zeno@webkit.org>
574
575         [Qt][Mac] Build fails after adding ICU support (r105997).
576         https://bugs.webkit.org/show_bug.cgi?id=77118
577
578         Define WTF_USE_ICU_UNICODE if we are on mac.
579
580         Reviewed by Tor Arne Vestbø.
581
582         * qmake/mkspecs/features/features.prf:
583
584 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
585
586         Update committers.py with new contributors.
587         https://bugs.webkit.org/show_bug.cgi?id=77207
588
589         I added six new contributors into committers.py:
590
591         - Adam Kallai
592         - Balazs Ankes
593         - Janos Badics
594         - Nandor Huszka
595         - Roland Takacs
596         - Szilard Ledan-Muntean
597
598         * Scripts/webkitpy/common/config/committers.py:
599
600 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
601
602         Add Vsevolod Vlasov to reviewers list.
603
604         Reviewed by Pavel Feldman.
605
606         * Scripts/webkitpy/common/config/committers.py:
607
608 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
609
610         [Qt] WKTR: Use a software rendering pipiline when running tests.
611         https://bugs.webkit.org/show_bug.cgi?id=76708
612
613         Reviewed by Kenneth Rohde Christiansen.
614
615         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
616         (WTR::WrapperWindow::WrapperWindow):
617         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
618
619 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
620
621         [wx] Unreviewed. Build fix, add WebCore/testing/js
622         to the list of source directories we build.
623
624         * waf/build/settings.py:
625
626 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
627
628         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
629         https://bugs.webkit.org/show_bug.cgi?id=77177
630
631         Reviewed by Jon Honeycutt.
632
633         * Scripts/commit-log-editor:
634
635 2012-01-26  Ojan Vafai  <ojan@chromium.org>
636
637         Decrease sleep time when killing server_process on Mac.
638         https://bugs.webkit.org/show_bug.cgi?id=77169
639
640         Reviewed by Eric Seidel.
641
642         This shaves another ~70ms off single test runtime.
643
644         * Scripts/webkitpy/layout_tests/port/server_process.py:
645         (ServerProcess.stop):
646
647 2012-01-26  Ojan Vafai  <ojan@chromium.org>
648
649         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
650         https://bugs.webkit.org/show_bug.cgi?id=77164
651
652         Reviewed by Dirk Pranke.
653
654         http://trac.webkit.org/changeset/106035 depends on builder_name being
655         falsey by default. There's other code that requires it to be iterable
656         by default. So, make it be the empty string.
657
658         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
659         (parse_args):
660
661 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
662
663         run-perf-test should include relative file paths in test names
664         https://bugs.webkit.org/show_bug.cgi?id=77144
665
666         Reviewed by Adam Birth.
667
668         Include all directory names in the test name separated by "/".
669         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
670
671         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
672         (PerfTestsRunner):
673         (PerfTestsRunner._process_parser_test_result):
674         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
675         (test_run_test_set_with_json_output):
676         (test_run_test_set_with_json_source):
677
678 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
679
680         webkitpy: re-land cleanup of test scaffolding
681         https://bugs.webkit.org/show_bug.cgi?id=77153
682
683         Reviewed by Eric Seidel.
684
685         This is an attempt to reland the change in bug 76973 / 
686         r105935. My earlier attempt to manipulate PYTHONPATH
687         seems to only work some of the time, for reasons that
688         elude me. Directly adding Tools/Scripts to sys.path from
689         inside the test script appears to work (more?) reliably.
690
691         Also, it seemed like the files didn't actually get deleted
692         the last time; I don't know why.
693
694         * Scripts/test-webkitpy:
695         * Scripts/webkitpy/common/system/executive_unittest.py:
696         (command_line):
697         (ExecutiveTest):
698         (ExecutiveTest.test_run_command_args_type):
699         (ExecutiveTest.test_run_command_with_unicode):
700         (ExecutiveTest.test_running_pids):
701         (main):
702         * Scripts/webkitpy/common/system/fileutils.py: Removed.
703         * Scripts/webkitpy/test/cat.py: Removed.
704         * Scripts/webkitpy/test/cat_unittest.py: Removed.
705         * Scripts/webkitpy/test/echo.py: Removed.
706         * Scripts/webkitpy/test/echo_unittest.py: Removed.
707
708 2012-01-26  Ojan Vafai  <ojan@chromium.org>
709
710         run-webkit-tests calls "nm" when it doesn't need to
711         https://bugs.webkit.org/show_bug.cgi?id=77143
712
713         Reviewed by Dirk Pranke.
714
715         If we are not running any test that can be skipped by checking
716         the DRT feature list or looking at the list of symbols, avoid calling
717         out to DRT or calling "nm".
718
719         This saves ~700ms on my Mac Pro. In cases where you still have to call out
720         to "nm" it's only a couple ms slower.
721
722         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
723         (TestExpectations.__init__):
724         * Scripts/webkitpy/layout_tests/port/base.py:
725         (Port.skipped_tests):
726         * Scripts/webkitpy/layout_tests/port/webkit.py:
727         (WebKitPort._should_check_for_missing_features):
728         (WebKitPort):
729         (WebKitPort._should_check_for_missing_symbols):
730         (WebKitPort._skipped_tests_for_unsupported_features):
731         (WebKitPort.skipped_layout_tests):
732         (WebKitPort.skipped_tests):
733         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
734         (WebKitPortTest.test_skipped_directories_for_symbols):
735         (test_skipped_directories_for_features):
736         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
737         (test_skipped_layout_tests):
738
739 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
740
741         Support a suffix on ChangeLog filenames based on a configuration file
742         https://bugs.webkit.org/show_bug.cgi?id=76956
743
744         Reviewed by Kentaro Hara.
745
746         Modify the tools used to generate, edit and resolve ChangeLogs to support
747         the addition of a suffix to the ChangeLog filename.
748
749         This patch makes it easier to support alternate ChangeLog files in branches.
750
751         * Scripts/VCSUtils.pm:
752         (changeLogSuffix):
753         (changeLogFileName):
754         * Scripts/commit-log-editor:
755         * Scripts/prepare-ChangeLog:
756         (getLatestChangeLogs):
757         (generateNewChangeLogs):
758         (generateFileList):
759         * Scripts/resolve-ChangeLogs:
760         (findChangeLog):
761
762 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
763
764         Unreviewed, rolling out r106038.
765         http://trac.webkit.org/changeset/106038
766         https://bugs.webkit.org/show_bug.cgi?id=77142
767
768         Caused a bunch of skipped tests to not be skipped. (Requested
769         by ojan on #webkit).
770
771         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
772         (TestExpectationParser):
773         (TestExpectationParser.parse):
774         (TestExpectationParser._parse_line):
775         (TestExpectationParser._collect_matching_tests):
776         (TestExpectations.__init__):
777         (TestExpectations._add_skipped_tests):
778         * Scripts/webkitpy/layout_tests/port/base.py:
779         (Port.test_dirs):
780         (Port.normalize_test_name):
781         (Port.update_baseline):
782         (Port.layout_tests_dir):
783         (Port.relative_perf_test_filename):
784         (Port.abspath_for_test):
785
786 2012-01-25  Ojan Vafai  <ojan@chromium.org>
787
788         Parsing test_expecations.txt + Skipped lists takes too long
789         https://bugs.webkit.org/show_bug.cgi?id=77059
790
791         Reviewed by Dirk Pranke.
792
793         This saves ~100ms on the Apple Mac port.
794         -memoize a bunch of path methods.
795         -Avoid doing multiple disk accesses per line.
796         -Parse the skipped list directly instead of turning it into a test_expecations.txt
797         formatting string and parsing that.
798
799         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
800         (TestExpectationParser):
801         (TestExpectationParser.parse_skipped_tests):
802         (TestExpectationParser._parse_line):
803         (TestExpectationParser._collect_matching_tests):
804         (TestExpectations.__init__):
805         (TestExpectations._add_skipped_tests):
806         * Scripts/webkitpy/layout_tests/port/base.py:
807         (Port):
808         (Port.test_isfile):
809         (Port.normalize_test_name):
810         (Port.layout_tests_dir):
811         (Port.abspath_for_test):
812
813 2012-01-25  Ojan Vafai  <ojan@chromium.org>
814
815         Only store the SVN revision in the summarized results if we're on a builder
816         https://bugs.webkit.org/show_bug.cgi?id=76976
817
818         Reviewed by Dirk Pranke.
819
820         This shaves another ~130ms off the single test run-webkit-tests runtime.
821
822         * Scripts/webkitpy/layout_tests/controllers/manager.py:
823         (summarize_results):
824         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
825         (ResultSummaryTest.get_result):
826         (ResultSummaryTest):
827         (ResultSummaryTest.get_result_summary):
828         (ResultSummaryTest.get_unexpected_results):
829         (ResultSummaryTest.test_no_svn_revision):
830         (ResultSummaryTest.test_svn_revision):
831         * Scripts/webkitpy/layout_tests/port/base.py:
832         (Port.use_trac_links_in_results_html):
833
834 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
835
836         [Qt][WK2] fast/loader tests failed after r94178
837         https://bugs.webkit.org/show_bug.cgi?id=67388
838
839         Reviewed by Simon Hausmann.
840
841         Applying the same fix used for Qt-WebKit1 from bug #67254 -
842         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
843         https://bugs.webkit.org/show_bug.cgi?id=67254
844         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
845         derived from the running location of DumpRenderTree binary.
846
847         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
848         (WTR::LayoutTestController::pathToLocalResource):
849
850 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
851
852         Implement overridePreference for boolean preferences in WebKitTestRunner
853         https://bugs.webkit.org/show_bug.cgi?id=77033
854
855         Reviewed by Alexey Proskuryakov.
856
857         For now overridePreference supports boolean values.
858
859         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
860         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
861         (WTR::LayoutTestController::setXSSAuditorEnabled):
862         (WTR::LayoutTestController::overridePreference):
863         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
864         * WebKitTestRunner/TestController.cpp:
865         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
866         explicitly and properly disable the use of PageCache when resetting the
867         state. Tests that use PageCache can now enable it via overridePreference.
868
869 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
870
871         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
872         https://bugs.webkit.org/show_bug.cgi?id=77100
873
874         Reviewed by Simon Hausmann.
875
876         This patch makes the MiniBrowser read multiple URL's from the command
877         line such that there will be one browser window opened for each URL.
878
879         * MiniBrowser/qt/MiniBrowserApplication.cpp:
880         (MiniBrowserApplication::handleUserOptions):
881
882 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
883
884         [Qt] The Qt MiniBrowser crashes when given multiple URL's
885         https://bugs.webkit.org/show_bug.cgi?id=77009
886
887         Reviewed by Simon Hausmann.
888
889         This patch fixes a crash in BrowserWindow::newWindow() where a
890         BrowserWindow-object is constructed with a 0 pointer as the
891         WindowOptions parameter which leads to a crash.
892
893         * MiniBrowser/qt/BrowserWindow.cpp:
894         (BrowserWindow::BrowserWindow):
895         (BrowserWindow::newWindow):
896         * MiniBrowser/qt/BrowserWindow.h:
897
898 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
899
900         [Qt] Use ICU if available
901         https://bugs.webkit.org/show_bug.cgi?id=76821
902
903         Reviewed by Simon Hausmann.
904
905         Adding unicode defines for a Qt 5 based build.
906
907         * qmake/mkspecs/features/features.prf:
908
909 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
910
911         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
912         https://bugs.webkit.org/show_bug.cgi?id=42545
913
914         Reviewed by Zoltan Herczeg.
915
916         Implement the setGeolocationPermission method.
917
918         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
919         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
920         (WTR::LayoutTestController::setGeolocationPermission):
921         (WTR):
922         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
923         (LayoutTestController):
924
925 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
926
927         [NRWT] Support --ignore-metrics
928         https://bugs.webkit.org/show_bug.cgi?id=76278
929
930         Reviewed by Tony Chang.
931
932         Port the feature from ORWT.
933
934         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
935         (SingleTestRunner._run_compare_test):
936         * Scripts/webkitpy/layout_tests/port/driver.py:
937         (DriverOutput):
938         (DriverOutput.strip_metrics):
939         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
940         (DriverOutputTest):
941         (DriverOutputTest.test_strip_metrics):
942         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
943         (_set_up_derived_options):
944         (parse_args):
945
946 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
947
948         Unreviewed, rolling out r105935 and r105954.
949         http://trac.webkit.org/changeset/105935
950         http://trac.webkit.org/changeset/105954
951         https://bugs.webkit.org/show_bug.cgi?id=77080
952
953         test-webkitpy is still broken (Requested by abarth on
954         #webkit).
955
956         * Scripts/test-webkitpy:
957         * Scripts/webkitpy/common/system/executive_unittest.py:
958         (never_ending_command):
959         (ExecutiveTest.test_run_command_args_type):
960         (ExecutiveTest.test_run_command_with_unicode):
961         (ExecutiveTest.test_running_pids):
962         * Scripts/webkitpy/common/system/fileutils.py:
963         (make_stdout_binary):
964         * Scripts/webkitpy/test/cat.py:
965         (command_arguments):
966         (main):
967         * Scripts/webkitpy/test/cat_unittest.py:
968         (CatTest):
969         (CatTest.assert_cat):
970         (CatTest.test_basic):
971         (CatTest.test_no_newline):
972         (CatTest.test_unicode):
973         (CatTest.test_as_command):
974         * Scripts/webkitpy/test/echo.py:
975         (command_arguments):
976         (main):
977         * Scripts/webkitpy/test/echo_unittest.py:
978         (EchoTest):
979         (EchoTest.test_basic):
980         (EchoTest.test_no_newline):
981         (EchoTest.test_unicode):
982         (EchoTest.test_argument_order):
983         (EchoTest.test_empty_arguments):
984         (EchoTest.test_no_arguments):
985         (EchoTest.test_as_command):
986
987 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
988
989         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
990         https://bugs.webkit.org/show_bug.cgi?id=76138
991
992         Reviewed by Martin Robinson.
993
994         * Scripts/webkitdirs.pm:
995         (isCrossCompilation):
996         (buildAutotoolsProject):
997
998 2012-01-25  Adam Barth  <abarth@webkit.org>
999
1000         Kentaro is a reviewer now.  Yay!
1001
1002         * Scripts/webkitpy/common/config/committers.py:
1003
1004 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1005
1006         nrwt: running w/ no arguments fails
1007         https://bugs.webkit.org/show_bug.cgi?id=77064
1008
1009         Unreviewed, build fix.
1010
1011         This change fixes a regression introduced in r105944
1012         where running without --platform <foo> or one of the other
1013         platform switches would cause a null deref :(.
1014
1015         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1016         (main):
1017
1018 2012-01-25  Eric Seidel  <eric@webkit.org>
1019
1020         Automatically CC someone from Apple on any changes to Obj-C public API
1021         https://bugs.webkit.org/show_bug.cgi?id=77053
1022
1023         Reviewed by Timothy Hatcher.
1024
1025         This has long been de-facto practice, seems now that we have
1026         fancy watchlist support, we should just make the tools
1027         do this automatically.
1028
1029         * Scripts/webkitpy/common/config/watchlist:
1030
1031 2012-01-25  Antoine Labour  <piman@chromium.org>
1032
1033         Updating status in committers.py.
1034
1035         Unreviewed.
1036
1037         * Scripts/webkitpy/common/config/committers.py:
1038
1039 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1040
1041         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
1042         https://bugs.webkit.org/show_bug.cgi?id=77058
1043
1044         Reviewed by Eric Seidel.
1045
1046         r105935 broke executive_unittest by changing which script we
1047         were running and not ensuring that the PYTHONPATH was set up
1048         properly.
1049
1050         This change also fixes a regression introduced recently where
1051         test-webkitpy wasn't figuring out the path to Tools/Scripts
1052         right, either (so running ./test-webkitpy would fail).
1053
1054         * Scripts/test-webkitpy:
1055         * Scripts/webkitpy/common/system/executive_unittest.py:
1056         (script_dir):
1057         (ExecutiveTest.setUp):
1058         (ExecutiveTest):
1059         (ExecutiveTest.tearDown):
1060
1061 2012-01-25  Adam Barth  <abarth@webkit.org>
1062
1063         Disable tests on the mac-ews while we sort out hte stability issues.
1064
1065         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1066         (MacEWS):
1067
1068 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1069
1070         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
1071         https://bugs.webkit.org/show_bug.cgi?id=76475
1072
1073         Reviewed by Eric Seidel.
1074
1075         This patch cleans up the internal usage of port names for the
1076         Apple mac and Apple win ports so that 'mac' and 'win are never
1077         considered "fully specified" port names: they are still legal
1078         input to the PortFactory.get() routine, but only if run on the given
1079         platform (i.e. trying to PortFactory.get('mac') on windows or
1080         linux will return an error, since we don't know which version of
1081         the port is desired.
1082
1083         This also cleans up handling of the webkit2 variants, so that
1084         the full port names consistently follow the
1085         <operating_system>-<version>[-<wk2>] convention.
1086
1087         Lastly this patch adds some assertions and removes some
1088         try/catch logic to catch more programming and usage errors;
1089         previously mac-tiger might've been allowed -- and it would've
1090         translated into using just the baselines in platform/mac -- but
1091         now it should fail.
1092
1093         * Scripts/webkitpy/layout_tests/port/apple.py:
1094         (ApplePort.determine_full_port_name):
1095         (ApplePort.__init__):
1096         (ApplePort):
1097         (ApplePort._port_name_with_version):
1098         * Scripts/webkitpy/layout_tests/port/builders.py:
1099         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1100         (FactoryTest.test_mac):
1101         (FactoryTest.test_win):
1102         * Scripts/webkitpy/layout_tests/port/mac.py:
1103         (MacPort.baseline_search_path):
1104         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1105         (MacTest.test_versions):
1106         * Scripts/webkitpy/layout_tests/port/win.py:
1107         (WinPort.baseline_search_path):
1108         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1109         (WinTest.test_versions):
1110
1111 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1112
1113         webkitpy: print nicer errors while linting expectations files, remove redundant tests
1114         https://bugs.webkit.org/show_bug.cgi?id=76955
1115
1116         Reviewed by Adam Barth.
1117
1118         This change cleans up the errors that are printed so that the
1119         are more "quickfix" compatible (path:lineno).
1120
1121         Also, there were a bunch of redundant tests between
1122         layout_tests.models.test_expectations_unittest and
1123         style.checkers.test_expectations_unittest. The latter should
1124         just expect the former to do most of the testing.
1125
1126         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1127         (TestExpectationParser._parse_modifiers):
1128         (TestExpectations._report_errors):
1129         (TestExpectations._add_skipped_tests):
1130         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1131         (test_parse_error_nonfatal):
1132         (SemanticTests.test_bad_bugid):
1133         * Scripts/webkitpy/style/checkers/test_expectations.py:
1134         (TestExpectationsChecker.__init__):
1135         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1136         (TestExpectationsTestCase.assert_lines_lint):
1137         (TestExpectationsTestCase.test_valid_expectations):
1138         (TestExpectationsTestCase.test_invalid_expectations):
1139         (TestExpectationsTestCase.test_tab):
1140
1141 2012-01-25  Eric Seidel  <eric@webkit.org>
1142
1143         webkit-patch apply-* should always continue after failures
1144         https://bugs.webkit.org/show_bug.cgi?id=77057
1145
1146         Reviewed by Adam Barth.
1147
1148         As far as I can tell there is only one potential drawback to always
1149         forcing: that if you're somehow in the wrong directory it will create new
1150         directories for new files.  Since webkit-patch always cd's to the root
1151         it seems that's not a drawback.  The drawback of not using --force for
1152         svn-apply, is that it will stop after the first failure, which is rarely
1153         (if ever) the desired behavior.  This just removes the force option
1154         (which was strangely hidden behind --non-interactive).  This should
1155         make for a better user experiance.
1156
1157         * Scripts/webkitpy/common/checkout/checkout.py:
1158         (Checkout.apply_patch):
1159         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1160         (MockCheckout.apply_patch):
1161         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1162         (CheckoutTest.test_chromium_deps):
1163         (CheckoutTest):
1164         (CheckoutTest.test_apply_patch):
1165         * Scripts/webkitpy/tool/commands/download_unittest.py:
1166         (DownloadCommandsTest._default_options):
1167         * Scripts/webkitpy/tool/steps/applypatch.py:
1168         (ApplyPatch.options):
1169         (ApplyPatch.run):
1170         * Scripts/webkitpy/tool/steps/options.py:
1171         (Options):
1172
1173 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1174
1175         nrwt: should be able to run --platform test interactively
1176         https://bugs.webkit.org/show_bug.cgi?id=76959
1177
1178         Reviewed by Adam Barth.
1179
1180         As part of refactoring the Port interfaces, in r103254 I made
1181         passing a Host object to the Port mandatory; previously TestPort
1182         objects would create their own (mock) hosts. However,
1183         new-run-webkit-tests always passed a real Host, not a MockHost,
1184         and so you couldn't run new-run-webkit-tests --platform test
1185         interactively to debug test failures.
1186
1187         This change fixes that by creating a MockHost instead of a real
1188         host if you say --platform test*.
1189
1190         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1191         (main):
1192
1193 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1194
1195         run-webkit-tests --lint-test-files should lint all the ports by default
1196         https://bugs.webkit.org/show_bug.cgi?id=76749
1197
1198         Reviewed by Ojan Vafai.
1199
1200         Currently run-webkit-tests --lint-test-files will only lint the
1201         test_expectations for the single port determined by the command
1202         line options. This is not obvious and can produce unintended results
1203         if you want to lint the chromium port (probably the normal case
1204         for using --lint-test-files) but don't specify a port name or
1205         --chromium.
1206
1207         I think we should probably lint *all* of the ports if no port
1208         name is supplied. This change implements that, and also moves
1209         the linting logic out of the Manager class, since this really
1210         has nothing to do with Managers. It has little to do with
1211         run-webkit-tests, but splitting it into a different script would
1212         introduce compatibility issues. It might make sense to do that
1213         anyway, in a separate patch and combining that with cleaning up
1214         the style checker to share more code.
1215
1216         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1217         (Manager._strip_test_dir_prefix):
1218         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1219         (lint):
1220         (run):
1221         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1222         (LintTest.test_all_configurations): added.
1223         (LintTest.test_lint_test_files): added.
1224         (LintTest.test_lint_test_files__errors): added.
1225         (MainTest.test_lint_test_files): removed.
1226         (MainTest.test_lint_test_files__errors): removed.
1227
1228 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1229
1230         webkitpy: clean up a bunch of test scaffolding
1231         https://bugs.webkit.org/show_bug.cgi?id=76973
1232
1233         Reviewed by Eric Seidel.
1234
1235         There were several helper modules in the webkitpy.test package
1236         that appear to only be used by executive_unittest.py. I am
1237         rolling them all into that file to make that clearer.
1238
1239         * Scripts/webkitpy/common/system/executive_unittest.py:
1240         (ExecutiveTest.test_run_command_args_type):
1241         (ExecutiveTest.test_run_command_with_unicode):
1242         (ExecutiveTest.test_running_pids):
1243         (command_line):
1244         (main):
1245         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1246         * Scripts/webkitpy/test/cat.py: Removed.
1247         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1248         * Scripts/webkitpy/test/echo.py: Removed.
1249         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1250
1251 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
1252
1253         webkitpy: clean up a bunch of test scaffolding
1254         https://bugs.webkit.org/show_bug.cgi?id=76973
1255
1256         Reviewed by Eric Seidel.
1257
1258         There were several helper modules in the webkitpy.test package
1259         that appear to only be used by executive_unittest.py. I am
1260         rolling them all into that file to make that clearer.
1261
1262         * Scripts/webkitpy/common/system/executive_unittest.py:
1263         (ExecutiveTest.test_run_command_args_type):
1264         (ExecutiveTest.test_run_command_with_unicode):
1265         (ExecutiveTest.test_running_pids):
1266         (command_line):
1267         (main):
1268         * Scripts/webkitpy/common/system/fileutils.py: Removed.
1269         * Scripts/webkitpy/test/cat.py: Removed.
1270         * Scripts/webkitpy/test/cat_unittest.py: Removed.
1271         * Scripts/webkitpy/test/echo.py: Removed.
1272         * Scripts/webkitpy/test/echo_unittest.py: Removed.
1273
1274 2012-01-25  Eric Seidel  <eric@webkit.org>
1275
1276         Remove Python 2.5 support from WebKit
1277         https://bugs.webkit.org/show_bug.cgi?id=71593
1278
1279         Reviewed by Adam Barth.
1280
1281         Just removing support from this one core file.
1282         I'll commit the rest of the (large) change once we've
1283         gone 24 hours and seen that no bots have exploded.
1284         We can roll out this one change if we break bots
1285         and then roll in the rest once those bots are fixed.
1286
1287         * Scripts/webkitpy/common/system/executive.py:
1288         (Executive.cpu_count):
1289
1290 2012-01-25  Hajime Morita  <morrita@google.com>
1291
1292         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
1293         https://bugs.webkit.org/show_bug.cgi?id=76863
1294
1295         Reviewed by Dimitri Glazkov.
1296
1297         Added a feature flag.
1298
1299         * Scripts/build-webkit:
1300         * qmake/mkspecs/features/features.prf:
1301
1302 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
1303
1304         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
1305         https://bugs.webkit.org/show_bug.cgi?id=76344
1306
1307         Reviewed by Sam Weinig.
1308
1309         Add a test verifying that the mouse button during policy decisions for
1310         events not triggered by mouse events is NoButton.
1311
1312         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1313         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
1314         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
1315
1316 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1317
1318         run-perf-tests should timeout sooner
1319         https://bugs.webkit.org/show_bug.cgi?id=77026
1320
1321         Reviewed by Adam Barth.
1322
1323         Bump off the timeout from 10 minutes to 4 minutes.
1324
1325         Also use float instead of str in test result values to compress the size of json files bots upload.
1326
1327         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1328         (PerfTestsRunner._parse_args):
1329         (PerfTestsRunner._process_chromium_style_test_result):
1330         (PerfTestsRunner._process_parser_test_result):
1331         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1332         (test_run_test_set_for_parser_tests):
1333         (test_run_test_set_with_json_output):
1334         (test_run_test_set_with_json_source):
1335
1336 2012-01-25  Enrica Casucci  <enrica@apple.com>
1337
1338         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1339         https://bugs.webkit.org/show_bug.cgi?id=76951
1340         <rdar://problem/9325158>
1341
1342         Reviewed by Alexey Proskuryakov.
1343
1344         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
1345         and WebHTMLView.
1346         (TestWebKitAPI::TEST):
1347
1348 2012-01-23  MORITA Hajime  <morrita@google.com>
1349
1350         [Refactoring][Internals] Should have InternalSettings
1351         https://bugs.webkit.org/show_bug.cgi?id=76424
1352
1353         Reviewed by Kent Tamura.
1354
1355         * GNUmakefile.am: Added so new files.
1356
1357 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
1358
1359         webkitpy: new-run-webkit-websocket is broken
1360         https://bugs.webkit.org/show_bug.cgi?id=76999
1361
1362         Reviewed by Dirk Pranke.
1363
1364         r105674 broke new-run-webkit-websocket, since options.chromium
1365         doesn't exist any more. new-run-webkit-httpd was also broken
1366         and already fixed at r105835.
1367         * Scripts/new-run-webkit-websocketserver:
1368         (main):
1369
1370 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1371
1372         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
1373         https://bugs.webkit.org/show_bug.cgi?id=63458
1374
1375         Reviewed by Adam Roben.
1376
1377         Implement the setPopupBlockingEnabled method.
1378
1379         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1380         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1381         (WTR::LayoutTestController::setPopupBlockingEnabled):
1382         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1383
1384 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
1385
1386         [Qt] Cleanup testfonts handling
1387         https://bugs.webkit.org/show_bug.cgi?id=76068
1388
1389         Reviewed by Simon Hausmann.
1390
1391         Factor test font initialization into it's own file  so test
1392         font users can share the implementation by adding the file
1393         to their build.
1394         Use fonts.conf from the test font directory to not require the
1395         current directory to be the WebKit root.
1396         Fix the -use-test-fonts option of QtTestBrowser by initializing
1397         the fonts earlier, before it is too late (namely before calling
1398         show on the main window).
1399
1400         * DumpRenderTree/qt/DumpRenderTree.pro:
1401         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1402         (WebCore::DumpRenderTree::open):
1403         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1404         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
1405         (WebKit::initializeTestFonts):
1406         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
1407         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
1408         we will use the one from the test fonts directory.
1409         * DumpRenderTree/qt/main.cpp:
1410         (main): Fix the ifdefs to make it clear that the code to
1411         set up the Dpi has not been ported to Qt5 yet.
1412         * QtTestBrowser/QtTestBrowser.pro:
1413         * QtTestBrowser/launcherwindow.h:
1414         (WindowOptions::WindowOptions):
1415         * QtTestBrowser/main.cpp:
1416         (launcherMain):
1417         (LauncherApplication::handleUserOptions):
1418         * WebKitTestRunner/InjectedBundle/Target.pri:
1419         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1420         (WTR::activateFonts): Remove the code to set up the Dpi
1421         because it does not work with Qt5.
1422
1423 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
1424
1425         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
1426
1427         Reviewed by Tor Arne Vestø.
1428
1429         Don't require it by making svnRevisionForDirectory return "unknown"
1430         instead of bailing out with an error.
1431
1432         * Scripts/VCSUtils.pm:
1433         (svnRevisionForDirectory):
1434
1435 2012-01-25  Adam Barth  <abarth@webkit.org>
1436
1437         Temporarily disable running the unit tests on the Chromium EWS.  These
1438         tests don't work properly (see
1439         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
1440         blocking the EWS.
1441
1442         * Scripts/webkitpy/common/config/ports.py:
1443         (ChromiumPort):
1444
1445 2012-01-25  Adam Barth  <abarth@webkit.org>
1446
1447         Update results.html version of PixelZoomer
1448         https://bugs.webkit.org/show_bug.cgi?id=76965
1449
1450         Reviewed by Ojan Vafai.
1451
1452         Improve readability as suggested by Ojan.
1453
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1455
1456 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1457
1458         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
1459         https://bugs.webkit.org/show_bug.cgi?id=76899
1460
1461         Reviewed by Martin Robinson.
1462
1463         * gtk/generate-gtkdoc:
1464         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
1465         WebKitLoaderClient.
1466
1467 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1468
1469         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
1470
1471         * BuildSlaveSupport/build.webkit.org-config/config.json:
1472
1473 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1474
1475         WebKit needs public performance tests running on public bots
1476         https://bugs.webkit.org/show_bug.cgi?id=10266
1477
1478         Reviewed by Adam Barth.
1479
1480         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
1481         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
1482
1483         * BuildSlaveSupport/build.webkit.org-config/config.json:
1484         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1485         (RunAndUploadPerfTests):
1486         (RunAndUploadPerfTests.start):
1487         (UploadPerfTestResults):
1488         (BuildAndPerfTestFactory):
1489         (BuildAndPerfTestFactory.__init__):
1490
1491 2012-01-24  Ojan Vafai  <ojan@chromium.org>
1492
1493         Initializing the browser property of the Bugzilla class takes too long
1494         https://bugs.webkit.org/show_bug.cgi?id=76960
1495
1496         Reviewed by Adam Barth.
1497
1498         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
1499         on my Mac Pro.
1500
1501         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1502         (Bugzilla.__init__):
1503         (Bugzilla._get_browser):
1504         (Bugzilla):
1505         (Bugzilla._set_browser):
1506
1507 2012-01-24  Mark Rowe  <mrowe@apple.com>
1508
1509         Death to JavaScriptGlue.
1510
1511         Rubber-stamped by Geoffrey Garen.
1512
1513         * BuildSlaveSupport/build-launcher-app:
1514         (copyNightlyLauncher):
1515         * Scripts/build-webkit:
1516         * Scripts/do-file-rename:
1517         * Scripts/do-webcore-rename:
1518         * Scripts/webkitpy/common/config/build.py:
1519         (_should_file_trigger_build):
1520         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
1521         path in conjunction with a cross-platform path.
1522         (ShouldBuildTest):
1523
1524 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1525
1526         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
1527         https://bugs.webkit.org/show_bug.cgi?id=75836
1528
1529         Reviewed by David Kilzer.
1530
1531         Previously parser_unittests.pl can just test the returned value of
1532         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
1533         parser_unittests.pl so that it also tests the stdout and stderr of
1534         get_function_line_ranges().
1535
1536         This patch adds css_unittests_warning.css, which contains test cases
1537         for warning messages of the CSS parser of prepare-ChangeLog.
1538
1539         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1540         (captureOutput): Captures the stdout and stderr of a given method.
1541         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
1542         string to relative paths.
1543
1544         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
1545         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
1546         (element1):
1547         (element2):
1548         (element3):
1549         (element4):
1550         ():
1551         (element5):
1552         (element6):
1553
1554         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1555         Just updated the test results, i.e. added stdout and stderr results.
1556         No essential changes in the test results.
1557         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
1558         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
1559         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
1560         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
1561         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
1562
1563 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
1564
1565         webkitpy: new-run-webkit-httpd is broken
1566         https://bugs.webkit.org/show_bug.cgi?id=76963
1567
1568         Reviewed by Adam Barth.
1569
1570         r105674 broke new-run-webkit-httpd, since options.chromium
1571         doesn't exist any more. We didn't catch this because we don't
1572         run the integration tests by default anywhere :(.
1573
1574         * Scripts/new-run-webkit-httpd:
1575         (run):
1576         (main):
1577
1578 2012-01-24  Adam Barth  <abarth@webkit.org>
1579
1580         garden-o-matic pixel zoomer should let you look at every pixel of the image
1581         https://bugs.webkit.org/show_bug.cgi?id=76962
1582
1583         Reviewed by Ojan Vafai.
1584
1585         Previously, you couldn't get up to the right and bottom pixels.
1586
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
1588
1589 2012-01-24  Enrica Casucci  <enrica@apple.com>
1590
1591         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
1592         https://bugs.webkit.org/show_bug.cgi?id=76951
1593         <rdar://problem/9325158>
1594
1595         Added test to verify that WebHTMLView supports the typingAttributes method and that it
1596         works as expected.
1597         
1598         Reviewed by Alexey Proskuryakov.
1599
1600         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
1601         (TestWebKitAPI::TEST):
1602
1603 2012-01-24  James Robinson  <jamesr@chromium.org>
1604
1605         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
1606         https://bugs.webkit.org/show_bug.cgi?id=76884
1607
1608         Reviewed by Adam Barth.
1609
1610         * Scripts/webkitpy/tool/bot/irc_command.py:
1611         (Rollout.execute):
1612         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1613         (SheriffIRCBotTest.test_rollout):
1614         (SheriffIRCBotTest.test_revert):
1615         (SheriffIRCBotTest.test_multi_rollout):
1616         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
1617         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
1618         (SheriffIRCBotTest.test_rollout_invalidate_reason):
1619         (test_multi_rollout_invalidate_reason):
1620
1621 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1622
1623         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
1624         https://bugs.webkit.org/show_bug.cgi?id=75531
1625
1626         Reviewed by David Kilzer.
1627
1628         Previously, the cpp parser of prepare-ChangeLog could not detect a change
1629         outside methods. Consider the following cpp file.
1630
1631             namespace N {
1632             int a;     // this change does not appear on ChangeLog.
1633             class C {
1634                 int b;     // this change does not appear on ChangeLog.
1635                 void f()
1636                 {
1637                     int c;     // this change appears on ChangeLog.
1638                 }
1639                 int d;     // this change does not appear on ChangeLog.
1640             };
1641             int e;     // this change does not appear on ChangeLog.
1642             };
1643
1644         The previous prepare-ChangeLog outputs just methods in which a change is found:
1645             (N::C::f):
1646
1647         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
1648         and methods in which a change is found:
1649             (N):
1650             (N::C):
1651             (N::C::f):
1652
1653         * Scripts/prepare-ChangeLog:
1654         (get_function_line_ranges_for_cpp): Modified as described above.
1655
1656         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
1657         (Class104):
1658         (Class105):
1659         (Class106):
1660         (Class106::func32):
1661         (Class106::func33):
1662         (NameSpace3):
1663         (NameSpace4):
1664         (NameSpace5):
1665         (NameSpace6):
1666         (Class107):
1667         (NameSpace5::NameSpace6::Class107::func34):
1668         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
1669
1670 2012-01-24  Kentaro Hara  <haraken@chromium.org>
1671
1672         prepare-ChangeLog outputs warnings for top-level { ... } blocks
1673         https://bugs.webkit.org/show_bug.cgi?id=75943
1674
1675         Reviewed by David Kilzer.
1676
1677         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
1678         because it does not distinguish '}' at the end of a subroutine
1679         with '}' at the end of a if or for statement.
1680
1681         foo.pl:
1682             if (1) {
1683             }
1684             for (@v) {
1685             }
1686
1687         output:
1688             nested functions found at top-level at foo.pl:2
1689             nested functions found at top-level at foo.pl:4
1690
1691         This patch fixes the bug.
1692
1693         * Scripts/prepare-ChangeLog:
1694         (get_function_line_ranges_for_perl):
1695         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1696         Added test cases. No change in the test results.
1697
1698 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
1699
1700         r105674 broke check-webkit-style for chromium's test_expectations.
1701
1702         Unreviewed, build fix.
1703         
1704         We now need to pass in a platform name of 'chromium' if we want
1705         the chromium port; options.chromium is no longer recognized. I
1706         will follow this patch up with a separate patch that has a test,
1707         but this at least fixes the build.
1708
1709         * Scripts/webkitpy/style/checkers/test_expectations.py:
1710         (TestExpectationsChecker._determine_port_from_exepectations_path):
1711
1712 2012-01-20  Ojan Vafai  <ojan@chromium.org>
1713
1714         check-webkit-style of the chromium test_expectations.txt file takes too long
1715         https://bugs.webkit.org/show_bug.cgi?id=76745
1716
1717         Reviewed by Dimitri Glazkov.
1718
1719         When in lint mode, have TestExpectations test all configurations instead
1720         of looping over each configuration. This also has the benefit of making
1721         the error output considerably more concise.
1722
1723         Also, got rid of the double-printing of errors when linting through check-webkit-style.
1724
1725         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1726         (Manager.lint):
1727         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1728         (TestExpectations._report_errors):
1729         (TestExpectations._add_expectations):
1730         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1731         (test_parse_error_nonfatal):
1732         (test_error_on_different_platform):
1733         * Scripts/webkitpy/style/checkers/test_expectations.py:
1734         (TestExpectationsChecker.check_test_expectations):
1735         (TestExpectationsChecker.check):
1736         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1737         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
1738         (TestExpectationsTestCase.assert_lines_lint):
1739
1740 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1741
1742         Another build fix attempt after r105543.
1743
1744         * Scripts/webkitpy/common/net/file_uploader.py:
1745         (FileUploader.upload_as_multipart_form_data):
1746
1747 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
1748
1749         Build fix attempt after r105543.
1750
1751         * Scripts/webkitpy/common/net/file_uploader.py:
1752         (FileUploader.upload_as_multipart_form_data):
1753
1754 2012-01-24  Vincent Scheib  <scheib@chromium.org>
1755
1756         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
1757         https://bugs.webkit.org/show_bug.cgi?id=76411
1758
1759         Reviewed by Adam Barth.
1760
1761         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
1762         into a series of patches, this change adds a trivial
1763         pointer lock implementation to the Chromium port's DumpRenderTree
1764         and exposes LayoutTestController hooks to force failure conditions.
1765
1766         * DumpRenderTree/chromium/LayoutTestController.cpp:
1767         (LayoutTestController::LayoutTestController):
1768         (LayoutTestController::didLosePointerLock):
1769         (LayoutTestController::setPointerLockWillFailAsynchronously):
1770         (LayoutTestController::setPointerLockWillFailSynchronously):
1771         * DumpRenderTree/chromium/LayoutTestController.h:
1772         * DumpRenderTree/chromium/WebViewHost.cpp:
1773         (WebViewHost::requestPointerLock):
1774         (WebViewHost::requestPointerUnlock):
1775         (WebViewHost::isPointerLocked):
1776         (WebViewHost::didCompletePointerLock):
1777         (WebViewHost::didNotCompletePointerLock):
1778         (WebViewHost::didLosePointerLock):
1779         (WebViewHost::reset):
1780         * DumpRenderTree/chromium/WebViewHost.h:
1781         (WebViewHost::setPointerLockWillFailAsynchronously):
1782         (WebViewHost::setPointerLockWillFailSynchronously):
1783
1784 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
1785
1786         Unreviewed, skip WK2 API test timing out on some GTK bots.
1787
1788         WebKit2APITests/TestDownloads is consistently timing out on the
1789         32bit release and 64bit debug bots.
1790
1791         * Scripts/run-gtk-tests:
1792         (TestRunner): Skip WebKit2APITests/TestDownloads.
1793
1794 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
1795
1796         [Qt] Fix the build with the newes Qt5 hashes
1797         https://bugs.webkit.org/show_bug.cgi?id=76657
1798
1799         Reviewed by Simon Hausmann.
1800
1801         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1802         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
1803         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
1804
1805 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1806
1807         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
1808
1809         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
1810         building with MinGW inside cmd.exe will require the same construct. Instead
1811         we assume that when the first character in PWD is a '/' we're running under
1812         Cygwin, and use the normal unix way of setting environment variables.
1813
1814         Reviewed by Simon Hausmann.
1815
1816         * qmake/mkspecs/features/default_pre.prf:
1817
1818 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
1819
1820         Some qmake build files must include Qt5's "quick" module.
1821         https://bugs.webkit.org/show_bug.cgi?id=76671
1822
1823         Unreviewed build fix.
1824
1825         * MiniBrowser/qt/MiniBrowser.pro:
1826         * WebKitTestRunner/Target.pri:
1827
1828 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
1829
1830         [Qt] Fix the event timestamps for touch mocking
1831
1832         Reviewed by Simon Hausmann.
1833
1834         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1835         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
1836         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
1837
1838 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1839
1840         [GTK] Implement DownloadClient in WebKit2 GTK+ API
1841         https://bugs.webkit.org/show_bug.cgi?id=72952
1842
1843         Reviewed by Martin Robinson.
1844
1845         * gtk/generate-gtkdoc:
1846         (get_webkit2_options): Ignore WebKitDownloadClient.
1847
1848 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
1849
1850         [GTK] editing/deleting/5408255.html results are incorrect
1851         https://bugs.webkit.org/show_bug.cgi?id=53644
1852
1853         Reviewed by Martin Robinson.
1854
1855         WEBKIT_TOP_LEVEL environment variable is now set directly in either
1856         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
1857         macro. This way both tools can be run outside the test harness without
1858         the need to manually set the environment variable.
1859
1860         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1861         (getTopLevelPath):
1862         * GNUmakefile.am:
1863         * Scripts/webkitpy/layout_tests/port/gtk.py:
1864         (GtkPort.setup_environ_for_server):
1865         * WebKitTestRunner/GNUmakefile.am:
1866         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1867         (WTR::InjectedBundle::platformInitialize):
1868
1869 2012-01-23  Dmitry Lomov  <dslomov@google.com>
1870
1871         [Chromium] Implement layoutTestController.workerThreadCount in DRT
1872         https://bugs.webkit.org/show_bug.cgi?id=74653.
1873
1874         Reviewed by Darin Fisher.
1875
1876         * DumpRenderTree/chromium/LayoutTestController.cpp:
1877         (LayoutTestController::LayoutTestController):
1878         (LayoutTestController::workerThreadCount):
1879         * DumpRenderTree/chromium/LayoutTestController.h:
1880
1881 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1882
1883         nrwt: make --chromium work like --qt
1884         https://bugs.webkit.org/show_bug.cgi?id=76875
1885
1886         Reviewed by Adam Barth.
1887
1888         --chromium used to have to be handled differently from --qt
1889         due to the way the PortFactory was implemented; there's not
1890         really a good reason for that any more so this patch makes
1891         things slightly more consistent and eliminates the
1892         options.chromium flag (--chromium is now truly a synonym for
1893         --platform chromium).
1894
1895         * Scripts/webkitpy/layout_tests/port/factory.py:
1896         (PortFactory._default_port):
1897         (PortFactory.get):
1898         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1899         (FactoryTest.setUp):
1900         (FactoryTest.test_chromium_mac):
1901         (FactoryTest.test_chromium_linux):
1902         (FactoryTest.test_chromium_win):
1903         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1904         (parse_args):
1905
1906 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
1907
1908         run-webkit-tests needs to propagate --chromium
1909         https://bugs.webkit.org/show_bug.cgi?id=76870
1910
1911         Reviewed by Eric Seidel.
1912
1913         run-webkit-tests removes '--chromium' argument from @ARGV when
1914         determining which port to run, which means that that doesn't
1915         propagate to new-run-webkit-tests. That's bad (and is handled
1916         for the other ports by re-adding the flag, but apparently we're
1917         just now noticing for Chromium).
1918
1919         * Scripts/run-webkit-tests:
1920
1921 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
1922
1923         More build fixing after r105646.
1924
1925         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1926         (TestWebKitAPI::TestNode::key):
1927
1928 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
1929
1930         Unreviewed build fix - r105646 broke this.
1931
1932         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1933         (TestWebKitAPI::TestNode::TestNode):
1934         (TestWebKitAPI::TestNode::key):
1935         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
1936         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
1937         (TestWebKitAPI::RedBlackTreeTest::testDriver):
1938
1939 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
1940
1941         Unreviewed, rolling out r105658.
1942         http://trac.webkit.org/changeset/105658
1943         https://bugs.webkit.org/show_bug.cgi?id=76883
1944
1945         We want this eventually, but not right at this moment
1946         (Requested by abarth on #webkit).
1947
1948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1949
1950 2012-01-23  Adam Barth  <abarth@webkit.org>
1951
1952         garden-o-matic should support Chromium Mac Lion
1953         https://bugs.webkit.org/show_bug.cgi?id=76880
1954
1955         Reviewed by Eric Seidel.
1956
1957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1958
1959 2012-01-23  Emil A Eklund  <eae@chromium.org>
1960
1961         check-webkit-style whitespace/operators triggers on overloaded division operator
1962         https://bugs.webkit.org/show_bug.cgi?id=76650
1963
1964         Reviewed by Darin Adler.
1965
1966         * Scripts/webkitpy/style/checkers/cpp.py:
1967         (check_spacing):
1968         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1969         (CppStyleTest.test_operator_methods):
1970
1971 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
1972
1973         run-perf-tests should report server-side errors
1974         https://bugs.webkit.org/show_bug.cgi?id=76802
1975
1976         Reviewed by Tony Chang.
1977
1978         Report errors whenever server's response doesn't match "OK".
1979
1980         * Scripts/webkitpy/common/net/file_uploader.py:
1981         (FileUploader.upload_single_text_file):
1982         (FileUploader.upload_as_multipart_form_data):
1983         (FileUploader._upload_data.callback):
1984         (FileUploader):
1985         (FileUploader._upload_data):
1986         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1987         (PerfTestsRunner._upload_json):
1988         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1989         (test_upload_json):
1990         (test_upload_json.MockFileUploader.upload_single_text_file):
1991
1992 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
1993
1994         run-perf-tests ignore Skipped list on chromium
1995         https://bugs.webkit.org/show_bug.cgi?id=76764
1996
1997         Reviewed by Dirk Pranke.
1998
1999         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
2000         can also find skipped list. Chromium port only uses test_expectations.txt for
2001         layout tests but performacne tests don't use test_expectations.txt so Chromium port
2002         also needs to use Skipped list.
2003
2004         * Scripts/webkitpy/layout_tests/port/base.py:
2005         (Port._tests_from_skipped_file_contents):
2006         (Port):
2007         (Port._expectations_from_skipped_files):
2008         (Port.skipped_perf_tests):
2009         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2010         (PortTest.test_skipped_perf_tests):
2011         (PortTest.test_skipped_perf_tests.add_text_file):
2012         * Scripts/webkitpy/layout_tests/port/webkit.py:
2013         (WebKitPort._skipped_tests_for_unsupported_features):
2014         (WebKitPort._skipped_file_search_paths):
2015         (WebKitPort.skipped_layout_tests):
2016
2017 2012-01-23  Andy Estes  <aestes@apple.com>
2018
2019         Fix the build after r105635.
2020
2021         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2022         (TestWebKitAPI::TEST):
2023
2024 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
2025
2026         Basic enhancements to StringBuilder
2027         https://bugs.webkit.org/show_bug.cgi?id=67081
2028
2029         Reviewed by Darin Adler.
2030
2031         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2032         (TestWebKitAPI::TEST):
2033
2034 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2035
2036         [GTK] run-gtk-tests randomly fails while running the xprop comand
2037         https://bugs.webkit.org/show_bug.cgi?id=76817
2038
2039         Reviewed by Gustavo Noronha Silva.
2040
2041         No need to use xprop to remove the AT_SPI_BUS property since
2042         run-gtk-tests will always run new instances of Xvfb.
2043
2044         * Scripts/run-gtk-tests:
2045         (TestRunner): Unskip TestWebKitAccessibility.
2046         (TestRunner.run): Uncomment lines for launching the accessibility
2047         bus and registry daemon, and remove lines for running xprop.
2048
2049 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2050
2051         [Qt] Don't warn about override and final being C++11 extensions
2052
2053         Clang will emit a warning when these extensions are used without passing
2054         --std=c++11, but we use feature checking to decide if we have the right
2055         extensions, so we can safely ignore these warnings. The XCode and Windows
2056         project files have the same workaround.
2057
2058         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
2059         we only have one extra compiler for Objective-C, which is also used for
2060         Objective-C++ sources, so we have to pass the flag, even if it doesn't
2061         make sense for Objective-C.
2062
2063         Reviewed by Simon Hausmann.
2064
2065         * qmake/mkspecs/features/unix/default_post.prf:
2066
2067 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2068
2069         [Qt] Change how build-webkit decides when to do full incremental builds
2070
2071         Instead of relying on update-webkit (which isn't run on the bots) to
2072         decide when to do a full incremental build (make qmake), we let the
2073         build-webkit script itself check the current SVN revision against the
2074         previous build (by storing it in .webkit.config).
2075
2076         If the two differ we assume a full incremental build is needed, since
2077         the new revisions might have introduced problematic things like new
2078         Q_OBJECT macros. If not, we assume the developer is doing changes
2079         locally, and revert to doing a plain 'make'.
2080
2081         In addition, when the build fails in the latter case, we inform the
2082         developer of possible pitfalls and how to manually run 'make qmake'.
2083
2084         Reviewed by Ossy.
2085
2086         * Scripts/update-webkit:
2087         * Scripts/webkitdirs.pm:
2088         (buildQMakeProjects):
2089
2090 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
2091
2092         [GTK] run-gtk-tests randomly fails while running the xprop comand
2093         https://bugs.webkit.org/show_bug.cgi?id=76817
2094
2095         Reviewed by Philippe Normand.
2096
2097         Temporarily comment the lines related to launching the ATSPI bus
2098         and registry daemon, which are making the bots to fail randomly.
2099
2100         * Scripts/run-gtk-tests:
2101         (TestRunner): Skip TestWebKitAccessibility, as it won't run
2102         properly if the ATSPI infrastructure is not properly initialized.
2103         (TestRunner.run): Comment lines related to initialization of ATSPI.
2104
2105 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
2106
2107         Windows python test build fix.
2108
2109         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2110         (PerfTestsRunner.__init__):
2111
2112 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
2113
2114         [GTK] DumpRenderTree converts "file:///" to a path differently
2115         https://bugs.webkit.org/show_bug.cgi?id=76631
2116
2117         Reviewed by Martin Robinson.
2118
2119         DumpRenderTree should print "/" as the last path component if the
2120         path is a lone slash instead of empty output.
2121
2122         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2123         (webViewConsoleMessage):
2124
2125 2012-01-20  David Levin  <levin@chromium.org>
2126
2127         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
2128         https://bugs.webkit.org/show_bug.cgi?id=76752
2129
2130         Reviewed by Eric Seidel.
2131
2132         * Scripts/webkitpy/style/checkers/cpp.py:
2133         (check_for_leaky_patterns):
2134         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2135         (LeakyPatternTest.test_create_dc):
2136         (LeakyPatternTest.test_create_compatible_dc):
2137
2138 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
2139
2140         Changed my status in commiters.py
2141
2142         Unreviewed.
2143
2144         * Scripts/webkitpy/common/config/committers.py:
2145
2146 2012-01-20  Ojan Vafai  <ojan@chromium.org>
2147
2148         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
2149         https://bugs.webkit.org/show_bug.cgi?id=76748
2150
2151         Reviewed by Ryosuke Niwa.
2152
2153         It crawls the whole subtree and then doesn't use the data. Cutting this out
2154         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
2155
2156         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2157         (run):
2158
2159 2012-01-20  Adam Barth  <abarth@webkit.org>
2160
2161         Another tiny tweak to the garden-o-matic CSS.  This makes things line
2162         up slightly nicer when there aren't any failures.
2163
2164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2165         (#summary):
2166
2167 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2168
2169         run-perf-tests should support --test-results-server option
2170         https://bugs.webkit.org/show_bug.cgi?id=76680
2171
2172         Reviewed by Adam Barth.
2173
2174         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
2175         to be used by perf bots. Also refactor file_uploader as needed.
2176
2177         * Scripts/webkitpy/common/net/file_uploader.py:
2178         (FileUploader.__init__):
2179         (FileUploader.upload_single_file):
2180         (FileUploader.upload_as_multipart_form_data):
2181         (FileUploader):
2182         (FileUploader._upload_data):
2183         (FileUploader._upload_data.callback):
2184         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2185         (JSONResultsGeneratorBase.upload_json_files):
2186         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2187         (PerfTestsRunner):
2188         (PerfTestsRunner._parse_args):
2189         (PerfTestsRunner.run):
2190         (PerfTestsRunner._generate_json):
2191         (PerfTestsRunner._upload_json):
2192         (PerfTestsRunner._run_tests_set):
2193         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2194         (create_runner):
2195         (test_run_with_upload_json):
2196         (test_run_with_upload_json.mock_upload_json):
2197         (test_upload_json):
2198         (test_upload_json.MockFileUploader):
2199         (test_upload_json.MockFileUploader.__init__):
2200         (test_upload_json.MockFileUploader.upload_single_file):
2201         (test_parse_args):
2202
2203 2012-01-20  Adam Barth  <abarth@webkit.org>
2204
2205         The party time image overlaps real content!  This patch makes the
2206         image centered vertically.
2207
2208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2209         (#onebar.partytime #summary):
2210
2211 2012-01-19  Ojan Vafai  <ojan@chromium.org>
2212
2213         Refactor TestExpectationsParser in preparation for caching the results
2214         https://bugs.webkit.org/show_bug.cgi?id=76669
2215
2216         Reviewed by Dimitri Glazkov.
2217
2218         Make everything private expect for the parse method. 
2219         Eventually, we'll need the expectations lines to not be modified
2220         outside of TestExpectationsParser so we can cache the results.
2221         This makes check-webkit-style of the chromium test_expectations.txt file
2222         go from ~17 seconds to ~12 seconds on my Mac Pro.
2223
2224         This patch is just a refactor in preparation, so no new tests.
2225
2226         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
2227         (TestExpectationEditorTests.make_parsed_expectation_lines):
2228         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2229         (TestExpectationParser.parse):
2230         (TestExpectationParser):
2231         (TestExpectationParser._parse_line):
2232         (TestExpectationParser._tokenize):
2233         (TestExpectationParser._tokenize_list):
2234         (TestExpectationsModel._clear_expectations_for_test):
2235         (TestExpectations.__init__):
2236         (TestExpectations._add_expectations):
2237         (TestExpectations._add_skipped_tests):
2238         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2239         (TestExpectationParserTests.test_tokenize_blank):
2240         (TestExpectationParserTests.test_tokenize_missing_colon):
2241         (TestExpectationParserTests.test_tokenize_extra_colon):
2242         (TestExpectationParserTests.test_tokenize_empty_comment):
2243         (TestExpectationParserTests.test_tokenize_comment):
2244         (TestExpectationParserTests.test_tokenize_missing_equal):
2245         (TestExpectationParserTests.test_tokenize_extra_equal):
2246         (TestExpectationParserTests.test_tokenize_valid):
2247         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2248         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2249         (TestExpectationParserTests.test_parse_empty_string):
2250         (TestExpectationSerializerTests.assert_round_trip):
2251         (TestExpectationSerializerTests.assert_list_round_trip):
2252         * Scripts/webkitpy/tool/commands/expectations.py:
2253         (OptimizeExpectations.execute):
2254         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2255         (GardeningExpectationsUpdater.update_expectations):
2256
2257 2012-01-20  Adam Barth  <abarth@webkit.org>
2258
2259         Follow-up to previous patch: don't produce NaN when the revision number
2260         is missing.
2261
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2264
2265 2012-01-20  Adam Barth  <abarth@webkit.org>
2266
2267         Garden-o-matic should tell me which revisions have been checked by all the bots
2268         https://bugs.webkit.org/show_bug.cgi?id=76722
2269
2270         Reviewed by Dimitri Glazkov.
2271
2272         This information helps me know when it's safe for me to roll a
2273         candidate revision.
2274
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
2278
2279 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2280
2281         build-webkit: Don't spit out congratulations message on Ctrl+C
2282
2283         Reviewed by Andreas Kling.
2284
2285         * Scripts/build-webkit:
2286
2287 2012-01-20  Philippe Normand  <pnormand@igalia.com>
2288
2289         [GTK] Allow extra jhbuild modulesets
2290         https://bugs.webkit.org/show_bug.cgi?id=76691
2291
2292         Reviewed by Gustavo Noronha Silva.
2293
2294         * gtk/jhbuildrc: Extra modulesets and modules can be added in
2295         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
2296         env variables respectively. Use comma-separated values. Example:
2297         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
2298
2299 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2300
2301         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
2302         https://bugs.webkit.org/show_bug.cgi?id=72589
2303
2304         Reviewed by Martin Robinson.
2305
2306         Ensure the accessibility infrastructure is available when running
2307         the unit tests, otherwise WK2's accessibility tests won't work.
2308
2309         * Scripts/run-gtk-tests:
2310         (TestRunner):
2311         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
2312         where at-spi2's stuff is located (like at-spi-bus-launcher and
2313         at-spi2-registryd).
2314         (TestRunner.run): Initialize the accessibility infrastructure.
2315
2316         * gtk/generate-gtkdoc:
2317         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
2318
2319         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
2320
2321 2012-01-20  Hayato Ito  <hayato@chromium.org>
2322
2323         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
2324         https://bugs.webkit.org/show_bug.cgi?id=76353
2325
2326         Reviewed by Hajime Morita.
2327
2328         Add ShadowRoot.idl, which is enabled only on chromium port since this is
2329         under development feature.
2330         ShadowRoot.idl contains minimum API so that we can test it.
2331         Other APIs should be added on other changes so that we can isolate issues.
2332
2333         * DumpRenderTree/chromium/TestShell.cpp:
2334         (TestShell::TestShell):
2335
2336 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
2337
2338         [GTK] GTK's DRT not to log events for already defunct objects
2339         https://bugs.webkit.org/show_bug.cgi?id=76620
2340
2341         Reviewed by Martin Robinson.
2342
2343         Do not log 'state-change:defunct' events.
2344
2345         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2346         (printAccessibilityEvent): Early return if a
2347         'state-change:defunct' signal is passed.
2348         (axObjectEventListener): Pass the signal name and value in
2349         separate parameters to printAccessibilityEvent.
2350
2351 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2352
2353         Unreviewed build fix. Wrong variable being used as the cwd for git
2354         remote update command.
2355
2356         * gtk/run-with-jhbuild:
2357         (update_jhbuild):
2358
2359 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2360
2361         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
2362         https://bugs.webkit.org/show_bug.cgi?id=76585
2363
2364         Reviewed by Martin Robinson.
2365
2366         This allows us to specify a minimum version of jhbuild required,
2367         while also providing stability against changes done to the master
2368         branch, by letting us choose what is the exact version that will
2369         be used.
2370
2371         * gtk/run-with-jhbuild: refactored for more hackability and easier
2372         reading
2373         (jhbuild_installed): checks whether jhbuild is installed
2374         (jhbuild_cloned): checks whether jhbuild has been cloned
2375         (jhbuild_at_expected_revision): checks whether jhbuild is at the
2376         expected revision
2377         (update_jhbuild): brings jhbuild to the expected revision
2378         (clone_jhbuild): clones jhbuild
2379         (install_jhbuild): build and installs jhbuild
2380         (update_webkitgtk_libs): runs update-webkitgtk-libs
2381         (ensure_jhbuild): high-level logic to decide whether and which of
2382         the steps above are executed
2383
2384 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2385
2386         [WK2] DumpRenderTree converts "file:///" to a path differently
2387         https://bugs.webkit.org/show_bug.cgi?id=76653
2388
2389         Reviewed by John Sullivan.
2390
2391         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
2392         Do print a slash if there are no path components.
2393
2394 2012-01-19  Eric Seidel  <eric@webkit.org>
2395
2396         webkit-patch cannot rollout patches without changelog/bug number
2397         https://bugs.webkit.org/show_bug.cgi?id=75962
2398
2399         Reviewed by Adam Barth.
2400
2401         * Scripts/webkitpy/tool/commands/download.py:
2402         (AbstractRolloutPrepCommand._prepare_state):
2403         * Scripts/webkitpy/tool/commands/download_unittest.py:
2404         (AbstractRolloutPrepCommandTest.test_prepare_state):
2405
2406 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2407
2408         [WK2] fast/url/degenerate-file-base.html fails
2409         https://bugs.webkit.org/show_bug.cgi?id=76619
2410
2411         Reviewed by Adam Roben.
2412
2413         A URL generated form local path for loading had an extra slash, making document.URL
2414         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
2415
2416         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
2417
2418 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2419
2420         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
2421         https://bugs.webkit.org/show_bug.cgi?id=76510
2422
2423         Reviewed by Adam Barth.
2424
2425         Unlike other style rules, if you get the syntax of the test_expectations.txt
2426         file wrong, the layout tests won't run. Also, this check is simple and only
2427         slows down committing if you actually modify one of the test_expectations.txt files.
2428
2429         * Scripts/webkitpy/style/checkers/test_expectations.py:
2430         (TestExpectationsChecker.check_test_expectations):
2431         (TestExpectationsChecker.check):
2432         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2433         (TestExpectationsTestCase.test_check_covers_all_configurations):
2434         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
2435         (TestExpectationsTestCase):
2436         (assert_lines_lint):
2437
2438 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2439
2440         Build fix. Revert an unintentional change to WebKitDriver in r105443.
2441
2442         * Scripts/webkitpy/layout_tests/port/driver.py:
2443         (DriverProxy.__init__):
2444
2445 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
2446
2447         remove the duplicated build rules from WebKit.gyp, Tools.gyp
2448         https://bugs.webkit.org/show_bug.cgi?id=73384
2449
2450         Reviewed by Tony Chang.
2451
2452         This patch removes the no-longer-necessary conditional logic for
2453         build_webkit_exes_from_webkit_gyp; we now always build the exes
2454         from their own dedicated gyp files.
2455
2456         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2457
2458 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
2459
2460         make-new-script-test should work with HTTP tests
2461         https://bugs.webkit.org/show_bug.cgi?id=76603
2462
2463         Reviewed by Adam Roben.
2464
2465         * Scripts/make-new-script-test:
2466         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
2467         now also creates absolute paths for HTTP.
2468
2469 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
2470
2471         Some perf tests time out when ran by run-perf-tests
2472         https://bugs.webkit.org/show_bug.cgi?id=76612
2473
2474         Reviewed by Dirk Pranke and Eric Seidel.
2475
2476         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
2477         Otherwise some tests such as Parser/xml-parser.html will timeout.
2478
2479         --no-timeout option is currently supported by Chromium and Mac ports.
2480
2481         * Scripts/webkitpy/layout_tests/port/base.py:
2482         (Port.to.create_driver):
2483         * Scripts/webkitpy/layout_tests/port/chromium.py:
2484         (ChromiumDriver.__init__):
2485         (ChromiumDriver._wrapper_options):
2486         * Scripts/webkitpy/layout_tests/port/driver.py:
2487         (Driver.__init__):
2488         (DriverProxy.__init__):
2489         * Scripts/webkitpy/layout_tests/port/webkit.py:
2490         (WebKitDriver.__init__):
2491         (WebKitDriver.cmd_line):
2492         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2493         (WebKitDriverTest.test_read_binary_block):
2494         (WebKitDriverTest):
2495         (WebKitDriverTest.test_no_timeout):
2496         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2497         (get_tests_run.RecordingTestDriver.__init__):
2498         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2499         (PerfTestsRunner._parse_args):
2500         (PerfTestsRunner._run_tests_set):
2501         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2502         (create_runner):
2503
2504 2012-01-19  Ben Wells  <benwells@chromium.org>
2505
2506         Add support for window.print to chromium DRT
2507         https://bugs.webkit.org/show_bug.cgi?id=76479
2508
2509         When used in a test window.print goes into print mode and then
2510         straight out again. This will allow the afterprint event to be
2511         tested by having the afterprint event happen before the dump
2512         happens.
2513
2514         Reviewed by Mihai Parparita.
2515
2516         * DumpRenderTree/chromium/WebViewHost.cpp:
2517         (WebViewHost::printPage):
2518         * DumpRenderTree/chromium/WebViewHost.h:
2519
2520 2012-01-18  Enrica Casucci  <enrica@apple.com>
2521
2522         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
2523         https://bugs.webkit.org/show_bug.cgi?id=76588
2524         <rdar://problem/9325183>
2525
2526         Added test.
2527         
2528         Reviewed by Dan Bernstein.
2529
2530         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
2531         (TestWebKitAPI::TEST):
2532
2533 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2534
2535         [Qt] Do full incremental builds until bots use update-webkit
2536
2537         Rubber-stamped by Simon Hausmann.
2538
2539         * Scripts/webkitdirs.pm:
2540         (buildQMakeProjects):
2541
2542 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2543
2544         Fix the Qt build
2545
2546         Unreviewed build fix.
2547
2548         * Scripts/webkitdirs.pm:
2549         (buildQMakeProjects):
2550
2551 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2552
2553         [Qt] Make build-webkit always do safe incremental builds after update-webkit
2554
2555         When building against Qt5 with GCC we would just run 'make' in the build dir,
2556         and rely on the dependency files output by GCC (-MD) to handle dependency
2557         tracking, but that fails for special-cases like adding a Q_OBJECT macro
2558         to a header.
2559
2560         To guarantee that an incrmental build will work, we have to run 'make qmake',
2561         which we now do on every build-webkit that's followed by a successful run
2562         of update-webkit. The reasoning is that update-webkit can result in such
2563         potential corner-cases being applied, and since we can't know for sure
2564         unless we inspect the diff and account for all the corner cases we assume
2565         the worst and always run 'make qmake'.
2566
2567         After a succesful run of build-webkit we proceed to do just 'make' for any
2568         subsequent runs, since we assume that the developer knows what kind of
2569         changes he/she is doing, and when a 'make qmake' is needed.
2570
2571         Reviewed by Simon Hausmann.
2572
2573         * Scripts/update-webkit:
2574         * Scripts/webkitdirs.pm:
2575         (determineCurrentSVNRevision):
2576         (currentSVNRevision):
2577         (buildQMakeProjects):
2578         * qmake/mkspecs/features/default_post.prf:
2579
2580 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
2581
2582         run-perf-tests should support Skipped list
2583         https://bugs.webkit.org/show_bug.cgi?id=76594
2584
2585         Reviewed by Adam Barth.
2586
2587         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
2588
2589         * Scripts/webkitpy/layout_tests/port/base.py:
2590         (Port.perf_tests_dir):
2591         (Port.skipped_perf_tests):
2592         (Port.skips_perf_test):
2593         (Port.relative_perf_test_filename):
2594         * Scripts/webkitpy/layout_tests/port/test.py:
2595         (TestPort.perf_tests_dir):
2596         * Scripts/webkitpy/layout_tests/port/webkit.py:
2597         (WebKitPort._expectations_from_skipped_files):
2598         (WebKitPort):
2599         (WebKitPort.skipped_layout_tests):
2600         (WebKitPort.skipped_perf_tests):
2601         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2602         (PerfTestsRunner._collect_tests):
2603         (PerfTestsRunner.run):
2604         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2605         (test_run_test_set_with_json_output):
2606         (test_run_test_set_with_json_source):
2607         (test_collect_tests_with_skipped_list):
2608         (test_collect_tests_with_skipped_list.add_file):
2609
2610 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
2611
2612         Fix path to chromium_src_dir introduced in previous change.
2613
2614         Unreviewed, build fix.
2615
2616         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2617
2618 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
2619
2620         Need infrastructure to test Content-Disposition filename encoding support
2621         https://bugs.webkit.org/show_bug.cgi?id=76572
2622         <rdar://problem/6421825>
2623
2624         Reviewed by Sam Weinig.
2625
2626         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
2627
2628         WebKitTestRunner does not have a policy delegate yet, bug 42546.
2629
2630         * DumpRenderTree/mac/PolicyDelegate.mm:
2631         (dispositionTypeFromContentDispositionHeader):
2632         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
2633
2634 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2635
2636         Fix tests from http://trac.webkit.org/changeset/105332.
2637
2638         The code assumed that if you passed an options object with a configuration
2639         attribute that it would have a valid value. A bunch of the testing mocks
2640         do things like having a configuration value of None.
2641
2642         * Scripts/webkitpy/layout_tests/port/base.py:
2643         (Port.__init__):
2644
2645 2012-01-18  Ojan Vafai  <ojan@chromium.org>
2646
2647         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
2648         https://bugs.webkit.org/show_bug.cgi?id=76576
2649
2650         Reviewed by Adam Barth.
2651
2652         Avoid calling default_configuration in base.py. We don't need it for
2653         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
2654         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
2655         from common.executive.
2656
2657         At some point someone should probably look into why that call is so slow
2658         since it's on the critical path for run-webkit-tests and build-webkit startup.
2659
2660         * Scripts/webkitpy/layout_tests/port/base.py:
2661         (Port.__init__):
2662         * Scripts/webkitpy/style/checkers/test_expectations.py:
2663         (TestExpectationsChecker._determine_port_from_exepectations_path):
2664
2665 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
2666
2667         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
2668         https://bugs.webkit.org/show_bug.cgi?id=76505
2669
2670         Reviewed by Tony Chang.
2671
2672         Update chromium build script to use All.gyp instead of WebKit.gyp
2673
2674         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
2675         * Scripts/webkitdirs.pm:
2676
2677 2012-01-18  Sam Weinig  <sam@webkit.org>
2678
2679         Don’t hardcode the path to ‘make‘.
2680
2681         Reviewed by Dan Bernstein.
2682
2683         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2684
2685 2012-01-18  Joshua Bell  <jsbell@chromium.org>
2686
2687         Adding myself to committers.py
2688         https://bugs.webkit.org/show_bug.cgi?id=76569
2689
2690         Unreviewed.
2691
2692         * Scripts/webkitpy/common/config/committers.py:
2693
2694 2012-01-18  Adam Barth  <abarth@webkit.org>
2695
2696         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
2697         https://bugs.webkit.org/show_bug.cgi?id=76567
2698
2699         Reviewed by Eric Seidel.
2700
2701         Current the AppleMac port has slightly more failures than we allow on
2702         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
2703         which should hopefully let the mac-ews run to completion.  Once
2704         AppleMac has fewer failures, we can lower the cap again.
2705
2706         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2707         (LayoutTestResultsReaderTest.test_layout_test_results):
2708         * Scripts/webkitpy/tool/steps/runtests.py:
2709         (RunTests):
2710         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2711
2712 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
2713
2714         Provide access to user's list of preferred languages
2715         https://bugs.webkit.org/show_bug.cgi?id=76138
2716
2717         Reviewed by Alexey Proskuryakov.
2718
2719         * GNUmakefile.am: Add JSInternalsCustom.cpp.
2720
2721 2012-01-18  Adam Barth  <abarth@webkit.org>
2722
2723         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
2724         configurations.
2725
2726         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2727         (ChromiumLinuxPort.__init__):
2728
2729 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
2730
2731         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
2732         https://bugs.webkit.org/show_bug.cgi?id=73460
2733
2734         Reviewed by Chris Fleizach.
2735
2736         * DumpRenderTree/AccessibilityUIElement.h:
2737         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2738         (AccessibilityUIElement::AccessibilityUIElement):
2739         (AccessibilityUIElement::scrollToMakeVisibleCallback):
2740         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
2741         (AccessibilityUIElement::scrollToGlobalPointCallback):
2742         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2743         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2744         (AccessibilityUIElement::scrollToMakeVisible):
2745         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2746         (AccessibilityUIElement::scrollToGlobalPoint):
2747         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2748         (AccessibilityUIElement::scrollToMakeVisible):
2749         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2750         (AccessibilityUIElement::scrollToGlobalPoint):
2751         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2752         (AccessibilityUIElement::scrollToMakeVisible):
2753         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2754         (AccessibilityUIElement::scrollToGlobalPoint):
2755
2756 2012-01-17  Enrica Casucci  <enrica@apple.com>
2757
2758         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
2759         https://bugs.webkit.org/show_bug.cgi?id=76490
2760         <rdar://problem/9460733>
2761
2762         Added TestWebKitAPI test.
2763         
2764         Reviewed by Dan Bernstein.
2765
2766         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
2767         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
2768         changeAttributes to the WebView.
2769         
2770 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
2771
2772         [Qt] Consolidate layout test crash logging
2773         https://bugs.webkit.org/show_bug.cgi?id=75088
2774
2775         Reviewed by Simon Hausmann.
2776
2777         Move backtrace generating logic into WTFReportBacktrace
2778         and add a way to deinstall signal handlers if we know
2779         that we have already printed the backtrace.
2780
2781         * DumpRenderTree/qt/main.cpp:
2782         (crashHandler):
2783         (setupSignalHandlers):
2784         (WTFCrashHook):
2785         (main):
2786         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2787         (WTR::crashHandler):
2788         (WTR::setupSignalHandlers):
2789         (WTR::crashHook):
2790         (WTR::InjectedBundle::platformInitialize):
2791
2792 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
2793
2794         Unreviewed build fix after r105256.
2795
2796         There was a cyclic dependency between self._port and self._host assigments.
2797
2798         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2799         (PerfTestsRunner.__init__):
2800
2801 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2802
2803         Add new watchlist rule for the Qt build system
2804
2805         Reviewed by Simon Hausmann.
2806
2807         * Scripts/webkitpy/common/config/watchlist:
2808
2809 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2810
2811         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
2812
2813         Reviewed by Simon Hausmann.
2814
2815         * Tools.pro:
2816
2817 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2818
2819         [Qt] Allow building only a subset of the WebKit sub-projects
2820
2821         Fixes build-jsc, broken in r104825.
2822
2823         We no longer need the intermediate buildQMakeQtProject(), as we're the
2824         only port using qmake, and buildQMakeProject is now highly Qt specific.
2825
2826         <http://webkit.org/b/76179>
2827
2828         Reviewed by Simon Hausmann.
2829
2830         * Scripts/build-jsc:
2831         * Scripts/build-webkit:
2832         * Scripts/webkitdirs.pm:
2833         (buildQMakeProjects):
2834
2835 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
2836
2837         run-perf-tests should generate a json file that summaries the result
2838         https://bugs.webkit.org/show_bug.cgi?id=76504
2839
2840         Reviewed by Adam Barth.
2841
2842         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
2843         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
2844         another json file to be merged into the generated json file.
2845
2846         Also fixed a bug that --build wasn't set by default.
2847
2848         * Scripts/webkitpy/layout_tests/port/test.py:
2849         (TestPort.webkit_base):
2850         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2851         (PerfTestsRunner.__init__):
2852         (PerfTestsRunner):
2853         (PerfTestsRunner._parse_args):
2854         (PerfTestsRunner.run):
2855         (PerfTestsRunner._generate_json_if_specified):
2856         (PerfTestsRunner._process_chromium_style_test_result):
2857         (PerfTestsRunner._process_parser_test_result):
2858         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2859         (MainTest):
2860         (create_runner):
2861         (test_run_test_set):
2862         (test_run_test_set_for_parser_tests):
2863         (test_run_test_set_with_summary_json):
2864         (test_collect_tests):
2865         (test_parse_args):
2866
2867 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
2868
2869         Unreviewed, rolling out r105244.
2870         http://trac.webkit.org/changeset/105244
2871         https://bugs.webkit.org/show_bug.cgi?id=76518
2872
2873         broke Chromium Mac (Requested by rolandsteiner on #webkit).
2874
2875         * DumpRenderTree/AccessibilityUIElement.h:
2876         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2877         (AccessibilityUIElement::AccessibilityUIElement):
2878         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2879         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2880         (AccessibilityUIElement::removeSelection):
2881         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2882         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2883         (AccessibilityUIElement::removeSelection):
2884
2885 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
2886
2887         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
2888         https://bugs.webkit.org/show_bug.cgi?id=73460
2889
2890         Reviewed by Chris Fleizach.
2891
2892         * DumpRenderTree/AccessibilityUIElement.h:
2893         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2894         (AccessibilityUIElement::AccessibilityUIElement):
2895         (AccessibilityUIElement::scrollToMakeVisibleCallback):
2896         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
2897         (AccessibilityUIElement::scrollToGlobalPointCallback):
2898         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2899         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2900         (AccessibilityUIElement::scrollToMakeVisible):
2901         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2902         (AccessibilityUIElement::scrollToGlobalPoint):
2903         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2904         (AccessibilityUIElement::scrollToMakeVisible):
2905         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2906         (AccessibilityUIElement::scrollToGlobalPoint):
2907         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2908         (AccessibilityUIElement::scrollToMakeVisible):
2909         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2910         (AccessibilityUIElement::scrollToGlobalPoint):
2911
2912 2012-01-17  Adam Barth  <abarth@webkit.org>
2913
2914         Enable tests on the mac-ews
2915         https://bugs.webkit.org/show_bug.cgi?id=76502
2916
2917         Reviewed by Simon Fraser.
2918
2919         Apple now has five machines running the mac-ews.  Lucas Forschler has
2920         asked that we try enabling tests to see if we have enough bandwidth.
2921
2922         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2923         (MacEWS):
2924
2925 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
2926
2927         Add a check-webkit-style exception for GDBInterface.cpp
2928         https://bugs.webkit.org/show_bug.cgi?id=76187
2929
2930         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
2931         that it does not fail the style check.
2932
2933         Reviewed by Martin Robinson.
2934
2935         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
2936         readability/naming tests on
2937         Source/JavaScriptCore/jit/GDBInterface.cpp.
2938         * Scripts/webkitpy/style/checker_unittest.py:
2939         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
2940         the above exception.
2941
2942 2012-01-17  Hajime Morrita  <morrita@chromium.org>
2943
2944         https://bugs.webkit.org/show_bug.cgi?id=76245
2945         [Mac][DRT] should allow query string for the file URL.
2946
2947         Reviewed by Tony Chang.
2948
2949         Taught DRT about file:// as a url instead of a file path.
2950         We are now able to use a path file:///foo/bar.html?baz as a url
2951         with which DRT opens "/foo/bar.html" with "baz" as a query string.
2952
2953         * DumpRenderTree/mac/DumpRenderTree.mm:
2954         (runTest):
2955
2956 2012-01-17  Ojan Vafai  <ojan@chromium.org>
2957
2958         Check style on test_expectations.txt files before commit
2959         https://bugs.webkit.org/show_bug.cgi?id=76484
2960
2961         Reviewed by Adam Barth.
2962
2963         Unlike other style rules, if you get the syntax of the test_expectations.txt
2964         file wrong, the layout tests won't run. Also, this check is simple and only
2965         slows down committing if you actually modify one of the test_expectations.txt files.
2966
2967         * Scripts/webkitpy/tool/steps/commit.py:
2968         (Commit._check_test_expectations):
2969         (Commit.run):
2970         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
2971         (CommitTest):
2972         (CommitTest.test_check_test_expectations):
2973
2974 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2975
2976         [Qt] Debug build fails with debug qt5
2977         https://bugs.webkit.org/show_bug.cgi?id=76463
2978
2979         Reviewed by Simon Hausmann.
2980
2981         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
2982
2983         * QtTestBrowser/cookiejar.h:
2984
2985 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
2986
2987         webkitpy: fix json import on linux
2988         https://bugs.webkit.org/show_bug.cgi?id=76481
2989
2990         Reviewed by Adam Barth.
2991
2992         For some reason, the version of simplejson autoinstalled on my linux
2993         box seems to be broken. We should really only be using
2994         simplejson if json isn't available anyway, so this change looks
2995         for json first.
2996
2997         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2998         (JSONGeneratorTest.test_test_timings_trie):
2999
3000 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3001
3002         Fix failures in test-webkitpy caused by r105177.
3003
3004         Unreviewed, build fix.
3005
3006         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3007         (ChromiumLinuxPort._determine_driver_path_statically):
3008         (ChromiumLinuxPort._static_build_path):
3009
3010 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3011
3012         webkitpy: make PortFactory.get() be fully data-driven
3013         https://bugs.webkit.org/show_bug.cgi?id=76360
3014
3015         Reviewed by Eric Seidel.
3016
3017         Refactor PortFactory.get() to be fully data-driven.
3018
3019         * Scripts/webkitpy/layout_tests/port/factory.py:
3020         (PortFactory):
3021         (PortFactory._default_port):
3022         (PortFactory.get):
3023         (PortFactory.get.in):
3024         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3025         (FactoryTest.assert_port):
3026
3027 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3028
3029         webkitpy: add determine_full_port_name(), clean up port.__init__()
3030         https://bugs.webkit.org/show_bug.cgi?id=76357
3031
3032         Reviewed by Adam Barth.
3033
3034         Each Port class is now required to implement a 'port_name' field
3035         that will match the start of all ports constructed by this class and
3036         a 'determine_full_port_name' field that will make the port
3037         fully-qualified.
3038
3039         * Scripts/webkitpy/layout_tests/port/apple.py:
3040         (ApplePort.__init__):
3041         * Scripts/webkitpy/layout_tests/port/base.py:
3042         (Port):
3043         (Port.determine_port_name):
3044         (Port.__init__):
3045         * Scripts/webkitpy/layout_tests/port/chromium.py:
3046         (ChromiumPort.for):
3047         (ChromiumPort.__init__):
3048         (ChromiumPort):
3049         (ChromiumPort._chromium_base_dir):
3050         (ChromiumPort.path_from_chromium_base):
3051         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3052         (ChromiumGpuLinuxPort):
3053         (ChromiumGpuLinuxPort.__init__):
3054         (ChromiumGpuMacPort):
3055         (ChromiumGpuMacPort.__init__):
3056         (ChromiumGpuWinPort):
3057         (ChromiumGpuWinPort.__init__):
3058         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3059         (ChromiumLinuxPort):
3060         (ChromiumLinuxPort.determine_port_name):
3061         (ChromiumLinuxPort.__init__):
3062         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3063         (ChromiumMacPort):
3064         (ChromiumMacPort.determine_port_name):
3065         (ChromiumMacPort.__init__):
3066         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3067         (ChromiumWinPort):
3068         (ChromiumWinPort.determine_port_name):
3069         (ChromiumWinPort.__init__):
3070         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3071         (DryRunPort):
3072         (DryRunPort.determine_port_name):
3073         (DryRunPort.__init__):
3074         * Scripts/webkitpy/layout_tests/port/efl.py:
3075         (EflPort):
3076         * Scripts/webkitpy/layout_tests/port/factory.py:
3077         (PortFactory):
3078         (PortFactory._default_port):
3079         (PortFactory.get):
3080         (PortFactory.get.in):
3081         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3082         (FactoryTest.assert_port):
3083         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3084         (GoogleChromeLinux32Port):
3085         (GoogleChromeLinux32Port.determine_port_name):
3086         (GoogleChromeLinux64Port):
3087         (GoogleChromeLinux64Port.determine_port_name):
3088         (GoogleChromeMacPort):
3089         (GoogleChromeMacPort.determine_port_name):
3090         (GoogleChromeWinPort):
3091         (GoogleChromeWinPort.determine_port_name):
3092         * Scripts/webkitpy/layout_tests/port/gtk.py:
3093         (GtkPort):
3094         * Scripts/webkitpy/layout_tests/port/mac.py:
3095         (MacPort):
3096         (MacPort.determine_port_name):
3097         (MacPort.__init__):
3098         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3099         (test_versions):
3100         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3101         (MockDRTPort):
3102         (MockDRTPort.determine_port_name):
3103         (MockDRTPort.__init__):
3104         (MockDRT):
3105         (MockDRT.determine_port_name):
3106         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3107         (PortTestCase.make_port):
3108         * Scripts/webkitpy/layout_tests/port/qt.py:
3109         (QtPort):
3110         (QtPort.determine_port_name):
3111         (QtPort.__init__):
3112         * Scripts/webkitpy/layout_tests/port/test.py:
3113         (TestPort):
3114         (TestPort.determine_port_name):
3115         (TestPort.__init__):
3116         * Scripts/webkitpy/layout_tests/port/webkit.py:
3117         (WebKitPort.__init__):
3118         * Scripts/webkitpy/layout_tests/port/win.py:
3119         (WinPort):
3120         (WinPort.determine_port_name):
3121         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3122         (get_test_baselines.AllPlatformsPort.__init__):
3123         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3124         (get_test_config.TestMacPort):
3125         (get_test_config):
3126
3127 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
3128
3129         webkitpy: clean up port code in preparation for static port names
3130         https://bugs.webkit.org/show_bug.cgi?id=76356
3131
3132         Reviewed by Adam Barth.
3133
3134         To fix bug 76215 and be able to determine appropriate port names
3135         in webkitpy without actually constructing Port objects, we need
3136         to shuffle some logic in the chromium ports to be able to figure
3137         out whether we built DRT in 32 or 64-bit mode.
3138
3139         * Scripts/webkitpy/layout_tests/port/chromium.py:
3140         (ChromiumPort):
3141         (ChromiumPort._chromium_base_dir):
3142         (ChromiumPort.__init__):
3143         (ChromiumPort.path_from_chromium_base):
3144         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3145         (ChromiumLinuxPort):
3146         (ChromiumLinuxPort._determine_driver_path_statically):
3147         (ChromiumLinuxPort._static_build_path):
3148         (ChromiumLinuxPort._determine_architecture):
3149         (ChromiumLinuxPort.__init__):
3150         (ChromiumLinuxPort._build_path):
3151
3152 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
3153
3154         Do not remove pixel failures for ref tests.
3155         https://bugs.webkit.org/show_bug.cgi?id=76243
3156
3157         Reviewed by Tony Chang.
3158
3159         'NRWT --no-pixel-tests' complains when reftests are expected to
3160         be image mismatch.
3161
3162         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3163         (Manager._update_summary_with_result):
3164         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3165         (is_reftest_failure):
3166         (determine_result_type):
3167
3168 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3169
3170         REGRESSION(r81225): ORWT should ignore reftests
3171         https://bugs.webkit.org/show_bug.cgi?id=67936
3172
3173         Reviewed by Csaba Osztrogonác.
3174
3175         * Scripts/old-run-webkit-tests:
3176         (isUsedInReftest): $filename should be the first parameter
3177         (findTestsToRun): run test if it isn't reftest
3178
3179 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
3180
3181         Unreviewed. Fix python unit test I broke with r105142
3182
3183         * Scripts/webkitpy/common/config/ports_unittest.py:
3184         (WebKitPortTest.test_gtk_port):
3185
3186 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3187
3188         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
3189
3190         Qt 5 no longer has that flag.
3191
3192         Reviewed by Simon Hausmann.
3193
3194         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3195         (MiniBrowserApplication::notify):
3196
3197 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3198
3199         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
3200         https://bugs.webkit.org/show_bug.cgi?id=75857
3201
3202         Reviewed by Adam Barth.
3203
3204         * Scripts/webkitdirs.pm:
3205         (buildAutotoolsProject): move cleaning the build to happen early,
3206         and handle --update-gtk right after that
3207         * Scripts/webkitpy/common/config/ports.py:
3208         (GtkPort.build_webkit_command): pass --update-gtk as an option to
3209         build-webkit, so that it is used in the EWS
3210
3211 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3212
3213         [Qt] Don't add _debug postfix to targets when building debug only
3214
3215         Reviewed by Simon Hausmann.
3216
3217         * qmake/mkspecs/features/default_post.prf:
3218         * qmake/mkspecs/features/functions.prf:
3219
3220 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3221
3222         [Qt] Add more files to project-files for easier navigation in Qt Creator
3223
3224         Reviewed by Simon Hausmann.
3225
3226         * Tools.pro:
3227         * qmake/config.tests/README: Added.
3228
3229 2012-01-17  Philippe Normand  <pnormand@igalia.com>
3230
3231         [GTK] fast/dom/constructed-objects-prototypes.html fails
3232         https://bugs.webkit.org/show_bug.cgi?id=75432
3233
3234         Reviewed by Martin Robinson.
3235
3236         * Scripts/build-webkit: Enable video-track in GTK.
3237
3238 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
3239
3240         Add toyoshim as a committer.
3241         https://bugs.webkit.org/show_bug.cgi?id=76390
3242
3243         Reviewed by Hajime Morita.
3244
3245         * Scripts/webkitpy/common/config/committers.py:
3246
3247 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
3248
3249         [WinCairo] Build fix after r104155. Several debug targets were not
3250         properly including the '*Common' property sheets.
3251
3252         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
3253         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
3254         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
3255         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
3256         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
3257
3258 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
3259
3260         REGRESSION(r105072): It broke committers_unittest.py
3261         https://bugs.webkit.org/show_bug.cgi?id=76396
3262
3263         Reviewed by Adam Barth.
3264
3265         * Scripts/webkitpy/common/config/committers_unittest.py:
3266         (CommittersTest._assert_fuzz_match): It should handle more names.
3267         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
3268
3269 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
3270
3271         [GTK] Include gtk+3 in the jhbuild modules
3272         https://bugs.webkit.org/show_bug.cgi?id=76284
3273
3274         Reviewed by Philippe Normand.
3275
3276         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3277
3278 2012-01-16  Dan Winship  <danw@gnome.org>
3279
3280         Add myself as a committer
3281
3282         Unreviewed
3283
3284         * Scripts/webkitpy/common/config/committers.py:
3285
3286 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
3287
3288         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
3289
3290         Some recent versions of a few Linux distributions have started passing
3291         --as-needed and --no-copy-dt-needed-entries by default to the linker,
3292         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
3293         needed a few symbols from libjavascriptcore_efl.so.
3294
3295         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
3296         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
3297         libraries are searched in the right order by the linker.
3298
3299 2012-01-16  Philippe Normand  <pnormand@igalia.com>
3300
3301         [GTK] set audio resources path in NRTW
3302         https://bugs.webkit.org/show_bug.cgi?id=76380
3303
3304         Reviewed by Martin Robinson.
3305
3306         * Scripts/webkitpy/layout_tests/port/gtk.py:
3307         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
3308         the uninstalled audio resources are used during webaudio tests.
3309
3310 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
3311
3312         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
3313         https://bugs.webkit.org/show_bug.cgi?id=76369
3314
3315         Reviewed by Xan Lopez.
3316
3317         If there's an installed version of webkit and there are new
3318         symbols in the build tree, gtkdoc-scanobj fails due to undefined
3319         references, because the env ldflags are given before the local
3320         ones.
3321
3322         * gtk/gtkdoc.py:
3323         (GTKDoc._run_gtkdoc_scangobj):
3324
3325 2012-01-15  Pablo Flouret  <pablof@motorola.com>
3326
3327         Fix compilation errors on build-webkit --debug --no-video on mac.
3328         https://bugs.webkit.org/show_bug.cgi?id=75867
3329
3330         Reviewed by Philippe Normand.
3331
3332         Add --[no-]video-track to build-webkit, since video track feature
3333         depends on video.
3334
3335         * Scripts/build-webkit:
3336
3337 2012-01-14  James Robinson  <jamesr@chromium.org>
3338
3339         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
3340         https://bugs.webkit.org/show_bug.cgi?id=76313
3341
3342         Reviewed by Adam Barth.
3343
3344         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
3345
3346         * Scripts/run-chromium-webkit-unit-tests:
3347
3348 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3349
3350         Unreviewed, rolling out r105017.
3351         http://trac.webkit.org/changeset/105017
3352         https://bugs.webkit.org/show_bug.cgi?id=76333
3353
3354         broke the build (Requested by philn-tp on #webkit).
3355
3356         * gtk/jhbuild.modules:
3357
3358 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
3359
3360         [GTK] Include gtk+3 in the jhbuild modules
3361         https://bugs.webkit.org/show_bug.cgi?id=76284
3362
3363         Reviewed by Philippe Normand.
3364
3365         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
3366
3367 2012-01-13  Adam Barth  <abarth@webkit.org>
3368
3369         Remove --dry-run support from webkit-patch
3370         https://bugs.webkit.org/show_bug.cgi?id=76300
3371
3372         Reviewed by Dirk Pranke.
3373
3374         This is the rest of the patch from Bug 76300.  I landed it separtely
3375         because main.py had some stray conflict markers that I needed to clean
3376         up first.
3377
3378         * Scripts/webkitpy/test/main.py:
3379         (Tester.parse_args):
3380         (Tester._run_tests):
3381
3382 2012-01-13  Adam Barth  <abarth@webkit.org>
3383
3384         test-webkitpy does not run
3385         https://bugs.webkit.org/show_bug.cgi?id=76318
3386
3387         Unreviewed.
3388
3389         Looks like some conflict markers got left in the file.
3390
3391         * Scripts/webkitpy/test/main.py:
3392         (Tester.run):
3393
3394 2012-01-13  Adam Barth  <abarth@webkit.org>
3395
3396         Remove --dry-run support from webkit-patch
3397         https://bugs.webkit.org/show_bug.cgi?id=76300
3398
3399         Reviewed by Dirk Pranke.
3400
3401         We don't use this functionality for anything, and it doesn't really
3402         work.  Someone in #webkit tried using it and and got sad/confused.  We
3403         should just remove it.
3404
3405         * Scripts/webkitpy/common/checkout/scm/git.py:
3406         (Git.push_local_commits_to_server):
3407         * Scripts/webkitpy/common/checkout/scm/scm.py:
3408         (SCM.__init__):
3409         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3410         (_shared_test_commit_with_message):
3411         (GitSVNTest.test_commit_text_parsing):
3412         * Scripts/webkitpy/common/checkout/scm/svn.py:
3413         (SVN.commit_with_message):
3414         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3415         (Bugzilla.__init__):
3416         (Bugzilla.quips):
3417         (Bugzilla.authenticate):
3418         (Bugzilla.add_attachment_to_bug):
3419         (Bugzilla.add_patch_to_bug):
3420         (Bugzilla.create_bug):
3421         (Bugzilla.clear_attachment_flags):
3422         (Bugzilla.set_flag_on_attachment):
3423         (Bugzilla.obsolete_attachment):
3424         (Bugzilla.add_cc_to_bug):
3425         (Bugzilla.post_comment_to_bug):
3426         (Bugzilla.close_bug_as_fixed):
3427         (Bugzilla.reassign_bug):
3428         (reopen_bug):
3429         * Scripts/webkitpy/test/main.py:
3430         (Tester.parse_args):
3431         (Tester.run_tests):
3432
3433 2012-01-13  David Levin  <levin@chromium.org>
3434
3435         check-webkit-style: should encourage the use of Own* classes for Windows DC.
3436         https://bugs.webkit.org/show_bug.cgi?id=76227
3437
3438         Reviewed by Dirk Pranke.
3439
3440         * Scripts/webkitpy/style/checkers/cpp.py:
3441         (check_for_leaky_patterns): The new check.
3442         (process_line): Added a call to the new check.
3443         (CppChecker): Added the new error type.
3444         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3445         (CppStyleTestBase):
3446         (CppStyleTestBase.perform_leaky_pattern_check):
3447         The check for only leaky pattern errors.
3448         (LeakyPatternTest): Test cases.
3449
3450 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3451
3452         test-webkitpy: clean up handling of test directories, QueueStatusServer
3453         https://bugs.webkit.org/show_bug.cgi?id=76238
3454
3455         Reviewed by Adam Barth.
3456
3457         This patch cleans up a bunch of hacks related to how we find all
3458         of the python unit tests and set up the sys.path variable in
3459         test-webkitpy.
3460
3461         This patch changes how test-webkitpy works slightly in that we
3462         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
3463         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
3464         This greatly simplifies the mapping of paths to module names and
3465         appears to have no significant performance impact or other drawbacks.
3466
3467         There are other ways that we could remove all of the hacks and
3468         still have a more flexible mapping of paths to module names, but
3469         the ones I've thought of so far add a decent amount of complexity to
3470         the implementation and don't seem to buy us much.
3471         
3472         * QueueStatusServer/__init__.py:
3473         * Scripts/test-webkitpy:
3474         * Scripts/webkitpy/test/main.py:
3475         (Tester._modules_from_paths):
3476         (Tester._is_module):
3477
3478 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3479
3480         test-webkitpy: should support classes and individual test names as well as modules
3481         https://bugs.webkit.org/show_bug.cgi?id=76233
3482
3483         Reviewed by Adam Barth.
3484
3485         The default unittest.main() supports a list of individual
3486         TestCase classes or individual tests as well as modules. This
3487         change adds support for the same to test-webkitpy, so now you
3488         can say
3489
3490           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
3491
3492         and
3493
3494           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
3495
3496         in addition to
3497
3498           % test-wekbitpy webkitpy.test.cat_unittest
3499
3500         * Scripts/test-webkitpy:
3501         * Scripts/webkitpy/test/cat_unittest.py:
3502         * Scripts/webkitpy/test/main.py:
3503         (Tester.parse_args):
3504         (Tester.run):
3505         (Tester):
3506         (Tester._find_modules):
3507         (Tester._exclude):
3508         (Tester._run_tests):
3509         (Tester._is_module):
3510         (Tester._log_exception):
3511
3512 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3513
3514         test-webkitpy: add basic code coverage support
3515         https://bugs.webkit.org/show_bug.cgi?id=76201
3516
3517         Reviewed by Adam Barth.
3518
3519         This test adds basic code coverage support to test-webkitpy; if
3520         you pass the -c flag, we will generate a new coverage file. We
3521         can start simply with this and add more features as necessary.
3522
3523         This patch requires coverage to be already installed on the
3524         machine. I am not auto-installing this for now.
3525
3526         * Scripts/webkitpy/test/main.py:
3527         (Tester.parse_args):
3528         (Tester.run_tests):
3529
3530 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
3531
3532         StatusBubbleTest.test_build_bubble is failing
3533         https://bugs.webkit.org/show_bug.cgi?id=76222
3534
3535         Reviewed by Adam Barth.
3536
3537         * QueueStatusServer/handlers/statusbubble_unittest.py:
3538         (StatusBubbleTest.test_build_bubble):
3539
3540 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3541
3542         nrwt should use multiple http shards
3543         https://bugs.webkit.org/show_bug.cgi?id=75958
3544
3545         Add --max-locked-shards option to the nrwt for manual set
3546         the maximum number of the locked shards
3547
3548         Reviewed by Dirk Pranke.
3549
3550         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3551         (Manager._max_locked_shards):
3552         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3553         (ShardingTests.get_shards):
3554         (ShardingTests.test_multiple_locked_shards):
3555         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3556         (parse_args):
3557
3558 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
3559
3560         prepare-ChangeLog: Look for a text editor in a few more variables.
3561         https://bugs.webkit.org/show_bug.cgi?id=76289
3562
3563         Reviewed by Ryosuke Niwa.
3564
3565         A text editor was looked for only in the CHANGE_LOG_EDITOR and
3566         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
3567         to the OS X-specific open(1) command.
3568
3569         As there does not seem to be a common way of looking for a text editor
3570         among the scripts in Tools/Scripts right now, just look at $VISUAL and
3571         $EDITOR (set much more often than the other variables in Unix systems)
3572         before falling back to open(1).
3573
3574         * Scripts/prepare-ChangeLog:
3575         (openChangeLogs):
3576
3577 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
3578
3579         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
3580         https://bugs.webkit.org/show_bug.cgi?id=76269
3581
3582         Reviewed by Martin Robinson.
3583
3584         * gtk/gtkdoc.py:
3585         (GTKDoc._run_gtkdoc_scangobj):
3586
3587 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3588
3589         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
3590         https://bugs.webkit.org/show_bug.cgi?id=76247
3591
3592         Reviewed by Kenneth Rohde Christiansen.
3593
3594         * WebKitTestRunner/TestController.cpp:
3595         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
3596
3597 2012-01-13  Hajime Morrita  <morrita@chromium.org>
3598
3599         [Mac][DRT] Should support --no-timeout
3600         https://bugs.webkit.org/show_bug.cgi?id=76242
3601
3602         Reviewed by Darin Adler.
3603
3604         * DumpRenderTree/mac/DumpRenderTree.mm:
3605         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
3606         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
3607         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
3608         * DumpRenderTree/mac/DumpRenderTreeMac.h:
3609         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3610         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
3611
3612 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
3613
3614         Mitigate scrollbar differences when running pixel tests
3615         https://bugs.webkit.org/show_bug.cgi?id=67217
3616
3617         Reviewed by Dan Bernstein.
3618         
3619         Enable mock scrollbars by default for tests.
3620
3621         * DumpRenderTree/mac/DumpRenderTree.mm:
3622         (resetDefaultsToConsistentValues):
3623         * WebKitTestRunner/TestController.cpp:
3624         (WTR::TestController::resetStateToConsistentValues):
3625
3626 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
3627
3628         Need a script to run tests in PerformanceTests
3629         https://bugs.webkit.org/show_bug.cgi?id=76132
3630
3631         Reviewed by Adam Barth.
3632
3633         Add run-perf-tests to run performance tests using parser/resources/runner.js.
3634         Unfortunately, there isn't an easy way of telling which test uses which format
3635         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
3636
3637         All test outputs are re-formatted to match Chromium perf-bot style.
3638
3639         * Scripts/run-inspector-perf-tests.py:
3640         * Scripts/run-perf-tests: Added.
3641         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3642         (PerfTestsRunner):
3643         (PerfTestsRunner.__init__):
3644         (PerfTestsRunner._collect_tests):
3645         (PerfTestsRunner.run):
3646         (PerfTestsRunner._print_status):
3647         (PerfTestsRunner._run_tests_set):
3648         (PerfTestsRunner._process_chromium_style_test_result):
3649         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3650         (PerfTestsRunner._process_parser_test_result):
3651         (PerfTestsRunner._run_single_test):
3652         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3653         (MainTest.TestDriver.run_test):
3654         (create_runner):
3655         (run_test):
3656         (test_run_test_set):
3657         (test_run_test_set_for_parser_tests):
3658         (test_collect_tests):
3659
3660 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
3661
3662         webkitpy: clean up port unit tests in preparation for making port_name mandatory
3663         https://bugs.webkit.org/show_bug.cgi?id=76123
3664
3665         Reviewed by Adam Barth.
3666
3667         This change updates the unit tests to be more consistent in how
3668         ports are created, in preparation for making port_name a
3669         mandatory parameter to the constructor and removing any version
3670         interpretation from it.
3671
3672         There should be no functional changes in this patch, but some
3673         tests that are no longer relevant have been removed or reworked.
3674
3675         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3676         (PortTest.test_get_option__default):
3677         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3678         (ChromiumLinuxPortTest):
3679         (ChromiumLinuxPortTest.assert_architecture):
3680         (ChromiumLinuxPortTest.test_determine_architecture_fails):
3681         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3682         (ChromiumMacPortTest):
3683         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3684         (ChromiumPortTest):
3685         (ChromiumPortTest.test_all_test_configurations):
3686         (ChromiumPortTest.TestMacPort.__init__):
3687         (ChromiumPortTest.TestLinuxPort.__init__):
3688         (ChromiumPortTest.TestWinPort.__init__):
3689         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3690         (ChromiumWinTest):
3691         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3692         (EflPortTest):
3693         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3694         (GtkPortTest):
3695         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3696         (MacTest):
3697         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3698         (MockDRTPortTest):
3699         (MockDRTPortTest.make_port):
3700         * Scripts/webkitpy/layout_tests/port/qt.py:
3701         (QtPort._port_flag_for_scripts):
3702         (QtPort.__init__):
3703         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3704         (QtPortTest):
3705         (QtPortTest._assert_search_path):
3706         (QtPortTest.test_baseline_search_path):
3707         (QtPortTest.test_operating_system):
3708         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3709         (WebKitPortTest):
3710         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3711         (WinPortTest):
3712         (WinPortTest._assert_search_path):
3713         (WinPortTest.test_baseline_search_path):
3714         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3715         (get_test_config.TestMacPort.__init__):
3716
3717 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
3718
3719         test-webkitpy: clean up logging and provide a real --help message
3720         https://bugs.webkit.org/show_bug.cgi?id=76142
3721
3722         Reviewed by Adam Barth.
3723
3724         This test is mostly more refactoring - it calls objects in
3725         unittest directly instead of routing through unittest.main() --
3726         in order to gain more control over the logging and to provide a
3727         correct --help message. This will also give us a better
3728         foundation for adding more feautures down the road.
3729
3730         This patch adds different levels of logging controlled by the
3731         '-s', '-q', and '-v' options (see --help for details), and
3732         removes the --verbose-logging option.
3733
3734         * Scripts/test-webkitpy:
3735         * Scripts/webkitpy/test/main.py:
3736         (Tester):
3737         (Tester.clean_packages):
3738         (Tester.__init__):
3739         (Tester.parse_args):
3740         (Tester.configure):
3741         (Tester._configure_logging):
3742         (Tester.find_modules):
3743         (Tester._exclude):
3744         (Tester._modules_from_paths):
3745         (Tester.run_tests):
3746
3747 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
3748
3749         Make the new WTF module build on Qt
3750         https://bugs.webkit.org/show_bug.cgi?id=76163
3751
3752         Reviewed by Tor Arne Vestbø.
3753
3754         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
3755
3756 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
3757
3758         Unreviewed, mac DumpRenderTree fix.
3759
3760         * DumpRenderTree/mac/UIDelegate.mm:
3761         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3762
3763 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
3764
3765         WebKitTestRunner should not print console message line number when it is equal to zero.
3766         https://bugs.webkit.org/show_bug.cgi?id=76167
3767
3768         Reviewed by Csaba Osztrogonác.
3769
3770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3771         (WTR::InjectedBundlePage::willAddMessageToConsole):
3772
3773 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
3774
3775         Make default console messages line numbers consistent.
3776         https://bugs.webkit.org/show_bug.cgi?id=74075
3777
3778         Reviewed by Pavel Feldman.
3779
3780         Unset line numbers are not printed to console now.
3781         Added Source/WebCore/inspector to efl DumpRenderTree include path.
3782
3783         * DumpRenderTree/chromium/WebViewHost.cpp:
3784         (WebViewHost::didAddMessageToConsole):
3785         * DumpRenderTree/efl/CMakeLists.txt:
3786         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3787         (onConsoleMessage):
3788         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3789         (webViewConsoleMessage):
3790         * DumpRenderTree/mac/UIDelegate.mm:
3791         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3792         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3793         (WebCore::WebPage::javaScriptConsoleMessage):
3794         * DumpRenderTree/win/UIDelegate.cpp:
3795         (UIDelegate::webViewAddMessageToConsole):
3796         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
3797         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
3798
3799 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
3800
3801         test-webkitpy: push more logic into webkitpy.test.main, clean up code
3802         https://bugs.webkit.org/show_bug.cgi?id=76021
3803
3804         Reviewed by Eric Seidel.
3805
3806         I plan to add more functionality to test-webkitpy, but it is
3807         difficult to hack on now; this patch is the first of two that
3808         brings test-webkitpy more inline with current coding style by
3809         pushing more logic into the webkitpy.test.main.Tester class (so
3810         that it will be testable itself).
3811         
3812         There should be no functional changes in this patch.
3813
3814         * Scripts/test-webkitpy:
3815         (_path_from_webkit_root):
3816         * Scripts/webkitpy/test/main.py:
3817         (Tester):
3818         (Tester.init):
3819         (Tester.configure_logging):
3820         (Tester.configure_logging.filter):
3821         (Tester.clean_packages):
3822         (Tester.run_tests):
3823
3824 2012-01-11  Wei Jia  <wjia@chromium.org>
3825
3826         implement layout tests for <video> with media stream
3827         https://bugs.webkit.org/show_bug.cgi?id=74882
3828
3829         Reviewed by Kent Tamura.
3830
3831         * DumpRenderTree/DumpRenderTree.gypi:
3832         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
3833         (WebKit::WebUserMediaClientMock::create):
3834         (WebKit::WebUserMediaClientMock::IsMockStream):
3835         (WebKit::WebUserMediaClientMock::requestUserMedia):
3836         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
3837         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
3838         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
3839         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
3840         * DumpRenderTree/chromium/WebViewHost.cpp:
3841         (WebViewHost::userMediaClient):
3842         (WebViewHost::userMediaClientMock):
3843         (WebViewHost::createMediaPlayer):
3844         (WebViewHost::mediaStreamUtil):
3845         (WebViewHost::testMediaStreamClient):
3846         * DumpRenderTree/chromium/WebViewHost.h:
3847
3848 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3849
3850         Unreviewed, build fix.
3851
3852         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
3853
3854         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3855         (ChromiumWinPort.__init__):
3856
3857 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3858
3859         Sheriffbot build fix. Don't emit empty lines on IRC.
3860
3861         * Scripts/webkitpy/tool/bot/irc_command.py:
3862         (LastGreenRevision.execute):
3863
3864 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
3865
3866         last-green-revision should report the revision that succeeded on all bots
3867         https://bugs.webkit.org/show_bug.cgi?id=76109
3868
3869         Reviewed by Adam Barth.
3870
3871         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
3872         considered green by this algorithm, all matching builders must have a successful run at the revision
3873         or two consecutive successful runs before and after the revision.
3874
3875         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
3876         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
3877
3878         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3879         (BuildBot._revisions_for_builder):
3880         (BuildBot):
3881         (BuildBot._find_green_revision):
3882         (BuildBot.last_green_revision):
3883         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3884         (MockBuildBot.last_green_revision):
3885         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3886         (test_revisions_for_builder):
3887         (test_find_green_revision):
3888         (test_last_green_revision):
3889         * Scripts/webkitpy/tool/bot/irc_command.py:
3890         (LastGreenRevision.execute):
3891         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3892         (SheriffIRCBotTest.test_lgr):
3893         * Scripts/webkitpy/tool/commands/queries.py:
3894         (LastGreenRevision):
3895
3896 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3897
3898         Unreviewed, fix build bustage on win32 introduced by r104725.
3899
3900         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3901         (MockDRTPortTest.make_port):
3902         (MockChromiumDRTTest.test_pixeltest__fails):
3903
3904 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
3905
3906         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
3907         https://bugs.webkit.org/show_bug.cgi?id=75618
3908
3909         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
3910
3911         Reviewed by Tony Chang.
3912
3913         * DumpRenderTree/chromium/LayoutTestHelper.mm:
3914         (installLayoutTestColorProfile):
3915         (restoreUserColorProfile):
3916         (main):
3917
3918 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3919
3920         test-webkitpy: fix -v and eliminate some spurious warnings
3921         https://bugs.webkit.org/show_bug.cgi?id=76099
3922
3923         Reviewed by Adam Barth.
3924
3925         when we added support for --xml output, we broke the -v flag.
3926
3927         Also, fix the code to swallow a harmless warning from
3928         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
3929
3930         test-webkitpy is now silent again except for the one known
3931         logging issue.
3932
3933         * Scripts/webkitpy/common/checkout/checkout.py:
3934         (Checkout.commit_message_for_this_commit):
3935         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3936         (test_commit_message_for_this_commit):
3937         * Scripts/webkitpy/style/checkers/jsonchecker.py:
3938         (JSONChecker.check):
3939         (JSONChecker.line_number_from_json_exception):
3940         * Scripts/webkitpy/test/main.py:
3941         (Tester.run_tests):
3942
3943 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
3944
3945         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
3946         https://bugs.webkit.org/show_bug.cgi?id=76084
3947
3948         Reviewed by Adam Barth.
3949
3950         This will help make it easier to catch layering violations. This
3951         change just refactors test code; there are no changes to
3952         production code.
3953
3954         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3955         (PortTest.make_port):
3956         (PortTest.test_find_no_paths_specified):
3957         (PortTest.test_find_one_test):
3958         (PortTest.test_find_glob):
3959         (PortTest.test_find_with_skipped_directories):
3960         (PortTest.test_find_with_skipped_directories_2):
3961         (PortTest.test_parse_reftest_list):
3962         (PortTest.test_httpd_returns_error_code):
3963         (PortTest.test_virtual_methods):
3964         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3965         (ChromiumGpuTest.assert_port_works):
3966         (ChromiumGpuTest._assert_baseline_path):
3967         (ChromiumGpuTest.test_graphics_type):
3968         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3969         (ChromiumGpuTest.test_test_files):
3970         (ChromiumGpuTest.test_test_files.test_paths):
3971         (ChromiumGpuTest):
3972         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3973         (ChromiumLinuxPortTest.assert_architecture):
3974         (ChromiumLinuxPortTest.test_check_illegal_port_names):
3975         (ChromiumLinuxPortTest.test_determine_architecture_fails):
3976         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
3977         (DriverTest.make_port):
3978         (DriverTest):
3979         (DriverTest.assertVirtual):
3980         (DriverTest._assert_wrapper):
3981         (DriverTest.test_virtual_driver_methods):
3982         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3983         (MockDRTPortTest.make_port):
3984         (MockDRTPortTest.test_port_name_in_constructor):
3985         (MockDRTTest.assertTest):
3986         (MockDRTTest.test_main):
3987         (MockChromiumDRTTest.test_pixeltest__fails):
3988         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3989         (QtPortTest._assert_search_path):
3990         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3991         (TestWebKitPort.__init__):
3992         (WebKitPortUnitTests.test_default_options):
3993         (test_runtime_feature_list):
3994         (test_test_expectations):
3995
3996 2012-01-11  Ojan Vafai  <ojan@chromium.org>
3997
3998         Style skipped tests in the flakiness dashboard
3999         https://bugs.webkit.org/show_bug.cgi?id=76091
4000
4001         Reviewed by Tony Chang.
4002
4003         * TestResultServer/static-dashboards/dashboard_base.js:
4004         Removed "FLAKY" from this list since we don't ever mark individual runs
4005         as flaky. Also deleted an outdated line.
4006         * TestResultServer/static-dashboards/flakiness_dashboard.html:
4007
4008 2012-01-11  Ojan Vafai  <ojan@chromium.org>
4009
4010         Remove gtest normalization code from the test results server
4011         https://bugs.webkit.org/show_bug.cgi?id=76089
4012
4013         Reviewed by Tony Chang.
4014
4015         The normalization now happens on the gtest side.
4016
4017         * TestResultServer/model/jsonresults.py:
4018         (JsonResults.merge):
4019         * TestResultServer/model/jsonresults_unittest.py:
4020         (JsonResultsTest.test_gtest):
4021
4022 2012-01-11  Ojan Vafai  <ojan@chromium.org>
4023
4024         Be more aggressive about deleting unnecessary results from the test-results-server json files
4025         https://bugs.webkit.org/show_bug.cgi?id=76086
4026
4027         Reviewed by Tony Chang.
4028
4029         Remove any tests that only contain skip/pass/nodata values whose runtime
4030         is less than 5 seconds.
4031
4032         * TestResultServer/model/jsonresults.py:
4033         (JsonResults._normalize_results_json):
4034         * TestResultServer/model/jsonresults_unittest.py:
4035         (JsonResultsTest.test_merge_remove_test):
4036         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
4037
4038 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
4039
4040         last-green-revision should give us per-bot information
4041         https://bugs.webkit.org/show_bug.cgi?id=76011
4042
4043         Reviewed by Adam Barth.
4044
4045         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
4046         we report the latest green run on each bot from the last 100 runs.
4047
4048         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4049         (BuildBot._fetch_builder_page):
4050         (BuildBot):
4051         (BuildBot._green_revision_for_builder):
4052         (BuildBot.last_green_revision):
4053         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4054         (test_green_revision_for_builder):
4055         (test_last_green_revision):
4056         * Scripts/webkitpy/tool/bot/irc_command.py:
4057         (LastGreenRevision.execute):
4058         * Scripts/webkitpy/tool/commands/queries.py:
4059         (LastGreenRevision.execute):
4060
4061 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
4062
4063         webkitpy: clean up version detection in webkitpy.layout_tests.port
4064         https://bugs.webkit.org/show_bug.cgi?id=76016
4065
4066         Reviewed by Adam Barth.
4067
4068         This change updates the code in webkitpy.layout_tests.port to
4069         use the new os_name and os_version fields on host.platform. This
4070         gets layout_tests.port out of the version parsing business. Most
4071         of the diffs are just cleaning up test code to accomodate the
4072         changes.
4073
4074         * Scripts/webkitpy/common/system/executive_mock.py:
4075         (MockExecutive):
4076         (MockExecutive.ignore_error):
4077         (MockExecutive2):
4078         (MockExecutive2.ignore_error):
4079         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4080         (MockPlatformInfo.is_mac):
4081         (MockPlatformInfo.is_linux):
4082         (MockPlatformInfo.is_win):
4083         * Scripts/webkitpy/common/system/systemhost_mock.py:
4084         (MockSystemHost.__init__):
4085         * Scripts/webkitpy/layout_tests/port/apple.py:
4086         (ApplePort.__init__):
4087         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4088         (ChromiumMacPort.__init__):
4089         (ChromiumMacPort.check_wdiff):
4090         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4091         (ChromiumMacPortTest):
4092         (ChromiumMacPortTest.assert_name):
4093         (ChromiumMacPortTest.test_versions):
4094         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4095         (ChromiumPortTest.test_all_test_configurations):
4096         (ChromiumPortTest.TestMacPort.__init__):
4097         (ChromiumPortTest.TestLinuxPort.__init__):
4098         (ChromiumPortTest.TestWinPort.__init__):
4099         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4100         (ChromiumWinPort.__init__):
4101         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4102         (ChromiumWinTest):
4103         (ChromiumWinTest.assert_name):
4104         (ChromiumWinTest.test_versions):
4105         (ChromiumWinTest.test_baseline_path):
4106         (ChromiumWinTest.test_build_path):
4107         * Scripts/webkitpy/layout_tests/port/factory.py:
4108         (PortFactory._port_name_from_arguments_and_options):
4109         (PortFactory.get):
4110         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4111         (FactoryTest):
4112         (FactoryTest.setUp):
4113         (FactoryTest.assert_port):
4114         (FactoryTest.test_mac):
4115         (FactoryTest.test_win):
4116         (FactoryTest.test_google_chrome):
4117         (FactoryTest.test_gtk):
4118         (FactoryTest.test_qt):
4119         (FactoryTest.test_chromium_gpu):
4120         (FactoryTest.test_chromium_gpu_linux):
4121         (FactoryTest.test_chromium_gpu_mac):
4122         (FactoryTest.test_chromium_gpu_win):
4123         (FactoryTest.test_chromium_mac):
4124         (FactoryTest.test_chromium_linux):
4125         (FactoryTest.test_chromium_win):
4126         (FactoryTest.test_unknown_specified):
4127         (FactoryTest.test_unknown_default):
4128         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
4129         (TestGoogleChromePort):
4130         (TestGoogleChromePort._verify_baseline_path):
4131         (TestGoogleChromePort._verify_expectations_overrides):
4132         (TestGoogleChromePort.test_get_google_chrome_port):
4133         * Scripts/webkitpy/layout_tests/port/mac.py:
4134         (MacPort):
4135         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4136         (MacTest):
4137         (assert_name):
4138         (test_tests_for_other_platforms):
4139         (test_version):
4140         (test_versions):
4141         (test_is_version_methods):
4142         (test_setup_environ_for_server):
4143         (_assert_search_path):
4144         (test_show_results_html_file):
4145         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4146         (PortTestCase):
4147         (PortTestCase.make_port):
4148         * Scripts/webkitpy/layout_tests/port/win.py:
4149         (WinPort):
4150         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
4151         (WinPortTest):
4152         (WinPortTest.test_show_results_html_file):
4153         (WinPortTest._assert_search_path):
4154         (WinPortTest._assert_version):
4155
4156 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
4157
4158         [Qt][WK2] Remove workaround introduced into bug 75470
4159         https://bugs.webkit.org/show_bug.cgi?id=75889
4160
4161         Reviewed by Tor Arne Vestbø.
4162
4163         * MiniBrowser/qt/qml/BrowserWindow.qml:
4164
4165 2012-01-10  Dmitry Lomov  <dslomov@google.com>
4166
4167         [Chromium] Remove obsolete references to WebWorker class.
4168         https://bugs.webkit.org/show_bug.cgi?id=76020
4169
4170         Reviewed by David Levin.
4171
4172         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
4173         * DumpRenderTree/chromium/WebViewHost.cpp:
4174         * DumpRenderTree/chromium/WebViewHost.h:
4175
4176 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
4177
4178         [Qt] Some css3 filter tests are failing after r104698
4179         https://bugs.webkit.org/show_bug.cgi?id=76055
4180
4181         Reviewed by Simon Hausmann.
4182
4183         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4184         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
4185
4186 2012-01-11  Tony Chang  <tony@chromium.org>
4187
4188         Don't remove 0 byte files when running build-webkit --chromium
4189         https://bugs.webkit.org/show_bug.cgi?id=75997
4190
4191         Reviewed by Csaba Osztrogonác.
4192
4193         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
4194
4195         * Scripts/webkitdirs.pm:
4196         (determineIsQt):
4197
4198 2012-01-10  David Kilzer  <ddkilzer@apple.com>
4199
4200         Add TestWebKitAPI tests for KURL
4201         <http://webkit.org/b/75774>
4202
4203         Reviewed by Adam Barth.
4204
4205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
4206         WebCore folder and KURL.cpp source file to the project.
4207         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
4208         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
4209         during setup since this test doesn't go through WebKit or
4210         WebKit2.
4211         (TestWebKitAPI::TEST_F): Add two basic tests.
4212
4213 2012-01-10  David Kilzer  <ddkilzer@apple.com>
4214
4215         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
4216
4217         Reviewed by Adam Barth.
4218
4219         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
4220
4221         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
4222         WTFStringUtilities.h to the project.
4223         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
4224         WTFStringUtilities.h.
4225         * TestWebKitAPI/WTFStringUtilities.h: Added.
4226         (WTF::operator<<):
4227
4228 2012-01-10  Vincent Scheib  <scheib@chromium.org>
4229
4230         Clarify run-webkit-tests options reset-results and new-baseline
4231         https://bugs.webkit.org/show_bug.cgi?id=75993
4232
4233         Reviewed by Dirk Pranke.
4234
4235         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4236         (parse_args):
4237
4238 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
4239
4240         Disabled mock scrollbars should draw differently
4241         https://bugs.webkit.org/show_bug.cgi?id=75995
4242
4243         Reviewed by James Robinson.
4244
4245         When the scrollbar is disabled, paint the entire track of
4246         mock scrollbars with a lighter gray, and hide the thumb.
4247
4248         * DumpRenderTree/mac/DumpRenderTree.mm:
4249         (-[DRTMockScroller drawKnob]):
4250         (-[DRTMockScroller drawRect:]):
4251
4252 2012-01-10  James Robinson  <jamesr@chromium.org>
4253
4254         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
4255         https://bugs.webkit.org/show_bug.cgi?id=75988
4256
4257         Reviewed by Adam Barth.
4258
4259         * Scripts/webkitpy/common/config/ports.py:
4260         (WebKitPort.run_webkit_unit_tests_command):
4261         (WebKitPort):
4262         (ChromiumPort.run_webkit_unit_tests_command):
4263         (ChromiumPort):
4264         * Scripts/webkitpy/common/config/ports_mock.py:
4265         (MockPort.run_webkit_unit_tests_command):
4266         * Scripts/webkitpy/tool/commands/download_unittest.py:
4267         (DownloadCommandsTest.test_build_and_test):
4268         (test_land):
4269         (test_land_red_builders):
4270         * Scripts/webkitpy/tool/steps/runtests.py:
4271         (RunTests.run):
4272         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4273
4274 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
4275
4276         webkitpy: add os_name, os_version to platforminfo
4277         https://bugs.webkit.org/show_bug.cgi?id=75931
4278
4279         Reviewed by Eric Siedel.
4280
4281         As a first step in cleaning up the version parsing logic in
4282         webkitpy.layout_tests.port, this adds common routines for
4283         getting the os_name and os_version fields to the PlatformInfo
4284         class. Nothing uses them yet but I've added FIXME's to some of
4285         the code that needs to be deleted in the port files.
4286
4287         * Scripts/webkitpy/common/system/platforminfo.py:
4288         (PlatformInfo.__init__):
4289         (PlatformInfo):
4290         (PlatformInfo._determine_os_name):
4291         (PlatformInfo._determine_mac_version):
4292         (PlatformInfo._determine_linux_version):
4293         (PlatformInfo._determine_win_version):
4294         (PlatformInfo.display_name):
4295         (PlatformInfo.total_bytes_memory):
4296         (PlatformInfo._compute_bytes_from_vm_stat_output):
4297         (PlatformInfo.free_bytes_memory):
4298         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
4299         (TestPlatformInfo):
4300         (TestPlatformInfo.make_info):
4301         (TestPlatformInfo.make_info.mock_run_command):
4302         (TestPlatformInfo.setUp):
4303         (TestPlatformInfo.tearDown):
4304         (TestPlatformInfo.test_basic):
4305         (TestPlatformInfo.integration_test_basic):
4306         (TestPlatformInfo.test_display_name_mac):
4307         (TestPlatformInfo.test_display_name_win32):
4308         (TestPlatformInfo.test_memory_mac):
4309         (TestPlatformInfo.test_memory_win32):
4310         (TestPlatformInfo.test_determine_os_name):
4311         (TestPlatformInfo.test_determine_mac_version):
4312         (TestPlatformInfo.test_determine_linux_version):
4313         (TestPlatformInfo.test_determine_win_version_from_tuple):
4314         (TestPlatformInfo.test_determine_win_version_from_cmd):
4315         * Scripts/webkitpy/layout_tests/port/apple.py:
4316         (ApplePort.__init__):
4317         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4318         (ChromiumMacPort.__init__):
4319         * Scripts/webkitpy/layout_tests/port/mac.py:
4320         (MacPort):
4321         * Scripts/webkitpy/layout_tests/port/win.py:
4322         (WinPort):
4323
4324 2012-01-10  Adam Roben  <aroben@apple.com>
4325
4326         Make it possible to type data: URLs into MiniBrowser on Windows
4327
4328         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
4329         MiniBrowser on Windows
4330
4331         Reviewed by Darin Adler.
4332
4333         * MiniBrowser/win/BrowserWindow.cpp:
4334         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
4335         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
4336         does, we assume it already has a scheme and don't modify it.
4337
4338 2012-01-10  Adam Roben  <aroben@apple.com>
4339
4340         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
4341
4342         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
4343         MiniBrowser on Windows
4344
4345         Reviewed by Darin Adler.
4346
4347         * MiniBrowser/win/BrowserView.cpp:
4348         (BrowserView::goToURL): Pass the typed string through
4349         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
4350
4351 2012-01-10  Ben Wells  <benwells@chromium.org>
4352
4353         Adding myself (benwells) to committers.py
4354         https://bugs.webkit.org/show_bug.cgi?id=75971
4355
4356         Reviewed by Ojan Vafai.
4357
4358         * Scripts/webkitpy/common/config/committers.py:
4359
4360 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
4361
4362         AX: support helpText() in DumpRenderTree
4363         https://bugs.webkit.org/show_bug.cgi?id=40193
4364
4365         Reviewed by Chris Fleizach.
4366
4367         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4368         (AccessibilityUIElement::helpText): Implemented.
4369