07b1370a40ca526fdf9b4d64b2acb98108c41a5b
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-24  Timothy Horton  <timothy_horton@apple.com>
2
3         Add Conrad Shultz to the contributors list.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2014-10-24  Dan Bernstein  <mitz@apple.com>
8
9         build.webkit.org/dashboard immediately retries a request to buildbot when the response is 404
10         https://bugs.webkit.org/show_bug.cgi?id=138046
11
12         Reviewed by Alexey Proskuryakov.
13
14         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
15         (BuildbotQueue.prototype._load): Only consider retrying immediately if the error code was
16         401. Otherwise, we’ll retry normally in 45 seconds.
17
18 2014-10-24  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
19
20         [GTK] Implement is_selected method on WebKitHitTestResult
21         https://bugs.webkit.org/show_bug.cgi?id=137110
22
23         Reviewed by Tim Horton.
24
25         Add tests for new context SELECTION on WebKitHitTestResult.
26
27         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
28         (testContextMenuDefaultMenu):
29         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
30         (testWebViewMouseTarget):
31
32 2014-10-23  Roger Fong  <roger_fong@apple.com>
33
34         [Win] Skip failing JSC tests following r175078
35         https://bugs.webkit.org/show_bug.cgi?id=130967.
36
37         * Scripts/run-javascriptcore-tests:
38
39 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
40
41         commitqueuetask_unittest.py should be made more concise.
42         https://bugs.webkit.org/show_bug.cgi?id=137985
43
44         Reviewed by Alexey Proskuryakov.
45
46         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
47         Refactors tests to use MockSimpleTestPlanCommitQueue where possible.
48         (MockCommitQueue.__init__):
49         (MockCommitQueue.report_flaky_tests):
50         (MockCommitQueue):
51         (MockCommitQueue.get_reported_flaky_tests):
52         (MockSimpleTestPlanCommitQueue.__init__):
53         (MockSimpleTestPlanCommitQueue.run_command):
54         (MockSimpleTestPlanCommitQueue.did_run_clean_tests):
55         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
56         (test_land_failure):
57         (test_failed_archive):
58         (test_double_flaky_test_failure):
59         (test_test_failure):
60         (test_red_test_failure):
61         (test_very_red_tree_retry):
62         (test_red_tree_patch_rejection):
63         (test_one_flaky_test):
64         (test_tree_more_red_than_patch):
65         (MockCommitQueue.test_results): Deleted.
66         (test_simple_flaky_test_failure): Deleted.
67         (_expect_validate): Deleted.
68         (_expect_validate.MockDelegate): Deleted.
69         (_expect_validate.MockDelegate.refetch_patch): Deleted.
70         (_expect_validate.MockDelegate.expected_failures): Deleted.
71         (_mock_patch): Deleted.
72         (test_validate): Deleted.
73         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
74         Fixes a bug that slipped through the cracks prior to this change.
75         (PatchAnalysisTask._test_patch):
76
77 2014-10-22  Alexey Proskuryakov  <ap@apple.com>
78
79         Flakiness dashboard should support OS X Yosemite
80         https://bugs.webkit.org/show_bug.cgi?id=137986
81
82         Reviewed by Ryosuke Niwa.
83
84         * TestResultServer/app.yaml:
85         * TestResultServer/static-dashboards/builders.jsonp:
86         * TestResultServer/static-dashboards/flakiness_dashboard.js:
87
88 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
89
90         commitqueuetask should include more tests to ensure that the behavior
91         of PatchAnalysisTask._test_patch() is well defined
92         https://bugs.webkit.org/show_bug.cgi?id=137977
93
94         Reviewed by Alexey Proskuryakov.
95
96         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
97         Adds the MockSimpleTestPlanCommitQueue class, which makes it easier
98         and more readable to define tests that are meant to test the behaviour
99         of PatchAnalysisTask._test_patch(), and adds several unit tests.
100         (FailingTestCommitQueue.test_results):
101         (PatchAnalysisResult):
102         (MockSimpleTestPlanCommitQueue):
103         (MockSimpleTestPlanCommitQueue.__init__):
104         (MockSimpleTestPlanCommitQueue.run_command):
105         (MockSimpleTestPlanCommitQueue._mock_test_result):
106         (MockSimpleTestPlanCommitQueue.test_results):
107         (CommitQueueTaskTest._run_and_expect_patch_analysis_result):
108         (test_flaky_test_failure):
109         (test_failed_archive):
110         (test_two_flaky_tests):
111         (test_one_flaky_test):
112         (test_very_flaky_patch):
113         (test_very_flaky_patch_with_some_tree_redness):
114         (test_different_test_failures):
115         (test_different_test_failures_with_some_tree_redness):
116         (test_mildly_flaky_patch):
117         (test_mildly_flaky_patch_with_some_tree_redness):
118         (test_tree_more_red_than_patch):
119
120 2014-10-22  Jake Nielsen  <jacob_nielsen@apple.com>
121
122         PatchAnalysisTask._test_patch() needs refactoring
123         https://bugs.webkit.org/show_bug.cgi?id=137904
124
125         Reviewed by Alexey Proskuryakov.
126
127         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
128         Fixes several small bugs, and makes minor changes to accomodate the
129         changes in PatchAnalysisTask.
130         (MockCommitQueue.refetch_patch):
131         (MockCommitQueue.test_results):
132         (test_flaky_test_failure):
133         (test_failed_archive):
134         (test_very_red_tree_retry):
135         (_expect_validate.MockDelegate.refetch_patch):
136         (MockCommitQueue.expected_failures): Deleted.
137         (_expect_validate.MockDelegate.expected_failures): Deleted.
138         * Scripts/webkitpy/tool/bot/expectedfailures.py: Removed.
139         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Removed.
140         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
141         Removes the unexpected_failures member, adds the _clean_tree_results
142         member, adds a helper function for _test_patch, and refactors
143         _test_patch to be more readable.
144         (PatchAnalysisTask.__init__):
145         (PatchAnalysisTask._continue_testing_patch_that_exceeded_failure_limit_on_first_or_second_try):
146         (PatchAnalysisTask._test_patch):
147         (PatchAnalysisTask.results_from_test_run_without_patch):
148         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
149         Removes AbstractEarlyWarningSystem's dependancy on ExpectedFailures. 
150         (AbstractEarlyWarningSystem.begin_work_queue):
151         (AbstractEarlyWarningSystem._failing_tests_message):
152         (AbstractEarlyWarningSystem.command_failed):
153         (AbstractEarlyWarningSystem.expected_failures): Deleted.
154         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
155         Makes changes to accomodate the changes made to PatchAnalysisTask.
156         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
157         * Scripts/webkitpy/tool/commands/perfalizer.py:
158         Removes Perfalizer's dependancy on ExpectedFailures. 
159         (PerfalizerTask.refetch_patch):
160         (PerfalizerTask.expected_failures): Deleted.
161         * Scripts/webkitpy/tool/commands/queues.py:
162         Removes CommitQueue's dependancy on ExpectedFailures, and adds an
163         initializer to allow for mock injection.
164         (CommitQueue.__init__):
165         (CommitQueue.begin_work_queue):
166         (CommitQueue.process_work_item):
167         (CommitQueue._failing_tests_message):
168         * Scripts/webkitpy/tool/commands/queues_unittest.py:
169         Removes dependancy on ExpectedFailures, and instead uses mock
170         injection.
171         (MockCommitQueueTask):
172         (MockCommitQueueTask.results_from_patch_test_run):
173         (MockCommitQueueTask.results_from_test_run_without_patch):
174         (mock_run_webkit_patch):
175
176 2014-10-22  Rohit Kumar  <kumar.rohit@samsung.com>
177
178         [EFL][WK2] Minibrowser : Add support for mouse middle button to open links in new window
179         https://bugs.webkit.org/show_bug.cgi?id=136736
180
181         Reviewed by Gyuyoung Kim.
182
183         * MiniBrowser/efl/main.c:
184         (on_navigation_policy_decision): Check whether it's a link clicked with the middle mouse button and load the request in a new window.
185         (window_create):
186
187 2014-10-22  Carlos Garcia Campos  <cgarcia@igalia.com>
188
189         [GTK] Move GtkInputMethodFilter from Platform to WebKit2
190         https://bugs.webkit.org/show_bug.cgi?id=137884
191
192         Reviewed by Gustavo Noronha Silva.
193
194         Move InputMethodFilter test from WebCore tests to WebKit2 tests
195         and adapt it to use the new InputMethodFilter WebKit class. Instead
196         of having virtual methods just for testing, it has a testing mode
197         that logs the events.
198
199         * TestWebKitAPI/PlatformGTK.cmake:
200         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/gtk/InputMethodFilter.cpp.
201         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
202         (TestWebKitAPI::TestInputMethodFilter::~TestInputMethodFilter):
203         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventToFilter):
204         (TestWebKitAPI::TestInputMethodFilter::sendPressAndReleaseKeyEventPairToFilter):
205         (TestWebKitAPI::TEST):
206         (TestWebKitAPI::temporaryGetPreeditStringOverride):
207         (TestWebKitAPI::temporaryResetOverride):
208         (TestWebKitAPI::verifyCanceledComposition):
209
210 2014-10-21  Alexey Proskuryakov  <ap@apple.com>
211
212         build.webkit.org/dashboard: Cannot click on green tester bubbles
213         https://bugs.webkit.org/show_bug.cgi?id=137909
214
215         Reviewed by Darin Adler.
216
217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
218         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
219
220 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
221
222         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
223         https://bugs.webkit.org/show_bug.cgi?id=137932
224
225         Reviewed by Simon Fraser.
226
227         This is the first step in moving over to native Windows rendering for our layout tests.
228         Once this change lands, approximately 300 tests will start failing on Windows. I will
229         rebaseline these changes against our test hardware and update this bug with the
230         commits related to that work.
231
232         * DumpRenderTree/win/DumpRenderTree.cpp:
233         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
234         we use native Windows drawing style.
235
236 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
237
238         Fix FTL Native Inlining for EFL
239         https://bugs.webkit.org/show_bug.cgi?id=137774
240
241         Reviewed by Michael Saboff.
242
243         Added Clang as an optional module to jhbuild.
244
245         * efl/jhbuild.modules:
246
247 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
248
249         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
250         https://bugs.webkit.org/show_bug.cgi?id=137832
251
252         Reviewed by Carlos Garcia Campos.
253
254         Ensure each test sets the TLS errors policy that it really needs.
255         Have each test except testTLSErrorsPolicy stash and restore the original
256         TLS errors policy. Update testTLSErrorsPolicy to account for the new
257         default policy.
258
259         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
260         (testSSL):
261         (testInsecureContent):
262         (testTLSErrorsPolicy):
263         (testTLSErrorsRedirect):
264         (testTLSErrorsHTTPAuth):
265         (testLoadFailedWithTLSErrors):
266         (beforeAll):
267
268 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
269
270         Unreviewed. Unskip inspector server unit tests.
271
272         They should pass now.
273
274         * Scripts/run-gtk-tests:
275         (TestRunner):
276
277 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
278
279         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
280         https://bugs.webkit.org/show_bug.cgi?id=132044
281
282         Reviewed by Brian Burg.
283
284         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
285         (openRemoteDebuggingSession): Remove trailing slash when
286         concatenating base inspector URL with the page, because the
287         inspector returns the relative paths with a leading slash.
288
289 2014-10-20  Tanay C  <tanay.c@samsung.com>
290
291         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
292         https://bugs.webkit.org/show_bug.cgi?id=137023
293
294         Reviewed by Gyuyoung Kim.
295
296         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
297         (search_box_show): Modified.
298         (search_box_hide): Modified.
299         (on_search_field_activated): Modified.
300         (on_search_backward_button_clicked): Modified.
301         (on_search_forward_button_clicked): Modified.
302         (on_search_case_option_changed): Added.
303         (on_search_word_start_option_changed): Added.
304         (window_create): Modified.
305
306 2014-10-20  Tanay C  <tanay.c@samsung.com>
307
308         [GTK][Minibrowser] Escape key does not hide the search box
309         https://bugs.webkit.org/show_bug.cgi?id=137734
310
311         Reviewed by Philippe Normand.
312
313         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
314         (stopPageLoad): Modified.
315
316 2014-10-18  Antti Koivisto  <antti@apple.com>
317
318         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
319         https://bugs.webkit.org/show_bug.cgi?id=137855
320
321         Reviewed by Dan Bernstein.
322
323         Test and warn if the dumped response mime type differs from the platform response mime type.
324
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
326         (WTR::InjectedBundlePage::didReceiveResponseForResource):
327         (WTR::InjectedBundlePage::platformResponseMimeType):
328         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
329         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
330         (WTR::InjectedBundlePage::platformResponseMimeType):
331
332 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
333
334         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
335         https://bugs.webkit.org/show_bug.cgi?id=137835
336
337         Reviewed by Andreas Kling.
338
339         * Scripts/run-inspector-perf-tests.py: Removed.
340         This script is stale, as PerformanceTests/inspector no longer exists.
341
342 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
343
344         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
345
346         * Scripts/webkitpy/port/ios.py:
347         (IOSSimulatorPort.default_baseline_search_path):
348
349 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
350
351         [iOS] Simplify test fallback paths for iOS Simulator testing
352         https://bugs.webkit.org/show_bug.cgi?id=137830
353
354         Reviewed by Zalan Bujtas.
355         
356         Make the fallback paths be:
357             ios-simulator -> generic
358             ios-simulator-wk2->ios-simulator -> generic
359         
360         so don't include mac in the fallback path. Also remove the
361         version handling for simplicity.
362
363         * Scripts/webkitpy/port/ios.py:
364         (IOSSimulatorPort):
365         (IOSSimulatorPort.default_baseline_search_path):
366
367 2014-10-17  Dana Burkart  <dburkart@apple.com>
368
369         Fix typos in the dashboard config file.
370
371         Unreviewed.
372
373         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
374         (WebKitBuildbot):
375
376 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
377
378         [Win] Allow WinLauncher to specify Custom User Agent strings
379         https://bugs.webkit.org/show_bug.cgi?id=137828
380
381         Reviewed by Dean Jackson.
382
383         * WinLauncher/Common.cpp: Add support for custom user agent strings.
384         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
385         and set the user agent strings.
386         * WinLauncher/WinLauncher.h:
387         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
388         resources and dialog for setting custom User Agent strings.
389         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
390
391 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
392
393         [iOS] Turn off font autosizing for iOS WebKitTestRunner
394         https://bugs.webkit.org/show_bug.cgi?id=137806
395
396         Reviewed by Sam Weinig.
397
398         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
399         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
400         to disable font autosizing.
401         
402         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
403         test controller to set platform-specific prefs.
404
405         * WebKitTestRunner/TestController.cpp:
406         (WTR::TestController::resetPreferencesToConsistentValues):
407         (WTR::TestController::platformResetPreferencesToConsistentValues):
408         * WebKitTestRunner/TestController.h:
409         * WebKitTestRunner/ios/TestControllerIOS.mm:
410         (WTR::TestController::platformResetPreferencesToConsistentValues):
411         * WebKitTestRunner/mac/TestControllerMac.mm:
412         (WTR::TestController::platformResetPreferencesToConsistentValues):
413
414 2014-10-16  Dan Bernstein  <mitz@apple.com>
415
416         OSObjectPtr is missing leakRef()
417         https://bugs.webkit.org/show_bug.cgi?id=137798
418
419         Reviewed by Sam Weinig.
420
421         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
422         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
423
424 2014-10-16  Lucas Forschler  <lforschler@apple.com>
425
426         Update target platform to remove Leopard, Snow Leopard, Lion.
427         Add Yosemite. 
428         
429         Unreviewed.
430
431         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
432         (_should_file_trigger_build):
433
434 2014-10-16  David Kilzer  <ddkilzer@apple.com>
435
436         commit-queue: fails to replace OO-PS! with reviewer name
437         <http://webkit.org/b/137795>
438
439         Reviewed by Alexey Proskuryakov.
440
441         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
442         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
443         email addresses to unauthenticated page loads, so we must always
444         authenticate before getting bug data so we get full email
445         addresses.
446
447 2014-10-16  David Kilzer  <ddkilzer@apple.com>
448
449         commit-queue: fails to close bugs after successfully landing patches
450         <http://webkit.org/b/137794>
451
452         Reviewed by Alexey Proskuryakov.
453
454         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
455         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
456         tell Mechanize to use the second <textarea> on the page with
457         name="comment".
458
459 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
460
461         [Win] Update DRT to match Mac Logic
462         https://bugs.webkit.org/show_bug.cgi?id=137787
463
464         Reviewed by Dean Jackson.
465
466         * DumpRenderTree/win/DumpRenderTree.cpp:
467         (initialize): 0 -> nullptr
468         (runTest): Initialize MSG structure before using.
469         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
470         Also, cleanly shut down COM when exiting.
471         * DumpRenderTree/win/FrameLoadDelegate.cpp:
472         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
473         header and add printf to match Mac.
474         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
475         * DumpRenderTree/win/FrameLoadDelegate.h:
476         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
477         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
478         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
479         (isLocalhost): Added.
480         (hostIsUsedBySomeTestsToGenerateError): Added.
481         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
482         of certain error and redirect host names.
483         * DumpRenderTree/win/UIDelegate.cpp:
484         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
485         anything should be output to the console. This modifies behavior to match the Mac.
486         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
487         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
488         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
489         (UIDelegate::webViewAddMessageToConsole): Ditto.
490         * WinLauncher/PageLoadTestClient.cpp:
491         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
492         added last week.
493
494 2014-10-16  Commit Queue  <commit-queue@webkit.org>
495
496         Unreviewed, rolling out r174754.
497         https://bugs.webkit.org/show_bug.cgi?id=137789
498
499         Speculative fix for Windows test was ineffective. (Requested
500         by rfong on #webkit).
501
502         Reverted changeset:
503
504         "[Windows] Add some more logging to debug Windows test
505         issues."
506         http://trac.webkit.org/changeset/174754
507
508 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
509
510         Unreviewed, add myself to CoordinatedGraphics watchers.
511
512         * Scripts/webkitpy/common/config/watchlist:
513
514 2014-10-15  Roger Fong  <roger_fong@apple.com>
515
516         [Windows] Speculative Windows test fix.
517
518         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
519
520 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
521
522         import-w3c-test rewrites relative src paths in ref files incorrectly
523         https://bugs.webkit.org/show_bug.cgi?id=137586
524
525         This patch fixes a bug in test_converter.py where src paths were getting 
526         rewritten as ../../some-path instead of <script src="../../some-path>". 
527         It also adds support for rewriting src paths in style  elements, which was 
528         missing before and it adds tests for this case.
529
530         Reviewed by Bem Jones-Bey.
531
532         * Scripts/webkitpy/w3c/test_converter.py:
533         (_W3CTestConverter.convert_attributes_if_needed):
534         * Scripts/webkitpy/w3c/test_converter_unittest.py:
535         (test_convert_attributes_if_needed):
536         (verify_reference_relative_paths):
537
538 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
539
540         Add --json flag to test-webkitpy to emit JSON formatted test results
541         to stdout
542         https://bugs.webkit.org/show_bug.cgi?id=137353
543
544         Reviewed by Daniel Bates.
545
546         * Scripts/webkitpy/port/server_process_unittest.py:
547         Adds the read method to MockFile to allow the stdout of test_webkitpy
548         to be redirected without causing erroneous test failures.
549         In particular,
550         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
551         and
552         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
553         because when redirecting to a file, the
554         _wait_for_data_and_update_buffers_using_select method in 
555         server_process.py will find that there is a read file descriptor in
556         its call to select.select, which eventually leads to it calling read()
557         on the MockFile object.
558         (MockFile.read):
559         * Scripts/webkitpy/test/main.py:
560         Adds the _print_results_as_json method and the --json flag which
561         determines whether _print_results_as_json will get called.
562         (Tester._parse_args):
563         (Tester._print_results_as_json):
564         (Tester._print_results_as_json.result_dict_from_tuple):
565         (Tester._run_tests):
566
567 2014-10-13  David Farler  <dfarler@apple.com>
568
569         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
570         https://bugs.webkit.org/show_bug.cgi?id=137662
571
572         Reviewed by Darin Adler.
573
574         The layout test harness can close LayoutTestRelay's subprocess
575         stdout and stderr in the case of a timeout or if a run is
576         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
577         finds that no one is listening to its stdout/stderr (broken
578         pipe), then just exit(1), there is nothing to report.
579
580         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
581         (-[LTRelayController didReceiveStdoutData:]):
582         Add @try/@catch for NSFileHandleOperationException.
583         (-[LTRelayController didReceiveStderrData:]):
584         Add @try/@catch for NSFileHandleOperationException.
585
586 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
587
588         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
589         https://bugs.webkit.org/show_bug.cgi?id=137060
590
591         Reviewed by Philippe Normand.
592
593         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
594
595         * MiniBrowser/gtk/BrowserWindow.c:
596         (zoomInCallback):
597         (zoomOutCallback):
598         (defaultZoomCallback): Callback for default zoom keyboard support.
599         (browser_window_init):
600
601 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
602
603         [Mac] DRT stderr logging after the test completes gets attributed to the next test
604
605         Reviewed by Alexey Proskuryakov.
606         
607         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
608         logging to stderr to get associated with the next test.
609         
610         Fix by logging #EOF to stderr later, after we've completely finished with this test.
611
612         * DumpRenderTree/mac/DumpRenderTree.mm:
613         (dumpTestResults):
614         (runTest):
615
616 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
617
618         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
619
620         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
621
622 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
623
624         [cmake] Fix the make build after r174683
625         https://bugs.webkit.org/show_bug.cgi?id=137703
626
627         Reviewed by Martin Robinson.
628
629         * Scripts/webkitdirs.pm:
630         (buildCMakeGeneratedProject):
631
632 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
633
634         Adding myself to the watchlist to CachedFont
635
636         Unreviewed.
637
638         * Scripts/webkitpy/common/config/watchlist:
639
640 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
641
642         [EFL][GTK] Make it possible to get verbose output with ninja
643         https://bugs.webkit.org/show_bug.cgi?id=137606
644
645         Reviewed by Csaba Osztrogonác.
646
647         * Scripts/webkitdirs.pm:
648         (buildCMakeGeneratedProject):
649
650 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
651
652         [EFL] Make it possible to use ninja for EFL build too
653         https://bugs.webkit.org/show_bug.cgi?id=137605
654
655         Reviewed by Csaba Osztrogonác.
656
657         * Scripts/webkitdirs.pm:
658         (generateBuildSystemFromCMakeProject):
659         * efl/install-dependencies:
660
661 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
662
663         [GTK] Minibrowser : Add home buton and keyboard support for home page load
664         https://bugs.webkit.org/show_bug.cgi?id=137486
665
666         Reviewed by Philippe Normand.
667
668         * MiniBrowser/gtk/BrowserWindow.c:
669         (loadHomePage): Callback for home page load.
670         (browser_window_init):
671         * MiniBrowser/gtk/BrowserWindow.h:
672         * MiniBrowser/gtk/main.c:
673         (main):
674
675 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
676
677         import-w3c-tests doesn't prefix property values
678         https://bugs.webkit.org/show_bug.cgi?id=137600
679
680         Reviewed by Bem Jones-Bey.
681
682         Some property values are prefixed in WebKit. Modified the W3C import
683         script in order to prefix property values and not only properties.
684         The patch re-uses most of the already existent logic to prefix
685         properties.
686
687         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
688         from CSSValueKeywords.in and adapt converter to modify both properties
689         and property values.
690         (convert_for_webkit):
691         (_W3CTestConverter.__init__):
692         (_W3CTestConverter.output):
693         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
694         (_W3CTestConverter):
695         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
696         (_W3CTestConverter.add_webkit_prefix_following_regex):
697         (_W3CTestConverter.convert_reference_relpaths):
698         (_W3CTestConverter.convert_style_data):
699         (_W3CTestConverter.convert_attributes_if_needed):
700         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
701         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
702         include checks for property values too.
703         (W3CTestConverterTest.test_read_prefixed_property_list):
704         (verify_no_conversion_happened):
705         (verify_prefixed_properties):
706         (verify_prefixed_property_values):
707         (generate_test_content_properties_and_values):
708         (generate_test_content):
709         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
710         prefixed property values and inform about them.
711         (TestImporter.import_tests):
712         (TestImporter.write_import_log):
713
714 2014-10-13  Jer Noble  <jer.noble@apple.com>
715
716         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
717         https://bugs.webkit.org/show_bug.cgi?id=137533
718
719         Reviewed by Andy Estes.
720
721         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
722
723         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
724         (TestWebKitAPI::isMSEEnabledCallback):
725         (TestWebKitAPI::TEST):
726
727 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
728
729         [Win] Implement a page load profiling tool
730         https://bugs.webkit.org/show_bug.cgi?id=137673
731
732         Reviewed by Dean Jackson.
733
734         Add a tool to capture and summarize page load statistics.
735
736         * WinLauncher/Common.cpp:
737         (parseCommandLine): Move from WinMain.cpp so that it can
738         be shared with internal tools.
739         * WinLauncher/PageLoadTestClient.cpp: Added.
740         (PageLoadTestClient::PageLoadTestClient):
741         (PageLoadTestClient::pageLoadStartedAtTime):
742         (PageLoadTestClient::didStartProvisionalLoad):
743         (PageLoadTestClient::didCommitLoad):
744         (PageLoadTestClient::didFirstLayoutForMainFrame):
745         (PageLoadTestClient::didHandleOnLoadEvents):
746         (PageLoadTestClient::didFinishLoad):
747         (PageLoadTestClient::didFailLoad):
748         (PageLoadTestClient::didInitiateResourceLoad):
749         (PageLoadTestClient::didEndResourceLoad):
750         (PageLoadTestClient::pageLoadEndedAtTime):
751         (PageLoadTestClient::endPageLoad):
752         (PageLoadTestClient::clearPageLoadState):
753         (PageLoadTestClient::shouldConsiderPageLoadEnded):
754         (PageLoadTestClient::maybeEndPageLoadSoon):
755         (PageLoadTestClient::setPageURL):
756         (PageLoadTestClient::dumpRunStatistics):
757         * WinLauncher/PrintWebUIDelegate.cpp:
758         (PrintWebUIDelegate::createWebViewWithRequest): Handle
759         nullptr URL properly.
760         * WinLauncher/ResourceLoadDelegate.cpp: Added.
761         (ResourceLoadDelegate::QueryInterface):
762         (ResourceLoadDelegate::AddRef):
763         (ResourceLoadDelegate::Release):
764         (ResourceLoadDelegate::identifierForInitialRequest):
765         (ResourceLoadDelegate::willSendRequest):
766         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
767         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
768         (ResourceLoadDelegate::didReceiveResponse):
769         (ResourceLoadDelegate::didReceiveContentLength):
770         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
771         (ResourceLoadDelegate::didFailLoadingWithError):
772         (ResourceLoadDelegate::plugInFailedWithError):
773         * WinLauncher/ResourceLoadDelegate.h: Added.
774         (ResourceLoadDelegate::ResourceLoadDelegate):
775         * WinLauncher/WinLauncher.cpp:
776         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
777         page loading statistics.
778         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
779         and set private load delegate state.
780         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
781         that sets the view's resource load delegate.
782         (WinLauncher::loadURL): If no URL is passed, load the test document.
783         * WinLauncher/WinLauncher.h:
784         (WinLauncher::pageLoadTestClient):
785         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
786         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
787         * WinLauncher/WinLauncherWebHost.cpp:
788         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
789         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
790         it could be used from other source files.
791         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
792         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
793         (WinLauncherWebHost::didFailLoadWithError): Ditto.
794         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
795         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
796         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
797         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
798         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
799         * WinLauncher/WinLauncherWebHost.h:
800         * WinLauncher/WinMain.cpp:
801         (wWinMain): Create and use new delegates for gathering page load data.
802         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
803
804 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
805
806         Improve the test image diffs page
807         https://bugs.webkit.org/show_bug.cgi?id=137674
808
809         Reviewed by Alexey Proskuryakov.
810         
811         Don't treat the input file as a format string, otherwise we have to escape special
812         characters. Just do a couple of replaces.
813
814         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
815         (TestResultWriter.write_image_diff_files):
816
817 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
818
819         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
820         https://bugs.webkit.org/show_bug.cgi?id=137659
821
822         Reviewed by Martin Robinson.
823
824         * Scripts/webkitpy/port/xvfbdriver.py:
825         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
826
827 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
828
829         Add more detailed wait time information to EWS metrics
830         https://bugs.webkit.org/show_bug.cgi?id=137649
831
832         Reviewed by Daniel Bates.
833
834         Added average and worst time (we used to only have median), and also a percentage
835         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
836
837         There is always some wait due to the polling nature of the queues, which is well understood
838         and doesn't need to be measured. What needs to be measured is whether there is enough
839         bot machines to process patches as soon as they are submitted.
840
841         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
842         (Analyzer.prototype._analyzeBubblePerformance):
843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
844         (MetricsBubbleView.prototype._update):
845
846 2014-10-11  Jer Noble  <jer.noble@apple.com>
847
848         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
849         https://bugs.webkit.org/show_bug.cgi?id=137533
850
851         Reviewed by Darin Adler.
852
853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
854         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
855         (TestWebKitAPI::TEST):
856         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
857         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
858
859 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
860
861         iOS DRT snapshots are limited to the page visible area
862         https://bugs.webkit.org/show_bug.cgi?id=137650
863
864         Reviewed by Daniel Bates.
865         
866         LegacyTileCache drawing was limited to the window's visible area, found by
867         crawling up the layer hierarchy to the root layer. This caused test snapshots to
868         be missing non-composited content outside the iPhone visible area, which hinders
869         testing.
870         
871         Fix by adding a test-only mode where the window visible area is the entire window.
872         
873         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
874         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
875         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
876         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
877         for the DRT window.
878         
879
880 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
881
882         Page not fully rendered in iOS DRT snapshots
883         https://bugs.webkit.org/show_bug.cgi?id=137638
884
885         Reviewed by Tim Horton.
886         
887         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
888         to ensure that the page has laid out and is rendered by the time we take
889         the snapshot.
890
891         * DumpRenderTree/mac/DumpRenderTree.mm:
892         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
893         (-[DumpRenderTree _webThreadInvoked]): Moved.
894         (-[DumpRenderTree _waitForWebThreadThenDump]):
895         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
896         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
897         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
898         relies on dispatch_async too, and the inner block won't complete until the outer block
899         has completed.
900         (dumpTestResults): Move the guts of dump() here.
901         (runTest): Whitespace.
902
903 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
904
905         Adding svn:ignore so that .pyc files don't show up as new.
906
907         * Scripts/webkitpy/xcode: Added property svn:ignore.
908
909 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
910
911         [EFL] Introduce EWebKit_Extension
912         https://bugs.webkit.org/show_bug.cgi?id=134921
913
914         Reviewed by Gyuyoung Kim.
915
916         * MiniBrowser/efl/main.c: Added x option to test extension path.
917         (window_create):
918         (elm_main):
919         * Scripts/webkitpy/common/config/watchlist:
920         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
921         * Scripts/webkitpy/style/checker.py:
922         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
923
924 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
925
926         After r174628 we send the test process a SIGTERM before the SIGKILL.
927
928         * Scripts/webkitpy/common/system/executive_unittest.py:
929         (ExecutiveTest.serial_test_kill_process):
930
931 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
932
933         [EFL] Enable WebP support.
934         https://bugs.webkit.org/show_bug.cgi?id=136156
935
936         Reviewed by Gyuyoung Kim.
937
938         Include libwebp-dev package to support WebP for WK2 Efl.
939
940         * efl/install-dependencies:
941
942 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
943
944         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
945         https://bugs.webkit.org/show_bug.cgi?id=137485
946
947         Reviewed by Sergio Villar Senin.
948
949         Update GMainLoopSource tests. Most of the tests are now run twice,
950         first with a GMainLoopSource and then with a
951         GThreadSafeMainLoopSource, since both should have the same
952         behaviour. The threading test uses GThreadSafeMainLoopSource and
953         the delete on destroy test uses GMainLoopSource. The tests
954         themselves haven't changed, since there's no change in behaviour.
955
956         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
957         (TestWebKitAPI::GMainLoopSourceTest::source):
958         (TestWebKitAPI::basicRescheduling):
959         (TestWebKitAPI::TEST):
960         (TestWebKitAPI::reentrantRescheduling):
961         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
962         (TestWebKitAPI::basicDestroyCallbacks):
963         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
964         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
965
966 2014-10-10  Dana Burkart  <dburkart@apple.com>
967
968         Fix fat-fingered function name in git-add-reviewer.
969
970         Unreviewed.
971
972         * Scripts/git-add-reviewer:
973         (getConfigValue):
974
975 2014-10-10  David Farler  <dfarler@apple.com>
976
977         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
978         https://bugs.webkit.org/show_bug.cgi?id=137528
979
980         Reviewed by Simon Fraser.
981
982         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
983         and SIGKILL the paired simulator app before exiting cleanly.
984
985         webkitpy only uses SIGKILL to kill processes which you cannot
986         catch. Send SIGTERM to the process and give it chance to do
987         its thing before sending SIGKILL. Sending a SIGKILL to an already
988         dead PID is safe.
989
990         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
991         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
992         (-[LTRelayController finish]):
993         * LayoutTestRelay/LayoutTestRelay/main.m:
994         (receivedSignal):
995         (main):
996
997 2014-10-10  David Farler  <dfarler@apple.com>
998
999         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
1000         https://bugs.webkit.org/show_bug.cgi?id=137527
1001
1002         Reviewed by Simon Fraser.
1003
1004         NSFileHandle doesn't notify of EOF in its readability handler.
1005         Use a dispatch_source_t and an event handler that is called when reading is possible.
1006         In the handler block, do a run-of-the-mill read(2) from standard input and
1007         detect EOF in the usual way by checking that zero bytes were read.
1008
1009         Once an EOF is received, the FIFOs are disconnected, the simulator app
1010         is killed, and the relay exits with status 0.
1011
1012         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1013         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
1014         (-[LTRelayController didDisconnect]):
1015         (-[LTRelayController didConnect]):
1016         (-[LTRelayController launchApp]):
1017         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
1018         confusion with this new dispatch source, called "standardInputDispatchSource".
1019         (-[LTRelayController finish]): Added.
1020         (-[LTRelayController readFileHandle:]): Deleted.
1021
1022 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1023
1024         [EFL] Crash on facebook.com
1025         https://bugs.webkit.org/show_bug.cgi?id=137562
1026
1027         Reviewed by Chris Dumez.
1028
1029         Crash occurs on the facebook.com when the webview is resized
1030         after the <select> item is clicked but no item is chosen.
1031         This crash is just caused by the reference of invalidated variable.
1032         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
1033         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
1034         on MiniBrowser is called.
1035         As a result, just set ewk_menu to NULL in order to prevent crash condition.
1036
1037         * MiniBrowser/efl/main.c:
1038         (on_popup_menu_hide):
1039
1040 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1041
1042         A small wording change for clarity.
1043
1044         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
1045         (MetricsBubbleView.prototype._update):
1046
1047 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1048
1049         Dashboard metrics page should have EWS statistics
1050         https://bugs.webkit.org/show_bug.cgi?id=137626
1051
1052         Reviewed by Ryosuke Niwa.
1053
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
1055         (BubbleQueue): Put shortName in the object, so that it's actually useful.
1056
1057         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1058         (BubbleQueueServer): Re-ordered queues to match bubble order.
1059         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
1060         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
1061
1062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
1063         Added analysis for bubble queues.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
1066
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1068         (buildBubbleQueuesTable): Build the UI.
1069
1070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
1071         Added JS sources to load.
1072
1073         * QueueStatusServer/app.yaml: To update app version.
1074
1075         * QueueStatusServer/handlers/processingtimesjson.py: Added.
1076
1077         * QueueStatusServer/main.py: Added a handler for processing-times-json.
1078
1079 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
1080
1081         REGRESSION: Commit queue doesn't process rollouts
1082         https://bugs.webkit.org/show_bug.cgi?id=137623
1083
1084         Reviewed by Tim Horton.
1085
1086         * QueueStatusServer/app.yaml:
1087         * QueueStatusServer/handlers/updateworkitems.py:
1088         (UpdateWorkItems._work_items_from_request):
1089
1090 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
1091
1092         Fix syntax error after r174601.
1093
1094         * Scripts/run-javascriptcore-tests:
1095
1096 2014-10-10  Michael Saboff  <msaboff@apple.com>
1097
1098         Add ability to select tarfile name in run-jsc-stress-tests
1099         https://bugs.webkit.org/show_bug.cgi?id=137614
1100
1101         Reviewed by Mark Hahnenberg.
1102
1103         Added optional file name argument to the --tarball option.  
1104
1105         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
1106         extra test given after the options wont be used for the optional tarball file name.
1107         * Scripts/run-jsc-stress-tests:
1108
1109 2014-10-10  Chris Dumez  <cdumez@apple.com>
1110
1111         Unreviewed, update my information in contributors.json
1112
1113         Use my preferred first name and update my expertise areas.
1114
1115         * Scripts/webkitpy/common/config/contributors.json:
1116
1117 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
1118
1119         Fix perl scripts to run with env on Linux
1120         https://bugs.webkit.org/show_bug.cgi?id=137601
1121
1122         Reviewed by Csaba Osztrogonác.
1123
1124         Use of arguments in #! is nonstandard and does not behave the same on
1125         different systems. Linux would look for an executable named "perl -w" 
1126         "use warnings;" does the same things in a more portable way.
1127
1128         * Scripts/commit-log-editor:
1129         * Scripts/num-cpus:
1130         * Scripts/prepare-ChangeLog:
1131         * Scripts/run-launcher:
1132         * Scripts/svn-create-patch:
1133
1134 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1135
1136         [jhbuild] We should be able to disable wiping on configuration change
1137         https://bugs.webkit.org/show_bug.cgi?id=137446
1138
1139         Reviewed by Csaba Osztrogonác.
1140
1141         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
1142         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
1143         or passing --no-wipe-on-change command line option.
1144
1145         * Scripts/update-webkit-libs-jhbuild:
1146
1147 2014-10-09  Andy Estes  <aestes@apple.com>
1148
1149         Teach webkitpy about OS X Yosemite
1150         https://bugs.webkit.org/show_bug.cgi?id=137585
1151
1152         Reviewed by Simon Fraser.
1153
1154         * Scripts/webkitpy/common/system/platforminfo.py:
1155         (PlatformInfo._determine_mac_version):
1156         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
1157         (TestPlatformInfo.test_os_version):
1158         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1159         (TestExpectationParser):
1160         * Scripts/webkitpy/port/builders.py:
1161         * Scripts/webkitpy/port/mac.py:
1162         (MacPort):
1163         * Scripts/webkitpy/port/mac_unittest.py:
1164         (test_versions):
1165         (test_baseline_search_path):
1166         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1167         (TestRebaselineTest.test_baseline_directory):
1168         (TestRebaselineExpectations.test_rebaseline_expectations):
1169
1170 2014-10-09  Dana Burkart  <dburkart@apple.com>
1171
1172         Add Mac OS Yosemite dashboard support.
1173
1174         Rubber-stamped by Lucas Forschler.
1175
1176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
1177         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
1178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1180         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1181
1182 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
1183
1184         Add Babak to contributors.json and add historical email addresses for some contributors
1185         https://bugs.webkit.org/show_bug.cgi?id=137546
1186
1187         Reviewed by Christophe Dumez.
1188
1189         contributors.json is used to analyze historical commit data and change logs.
1190
1191         Add back historical email addresses for some contributors and also add Babak (Shafiei).
1192
1193         * Scripts/webkitpy/common/config/contributors.json:
1194
1195 2014-10-09  Lucas Forschler  <lforschler@apple.com>
1196
1197         Add Mac OS Yosemite webkit build infrastructure.
1198         
1199         This patch adds 15 bots to our build.webkit.org configuration.
1200         We are matching the current Mavericks machines 1:1.
1201         
1202         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
1203         
1204         Reviewed by Matt Hanson.
1205
1206         * BuildSlaveSupport/build.webkit.org-config/config.json:
1207
1208 2014-10-09  Dana Burkart  <dburkart@apple.com>
1209
1210         Don't use backticks when running commands, as we run into sh-related
1211         interpolation issues. Also, fix our usage of system() to properly
1212         retrieve the status code.
1213         https://bugs.webkit.org/show_bug.cgi?id=137541
1214
1215         Reviewed by Darin Adler.
1216
1217         * Scripts/git-add-reviewer:
1218         (interactive):
1219         (nonInteractive):
1220         (requireCleanWorkTree):
1221         (cherryPick):
1222         (commit):
1223         (addReviewerToFile):
1224         (head):
1225         (isAncestor):
1226         (toCommit):
1227         (changeLogsForCommit):
1228         (resetToCommit):
1229         (getConfigValue):
1230         (runCommandWithOutput):
1231
1232 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1233
1234         Add a WebKit1 preference for selection services
1235         https://bugs.webkit.org/show_bug.cgi?id=137498
1236         <rdar://problem/18572699>
1237
1238         Reviewed by Simon Fraser.
1239
1240         * MiniBrowser/mac/WK1BrowserWindowController.m:
1241         (-[WK1BrowserWindowController awakeFromNib]):
1242         Turn on image and selection services in the Legacy WebKit MiniBrowser.
1243
1244 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
1245
1246         Get the patch scripts running on Haiku
1247         https://bugs.webkit.org/show_bug.cgi?id=137559
1248
1249         Reviewed by Benjamin Poulain.
1250
1251         Use /usr/bin/env instead of hardcoding path to perl.
1252         Declare haiku platform in platforminfo.py to avoid check-webkit-style
1253         failure.
1254
1255         * Scripts/commit-log-editor:
1256         * Scripts/num-cpus:
1257         * Scripts/prepare-ChangeLog:
1258         * Scripts/run-launcher:
1259         * Scripts/svn-create-patch:
1260         * Scripts/webkitpy/common/system/platforminfo.py:
1261         (PlatformInfo._determine_os_name):
1262
1263 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
1264
1265         StyleQueue should throw a PatchIsNotValid exception to achieve
1266         consistency with CommitQueue and EWS
1267         https://bugs.webkit.org/show_bug.cgi?id=137500
1268
1269         Reviewed by Alexey Proskuryakov.
1270
1271         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1272         Adds a call to validate() in run().
1273         (StyleQueueTask.run):
1274         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1275         Adds a return False in the patch is not valid exception statement.
1276         (AbstractEarlyWarningSystem.review_patch):
1277         * Scripts/webkitpy/tool/commands/queues.py:
1278         Adds a return False in the patch is not valid exception statement in
1279         commit queue, and adds an except statement to catch PatchIsNotValid
1280         exceptions in style queue.
1281         (CommitQueue.process_work_item):
1282         (StyleQueue.review_patch):
1283
1284 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1285
1286         Race condition with WebKitWebView:is-loading after starting page load
1287         https://bugs.webkit.org/show_bug.cgi?id=136692
1288
1289         Reviewed by Gustavo Noronha Silva.
1290
1291         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1292         (loadChangedCallback): Only check is-loading is false when load
1293         has finished if the load didn't fail due to a cancellation.
1294         (loadFailedCallback): Only check is-loading is false if the load
1295         didn't fail due to a cancellation.
1296         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1297         (WebViewTest::loadURI): Check is-loading is true and active URI is
1298         the requested one rigth after requesting the load.
1299         (WebViewTest::loadHtml): Ditto.
1300         (WebViewTest::loadPlainText): Ditto.
1301         (WebViewTest::loadBytes): Ditto.
1302         (WebViewTest::loadRequest): Ditto.
1303         (WebViewTest::loadAlternateHTML): Ditto.
1304         (WebViewTest::goBack): Ditto.
1305         (WebViewTest::goForward): Ditto.
1306         (WebViewTest::goToBackForwardListItem): Ditto.
1307
1308 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1309
1310         [Win] Resolve various static analyzer warnings in Tools.
1311         https://bugs.webkit.org/show_bug.cgi?id=137534
1312
1313         Reviewed by Dean Jackson.
1314
1315         * DumpRenderTree/cg/ImageDiffCG.cpp:
1316         (main): User proper printf specifiers.
1317         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1318         (AccessibilityUIElement::childrenCount): Handle possibility that
1319         gcc_accChildCount returns with an error.
1320         (accessibilityState): Ditto for gcc_accState.
1321         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1322         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1323         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1324         be treated as such.
1325         * DumpRenderTree/win/DumpRenderTree.cpp:
1326         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1327         by comparing an unsigned value as being greater-than zero.
1328         * DumpRenderTree/win/EditingDelegate.cpp:
1329         (dump): Pass proper character pointer type to printf.
1330         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1331         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1332         (EditingDelegate::shouldInsertNode): Ditto.
1333         (EditingDelegate::shouldInsertText): Ditto.
1334         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1335         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1336         (EditingDelegate::shouldApplyStyle): Ditto.
1337         * DumpRenderTree/win/EventSender.cpp:
1338         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1339         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1340         system headers.
1341         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1342         from CreateDIBSection.
1343         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1344         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1345         older versions of MSVC we no longer support.
1346         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1347         for 64-bit builds.
1348         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1349         * TestWebKitAPI/TestsController.h: Ditto.
1350         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1351         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1352         performing bitwise | before the comparison is done.
1353
1354 2014-10-08  Ada Chan  <adachan@apple.com>
1355
1356         Add a test for WKPageIsPlayingAudio().
1357         https://bugs.webkit.org/show_bug.cgi?id=137048
1358
1359         Reviewed by Darin Adler.
1360
1361         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1362         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1363         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1364         (TestWebKitAPI::nullJavaScriptCallback):
1365         (TestWebKitAPI::didFinishLoadForFrame):
1366         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1367         (TestWebKitAPI::setUpClients):
1368         (TestWebKitAPI::TEST):
1369         This test loads a page with a video in it. When the page is loaded, we first check that
1370         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1371         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1372         now returns true for the page.
1373         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1374         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1375         This is a video copied from LayoutTests/media/content.
1376
1377 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1378
1379         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1380         https://bugs.webkit.org/show_bug.cgi?id=137516
1381
1382         Reviewed by Alexey Proskuryakov.
1383
1384         * Scripts/webkitpy/thirdparty/__init__.py:
1385         (AutoinstallImportHook._install_irc):
1386
1387 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1388
1389         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1390         https://bugs.webkit.org/show_bug.cgi?id=137520
1391
1392         Reviewed by Philippe Normand.
1393
1394         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1395         For other distributions, we are already installing libjpeg-turbo.
1396         So, do the same for Debian and derivatives.
1397
1398         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1399
1400 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1401
1402         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1403         https://bugs.webkit.org/show_bug.cgi?id=137519
1404
1405         Reviewed by Csaba Osztrogonác.
1406
1407         It was removed by <http://trac.webkit.org/changeset/174266>,
1408         because the comment stated it is a workaround for buggy python
1409         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1410         is still valid with python 2.7 shipped on the latest Ubuntu
1411         (12.04 and 14.04) and OS X 10.9.
1412
1413         * Scripts/webkitpy/common/system/autoinstall.py:
1414         (AutoInstaller):
1415         (AutoInstaller._extract_all):
1416         (AutoInstaller._unzip):
1417
1418 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1419
1420         Unreviewed, rolling out r174335.
1421         https://bugs.webkit.org/show_bug.cgi?id=137515
1422
1423         It broke EFL layout test totally (Requested by gyuyoung on
1424         #webkit).
1425
1426         Reverted changeset:
1427
1428         "[EFL] Introduce EWebKit_Extension"
1429         https://bugs.webkit.org/show_bug.cgi?id=134921
1430         http://trac.webkit.org/changeset/174335
1431
1432 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1433
1434         [GTK] Make forwarding headers generation depend on source code
1435         https://bugs.webkit.org/show_bug.cgi?id=137394
1436
1437         Reviewed by Philippe Normand.
1438
1439         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1440         * TestWebKitAPI/PlatformGTK.cmake: Only run
1441         generate-forwarding-headers.pl when source code changes.
1442         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1443
1444 2014-10-07  Tanay C  <tanay.c@samsung.com>
1445
1446         Remove build warnings in Hashmap API tests
1447         https://bugs.webkit.org/show_bug.cgi?id=137484
1448
1449         Reviewed by Darin Adler.
1450
1451         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1452         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1453
1454 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1455
1456         Commit queue doesn't drop obsolete patches sometimes
1457         https://bugs.webkit.org/show_bug.cgi?id=137460
1458
1459         Reviewed by Alexey Proskuryakov.
1460
1461         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1462         Adds another test patch for use in queues_unittest.py.
1463         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1464         (MockBugzilla):
1465         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1466         Raises a PatchIsNotValid exception in the case of validate() returning
1467         false.
1468         (CommitQueueTask.run):
1469         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1470         Raises a PatchIsNotValid exception in the case of validate() returning
1471         false.
1472         (EarlyWarningSystemTask.run):
1473         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1474         Defines PatchIsNotValid exception. 
1475         (PatchIsNotValid):
1476         (PatchIsNotValid.__init__):
1477         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1478         Remove call to validate() and instead catches the PatchIsNotValid
1479         exception.
1480         (AbstractEarlyWarningSystem.review_patch):
1481         * Scripts/webkitpy/tool/commands/queues.py:
1482         Adds logic to catch the PatchIsNotValid exception.
1483         (CommitQueue.process_work_item):
1484         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1485         Adds the test_non_valid_patch test to ensure that invalid patches are
1486         handled properly, and don't just result in indefinite spinning.
1487         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1488         (test_non_valid_patch):
1489
1490 2014-10-07  Daniel Bates  <dabates@apple.com>
1491
1492         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1493         https://bugs.webkit.org/show_bug.cgi?id=137499
1494
1495         Reviewed by Simon Fraser.
1496
1497         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1498         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1499         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1500         bit simulator builds of iOS WebKit.
1501
1502         * Scripts/webkitpy/port/ios.py:
1503         (IOSSimulatorPort._generate_all_test_configurations):
1504
1505 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1506
1507         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1508         https://bugs.webkit.org/show_bug.cgi?id=137482
1509
1510         Reviewed by Martin Robinson.
1511
1512         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1513
1514 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1515
1516         [SOUP] TLS errors should take precedence over HTTP authentication
1517         https://bugs.webkit.org/show_bug.cgi?id=137300
1518
1519         Reviewed by Sergio Villar Senin.
1520
1521         Add a test case to check that authenticate signal is not emitted
1522         in case of TLS errors, and the load fails instead.
1523
1524         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1525         (webViewAuthenticationCallback):
1526         (testTLSErrorsHTTPAuth):
1527         (httpsServerCallback):
1528         (beforeAll):
1529
1530 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1531
1532         Make webkit-patch find-users useful
1533         https://bugs.webkit.org/show_bug.cgi?id=137475
1534
1535         Reviewed by Alexey Proskuryakov.
1536
1537         Make find-users use the CommitterList instead of accessing Bugzilla.
1538
1539         This essentially exposes the same functionality as webkitbot's whois command.
1540
1541         * Scripts/webkitpy/tool/commands/findusers.py:
1542         (FindUsers.execute):
1543
1544 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1545
1546         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1547         https://bugs.webkit.org/show_bug.cgi?id=137289
1548
1549         Unreviewed build fix.
1550
1551         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1552         (AccessibilityUIElement::getChildrenWithRange):
1553
1554 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1555
1556         build.webkit.org/dashboard: Add commit queue
1557         https://bugs.webkit.org/show_bug.cgi?id=137462
1558
1559         Reviewed by Tim Horton.
1560
1561         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1562         Style queue is still invisible, as it doesn't have an associated platform, and also
1563         we never have problems with it anyway, so it's not worth watching.
1564
1565         The UI now allows for adding more bots to the Other column (such as leaks bot).
1566         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1567         sources of data in a cell.
1568
1569         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1570         (BubbleQueue):
1571         (BubbleQueue.prototype.get statusPageURL):
1572         (BubbleQueue.prototype.update):
1573         (BubbleQueue.prototype.loadDetailedStatus):
1574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1575         (BubbleQueueServer):
1576         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1577         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1578         (BubbleQueueServer.prototype.queueStatusURL):
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1580         (BubbleQueueView):
1581         (BubbleQueueView.prototype.update.appendQueue):
1582         (BubbleQueueView.prototype.update):
1583         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1584         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1585         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1586         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1587         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1588         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1589         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1590         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1591         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1592         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1593         (.bubble-server-popover .latest-status-no-link):
1594         (.bubble-server-popover .bot-status-description):
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1596
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1598         (buildAggregateTable):
1599         (buildQueuesTable):
1600         Removed dysfunctional support for EWS for now. It will be different.
1601
1602 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1603
1604         One more case of incorrect comparison in recordpatchevent.py
1605         https://bugs.webkit.org/show_bug.cgi?id=137459
1606
1607         Reviewed by Tim Horton.
1608
1609         * QueueStatusServer/app.yaml:
1610         * QueueStatusServer/loggers/recordpatchevent.py:
1611         (RecordPatchEvent.started):
1612
1613 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1614
1615         webkit-queues PatchLog is incorrect for patches that took less than a second
1616         https://bugs.webkit.org/show_bug.cgi?id=137453
1617
1618         Reviewed by Tim Horton.
1619
1620         * QueueStatusServer/app.yaml: Updated app version.
1621
1622         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
1623         Don't bail out for patches that took 0 seconds to process (as frequently happens
1624         when a patch is obsolete).
1625
1626 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
1627
1628         EWS bubble hover shows wrong timestamps
1629         https://bugs.webkit.org/show_bug.cgi?id=137252
1630
1631         Reviewed by Alexey Proskuryakov.
1632
1633         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
1634
1635         * QueueStatusServer/handlers/queuestatusjson.py:
1636         (QueueStatusJSON.get):
1637         * QueueStatusServer/handlers/statusbubble.py:
1638         (StatusBubble._iso_time):
1639
1640 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1641
1642         Unreviewed, updated list of email addresses in contributors.json
1643
1644         * Scripts/webkitpy/common/config/contributors.json: Added my former
1645         email address in Igalia, for the sake of completeness.
1646
1647 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1648
1649         Unreviewed, moved myself to the list of committers.
1650
1651         * Scripts/webkitpy/common/config/contributors.json:
1652
1653 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1654
1655         [EFL] Introduce EWebKit_Extension
1656         https://bugs.webkit.org/show_bug.cgi?id=134921
1657
1658         Reviewed by Gyuyoung Kim.
1659
1660         * MiniBrowser/efl/main.c: Added x option to test extension path.
1661         (window_create):
1662         (elm_main):
1663         * Scripts/webkitpy/common/config/watchlist:
1664         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1665         * Scripts/webkitpy/style/checker.py:
1666         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1667
1668 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1669
1670         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1671         https://bugs.webkit.org/show_bug.cgi?id=137390
1672
1673         Reviewed by Carlos Garcia Campos.
1674
1675         * Scripts/update-webkit-libs-jhbuild:
1676
1677 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1678
1679         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1680         https://bugs.webkit.org/show_bug.cgi?id=137391
1681
1682         Reviewed by Martin Robinson.
1683
1684         Add a custom command to only re-generate
1685         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1686
1687         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1688
1689 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1690
1691         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1692         https://bugs.webkit.org/show_bug.cgi?id=135502
1693
1694         Reviewed by Martin Robinson.
1695
1696         When writing to stdout/stderr fails due to a UnicodeDecodeError
1697         exception, try again without encoding the output.
1698
1699         * gtk/gtkdoc.py:
1700         (GTKDoc._run_command):
1701
1702 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1703
1704         Bugzilla status bubble displays an exception showing attachment 175738
1705         https://bugs.webkit.org/show_bug.cgi?id=137410
1706
1707         Reviewed by Tim Horton.
1708
1709         * QueueStatusServer/app.yaml: Update version.
1710
1711         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1712         Don't fail even if expected status message is missing.
1713
1714         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1715         the field in the same way it's defined in QueueStatus table.
1716
1717 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1718
1719         Record latest message in PatchLog for quick access
1720         https://bugs.webkit.org/show_bug.cgi?id=137405
1721
1722         Fixing a typo.
1723
1724         * QueueStatusServer/app.yaml:
1725         * QueueStatusServer/handlers/releasepatch.py:
1726
1727 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1728
1729         Record latest message in PatchLog for quick access
1730         https://bugs.webkit.org/show_bug.cgi?id=137405
1731
1732         Reviewed by Ryosuke Niwa.
1733
1734         It's no SQL...
1735
1736         * QueueStatusServer/handlers/releasepatch.py:
1737         * QueueStatusServer/handlers/updatestatus.py:
1738         * QueueStatusServer/loggers/recordpatchevent.py:
1739         * QueueStatusServer/model/patchlog.py:
1740
1741 2014-10-02  David Farler  <dfarler@apple.com>
1742
1743         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1744         https://bugs.webkit.org/show_bug.cgi?id=137377
1745
1746         Reviewed by Daniel Bates.
1747
1748         * asan/asan.xcconfig:
1749         -asan-blacklist -> -fsanitize-blacklist
1750
1751         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1752
1753 2014-10-03  Roger Fong  <roger_fong@apple.com>
1754
1755         [Windows] Include batch size argument to layout tests on Windows.
1756
1757         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1758         (RunWebKitTests.start): 
1759         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1760         These crashes seem to happen on random tests though generally in a spread out fashion.
1761         It seems possible that the DRT instance is being clobbered somehow after running too many
1762         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1763
1764 2014-10-03  Roger Fong  <roger_fong@apple.com>
1765
1766         [Windows] Settle for 2 chid processes running NRWT on Windows.
1767
1768         * Scripts/webkitpy/port/win.py:
1769         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1770
1771 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1772
1773         [GTK] Bump up and patch dependencies to allow building for aarch64
1774         https://bugs.webkit.org/show_bug.cgi?id=137147
1775
1776         Reviewed by Martin Robinson.
1777
1778         The currently used versions of pixman, libffi, librsvg, glib,
1779         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1780         and/or build for aarch64, so they are bumped up and patched where
1781         necessary. Wherever possible, the same versions and patches were used as
1782         for the EFL port bump-up
1783         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1784
1785         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1786         regression by crashing http/tests/media/video-redirect.html . A patch
1787         already in upstream fixes that bug.
1788
1789         This change does not touch xserver, which also needs bumping up, but 
1790         will be dealt with later.
1791
1792         * gtk/jhbuild.modules:
1793         Specified versions and patches necessary to correctly build for aarch64.
1794         * gtk/patches/gst-events-arent-gstobjects.patch:
1795         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1796         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1797         Added. Patches gst-plugins-base to configure correctly for aarch64.
1798         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1799         Added. Bumps up config.guess and config.sub in librsvg to recognize
1800         aarch64.
1801         * gtk/patches/libxml2-2.9.0-dtd.patch:
1802         Removed. Not necessary for libxml2 v2.9.1 anymore.
1803
1804 2014-09-28  Sam Weinig  <sam@webkit.org>
1805
1806         Remove RefPtrHashMap
1807         https://bugs.webkit.org/show_bug.cgi?id=137200
1808
1809         Reviewed by Darin Adler.
1810
1811         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1812         (TestWebKitAPI::TEST):
1813         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1814         a minimum of refcount churn occurs.
1815
1816 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1817
1818         Remove workarounds for versions of Python before 2.7
1819         https://bugs.webkit.org/show_bug.cgi?id=137338
1820
1821         Reviewed by Csaba Osztrogonác.
1822
1823         * Scripts/webkitpy/common/system/autoinstall.py:
1824         (AutoInstaller._extract_targz):
1825         (AutoInstaller._unzip):
1826         (AutoInstaller): Deleted.
1827         (AutoInstaller._extract_all): Deleted.
1828         * Scripts/webkitpy/common/webkitunittest.py:
1829         (TestCase.setUp): Deleted.
1830         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1831         (TestConfigurationConverter.collapse_macros):
1832         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1833         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1834         (TestConfigurationConverter):
1835         (TestConfigurationConverter.combinations): Deleted.
1836         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1837         * Scripts/webkitpy/port/base.py:
1838
1839 2014-10-03  Commit Queue  <commit-queue@webkit.org>
1840
1841         Unreviewed, rolling out r174264.
1842         https://bugs.webkit.org/show_bug.cgi?id=137392
1843
1844         It broke run-webkit-tests (Requested by ebalazsfalvi on
1845         #webkit).
1846
1847         Reverted changeset:
1848
1849         "Remove workarounds for versions of Python before 2.7"
1850         https://bugs.webkit.org/show_bug.cgi?id=137338
1851         http://trac.webkit.org/changeset/174264
1852
1853 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1854
1855         Remove workarounds for versions of Python before 2.7
1856         https://bugs.webkit.org/show_bug.cgi?id=137338
1857
1858         Reviewed by Csaba Osztrogonác.
1859
1860         * Scripts/webkitpy/common/system/autoinstall.py:
1861         (AutoInstaller._extract_targz):
1862         (AutoInstaller._unzip):
1863         (AutoInstaller): Deleted.
1864         (AutoInstaller._extract_all): Deleted.
1865         * Scripts/webkitpy/common/webkitunittest.py:
1866         (TestCase.setUp): Deleted.
1867         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1868         (TestConfigurationConverter.collapse_macros):
1869         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1870         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1871         (TestConfigurationConverter):
1872         (TestConfigurationConverter.combinations): Deleted.
1873         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1874         * Scripts/webkitpy/port/base.py:
1875         * Scripts/webkitpy/port/driver.py:
1876         (ContentBlock.__init__):
1877         * Scripts/webkitpy/port/server_process.py:
1878         (ServerProcess._reset):
1879
1880 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1881
1882         Remove autoinstaller workaround for python 2.6
1883         https://bugs.webkit.org/show_bug.cgi?id=137343
1884
1885         Reviewed by Daniel Bates.
1886
1887         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
1888         2.6, nor Snow Leopard is supported anymore, so the workaround is not
1889         needed anymore.
1890
1891         * Scripts/webkitpy/common/system/autoinstall.py:
1892         (AutoInstaller.install):
1893         * Scripts/webkitpy/test/main.py:
1894         (Tester._run_tests):
1895         * Scripts/webkitpy/thirdparty/__init__.py:
1896         (AutoinstallImportHook._install_mechanize):
1897         (AutoinstallImportHook._install_pep8):
1898         (AutoinstallImportHook._install_pylint):
1899         (AutoinstallImportHook._install_buildbot):
1900         (AutoinstallImportHook._install_coverage):
1901         (AutoinstallImportHook._install_eliza):
1902         (AutoinstallImportHook._install_irc):
1903         (AutoinstallImportHook._install):
1904         (autoinstall_everything):
1905
1906 2014-10-02  Daniel Bates  <dabates@apple.com>
1907
1908         Use version number 101000 instead of 10100 for OS X Yosemite
1909         https://bugs.webkit.org/show_bug.cgi?id=137372
1910
1911         Reviewed by Mark Rowe.
1912
1913         The version number for OS X Yosemite is 101000.
1914
1915         * DumpRenderTree/mac/TextInputController.m:
1916
1917 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
1918
1919         update-work-items should never delete items
1920         https://bugs.webkit.org/show_bug.cgi?id=137366
1921
1922         Reviewed by Ryosuke Niwa.
1923
1924         As we don't just replace the whole list any more, indicate which items are high
1925         priority, and which are not. Hight priority ones will be prepended to the queue,
1926         others will be appended.
1927
1928         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
1929         But hopefully we will never have many rollouts competing like that.
1930
1931         * QueueStatusServer/app.yaml: Update version.
1932
1933         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
1934         priority and regular items separately. Removed some error handling that used to
1935         end up in returning status 500 - an uncaught exception does that automatically.
1936
1937         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
1938
1939         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
1940
1941         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
1942         priority items.
1943
1944         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1945         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
1946         line that complicated testing.
1947
1948         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
1949
1950         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
1951         priority items into separate lists.
1952
1953         * Scripts/webkitpy/common/net/statusserver_mock.py:
1954         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1955         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1956         Updated tests.
1957
1958 2014-10-02  Brendan Long  <b.long@cablelabs.com>
1959
1960         Annoying build warnings in WTFString API tests
1961         https://bugs.webkit.org/show_bug.cgi?id=137360
1962
1963         Reviewed by Darin Adler.
1964
1965         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1966         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1967
1968 2014-10-02  Roger Fong  <roger_fong@apple.com>
1969
1970         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1971
1972         * Scripts/webkitpy/port/win.py:
1973         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1974
1975 2014-10-02  David Farler  <dfarler@apple.com>
1976
1977         Move ASan arguments from LLVM (-mllvm) to the frontend
1978         https://bugs.webkit.org/show_bug.cgi?id=137365
1979
1980         Reviewed by David Kilzer.
1981
1982         * asan/asan.xcconfig:
1983         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1984         to the clang frontend.
1985
1986         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1987
1988 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1989
1990         Unreviewed, rolling out r174120.
1991         https://bugs.webkit.org/show_bug.cgi?id=137350
1992
1993         While number of failures is reasonable with 2 processes, test
1994         results seem to be inconsistent between runs (Requested by
1995         rfong on #webkit).
1996
1997         Reverted changeset:
1998
1999         "[Windows] Back to 2 child processes for NRWT on Windows."
2000         http://trac.webkit.org/changeset/174120
2001
2002 2014-10-02  Jeff Miller  <jeffm@apple.com>
2003
2004         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
2005         https://bugs.webkit.org/show_bug.cgi?id=137347
2006
2007         Reviewed by Dan Bernstein.
2008
2009         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2010         Use WebKitSystemInterfaceYosemite on OS X 10.10.
2011
2012         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2013         Ditto.
2014
2015 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2016
2017         [GTK] [JHBuild] Switch sourceware.org mirror to http.
2018
2019         Unreviewed.
2020
2021         The ftp access is recently failing to work as expected, and the
2022         bots fail to download the file.
2023         The same mirror is available via http and seems to work better.
2024
2025         * gtk/jhbuild.modules:
2026
2027 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2028
2029         Unreviewed, rolling out r174185.
2030         https://bugs.webkit.org/show_bug.cgi?id=137334
2031
2032         Patch that adds logging causes webkitpy failures (Requested by
2033         rfong on #webkit).
2034
2035         Reverted changeset:
2036
2037         "commitqueuetasks_unittest references a non-existent member
2038         variable"
2039         https://bugs.webkit.org/show_bug.cgi?id=137303
2040         http://trac.webkit.org/changeset/174185
2041
2042 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2043
2044         EWS and Commit Queue should know better than to spew 500 failed
2045         results in the case of extremely red patches.
2046         https://bugs.webkit.org/show_bug.cgi?id=137324
2047
2048         Reviewed by Alexey Proskuryakov.
2049
2050         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2051         Adds a check for did_exceed_test_failure_limit.
2052         (AbstractEarlyWarningSystem._failing_tests_message):
2053         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2054         Alters the task mock to respond properly to
2055         results_from_patch_test_run(patch)
2056         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2057         * Scripts/webkitpy/tool/commands/queues.py:
2058         Adds a check for did_exceed_test_failure_limit.
2059         (CommitQueue._failing_tests_message):
2060
2061 2014-10-01  Daniel Bates  <dabates@apple.com>
2062
2063         Unreviewed, rolling out r174192.
2064
2065         Revert the unit test fix in r174192 since we reverted r174187
2066         in r174194 due to correctness issues. See
2067         <http://webkit.org/b/137329> for more details.
2068
2069         Reverted changeset:
2070
2071         "Test fix after r174187"
2072         http://trac.webkit.org/changeset/174192
2073
2074 2014-10-01  Mark Rowe  <mrowe@apple.com>
2075
2076         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
2077
2078         Reviewed by Dan Bernstein.
2079
2080         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
2081         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
2082         for the LLVM components when on Yosemite.
2083
2084 2014-10-01  Commit Queue  <commit-queue@webkit.org>
2085
2086         Unreviewed, rolling out r174187.
2087         https://bugs.webkit.org/show_bug.cgi?id=137329
2088
2089         webkitpy failures, and thorton says the patch is wrong
2090         (Requested by dethbakin on #webkit).
2091
2092         Reverted changeset:
2093
2094         "[Windows] Increase layout test timeout for Windows following
2095         r174162."
2096         http://trac.webkit.org/changeset/174187
2097
2098 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
2099
2100         Test fix after r174187
2101
2102         * Scripts/webkitpy/port/win_unittest.py:
2103         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
2104
2105 2014-10-01  Roger Fong  <roger_fong@apple.com>
2106
2107         [Windows] Increase layout test timeout for Windows following r174162.
2108
2109         * Scripts/webkitpy/port/win.py:
2110         (WinPort.default_timeout_ms):
2111
2112 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2113
2114         commitqueuetasks_unittest references a non-existent member variable
2115         when mock-reporting flaky tests.
2116         https://bugs.webkit.org/show_bug.cgi?id=137303
2117
2118         Reviewed by Daniel Bates.
2119
2120         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2121         (MockCommitQueue.report_flaky_tests):
2122         Makes the appropriate name change.
2123         (test_simple_flaky_test_failure):
2124         Adds a unit test to make sure that the code is excercised.
2125
2126 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2127
2128         EWS is inconclusively spinning forever on a patch that breaks 500+
2129         tests
2130         https://bugs.webkit.org/show_bug.cgi?id=137223
2131
2132         Reviewed by Tim Horton.
2133
2134         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2135         Checks to see whether the tests have exceeded the failure limit, and
2136         only spins off another test if they have not exceeded the limit.
2137         (PatchAnalysisTask._test_patch):
2138
2139 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
2140
2141         Unreviewed, add Katie Madonna as a contributor.
2142
2143         * Scripts/webkitpy/common/config/contributors.json:
2144
2145 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
2146
2147         commitqueuetasks_unittest does not construct FailingTestCommitQueue
2148         objects properly in its test cases.
2149         https://bugs.webkit.org/show_bug.cgi?id=137281
2150
2151         Reviewed by Daniel Bates.
2152
2153         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2154         (FailingTestCommitQueue.test_results):
2155         Adds an assert to make FailingTestCommitQueue harder to mis-use.
2156         (test_double_flaky_test_failure):
2157         Nests the intended test failure strings into one-length lists.
2158         (test_red_test_failure):
2159         Nests the intended test failure strings into one-length lists.
2160
2161 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2162
2163         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
2164         https://bugs.webkit.org/show_bug.cgi?id=136987
2165
2166         Reviewed by Daniel Bates.
2167
2168         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
2169         Specify the default encoding for all WebKit developers to get consistent results.
2170
2171 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
2172
2173         EWS is too eager to say that a patch does not apply to trunk of repository
2174         https://bugs.webkit.org/show_bug.cgi?id=137290
2175
2176         Reviewed by Ryosuke Niwa.
2177
2178         * QueueStatusServer/app.yaml: Updated app version.
2179
2180         * QueueStatusServer/handlers/statusbubble.py:
2181         (StatusBubble._build_bubble):
2182         (StatusBubble._build_bubbles_for_attachment):
2183         Rewrote to make more sense.
2184
2185 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2186
2187         Remove thirdparty/unittest2 from webkitpy
2188         https://bugs.webkit.org/show_bug.cgi?id=137251
2189
2190         Reviewed by Brent Fulgham.
2191
2192         Additionally ordered imports in related webkitpy files and
2193         removed unnecessary shebangs from unittest files.
2194
2195         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
2196         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2197         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2198         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2199         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2200         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2201         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2202         * Scripts/webkitpy/common/config/committers_unittest.py:
2203         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2204         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
2205         * Scripts/webkitpy/common/config/ports_unittest.py:
2206         * Scripts/webkitpy/common/config/urls_unittest.py:
2207         * Scripts/webkitpy/common/editdistance_unittest.py:
2208         * Scripts/webkitpy/common/find_files_unittest.py:
2209         * Scripts/webkitpy/common/lru_cache_unittest.py:
2210         * Scripts/webkitpy/common/memoized_unittest.py:
2211         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
2212         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2213         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2214         * Scripts/webkitpy/common/net/credentials_unittest.py:
2215         * Scripts/webkitpy/common/net/failuremap_unittest.py:
2216         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2217         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2218         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2219         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2220         * Scripts/webkitpy/common/net/statusserver_unittest.py:
2221         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2222         * Scripts/webkitpy/common/newstringio_unittest.py:
2223         * Scripts/webkitpy/common/prettypatch_unittest.py:
2224         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2225         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2226         * Scripts/webkitpy/common/system/environment_unittest.py:
2227         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
2228         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
2229         * Scripts/webkitpy/common/system/executive_unittest.py:
2230         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2231         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2232         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2233         * Scripts/webkitpy/common/system/logtesting.py:
2234         * Scripts/webkitpy/common/system/logutils_unittest.py:
2235         * Scripts/webkitpy/common/system/outputcapture.py:
2236         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2237         * Scripts/webkitpy/common/system/outputtee_unittest.py:
2238         * Scripts/webkitpy/common/system/path_unittest.py:
2239         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2240         * Scripts/webkitpy/common/system/profiler_unittest.py:
2241         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
2242         * Scripts/webkitpy/common/system/user_unittest.py:
2243         * Scripts/webkitpy/common/system/workspace_unittest.py:
2244         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2245         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
2246         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
2247         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
2248         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
2249         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
2250         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2251         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2252         * Scripts/webkitpy/common/webkitunittest.py:
2253         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2254         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2255         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2256         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2257         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2258         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2259         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2260         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2261         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
2262         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2263         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2264         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2265         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
2266         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2267         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2268         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2269         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2270         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2271         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2272         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2273         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2274         * Scripts/webkitpy/port/base_unittest.py:
2275         * Scripts/webkitpy/port/builders_unittest.py:
2276         * Scripts/webkitpy/port/config_unittest.py:
2277         * Scripts/webkitpy/port/driver_unittest.py:
2278         * Scripts/webkitpy/port/efl_unittest.py:
2279         * Scripts/webkitpy/port/factory_unittest.py:
2280         * Scripts/webkitpy/port/gtk_unittest.py:
2281         * Scripts/webkitpy/port/http_lock_unittest.py:
2282         * Scripts/webkitpy/port/image_diff_unittest.py:
2283         * Scripts/webkitpy/port/leakdetector_unittest.py:
2284         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2285         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2286         * Scripts/webkitpy/port/mock_drt_unittest.py:
2287         * Scripts/webkitpy/port/port_testcase.py:
2288         * Scripts/webkitpy/port/server_process_unittest.py:
2289         * Scripts/webkitpy/port/westondriver_unittest.py:
2290         * Scripts/webkitpy/port/win_unittest.py:
2291         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2292         * Scripts/webkitpy/style/checker_unittest.py:
2293         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2294         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2295         * Scripts/webkitpy/style/checkers/common_unittest.py:
2296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2297         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2298         * Scripts/webkitpy/style/checkers/js_unittest.py:
2299         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2300         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2301         * Scripts/webkitpy/style/checkers/png_unittest.py:
2302         * Scripts/webkitpy/style/checkers/python_unittest.py:
2303         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2304         * Scripts/webkitpy/style/checkers/text_unittest.py:
2305         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2306         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2307         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2308         * Scripts/webkitpy/style/error_handlers_unittest.py:
2309         * Scripts/webkitpy/style/filereader_unittest.py:
2310         * Scripts/webkitpy/style/filter_unittest.py:
2311         * Scripts/webkitpy/style/main_unittest.py:
2312         * Scripts/webkitpy/style/optparser_unittest.py:
2313         * Scripts/webkitpy/style/patchreader_unittest.py:
2314         * Scripts/webkitpy/test/finder_unittest.py:
2315         * Scripts/webkitpy/test/main.py: Ordered imports.
2316         * Scripts/webkitpy/test/main_unittest.py:
2317         * Scripts/webkitpy/test/printer.py: Ordered imports.
2318         (Printer.configure):
2319         * Scripts/webkitpy/test/runner_unittest.py:
2320         * Scripts/webkitpy/test/skip_unittest.py:
2321         * Scripts/webkitpy/thirdparty/__init__.py:
2322         (AutoinstallImportHook._install_irc):
2323         (AutoinstallImportHook._install_unittest2): Deleted.
2324         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2325         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2326         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2327         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2328         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2329         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2330         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2331         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2332         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2333         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2334         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2335         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2336         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2337         * Scripts/webkitpy/tool/commands/download_unittest.py:
2338         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2339         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2340         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2341         * Scripts/webkitpy/tool/commands/queuestest.py:
2342         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2343         * Scripts/webkitpy/tool/grammar_unittest.py:
2344         * Scripts/webkitpy/tool/mocktool_unittest.py:
2345         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2346         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2347         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2348         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2349         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2350         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2351         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2352         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2353         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2354         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2355         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2356         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2357         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2358         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2359         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2360         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2361         * Scripts/webkitpy/tool/steps/update_unittest.py:
2362         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2363         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2364         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2365         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2366         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2367
2368 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2369
2370         LayoutTestResults and ExpectedFailures should know about the
2371         interrupted flag from the json results file
2372         https://bugs.webkit.org/show_bug.cgi?id=137229
2373
2374         Reviewed by Daniel Bates.
2375
2376         Changes LayoutTestResults to use the interrupted flag instead of
2377         counting failures.
2378
2379         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2380         (BuilderTest._install_fetch_build._mock_fetch_build):
2381         (BuilderTest.test_latest_layout_test_results):
2382         * Scripts/webkitpy/common/net/layouttestresults.py:
2383         Removes notion of failure_limit_count, and adds
2384         did_exceed_test_failure_limit.
2385
2386         (LayoutTestResults.results_from_string):
2387         (LayoutTestResults.__init__):
2388         (LayoutTestResults.did_exceed_test_failure_limit):
2389         (LayoutTestResults): Deleted.
2390         (LayoutTestResults.set_failure_limit_count): Deleted.
2391         (LayoutTestResults.failure_limit_count): Deleted.
2392         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2393         Removes unit test for failure_limit_count logic.
2394
2395         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2396         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2397         Instead of providing a class method that returns a list of
2398         TestResults objects, resultsjsonparser now provides a class
2399         ParsedJSONResults that serves as an interface between the results.json
2400         file and the rest of webkitpy.
2401
2402         (ParsedJSONResults):
2403         (ParsedJSONResults.__init__):
2404         (ParsedJSONResults.did_exceed_test_failure_limit):
2405         (ParsedJSONResults.test_results):
2406         (ResultsJSONParser): Deleted.
2407         (ResultsJSONParser.parse_results_json): Deleted.
2408         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2409         Updates the unit test so that it can test the new ResultsJSONParser
2410         class.
2411
2412         (ParsedJSONResultsTest):
2413         (test_basic):
2414         (ResultsJSONParserTest): Deleted.
2415         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2416         Updates the unit test to instantiate ResultsJSONParser objects rather
2417         than simple lists of TestResult objects.
2418
2419         (MockCommitQueue.test_results):
2420         (FailingTestCommitQueue.test_results):
2421         (test_flaky_test_failure):
2422         (test_failed_archive):
2423         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2424         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2425         method rather than counting the number of failed tests.
2426
2427         (ExpectedFailures._should_trust):
2428         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2429         Updates MockResults to more closely resemble the updated
2430         LayoutTestResults class.
2431
2432         (MockResults.__init__):
2433         (MockResults.did_exceed_test_failure_limit):
2434         (ExpectedFailuresTest.test_can_trust_results):
2435         (ExpectedFailuresTest.test_unexpected_failures_observed):
2436         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2437         (MockResults.failure_limit_count): Deleted.
2438         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2439         Removes a FIXME regarding the use of the
2440         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2441
2442         (LayoutTestResultsReader.results):
2443         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2444         Updates test to not check the now-nonexistant failure_count_limit
2445         method.
2446
2447         (test_missing_unit_test_results_path):
2448         (test_layout_test_results):
2449         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2450         Accounts for name change: ResultsJSONParserTest ->
2451         ParsedJSONParserTest.
2452
2453         (RebaselineTestTest.test_gather_baselines):
2454
2455 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2456
2457         [EFL] Rename TEST_THEME_DIR macro
2458         https://bugs.webkit.org/show_bug.cgi?id=137244
2459
2460         Reviewed by Csaba Osztrogonác.
2461
2462         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2463         DEFAULT_THEME_DIR is better than it.
2464
2465         * MiniBrowser/efl/main.c:
2466         (window_create):
2467         * TestWebKitAPI/efl/PlatformWebView.cpp:
2468         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2469         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2470         (WTR::PlatformWebView::PlatformWebView):
2471
2472 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2473
2474         Windows EWS went purple when it failed to build
2475         https://bugs.webkit.org/show_bug.cgi?id=137267
2476
2477         Reviewed by Ryosuke Niwa.
2478
2479         * QueueStatusServer/app.yaml: Update the version.
2480
2481         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2482         Make it work for style and win-ews queues.
2483
2484 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2485
2486         It should be fun and easy to run every possible JavaScript benchmark from the command line
2487         https://bugs.webkit.org/show_bug.cgi?id=137245
2488
2489         Reviewed by Oliver Hunt.
2490         
2491         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2492         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2493         having their own private scripts for doing benchmark runs, and didn't share them in the open
2494         source community, because of fears about the shady licensing of the benchmarks suites that
2495         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2496         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2497         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2498         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2499         but some of them are. The non-public tests are exclusively those that were not made by any
2500         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2501
2502         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2503         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2504         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2505         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2506         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2507         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2508         probably never be checked in because there is no license text anywhere in that benchmark.
2509         A valid ~/.run-jsc-benchmarks file will just be something like:
2510         
2511             {
2512                 "OctanePath": "/path/to/Octane2",
2513                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2514             }
2515         
2516         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2517         run-jsc-benchmarks will just gracefully avoid running that test suite.
2518         
2519         Finally, a word about policy: it is understood that different organizations that do
2520         development on JSC may find themselves having internal benchmarks that they cannot share
2521         because of weird licensing. It happens - usually because the organization doing JSC
2522         development found some test in the wild that is owned by someone else and therefore cannot
2523         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2524         that add support for some new kind of benchmark suite even if the suite is not made public
2525         as part of the same patch - so long as the patch isn't too invasive. An example of
2526         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2527         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2528         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2529         completely open-sourced and committed to the WebKit repo - but the reality is that this
2530         can't always be done safely.
2531
2532         * Scripts/bencher: Removed.
2533         * Scripts/run-jsc-benchmarks: Added.
2534
2535 2014-09-30  Roger Fong  <roger_fong@apple.com>
2536
2537         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2538
2539         * Scripts/webkitpy/port/drdiver.py:
2540         (Driver.stop):
2541         * Scripts/webkitpy/port/server_process.py:
2542         (ServerProcess.stop):
2543
2544 2014-09-30  Roger Fong  <roger_fong@apple.com>
2545
2546         [Windows] Back to 2 child processes for NRWT on Windows.
2547
2548         * Scripts/webkitpy/port/win.py:
2549         (WinPort.default_child_processes):
2550         Changing the number of processes to 1 did not have an effect on the layout test results. 
2551         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2552         layout tests to timeout as a whole occasionally, but we should just fix that.
2553
2554 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2555
2556         Remove an accidentally committed line..
2557
2558         * QueueStatusServer/handlers/statusbubble.py:
2559         (StatusBubble._build_bubble):
2560
2561 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2562
2563         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2564         https://bugs.webkit.org/show_bug.cgi?id=137240
2565
2566         Reviewed by Ryosuke Niwa.
2567
2568         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2569         (EWSQueue.prototype.loadDetailedStatus):
2570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2571         (EWSQueueView.prototype._popoverContentForEWSQueue):
2572         Use the new retry_count data member from JSON.
2573
2574         * QueueStatusServer/app.yaml: Updating the version.
2575
2576         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2577         Instead of message_count, produce retry_count.
2578
2579 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2580
2581         EWS doesn't need to show all the bubbles when a patch fails to apply
2582         https://bugs.webkit.org/show_bug.cgi?id=137256
2583
2584         Reviewed by Ryosuke Niwa.
2585
2586         * QueueStatusServer/app.yaml: Updated app version.
2587
2588         * QueueStatusServer/handlers/statusbubble.py:
2589         (StatusBubble._build_bubble):
2590         (StatusBubble._build_bubbles_for_attachment):
2591         (StatusBubble.get):
2592         * QueueStatusServer/templates/statusbubble.html:
2593         When some queues fail to apply, and no queues had meaningful output (meaning that
2594         they will almost certainly fail to apply later), we can show a single bubble
2595         telling the user just that.
2596
2597 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2598
2599         [EFL] Bump EFL version to 1.11.2
2600         https://bugs.webkit.org/show_bug.cgi?id=137118
2601
2602         Reviewed by Gyuyoung Kim.
2603
2604         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2605         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2606
2607         * efl/jhbuild.modules:
2608         * efl/patches/ecore.patch: Removed.
2609
2610 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2611
2612         REGRESSION(r173929): [GTK] TestInspector fails after r173929
2613         https://bugs.webkit.org/show_bug.cgi?id=137247
2614
2615         Reviewed by Philippe Normand.
2616
2617         Wait until can-attach property changes before trying to attach the
2618         inspector after resizing the view.
2619
2620         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2621         (testInspectorDefault):
2622
2623 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2624
2625         Require Python 2.7 version
2626         https://bugs.webkit.org/show_bug.cgi?id=137112
2627
2628         Reviewed by Csaba Osztrogonác.
2629
2630         * Scripts/ensure-valid-python:
2631         (checkPythonVersion):
2632         * Scripts/webkitpy/common/version_check.py:
2633
2634 2014-09-30  Martin Hock  <mhock@apple.com>
2635
2636         Skip a JSC test after r174036.
2637         https://bugs.webkit.org/show_bug.cgi?id=137236
2638
2639         Reviewed by Csaba Osztrogonác.
2640
2641         * Scripts/run-javascriptcore-tests:
2642
2643 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2644
2645         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2646         https://bugs.webkit.org/show_bug.cgi?id=137212
2647
2648         This moves TestNetscapePlugin to a new folder (lib/plugins).
2649         We should not use the same directory for TestNetscapePlugin and
2650         the other libraries, because we end up scanning all the .so in the
2651         lib dir for every test.
2652
2653         Reviewed by Carlos Garcia Campos.
2654
2655         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2656         * Scripts/webkitpy/port/efl.py:
2657         (EflPort.setup_environ_for_server): Update plugin path.
2658         * Scripts/webkitpy/port/gtk.py:
2659         (GtkPort.setup_environ_for_server): Update plugin path.
2660         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2661
2662 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2663
2664         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2665
2666         Rubber-stamped by Tim Horton.
2667
2668         * QueueStatusServer/app.yaml:
2669         * QueueStatusServer/handlers/statusbubble.py:
2670         (StatusBubble._build_bubble):
2671
2672 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2673
2674         Typo fix, suggested by Tim Horton.
2675
2676         * QueueStatusServer/handlers/statusbubble.py:
2677         (StatusBubble._build_message_for_provisional_failure):
2678
2679 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2680
2681         Improve Bugzilla status bubbles
2682         https://bugs.webkit.org/show_bug.cgi?id=137232
2683
2684         Reviewed by Ryosuke Niwa.
2685
2686         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2687
2688         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2689         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2690         that are stuck, as it was only confusing that they disappeared after 99.
2691
2692         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2693         by old bubbles. We need a lot more information to determine color, so the implementation
2694         can not be here.
2695
2696         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2697         always have a link for consistency. Added code to convert timestamps in tooltips
2698         to local time zone.
2699
2700 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2701
2702         Unreviewed, rolling out r174045.
2703         https://bugs.webkit.org/show_bug.cgi?id=137231
2704
2705         Introduced a crash during page loading tests on Mac (Requested
2706         by rniwa on #webkit).
2707
2708         Reverted changeset:
2709
2710         "Replace OSObjectPtr with RetainPtr/adoptOS"
2711         https://bugs.webkit.org/show_bug.cgi?id=137158
2712         http://trac.webkit.org/changeset/174045
2713
2714 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2715
2716         Add Jake as a contributor.
2717
2718         * Scripts/webkitpy/common/config/contributors.json:
2719
2720 2014-09-29  Roger Fong  <roger_fong@apple.com>
2721
2722         [Windows] Skip a javascriptcore test following r174036.
2723
2724         * Scripts/run-javascriptcore-tests:
2725
2726 2014-09-29  Roger Fong  <roger_fong@apple.com>
2727
2728         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2729
2730         * Scripts/webkitpy/port/win.py:
2731         (WinPort.default_child_processes):
2732         Reduce number of processes to 1 so we can get a good baseline for what failures
2733         we should be expecting to see from the Windows bots.
2734
2735 2014-09-29  Darin Adler  <darin@apple.com>
2736
2737         Tweak and tighten SVG font converter
2738         https://bugs.webkit.org/show_bug.cgi?id=136956
2739
2740         Reviewed by Myles Maxfield.
2741
2742         I was investigating behavior of String::toInt, String::toDouble, and
2743         String::toFloat for various failure cases, and decided to start some
2744         unit tests for those functions here.
2745
2746         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2747         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2748         StringToDouble testing.
2749
2750 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2751
2752         [GTK][CMake] TestWebCore target build sometimes fail
2753         https://bugs.webkit.org/show_bug.cgi?id=137207
2754
2755         Reviewed by Csaba Osztrogon.
2756
2757         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2758         headers are generated before the TestWebCore target is built.
2759
2760 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2761
2762         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2763         https://bugs.webkit.org/show_bug.cgi?id=137209
2764
2765         Reviewed by Philippe Normand.
2766
2767         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2768         from the WebCore test sources.
2769
2770 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2771
2772         Allow webkit-patch upload to respect the --directory argument with git checkouts
2773         https://bugs.webkit.org/show_bug.cgi?id=137166
2774
2775         Reviewed by Darin Adler.
2776
2777         We simply hadn't plumbed it through.
2778
2779         * Scripts/webkitpy/common/checkout/scm/detection.py:
2780         (SCMDetector.detect_scm_system):
2781         * Scripts/webkitpy/common/checkout/scm/git.py:
2782         (Git.__init__):
2783         (Git.changed_files):
2784
2785 2014-09-26  Sam Weinig  <sam@webkit.org>
2786
2787         Replace OSObjectPtr with RetainPtr/adoptOS
2788         https://bugs.webkit.org/show_bug.cgi?id=137158
2789
2790         Reviewed by Dan Bernstein.
2791
2792         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2793         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2794         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2795         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2796
2797 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2798
2799         Disable function.arguments
2800         https://bugs.webkit.org/show_bug.cgi?id=137167
2801
2802         Rubber stamped by Geoffrey Garen
2803         
2804         Enable the feature by default during tests.
2805
2806         * Scripts/run-jsc-stress-tests:
2807
2808 2014-09-26  Beth Dakin  <bdakin@apple.com>
2809
2810         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2811         https://bugs.webkit.org/show_bug.cgi?id=137089
2812
2813         Reviewed by Tim Horton.
2814
2815         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2816         tests run at 1x, but that code does not seem to execute at the right time for 
2817         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2818         tests and does not break the HiDPI tests either.
2819         * WebKitTestRunner/TestController.cpp:
2820         (WTR::TestController::createWebViewWithOptions):
2821
2822 2014-09-26  Roger Fong  <roger_fong@apple.com>
2823
2824         [Windows] Decrease default number of child processes used by Windows.
2825
2826         * Scripts/webkitpy/port/win.py:
2827         (WinPort.default_child_processes):
2828         Having too many seems to cause many tests to crash or timeout. 
2829         We may even need to make it have only 1 child process if we’re still seeing problems after this.
2830
2831 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2832
2833         Mac EWS bots do not keep logs as promised
2834         https://bugs.webkit.org/show_bug.cgi?id=137151
2835
2836         Reviewed by Ryosuke Niwa.
2837
2838         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
2839
2840 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2841
2842         Get rid of webkit-queues dashboard
2843         https://bugs.webkit.org/show_bug.cgi?id=137141
2844
2845         Reviewed by Ryosuke Niwa.
2846
2847         * QueueStatusServer/app.yaml: Updated version.
2848
2849         * QueueStatusServer/templates/dashboard.html: Removed.
2850         * QueueStatusServer/handlers/dashboard.py: Removed.
2851         * QueueStatusServer/main.py:
2852         Kill it!
2853
2854         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
2855         (.status-cell): Deleted.
2856         (.status-cell:hover): Deleted.
2857         (.status-cell.pass): Deleted.
2858         (.status-cell.fail): Deleted.
2859         (.status-cell.pending): Deleted.
2860         (.status-cell.error): Deleted.
2861         * QueueStatusServer/stylesheets/dashboard.css: Removed.
2862         * QueueStatusServer/templates/activebots.html:
2863         * QueueStatusServer/templates/patch.html:
2864         * QueueStatusServer/templates/queuestatus.html:
2865         * QueueStatusServer/templates/recentstatus.html:
2866         Renamed dashboard.css to common.css, and removed dashboard-only rules.
2867
2868 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2869
2870         Get rid of Retry status in webkit-queues
2871         https://bugs.webkit.org/show_bug.cgi?id=137135
2872
2873         Reviewed by Ryosuke Niwa.
2874
2875         * QueueStatusServer/config/messages.py: Removed Retry.
2876
2877         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
2878         no longer needs to check the latest status. It just always both unlocks the patch
2879         and removes it from WorkItems.
2880
2881         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
2882         I don't understand why we even needed to check for retries here, but now that there
2883         are no retries, that code can go to /dev/null.
2884
2885         * QueueStatusServer/loggers/recordpatchevent.py:
2886         (RecordPatchEvent.started):
2887         (RecordPatchEvent.retrying): Deleted.
2888         Fixed retry counting, it should work for all queues now.
2889
2890         * QueueStatusServer/model/queuestatus.py:
2891         (QueueStatus.is_retry_request): Deleted. These are no more.
2892
2893         * Scripts/webkitpy/common/net/statusserver_mock.py:
2894         (MockStatusServer.release_lock):
2895         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2896         Did whatever it took to keep passing the tests. The particular test doesn't seem
2897         quite right, but whatever.
2898
2899         * Scripts/webkitpy/tool/commands/queues.py:
2900         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
2901         and let others pick up. Also, added explicit returns for clarity.
2902         (AbstractPatchQueue._did_retry): Deleted.
2903
2904 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2905
2906         [EFL] Fix the gst-libav build on ARM Thumb2
2907         https://bugs.webkit.org/show_bug.cgi?id=137022
2908
2909         Reviewed by Zoltan Herczeg.
2910
2911         * efl/jhbuild.modules:
2912         * efl/patches/gst-libav.patch: Added.
2913
2914 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2915
2916         [EFL] Bump up dependencies not to conflict with the GTK port.
2917         https://bugs.webkit.org/show_bug.cgi?id=137143
2918
2919         Reviewed by Gyuyoung Kim.
2920
2921         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
2922         installing and removing different versions of libgnutls-dev, thus
2923         hindering the development for both ports on the same machine. GTK is
2924         using the newer version of the package, now bumping up EFL to use the 
2925         same.
2926
2927         * efl/install-dependencies:
2928
2929 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
2930
2931         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
2932         https://bugs.webkit.org/show_bug.cgi?id=136854
2933
2934         Reviewed by Gyuyoung Kim.
2935
2936         'Escape' key should exit fullscreen first and then should be used to stop page load.
2937
2938         * MiniBrowser/efl/main.c:
2939         (on_key_down):
2940
2941 2014-09-25  Dean Jackson  <dino@apple.com>
2942
2943         Add Said to the contributors list so his name completes in bugzilla.
2944
2945         * Scripts/webkitpy/common/config/contributors.json:
2946
2947 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
2948
2949         EWS only repeats its cycle every two hours
2950         https://bugs.webkit.org/show_bug.cgi?id=137129
2951
2952         Reviewed by Ryosuke Niwa.
2953
2954         * QueueStatusServer/app.yaml: Updated version.
2955
2956         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
2957
2958         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
2959         the patch from work items.
2960
2961         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
2962
2963         * QueueStatusServer/main.py: Added release-lock.
2964
2965         * QueueStatusServer/model/activeworkitems.py:
2966         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2967
2968         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2969         we don't want it to be immediately picked up again, it's better to give other patches
2970         a chance.
2971
2972         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2973         these interactive versions, but OK.
2974
2975         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2976         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2977         or svn is down).
2978
2979         * Scripts/webkitpy/tool/commands/queues.py:
2980         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2981         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2982         meaning that these handlers could never do the right thing. We'd either get a duplicate
2983         _did_fail, or try to unlock an already unlocked patch.
2984         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2985         making it eligible for retry immediately.
2986
2987         * Scripts/webkitpy/common/net/statusserver.py:
2988         (StatusServer._post_release_lock):
2989         (StatusServer.release_lock):
2990         Added a call to release-lock.
2991
2992 2014-09-25  Roger Fong  <roger_fong@apple.com>
2993
2994         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2995
2996         * Scripts/webkitpy/common/system/path.py:
2997         (_CygPath.convert):
2998
2999 2014-09-25  Roger Fong  <roger_fong@apple.com>
3000
3001         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
3002
3003         * Scripts/webkitpy/common/system/path.py:
3004         (_CygPath.convert):
3005
3006 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
3007
3008         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
3009         https://bugs.webkit.org/show_bug.cgi?id=136377
3010
3011         Reviewed by Philippe Normand.
3012
3013         * Scripts/webkitdirs.pm:
3014         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
3015
3016 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
3017
3018         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
3019         https://bugs.webkit.org/show_bug.cgi?id=137117
3020
3021         Tools/efl/install-dependencies relies on apt-get to install packages.
3022         Unfortunately, if a package does not exist (e.g., for a given
3023         architecture) then apt-get install is not able to ignore the missing
3024         package and install the rest but fails to run entirely (and there
3025         seems to be no intent to change this behaviour).
3026
3027         On ARM64, the luajit package is missing and currently it needs manual
3028         editing of install-dependencies to get the script install as much as it
3029         can.
3030
3031         This patch separates the installation of the universally available
3032         packages from those which might not be available for all architectures.
3033
3034         Reviewed by Gyuyoung Kim.
3035
3036         * efl/install-dependencies:
3037
3038 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
3039
3040         Remove WinCE port from trunk
3041         https://bugs.webkit.org/show_bug.cgi?id=136951
3042
3043         Reviewed by Alex Christensen.
3044
3045         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3046         (_should_file_trigger_build):
3047         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3048         (ShouldBuildTest):
3049         * CMakeLists.txt:
3050         * DumpRenderTree/win/DRTDataObject.cpp:
3051         (DRTDataObject::CopyMedium):
3052         * Scripts/build-webkit:
3053         * Scripts/webkit-build-directory:
3054         * Scripts/webkitdirs.pm:
3055         (argumentsForConfiguration):
3056         (builtDylibPathForName):
3057         (isAppleWinWebKit):
3058         (launcherPath):
3059         (launcherName):
3060         (shouldRemoveCMakeCache):
3061         (cmakeBasedPortArguments):
3062         (cmakeBasedPortName):
3063         (isCMakeBuild):
3064         (isWinCE): Deleted.
3065         (determineIsWinCE): Deleted.
3066         * Scripts/webkitperl/FeatureList.pm:
3067         * Scripts/webkitpy/port/port_testcase.py:
3068         (test_apache_config_file_name_for_platform):
3069         * TestWebKitAPI/config.h:
3070         * WinCELauncher/CMakeLists.txt: Removed.
3071         * WinCELauncher/main.cpp: Removed.
3072         * gtk/manifest.txt:
3073
3074 2014-09-23  David Farler  <dfarler@apple.com>
3075
3076         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
3077         https://bugs.webkit.org/show_bug.cgi?id=136895
3078
3079         Reviewed by David Kilzer.
3080
3081         Create Device, DeviceType, and Runtime data classes.
3082         Create Simulator class represent simctl output.
3083
3084         Wherever possible, use structured data classes anywhere a raw
3085         identifier or UDID string was used for a cleaner implementation
3086         and to encapsulate the inherent fragility of scraping simctl output.
3087
3088         Create a suitably named testing device if one doesn't exist.
3089
3090         Finally, accurately handle having multiple simulator runtimes (SDKs)
3091         installed in the active Xcode.app bundle.
3092
3093         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3094         (_set_up_derived_options):
3095         * Scripts/webkitpy/port/driver.py:
3096         (IOSSimulatorDriver.cmd_line):
3097         Construct DeviceType and Runtime objects from identifiers passed at the
3098         command line, still providing sensible defaults for 32- and 64-bit testing.
3099         * Scripts/webkitpy/port/ios.py:
3100         (IOSSimulatorPort.__init__):
3101         (IOSSimulatorPort.setup_test_run):
3102         (IOSSimulatorPort):
3103         (IOSSimulatorPort.testing_device):
3104         Cache the testing device once it is created or found.
3105         (IOSSimulatorPort.reset_preferences):
3106         Get the device path from the Device object instead of consructing it
3107         in the port class.
3108         (IOSSimulatorPort.simulator_udid): Deleted.
3109         Get the UDID from the testing_device :: Device object itself.
3110         * Scripts/webkitpy/xcode/simulator.py:
3111         Created Device, DeviceType, Runtime, and Simulator classes.
3112         (get_runtimes): Deleted.
3113         (get_devices): Deleted.
3114         (get_device_types): Deleted.
3115         (get_latest_runtime): Deleted.
3116
3117 2014-09-24  Roger Fong  <roger_fong@apple.com>
3118
3119         [Windows] Tentative fix for Windows test bots.
3120
3121         * Scripts/webkitpy/common/system/path.py:
3122         (_CygPath.convert):
3123
3124 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
3125
3126         Change more build.webkit.org links to https
3127         https://bugs.webkit.org/show_bug.cgi?id=137049
3128
3129         Reviewed by Csaba Osztrogonác.
3130
3131         Fix appspot, svn.webkit.org and Trac links.
3132
3133         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3134         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
3135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3137         (ViewController.prototype._domForBuildName):
3138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3140         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3142         (.):
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
3144         (EWS):
3145         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
3147         (TestHistory):
3148         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3149
3150 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
3151
3152         Update the list of u-szeged contributors.
3153
3154         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
3155
3156         * Scripts/webkitpy/common/config/contributors.json:
3157
3158 2014-09-23  Roger Fong  <roger_fong@apple.com>
3159
3160         [Windows] More debugging for the Windows bots.
3161
3162         * Scripts/webkitpy/common/system/path.py:
3163         (_CygPath):
3164
3165 2014-09-23  Roger Fong  <roger_fong@apple.com>
3166
3167         Unreviewed. Fix for r173899, those tabs should be spaces.
3168
3169         * Scripts/webkitpy/port/driver.py:
3170         (Driver._command_from_driver_input):
3171         (Driver): Deleted.
3172
3173 2014-09-23  Roger Fong  <roger_fong@apple.com>
3174
3175         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
3176
3177         * Scripts/webkitpy/port/driver.py:
3178         (Driver):
3179
3180 2014-09-23  Jer Noble  <jer.noble@apple.com>
3181
3182         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
3183         https://bugs.webkit.org/show_bug.cgi?id=137031
3184
3185         Reviewed by Joseph Pecoraro.
3186
3187         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
3188         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
3189         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
3190         ChangeLog locations before passing them to createCommitMessage().
3191
3192         * Scripts/commit-log-editor:
3193
3194 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3195
3196         W3C test importer should detect manual and reference tests according their filenames
3197         https://bugs.webkit.org/show_bug.cgi?id=133852
3198
3199         Reviewed by Bem Jones-Bey.
3200
3201         * Scripts/webkitpy/w3c/test_parser.py:
3202         (TestParser.analyze_test): Adding checks based on WPT filename rules.
3203         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
3204         (TestParser):
3205         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
3206         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
3207         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3208         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
3209
3210 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
3211
3212         Unreviewed, add Rebecca Hauck as a contributor.
3213
3214         * Scripts/webkitpy/common/config/contributors.json:
3215
3216 2014-09-23  David Kilzer  <ddkilzer@apple.com>
3217
3218         Switch build.webkit.org URLs to https
3219
3220         Reviewed by Lucas Forschler and Alexey Proskuryakov.
3221
3222         * TestResultServer/app.yaml: Update version to this commit
3223         revision.
3224
3225         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3227         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
3229         (WebKitBuildbot):
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3233         (.):
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3235         (WebKitBuildbot):
3236         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3237         * Scripts/webkitpy/common/config/urls.py:
3238         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3239         (test_builder_with_name):
3240         * Scripts/webkitpy/tool/commands/queries.py:
3241         (TreeStatus):
3242         * TestResultServer/generate_builders_json.py:
3243         (main):
3244         * TestResultServer/generate_builders_json_unittest.py:
3245         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3246         (GenerateBuildersJsonTest):
3247         (GenerateBuildersJsonTest.test_generate_json_data):
3248         * TestResultServer/static-dashboards/builders.jsonp:
3249         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3250         (loadExpectationsLayoutTests):
3251         * TestResultServer/static-dashboards/timeline_explorer.js:
3252
3253 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3254
3255         W3C test importer should copy .htaccess files
3256         https://bugs.webkit.org/show_bug.cgi?id=136850
3257
3258         Reviewed by Bem Jones-Bey.
3259
3260         * Scripts/webkitpy/w3c/test_importer.py:
3261         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
3262         (TestImporter):
3263         (TestImporter.find_importable_tests): Making use of new helper function.
3264
3265 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
3266
3267         Trying to revive bot watcher's dashboard after HSTS.
3268
3269         Unreviewed.
3270
3271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3272         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
3273
3274 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3275
3276         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
3277         https://bugs.webkit.org/show_bug.cgi?id=137026
3278
3279         Reviewed by Csaba Osztrogonác.
3280
3281         * BuildSlaveSupport/wait-for-SVN-server.py:
3282         (getLatestSVNRevision):
3283         (waitForSVNRevision):
3284
3285 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3286
3287         Remove unlinkZeroFiles from build-webkit
3288         https://bugs.webkit.org/show_bug.cgi?id=137018
3289
3290         Reviewed by Csaba Osztrogonác.
3291
3292         * Scripts/build-webkit:
3293         (unlinkZeroFiles): Deleted.
3294
3295 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
3296
3297         [GTK] Minibrowser : Add keyboard support for stop page load
3298         https://bugs.webkit.org/show_bug.cgi?id=136857
3299
3300         Reviewed by Philippe Normand.
3301
3302         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
3303
3304         * MiniBrowser/gtk/BrowserWindow.c:
3305         (stopPageLoad): Callback to stop page load.
3306         (browser_window_init):
3307
3308 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
3309
3310         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
3311         https://bugs.webkit.org/show_bug.cgi?id=136813
3312
3313         Reviewed by Gyuyoung Kim.
3314
3315         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
3316
3317         * MiniBrowser/efl/main.c:
3318         (on_key_down):
3319
3320 2014-09-22  Daniel Bates  <dabates@apple.com>
3321
3322         [Cocoa] Add UI delegate callback when window.close() is called
3323         https://bugs.webkit.org/show_bug.cgi?id=137008
3324         <rdar://problem/17801001>
3325
3326         Reviewed by Anders Carlsson.
3327
3328         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
3329         for window opened via JavaScript (i.e. window.open()).
3330
3331         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3332         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
3333         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
3334
3335 2014-09-22  Youenn Fablet  <youennf@gmail.com>
3336
3337         W3C importer should import html files within resources folders
3338         https://bugs.webkit.org/show_bug.cgi?id=127548
3339
3340         Reviewed by Ryosuke Niwa.
3341         
3342         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
3343
3344         * Scripts/webkitpy/w3c/test_importer.py:
3345         (TestImporter.find_importable_tests):
3346
3347 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
3350         https://bugs.webkit.org/show_bug.cgi?id=136998
3351
3352         Reviewed by Philippe Normand.
3353
3354         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3355         (testWebViewCanShowMIMEType): Remove the check of PDF as
3356         unsupported MIME type.
3357
3358 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3359
3360         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
3361
3362         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
3363         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
3364
3365         * Scripts/webkitpy/common/config/watchlist: Use
3366         Source/WebCore/platform/gtk/po/ as directory to watch for
3367         WebKitGTKTranslations rule and add berto and myself to the list of
3368         watchers.
3369
3370 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
3371
3372         Fix syntaxError in watchlist since r173594
3373         https://bugs.webkit.org/show_bug.cgi?id=136996
3374
3375         Reviewed by Philippe Normand.
3376
3377         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
3378
3379 2014-09-20  Sam Weinig  <sam@webkit.org>
3380
3381         Make possible HashSet<std::unique_ptr<>>
3382         https://bugs.webkit.org/show_bug.cgi?id=136166
3383
3384         Reviewed by Darin Adler.
3385
3386         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
3387         * TestWebKitAPI/Counters.cpp: Added.
3388         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
3389         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
3390         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
3391         translation unit.
3392     
3393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3394         Add new files.
3395
3396         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3397         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
3398
3399         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3400         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
3401
3402 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3403
3404         run-webkit-tests should count tests submitted as absolute paths once
3405         https://bugs.webkit.org/show_bug.cgi?id=136848
3406
3407         Reviewed by Darin Adler.
3408
3409         * Scripts/webkitpy/port/base.py:
3410         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
3411
3412 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3413
3414         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
3415         https://bugs.webkit.org/show_bug.cgi?id=136974
3416
3417         Reviewed by Chris Fleizach.
3418
3419         * DumpRenderTree/AccessibilityUIElement.cpp:
3420         (selectTextWithCriteriaCallback):
3421         Be sure to release the string if it was allocated.
3422
3423 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
3424
3425         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
3426         https://bugs.webkit.org/show_bug.cgi?id=136966
3427
3428         Reviewed by Daniel Bates.
3429
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3431         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
3432
3433 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3434
3435         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
3436         https://bugs.webkit.org/show_bug.cgi?id=136917
3437
3438         Reviewed by Darin Adler.
3439
3440         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
3441
3442         * TestWebKitAPI/PlatformEfl.cmake:
3443         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
3444         (TestWebKitAPI::didFinishLoadForFrame):
3445         (TestWebKitAPI::TEST):
3446         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
3447
3448 2014-09-19  Daniel Bates  <dabates@apple.com>
3449
3450         Always assume internal SDK when building configuration Production
3451         https://bugs.webkit.org/show_bug.cgi?id=136925
3452         <rdar://problem/18362399>
3453
3454         Reviewed by Dan Bernstein.
3455
3456         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3457         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3458         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3459         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3460
3461 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3462
3463         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
3464         https://bugs.webkit.org/show_bug.cgi?id=136847
3465
3466         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
3467
3468         Reviewed by Alexey Proskuryakov.
3469
3470         * WebKitTestRunner/TestController.cpp:
3471         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
3472
3473 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3474
3475         [GTK] Missing inspector files in the tarball
3476         https://bugs.webkit.org/show_bug.cgi?id=136952
3477
3478         Reviewed by Gustavo Noronha Silva.
3479
3480         * gtk/manifest.txt: Add
3481         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
3482         to the tarball.
3483
3484 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3485
3486         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
3487         https://bugs.webkit.org/show_bug.cgi?id=136632
3488
3489         Reviewed by Gustavo Noronha Silva.
3490
3491         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
3492         the gtk icons.
3493         * gtk/manifest.txt: Only include the free icons in the tarball.
3494
3495 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3496
3497         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
3498         https://bugs.webkit.org/show_bug.cgi?id=136943
3499
3500         Reviewed by Philippe Normand.
3501
3502         Update the script to receive the list of files from the command
3503         line instead of scanning the given directories.
3504
3505         * gtk/generate-inspector-gresource-manifest.py:
3506         (get_filenames): Convert filenames to use relative paths.
3507         (find_all_files_in_directory): Deleted.
3508         (find_all_files_in_directory.select_file): Deleted.
3509
3510 2014-09-18  Tanay C  <tanay.c@samsung.com>
3511
3512         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
3513         https://bugs.webkit.org/show_bug.cgi?id=136739
3514
3515         Reviewed by Gyuyoung Kim.
3516
3517         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
3518         (on_mouse_wheel): Modified.
3519
3520 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3521
3522         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
3523         https://bugs.webkit.org/show_bug.cgi?id=136923
3524
3525         Reviewed by Gustavo Noronha Silva.
3526
3527         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3528         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
3529         the source.
3530
3531 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
3532
3533         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
3534         https://bugs.webkit.org/show_bug.cgi?id=136856
3535
3536         Reviewed by Darin Adler.
3537
3538         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3539         (RunLLINTCLoopTests.countFailures):
3540         (Run32bitJSCTests.countFailures):
3541         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3542         (RunLLINTCLoopTestsTest.test_failures):
3543         (RunLLINTCLoopTestsTest.test_failure):
3544         (RunLLINTCLoopTestsTest.test_no_failure):
3545         (Run32bitJSCTestsTest.test_failures):
3546         (Run32bitJSCTestsTest.test_failure):
3547         (Run32bitJSCTestsTest.test_no_failure):
3548
3549 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
3550
3551         GMainLoopSource is exposed to race conditions
3552         https://bugs.webkit.org/show_bug.cgi?id=135800
3553
3554         Reviewed by Carlos Garcia Campos.
3555
3556         Add unit tests for GMainLoopSource.
3557
3558         The tests check correct behavior of GMainLoopSource in various conditions --
3559         from the most simple rescheduling to rescheduling during dispatch, cancelling
3560         or destroying the GMainLoopSource during dispatch, proper destroy callback
3561         dispatching etc.
3562
3563         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
3564         State of the GMainLoopSource object (either ready, sheduled or active) is
3565         thoroughly tested throughout the lifetime of that object.
3566
3567         Still missing are tests for socket callbacks, which are a bit trickier because
3568         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
3569         are also not tested thoroughly, simply because it is at the moment impossible
3570         to test that the objects are actually destroyed when the corresponding source
3571         is finally deleted.
3572
3573         * TestWebKitAPI/PlatformGTK.cmake:
3574         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3575         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3576         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3577         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3578         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3579         (TestWebKitAPI::GMainLoopSourceTest::finish):
3580         (TestWebKitAPI::GMainLoopSourceTest::source):
3581         (TestWebKitAPI::TEST):
3582
3583 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
3584
3585         Unreviewed, Update my email in contributors.json
3586
3587         * Scripts/webkitpy/common/config/contributors.json:
3588
3589 2014-09-17  Daniel Bates  <dabates@apple.com>
3590
3591         Unreviewed, rolling out r173695.
3592
3593         Broke building third-party Legacy WebKit apps; will
3594         investigate offline
3595
3596         Reverted changeset:
3597
3598         "[iOS] Make WebCore build with public iOS SDK"
3599         https://bugs.webkit.org/show_bug.cgi?id=136487
3600         http://trac.webkit.org/changeset/173695
3601
3602 2014-09-17  Daniel Bates  <dabates@apple.com>
3603
3604         [iOS] Make WebCore build with public iOS SDK
3605         https://bugs.webkit.org/show_bug.cgi?id=136487
3606
3607         Reviewed by David Kilzer.
3608
3609         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
3610
3611         * DumpRenderTree/mac/CheckedMalloc.cpp:
3612
3613 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3614
3615         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
3616         https://bugs.webkit.org/show_bug.cgi?id=136889
3617
3618         Reviewed by Gustavo Noronha Silva.
3619
3620         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3621         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
3622         event was added to the events vector.
3623         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3624         (loadFailedCallback): Do not assume the web view URI is the
3625         failing URI when the load fails before the committed state.
3626         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
3627         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
3628         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
3629         (LoadTrackingTest::loadFailedWithTLSErrors): Add
3630         LoadFailedWithTLSErrors event to the events vector.
3631         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3632
3633 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
3634
3635         [EFL][GTK] Remove WebKit1 related codes
3636         https://bugs.webkit.org/show_bug.cgi?id=136853
3637
3638         Reviewed by Csaba Osztrogonác.
3639
3640         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3641         from scripts.
3642
3643         * BuildSlaveSupport/build.webkit.org-config/config.json:
3644         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3645         (Compile32bitJSC):
3646         (BuildAndTestWebKit2Factory):
3647         (CompileWebKit1Only): Deleted.
3648         (CompileWebKit2Only): Deleted.
3649         (BuildAndTestWebKit1OnlyFactory): Deleted.
3650         (BuildAndTestWebKit2OnlyFactory): Deleted.
3651         * Scripts/build-webkit:
3652         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3653         * Scripts/webkitpy/common/config/ports.py:
3654         (GtkWK2Port.build_webkit_command):
3655         (EflWK2Port.build_webkit_command):
3656         * Scripts/webkitpy/common/config/ports_unittest.py:
3657         (DeprecatedPortTest.test_gtk_wk2_port):
3658         * Scripts/webkitpy/port/efl.py:
3659         (EflPort.build_webkit_command):
3660         * Scripts/webkitpy/port/gtk.py:
3661         (GtkPort._built_libraries_path):
3662         (GtkPort._search_paths):
3663         (GtkPort.test_expectations_file_position):
3664         (GtkPort.build_webkit_command):
3665         (GtkPort.run_webkit_tests_command):
3666         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3667
3668 2014-09-16  Daniel Bates  <dabates@apple.com>
3669
3670         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3671         https://bugs.webkit.org/show_bug.cgi?id=136862
3672
3673         Reviewed by David Kilzer.
3674
3675         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3676         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3677         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3678         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3679
3680 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3681
3682         Mac queue slaves should reboot every so often
3683         https://bugs.webkit.org/show_bug.cgi?id=136791
3684
3685         Reviewed by Alexey Proskuryakov.
3686
3687         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3688
3689         * EWSTools/start-queue-mac.sh:
3690
3691 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3692
3693         Unreviewed gardening, skip one more tests on Windows.
3694
3695         * Scripts/run-javascriptcore-tests:
3696
3697 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3698
3699         JSC test gardening
3700         https://bugs.webkit.org/show_bug.cgi?id=136823
3701
3702         Reviewed by Geoffrey Garen.
3703
3704         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3705
3706 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3707
3708         Remove shouldAbortEarly cruft from master.cfg
3709         https://bugs.webkit.org/show_bug.cgi?id=136779
3710
3711         Reviewed by Csaba Osztrogonác.
3712
3713         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3714         (ConfigureBuild.start):
3715         (RunWebKitTests.start):
3716         (RunWebKit2Tests.start): Deleted.
3717
3718 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3719
3720         Remove ORWT related crufts from webkitdirs.pm
3721         https://bugs.webkit.org/show_bug.cgi?id=136821
3722
3723         Reviewed by Alexey Proskuryakov.
3724
3725         * Scripts/webkitdirs.pm:
3726         (isPerianInstalled): Deleted.
3727         (determineIPhoneSimulatorVersion): Deleted.
3728         (iPhoneSimulatorVersion): Deleted.
3729         (isSnowLeopard): Deleted.
3730         (isLion): Deleted.
3731         (quitIOSSimulator): Deleted.
3732
3733 2014-09-15  Roger Fong  <roger_fong@apple.com>
3734
3735         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3736         https://bugs.webkit.org/show_bug.cgi?id=25160
3737
3738         * Scripts/run-javascriptcore-tests:
3739
3740 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3741
3742         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3743         
3744         Rubber stamped by Matt Hanson.
3745         
3746         * BuildSlaveSupport/build.webkit.org-config/config.json:
3747
3748 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3749
3750         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3751         https://bugs.webkit.org/show_bug.cgi?id=136822
3752
3753         Reviewed by Gyuyoung Kim.
3754
3755         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3756         initialized as we already does it in PlatformWebView::PlatformWebView
3757         calling ewk_init(). The reason for that was to ensure testing for example,
3758         WTF where creating the view is not mandatory.
3759
3760         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3761         in order to properly initalize and release EWebKit.
3762
3763         * TestWebKitAPI/PlatformEfl.cmake:
3764         * TestWebKitAPI/efl/PlatformWebView.cpp:
3765         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3766         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3767         * TestWebKitAPI/efl/main.cpp:
3768         (main):
3769
3770 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3771
3772         [WinCairo] Make it easier to enable/disable GStreamer.
3773         https://bugs.webkit.org/show_bug.cgi?id=135766
3774
3775         Reviewed by Brent Fulgham.
3776
3777         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3778
3779         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3780
3781 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3782
3783         Web Inspector: remind about rebaselining generator test results
3784         https://bugs.webkit.org/show_bug.cgi?id=136759
3785
3786         Reviewed by Joseph Pecoraro.
3787
3788         For now, we can implement this as a watchlist message. Add watchlist
3789         groups and messages for the inspector and web replay generators.
3790
3791         * Scripts/webkitpy/common/config/watchlist:
3792
3793 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3794
3795         build.webkit.org/dashboard: Overlapping text when status is long
3796         https://bugs.webkit.org/show_bug.cgi?id=136794
3797
3798         Reviewed by Timothy Hatcher.
3799
3800         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3801         (.status-line): Replaces height with min-height.
3802
3803 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3804
3805         Make Brian Burg a WebKit reviewer.
3806
3807         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3808
3809 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3810
3811         Multiple EWS or commit bots can pick up processing of the same patch
3812         https://bugs.webkit.org/show_bug.cgi?id=136793
3813
3814         Reviewed by Ryosuke Niwa.
3815
3816         Change timeout from one hour to two hours. This will let bots finish, and in the
3817         unlikely event of a bot being frozen, will only delay patch processing restart by
3818         one hour.
3819
3820         * QueueStatusServer/app.yaml:
3821         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3822
3823 2014-09-11  Andy Estes  <aestes@apple.com>
3824
3825         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
3826         https://bugs.webkit.org/show_bug.cgi?id=136768
3827
3828         Reviewed by Tim Horton.
3829
3830         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3831         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
3832         (TestWebKitAPI::TEST):
3833
3834 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3835
3836         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
3837         https://bugs.webkit.org/show_bug.cgi?id=136669
3838
3839         Reviewed by Antti Koivisto.
3840
3841         * Scripts/run-gtk-tests:
3842         (TestRunner): Unskip SSL test.
3843
3844 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
3845
3846         Strip extraneous AVFoundation and CoreMedia logging
3847         https://bugs.webkit.org/show_bug.cgi?id=136747
3848
3849         Reviewed by Jer Noble.
3850
3851         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3852         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
3853
3854         * Scripts/webkitpy/port/base.py:
3855         (Port.stderr_patterns_to_strip): Base class, empty list
3856
3857         * Scripts/webkitpy/port/driver.py:
3858         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
3859
3860         * Scripts/webkitpy/port/ios.py:
3861         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
3862
3863         * Scripts/webkitpy/port/mac.py:
3864         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
3865
3866
3867 2014-09-11  Michael Saboff  <msaboff@apple.com>
3868
3869         lldb_webkit.py:btjs doesn't work with release builds
3870         https://bugs.webkit.org/show_bug.cgi?id=136760
3871
3872         Reviewed by Jer Noble.
3873
3874         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
3875         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
3876         we can't get a valid result from trying either call.  In that case, we fallback to
3877         just showing the PC.  Also added check for both entry points.  If neither is found,
3878         we issue a warning and output the stack trace without JavaScript annotations.
3879
3880         * lldb/lldb_webkit.py:
3881         (btjs):
3882
3883 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
3884
3885         webkitpy test failures from import-w3c-tests
3886         https://bugs.webkit.org/show_bug.cgi?id=136752
3887
3888         Reviewed by Bem Jones-Bey.
3889
3890         This patch fixes a bug in import-w3c-tests where we were appending
3891         the wrong set of files to the copy_list. This also updates the tests
3892         to clear the failures introduced in the patch for bug 135929.
3893
3894         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3895         (W3CTestConverterTest.test_read_prefixed_property_list):
3896         * Scripts/webkitpy/w3c/test_parser.py:
3897         (TestParser.analyze_test):
3898         (TestParser.support_files):
3899         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3900
3901 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
3902
3903         Blink merge: Speculative fix for windows run-webkit-tests hangs
3904         https://bugs.webkit.org/show_bug.cgi?id=136727
3905
3906         Reviewed by Csaba Osztrogonác.
3907
3908         Merged from Blink (patch by Dirk Pranke):
3909         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
3910
3911         * Scripts/webkitpy/common/system/executive.py:
3912         (Executive.kill_process):
3913
3914 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3915
3916         Added myself as a committer.
3917
3918         Unreviewed.
3919
3920         * Scripts/webkitpy/common/config/contributors.json:
3921
3922 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
3923
3924         [JavaScriptCore] Fix FTL on platform EFL.
3925         https://bugs.webkit.org/show_bug.cgi?id=133571
3926
3927         Reviewed by Filip Pizlo.
3928
3929         * efl/install-dependencies: Revert r169181.
3930         * efl/jhbuild.modules: Clone and build a custom branch.
3931         This branch contains some fix for FTL of platform EFL.
3932         The branch is a fork of llvm r206311.
3933
3934 2014-09-10  Tanay C  <tanay.c@samsung.com>
3935
3936         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
3937         https://bugs.webkit.org/show_bug.cgi?id=136698
3938
3939         Reviewed by Gyuyoung Kim.
3940
3941         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
3942         (on_mouse_wheel): Added.
3943         (window_free):
3944         (window_create):
3945
3946 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
3947
3948         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
3949         https://bugs.webkit.org/show_bug.cgi?id=136284
3950
3951         Reviewed by Gyuyoung Kim.
3952
3953         * MiniBrowser/efl/main.c:
3954         (window_create):
3955
3956 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
3957
3958         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
3959         https://bugs.webkit.org/show_bug.cgi?id=135929
3960
3961         Reviewed by Bem Jones-Bey.
3962
3963         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
3964         were made when this script was originally written with respect to relative paths
3965         in ref files. This patch updates import-w3c-tests to update paths in ref files if
3966         they move relative to the test file.
3967
3968
3969         * Scripts/webkitpy/w3c/test_converter.py:
3970         (convert_for_webkit):
3971         (_W3CTestConverter.__init__):
3972         (_W3CTestConverter.convert_reference_relpaths):
3973         (_W3CTestConverter.convert_style_data):
3974         (_W3CTestConverter.convert_attributes_if_needed):
3975         * Scripts/webkitpy/w3c/test_importer.py:
3976         (TestImporter.find_importable_tests):
3977         (TestImporter.import_tests):
3978         * Scripts/webkitpy/w3c/test_parser.py:
3979         (TestParser.load_file):
3980         (TestParser.analyze_test):
3981         (TestParser.support_files):
3982
3983 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3984
3985         [GTK] allow overwriting destination of download
3986         https://bugs.webkit.org/show_bug.cgi?id=136372
3987
3988         Reviewed by Carlos Garcia Campos.
3989
3990         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3991         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
3992         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
3993         (createFileAtDestination): Added
3994         (testDownloadOverwriteDestinationAllowed): Added
3995         (testDownloadOverwriteDestinationDisallowed): Added
3996         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
3997         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
3998         (beforeAll): New tests
3999
4000 2014-08-05  David Farler  <dfarler@apple.com>
4001
4002         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
4003         https://bugs.webkit.org/show_bug.cgi?id=135551
4004
4005         Reviewed by Daniel Bates.
4006
4007         Prevent printing invalid Unicode strings going to stderr.
4008         Also, make filesystem.py more tolerant about receiving
4009         Unicode (encoded as UTF-8) when writing to files, in the
4010         rare case that an NSError description will make it to
4011         stderr, such as -[LTRelayController createUniqueApp].
4012
4013         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
4014         (-[LTRelayController launchSimulator]): Removed.
4015         (-[LTRelayController createUniqueApp]):
4016         Don't explicitly try to uninstall the app. It is automatically handled
4017         when installing an app with the same bundle identifier.
4018         (-[LTRelayController start]):
4019         (-[LTRelayController bootDevice]): Removed.
4020         The device already boots as a part of starting the simulator. Attempting
4021         to boot a second time may cause spurious stderr output.
4022         * Scripts/webkitpy/port/driver.py:
4023         (IOSSimulatorDriver._setup_environ_for_driver):
4024         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
4025         Open the iOS Simulator once instead of the LayoutTestRelay trying
4026         to do it.
4027         * Scripts/webkitpy/port/ios.py:
4028         (IOSSimulatorPort._get_crash_log):
4029         Make sure stderr is at least an empty string.
4030         (IOSSimulatorPort):
4031         (IOSSimulatorPort.developer_dir):
4032         New property for setting up DEVELOPER_DIR in the driver environment.
4033
4034 2014-09-09  Dan Bernstein  <mitz@apple.com>
4035
4036         Clean up the MiniBrowser Xcode project
4037         https://bugs.webkit.org/show_bug.cgi?id=136684
4038
4039         Reviewed by Tim Horton.
4040
4041         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
4042         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
4043         WebKit2.framework. Upgraded project file version.
4044
4045 2014-09-09  Daniel Bates  <dbates@webkit.org>
4046
4047         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
4048         https://bugs.webkit.org/show_bug.cgi?id=136379
4049
4050         Reviewed by David Kilzer.
4051
4052         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
4053         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
4054         and sets a property on F (say, the executable bit).
4055
4056         * Scripts/svn-apply:
4057         (patch): Only add file if the diff has text chunks.
4058         * Scripts/svn-unapply:
4059         (patch): Only delete added file if the diff has text chunks.
4060
4061 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4062
4063         [GTK] Unreviewed GTK gardening.
4064
4065         * Scripts/run-gtk-tests:
4066         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
4067
4068 2014-09-09  Christophe Dumez  <cdumez@apple.com>
4069
4070         Update my email in contributors.json
4071         https://bugs.webkit.org/show_bug.cgi?id=136671
4072
4073         Reviewed by Andreas Kling.
4074
4075         * Scripts/webkitpy/common/config/contributors.json:
4076
4077 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4078
4079         [EFL] Enable fixed layout by default
4080         https://bugs.webkit.org/show_bug.cgi?id=136607
4081
4082         Reviewed by Csaba Osztrogonác.
4083
4084         Fixed layout is being used by Tizen platform by default. However, the feature
4085         has still many defects now. So, we need to enable it by default, then should fix
4086         those bugs. 
4087
4088         * MiniBrowser/efl/main.c:
4089
4090 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4091
4092         Remove FILTERS flag
4093         https://bugs.webkit.org/show_bug.cgi?id=136571
4094
4095         Reviewed by Darin Adler.
4096
4097         * Scripts/webkitperl/FeatureList.pm:
4098
4099 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
4100
4101         Dashboard metrics should ignore commits that didn't trigger builds
4102         https://bugs.webkit.org/show_bug.cgi?id=136618
4103
4104         Reviewed by Darin Adler.
4105
4106         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
4107         other platforms etc. It does not make sense to count wait time for these, as it
4108         can be arbitrarily long.
4109
4110         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
4111
4112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4113         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
4114
4115         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
4116         We used to walk the timeline to see which revisions are fully tested, but that's not
4117         correct. A revision that's only tested by a subset of queues finishes independently
4118         of another that's tested by another subset. Now, we just search for the answer for
4119         each revision individually.
4120
4121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
4122         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
4123         the analyzer now reports. Removed best time, which is more confusing than meaningful.
4124
4125 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
4126
4127         Remove EWebLauncher from webkitdirs.pm
4128         https://bugs.webkit.org/show_bug.cgi?id=136622
4129
4130         Reviewed by Gyuyoung Kim.
4131
4132         * Scripts/webkitdirs.pm:
4133         (launcherName):
4134
4135 2014-09-06  Sam Weinig  <sam@webkit.org>
4136
4137         XPCPtr should be converted into an all purpose smart pointer for os_objects
4138         https://bugs.webkit.org/show_bug.cgi?id=136602
4139
4140         Reviewed by Darin Adler.
4141
4142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4143         * TestWebKitAPI/Tests/WTF/darwin: Added.
4144         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
4145         Add basic unit tests for OSObjectPtr.
4146
4147 2014-09-06  Saam Barati  <saambarati1@gmail.com>
4148
4149         Unreviewed. Add myself as a committer.
4150
4151         * Scripts/webkitpy/common/config/contributors.json:
4152
4153 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
4154
4155         Unreviewed, EFL build fix when SHARED_CORE is on.
4156
4157         * TestWebKitAPI/PlatformEfl.cmake:
4158
4159 2014-09-05  Lucas Forschler  <lforschler@apple.com>
4160
4161         <https://webkit.org/b/136586> Add bots to Apple build/test queues
4162         
4163         Reviewed by Daniel Bates.
4164
4165         * BuildSlaveSupport/build.webkit.org-config/config.json:
4166
4167 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
4168
4169         Buildbot metrics page gives wrong results after a new bot gets added
4170         https://bugs.webkit.org/show_bug.cgi?id=136516
4171
4172         Reviewed by Tim Horton.
4173
4174         Part 2: Fix elapsed times.
4175
4176         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
4177         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
4178         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
4179
4180 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4181
4182         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
4183         https://bugs.webkit.org/show_bug.cgi?id=136562
4184
4185         Reviewed by Martin Robinson.
4186
4187         * Scripts/run-gtk-tests:
4188         (TestRunner): Remove failure expectations for tests that now pass.
4189
4190 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
4191
4192         Dashboard metrics page wastes a lot of time sorting iterations
4193         https://bugs.webkit.org/show_bug.cgi?id=136559
4194
4195         Reviewed by Tim Horton.
4196
4197         Also fixes comments here and there, and adds a missing "var".
4198
4199         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4200         (BuildbotIteration.prototype._parseData):
4201         (BuildbotIteration.prototype._updateWithData):
4202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4203         (BuildbotQueue.prototype.loadAll):
4204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
4205         (Analyzer.prototype._countTimes):
4206
4207 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4208
4209         [GTK] Unreviewed GTK gardening.
4210
4211         * Scripts/run-gtk-tests:
4212         (TestRunner): Skip tests failing since r173272.
4213
4214 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
4215
4216         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
4217         https://bugs.webkit.org/show_bug.cgi?id=136561
4218
4219         Reviewed by Tim Horton.
4220         
4221         Log for calloc() and CGBitmapContextCreate() failures.
4222
4223         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4224         (createBitmapContext):
4225         (createBitmapContextFromWebView):
4226
4227 2014-09-04  Andy Estes  <aestes@apple.com>
4228
4229         Fix the Mac Production build after r173283.
4230
4231         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
4232
4233 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
4234
4235         [Win] webkitpy test suite frequently fails to complete
4236         https://bugs.webkit.org/show_bug.cgi?id=136546
4237
4238         Reviewed by Daniel Bates.
4239
4240         Properly convert the ASCII crash log produced by ntsd into
4241         a unicode string as early as possible so that we handle it
4242         properly when generating our logs and other test support output.
4243
4244         We were mixing ASCII/unicode strings under Windows, which was
4245         causing test system failures when we processed some crash logs.
4246
4247         Also do a better job of handling garbage pid entries in the
4248         Cygwin lock files.
4249
4250         * Scripts/webkitpy/common/system/crashlogs.py:
4251         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
4252         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
4253         handle the strings as unicode from that point on.
4254         * Scripts/webkitpy/port/http_lock.py:
4255         (HttpLock._current_lock_pid): Add logging and handle case of
4256         the current_pid failing to cleanly convert to 'int'.
4257         * Scripts/webkitpy/port/win.py:
4258         (WinPort): Add 64-bit architecture as a known target for the
4259         Windows build.
4260
4261 2014-09-04  Andy Estes  <aestes@apple.com>
4262
4263         Address additional review feedback after landing r173283.
4264
4265         Reviewed by Daniel Bates.
4266
4267         * DumpRenderTree/config.h: Removed redundant includes.
4268         * TestWebKitAPI/config.h: Ditto.
4269         * WebKitTestRunner/config.h: Ditto.
4270
4271 2014-09-03  Andy Estes  <aestes@apple.com>
4272
4273         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
4274         https://bugs.webkit.org/show_bug.cgi?id=136521
4275
4276         Reviewed by Anders Carlsson.
4277
4278         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
4279         * TestWebKitAPI/config.h: Ditto.
4280         * WebKitTestRunner/config.h: Ditto.
4281
4282 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
4283
4284         REGRESSION: Dashboard metrics page aggregation counts performance bots
4285         https://bugs.webkit.org/show_bug.cgi?id=136539
4286
4287         Reviewed by Tim Horton.
4288
4289         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
4290
4291 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
4292
4293         [Win] Perl test fix.
4294
4295         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
4296         VersionStamp.exe tool, not just the driver script.
4297
4298 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>