077e7745e1e45ef98310ffce4d4136c938714678
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-29  Hayato Ito  <hayato@chromium.org>
2
3         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
4         https://bugs.webkit.org/show_bug.cgi?id=73381
5
6         Reviewed by Ryosuke Niwa.
7
8         This is a quick fix for the breakage of tests on non-chromium port.
9         We should implement diff_image later on non-chromium ports.
10
11         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
12         (write_test_result):
13
14 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
15
16         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
17         https://bugs.webkit.org/show_bug.cgi?id=72489
18
19         Reviewed by Eric Seidel.
20
21         Before the this fix always added "qt" option for the option list
22         * Scripts/run-webkit-tests:
23         * Scripts/webkitpy/layout_tests/port/qt.py:
24
25 2011-11-29  David Levin  <levin@chromium.org>
26
27         Add a way to revert a variable to its previous value after leaving a scope.
28         https://bugs.webkit.org/show_bug.cgi?id=73371
29
30         Reviewed by Adam Barth.
31
32         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
33         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
34         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
35         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
36         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
37         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
38
39 2011-11-28  Kentaro Hara  <haraken@chromium.org>
40
41         Implement [Supplemental] IDL and support it in run-bindings-tests
42         https://bugs.webkit.org/show_bug.cgi?id=73162
43
44         Reviewed by Adam Barth.
45
46         run-bindings-tests supports the [Supplemental] IDL in the following way.
47             (1) It creates a file |x| listing all IDL files.
48             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
49             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
50                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
51                 including all attributes in IDL files that are supplementing the IDL file |z|.
52
53         * Scripts/run-bindings-tests:
54         (generate_from_idl):
55         (generate_supplemental_dependency):
56         (detect_changes):
57         (run_tests):
58         (main):
59
60 2011-11-18  Nat Duca  <nduca@chromium.org>
61
62         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
63         https://bugs.webkit.org/show_bug.cgi?id=70838
64
65         Reviewed by James Robinson.
66
67         * DumpRenderTree/chromium/TestShell.cpp:
68         (TestShell::resetWebSettings):
69         * DumpRenderTree/chromium/TestShell.h:
70         (TestShell::threadedCompositingEnabled):
71         * DumpRenderTree/chromium/WebPreferences.cpp:
72         (WebPreferences::reset):
73         (WebPreferences::applyTo):
74         * DumpRenderTree/chromium/WebPreferences.h:
75         * DumpRenderTree/chromium/WebViewHost.cpp:
76         (WebViewHost::WebViewHost):
77         (WebViewHost::~WebViewHost):
78
79 2011-11-29  Ojan Vafai  <ojan@chromium.org>
80
81         List of builders in the flakiness dashboard is out of date
82         https://bugs.webkit.org/show_bug.cgi?id=73347
83
84         Reviewed by Adam Barth.
85
86         The chromium gpu bots no longer run layout tests, so kill that
87         group entirely.
88
89         * TestResultServer/static-dashboards/builders.js:
90         * TestResultServer/static-dashboards/dashboard_base.js:
91
92 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
93
94         [Qt] Don't hard-code the list of WebKit2 generated sources
95
96         The generated sources are... wait for it... generated. So
97         use the generator itself to figure out which sources we need
98         to compile.
99
100         Reviewed by Simon Hausmann.
101
102         * qmake/mkspecs/features/default_post.prf:
103
104 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
105
106         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
107         https://bugs.webkit.org/show_bug.cgi?id=73216
108
109         Reviewed by Philippe Normand.
110
111         Add a script that tries to sniff out 'make dist' problems without running
112         'make dist.' 'make distcheck' takes a very long time to run and this should
113         reduce the amount of times it needs to be run consecutively.
114
115         * gtk/common.py:
116         (get_build_path.is_valid_build_directory): Guess the source directory
117         by the existence of the GNUmakefile instead of the .libs directory. This
118         allows one to run the script after running autogen.sh but before fully
119         building.
120         * gtk/find-make-dist-errors: Added.
121
122 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
123
124         [Qt] Remove use of internal headers in the MiniBrowser
125
126         Reviewed by Simon Hausmann.
127
128         * MiniBrowser/qt/MiniBrowser.pro:
129
130 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
131
132         [Qt] Fix debug-shlib build without webkit2
133
134         Reviewed by Tor Arne Vestbø.
135
136         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
137
138 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
139
140         [Qt][WK2] Unreviewed buildfix after r101307.
141
142         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
143
144 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
145
146         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
147         https://bugs.webkit.org/show_bug.cgi?id=72848
148
149         Add option to build-webkit.
150
151         Reviewed by Dimitri Glazkov.
152
153         * Scripts/build-webkit:
154
155 2011-11-28  Ojan Vafai  <ojan@chromium.org>
156
157         gtest normalization in the test results server is sometimes wrong
158         https://bugs.webkit.org/show_bug.cgi?id=73262
159
160         Reviewed by Tony Chang.
161
162         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
163         entries in the incremental JSON, one of the entries will have the correct data
164         from the run and the other will have dummy no-data values. Make sure to
165         always pick the one with real data.
166
167         * TestResultServer/model/jsonresults.py:
168         (JsonResults._remove_gtest_modifiers):
169         * TestResultServer/model/jsonresults_unittest.py:
170         (JsonResultsTest.test_remove_gtest_modifiers):
171
172 2011-11-28  Ojan Vafai  <ojan@chromium.org>
173
174         Some of the results.json files have results/times entries at the directory level
175         https://bugs.webkit.org/show_bug.cgi?id=73261
176
177         Reviewed by Tony Chang.
178
179         This is just a bug that got introduced in a temporary push of the results server.
180         This patch repairs the broken files. After all the bots have cycled, we can simplify
181         this code to just assert that results/times are not at the directory level.
182
183         Also, when catching exceptions, log the full stacktrace.
184
185         * TestResultServer/model/jsonresults.py:
186         (_is_directory):
187         (JsonResults._load_json):
188         (JsonResults._merge_tests):
189         (JsonResults.merge):
190         * TestResultServer/model/jsonresults_unittest.py:
191         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
192
193 2011-11-28  Tony Chang  <tony@chromium.org>
194
195         ews bots should pass --force to update-webkit-chromium
196         https://bugs.webkit.org/show_bug.cgi?id=73230
197
198         Reviewed by Adam Barth.
199
200         This makes it less likely for gclient changes to break the bots (e.g.,
201         if a DEPS repository moves or is switched to a branch).
202
203         Also pass --force when using |build-webkit --update-chromium| since this
204         appears to only be used by the bots.
205
206         Take 2: Add Options.non_interactive to update.py's options() method.
207
208         * Scripts/update-webkit:
209         * Scripts/webkitdirs.pm:
210         (determineIsChromium): Add --force-update to update-webkit --chromium.
211         (forceChromiumUpdate):
212         (buildChromium): Pass --force to update-webkit-chromium.
213         * Scripts/webkitpy/tool/steps/update.py:
214         (Update.run): Add --force-update if non-interactive (i.e., bots).
215         * Scripts/webkitpy/tool/steps/update_unittest.py:
216
217 2011-11-28  Tony Chang  <tony@chromium.org>
218
219         Revert r101279, broke the ews and cq bots.
220
221         * Scripts/update-webkit:
222         * Scripts/webkitdirs.pm:
223         (determineIsChromium):
224         (buildChromium):
225         * Scripts/webkitpy/common/config/ports.py:
226         (WebKitPort.update_webkit_command):
227         (ChromiumPort.update_webkit_command):
228         * Scripts/webkitpy/common/config/ports_mock.py:
229         (MockPort.update_webkit_command):
230         * Scripts/webkitpy/tool/steps/update.py:
231         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
232
233 2011-11-28  Ojan Vafai  <ojan@chromium.org>
234
235         testlistjson on the test results server doesn't understand hierarchical results format
236         https://bugs.webkit.org/show_bug.cgi?id=73246
237
238         Reviewed by Tony Chang.
239
240         * TestResultServer/model/jsonresults.py:
241         (JsonResults._delete_results_and_times):
242         Instead of just getting the top-level keys, we now walk the tests tree and
243         delete the results and times values.
244
245         * TestResultServer/model/jsonresults_unittest.py:
246         Simplify the test harness to take in the same JSON format for the tests
247         that the actual results.json uses instead of something very similar but
248         needlessly different. This also allows for testing the broken case of
249         results and times values being at non-leaf level.
250
251 2011-11-28  Tony Chang  <tony@chromium.org>
252
253         ews bots should pass --force to update-webkit-chromium
254         https://bugs.webkit.org/show_bug.cgi?id=73230
255
256         Reviewed by Adam Barth.
257
258         This makes it less likely for gclient changes to break the bots (e.g.,
259         if a DEPS repository moves or is switched to a branch).
260
261         Also pass --force when using |build-webkit --update-chromium| since this
262         appears to only be used by the bots.
263
264         * Scripts/update-webkit:
265         * Scripts/webkitdirs.pm:
266         (determineIsChromium): Add --force-update to update-webkit --chromium.
267         (forceChromiumUpdate):
268         (buildChromium): Pass --force to update-webkit-chromium.
269         * Scripts/webkitpy/tool/steps/update.py:
270         (Update.run): Add --force-update if non-interactive (i.e., bots).
271         * Scripts/webkitpy/tool/steps/update_unittest.py:
272
273 2011-11-28  Michael Saboff  <msaboff@apple.com>
274
275         Fixed help message for --exclude-kraken to say that
276         it excludes Kraken and not SunSpider.
277
278         Rubber-stamped by Filip Pizlo.
279
280         * Scripts/bencher:
281
282 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
283
284         Unreviewed, rolling out r101273.
285         http://trac.webkit.org/changeset/101273
286         https://bugs.webkit.org/show_bug.cgi?id=73244
287
288         multiple test failures and timeouts (Requested by tony^work on
289         #webkit).
290
291         * DumpRenderTree/DumpRenderTree.gypi:
292         * DumpRenderTree/chromium/EventSender.cpp:
293         (EventSender::keyDown):
294         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
295         (AlarmHandler):
296         (TestShell::waitTestFinished):
297         (platformInit):
298         (openStartupDialog):
299         (checkLayoutTestSystemDependencies):
300         * DumpRenderTree/chromium/TestShellGtk.cpp:
301         (AlarmHandler):
302         (setupFontconfig):
303         (TestShell::waitTestFinished):
304         (platformInit):
305         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
306         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
307
308 2011-11-28  John Yani  <vanuan@gmail.com>
309
310         new-run-webkit-tests is locale dependent
311         https://bugs.webkit.org/show_bug.cgi?id=68691
312
313         Reviewed and modified by Eric Seidel.
314
315         This is a simpler version of John's patch which I'm landing.
316         This just engages the hacks from the Host constructor on a global
317         basis.
318
319         * Scripts/webkitpy/common/host.py:
320         (Host.__init__):
321         (Host._engage_awesome_locale_hacks):
322
323 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
324
325         [Chromium] Fix broken DRT build for Aura Linux
326         https://bugs.webkit.org/show_bug.cgi?id=72667
327
328         Reviewed by Tony Chang.
329
330         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
331
332         The following changes have been made:
333
334           1. Renamed TestShellAndroid to TestShellLinux.
335           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
336           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
337
338         * DumpRenderTree/DumpRenderTree.gypi:
339         * DumpRenderTree/chromium/EventSender.cpp:
340         (EventSender::keyDown):
341         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
342         * DumpRenderTree/chromium/TestShellGtk.cpp:
343         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
344         (AlarmHandler):
345         (TestShell::waitTestFinished):
346         (setupFontconfig):
347         (platformInit):
348         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
349         (checkLayoutTestSystemDependencies):
350         (openStartupDialog):
351
352 2011-11-28  Eric Seidel  <eric@webkit.org>
353
354         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
355         https://bugs.webkit.org/show_bug.cgi?id=71983
356
357         Reviewed by Adam Barth.
358
359         We'll add more code to Environment overtime,
360         allowing us to mock out more of our direct interactions with os.environ.
361
362         This patch also makes run_command print the passed in environment.
363
364         * Scripts/webkitpy/common/host_mock.py:
365         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
366         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
367         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
368         * Scripts/webkitpy/common/system/executive.py:
369         * Scripts/webkitpy/common/system/executive_mock.py:
370         * Scripts/webkitpy/layout_tests/port/webkit.py:
371         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
372         * Scripts/webkitpy/tool/commands/download_unittest.py:
373         * Scripts/webkitpy/tool/steps/build.py:
374
375 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
376
377         [Qt] Build system fixes against V8.
378
379         Reviewed by Tor Arne Vestbø.
380
381         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
382         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
383         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
384
385 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
386
387         Make sure the useFixedLayout feature is consistently handled
388         https://bugs.webkit.org/show_bug.cgi?id=73212
389
390         Reviewed by Simon Hausmann.
391
392         The web page parameters are set to our Qt defaults and are now altered
393         in the WebKitTestRunner.
394
395         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
396         (WTR::WrapperWindow::WrapperWindow):
397
398 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
399
400         [Qt] WTF should be built as separate static library
401         https://bugs.webkit.org/show_bug.cgi?id=73201
402
403         Reviewed by Tor Arne Vestbø.
404
405         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
406         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
407         thus wtf dependency.
408         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
409         * WebKitTestRunner/Target.pri: Ditto.
410         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
411         consider wtf, too.
412         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
413         moved into wtf.prf.
414         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
415         link in libwtf.
416         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
417
418 2011-11-28  Kentaro Hara  <haraken@chromium.org>
419
420         run-bindings-tests shows diff error for a newly added binding test
421         https://bugs.webkit.org/show_bug.cgi?id=73179
422
423         Reviewed by Adam Barth.
424
425         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
426         run-bindings-tests just shows diff error because reference files
427         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
428
429             FAIL: (V8) V8TestSupplemental.h
430             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
431
432         Instead, this patch treats a non-existent reference file as an empty file and
433         shows the result of the newly added binding test, like this:
434
435             FAIL: (V8) V8TestSupplemental.h
436             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
437             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
438             @@ -0,0 +1,84 @@
439             +/*
440             +    This file is part of the WebKit open source project.
441             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
442             +
443             (omitted)
444
445         * Scripts/run-bindings-tests:
446         (detect_changes): Just added an -N option to the diff command.
447
448 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
449
450         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
451         https://bugs.webkit.org/show_bug.cgi?id=73165
452
453         Reviewed by Philippe Normand.
454
455         Fix some syntax errors in this script and remove an unused variable.
456
457         * gtk/generate-gtkdoc:
458         (get_webkit2_options.src_path): 
459         (get_webkit2_options):
460         (get_webkit1_options.src_path):
461
462 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
463
464         [wx] Unreviewed build fix. Enable the inspector.
465         
466         * waf/build/settings.py:
467
468 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
469
470         Try to fix the build after r101174.
471
472         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
473
474 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
475
476         [GTK] Integrate build-gtkdoc into build-webkit and make
477         https://bugs.webkit.org/show_bug.cgi?id=72626
478
479         Reviewed by Philippe Normand.
480
481         * GNUmakefile.am: Added support for new scripts and "make docs".
482         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
483         (buildAutotoolsProject):
484         * gtk/generate-gtkdoc: Added.
485         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
486
487 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
488
489         [Qt] Add support for using OWRT with Qt5
490         https://bugs.webkit.org/show_bug.cgi?id=72947
491
492         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
493
494         Reviewed by Csaba Osztrogonác.
495
496         * Scripts/old-run-webkit-tests:
497
498 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
499
500         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
501         https://bugs.webkit.org/show_bug.cgi?id=73126
502
503         No need to have a separate client call for this. The front-end can store messages
504         which arrive before front-end loaded and dispatch them later. This happens in layout
505         tests only by the way as all other messages should be initiated by the front-end code.
506
507         Reviewed by Pavel Feldman.
508
509         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
510         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
511         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
512         * DumpRenderTree/chromium/DRTDevToolsClient.h:
513
514 2011-11-24  Kentaro Hara  <haraken@chromium.org>
515
516         Replace subprocess.call() with subprocess.Popen()
517         https://bugs.webkit.org/show_bug.cgi?id=73105
518
519         Reviewed by Adam Barth.
520
521         Currently, the stdout and stderr of the child processes of run-bindings-tests
522         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
523         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
524         between a parent process and a child process. This patch replaces subprocess.call() with
525         subprocess.Popen() and synchronizes the stdout and stderr between them.
526         This patch also makes output messages of run-bindings-tests more readable.
527
528         With this patch, the output messages of run-bindings-tests look like as follows:
529
530             PASS: (CPP) WebDOMTestObj.h
531             PASS: (CPP) WebDOMTestObj.cpp
532             FAIL: (CPP) WebDOMTestInterface.h
533             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
534             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
535             @@ -23,7 +23,7 @@
536              #ifndef WebDOMTestInterface_h
537              #define WebDOMTestInterface_h
538
539             -#if ENABLE(Condition1) || ENABLE(Condition2)
540             +#if ENABLE(Condition1) || ENABLE(Condition3)
541
542              #include <WebDOMObject.h>
543              #include <WebDOMString.h>
544              @@ -53,5 +53,5 @@
545              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
546
547              #endif
548             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
549             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
550             PASS: (CPP) WebDOMFloat64Array.cpp
551             PASS: (CPP) WebDOMFloat64Array.h
552
553             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
554
555         * Scripts/run-bindings-tests:
556         (generate_from_idl):
557         (detect_changes):
558         (run_tests):
559         (main):
560
561 2011-11-24  Kentaro Hara  <haraken@chromium.org>
562
563         Fix the current working directory of run-bindings-tests
564         https://bugs.webkit.org/show_bug.cgi?id=73106
565
566         Reviewed by Adam Barth.
567
568         Currently, run-bindings-tests outputs the following error
569         (although it outputs "all tests passed!" in the end):
570
571             Testing the ObjC generator on TestObj.idl
572             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
573             gcc: warning: '-x objective-c' after last input file has no effect
574             gcc: no input files
575
576         This is because CodeGeneratorObjC.pm assumes that the current working directory
577         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
578         Thus, this patch changes it to WebKit/Source/.
579
580         * Scripts/run-bindings-tests:
581         (generate_from_idl):
582         (main):
583
584 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
585
586         [Qt] Get rid of the buildDirForSource() function in the build system
587
588         At some point the plan was to allow for running qmake on sub-trees
589         of the sources, into the top level build directory, but this is no
590         longer possible, so no reason to keep the convenience function around.
591
592         Reviewed by Simon Hausmann.
593
594         * WebKitTestRunner/DerivedSources.pri:
595         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
596         * qmake/mkspecs/features/default_post.prf:
597         * qmake/mkspecs/features/default_pre.prf:
598         * qmake/mkspecs/features/functions.prf:
599         * qmake/mkspecs/features/javascriptcore.prf:
600         * qmake/mkspecs/features/webcore.prf:
601         * qmake/mkspecs/features/webkit2.prf:
602
603 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
604
605         Unreviewed, rolling out r101107.
606         http://trac.webkit.org/changeset/101107
607         https://bugs.webkit.org/show_bug.cgi?id=73062
608
609         Breaks the commit-queue (Requested by abarth on #webkit).
610
611         * Scripts/webkitpy/common/host.py:
612         (Host._engage_awesome_windows_hacks):
613         * Scripts/webkitpy/common/host_mock.py:
614         (MockHost.__init__):
615         * Scripts/webkitpy/common/system/environment.py: Removed.
616         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
617         * Scripts/webkitpy/common/system/executive.py:
618         (Executive._run_command_with_teed_output):
619         (Executive.run_and_throw_if_fail):
620         * Scripts/webkitpy/common/system/executive_mock.py:
621         (MockExecutive.run_and_throw_if_fail):
622         (MockExecutive.run_command):
623         * Scripts/webkitpy/layout_tests/port/webkit.py:
624         (WebKitPort._driver_build_script_name):
625         (WebKitPort._run_script):
626         (WebKitPort._build_driver):
627         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
628         (test_build_driver):
629         * Scripts/webkitpy/tool/commands/download_unittest.py:
630         * Scripts/webkitpy/tool/steps/build.py:
631         (Build.build):
632
633 2011-11-23  Ojan Vafai  <ojan@chromium.org>
634
635         Unreviewed, rolling out r101110.
636         http://trac.webkit.org/changeset/101110
637         https://bugs.webkit.org/show_bug.cgi?id=73057
638
639         The bots have now cycled and this patch is no longer needed.
640
641         * Scripts/webkitpy/layout_tests/controllers/manager.py:
642         (Manager._upload_json_files):
643
644 2011-11-23  Ojan Vafai  <ojan@chromium.org>
645
646         Temporarily save the incremental results json in order to identify bug
647         https://bugs.webkit.org/show_bug.cgi?id=73057
648
649         Reviewed by Dean Jackson.
650
651         The test results server needed to be rolled back from tip of tree
652         due to a JSON merging bug. It's hard to identify what the bug is without
653         the raw data.
654
655         * Scripts/webkitpy/layout_tests/controllers/manager.py:
656         (Manager._upload_json_files):
657
658 2011-11-23  Ojan Vafai  <ojan@chromium.org>
659
660         Merging two version 4 results hits an error in the test results server
661         https://bugs.webkit.org/show_bug.cgi?id=73042
662
663         Reviewed by Adam Barth.
664
665         The old code assumed that if the aggregate results value was not a leaf
666         value that the incremental results would exist, which is just totally
667         wrong. Added a test for that case as well.
668
669         * TestResultServer/model/jsonresults.py:
670         (JsonResults._merge_tests):
671         * TestResultServer/model/jsonresults_unittest.py:
672         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
673         (JsonResultsTest.test_merge_build_directory_hierarchy):
674
675 2011-11-23  Eric Seidel  <eric@webkit.org>
676
677         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
678         https://bugs.webkit.org/show_bug.cgi?id=71983
679
680         Reviewed by Adam Barth.
681
682         We'll add more code to Environment overtime,
683         allowing us to mock out more of our direct interactions with os.environ.
684
685         This patch also makes run_command print the passed in environment.
686
687         * Scripts/webkitpy/common/host_mock.py:
688         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
689         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
690         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
691         * Scripts/webkitpy/common/system/executive.py:
692         * Scripts/webkitpy/common/system/executive_mock.py:
693         * Scripts/webkitpy/layout_tests/port/webkit.py:
694         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
695         * Scripts/webkitpy/tool/commands/download_unittest.py:
696         * Scripts/webkitpy/tool/steps/build.py:
697
698 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
699
700         [Qt] Re-generate QtWebKit API forwarding headers when API changes
701
702         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
703         so we need sync.profile to live in the same directory as the project file
704         that will be touched when adding/removing API (api.pri in our case).
705
706         Since the WebKit2 APIs live in a separate static library, we have to
707         add the project file for WebKit2 as a dependency of the api.pri file
708         as well, so that any changes to the WebKit2 API will still trigger a
709         run of qmake (and then syncqt).
710
711         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
712         that the forwarding headers are still generated in the root build dir,
713         not in the Source dir along with the internal forwarding headers.
714
715         Reviewed by Andreas Kling.
716
717         * qmake/mkspecs/features/default_pre.prf:
718         * qmake/mkspecs/features/functions.prf:
719
720 2011-11-23  Johnny Ding  <jnd@chromium.org>
721
722         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
723         https://bugs.webkit.org/show_bug.cgi?id=72950
724
725         Reviewed by Tony Chang.
726
727         * DumpRenderTree/chromium/LayoutTestController.cpp:
728         (LayoutTestController::queueLoadHTMLString):
729
730 2011-11-23  Adam Barth  <abarth@webkit.org>
731
732         garden-o-matic should display a message if it can't find results to display
733         https://bugs.webkit.org/show_bug.cgi?id=72991
734
735         Reviewed by Dimitri Glazkov.
736
737         Not all failures (e.g., TIMEOUT) have results that we can display.
738         This patch adds a short message so that the user can see that we're
739         done trying to load the results.
740
741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
742         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
744
745 2011-11-23  Adam Barth  <abarth@webkit.org>
746
747         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
748         https://bugs.webkit.org/show_bug.cgi?id=72992
749
750         Reviewed by Dimitri Glazkov.
751
752         This patch also prepares us to list other sorts of failures, like
753         performance and unit test.
754
755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
758         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
759
760 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
761
762         Add new Chromium tests to the flakiness dashboard
763         https://bugs.webkit.org/show_bug.cgi?id=72997
764
765         Reviewed by Ojan Vafai.
766
767         * TestResultServer/static-dashboards/dashboard_base.js:
768         ():
769
770 2011-11-23  Adam Barth  <abarth@webkit.org>
771
772         garden-o-matic should support AUDIO failures
773         https://bugs.webkit.org/show_bug.cgi?id=69477
774
775         Reviewed by Dimitri Glazkov.
776
777         This is a first iteration at supporting AUDIO failures in
778         garden-o-matic.  We'll probably need to iterate a bit when we have a
779         real audio failure in the tree to play with.  For example, we'll
780         probably want to add and <audio> element to the "Examine" view to hear
781         the differences, but that all can be done in a subsequent patch.
782
783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
784
785 2011-11-23  Scott Graham  <scottmg@chromium.org>
786
787         Adding gamepad support
788         https://bugs.webkit.org/show_bug.cgi?id=69451
789
790         Reviewed by Darin Fisher.
791
792         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
793         gamepad data that will be retrieved when JS code pulls via API access.
794
795         * DumpRenderTree/DumpRenderTree.gypi:
796         * DumpRenderTree/chromium/GamepadController.cpp: Added.
797         (GamepadController::GamepadController):
798         (GamepadController::bindToJavascript):
799         (GamepadController::reset):
800         (GamepadController::connect):
801         (GamepadController::disconnect):
802         (GamepadController::setId):
803         (GamepadController::setButtonCount):
804         (GamepadController::setButtonData):
805         (GamepadController::setAxisCount):
806         (GamepadController::setAxisData):
807         (GamepadController::fallbackCallback):
808         * DumpRenderTree/chromium/GamepadController.h: Added.
809         * DumpRenderTree/chromium/TestShell.cpp:
810         (TestShell::TestShell):
811         (TestShell::resetTestController):
812         (TestShell::bindJSObjectsToWindow):
813         * DumpRenderTree/chromium/TestShell.h:
814         (TestShell::gamepadController):
815
816 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
817
818         [CMake] Move the top-level logic to the top-level directory.
819         https://bugs.webkit.org/show_bug.cgi?id=72685
820
821         Reviewed by Brent Fulgham.
822
823         * CMakeLists.txt: Added.
824         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
825         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
826         * Scripts/webkitdirs.pm:
827         (generateBuildSystemFromCMakeProject):
828         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
829
830 2011-11-17  Vincent Scheib  <scheib@chromium.org>
831
832         Pointer Lock: Initial Tests for navigator.webkitPonter
833         https://bugs.webkit.org/show_bug.cgi?id=72659
834
835         Reviewed by Darin Fisher.
836
837         * DumpRenderTree/chromium/TestShell.cpp:
838         (TestShell::TestShell):
839             Enabling PointerLock in TestShell
840
841 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
842
843         Update flakiness dashboard for new Chromium builders and tests
844         https://bugs.webkit.org/show_bug.cgi?id=72931
845
846         Reviewed by Ojan Vafai.
847
848         * TestResultServer/static-dashboards/builders.js:
849         * TestResultServer/static-dashboards/dashboard_base.js:
850
851 2011-11-22  Adam Roben  <aroben@apple.com>
852
853         Remove some debugging code I accidentally left in r101005
854
855         * Scripts/prepare-ChangeLog:
856         (get_function_line_ranges_for_python):
857
858 2011-11-22  Adam Roben  <aroben@apple.com>
859
860         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
861
862         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
863         classes/methods in Python source files
864
865         Reviewed by Dan Bates.
866
867         * Scripts/prepare-ChangeLog:
868         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
869         or that use python as their interpreter. Modified the code that extracts the interpreter to
870         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
871         scripts.
872         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
873         for class/def lines and generate ranges based on them.
874
875 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
876
877         [GTK] Enable WebSocket hybi tests
878         https://bugs.webkit.org/show_bug.cgi?id=72870
879
880         Reviewed by Xan Lopez.
881
882         * DumpRenderTree/gtk/DumpRenderTree.cpp:
883         (resetDefaultsToConsistentValues):
884         Reset the setting value to the default value (true).
885         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
886         (LayoutTestController::overridePreference):
887         Change the setting value through a function in DumpRenderTreeSupportGtk.
888
889 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
890
891         ChangeLogEntry should be able to parse entries with multiple authors
892         https://bugs.webkit.org/show_bug.cgi?id=72690
893
894         Reviewed by Eric Seidel.
895
896         Support multi-author change log entries in ChangeLogEntry. Split author names using
897         the same logic as splitting reviewer names. _authors now stores list of dictionaries
898         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
899         accounts because some contributors are never listed in committers.py. 
900
901         * Scripts/webkitpy/common/checkout/changelog.py:
902         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
903         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
904         throws an exception when the argument is None.
905
906 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
907
908         [Qt] Speed up debug builds.
909         https://bugs.webkit.org/show_bug.cgi?id=72882
910
911         Reviewed by Tor Arne Vestbø.
912
913         Introduce a special type of build that replaces the static jsc/wc/wk2
914         static libraries with shared libraries, that individually are much faster
915         to link and don't require relinking into the big library when changing just
916         one file in one module. It can be enabled with
917         --qmakearg="CONFIG+=force_static_libs_as_shared"
918
919         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
920         disable symbol visibility, static linkage and enable rpath.
921         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
922         we need to link the convenience libraries together or not and renamed linkStaticLibrary
923         to just linkLibrary (because linkage is not necessarily static).
924         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
925         link against jsc/wc/wk2 when linking app code against QtWebKit.
926         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
927         function.
928         * qmake/mkspecs/features/webcore.prf: Ditto.
929         * qmake/mkspecs/features/webkit2.prf: Ditto.
930
931 2011-11-21  Adam Klein  <adamk@chromium.org>
932
933         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
934         https://bugs.webkit.org/show_bug.cgi?id=72898
935
936         Reviewed by Ojan Vafai.
937
938         Also removed a comment that was going to be more trouble to keep up to
939         date than seemed worthwhile (the code is now the documentation).
940
941         * TestResultServer/static-dashboards/flakiness_dashboard.html:
942
943 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
944
945         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
946         https://bugs.webkit.org/show_bug.cgi?id=72895
947
948         Reviewed by Chris Fleizach.
949
950         * DumpRenderTree/chromium/WebViewHost.cpp:
951         (WebViewHost::postAccessibilityNotification):
952
953 2011-11-21  Philippe Normand  <pnormand@igalia.com>
954
955         Unreviewed, run-gtk-tests temporary workaround after r98500.
956
957         * Scripts/run-gtk-tests: Try to find the build directory like in
958         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
959
960 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
961
962         [GTK] Add a way to skip unit tests in the bots
963         https://bugs.webkit.org/show_bug.cgi?id=72879
964
965         Reviewed by Philippe Normand.
966
967         Rewrite the script in python to make it easier for everybody to
968         change it and add support for skipping tests.
969
970         * Scripts/run-gtk-tests:
971
972 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
973
974         [EFL] Add more appcache functions to ewk_settings.
975         https://bugs.webkit.org/show_bug.cgi?id=72143
976
977         Reviewed by Kenneth Rohde Christiansen.
978
979         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
980         (LayoutTestController::clearAllApplicationCaches):
981         (LayoutTestController::setAppCacheMaximumSize): Use the right
982         function, this is not related to the memory cache, but rather to the
983         appcache.
984
985 2011-11-18  Adam Roben  <aroben@apple.com>
986
987         Make NRWT consider all lines of output from parse-malloc-history, not just the first
988
989         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
990         found" even when there are more than 1 unique leaks
991
992         Reviewed by Darin Adler.
993
994         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
995         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
996         "^" will be considered to match the beginning of any line, not only the beginning of the
997         string.
998
999         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1000         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
1001         fake output and updated expectations to match.
1002
1003 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
1004
1005         [Qt] Clean up MiniBrowser project file after recent changes
1006         https://bugs.webkit.org/show_bug.cgi?id=72869
1007
1008         Reviewed by Simon Hausmann.
1009
1010         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
1011
1012         * MiniBrowser/qt/MiniBrowser.pro:
1013
1014 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
1015
1016         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
1017         https://bugs.webkit.org/show_bug.cgi?id=72479
1018
1019         Reviewed by Chris Fleizach.
1020
1021         * DumpRenderTree/AccessibilityUIElement.cpp:
1022         (getIsSelectedOptionActiveCallback):
1023         (AccessibilityUIElement::getJSClass):
1024         * DumpRenderTree/AccessibilityUIElement.h:
1025         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1026         (AccessibilityUIElement::AccessibilityUIElement):
1027         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
1028         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1029         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1030         (AccessibilityUIElement::isSelectedOptionActive):
1031         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1032         (AccessibilityUIElement::isSelectedOptionActive):
1033         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1034         (AccessibilityUIElement::isSelectedOptionActive):
1035
1036 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
1037
1038         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
1039         https://bugs.webkit.org/show_bug.cgi?id=72859
1040
1041         Reviewed by Eric Seidel.
1042         
1043         * Scripts/new-run-webkit-websocketserver:
1044
1045 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
1046
1047         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
1048         https://bugs.webkit.org/show_bug.cgi?id=72655
1049
1050         Reviewed by Hajime Morita.
1051
1052         Fixed the calculation of offset.
1053
1054         * DumpRenderTree/chromium/WebViewHost.cpp:
1055         (WebViewHost::finishLastTextCheck):
1056
1057 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1058
1059         Change the final place where we use version 3 of the results json output
1060         https://bugs.webkit.org/show_bug.cgi?id=72838
1061
1062         Reviewed by Adam Barth.
1063
1064         This converts the json from being a flat map of test name --> results
1065         to being hierarchical by directory. This will make the json files 
1066         considerably smaller.
1067
1068         Also cleaned up some functions that were returning/checking boolean values
1069         that were always True.
1070
1071         * TestResultServer/model/jsonresults.py:
1072         * TestResultServer/model/jsonresults_unittest.py:
1073
1074 2011-11-20  Ojan Vafai  <ojan@chromium.org>
1075
1076         Include the master name when querying the test results server.
1077         This will soon be required since leaving the master name out mean
1078         that multiple files could match the query.
1079
1080         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1081
1082 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1083
1084         Fix jsonp callback code to add the callback if json content
1085         is not jsonp.
1086         * TestResultServer/handlers/testfilehandler.py:
1087
1088 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
1089
1090         Modify dashboard_base.js to optionally accept version 4 results json.
1091
1092         Reviewed by Ojan Vafai.
1093
1094         * TestResultServer/static-dashboards/dashboard_base.js:
1095         (ADD_RESULTS):
1096         (flattenTrie):
1097         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1098         (testFlattenTrie):
1099
1100 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1101
1102         Stop storing results files as jsonp in the test results server
1103         https://bugs.webkit.org/show_bug.cgi?id=72814
1104
1105         Reviewed by Adam Barth.
1106
1107         * TestResultServer/model/jsonresults.py:
1108         * TestResultServer/model/jsonresults_unittest.py:
1109
1110 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1111
1112         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
1113         https://bugs.webkit.org/show_bug.cgi?id=72813
1114
1115         Reviewed by Adam Barth.
1116
1117         Once this lands, we can start storing pure json in the test results server and then
1118         we can delete the code with all the FIXMEs added here.
1119
1120         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1121         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1122         Only add jsonp for full_results.json.
1123         * TestResultServer/model/jsonresults.py:
1124         * TestResultServer/model/jsonresults_unittest.py:
1125         Accept pure json uploads.
1126         * TestResultServer/static-dashboards/dashboard_base.js:
1127         (appendJSONScriptElementFor):
1128         Use the callback parameter so that the server can start returning pure json if it's left out.
1129
1130 2011-11-19  Ojan Vafai  <ojan@chromium.org>
1131
1132         Allow json NRWT downloads to be pure json and not jsonp
1133         https://bugs.webkit.org/show_bug.cgi?id=72809
1134
1135         Reviewed by Adam Barth.
1136
1137         I'm moving the server to storing and serving up raw json instead of jsonp.
1138         You can still get the jsonp by passing a "callback" parameter, but there's no
1139         need for run-webkit-tests to get jsonp when all it wants is the raw json.
1140
1141         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1142         Make the wrapper stripping only happen if the json is actually wrapped.
1143         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1144
1145 2011-11-18  Daniel Bates  <dbates@rim.com>
1146
1147         Add CMake build infrastructure for the BlackBerry port
1148         https://bugs.webkit.org/show_bug.cgi?id=72768
1149
1150         Reviewed by Antonio Gomes.
1151
1152         Add optional --blackberry command line argument to build-webkit to build the
1153         BlackBerry port.
1154
1155         * Scripts/build-webkit:
1156         * Scripts/webkitdirs.pm:
1157         (determineBaseProductDir):
1158         (argumentsForConfiguration):
1159         (builtDylibPathForName):
1160         (determineIsQt):
1161         (isBlackBerry): Added.
1162         (determineIsBlackBerry): Added.
1163         (blackberryTargetArchitecture): Added.
1164         (isAppleWebKit):
1165
1166 2011-11-18  James Robinson  <jamesr@chromium.org>
1167
1168         Unreviewed, rolling out r100835.
1169         http://trac.webkit.org/changeset/100835
1170         https://bugs.webkit.org/show_bug.cgi?id=72778
1171
1172         Broke some page scale tests
1173
1174         * DumpRenderTree/chromium/EventSender.cpp:
1175         (EventSender::scalePageBy):
1176
1177 2011-11-18  Adam Barth  <abarth@webkit.org>
1178
1179         Prepare to move manual-tests out of WebCore
1180         https://bugs.webkit.org/show_bug.cgi?id=72782
1181
1182         Reviewed by Eric Seidel.
1183
1184         Update this file to refer to the new location of ManualTests.
1185
1186         * Scripts/webkitpy/common/config/build.py:
1187
1188 2011-11-18  James Robinson  <jamesr@chromium.org>
1189
1190         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
1191         https://bugs.webkit.org/show_bug.cgi?id=72778
1192
1193         Reviewed by Kenneth Russell.
1194
1195         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
1196
1197         * DumpRenderTree/chromium/EventSender.cpp:
1198         (EventSender::scalePageBy):
1199
1200 2011-11-18  Scott Graham  <scottmg@chromium.org>
1201
1202         IDL changes for gamepad support
1203         https://bugs.webkit.org/show_bug.cgi?id=71753
1204
1205         Reviewed by Adam Barth.
1206
1207         Runtime enable gamepad in chromium test shell.
1208
1209         * DumpRenderTree/chromium/TestShell.cpp:
1210         (TestShell::TestShell):
1211
1212 2011-10-27  Darin Fisher  <darin@chromium.org>
1213
1214         [chromium] Improve fullscreen API
1215         https://bugs.webkit.org/show_bug.cgi?id=70477
1216
1217         Reviewed by Adam Barth.
1218
1219         Implement enter/exitFullScreen.  The implementation is asynchronous,
1220         via postDelayedTask, to simulate how the browser actually behaves.
1221
1222         * DumpRenderTree/chromium/WebViewHost.cpp:
1223         (WebViewHost::enterFullScreen):
1224         (WebViewHost::exitFullScreen):
1225         (WebViewHost::setAddressBarURL):
1226         (WebViewHost::enterFullScreenNow):
1227         (WebViewHost::exitFullScreenNow):
1228         * DumpRenderTree/chromium/WebViewHost.h:
1229
1230 2011-11-18  Adam Roben  <aroben@apple.com>
1231
1232         Ignore an ANGLE leak that is not WebKit's fault
1233
1234         * Scripts/old-run-webkit-tests:
1235         (countAndPrintLeaks):
1236         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1237         (LeakDetector._callstacks_to_exclude_from_leaks):
1238         Added ScanFromString to the call stacks to exclude on all OS versions.
1239
1240 2011-11-18  Adam Roben  <aroben@apple.com>
1241
1242         Ignore another Lion-specific leak that is not WebKit's fault
1243
1244         * Scripts/old-run-webkit-tests:
1245         (countAndPrintLeaks):
1246         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1247         (LeakDetector._callstacks_to_exclude_from_leaks):
1248         Added SecTransformExecute to the call stacks to exclude.
1249
1250 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
1251
1252         [Qt] Enable WebSocket hybi tests
1253         https://bugs.webkit.org/show_bug.cgi?id=72687
1254
1255         Reviewed by Simon Hausmann.
1256
1257         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
1258
1259         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1260         (WebCore::WebPage::resetSettings):
1261         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1262         (LayoutTestController::overridePreference):
1263
1264 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
1265
1266         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
1267         https://bugs.webkit.org/show_bug.cgi?id=72707
1268
1269         Reviewed by Philippe Normand.
1270
1271         Make new-run-webkit-tests use the right path to locate the test
1272         plugin used by WebKitTestRunner.
1273
1274         * Scripts/webkitpy/layout_tests/port/gtk.py:
1275
1276 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
1277
1278         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
1279         https://bugs.webkit.org/show_bug.cgi?id=72697
1280
1281         Reviewed by Kenneth Rohde Christiansen.
1282
1283         * Tools.pro: Make WTR linux only for the moment.
1284         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
1285         * WebKitTestRunner/Target.pri: Ditto.
1286         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
1287         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
1288
1289 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1290
1291         [Qt] Change default size of the MiniBrowser
1292
1293         Reviewed by Simon Hausmann.
1294
1295         As we lay out desktop pages using the width of 980, change our default
1296         size to 980x735 so that we are not scaling down by default.
1297
1298         * MiniBrowser/qt/MiniBrowserApplication.h:
1299         (WindowOptions::WindowOptions):
1300
1301 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1302
1303         [EFL] Clean up the use of DATA_DIR in the buildsystem
1304         https://bugs.webkit.org/show_bug.cgi?id=72681
1305
1306         Reviewed by Daniel Bates.
1307
1308         Instead of adding -DDATA_DIR in all scopes, only define it in
1309         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
1310         it.
1311
1312         We can then define DATA_DIR to the generated theme directory for
1313         EWebLauncher, since it's what we want here.
1314
1315         * CMakeListsEfl.txt:
1316
1317 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
1318
1319         [EFL] Move platform includes last in DRT's include directories.
1320         https://bugs.webkit.org/show_bug.cgi?id=72684
1321
1322         Reviewed by Daniel Bates.
1323
1324         This is the first step in fixing the build when a platform include (in
1325         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
1326         is included instead of WebKit's.
1327
1328         * DumpRenderTree/efl/CMakeLists.txt:
1329
1330 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
1331
1332         fuzzy_match doesn't recognize "Dan B" or "hyatt"
1333         https://bugs.webkit.org/show_bug.cgi?id=72636
1334
1335         Reviewed by Eric Seidel.
1336
1337         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
1338         and user names of email addreses such as rniwa in rniwa@webkit.org.
1339
1340         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
1341
1342         * Scripts/webkitpy/common/config/committers.py:
1343         * Scripts/webkitpy/common/config/committers_unittest.py:
1344
1345 2011-11-17  Eric Seidel  <eric@webkit.org>
1346
1347         Remove support for running check-webkit-style w/o a webkit checkout
1348         https://bugs.webkit.org/show_bug.cgi?id=72678
1349
1350         Reviewed by Adam Barth.
1351
1352         After talking to Dave Levin we've decided to remove this
1353         code.  I know of no users of check-webkit-style w/o a webkit checkout
1354         and this needlessly adds complexity.
1355
1356         * Scripts/webkitpy/style/main.py:
1357
1358 2011-11-17  Eric Seidel  <eric@webkit.org>
1359
1360         Remove more direct uses of os.path
1361         https://bugs.webkit.org/show_bug.cgi?id=72677
1362
1363         Reviewed by Adam Barth.
1364
1365         Remove more uses of os.path, including refactoring
1366         CommitterValidator to use a Host object instead of
1367         manual hacks to emulate what SCM and FileSystem provide.
1368
1369         * Scripts/webkitpy/common/checkout/changelog.py:
1370         * Scripts/webkitpy/common/config/committervalidator.py:
1371         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1372         * Scripts/webkitpy/common/system/filesystem_mock.py:
1373          - Turns out none of our unittests actually looked at this path.
1374            now I've made it be a valid path.
1375         * Scripts/webkitpy/tool/bot/feeders.py:
1376         * Scripts/webkitpy/tool/commands/queues.py:
1377
1378 2011-11-17  Eric Seidel  <eric@webkit.org>
1379
1380         Teach TextFileReader about FileSystem
1381         https://bugs.webkit.org/show_bug.cgi?id=72673
1382
1383         Reviewed by Adam Barth.
1384
1385         Unfortunately TextFileReader doesn't use FileSystem
1386         everywhere yet, so we can't move the unittests to
1387         using MockFileSystem, but we're close.
1388
1389         * Scripts/webkitpy/style/filereader.py:
1390         * Scripts/webkitpy/style/filereader_unittest.py:
1391         * Scripts/webkitpy/style/main.py:
1392
1393 2011-11-17  Eric Seidel  <eric@webkit.org>
1394
1395         Give check-webkit-style a Host
1396         https://bugs.webkit.org/show_bug.cgi?id=72670
1397
1398         Reviewed by Adam Barth.
1399
1400         * Scripts/webkitpy/common/checkout/scm/detection.py:
1401         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1402          - We don't run these unittests, but this one was looking for the wrong exception.
1403         * Scripts/webkitpy/style/main.py:
1404         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1405          - This was create a new scm object even though it already had one?
1406
1407 2011-11-17  Eric Seidel  <eric@webkit.org>
1408
1409         Move check-webkit-style change_directory code to more modern mocks
1410         https://bugs.webkit.org/show_bug.cgi?id=72664
1411
1412         Reviewed by Adam Barth.
1413
1414         * Scripts/check-webkit-style:
1415         * Scripts/webkitpy/style/main.py:
1416         * Scripts/webkitpy/style/main_unittest.py:
1417
1418 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
1419
1420         [GTK] enable ref tests
1421         https://bugs.webkit.org/show_bug.cgi?id=72601
1422
1423         Re-enable ref tests. Run the driver under evenly numbered display if performing
1424         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
1425         being run in an already used Xvfb instance if pixel tests are disabled.
1426
1427         Reviewed by Tony Chang.
1428
1429         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
1430         after the process is killed
1431
1432 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1433
1434         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
1435         https://bugs.webkit.org/show_bug.cgi?id=72620
1436
1437         Reviewed by David Levin.
1438
1439         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
1440         adding the suffix the cpp file. One example of false positive
1441         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
1442
1443         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
1444         basename contains the cpp's basename.
1445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1446
1447 2011-11-17  Eric Seidel  <eric@webkit.org>
1448
1449         Move check-webkit-style's guts into webkitpy/style/main.py
1450         https://bugs.webkit.org/show_bug.cgi?id=72657
1451
1452         Reviewed by Adam Barth.
1453
1454         * Scripts/check-webkit-style:
1455         * Scripts/webkitpy/style/main.py:
1456
1457 2011-11-17  Eric Seidel  <eric@webkit.org>
1458
1459         new-run-webkit-tests is locale dependent
1460         https://bugs.webkit.org/show_bug.cgi?id=68691
1461
1462         Reviewed by Adam Barth.
1463
1464         Make NRWT use a clean environment, just like ORWT did.
1465
1466         * Scripts/webkitpy/layout_tests/port/base.py:
1467         * Scripts/webkitpy/layout_tests/port/chromium.py:
1468         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1469         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1470         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1471         * Scripts/webkitpy/layout_tests/port/efl.py:
1472         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1473         * Scripts/webkitpy/layout_tests/port/mac.py:
1474         * Scripts/webkitpy/layout_tests/port/qt.py:
1475         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1476         * Scripts/webkitpy/layout_tests/port/webkit.py:
1477         * Scripts/webkitpy/layout_tests/port/win.py:
1478
1479 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
1480
1481         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
1482         https://bugs.webkit.org/show_bug.cgi?id=72615
1483
1484         Reviewed by James Robinson.
1485
1486         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1487
1488 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
1489
1490         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
1491         https://bugs.webkit.org/show_bug.cgi?id=72595
1492
1493         Reviewed by Noam Rosenthal.
1494
1495         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1496         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
1497         ensure the registration of the DRTNode JS bindings.
1498         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1499         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
1500         registration of QWebElement (now done implicitly through QWebPage ->
1501         QtWebElementRunTime::initialize code path)
1502
1503 2011-11-17  Adam Roben  <aroben@apple.com>
1504
1505         Fix a crash-inducing typo I introduced in r100648
1506
1507         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
1508         handling a crashing test
1509
1510         Reviewed by Adam Barth.
1511
1512         * Scripts/webkitpy/layout_tests/port/chromium.py:
1513         (ChromiumDriver.run_test): Get the driver name from the port.
1514
1515         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1516         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
1517         right crashed process name.
1518
1519 2011-11-17  Adam Roben  <aroben@apple.com>
1520
1521         Fix NRWT's parsing of the number of excluded leaks
1522
1523         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
1524         leaks were excluded
1525
1526         Reviewed by Adam Barth.
1527
1528         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1529         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
1530         regular expression match, not the entire matched string.
1531
1532         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1533         (LeakDetectorTest): Added some example output that shows how things look when leaks are
1534         excluded.
1535         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
1536         correctly.
1537
1538 2011-11-17  Adam Roben  <aroben@apple.com>
1539
1540         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
1541
1542         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
1543         when web process crashes, but WebProcess crash log should get saved instead
1544
1545         Reviewed by Eric Seidel.
1546
1547         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1548         (write_test_result): Simplified a little to share more code between the case where we
1549         crashed when running the test and where we crashed when checking the expected rendering for
1550         a reftest. Changed to pass the crashed process name down to write_crash_report.
1551         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
1552         along to CrashLogs.find_newest_log rather than always using the driver name.
1553
1554         * Scripts/webkitpy/layout_tests/port/chromium.py:
1555         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
1556         crashed.
1557
1558         * Scripts/webkitpy/layout_tests/port/test.py:
1559         (TestInstance.__init__): Initialize new web_process_crash attribute.
1560         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
1561         test this patch adds.
1562         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
1563         specifies that the driver crashed or the web process crashed.
1564
1565         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1566         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
1567         which we pretend the web process crashed rather than the driver process.
1568
1569         (MainTest.test_run_singly_actually_runs_tests):
1570         (MainTest.test_unexpected_failures):
1571         (EndToEndTest.test_end_to_end):
1572         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
1573
1574 2011-11-17  Tony Chang  <tony@chromium.org>
1575
1576         [chromium] stop spamming features warning on every build
1577         https://bugs.webkit.org/show_bug.cgi?id=72629
1578
1579         Reviewed by Ojan Vafai.
1580
1581         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
1582         $mediaStreamSupport is on by default for chromium, make the default
1583         for $blobSupport also on.
1584
1585         * Scripts/build-webkit:
1586
1587 2011-11-17  Adam Roben  <aroben@apple.com>
1588
1589         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
1590
1591         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
1592         that are supposed to be ignored
1593
1594         Reviewed by Adam Barth.
1595
1596         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1597         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
1598         required when passing arguments via the shell (which we aren't doing here). It is not
1599         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
1600
1601         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1602         (LeakDetectorTest.test_leaks_args): Updated expectations.
1603
1604 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1605
1606         Unreviewed, run-bindings-tests fix after r91028.
1607
1608         * Scripts/run-bindings-tests: Use scm.detection module.
1609
1610 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
1611
1612         Silence a warning about control reaching the end of a non-void function
1613         https://bugs.webkit.org/show_bug.cgi?id=72616
1614
1615         Reviewed by Tony Gentilcore.
1616
1617         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1618         (AccessibilityUIElement::verticalScrollbar):
1619
1620 2011-11-17  Adam Roben  <aroben@apple.com>
1621
1622         Ignore some leaks in frameworks we link against on Lion
1623
1624         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
1625         aren't WebKit's fault
1626
1627         Reviewed by Antti Koivisto.
1628
1629         * Scripts/old-run-webkit-tests:
1630         (countAndPrintLeaks):
1631         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1632         (LeakDetector._callstacks_to_exclude_from_leaks):
1633         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
1634
1635         * Scripts/webkitpy/layout_tests/port/mac.py:
1636         (MacPort.is_lion): Added.
1637
1638         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1639         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
1640         methods.
1641
1642 2011-11-17  Philippe Normand  <pnormand@igalia.com>
1643
1644         [GTK] Disable ref tests
1645         https://bugs.webkit.org/show_bug.cgi?id=72599
1646
1647         Reviewed by Xan Lopez.
1648
1649         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
1650         tests to avoid massive flakiness.
1651
1652 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1653
1654         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
1655
1656         A new extension object has been added to QQuickWebView (the same approach should be used
1657         for other API classes that need experimental APIs). The QML extension mechanism is then
1658         built on top of the experimental object.
1659
1660         https://bugs.webkit.org/show_bug.cgi?id=72522
1661
1662         Reviewed by Simon Hausmann.
1663
1664         * MiniBrowser/qt/BrowserWindow.cpp:
1665         (BrowserWindow::BrowserWindow):
1666         (BrowserWindow::webView):
1667         * MiniBrowser/qt/BrowserWindow.h:
1668         * MiniBrowser/qt/UrlLoader.cpp:
1669         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1670         * qmake/mkspecs/features/default_post.prf:
1671         * qmake/mkspecs/features/default_pre.prf:
1672         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
1673         * qmake/mkspecs/features/qtwebkit.prf:
1674
1675 2011-11-17  Adam Barth  <abarth@webkit.org>
1676
1677         Move test_results_uploader.py out of layout_package
1678         https://bugs.webkit.org/show_bug.cgi?id=72590
1679
1680         Reviewed by Eric Seidel.
1681
1682         Most of the lines of code in this file are wrong, but I've restrained
1683         myself and only changed a few of them to generalized this class to the
1684         common package.
1685
1686         This is part of a series of patches to remove layout_package.
1687
1688         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
1689         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1690         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
1691
1692 2011-11-17  Adam Barth  <abarth@webkit.org>
1693
1694         Unreviewed. Fix style nits in printing.py.
1695
1696         * Scripts/webkitpy/layout_tests/views/printing.py:
1697
1698 2011-11-17  Adam Barth  <abarth@webkit.org>
1699
1700         Minor style nits in run_webkit_tests.py
1701         https://bugs.webkit.org/show_bug.cgi?id=72583
1702
1703         Reviewed by Eric Seidel.
1704
1705         This patch just fixes some minor style issues as I work my way back
1706         into this code.
1707
1708         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1709
1710 2011-11-17  Adam Barth  <abarth@webkit.org>
1711
1712         Move test_result_writer out of layout_package
1713         https://bugs.webkit.org/show_bug.cgi?id=72586
1714
1715         Rubber-stamped by Eric Seidel.
1716
1717         This is part of a series of patches to remove layout_package.
1718
1719         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1720         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
1721         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
1722         * Scripts/webkitpy/tool/commands/rebaseline.py:
1723
1724 2011-11-17  Adam Barth  <abarth@webkit.org>
1725
1726         svn-apply shouldn't magically move files into Source anymore
1727         https://bugs.webkit.org/show_bug.cgi?id=72579
1728
1729         Reviewed by Eric Seidel.
1730
1731         The Source directory has existed for long enough that we don't need
1732         svn-apply to magically re-write old-style patches anymore.
1733
1734         * Scripts/VCSUtils.pm:
1735         (parseGitDiffHeader):
1736         (parseSvnDiffHeader):
1737
1738 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1739
1740         Add a list of contribution areas
1741         https://bugs.webkit.org/show_bug.cgi?id=72566
1742
1743         Reviewed by Eric Seidel.
1744
1745         Added ContributionAreas class.
1746
1747         * Scripts/webkitpy/common/config/contributionareas.py: Added.
1748         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
1749
1750 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1751
1752         Refactor ChangeLogTest.test_parse_reviewer_text
1753         https://bugs.webkit.org/show_bug.cgi?id=72572
1754
1755         Reviewed by Eric Seidel.
1756
1757         Refactored the test code by introduing two helper functions.
1758
1759         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1760
1761 2011-11-16  Eric Seidel  <eric@webkit.org>
1762
1763         Add SCMDetector object to make scm detection mockable
1764         https://bugs.webkit.org/show_bug.cgi?id=72247
1765
1766         Reviewed by Adam Barth.
1767
1768         I think SCM detection may eventually be rolled into Checkout,
1769         but this patch at least makes it possible to mock code-paths
1770         which rely on scm detection.
1771         In the process of replacing callers of these free-functions
1772         I found that one of the functions was no longer used,
1773         and that one of the callers could instead just use the SCM
1774         object it already had access to through port.host.scm().
1775         I also discovered that I was not calling Host._initialize_scm()
1776         and thus host.scm() was always returning None!
1777
1778         * Scripts/check-webkit-style:
1779         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1780         * Scripts/webkitpy/common/checkout/deps.py:
1781         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1782         * Scripts/webkitpy/common/checkout/scm/detection.py:
1783         * Scripts/webkitpy/common/checkout/scm/git.py:
1784         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1785         * Scripts/webkitpy/common/checkout/scm/svn.py:
1786         * Scripts/webkitpy/common/host.py:
1787         * Scripts/webkitpy/common/host_mock.py:
1788         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1789         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1790         * Scripts/webkitpy/layout_tests/port/base.py:
1791         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1793         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1794         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1795
1796 2011-11-16  Mark Rowe  <mrowe@apple.com>
1797
1798         Fix the build.
1799
1800         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
1801         Apply the workaround that we use in other projects to WebKitTestRunner.
1802
1803         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
1804         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1805         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
1806
1807 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1808
1809         [Qt] Fix build after WTR AX support
1810         https://bugs.webkit.org/show_bug.cgi?id=72560
1811
1812         Reviewed by Geoffrey Garen.
1813
1814         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1815         * WebKitTestRunner/InjectedBundle/Target.pri:
1816
1817 2011-11-16  Tony Chang  <tony@chromium.org>
1818
1819         repurpose the flexbox bot for grid layout
1820         https://bugs.webkit.org/show_bug.cgi?id=72557
1821
1822         Reviewed by Ryosuke Niwa.
1823
1824         Since new flexbox is enabled everywhere, we don't need this bot
1825         anymore.  However, work on grid layout has begun, so we can use this
1826         bot to compile with ENABLE_CSS_GRID_LAYOUT.
1827
1828         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
1829         the bot on the waterfall, I will change the slave config to enable
1830         the compile flag and tests.
1831
1832 2011-11-11  Adrienne Walker  <enne@google.com>
1833
1834         [chromium] Expose mock scrollbars to window.internals
1835         https://bugs.webkit.org/show_bug.cgi?id=72195
1836
1837         Reviewed by James Robinson.
1838
1839         Because mock scrollbars are a global setting, reset between runs.
1840
1841         * DumpRenderTree/chromium/WebPreferences.cpp:
1842         (WebPreferences::applyTo):
1843
1844 2011-11-16  James Robinson  <jamesr@chromium.org>
1845
1846         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
1847         https://bugs.webkit.org/show_bug.cgi?id=72562
1848
1849         Reviewed by Dirk Pranke.
1850
1851         * DumpRenderTree/chromium/TestShell.cpp:
1852         (TestShell::runFileTest):
1853
1854 2011-11-16  Tony Chang  <tony@chromium.org>
1855
1856         [NRWT] speculative fix for multiple subprocess test on cygwin
1857         https://bugs.webkit.org/show_bug.cgi?id=72518
1858
1859         Reviewed by Adam Barth.
1860
1861         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
1862             tries to emulate posix fd behavior.
1863         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1864
1865 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1866
1867         Revert r100509; change was committed twice (first time as r100491).
1868         Unreviewed, build fix.
1869
1870         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1871
1872 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1873
1874         Run a dummy test in the gpu configurations if there's nothing to do.
1875         https://bugs.webkit.org/show_bug.cgi?id=72498
1876
1877         Reviewed by James Robinson.
1878
1879         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1880
1881 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
1882
1883         contributors_by_fuzzy_match is super slow
1884         https://bugs.webkit.org/show_bug.cgi?id=72540
1885
1886         Reviewed by Eric Seidel.
1887
1888         Make contributors_by_name do case insensitive search using a dictionary.
1889
1890         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
1891         because that's the most common case.
1892
1893         * Scripts/webkitpy/common/config/committers.py:
1894         * Scripts/webkitpy/common/config/committers_unittest.py:
1895
1896 2011-11-16  David Levin  <levin@chromium.org>
1897
1898         check-webkit-style should recognize functions even if they have OVERRIDE after them.
1899         https://bugs.webkit.org/show_bug.cgi?id=72515
1900
1901         Reviewed by Adam Barth.
1902
1903         * Scripts/webkitpy/style/checkers/cpp.py:
1904         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1905
1906 2011-11-16  Tony Chang  <tony@chromium.org>
1907
1908         [NRWT] refactor drivers to require pixel_tests param
1909         https://bugs.webkit.org/show_bug.cgi?id=72517
1910
1911         Reviewed by Ojan Vafai.
1912
1913         No tests, just a refactoring.
1914
1915         * Scripts/webkitpy/layout_tests/port/chromium.py:
1916         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1917         * Scripts/webkitpy/layout_tests/port/webkit.py:
1918         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1919
1920 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
1921
1922         Run a dummy test in the gpu configurations if there's nothing to do.
1923         https://bugs.webkit.org/show_bug.cgi?id=72498
1924
1925         Reviewed by James Robinson.
1926
1927         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1928
1929 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
1930
1931         WebKitTestRunner needs to support accessibility-related DRT APIs
1932         https://bugs.webkit.org/show_bug.cgi?id=42131
1933
1934         Reviewed by Beth Dakin.
1935
1936         Port the AX code in DRT to WKTestRunner by using IDL.
1937
1938         * DumpRenderTree/AccessibilityUIElement.cpp:
1939         (horizontalScrollbarCallback):
1940         (verticalScrollbarCallback):
1941         (AccessibilityUIElement::horizontalScrollbar):
1942         (AccessibilityUIElement::verticalScrollbar):
1943         (AccessibilityUIElement::getJSClass):
1944         * DumpRenderTree/AccessibilityUIElement.h:
1945         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1946         (AccessibilityUIElement::horizontalScrollbar):
1947         (AccessibilityUIElement::verticalScrollbar):
1948         * WebKitTestRunner/DerivedSources.make:
1949         * WebKitTestRunner/GNUmakefile.am:
1950         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
1951         (WTR::AccessibilityController::create):
1952         (WTR::AccessibilityController::AccessibilityController):
1953         (WTR::AccessibilityController::~AccessibilityController):
1954         (WTR::AccessibilityController::makeWindowObject):
1955         (WTR::AccessibilityController::wrapperClass):
1956         (WTR::AccessibilityController::rootElement):
1957         (WTR::AccessibilityController::focusedElement):
1958         (WTR::AccessibilityController::elementAtPoint):
1959         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
1960         (WTR::AccessibilityController::logFocusEvents):
1961         (WTR::AccessibilityController::logValueChangeEvents):
1962         (WTR::AccessibilityController::logScrollingStartEvents):
1963         (WTR::AccessibilityController::logAccessibilityEvents):
1964         (WTR::AccessibilityController::addNotificationListener):
1965         (WTR::AccessibilityController::notificationReceived):
1966         (WTR::AccessibilityController::resetToConsistentState):
1967         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
1968         (WTR::AccessibilityTextMarker::create):
1969         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
1970         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
1971         (WTR::AccessibilityTextMarker::platformTextMarker):
1972         (WTR::AccessibilityTextMarker::wrapperClass):
1973         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
1974         (WTR::AccessibilityTextMarker::isEqual):
1975         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
1976         (WTR::AccessibilityTextMarkerRange::create):
1977         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
1978         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
1979         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
1980         (WTR::AccessibilityTextMarkerRange::wrapperClass):
1981         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
1982         (WTR::AccessibilityTextMarkerRange::isEqual):
1983         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
1984         (WTR::AccessibilityUIElement::create):
1985         (WTR::AccessibilityUIElement::wrapperClass):
1986         (WTR::AccessibilityUIElement::isValid):
1987         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1988         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
1989         (WTR::AccessibilityUIElement::isEqual):
1990         (WTR::AccessibilityUIElement::elementAtPoint):
1991         (WTR::AccessibilityUIElement::childAtIndex):
1992         (WTR::AccessibilityUIElement::indexOfChild):
1993         (WTR::AccessibilityUIElement::childrenCount):
1994         (WTR::AccessibilityUIElement::titleUIElement):
1995         (WTR::AccessibilityUIElement::parentElement):
1996         (WTR::AccessibilityUIElement::takeFocus):
1997         (WTR::AccessibilityUIElement::takeSelection):
1998         (WTR::AccessibilityUIElement::addSelection):
1999         (WTR::AccessibilityUIElement::removeSelection):
2000         (WTR::AccessibilityUIElement::allAttributes):
2001         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2002         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2003         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2004         (WTR::AccessibilityUIElement::attributesOfChildren):
2005         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2006         (WTR::AccessibilityUIElement::increment):
2007         (WTR::AccessibilityUIElement::decrement):
2008         (WTR::AccessibilityUIElement::showMenu):
2009         (WTR::AccessibilityUIElement::press):
2010         (WTR::AccessibilityUIElement::stringAttributeValue):
2011         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2012         (WTR::AccessibilityUIElement::numberAttributeValue):
2013         (WTR::AccessibilityUIElement::boolAttributeValue):
2014         (WTR::AccessibilityUIElement::isAttributeSupported):
2015         (WTR::AccessibilityUIElement::isAttributeSettable):
2016         (WTR::AccessibilityUIElement::isActionSupported):
2017         (WTR::AccessibilityUIElement::role):
2018         (WTR::AccessibilityUIElement::subrole):
2019         (WTR::AccessibilityUIElement::roleDescription):
2020         (WTR::AccessibilityUIElement::title):
2021         (WTR::AccessibilityUIElement::description):
2022         (WTR::AccessibilityUIElement::language):
2023         (WTR::AccessibilityUIElement::stringValue):
2024         (WTR::AccessibilityUIElement::accessibilityValue):
2025         (WTR::AccessibilityUIElement::helpText):
2026         (WTR::AccessibilityUIElement::orientation):
2027         (WTR::AccessibilityUIElement::x):
2028         (WTR::AccessibilityUIElement::y):
2029         (WTR::AccessibilityUIElement::width):
2030         (WTR::AccessibilityUIElement::height):
2031         (WTR::AccessibilityUIElement::intValue):
2032         (WTR::AccessibilityUIElement::minValue):
2033         (WTR::AccessibilityUIElement::maxValue):
2034         (WTR::AccessibilityUIElement::valueDescription):
2035         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2036         (WTR::AccessibilityUIElement::selectedTextRange):
2037         (WTR::AccessibilityUIElement::isEnabled):
2038         (WTR::AccessibilityUIElement::isRequired):
2039         (WTR::AccessibilityUIElement::isFocused):
2040         (WTR::AccessibilityUIElement::isFocusable):
2041         (WTR::AccessibilityUIElement::isSelected):
2042         (WTR::AccessibilityUIElement::isSelectable):
2043         (WTR::AccessibilityUIElement::isMultiSelectable):
2044         (WTR::AccessibilityUIElement::setSelectedChild):
2045         (WTR::AccessibilityUIElement::selectedChildrenCount):
2046         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2047         (WTR::AccessibilityUIElement::isExpanded):
2048         (WTR::AccessibilityUIElement::isChecked):
2049         (WTR::AccessibilityUIElement::isVisible):
2050         (WTR::AccessibilityUIElement::isOffScreen):
2051         (WTR::AccessibilityUIElement::isCollapsed):
2052         (WTR::AccessibilityUIElement::isIgnored):
2053         (WTR::AccessibilityUIElement::hasPopup):
2054         (WTR::AccessibilityUIElement::hierarchicalLevel):
2055         (WTR::AccessibilityUIElement::clickPointX):
2056         (WTR::AccessibilityUIElement::clickPointY):
2057         (WTR::AccessibilityUIElement::documentEncoding):
2058         (WTR::AccessibilityUIElement::documentURI):
2059         (WTR::AccessibilityUIElement::url):
2060         (WTR::AccessibilityUIElement::speak):
2061         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2062         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2063         (WTR::AccessibilityUIElement::attributesOfColumns):
2064         (WTR::AccessibilityUIElement::attributesOfRows):
2065         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2066         (WTR::AccessibilityUIElement::attributesOfHeader):
2067         (WTR::AccessibilityUIElement::indexInTable):
2068         (WTR::AccessibilityUIElement::rowIndexRange):
2069         (WTR::AccessibilityUIElement::columnIndexRange):
2070         (WTR::AccessibilityUIElement::rowCount):
2071         (WTR::AccessibilityUIElement::columnCount):
2072         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2073         (WTR::AccessibilityUIElement::disclosedByRow):
2074         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2075         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2076         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2077         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2078         (WTR::AccessibilityUIElement::ariaDropEffects):
2079         (WTR::AccessibilityUIElement::lineForIndex):
2080         (WTR::AccessibilityUIElement::rangeForLine):
2081         (WTR::AccessibilityUIElement::boundsForRange):
2082         (WTR::AccessibilityUIElement::setSelectedTextRange):
2083         (WTR::AccessibilityUIElement::stringForRange):
2084         (WTR::AccessibilityUIElement::attributedStringForRange):
2085         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2086         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2087         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2088         (WTR::AccessibilityUIElement::horizontalScrollbar):
2089         (WTR::AccessibilityUIElement::verticalScrollbar):
2090         (WTR::AccessibilityUIElement::addNotificationListener):
2091         (WTR::AccessibilityUIElement::removeNotificationListener):
2092         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2093         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2094         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2095         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2096         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2097         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2098         (WTR::AccessibilityUIElement::textMarkerForPoint):
2099         (WTR::AccessibilityUIElement::previousTextMarker):
2100         (WTR::AccessibilityUIElement::nextTextMarker):
2101         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2102         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
2103         (WTR::AccessibilityUIElement::platformUIElement):
2104         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
2105         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
2106         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
2107         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
2108         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2109         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2110         (WTR::InjectedBundle::beginTesting):
2111         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2112         (WTR::InjectedBundle::accessibilityController):
2113         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2114         (WTR::InjectedBundlePage::didClearWindowForFrame):
2115         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2116         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
2117         (WTR::LayoutTestController::platformName):
2118         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
2119         (WTR::AccessibilityTextMarker::isEqual):
2120         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
2121         (WTR::AccessibilityTextMarkerRange::isEqual):
2122         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
2123         (+[NSString stringWithJSStringRef:]):
2124         (-[NSString createJSStringRef]):
2125         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
2126         (-[AccessibilityNotificationHandler dealloc]):
2127         (-[AccessibilityNotificationHandler _notificationReceived:]):
2128         (-[AccessibilityNotificationHandler setCallback:]):
2129         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2130         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
2131         (WTR::AccessibilityUIElement::isEqual):
2132         (WTR::descriptionOfValue):
2133         (WTR::attributesOfElement):
2134         (WTR::concatenateAttributeAndValue):
2135         (WTR::convertNSArrayToVector):
2136         (WTR::descriptionOfElements):
2137         (WTR::AccessibilityUIElement::getLinkedUIElements):
2138         (WTR::AccessibilityUIElement::getDocumentLinks):
2139         (WTR::AccessibilityUIElement::getChildren):
2140         (WTR::AccessibilityUIElement::getChildrenWithRange):
2141         (WTR::AccessibilityUIElement::childrenCount):
2142         (WTR::AccessibilityUIElement::elementAtPoint):
2143         (WTR::AccessibilityUIElement::indexOfChild):
2144         (WTR::AccessibilityUIElement::childAtIndex):
2145         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
2146         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
2147         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
2148         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
2149         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2150         (WTR::AccessibilityUIElement::selectedChildrenCount):
2151         (WTR::AccessibilityUIElement::selectedRowAtIndex):
2152         (WTR::AccessibilityUIElement::titleUIElement):
2153         (WTR::AccessibilityUIElement::parentElement):
2154         (WTR::AccessibilityUIElement::disclosedByRow):
2155         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2156         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
2157         (WTR::AccessibilityUIElement::attributesOfChildren):
2158         (WTR::AccessibilityUIElement::allAttributes):
2159         (WTR::AccessibilityUIElement::stringAttributeValue):
2160         (WTR::AccessibilityUIElement::numberAttributeValue):
2161         (WTR::AccessibilityUIElement::uiElementAttributeValue):
2162         (WTR::AccessibilityUIElement::boolAttributeValue):
2163         (WTR::AccessibilityUIElement::isAttributeSettable):
2164         (WTR::AccessibilityUIElement::isAttributeSupported):
2165         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
2166         (WTR::AccessibilityUIElement::role):
2167         (WTR::AccessibilityUIElement::subrole):
2168         (WTR::AccessibilityUIElement::roleDescription):
2169         (WTR::AccessibilityUIElement::title):
2170         (WTR::AccessibilityUIElement::description):
2171         (WTR::AccessibilityUIElement::orientation):
2172         (WTR::AccessibilityUIElement::stringValue):
2173         (WTR::AccessibilityUIElement::language):
2174         (WTR::AccessibilityUIElement::helpText):
2175         (WTR::AccessibilityUIElement::x):
2176         (WTR::AccessibilityUIElement::y):
2177         (WTR::AccessibilityUIElement::width):
2178         (WTR::AccessibilityUIElement::height):
2179         (WTR::AccessibilityUIElement::clickPointX):
2180         (WTR::AccessibilityUIElement::clickPointY):
2181         (WTR::AccessibilityUIElement::intValue):
2182         (WTR::AccessibilityUIElement::minValue):
2183         (WTR::AccessibilityUIElement::maxValue):
2184         (WTR::AccessibilityUIElement::valueDescription):
2185         (WTR::AccessibilityUIElement::insertionPointLineNumber):
2186         (WTR::AccessibilityUIElement::isActionSupported):
2187         (WTR::AccessibilityUIElement::isEnabled):
2188         (WTR::AccessibilityUIElement::isRequired):
2189         (WTR::AccessibilityUIElement::isFocused):
2190         (WTR::AccessibilityUIElement::isSelected):
2191         (WTR::AccessibilityUIElement::isExpanded):
2192         (WTR::AccessibilityUIElement::isChecked):
2193         (WTR::AccessibilityUIElement::hierarchicalLevel):
2194         (WTR::AccessibilityUIElement::speak):
2195         (WTR::AccessibilityUIElement::ariaIsGrabbed):
2196         (WTR::AccessibilityUIElement::ariaDropEffects):
2197         (WTR::AccessibilityUIElement::lineForIndex):
2198         (WTR::AccessibilityUIElement::rangeForLine):
2199         (WTR::AccessibilityUIElement::boundsForRange):
2200         (WTR::AccessibilityUIElement::stringForRange):
2201         (WTR::AccessibilityUIElement::attributedStringForRange):
2202         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2203         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2204         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2205         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
2206         (WTR::AccessibilityUIElement::attributesOfColumns):
2207         (WTR::AccessibilityUIElement::attributesOfRows):
2208         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
2209         (WTR::AccessibilityUIElement::attributesOfHeader):
2210         (WTR::AccessibilityUIElement::rowCount):
2211         (WTR::AccessibilityUIElement::columnCount):
2212         (WTR::AccessibilityUIElement::indexInTable):
2213         (WTR::AccessibilityUIElement::rowIndexRange):
2214         (WTR::AccessibilityUIElement::columnIndexRange):
2215         (WTR::AccessibilityUIElement::cellForColumnAndRow):
2216         (WTR::AccessibilityUIElement::horizontalScrollbar):
2217         (WTR::AccessibilityUIElement::verticalScrollbar):
2218         (WTR::AccessibilityUIElement::selectedTextRange):
2219         (WTR::AccessibilityUIElement::setSelectedTextRange):
2220         (WTR::AccessibilityUIElement::increment):
2221         (WTR::AccessibilityUIElement::decrement):
2222         (WTR::AccessibilityUIElement::showMenu):
2223         (WTR::AccessibilityUIElement::press):
2224         (WTR::AccessibilityUIElement::setSelectedChild):
2225         (WTR::AccessibilityUIElement::accessibilityValue):
2226         (WTR::AccessibilityUIElement::documentEncoding):
2227         (WTR::AccessibilityUIElement::documentURI):
2228         (WTR::AccessibilityUIElement::url):
2229         (WTR::AccessibilityUIElement::addNotificationListener):
2230         (WTR::AccessibilityUIElement::removeNotificationListener):
2231         (WTR::AccessibilityUIElement::isFocusable):
2232         (WTR::AccessibilityUIElement::isSelectable):
2233         (WTR::AccessibilityUIElement::isMultiSelectable):
2234         (WTR::AccessibilityUIElement::isVisible):
2235         (WTR::AccessibilityUIElement::isOffScreen):
2236         (WTR::AccessibilityUIElement::isCollapsed):
2237         (WTR::AccessibilityUIElement::isIgnored):
2238         (WTR::AccessibilityUIElement::hasPopup):
2239         (WTR::AccessibilityUIElement::takeFocus):
2240         (WTR::AccessibilityUIElement::takeSelection):
2241         (WTR::AccessibilityUIElement::addSelection):
2242         (WTR::AccessibilityUIElement::removeSelection):
2243         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
2244         (WTR::AccessibilityUIElement::textMarkerRangeLength):
2245         (WTR::AccessibilityUIElement::previousTextMarker):
2246         (WTR::AccessibilityUIElement::nextTextMarker):
2247         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2248         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
2249         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
2250         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
2251         (WTR::AccessibilityUIElement::textMarkerForPoint):
2252         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
2253         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
2254         (WTR::LayoutTestController::platformName):
2255         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
2256         (WTR::LayoutTestController::platformName):
2257         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
2258         (WTR::LayoutTestController::platformName):
2259         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2260         * WebKitTestRunner/win/InjectedBundle.vcproj:
2261
2262 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2263
2264         [Qt] Fix use of config.tests
2265
2266         We were checking @buildArgs to determine if the optional argument was
2267         passed or not, but this is not the right way to do that in Perl. The
2268         right way is to not use a prototype for the function, and to pass
2269         the list as a reference (to avoid list expansion). That way we can
2270         check the number of arguments, and choose the right code path based
2271         on that.
2272
2273         We were also missing a default-value of 0 for any feature that's not
2274         set in features.prf.
2275
2276         Reviewed by Kenneth Rohde Christiansen.
2277
2278         * Scripts/build-webkit:
2279         * Scripts/webkitdirs.pm:
2280         (qtFeatureDefaults):
2281         (buildQMakeProject):
2282
2283 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2284
2285         [Qt] Prospective fix for broken plugin tests
2286
2287         Don't hide symbols for the NPAPI test plugin
2288
2289         Rubber-stamped by Andreas Kling.
2290
2291         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2292
2293 2011-11-16  Adam Roben  <aroben@apple.com>
2294
2295         Move filenames/line numbers off to the right edge in Leaks Viewer
2296
2297         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
2298         because filenames/line numbers are right next to function names
2299
2300         Reviewed by Andreas Kling.
2301
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
2303         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
2304         function name. Use the filename as the profile node's URL (we don't have enough info to
2305         compute a real URL currently) and the line number as the profile node's line number so the
2306         Inspector code will put them on the right side of the callstack graph.
2307
2308         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2309         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
2310         passed here, just filenames.
2311
2312         (WebInspector.linkifyURLAsNode):
2313         (WebInspector.linkifyResourceAsNode):
2314         Copied and slightly modified from inspector.js.
2315
2316 2011-11-16  Adam Roben  <aroben@apple.com>
2317
2318         Make Leaks Viewer load builds from the new Lion Leaks bot
2319
2320         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
2321
2322         Reviewed by Andreas Kling.
2323
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2325         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
2326         SnowLeopard one.
2327
2328 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
2329
2330         [EFL] Clean up the offline apps-related functions in ewk_settings.
2331         https://bugs.webkit.org/show_bug.cgi?id=72132
2332
2333         Reviewed by Kenneth Rohde Christiansen.
2334
2335         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
2336         prefixes for code that is related only to the HTML5 app cache
2337         features.
2338
2339         Use `ewk_settings_application_cache' and
2340         `ewk_view_setting_application_cache' instead.
2341
2342         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2343         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2344
2345 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2346
2347         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2348
2349         Reviewed by Tor Arne Vestbø.
2350
2351         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2352         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
2353         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
2354         removes the .so.0.0.0 and just produces .so.
2355
2356 2011-11-16  Peter Beverloo  <peter@chromium.org>
2357
2358         Explicitly include unistd.h in TestNetscapePlugIn
2359         https://bugs.webkit.org/show_bug.cgi?id=72385
2360
2361         This is needed for the sleep() call in the indicateTestFailure method,
2362         which seems to be implicitly available for other platforms. This is not
2363         the case on Android.
2364
2365         Reviewed by Steve Block.
2366
2367         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2368
2369 2011-11-16  Peter Beverloo  <peter@chromium.org>
2370
2371         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
2372         https://bugs.webkit.org/show_bug.cgi?id=72384
2373
2374         Update to Android NDK r7, which was released last Friday. This adds
2375         support for RTTI and the -mimplicit-it gcc flag, which are required to
2376         respectively build ICU and Skia.
2377
2378         Reviewed by Steve Block.
2379
2380         * Scripts/update-webkit-chromium:
2381         * Scripts/webkitdirs.pm:
2382         (buildChromiumMakefile):
2383
2384 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
2385
2386         Unreviewed, rolling out r100266.
2387         http://trac.webkit.org/changeset/100266
2388
2389         Broke WTR.
2390
2391         * qmake/mkspecs/features/default_post.prf:
2392
2393 2011-11-16  Eric Seidel  <eric@webkit.org>
2394
2395         check-webkit-style broken by r99773: "Could not determine the port"
2396         https://bugs.webkit.org/show_bug.cgi?id=72275
2397
2398         Reviewed by Adam Barth.
2399
2400         I will continue engaging hacks, until windows improves.
2401
2402         * Scripts/webkitpy/common/host.py:
2403          - Host uses self.executive instead of self._executive like Port does.
2404          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
2405
2406 2011-11-16  Eric Seidel  <eric@webkit.org>
2407
2408         check-webkit-style broken by r99773: "Could not determine the port"
2409         https://bugs.webkit.org/show_bug.cgi?id=72275
2410
2411         Reviewed by Adam Barth.
2412
2413         Engage windows hacks harder.
2414
2415         This is a speculative fix for ChromiumWin.  We're now
2416         creating an SCM object much earlier, so we need to
2417         engage our "awesome" windows hacks earlier.
2418
2419         * Scripts/webkitpy/common/host.py:
2420         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2421
2422 2011-11-15  Darin Adler  <darin@apple.com>
2423
2424         DRT's uiElementAttributeValueCallback function is leaky
2425         https://bugs.webkit.org/show_bug.cgi?id=72453
2426
2427         Reviewed by Dan Bernstein.
2428
2429         * DumpRenderTree/AccessibilityUIElement.cpp:
2430         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
2431
2432 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2433
2434         Implement edit-distance based reviewer recognition algorithm
2435         https://bugs.webkit.org/show_bug.cgi?id=72351
2436
2437         Reviewed by Eric Seidel.
2438
2439         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
2440         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
2441         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
2442         "build fix" to a reviewer's name (e.g. with with edit distance 9).
2443
2444         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
2445         the edit distance is implemented in edit_distance.py.
2446
2447         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
2448         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
2449
2450         * Scripts/webkitpy/common/checkout/changelog.py:
2451         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2452         * Scripts/webkitpy/common/config/committers.py:
2453         * Scripts/webkitpy/common/config/committers_unittest.py:
2454         * Scripts/webkitpy/common/editdistance.py: Added.
2455         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
2456         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2457         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
2458
2459 2011-11-15  Tony Chang  <tony@chromium.org>
2460
2461         Skip a failing webkitpy test on cygwin.
2462
2463         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2464
2465 2011-11-15  Sam Weinig  <sam@webkit.org>
2466
2467         TestWebKitAPI should not put its resources in the root products directory
2468         https://bugs.webkit.org/show_bug.cgi?id=72446
2469
2470         Reviewed by Anders Carlsson.
2471
2472         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2473         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
2474         directory.
2475
2476         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2477         (TEST_F):
2478         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2479         (TestWebKitAPI::TEST):
2480         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2481         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
2482         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2483         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
2484         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2485         (TestWebKitAPI::Util::createURLForResource):
2486         Update calls to retrieve files from the bundle to look in the newly
2487         created subdirectory.
2488
2489 2011-11-15  Tony Chang  <tony@chromium.org>
2490
2491         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
2492
2493         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2494
2495 2011-11-15  Tony Chang  <tony@chromium.org>
2496
2497         Unreviewed, fix test-webkitpy tests.  Move the check for image results
2498         earlier.
2499
2500         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2501         * Scripts/webkitpy/layout_tests/port/webkit.py:
2502
2503 2011-11-15  James Robinson  <jamesr@chromium.org>
2504
2505         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
2506         https://bugs.webkit.org/show_bug.cgi?id=72444
2507
2508         Reviewed by Adam Barth.
2509
2510         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2511
2512 2011-11-15  Tony Chang  <tony@chromium.org>
2513
2514         Unreviewed, better fix for ref tests failures on SL Intel bot.
2515         Revert the previous change and return None if pixel results from
2516         either the test page or the expected page is missing.
2517
2518         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2519         * Scripts/webkitpy/layout_tests/port/webkit.py:
2520
2521 2011-11-15  James Robinson  <jamesr@chromium.org>
2522
2523         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
2524         https://bugs.webkit.org/show_bug.cgi?id=72402
2525
2526         Reviewed by Dirk Pranke.
2527
2528         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
2529         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
2530         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
2531         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
2532         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
2533         compositing enabled.
2534
2535         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
2536         patch should not impact any tests.
2537
2538         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2539         (main):
2540         * DumpRenderTree/chromium/TestShell.cpp:
2541         (TestShell::TestShell):
2542         (TestShell::resetWebSettings):
2543         * DumpRenderTree/chromium/TestShell.h:
2544         (TestShell::setAcceleratedCompositingForVideoEnabled):
2545         * DumpRenderTree/chromium/WebPreferences.cpp:
2546         (WebPreferences::reset):
2547         (WebPreferences::applyTo):
2548         * DumpRenderTree/chromium/WebPreferences.h:
2549         * Scripts/webkitpy/layout_tests/port/chromium.py:
2550         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2551         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2552
2553 2011-11-15  Tony Chang  <tony@chromium.org>
2554
2555         Unreviewed, try to fix ref tests failures on SL Intel bot.
2556         It looks like ImageDiff isn't returning an image diff.
2557
2558         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2559
2560 2011-11-15  Tony Chang  <tony@chromium.org>
2561
2562         Unreviewed fix of ref-tests on GTK+.
2563         If a driver is never started, _xvfb_process is never set.
2564
2565         * Scripts/webkitpy/layout_tests/port/gtk.py:
2566
2567 2011-11-14  Tony Chang  <tony@chromium.org>
2568
2569         [NRWT] Reftests should run even when pixel tests are disabled.
2570         https://bugs.webkit.org/show_bug.cgi?id=60605
2571
2572         Reviewed by Dirk Pranke.
2573
2574         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
2575             Also add an assert to make sure we get image hashes back when running ref tests.
2576         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
2577         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2578         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
2579         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
2580             of starting a pixel driver if needed.  It handles the logic of sending the test
2581             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
2582         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2583         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
2584         * Scripts/webkitpy/layout_tests/port/webkit.py:
2585         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
2586         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
2587
2588 2011-11-15  David Kilzer  <ddkilzer@apple.com>
2589
2590         Don't use File::Slurp for run-leaks unit tests
2591         <http://webkit.org/b/72356>
2592
2593         Reviewed by Daniel Bates.
2594
2595         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
2596         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
2597         Extracted common package logic into RunLeaks.pm.  Fixed call to
2598         RunLeaks::parseLeaksOutput().
2599         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
2600         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
2601
2602 2011-11-15  Peter Kasting  <pkasting@google.com>
2603
2604         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
2605         https://bugs.webkit.org/show_bug.cgi?id=72349
2606
2607         Reviewed by Adam Roben.
2608
2609         * Scripts/VCSUtils.pm:
2610         (isSVNDirectory):
2611
2612 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2613
2614         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
2615
2616         Reviewed by Tor Arne Vestbø.
2617
2618         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
2619         magic here where we handle all TEMPLATE = lib .pro files.
2620
2621 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2622
2623         [Qt] Unreviewed prospective --minimal build fix.
2624
2625         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
2626         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
2627
2628 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
2629
2630         [Qt] Unreviewed --minimal build fix.
2631
2632         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
2633         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
2634         to make moc's preprocessor abort.
2635
2636 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
2637
2638         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
2639         https://bugs.webkit.org/show_bug.cgi?id=72156
2640
2641         Reviewed by Daniel Bates.
2642
2643         Similar to --makearg and --qmakearg, --cmakearg lets one pass
2644         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
2645
2646         * Scripts/build-webkit:
2647         * Scripts/webkitdirs.pm:
2648         (generateBuildSystemFromCMakeProject):
2649
2650 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
2651
2652         Improve ChangeLogEntry's reviewer parsing algorithm part 2
2653         https://bugs.webkit.org/show_bug.cgi?id=72340
2654
2655         Reviewed by Eric Seidel.
2656
2657         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
2658         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
2659
2660         * Scripts/webkitpy/common/checkout/changelog.py:
2661         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2662
2663 2011-11-14  Eric Seidel  <eric@webkit.org>
2664
2665         check-webkit-style broken by r99773: "Could not determine the port"
2666         https://bugs.webkit.org/show_bug.cgi?id=72275
2667
2668         Reviewed by Adam Barth.
2669
2670         The TestExpectationsChecker was using a generic try/except block
2671         which caught all exceptions, so we didn't notice that failing
2672         to pass a Host to PortFactory was causing an exception in port instantiation.
2673         I've factored out the "lookup the port" logic into a separate function
2674         which I've now unittested.  This should fix the bug and prevent
2675         others like it from occuring the the future.
2676
2677         * Scripts/webkitpy/style/checkers/test_expectations.py:
2678         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2679
2680 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2681
2682         Add --css-grid-layout to build-webkit and the build systems
2683         https://bugs.webkit.org/show_bug.cgi?id=72320
2684
2685         Reviewed by Ojan Vafai.
2686
2687         * Scripts/build-webkit:
2688         Added the option.
2689
2690 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2691
2692         Unreviewed, rolling out r100192.
2693         http://trac.webkit.org/changeset/100192
2694         https://bugs.webkit.org/show_bug.cgi?id=72328
2695
2696         Caused infinite tests to fail (Requested by abarth on
2697         #webkit).
2698
2699         * Scripts/webkitpy/layout_tests/port/base.py:
2700         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2701
2702 2011-11-14  Tony Chang  <tony@chromium.org>
2703
2704         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
2705         https://bugs.webkit.org/show_bug.cgi?id=72196
2706
2707         Reviewed by Ojan Vafai.
2708
2709         * Scripts/build-webkit:
2710
2711 2011-11-14  John Yani  <vanuan@gmail.com>
2712
2713         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
2714         Override LOCALE to en_US.
2715
2716         Reviewed by Eric Seidel.
2717
2718         * Scripts/webkitpy/layout_tests/port/base.py:
2719
2720 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
2721
2722         [Chromium] build-webkit silently drops the features flags
2723         https://bugs.webkit.org/show_bug.cgi?id=72293
2724
2725         Reviewed by Tony Chang.
2726
2727         Chromium still ignores @features but now we give a warning!
2728
2729         * Scripts/build-webkit: Check if one of the features is different
2730         from the default and print a warning in this case.
2731
2732 2011-11-14  David Kilzer  <ddkilzer@apple.com>
2733
2734         run-leaks does not work on Lion?
2735         <http://webkit.org/b/71059>
2736         <rdar://problem/10428527>
2737
2738         Reviewed by Adam Roben.
2739
2740         The output of leaks(1) changed again in Lion to move the
2741         "leaks Report Version: 2.0" line from the first line of the
2742         output to just above the "Process " lines that run-leaks is
2743         interested in parsing.  This required using a more generic
2744         algorithm to find the start of the "Process " lines.
2745
2746         * Scripts/run-leaks:
2747         (parseLeaksOutput): Make the code to skip headers more generic.
2748         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
2749         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
2750         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
2751
2752 2011-11-14  Lei Zhang  <thestig@chromium.org>
2753
2754         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
2755         https://bugs.webkit.org/show_bug.cgi?id=72088
2756
2757         Reviewed by Tony Chang.
2758
2759         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2760
2761 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
2762
2763         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
2764         https://bugs.webkit.org/show_bug.cgi?id=72147
2765
2766         Reviewed by Adam Barth.
2767
2768         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2769
2770 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2771
2772         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
2773
2774         Reviewed by Simon Hausmann.
2775
2776         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
2777
2778 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
2779
2780         [Qt] Disable plugins on X11 for WK2
2781
2782         Reviewed by Kenneth Rohde Christiansen.
2783
2784         Currently plugins are in-process and they crash in the likely case of
2785         a plugin installation that uses Qt 4, which beautifully clashes with the
2786         Qt 5 based QtWebProcess.
2787
2788         * qmake/mkspecs/features/features.prf:
2789
2790 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2791
2792         [Qt] Add support for config tests for Qt 5
2793
2794         This allows us to build and run configure-tests at build
2795         time to determine if a given platform feature is available.
2796
2797         Reviewed by Simon Hausmann.
2798
2799         * Scripts/build-webkit:
2800         * Scripts/webkitdirs.pm:
2801         (qtFeatureDefaults):
2802         * qmake/configure.pro: Added.
2803         * qmake/mkspecs/features/features.prf:
2804         * qmake/sync.profile: Added.
2805
2806 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
2807
2808         [Qt] Remove the QStyle dependency in Qt's mobile theme
2809         https://bugs.webkit.org/show_bug.cgi?id=67773
2810
2811         This refactoring splits up RenderThemeQt with two
2812         subclasses, a QStyle-backed one, and a Mobile version
2813         that uses the old mobile theme for now.
2814
2815         QStyle availability is detected at compile time, and
2816         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
2817         environment variable.
2818
2819         Reviewed by Simon Hausmann.
2820
2821         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2822         (WTR::activateFonts):
2823         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
2824         based on availability of QtWidgets.
2825         * qmake/mkspecs/features/webcore.prf: cleanup.
2826
2827 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2828
2829         Unreviewed, rolling out r100116.
2830         http://trac.webkit.org/changeset/100116
2831
2832         r100104 was rolled out, so no longer needed
2833
2834         * Scripts/run-bindings-tests:
2835
2836 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
2837
2838         Unreviewed, rolling out r100104.
2839         http://trac.webkit.org/changeset/100104
2840         https://bugs.webkit.org/show_bug.cgi?id=72247
2841
2842         broke windows builds
2843
2844         * Scripts/check-webkit-style:
2845         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2846         * Scripts/webkitpy/common/checkout/deps.py:
2847         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2848         * Scripts/webkitpy/common/checkout/scm/detection.py:
2849         * Scripts/webkitpy/common/checkout/scm/git.py:
2850         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2851         * Scripts/webkitpy/common/checkout/scm/svn.py:
2852         * Scripts/webkitpy/common/host.py:
2853         * Scripts/webkitpy/common/host_mock.py:
2854         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2855         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2856         * Scripts/webkitpy/layout_tests/port/base.py:
2857         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2859         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2860         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2861
2862 2011-11-14  Philippe Normand  <pnormand@igalia.com>
2863
2864         Unreviewed, build fix after r100104. run-binding-tests broke.
2865
2866         * Scripts/run-bindings-tests: Explicitely use scm.detection.
2867
2868 2011-11-13  Eric Seidel  <eric@webkit.org>
2869
2870         Add SCMDetector object to make scm detection mockable
2871         https://bugs.webkit.org/show_bug.cgi?id=72247
2872
2873         Reviewed by Adam Barth.
2874
2875         I think SCM detection may eventually be rolled into Checkout,
2876         but this patch at least makes it possible to mock code-paths
2877         which rely on scm detection.
2878         In the process of replacing callers of these free-functions
2879         I found that one of the functions was no longer used,
2880         and that one of the callers could instead just use the SCM
2881         object it already had access to through port.host.scm().
2882         I also discovered that I was not calling Host._initialize_scm()
2883         and thus host.scm() was always returning None!
2884
2885         * Scripts/check-webkit-style:
2886         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2887         * Scripts/webkitpy/common/checkout/deps.py:
2888         * Scripts/webkitpy/common/checkout/scm/__init__.py:
2889         * Scripts/webkitpy/common/checkout/scm/detection.py:
2890         * Scripts/webkitpy/common/checkout/scm/git.py:
2891         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2892         * Scripts/webkitpy/common/checkout/scm/svn.py:
2893         * Scripts/webkitpy/common/host.py:
2894         * Scripts/webkitpy/common/host_mock.py:
2895         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2896         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2897         * Scripts/webkitpy/layout_tests/port/base.py:
2898         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2899         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2900         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2901         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2902
2903 2011-11-13  Gavin Peters  <gavinp@chromium.org>
2904
2905         command line control of webcore log channels in chromium DumpRenderTree
2906         https://bugs.webkit.org/show_bug.cgi?id=72126
2907         
2908         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
2909         what chromium takes.
2910
2911         Reviewed by Kent Tamura.
2912
2913         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2914         (main):
2915
2916 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
2917
2918         [Qt] Fix minor config typo in the build tool documentation
2919         https://bugs.webkit.org/show_bug.cgi?id=72194
2920
2921         Reviewed by Andreas Kling.
2922
2923         * qmake/README:
2924
2925 2011-11-11  Stephen Chenney  <schenney@chromium.org>
2926
2927         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
2928         https://bugs.webkit.org/show_bug.cgi?id=49257
2929
2930         Adds the remaining missing layout test functionality for printing.
2931
2932         Reviewed by Darin Fisher.
2933
2934         * DumpRenderTree/chromium/LayoutTestController.cpp:
2935         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
2936         (parsePageNumber): Method to parse JS arguments for a page number
2937         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
2938         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
2939         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
2940         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
2941         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
2942
2943 2011-11-11  Darin Adler  <darin@apple.com>
2944
2945         Remove all releaseRef implementations except for RetainPtr
2946         https://bugs.webkit.org/show_bug.cgi?id=71423
2947
2948         Reviewed by Julien Chaffraix.
2949
2950         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
2951         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
2952
2953 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
2954
2955         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
2956         https://bugs.webkit.org/show_bug.cgi?id=72090
2957
2958         Reviewed by Eric Seidel.
2959
2960         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
2961         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
2962
2963         yay! r100002.
2964
2965         * Scripts/webkitpy/common/checkout/changelog.py:
2966         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2967
2968 2011-11-11  Tony Chang  <tony@chromium.org>
2969
2970         Remove --force from gclient sync.  The bots seem to have made it past
2971         the update step.
2972
2973         * Scripts/update-webkit:
2974
2975 2011-11-11  Tony Chang  <tony@chromium.org>
2976
2977         Add --force to gclient sync. Once the cq bots cycle, we can remove
2978         this since it slows down the normal sync.
2979
2980         * Scripts/update-webkit:
2981
2982 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
2983
2984         When --force is used, also use --reset
2985         https://bugs.webkit.org/show_bug.cgi?id=72129
2986
2987         Reviewed by Dimitri Glazkov.
2988
2989         * Scripts/update-webkit-chromium:
2990
2991 2011-11-11  Tony Chang  <tony@chromium.org>
2992
2993         allow two chromium drivers to run at the same time in NRWT
2994         https://bugs.webkit.org/show_bug.cgi?id=72067
2995
2996         Reviewed by Dirk Pranke.
2997
2998         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
2999             posix prevents the subprocesses from sharing the same fd for stdin.
3000             Sharing the same fd prevents us from closing the files unless all references
3001             to the fd are closed.
3002         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
3003             to adding a test for this, speed up a test (from 3sec to 0) by fixing
3004             the timeout override. It looks like it regressed in r95875.
3005
3006 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
3007
3008         Unreviewed, rolling out r99964.
3009         http://trac.webkit.org/changeset/99964
3010         https://bugs.webkit.org/show_bug.cgi?id=72124
3011
3012         Broke too many Qt tests (Requested by tronical_ on #webkit).
3013
3014         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3015         (WTR::activateFonts):
3016         * qmake/mkspecs/features/features.prf:
3017         * qmake/mkspecs/features/webcore.prf:
3018
3019 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
3020
3021         [Qt] Remove the QStyle dependency in Qt's mobile theme
3022         https://bugs.webkit.org/show_bug.cgi?id=67773
3023
3024         This refactoring splits up RenderThemeQt with two
3025         subclasses, a QStyle-backed one, and a Mobile version
3026         that uses the old mobile theme for now.
3027
3028         QStyle availability is detected at compile time, and
3029         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
3030         environment variable.
3031
3032         Reviewed by Simon Hausmann.
3033
3034         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3035         (WTR::activateFonts):
3036         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
3037         based on availability of QtWidgets.
3038         * qmake/mkspecs/features/webcore.prf: cleanup.
3039
3040 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3041
3042         [Qt] Add missing include to PlatformWebViewQt
3043
3044         Reviewed by Simon Hausmann.
3045
3046         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3047
3048 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3049
3050         [Qt] Fix incremental builds on Windows after buildsystem refactor
3051
3052         The qmake rules to ensure that we run make on the derived sources
3053         before running qmake on the target were inside a unix-scope, which
3054         resulted in flakey builds on Windows.
3055
3056         We now generate a rule on all platforms that ensures that "make qmake"
3057         will always run make on the derived sources. In addition, on platforms
3058         that have GNU make (where "make incremental" does not run "make qmake",
3059         but only "make"), we add a similar rule that ensures that any time the
3060         target makefile is regenerated we first run qmake and make on the derived
3061         sources. This rule relies on GNU make's order-only-prerequisites to
3062         not trigger a qmake-run of the target every time we run make.
3063
3064         https://bugs.webkit.org/show_bug.cgi?id=71778
3065
3066         Reviewed by Simon Hausmann.
3067
3068         * qmake/mkspecs/features/functions.prf:
3069
3070 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3071
3072         [Qt][WK2] Remove QWebNavigationController
3073         https://bugs.webkit.org/show_bug.cgi?id=72113
3074
3075         Reviewed by Andreas Kling.
3076
3077         Adapt to the move of the QWebNavigationController functions/properties to
3078         QQuickWebView.
3079
3080         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3081         * MiniBrowser/qt/qml/BrowserWindow.qml:
3082
3083 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3084
3085         [Qt] Build system tweak
3086
3087         Reviewed by Tor Arne Vestbø.
3088
3089         Be a good qmake citizen, return true from our linkStaticLibrary
3090         "test" function.
3091
3092         * qmake/mkspecs/features/functions.prf:
3093
3094 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
3095
3096         [Qt] Add support for QT += webkit-private
3097
3098         Reviewed by Tor Arne Vestbø.
3099
3100         * qmake/qt_webkit.pri: Declare private headers.
3101
3102 2011-11-11  Philippe Normand  <pnormand@igalia.com>
3103
3104         Unreviewed, build fix attempt after r99907. Since that revision
3105         GTK layout tests were not running at all...
3106
3107         * Scripts/webkitpy/layout_tests/port/gtk.py:
3108
3109 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
3110
3111         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
3112         https://bugs.webkit.org/show_bug.cgi?id=72001
3113
3114         Reviewed by Dirk Pranke.
3115
3116         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3117
3118 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
3119
3120         bencher script should support remote benchmarking
3121         https://bugs.webkit.org/show_bug.cgi?id=71618
3122
3123         Rubber-stamped by Geoff Garen.
3124         
3125         Added the following features:
3126         
3127         - Benchmark report tells you the hostname and machine model (according to
3128           'sysctl hw.model') of the machine you did the run on, and svn revision number
3129           (according to 'svn info') of the VMs you're testing.
3130         
3131         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
3132           acceptable, in addition to just host, in which case your username is used)
3133           and it automatically packages the build directories of the VMs you're testing,
3134           sends them to the remote machine along with your copy of the bencher script
3135           and all of the options you passed.  This pretty much seamlessly allows you
3136           to run a set of benchmarks on any machine that is sufficiently compatible with
3137           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
3138           must now include a tempPath setting that tells bencher where to put files
3139           when that machine is used as a slave in a remote benchmarking run.
3140           
3141         - Added yet another way of specifying which benchmarks to run. This was sort of
3142           necessary for --remote to work as expected. Previously, you either said what
3143           suites to exclude (for example --exclude-sunspider) or that you only wanted
3144           to run one suite to the exclusion of others (--sunspider-only). But it's
3145           often better to just be able to specify the list of suites you want. This is
3146           now supported. You can say, for example, --v8 --sunspider, which means, just
3147           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
3148           still supported.
3149
3150         * Scripts/bencher:
3151
3152 2011-11-10  Tony Chang  <tony@chromium.org>
3153
3154         Lazily start DRT instances in NRWT
3155         https://bugs.webkit.org/show_bug.cgi?id=72038
3156
3157         Reviewed by Eric Seidel.
3158
3159         Just a refactoring, no new tests.
3160
3161         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3162         * Scripts/webkitpy/layout_tests/port/chromium.py:
3163         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3164         * Scripts/webkitpy/layout_tests/port/test.py:
3165         * Scripts/webkitpy/layout_tests/port/webkit.py:
3166
3167 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
3168
3169         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
3170         https://bugs.webkit.org/show_bug.cgi?id=72057
3171
3172         Reviewed by Eric Seidel.
3173
3174         Make the regular expression more explicit.
3175
3176         * Scripts/webkitpy/common/checkout/changelog.py:
3177         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3178
3179 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
3180
3181         [Qt] X11 plugins need to be reworked for Qt5
3182         https://bugs.webkit.org/show_bug.cgi?id=70023
3183
3184         Reviewed by Simon Hausmann.
3185
3186         Rework our basic plugin support in a way that does
3187         not need a bridge between Qt and X. The solution is
3188         based on getting the content drawed by the plugin
3189         from the server as an image and creating a QImage
3190         from it.
3191
3192         * qmake/mkspecs/features/features.prf: Enable X11
3193         plugins if Qt is built with the xcb-xlib backend.
3194
3195 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
3196
3197         [Qt] Fix keyboard related layout tests after API refactoring
3198
3199         Reviewed by Tor Arne Vestbø.
3200
3201         Send key events to the handling page item, not the view.
3202
3203         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3204         (WTR::PlatformWebView::sendEvent):
3205         (WTR::PlatformWebView::postEvent):
3206
3207 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
3208
3209         [GTK] Make the ENABLE(FEATURE) macro work in DRT
3210         https://bugs.webkit.org/show_bug.cgi?id=71940
3211
3212         Reviewed by Philippe Normand.
3213
3214         * GNUmakefile.am:
3215         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
3216         ENABLE_* variables are part of the environment.
3217
3218 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
3219
3220         [Qt] Fix focus related layout tests after API refactoring
3221
3222         Reviewed by Tor Arne Vestbø.
3223
3224         Make sure the focus is set on the page now, not on the view
3225         (which doesn't actually handle the focus).
3226
3227         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3228         (WTR::WrapperWindow::WrapperWindow):
3229         (WTR::WrapperWindow::handleStatusChanged):
3230
3231 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
3232
3233         [Qt] Merge QTouchWebView and QDesktopWebView into one class
3234         https://bugs.webkit.org/show_bug.cgi?id=71355
3235
3236         Reviewed by Kenneth Rohde Christiansen.
3237
3238         Make MiniBrowser and WebKitTestRunner work again after the
3239         merge.
3240
3241         * MiniBrowser/qt/BrowserWindow.cpp:
3242         (BrowserWindow::BrowserWindow):
3243         (BrowserWindow::webView):
3244         * MiniBrowser/qt/MiniBrowser.pro:
3245         * MiniBrowser/qt/MiniBrowser.qrc:
3246         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3247         * MiniBrowser/qt/main.cpp:
3248         * MiniBrowser/qt/qml/BrowserWindow.qml:
3249         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
3250         * MiniBrowser/qt/qml/TouchView.qml: Removed.
3251         * WebKitTestRunner/PlatformWebView.h:
3252         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3253         (WTR::PlatformWebView::PlatformWebView):
3254
3255 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3256
3257         [Qt] Change semantics of the haveQt() function to match API promises
3258
3259         Having Qt 5 does not imply that we have Qt 4, from an API point of
3260         view, as a major version can in theory break BC/SC. Our minimum
3261         version of Qt 4 will always be the latest released version of Qt 4,
3262         so the only place we should use haveQt(4, x) is when checking for
3263         the minimum requirements.
3264
3265         Reviewed by Simon Hausmann.
3266
3267         * qmake/mkspecs/features/default_pre.prf:
3268         * qmake/mkspecs/features/features.prf:
3269         * qmake/mkspecs/features/functions.prf:
3270
3271 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
3272
3273         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
3274         https://bugs.webkit.org/show_bug.cgi?id=69411
3275
3276         Reviewed by Martin Robinson.
3277
3278         * WebKitTestRunner/EventSenderProxy.h:
3279         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3280         * WebKitTestRunner/TestController.cpp:
3281         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3282         use the EventSender instead of WebProcess Event Simulation.
3283         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3284         (WTR::WTREventQueueItem::WTREventQueueItem):
3285         (WTR::EventSenderProxy::EventSenderProxy):
3286         (WTR::getMouseButtonModifiers):
3287         (WTR::eventSenderButtonToGDKButton):
3288         (WTR::EventSenderProxy::createMouseButtonEvent):
3289         (WTR::EventSenderProxy::updateClickCountForButton):
3290         (WTR::EventSenderProxy::replaySavedEvents):
3291         (WTR::EventSenderProxy::sendOrQueueEvent):
3292         (WTR::webkitModifiersToGDKModifiers):
3293         (WTR::getGDKKeySymForKeyRef):
3294         (WTR::EventSenderProxy::keyDown):
3295         (WTR::EventSenderProxy::mouseDown):
3296         (WTR::EventSenderProxy::mouseUp):
3297         (WTR::EventSenderProxy::mouseMoveTo):
3298         (WTR::EventSenderProxy::mouseScrollBy):
3299         (WTR::EventSenderProxy::leapForward):
3300
3301 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3302
3303         [Qt] Enable exports and constructor functions in static libs
3304
3305         Reviewed by Tor Arne Vestbø.
3306
3307         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3308         mac/win32-msvc equivalents when linking static libraries into a shared
3309         library or executable.
3310
3311 2011-11-09  Hayato Ito  <hayato@chromium.org>
3312
3313         [NRWT] Make results.html aware of reference filename in reftests.
3314         https://bugs.webkit.org/show_bug.cgi?id=71574
3315
3316         Reviewed by Ryosuke Niwa.
3317
3318         If a reference filename is different from the default one, include that in result summary
3319         so results.html can link to the correct reference file.
3320
3321         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3322         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3323
3324 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3325
3326         [wx] Unreviewed build fix. Update project files and
3327         add LTC stubs for new methods.
3328
3329         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3330         (LayoutTestController::addChromeInputField):
3331         (LayoutTestController::removeChromeInputField):
3332         (LayoutTestController::focusWebView):
3333         (LayoutTestController::setBackingScaleFactor):
3334         * waf/build/settings.py:
3335
3336 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
3337
3338         [wx] Unreviewed build fix. Support XCode 4 when building deps.
3339
3340         * wx/install-unix-extras:
3341
3342 2011-11-09  Eric Seidel  <eric@webkit.org>
3343
3344         Remove the concept of platform-dependent unittests
3345         https://bugs.webkit.org/show_bug.cgi?id=71963
3346
3347         Unreviewed.  Fix test-webkitpy on cygwin.
3348
3349         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3350
3351 2011-11-09  Dana Jansens  <danakj@chromium.org>
3352
3353         Add cc-bugs group to watch changes in chromium graphics
3354         https://bugs.webkit.org/show_bug.cgi?id=71690
3355
3356         Reviewed by David Levin.
3357
3358         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
3359         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
3360         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
3361         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
3362
3363 2011-11-09  Eric Seidel  <eric@webkit.org>
3364
3365         Remove more platform-dependent unittests
3366         https://bugs.webkit.org/show_bug.cgi?id=71971
3367
3368         Reviewed by Adam Barth.
3369
3370         Tests which only run on a couple platforms will break.
3371         All tests should run on all platforms where possible.
3372
3373         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3374         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3375         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3376         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3377
3378 2011-11-09  Ojan Vafai  <ojan@chromium.org>
3379
3380         Merge in results to the test results server even if build numbers conflict
3381         https://bugs.webkit.org/show_bug.cgi?id=71967
3382
3383         Reviewed by Tony Chang.
3384
3385         This was initially meant to be a sanity check that we don't
3386         enter duplicate runs, but it turns out that we can reasonably get
3387         in these situations when a builder is clobbered (e.g. the build
3388         numbers start over again from 0).
3389
3390         * TestResultServer/model/jsonresults.py:
3391         * TestResultServer/model/jsonresults_unittest.py:
3392
3393 2011-11-09  Eric Seidel  <eric@webkit.org>
3394
3395         Remove the concept of platform-dependent unittests
3396         https://bugs.webkit.org/show_bug.cgi?id=71963
3397
3398         Reviewed by Adam Barth.
3399
3400         These have been the source of never-ending sadness.
3401         We'd change behavior and forget to update results in
3402         some unittests because they were only run on certain platforms.
3403         This change removes a large source of these platform-dependent
3404         unittests, which was caused by the port_maker stuff.
3405
3406         It's possible that this change will break test-webkitpy
3407         on some platforms, but that will be a one-time cost.
3408         I will fix the breakage by removing the platform-dependantness
3409         of any such broken tests.
3410
3411         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3412         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3413         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3414         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3415         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3416         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3417         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3418         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3419         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3420         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3421         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3422         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3423         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3424
3425 2011-11-09  Eric Seidel  <eric@webkit.org>
3426
3427         Make the Port object have a Host
3428         https://bugs.webkit.org/show_bug.cgi?id=71961
3429
3430         Reviewed by Adam Barth.
3431
3432         This has been a long time coming.
3433         Now that Port has a Host object, it's very easy
3434         to write unittests which use a properly mocked Port.
3435         Soon we will remove the executive, filesystem and user
3436         members of Port and get everything through the Host.
3437
3438         Note how in many callsites we're actually removing
3439         explicit mocks, since we're now always going to get the
3440         correct Executive/User/FileSystem from the
3441         Host and callsites don't need to be careful to pass each one.
3442
3443         This is prep-work for adding a new Environment member to
3444         Host and needing to be able to access the Environment
3445         member from Port functions w/o needing to pass an Environment
3446         object (or appropriate Mock) every place we create a Port object.
3447         Now that we have a single Host object to reach out through, its
3448         simple to add additional functionality (like Environment) while
3449         keeping our unittests properly mocked.
3450
3451         * Scripts/webkitpy/common/host.py:
3452         * Scripts/webkitpy/common/net/credentials_unittest.py:
3453         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3454         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3455         * Scripts/webkitpy/layout_tests/port/apple.py:
3456         * Scripts/webkitpy/layout_tests/port/base.py:
3457         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3458         * Scripts/webkitpy/layout_tests/port/chromium.py:
3459         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3460         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3461         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3462         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
3463         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3464         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3465         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3466         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3467         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3468         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3469         * Scripts/webkitpy/layout_tests/port/efl.py:
3470         * Scripts/webkitpy/layout_tests/port/factory.py:
3471         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3472         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3473         * Scripts/webkitpy/layout_tests/port/gtk.py:
3474         * Scripts/webkitpy/layout_tests/port/mac.py:
3475         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3476         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3477         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3478         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3479         * Scripts/webkitpy/layout_tests/port/qt.py:
3480         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3481         * Scripts/webkitpy/layout_tests/port/test.py:
3482         * Scripts/webkitpy/layout_tests/port/webkit.py:
3483         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3484         * Scripts/webkitpy/layout_tests/port/win.py:
3485         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3486         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3487         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3488         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3489         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
3490
3491 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
3492
3493         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
3494         https://bugs.webkit.org/show_bug.cgi?id=71561
3495
3496         Reviewed by Dimitri Glazkov.
3497
3498         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3499         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
3500
3501 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
3502
3503         Implement dumpProgressFinishedCallback() for Mac layoutTestController
3504         https://bugs.webkit.org/show_bug.cgi?id=66772
3505
3506         Reviewed by Simon Fraser.
3507
3508         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
3509         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
3510
3511         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
3512         in the FrameLoadDelegate and print the output in response to the notification.
3513
3514         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3515         (-[FrameLoadDelegate init]):
3516         (-[FrameLoadDelegate dealloc]):
3517         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
3518
3519 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3520
3521         [GTK][DRT] window internals object is not reset after each test
3522         https://bugs.webkit.org/show_bug.cgi?id=71890
3523
3524         Reviewed by Martin Robinson.
3525
3526         Call WebCoreTestSupport::resetInternalsObject without going
3527         through DumpRenderTreeSupport.
3528
3529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3530         (runTest):
3531
3532 2011-11-09  Beth Dakin  <bdakin@apple.com>
3533
3534         Build fix.
3535
3536         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3537         (AccessibilityUIElement::uiElementAttributeValue):
3538
3539 2011-11-09  Beth Dakin  <bdakin@apple.com>
3540
3541         Speculative build fix.
3542
3543         * DumpRenderTree/AccessibilityUIElement.h:
3544
3545 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
3546
3547         Unreviewed build fix.
3548
3549         * DumpRenderTree/AccessibilityUIElement.cpp:
3550         (AccessibilityUIElement::makeJSAccessibilityUIElement):
3551         A bad merge added this check that is making the bots sad.
3552
3553 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
3554
3555         AX: crash when accessing selectedTab in a tab list
3556         https://bugs.webkit.org/show_bug.cgi?id=70938
3557
3558         Reviewed by Beth Dakin.
3559
3560         Add the ability to retrieve an element through an arbitrary attribute.
3561
3562         * DumpRenderTree/AccessibilityUIElement.cpp:
3563         (uiElementAttributeValueCallback):
3564         (AccessibilityUIElement::uiElementAttributeValue):
3565         (AccessibilityUIElement::getJSClass):
3566         * DumpRenderTree/AccessibilityUIElement.h:
3567         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3568         (AccessibilityUIElement::uiElementAttributeValue):
3569
3570 2011-11-09  Andy Wingo  <wingo@igalia.com>
3571
3572         Add webkitdirs.pm:getArchitecture implementation for GTK
3573         https://bugs.webkit.org/show_bug.cgi?id=71370
3574
3575         Reviewed by Xan Lopez.
3576
3577         * Scripts/webkitdirs.pm (determineArchitecture): Add an
3578         implementation for ports using autotools, so that a vanilla
3579         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
3580         to build-jsc on x86-64 machines.
3581
3582 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3583
3584         Unreviewed, rolling out r99707.
3585         http://trac.webkit.org/changeset/99707
3586
3587         Re-enable until we can disable it together with tests in one
3588         shot.
3589
3590         * qmake/mkspecs/features/features.prf:
3591
3592 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3593
3594         [Qt] Disable use of QtUiTools if the library/module is not found
3595
3596         We rely on the lookup order of prf files to inject our own uitools.prf
3597         that will verify that QtUiTools is in fact present before allowing the
3598         CONFIG += uitools to have any effect.
3599
3600         Reviewed by Simon Hausmann.
3601
3602         * DumpRenderTree/qt/DumpRenderTree.pro:
3603         * QtTestBrowser/QtTestBrowser.pro:
3604         * qmake/mkspecs/features/uitools.prf: Added.
3605
3606 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3607
3608         Unreviewed, rolling out r99701.
3609         http://trac.webkit.org/changeset/99701
3610
3611         Breaks Qt mac build
3612
3613         * qmake/mkspecs/features/functions.prf:
3614
3615 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3616
3617         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
3618
3619         Reviewed by Tor Arne Vestbø.
3620
3621         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
3622         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
3623         is not up to the task of full XSLT support, so we should disable it.
3624
3625 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3626
3627         [Qt] Enable exports and constructor functions in static libs
3628
3629         Reviewed by Tor Arne Vestbø.
3630
3631         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
3632         mac/win32-msvc equivalents when linking static libraries into a shared
3633         library or executable.
3634
3635 2011-11-09  Philippe Normand  <pnormand@igalia.com>
3636
3637         [GTK][DRT] window internals object is not reset after each test
3638         https://bugs.webkit.org/show_bug.cgi?id=71890
3639
3640         Reviewed by Xan Lopez.
3641
3642         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3643         (runTest): reset the Internals object after each test.
3644
3645 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3646
3647         [Qt] Detect presence of QtUiTools and enable it only when available
3648
3649         The disable_uitools option was a workaround for missing detection.
3650
3651         Reviewed by Simon Hausmann.
3652
3653         * QtTestBrowser/QtTestBrowser.pro:
3654         * qmake/mkspecs/features/default_post.prf:
3655         * qmake/mkspecs/features/default_pre.prf:
3656
3657 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3658
3659         [Qt] Don't override config for the build_pass of debug_and_release
3660
3661         Qmake will parse the profile once for each configuration (debug and
3662         release), with the build_pass option set. In that situation we don't
3663         want to override what qmake is setting explicitly, otherwise the
3664         debug-step will end up hitting all the release-scopes.
3665
3666         Reviewed by Simon Hausmann.
3667
3668         * qmake/mkspecs/features/default_pre.prf:
3669
3670 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3671
3672         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
3673
3674         * qmake/mkspecs/features/functions.prf:
3675
3676 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3677
3678         [Qt] Centralize duplicated code for linking the static libs
3679
3680         Reviewed by Tor Arne Vestbø.
3681
3682         * qmake/mkspecs/features/functions.prf:
3683         * qmake/mkspecs/features/javascriptcore.prf:
3684         * qmake/mkspecs/features/webcore.prf:
3685         * qmake/mkspecs/features/webkit2.prf:
3686
3687 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
3688
3689         [Qt] Build system cleanup
3690         https://bugs.webkit.org/show_bug.cgi?id=71815
3691
3692         Reviewed by Kenneth Rohde Christiansen.
3693
3694         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
3695         static library.
3696         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
3697         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
3698
3699 2011-11-08  Hayato Ito  <hayato@chromium.org>
3700
3701         [NRWT] Make single_test_runner aware of reference filename of test_input.
3702         https://bugs.webkit.org/show_bug.cgi?id=71567
3703
3704         Reviewed by Ryosuke Niwa.
3705
3706         Make single_test_runner honor a reference filename of given test_input so that
3707         we can use any file as reference html, instead of depending on implicit naming convention.
3708         The typical use case is to support w3c reftests.
3709
3710         No tests since no functional changes until there is a client.
3711         Test should be easily written with future clients.
3712
3713         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3714         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3715         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3716         * Scripts/webkitpy/layout_tests/models/test_input.py:
3717
3718 2011-11-08  Lucas Forschler  <lforschler@apple.com>
3719
3720         https://bugs.webkit.org/show_bug.cgi?id=71839
3721         Update the leaks bot OS to Lion.
3722         Update the config.json to reflect the update.
3723
3724         Reviewed by Stephanie Lewis.
3725
3726         * BuildSlaveSupport/build.webkit.org-config/config.json:
3727
3728 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
3729
3730         Unreviewed, rolling out r99626.
3731         http://trac.webkit.org/changeset/99626
3732         https://bugs.webkit.org/show_bug.cgi?id=71866
3733
3734         "C++ exceptions cannot be disabled without influencing the
3735         Objective-C exceptions" (Requested by benjaminp on #webkit).
3736
3737         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3738
3739 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
3740
3741         [Mac] Disable C++ exceptions from DumpRenderTree
3742         https://bugs.webkit.org/show_bug.cgi?id=71834
3743
3744         Reviewed by Darin Adler.
3745
3746         DumpRenderTree Mac does not handle C++ exceptions. When such exception
3747         happens, it tends to cause the AutoReleasePool stack to be corrupted,
3748         which leads to crashes long after the exception was raised.
3749
3750         This patch disabled C++ exceptions in order to catch the problems where
3751         they happen when a C++ exception is raised.
3752
3753         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3754
3755 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
3756
3757         Moved myself to the reviewer list (yay!).
3758
3759         * Scripts/webkitpy/common/config/committers.py:
3760
3761 2011-11-08  Zeno Albisser  <zeno@webkit.org>
3762
3763         Added myself as a committer.
3764
3765         * Scripts/webkitpy/common/config/committers.py:
3766
3767 2011-11-08  Andy Wingo  <wingo@igalia.com>
3768
3769         Skip some ECMAScript tests that fail on Linux in some time zones.
3770         https://bugs.webkit.org/show_bug.cgi?id=71371
3771
3772         Reviewed by Martin Robinson.
3773
3774         * Scripts/run-javascriptcore-tests: Skip some more tests.
3775
3776 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
3777
3778         [Qt] Unreviewed trivial fix after build system refactoring.
3779
3780         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
3781
3782 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3783
3784         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
3785
3786         If a pro file needs to access the OBJECTS_DIR it should use the
3787         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
3788         after defaults_post has been processed.
3789
3790         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
3791         the command line will override whatever we set in defaults_pre.
3792
3793         Reviewed by Simon Hausmann.
3794
3795         * qmake/mkspecs/features/default_post.prf:
3796         * qmake/mkspecs/features/default_pre.prf:
3797
3798 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3799
3800         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
3801
3802         Reviewed by Simon Hausmann.
3803
3804         * qmake/mkspecs/features/default_post.prf:
3805
3806 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
3807
3808         [Qt][WK2] MiniBrowser should use urlFromUserInput()
3809         https://bugs.webkit.org/show_bug.cgi?id=71680
3810
3811         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
3812         complete urls in MiniBrowser.
3813
3814         Reviewed by Tor Arne Vestbø.
3815
3816         * MiniBrowser/qt/BrowserWindow.cpp:
3817         (BrowserWindow::BrowserWindow):
3818         (BrowserWindow::load):
3819         * MiniBrowser/qt/qml/BrowserWindow.qml:
3820         * MiniBrowser/qt/utils.cpp:
3821         (Utils::urlFromUserInput):
3822         * MiniBrowser/qt/utils.h:
3823         (Utils::Utils):
3824
3825 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
3826
3827         Added myself as a committer.
3828
3829         * Scripts/webkitpy/common/config/committers.py:
3830
3831 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
3832
3833         Unreviewed webkitpy test fix after r99512.
3834
3835         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
3836         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
3837
3838 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3839
3840         Added myself as a committer.
3841
3842         * Scripts/webkitpy/common/config/committers.py:
3843
3844 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3845
3846         Unreviewed, rolling out r99470.
3847         http://trac.webkit.org/changeset/99470
3848         https://bugs.webkit.org/show_bug.cgi?id=71740
3849
3850         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
3851
3852         * Scripts/webkitpy/common/config/watchlist:
3853
3854 2011-11-07  Tony Chang  <tony@chromium.org>
3855
3856         [chromium] update flakiness dashboard to reflect current bots
3857
3858         Reviewed by Ojan Vafai.
3859
3860         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
3861             bots and merged linux debug bots into a single bot.
3862         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3863         (setupExpectationsTest):
3864
3865 2011-11-07  Dana Jansens  <danakj@chromium.org>
3866
3867         Add cc-bugs group to watch changes in chromium graphics
3868         https://bugs.webkit.org/show_bug.cgi?id=71690
3869
3870         Reviewed by James Robinson.
3871
3872         * Scripts/webkitpy/common/config/watchlist:
3873
3874 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
3875
3876         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
3877         https://bugs.webkit.org/show_bug.cgi?id=70912
3878
3879         Reviewed by Ojan Vafai.
3880
3881         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
3882         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
3883
3884 2011-11-07  Eric Seidel  <eric@webkit.org>
3885
3886         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
3887         https://bugs.webkit.org/show_bug.cgi?id=62199
3888
3889         Reviewed by Dirk Pranke.
3890
3891         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3892         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3893         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3894
3895 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
3896
3897         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
3898         https://bugs.webkit.org/show_bug.cgi?id=71485
3899
3900         Reviewed by Darin Fisher.
3901
3902         * DumpRenderTree/chromium/EventSender.cpp:
3903         (EventSender::scalePageBy):
3904         * DumpRenderTree/chromium/TestShell.cpp:
3905         (TestShell::resetTestController):
3906
3907 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3908
3909         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
3910
3911         Allows us to not package up the whole Source/JavaScriptCore directory for the
3912         buildbots.
3913
3914         Reviewed-by Simon Hausmann.
3915
3916         * BuildSlaveSupport/built-product-archive:
3917         * Scripts/webkitdirs.pm:
3918         (jscProductDir):
3919
3920 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3921
3922         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
3923
3924         Reviewed-by Simon Hausmann.
3925
3926         * qmake/mkspecs/features/default_post.prf:
3927
3928 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3929
3930         [Qt] Sanitize qmake paths correctly before comparing
3931
3932         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
3933         which caused us to always generate derived webcore sources, but never build
3934         them. The bug has been fixed, and we now also sanitize paths for the injected
3935         bundle derived sources.
3936
3937         Reviewed by Simon Hausmann.
3938
3939         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
3940         * qmake/mkspecs/features/functions.prf:
3941
3942 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3943
3944         [Qt] Print right order for changing feature defines
3945
3946         Reviewed by Simon Hausmann.
3947
3948         * Scripts/webkitdirs.pm:
3949         (buildQMakeProject):
3950
3951 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
3952
3953         [Qt] Unreviewed trivial fix after build system refactoring.
3954
3955         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
3956
3957 2011-11-06  Eric Seidel  <eric@webkit.org>
3958
3959         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3960         https://bugs.webkit.org/show_bug.cgi?id=66078
3961
3962         Unreviewed.  Add an assert about the type of "args"
3963         to our Executive Mocks and fix a piece of code
3964         from this patch which was hitting that assert
3965         when executing for real.
3966
3967         * Scripts/webkitpy/common/system/executive_mock.py:
3968         * Scripts/webkitpy/layout_tests/port/webkit.py:
3969
3970 2011-11-06  Eric Seidel  <eric@webkit.org>
3971
3972         Split chunk handling out of prepare_lists_and_print_output to make it more readable
3973         https://bugs.webkit.org/show_bug.cgi?id=71629
3974
3975         Reviewed by Adam Barth.
3976
3977         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3978
3979 2011-11-06  Eric Seidel  <eric@webkit.org>
3980
3981         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
3982         https://bugs.webkit.org/show_bug.cgi?id=66078
3983
3984         Reviewed by Adam Barth.
3985
3986         The runtime feature detection was fixed to work in bug 64472.
3987         In this bug I moved the symbol-based feature detection from
3988         popen() to Executive.run_command and cleaned up the callers
3989         and unittests to make sure that we're correctly parsing the
3990         nm output correctly.  The old code happened to work even though
3991         the runtime-features path was using "str in list" and the
3992         symbol features path was using "str in str" and it just happened
3993         to do what we wanted to.  Now runtime features and symbol feature
3994         blacklists are computed separately (and with better documentation).
3995
3996         This system remains confusing, partially because these are black-lists
3997         which are amended to whatever static blacklist may exist for the
3998         port as part of a Skipped list file.
3999
4000         For example, notice how the runtime feature list only has directory
4001         blacklists for a couple features.  If all features are off,
4002         how do we skip enough tests with only 2 entries in the blacklist map?
4003         The answer is that Windows is the only port to use runtime feature
4004         detection, and the win/Skipped file turns off all the other features
4005         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
4006         which use symbol-based feature detection turn of mathml, wcss, etc
4007         using the blacklists found in _missing_symbol_to_skipped_tests.
4008
4009         I also noticed a couple places where we still referenced xhtmlmp
4010         even though support for such has been removed from WebKit.  Removed those.
4011
4012         This should result in no functional change.
4013
4014         * Scripts/webkitpy/layout_tests/port/gtk.py:
4015          - Use self._filesystem instead of os.path
4016         * Scripts/webkitpy/layout_tests/port/webkit.py:
4017         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4018
4019 2011-11-06  Dan Bernstein  <mitz@apple.com>
4020
4021         Made show-pretty-diff work when the input path contains spaces.
4022
4023         Reviewed by Anders Carlsson.
4024
4025         * Scripts/show-pretty-diff:
4026
4027 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
4028
4029         [chromium] Use the security origin instead of the URL when checking notification permissions
4030         https://bugs.webkit.org/show_bug.cgi?id=71590
4031
4032         Reviewed by Adam Barth.
4033
4034         * DumpRenderTree/chromium/NotificationPresenter.cpp:
4035         (NotificationPresenter::checkPermission):
4036         * DumpRenderTree/chromium/NotificationPresenter.h:
4037
4038 2011-11-05  Darin Adler  <darin@apple.com>
4039
4040         Fix a small leak in Mac version of LayoutTestController
4041         https://bugs.webkit.org/show_bug.cgi?id=71615
4042
4043         Reviewed by Mark Rowe.
4044
4045         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4046         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
4047         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
4048
4049 2011-11-04  Eric Seidel  <eric@webkit.org>
4050
4051         Upgrade to the latest Mechanize
4052         https://bugs.webkit.org/show_bug.cgi?id=71594
4053
4054         Reviewed by Adam Barth.
4055
4056         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
4057         Mechanize is no longer two separate libraries, so importing it is much simpler.
4058
4059         * Scripts/webkitpy/thirdparty/__init__.py:
4060
4061 2011-11-04  Stephen Chenney  <schenney@chromium.org>
4062
4063         Crash in ScrollAnimator.cpp
4064         https://bugs.webkit.org/show_bug.cgi?id=69865
4065
4066         The code in ScrollAnimator assumes that horizontal per-page mouse
4067         wheel events cannot happen, which is not true. This patch adds layout
4068         tests for all paging wheel event situations and fixes the broken
4069         horizontal case.
4070
4071         Reviewed by Anders Carlsson
4072
4073         * DumpRenderTree/chromium/EventSender.cpp:
4074         (EventSender::handleMouseWheel): Added the ability to specify that a
4075         mouse wheel event should be paging.
4076
4077 2011-11-04  Eric Seidel  <eric@webkit.org>
4078
4079         Remove deprecated free functions in port.factory
4080         https://bugs.webkit.org/show_bug.cgi?id=71494
4081
4082         Unreviewed.  Fix exception when running new-run-webkit-httpd.
4083
4084         * Scripts/new-run-webkit-httpd:
4085
4086 2011-11-04  Adam Roben  <aroben@apple.com>
4087
4088         Remove Leopard-specific code from build.webkit.org
4089
4090         We don't have any Leopard bots anymore.
4091
4092         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
4093
4094         Reviewed by Mark Rowe.
4095
4096         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
4097         and StopATSServer steps.
4098         (unitTestsSupported): Removed check for mac-leopard.
4099         (TestFactory.__init__): Removed Leopard-specific steps.
4100
4101 2011-11-04  Eric Seidel  <eric@webkit.org>
4102
4103         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
4104         https://bugs.webkit.org/show_bug.cgi?id=71549
4105
4106         Reviewed by Adam Barth.
4107
4108         Several members of Host didn't really belong there
4109         and were instead specific to WebKitPatch, so I've moved
4110         them up onto that class.
4111
4112         * Scripts/webkitpy/common/host.py:
4113         * Scripts/webkitpy/common/host_mock.py:
4114         * Scripts/webkitpy/tool/main.py:
4115         * Scripts/webkitpy/tool/mocktool.py:
4116         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4117
4118 2011-11-04  Tony Chang  <tony@chromium.org>
4119
4120         garden-o-matic: bring back party time!
4121         https://bugs.webkit.org/show_bug.cgi?id=71582
4122
4123         Reviewed by Adam Barth.
4124
4125         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
4128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
4129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
4130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
4131
4132 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
4133
4134         [EFL] DRT: Fix the order of the items in the dumped history list.
4135         https://bugs.webkit.org/show_bug.cgi?id=71562
4136
4137         It did not make much sense to hold the history list in a map, as we do not need
4138         the keys. And the printed items must be sorted by target, which is more easily
4139         done with a vector.
4140
4141         Should make tests such as http/tests/navigation/error404-frames.html pass.
4142
4143         Reviewed by Antonio Gomes.
4144
4145         * DumpRenderTree/efl/DumpHistoryItem.cpp:
4146         (compareHistoryItemsByTarget):
4147         (dumpHistoryItem):
4148
4149 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
4150
4151         [Qt] Remove ENABLE_SQLITE from qmake files
4152         https://bugs.webkit.org/show_bug.cgi?id=71546
4153
4154         Reviewed by Simon Hausmann.
4155
4156         * qmake/mkspecs/features/features.prf:
4157         * qmake/mkspecs/features/webcore.prf:
4158
4159 2011-11-04  Adam Barth  <abarth@webkit.org>
4160
4161         watchlist for WebIDL shouldn't trigger on Internals.idl
4162         https://bugs.webkit.org/show_bug.cgi?id=70657
4163
4164         Reviewed by David Levin.
4165
4166         Internals.idl isn't part of the Web-facing IDL in the project.
4167
4168         * Scripts/webkitpy/common/config/watchlist:
4169
4170 2011-11-04  Anders Carlsson  <andersca@apple.com>
4171
4172         Fix WKTR crash when running NPN_ConvertPoint test.
4173
4174         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
4175
4176         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
4177         (ConvertPoint::NPP_SetWindow):
4178
4179 2011-11-04  Anders Carlsson  <andersca@apple.com>
4180
4181         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
4182         https://bugs.webkit.org/show_bug.cgi?id=71570
4183
4184         Reviewed by Simon Fraser.
4185
4186         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4187         (PluginTest::NPP_SetWindow):
4188         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4189         Remove the NPP parameter from NPP_SetWindow.
4190
4191         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
4192         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
4193         Remove the NPP parameter from NPP_SetWindow.
4194
4195         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
4196         (PassDifferentNPPStruct::NPP_SetWindow):
4197         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
4198
4199         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
4200         (ConvertPoint::NPP_SetWindow):
4201         Run the test from NPP_SetWindow and call notifyDone() when done.
4202
4203         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4204         (NPP_SetWindow):
4205         Remove unnecessary parameter.
4206
4207 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4208
4209         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
4210
4211         Rubber-stamped by Tor Arne Vestbø.
4212
4213         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
4214         changed slightly after the refactoring.
4215
4216 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4217
4218         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
4219
4220         Reviewed by Simon Hausmann.
4221
4222         * qmake/mkspecs/features/default_pre.prf:
4223
4224 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4225
4226         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
4227
4228         Reviewed by Simmon Hausmann.
4229
4230         * qmake/mkspecs/features/default_pre.prf:
4231
4232 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4233
4234         [Qt] Disable STDIN check before cleaning build dir
4235
4236         It didn't work on the bots.
4237
4238         Reviewed by Ossy.
4239
4240         * Scripts/webkitdirs.pm:
4241
4242 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4243
4244         [Qt] Don't build all of webkit when running build-jsc
4245
4246         In case the whole webkit project was built, but we then subsequently
4247         want to build only JSC, we need to run make in the proper subdirectory.
4248
4249         This also means the incremental target needs to be added to all
4250         makefiles.
4251
4252         Reviewed by Simmon Hausmann.
4253
4254         * Scripts/webkitdirs.pm:
4255         (buildQMakeProject):
4256         * qmake/mkspecs/features/default_post.prf:
4257
4258 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4259
4260         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
4261
4262         Reviewed by Tor Arne Vestbø.
4263
4264         * Scripts/webkitdirs.pm:
4265         (jscProductDir): jsc path changed.
4266
4267 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4268
4269         [Qt] Error out early if trying to build against Qt < 4.8
4270
4271         Reviewed by Simon Hausmann.
4272
4273         * qmake/mkspecs/features/default_pre.prf:
4274
4275 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
4276
4277         Fix run-launcher for Qt and Gtk.
4278
4279         Rubber-stamped by Tor Arne Vestbø.
4280
4281         * Scripts/webkitdirs.pm:
4282         (isWK2): Re-add isWK2(), as it's used in run-launcher.
4283
4284 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4285
4286         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
4287
4288         Reviewed by Simon Hausmann.
4289
4290         * Scripts/build-webkit:
4291
4292 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
4293
4294         [GTK] Use web view title as window title in MiniBrowser
4295         https://bugs.webkit.org/show_bug.cgi?id=71544
4296
4297         Reviewed by Philippe Normand.
4298
4299         * MiniBrowser/gtk/BrowserWindow.c:
4300         (webViewURIChanged): Removed extra space.
4301         (webViewTitleChanged): Set window title using
4302         webkit_web_view_get_title().
4303         (browser_window_init): Set initial default window title.
4304         (browserWindowConstructed): Connect to WebView notify::title
4305         signal.
4306
4307 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4308
4309         [Qt] Refactor and clean up the qmake build system
4310
4311         The qmake build system has accumulated a bit of cruft and redundancy
4312         over time. There's also a fairly tight coupling between how to build
4313         the various targets, and _what_ to build, making it harder to add new
4314         rules or sources. This patch aims to elevate these issues somewhat.
4315
4316         This is a short-list of the changes: