[wx] Unreviewed build fix. Don't error out or hang if we have
[WebKit-https.git] / Tools / ChangeLog
1 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
2
3         [wx] Unreviewed build fix. Don't error out or hang if we have
4         downloaded dependencies but server update check fails.
5
6         * waf/build/build_utils.py:
7         (download_if_newer):
8
9 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
10
11         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
12         https://bugs.webkit.org/show_bug.cgi?id=69444
13
14         Reviewed by Tony Chang.
15
16         Currently if a test's image checksum doesn't match the checksum
17         in the baseline, but the images themselves match according to
18         ImageDiff, new-run-webkit-tests ignores the problem. This is
19         probably bad, but it's not yet clear what the right thing to do
20         is. This patch will log a warning to stderr, at least (but the
21         test will still pass).
22
23         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
24         (SingleTestRunner._compare_image):
25         (SingleTestRunner._run_reftest):
26         * Scripts/webkitpy/layout_tests/port/test.py:
27         (unit_test_list):
28         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
29
30 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
31
32         NRWT does not report failure for a skipped test
33         https://bugs.webkit.org/show_bug.cgi?id=78750
34
35         Reviewed by Eric Seidel.
36
37         If a test is listed in a Skipped file and you run it anyway
38         with --force, and the test fails, currently NRWT will print
39         "test ran as expected"; this is confusing, because you probably
40         expect the test to fail and yet this might lead you to think the
41         test passed. This patch changes the expected behavior to "PASS",
42         so tests that fail will be reported.
43
44         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
45         (result_was_expected):
46         (TestExpectationParser):
47         (TestExpectationParser.expectation_for_skipped_test):
48         (TestExpectations):
49         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
50         (test_add_skipped_tests):
51         * Scripts/webkitpy/layout_tests/port/test.py:
52         (unit_test_list): Add some tests that are expected to be in a Skipped file.
53         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
54
55 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
56
57         webkitpy: fix test code after bug 78181
58         https://bugs.webkit.org/show_bug.cgi?id=78870
59
60         Reviewed by Adam Barth.
61
62         I forgot to update the test code as per Tony's suggestion in
63         bug 78181 (r108005). This change does that, and in doing so
64         it revealed a subtle bug in _InlineWorkerConnection.run() that
65         I am fixing as part of this (_alive would not be cleared if an
66         exception was thrown).
67
68         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
69         (_InlineWorkerConnection.run):
70         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
71         (_TestWorker.__init__):
72         (_TestWorker.handle_stop):
73         (_TestWorker.handle_test):
74         (_TestWorker.run):
75         (_TestsMixin.handle_exception):
76         (_TestsMixin.test_unknown_message):
77
78 2012-02-17  Adam Roben  <aroben@apple.com>
79
80         Mac build fix after r108119
81
82         * DumpRenderTree/mac/DumpRenderTree.mm:
83         (runThread):
84         (runPthread):
85         (testThreadIdentifierMap):
86         Updated to match current WTF threading APIs.
87
88 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
89
90         revert r107147 - breaks webkit-patch on Mac SL
91         https://bugs.webkit.org/show_bug.cgi?id=78866
92
93         Reviewed by Adam Barth.
94
95         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
96         which is the version that ships on Mac SL. Reverting this
97         change until we no longer have to worry about that version.
98
99         * Scripts/webkitpy/common/system/autoinstall.py:
100         (AutoInstaller):
101         (AutoInstaller._extract_all): Added a comment about SL.
102         (AutoInstaller._unzip):
103
104 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
105
106         CSS regions enabled by default
107         https://bugs.webkit.org/show_bug.cgi?id=78525
108
109         Reviewed by David Hyatt.
110
111         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
112         CSSRegions are still enabled by default.
113         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
114
115         * DumpRenderTree/chromium/LayoutTestController.cpp:
116         (LayoutTestController::overridePreference):
117         * DumpRenderTree/chromium/WebPreferences.cpp:
118         (WebPreferences::reset):
119         (WebPreferences::applyTo):
120         * DumpRenderTree/chromium/WebPreferences.h:
121         (WebPreferences):
122         * DumpRenderTree/mac/DumpRenderTree.mm:
123         (resetDefaultsToConsistentValues):
124
125 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
126
127         Some API tests erroneously use = instead of == (causing build failures)
128         https://bugs.webkit.org/show_bug.cgi?id=78915
129
130         Reviewed by Sam Weinig.
131
132         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
133         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
134         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
135
136 2012-02-17  Peter Beverloo  <peter@chromium.org>
137
138         [Chromium] Include TestShellLinux.cpp in the build for Android
139         https://bugs.webkit.org/show_bug.cgi?id=78865
140
141         Reviewed by Eric Seidel.
142
143         Android will be re-using the TestShellLinux.cpp file. I already
144         added this r104033, but it seems to have gotten lost in the
145         recent refactorings.
146
147         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
148
149 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
150
151         Unreviewed, disable video build on EFL until it can be
152         supported by EFL build bot.
153
154         * Scripts/build-webkit:
155
156 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
157
158         [GTK] Implement zoom in/out in MiniBrowser
159         https://bugs.webkit.org/show_bug.cgi?id=75253
160
161         Reviewed by Gustavo Noronha Silva.
162
163         * MiniBrowser/gtk/BrowserWindow.c:
164         (browserWindowCanZoomIn):
165         (browserWindowCanZoomOut):
166         (browserWindowUpdateZoomActions):
167         (webViewZoomLevelChanged):
168         (zoomInCallback):
169         (zoomOutCallback):
170         (browser_window_init):
171         (browserWindowConstructed):
172
173 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
174
175         layoutTestController.display() is flaky for SVG tests
176         https://bugs.webkit.org/show_bug.cgi?id=78021
177
178         Reviewed by Adam Roben.
179
180         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
181         Size the web view before running the test, not when dumping.
182         All platforms handle this correctly now.
183
184         * DumpRenderTree/win/DumpRenderTree.cpp:
185         (dump):
186         (sizeWebViewForCurrentTest):
187         (runTest):
188
189 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
190
191         [GTK] Make install is broken when building without --enable-gtk-doc
192         https://bugs.webkit.org/show_bug.cgi?id=78828
193
194         Reviewed by Martin Robinson.
195
196         * gtk/generate-gtkdoc:
197         (rebase_installed_docs): Check documentation has been generated
198         before trying to rebase it.
199
200 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
201
202         nrwt: simplify worker interface
203         https://bugs.webkit.org/show_bug.cgi?id=78181
204
205         Reviewed by Tony Chang.
206
207         This change moves code in name(), is_done(), run(), and cancel()
208         from Worker to AbstractWorker, since the logic is pretty much
209         boilerplate code that any implementation would want to use.
210
211         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
212         (get.should):
213         (AbstractWorker.__init__):
214         (AbstractWorker):
215         (AbstractWorker.name):
216         (AbstractWorker.stop_handling_messages):
217         (AbstractWorker.run):
218         (AbstractWorker.is_done):
219         (AbstractWorker.cancel):
220         * Scripts/webkitpy/layout_tests/controllers/worker.py:
221         (Worker.__init__):
222         (Worker.run):
223         (Worker.handle_stop):
224
225 2012-02-16  Michael Saboff  <msaboff@apple.com>
226
227         ENH: Add ability to run subset of JavaScript layout tests with JSC
228         https://bugs.webkit.org/show_bug.cgi?id=78764
229
230         Reviewed by Gavin Barraclough.
231
232         New simple test drive shell script that runs a defined
233         list of javascript tests using jsc and the standalone-{pre,post}.js
234         wrappers.
235
236         * Scripts/run-fast-jsc: Added.
237
238 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
239
240         Add new Qt performance tester bot to build.webkit.org
241         https://bugs.webkit.org/show_bug.cgi?id=78795
242
243         Reviewed by Adam Roben.
244
245         * BuildSlaveSupport/build.webkit.org-config/config.json:
246
247 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
248
249         Disable inspector on WinCE.
250
251         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
252
253         * Scripts/build-webkit:
254
255 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
256
257         WinCE build fix after r107656.
258
259         Disable FTPDIR on WinCE, since it does not compile there.
260
261         * Scripts/build-webkit:
262
263 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
264
265         Build fix after r107863.
266
267         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
268
269 2012-02-15  Tony Chang  <tony@chromium.org>
270
271         [chromium] add linux dbg back to garden-o-matic
272         https://bugs.webkit.org/show_bug.cgi?id=78752
273
274         Reviewed by Adam Barth.
275
276         This reflects the current linux debug bot name (there's only one bot).
277         I'm also remove the mac clang builder since it doesn't exist (mac
278         always uses clang now).
279
280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
281         * Scripts/webkitpy/layout_tests/port/builders.py:
282
283 2012-02-15  Sam Weinig  <sam@webkit.org>
284
285         Add style check for ctype functions that are generally frowned upon in WebKit
286         https://bugs.webkit.org/show_bug.cgi?id=78748
287
288         Reviewed by Anders Carlsson.
289
290         Not every platform has DisallowCType.h to check for uses of the ctype.h
291         functions, so add a style check for them as well.
292
293         * Scripts/webkitpy/style/checkers/cpp.py:
294         (check_ctype_functions):
295         (check_style):
296         (CppChecker):
297         Add check.
298
299         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
300         (WebKitStyleTest.test_ctype_fucntion):
301         Add checker.
302
303 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
304
305         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
306         https://bugs.webkit.org/show_bug.cgi?id=76546
307
308         Reviewed by Simon Hausmann.
309
310         Resize the web view programatically because the declarative property binding
311         does not work. Seems like our qml environment is not initialized fully but it
312         needs more investigation.
313
314         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
315         (WTR::WrapperWindow::handleStatusChanged):
316         (WTR::PlatformWebView::resizeTo):
317
318 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
319
320         webkitpy: add a worker_args concept to start_worker()
321         https://bugs.webkit.org/show_bug.cgi?id=78572
322
323         Reviewed by Tony Chang.
324
325         This change replaces the three NRWT-specific arguments passed
326         through the broker to the worker with a generic WorkerArguments
327         wrapper class and a separate set_inline_arguments() call that can
328         be used to pass additional data to the worker when it is running
329         in the same process as the manager (this is needed for testing).
330         With the addition of set_inline_arguments() we also no longer
331         need to pass an optional argument to the worker.run() call.
332
333         Note that this method is *only* implemented on inline workers,
334         so calling this on a regular (child process) worker will result
335         in a runtime error.
336
337         * Scripts/webkitpy/layout_tests/controllers/manager.py:
338         (Manager._run_tests):
339         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
340         (AbstractWorker.__init__):
341         (AbstractWorker.run):
342         (_ManagerConnection.start_worker):
343         (_InlineManager.start_worker):
344         (_InlineManager.set_inline_arguments):
345         (_InlineManager.run_message_loop):
346         (_MultiProcessManager.start_worker): Reworked signature.
347         (_WorkerConnection.__init__):
348         (_InlineWorkerConnection.__init__):
349         (_InlineWorkerConnection.set_inline_arguments): New method.
350         (_InlineWorkerConnection):
351         (_InlineWorkerConnection.run):
352         (_Process.run):
353         (_MultiProcessWorkerConnection.__init__):
354         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
355         (_TestWorker.__init__):
356         (_TestWorker.set_inline_arguments):
357         (_TestWorker.handle_test):
358         (_TestWorker.run):
359         (_TestsMixin.test_cancel):
360         (_TestsMixin.test_done):
361         (_TestsMixin.test_unknown_message):
362         (InlineBrokerTests): New class for more testing.
363         (InlineBrokerTests.setUp):
364         (InlineBrokerTests.test_inline_arguments): New test.
365         (InterfaceTest.test_managerconnection_is_abstract):
366         (InterfaceTest.test_workerconnection_is_abstract):
367         * Scripts/webkitpy/layout_tests/controllers/worker.py:
368         (WorkerArguments):
369         (WorkerArguments.__init__):
370         (Worker.__init__):
371         (Worker.set_inline_arguments):
372         (Worker):
373         (Worker.run):
374         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
375         (WorkerTest.test_default_platform_in_worker):
376
377 2012-02-15  Adam Klein  <adamk@chromium.org>
378
379         Unreviewed, rolling out r107704.
380         http://trac.webkit.org/changeset/107704
381         https://bugs.webkit.org/show_bug.cgi?id=78486
382
383         Caused layout test crashes in debug builds.
384
385         Specific crashing tests:
386
387         fast/events/show-modal-dialog-onblur-onfocus.html
388         fast/harness/show-modal-dialog.html
389         inspector/console/console-long-eval-crash.html
390
391         * DumpRenderTree/chromium/TestShell.cpp:
392         (TestShell::TestShell):
393         * DumpRenderTree/chromium/TestShell.h:
394         (TestShell):
395         * DumpRenderTree/chromium/WebViewHost.cpp:
396         (WebViewHost::runModal):
397
398 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
399
400         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
401         https://bugs.webkit.org/show_bug.cgi?id=76347
402
403         Reviewed by Kenneth Rohde Christiansen.
404
405         * MiniBrowser/qt/MiniBrowser.qrc:
406         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added. 
407         * MiniBrowser/qt/qml/BrowserWindow.qml:
408         * MiniBrowser/qt/qml/DialogLineInput.qml:
409
410 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
411
412         [Qt] Fix WebGL in QtTestBrowser
413
414         Reviewed by Tor Arne Vestbø.
415
416         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
417         the options for enabling GL we also pass them on properly.
418
419 2012-02-14  Sam Weinig  <sam@webkit.org>
420
421         Add #include of unistd.h on the mac for getcwd. 
422
423         Reviewed by Anders Carlsson.
424
425         This is necessary when building with libc++.
426
427         * WebKitTestRunner/TestInvocation.cpp:
428
429 2012-02-14  Sam Weinig  <sam@webkit.org>
430
431         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
432         https://bugs.webkit.org/show_bug.cgi?id=78663
433
434         Reviewed by Anders Carlsson.
435
436         * DumpRenderTree/DumpRenderTreePrefix.h:
437         * DumpRenderTree/cg/ImageDiffCG.cpp:
438
439 2012-02-14  Adam Barth  <abarth@webkit.org>
440
441         Implement an adb-based driver for the ChromiumAndroidPort
442         https://bugs.webkit.org/show_bug.cgi?id=78627
443
444         Reviewed by Eric Seidel.
445
446         This driver mostly just wires up the ChromiumDriver through adb.  In
447         some cases, it translates protocol elements, such as URIs, so that the
448         rest of webkitpy is insulated from the "remoteness" of the target device.
449
450         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
451         (ChromiumAndroidPort.start_helper):
452         (ChromiumAndroidPort._driver_class):
453         (ChromiumAndroidPort._update_version):
454         (ChromiumAndroidPort._get_stderr):
455         (ChromiumAndroidPort):
456         (ChromiumAndroidPort._get_last_stacktrace):
457         (ChromiumAndroidPort._teardown_performance):
458         (ChromiumAndroidDriver):
459         (ChromiumAndroidDriver.__init__):
460         (ChromiumAndroidDriver._start):
461         (ChromiumAndroidDriver.run_test):
462         (ChromiumAndroidDriver.stop):
463         (ChromiumAndroidDriver._test_shell_command):
464         (ChromiumAndroidDriver._write_command_and_read_line):
465         (ChromiumAndroidDriver._output_image):
466         (ChromiumAndroidDriver._has_crash_hint):
467
468 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
469
470         webkitpy: the real_name() method in the Port class is no longer needed
471         https://bugs.webkit.org/show_bug.cgi?id=78651
472
473         Reviewed by Eric Seidel.
474
475         The change in bug 78565 / r107718 made it no longer necessary
476         (we can use options.platform instead).
477
478         * Scripts/webkitpy/layout_tests/port/base.py:
479         (Port.name):
480         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
481         (MockDRTPort.__init__):
482
483 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
484
485         webkitpy: clean up options, port handling in manager_worker_broker
486         https://bugs.webkit.org/show_bug.cgi?id=78568
487
488         Reviewed by Tony Chang.
489
490         manager_worker_broker no longer needs options or port objects
491         directly, so we make them only be passed in start_worker().
492
493         * Scripts/webkitpy/layout_tests/controllers/manager.py:
494         (Manager._run_tests):
495         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
496         (get):
497         (_ManagerConnection.__init__):
498         (_ManagerConnection.start_worker):
499         (_InlineManager.__init__):
500         (_InlineManager.start_worker):
501         (_InlineManager.run_message_loop):
502         (_MultiProcessManager.__init__):
503         (_MultiProcessManager):
504         (_MultiProcessManager.start_worker):
505         (_InlineWorkerConnection.__init__):
506         (_InlineWorkerConnection.run):
507         (_Process.__init__):
508         (_MultiProcessWorkerConnection.__init__):
509         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
510         (make_broker):
511         (_TestWorker.run):
512         (_TestsMixin.test_cancel):
513         (_TestsMixin.test_done):
514         (_TestsMixin.test_unknown_message):
515         (MultiProcessBrokerTests.setUp):
516         (InterfaceTest.test_managerconnection_is_abstract):
517         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
518         (Broker.__init__):
519
520 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
521
522         nrwt: add a unit test for regression introduced in bug 78565
523         https://bugs.webkit.org/show_bug.cgi?id=78646
524
525         Reviewed by Tony Chang.
526
527         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
528         (FakeConnection):
529         (FakeConnection.run_message_loop):
530         (FakeConnection.post_message):
531         (WorkerTest):
532         (WorkerTest.test_default_platform_in_worker):
533
534 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
535
536         NRWT is broken for the default port
537         https://bugs.webkit.org/show_bug.cgi?id=78640
538     
539         Reviewed by Tony Chang.
540
541         The change in r107718 (bug 78565) broke NRWT if you didn't
542         specify any sort of --platform flag or equivalent. I didn't
543         catch this because it's a full integration test (which we don't
544         have an automated test for) and I missed this command line
545         variant when testing interactively.
546
547         * Scripts/webkitpy/layout_tests/controllers/worker.py:
548         (Worker.run):
549
550 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
551
552         Last character display for passwords in Android.
553         https://bugs.webkit.org/show_bug.cgi?id=78532
554
555         Reviewed by Adam Barth.
556
557         * DumpRenderTree/chromium/WebPreferences.cpp:
558         (WebPreferences::applyTo):
559
560 2012-02-14  Adam Barth  <abarth@webkit.org>
561
562         Finish implementing start_helper for ChromiumAndroidPort
563         https://bugs.webkit.org/show_bug.cgi?id=78582
564
565         Reviewed by Eric Seidel.
566
567         This patch contains the remaining odds and ends for the start_helper function.
568
569         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
570         (ChromiumAndroidPort.start_helper):
571         (ChromiumAndroidPort._synchronize_datetime):
572         (ChromiumAndroidPort):
573         (ChromiumAndroidPort._check_version):
574         (ChromiumAndroidPort._run_adb_command):
575         (ChromiumAndroidPort._copy_device_file):
576
577 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
578
579         webkitpy: create ports in Workers, not in manager_worker_broker
580         https://bugs.webkit.org/show_bug.cgi?id=78565
581
582         Reviewed by Tony Chang.
583
584         We will now create the Port object (if necessary) in the Worker
585         directly, so that the manager_worker_broker module doesn't need
586         all of this layout_test-specific logic. Part of the fixes for
587         bug 78171.
588
589         These changes are all well-tested by the existing tests in
590         run_webkit_tests_integrationtest.py.
591
592         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
593         (_Process.run):
594         * Scripts/webkitpy/layout_tests/controllers/worker.py:
595         (Worker.__init__):
596         (Worker.safe_init):
597         (Worker.run):
598         (Worker.cleanup):
599         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
600         (parse_args):
601         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
602
603 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
604
605         [chromium] check that we're not running multiple modal dialogs at the same time
606         https://bugs.webkit.org/show_bug.cgi?id=78486
607
608         Reviewed by Kent Tamura.
609
610         * DumpRenderTree/chromium/TestShell.cpp:
611         (TestShell::TestShell):
612         * DumpRenderTree/chromium/TestShell.h:
613         (TestShell::setIsDisplayingModalDialog):
614         (TestShell::isDisplayingModalDialog):
615         (TestShell):
616         * DumpRenderTree/chromium/WebViewHost.cpp:
617         (WebViewHost::runModal):
618
619 2012-02-14  Adam Barth  <abarth@webkit.org>
620
621         Enable the GPU codepath in the chromium-android port
622         https://bugs.webkit.org/show_bug.cgi?id=78580
623
624         Reviewed by James Robinson.
625
626         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
627         Android always uses the GPU codepath, so we set the GPU flags on the
628         main chromium-android port instead.
629
630         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
631         (ChromiumAndroidPort.__init__):
632
633 2012-02-14  Adam Barth  <abarth@webkit.org>
634
635         NRWT should expose --adb-args flag for Android
636         https://bugs.webkit.org/show_bug.cgi?id=78579
637
638         Reviewed by Eric Seidel.
639
640         This flag is already wired up to the ChromiumAndroidPort.
641
642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
643         (parse_args):
644
645 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
646
647         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
648         https://bugs.webkit.org/show_bug.cgi?id=78541
649         <rdar://problem/10036695>
650
651         Reviewed by Kent Tamura.
652
653         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
654         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
655         After each test, reset to using new protocol.
656
657 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
658
659         Convert svg/animations to use SMIL methods for driving the timeline
660         https://bugs.webkit.org/show_bug.cgi?id=78422
661
662         Reviewed by Dirk Schulze.
663
664         Remove no longer needed SVG specific animation sampling functionality from DRT.
665         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
666
667         * DumpRenderTree/LayoutTestController.cpp:
668         (LayoutTestController::staticFunctions):
669         * DumpRenderTree/LayoutTestController.h:
670         (LayoutTestController):
671         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
672         * DumpRenderTree/chromium/LayoutTestController.cpp:
673         (LayoutTestController::LayoutTestController):
674         * DumpRenderTree/chromium/LayoutTestController.h:
675         (LayoutTestController):
676         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
677         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
678         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
679         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
680         * DumpRenderTree/qt/LayoutTestControllerQt.h:
681         (LayoutTestController):
682         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
683         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
684
685 2012-02-13  Rob Flack  <flackr@chromium.org>
686
687         Add Linux ChromiumOS test results to flakiness dashboard.
688         https://bugs.webkit.org/show_bug.cgi?id=78495
689
690         Reviewed by Ojan Vafai.
691
692         * TestResultServer/static-dashboards/builders.js:
693         * TestResultServer/static-dashboards/dashboard_base.js:
694
695 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
696
697         [GTK] Mutation Observers build is broken
698         https://bugs.webkit.org/show_bug.cgi?id=78433
699
700         Reviewed by Martin Robinson.
701
702         Enabled mutation observers as a default feature for GTK port, too.
703
704         * Scripts/build-webkit:
705
706 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
707
708         Allow to configure ENABLE_FTPDIR in build-webkit
709         https://bugs.webkit.org/show_bug.cgi?id=65098
710
711         Reviewed by Eric Seidel.
712
713         Allow to disable ENABLE_FTPDIR by command line.
714         Remove ENABLE_FTPDIR from --minimal build
715
716         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
717         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
718         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
719
720 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
721
722         Add shinyak as committer.
723
724         Unreviewed.
725
726         * Scripts/webkitpy/common/config/committers.py:
727
728 2012-02-13  Adam Barth  <abarth@webkit.org>
729
730         Implement start/stop_helper for ChromiumAndroidPort
731         https://bugs.webkit.org/show_bug.cgi?id=78558
732
733         Reviewed by Dirk Pranke.
734
735         These functions (and their dependencies) set up the Android device for
736         testing.
737
738         This patch also includes a few tweaks on the previous patch recommended
739         by dpranke.
740
741         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
742         (ChromiumAndroidPort.__init__):
743         (ChromiumAndroidPort.start_helper):
744         (ChromiumAndroidPort.stop_helper):
745         (ChromiumAndroidPort._shut_down_http_server):
746         (ChromiumAndroidPort):
747         (ChromiumAndroidPort._push_executable):
748         (ChromiumAndroidPort._push_fonts):
749         (ChromiumAndroidPort._restore_system_font):
750         (ChromiumAndroidPort._push_test_resources):
751         (ChromiumAndroidPort._push_to_device):
752         (ChromiumAndroidPort._pull_from_device):
753         (ChromiumAndroidPort._kill_device_process):
754         (ChromiumAndroidPort._setup_performance):
755         (ChromiumAndroidPort._teardown_performance):
756         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
757         (ChromiumAndroidPortTest):
758         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
759         (PortTestCase):
760         (PortTestCase.make_port):
761         (PortTestCase.test_default_worker_model):
762
763 2012-02-13  Adam Barth  <abarth@webkit.org>
764
765         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
766         https://bugs.webkit.org/show_bug.cgi?id=78550
767
768         Reviewed by Eric Seidel.
769
770         Much of this code just forwards to the "host" port, which seems like a
771         reasonable thing to do.
772
773         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
774         (ChromiumAndroidPort.__init__):
775         (ChromiumAndroidPort.stop_helper):
776         (ChromiumAndroidPort):
777         (ChromiumAndroidPort._build_path):
778         (ChromiumAndroidPort._path_to_apache):
779         (ChromiumAndroidPort._path_to_apache_config_file):
780         (ChromiumAndroidPort._path_to_driver):
781         (ChromiumAndroidPort._path_to_helper):
782         (ChromiumAndroidPort._path_to_image_diff):
783         (ChromiumAndroidPort._path_to_lighttpd):
784         (ChromiumAndroidPort._path_to_lighttpd_modules):
785         (ChromiumAndroidPort._path_to_lighttpd_php):
786         (ChromiumAndroidPort._path_to_wdiff):
787         (ChromiumAndroidPort._shut_down_http_server):
788         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
789         (ChromiumAndroidPortTest):
790         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
791         (PortTestCase):
792         (PortTestCase.make_port):
793         (PortTestCase.test_default_worker_model):
794
795 2012-02-13  Adam Barth  <abarth@webkit.org>
796
797         chromium_android.py should implement "virtual" methods from ChromiumPort
798         https://bugs.webkit.org/show_bug.cgi?id=78545
799
800         Reviewed by Dirk Pranke.
801
802         This patch adds basic implementations that specialize a bunch of
803         functions from ChromiumPort.
804
805         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
806         (ChromiumAndroidPort):
807         (ChromiumAndroidPort.__init__):
808         (ChromiumAndroidPort.default_child_processes):
809         (ChromiumAndroidPort.baseline_search_path):
810         (ChromiumAndroidPort.check_build):
811         (ChromiumAndroidPort.check_sys_deps):
812         (ChromiumAndroidPort.default_worker_model):
813         (ChromiumAndroidPort.test_expectations):
814         (ChromiumAndroidPort.start_http_server):
815         (ChromiumAndroidPort.stop_http_server):
816         (ChromiumAndroidPort.start_helper):
817         (ChromiumAndroidPort.stop_helper):
818
819 2012-02-13  Adam Barth  <abarth@webkit.org>
820
821         Add a skeleton ChromiumAndroid port to webkitpy
822         https://bugs.webkit.org/show_bug.cgi?id=78543
823
824         Reviewed by Eric Seidel.
825
826         This patch just adds an empty ChromiumAndroid port object to webkitpy
827         and wires it up to the factory objects.  An actual implementation will
828         follow.
829
830         * Scripts/webkitpy/layout_tests/port/chromium.py:
831         (ChromiumPort):
832         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
833         (ChromiumAndroidPort):
834         (ChromiumAndroidPort.__init__):
835         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
836         (ChromiumPortTest.test_all_test_configurations):
837         * Scripts/webkitpy/layout_tests/port/factory.py:
838         (PortFactory):
839
840 2012-02-13  Adam Barth  <abarth@webkit.org>
841
842         NRWT's HTTP servers should support additional directories for resources
843         https://bugs.webkit.org/show_bug.cgi?id=78528
844
845         Reviewed by Eric Seidel.
846
847         This functionality will be used by the Chromium-Android port.
848
849         * Scripts/webkitpy/layout_tests/port/base.py:
850         (Port.to.start_http_server):
851         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
852         (LayoutTestApacheHttpd.__init__):
853         * Scripts/webkitpy/layout_tests/servers/http_server.py:
854         (Lighttpd.__init__):
855         (Lighttpd._prepare_config):
856
857 2012-02-13  Ami Fischman  <fischman@chromium.org>
858
859         Add fischman as committer.
860
861         Unreviewed
862
863         * Scripts/webkitpy/common/config/committers.py:
864
865 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
866
867         [EFL] Drop support for the Curl network backend.
868         https://bugs.webkit.org/show_bug.cgi?id=77874
869
870         Reviewed by Eric Seidel.
871
872         Nobody seems to be maintaining the Curl backend in WebCore, the
873         EFL port developers all seem to be using the Soup backend and the
874         port itself has many features which are only implemented for the
875         latter.
876
877         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
878         and always add the required include directories.
879         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
880         include directories and link to them.
881
882 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
883
884         [WebSocket] Update pywebsocket to 0.7.1
885         https://bugs.webkit.org/show_bug.cgi?id=78484
886
887         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
888
889         Reviewed by Kent Tamura.
890
891         * Scripts/webkitpy/thirdparty/__init__.py:
892         (AutoinstallImportHook._install_pywebsocket):
893
894 2012-02-12  Kangil Han  <kangil.han@samsung.com>
895
896         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
897         https://bugs.webkit.org/show_bug.cgi?id=78091
898
899         Reviewed by Hajime Morita.
900
901         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
902         This patch will activate around 1,900 test cases from skipped list in EFL port.
903
904         * DumpRenderTree/efl/EventSender.cpp:
905         (textZoom):
906         (pageZoom):
907         (textZoomInCallback):
908         (textZoomOutCallback):
909         (zoomPageInCallback):
910         (zoomPageOutCallback):
911
912 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
913
914         KeywordLookupGenerator.py script fails in some cases
915         https://bugs.webkit.org/show_bug.cgi?id=77886
916
917         Reviewed by Benjamin Poulain.
918
919         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
920         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
921         (GlobalVariablesTest.test_path_rules_specifier):
922
923 2012-02-12  Joe Thomas  <joethomas@motorola.com>
924
925         Add toText and isTextNode helpers in Text class.
926         https://bugs.webkit.org/show_bug.cgi?id=78140
927
928         Unit test case for the new style checker introduced.
929
930         Reviewed by Adam Barth.
931
932         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
933         (CppStyleTest):
934         (CppStyleTest.test_static_cast_readability): Added a unit test case.
935
936 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
937
938         Enable features supported by EFL port in build-webkit.
939         https://bugs.webkit.org/show_bug.cgi?id=78348
940
941         Reviewed by Ryosuke Niwa.
942
943         Sync build-webkit with OptionEfl.cmake, as some features enabled in
944         OptionEfl.cmake are not enabled in build-webkit.
945
946         * Scripts/build-webkit:
947
948 2012-02-12  Joe Thomas  <joethomas@motorola.com>
949
950         Add toText and isTextNode helpers in Text class.
951         https://bugs.webkit.org/show_bug.cgi?id=78140
952
953         Added a style checker to use toText rather than static_cast<Text*>.
954
955         Reviewed by Adam Barth.
956
957         * Scripts/webkitpy/style/checkers/cpp.py:
958         (check_language): Style checker for static_cast<Text*>.
959
960 2012-02-12  Philippe Normand  <pnormand@igalia.com>
961
962         Unreviewed, disable Mutation observers build on GTK until it can
963         actually build.
964
965         * Scripts/build-webkit:
966
967 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
968
969         Add back WTFURL to WebKit
970         https://bugs.webkit.org/show_bug.cgi?id=77291
971
972         Reviewed by Adam Barth.
973
974         Add a flag to build-webkit to easily build WebKit with WTFURL.
975
976         * Scripts/build-webkit:
977
978 2012-02-10  Adam Klein  <adamk@chromium.org>
979
980         Enable MUTATION_OBSERVERS by default on all platforms
981         https://bugs.webkit.org/show_bug.cgi?id=78196
982
983         Reviewed by Ojan Vafai.
984
985         * Scripts/build-webkit:
986
987 2012-02-10  Adam Barth  <abarth@webkit.org>
988
989         Move garden-o-matic's All Failures out of experimental
990         https://bugs.webkit.org/show_bug.cgi?id=78395
991
992         Reviewed by Dimitri Glazkov.
993
994         Several folks have tried this feature and found it useful.
995
996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
997
998 2012-02-10  Tim Horton  <timothy_horton@apple.com>
999
1000         NRWT should categorize options in --help
1001         https://bugs.webkit.org/show_bug.cgi?id=76221
1002
1003         Reviewed by Eric Seidel.
1004         
1005         Use optparse's OptionGroup mechanism to logically group NRWT's options,
1006         providing a better experience when scanning all the options.
1007
1008         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1009         (parse_args):
1010
1011 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1012
1013         [Qt][WK2] Refactor on Qt5 Layout tests' structure
1014         https://bugs.webkit.org/show_bug.cgi?id=77450
1015
1016         Reviewed by Csaba Osztrogonác.
1017
1018         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
1019         to qt-5.0-wk2 and qt-5.0-wk1.
1020
1021         * Scripts/old-run-webkit-tests:
1022         (buildPlatformResultHierarchy):
1023         (readSkippedFiles):
1024         * Scripts/webkitpy/layout_tests/port/qt.py:
1025         (QtPort._wk2_port_name):
1026         (QtPort._skipped_file_search_paths):
1027         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1028         (QtPortTest.test_baseline_search_path):
1029         * Scripts/webkitpy/layout_tests/port/webkit.py:
1030         (WebKitPort._wk2_port_name):
1031
1032 2012-02-09  Philippe Normand  <pnormand@igalia.com>
1033
1034         [GTK] EWS command-line option to run the tests
1035         https://bugs.webkit.org/show_bug.cgi?id=78211
1036
1037         Reviewed by Adam Barth.
1038
1039         New --run-tests option (defaults to False) for the EWS commands.
1040
1041         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1042         (AbstractEarlyWarningSystem):
1043         (AbstractEarlyWarningSystem.__init__):
1044         (AbstractEarlyWarningSystem.review_patch):
1045         (ChromiumLinuxEWS):
1046         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1047         (EarlyWarningSytemTest._test_builder_ews):
1048
1049 2012-02-09  Eric Seidel  <eric@webkit.org>
1050
1051         Rename compare_text and compare_audio to make it clear that they're !=
1052         https://bugs.webkit.org/show_bug.cgi?id=78301
1053
1054         Reviewed by Adam Barth.
1055
1056         I also removed the maybe_create_directory function which was redundant.
1057
1058         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1059         (Manager.set_up_run):
1060         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1061         (TestResultWriter._make_output_directory):
1062         * Scripts/webkitpy/layout_tests/port/base.py:
1063         (Port.do_text_results_differ):
1064         (Port.do_audio_results_differ):
1065         (Port.diff_text):
1066         (Port.driver_name):
1067         (Port.skips_perf_test):
1068         * Scripts/webkitpy/layout_tests/port/win.py:
1069         (WinPort.do_text_results_differ):
1070         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1071         (WinPortTest.test_do_text_results_differ):
1072         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1073         (LayoutTestApacheHttpd.__init__):
1074         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1075         (HttpServerBase.__init__):
1076         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1077         (Rebaseliner._diff_baselines):
1078
1079 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1080
1081         [GTK] Add DRT support for modal dialogs
1082         https://bugs.webkit.org/show_bug.cgi?id=53600
1083
1084         Reviewed by Martin Robinson.
1085
1086         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
1087         Most significantly, when creating a new web view in GtkLauncher, the window
1088         of the web view opener is passed around. In DumpRenderTree, the window of
1089         the main web view is always considered as the opener. This is required so
1090         the modal dialog's toplevel can be made transient for the opener's toplevel.
1091
1092         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1093         (webViewRunModalDialog):
1094         (createWebView):
1095         * GtkLauncher/main.c:
1096         (createWebViewCb):
1097         (runModalDialogCb):
1098         (createBrowser):
1099         (createWindow):
1100         (main):
1101
1102 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
1103
1104         [Gtk] security/set-form-autocomplete-attribute.html fails
1105         https://bugs.webkit.org/show_bug.cgi?id=78261
1106
1107         Reviewed by Martin Robinson.
1108
1109         Use the new helper in DumpRenderTreeSupportGtk to properly
1110         test whether an element performs autocompletion.
1111
1112         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1113         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
1114
1115 2012-02-09  James Robinson  <jamesr@chromium.org>
1116
1117         [chromium] Enable mock scrollbars for compositing layout tests
1118         https://bugs.webkit.org/show_bug.cgi?id=78299
1119
1120         Reviewed by Dirk Pranke.
1121
1122         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
1123         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
1124         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
1125
1126         * DumpRenderTree/chromium/TestShell.cpp:
1127         (TestShell::runFileTest):
1128         * DumpRenderTree/chromium/WebPreferences.cpp:
1129         (WebPreferences::reset):
1130         (WebPreferences::applyTo):
1131         * DumpRenderTree/chromium/WebPreferences.h:
1132         (WebPreferences):
1133
1134 2012-02-09  Eric Seidel  <eric@webkit.org>
1135
1136         Remove more uses of "os" from our webkitpy code
1137         https://bugs.webkit.org/show_bug.cgi?id=78292
1138
1139         Reviewed by Adam Barth.
1140
1141         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1142         (MockCheckout.__init__):
1143         (MockCheckout.is_path_to_changelog):
1144         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1145         * Scripts/webkitpy/common/system/filesystem_mock.py:
1146         (MockFileSystem._split):
1147         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1148         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1149         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1150         * Scripts/webkitpy/layout_tests/port/webkit.py:
1151         * Scripts/webkitpy/tool/bot/queueengine.py:
1152         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
1153         * Scripts/webkitpy/tool/commands/download.py:
1154         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1155         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1156         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1157         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1158         * Scripts/webkitpy/tool/commands/upload.py:
1159         (CreateBug.prompt_for_bug_title_and_comment):
1160         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1161         * Scripts/webkitpy/tool/steps/attachtobug.py:
1162         (AttachToBug.run):
1163         * Scripts/webkitpy/tool/steps/checkstyle.py:
1164         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1165         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1166         * Scripts/webkitpy/tool/steps/editchangelog.py:
1167         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1168         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1169         (PrepareChangeLogTest.test_ensure_bug_url):
1170         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1171         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1172         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1173         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1174
1175 2012-02-09  Eric Seidel  <eric@webkit.org>
1176
1177         Remove the cr-mac-ews (it's long been dead)
1178         https://bugs.webkit.org/show_bug.cgi?id=78267
1179
1180         Reviewed by Adam Barth.
1181
1182         * QueueStatusServer/model/queues.py:
1183         (Queue):
1184         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1185         (ChromiumWindowsEWS):
1186         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1187         (EarlyWarningSytemTest._test_builder_ews):
1188         (EarlyWarningSytemTest._test_testing_ews):
1189
1190 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
1191
1192         some tests in webkitpy are being run three times
1193         https://bugs.webkit.org/show_bug.cgi?id=78283
1194
1195         Reviewed by Ryosuke Niwa.
1196
1197         It turns out that if you import a class derived from
1198         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
1199         the unittest framework treats it as if the class was defined in
1200         the file (as well in the original file). This led us to running
1201         the tests in ChangeLogTest three times.
1202
1203         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1204         (PrepareChangeLogTest):
1205         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1206         (_assert_message_for_revert_output):
1207
1208 2012-02-09  Adam Barth  <abarth@webkit.org>
1209
1210         Remove extraneous line in previous patch.  I forgot to remove this
1211         before landing.
1212
1213         * Scripts/webkitpy/layout_tests/port/driver.py:
1214         (DriverProxy.start):
1215
1216 2012-02-09  Adam Barth  <abarth@webkit.org>
1217
1218         run-perf-tests should have an option to pause before running tests so we can attach Instruments
1219         https://bugs.webkit.org/show_bug.cgi?id=78271
1220
1221         Reviewed by Ryosuke Niwa.
1222
1223         This lets me attach instruments to profile the performance of the test.
1224
1225         * Scripts/webkitpy/layout_tests/port/chromium.py:
1226         (ChromiumDriver.start):
1227         * Scripts/webkitpy/layout_tests/port/driver.py:
1228         (Driver.start):
1229         (DriverProxy.start):
1230         * Scripts/webkitpy/layout_tests/port/server_process.py:
1231         (ServerProcess.start):
1232         * Scripts/webkitpy/layout_tests/port/test.py:
1233         (TestDriver.start):
1234         * Scripts/webkitpy/layout_tests/port/webkit.py:
1235         (WebKitDriver.start):
1236         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1237         (get_tests_run.RecordingTestDriver.start):
1238         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1239         (PerfTestsRunner._parse_args):
1240         (PerfTestsRunner._run_tests_set):
1241         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1242         (start):
1243         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1244         (test_run_test_set_kills_drt_per_run):
1245         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
1246         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
1247
1248 2012-02-09  Adam Barth  <abarth@webkit.org>
1249
1250         run-perf-tests --chromium should run the chromium port
1251         https://bugs.webkit.org/show_bug.cgi?id=78266
1252
1253         Reviewed by Ryosuke Niwa.
1254
1255         This patch makes run-perf-tests work more like run-webkit-tests.
1256
1257         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1258         (PerfTestsRunner._parse_args):
1259
1260 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1261
1262         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
1263         https://bugs.webkit.org/show_bug.cgi?id=77466
1264
1265         Reviewed by Dirk Pranke.
1266
1267         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
1268         is set or if we should raise an error. A unit test was added.
1269
1270         * Scripts/webkitpy/layout_tests/port/qt.py:
1271         (QtPort.operating_system):
1272         (QtPort):
1273         (QtPort.check_sys_deps):
1274         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1275         (QtPortTest.test_operating_system):
1276         (QtPortTest):
1277         (QtPortTest.test_check_sys_deps):
1278
1279 2012-02-09  Eric Seidel  <eric@webkit.org>
1280
1281         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
1282         https://bugs.webkit.org/show_bug.cgi?id=78263
1283
1284         Reviewed by Adam Barth.
1285
1286         * Scripts/webkitpy/common/config/ports.py:
1287         (DeprecatedPort):
1288         (DeprecatedPort.name):
1289         (DeprecatedPort.flag):
1290         (DeprecatedPort.script_path):
1291         (DeprecatedPort.script_shell_command):
1292         (DeprecatedPort.port):
1293         (DeprecatedPort.makeArgs):
1294         (DeprecatedPort.update_webkit_command):
1295         (DeprecatedPort.check_webkit_style_command):
1296         (DeprecatedPort.prepare_changelog_command):
1297         (DeprecatedPort.build_webkit_command):
1298         (DeprecatedPort.run_javascriptcore_tests_command):
1299         (DeprecatedPort.run_webkit_unit_tests_command):
1300         (DeprecatedPort.run_webkit_tests_command):
1301         (DeprecatedPort.run_python_unittests_command):
1302         (DeprecatedPort.run_perl_unittests_command):
1303         (DeprecatedPort.layout_tests_results_path):
1304         (MacPort):
1305         (WinPort):
1306         (GtkPort):
1307         (GtkPort.build_webkit_command):
1308         (GtkPort.run_webkit_tests_command):
1309         (QtPort):
1310         (QtPort.build_webkit_command):
1311         (EflPort):
1312         (EflPort.build_webkit_command):
1313         (ChromiumPort):
1314         (ChromiumPort.update_webkit_command):
1315         (ChromiumPort.build_webkit_command):
1316         (ChromiumPort.run_webkit_tests_command):
1317         (ChromiumPort.run_javascriptcore_tests_command):
1318         (ChromiumXVFBPort):
1319         (ChromiumXVFBPort.run_webkit_tests_command):
1320         * Scripts/webkitpy/common/config/ports_unittest.py:
1321         (DeprecatedPortTest):
1322         (DeprecatedPortTest.test_mac_port):
1323         (DeprecatedPortTest.test_gtk_port):
1324         (DeprecatedPortTest.test_qt_port):
1325         (DeprecatedPortTest.test_chromium_port):
1326         (DeprecatedPortTest.test_chromium_xvfb_port):
1327         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1328         (AbstractEarlyWarningSystem.__init__):
1329         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1330         * Scripts/webkitpy/tool/main.py:
1331         (WebKitPatch):
1332         (WebKitPatch.handle_global_options):
1333         * Scripts/webkitpy/tool/steps/abstractstep.py:
1334         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1335         (StepsTest.test_runtests_args):
1336
1337 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
1338
1339         [chromium] always initialize makeArgs in buildChromiumNinja
1340         https://bugs.webkit.org/show_bug.cgi?id=78231
1341
1342         Reviewed by Tony Gentilcore.
1343
1344         * Scripts/webkitdirs.pm:
1345         (buildChromiumNinja):
1346
1347 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1348
1349         [GTK] Show url of current hovered link in MiniBrowser
1350         https://bugs.webkit.org/show_bug.cgi?id=78098
1351
1352         Reviewed by Martin Robinson.
1353
1354         * MiniBrowser/gtk/BrowserWindow.c:
1355         (webViewMouseTargetChanged): Check whether hit test result is a
1356         link and use the url to update the status bar text.
1357         (browserWindowConstructed): Connect to
1358         WebKitWebView::mouse-target-changed signal.
1359
1360 2012-02-09  Rob Buis  <rbuis@rim.com>
1361
1362         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1363         https://bugs.webkit.org/show_bug.cgi?id=78042
1364
1365         Reviewed by Antonio Gomes.
1366
1367         Upstream final part of our DRT implementation.
1368
1369         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
1370         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
1371         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
1372         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
1373         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
1374
1375 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
1376
1377         kill-old-processes should kill gcc and clang
1378         https://bugs.webkit.org/show_bug.cgi?id=78189
1379
1380         Reviewed by Eric Seidel.
1381
1382         Added a bunch of processes names of gcc and clang to the list.
1383
1384         * BuildSlaveSupport/kill-old-processes:
1385
1386 2012-02-07  MORITA Hajime  <morrita@google.com>
1387
1388         Replacement text should be available from the marker.
1389         https://bugs.webkit.org/show_bug.cgi?id=77934
1390
1391         Made the mock requestCheckingOfText() implementation to return
1392         a replacement text for each misspelled word if available.
1393
1394         Reviewed by Kent Tamura.
1395
1396         * DumpRenderTree/chromium/WebViewHost.cpp:
1397         (WebViewHost::finishLastTextCheck):
1398
1399 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1400
1401         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
1402         https://bugs.webkit.org/show_bug.cgi?id=78146
1403
1404         Reviewed by Ryosuke Niwa.
1405
1406         Our DumpRenderTree should support --no-timeout and --timeout options in order
1407         to be able to use run-perf-tests and have a Performance Bot.
1408         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
1409         and the necessary code to handle such command line arguments to our DumpRenderTree.
1410
1411         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1412         (WebCore::DumpRenderTree::setTimeout):
1413         (WebCore):
1414         (WebCore::DumpRenderTree::setShouldTimeout):
1415         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1416         (DumpRenderTree):
1417         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1418         (LayoutTestController::LayoutTestController):
1419         (LayoutTestController::waitUntilDone):
1420         (LayoutTestController::notifyDone):
1421         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1422         (LayoutTestController::setTimeout):
1423         (LayoutTestController::setShouldTimeout):
1424         (LayoutTestController):
1425         * DumpRenderTree/qt/main.cpp:
1426         (isOption):
1427         (printUsage):
1428         (main):
1429
1430 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1431
1432         Rubber-stamped by Martin Robinson.
1433
1434         * gtk/common.py:
1435         (get_build_path): Move test for current directory being a valid
1436         directory up so it takes precedence over WebKitBuild/Release and
1437         WebKitBuild/Debug when they exist as well.
1438
1439 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1440
1441         [GTK] doc rebasing does not respect DESTDIR
1442         https://bugs.webkit.org/show_bug.cgi?id=78177
1443
1444         Reviewed by Martin Robinson.
1445
1446         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
1447         calling it for rebasing.
1448         * gtk/generate-gtkdoc:
1449         (get_common_options): Handle the new --virtual-root option.
1450         * gtk/gtkdoc.py:
1451         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
1452         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
1453
1454 2012-02-08  Adam Barth  <abarth@webkit.org>
1455
1456         Remove Python 2.5 support from WebKit
1457         https://bugs.webkit.org/show_bug.cgi?id=71593
1458
1459         Reviewed by Eric Seidel.
1460
1461         This is the last vestige of our Python 2.5 support.
1462
1463         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1464         (AbstractQueueTest.test_log_from_script_error_for_upload):
1465
1466 2012-02-08  Adam Barth  <abarth@webkit.org>
1467
1468         version_check.py should inform users that we don't support Python 2.5 anymore
1469         https://bugs.webkit.org/show_bug.cgi?id=78179
1470
1471         Reviewed by Eric Seidel.
1472
1473         We don't support Python 2.5 anymore.
1474
1475         * Scripts/webkitpy/common/version_check.py:
1476
1477 2012-02-08  Adam Barth  <abarth@webkit.org>
1478
1479         test_configuration.py shouldn't re-implement itertools
1480         https://bugs.webkit.org/show_bug.cgi?id=78178
1481
1482         Reviewed by Eric Seidel.
1483
1484         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1485         (TestConfigurationConverter.to_specifiers_list):
1486         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1487         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1488         (TestConfigurationConverter):
1489
1490 2012-02-08  Adam Barth  <abarth@webkit.org>
1491
1492         webkitpy should reply upon the multiprocessing package existing
1493         https://bugs.webkit.org/show_bug.cgi?id=78176
1494
1495         Reviewed by Eric Seidel.
1496
1497         Now that we don't support Python 2.5, this import can't fail.
1498
1499         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1500         (get):
1501         (_Process):
1502         (_Process.__init__):
1503         (_Process.run):
1504         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1505         (FunctionTests.test_get__processes):
1506         (MultiProcessBrokerTests.setUp):
1507         * Scripts/webkitpy/layout_tests/port/base.py:
1508         (Port.__init__):
1509         (Port.default_worker_model):
1510         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1511         (ChromiumMacPort.check_build):
1512         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1513         (PortTestCase.test_default_worker_model):
1514         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1515
1516 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1517
1518         Unreviewed typo fix that makes docs build again for the gtk2-based
1519         library.
1520
1521         * gtk/generate-gtkdoc:
1522
1523 2012-02-08  Adam Barth  <abarth@webkit.org>
1524
1525         Don't re-implement ZipFile.extractall
1526         https://bugs.webkit.org/show_bug.cgi?id=78173
1527
1528         Reviewed by Eric Seidel.
1529
1530         We can use ZipFile.extractall now that we don't support Python 2.5.
1531
1532         * Scripts/webkitpy/common/system/autoinstall.py:
1533         (AutoInstaller._extract_targz):
1534         (AutoInstaller._unzip):
1535
1536 2012-02-08  Adam Barth  <abarth@webkit.org>
1537
1538         Remove the ospath compat shim from webkitpy
1539         https://bugs.webkit.org/show_bug.cgi?id=78170
1540
1541         Reviewed by Eric Seidel.
1542
1543         We no longer need this compat shim now that we don't support Python 2.5.
1544
1545         * Scripts/webkitpy/common/checkout/scm/git.py:
1546         * Scripts/webkitpy/common/checkout/scm/svn.py:
1547         * Scripts/webkitpy/common/system/filesystem.py:
1548         (FileSystem.relpath):
1549         * Scripts/webkitpy/common/system/filesystem_mock.py:
1550         (MockFileSystem.relpath):
1551         * Scripts/webkitpy/common/system/ospath.py: Removed.
1552         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
1553
1554 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1555
1556         Build fix attempt after r107053.
1557
1558         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1559         (test_collect_tests):
1560
1561 2012-02-08  Adam Barth  <abarth@webkit.org>
1562
1563         Remove simplejson because it's no longer used by webkitpy
1564         https://bugs.webkit.org/show_bug.cgi?id=78164
1565
1566         Reviewed by Eric Seidel.
1567
1568         All the importers of this code were removed in a previous patch.
1569
1570         * Scripts/webkitpy/thirdparty/simplejson: Removed.
1571         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
1572         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
1573         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
1574         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
1575         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
1576         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
1577         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
1578         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
1579         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
1580         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
1581
1582 2012-02-08  Adam Barth  <abarth@webkit.org>
1583
1584         webkitpy still imports simplejson
1585         https://bugs.webkit.org/show_bug.cgi?id=78161
1586
1587         Reviewed by Eric Seidel.
1588
1589         We no longer support Python 2.5, so we can rely upon Python's built-in
1590         JSON package.
1591
1592         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1593         * Scripts/webkitpy/common/net/resultsjsonparser.py:
1594         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
1595         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1596         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1597         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1598         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1599         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1600         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1601         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1602         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1603
1604 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1605
1606         [GTK] Fails to build docs with non-standard build directories
1607         https://bugs.webkit.org/show_bug.cgi?id=78118
1608
1609         * gtk/common.py:
1610         (get_build_path): add comment to document changes done in r107098,
1611         as requested by the reviewer and forgotten by me.
1612
1613 2012-02-08  Adam Barth  <abarth@webkit.org>
1614
1615         Stop importing with_statement from the mysterious future
1616         https://bugs.webkit.org/show_bug.cgi?id=78156
1617
1618         Reviewed by Eric Seidel.
1619
1620         The future is now!  (Well, at least 2008, when Python 2.6 was released,
1621         is no longer the __future__.)
1622
1623         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1624         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1625         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1626         * Scripts/webkitpy/common/net/credentials_unittest.py:
1627         * Scripts/webkitpy/common/net/file_uploader.py:
1628         * Scripts/webkitpy/common/newstringio_unittest.py:
1629         * Scripts/webkitpy/common/system/autoinstall.py:
1630         * Scripts/webkitpy/common/system/crashlogs.py:
1631         * Scripts/webkitpy/common/system/fileset.py:
1632         * Scripts/webkitpy/common/system/filesystem.py:
1633         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1634         * Scripts/webkitpy/common/system/path.py:
1635         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
1636         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1637         * Scripts/webkitpy/layout_tests/port/base.py:
1638         (of):
1639         * Scripts/webkitpy/layout_tests/port/gtk.py:
1640         * Scripts/webkitpy/layout_tests/port/test.py:
1641         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1642         * Scripts/webkitpy/style/filereader_unittest.py:
1643         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1644         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1645         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
1646         * Scripts/webkitpy/tool/commands/queues.py:
1647         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1648         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1649
1650 2012-02-08  Rob Buis  <rbuis@rim.com>
1651
1652         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1653         https://bugs.webkit.org/show_bug.cgi?id=78042
1654
1655         Reviewed by Antonio Gomes.
1656
1657         Upstream more parts of our DRT implementation.
1658
1659         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
1660         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
1661         * DumpRenderTree/blackberry/EventSender.cpp: Added.
1662         * DumpRenderTree/blackberry/EventSender.h: Added.
1663         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
1664         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
1665
1666 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
1667
1668         check-webkit-style failing with "Path does not exist."
1669         https://bugs.webkit.org/show_bug.cgi?id=77873
1670
1671         Reviewed by Ojan Vafai.
1672
1673         This change fixes the way the style checker determines which
1674         Port class to use for a given test_expectations.txt path; the
1675         previous version used a heuristic that didn't really work in the
1676         first place.
1677
1678         * Scripts/webkitpy/style/checkers/test_expectations.py:
1679         (TestExpectationsChecker._determine_port_from_expectations_path):
1680         (TestExpectationsChecker.__init__):
1681         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1682         (TestExpectationsTestCase._expect_port_for_expectations_path):
1683         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1684
1685 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
1686
1687         nrwt: make --skip-pixel-test-if-no-baseline option
1688         https://bugs.webkit.org/show_bug.cgi?id=70484
1689
1690         Reviewed by Dirk Pranke.
1691
1692         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1693         (SingleTestRunner.__init__):
1694         (SingleTestRunner._should_fetch_expected_checksum):
1695         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1696         (Worker.handle_test_list):
1697         * Scripts/webkitpy/layout_tests/models/test_input.py:
1698         (TestInput.__init__):
1699         * Scripts/webkitpy/layout_tests/port/webkit.py:
1700         (WebKitDriver.cmd_line):
1701         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1702         (_set_up_derived_options):
1703         (parse_args):
1704         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1705         (MainTest.test_skip_pixel_test_if_no_baseline_option):
1706         * WebKitTestRunner/TestController.cpp:
1707         (WTR::TestController::TestController):
1708         (WTR::TestController::initialize):
1709         (WTR::TestController::runTest):
1710         * WebKitTestRunner/TestController.h:
1711         (TestController):
1712         * WebKitTestRunner/TestInvocation.cpp:
1713         (WTR::TestInvocation::TestInvocation):
1714         (WTR::TestInvocation::setIsPixelTest):
1715         * WebKitTestRunner/TestInvocation.h:
1716         (WTR::TestInvocation::setSkipPixelTestOption):
1717         (TestInvocation):
1718
1719 2012-02-08  Rob Buis  <rbuis@rim.com>
1720
1721         [BlackBerry] Upstream DumpRenderTreeBlackBerry
1722         https://bugs.webkit.org/show_bug.cgi?id=78042
1723
1724         Reviewed by Antonio Gomes.
1725
1726         Add implementation for our DumpRenderTree solution.
1727
1728         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
1729         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
1730
1731 2012-02-08  Antti Koivisto  <antti@apple.com>
1732
1733         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
1734         https://bugs.webkit.org/show_bug.cgi?id=78080
1735
1736         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
1737         
1738         Add API test.
1739
1740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1741         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
1742         (TestWebKitAPI):
1743         (TestWebKitAPI::TEST):
1744
1745 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
1746
1747         [GTK] Fails to build docs with non-standard build directories
1748         https://bugs.webkit.org/show_bug.cgi?id=78118
1749
1750         Reviewed by Martin Robinson.
1751
1752         * gtk/common.py:
1753         (get_build_path): also try the current directory as a valid build
1754         dir, which makes non-standard build directories such as build-2.0
1755         and build-3.0 work
1756
1757 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1758
1759         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
1760         https://bugs.webkit.org/show_bug.cgi?id=78099
1761
1762         Reviewed by Martin Robinson.
1763
1764         * MiniBrowser/gtk/BrowserWindow.c:
1765         (webViewDecidePolicy): Check whether it's a link clicked with the
1766         middle mouse button and load the request in a new window.
1767         (browserWindowConstructed): Connect to
1768         WebKitWebView::decide-policy signal.
1769
1770 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
1771
1772         Revert a part of the change in r106687 as a build fix.
1773
1774         Since Chromium port doesn't checkout the entire WebKit trunk,
1775         we can't run "svn info" on webkit_base.
1776
1777         * Scripts/webkitpy/layout_tests/port/base.py:
1778         (Port.repository_paths):
1779
1780 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
1781
1782         run-perf-tests doesn't recognize paths that start with PerformanceTests
1783         https://bugs.webkit.org/show_bug.cgi?id=78012
1784
1785         Reviewed by Adam Barth.
1786
1787         Use resolve paths using filesystem.relpath before passing it to find_files.find.
1788
1789         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1790         (PerfTestsRunner):
1791         (PerfTestsRunner._collect_tests):
1792         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1793         (test_collect_tests):
1794         (test_collect_tests.add_file):
1795
1796 2012-02-07  Justin Novosad  <junov@chromium.org>
1797
1798         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
1799         https://bugs.webkit.org/show_bug.cgi?id=78039
1800
1801         Reviewed by Stephen White.
1802
1803         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
1804
1805         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1806         (main):
1807         * DumpRenderTree/chromium/TestShell.cpp:
1808         (TestShell::TestShell):
1809         (TestShell::resetWebSettings):
1810         (TestShell::runFileTest):
1811         * DumpRenderTree/chromium/TestShell.h:
1812         (TestShell::setDeferred2dCanvasEnabled):
1813         (TestShell):
1814         * DumpRenderTree/chromium/WebPreferences.cpp:
1815         (WebPreferences::reset):
1816         (WebPreferences::applyTo):
1817         * DumpRenderTree/chromium/WebPreferences.h:
1818         (WebPreferences):
1819
1820 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1821
1822         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
1823         https://bugs.webkit.org/show_bug.cgi?id=77928
1824
1825         Reviewed by Daniel Bates.
1826
1827         CMake has used *Programs* directory for executable. In addition, shared libraries are being
1828         built in source directory. It is better to set common places in order to maintain executable
1829         and libraries. *bin* is for executable and *lib* is for library.
1830
1831         * DumpRenderTree/efl/CMakeLists.txt:
1832         * EWebLauncher/CMakeLists.txt:
1833         * Scripts/run-launcher:
1834         * Scripts/webkitdirs.pm:
1835         (jscProductDir):
1836         * Scripts/webkitpy/layout_tests/port/efl.py:
1837         (EflPort._path_to_driver):
1838         (EflPort._path_to_image_diff):
1839
1840 2012-02-07  Adam Klein  <adamk@chromium.org>
1841
1842         Add JSC support for delivering mutations when the outermost script context exits
1843         https://bugs.webkit.org/show_bug.cgi?id=70289
1844
1845         Reviewed by Eric Seidel.
1846
1847         * DumpRenderTree/mac/EventSendingController.mm: Add support for
1848         eventSender.scheduleAsynchronousKeyDown.
1849         (+[EventSendingController isSelectorExcludedFromWebScript:]):
1850         (+[EventSendingController webScriptNameForSelector:]):
1851         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
1852         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
1853         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
1854
1855 2012-02-07  Chris Rogers  <crogers@google.com>
1856
1857         Add Chris Rogers to reviewers section
1858         https://bugs.webkit.org/show_bug.cgi?id=78016
1859
1860         Reviewed by Adam Barth.
1861
1862         * Scripts/webkitpy/common/config/committers.py:
1863
1864 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
1865
1866         layoutTestController.display() is flaky for SVG tests
1867         https://bugs.webkit.org/show_bug.cgi?id=78021
1868
1869         Reviewed by Dan Bernstein.
1870
1871         Fix race condition in repaint rect tracking. When running a test using the repaint.js
1872         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
1873         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
1874         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
1875         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
1876         the repaint test already run, thus invalidating the previously tracked repaint rects.
1877
1878         * DumpRenderTree/mac/DumpRenderTree.mm:
1879         (dump):
1880         (runTest):
1881
1882 2012-02-07  Hans Wennborg  <hans@chromium.org>
1883
1884         Chromium: remove WebSpeechInputResult::set
1885         https://bugs.webkit.org/show_bug.cgi?id=77977
1886
1887         Reviewed by Darin Fisher.
1888
1889         It was renamed to assign() in r106475.
1890
1891         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1892         (makeRectResult):
1893
1894 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1895
1896         [Qt] Give emulated touch-point a radius
1897         https://bugs.webkit.org/show_bug.cgi?id=77985
1898         
1899         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
1900
1901         Reviewed by Kenneth Rohde Christiansen.
1902
1903         * MiniBrowser/qt/BrowserWindow.cpp:
1904         (BrowserWindow::updateVisualMockTouchPoints):
1905         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1906         (MiniBrowserApplication::notify):
1907         * MiniBrowser/qt/qml/MockTouchPoint.qml:
1908
1909 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
1910
1911         [GTK] Include gdk-pixbuf in the jhbuild modules
1912         https://bugs.webkit.org/show_bug.cgi?id=77980
1913
1914         Reviewed by Gustavo Noronha Silva.
1915
1916         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
1917
1918 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
1919
1920         [Qt] Prevent early test termination with newer Qt 5
1921         https://bugs.webkit.org/show_bug.cgi?id=77945
1922
1923         Reviewed by Csaba Osztrogonác.
1924
1925         QTBUG-24120 tracks a regression in Qt that would make layout tests
1926         terminate early. This patch works around it in a Qt 4 + 5 safe manner
1927         by disabling the quitOnLastWindowClosed feature, which we don't want/need
1928         for DRT anyway.
1929
1930         * DumpRenderTree/qt/main.cpp:
1931         (main): Don't quit on last window closed.
1932
1933 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
1934
1935         Fix some miscellaneous 'make dist' error for WebKitGTK+.
1936
1937         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
1938         files should not be distributed.
1939
1940 2012-02-02  Hajime Morrita  <morrita@chromium.org>
1941
1942         [PerformanceTests] Each Dromaeo test needs its landing html.
1943         https://bugs.webkit.org/show_bug.cgi?id=77504
1944
1945         Reviewed by Ryosuke Niwa.
1946
1947         Added an ignorable pattern which happens in some Dromaeo tests.
1948
1949         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1950         (PerfTestsRunner):
1951
1952 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
1953
1954         [GTK] Add missing pango include dir to fix build
1955         https://bugs.webkit.org/show_bug.cgi?id=77832
1956
1957         Reviewed by Martin Robinson.
1958
1959         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
1960
1961 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
1962
1963         [GTK] Fix remaining errors in GTK+ WebKit2 API
1964         https://bugs.webkit.org/show_bug.cgi?id=77890
1965
1966         Reviewed by Gustavo Noronha Silva.
1967
1968         Verify that WebKit2 GTK+ test files are not skipped during style checks.
1969         Skip soup_server_new when checking for NULL versus 0 usage.
1970
1971         * Scripts/webkitpy/style/checker_unittest.py:
1972         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
1973         * Scripts/webkitpy/style/checkers/cpp.py:
1974         (check_for_null):
1975
1976 2012-02-06  Eric Seidel  <eric@webkit.org>
1977
1978         webkit-patch apply-from-bug should be able to apply non-reviewed patches
1979         https://bugs.webkit.org/show_bug.cgi?id=77883
1980
1981         Reviewed by Adam Barth.
1982
1983         This is very helpful if you use bugzilla as a replacement for git-stash.
1984         Makes it simpler to re-apply the patch w/o having to look up the patch id.
1985
1986         * Scripts/webkitpy/tool/commands/download.py:
1987         (ProcessBugsMixin._fetch_list_of_patches_to_process):
1988         * Scripts/webkitpy/tool/commands/download_unittest.py:
1989         (DownloadCommandsTest.test_apply_from_bug):
1990
1991 2012-02-06  Philippe Normand  <pnormand@igalia.com>
1992
1993         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
1994         https://bugs.webkit.org/show_bug.cgi?id=77866
1995
1996         Reviewed by Martin Robinson.
1997
1998         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
1999         errors in some gstreamer source code files defining new GStreamer elements.
2000         * Scripts/webkitpy/style/checker_unittest.py:
2001         (GlobalVariablesTest.test_path_rules_specifier):
2002
2003 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2004
2005         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
2006         https://bugs.webkit.org/show_bug.cgi?id=77869
2007
2008         Reviewed by Philippe Normand.
2009
2010         * gtk/gtkdoc.py:
2011         (GTKDoc.rebase_installed_docs): Check html_dir exists.
2012
2013 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2014
2015         [Qt] Don't version QtWebKit.experimental.
2016         https://bugs.webkit.org/show_bug.cgi?id=77739
2017
2018         Reviewed by Tor Arne Vestbø.
2019
2020         * MiniBrowser/qt/qml/BrowserWindow.qml:
2021
2022 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2023
2024         [GTK] Fix several gtkdoc-fixxref warnings
2025         https://bugs.webkit.org/show_bug.cgi?id=77613
2026
2027         Reviewed by Martin Robinson.
2028
2029         * gtk/generate-gtkdoc:
2030         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
2031         of ignored files, since it's private.
2032         * gtk/gtkdoc.py:
2033         (GTKDoc._ignored_files_basenames): Helper function that returns a
2034         string with the list of ignored files basenames separated by a
2035         spaces, as expected by several gtkdoc commands.
2036         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
2037         --ignore-headers option.
2038         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
2039         --ignore-files option.
2040
2041 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2042
2043         [GTK] Fix xrefs after installing API documentation
2044         https://bugs.webkit.org/show_bug.cgi?id=77551
2045
2046         Reviewed by Martin Robinson.
2047
2048         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
2049         api docs.
2050         * gtk/common.py:
2051         (prefix_of_pkg_config_file): Get the prefix variable of the given
2052         pkg-config file.
2053         (gtk_version_of_pkg_config_file): Get the gtk version required by
2054         the given pkg-config file.
2055         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
2056         installed documentation.
2057         (get_gtkdoc_module_paths): Get paths where API doc is installed
2058         for the dependencies of the given pkg-config file.
2059         (get_common_xref_deps): Get API doc directories of dependencies
2060         common to WebKit1 and WebKit2.
2061         (get_webkit2_options): Add cross_reference_deps option.
2062         (get_webkit1_options): Ditto
2063         (rebase_installed_docs): Helper function to create a generator for
2064         the given pkg-config file and options and call rebase_installed_docs.
2065         * gtk/gtkdoc.py:
2066         (GTKDoc.__init__): Initialize cross_reference_deps.
2067         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
2068         dependencies.
2069         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
2070         links of installed documentation.
2071         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
2072         file.
2073
2074 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
2075
2076         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
2077         https://bugs.webkit.org/show_bug.cgi?id=77672
2078
2079         Reviewed by Dirk Pranke.
2080
2081         Test repetitions must be taken into account when working out
2082         the statistics shown by run-webkit-tests.
2083
2084         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2085         (Manager.prepare_lists_and_print_output):
2086         (Manager._print_result_summary):
2087         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2088         (ResultSummary.__init__):
2089         (ResultSummary.add):
2090         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2091         (MainTest.test_repeat_each_iterations_num_tests):
2092
2093 2012-02-05  Dan Bernstein  <mitz@apple.com>
2094
2095         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
2096         https://bugs.webkit.org/show_bug.cgi?id=77823
2097
2098         Reviewed by Anders Carlsson.
2099
2100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2101         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2102
2103 2012-02-04  Dan Bernstein  <mitz@apple.com>
2104
2105         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
2106         https://bugs.webkit.org/show_bug.cgi?id=77822
2107
2108         Reviewed by Sam Weinig.
2109
2110         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2111         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
2112
2113 2012-02-04  Sam Weinig  <sam@webkit.org>
2114
2115         Add ability to send WKURLRequests in WebKit2 API user messages
2116         https://bugs.webkit.org/show_bug.cgi?id=77819
2117
2118         Reviewed by Anders Carlsson.
2119
2120         Add testing for round-tripping WKTypes from the UIProcess,
2121         to the WebProcess, and back.
2122
2123         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
2124           More can easily be added.
2125
2126         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2127         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
2128         (TestWebKitAPI):
2129         (WebKit2UserMessageRoundTripTest):
2130         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
2131         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
2132         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
2133         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2134         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2135         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2136         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
2137         (TestWebKitAPI::TEST_F):
2138         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
2139         (TestWebKitAPI):
2140         (UserMessageTest):
2141         (TestWebKitAPI::UserMessageTest::UserMessageTest):
2142         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
2143         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2144         (TestWebKitAPI::PlatformWebView::resizeTo):
2145         (TestWebKitAPI):
2146         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2147         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2148
2149 2012-02-04  Dan Bernstein  <mitz@apple.com>
2150
2151         <rdar://problem/10772406> WKPreferences instances cannot be copied
2152         https://bugs.webkit.org/show_bug.cgi?id=77816
2153
2154         Reviewed by Sam Weinig.
2155
2156         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2157         (TestWebKitAPI::TEST):
2158
2159 2012-02-04  Adam Barth  <abarth@webkit.org>
2160
2161         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
2162         https://bugs.webkit.org/show_bug.cgi?id=77802
2163
2164         Reviewed by Eric Seidel.
2165
2166         This patch refactors our directory grouping code into base.js where it
2167         can be shared between failures.js and notifications.js.  It then adds
2168         an Examine action to each group of failures that triggers the "results"
2169         view.
2170
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
2177
2178 2012-02-04  Ojan Vafai  <ojan@chromium.org>
2179
2180         check-webkit-style is throwing an exception
2181         https://bugs.webkit.org/show_bug.cgi?id=77744
2182
2183         Reviewed by David Levin.
2184
2185         If the test_list is None, then we don't need to check for unsupported
2186         feature tests to skip.
2187
2188         * Scripts/webkitpy/layout_tests/port/webkit.py:
2189         (WebKitPort._has_test_in_directories):
2190         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2191         (test_skipped_tests_for_unsupported_features_empty_test_list):
2192
2193 2012-02-03  Adam Barth  <abarth@webkit.org>
2194
2195         List of all failures in garden-o-matic should actually list all the failures
2196         https://bugs.webkit.org/show_bug.cgi?id=77796
2197
2198         Reviewed by Eric Seidel.
2199
2200         This patch wires a bit more data into the new "All Failures" tab.  I've
2201         also iterated on how we enable this experimental feature.  The tab is
2202         still just a dumb list, but we'll make it smarter.
2203
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2208
2209 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2210
2211         Windows build fix after r106692.
2212
2213         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2214         (PortTest.test_reference_files):
2215
2216 2012-02-03  Beth Dakin  <bdakin@apple.com>
2217
2218         https://bugs.webkit.org/show_bug.cgi?id=77782
2219         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than 
2220         once on some pages with frames
2221         -and corresponding-
2222         <rdar://problem/10798474>
2223
2224         Reviewed by Sam Weinig.
2225
2226         One new test.
2227         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2228         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
2229         (TestWebKitAPI):
2230         (TestWebKitAPI::didForceRepaint):
2231         (TestWebKitAPI::didFinishLoadForFrame):
2232         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2233         (TestWebKitAPI::setPageLoaderClient):
2234         (TestWebKitAPI::TEST):
2235         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
2236         (TestWebKitAPI):
2237         (NewFirstVisuallyNonEmptyLayoutFramesTest):
2238         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
2239         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
2240         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
2241
2242 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2243
2244         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
2245         https://bugs.webkit.org/show_bug.cgi?id=77781
2246
2247         Reviewed by Eric Seidel.
2248
2249         This change fixes a couple of issues discovered while debugging
2250         test-webkitpy; both calling exit() instead of sys.exit() --
2251         which is discouraged in program code instead of the interpreter
2252         -- and a particular usage of outputcapture were stdin to get whacked
2253         and preventing debugging.
2254        
2255         This change introduces a couple of common _exit() methods that
2256         will standardize how webkit-patch exit's, in case we need to do
2257         something different in the future.
2258
2259         * Scripts/webkitpy/common/system/deprecated_logging.py:
2260         (error):
2261         * Scripts/webkitpy/common/system/outputcapture.py:
2262         (OutputCapture.assert_outputs):
2263         * Scripts/webkitpy/tool/bot/queueengine.py:
2264         (QueueEngine.exit_after_handled_error):
2265         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2266         (AbstractSequencedCommand.execute):
2267         * Scripts/webkitpy/tool/commands/queues.py:
2268         (StyleQueue.handle_script_error):
2269         * Scripts/webkitpy/tool/commands/upload.py:
2270         (MarkBugFixed.execute):
2271         * Scripts/webkitpy/tool/multicommandtool.py:
2272         (Command._exit):
2273         * Scripts/webkitpy/tool/steps/abstractstep.py:
2274         (AbstractStep._exit):
2275         * Scripts/webkitpy/tool/steps/checkstyle.py:
2276         (CheckStyle.run):
2277         * Scripts/webkitpy/tool/steps/commit.py:
2278         (Commit._check_test_expectations):
2279         * Scripts/webkitpy/tool/steps/confirmdiff.py:
2280         (ConfirmDiff.run):
2281
2282 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2283
2284         Perf bot build fix.
2285
2286         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2287         (PerfTestsRunner._generate_json):
2288
2289 2012-02-03  Adam Barth  <abarth@webkit.org>
2290
2291         Add a blank "Expected Failures" tab to garden-o-matic
2292         https://bugs.webkit.org/show_bug.cgi?id=77793
2293
2294         Reviewed by Eric Seidel.
2295
2296         This tab will help us explore and manage our expected failures.  The
2297         tab is hidden by default via a new "experimental features" flag.
2298
2299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2304         (#unexpected):
2305         (#onebar.partytime #unexpected):
2306
2307 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2308
2309         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
2310         https://bugs.webkit.org/show_bug.cgi?id=77785
2311
2312         Fix the build bots.
2313         
2314         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
2315
2316         * Scripts/update-webkit-support-libs:
2317         (downloadExpectedVersionNumber):
2318
2319 2012-02-03  Lucas Forschler  <lforschler@apple.com>
2320
2321         Add a Mac Lion Performance bot.
2322         https://bugs.webkit.org/show_bug.cgi?id=77765
2323
2324         Reviewed by Adam Roben.
2325
2326         This will update the master configuration in the following ways:
2327             Add a new performance slave (apple-xseve-11)
2328             Add a new Factory to download a build and run perf tests.
2329             
2330         * BuildSlaveSupport/build.webkit.org-config/config.json:
2331         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2332         (DownloadAndPerfTestFactory):
2333         (DownloadAndPerfTestFactory.__init__):
2334
2335 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
2336
2337         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
2338         https://bugs.webkit.org/show_bug.cgi?id=77752
2339
2340         Reviewed by James Robinson.
2341
2342         Delete unneeded file accidentally checked in in r106481.
2343
2344         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
2345
2346 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2347
2348         Ref Tests should support plain SVG files
2349         https://bugs.webkit.org/show_bug.cgi?id=77685
2350
2351         Reviewed by Tony Chang.
2352
2353         Don't assume reference files always use .html as the extension.
2354         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
2355
2356         Also fix various bugs in MockFileSystem and TestPort.
2357
2358         * Scripts/webkitpy/common/system/filesystem_mock.py:
2359         (MockFileSystem.isdir):
2360         * Scripts/webkitpy/layout_tests/port/base.py:
2361         (Port.reference_files):
2362         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2363         (PortTest.test_is_test_file):
2364         (PortTest.test_reference_files):
2365         * Scripts/webkitpy/layout_tests/port/test.py:
2366         (TestInstance.__init__):
2367
2368 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
2369
2370         perf-o-matic should store chromium svn revision
2371         https://bugs.webkit.org/show_bug.cgi?id=77725
2372
2373         Reviewed by Dirk Pranke.
2374
2375         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
2376         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
2377         is implemented in terms of newly added svn_revision.
2378
2379         * Scripts/webkitpy/common/checkout/scm/git.py:
2380         (Git.svn_revision):
2381         * Scripts/webkitpy/common/checkout/scm/scm.py:
2382         (SCM.head_svn_revision):
2383         (SCM):
2384         (SCM.svn_revision):
2385         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2386         (MockSCM.svn_revision):
2387         * Scripts/webkitpy/common/checkout/scm/svn.py:
2388         (SVN.svn_revision):
2389         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2390         (JSONLayoutResultsGenerator.__init__):
2391         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2392         (JSONResultsGeneratorBase._insert_generic_metadata):
2393         * Scripts/webkitpy/layout_tests/port/base.py:
2394         (Port.repository_paths):
2395         * Scripts/webkitpy/layout_tests/port/chromium.py:
2396         (ChromiumPort.repository_paths):
2397         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2398         (PerfTestsRunner._generate_json):
2399         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2400         (test_run_test_set_with_json_output):
2401         (test_run_test_set_with_json_source):
2402         (test_run_test_set_with_multiple_repositories):
2403
2404 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2405
2406         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
2407         https://bugs.webkit.org/show_bug.cgi?id=77632
2408
2409         Reviewed by Kenneth Rohde Christiansen.
2410
2411         * MiniBrowser/qt/BrowserWindow.cpp:
2412         (BrowserWindow::BrowserWindow):
2413         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2414         (MiniBrowserApplication::sendTouchEvent):
2415         (MiniBrowserApplication::handleUserOptions):
2416         * MiniBrowser/qt/MiniBrowserApplication.h:
2417         (WindowOptions):
2418         (WindowOptions::WindowOptions):
2419         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2420         (WTR::PlatformWebView::PlatformWebView):
2421         * WebKitTestRunner/qt/main.cpp:
2422         (main):
2423         * qmake/mkspecs/features/default_post.prf:
2424
2425 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
2426
2427         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
2428         https://bugs.webkit.org/show_bug.cgi?id=77723
2429
2430         Reviewed by Tor Arne Vestbø.
2431
2432         * Tools.pro: Compile WTR again on all platforms with WK2.
2433
2434 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
2435
2436         Ensure that inspector disabled build works
2437         https://bugs.webkit.org/show_bug.cgi?id=77604
2438
2439         Reviewed by Tor Arne Vestbø.
2440
2441         * qmake/mkspecs/features/features.prf:
2442
2443 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
2444
2445         [chromium] add support for --makeargs to the ninja-based build
2446         https://bugs.webkit.org/show_bug.cgi?id=77688
2447
2448         Reviewed by Adam Barth.
2449
2450         * Scripts/webkitdirs.pm:
2451         (buildChromiumNinja):
2452
2453 2012-02-02  Eric Seidel  <eric@webkit.org>
2454
2455         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
2456         https://bugs.webkit.org/show_bug.cgi?id=75145
2457
2458         Reviewed by Dirk Pranke.
2459
2460         * Scripts/webkitpy/layout_tests/port/mac.py:
2461         (MacPort.default_child_processes):
2462         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2463         (test_operating_system):
2464         (test_default_child_processes):
2465
2466 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
2467
2468        nrwt shouldn't blow up when there are errors in test_expectations.txt
2469        https://bugs.webkit.org/show_bug.cgi?id=73603
2470
2471        Reviewed by Ojan Vafai.
2472
2473        This change removes the distinction between 'errors' and 'warnings'
2474        in the test expectations parser. Now, any problem is a
2475        'warning', and if we are linting the file, warnings become fatal (errors).
2476
2477         This will allow a normal run-webkit-tests run to proceed even if
2478         there are bad lines.
2479
2480         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2481         (ParseError.__init__):
2482         (ParseError.__str__):
2483         (ParseError.__repr__):
2484         (TestExpectationSerializer.to_string):
2485         (TestExpectationParser._parse_modifiers):
2486         (TestExpectationParser._parse_expectations):
2487         (TestExpectationParser._check_modifiers_against_expectations):
2488         (TestExpectationParser._tokenize):
2489         (TestExpectationLine.__init__):
2490         (TestExpectationLine.is_invalid):
2491         (TestExpectationsModel.add_expectation_line):
2492         (TestExpectationsModel._already_seen_better_match):
2493         (TestExpectations.__init__):
2494         (TestExpectations._report_warnings):
2495         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2496         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2497         (assert_bad_expectations):
2498         (test_parse_warning):
2499         (test_overrides__duplicate):
2500         (ExpectationSyntaxTests.test_missing_expectation):
2501         (ExpectationSyntaxTests.test_missing_colon):
2502         (ExpectationSyntaxTests.test_too_many_colons):
2503         (ExpectationSyntaxTests.test_too_many_equals_signs):
2504         (ExpectationSyntaxTests.test_unrecognized_expectation):
2505         (SemanticTests.test_bug_format):
2506         (SemanticTests.test_bad_bugid):
2507         (SemanticTests.test_slow_and_timeout):
2508         (test_ambiguous):
2509         (test_more_modifiers):
2510         (test_order_in_file):
2511         (test_macro_overrides):
2512         (RebaseliningTest.assertRemove):
2513         (TestExpectationParserTests.test_tokenize_blank):
2514         (TestExpectationParserTests.test_tokenize_missing_colon):
2515         (TestExpectationParserTests.test_tokenize_extra_colon):
2516         (TestExpectationParserTests.test_tokenize_empty_comment):
2517         (TestExpectationParserTests.test_tokenize_comment):
2518         (TestExpectationParserTests.test_tokenize_missing_equal):
2519         (TestExpectationParserTests.test_tokenize_extra_equal):
2520         (TestExpectationParserTests.test_tokenize_valid):
2521         (TestExpectationParserTests.test_tokenize_valid_with_comment):
2522         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
2523         (TestExpectationSerializerTests.test_unparsed_to_string):
2524         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2525         (lint):
2526         * Scripts/webkitpy/style/checkers/test_expectations.py:
2527         (TestExpectationsChecker.check_test_expectations):
2528
2529 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2530
2531         Unreviewed, rolling out r106543.
2532         http://trac.webkit.org/changeset/106543
2533         https://bugs.webkit.org/show_bug.cgi?id=77671
2534
2535         Made tests less stable (Requested by rniwa on #webkit).
2536
2537         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2538         (PerfTestsRunner):
2539         (PerfTestsRunner.__init__):
2540         (PerfTestsRunner._run_tests_set):
2541         (PerfTestsRunner._run_single_test):
2542         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2543         (MainTest.TestDriver.run_test):
2544         (run_test):
2545
2546 2012-02-02  Beth Dakin  <bdakin@apple.com>
2547
2548         https://bugs.webkit.org/show_bug.cgi?id=77664
2549         Add API tests for didNewFirstVisuallyNonEmptyLayout
2550
2551         Reviewed by Darin Adler.
2552
2553         Two new tests.
2554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2555         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
2556         (TestWebKitAPI):
2557         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2558         (TestWebKitAPI::setPageLoaderClient):
2559         (TestWebKitAPI::TEST):
2560         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
2561         (TestWebKitAPI):
2562         (TestWebKitAPI::didForceRepaint):
2563         (TestWebKitAPI::didFinishLoadForFrame):
2564         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
2565         (TestWebKitAPI::setPageLoaderClient):
2566         (TestWebKitAPI::TEST):
2567         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
2568         (TestWebKitAPI):
2569         (NewFirstVisuallyNonEmptyLayoutFailsTest):
2570         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
2571         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
2572         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
2573         (TestWebKitAPI):
2574         (NewFirstVisuallyNonEmptyLayoutTest):
2575         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
2576         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
2577
2578 2012-02-02  Michael Saboff  <msaboff@apple.com>
2579
2580         Add Michael Saboff to reviewers list.
2581
2582         Rubber-stamped by Gavin Barraclough.
2583
2584         * Scripts/webkitpy/common/config/committers.py:
2585
2586 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2587
2588         Add myself as a committer
2589
2590         Unreviewed
2591
2592         * Scripts/webkitpy/common/config/committers.py:
2593
2594 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2595
2596         [PerformanceTests] tests have dependencies
2597         https://bugs.webkit.org/show_bug.cgi?id=77506
2598
2599         Reviewed by Hajime Morita.
2600
2601         Load an initialization page before each test after starting a DRT so that
2602         warming up DRT won't affect the performance test results.
2603
2604         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2605         (PerfTestsRunner):
2606         (PerfTestsRunner.__init__):
2607         (PerfTestsRunner._run_tests_set):
2608         (PerfTestsRunner._run_single_test):
2609         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2610         (MainTest.TestDriver.run_test):
2611         (test_initial_page_loaded):
2612         (test_initial_page_loaded.run_test):
2613
2614 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
2615
2616         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
2617
2618         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2619         (PerfTestsRunner._run_tests_set):
2620         (PerfTestsRunner._run_single_test):
2621         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2622         (create_runner):
2623         (test_run_passing_test):
2624         (test_run_silent_test):
2625         (test_run_failed_test):
2626         (test_run_tonguey_test):
2627         (test_run_timeout_test):
2628         (test_run_crash_test):
2629         (test_run_test_set_kills_drt_per_run):
2630         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2631         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
2632         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
2633
2634 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
2635
2636         Webkit generate-coverage-data script needs update to use new test script
2637         https://bugs.webkit.org/show_bug.cgi?id=77597
2638
2639         Reviewed by Dirk Schulze.
2640
2641         * Scripts/generate-coverage-data:
2642
2643 2012-02-01  Adam Barth  <abarth@webkit.org>
2644
2645         Update the tests to show that the mac-ews processes patches from
2646         non-committers.
2647
2648         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2649         (EarlyWarningSytemTest.test_committer_only_ewses):
2650         (EarlyWarningSytemTest.test_builder_ewses):
2651
2652 2012-02-01  Adam Barth  <abarth@webkit.org>
2653
2654         Mac-ews logs are huge
2655         https://bugs.webkit.org/show_bug.cgi?id=77045
2656
2657         Reviewed by Eric Seidel.
2658
2659         In order to get the cr-linux-ews bot to run tests on EC2, we created
2660         the chromium-xvfb port, which contained a number of tweaks to the
2661         Chromium port's behavior.  This patch refactors those tweaks so they
2662         can be shared with the mac-ews, mostly by moving them into the
2663         non-interactive mode of RunTests.
2664
2665         * Scripts/webkitpy/common/config/ports.py:
2666         (WebKitPort):
2667         (WebKitPort.layout_tests_results_path):
2668         (ChromiumPort.run_javascriptcore_tests_command):
2669         (ChromiumXVFBPort):
2670         (ChromiumXVFBPort.run_webkit_tests_command):
2671         * Scripts/webkitpy/common/config/ports_mock.py:
2672         (MockPort):
2673         (MockPort.layout_tests_results_path):
2674         * Scripts/webkitpy/common/config/ports_unittest.py:
2675         (WebKitPortTest.test_chromium_xvfb_port):
2676         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2677         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2678         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2679         (CommitQueueTest.test_commit_queue):
2680         (test_rollout):
2681         (test_manual_reject_during_processing):
2682         * Scripts/webkitpy/tool/steps/runtests.py:
2683         (RunTests.run):
2684         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2685         (RunTestsTest.test_no_unit_tests):
2686         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2687         (StepsTest.test_runtests_args):
2688
2689 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
2690
2691         Roll out r106442. It made some tests more stable but others less stable.
2692
2693         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2694         (PerfTestsRunner._run_tests_set):
2695         (PerfTestsRunner._run_single_test):
2696         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2697         (create_runner):
2698         (test_run_passing_test):
2699         (test_run_silent_test):
2700         (test_run_failed_test):
2701         (test_run_tonguey_test):
2702         (test_run_timeout_test):
2703         (test_run_crash_test):
2704         (test_run_test_set):
2705
2706 2012-02-01  Lucas Forschler  <lforschler@apple.com>
2707
2708         Enable EWS for non-contributers.
2709         https://bugs.webkit.org/show_bug.cgi?id=77576
2710         
2711         Reviewed by Adam Barth.
2712
2713         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2714         (MacEWS):
2715
2716 2012-02-01  Beth Dakin  <bdakin@apple.com>
2717
2718         https://bugs.webkit.org/show_bug.cgi?id=77383
2719         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
2720         -and corresponding-
2721         <rdar://problem/10709560>
2722
2723         Reviewed by Sam Weinig.
2724
2725         WebKit2's WebLoaderClient has a temporary new function that must be accounted 
2726         for.
2727         * MiniBrowser/mac/BrowserWindowController.m:
2728         (-[BrowserWindowController awakeFromNib]):
2729         * WebKitTestRunner/TestController.cpp:
2730         (WTR::TestController::initialize):
2731
2732 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
2733
2734         TestWebKitAPI isn't being built on chromium bots any more
2735         https://bugs.webkit.org/show_bug.cgi?id=77563
2736
2737         Reviewed by Dimitri Glazkov.
2738
2739         I accidentally dropped it in the refactoring in r105449.
2740
2741         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
2742
2743 2012-02-01  Hans Wennborg  <hans@chromium.org>
2744
2745         Rename WebSpeechInputResult::set() to assign()
2746         https://bugs.webkit.org/show_bug.cgi?id=77540
2747
2748         Reviewed by Darin Fisher.
2749
2750         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2751         (MockWebSpeechInputController::addMockRecognitionResult):
2752         (MockWebSpeechInputController::speechTaskFired):
2753
2754 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2755
2756         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
2757         https://bugs.webkit.org/show_bug.cgi?id=77542
2758
2759         Reviewed by Martin Robinson.
2760
2761         * gtk/generate-gtkdoc: Check first whether there's
2762         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
2763         instead.
2764         (get_webkit2_options): Return just the options since the
2765         pkg_config_path doesn't depend on options
2766         (get_webkit1_options): Ditto.
2767         (generate_doc): Helper function to create a generator and generate
2768         documentation for the given pkg-config file with the given options.
2769         * gtk/gtkdoc.py:
2770         (GTKDoc.__init__): Don't use ** for args parameter, since it's
2771         used as a dict and never expanded.
2772         (PkgConfigGTKDoc.__init__): Ditto.
2773
2774 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2775
2776         [GTK] API documentation is not installed even when building with --enable-gtk-doc
2777         https://bugs.webkit.org/show_bug.cgi?id=77094
2778
2779         Reviewed by Martin Robinson.
2780
2781         * GNUmakefile.am: Add install-data-local and uninstall-local rules
2782         to install/uninstall WebKit1 and WebKit2 API documentation.
2783
2784 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2785
2786         Unreviewed, rolling out r106460.
2787         http://trac.webkit.org/changeset/106460
2788         https://bugs.webkit.org/show_bug.cgi?id=77552
2789
2790         It break unit tests if WEBKIT_TESTFONTS isn't defined.
2791         (Requested by Ossy on #webkit).
2792
2793         * Scripts/webkitpy/layout_tests/port/qt.py:
2794
2795 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2796
2797         [Qt] Automatic clean build feature always do clean build with --no-webkit2
2798         https://bugs.webkit.org/show_bug.cgi?id=74519
2799
2800         Reviewed by Tor Arne Vestbø.
2801
2802         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
2803
2804         * qmake/mkspecs/features/features.prf:
2805
2806 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2807
2808         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
2809         https://bugs.webkit.org/show_bug.cgi?id=77466
2810
2811         Reviewed by Kenneth Rohde Christiansen.
2812
2813         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
2814         is set or if we should raise an error.
2815
2816         * Scripts/webkitpy/layout_tests/port/qt.py:
2817         (QtPort.setup_environ_for_server):
2818
2819 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
2820
2821         Reviewed by Martin Robinson.
2822
2823         [GTK] Improve FrameLoader signals. Resource loading
2824         https://bugs.webkit.org/show_bug.cgi?id=49543
2825
2826         Support for the new loader signals in DRT.
2827
2828         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2829         (urlPath):
2830         (willSendRequestCallback):
2831         (urlSuitableForTestResult):
2832         (descriptionSuitableForTestResult):
2833         (didReceiveResponse):
2834         (didFinishLoading):
2835         (didFailLoadingWithError):
2836         (createWebView):
2837
2838 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
2839
2840         run-perf-tests should restart DRT for each test
2841         https://bugs.webkit.org/show_bug.cgi?id=77506
2842
2843         Reviewed by Adam Barth.
2844
2845         Always restart DRT when running performance tests in order to minimize the dependency between tests.
2846
2847         * Scripts/webkitpy/layout_tests/port/chromium.py:
2848         (ChromiumDriver.stop):
2849         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2850         (PerfTestsRunner._run_tests_set):
2851         (PerfTestsRunner._run_single_test):
2852         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2853         (create_runner):
2854         (test_run_passing_test):
2855         (test_run_silent_test):
2856         (test_run_failed_test):
2857         (test_run_tonguey_test):
2858         (test_run_timeout_test):
2859         (test_run_crash_test):
2860         (test_run_test_set_kills_drt_per_run):
2861         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
2862         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
2863         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
2864
2865 2012-01-31  Hans Wennborg  <hans@chromium.org>
2866
2867         Speech Input: Report speech element rect relative to window rather than frame
2868         https://bugs.webkit.org/show_bug.cgi?id=76443
2869
2870         Reviewed by Darin Fisher.
2871
2872         Update LayoutTestController to allow for retrieving the speech
2873         element's position used in a request.
2874
2875         In Chromium this is handled by the MockWebSpeechInputController;
2876         adding stubs for the other implementations.
2877
2878         * DumpRenderTree/LayoutTestController.cpp:
2879         (setMockSpeechInputDumpRectCallback):
2880         (LayoutTestController::staticFunctions):
2881         * DumpRenderTree/LayoutTestController.h:
2882         (LayoutTestController):
2883         * DumpRenderTree/chromium/LayoutTestController.cpp:
2884         (LayoutTestController::LayoutTestController):
2885         (LayoutTestController::setMockSpeechInputDumpRect):
2886         * DumpRenderTree/chromium/LayoutTestController.h:
2887         (LayoutTestController):
2888         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2889         (MockWebSpeechInputController::setDumpRect):
2890         (MockWebSpeechInputController::clearResults):
2891         (MockWebSpeechInputController::startRecognition):
2892         (MockWebSpeechInputController::MockWebSpeechInputController):
2893         (makeRectResult):
2894         (MockWebSpeechInputController::speechTaskFired):
2895         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
2896         (MockWebSpeechInputController):
2897         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2898         (LayoutTestController::setMockSpeechInputDumpRect):
2899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2900         (LayoutTestController::setMockSpeechInputDumpRect):
2901         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2902         (LayoutTestController::setMockSpeechInputDumpRect):
2903         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2904         (LayoutTestController::setMockSpeechInputDumpRect):
2905         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2906         (LayoutTestController):
2907         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2908         (LayoutTestController::setMockSpeechInputDumpRect):
2909         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2910         (LayoutTestController::setMockSpeechInputDumpRect):
2911
2912 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
2913
2914         [EFL] Add basic DRT/Efl implementation to support viewport test.
2915         https://bugs.webkit.org/show_bug.cgi?id=77320
2916
2917         Reviewed by Andreas Kling.
2918
2919         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2920         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
2921
2922 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
2923
2924         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
2925         https://bugs.webkit.org/show_bug.cgi?id=77473
2926         <rdar://problem/10751357>
2927
2928         Reviewed by Darin Adler.
2929
2930         * DumpRenderTree/mac/EventSendingController.mm:
2931         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2932         * WebKitTestRunner/mac/EventSenderProxy.mm:
2933         (WTR::EventSenderProxy::keyDown):
2934         Added a new special keyDown value to test this.
2935
2936 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
2937
2938         nrwt: fix the mock port to work with DriverProxy, reftests
2939         https://bugs.webkit.org/show_bug.cgi?id=77170
2940
2941         Reviewed by Eric Seidel.
2942
2943         The DryrunPort used for benchmarking and testing NRWT has been
2944         broken since we added the DriverProxy code. It isn't really
2945         needed any more, so I've removed it.
2946
2947         The MockDRT port was also broken by DriverProxy, and moreover,
2948         never worked w/ reftests. Since we don't exercise this module in
2949         the unit tests, the code had also bitrotted some. I have cleaned
2950         it up and made it use DriverInput and DriverOutput for
2951         consistency.
2952
2953         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2954         (DryRunPort.__init__):
2955         (DryRunPort):
2956         (DryRunPort.real_name):
2957         (DryRunPort.create_driver):
2958         (DryRunPort.driver_cmd_line):
2959         (DryRunPort._driver_class):
2960         (DryrunDriver):
2961         (DryrunDriver.run_test):
2962         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2963         (MockDRTPort.create_driver):
2964         (MockChromiumDRT.run_one_test):
2965
2966 2012-01-31  Ojan Vafai  <ojan@chromium.org>
2967
2968         run-webkit-tests calls out to webkit-build-directory twice
2969         https://bugs.webkit.org/show_bug.cgi?id=77248
2970
2971         Reviewed by Dirk Pranke.
2972
2973         * Scripts/webkit-build-directory:
2974         If called with no arguments, print out both the top-level directory and the 
2975         configuration directory
2976
2977         * Scripts/webkitpy/layout_tests/port/config.py:
2978         (Config.build_directory):
2979         When called with no arguments, get and cache both the top-level and configuration directories.
2980
2981         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
2982         (main):
2983         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2984         (ConfigTest.assert_configuration):
2985         (ConfigTest.test_build_directory.mock_webkit_build_directory):
2986         (ConfigTest.test_build_directory):
2987         (ConfigTest.test_default_configuration__notfound):
2988         * Scripts/webkitpy/layout_tests/port/webkit.py:
2989         (WebKitPort._build_path):
2990         Cache the build directory in the options object so that other users
2991         of the options object don't need to call out to webkit-build-directory.
2992         Also, properly support the existing --build-directory argument.
2993
2994 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
2995
2996         Bump up the timeout for performance tests since DOM/DOMTable.html
2997         and Parser/html5-full-render.html are timing out on the bot.
2998
2999         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3000         (PerfTestsRunner._parse_args):
3001
3002 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
3003
3004         Fix the update_webgl_conformance_tests.py script in order to enable it
3005         to detect the SCM being used correctly.
3006         https://bugs.webkit.org/show_bug.cgi?id=77462
3007
3008         Reviewed by Kenneth Russell.
3009
3010         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3011         (default_out_dir):
3012
3013 2012-01-31  Eric Seidel  <eric@webkit.org>
3014
3015         webkit-patch apply-from-bug should work regardless of your CWD
3016         https://bugs.webkit.org/show_bug.cgi?id=77482
3017
3018         Reviewed by Adam Barth.
3019
3020         webkit-patch only ever works with patches made from the root
3021         directory.  We should pass the CWD to svn-apply in the case
3022         where we're running not from the webkit root.  I believe
3023         this used to work in the past and regressed.
3024
3025         * Scripts/webkitpy/common/checkout/checkout.py:
3026         (Checkout.apply_patch):
3027         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3028         (CheckoutTest.test_apply_patch):
3029
3030 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
3031
3032         Unreviewed, rolling out r106302.
3033         http://trac.webkit.org/changeset/106302
3034         https://bugs.webkit.org/show_bug.cgi?id=77472
3035
3036         Broke building DRT before running the tests (Requested by ojan
3037         on #webkit).
3038
3039         * Scripts/webkit-build-directory:
3040         * Scripts/webkitpy/layout_tests/port/config.py:
3041         (Config.build_directory):
3042         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3043         (main):
3044         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3045         (ConfigTest.assert_configuration):
3046         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3047         (ConfigTest.test_build_directory):
3048         (ConfigTest.test_default_configuration__notfound):
3049         * Scripts/webkitpy/layout_tests/port/webkit.py:
3050         (WebKitPort._build_path):
3051
3052 2012-01-31  Antoine Labour  <piman@chromium.org>
3053
3054         Merge WebGraphicsContext3D creation and initialization, and move it to
3055         WebViewClient.
3056         https://bugs.webkit.org/show_bug.cgi?id=76593
3057
3058         Reviewed by Darin Fisher.
3059
3060         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3061         (TestWebPlugin::TestWebPlugin):
3062         (TestWebPlugin::initialize):
3063         * DumpRenderTree/chromium/TestWebPlugin.h:
3064         * DumpRenderTree/chromium/WebViewHost.cpp:
3065         (WebViewHost::createGraphicsContext3D):
3066         (WebViewHost::createPlugin):
3067         * DumpRenderTree/chromium/WebViewHost.h:
3068
3069 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
3070
3071         [GTK] build-webkit warning.
3072         https://bugs.webkit.org/show_bug.cgi?id=77411
3073
3074         Reviewed by Philippe Normand.
3075
3076         * Scripts/webkitdirs.pm:
3077         (isCrossCompilation):
3078
3079 2012-01-31  Dan Bernstein  <mitz@apple.com>
3080
3081         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
3082
3083         Reviewed by Anders Carlsson.
3084
3085         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3086
3087 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
3088
3089         If the QTDIR environment variable is set, the build system fails to compile WinCairo
3090         https://bugs.webkit.org/show_bug.cgi?id=77112
3091
3092         Reviewed by Daniel Bates.
3093
3094         * Scripts/webkitdirs.pm:
3095         (determineIsQt):
3096
3097 2012-01-31  Adam Roben  <aroben@apple.com>
3098
3099         Only call -typingAttributes on WebViews, not WebHTMLViews
3100
3101         Looks like this case was just missed in r105908.
3102
3103         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
3104
3105         Reviewed by Antti Koivisto.
3106
3107         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
3108         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
3109         earlier.
3110
3111 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3112
3113         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
3114         https://bugs.webkit.org/show_bug.cgi?id=77221
3115
3116         Reviewed by Kenneth Rohde Christiansen.
3117
3118         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
3119
3120         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3121         (MiniBrowserApplication::sendTouchEvent):
3122
3123 2012-01-26  Hans Wennborg  <hans@chromium.org>
3124
3125         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3126         https://bugs.webkit.org/show_bug.cgi?id=77083
3127
3128         Reviewed by Darin Fisher.
3129
3130         Add MockWebSpeechInputController which provides a mock implementation
3131         of the WebSpeechInputController interface, and use that in
3132         DumpRenderTree.
3133
3134         * DumpRenderTree/DumpRenderTree.gypi:
3135         * DumpRenderTree/chromium/LayoutTestController.cpp:
3136         (LayoutTestController::addMockSpeechInputResult):
3137         * DumpRenderTree/chromium/LayoutTestController.h:
3138         ():
3139         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
3140         (MockWebSpeechInputController::create):
3141         (MockWebSpeechInputController::addMockRecognitionResult):
3142         (MockWebSpeechInputController::clearResults):
3143         (MockWebSpeechInputController::startRecognition):
3144         (MockWebSpeechInputController::cancelRecognition):
3145         (MockWebSpeechInputController::stopRecording):
3146         (MockWebSpeechInputController::MockWebSpeechInputController):
3147         (MockWebSpeechInputController::speechTaskFired):
3148         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3149         (MockWebSpeechInputController::SpeechTask::stop):
3150         (MockWebSpeechInputController::SpeechTask::runIfValid):
3151         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
3152         (WebKit):
3153         (MockWebSpeechInputController):
3154         (MockWebSpeechInputController::taskList):
3155         (SpeechTask):
3156         * DumpRenderTree/chromium/TestShell.cpp:
3157         * DumpRenderTree/chromium/WebViewHost.cpp:
3158         (WebViewHost::speechInputController):
3159         * DumpRenderTree/chromium/WebViewHost.h:
3160         (WebKit):
3161         (WebViewHost::speechInputControllerMock):
3162         (WebViewHost):
3163         ():
3164
3165 2012-01-31  Hajime Morrita  <morrita@chromium.org>
3166
3167         [PerformanceTests] Add landing html for Dromaeo dom-query test
3168         https://bugs.webkit.org/show_bug.cgi?id=77329
3169
3170         Reviewed by Ryosuke Niwa.
3171
3172         Added some more ignorable output patterns to allow warnings
3173         from a third party test suite.
3174
3175         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3176         (PerfTestsRunner):
3177         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
3178
3179 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3180
3181         [wx] Unreviewed. Update download URLs to new domain.
3182         
3183         * waf/build/build_utils.py:
3184         (update_wx_deps):
3185
3186 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
3187
3188         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
3189         to the list of build directories.
3190         
3191         * waf/build/settings.py:
3192
3193 2012-01-30  Kentaro Hara  <haraken@chromium.org>
3194
3195         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
3196         output an empty method name (i.e. "()")
3197         https://bugs.webkit.org/show_bug.cgi?id=77336
3198
3199         Reviewed by Darin Adler.
3200
3201         r105797 tried to detect a change outside methods, but it causes a bug that
3202         prepare-ChangeLog can output an empty method name, like this:
3203
3204             * foo/bar/baz.cpp:
3205             (method1):
3206             ():
3207             (method2):
3208
3209         This is because the cpp parser in prepare-ChangeLog cannot distinguish
3210         '{' as the beginning of a method with '{' as the beginning of an array definition
3211         at the top level.
3212
3213             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
3214
3215             void func() { // This '{' is the beginning of a method.
3216                 ...;
3217             }
3218
3219         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
3220
3221         * Scripts/prepare-ChangeLog:
3222         (get_function_line_ranges_for_cpp): Modified as described above.
3223         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
3224         an empty method name. Ideally this should not happen but may happen, since the
3225         parsers are not perfect.
3226         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
3227         (NameSpace7):
3228         (NameSpace8):
3229         (Class109):
3230         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3231
3232 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3233
3234         run-webkit-tests calls out to webkit-build-directory twice
3235         https://bugs.webkit.org/show_bug.cgi?id=77248
3236
3237         Reviewed by Dirk Pranke.
3238
3239         This reduces to calls to webkit-build-directory to one call and
3240         saves 500ms for run-webkit-tests over a single file.
3241
3242         * Scripts/webkit-build-directory:
3243         If called with no arguments, print out both the top-level directory and the 
3244         configuration directory.
3245
3246         * Scripts/webkit-build-directory:
3247         * Scripts/webkitpy/layout_tests/port/config.py:
3248         (Config.build_directory):
3249         When called with no arguments, get and cache both the top-level and configuration directories.
3250
3251         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
3252         (main):
3253         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3254         (ConfigTest.assert_configuration):
3255         (ConfigTest.test_build_directory.mock_webkit_build_directory):
3256         (ConfigTest.test_build_directory):
3257         (ConfigTest.test_default_configuration__notfound):
3258         * Scripts/webkitpy/layout_tests/port/webkit.py:
3259         (WebKitPort._build_path):
3260         Cache the root directory in the options object so that other users
3261         of the options object don't need to call out to webkit-build-directory.
3262
3263 2012-01-30  Ojan Vafai  <ojan@chromium.org>
3264
3265         Parsing test_expecations.txt + Skipped lists takes too long
3266         https://bugs.webkit.org/show_bug.cgi?id=77059
3267
3268         Reviewed by Dirk Pranke.
3269
3270         This saves ~100ms on the Apple Mac port.
3271         -memoize a bunch of path methods.
3272         -Avoid doing multiple disk accesses per line.
3273         -Parse the skipped list directly instead of turning it into a test_expecations.txt
3274         formatting string and parsing that.
3275
3276         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3277         (TestExpectationParser):
3278         (TestExpectationParser.expectation_for_skipped_test):
3279         (TestExpectationParser._parse_line):
3280         (TestExpectationParser._collect_matching_tests):
3281         (TestExpectations.__init__):
3282         (TestExpectations._add_skipped_tests):
3283         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3284         (test_add_skipped_tests):
3285         (test_add_skipped_tests_duplicate):
3286         * Scripts/webkitpy/layout_tests/port/base.py:
3287         (Port):
3288         (Port.test_isfile):
3289         (Port.normalize_test_name):
3290         (Port.layout_tests_dir):
3291         (Port.abspath_for_test):
3292         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3293
3294 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
3295
3296         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
3297         
3298         * Scripts/webkitpy/common/config/watchlist:
3299
3300 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
3301
3302         Unreviewed build fix following bug#76855
3303
3304         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3305         ():
3306         (TestWebKitAPI::TEST_F):
3307
3308 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3309
3310         [Qt] WKTR: Use a software rendering pipiline when running tests.
3311         https://bugs.webkit.org/show_bug.cgi?id=76708
3312
3313         Reviewed by Kenneth Rohde Christiansen.
3314
3315         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3316         (WTR::WrapperWindow::WrapperWindow):
3317         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
3318
3319 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3320
3321         [Qt] Store build config immediately instead of waiting for a successfull build
3322
3323         Otherwise we will not pick up changes to the config if the build is aborted,
3324         for example due to build errors or if the user pressed Ctrl+Z. We now write
3325         the new config before starting a build, but still defer to write the SVN
3326         revision once the build completes successfully.
3327
3328         Reviewed by Ossy.
3329
3330         * Scripts/webkitdirs.pm:
3331         (buildQMakeProjects):
3332
3333 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
3334
3335         [Qt] Add "New Window" button to the Qt MiniBrowser
3336         https://bugs.webkit.org/show_bug.cgi?id=77281
3337
3338         Reviewed by Tor Arne Vestbø.
3339
3340         * MiniBrowser/qt/BrowserWindow.cpp:
3341         (BrowserWindow::BrowserWindow):
3342         * MiniBrowser/qt/MiniBrowser.qrc:
3343         * MiniBrowser/qt/icons/plus.png: Added.
3344         * MiniBrowser/qt/qml/BrowserWindow.qml:
3345
3346 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
3347
3348         Unreviewed rolling out r106222.
3349
3350         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3351         (SingleTestRunner.__init__):
3352         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3353         (Worker.handle_test_list):
3354         * Scripts/webkitpy/layout_tests/models/test_input.py:
3355         (TestInput.__init__):
3356         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3357         (_set_up_derived_options):
3358         (parse_args):
3359         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3360         (MainTest.test_repeat_each):
3361         * WebKitTestRunner/TestInvocation.cpp:
3362         (WTR::TestInvocation::setIsPixelTest):
3363
3364 2012-01-30  Hans Wennborg  <hans@chromium.org>
3365
3366         Unreviewed, rolling out r106219.
3367         http://trac.webkit.org/changeset/106219
3368         https://bugs.webkit.org/show_bug.cgi?id=77083
3369
3370         This broke Chromium's test_shell.
3371
3372         * DumpRenderTree/DumpRenderTree.gypi:
3373         * DumpRenderTree/chromium/LayoutTestController.cpp:
3374         (LayoutTestController::addMockSpeechInputResult):
3375         * DumpRenderTree/chromium/LayoutTestController.h:
3376         (WebKit):
3377         (LayoutTestController):
3378         ():
3379         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
3380         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
3381         * DumpRenderTree/chromium/TestShell.cpp:
3382         * DumpRenderTree/chromium/WebViewHost.cpp:
3383         (WebViewHost::speechInputController):
3384         * DumpRenderTree/chromium/WebViewHost.h:
3385         (WebKit):
3386         (WebViewHost::speechInputControllerMock):
3387         (WebViewHost):
3388         ():
3389
3390 2012-01-26  Hans Wennborg  <hans@chromium.org>
3391
3392         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
3393         https://bugs.webkit.org/show_bug.cgi?id=77083
3394
3395         Reviewed by Darin Fisher.
3396
3397         Add MockWebSpeechInputController which provides a mock implementation
3398         of the WebSpeechInputController interface, and use that in
3399         DumpRenderTree.
3400
3401         * DumpRenderTree/DumpRenderTree.gypi:
3402         * DumpRenderTree/chromium/LayoutTestController.cpp:
3403         (LayoutTestController::addMockSpeechInputResult):
3404         * DumpRenderTree/chromium/LayoutTestController.h:
3405         ():
3406         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
3407         (MockWebSpeechInputController::create):
3408         (MockWebSpeechInputController::addMockRecognitionResult):
3409         (MockWebSpeechInputController::clearResults):
3410         (MockWebSpeechInputController::startRecognition):
3411         (MockWebSpeechInputController::cancelRecognition):
3412         (MockWebSpeechInputController::stopRecording):
3413         (MockWebSpeechInputController::MockWebSpeechInputController):
3414         (MockWebSpeechInputController::speechTaskFired):
3415         (MockWebSpeechInputController::SpeechTask::SpeechTask):
3416         (MockWebSpeechInputController::SpeechTask::stop):
3417         (MockWebSpeechInputController::SpeechTask::runIfValid):
3418         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
3419         (WebKit):
3420         (MockWebSpeechInputController):
3421         (MockWebSpeechInputController::taskList):
3422         (SpeechTask):
3423         * DumpRenderTree/chromium/TestShell.cpp:
3424         * DumpRenderTree/chromium/WebViewHost.cpp:
3425         (WebViewHost::speechInputController):
3426         * DumpRenderTree/chromium/WebViewHost.h:
3427         (WebKit):
3428         (WebViewHost::speechInputControllerMock):
3429         (WebViewHost):
3430         ():
3431
3432 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3433
3434         Unreviewed, rolling out r106109.
3435         http://trac.webkit.org/changeset/106109
3436         https://bugs.webkit.org/show_bug.cgi?id=77302
3437
3438         It made tests crash (Requested by Ossy_weekend on #webkit).
3439
3440         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3441         (WTR::WrapperWindow::WrapperWindow):
3442         (WTR::PlatformWebView::PlatformWebView):
3443
3444 2012-01-28  Nico Weber  <thakis@chromium.org>
3445
3446         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
3447         https://bugs.webkit.org/show_bug.cgi?id=77243
3448
3449         Reviewed by Adam Barth.
3450
3451         * Scripts/update-webkit:
3452         * Scripts/webkitdirs.pm:
3453         (isChromiumNinja):
3454         (determineIsChromiumNinja):
3455         (buildChromiumNinja):
3456         (buildChromium):
3457
3458 2012-01-27  Kentaro Hara  <haraken@chromium.org>
3459
3460         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
3461         https://bugs.webkit.org/show_bug.cgi?id=77241
3462
3463         Reviewed by Ryosuke Niwa.
3464
3465         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
3466         in a method in some namespace or class is treated as a method.
3467         This patch fixes the bug.
3468
3469             class C {
3470                 void func()
3471                 {
3472                     if (1) {    // This should not be treated as a method.
3473                     }
3474                 }
3475             };
3476
3477         * Scripts/prepare-ChangeLog:
3478         (get_function_line_ranges_for_cpp):
3479         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
3480         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
3481         (Class108):
3482         (Class108::func35):
3483
3484 2012-01-27  Enrica Casucci  <enrica@apple.com>
3485
3486         Followup to http://trac.webkit.org/changeset/106171.
3487         Dan Bernstein pointed out correctly that I should
3488         have used copy instead of initWithString.
3489
3490         Reviewed by Dan Bernstein.
3491
3492         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3493         (-[LocalPasteboard initWithName:]):
3494
3495 2012-01-27  Enrica Casucci  <enrica@apple.com>
3496
3497         DRT pasteboard object should return the correct pasteboard name.
3498         https://bugs.webkit.org/show_bug.cgi?id=77260
3499         
3500         Currently the name property always returns nil.
3501         Adding a memeber variable to store the pasteboard name and return its
3502         value from the name method instead of returning nil always.
3503
3504         Reviewed by Dan Bernstein.
3505
3506         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
3507         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
3508         (-[LocalPasteboard initWithName:]):
3509         (-[LocalPasteboard name]):
3510
3511 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
3512
3513         [GTK] [WK2] Implement the policy client
3514         https://bugs.webkit.org/show_bug.cgi?id=76343
3515
3516         Reviewed by Gustavo Noronha Silva.
3517
3518         * gtk/generate-gtkdoc:
3519         (get_webkit2_options): Update the list of skipped source files to include all clients.
3520
3521 2012-01-27  Ada Chan  <adachan@apple.com>
3522
3523         Add test for WKBundleFrameGetParentFrame().
3524         https://bugs.webkit.org/show_bug.cgi?id=77161
3525
3526         Reviewed by Anders Carlsson.
3527
3528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
3529         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
3530         (TestWebKitAPI):
3531         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
3532         (TestWebKitAPI::setInjectedBundleClient):
3533         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
3534         Make sure the check is successful.
3535         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
3536         (TestWebKitAPI):
3537         (ParentFrameTest):
3538         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
3539         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
3540         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
3541         to the test controller.
3542         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
3543
3544 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
3545
3546         [Gtk] DumpRenderTree lacks --no-timeout command line option
3547         https://bugs.webkit.org/show_bug.cgi?id=77196
3548
3549         Reviewed by Martin Robinson.
3550
3551         Add the --no-timeout command line option and reorganize
3552         watchdog code to make running DumpRenderTree without
3553         timeout possible.
3554
3555         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3556         (setWaitToDumpWatchdog):
3557         (shouldSetWaitToDumpWatchdog):
3558         (initializeGlobalsFromCommandLineOptions):
3559         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
3560         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3561         (waitToDumpWatchdogFired):
3562         (LayoutTestController::setWaitToDump):
3563
3564 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
3565
3566         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
3567         https://bugs.webkit.org/show_bug.cgi?id=77122
3568
3569         Reviewed by Kenneth Rohde Christiansen.
3570
3571         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3572         (MiniBrowserApplication::MiniBrowserApplication):
3573
3574 2012-01-27  Zeno Albisser  <zeno@webkit.org>
3575
3576         [Qt][Mac] Build fails after adding ICU support (r105997).
3577         https://bugs.webkit.org/show_bug.cgi?id=77118
3578
3579         Define WTF_USE_ICU_UNICODE if we are on mac.
3580
3581         Reviewed by Tor Arne Vestbø.
3582
3583         * qmake/mkspecs/features/features.prf:
3584
3585 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
3586
3587         Update committers.py with new contributors.
3588         https://bugs.webkit.org/show_bug.cgi?id=77207
3589
3590         I added six new contributors into committers.py:
3591
3592         - Adam Kallai
3593         - Balazs Ankes
3594         - Janos Badics
3595         - Nandor Huszka
3596         - Roland Takacs
3597         - Szilard Ledan-Muntean
3598
3599         * Scripts/webkitpy/common/config/committers.py:
3600
3601 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
3602
3603         Add Vsevolod Vlasov to reviewers list.
3604
3605         Reviewed by Pavel Feldman.
3606
3607         * Scripts/webkitpy/common/config/committers.py:
3608
3609 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3610
3611         [Qt] WKTR: Use a software rendering pipiline when running tests.
3612         https://bugs.webkit.org/show_bug.cgi?id=76708
3613
3614         Reviewed by Kenneth Rohde Christiansen.
3615
3616         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3617         (WTR::WrapperWindow::WrapperWindow):
3618         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
3619
3620 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
3621
3622         [wx] Unreviewed. Build fix, add WebCore/testing/js
3623         to the list of source directories we build.
3624
3625         * waf/build/settings.py:
3626
3627 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
3628
3629         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
3630         https://bugs.webkit.org/show_bug.cgi?id=77177
3631
3632         Reviewed by Jon Honeycutt.
3633
3634         * Scripts/commit-log-editor:
3635
3636 2012-01-26  Ojan Vafai  <ojan@chromium.org>
3637
3638         Decrease sleep time when killing server_process on Mac.
3639         https://bugs.webkit.org/show_bug.cgi?id=77169
3640
3641         Reviewed by Eric Seidel.
3642
3643         This shaves another ~70ms off single test runtime.
3644
3645         * Scripts/webkitpy/layout_tests/port/server_process.py:
3646         (ServerProcess.stop):
3647
3648 2012-01-26  Ojan Vafai  <ojan@chromium.org>
3649
3650         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
3651         https://bugs.webkit.org/show_bug.cgi?id=77164
3652
3653         Reviewed by Dirk Pranke.
3654
3655         http://trac.webkit.org/changeset/106035 depends on builder_name being
3656         falsey by default. There's other code that requires it to be iterable
3657         by default. So, make it be the empty string.
3658
3659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3660         (parse_args):
3661
3662 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
3663
3664         run-perf-test should include relative file paths in test names
3665         https://bugs.webkit.org/show_bug.cgi?id=77144
3666
3667         Reviewed by Adam Birth.
3668
3669         Include all directory names in the test name separated by "/".
3670         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
3671
3672         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3673         (PerfTestsRunner):
3674         (PerfTestsRunner._process_parser_test_result):
3675         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3676         (test_run_test_set_with_json_output):
3677         (test_run_test_set_with_json_source):
3678
3679 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
3680
3681         webkitpy: re-land cleanup of test scaffolding
3682         https://bugs.webkit.org/show_bug.cgi?id=77153
3683
3684         Reviewed by Eric Seidel.
3685
3686         This is an attempt to reland the change in bug 76973 / 
3687         r105935. My earlier attempt to manipulate PYTHONPATH
3688         seems to only work some of the time, for reasons that
3689         elude me. Directly adding Tools/Scripts to sys.path from
3690         inside the test script appears to work (more?) reliably.
3691
3692         Also, it seemed like the files didn't actually get deleted
3693         the last time; I don't know why.
3694
3695         * Scripts/test-webkitpy:
3696         * Scripts/webkitpy/common/system/executive_unittest.py: