Wrap bot types inside ().
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-12  Lucas Forschler  <lforschler@apple.com>
2
3         Wrap bot types inside ().
4         https://bugs.webkit.org/show_bug.cgi?id=88893
5         
6         Reviewed by Stephanie Lewis.
7
8         * BuildSlaveSupport/build.webkit.org-config/config.json:
9
10 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
11
12         [soup] Prevent setting or editing httpOnly cookies from JavaScript
13         https://bugs.webkit.org/show_bug.cgi?id=88760
14
15         Reviewed by Gustavo Noronha Silva.
16
17         Update libsoup to v2.39.2, glib to v2.33.2 and glib-networking
18         to v2.33.2 for both GTK and EFL ports.
19
20         * efl/jhbuild.modules:
21         * gtk/jhbuild.modules:
22
23 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
24
25         [EFL] Enable SHADOW_DOM flag
26         https://bugs.webkit.org/show_bug.cgi?id=87732
27
28         Reviewed by Kentaro Hara.
29
30         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
31         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Enable
32         SHADOW_DOM by default in DRT.
33         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
34         (onFocusCanCycle): Enable focus cycling in EFL DRT to behave like
35         Chromium and Mac ports.
36         (drtViewAdd):
37         * Scripts/webkitperl/FeatureList.pm: Enable SHADOW_DOM flag by default
38         at compile time for EFL port.
39
40 2012-06-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
41
42         WinLauncher should show loading errors
43         https://bugs.webkit.org/show_bug.cgi?id=80760
44
45         Reviewed by Brent Fulgham.
46
47         * WinLauncher/WinLauncher.cpp: Added load-fail handler to show messagebox with error.
48         (WinLauncherWebHost::didFailProvisionalLoadWithError):
49         * WinLauncher/WinLauncher.h:
50         (WinLauncherWebHost::didFailProvisionalLoadWithError):
51         (WinLauncherWebHost):
52
53 2012-06-12  Ryuan Choi  <ryuan.choi@samsung.com>
54
55         [EFL][WK2] Add MiniBrowserEfl.
56         https://bugs.webkit.org/show_bug.cgi?id=61850
57
58         Reviewed by Chang Shu.
59
60         Implement MiniBrowser for EFL.
61
62         * CMakeLists.txt:
63         * MiniBrowser/efl/CMakeLists.txt: Added.
64         * MiniBrowser/efl/main.c: Added.
65         (_MiniBrowser):
66         (main_signal_exit):
67         (on_ecore_evas_resize):
68         (browserCreate):
69         (main):
70
71 2012-06-12  Helder Correia  <helder.correia@nokia.com>
72
73         Unreviewed. Update my email address in committers.py.
74
75         * Scripts/webkitpy/common/config/committers.py:
76
77 2012-06-12  Dominik Röttsches  <dominik.rottsches@intel.com>
78
79         [EFL] Resolve CMake warnings on overlapping search paths for EFL jhbuild-enabled build
80         https://bugs.webkit.org/show_bug.cgi?id=84707
81
82         Fixing CMAKE prefix path for 64bit systems to avoid CMAKE warnings on those.
83         use_lib64 variable is preconfigured to True by jhbuild.
84
85         Reviewed by Dirk Pranke.
86
87         * efl/jhbuildrc:
88
89 2012-06-12  Dana Jansens  <danakj@chromium.org>
90
91         Add zlieber@chromium.org to contributors list
92         https://bugs.webkit.org/show_bug.cgi?id=88904
93
94         Unreviewed.
95
96         * Scripts/webkitpy/common/config/committers.py:
97
98 2012-06-12  Lucas Forschler  <lforschler@apple.com>
99
100         Rename Apple bots to a standard convention.
101         https://bugs.webkit.org/show_bug.cgi?id=88893
102         
103         Note: This has the side effect of grouping all of the Apple bots together in the waterfall.
104
105         Reviewed by Simon Fraser.
106
107         * BuildSlaveSupport/build.webkit.org-config/config.json:
108
109 2012-06-12  Mike West  <mkwst@chromium.org>
110
111         Make document.documentURI readonly from JavaScript
112         https://bugs.webkit.org/show_bug.cgi?id=65187
113
114         Reviewed by Alexey Proskuryakov.
115
116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
117         * TestWebKitAPI/Tests/mac/SetDocumentURI.html: Added.
118         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm: Added.
119         (-[SetDocumentURITest webView:didFinishLoadForFrame:]):
120         (TestWebKitAPI):
121         (TestWebKitAPI::TEST):
122
123 2012-06-12  Christophe Dumez  <christophe.dumez@intel.com>
124
125         [EFL] enable LEGACY_WEBKIT_BLOB_BUILDER flag
126         https://bugs.webkit.org/show_bug.cgi?id=88715
127
128         Reviewed by Noam Rosenthal.
129
130         Enable LEGACY_WEBKIT_BLOB_BUILDER flag by default on EFL port.
131
132         * Scripts/webkitperl/FeatureList.pm:
133
134 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
135
136         [Qt] Fix -Werror for the buildbots
137         https://bugs.webkit.org/show_bug.cgi?id=88223
138
139         Rubber-stamped by Tor Arne Vestbø.
140
141         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
142
143         * qmake/mkspecs/features/unix/default_post.prf:
144
145 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
146
147         [REGRESSION][WTR] Build fail with werror after r120054
148         https://bugs.webkit.org/show_bug.cgi?id=88862
149
150         Reviewed by Csaba Osztrogonác.
151
152         Some static helpers become unused after counterValueForElementById
153         has moved to Internals. Let's remove them.
154
155         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
156         (WTR):
157
158 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
159
160         [Qt] Slave losts cause build break on bots
161         https://bugs.webkit.org/show_bug.cgi?id=38980
162
163         Minor fix after r59261.
164
165         Reviewed by Tor Arne Vestbø.
166
167         * Scripts/build-webkit:
168         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
169
170 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
171
172         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
173         https://bugs.webkit.org/show_bug.cgi?id=84406
174
175         Reviewed by Hajime Morita.
176
177         Move the counterValueForElementById from LayoutTestCotroller to Internals and
178         remove the old platform specific implementations as it exclusively tests WebCore functionality.
179
180         * DumpRenderTree/LayoutTestController.cpp:
181         (LayoutTestController::staticFunctions):
182         * DumpRenderTree/LayoutTestController.h:
183         (LayoutTestController):
184         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
185         * DumpRenderTree/chromium/LayoutTestController.cpp:
186         (LayoutTestController::LayoutTestController):
187         (LayoutTestController::setPOSIXLocale):
188         * DumpRenderTree/chromium/LayoutTestController.h:
189         (LayoutTestController):
190         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
191         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
192         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
193         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
194         * DumpRenderTree/qt/LayoutTestControllerQt.h:
195         (LayoutTestController):
196         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
197         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
198         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
199         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
200         (WTR):
201         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
202         (LayoutTestController):
203
204 2012-06-11  Hans Wennborg  <hans@chromium.org>
205
206         Speech JavaScript API: Make SpeechRecognitionError an Event
207         https://bugs.webkit.org/show_bug.cgi?id=88784
208
209         Reviewed by Adam Barth.
210
211         Make it possible to have MockWebSpeechRecognizer fire error events.
212
213         * DumpRenderTree/chromium/LayoutTestController.cpp:
214         (LayoutTestController::LayoutTestController):
215         (LayoutTestController::setMockSpeechRecognitionError):
216         * DumpRenderTree/chromium/LayoutTestController.h:
217         (LayoutTestController):
218         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
219         (WebKit):
220         (ErrorTask):
221         (WebKit::ErrorTask::ErrorTask):
222         (MockWebSpeechRecognizer::addMockResult):
223         (MockWebSpeechRecognizer::setError):
224         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
225         (MockWebSpeechRecognizer):
226
227 2012-06-11  Ojan Vafai  <ojan@chromium.org>
228
229         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
230         https://bugs.webkit.org/show_bug.cgi?id=88836
231
232         Reviewed by Dirk Pranke.
233
234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
236
237 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
238
239         [EFL] Remove CMakeCache.txt before building
240         https://bugs.webkit.org/show_bug.cgi?id=88717
241
242         Reviewed by Antonio Gomes.
243
244         Remove CMake cache file before every build to avoid using outdated
245         build flags when new features get enabled. This will avoid unexpected
246         failures on the bots due to outdated build flags.
247
248         * Scripts/webkitdirs.pm:
249         (generateBuildSystemFromCMakeProject):
250
251 2012-06-11  Vincent Scheib  <scheib@chromium.org>
252
253         Add new Pointer Lock spec attribute webkitPointerLockElement.
254         https://bugs.webkit.org/show_bug.cgi?id=88799
255
256         Reviewed by Dimitri Glazkov.
257
258         Part of a series of refactoring changes to update pointer lock API to
259         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
260
261         New attribute webkitPointerLockElement added. Follow up patches
262         will remove the previous isLocked attribute. Tests updated to use
263         the new attribute.
264
265         WebViewHost logic required modification to correctly repond to
266         a lock, unlock, pointerLockElement call series. Specifically,
267         unlocking must be queued after a lock command is issued always
268         as the lock state may not be set yet with a lock request in flight.
269
270         * DumpRenderTree/chromium/WebViewHost.cpp:
271         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
272         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
273
274 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
275
276         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
277         https://bugs.webkit.org/show_bug.cgi?id=88804
278
279         Reviewed by Tony Chang.
280
281         Protect box-decoration-break behind a feature flag enabled by default.
282
283         * Scripts/webkitperl/FeatureList.pm:
284         * qmake/mkspecs/features/features.pri:
285
286 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
287
288         [CMAKE][EFL] Remove duplicated executable output path
289         https://bugs.webkit.org/show_bug.cgi?id=88765
290
291         Reviewed by Daniel Bates.
292
293         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
294         need to define again because it is already defined in top-level CMake file.
295
296         * DumpRenderTree/efl/CMakeLists.txt:
297         * EWebLauncher/CMakeLists.txt:
298
299 2012-06-11  Ojan Vafai  <ojan@chromium.org>
300
301         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
302         https://bugs.webkit.org/show_bug.cgi?id=88816
303
304         Reviewed by Dirk Pranke.
305
306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
307         Expose a way to clear AsynchronousCaches.
308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
310         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
311
312 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
313
314         nrwt exits early too frequently
315         https://bugs.webkit.org/show_bug.cgi?id=73843
316
317         Reviewed by Ryosuke Niwa.
318
319         Change the defaults for new-run-webkit-tests for both
320         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
321         to zero (i.e., we will never exit early by default).
322
323         If people want their buildbots to exit early it is their
324         responsibility to update their buildbot configs appropriately.
325
326         Note that we have tests that ensure that these flags work for
327         non-zero numbers, but we don't have tests that either test the
328         default or ensure that zero means "run all of the tests". I
329         think that's okay but can add tests if others disagree.
330
331         Also note that it looks like no changes on the build.webkit.org
332         master.cfg are necessary; all of the bots seem to be using the
333         RunWebKitTests wrapper which is already setting the flags. There
334         is a NewRunWebKitTests wrapper, but that looks to be unused; I
335         will delete that in a separate patch.
336
337         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
338         (parse_args):
339
340 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
341
342         [EFL] [DRT] Reset CacheModel before running each test
343         https://bugs.webkit.org/show_bug.cgi?id=87534
344
345         Reviewed by Gustavo Noronha Silva.
346
347         Reset cache model to default before running each test to fix some
348         flaky tests on EFL build bots. Also fix case value in setCacheModel.
349
350         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
351         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
352         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
353         (LayoutTestController::setCacheModel):
354
355 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
356
357         [GTK] Memory leaks in DRT EventSender.cpp
358         https://bugs.webkit.org/show_bug.cgi?id=88774
359
360         Reviewed by Martin Robinson.
361
362         Fix a few possible memory leaks in EventSender code.
363
364         * DumpRenderTree/gtk/EventSender.cpp:
365         (contextClickCallback): Free the event returned by gdk_event_new().
366         (mouseDownCallback): Ditto.
367         (mouseUpCallback): Ditto.
368
369 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
370
371         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
372         https://bugs.webkit.org/show_bug.cgi?id=88661
373
374         Reviewed by Dirk Pranke.
375
376         Pass string length explicitly when creating String object from
377         non-null-terminated UChar* returned by characters().
378
379         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
380         (LayoutTestController::pathToLocalResource):
381
382 2012-06-11  David Dorwin  <ddorwin@chromium.org>
383
384         [chromium] Provide access to the WebPlugin created by the helper plugin widget
385         https://bugs.webkit.org/show_bug.cgi?id=88028
386
387         Reviewed by Adam Barth.
388
389         Added isPlaceholder() to WebPlugin.
390
391         * DumpRenderTree/chromium/TestWebPlugin.h:
392         (TestWebPlugin::isPlaceholder):
393
394 2012-06-11  Tony Chang  <tony@chromium.org>
395
396         rebaseline from garden-o-matic leaves N processes each time it is run
397         https://bugs.webkit.org/show_bug.cgi?id=88586
398
399         Reviewed by Dirk Pranke.
400
401         This appears to only be a problem on python 2.7. Maybe a bug causing
402         pools to not be garbage collected?
403
404         * Scripts/webkitpy/common/system/executive.py:
405         (Executive.run_in_parallel): close() and join() the process pool.
406         * Scripts/webkitpy/common/system/executive_unittest.py:
407         (ExecutiveTest.test_run_in_parallel):
408
409 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
410
411         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
412         https://bugs.webkit.org/show_bug.cgi?id=87841
413
414         Reviewed by Simon Hausmann.
415
416         * qmake/config.tests/libwebp/libwebp.cpp: Added.
417         (main):
418         * qmake/config.tests/libwebp/libwebp.pro: Added.
419         * qmake/sync.profile:
420
421 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
422
423         Expose layoutTestController as testRunner
424         https://bugs.webkit.org/show_bug.cgi?id=88210
425
426         Reviewed by Darin Adler.
427
428         * DumpRenderTree/LayoutTestController.cpp:
429         (LayoutTestController::makeWindowObject):
430         * DumpRenderTree/chromium/TestShell.cpp:
431         (TestShell::bindJSObjectsToWindow):
432         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
433         (WebCore::DumpRenderTree::initJSObjects):
434         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
435         (WTR::LayoutTestController::makeWindowObject):
436
437 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
438
439         [Chromium] Remove JavaScriptCore dependencies from gyp
440         https://bugs.webkit.org/show_bug.cgi?id=88510
441
442         Reviewed by Adam Barth.
443
444         Chromium doesn't support JSC any more and there doesn't seem to be
445         a strong interest in using GYP as the common build system in other
446         ports.
447
448         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
449         * Scripts/generate-project-files: Removed.
450
451 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
452
453         Add UNDO_MANAGER flag
454         https://bugs.webkit.org/show_bug.cgi?id=87908
455
456         Reviewed by Tony Chang.
457
458         * Scripts/webkitperl/FeatureList.pm:
459         * qmake/mkspecs/features/features.pri:
460
461 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
462
463         webkit-patch land-safely should set cq? if the patch author is not in committers.py
464         https://bugs.webkit.org/show_bug.cgi?id=88689
465
466         Reviewed by Dirk Pranke.
467
468         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
469         in committers.py or the contributor cannot commit. If anything, the contributor can still
470         set cq+ on thier patches manually so I don't think this will be an issue for people who
471         don't list their Bugzille email on committers.py.
472
473         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
474         (Bugzilla._commit_queue_flag):
475         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
476         (test_commit_queue_flag):
477         (test_commit_queue_flag.assert_commit_queue_flag):
478
479 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
480
481         remove obsolete NewRunWebKitTests buildbot master factory classes
482         https://bugs.webkit.org/show_bug.cgi?id=88693
483
484         Reviewed by Ryosuke Niwa.
485
486         I believe these aren't used any more ...
487
488         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
489         (RunWebKitTests.getText2):
490         (BuildAndTestLeaksFactory):
491
492 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
493
494         [Chromium-Android] Build DumpRenderTree with Android SDK
495         https://bugs.webkit.org/show_bug.cgi?id=88598
496
497         Change WebKit side of DRT related code according to some recent changes at chromium side.
498
499         Reviewed by Adam Barth.
500
501         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
502         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
503         (ChromiumAndroidPort.__init__):
504         (ChromiumAndroidPort._path_to_driver):
505
506 2012-06-08  Wei James  <james.wei@intel.com>
507
508         Add app_abi option for DumpRenderTree_apk
509         https://bugs.webkit.org/show_bug.cgi?id=88626
510
511         Reviewed by Adam Barth.
512
513         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
514
515 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
516
517         [GTK] Add API to get the library version to WebKit2 GTK+
518         https://bugs.webkit.org/show_bug.cgi?id=88426
519
520         Reviewed by Martin Robinson.
521
522         * gtk/generate-gtkdoc:
523         (get_webkit2_options): Add built sources to the list of files, but
524         ignore enum types and marshallers.
525
526 2012-06-07  Vincent Scheib  <scheib@chromium.org>
527
528         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
529         https://bugs.webkit.org/show_bug.cgi?id=88604
530
531         Reviewed by Kent Tamura.
532
533         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
534         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
535
536         * DumpRenderTree/chromium/WebViewHost.cpp:
537         (WebViewHost::requestPointerUnlock):
538
539 2012-06-08  Hans Wennborg  <hans@chromium.org>
540
541         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
542         https://bugs.webkit.org/show_bug.cgi?id=87976
543
544         Reviewed by Kent Tamura.
545
546         Provide a mock implementation of WebSpeechRecognizer for
547         DumpRenderTree. This will allow better testing of the API via layout
548         tests.
549
550         * DumpRenderTree/DumpRenderTree.gypi:
551         * DumpRenderTree/chromium/LayoutTestController.cpp:
552         (LayoutTestController::LayoutTestController):
553         (LayoutTestController::addMockSpeechRecognitionResult):
554         * DumpRenderTree/chromium/LayoutTestController.h:
555         (LayoutTestController):
556         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
557         (MockWebSpeechRecognizer::create):
558         (MockWebSpeechRecognizer::start):
559         (MockWebSpeechRecognizer::stop):
560         (MockWebSpeechRecognizer::abort):
561         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
562         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
563         (MockWebSpeechRecognizer::ResultTask::runIfValid):
564         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
565         (WebKit):
566         (MockWebSpeechRecognizer):
567         (MockWebSpeechRecognizer::addMockResult):
568         (MockWebSpeechRecognizer::taskList):
569         (ClientCallTask):
570         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
571         (ResultTask):
572         (MockWebSpeechRecognizer::ResultTask::ResultTask):
573         (NoMatchTask):
574         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
575         * DumpRenderTree/chromium/WebViewHost.cpp:
576         (WebViewHost::speechRecognizer):
577         * DumpRenderTree/chromium/WebViewHost.h:
578         (WebViewHost):
579         (WebViewHost::mockSpeechRecognizer):
580
581 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
582
583         check-webkit-style needs to be taught about <public/Foo.h>
584         https://bugs.webkit.org/show_bug.cgi?id=88524
585
586         Reviewed by David Levin.
587
588         * Scripts/webkitpy/style/checkers/cpp.py:
589         (_classify_include):
590         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
591         (OrderOfIncludesTest.test_public_primary_header):
592         (OrderOfIncludesTest.test_classify_include):
593
594 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
595
596         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
597         https://bugs.webkit.org/show_bug.cgi?id=67255
598
599         Reviewed by Dirk Pranke.
600
601         Implement pathToLocalResource to redirect file:///tmp URL's to
602         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
603         LayoutTests sub-directory of the WebKit source tree.
604
605         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
606         (LayoutTestController::pathToLocalResource):
607
608 2012-06-07  Tony Payne  <tpayne@chromium.org>
609
610         [chromium] Allow LayoutTests under new git workflow
611         https://bugs.webkit.org/show_bug.cgi?id=88575
612
613         On Windows, chromium indirects through git.bat. Adds the same hack that
614         is currently used for discovering svn.bat to support the new git
615         workflow.
616
617         Reviewed by Dirk Pranke.
618
619         * Scripts/webkitpy/common/checkout/scm/git.py:
620         (Git): Replaces all hard-coded references to 'git' with the class
621         variable executable_name.
622         (Git._check_git_architecture):
623         (Git.in_working_directory):
624         (Git.find_checkout_root):
625         (Git.read_git_config):
626         (Git.discard_local_commits):
627         (Git.local_commits):
628         (Git.working_directory_is_clean):
629         (Git.clean_working_directory):
630         (Git.status_command):
631         (Git.add_list):
632         (Git.delete_list):
633         (Git.exists):
634         (Git._current_branch):
635         (Git.changed_files):
636         (Git._changes_files_for_commit):
637         (Git.revisions_changing_file):
638         (Git.conflicted_files):
639         (Git.svn_revision):
640         (Git.create_patch):
641         (Git._run_git_svn_find_rev):
642         (Git.contents_at_revision):
643         (Git.diff_for_file):
644         (Git.show_head):
645         (Git.committer_email_for_revision):
646         (Git.apply_reverse_diff):
647         (Git.revert_files):
648         (Git.commit_with_message):
649         (Git._commit_on_branch):
650         (Git.svn_commit_log):
651         (Git.last_svn_commit_log):
652         (Git.svn_blame):
653         (Git._branch_ref_exists):
654         (Git.delete_branch):
655         (Git.remote_merge_base):
656         (Git.commit_locally_with_message):
657         (Git.push_local_commits_to_server):
658         (Git.commit_ids_from_commitish_arguments):
659         (Git.commit_message_for_local_commit):
660         (Git.files_changed_summary_for_commit):
661         * Scripts/webkitpy/common/host.py:
662         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
663         that duplicates the logic in the existing 'svn.bat' hack.
664
665 2012-06-07  Ojan Vafai  <ojan@chromium.org>
666
667         Style build architectures like build versions for non-layout test failures
668         https://bugs.webkit.org/show_bug.cgi?id=88590
669
670         Reviewed by Tony Chang.
671
672         Since we show the list of failing tests after the architecture, we want the
673         buildtype and architecture to be grouped together visually.
674
675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
676         (.effects a.failing-builder>span.architecture):
677
678 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
679
680         [Chromium] Remove header dependency of ImageDiff to WTF
681         https://bugs.webkit.org/show_bug.cgi?id=88422
682
683         Reviewed by Ryosuke Niwa.
684
685         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
686         * DumpRenderTree/chromium/ImageDiff.cpp:
687         (untestedCompareImages):
688
689 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
690
691         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
692         https://bugs.webkit.org/show_bug.cgi?id=88491
693
694         Reviewed by Dirk Pranke.
695
696         DRT should enable WebAudio when WebAudio feature is enabled,
697         so that the WebAudio feature could be tested by the Layouttest.
698
699         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
700         (LayoutTestController::overridePreference):
701
702 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
703
704         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
705         https://bugs.webkit.org/show_bug.cgi?id=88581
706
707         Reviewed by Ojan Vafai.
708
709         webkit-paptch rebaseline-expectations was ignoring what the
710         expected results for a test were and pulling down all the result
711         files from a bot. This could lead to us pulling down old,
712         incorrect .txt or .png files. With this patch we will now only
713         pull down expectations of the appropriate file types (so an
714         IMAGE failure will only pull the png and not the txt file).
715
716         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
717         (has_pixel_failures):
718         (suffixes_for_expectations):
719         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
720         (FunctionsTest.test_suffixes_for_expectations):
721         * Scripts/webkitpy/tool/commands/rebaseline.py:
722         (AbstractRebaseliningCommand.__init__):
723         (RebaselineExpectations._is_supported_port):
724         (RebaselineExpectations._update_expectations_file):
725         (RebaselineExpectations._tests_to_rebaseline):
726         (RebaselineExpectations._rebaseline_port):
727         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
728         (test_overrides_are_included_correctly):
729
730 2012-06-07  Ojan Vafai  <ojan@chromium.org>
731
732         Fix recent null pointer error regression in the flakiness dashboard
733         https://bugs.webkit.org/show_bug.cgi?id=88573
734
735         Reviewed by Dirk Pranke.
736
737         * TestResultServer/static-dashboards/builders.js:
738         (requestBuilderList):
739         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
740
741 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
742
743         Add Konrad Piascik to committers.py
744         https://bugs.webkit.org/show_bug.cgi?id=88560
745
746         Unreviewed.
747
748         * Scripts/webkitpy/common/config/committers.py:
749
750 2012-06-07  Tony Chang  <tony@chromium.org>
751
752         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
753         https://bugs.webkit.org/show_bug.cgi?id=77368
754
755         Reviewed by Ojan Vafai.
756
757         It doesn't look like we ever get a rect with width or height of 0.
758         I ran css1, css2.1, fast/forms, and tables without any crashes.
759
760         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
761         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
762
763 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
764
765         run-webkit-tests --lint-test-files gives an error when run on linux
766         https://bugs.webkit.org/show_bug.cgi?id=88551
767
768         Reviewed by Ojan Vafai.
769
770         We weren't mapping the expectations properly for the
771         google-chrome ports.
772
773         * Scripts/webkitpy/layout_tests/port/base.py:
774         (Port.path_to_test_expectations_file):
775         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
776         (TestGoogleChromePort.test_path_to_expectations):
777
778 2012-06-07  Daniel Erat  <derat@chromium.org>
779
780         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
781         https://bugs.webkit.org/show_bug.cgi?id=88263
782
783         Reviewed by Tony Chang.
784
785         * DumpRenderTree/chromium/LayoutTestController.cpp:
786         (LayoutTestController::LayoutTestController):
787         (LayoutTestController::reset):
788         (LayoutTestController::setTextSubpixelPositioning):
789         * DumpRenderTree/chromium/LayoutTestController.h:
790         (LayoutTestController):
791         * DumpRenderTree/chromium/fonts.conf:
792
793 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
794
795         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
796         https://bugs.webkit.org/show_bug.cgi?id=88060
797
798         Reviewed by Martin Robinson.
799
800         Spin the main loop before acquiring the pixel content. This ensures things
801         like late size allocations are finished before calling gtk_widget_draw,
802         avoiding assertions and subsequent empty pixel results.
803
804         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
805         (createBitmapContextFromWebView):
806
807 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
808
809         [Qt] Improve the visual of the viewport info box
810         https://bugs.webkit.org/show_bug.cgi?id=88410
811
812         Reviewed by Tor Arne Vestbø.
813
814         Improve the visual and make it possible to see the content more easy.
815
816         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
817
818 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
819
820         [EFL][WK2] Compile webkit1 and webkit2 by default.
821         https://bugs.webkit.org/show_bug.cgi?id=85041
822
823         Reviewed by Chang Shu.
824
825         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
826         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
827
828         * Scripts/build-webkit:
829
830 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
831
832         Unreviewed, rolling out r119662.
833         http://trac.webkit.org/changeset/119662
834         https://bugs.webkit.org/show_bug.cgi?id=88487
835
836         Broke builds (Requested by rniwa on #webkit).
837
838         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
839         * DumpRenderTree/chromium/ImageDiff.cpp:
840         (untestedCompareImages):
841
842 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
843
844         [Chromium] Remove header dependency of ImageDiff to WTF
845         https://bugs.webkit.org/show_bug.cgi?id=88422
846
847         Reviewed by Adam Barth.
848
849         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
850         * DumpRenderTree/chromium/ImageDiff.cpp:
851         (untestedCompareImages):
852
853 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
854
855         [WebKit] DeviceOrientation cleanup
856         https://bugs.webkit.org/show_bug.cgi?id=88406
857
858         Reviewed by Kent Tamura.
859
860         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
861
862         * DumpRenderTree/chromium/LayoutTestController.cpp:
863         (LayoutTestController::setMockDeviceOrientation):
864
865 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
866
867         webkitpy: add support for an ordered dict of test expectations
868         https://bugs.webkit.org/show_bug.cgi?id=87802
869
870         Reviewed by Ojan Vafai.
871
872         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
873         support a cascaded list of test expectations files. An easy way
874         to think of this is as an ordered dictionary of name -> contents
875         for files, where the name is usually a path on disk (I say
876         usually because we want to support other kinds of expectations
877         like the compile-time skips for unsupported features in
878         webkit.py, and we want to continue to support "in-memory" test
879         expectations that don't require a filesystem).
880
881         Conveniently there is an OrderedDict implementation in Python
882         2.7+ and it is available as a backport, so the first step in
883         adding this support is to use that implementation. Subsequent
884         patches will update the test_expectations.py module (and other
885         callers) to access the dict directly.
886
887         This patch just changes the base internal implementation and
888         provides wrappers for compatibility. The derived ports
889         (WebKitPort, TestPort, etc.) still need to be updated.
890
891         * Scripts/webkitpy/layout_tests/port/base.py:
892         (Port._expectations_dict):
893         (Port.test_expectations):
894         (Port):
895         (Port._expectations_overrides_dict):
896         (Port.test_expectations_overrides):
897         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
898         (PortTestCase.test_expectations_ordering):
899         (PortTestCase):
900         (PortTestCase.test_expectations_overrides_ordering):
901         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
902         (OrderedDict):
903         (OrderedDict.__init__):
904         (OrderedDict.clear):
905         (OrderedDict.__setitem__):
906         (OrderedDict.__delitem__):
907         (OrderedDict.__iter__):
908         (OrderedDict.__reversed__):
909         (OrderedDict.popitem):
910         (OrderedDict.__reduce__):
911         (OrderedDict.__repr__):
912         (OrderedDict.copy):
913         (OrderedDict.fromkeys):
914
915 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
916
917         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
918
919         * gtk/run-api-tests:
920         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
921
922 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
923
924         nrwt should look in 'out' for binaries on chromium win to support ninja
925         https://bugs.webkit.org/show_bug.cgi?id=88273
926
927         Reviewed by Tony Chang.
928
929         This patch standardizes the search algorithm the chromium ports
930         use to figure out which driver to run. We will look in a
931         chromium location before a webkit location (e.g., in
932         Source/WebKit/chromium/out before out/) and we will look in the
933         "legacy" directory (xcodebuild) before the directory ninja uses
934         (out).
935
936         Unfortunately due to the way the test code is set up testing the
937         properly requires some duplication of test code. I will fix that
938         in a followup patch.
939
940         * Scripts/webkitpy/layout_tests/port/chromium.py:
941         (ChromiumPort):
942         (ChromiumPort._static_build_path):
943         (ChromiumPort._build_path):
944         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
945         (ChromiumLinuxPort):
946         (ChromiumLinuxPort._determine_driver_path_statically):
947         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
948         (ChromiumLinuxPortTest.test_build_path):
949         (ChromiumLinuxPortTest):
950         (ChromiumLinuxPortTest.test_driver_name_option):
951         (ChromiumLinuxPortTest.path_to_image_diff):
952         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
953         (ChromiumMacPort):
954         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
955         (ChromiumMacPortTest.test_build_path):
956         (ChromiumMacPortTest):
957         (ChromiumMacPortTest.test_driver_name_option):
958         (ChromiumMacPortTest.path_to_image_diff):
959         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
960         (ChromiumPortTest.test_overrides_and_builder_names):
961         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
962         (ChromiumWinPort):
963         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
964         (ChromiumWinTest.test_build_path):
965         (ChromiumWinTest.test_operating_system):
966         (ChromiumWinTest):
967         (ChromiumWinTest.test_driver_name_option):
968         (ChromiumWinPortTest.path_to_image_diff):
969         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
970         (PortTestCase.assert_build_path):
971
972 2012-06-06  Jessie Berlin  <jberlin@apple.com>
973
974         Remove very red Windows WebKit2 testers
975         https://bugs.webkit.org/show_bug.cgi?id=88452
976
977         Reviewed by Steve Falkenburg.
978
979         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
980         need to focus on getting the WK1 testers green.
981
982         * BuildSlaveSupport/build.webkit.org-config/config.json:
983
984 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
985
986         get rebaselining tools to kinda work with the skia overrides file
987         https://bugs.webkit.org/show_bug.cgi?id=88456
988
989         Reviewed by Ryosuke Niwa.
990
991         Update rebaseline-expectations so that we read in the overrides
992         when looking for tests to rebaseline, but don't read in the
993         overrides when we are writing the expectations file back out.
994         This prevents the overrides from getting written into the main
995         file. This is kind of a hack but will have to do until we
996         support multiple expectations files properly.
997
998         * Scripts/webkitpy/tool/commands/rebaseline.py:
999         (RebaselineExpectations._expectations):
1000         (RebaselineExpectations._update_expectations_file):
1001         (RebaselineExpectations._tests_to_rebaseline):
1002         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1003         (test_overrides_are_included_correctly):
1004
1005 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1006
1007         webkitpy: two manager_worker_broker_unittest tests are broken
1008         https://bugs.webkit.org/show_bug.cgi?id=88445
1009
1010         Reviewed by Ojan Vafai.
1011
1012         These tests were never updated when we removed the
1013         --worker-model argument, and we were passing 'inline' instead of
1014         1 (for the number of workers) :(. As a result we were creating
1015         multiprocessing queues unnecessarily and that was failing on cygwin.
1016
1017         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1018         (InterfaceTest.test_managerconnection_is_abstract):
1019         (InterfaceTest.test_workerconnection_is_abstract):
1020
1021 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
1022
1023         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
1024         https://bugs.webkit.org/show_bug.cgi?id=87406
1025
1026         Reviewed by Dirk Pranke.
1027
1028         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1029         (TestExpectations.__init__):
1030         * Scripts/webkitpy/tool/commands/rebaseline.py:
1031         (RebaselineTest._update_expectations_file):
1032         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1033         (test_rebaseline_does_not_include_overrides):
1034
1035 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
1036
1037         webkitpy: perf tests unit tests fail on chromium win
1038         https://bugs.webkit.org/show_bug.cgi?id=88279
1039
1040         Reviewed by Ryosuke Niwa.
1041
1042         I'm seeing weird failures running the unit tests in my win32
1043         checkout, and we don't really expect webpagereplay to work on
1044         win32 anyway, so I'm skipping the import of that module for now
1045         and adding a warning.
1046
1047         * Scripts/run-perf-tests:
1048         * Scripts/webkitpy/performance_tests/perftest.py:
1049
1050 2012-06-06  Yong Li <yoli@rim.com>
1051
1052         Unreviewed. Update my email address in committers.py.
1053
1054         * Scripts/webkitpy/common/config/committers.py:
1055
1056 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
1057
1058         Add Robert Kroeger  to commiters.py
1059         https://bugs.webkit.org/show_bug.cgi?id=88415
1060
1061         Unreviewed.
1062
1063         * Scripts/webkitpy/common/config/committers.py:
1064
1065 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1066
1067         [EFL][DRT] http/tests/globalhistory testcases do not pass
1068         https://bugs.webkit.org/show_bug.cgi?id=82579
1069
1070         Reviewed by Csaba Osztrogonác.
1071
1072         DRT has provided callbacks for ewk_view "global history delegate" signals.
1073
1074         * DumpRenderTree/efl/DumpRenderTree.cpp:
1075         (isGlobalHistoryTest): Aux function to ident global history testcase.
1076         (createLayoutTestController):
1077         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1078         (DumpRenderTreeChrome::createView):
1079         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
1080         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
1081         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
1082         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
1083         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
1084         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1085         (DumpRenderTreeChrome):
1086
1087 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
1088
1089         [Qt] run-qtwebkit-tests hangs with -j1
1090         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
1091         This could happen due to an uncancelled timer after results were returned. This timer was
1092         started only if --timeout was set.
1093         https://bugs.webkit.org/show_bug.cgi?id=85475
1094
1095         Reviewed by Csaba Osztrogonác.
1096
1097         * Scripts/run-qtwebkit-tests:
1098         (run_test):
1099
1100 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
1101
1102         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
1103         https://bugs.webkit.org/show_bug.cgi?id=88327
1104
1105         Reviewed by Kenneth Rohde Christiansen.
1106
1107         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
1108         * MiniBrowser/qt/icons/contents_width.png: Added.
1109         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
1110         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
1111
1112 2012-06-05  Jon Lee  <jonlee@apple.com>
1113
1114         Buildbot fix.
1115
1116         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
1117         in the function. Store in a local variable.
1118         (loadBuilderConfig):
1119
1120 2012-06-05  Jon Lee  <jonlee@apple.com>
1121
1122         Buildbot fix.
1123
1124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1125         (loadBuilderConfig):
1126
1127 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1128
1129         webkitpy: clean up win-specific path handling and tests
1130         https://bugs.webkit.org/show_bug.cgi?id=88281
1131
1132         Reviewed by Adam Barth.
1133
1134         There was a bunch of inconsistent logic for handling path
1135         conversions for win32 and cygwin paths due to us sometimes
1136         looking at sys.platform and sometimes using mock hosts. This
1137         patch cleans everything up so that we are required to pass
1138         PlatformInfo objects to the path module and stop trying to do
1139         different things when running on cygwin or win32 hosts (except
1140         in the path_unittest module itself).
1141
1142         This may slightly reduce test coverage for the win32 code paths
1143         but will be a lot easier to follow and maintain.
1144
1145         * Scripts/webkitpy/common/system/path.py:
1146         (abspath_to_uri):
1147         (_convert_path):
1148         * Scripts/webkitpy/common/system/path_unittest.py:
1149         (AbspathTest.platforminfo):
1150         (AbspathTest.test_abspath_to_uri_cygwin):
1151         (AbspathTest.test_abspath_to_uri_unixy):
1152         (AbspathTest.test_abspath_to_uri_win):
1153         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1154         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1155         (AbspathTest.test_stop_cygpath_subprocess):
1156         * Scripts/webkitpy/common/system/platforminfo.py:
1157         (PlatformInfo.__init__):
1158         (PlatformInfo.is_cygwin):
1159         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1160         (MockPlatformInfo.is_cygwin):
1161         * Scripts/webkitpy/layout_tests/port/base.py:
1162         (Port.to.show_results_html_file):
1163         * Scripts/webkitpy/layout_tests/port/driver.py:
1164         (Driver.test_to_uri):
1165         (Driver.uri_to_test):
1166         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1167         (DriverTest.test_test_to_uri):
1168         (DriverTest.test_uri_to_test):
1169         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1170         (MockDRTPortTest.make_port):
1171         (MockDRTTest.input_line):
1172         (MockChromiumDRTTest.test_pixeltest__fails):
1173         * Scripts/webkitpy/layout_tests/port/test.py:
1174         * Scripts/webkitpy/layout_tests/port/win.py:
1175         (WinPort.show_results_html_file):
1176         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1177         (MainTest.test_unexpected_failures):
1178         (MainTest.test_results_directory_absolute):
1179         (MainTest.test_results_directory_default):
1180         (MainTest.test_results_directory_relative):
1181
1182 2012-06-05  Jon Lee  <jonlee@apple.com>
1183
1184         Workaround buildbot bug when merging build requests.
1185         https://bugs.webkit.org/show_bug.cgi?id=88158
1186
1187         Reviewed by Mark Rowe.
1188
1189         For expediency, we still want testers to pick the latest build to test, but to ensure
1190         that the builders are reporting the correct revision number, we should let the building bots
1191         run as they normally would. That is, the builder picks the oldest revision, and merges
1192         subsequent requests. Because merged requests get appended to the list of changes for a given
1193         build, the last change in that list is also the latest change. When we used pickLatestBuild
1194         for the builders, this was not the case (it would always report the penultimate change).
1195
1196         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
1197
1198         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
1199         for all Apple builders.
1200         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
1201         the latest build to run.
1202         (loadBuilderConfig):
1203
1204 2012-06-05  Jessie Berlin  <jberlin@apple.com>
1205
1206         [Win] DumpRenderTree should call resetInternalsObject
1207         https://bugs.webkit.org/show_bug.cgi?id=88346
1208
1209         Reviewed by Simon Fraser.
1210
1211         Invoke it on Windows in the same place it is invoked on Mac.
1212
1213         * DumpRenderTree/win/DumpRenderTree.cpp:
1214         (resetWebViewToConsistentStateBeforeTesting):
1215
1216 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1217
1218         [GTK] Fix two more memory leaks in DRT
1219         https://bugs.webkit.org/show_bug.cgi?id=88255
1220
1221         Reviewed by Martin Robinson.
1222
1223         Fixed memory leaks in GTK's DRT code.
1224
1225         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1226         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
1227         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
1228         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1229         (createBitmapContextFromWebView): Free the cairo surface.
1230
1231 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1232
1233         [Qt] Building when a top directory is named Source
1234         https://bugs.webkit.org/show_bug.cgi?id=77727
1235
1236         Reviewed by Tor Arne Vestbø.
1237
1238         Change regex to only replace the last instance of OUT_PWD.
1239
1240         * qmake/mkspecs/features/default_pre.prf:
1241
1242 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
1243
1244         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
1245         https://bugs.webkit.org/show_bug.cgi?id=73176
1246
1247         Reviewed by Adam Barth.
1248
1249         Two more APIs are added in Custom Scheme Handler specification.
1250         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
1251         One is 'isProtocolHandlerRegistered' to query whether the specific URL
1252         is registered or not.
1253         The other is 'unregisterProtocolHandler' to remove the registered URL.
1254
1255         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
1256
1257 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
1258
1259         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
1260         https://bugs.webkit.org/show_bug.cgi?id=83879
1261
1262         Reviewed by Carlos Garcia Campos.
1263
1264         Make minibrowser connect to the new 'permission requests' signal
1265         to allow users handle the Geolocation permission requests.
1266
1267         * MiniBrowser/gtk/BrowserWindow.c:
1268         (geolocationRequestDialogCallback): Callback for the dialog asking
1269         the user for allowing or not geolocation permission requests.
1270         (webViewDecidePermissionRequest): Launch a dialog to ask the user
1271         whether to allow or deny geolocation permission requests.
1272         (browserWindowConstructed): Connect to 'permission-request' signal.
1273
1274 2012-06-04  Chase Phillips  <cmp@google.com>
1275
1276         Make a builder group support+expect multiple loads.
1277         https://bugs.webkit.org/show_bug.cgi?id=88260
1278
1279         Change BuilderGroup to allow expecting multiple
1280         loads.  This allows merging results for a given set
1281         of builders into one group.
1282
1283         Add a test that verifies that the group count
1284         increments correctly based on successful and failed
1285         list loads.
1286
1287         Reviewed by Ojan Vafai.
1288
1289         * TestResultServer/static-dashboards/builders.js:
1290         (BuilderGroup):
1291         (BuilderGroup.prototype.setbuilder):
1292         (BuilderGroup.prototype.append):
1293         (BuilderGroup.prototype.loaded):
1294         (requestBuilderList.xhr.onload):
1295         (requestBuilderList.xhr.onerror):
1296         (onErrorLoadingBuilderList):
1297         (loadBuildersList):
1298         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1299         (test):
1300         * TestResultServer/static-dashboards/run-unittests.html:
1301
1302 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1303
1304         Python test fix attempt for Chromium Windows.
1305
1306         * Scripts/webkitpy/layout_tests/port/driver.py:
1307         (Driver.uri_to_test):
1308
1309 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
1310
1311         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
1312         https://bugs.webkit.org/show_bug.cgi?id=88243
1313
1314         Reviewed by Adam Barth.
1315
1316         * qmake/mkspecs/features/features.prf:
1317
1318 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1319
1320         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
1321         https://bugs.webkit.org/show_bug.cgi?id=88280
1322
1323         Unreviewed, build fix.
1324
1325         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1326         (TestServerProcess.test_basic):
1327
1328 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1329
1330         test-webkitpy is hanging under cygwin
1331         https://bugs.webkit.org/show_bug.cgi?id=88269
1332
1333         Reviewed by Ryosuke Niwa.
1334
1335         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
1336         so we need to skip any tests that use it.
1337
1338         * Scripts/webkitpy/common/system/executive.py:
1339         (Executive.run_in_parallel):
1340         * Scripts/webkitpy/common/system/executive_unittest.py:
1341         (ExecutiveTest.test_run_in_parallel):
1342
1343 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1344
1345         test-webkitpy is failing on win32 after r115054
1346         https://bugs.webkit.org/show_bug.cgi?id=88264
1347
1348         Reviewed by Ryosuke Niwa.
1349
1350         The failing http_server test was improperly suppressed (the
1351         tuple was missing a comma, and so wasn't a tuple at all, just a
1352         string) and so we were skipping *all* tests on win32. The right
1353         way to skip a single test is to disable it inside the test
1354         itself.
1355
1356         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1357         (TestHttpServer.test_start_cmd):
1358         * Scripts/webkitpy/test/test_finder.py:
1359         (TestFinder._default_names):
1360         * Scripts/webkitpy/test/main.py:
1361         (Tester.run): Add error message if we don't find any tests to run.
1362         * Scripts/webkitpy/test/main_unittest.py:
1363             
1364
1365 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1366
1367         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
1368         https://bugs.webkit.org/show_bug.cgi?id=88215
1369
1370         Reviewed by Martin Robinson.
1371
1372         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
1373         for newly allocated strings.
1374
1375         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1376         (attributeSetToString):
1377         (AccessibilityUIElement::allAttributes):
1378
1379 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1380
1381         [GTK] Memory leaks in DumpRenderTree.cpp
1382         https://bugs.webkit.org/show_bug.cgi?id=88213
1383
1384         Reviewed by Martin Robinson.
1385
1386         Fixed memory leaks in DumpRenderTree.
1387
1388         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1389         (appendString): Accepts const gchar* as the second argument.
1390         (dumpFramesAsText): Free the string returned by g_strdup_printf().
1391         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
1392
1393 2012-06-04  David Dorwin  <ddorwin@chromium.org>
1394
1395         Enable Chromium media player to instantiate a plugin
1396         https://bugs.webkit.org/show_bug.cgi?id=87399
1397
1398         Reviewed by Kent Tamura.
1399
1400         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
1401
1402         * DumpRenderTree/chromium/WebViewHost.cpp:
1403         (WebViewHost::createPopupMenu):
1404
1405 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
1406
1407         [GTK][WK2] Implement geolocation provider for the GTK port
1408         https://bugs.webkit.org/show_bug.cgi?id=83877
1409
1410         Reviewed by Carlos Garcia Campos.
1411
1412         * gtk/generate-gtkdoc:
1413         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
1414
1415 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1416
1417         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
1418         https://bugs.webkit.org/show_bug.cgi?id=87668
1419
1420         Reviewed by Ryosuke Niwa.
1421
1422         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
1423         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
1424         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
1425
1426         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1427         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1428
1429 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
1430
1431         [EFL] Refactor ewk_view_context_paint code.
1432         https://bugs.webkit.org/show_bug.cgi?id=85588
1433
1434         Reviewed by Hajime Morita.
1435
1436         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
1437
1438 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
1439
1440         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
1441         https://bugs.webkit.org/show_bug.cgi?id=87869
1442
1443         Reviewed by Andreas Kling.
1444
1445         Replace %lld by PRId64 macro to print an int64_t value and silent a
1446         compilation warning on 64-Bit.
1447
1448         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1449         (onExceededApplicationCacheQuota):
1450
1451 2012-06-03  Varun Jain  <varunjain@google.com>
1452
1453         [chromium] Add new gesture type (two finger tap) that triggers context menu.
1454         https://bugs.webkit.org/show_bug.cgi?id=88173
1455
1456         Reviewed by Adam Barth.
1457
1458         * DumpRenderTree/chromium/EventSender.cpp:
1459         (EventSender::EventSender):
1460         (EventSender::gestureTwoFingerTap):
1461         (EventSender::gestureEvent):
1462         * DumpRenderTree/chromium/EventSender.h:
1463         (EventSender):
1464
1465 2012-06-02  Zeno Albisser  <zeno@webkit.org>
1466
1467         Fix and enable WebGL for WebKit2 on Qt.
1468         https://bugs.webkit.org/show_bug.cgi?id=86214
1469
1470         Enable WebGL by default for Qt MiniBrowser.
1471
1472         Reviewed by Noam Rosenthal.
1473
1474         * MiniBrowser/qt/qml/BrowserWindow.qml:
1475
1476 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1477
1478         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
1479         https://bugs.webkit.org/show_bug.cgi?id=88164
1480
1481         Reviewed by Kentaro Hara.
1482
1483         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
1484         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
1485
1486         * Scripts/VCSUtils.pm:
1487         (adjustPathForRecentRenamings):
1488         (fixChangeLogPatch):
1489
1490 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1491
1492         Rename test_expectations.txt to TestExpectations
1493         https://bugs.webkit.org/show_bug.cgi?id=86690
1494
1495         Reviewed by Dirk Pranke.
1496
1497         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
1498         We can the code to read test_expectations.txt once we've successfully transitioned.
1499
1500         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1501         (TestExpectationParser._check_path_does_not_exist):
1502         (TestExpectationParser._tokenize):
1503         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
1504         * Scripts/webkitpy/layout_tests/port/base.py:
1505         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
1506         test_expectations.txt if one exists and the path to TestExpectations otherwise.
1507         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1508         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
1509         virtual.
1510         * Scripts/webkitpy/layout_tests/port/chromium.py:
1511         (ChromiumPort.path_from_chromium_base):
1512         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1513         (ChromiumAndroidPort.test_expectations):
1514         * Scripts/webkitpy/layout_tests/port/test.py:
1515         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
1516         (TestPort.__init__):
1517         * Scripts/webkitpy/layout_tests/port/webkit.py:
1518         (WebKitPort.baseline_search_path):
1519         (WebKitPort.test_expectations):
1520         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
1521         tests to base as a follow up.
1522         (WebKitPortTest.test_path_to_test_expectations_file):
1523         (test_test_expectations):
1524         (test_legacy_test_expectations):
1525         * Scripts/webkitpy/style/checker.py:
1526         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
1527         with one for TestExpectations.
1528         * Scripts/webkitpy/style/checkers/test_expectations.py:
1529         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
1530         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1531         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
1532         test_expectations.txt.
1533         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1534         (TestExpectationsTestCase.assert_lines_lint):
1535         * Scripts/webkitpy/tool/commands/queries.py:
1536         (PrintExpectations.__init__):
1537         * Scripts/webkitpy/tool/commands/rebaseline.py:
1538         (RebaselineExpectations):
1539         * Scripts/webkitpy/tool/steps/commit.py:
1540         (Commit._check_test_expectations):
1541         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1542         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
1543         (CommitTest.test_check_test_expectations): For TestExpectations.
1544         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
1545         * TestResultServer/static-dashboards/dashboard_base.js:
1546         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
1547         Error only when neither exists.
1548         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1549         (processMissingAndExtraExpectations):
1550         (htmlForTestsWithExpectationsButNoFailures):
1551         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1552
1553 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1554
1555         Remove dependency from ImageDiff to WTF
1556         https://bugs.webkit.org/show_bug.cgi?id=88147
1557
1558         Reviewed by Adam Barth.
1559
1560         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1561
1562 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1563
1564         NRWT seems to leak (more?) temp dirs
1565         https://bugs.webkit.org/show_bug.cgi?id=88126
1566
1567         Re-land r119297 with chromium fix (weren't calling the
1568         super() method if not in --test-shell mode in start().
1569         Add unit tests to chromium_unittest as well to check.
1570
1571         * Scripts/webkitpy/layout_tests/port/chromium.py:
1572         (ChromiumDriver.start):
1573         * Scripts/webkitpy/layout_tests/port/webkit.py:
1574         (WebKitDriver.__del__):
1575         (WebKitDriver._start):
1576         (WebKitDriver.run_test):
1577         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1578         (WebKitDriverTest.test_check_for_driver_crash):
1579         (WebKitDriverTest.test_stop_cleans_up_properly):
1580         (WebKitDriverTest):
1581         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1582         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1583         (ChromiumDriverTest.test_stop_cleans_up_properly):
1584         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
1585
1586 2012-06-01  Tim Horton  <timothy_horton@apple.com>
1587
1588         Lots of "failed download-built-product" on Apple bots
1589         https://bugs.webkit.org/show_bug.cgi?id=88158
1590
1591         Reviewed by Jessie Berlin.
1592         
1593         Disable mergeRequests on all Apple builders. This is a speculative fix.
1594
1595         * BuildSlaveSupport/build.webkit.org-config/config.json:
1596
1597 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1598
1599         Unreviewed, rolling out r119297.
1600         http://trac.webkit.org/changeset/119297
1601         https://bugs.webkit.org/show_bug.cgi?id=88156
1602
1603         May have broken Chromium bots (Requested by rniwa on #webkit).
1604
1605         * Scripts/webkitpy/layout_tests/port/webkit.py:
1606         (WebKitDriver.__del__):
1607         (WebKitDriver.run_test):
1608         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1609         (WebKitDriverTest.test_check_for_driver_crash):
1610         (WebKitDriverTest.test_stop_cleans_up_properly):
1611
1612 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1613
1614         nrwt seems to leak tmpdirs
1615         https://bugs.webkit.org/show_bug.cgi?id=88126
1616
1617         Reviewed by Ojan Vafai.
1618
1619         Fix leak possibly introduced in r118979 - we now will
1620         make sure we clean up any stale temp directories during the
1621         start routine and attempt to clean up again in __del__. It
1622         turns out that asserting in __del__ logs a message but is
1623         caught by the runtime, so it's mostly useless.
1624
1625         * Scripts/webkitpy/layout_tests/port/webkit.py:
1626         (WebKitDriver.__del__):
1627         (WebKitDriver._start):
1628         (WebKitDriver.run_test):
1629         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1630         (WebKitDriverTest.test_check_for_driver_crash):
1631         (WebKitDriverTest.test_stop_cleans_up_properly):
1632         (WebKitDriverTest):
1633         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1634
1635 2012-06-01  Michael Saboff  <msaboff@apple.com>
1636
1637         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1638         https://bugs.webkit.org/show_bug.cgi?id=88109
1639
1640         Reviewed by Geoffrey Garen.
1641
1642         Additional test case.
1643
1644         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1645         (TestWebKitAPI::TEST):
1646
1647 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1648
1649         [Qt] Use -Werror only in developer builds
1650
1651         Rubber-stamped by Tor Arne Vestbø.
1652
1653         In production builds -Werror with custom toolchains and wierd system
1654         headers, -Werror is of no use and just creates confusion. So use it
1655         only if Qt is configured with -developer-build.
1656
1657         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1658         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1659         only if qt_developer_build is set.
1660
1661 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1662
1663         [watchlist] Add myself to loader and v8 bindings changes
1664         https://bugs.webkit.org/show_bug.cgi?id=88112
1665
1666         Reviewed by Adam Barth.
1667
1668         * Scripts/webkitpy/common/config/watchlist:
1669
1670 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1671
1672         Adding Jacky Jiang to committers.py
1673         https://bugs.webkit.org/show_bug.cgi?id=88122
1674
1675         Reviewed by Rob Buis.
1676
1677         Adding myself to committers.py as a Committer.
1678
1679         * Scripts/webkitpy/common/config/committers.py:
1680
1681 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1682
1683         Fix Windows build.
1684
1685         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1686
1687 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1688
1689         Windows WK2 MouseMoveAfterCrash API test failing
1690         https://bugs.webkit.org/show_bug.cgi?id=69982
1691
1692         Disable the test on Windows to get the bots greener.
1693
1694         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1695         (TestWebKitAPI::TEST):
1696
1697 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1698
1699         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1700         https://bugs.webkit.org/show_bug.cgi?id=86866
1701
1702         Reviewed by Adam Barth.
1703
1704         Catch new "intent,service,register" signal on the frame and print out
1705         information about the Web Intent service in EFL's DumpRenderTree.
1706
1707         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1708         (DumpRenderTreeChrome::createView):
1709         (DumpRenderTreeChrome::onFrameCreated):
1710         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1711         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1712         (DumpRenderTreeChrome):
1713
1714 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1715
1716         The ChangeLog parser cannot handle reviewers with initials in their name
1717         https://bugs.webkit.org/show_bug.cgi?id=87864
1718
1719         Reviewed by Ryosuke Niwa.
1720
1721         Add support in the ChangeLog parser for reviewer names that have
1722         initials in them.
1723
1724         * Scripts/webkitpy/common/checkout/changelog.py:
1725         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1726         in the replacement string. This allows for matching the word characters before a
1727         period, without totally throwing them away.
1728         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1729         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1730         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1731
1732 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1733
1734         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1735         https://bugs.webkit.org/show_bug.cgi?id=86865
1736
1737         Reviewed by Adam Barth.
1738
1739         Add deliverWebIntent method to LayoutTestController and provide
1740         implementation for EFL port.
1741
1742         * DumpRenderTree/LayoutTestController.cpp:
1743         (deliverWebIntentCallback):
1744         (LayoutTestController::staticFunctions):
1745         * DumpRenderTree/LayoutTestController.h:
1746         (LayoutTestController):
1747         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1748         (LayoutTestController::deliverWebIntent):
1749         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1750         (LayoutTestController::deliverWebIntent):
1751         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1752         (LayoutTestController::deliverWebIntent):
1753         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1754         (LayoutTestController::deliverWebIntent):
1755         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1756         (LayoutTestController::deliverWebIntent):
1757         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1758         (LayoutTestController::deliverWebIntent):
1759
1760 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1761
1762         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1763
1764         Reviewed by Simon Hausmann.
1765
1766         * Tools.pro:
1767
1768 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1769
1770         Add public page loading performance tests using web-page-replay
1771         https://bugs.webkit.org/show_bug.cgi?id=84008
1772
1773         Reviewed by Dirk Pranke.
1774
1775         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1776         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1777         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1778
1779         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1780         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1781         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1782         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1783
1784         * Scripts/webkitpy/layout_tests/port/driver.py:
1785         (Driver.is_external_http_test): Added.
1786         * Scripts/webkitpy/layout_tests/port/webkit.py:
1787         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1788         * Scripts/webkitpy/performance_tests/perftest.py:
1789         (PerfTest.__init__): Takes port.
1790         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1791         (PerfTest):
1792         (PerfTest.run): Calls run_single.
1793         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1794         (ChromiumStylePerfTest.__init__):
1795         (PageLoadingPerfTest.__init__):
1796         (PageLoadingPerfTest.run):
1797         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1798         (ReplayServer.__init__):
1799         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1800         but it caused a dead lock on some web pages.
1801         (ReplayServer.stop):
1802         (ReplayServer.__del__):
1803         (ReplayPerfTest):
1804         (ReplayPerfTest.__init__):
1805         (ReplayPerfTest._start_replay_server):
1806         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1807         The subsequent runs of the same test will just use test.wpr.
1808         (ReplayPerfTest.run_single):
1809         (PerfTestFactory):
1810         (PerfTestFactory.create_perf_test):
1811         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1812         (MainTest.test_parse_output):
1813         (MainTest.test_parse_output_with_failing_line):
1814         (TestPageLoadingPerfTest.test_run):
1815         (TestPageLoadingPerfTest.test_run_with_bad_output):
1816         (TestReplayPerfTest):
1817         (TestReplayPerfTest.ReplayTestPort):
1818         (TestReplayPerfTest.ReplayTestPort.__init__):
1819         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1820         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1821         (TestReplayPerfTest.ReplayTestPort._driver_class):
1822         (TestReplayPerfTest.MockReplayServer):
1823         (TestReplayPerfTest.MockReplayServer.__init__):
1824         (TestReplayPerfTest.MockReplayServer.stop):
1825         (TestReplayPerfTest._add_file):
1826         (TestReplayPerfTest._setup_test):
1827         (TestReplayPerfTest.test_run_single):
1828         (TestReplayPerfTest.test_run_single.run_test):
1829         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1830         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1831         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1832         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1833         (TestReplayPerfTest.test_prepare):
1834         (TestReplayPerfTest.test_prepare.run_test):
1835         (TestReplayPerfTest.test_prepare_calls_run_single):
1836         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1837         (TestPerfTestFactory.test_regular_test):
1838         (TestPerfTestFactory.test_inspector_test):
1839         (TestPerfTestFactory.test_page_loading_test):
1840         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1841         (PerfTestsRunner):
1842         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1843         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1844         (PerfTestsRunner._collect_tests._is_test_file):
1845         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1846         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1847         (create_runner):
1848         (run_test):
1849         (_tests_for_runner):
1850         (test_run_test_set):
1851         (test_run_test_set_kills_drt_per_run):
1852         (test_run_test_pause_before_testing):
1853         (test_run_test_set_for_parser_tests):
1854         (test_run_test_set_with_json_output):
1855         (test_run_test_set_with_json_source):
1856         (test_run_test_set_with_multiple_repositories):
1857         (test_run_with_upload_json):
1858         (test_upload_json):
1859         (test_upload_json.MockFileUploader.upload_single_text_file):
1860         (_add_file):
1861         (test_collect_tests):
1862         (test_collect_tests_with_multile_files):
1863         (test_collect_tests_with_multile_files.add_file):
1864         (test_collect_tests_with_skipped_list):
1865         (test_collect_tests_with_page_load_svg):
1866         (test_collect_tests_should_ignore_replay_tests_by_default):
1867         (test_collect_tests_with_replay_tests):
1868         (test_parse_args):
1869         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1870         (AutoinstallImportHook.find_module):
1871         (AutoinstallImportHook._install_webpagereplay):
1872
1873 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1874
1875         Support building the Android port of chromium with Ninja
1876         https://bugs.webkit.org/show_bug.cgi?id=87545
1877
1878         Reviewed by Adam Barth.
1879
1880         Ensures that shared libraries are looked up in a generator-agnostic
1881         way and that output is placed in the correct directory.
1882
1883         Depends on http://codereview.chromium.org/10386188/
1884
1885         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1886
1887 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1888
1889         [Chromium] Chromium DRT should be able to load external resources
1890         https://bugs.webkit.org/show_bug.cgi?id=87893
1891
1892         Reviewed by Dirk Pranke.
1893
1894         Allow external resources to be loaded when the main frame's URL is also an external resource.
1895         This change is analogous to r118231 for Mac port.
1896
1897         * DumpRenderTree/chromium/WebViewHost.cpp:
1898         (blockRequest):
1899         (isLocalhost):
1900         (hostIsUsedBySomeTestsToGenerateError):
1901         (WebViewHost::willSendRequest):
1902
1903 2012-05-31  Anders Carlsson  <andersca@apple.com>
1904
1905         Build fixes.
1906
1907         Disable the C++11 extensions warning.
1908
1909         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1910         * TestWebKitAPI/Configurations/Base.xcconfig:
1911         * WebKitTestRunner/Configurations/Base.xcconfig:
1912
1913 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1914
1915         [WK2] window.internals settings are not reset between tests
1916         https://bugs.webkit.org/show_bug.cgi?id=87783
1917
1918         Reviewed by Mihai Parparita.
1919
1920         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1921         (WTR::InjectedBundle::done): Call resetAfterTest().
1922
1923         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1924         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1925         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1926         This needs to be done after a tets, because the code assumes that there is an object
1927         with this name in global scope.
1928
1929         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1930
1931 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1932
1933         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1934         https://bugs.webkit.org/show_bug.cgi?id=85006
1935
1936         Reviewed by Tor Arne Vestbø.
1937
1938         Added navigation_policy_decision implementation for DumpRenderTreeView.
1939         Added LayoutTestController::setCustomPolicyDelegate implementation.
1940         Modified LayoutTestController::waitForPolicyDelegate.
1941
1942         * DumpRenderTree/efl/DumpRenderTree.cpp:
1943         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1944         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1945         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1946         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1947         (navigationTypeToString): aux function
1948         (onNavigationPolicyDecision): navigation_policy_decision implementation
1949         (drtViewAdd):
1950         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1951         (LayoutTestController::setCustomPolicyDelegate):
1952         (LayoutTestController::waitForPolicyDelegate):
1953
1954 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1955
1956         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1957         https://bugs.webkit.org/show_bug.cgi?id=86195
1958
1959         Reviewed by Gustavo Noronha Silva.
1960
1961         Implement clearApplicationCacheForOrigin in EFL
1962         LayoutTestController.
1963
1964         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1965         (LayoutTestController::clearApplicationCacheForOrigin):
1966
1967 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1968
1969         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1970         https://bugs.webkit.org/show_bug.cgi?id=87955
1971
1972         Reviewed by Simon Hausmann.
1973
1974         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1975         * DumpRenderTree/qt/EventSenderQt.cpp:
1976         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1977         * DumpRenderTree/qt/main.cpp:
1978         * QtTestBrowser/cookiejar.cpp:
1979         * QtTestBrowser/launcherwindow.cpp:
1980         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1981         * qmake/mkspecs/features/default_post.prf:
1982
1983 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1984
1985         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1986
1987         Rubber-stamped by Kenneth Rohde Christiansen.
1988
1989         * qmake/config.tests/libpng/libpng.pro:
1990
1991 2012-05-30  Peter Beverloo  <peter@chromium.org>
1992
1993         [Chromium] Automatically install 64-bit linker for Android
1994         https://bugs.webkit.org/show_bug.cgi?id=79780
1995
1996         Reviewed by Adam Barth.
1997
1998         Change the update-webkit-chromium script to check whether the 64-bit
1999         linker needs to be installed as part of the update process. The actual
2000         code for doing these checks and "installing" it has been added to the
2001         webkitdirs.pm script.
2002
2003         The linker itself is part of the third_party/aosp repository, which
2004         will be pulled in through the DEPS change.
2005
2006         * Scripts/update-webkit-chromium:
2007         * Scripts/webkitdirs.pm:
2008         (chromiumInstall64BitAndroidLinkerIfNeeded):
2009         (chromiumReplaceAndroidLinkerIfNeeded):
2010
2011 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2012
2013         https://bugs.webkit.org/show_bug.cgi?id=87803
2014         Layout tests often fail trying to stat nonexistent logs 
2015
2016         Reviewed by Dirk Pranke.
2017
2018         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
2019         try/catch block around accessing the logs as a precaution.
2020
2021         * Scripts/webkitpy/common/system/crashlogs.py:
2022         (CrashLogs._find_newest_log_darwin):
2023
2024 2012-05-30  Gavin Peters  <gavinp@chromium.org>
2025
2026         Add a LayoutTest for prerender remove after stop.
2027         https://bugs.webkit.org/show_bug.cgi?id=87860
2028
2029         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
2030         can be tested by LayoutTests now.
2031
2032         Reviewed by Adam Barth.
2033
2034         * DumpRenderTree/DumpRenderTree.gypi:
2035         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
2036         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
2037         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
2038         (MockWebPrerenderingSupport::add):
2039         (MockWebPrerenderingSupport::cancel):
2040         (MockWebPrerenderingSupport::abandon):
2041         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
2042         (MockWebPrerenderingSupport):
2043         * DumpRenderTree/chromium/TestShell.cpp:
2044         (TestShell::initialize):
2045         * DumpRenderTree/chromium/TestShell.h:
2046         (TestShell):
2047         * DumpRenderTree/chromium/WebViewHost.cpp:
2048         (WebViewHost::willAddPrerender):
2049         (WebViewHost::setWebWidget):
2050         * DumpRenderTree/chromium/WebViewHost.h:
2051         (WebViewHost):
2052
2053 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2054
2055         https://bugs.webkit.org/show_bug.cgi?id=87717
2056         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
2057
2058         Reviewed by Dirk Pranke.
2059
2060         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
2061         If there isn't a crash log found for the process add a message saying
2062         the process was unresponsive.
2063
2064         * Scripts/webkitpy/layout_tests/port/webkit.py:
2065         (WebKitDriver.__init__):
2066         (WebKitDriver._check_for_driver_crash):
2067         (WebKitDriver.run_test):
2068         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2069         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2070         (WebKitDriverTest):
2071         (WebKitDriverTest.test_check_for_driver_crash):
2072         * WebKitTestRunner/TestController.cpp:
2073         (WTR):
2074         (WTR::TestController::runTest):
2075
2076 2012-05-30  Stephanie Lewis  <slewis@apple.com>
2077
2078         https://bugs.webkit.org/show_bug.cgi?id=87714
2079         Mac crash logs can take a really long time to be written out.
2080
2081         Reviewed by Dirk Pranke.
2082
2083         Make a second pass looking for crash logs after the tests have completed running.
2084
2085         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2086         (use_trac_links_in_results_html):
2087         (Manager.run):
2088         * Scripts/webkitpy/layout_tests/port/base.py:
2089         (Port.repository_paths):
2090         (Port.look_for_new_crash_logs):
2091         * Scripts/webkitpy/layout_tests/port/mac.py:
2092         (MacPort.look_for_new_crash_logs):
2093         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2094         (test_get_crash_log):
2095         (test_look_for_new_crash_logs):
2096         (test_look_for_new_crash_logs.fake_time_cb):
2097
2098 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2099
2100         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
2101
2102         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2103         (LayoutWebViewEventHandler::OnAlertEvent):
2104         (LayoutWebViewEventHandler::OnConfirmEvent):
2105         (LayoutWebViewEventHandler):
2106         (LayoutWebViewEventHandler::OnPromptEvent):
2107         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2108         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2109
2110 2012-05-30  Ojan Vafai  <ojan@chromium.org>
2111
2112         Only give lint errors for -expected.png png files that lack a checksum
2113         https://bugs.webkit.org/show_bug.cgi?id=87875
2114
2115         Reviewed by Tony Chang.
2116
2117         We have other pngs in the tree, e.g. for the inspector, that legitimately
2118         lack a checksum.
2119
2120         * Scripts/webkitpy/style/checkers/png.py:
2121         (PNGChecker.check):
2122         * Scripts/webkitpy/style/checkers/png_unittest.py:
2123         (PNGCheckerTest.test_check):
2124
2125 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
2126
2127         nrwt: seems to leak temp dirs
2128         https://bugs.webkit.org/show_bug.cgi?id=87795
2129
2130         Reviewed by Ojan Vafai.
2131
2132         There appears to be a bug where the chromium bots are creating
2133         temporary directories and not cleaning them up that started
2134         after the switch to WebKitDriver. It's possible that __del__
2135         wasn't getting called in a timely manner (or at all), and it's
2136         generally bad style to rely on __del__ being called, so this
2137         code changes things so that we create a temp dir in
2138         driver.start() and remove it in driver.stop(). We could be
2139         paranoid and leave the __del__ code in, but there doesn't seem
2140         to be much advantage to it. If there are bugs that result in
2141         drivers being started but not stopped, we have other problems.
2142
2143         * Scripts/webkitpy/common/system/filesystem_mock.py:
2144         (MockFileSystem.__init__):
2145         (MockFileSystem._mktemp):
2146         (MockFileSystem.mkdtemp):
2147         * Scripts/webkitpy/layout_tests/port/webkit.py:
2148         (WebKitDriver.__init__):
2149         (WebKitDriver._start):
2150         (WebKitDriver.stop):
2151         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2152         (WebKitDriverTest.test_check_for_driver_crash):
2153         (WebKitDriverTest):
2154         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2155         (WebKitDriverTest.test_stop_cleans_up_properly):
2156
2157 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2158
2159         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
2160         https://bugs.webkit.org/show_bug.cgi?id=86841
2161
2162         Reviewed by Adam Barth.
2163
2164         Print the number of MessagePorts for each new intent in EFL's DRT.
2165         This output is expected by several Web Intents test cases.
2166
2167         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2168         (DumpRenderTreeChrome::onFrameIntentNew):
2169
2170 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2171
2172         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
2173
2174         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2175
2176 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2177
2178         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
2179         https://bugs.webkit.org/show_bug.cgi?id=87829
2180
2181         Reviewed by Adam Barth.
2182
2183         EFL's LayoutTestController now makes uses of the new helper method in
2184         DumpRenderTreeSupportEfl in order to send the intent response. This is
2185         now needed because the Ewk_Intent_Request postResult / postFailure
2186         methods were made private.
2187
2188         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2189         (LayoutTestController::sendWebIntentResponse):
2190
2191 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
2192
2193         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
2194         https://bugs.webkit.org/show_bug.cgi?id=86296
2195
2196         Reviewed by Tony Chang.
2197
2198         * DumpRenderTree/win/DRTDataObject.cpp: Added.
2199         (cfHDropFormat):
2200         (cfFileNameWFormat):
2201         (cfUrlWFormat):
2202         (WCEnumFormatEtc):
2203         (WCEnumFormatEtc::WCEnumFormatEtc):
2204         (WCEnumFormatEtc::QueryInterface):
2205         (WCEnumFormatEtc::AddRef):
2206         (WCEnumFormatEtc::Release):
2207         (WCEnumFormatEtc::Next):
2208         (WCEnumFormatEtc::Skip):
2209         (WCEnumFormatEtc::Reset):
2210         (WCEnumFormatEtc::Clone):
2211         (DRTDataObject::createInstance):
2212         (DRTDataObject::DRTDataObject):
2213         (DRTDataObject::~DRTDataObject):
2214         (DRTDataObject::QueryInterface):
2215         (DRTDataObject::AddRef):
2216         (DRTDataObject::Release):
2217         (DRTDataObject::GetData):
2218         (DRTDataObject::GetDataHere):
2219         (DRTDataObject::QueryGetData):
2220         (DRTDataObject::GetCanonicalFormatEtc):
2221         (DRTDataObject::SetData):
2222         (DRTDataObject::CopyMedium):
2223         (DRTDataObject::EnumFormatEtc):
2224         (DRTDataObject::DAdvise):
2225         (DRTDataObject::DUnadvise):
2226         (DRTDataObject::EnumDAdvise):
2227         (DRTDataObject::clearData):
2228         * DumpRenderTree/win/DRTDataObject.h: Added.
2229         (DRTDataObject):
2230         * DumpRenderTree/win/DRTDropSource.cpp: Added.
2231         (DRTDropSource::DRTDropSource):
2232         (DRTDropSource::~DRTDropSource):
2233         (DRTDropSource::QueryInterface):
2234         (DRTDropSource::AddRef):
2235         (DRTDropSource::Release):
2236         (DRTDropSource::createInstance):
2237         (DRTDropSource::QueryContinueDrag):
2238         (DRTDropSource::GiveFeedback):
2239         * DumpRenderTree/win/DRTDropSource.h: Added.
2240         (DRTDropSource):
2241         * DumpRenderTree/win/DumpRenderTree.vcproj:
2242         * DumpRenderTree/win/EventSender.cpp:
2243         (beginDragWithFilesCallback):
2244
2245 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
2246
2247         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
2248         https://bugs.webkit.org/show_bug.cgi?id=58593
2249
2250         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
2251         to WebKitTestRunner's LayoutTestController. The flag is modified via the
2252         public C API of the WebProcess.
2253
2254         Reviewed by Darin Adler.
2255
2256         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2257         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2258         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
2259         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
2260         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2261
2262 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2263
2264         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
2265         https://bugs.webkit.org/show_bug.cgi?id=87848
2266
2267         Reviewed by Csaba Osztrogonác.
2268
2269         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
2270         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
2271         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
2272
2273         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2274         (DumpRenderTreeChrome::extraViews):
2275         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2276         (DumpRenderTreeChrome):
2277
2278 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2279
2280         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
2281         https://bugs.webkit.org/show_bug.cgi?id=87833
2282
2283         Reviewed by Tor Arne Vestbø.
2284
2285         Print "postProgressFinishedNotification" message if frame load finished 
2286         to unskip http/tests/loading/progress-finished-callback.html.
2287
2288         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2289         (DumpRenderTreeChrome::onFrameLoadFinished):
2290
2291 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
2292
2293         [EFL][WK2] Fix WebKit2-EFL build
2294         https://bugs.webkit.org/show_bug.cgi?id=83693
2295
2296         Reviewed by Carlos Garcia Campos.
2297
2298         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
2299
2300 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
2301
2302         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
2303         (They only used to check for Skipped in platform/qt-5.0-wk1)
2304         https://bugs.webkit.org/show_bug.cgi?id=87376
2305
2306         Reviewed by Csaba Osztrogonác.
2307
2308         * Scripts/old-run-webkit-tests:
2309         (buildPlatformResultHierarchy):
2310         * Scripts/webkitpy/layout_tests/port/qt.py:
2311         (QtPort.baseline_search_path):
2312
2313 2012-05-29  Ojan Vafai  <ojan@chromium.org>
2314
2315         Add a linter error for pngs that lack an embedded checksum
2316         https://bugs.webkit.org/show_bug.cgi?id=87793
2317
2318         Reviewed by Dirk Pranke.
2319
2320         * Scripts/read-checksum-from-png:
2321         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
2322         (read_checksum):
2323         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
2324         (ReadChecksumFromPngTest):
2325         (ReadChecksumFromPngTest.test_read_checksum):
2326         * Scripts/webkitpy/layout_tests/port/base.py:
2327         * Scripts/webkitpy/style/checkers/png.py:
2328         (PNGChecker.check):
2329         * Scripts/webkitpy/style/checkers/png_unittest.py:
2330         (PNGCheckerTest.test_check):
2331
2332 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2333
2334         https://bugs.webkit.org/show_bug.cgi?id=87720
2335         WebProcess is often killed due to being unresponsive on the bots
2336
2337         Reviewed by Alexey Proskuryakov.
2338
2339         Blind attempt to improve flakiness on the bots by reducing the number
2340         of crashes due to an unresponsive process.  This helped on my personal machine
2341         under stress conditions.  I don't have enough cores to hit the problem
2342         under normal conditions.
2343
2344         * WebKitTestRunner/TestController.cpp:
2345         (WTR):
2346
2347 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2348
2349         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
2350         https://bugs.webkit.org/show_bug.cgi?id=87779
2351
2352         Reviewed by Eric Seidel.
2353
2354         Update output to match the names in scm.py as per
2355         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
2356
2357         * Scripts/webkitpy/tool/commands/rebaseline.py:
2358         (RebaselineTest.execute):
2359         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2360         (test_rebaseline_test_and_print_scm_changes):
2361         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2362         (GardeningServerTest.test_rebaselineall):
2363
2364 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=87711
2367
2368         Reviewed by Jessie Berlin.
2369
2370         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
2371         are better maintained.
2372
2373         * BuildSlaveSupport/build.webkit.org-config/config.json:
2374
2375 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2376
2377         webkit-patch optimize-baselines should add/delete files in batches from the vcs
2378         https://bugs.webkit.org/show_bug.cgi?id=87538
2379
2380         Reviewed by Ojan Vafai.
2381
2382         Invoking git and svn on one file at a time is kinda slow. We
2383         should batch the add and rm operations together.
2384
2385         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2386         (BaselineOptimizer._move_baselines):
2387
2388 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2389
2390         garden-o-matic should rebaseline baselines in parallel
2391         https://bugs.webkit.org/show_bug.cgi?id=87451
2392
2393         Reviewed by Ojan Vafai.
2394                                                                                
2395         This modifies garden-o-matic so that we will fetch all                  
2396         of the baselines in parallel from the bots, and then                    
2397         optimize the baselines serially (since that should be fairly            
2398         quick and we get into trouble if we optimize in parallel due            
2399         to concurrent access to the source control system).                     
2400
2401         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
2402         so that the files that need to be modified in the SCM are returned to 
2403         garden-o-matic rather than actually added or removed. This is done so that
2404         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
2405         concurrently). In order to safely return the files (as a JSON dict) I
2406         needed to shift all of the logging in rebaseline-test to use the logging
2407         module (and hence log to stderr).
2408
2409         I also had to stub out a line in chromium.py that would get confused if
2410         the skia overrides file didn't exist in a mock checkout.
2411
2412         * Scripts/webkitpy/common/system/executive.py:
2413         (Executive.popen):
2414         (Executive):
2415         (Executive.run_in_parallel):
2416         (_run_command_thunk):
2417         * Scripts/webkitpy/common/system/executive_mock.py:
2418         (MockExecutive.run_in_parallel):
2419         * Scripts/webkitpy/common/system/executive_unittest.py:
2420         (ExecutiveTest.test_run_in_parallel):
2421         * Scripts/webkitpy/layout_tests/port/chromium.py:
2422         (ChromiumPort._expectations_file_contents):
2423         * Scripts/webkitpy/tool/commands/rebaseline.py:
2424         (AbstractRebaseliningCommand.__init__):
2425         (RebaselineTest.__init__):
2426         (RebaselineTest._copy_existing_baseline):
2427         (RebaselineTest._save_baseline):
2428         (RebaselineTest):
2429         (RebaselineTest._add_to_scm):
2430         (RebaselineTest._rebaseline_test):
2431         (RebaselineTest.execute):
2432         (RebaselineExpectations._rebaseline_port):
2433         (RebaselineExpectations.execute):
2434         (Rebaseline._builder_to_pull_from):
2435         (Rebaseline.execute):
2436         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2437         (test_rebaseline_updates_expectations_file):
2438         (test_rebaseline_test):
2439         (test_rebaseline_test_and_print_scm_changes):
2440         (test_rebaseline_and_copy_test):
2441         (test_rebaseline_and_copy_test_no_existing_result):
2442         (test_rebaseline_and_copy_test_with_lion_result):
2443         (test_rebaseline_and_copy_no_overwrite_test):
2444         (test_rebaseline_expectations):
2445         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2446         (GardeningHTTPRequestHandler._rebaseline_commands):
2447         (GardeningHTTPRequestHandler):
2448         (GardeningHTTPRequestHandler._files_to_add):
2449         (GardeningHTTPRequestHandler._optimize_baselines):
2450         (GardeningHTTPRequestHandler.rebaselineall):
2451         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2452         (GardeningServerTest._post_to_path):
2453         (GardeningServerTest.test_rebaselineall):
2454         (GardeningServerTest.test_rebaselineall.run_command):
2455
2456 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
2457
2458         Fix the type of dispatch_time() offset
2459
2460         Rubber-stamped by Joseph Pecoraro.
2461
2462         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
2463
2464         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2465         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2466
2467 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2468
2469         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2470
2471         [BlackBerry] OpenGL content is not rendered on simulator
2472         https://bugs.webkit.org/show_bug.cgi?id=87721
2473
2474         Reviewed by George Staikos.
2475
2476         Fixed by enabling GLES2 support in simulator builds.
2477
2478         To experiment with building without OpenGL support, you can set the
2479         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
2480
2481         PR #150695
2482
2483         * Scripts/webkitdirs.pm:
2484         (blackberryCMakeArguments):
2485
2486 2012-05-29  David Barr  <davidbarr@chromium.org>
2487
2488         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
2489         https://bugs.webkit.org/show_bug.cgi?id=87685
2490
2491         Reviewed by Eric Seidel.
2492
2493         Add a configuration option for CSS image-resolution support, disabling it by default.
2494
2495         * Scripts/webkitperl/FeatureList.pm:
2496         * qmake/mkspecs/features/features.pri:
2497
2498 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2499
2500         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
2501
2502         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
2503             valid for C++/ObjC++ but not for C [enabled by default]"
2504
2505         Reviewed by Simon Hausmann.
2506
2507         * qmake/mkspecs/features/unix/default_post.prf:
2508
2509 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2510
2511         [Qt] Sync up favicon-implementation with WebView url changes in r118158
2512
2513         https://bugs.webkit.org/show_bug.cgi?id=87133
2514
2515         We now base64-encode the page url in the image-provider url, so that any
2516         normalization done by QUrl will not mess up the page-url. The logic of
2517         creating and parsing the provider-url has been moved into the image
2518         provider, to keep it in one place.
2519
2520         We were also releasing icons (even ones we hadn't retained), which we can't
2521         do since we don't know when the icon url is no longer in use.
2522
2523         Reviewed-by Simon Hausmann.
2524
2525         * MiniBrowser/qt/icons/favicon.png:
2526         * MiniBrowser/qt/qml/BrowserWindow.qml:
2527
2528 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2529
2530         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
2531         https://bugs.webkit.org/show_bug.cgi?id=87654
2532
2533         Reviewed by Csaba Osztrogonác.
2534
2535         Event sender provides strings for all the key events.
2536         Also KeyEventInfo constructor parameters order was changed to simplify the case when
2537         a key event has empty string.
2538
2539         * DumpRenderTree/efl/EventSender.cpp:
2540         (KeyEventInfo::KeyEventInfo):
2541         (keyPadNameFromJSValue):
2542         (keyNameFromJSValue):
2543
2544 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2545
2546         [Qt] Cancel potential url-edit when going back/forward
2547
2548         Reviewed by Kenneth Rohde Christiansen.
2549
2550         * MiniBrowser/qt/qml/BrowserWindow.qml:
2551
2552 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
2553
2554         [EFL] Compilation warning in DumpRenderTreeView.cpp
2555         https://bugs.webkit.org/show_bug.cgi?id=87636
2556
2557         Reviewed by Filip Pizlo.
2558
2559         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
2560         specifier in printf. Also fix the return type for
2561         onExceededApplicationCacheQuota callback.
2562
2563         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2564         (onExceededApplicationCacheQuota):
2565
2566 2012-05-29  Hironori Bono  <hbono@chromium.org>
2567
2568         Adding Hironori Bono to committers.py.
2569         https://bugs.webkit.org/show_bug.cgi?id=87697
2570
2571         * Scripts/webkitpy/common/config/committers.py:
2572
2573 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2574
2575         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
2576         https://bugs.webkit.org/show_bug.cgi?id=80135
2577
2578         Reviewed by Rob Buis.
2579
2580         Implemented interface function didReceiveAuthenticationChallenge in class
2581         DumpRenderTree.
2582
2583         Resubmit the patch reverted by r115104 after the digest infinite loop
2584         issue for BlackBerry porting get identified and fixed.
2585
2586         Internally reviewed by Joe Mason <jmason@rim.com>
2587
2588         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2589         (drtCredentialDescription):
2590         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
2591         (WebKit):
2592         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2593         (WebCore):
2594         (DumpRenderTree):
2595
2596 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2597
2598         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2599         https://bugs.webkit.org/show_bug.cgi?id=42328
2600
2601         Reviewed by Eric Seidel.
2602
2603         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2604         move to windows.internals.settings.
2605
2606         * DumpRenderTree/LayoutTestController.cpp:
2607         (LayoutTestController::staticFunctions):
2608         * DumpRenderTree/LayoutTestController.h:
2609         (LayoutTestController):
2610         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2611         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2612         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2613         (DRTDevToolsAgent):
2614         * DumpRenderTree/chromium/LayoutTestController.cpp:
2615         (LayoutTestController::LayoutTestController):
2616         * DumpRenderTree/chromium/LayoutTestController.h:
2617         (LayoutTestController):
2618         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2619         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2620         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2621         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2622         * DumpRenderTree/mac/DumpRenderTree.mm:
2623         (resetWebViewToConsistentStateBeforeTesting):
2624         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2625         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2626         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2627         (LayoutTestController):
2628         * DumpRenderTree/win/DumpRenderTree.cpp:
2629         (resetWebViewToConsistentStateBeforeTesting):
2630         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2631         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2632         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2633         (LayoutTestController):
2634
2635 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2636
2637         Move allowRoundingHacks to Internals interface
2638         https://bugs.webkit.org/show_bug.cgi?id=87328
2639
2640         Reviewed by Hajime Morita.
2641
2642         Remove allowRoundingHacks functions, because it is able to work in the
2643         cross-port way through the Internals interface.
2644
2645         * DumpRenderTree/LayoutTestController.cpp:
2646         (LayoutTestController::staticFunctions):
2647         * DumpRenderTree/LayoutTestController.h:
2648         (LayoutTestController):
2649         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2650         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2651         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2652         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2653         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2654         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2655
2656 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2657
2658         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2659         https://bugs.webkit.org/show_bug.cgi?id=87616
2660
2661         Reviewed by Hajime Morita.
2662
2663         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2664         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2665         Patch just adds a #ifndef / #define check.
2666
2667         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2668         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2669
2670 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2671
2672         [EFL] Enable blob support for the EFL port
2673         https://bugs.webkit.org/show_bug.cgi?id=85363
2674
2675         Reviewed by Hajime Morita.
2676
2677         Enable Blob support by default for the EFL port.
2678
2679         * Scripts/webkitperl/FeatureList.pm:
2680
2681 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2682
2683         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2684         https://bugs.webkit.org/show_bug.cgi?id=87582
2685
2686         Reviewed by Darin Adler.
2687
2688         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2689         possible to test pages in a similar way as they are loaded in Browsers.
2690
2691         * DumpRenderTree/LayoutTestController.cpp:
2692         (LayoutTestController::LayoutTestController):
2693         (setUseDeferredFrameLoadingCallback):
2694         (LayoutTestController::staticFunctions):
2695         * DumpRenderTree/LayoutTestController.h:
2696         (LayoutTestController::useDeferredFrameLoading):
2697         (LayoutTestController::setUseDeferredFrameLoading):
2698         (LayoutTestController):
2699         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2700         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2701
2702 2012-05-27  David Barton  <dbarton@mathscribe.com>
2703
2704         [watchlist] Improve MathML rule
2705         https://bugs.webkit.org/show_bug.cgi?id=87592
2706
2707         Reviewed by Adam Barth.
2708
2709         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2710         but if this changed the rule would be slow. We protect against this, clarify the rule,
2711         and make it more similar to existing rules.
2712
2713         * Scripts/webkitpy/common/config/watchlist:
2714
2715 2012-05-27  David Barton  <dbarton@mathscribe.com>
2716
2717         [watchlist] Add myself & a rule for MathML
2718         https://bugs.webkit.org/show_bug.cgi?id=87586
2719
2720         Reviewed by Adam Barth.
2721
2722         * Scripts/webkitpy/common/config/watchlist:
2723
2724 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2725
2726         Use xcrun to find path to nm for Mac port
2727         <http://webkit.org/b/87588>
2728
2729         Reviewed by Dan Bernstein.
2730
2731         * Scripts/webkitpy/layout_tests/port/mac.py:
2732         (MacPort.nm_command): Add. Tries to find a path for the nm
2733         command using xcrun.  Falls back to returning 'nm'.
2734         * Scripts/webkitpy/layout_tests/port/webkit.py:
2735         (WebKitPort.nm_command): Add. Returns 'nm'.
2736         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2737
2738 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2739
2740         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2741
2742         Reviewed by Eric Seidel.
2743
2744         * DumpRenderTree/win/DumpRenderTree.vcproj:
2745         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2746         (FrameLoadDelegate::FrameLoadDelegate):
2747         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2748         * DumpRenderTree/win/FrameLoadDelegate.h:
2749         (FrameLoadDelegate):
2750         * DumpRenderTree/win/TextInputController.cpp: Added.
2751         (setMarkedTextCallback):
2752         (hasMarkedTextCallback):
2753         (unmarkTextCallback):
2754         (markedRangeCallback):
2755         (insertTextCallback):
2756         (firstRectForCharacterRangeCallback):
2757         (selectedRangeCallback):
2758         (TextInputController::makeWindowObject):
2759         (TextInputController::getJSClass):
2760         (TextInputController::staticValues):
2761         (TextInputController::staticFunctions):
2762         * DumpRenderTree/win/TextInputController.h: Added.
2763         (TextInputController):
2764         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2765         (TextInputController::setMarkedText):
2766         (TextInputController::hasMarkedText):
2767         (TextInputController::unmarkText):
2768         (TextInputController::markedRange):
2769         (TextInputController::insertText):
2770         (TextInputController::firstRectForCharacterRange):
2771         (TextInputController::selectedRange):
2772
2773 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2774
2775         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2776         https://bugs.webkit.org/show_bug.cgi?id=87528
2777
2778         Reviewed by Ojan Vafai.
2779
2780         launching git or svn for individual files can be slow; this
2781         change will hand multiple paths at once to git and svn so they
2782         can be added in a batch.
2783
2784         * Scripts/webkitpy/common/checkout/scm/git.py:
2785         (Git.add_list):
2786         (Git.delete_list):
2787         * Scripts/webkitpy/common/checkout/scm/scm.py:
2788         (SCM.add):
2789         (SCM):
2790         (SCM.add_list):
2791         (SCM.delete):
2792         (SCM.delete_list):
2793         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2794         (MockSCM.add):
2795         (MockSCM):
2796         (MockSCM.add_list):
2797         (MockSCM.delete):
2798         (MockSCM.delete_list):
2799         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2800         (_shared_test_exists):
2801         (_shared_test_added_files):
2802         (_test_delete_list):
2803         * Scripts/webkitpy/common/checkout/scm/svn.py:
2804         (SVN.add_list):
2805         (SVN.delete_list):
2806
2807 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2808
2809         [NRWT] Add unit testing for perf tests on locked shards
2810         https://bugs.webkit.org/show_bug.cgi?id=87489
2811
2812         Reviewed by Dirk Pranke.
2813
2814         Adding utests that makes sure that perf tests are running in locked
2815         shards and by passing --no-http won't break NRWT (r118421).
2816
2817         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2818         (ShardingTests):
2819         (ShardingTests.test_shard_by_dir):
2820         (ShardingTests.test_shard_every_file):
2821         (ShardingTests.test_shard_in_two):
2822         (ShardingTests.test_multiple_locked_shards):
2823         (LockCheckingManager):
2824         (LockCheckingManager.__init__):
2825         (LockCheckingManager.handle_finished_list):
2826         (ManagerTest.test_http_locking):
2827         (ManagerTest):
2828         (ManagerTest.test_perf_locking):
2829         * Scripts/webkitpy/layout_tests/port/test.py:
2830
2831 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2832
2833         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2834         https://bugs.webkit.org/show_bug.cgi?id=87511
2835
2836         Reviewed by Alexey Proskuryakov.
2837
2838         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2839
2840         * DumpRenderTree/win/EventSender.cpp:
2841         (keyDownCallback):
2842
2843 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2844
2845         Adding Ken Buchanan to committers.py
2846         https://bugs.webkit.org/show_bug.cgi?id=87443
2847
2848         Unreviewed.
2849
2850         Adding self to committers.py as a Committer.
2851
2852         * Scripts/webkitpy/common/config/committers.py:
2853
2854 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2855
2856         [Qt] Buildfix for newer Qt5
2857         https://bugs.webkit.org/show_bug.cgi?id=87257
2858
2859         Reviewed by Simon Hausmann.
2860
2861         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2862
2863 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2864
2865         [Qt] Unreviewed fix after r118484.
2866
2867         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2868         They were enabled uncoditinally before r118484.
2869
2870         * qmake/mkspecs/features/features.pri:
2871
2872 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2873
2874         Add feature defines for web-facing parts of CSS Regions and Exclusions
2875         https://bugs.webkit.org/show_bug.cgi?id=87442
2876         <rdar://problem/10887709>
2877
2878         Reviewed by Dan Bernstein.
2879
2880         * Scripts/webkitperl/FeatureList.pm:
2881
2882 2012-05-24  Hironori Bono  <hbono@chromium.org>
2883
2884         Enable grammar checking on Chromium when we paste text (Take 2)
2885         https://bugs.webkit.org/show_bug.cgi?id=74393
2886
2887         Reviewed by Ryosuke Niwa.
2888
2889         This change enables grammar checking on Chromium and implements a mock grammar
2890         checker to fix a failing test.
2891
2892         * DumpRenderTree/DumpRenderTree.gypi:
2893         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2894         (MockGrammarCheck::checkGrammarOfString):
2895         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2896         (WebKit):
2897         (MockGrammarCheck):
2898         * DumpRenderTree/chromium/WebViewHost.cpp:
2899         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2900
2901 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2902
2903         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2904         https://bugs.webkit.org/show_bug.cgi?id=86842
2905
2906         Reviewed by Antonio Gomes.
2907
2908         Add support for overriding the application cache support preference
2909         through EFL's LayoutTestController.
2910
2911         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2912         (LayoutTestController::overridePreference):
2913
2914 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2915
2916         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2917         https://bugs.webkit.org/show_bug.cgi?id=85209
2918
2919         Reviewed by Antonio Gomes.
2920
2921         Set developer extras setting called twice on the test startup. Hence, removing
2922         an unnecessary extra call which set wrong value. 
2923
2924         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2925         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2926
2927 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2928
2929         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2930         https://bugs.webkit.org/show_bug.cgi?id=86916
2931
2932         Reviewed by Adam Barth.
2933
2934         Note that if release and debug are failing differently, debug
2935         will be ignored ...
2936
2937         Note: also change the use of a fake port name from
2938         "mock-port-name" to "test-mac-leopard" to make it more friendly
2939         to the port factory ("mock" actually is a real port).
2940
2941         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2942         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2943         (GardeningHTTPRequestHandler.rebaselineall):
2944         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2945         (GardeningServerTest.test_rebaselineall):
2946         (GardeningServerTest.test_rebaseline_new_port):
2947
2948 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2949
2950         nrwt: fix baseline search path for official chrome builders
2951         https://bugs.webkit.org/show_bug.cgi?id=87432
2952
2953         Reviewed by Tony Chang.
2954
2955         The official chrome builders need to use the win7 and SL
2956         baseline paths, not the XP and Leopard paths. Linux is correct.
2957
2958         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2959         (GoogleChromeMacPort.determine_full_port_name):
2960         (GoogleChromeWinPort.determine_full_port_name):
2961         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2962         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2963         (TestGoogleChromePort.test_get_google_chrome_port):
2964
2965 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2966
2967         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2968         https://bugs.webkit.org/show_bug.cgi?id=86800
2969
2970         Reviewed by Dirk Pranke.
2971
2972         Don't launch a HTTP server with lock based only on the existence of
2973         locked shards since we now run perf on locked shards too.
2974
2975         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2976         (Manager._run_tests):
2977
2978 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2979
2980         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2981         https://bugs.webkit.org/show_bug.cgi?id=87128
2982
2983         Reviewed by Dirk Pranke.
2984
2985         * Scripts/webkitpy/layout_tests/port/base.py:
2986         (Port.driver_name):
2987         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2988         (ChromiumLinuxPort._path_to_driver):
2989         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2990         (ChromiumPortTest.test_driver_name_option):
2991         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2992         (ChromiumWinPort._path_to_driver):
2993         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2994         (parse_args):
2995
2996 2012-05-24  John Mellor  <johnme@chromium.org>
2997
2998         Font Boosting: Add compile flag and runtime setting
2999         https://bugs.webkit.org/show_bug.cgi?id=87394
3000
3001         Reviewed by Adam Barth.
3002
3003         Add ENABLE_FONT_BOOSTING.
3004
3005         * Scripts/webkitperl/FeatureList.pm:
3006         * qmake/mkspecs/features/features.pri:
3007
3008 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3009
3010         [EFL] [DRT] keyboard-related tests do not pass
3011         https://bugs.webkit.org/show_bug.cgi?id=85369
3012
3013         Reviewed by Gustavo Noronha Silva.
3014
3015         Add SHIFT modifier for capital letters as VK_ 
3016         codes do not distinguish between lows and caps and also to be consistent
3017         with other ports which send caps as lowercase letters with the shift key down.
3018
3019         * DumpRenderTree/efl/EventSender.cpp:
3020         (keyNameFromJSValue): 
3021
3022 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
3023
3024         [WK2] Let the client give local files universal access on a case by case basis
3025         https://bugs.webkit.org/show_bug.cgi?id=87174
3026         <rdar://problem/11024330>
3027
3028         Reviewed by Maciej Stachowiak.
3029
3030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
3031         Added initialization of a new structure member to prevent build failure.
3032
3033 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
3034
3035         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
3036         https://bugs.webkit.org/show_bug.cgi?id=87203
3037
3038         Reviewed by Andreas Kling.
3039
3040         Add the required changes to make
3041         fast/events/keydown-leftright-keys.html pass after r118001.
3042
3043         * DumpRenderTree/efl/EventSender.cpp:
3044         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
3045         into the proper X11 keysym definitions.
3046
3047 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3048
3049         Unreviewed, rolling out r118352.
3050         http://trac.webkit.org/changeset/118352
3051         https://bugs.webkit.org/show_bug.cgi?id=87390
3052
3053         Caused 6 editing/spelling tests crash/fail on chromium in
3054         debug. (Requested by vsevik on #webkit).
3055
3056         * DumpRenderTree/DumpRenderTree.gypi:
3057         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
3058         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
3059         * DumpRenderTree/chromium/WebViewHost.cpp:
3060         (WebViewHost::finishLastTextCheck):
3061
3062 2012-05-24  Peter Beverloo  <peter@chromium.org>
3063
3064         Add John Mellor as a contributor
3065         https://bugs.webkit.org/show_bug.cgi?id=87389
3066
3067         Reviewed by Kenneth Rohde Christiansen.
3068
3069         John will be working on Font Boosting and is very involved with various
3070         web-facing subjects of Chrome for Android, such as viewport.
3071
3072         * Scripts/webkitpy/common/config/committers.py:
3073
3074 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3075
3076         [EFL][DRT] LayoutTestController's setCacheModel() implementation
3077         https://bugs.webkit.org/show_bug.cgi?id=86840
3078
3079         Reviewed by Csaba Osztrogonác.
3080
3081         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3082         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
3083         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3084         (LayoutTestController::setCacheModel): Implementation added.
3085
3086 2012-05-24  Hironori Bono  <hbono@chromium.org>
3087
3088         Enable grammar checking on Chromium when we paste text.
3089         https://bugs.webkit.org/show_bug.cgi?id=74393
3090
3091         Reviewed by Hajime Morita.
3092
3093         This change enables grammar checking on Chromium and implements a mock grammar
3094         checker to fix a failing test.
3095
3096         * DumpRenderTree/DumpRenderTree.gypi:
3097         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
3098         (MockGrammarCheck::checkGrammarOfString):
3099         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
3100         (WebKit):
3101         (MockGrammarCheck):
3102         * DumpRenderTree/chromium/WebViewHost.cpp:
3103         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
3104
3105 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
3106
3107         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
3108
3109         * qmake/mkspecs/features/features.pri:
3110
3111 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3112
3113         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
3114         https://bugs.webkit.org/show_bug.cgi?id=86867
3115
3116         Reviewed by Adam Barth.
3117
3118         Add implementation for sendWebIntentResponse() in EFL's
3119         LayoutTestController and add empty implementation for other ports.
3120
3121         * DumpRenderTree/LayoutTestController.cpp:
3122         (sendWebIntentResponseCallback):
3123         (LayoutTestController::staticFunctions):
3124         * DumpRenderTree/LayoutTestController.h:
3125         (LayoutTestController):
3126         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3127         (LayoutTestController::sendWebIntentResponse):
3128         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3129         (DumpRenderTreeChrome::currentIntentRequest):
3130         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3131         (DumpRenderTreeChrome::onFrameIntentNew):
3132         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3133         (DumpRenderTreeChrome):
3134         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3135         (LayoutTestController::sendWebIntentResponse):
3136         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3137         (LayoutTestController::sendWebIntentResponse):
3138         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3139         (LayoutTestController::sendWebIntentResponse):
3140         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3141         (LayoutTestController::sendWebIntentResponse):
3142         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3143         (LayoutTestController::sendWebIntentResponse):
3144
3145 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3146
3147         [EFL] The EFL port has no support for title directionality
3148         https://bugs.webkit.org/show_bug.cgi?id=86462
3149
3150         Reviewed by Gustavo Noronha Silva.
3151
3152         Update "title,changed" signal handlers in DRT and EWebLauncher to
3153         reflect the change from const char* to Ewk_Text_With_Direction* type
3154         for the title.
3155
3156         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3157         (DumpRenderTreeChrome::onTitleChanged):
3158         * EWebLauncher/main.c:
3159         (title_set):
3160         (on_title_changed):
3161         (on_key_down):
3162
3163 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3164
3165         Change EFL debug build name with more detail one
3166         https://bugs.webkit.org/show_bug.cgi?id=87254
3167
3168         Reviewed by Ryosuke Niwa.
3169
3170         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
3171         In addition, remove efl-linux-debug triggerable since nobody uses it.
3172
3173         * BuildSlaveSupport/build.webkit.org-config/config.json:
3174
3175 2012-05-23  Kangil Han  <kangil.han@samsung.com>
3176
3177         [EFL][DRT] Fix WebCore library path and rebaseline result
3178         https://bugs.webkit.org/show_bug.cgi?id=86355
3179
3180         Reviewed by Dirk Pranke.
3181
3182         Currently EFL DRT uses wrong WebCore library path when running DRT.
3183         Therefore, this patch adjusted the path correctly.
3184
3185         * Scripts/webkitpy/layout_tests/port/efl.py:
3186         (EflPort._path_to_webcore_library):
3187
3188 2012-05-23  Ojan Vafai  <ojan@chromium.org>
3189
3190         add back the ability to disable flexbox
3191         https://bugs.webkit.org/show_bug.cgi?id=87147
3192
3193         Reviewed by Tony Chang.
3194
3195         * Scripts/webkitperl/FeatureList.pm:
3196
3197 2012-05-23  Tony Chang  <tony@chromium.org>
3198
3199         Remove the Chromium Grid Layout bot from the waterfall
3200         https://bugs.webkit.org/show_bug.cgi?id=87311
3201
3202         Reviewed by Ryosuke Niwa.
3203
3204         I removed the compiler define in r117613, so we don't need a separate
3205         bot to compile/test this code.
3206
3207         * BuildSlaveSupport/build.webkit.org-config/config.json:
3208
3209 2012-05-23  Ian Vollick  <vollick@chromium.org>
3210
3211         Add vollick to list of contributors.
3212         https://bugs.webkit.org/show_bug.cgi?id=87305
3213
3214         Reviewed by Adam Barth.
3215
3216         * Scripts/webkitpy/common/config/committers.py:
3217
3218 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
3219
3220         [Chromium-Android] Fix chromium_android_unittest
3221         https://bugs.webkit.org/show_bug.cgi?id=87196
3222
3223         Reviewed by Tony Chang.
3224
3225         Update unit tests after ChromiumAndroidPort supported apk based
3226         DumpRenderTree.
3227
3228         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3229         (ChromiumAndroidPortTest):
3230         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
3231         (ChromiumAndroidPortTest.test_get_last_stacktrace):
3232         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
3233         (ChromiumAndroidDriverTest):
3234         (ChromiumAndroidDriverTest.setUp):
3235         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
3236         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
3237
3238 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3239
3240         [watchlist] Add myself and create a watch rule to catch Attribute related patches
3241         https://bugs.webkit.org/show_bug.cgi?id=87303
3242
3243         Reviewed by Alexis Menard.
3244
3245         * Scripts/webkitpy/common/config/watchlist:
3246
3247 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
3248
3249         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3250         https://bugs.webkit.org/show_bug.cgi?id=86916
3251
3252         Reviewed by Adam Barth.
3253
3254         This change pushes all of the logic for rebaselining a cluster
3255         of failures (a list of tests failing a list of suffixes on a
3256         list of bots) onto the server, so there is a single call from
3257         the web page; we will then be able to optimize the performance
3258         of the rebaselining better.
3259
3260         Also remove the 'optimizebaseline' entry point on garden-o-matic
3261         (and the client-side call) since we don't need it any more.
3262
3263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3265         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3266         (GardeningHTTPRequestHandler.rebaselineall):
3267         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3268
3269 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3270
3271         Mac DRT should be able to load external URLs for replay performance tests
3272         https://bugs.webkit.org/show_bug.cgi?id=86191
3273
3274         Reviewed by Alexey Proskuryakov.
3275
3276         Let external URL requests go through if the test file is not a local file or hosted at localhost.
3277         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
3278         "DumpRenderTree http://localhost:8000/".
3279
3280         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3281         (isLocalhost):
3282         (hostIsUsedBySomeTestsToGenerateError):
3283         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3284
3285 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
3286
3287         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
3288         debug symbols for easier debugging.
3289         https://bugs.webkit.org/show_bug.cgi?id=87151
3290
3291         Reviewed by Kevin Ollivier.
3292
3293         * waf/build/settings.py:
3294         (common_configure):
3295
3296 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3297
3298         Unreviewed. Move myself to reviewers.
3299
3300         * Scripts/webkitpy/common/config/committers.py:
3301
3302 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
3303
3304         [EFL] Implements the registerProtocolHandler method and option.
3305         https://bugs.webkit.org/show_bug.cgi?id=73638
3306
3307         Reviewed by Andreas Kling.
3308
3309         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
3310
3311 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
3312
3313         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
3314         https://bugs.webkit.org/show_bug.cgi?id=87221
3315
3316         Reviewed by Martin Robinson.
3317
3318         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
3319         rightShift key names into proper GDK key symbols.
3320
3321         * DumpRenderTree/gtk/EventSender.cpp:
3322         (createKeyPressEvent):
3323
3324 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3325
3326         [Qt] Make the web view's url property follow the active url
3327
3328         https://bugs.webkit.org/show_bug.cgi?id=77554
3329
3330         Update  the location bar in the minibrowser to behave
3331         a bit more like normal browsers in terms of when the url will change
3332         and how active focus is handled.
3333
3334         Reviewed by Simon Hausmann.
3335
3336         * MiniBrowser/qt/qml/BrowserWindow.qml:
3337
3338 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3339
3340         [Qt] Remove references to $$QT_SOURCE_TREE
3341
3342         With a modularized Qt, it's ambigious. What we really want is qtbase,
3343         which qtcore is a proxy for (we assume it will always live in qtbase).
3344
3345         Reviewed by Tor Arne Vestbø.
3346
3347         * DumpRenderTree/qt/DumpRenderTree.pro:
3348
3349 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3350
3351         [Qt] Fix qmake conditional for c++-11 compat warnings
3352
3353         Reviewed by Tor Arne Vestbø.
3354
3355         * qmake/mkspecs/features/unix/default_post.prf:
3356
3357 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3358
3359         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
3360         https://bugs.webkit.org/show_bug.cgi?id=85956
3361
3362         Reviewed by Gustavo Noronha Silva.
3363
3364         Catch new "load,provisional,failed" signal and print
3365         didFailProvisionalLoadWithError messages when LayoutTestController's
3366         dumpFrameLoadCallbacks() returns true. Also make sure the
3367         didFailLoadWithError message is not printed in case of provisional
3368         load failure.
3369
3370         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3371         (DumpRenderTreeChrome::createView):
3372         (DumpRenderTreeChrome::onFrameCreated):
3373         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
3374         (DumpRenderTreeChrome::onFrameLoadError):
3375         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3376         (DumpRenderTreeChrome):
3377
3378 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3379
3380         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
3381         https://bugs.webkit.org/show_bug.cgi?id=86366
3382
3383         Reviewed by Antonio Gomes.
3384
3385         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
3386
3387         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3388         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3389
3390 2012-05-22  Darin Adler  <darin@apple.com>
3391
3392         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
3393         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
3394
3395 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3396
3397         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
3398         https://bugs.webkit.org/show_bug.cgi?id=86922
3399
3400         Because we have new platformInit() in TestShellAndroid.cpp, and
3401         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
3402         is split into TestShellPosix.cpp and TestShellX11.cpp.
3403
3404         Reviewed by Kent Tamura.
3405
3406         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3407         * DumpRenderTree/DumpRenderTree.gypi:
3408         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
3409         (platformInit):
3410         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
3411         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
3412         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
3413         (AlarmHandler):
3414         (TestShell::waitTestFinished):
3415         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
3416         (openStartupDialog): from TestShellGtk.cpp
3417         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
3418         (setupFontconfig):
3419         (platformInit):
3420
3421 2012-05-22  Kangil Han  <kangil.han@samsung.com>
3422
3423         [EFL][DRT] Implement touch event
3424         https://bugs.webkit.org/show_bug.cgi?id=86720
3425
3426         Reviewed by Hajime Morita.
3427
3428         Currently EFL DRT doesn't support touch event.
3429         Therefore, this patch enabled it and implemented some eventSender function callbacks.
3430
3431         * DumpRenderTree/efl/EventSender.cpp:
3432         (TouchEventInfo::TouchEventInfo):
3433         (TouchEventInfo):
3434         (touchPointList):
3435         (sendTouchEvent):
3436         (addTouchPointCallback):
3437         (touchStartCallback):
3438         (updateTouchPointCallback):
3439         (touchMoveCallback):
3440         (cancelTouchPointCallback):
3441         (touchCancelCallback):
3442         (releaseTouchPointCallback):
3443         (touchEndCallback):
3444         (clearTouchPointsCallback):
3445         (setTouchModifierCallback):
3446         * Scripts/webkitperl/FeatureList.pm:
3447
3448 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3449
3450         [Chromium-Android] Fix chromium_android_unittest
3451         https://bugs.webkit.org/show_bug.cgi?id=87196
3452
3453         Not reviewed.
3454         Temporarily disable chromium_android_unittest.
3455
3456         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3457         (ChromiumAndroidPortTest):
3458         (ChromiumAndroidDriverTest):
3459
3460 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3461
3462         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
3463         https://bugs.webkit.org/show_bug.cgi?id=64313
3464
3465         Reviewed by Jon Honeycutt.
3466
3467         Add it.
3468
3469         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3470         Make sure to generate the binding.
3471
3472         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3473         (WTR::LayoutTestController::setDefersLoading):
3474         Call WKBundlePageSetDefersLoading.
3475         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3476
3477 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3478
3479         [Chromium-Android] Run DumpRenderTree as an apk (python part)
3480         https://bugs.webkit.org/show_bug.cgi?id=86923
3481
3482         chromium_android.py is modified to support running DumpRenderTree as
3483         an apk, so that we can run the tests (e.g. video) requiring features
3484         implemented in Java on Android.
3485
3486         Reviewed by Adam Barth.
3487
3488         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3489         (ChromiumAndroidPort.__init__):
3490         (ChromiumAndroidPort.default_child_processes):
3491         (ChromiumAndroidPort.check_wdiff):
3492         (ChromiumAndroidPort.check_build):
3493         (ChromiumAndroidPort.start_helper):
3494         (ChromiumAndroidPort.skipped_layout_tests):
3495         (ChromiumAndroidPort):
3496         (ChromiumAndroidPort._path_to_driver):
3497         (ChromiumAndroidPort._get_crash_log):
3498         (ChromiumAndroidPort._push_executable):
3499         (ChromiumAndroidPort._run_adb_command):
3500         (ChromiumAndroidPort._get_last_stacktrace):
3501         (ChromiumAndroidPort._get_logcat):
3502         (ChromiumAndroidPort._setup_performance):
3503         (ChromiumAndroidDriver):
3504         (ChromiumAndroidDriver.__init__):
3505         (ChromiumAndroidDriver._command_wrapper):
3506         (ChromiumAndroidDriver.cmd_line):
3507         (ChromiumAndroidDriver._file_exists_on_device):
3508         (ChromiumAndroidDriver._deadlock_detector):
3509         (ChromiumAndroidDriver._start):
3510         (ChromiumAndroidDriver.run_test):
3511         (ChromiumAndroidDriver.stop):
3512         (ChromiumAndroidDriver._write_command_and_read_line):
3513         (ChromiumAndroidDriver._output_image):
3514         (ChromiumAndroidDriver._get_stderr):
3515
3516 2012-05-22  Joshua Bell  <jsbell@chromium.org>
3517
3518         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
3519
3520         Unreviewed gardening.
3521
3522         * Scripts/webkitpy/layout_tests/port/base.py:
3523         (Port.driver_name):
3524         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3525         (ChromiumLinuxPort._path_to_driver):
3526         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3527         (ChromiumPortTest.test_overrides_and_builder_names):
3528         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3529         (ChromiumWinPort._path_to_driver):
3530         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3531         (parse_args):
3532
3533 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3534
3535         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
3536         https://bugs.webkit.org/show_bug.cgi?id=87176
3537
3538         Reviewed by Tony Chang.
3539
3540         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3541         * DumpRenderTree/DumpRenderTree.gypi:
3542
3543 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
3544
3545         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3546         https://bugs.webkit.org/show_bug.cgi?id=87128
3547
3548         Reviewed by Dirk Pranke.
3549
3550         * Scripts/webkitpy/layout_tests/port/base.py:
3551         (Port.driver_name):
3552         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3553         (ChromiumLinuxPort._path_to_driver):
3554         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3555         (ChromiumPortTest.test_driver_name_option):
3556         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3557         (ChromiumWinPort._path_to_driver):
3558         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3559         (parse_args):
3560
3561 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3562
3563         WTR fix after r118001.
3564
3565         Rubber-stamped by Alexey Proskuryakov.
3566
3567         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
3568
3569         * WebKitTestRunner/mac/EventSenderProxy.mm:
3570         (WTR::EventSenderProxy::keyDown):
3571
3572 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3573
3574         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
3575         https://bugs.webkit.org/show_bug.cgi?id=86684
3576
3577         Reviewed by Darin Fisher.
3578
3579         * DumpRenderTree/chromium/LayoutTestController.cpp:
3580         (LayoutTestController::numberOfPages):
3581         * DumpRenderTree/chromium/WebViewHost.cpp:
3582         (WebViewHost::printPage):
3583
3584 == Rolled over to ChangeLog-2012-05-22 ==