Allow XMLHttpRequest withCredentials to be set prior to a call to open()
[WebKit-https.git] / Tools / ChangeLog
1 2011-12-24  Dan Bernstein  <mitz@apple.com>
2
3         Make build-webkit aware of additional Xcode build location defaults.
4
5         Reviewed by Anders Carlsson.
6
7         * Scripts/webkitdirs.pm:
8         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
9         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
10         (determineBaseProductDir): Changed to check for a custom build location
11         style specified as an absolute location.
12
13 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
14
15         Unreviewed, rolling out r103619.
16         http://trac.webkit.org/changeset/103619
17         https://bugs.webkit.org/show_bug.cgi?id=66509
18
19         Broke chromium clang build
20
21         * DumpRenderTree/chromium/TestWebWorker.h:
22         (TestWebWorker::createWorker):
23         * DumpRenderTree/chromium/WebViewHost.cpp:
24         (WebViewHost::createWorker):
25         * DumpRenderTree/chromium/WebViewHost.h:
26
27 2011-12-23  Daniel Bates  <dbates@webkit.org>
28
29         Provide option to disable Mac OS 10.7 application resume when using
30         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
31         https://bugs.webkit.org/show_bug.cgi?id=66902
32
33         Reviewed by David Kilzer.
34
35         Add an optional command line argument --no-saved-state to disable
36         application resume (state restoration) for the session on Mac OS 10.7.
37
38         For instance, when debugging an issue in Safari it is useful to be able
39         to temporarily disable application resume. Currently you can disable
40         application resume when launching Safari from within Xcode. We should
41         expose a similar option in our command line tools.
42
43         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
44         to print a help message and exit() if the command line argument --help was given.
45         * Scripts/debug-safari: Ditto.
46         * Scripts/debug-test-runner: Ditto.
47         * Scripts/run-minibrowser: Ditto.
48         * Scripts/run-safari: Ditto.
49         * Scripts/run-test-runner: Ditto.
50         * Scripts/run-test-webkit-api: Ditto.
51         * Scripts/run-webkit-app: Ditto.
52         * Scripts/webkitdirs.pm:
53         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
54         (argumentsForRunAndDebugMacWebKitApp): Added.
55         (runMacWebKitApp): If the --no-saved-state command line argument was given then
56         disable application resume for the session.
57         (execMacWebKitAppForDebugging): Ditto.
58
59 2011-12-23  Dmitry Lomov  <dslomov@google.com>
60
61         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
62         https://bugs.webkit.org/show_bug.cgi?id=66509
63         Just renames, merges and removal of dead code. Here are the list of renames:
64           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
65           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
66           - WebWorkerBase merged into WebSharedWorkerImpl
67           - NewWebWorkerBase renamed into WebWorkerBase
68  
69         Reviewed by David Levin.
70
71         * DumpRenderTree/chromium/TestWebWorker.h:
72         (TestWebWorker::createWorker):
73         * DumpRenderTree/chromium/WebViewHost.cpp:
74         (WebViewHost::createWorker):
75         * DumpRenderTree/chromium/WebViewHost.h:
76
77 2011-12-23  Kentaro Hara  <haraken@chromium.org>
78
79         Let parser_unittests.pl call different language parsers
80         https://bugs.webkit.org/show_bug.cgi?id=75081
81
82         Reviewed by David Kilzer.
83
84         We introduced parser_unittests.pl in bug 74994 , but it is implemented
85         to always call get_function_line_ranges_for_perl(). In order to enable unittests
86         for other languages, this patch lets parser_unittests.pl call different language
87         parsers depending on the languages.
88
89         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
90
91         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
92
93 2011-12-22  Adam Roben  <aroben@apple.com>
94
95         Snow Leopard test fix
96
97         * Scripts/webkitpy/test/main.py:
98         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
99         unittest.main, even though that's the default. So now we explicitly specify a
100         TextTestRunner.
101
102 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
103
104         AX: attributed strings do not include AXHeading information when a link is contained within the heading
105         https://bugs.webkit.org/show_bug.cgi?id=75059
106
107         Reviewed by Darin Adler.
108
109         Support the ability to check if an arbitrary attribute is present within an
110         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
111
112         * DumpRenderTree/AccessibilityUIElement.cpp:
113         (attributedStringForTextMarkerRangeContainsAttributeCallback):
114         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
115         (AccessibilityUIElement::getJSClass):
116         * DumpRenderTree/AccessibilityUIElement.h:
117         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
118         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
119         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
120         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
121         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
122         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
123         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
124         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
125
126 2011-12-22  David Kilzer  <ddkilzer@apple.com>
127
128         run-api-tests: runAllTests() and runTest() should not use global variables
129
130         Reviewed by Adam Roben.
131
132         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
133
134         * Scripts/run-api-tests:
135         (runTestsBySuite): Rename from runAllTests().  Add arguments for
136         list of tests and $verbose.
137         (runTest): Add $verbose argument.
138
139 2011-12-22  David Kilzer  <ddkilzer@apple.com>
140
141         run-api-tests: inline runAllTestsInSuite() into runAllTests()
142
143         Reviewed by Adam Roben.
144
145         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
146
147         In order to make it easy to run one or more individual suites,
148         or one more individual tests, it's easier to call a single
149         method with different data structures than individual methods.
150
151         * Scripts/run-api-tests:
152         (runAllTests): Inline runAllTestsInSuite().
153
154 2011-12-22  Adam Roben  <aroben@apple.com>
155
156         Add a --xml flag to test-webkitpy
157
158         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
159         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
160         This is useful for working with tools that consume JUnit-style XML files.
161
162         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
163         running test-webkitpy
164
165         Reviewed by Darin Adler.
166
167         * Scripts/webkitpy/test/main.py:
168         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
169         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
170
171         * Scripts/webkitpy/thirdparty/__init__.py:
172         (AutoinstallImportHook.find_module):
173         (AutoinstallImportHook._install_xmlrunner):
174         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
175         This change is untested because it's basically impossible to get a test to pass when --xml
176         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
177         the test runs).
178
179 2011-12-22  David Kilzer  <ddkilzer@apple.com>
180
181         TestWebKitAPI: initialize the main thread before running tests
182         <http://webkit.org/b/75064>
183
184         Reviewed by Adam Roben.
185
186         * TestWebKitAPI/TestsController.cpp:
187         (TestWebKitAPI::TestsController::TestsController): Call
188         WTF::initializeMainThread() to prevent assertions in Debug
189         builds.
190
191 2011-12-22  David Kilzer  <ddkilzer@apple.com>
192
193         run-api-tests: dumpAllTests() should not use global variables
194
195         Reviewed by Adam Roben.
196
197         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
198
199         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
200         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
201         global data as an argument.  Sort suite names and test names
202         alphabetically to match output when running tests.
203
204 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
205
206         [BlackBerry] Enable blob for the BlackBerry porting
207         https://bugs.webkit.org/show_bug.cgi?id=75074
208
209         Reviewed by George Staikos.
210
211         * Scripts/build-webkit:
212
213 2011-12-22  Kentaro Hara  <haraken@chromium.org>
214
215         Add unittests for the Perl parser of prepare-ChangeLog
216         https://bugs.webkit.org/show_bug.cgi?id=74994
217
218         Reviewed by David Kilzer.
219
220         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
221
222         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
223
224         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
225         Runs unittests specified in @testFiles.
226         You can reset expected results by specifying a --reset-results option.
227         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
228         Contains simple methods.
229         (func1):
230         (func2):
231         (func3):
232         (func4):
233         (func5):
234         (func6):
235         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
236         This test result is generated by the --reset-results option.
237
238 2011-12-21  Eric Seidel  <eric@webkit.org>
239
240         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
241         so that they appear in the bugzilla autocomplete CC list.
242         I also removed the "radar" irc nick (which I believe does not exist)
243         and removed the uneeded [] around the radar bugzilla email.
244
245         Unreviewed.
246
247         * Scripts/webkitpy/common/config/committers.py:
248
249 2011-12-21  Daniel Bates  <dbates@rim.com>
250
251         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
252         https://bugs.webkit.org/show_bug.cgi?id=74985
253
254         Reviewed by Eric Seidel.
255
256         * Scripts/build-jsc:
257         * Scripts/webkitdirs.pm:
258         (cmakeBasedPortName): Added.
259
260 2011-12-21  Daniel Bates  <dbates@rim.com>
261
262         Extract BlackBerry CMake arguments from build-webkit into separate function
263         https://bugs.webkit.org/show_bug.cgi?id=74981
264
265         Reviewed by Rob Buis.
266
267         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
268         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
269         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
270         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
271         that we can pass them to the CMake build system when building JavaScriptCore.
272
273         * Scripts/build-webkit: Move construction of CMake argument list from here to
274         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
275         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
276         call it from build-webkit.
277         * Scripts/webkitdirs.pm:
278         (blackberryCMakeArguments): Added.
279         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
280         BlackBerry port.
281
282 2011-12-21  Daniel Bates  <dbates@webkit.org>
283
284         Extract WinCE CMake arguments from build-webkit into separate function
285         https://bugs.webkit.org/show_bug.cgi?id=74983
286
287         Reviewed by Rob Buis.
288
289         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
290         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
291         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
292         that we can pass it to the CMake build system when building JavaScriptCore.
293
294         * Scripts/build-webkit:
295         * Scripts/webkitdirs.pm:
296         (cmakeBasedPortArguments): Added.
297
298 2011-12-21  Kentaro Hara  <haraken@chromium.org>
299
300         In prepare-ChangeLog, replace constant global variables with "use constant"
301         https://bugs.webkit.org/show_bug.cgi?id=74992
302
303         Reviewed by Ryosuke Niwa.
304
305         This patch replaces the following constant global variables with "use constant"s.
306             - $changeLogTimeZone
307             - $SVN
308             - $GIT
309             - %supportedTestExtensions
310
311         * Scripts/prepare-ChangeLog:
312         (changeLogNameFromArgs):
313         (changeLogEmailAddressFromArgs):
314         (resolveConflictedChangeLogs):
315         (generateNewChangeLogs):
316         (diffCommand):
317         (statusCommand):
318         (createPatchCommand):
319         (findOriginalFileFromSvn):
320         (determinePropertyChanges):
321         (generateFileList):
322         (reviewerAndDescriptionForGitCommit):
323
324 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
325
326         nrwt: rename field references from _fs to _filesystem
327         https://bugs.webkit.org/show_bug.cgi?id=74898
328
329         Reviewed by Adam Barth.
330
331         This is a simple cleanup; most of the code uses
332         self._filesystem, but some used self._fs; this change renames
333         the latter to the former to be more consistent.
334
335         * Scripts/webkitpy/layout_tests/controllers/manager.py:
336         (Manager.__init__):
337         (Manager.collect_tests):
338         (Manager._strip_test_dir_prefix):
339         (Manager._split_into_chunks_if_necessary):
340         (Manager.results_directory):
341         (Manager._clobber_old_results):
342         (Manager._upload_json_files):
343         (Manager.print_config):
344         (Manager._copy_results_html_file):
345         (Manager._show_results_html_file):
346         (Manager._log_worker_stack):
347         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
348         (JSONLayoutResultsGenerator._normalize_results_json):
349         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
350         (JSONResultsGeneratorBase.__init__):
351         (JSONResultsGeneratorBase.generate_json_output):
352         (JSONResultsGeneratorBase.generate_times_ms_file):
353         (JSONResultsGeneratorBase.upload_json_files):
354         (JSONResultsGeneratorBase._get_svn_revision):
355         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
356         (Base.__init__):
357
358 2011-12-20  Kentaro Hara  <haraken@chromium.org>
359
360         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
361         https://bugs.webkit.org/show_bug.cgi?id=74836
362
363         Reviewed by David Kilzer.
364
365         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
366         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
367         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
368         of prepare-ChangeLog.
369
370         Using LoadAsModule.pm, you can load a Perl script as follows.
371         The first argument is the arbitrary package name you want to use, and the second argument
372         is the name of the Perl script you want to load.
373
374             use LoadAsModule qw(RunLeaks run-leaks);
375             RunLeaks::someFunctionDefinedInRunLeaks(...);
376
377         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
378                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
379                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
380
381         * Scripts/webkitperl/LoadAsModule.pm: Added.
382         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
383         (import):
384         (readFile):
385         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
386         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
387         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
388
389 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
390
391         [Qt] WK2 Debugging quirks need some improvement
392         https://bugs.webkit.org/show_bug.cgi?id=74859
393
394         Reviewed by Simon Hausmann.
395
396         Improvements added to make debugging WebKit2 more
397         confortable and efficient:
398         1. Unify debugging quirks. From now all of them are controlled
399         by the QT_WEBKIT2_DEBUG environment variable.
400         2. Disable crash handlers for WebKitTestRunner if debugging quirks
401         are used to make it possible to use postmortem debugging via core dumps
402         which is extremely useful for debugging bugs triggered by layout tests.
403         3. Disable test timeout for WebKitTestRunner if debugging quirks
404         are used because that makes debugging impossible.
405
406         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
407         (WTR::InjectedBundle::platformInitialize):
408         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
409         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
410         * WebKitTestRunner/qt/TestControllerQt.cpp:
411         (WTR::TestController::platformRunUntil):
412
413 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
414
415         [Qt][WK2] Implement favicon support
416         https://bugs.webkit.org/show_bug.cgi?id=71082
417
418         Reviewed by Simon Hausmann.
419
420         A favorite icon was added on MiniBrowser's url bar as example.
421         We display a default icon when the page doesn't have an icon ready.
422
423         * MiniBrowser/qt/MiniBrowser.qrc:
424         * MiniBrowser/qt/icons/favicon.png: Added.
425         * MiniBrowser/qt/qml/BrowserWindow.qml:
426
427 2011-12-19  Sam Weinig  <sam@webkit.org>
428
429         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
430         https://bugs.webkit.org/show_bug.cgi?id=74907
431
432         Reviewed by Dan Bernstein.
433
434         Add ScrollByLineCommands API test.
435
436         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
437         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
438         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
439
440 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
441
442         webkitpy: remove port.executive, port.filesystem, port.user properties
443         https://bugs.webkit.org/show_bug.cgi?id=74896
444
445         Reviewed by Eric Seidel.
446
447         Following on the refactoring of the port and host objects, this
448         removes the public executive, filesystem, and user properties
449         from the Port interface (protected versions of executive and
450         filesystem still exist). There is still some more clean up to
451         make the code more consistent and rearrange some other files to
452         talk to Hosts directly instead of getting them off of the Port
453         class.
454
455         * Scripts/webkitpy/layout_tests/controllers/manager.py:
456         (Manager.__init__):
457         (Manager.results_directory):
458         (Manager._log_worker_stack):
459         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
460         (ManagerTest.test_fallback_path_in_config):
461         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
462         (_InlineManager.start_worker):
463         (_InlineWorkerConnection.__init__):
464         * Scripts/webkitpy/layout_tests/controllers/worker.py:
465         (Worker.safe_init):
466         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
467         (TestConfiguration.from_port):
468         * Scripts/webkitpy/layout_tests/port/base.py:
469         (Port.__init__):
470         (Port.tests):
471         (Port.show_results_html_file):
472         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
473         (PortTest.test_layout_tests_skipping):
474         (PortTest.test_test_dirs):
475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
476         (_set_up_derived_options):
477         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
478         (PerfTestsRunner.__init__):
479         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
480         (HtmlGenerator.__init__):
481         (HtmlGenerator.show_html):
482         (real_main):
483         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
484         (TestHtmlGenerator.make_generator):
485
486 2011-12-19  Daniel Bates  <dbates@webkit.org>
487
488         Pass command line arguments to GDB when debugging a Mac WebKit application
489         https://bugs.webkit.org/show_bug.cgi?id=72829
490
491         Reviewed by David Kilzer.
492
493         Pass through any command line arguments given to debug-{safari, minibrowser}
494         to GDB so that they may influence the application instance launched by GDB.
495
496         * Scripts/webkitdirs.pm:
497         (execMacWebKitAppForDebugging):
498
499 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
500
501         webkitpy: remove executive,filesystem,user parameters from Port constructor
502         https://bugs.webkit.org/show_bug.cgi?id=74878
503
504         Reviewed by Eric Seidel.
505
506         This change concludes the refactoring that makes Host a required
507         parameter for Port and ensures that all access to filesystem,
508         executives, etc. is going through the Host.
509
510         * Scripts/webkitpy/layout_tests/port/base.py:
511         (Port.__init__):
512
513 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
514
515         webkitpy: finish refactoring port classes to make a host mandatory
516         https://bugs.webkit.org/show_bug.cgi?id=74566
517
518         Reviewed by Eric Seidel.
519
520         This change makes all Port objects take a required (System)Host
521         parameter, and updates the TestPort object to no longer create a
522         mock filesystem or add files to the existing filesystem by
523         default.
524
525         * Scripts/webkitpy/layout_tests/port/base.py:
526         (Port.__init__):
527         * Scripts/webkitpy/layout_tests/port/factory.py:
528         (PortFactory.__init__):
529         (PortFactory._get_kwargs):
530         * Scripts/webkitpy/layout_tests/port/test.py:
531         (TestInstance.__init__):
532         (TestPort.__init__):
533         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
534         (passing_run):
535         (logging_run):
536         (get_tests_run):
537         (MainTest.test_single_file):
538         (MainTest.test_stderr_is_saved):
539         (MainTest.test_test_list):
540         (MainTest.test_test_list_with_prefix):
541         (MainTest.test_missing_and_unexpected_results):
542         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
543         (MainTest.test_crash_with_stderr):
544         (MainTest.test_no_image_failure_with_image_diff):
545         (MainTest.test_crash_log):
546         (MainTest.test_web_process_crash_log):
547         (MainTest.test_exit_after_n_failures_upload):
548         (MainTest.test_results_directory_absolute):
549         (MainTest.test_results_directory_relative):
550         (MainTest.test_retries_directory):
551         (MainTest.test_tolerance.get_port_for_run):
552         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
553         (EndToEndTest.test_end_to_end):
554         (EndToEndTest.test_reftest_with_two_notrefs):
555         (RebaselineTest.test_reset_results):
556         (RebaselineTest.test_missing_results):
557         (RebaselineTest.test_new_baseline):
558         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
559         (Rebaseliner.__init__):
560         (main):
561         (real_main):
562         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
563         (test_host_port_and_filesystem):
564         (TestRebaseliner.make_rebaseliner):
565         (TestRealMain.test_all_platforms):
566         (TestHtmlGenerator.make_generator):
567
568 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
569
570         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
571         https://bugs.webkit.org/show_bug.cgi?id=74562
572
573         Reviewed by Eric Seidel.
574
575         Apart from a minor change to style/checkers/test_expectations.py
576         to take a host as a parameter to a TestExpectationsChecker(),
577         there are only refactoring changes to unit tests here.
578
579         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
580         (TestResultWriterTest.test_reftest_diff_image):
581         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
582         (JSONGeneratorTest._test_json_generation):
583         (JSONGeneratorTest.test_test_timings_trie):
584         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
585         (Base.__init__):
586         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
587         (PortTest.make_port):
588         (PortTest.test_layout_tests_skipping):
589         (PortTest.test_test_dirs):
590         (PortTest.test_additional_platform_directory):
591         (PortTest.test_uses_test_expectations_file):
592         (PortTest.test_find_no_paths_specified):
593         (PortTest.test_find_one_test):
594         (PortTest.test_find_glob):
595         (PortTest.test_find_with_skipped_directories):
596         (PortTest.test_find_with_skipped_directories_2):
597         (PortTest.test_parse_reftest_list):
598         * Scripts/webkitpy/layout_tests/port/dryrun.py:
599         (DryRunPort.__init__):
600         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
601         (FactoryTest.setUp):
602         (FactoryTest.tearDown):
603         (FactoryTest.assert_port):
604         (FactoryTest.assert_platform_port):
605         (FactoryTest.test_unknown_specified):
606         (FactoryTest.test_unknown_default):
607         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
608         (GetGoogleChromePortTest._verify_expectations_overrides):
609         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
610         (MockDRTPortTest.make_port):
611         (MockDRTTest.assertTest):
612         (MockDRTTest.test_main):
613         (MockChromiumDRTTest.test_pixeltest__fails):
614         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
615         (QtPortTest._assert_search_path):
616         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
617         (TestWebKitPort.__init__):
618         (WebKitPortTest.test_skipped_directories_for_symbols):
619         (test_skipped_directories_for_features):
620         (test_skipped_layout_tests):
621         (test_skipped_file_search_paths):
622         (test_root_option):
623         (test_test_expectations):
624         (test_build_driver):
625         (test_linux_distro_detection):
626         (test_apache_config_file_name_for_platform):
627         (test_path_to_apache_config_file):
628         (WebKitDriverTest.test_read_block):
629         * Scripts/webkitpy/style/checkers/test_expectations.py:
630         (TestExpectationsChecker.__init__):
631         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
632         (TestExpectationsTestCase._expect_port_for_expectations_path):
633         (TestExpectationsTestCase.assert_lines_lint):
634         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
635         (get_test_config.TestMacPort):
636
637 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
638
639         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
640         https://bugs.webkit.org/show_bug.cgi?id=74854
641
642         Reviewed by Csaba Osztrogonác.
643
644         Since r101052, libewebkit.so is built in a different location, so we
645         need to adjust the path returned by builtDylibPathForName.
646
647         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
648         port also respects Release/Debug configurations.
649
650         These changes should make run-launcher finally work correctly with
651         webkit-efl.
652
653         * Scripts/webkitdirs.pm:
654         (usesPerConfigurationBuildDirectory):
655         (builtDylibPathForName):
656
657 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
658
659         [Qt][WK2] Add support for modal event loop processing for WTR
660         https://bugs.webkit.org/show_bug.cgi?id=74852
661
662         Reviewed by Kenneth Rohde Christiansen.
663
664         Rewrote event loop processing: Instead of terminating the event loop
665         in notifyDone() - something no other platform does - we now respect the
666         "bool& condition" parameter passed to platformRunUntil. This ensures
667         proper termination even when the condition is changed from within a
668         nested event loop, because only when we _exit_ from the nested event
669         loop we will check the condition and terminate the test properly.
670
671         In addition this patch implements TestController::runModal by means of
672         a nested event loop, which is passed to the platform webview that is
673         supposed to be modal. It is that view's responsibility to exit the
674         loop, upon destruction. I believe that's similar to how it works on the Mac,
675         where it doesn't seem that NSApp's runModalForWindow is terminate via
676         abort/stopModal but simply because the window is closed.
677
678         * WebKitTestRunner/PlatformWebView.h:
679         (WTR::PlatformWebView::setModalEventLoop):
680         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
681         (WTR::PlatformWebView::PlatformWebView):
682         (WTR::PlatformWebView::~PlatformWebView):
683         * WebKitTestRunner/qt/TestControllerQt.cpp:
684         (WTR::TestController::notifyDone):
685         (WTR::TestController::platformRunUntil):
686         (WTR::TestController::runModal):
687
688 2011-12-18  Kentaro Hara  <haraken@chromium.org>
689
690         REGRESSION(r103149): prepare-ChangeLog outputs a warning
691         https://bugs.webkit.org/show_bug.cgi?id=74808
692
693         Reviewed by David Kilzer.
694
695         Added the prototype declaration of main() to avoid warning messages.
696         Sorted subroutine declarations in the alphabetical order.
697
698         * Scripts/prepare-ChangeLog:
699
700 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
701
702         [Qt] Fix QtTestBrowser compilation with QtWidgets module
703         https://bugs.webkit.org/show_bug.cgi?id=74791
704
705         Reviewed by Andreas Kling.
706
707         * QtTestBrowser/QtTestBrowser.pro:
708
709 2011-12-17  Kentaro Hara  <haraken@chromium.org>
710
711         Remove top-level code completely from prepare-ChangeLog
712         https://bugs.webkit.org/show_bug.cgi?id=74698
713
714         Reviewed by Darin Adler.
715
716         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
717         This patch just moves all top-level code into main().
718
719         * Scripts/prepare-ChangeLog:
720         (main):
721
722 2011-12-16  Dean Jackson  <dino@apple.com>
723
724         Move webkit-bug-importer to Contributor. It won't
725         autocomplete as an Account.
726         See https://bugs.webkit.org/show_bug.cgi?id=74739
727         for some discussion.
728
729         Unreviewed.
730
731         * Scripts/webkitpy/common/config/committers.py:
732
733 2011-12-16  Dean Jackson  <dino@apple.com>
734
735         Add webkit-bug-importer@group.apple.com to accounts
736         so that it autocompletes in bugzilla.
737
738         Unreviewed.
739
740         * Scripts/webkitpy/common/config/committers.py:
741
742 2011-12-16  Philippe Normand  <pnormand@igalia.com>
743
744         Unreviewed, skipping 3 failing GTK API tests.
745
746         * Scripts/run-gtk-tests:
747
748 2011-12-16  Philippe Normand  <pnormand@igalia.com>
749
750         Unreviewed, GTK API tests build fix attempt.
751
752         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
753
754 2011-12-16  Philippe Normand  <pnormand@igalia.com>
755
756         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
757
758         * Scripts/run-gtk-tests:
759
760 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
761
762         [Qt] Fix the build for newer Qt5
763         https://bugs.webkit.org/show_bug.cgi?id=74703
764
765         Reviewed by Csaba Osztrogonác.
766
767         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
768         * DumpRenderTree/qt/EventSenderQt.cpp:
769         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
770         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
771         (WTR::EventSenderProxy::sendTouchEvent):
772         * MiniBrowser/qt/MiniBrowserApplication.cpp:
773         (MiniBrowserApplication::sendTouchEvent): Ditto.
774         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
775
776 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
777
778         [Qt] Detect and force clean build when feature defines are added
779
780         Reviewed by Ossy.
781
782         https://bugs.webkit.org/show_bug.cgi?id=74689
783
784         * Scripts/webkitdirs.pm:
785
786 2011-12-16  Kentaro Hara  <haraken@chromium.org>
787
788         [Refactoring] Remove all global variables from prepare-ChangeLog
789         https://bugs.webkit.org/show_bug.cgi?id=74681
790
791         Reviewed by Ryosuke Niwa.
792
793         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
794         manner. This bug is one of the incremental refactorings to remove all top-level
795         code and global variables from prepare-ChangeLog. In this patch,
796         we make the following global variables be used only through parameter passing.
797         This patch removes all global variables from prepare-ChangeLog.
798             - $mergeBase
799             - $gitCommit
800             - $gitIndex
801
802         * Scripts/prepare-ChangeLog:
803         (generateFunctionLists):
804         (changeLogNameFromArgs):
805         (changeLogEmailAddressFromArgs):
806         (generateNewChangeLogs):
807         (printDiff):
808         (diffFromToString):
809         (diffCommand):
810         (statusCommand):
811         (createPatchCommand):
812         (generateFileList):
813         (isConflictStatus):
814
815 2011-12-15  Philippe Normand  <pnormand@igalia.com>
816
817         [GTK] Rounding errors on 32-bit machines causes tests to fail
818         https://bugs.webkit.org/show_bug.cgi?id=72254
819
820         Initial patch by vanuan@gmail.com.
821         Reviewed by Martin Robinson.
822
823         * Scripts/webkitdirs.pm:
824         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
825         CXXFLAGS to autogen in an attempt to harmonize floating point
826         values between 32-bit and 64-bit architectures.
827
828 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
829
830         [GTK] Make distcheck fails during the install
831         https://bugs.webkit.org/show_bug.cgi?id=74274
832
833         No review, since this is a build fix.
834
835         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
836         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
837         always runs. This means that the gtkdoc step was always running when make was
838         invoked. Generating gtkdoc during 'make install' was triggering a race condition
839         with the library file. Later we can fix generate-forwarding-headers and unbreak
840         'make docs,' but this bandaid is sufficient to let us release.
841
842 2011-12-15  Eric Seidel  <eric@webkit.org>
843
844         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
845         https://bugs.webkit.org/show_bug.cgi?id=74650
846
847         Reviewed by Adam Barth.
848
849         * Scripts/webkitpy/common/system/platforminfo.py:
850         (PlatformInfo._compute_bytes_from_vm_stat_output):
851         * Scripts/webkitpy/layout_tests/port/base.py:
852         (Port.default_child_processes):
853         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
854         (PortTest.test_default_child_processes):
855
856 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
857
858         bencher script should support remote benchmarking on platforms that don't have ruby
859         https://bugs.webkit.org/show_bug.cgi?id=74659
860
861         Rubber-stamped by Sam Weinig.
862         
863         Added the ability to have bencher generate a benchmarking playload that consists of
864         copies of all of the benchmarks, optionally copies of all of the frameworks and
865         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
866         order, which then spits out a raw results file that bencher can parse.
867         
868         In normal operating mode, you never see this, as it just generates the payload and
869         script internally, runs it, parses the results, and spits them out.
870         
871         The --remote mode has been changed to use this style, so any remote host that has
872         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
873         a sh-compatible shell can be used for remote benchmarking.
874         
875         The feature to include VMs in the benchmarking payload is by default only activated
876         when using --remote, but it can also be activated when doing local benchmarking; the
877         benefit is that you remove any pathname-related performance pathologies. All VMs
878         become equal because they are all located in
879         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
880         (usually 0 or 1).
881         
882         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
883         through DumpRenderTree. This is only a bit slower than running in jsc.
884
885         * Scripts/bencher:
886
887 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
888
889         webkitpy: clean up TestPort to (mostly) not create a new filesystem
890         https://bugs.webkit.org/show_bug.cgi?id=74556
891
892         This change modifies the TestPort to be ready to add tests to an
893         existing filesystem instead of creating a new filesystem; we
894         leave unit_test_filesystem() in for now for compatibility.
895
896         * Scripts/webkitpy/common/host_mock.py:
897         (MockHost.__init__):
898           - call add_unit_tests_to_mock_filesystem by default to make
899             the MockHost more generally useful for layout_test unit tests.
900         * Scripts/webkitpy/layout_tests/port/test.py:
901         (TestInstance.__init__):
902         (add_unit_tests_to_mock_filesystem):
903         (add_file):
904         (unit_test_filesystem):
905         (TestPort.__init__):
906         (TestPort._set_default_overriding_none):
907
908 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
909
910         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
911         https://bugs.webkit.org/show_bug.cgi?id=74551
912
913         This is some minor cleanup prior to making all of the host/port
914         changes described in bug 74138.
915
916         * Scripts/webkitpy/common/host_mock.py:
917         (MockHost.__init__):
918           - make sure the scm object is initialized with the same mock
919             executive and filesystem objects.
920
921         * Scripts/webkitpy/common/system/filesystem_mock.py:
922         (MockFileSystem.clear_written_files):
923           - add a routine that will be useful in testing.
924         (MockFileSystem.maybe_make_directory):
925         (MockFileSystem.write_binary_file):
926           - fix bugs to make sure directories are created properly.
927         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
928         (_Process.run):
929           - add clarifying comments.
930         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
931         (MockDRTPort.__init__):
932         (MockDRT.__init__):
933           - add clarifying comments.
934
935 2011-12-15  Anders Carlsson  <andersca@apple.com>
936
937         Regression (r102866): Navigating away from or closing a page with a plugin crashes
938         https://bugs.webkit.org/show_bug.cgi?id=74655
939
940         Reviewed by Sam Weinig.
941
942         Add a bunch of tests.
943
944         * TestWebKitAPI/Tests/WTF/Functional.cpp:
945
946 2011-12-15  Stephanie Lewis  <slewis@apple.com>
947
948         https://bugs.webkit.org/show_bug.cgi?id=74469
949         Escape paths to svn commands so our tools can handle filenames with @ symbols.
950
951         Reviewed by Adam Roben.
952
953         * Scripts/VCSUtils.pm:
954         (scmMoveOrRenameFile):
955         (scmAddExecutableBit):
956         (scmRemoveExecutableBit):
957         (determineSVNRoot):
958         (svnRevisionForDirectory):
959         (pathRelativeToSVNRepositoryRootForPath):
960         (svnStatus):
961         (escapeSubversionPath):
962         * Scripts/parse-malloc-history:
963         (main):
964         * Scripts/prepare-ChangeLog:
965         (diffCommand):
966         (statusCommand):
967         (findOriginalFileFromSvn):
968         (determinePropertyChanges):
969         * Scripts/resolve-ChangeLogs:
970         (conflictFiles):
971         (resolveConflict):
972         (showStatus):
973         * Scripts/svn-apply:
974         (patch):
975         (scmCopy):
976         (scmAdd):
977         (scmRemove):
978         * Scripts/svn-create-patch:
979         (findBaseUrl):
980         (findMimeType):
981         (findSourceFileAndRevision):
982         (generateDiff):
983         (generateFileList):
984         (manufacturePatchForAdditionWithHistory):
985         * Scripts/svn-unapply:
986         (patch):
987         (revertDirectories):
988
989 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
990
991         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
992         https://bugs.webkit.org/show_bug.cgi?id=74617
993
994         Reviewed by Kenneth Rohde Christiansen.
995
996         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
997         for viewport info button, adjusted height and added rounded corners.
998
999 2011-12-15  Andy Estes  <aestes@apple.com>
1000
1001         TestFailures: store the name of the buildbot results directory in a property
1002         https://bugs.webkit.org/show_bug.cgi?id=74663
1003
1004         Reviewed by Adam Barth.
1005         
1006         Store the name of the results directory as a property on Buildbot's
1007         prototype. This allows subclasses of Buildbot to customize the results
1008         directory.
1009
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
1011         (Buildbot.prototype.resultsDirectoryURL):
1012
1013 2011-12-15  Tony Chang  <tony@chromium.org>
1014
1015         [chromium] pass --delete_unversioned_trees to gclient on the bots
1016         https://bugs.webkit.org/show_bug.cgi?id=74565
1017
1018         Reviewed by Kenneth Russell.
1019
1020         It was temporarily removed in r102891 to keep the bots green.  Now
1021         that the bots have cycled, we can add it back.
1022
1023         * Scripts/update-webkit-chromium:
1024
1025 2011-12-15  Kentaro Hara  <haraken@chromium.org>
1026
1027         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
1028         https://bugs.webkit.org/show_bug.cgi?id=74497
1029
1030         Reviewed by Ryosuke Niwa.
1031
1032         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1033         manner. This bug is one of the incremental refactorings to remove all top-level
1034         code and global variables from prepare-ChangeLog. In this patch,
1035         we make the following global variables be used only through parameter passing.
1036             - $bugDescription
1037             - $bugNumber
1038             - $name
1039             - $emailAddress
1040             - $gitReviewer
1041             - $writeChangeLogs
1042
1043         * Scripts/prepare-ChangeLog:
1044         (fetchBugDescriptionFromURL):
1045         (generateNewChangeLogs):
1046         (reviewerAndDescriptionForGitCommit):
1047
1048 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
1049
1050         [EFL] Add a few more web database functions to ewk_settings.
1051         https://bugs.webkit.org/show_bug.cgi?id=72148
1052
1053         Reviewed by Antonio Gomes.
1054
1055         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1056         (LayoutTestController::clearAllDatabases):
1057         (LayoutTestController::setDatabaseQuota):
1058
1059 2011-12-15  Martin Kosiba  <mkosiba@google.com>
1060
1061         Fix find on web pages with -webkit-user-select: none for Chromium
1062         https://bugs.webkit.org/show_bug.cgi?id=72281
1063
1064         Reviewed by Ryosuke Niwa.
1065
1066         Provided a partial findString implementation. This doesn't support
1067         all of the FindOptions since they're not exposed via WebFindOptions.
1068
1069         * DumpRenderTree/chromium/LayoutTestController.cpp:
1070         (LayoutTestController::LayoutTestController):
1071         (LayoutTestController::findString):
1072         * DumpRenderTree/chromium/LayoutTestController.h:
1073
1074 2011-12-15  Kenneth Russell  <kbr@google.com>
1075
1076         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
1077         https://bugs.webkit.org/show_bug.cgi?id=74581
1078
1079         Reviewed by Darin Fisher.
1080
1081         * DumpRenderTree/chromium/LayoutTestController.cpp:
1082         (LayoutTestController::overridePreference):
1083         * DumpRenderTree/chromium/WebPreferences.cpp:
1084         (WebPreferences::reset):
1085         (WebPreferences::applyTo):
1086         * DumpRenderTree/chromium/WebPreferences.h:
1087
1088 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1089
1090         [Qt] Improve the look of the viewport info overlay
1091
1092         Reviewed by Tor Arne Vestbø.
1093
1094         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1095
1096 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
1097
1098         [Qt] Support requestAnimationFrame API
1099         https://bugs.webkit.org/show_bug.cgi?id=74528
1100
1101         Add build-option for requestAnimationFrame feature.
1102
1103         Reviewed by Kenneth Rohde Christiansen.
1104
1105         * qmake/mkspecs/features/features.prf:
1106
1107 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1108
1109         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1110
1111         Reviewed by Simon Hausmann.
1112
1113         * qmake/mkspecs/features/webcore.prf:
1114
1115 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
1116
1117         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
1118         https://bugs.webkit.org/show_bug.cgi?id=72893
1119
1120         Reviewed by Kenneth Rohde Christiansen.
1121
1122         This patch extends QQuickWebViewExperimental by a property named
1123         viewportInfo, which contains the viewport scalability and
1124         layout and contents size information. This property is exposed to
1125         QML through the experimental extension for QQuickWebView.
1126
1127         * MiniBrowser/qt/MiniBrowser.pro:
1128         * MiniBrowser/qt/MiniBrowser.qrc:
1129         * MiniBrowser/qt/icons/info.png: Added.
1130         * MiniBrowser/qt/qml/BrowserWindow.qml:
1131         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
1132
1133 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
1134
1135         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
1136         https://bugs.webkit.org/show_bug.cgi?id=74586
1137
1138         Reviewed by Hajime Morita.
1139
1140         No new tests. Covered by existing tests.
1141
1142         * DumpRenderTree/chromium/WebViewHost.cpp:
1143         (WebViewHost::requestCheckingOfText):
1144           Returns immediately if text is empty.
1145
1146 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
1147
1148         [Qt] QtWebKit fails to build on Mac OS X after r102776
1149         https://bugs.webkit.org/show_bug.cgi?id=74593
1150
1151         Reviewed by Simon Hausmann.
1152
1153         CONFIG =+ link_pkgconfig is needed such that the correct parameters
1154         are passed to the compiler.
1155
1156         * DumpRenderTree/qt/DumpRenderTree.pro:
1157
1158 2011-12-14  Tony Chang  <tony@chromium.org>
1159
1160         [chromium] Remove redundant third_party entries from chromium DEPS
1161         https://bugs.webkit.org/show_bug.cgi?id=74472
1162
1163         Reviewed by Kenneth Russell.
1164
1165         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
1166
1167 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1168
1169         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
1170         VCSUtils::isGit() and VCSUtils::isSVN().
1171         https://bugs.webkit.org/show_bug.cgi?id=74485
1172
1173         Reviewed by David Kilzer.
1174
1175         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1176         manner. This bug is one of the incremental refactorings to remove all top-level
1177         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
1178         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
1179         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
1180         just by looking at the current working directory.
1181
1182         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
1183         (diffFromToString):
1184         (diffCommand):
1185         (statusCommand):
1186         (createPatchCommand):
1187         (diffHeaderFormat):
1188         (generateFileList):
1189         (isAddedStatus):
1190         (isConflictStatus):
1191         (statusDescription):
1192         (extractLineRange):
1193
1194 2011-12-14  Sam Weinig  <weinig@apple.com>
1195
1196         Remove whitespace from InheritedPropertySheets attributes in
1197         vsprops files to appease the Visual Studio project migrator.
1198
1199         Reviewed by Adam Roben.
1200
1201         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
1202         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
1203         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
1204         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1205         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1206         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1207         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
1208         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
1209         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
1210         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1211         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1212         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1213         * DumpRenderTree/win/ImageDiffDebug.vsprops:
1214         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
1215         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
1216         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1217         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1218         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1219         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
1220         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
1221         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
1222         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1223         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1224         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1225         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1226         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1227         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
1228         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
1229         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
1230         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1231         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1232         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1233         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
1234         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
1235         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
1236         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1237         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1238         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1239         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
1240         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
1241         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
1242         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1243         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1244         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1245         * WinLauncher/WinLauncherDebug.vsprops:
1246         * WinLauncher/WinLauncherDebugAll.vsprops:
1247         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
1248         * WinLauncher/WinLauncherProduction.vsprops:
1249         * WinLauncher/WinLauncherRelease.vsprops:
1250         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1251         * record-memory-win/record-memory-winDebug.vsprops:
1252         * record-memory-win/record-memory-winDebugAll.vsprops:
1253         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
1254         * record-memory-win/record-memory-winProduction.vsprops:
1255         * record-memory-win/record-memory-winRelease.vsprops:
1256         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1257
1258 2011-12-14  Anders Carlsson  <andersca@apple.com>
1259
1260         Windows build fix.
1261
1262         Move CHECKs out of the destructor.
1263
1264         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1265         (TestWebKitAPI::B::~B):
1266         (TestWebKitAPI::TEST):
1267
1268 2011-12-14  Anders Carlsson  <andersca@apple.com>
1269
1270         binding a member function should ref/deref the object pointer if needed
1271         https://bugs.webkit.org/show_bug.cgi?id=74552
1272
1273         Reviewed by Sam Weinig.
1274
1275         Add new tests.
1276
1277         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1278         (TestWebKitAPI::B::B):
1279         (TestWebKitAPI::B::~B):
1280         (TestWebKitAPI::B::ref):
1281         (TestWebKitAPI::B::deref):
1282         (TestWebKitAPI::B::f):
1283         (TestWebKitAPI::B::g):
1284         (TestWebKitAPI::TEST):
1285
1286 2011-12-14  Hajime Morrita  <morrita@chromium.org>
1287
1288         JS_INLINE and WTF_INLINE should be visible from WebCore
1289         https://bugs.webkit.org/show_bug.cgi?id=73191
1290
1291         Reviewed by Kevin Ollivier.
1292
1293         Removed macro definitions which is now provided by Platform.h
1294
1295         * DumpRenderTree/chromium/config.h:
1296         * DumpRenderTree/config.h:
1297         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
1298         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
1299         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
1300         * TestWebKitAPI/config.h:
1301         * WebKitTestRunner/config.h:
1302
1303 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1304
1305         Unreviewed, rolling out r102761.
1306         http://trac.webkit.org/changeset/102761
1307         https://bugs.webkit.org/show_bug.cgi?id=74485
1308
1309         we came up with a better fix than this (see comments in bug
1310         74485)
1311
1312         * Scripts/prepare-ChangeLog:
1313         (generateFunctionLists):
1314         (printDiff):
1315         (diffCommand):
1316         (statusCommand):
1317         (createPatchCommand):
1318         (generateFileList):
1319         (isAddedStatus):
1320         (isConflictStatus):
1321         (statusDescription):
1322         (extractLineRange):
1323
1324 2011-12-14  Anders Carlsson  <andersca@apple.com>
1325
1326         Work around a bug in the MSVC2005 compiler
1327         https://bugs.webkit.org/show_bug.cgi?id=74550
1328
1329         Reviewed by Sam Weinig.
1330
1331         Re-enable tests.
1332
1333         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1334
1335 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1336
1337         [Qt] Test fonts are not used with Qt5
1338         https://bugs.webkit.org/show_bug.cgi?id=72513
1339
1340         My last unreviewed buildfix for this crazy bug.
1341
1342         * qmake/mkspecs/features/features.prf:
1343
1344 2011-12-14  Anders Carlsson  <andersca@apple.com>
1345
1346         Another attempt at fixing the Windows build.
1347
1348         Disable all the tests until I can figure out what's going on here.
1349
1350         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1351
1352 2011-12-14  Anders Carlsson  <andersca@apple.com>
1353
1354         Fix the Windows build.
1355
1356         Disable some of the tests for now.
1357
1358         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1359
1360 2011-12-14  Anders Carlsson  <andersca@apple.com>
1361
1362         bind should handle member functions
1363         https://bugs.webkit.org/show_bug.cgi?id=74529
1364
1365         Reviewed by Sam Weinig.
1366
1367         Add tests.
1368
1369         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1370         (TestWebKitAPI::A::A):
1371         (TestWebKitAPI::A::f):
1372         (TestWebKitAPI::A::addF):
1373         (TestWebKitAPI::TEST):
1374
1375 2011-12-14  Anders Carlsson  <andersca@apple.com>
1376
1377         Add unary and binary bind overloads
1378         https://bugs.webkit.org/show_bug.cgi?id=74524
1379
1380         Reviewed by Sam Weinig.
1381
1382         Add tests.
1383
1384         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1385         (TestWebKitAPI::TEST):
1386         (TestWebKitAPI::multiplyByTwo):
1387         (TestWebKitAPI::multiplyByOneAndAHalf):
1388         (TestWebKitAPI::multiply):
1389         (TestWebKitAPI::subtract):
1390
1391 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
1392
1393         [Qt] Test fonts are not used with Qt5
1394         https://bugs.webkit.org/show_bug.cgi?id=72513
1395
1396         MIPS and SH4 buildfix after r102776 and r102795.
1397
1398         Reviewed by Csaba Osztrogonác.
1399
1400         * qmake/mkspecs/features/features.prf:
1401
1402 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1403
1404         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
1405
1406         * qmake/mkspecs/features/features.prf:
1407
1408 2011-12-14  Andreas Kling  <kling@webkit.org>
1409
1410         Make my e-mail address a little more awesome.
1411
1412         * Scripts/webkitpy/common/config/committers.py:
1413
1414 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
1415
1416         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
1417
1418         * qmake/mkspecs/features/webcore.prf:
1419
1420 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
1421
1422         [Qt] Test fonts are not used with Qt5
1423         https://bugs.webkit.org/show_bug.cgi?id=72513
1424
1425         Reviewed by Simon Hausmann.
1426
1427         Don't depend on Q_WS_X11 anymore since it's not the Qt5
1428         way to detect the platform. Make the guards depend
1429         on our own configtest for fontconfig. For Qt4 we can still
1430         use the preassumption that we have it on Linux.
1431
1432         * DumpRenderTree/qt/DumpRenderTree.pro:
1433         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1434         (WebCore::DumpRenderTree::open):
1435         (WebCore::DumpRenderTree::initializeFonts):
1436         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1437         * DumpRenderTree/qt/main.cpp:
1438         (main): Additionally remove a nonsense piece of code that was
1439         trying to reset the font settings - which is not necessary -
1440         after we have already returned from main.
1441         * WebKitTestRunner/InjectedBundle/Target.pri:
1442         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1443         (WTR::activateFonts):
1444         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
1445         from WTR. It is not needed. We set up the fonts via the injected bundle.
1446         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
1447         (main):
1448         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
1449         * qmake/mkspecs/features/features.prf:
1450         * qmake/sync.profile:
1451
1452 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1453
1454         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1455
1456         Followup to r102679
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=74413
1459
1460         Reviewed by Simon Hausmann.
1461
1462         * qmake/mkspecs/features/webcore.prf:
1463
1464 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
1465
1466         [Qt] Mobile theme could use a little refresh
1467         https://bugs.webkit.org/show_bug.cgi?id=74293
1468
1469         Have MiniBrowser use the mobile theme when not
1470         passed --desktop.
1471
1472         Reviewed by Kenneth Rohde Christiansen.
1473
1474         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1475         (MiniBrowserApplication::handleUserOptions):
1476
1477 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
1478
1479         [Qt] [Gardening] Remove qt-4.7 layout tests dir
1480         https://bugs.webkit.org/show_bug.cgi?id=74426
1481
1482         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
1483         on the tree.
1484
1485         Reviewed by Csaba Osztrogonác.
1486
1487         * Scripts/webkitpy/layout_tests/port/qt.py:
1488         (QtPort.qt_version):
1489         (QtPort.baseline_search_path):
1490         (QtPort._skipped_file_search_paths):
1491         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1492         (QtPortTest._assert_search_path):
1493
1494 2011-12-14  Kentaro Hara  <haraken@chromium.org>
1495
1496         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
1497         through parameter passing
1498         https://bugs.webkit.org/show_bug.cgi?id=74485
1499
1500         Reviewed by Ryosuke Niwa.
1501
1502         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1503         manner. This bug is one of the incremental refactorings to remove all top-level
1504         code and global variables from prepare-ChangeLog. In this patch,
1505         we make the following global variables be used only through parameter passing.
1506             - $isGit
1507             - $isSVN
1508
1509         * Scripts/prepare-ChangeLog:
1510         (generateFunctionLists):
1511         (printDiff):
1512         (diffFromToString):
1513         (diffCommand):
1514         (statusCommand):
1515         (createPatchCommand):
1516         (diffHeaderFormat):
1517         (generateFileList):
1518         (isAddedStatus):
1519         (isConflictStatus):
1520         (statusDescription):
1521         (extractLineRange):
1522
1523 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
1524
1525         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
1526         https://bugs.webkit.org/show_bug.cgi?id=74417
1527
1528         Reviewed by Simon Hausmann.
1529
1530         Based on original patch by Kenneth Christiansen.
1531
1532         Already covered by current tests.
1533
1534         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1535         (WebCore::DumpRenderTree::DumpRenderTree):
1536         (WebCore::DumpRenderTree::~DumpRenderTree):
1537         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1538         (LayoutTestController::setMockDeviceOrientation):
1539
1540 2011-12-03  Philippe Normand  <pnormand@igalia.com>
1541
1542         [GTK] Bad text rendering since r101343
1543         https://bugs.webkit.org/show_bug.cgi?id=73744
1544
1545         Reviewed by Martin Robinson.
1546
1547         Turn cairo hint metrics off for better font metrics reporting in
1548         the tests. This is especially important for SVG.
1549
1550         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1551         (initializeGtkFontSettings):
1552         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1553         (WTR::initializeGtkSettings):
1554
1555 2011-12-13  Kentaro Hara  <haraken@chromium.org>
1556
1557         [Refactoring] Remove several global variables from prepare-ChangeLog
1558         https://bugs.webkit.org/show_bug.cgi?id=74389
1559
1560         Reviewed by David Kilzer.
1561
1562         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1563         manner. This bug is one of the incremental refactorings to remove all top-level
1564         code and global variables from prepare-ChangeLog. In this patch,
1565         we make the following global variables being used only through parameter passing.
1566             - %paths
1567             - $changedFiles
1568             - $conflictFiles
1569             - $functionLists
1570             - $bugURL
1571
1572         * Scripts/prepare-ChangeLog:
1573         (findChangeLogs):
1574         (generateNewChangeLogs):
1575         (processPaths):
1576         (generateFileList):
1577         (firstDirectoryOrCwd):
1578
1579 2011-12-13  Anders Carlsson  <andersca@apple.com>
1580
1581         Add a very bare-bones implementation of bind and Function to WTF
1582         https://bugs.webkit.org/show_bug.cgi?id=74462
1583
1584         Reviewed by Sam Weinig.
1585
1586         Add basic tests for WTF::Function and WTF::bind.
1587
1588         * TestWebKitAPI/TestWebKitAPI.gypi:
1589         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1590         * TestWebKitAPI/Tests/Functional.cpp: Added.
1591         (TestWebKitAPI::returnFortyTwo):
1592         (TestWebKitAPI::TEST):
1593         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1594
1595 2011-12-13  Robin Dunn  <robin@alldunn.com>
1596
1597         [wx] Add a URL argument to wxWebView constructor.
1598         https://bugs.webkit.org/show_bug.cgi?id=74316
1599         
1600         Reviewed by Kevin Ollivier.
1601
1602         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1603         (MyApp::OnInit):
1604         * wx/browser/browser.cpp:
1605         (MyApp::OnInit):
1606
1607 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1608
1609         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
1610         https://bugs.webkit.org/show_bug.cgi?id=74430
1611
1612         Reviewed by David Levin.
1613
1614         * Scripts/webkitpy/common/config/watchlist:
1615
1616 2011-12-13  Peter Beverloo  <peter@chromium.org>
1617
1618         [Chromium] Pull in FreeType and decrease check-out complexity for Android
1619         https://bugs.webkit.org/show_bug.cgi?id=74401
1620
1621         Decrease the check-out complexity by removing the need to first run
1622         "update-webkit-chromium --chromium" prior to running it with
1623         "--chromium-android", which was caused by an unversioned third_party/
1624         directory being created. This moves the Android NDK to Source/WebKit/
1625         chromium/, coming from third_party/ in that directory.
1626
1627         Reviewed by Adam Barth.
1628
1629         * Scripts/update-webkit-chromium:
1630         * Scripts/webkitdirs.pm:
1631         (buildChromiumMakefile):
1632
1633 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
1634
1635         build-jsc passing incorrect args to buildGtkProject
1636         https://bugs.webkit.org/show_bug.cgi?id=74308
1637
1638         Reviewed by Gustavo Noronha Silva.
1639
1640         * Scripts/build-webkit: Instead of invoking buildGtkProject with
1641         another argument about webkit2, unshift a --disable-webkit2
1642         argument onto the buildArgs.
1643         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
1644         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
1645         and build-jsc are run one after the other.
1646
1647 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1648
1649         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
1650         https://bugs.webkit.org/show_bug.cgi?id=74413
1651
1652         Unreviewed buildfix.
1653
1654         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
1655
1656 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
1657
1658         [Qt] Unreviewed speculativ debug buildfix after r102679.
1659
1660         * QtTestBrowser/QtTestBrowser.pro:
1661         * QtTestBrowser/main.cpp:
1662
1663 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1664
1665         [Qt] Get rid of layering violations in includes
1666
1667         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
1668         in the webcore.prf, but rather in each target that specificly needs
1669         headers in these location. We used to include them directly in webcore
1670         since we had layering violations between WebCore and WebKit, but now
1671         that they are gone there's no reason to do that.
1672
1673         Reviewed by Simon Hausmann.
1674
1675         * DumpRenderTree/qt/DumpRenderTree.pro:
1676         * QtTestBrowser/launcherwindow.h:
1677         * WebKitTestRunner/InjectedBundle/Target.pri:
1678         * qmake/mkspecs/features/webcore.prf:
1679         * qmake/mkspecs/features/webkit2.prf:
1680
1681 2011-12-13  János Badics  <dicska@gmail.com>
1682
1683         [NRWT] It crashes intermittently when there are WebProcess crashes
1684         https://bugs.webkit.org/show_bug.cgi?id=73451
1685
1686         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
1687
1688         Reviewed by Kenneth Rohde Christiansen.
1689
1690         * Scripts/webkitpy/layout_tests/port/server_process.py:
1691         (ServerProcess._check_for_crash):
1692
1693 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
1694
1695         Unreviewed. Fix GTK+ API docs build.
1696
1697         * gtk/generate-gtkdoc:
1698         (get_webkit2_options): Ignore WebKitUIClient since it's private
1699         API.
1700
1701 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
1702
1703         Reviewed, removed one of my email addresses to use the apprpriate one.
1704
1705         * Scripts/webkitpy/common/config/committers.py:
1706
1707 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
1708
1709         [Qt] Fix skip list search path and expected file search path in ORWT
1710         https://bugs.webkit.org/show_bug.cgi?id=74281
1711
1712         Expected file search path fixed.
1713
1714         Print all used skipped list and expected search path in verbose mode similar to NRWT.
1715
1716         Reviewed by Csaba Osztrogonác.
1717
1718         * Scripts/old-run-webkit-tests:
1719         (buildPlatformResultHierarchy):
1720         (buildPlatformTestHierarchy):
1721         (readSkippedFiles):
1722
1723 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
1724
1725         [Qt] Missing layoutTestController.dumpWillCacheResponse
1726         https://bugs.webkit.org/show_bug.cgi?id=74287
1727
1728         Reviewed by Csaba Osztrogonác.
1729
1730         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1731         (LayoutTestController::reset):
1732         (LayoutTestController::dumpWillCacheResponse):
1733         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1734
1735 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
1736
1737         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
1738         https://bugs.webkit.org/show_bug.cgi?id=73771
1739
1740         Reviewed by Gustavo Noronha Silva.
1741
1742         When using a fallback font during testing, always use DejaVu Sans. This prevents
1743         falling back to DejaVu Serif on some systems.
1744
1745         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
1746
1747 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
1748
1749         Add myself as a committer
1750
1751         * Scripts/webkitpy/common/config/committers.py:
1752
1753 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1754
1755         [Qt] [WK2] Support customizing popup menus with QML
1756         https://bugs.webkit.org/show_bug.cgi?id=73560
1757
1758         Reviewed by Tor Arne Vestbø.
1759
1760         Add an Item Selector to our WebView using the experimental API.
1761
1762         * MiniBrowser/qt/MiniBrowser.pro:
1763         * MiniBrowser/qt/MiniBrowser.qrc:
1764         * MiniBrowser/qt/qml/BrowserWindow.qml:
1765         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
1766
1767 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
1768
1769         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
1770         https://bugs.webkit.org/show_bug.cgi?id=74283
1771
1772         Reviewed by Simon Hausmann.
1773
1774         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1775         (MiniBrowserApplication::sendTouchEvent):
1776
1777 2011-12-12  Kentaro Hara  <haraken@chromium.org>
1778
1779         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
1780         to show ChangeLogs diff and open ChangeLogs in an editor
1781         https://bugs.webkit.org/show_bug.cgi?id=74266
1782
1783         Reviewed by Ryosuke Niwa.
1784
1785         We are planning to write unit-tests for prepare-ChangeLog
1786         in a run-leaks_unittest manner. This patch is one of the incremental
1787         refactorings to remove all top-level code and global variables from
1788         prepare-ChangeLog.
1789
1790         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
1791         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
1792         Renamed @changed_files to @changedFiles.
1793         Renamed %conflict_files to %conflictFiles.
1794         (generateFunctionLists):
1795         (printDiff):
1796         (openChangeLogs):
1797
1798 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1799
1800         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
1801         https://bugs.webkit.org/show_bug.cgi?id=74257
1802
1803         Reviewed by Ryosuke Niwa.
1804
1805         We are planning to write unit-tests for prepare-ChangeLog
1806         in a run-leaks_unittest/ manner. This patch is one of the incremental
1807         refactorings to remove all top-level code and global variables from
1808         prepare-ChangeLog.
1809
1810         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
1811         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
1812         into resolveConflictedChangeLogs().
1813         (getLatestChangeLogs):
1814         (resolveConflictedChangeLogs):
1815
1816 2011-12-11  Kentaro Hara  <haraken@chromium.org>
1817
1818         [Refactoring] Move top-level code to generate a new ChangeLog into a method
1819         https://bugs.webkit.org/show_bug.cgi?id=74253
1820
1821         Reviewed by David Kilzer.
1822
1823         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
1824         which requires to remove top-level code and global variables. This patch is one of
1825         the incremental refactorings for that.
1826
1827         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
1828         (generateFunctionLists):
1829         (findChangeLogs):
1830         (generateNewChangeLogs):
1831         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
1832
1833 2011-12-10  Kentaro Hara  <haraken@chromium.org>
1834
1835         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
1836         https://bugs.webkit.org/show_bug.cgi?id=74175
1837
1838         Reviewed by Ryosuke Niwa.
1839
1840         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1841         This requires to remove top-level code. This patch is one of the incremental refactorings
1842         for that.
1843
1844         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
1845         (findChangeLogs):
1846
1847 2011-12-10  Andreas Kling  <kling@webkit.org>
1848
1849         Add my Apple e-mail to committers.py.
1850
1851         * Scripts/webkitpy/common/config/committers.py:
1852
1853 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1854
1855         chromium win build: revert build_webkit_exes_from_webkit_gyp change
1856         https://bugs.webkit.org/show_bug.cgi?id=74225
1857
1858         This change sets build_webkit_exes_from_webkit_gyp back to 1;
1859         the "All.gyp" solution doesn't work on windows.
1860
1861         * Scripts/webkitdirs.pm:
1862         (buildChromium):
1863
1864 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
1865
1866         [Qt] Click's count is limited to three continuous clicks.
1867         https://bugs.webkit.org/show_bug.cgi?id=45666
1868
1869         Reviewed by Kenneth Rohde Christiansen.
1870
1871         Update m_time at every call to leapForward, so double clicks
1872         event are correctly sent by EventSender.
1873
1874         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1875         (WTR::EventSenderProxy::updateClickCountForButton):
1876         (WTR::EventSenderProxy::leapForward):
1877
1878 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1879
1880         [Refactoring] Reduce top-level code in prepare-ChangeLog
1881         https://bugs.webkit.org/show_bug.cgi?id=74172
1882
1883         Reviewed by Ryosuke Niwa.
1884
1885         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1886         This requires to remove top-level code. This patch is one of the incremental refactorings
1887         for that.
1888
1889         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
1890         (generateFunctionLists):
1891
1892 2011-12-09  Sam Weinig  <sam@webkit.org>
1893
1894         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
1895         https://bugs.webkit.org/show_bug.cgi?id=74218
1896
1897         Reviewed by Anders Carlsson.
1898
1899         Add a test of the WKConnectionRef API.
1900
1901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1902         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
1903         (TestWebKitAPI::didCreateConnection):
1904         (TestWebKitAPI::connectionDidReceiveMessage):
1905         (TestWebKitAPI::connectionDidClose):
1906         (TestWebKitAPI::TEST):
1907         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
1908         (TestWebKitAPI::connectionDidReceiveMessage):
1909         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
1910         (TestWebKitAPI::WKConnectionTest::initialize):
1911
1912 2011-12-09  David Levin  <levin@chromium.org>
1913
1914         Hash* iterators should allow comparison between const and const versions.
1915         https://bugs.webkit.org/show_bug.cgi?id=73370
1916
1917         Reviewed by Darin Adler.
1918
1919         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
1920         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
1921         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
1922         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
1923         (TestWebKitAPI::TEST): Add a test for the new functionality.
1924
1925 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
1926
1927         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
1928         https://bugs.webkit.org/show_bug.cgi?id=74212
1929
1930         Reviewed by Tony Chang.
1931
1932         The change introduced in r102201 to split the executables out of
1933         WebKit.gyp apparently doesn't work right on Windows, since
1934         WebKit.gyp and Tools.gyp refer to dependent projects by
1935         different relative paths (it appears gyp doesn't normalize the
1936         paths). This change moves Tools.gyp to be in the same directory
1937         as WebKit.gyp (and All.gyp), which should fix this and
1938         conveniently will also solve the problem of how to add Tools.gyp
1939         to the chromium DEPS file.
1940
1941         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
1942
1943 2011-12-09  Kentaro Hara  <haraken@chromium.org>
1944
1945         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
1946         https://bugs.webkit.org/show_bug.cgi?id=74173
1947
1948         Reviewed by Ryosuke Niwa.
1949
1950         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
1951         This requires to remove top-level code. This patch is one of the incremental refactorings
1952         for that.
1953
1954         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
1955         (fetchBugDescriptionFromURL):
1956
1957 2011-12-09  Tony Chang  <tony@chromium.org>
1958
1959         Switch the chromium mac bots to using skia test results
1960         https://bugs.webkit.org/show_bug.cgi?id=74201
1961
1962         Reviewed by Ryosuke Niwa.
1963
1964         This is reverting http://trac.webkit.org/changeset/97781 and changing
1965         the name in master.cfg to no longer have cg in the name.
1966
1967         * BuildSlaveSupport/build.webkit.org-config/config.json:
1968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1969         (appendCustomBuildFlags):
1970         (RunWebKitTests.start):
1971
1972 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1973
1974         [Qt] Remove a wrongly placed ASSERT.
1975
1976         Reviewed by Tor Arne Vestbø.
1977
1978         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1979         (MiniBrowserApplication::notify):
1980
1981 2011-12-09  Cary Clark  <caryclark@google.com>
1982
1983         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
1984         https://bugs.webkit.org/show_bug.cgi?id=74118
1985
1986         Reviewed by Adam Barth.
1987
1988         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1989         (get):
1990         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1991         (ChromiumMacPort.__init__):
1992         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1993         (ChromiumMacPortTest.test_versions):
1994         (ChromiumMacPortTest.test_graphics_type):
1995
1996 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1997
1998         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
1999
2000         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
2001         this failed when moving files in the source tree, as the .d file would contain
2002         stale dependencies on the old source file location. By keeping the object files
2003         (and hence the depdendency files) in a proper tree structure inside the objects
2004         directory we can prevent this failure.
2005
2006         A side benefit is that we can also have objects with the same name inside the
2007         same project.
2008
2009         Reviewed by Simon Hausmann.
2010
2011         * qmake/mkspecs/features/unix/default_pre.prf:
2012
2013 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2014
2015         Unreviewed. Update unit test after r102412.
2016
2017         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2018         (IRCCommandTest.test_whois):
2019
2020 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2021
2022         REGRESSION(r102105): run-bindings-tests should output full diff results
2023         https://bugs.webkit.org/show_bug.cgi?id=74166
2024
2025         Reviewed by Adam Barth.
2026
2027         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
2028         run-bindings-tests should output full diff results.
2029
2030         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
2031         (BindingsTests.generate_from_idl):
2032         (BindingsTests.generate_supplemental_dependency):
2033         (BindingsTests.detect_changes):
2034
2035 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
2036
2037         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
2038         https://bugs.webkit.org/show_bug.cgi?id=73990
2039
2040         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
2041
2042         Fix QtQuick includes after move from QtDeclarative to QtQuick.
2043
2044         * MiniBrowser/qt/BrowserWindow.h:
2045         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2046
2047 2011-12-08  Adam Klein  <adamk@chromium.org>
2048
2049         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
2050         https://bugs.webkit.org/show_bug.cgi?id=73492
2051
2052         Reviewed by Adam Barth.
2053
2054         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
2055         keypress event without any script on the stack.
2056
2057         * DumpRenderTree/chromium/EventSender.cpp:
2058         (EventSender::EventSender):
2059         (EventSender::keyDown):
2060         (KeyDownTask::KeyDownTask):
2061         (KeyDownTask::runIfValid):
2062         (EventSender::scheduleAsynchronousKeyDown):
2063         * DumpRenderTree/chromium/EventSender.h:
2064
2065 2011-12-08  Hayato Ito  <hayato@chromium.org>
2066
2067         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
2068         https://bugs.webkit.org/show_bug.cgi?id=73980
2069
2070         Reviewed by Tony Chang.
2071
2072         * gdb/webkit.py:
2073         (guess_string_length):
2074         (ustring_to_string):
2075         (lstring_to_string):
2076         (LCharStringPrinter):
2077         (LCharStringPrinter.to_string):
2078         (WTFStringImplPrinter.get_length):
2079         (WTFStringImplPrinter.to_string):
2080         (WTFStringImplPrinter.is_8bit):
2081         (WTFStringPrinter.stringimpl_ptr):
2082         (WTFStringPrinter.get_length):
2083         (WTFStringPrinter.to_string):
2084         (add_pretty_printers.lookup_function):
2085
2086 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
2087
2088         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
2089         https://bugs.webkit.org/show_bug.cgi?id=73916
2090
2091         Reviewed by Kent Tamura.
2092
2093         * qmake/mkspecs/features/features.prf:
2094
2095 2011-12-08  Adrienne Walker  <enne@google.com>
2096
2097         Unreviewed contributor additions to committers.py.
2098
2099         * Scripts/webkitpy/common/config/committers.py:
2100
2101 2011-12-08  David Reveman  <reveman@chromium.org>
2102
2103         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
2104         https://bugs.webkit.org/show_bug.cgi?id=74017
2105
2106         Reviewed by James Robinson.
2107         
2108         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
2109
2110         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2111         (main):
2112         * DumpRenderTree/chromium/TestShell.cpp:
2113         (TestShell::TestShell):
2114         (TestShell::resetWebSettings):
2115         * DumpRenderTree/chromium/TestShell.h:
2116         (TestShell::setAcceleratedPaintingEnabled):
2117         (TestShell::setPerTilePaintingEnabled):
2118         * DumpRenderTree/chromium/WebPreferences.cpp:
2119         (WebPreferences::reset):
2120         (WebPreferences::applyTo):
2121         * DumpRenderTree/chromium/WebPreferences.h:
2122         * Scripts/webkitpy/layout_tests/port/chromium.py:
2123         (ChromiumDriver._wrapper_options):
2124         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2125         (parse_args):
2126
2127 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2128
2129         create a "SystemHost" object for webkitpy to slim down the Host object
2130         https://bugs.webkit.org/show_bug.cgi?id=72680
2131
2132         Reviewed by Eric Siedel.
2133
2134         This creates a SystemHost object that other objects that should
2135         only have dependencies on functionality in webkitpy.common.system
2136         can use; this will allow them to not require a full Host.
2137
2138         * Scripts/webkitpy/common/host.py:
2139         * Scripts/webkitpy/common/host_mock.py:
2140         * Scripts/webkitpy/common/system/systemhost.py: Added.
2141         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
2142
2143 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
2144
2145         AX: platform/mac/accessibility/search-with-frames.html crashes
2146         https://bugs.webkit.org/show_bug.cgi?id=74093
2147
2148         Reviewed by Darin Adler.
2149
2150         Take care of the case when an incoming element is null.
2151
2152         * DumpRenderTree/AccessibilityUIElement.cpp:
2153         (uiElementForSearchPredicateCallback):
2154         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2155         (AccessibilityUIElement::uiElementForSearchPredicate):
2156         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2157         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2158
2159 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
2160
2161         [Qt] Visualize mock point ID's in the MiniBrowser
2162         https://bugs.webkit.org/show_bug.cgi?id=74098
2163
2164         Reviewed by Tor Arne Vestbø.
2165
2166         * MiniBrowser/qt/BrowserWindow.cpp:
2167         (BrowserWindow::updateVisualMockTouchPoints):
2168         * MiniBrowser/qt/qml/MockTouchPoint.qml:
2169
2170 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
2171
2172         Accessibility: AccessibilityController should support listening to notifications on all elements.
2173         https://bugs.webkit.org/show_bug.cgi?id=72866
2174
2175         Adds addNotificationListener and removeNotificationListener methods
2176         to AccessibilityController, to listen to notifications on any element
2177         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
2178         implementations are all contained in this change.
2179
2180         On Mac, refactors AccessibilityNotificationHandler into its own
2181         source file that can be used by both AccessibilityController and
2182         AccessibilityUIElement. (Both DRT and WKTR.)
2183
2184         Reviewed by Chris Fleizach.
2185
2186         * DumpRenderTree/AccessibilityController.cpp:
2187         (addNotificationListenerCallback):
2188         (removeNotificationListenerCallback):
2189         (AccessibilityController::getJSClass):
2190         * DumpRenderTree/AccessibilityController.h:
2191         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2192         * DumpRenderTree/chromium/AccessibilityController.cpp:
2193         (AccessibilityController::AccessibilityController):
2194         (AccessibilityController::notificationReceived):
2195         (AccessibilityController::addNotificationListenerCallback):
2196         (AccessibilityController::removeNotificationListenerCallback):
2197         * DumpRenderTree/chromium/AccessibilityController.h:
2198         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2199         (AccessibilityController::addNotificationListener):
2200         (AccessibilityController::removeNotificationListener):
2201         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2202         (AccessibilityController::~AccessibilityController):
2203         (AccessibilityController::addNotificationListener):
2204         (AccessibilityController::removeNotificationListener):
2205         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
2206         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
2207         (-[NSString createJSStringRef]):
2208         (-[AccessibilityNotificationHandler init]):
2209         (-[AccessibilityNotificationHandler setPlatformElement:]):
2210         (-[AccessibilityNotificationHandler dealloc]):
2211         (-[AccessibilityNotificationHandler setCallback:]):
2212         (-[AccessibilityNotificationHandler startObserving]):
2213         (-[AccessibilityNotificationHandler _notificationReceived:]):
2214         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2215         (AccessibilityUIElement::addNotificationListener):
2216         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2217         (notificationListenerProc):
2218         (AccessibilityController::addNotificationListener):
2219         (AccessibilityController::removeNotificationListener):
2220         (AccessibilityController::winNotificationReceived):
2221         (AccessibilityController::winAddNotificationListener):
2222         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2223         (AccessibilityUIElement::addNotificationListener):
2224         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2225         (WTR::AccessibilityController::addNotificationListener):
2226         (WTR::AccessibilityController::removeNotificationListener):
2227         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2228         (WTR::AccessibilityController::logAccessibilityEvents):
2229         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
2230         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
2231         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
2232         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
2233         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2234         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
2235         (WTR::AccessibilityController::addNotificationListener):
2236         (WTR::AccessibilityController::removeNotificationListener):
2237         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
2238         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
2239         (-[NSString createJSStringRef]):
2240         (-[AccessibilityNotificationHandler init]):
2241         (-[AccessibilityNotificationHandler setPlatformElement:]):
2242         (-[AccessibilityNotificationHandler dealloc]):
2243         (-[AccessibilityNotificationHandler setCallback:]):
2244         (-[AccessibilityNotificationHandler startObserving]):
2245         (-[AccessibilityNotificationHandler _notificationReceived:]):
2246         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2247         (WTR::AccessibilityUIElement::AccessibilityUIElement):
2248         (WTR::AccessibilityUIElement::verticalScrollbar):
2249         (WTR::AccessibilityUIElement::addNotificationListener):
2250         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2251
2252 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
2253
2254         [Qt][WK2] Unreviewed buildfix after r102352.
2255
2256         * qmake/mkspecs/features/webkit2.prf:
2257
2258 2011-12-08  Adam Roben  <aroben@apple.com>
2259
2260         Make finding crash logs by PID work on Snow Leopard
2261
2262         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
2263         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
2264         read the first line of the crash log and pull the PID out of there.
2265
2266         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
2267         Snow Leopard
2268
2269         Reviewed by Darin Adler.
2270
2271         * Scripts/webkitpy/common/system/crashlogs.py:
2272         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
2273         name and PID for the log, rather than checking the Lion-only app_description extended
2274         attribute. We now also reject the log if the process name doesn't match what we expect.
2275
2276         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2277         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
2278         PID.
2279         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
2280         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
2281         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
2282         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
2283         read, files that actually contain a crash log for some other process, and files that are
2284         misformatted.
2285
2286         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
2287         unused.
2288
2289         * Scripts/webkitpy/common/system/filesystem_mock.py:
2290         (MockFileSystem.__init__): Removed xattr support, which is now unused.
2291         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
2292         ReadableTextFileObject. This function was completely broken before!
2293         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
2294         bugs like the above.
2295         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
2296         things like readline() and seek().
2297
2298         (ReadableTextFileObject.close):
2299         (ReadableTextFileObject.read):
2300         Added. We override the superclass implementation to account for using a StringIO object.
2301
2302         (ReadableTextFileObject.readline):
2303         (ReadableTextFileObject.seek):
2304         Added. These just call through to StringIO.
2305
2306         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2307         (MainTest.test_crash_log):
2308         (MainTest.test_web_process_crash_log):
2309         Changed to use make_mock_crash_report_darwin.
2310
2311 2011-12-06  Jon Lee  <jonlee@apple.com>
2312
2313         [WK2] Add permissions support (73960)
2314         https://bugs.webkit.org/show_bug.cgi?id=73960
2315         <rdar://problem/10357008>
2316
2317         Reviewed by Darin Adler.
2318
2319         Add null function item to comply with added callback to WKPageUIClient.
2320
2321         * MiniBrowser/mac/BrowserWindowController.m:
2322         (-[BrowserWindowController awakeFromNib]):
2323         * WebKitTestRunner/TestController.cpp:
2324         (WTR::TestController::createOtherPage):
2325         (WTR::TestController::initialize):
2326
2327 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
2328
2329         [Qt] Visualize mock points in the Qt MiniBrowser
2330         https://bugs.webkit.org/show_bug.cgi?id=74074
2331
2332         Reviewed by Tor Arne Vestbø.
2333
2334         * MiniBrowser/qt/BrowserWindow.cpp:
2335         (BrowserWindow::updateVisualMockTouchPoints):
2336         * MiniBrowser/qt/BrowserWindow.h:
2337         * MiniBrowser/qt/MiniBrowser.qrc:
2338         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2339         (MiniBrowserApplication::notify):
2340         (MiniBrowserApplication::sendTouchEvent):
2341         * MiniBrowser/qt/MiniBrowserApplication.h:
2342         * MiniBrowser/qt/icons/touchpoint.png: Added.
2343         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
2344
2345 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
2346
2347         [Qt] WebKitTestRunner crashes with debug builds
2348         https://bugs.webkit.org/show_bug.cgi?id=74090
2349
2350         Reviewed by Tor Arne Vestbø.
2351
2352         * WebKitTestRunner/qt/TestControllerQt.cpp:
2353         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
2354         to ensure WTF/JSC threading is initialized.
2355
2356 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
2357
2358         fix build-webkit --chromium after breakage in r102201
2359         https://bugs.webkit.org/show_bug.cgi?id=74031
2360
2361         Reviewed by Tony Chang.
2362
2363         * Scripts/webkitdirs.pm:
2364         (buildChromium):
2365
2366 2011-12-08  Kentaro Hara  <haraken@chromium.org>
2367
2368         Unreviewed, rolling out r102280.
2369         http://trac.webkit.org/changeset/102280
2370         https://bugs.webkit.org/show_bug.cgi?id=74031
2371
2372         Chromium/Windows build is broken
2373
2374         * Scripts/webkitdirs.pm:
2375         (buildChromium):
2376
2377 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
2378
2379         Adding myself to committers list.
2380
2381         Unreviewed.
2382
2383         * Scripts/webkitpy/common/config/committers.py:
2384
2385 2011-12-07  Michael Saboff  <msaboff@apple.com>
2386
2387         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
2388         https://bugs.webkit.org/show_bug.cgi?id=73995
2389
2390         Reenabled failing tests that the code part of the patch fixes.
2391
2392         Reviewed by Geoffrey Garen.
2393
2394         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2395         (TestWebKitAPI::TEST):
2396
2397 2011-12-07  MORITA Hajime  <morrita@google.com>
2398
2399         [filter-build-webkit] should not emit reset color when --no-color is given
2400         https://bugs.webkit.org/show_bug.cgi?id=73992
2401
2402         Reviewed by Daniel Bates.
2403
2404         Stop printing control sequences when --no-color is given.
2405         After this change, the filter runs nicely even on environments
2406         like Emacs compilation-mode which cannot understand the control sequence.
2407
2408         * Scripts/filter-build-webkit:
2409         (printLine):
2410
2411 2011-12-07  Eric Seidel  <eric@webkit.org>
2412
2413         Use free memory to determine if we have space for DRT instances instead of total memory
2414         https://bugs.webkit.org/show_bug.cgi?id=74021
2415
2416         Reviewed by Adam Barth.
2417
2418         This will hopefully make the Mac buildbots behave better.
2419
2420         I also reduced the expected memory needed per DRT now that
2421         we're properly accounting for the system memory in our calculations.
2422
2423         * Scripts/webkitpy/common/system/platforminfo.py:
2424         (PlatformInfo.total_bytes_memory):
2425         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
2426         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2427         (MockPlatformInfo.total_bytes_memory):
2428         * Scripts/webkitpy/layout_tests/port/base.py:
2429         (Port.default_child_processes):
2430         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2431         (PortTest.test_default_child_processes):
2432
2433 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
2434
2435         fix build-webkit --chromium after breakage in r102201
2436         https://bugs.webkit.org/show_bug.cgi?id=74031
2437
2438         Reviewed by Tony Chang.
2439
2440         r102201 introduced a change to the chromium build that splits
2441         the executables out of WebKit.gyp into other gyp files, and adds
2442         a new "All.gyp" that builds everything. However, I forgot to
2443         update the build script to use All.gyp.
2444
2445         * Scripts/webkitdirs.pm:
2446         (buildChromium):
2447
2448 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
2449
2450         Moved myself to the committers list.
2451
2452         * Scripts/webkitpy/common/config/committers.py:
2453
2454 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2455
2456         [Qt] Fix debug shlib build with V8.
2457
2458         Reviewed by Tor Arne Vestbø.
2459
2460         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
2461         v8 builds.
2462
2463 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
2464
2465         [Qt] V8 build fixes.
2466
2467         Reviewed by Tor Arne Vestbø.
2468
2469         * qmake/mkspecs/features/javascriptcore.prf: Don't add
2470         Source/Thirdparty to the include search path here.
2471         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
2472         used when building WebCore as well as using it, because header files like
2473         GraphicsContext3D.h include stuff from ThirdParty.
2474
2475 2011-12-07  Peter Beverloo  <peter@chromium.org>
2476
2477         [Chromium] Fix project file generation for the Android bot after r102201
2478         https://bugs.webkit.org/show_bug.cgi?id=73996
2479
2480         The gyp refactoring in r102201 was didn't explicitly exclude
2481         the Android operating system in Tools/Tools.gyp, which broke
2482         as gcc_version is not defined for that configuration.
2483
2484         Reviewed by Andreas Kling.
2485
2486         * Tools.gyp:
2487
2488 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
2489
2490         Unreviewed. Disabled failing tests on chromium.
2491
2492         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2493         (TestWebKitAPI::TEST):
2494
2495 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
2496
2497         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
2498         https://bugs.webkit.org/show_bug.cgi?id=73382
2499
2500         Reviewed by Tony Chang.
2501
2502         XCode (and hence GYP) can't handle circular dependencies between
2503         files (and projects). Accordingly, although the binaries in
2504         WebKit.gyp depend on webkit_support and webkit_support depends
2505         on webkit, we don't mention the latter dependency in the file.
2506         To fix this, this change moves the binaries like DRT into a new
2507         GYP file, and modifies gyp_webkit to build from that file
2508         instead of WebKit.gyp.
2509
2510         * Tools.gyp: Added.
2511
2512 2011-12-06  Adam Roben  <aroben@apple.com>
2513
2514         Add a pid parameter to CrashLogs.find_newest_log
2515
2516         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
2517         considered.
2518
2519         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
2520         process whose crash log you want to find
2521
2522         Reviewed by Dirk Pranke.
2523
2524         * Scripts/webkitpy/common/system/crashlogs.py:
2525         (CrashLogs.find_newest_log): Added an optional pid parameter.
2526         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
2527         candidate log's app_description extended attribute to see if that log corresponds to a
2528         crashed process with the specified PID.
2529
2530         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2531         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
2532         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
2533         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
2534
2535         * Scripts/webkitpy/common/system/filesystem.py:
2536         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
2537         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
2538         present.
2539
2540         * Scripts/webkitpy/common/system/filesystem_mock.py:
2541         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
2542         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
2543         dictionary.
2544
2545         * Scripts/webkitpy/tool/commands/queries.py:
2546         (CrashLog): Added help text. Added an optional PID parameter.
2547         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
2548
2549 2011-12-06  Adam Roben  <aroben@apple.com>
2550
2551         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
2552
2553         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
2554         alive beyond the normal timeout limit. In cases where the crashed process was able to die
2555         faster, NRWT would assume that Crash Reporter had finished even though it often was still
2556         running, which would lead to an incorrect crash log being picked up.
2557
2558         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
2559
2560         Reviewed by Dirk Pranke.
2561
2562         * Scripts/webkitpy/layout_tests/port/server_process.py:
2563         (ServerProcess._reset):
2564         (ServerProcess.write):
2565         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
2566         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
2567         set_crashed.
2568
2569         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
2570         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
2571         we bail out of handling the failure as a timeout if we find out that the process in fact
2572         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
2573         so.
2574         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
2575         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
2576         disk.
2577
2578         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2579         (TrivialMockPort.is_crash_reporter): Added.
2580
2581         * Scripts/webkitpy/layout_tests/port/webkit.py:
2582         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
2583         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
2584
2585 2011-12-06  Adam Barth  <abarth@webkit.org>
2586
2587         NRWT fails on unreleased versions of Mac OS X
2588         https://bugs.webkit.org/show_bug.cgi?id=72748
2589
2590         Reviewed by Dirk Pranke.
2591
2592         Hopefully this patch will make NRWT work on future versions on Mac OS X.
2593         Most of the infrastructure was already in place, but there were some
2594         asserts that failed.  I've tested this patch by haxoring the version
2595         detection logic to simulate an unknown version.  We might need to
2596         iterate based on feedback from folks with a real future version.
2597
2598         * Scripts/webkitpy/layout_tests/port/apple.py:
2599         (ApplePort.__init__):
2600             - mac-future is an allowed port_name that's used internally by
2601               webkitpy to represent future versions of Mac OS X.
2602         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2603         (test_versions):
2604             - Test that we don't throw exceptions when dealing with future
2605               versions of Mac OS X.
2606         * Scripts/webkitpy/layout_tests/port/webkit.py:
2607         (WebKitPort._expectations_from_skipped_files):
2608             - Demote this logging message to "debug".  It's expected that
2609               mac-future doesn't have a Skipped file.
2610         * Scripts/webkitpy/layout_tests/port/mac.py:
2611         (MacPort.__init__):
2612         * Scripts/webkitpy/layout_tests/port/win.py:
2613         (WinPort.__init__):
2614             - Re-order some code in these constructors so that
2615               self._operating_system is available to the ApplePort constructor.
2616
2617 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
2618
2619         Added myself as a committer.
2620
2621         * Scripts/webkitpy/common/config/committers.py:
2622
2623 2011-12-06  Peter Beverloo  <peter@chromium.org>
2624
2625         Added myself as a committer.
2626
2627         * Scripts/webkitpy/common/config/committers.py:
2628
2629 2011-12-06  Kentaro Hara  <haraken@chromium.org>
2630
2631         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
2632         https://bugs.webkit.org/show_bug.cgi?id=73637
2633
2634         Reviewed by Adam Barth.
2635
2636         This patch replaces subprocess.Popen() with Executive, similar to other
2637         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
2638         works well for cases where no exception is raised, no exception is raised
2639         but diff is found, and ScriptError is raised.
2640
2641         * Scripts/run-bindings-tests:
2642         (main):
2643         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
2644         (BindingsTests.__init__):
2645         (BindingsTests.generate_from_idl):
2646         (BindingsTests.generate_supplemental_dependency):
2647         (BindingsTests.detect_changes):
2648
2649 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
2650
2651         [Qt] MiniBrowser should default to touch behavior
2652         https://bugs.webkit.org/show_bug.cgi?id=73863
2653
2654         Reviewed by Chang Shu.
2655
2656         MiniBrowser currently defaults to the traditional desktop behaviour
2657         instead of touch behaviour which is prefered.
2658
2659         * MiniBrowser/qt/BrowserWindow.cpp:
2660         (BrowserWindow::BrowserWindow):
2661         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2662         (printHelp):
2663         (MiniBrowserApplication::handleUserOptions):
2664         * MiniBrowser/qt/MiniBrowserApplication.h:
2665         (WindowOptions::WindowOptions):
2666         (WindowOptions::setUseTraditionalDesktopBehavior):
2667         (WindowOptions::useTraditionalDesktopBehavior):
2668
2669 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2670
2671         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
2672         https://bugs.webkit.org/show_bug.cgi?id=73878
2673
2674         Reviewed by Tony Chang.
2675
2676         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
2677         r98785 made webkit.py always use m_data16, which does not work when
2678         the string is an 8-bit string (such as KURL::string()).
2679
2680         I was not able to directly call StringImpl::is8Bit() in the Python
2681         code, so I just reproduced the implementation there.
2682
2683         * gdb/webkit.py:
2684         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2685         (WTFStringPrinter.to_string):
2686         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
2687         (JSCUStringPrinter.to_string):
2688
2689 2011-12-05  Eric Seidel  <eric@webkit.org>
2690
2691         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
2692         in hopes of making the Snow Leopard bot stop timing out.
2693
2694         Unreviewed.
2695
2696         * Scripts/webkitpy/layout_tests/port/base.py:
2697         (Port.default_child_processes):
2698         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2699         (PortTest.test_default_child_processes):
2700
2701 2011-12-05  Eric Seidel  <eric@webkit.org>
2702
2703         NRWT creates too many workers on RAM-limited machines
2704         https://bugs.webkit.org/show_bug.cgi?id=73847
2705
2706         Reviewed by Dirk Pranke.
2707
2708         Make NRWT restrict its number of workers when there isn't enough
2709         RAM to support them.
2710         Also re-enable parallel testing on the Mac bots which were
2711         failing due to not enough ram.
2712
2713         * Scripts/run-webkit-tests:
2714         (platformIsReadyForParallelTesting):
2715         * Scripts/webkitpy/common/host.py:
2716         (Host.__init__):
2717         * Scripts/webkitpy/common/system/executive_mock.py:
2718         (MockExecutive.cpu_count):
2719         * Scripts/webkitpy/common/system/platforminfo.py:
2720         (PlatformInfo.__init__):
2721         (PlatformInfo.display_name):
2722         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2723         (MockPlatformInfo.display_name):
2724         * Scripts/webkitpy/layout_tests/port/base.py:
2725         (Port.default_child_processes):
2726         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2727         (PortTest.test_default_child_processes):
2728         (PortTest.test_pretty_patch_os_error):
2729
2730 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
2731
2732         Last mouse event could be lost if a JS call to eventSender.leapForward is made
2733         https://bugs.webkit.org/show_bug.cgi?id=73366
2734
2735         Reviewed by Kenneth Rohde Christiansen.
2736
2737         Empty the entire event queue when requested besides using
2738         sendEvent instead of postEvent to make sure all events were
2739         delivered.
2740
2741         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2742         (WTR::EventSenderProxy::EventSenderProxy):
2743         (WTR::EventSenderProxy::sendOrQueueEvent):
2744         (WTR::EventSenderProxy::replaySavedEvents):
2745
2746 2011-12-05  Adam Barth  <abarth@webkit.org>
2747
2748         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
2749         https://bugs.webkit.org/show_bug.cgi?id=73845
2750
2751         Reviewed by Darin Fisher.
2752
2753         Update includes to point to the new header locations.
2754
2755         * DumpRenderTree/chromium/AccessibilityController.cpp:
2756         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2757         * DumpRenderTree/chromium/CppBoundClass.cpp:
2758         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2759         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2760         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2761         * DumpRenderTree/chromium/EventSender.cpp:
2762         * DumpRenderTree/chromium/EventSender.h:
2763         * DumpRenderTree/chromium/GamepadController.h:
2764         * DumpRenderTree/chromium/LayoutTestController.cpp:
2765         * DumpRenderTree/chromium/LayoutTestController.h:
2766         * DumpRenderTree/chromium/MockSpellCheck.cpp:
2767         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2768         * DumpRenderTree/chromium/PlainTextController.cpp:
2769         * DumpRenderTree/chromium/Task.cpp:
2770         * DumpRenderTree/chromium/TestNavigationController.h:
2771         * DumpRenderTree/chromium/TestShell.cpp:
2772         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2773         * DumpRenderTree/chromium/TestWebPlugin.h:
2774         * DumpRenderTree/chromium/TextInputController.cpp:
2775         * DumpRenderTree/chromium/WebPermissions.cpp:
2776         * DumpRenderTree/chromium/WebPreferences.h:
2777         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2778         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2779         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2780         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2781         * DumpRenderTree/chromium/WebViewHost.cpp:
2782
2783 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2784
2785         Add Aharon Lanin to the contributors list.
2786
2787         * Scripts/webkitpy/common/config/committers.py:
2788
2789 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
2790
2791         Moving myself from contributors to committers.
2792
2793         * Scripts/webkitpy/common/config/committers.py:
2794
2795 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
2796
2797         Add myself as a committer.
2798
2799         * Scripts/webkitpy/common/config/committers.py:
2800
2801 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
2802
2803         [Qt] Rename QQuickWebView::canStop property to just loading 
2804         https://bugs.webkit.org/show_bug.cgi?id=73813
2805
2806         Reviewed by Kenneth Rohde Christiansen.
2807
2808         Replaced references to WebView.canStop with WebView.loading.
2809
2810         * MiniBrowser/qt/qml/BrowserWindow.qml:
2811
2812 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
2813
2814         run-webkit-tests: limit --child-processes properly on apple mac
2815         https://bugs.webkit.org/show_bug.cgi?id=73856
2816
2817         Reviewed by Adam Roben.
2818
2819         Fix typos in r102013 so that we correctly pass --child-processes=1 on
2820         the apple mac bots temporarily.
2821
2822         * Scripts/run-webkit-tests:
2823         (platformIsReadyForParallelTesting):
2824
2825 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
2826
2827         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
2828         https://bugs.webkit.org/show_bug.cgi?id=73840
2829
2830         Reviewed by Simon Fraser.
2831
2832         Temporarily go back to single process mode on Mac.
2833
2834         * Scripts/run-webkit-tests:
2835         (platformIsReadyForParallelTesting):
2836
2837 2011-12-05  Adam Roben  <aroben@apple.com>
2838
2839         Redeploy apple-macpro-7 and apple-xserve-1
2840
2841         These slaves have been sitting idle since we removed our Leopard builders in r97496.
2842
2843         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
2844         sitting idle
2845
2846         Reviewed by Sam Weinig.
2847
2848         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
2849         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
2850         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
2851         (WebKit2 Tests)".
2852
2853 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2854
2855         [Qt] Make the UI of the MiniBrowser slightly nicer
2856
2857         Rubberstamped by Simon Hausmann.
2858
2859         - Add proper padding
2860         - Show feedback when pressing on the toolbar icons
2861         - Make the text entry better looking
2862
2863         * MiniBrowser/qt/qml/BrowserWindow.qml:
2864
2865 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2866
2867         NRWT should handle duplicated expectations
2868         https://bugs.webkit.org/show_bug.cgi?id=69750
2869
2870         Reviewed by Dirk Pranke.
2871
2872         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2873         (TestExpectations.__init__):
2874         (TestExpectations._report_errors):
2875         (TestExpectations._add_expectations):
2876         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2877         (test_add_skipped_tests):
2878         * Scripts/webkitpy/layout_tests/port/base.py:
2879         (Port.skipped_tests):
2880         * Scripts/webkitpy/layout_tests/port/webkit.py:
2881         (WebKitPort.test_expectations):
2882         (WebKitPort.skipped_tests):
2883         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2884         (test_test_expectations):
2885
2886 2011-12-04  Eric Seidel  <eric@webkit.org>
2887
2888         After success with Mac, Win and Gtk, turning on parallel testing
2889         by default for all platforms (except Qt).
2890
2891         We'll add more platforms to the blacklist if we see problems.
2892
2893         Unreviewed.
2894
2895         * Scripts/run-webkit-tests:
2896         (platformIsReadyForParallelTesting):
2897
2898 2011-12-04  Sam Weinig  <sam@webkit.org>
2899
2900         Add tests for RetainPtr::adoptNS/adoptCF
2901         https://bugs.webkit.org/show_bug.cgi?id=73470
2902
2903         Reviewed by Adam Roben and Darin Adler.
2904
2905         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2906         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
2907         (TestWebKitAPI::TEST):
2908         Test that adopting using adoptCF creates a RetainPtr with a
2909         value whose retain count is 1.
2910
2911         * TestWebKitAPI/Tests/WTF/ns: Added.
2912         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
2913         (TestWebKitAPI::TEST):
2914         Test that adopting using adoptNS creates a RetainPtr with a
2915         value whose retain count is 1.
2916
2917 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
2918
2919         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
2920         https://bugs.webkit.org/show_bug.cgi?id=73748
2921
2922         Reviewed by Gustavo Noronha Silva.
2923
2924         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
2925
2926 2011-12-04  Philippe Normand  <pnormand@igalia.com>
2927
2928         Another GTK build fix after r101922.
2929
2930         Rubber-stamped by Martin Robinson.
2931
2932         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2933         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
2934
2935 2011-12-04  Xan Lopez  <xlopez@igalia.com>
2936
2937         Fix compiler warning in LayoutTestController
2938
2939         Reviewed by Philippe Normand.
2940
2941         * DumpRenderTree/LayoutTestController.cpp:
2942         (LayoutTestController::LayoutTestController): fix warning.
2943
2944 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
2945
2946         Add missing methods used by fast/notifications tests to LayoutTestController
2947         https://bugs.webkit.org/show_bug.cgi?id=63616
2948
2949         Reviewed by Martin Robinson.
2950
2951         Add missing simulateDesktopNotificationClick method used by
2952         fast/notifications. Provide a default implementation for
2953         areDesktopNotificationPermissionRequestsIgnored and
2954         ignoreDesktopNotificationPermissionRequests.
2955
2956         * DumpRenderTree/LayoutTestController.cpp:
2957         (LayoutTestController::LayoutTestController): call into the port implementation.
2958         (simulateDesktopNotificationClickCallback): ditto.
2959         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
2960         (LayoutTestController::staticFunctions): declare new methods.
2961         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
2962         * DumpRenderTree/LayoutTestController.h:
2963         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
2964         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2965         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
2966         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2967         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2968         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2969         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2970         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2971         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2972         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2973         (LayoutTestController::simulateDesktopNotificationClick): ditto.
2974
2975 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
2976
2977         [GTK] Don't log document events in DRT
2978         https://bugs.webkit.org/show_bug.cgi?id=73746
2979
2980         Reviewed by Martin Robinson.
2981
2982         Stop connecting globally to document-related events.
2983
2984         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2985         (connectAccessibilityCallbacks): Removed connections.
2986         (disconnectAccessibilityCallbacks): Removed disconnections.
2987
2988 2011-12-03  Dan Bernstein  <mitz@apple.com>
2989
2990         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
2991
2992         Reviewed by Darin Adler.
2993
2994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2995         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
2996         (TestWebKitAPI::TEST):
2997
2998 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2999
3000         Another GTK build fix after r101922.
3001
3002         Rubber-stamped by Martin James Robinson.
3003
3004         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3005         (LayoutTestController::pathToLocalResource): return value needs to
3006         be a URI.
3007
3008 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3009
3010         Small fix for my previous patch. Do not try to delete a member
3011         of a dictionary that does not exist.
3012
3013         Reviewed by Gustavo Noronha Silva.
3014
3015         * gtk/run-with-jhbuild:
3016         (install_and_run_jhbuild):
3017
3018 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3019
3020         Fix jhbuild installation for people who have unusual MAKE environment
3021         variables such as 'make -j4' as the jhbuild build does not handle it.
3022
3023         Reviewed by Gustavo Noronha Silva.
3024
3025         * gtk/run-with-jhbuild:
3026         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
3027
3028 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3029
3030         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
3031         when run for the first time.
3032
3033         Reviewed by Gustavo Noronha Silva.
3034
3035         * Scripts/update-webkitgtk-libs: Fix first run.
3036
3037 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3038
3039         Unreviewed, GTK build fix after r101922.
3040
3041         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3042         (LayoutTestController::pathToLocalResource): Added sentinel in
3043         g_build_filename call.
3044
3045 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3046
3047         GTK API tests build fix. Run the tests inside jhbuild.
3048
3049         Rubber-stamped by Gustavo Noronha Silva.
3050
3051         * Scripts/run-gtk-tests:
3052         (TestRunner.__init__):
3053         (TestRunner.run._error_handler):
3054         (TestRunner):
3055         (TestRunner.run):
3056
3057 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3058
3059         Small build fix. Properly specify the path to the locally installed jhbuild.
3060
3061         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
3062
3063 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3064
3065         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3066         https://bugs.webkit.org/show_bug.cgi?id=67256
3067
3068         Reviewed by Philippe Normand.
3069
3070         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
3071         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
3072         which points to the more generic top-level path of the WebKit checkout. This code is
3073         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
3074         share code here.
3075
3076         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
3077         location. This will cause the fallback to fail if you build into a non-typical location
3078         or even fake it with a symlink. In this case it's important to use the environment variable.
3079
3080         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3081         (getTopLevelPath): Added.
3082         (initializeFonts): Use the new helper to get the font path.
3083         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
3084         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3085         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
3086         test paths.
3087         * Scripts/webkitpy/layout_tests/port/gtk.py:
3088         (GtkPort.setup_environ_for_server):Pass the top-level path of the
3089         checkout instead of passing the font path.
3090         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3091         (WTR::getTopLevelPath): Added this helper.
3092         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
3093
3094 2011-12-02  David Levin  <levin@chromium.org>
3095
3096         Rename WTF class from TemporarilyChange to TemporaryChange.
3097         https://bugs.webkit.org/show_bug.cgi?id=73479
3098
3099         Reviewed by Eric Seidel.
3100
3101         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
3102         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
3103         * TestWebKitAPI/TestWebKitAPI.gypi:
3104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3105         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
3106         (TestWebKitAPI::TEST):
3107         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3108
3109 2011-12-02  Tony Chang  <tony@chromium.org>
3110
3111         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
3112         https://bugs.webkit.org/show_bug.cgi?id=73453
3113
3114         Reviewed by Ryosuke Niwa.
3115
3116         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
3117         The verbose output will include the failure reason.
3118
3119         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
3120         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3121         (write_test_result):
3122         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
3123         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
3124         (determine_result_type):
3125         (FailureReftestNoImagesGenerated.__init__):
3126         (FailureReftestNoImagesGenerated):
3127         (FailureReftestNoImagesGenerated.message):
3128         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
3129         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
3130         (MainTest.test_run_singly_actually_runs_tests):
3131         (MainTest.test_unexpected_failures):
3132         (EndToEndTest.test_end_to_end):
3133
3134 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
3135
3136         ChangeLog should be able to parse annotated changelogs
3137         https://bugs.webkit.org/show_bug.cgi?id=72703
3138
3139         Reviewed by Eric Seidel.
3140
3141         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
3142         and extract the revision number for each entry.
3143
3144         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
3145
3146         * Scripts/webkitpy/common/checkout/changelog.py:
3147         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3148         * Scripts/webkitpy/common/checkout/scm/git.py:
3149         * Scripts/webkitpy/common/checkout/scm/scm.py:
3150         * Scripts/webkitpy/common/checkout/scm/svn.py:
3151
3152 2011-12-02  Eric Seidel  <eric@webkit.org>
3153
3154         Enable parallel testing for Win and Gtk bots
3155         after confirming with Lucas and Martin the bots should be OK.
3156
3157         Unreviewed. (I ran the idea by Lucas and Martin.)
3158
3159         * Scripts/run-webkit-tests:
3160         (platformIsReadyForParallelTesting):
3161
3162 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3163
3164         Try to fix the GTK+ build.
3165
3166         * gtk/jhbuild.modules: Properly specify the glib-networking
3167         dependency for soup.
3168
3169 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3170
3171         Fix a syntax error in the committers.py file.
3172
3173         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
3174
3175 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
3176
3177         Add Alan Stearns and Peter Linss to the contributors list.
3178
3179         * Scripts/webkitpy/common/config/committers.py:
3180
3181 2011-12-02  Kent Tamura  <tkent@chromium.org>
3182
3183         [Chromium] Fix compilation warnings for ASSERT()
3184         https://bugs.webkit.org/show_bug.cgi?id=73623
3185
3186         Reviewed by Tony Chang.
3187
3188         * DumpRenderTree/chromium/ImageDiff.cpp:
3189          - Fix fprintf format: %s -> %d for __LINE__
3190          - Do nothing for ASSERT() if NDEBUG.
3191
3192 2011-12-02  Eric Seidel  <eric@webkit.org>
3193
3194         Enable parallel testing for all Mac bots.
3195
3196         Unreviewed.
3197
3198         * Scripts/run-webkit-tests:
3199         (platformIsReadyForParallelTesting):
3200
3201 2011-12-02  Eric Seidel  <eric@webkit.org>
3202
3203         Enable parallel testing for run-webkit-tests on Mac Lion.
3204         I plan to move all the machines to parallel testing shortly
3205         but we're starting with Lion.
3206
3207         Unreviewed.
3208
3209         * Scripts/run-webkit-tests:
3210         (platformIsReadyForParallelTesting):
3211
3212 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3213
3214         Added helper method to identify whether the page has custom page size style.
3215         https://bugs.webkit.org/show_bug.cgi?id=73585
3216
3217         Reviewed by Darin Fisher.
3218
3219         * DumpRenderTree/chromium/LayoutTestController.cpp:
3220         (LayoutTestController::LayoutTestController):
3221         (LayoutTestController::hasCustomPageSizeStyle):
3222         * DumpRenderTree/chromium/LayoutTestController.h:
3223
3224 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
3225
3226         [NRWT] reftest should support having multiple references per test
3227         https://bugs.webkit.org/show_bug.cgi?id=73613
3228
3229         Reviewed by Dirk Pranke.
3230
3231         Add a support for having multiple reference files for a single test.
3232
3233         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
3234         at least one of expected mismatches, we compare expected mismatches first in order to minimize
3235         the number of reference files to open on DRT.
3236
3237         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3238         (interpret_test_failures): Remove checks no longer applicable.
3239         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3240         (ResultSummaryTest.test_interpret_test_failures): Ditto.
3241         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3242         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
3243         (SingleTestRunner._driver_input):
3244         (SingleTestRunner.run):
3245         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
3246         * Scripts/webkitpy/layout_tests/models/test_input.py:
3247         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
3248         * Scripts/webkitpy/layout_tests/port/base.py:
3249         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
3250         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
3251         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3252         (PortTest.test_parse_reftest_list):
3253         * Scripts/webkitpy/layout_tests/port/test.py:
3254         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3255         (MainTest.test_unexpected_failures):
3256         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
3257         (EndToEndTest.test_end_to_end):
3258         (EndToEndTest.test_reftest_with_two_notrefs): Added.
3259
3260 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3261
3262         Build libsoup without gnome dependencies (like keyring).
3263
3264         * gtk/jhbuild.modules:
3265
3266 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3267
3268         Also build gcrypt and p11-kit, and make them dependencies of
3269         gnutls.
3270
3271         * gtk/jhbuild.modules:
3272
3273 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
3274
3275         [wx] Unreviewed build fixes for Windows build.
3276
3277         * waf/build/wxpresets.py:
3278
3279 2011-12-01  Eric Seidel  <eric@webkit.org>
3280
3281         Reviewed by Adam Barth.
3282
3283         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
3284         https://bugs.webkit.org/show_bug.cgi?id=32006
3285
3286         I decided not to make it warn, and just have it re-open the bug.
3287         That's not that different from today's behavior which will
3288         just silently attach the patch.
3289
3290         This patch makes behavior between upload and land-safely consistent
3291         (previously one would assign patches and the other would not)
3292         as well as adds the ability for both to ensure that the bug is open.
3293
3294         To test this I had to add a few more methods to MockBugzilla which
3295         (positively) affected a few other test results.
3296
3297         I also made AbstractStep keep a cached copy of the Bug object
3298         and used the cached copy where appropriate (including for 'bug_title').
3299         This should reduce the number of bug fetches we perform.
3300
3301         * Scripts/webkitpy/tool/commands/download_unittest.py:
3302         * Scripts/webkitpy/tool/commands/upload.py:
3303         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3304         * Scripts/webkitpy/tool/mocktool.py:
3305         * Scripts/webkitpy/tool/steps/__init__.py:
3306         * Scripts/webkitpy/tool/steps/abstractstep.py:
3307         * Scripts/webkitpy/tool/steps/closebug.py:
3308         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
3309         * Scripts/webkitpy/tool/steps/postdiff.py:
3310         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
3311         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3312         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3313         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
3314
3315 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3316
3317         Also pass --no-interact to jhbuild when updating dependencies.
3318
3319         * Scripts/update-webkitgtk-libs:
3320
3321 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
3322
3323         Make _build_path check more thoroughly that build paths exist.
3324         https://bugs.webkit.org/show_bug.cgi?id=73601
3325
3326         Reviewed by Ojan Vafai.
3327
3328         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3329         (ChromiumMacPort._build_path):
3330
3331 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3332
3333         Add libffi to the jhbuild modules list as a glib dependency.
3334
3335         Rubber-stamped by Martin Robinson.
3336
3337         * gtk/jhbuild.modules:
3338
3339 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3340
3341         Build fix. Use internal pcre on glib, make gnutls a dependency of
3342         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
3343         in non-interactive mode.
3344
3345         * Scripts/update-webkitgtk-libs:
3346         * gtk/jhbuild.modules:
3347         * gtk/run-with-jhbuild:
3348
3349 2011-12-02  Adam Roben  <aroben@apple.com>
3350
3351         Fix for Python 2.6
3352
3353         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3354         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
3355         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
3356         searching for "Tests that timed out:" etc. This makes our check less strict, but it
3357         shouldn't matter given the kinds of content we parse.
3358
3359 2011-12-02  Adam Roben  <aroben@apple.com>
3360
3361         Fix names of failed/timed out tests in run-api-tests output
3362
3363         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
3364         out tests
3365
3366         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
3367
3368         Reviewed by Simon Fraser.
3369
3370         * Scripts/run-api-tests:
3371         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
3372         of this function.
3373
3374 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
3375
3376         [GTK] generate-gtkdoc should respect build type
3377         https://bugs.webkit.org/show_bug.cgi?id=73296
3378
3379         Reviewed by Philippe Normand.
3380
3381         * Scripts/webkitdirs.pm:
3382         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
3383         * gtk/common.py: If --build is passed give preference to the Debug build directory.
3384
3385 2011-12-02  Tony Chang  <tony@chromium.org>
3386
3387         [nrwt] fix wdiff output
3388         https://bugs.webkit.org/show_bug.cgi?id=73604
3389
3390         Reviewed by Adam Barth.
3391
3392         * Scripts/webkitpy/layout_tests/port/base.py:
3393         (Port.wdiff_text):
3394         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3395         (PortTest.test_wdiff_text):
3396
3397 2011-12-02  Adam Roben  <aroben@apple.com>
3398
3399         Teach build.webkit.org to display how many unit tests failed or timed out
3400
3401         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
3402         build.webkit.org
3403
3404         We now display something like "5 unit tests failed or timed out". Eventually we might want
3405         to split out how many failure vs. timeouts there were.
3406
3407         Reviewed by Darin Adler.
3408
3409         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3410         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
3411         classes that may want to subclass it.
3412         (RunUnitTests): Changed to inherit from TestWithFailureCount.
3413         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
3414         timed out:" and "Tests that failed:" lines, if present.
3415
3416         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3417         (StubStdio):
3418         (StubRemoteCommand):
3419         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
3420
3421         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
3422         the test run correctly.
3423
3424         (RunUnitTestsTest.test_no_failures_or_timeouts):
3425         (RunUnitTestsTest.test_one_failure):
3426         (RunUnitTestsTest.test_multiple_failures):
3427         (RunUnitTestsTest.test_one_timeout):
3428         (RunUnitTestsTest.test_multiple_timeouts):
3429         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
3430         Test various cases.
3431
3432 2011-12-02  Adam Roben  <aroben@apple.com>
3433
3434         Teach prepare-ChangeLog to treat master.cfg as a Python file
3435
3436         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
3437         in buildbot's master.cfg
3438
3439         Reviewed by Darin Adler.
3440
3441         * Scripts/prepare-ChangeLog:
3442         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
3443         master.cfg.
3444
3445 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
3446
3447         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
3448         https://bugs.webkit.org/show_bug.cgi?id=73669
3449
3450         Reviewed by Gustavo Noronha Silva.
3451
3452         Add a wrapper script that knows how to install jhbuild and also to wrap commands
3453         in the jhbuild shell.
3454
3455         * Scripts/webkitdirs.pm:
3456         (runAutogenForAutotoolsProject): Use the new wrapper script.
3457         (mustReRunAutogen): Ditto.
3458         (buildAutotoolsProject): Ditto.
3459         * Scripts/webkitpy/layout_tests/port/gtk.py:
3460         (GtkDriver.cmd_line): Ditto.
3461         * gtk/run-with-jhbuild: Added.
3462
3463 2011-12-01  Adam Roben  <aroben@apple.com>
3464
3465         Teach check-webkit-style how to check the syntax of JSON files
3466
3467         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
3468
3469         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
3470         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
3471         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
3472         been removed, since its output differs by platform.
3473
3474         Reviewed by Darin Adler.
3475
3476         * Scripts/webkitpy/style/checker.py:
3477         (_all_categories): Added JSONChecker's categories to the set of all categories.
3478         (FileType): Added a JSON type. Incremented other types.
3479         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
3480         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
3481
3482         * Scripts/webkitpy/style/checker_unittest.py:
3483         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
3484         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
3485
3486         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
3487         which would have matched our other checkers, because I couldn't figure out how to call
3488         "json.loads" without hitting namespace conflicts.)
3489         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
3490         just the modified lines from a patch.
3491         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
3492         exception.
3493         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
3494         try to extract a line number.
3495
3496         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
3497         (MockErrorHandler.__init__):
3498         (MockErrorHandler.turn_off_line_filtering):
3499         (MockErrorHandler.__call__):
3500         Helper class. Copied from xml_unittest.py.
3501
3502         (JSONCheckerTest.test_line_number_from_json_exception): Test the
3503         line_number_from_json_exception helper method.
3504
3505         (JSONCheckerTest.assert_no_error):
3506         (JSONCheckerTest.assert_error):
3507         Helper methods to assert that we did or didn't get an error.
3508
3509         (JSONCheckerTest.mock_handle_style_error): Helper method.
3510
3511         (JSONCheckerTest.test_conflict_marker):
3512         (JSONCheckerTest.test_single_quote):
3513         (JSONCheckerTest.test_init):
3514         (JSONCheckerTest.test_no_error):
3515         Test various cases.
3516
3517 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3518
3519         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
3520         https://bugs.webkit.org/show_bug.cgi?id=73664
3521
3522         Reviewed by Martin Robinson.
3523
3524         This patch adds our HTTP library and its main dependencies; this
3525         should not affect layout or rendering.
3526
3527         * gtk/jhbuild.modules:
3528
3529 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
3530
3531         [GTK] Also run DumpRenderTree under jhbuild
3532         https://bugs.webkit.org/show_bug.cgi?id=73646
3533
3534         Reviewed by Martin Robinson.
3535
3536         * Scripts/webkitpy/layout_tests/port/gtk.py:
3537         (GtkDriver.cmd_line):
3538
3539 2011-12-02  Hajime Morrita  <morrita@chromium.org>
3540
3541         Unreviewed, rolling out r101751 and r101775.
3542         http://trac.webkit.org/changeset/101751
3543         http://trac.webkit.org/changeset/101775
3544         https://bugs.webkit.org/show_bug.cgi?id=73191
3545
3546         breaks Windows build
3547
3548         * DumpRenderTree/chromium/config.h:
3549         * DumpRenderTree/config.h:
3550         * TestWebKitAPI/config.h:
3551         * WebKitTestRunner/config.h:
3552
3553 2011-12-02  Kentaro Hara  <haraken@chromium.org>
3554
3555         Move run-bindings-tests implementation to webkitpy/bindings/main.py
3556         https://bugs.webkit.org/show_bug.cgi?id=73619
3557
3558         Reviewed by Adam Barth.
3559
3560         As run-bindings-tests has been growing, this patch just moves its implementation
3561         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
3562
3563         No change in behavior.
3564
3565         * Scripts/run-bindings-tests:
3566         (main):
3567         * Scripts/webkitpy/bindings/__init__.py: Added.
3568         * Scripts/webkitpy/bindings/main.py: Added.
3569         (BindingsTests.__init__):
3570         (BindingsTests.generate_from_idl):
3571         (BindingsTests.generate_supplemental_dependency):
3572         (BindingsTests.detect_changes):
3573         (BindingsTests.run_tests):
3574
3575 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
3576
3577         Tools/Scripts: eliminate find_test_files from Port class.
3578         https://bugs.webkit.org/show_bug.cgi?id=73553
3579
3580         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
3581         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
3582         Also I'll move _is_test_file() and related functions close to Port.tests().
3583
3584         Reviewed by Dirk Pranke.
3585
3586         * Scripts/webkitpy/layout_tests/port/base.py:
3587         (Port.tests):
3588         (Port.is_reference_html_file):
3589         (Port._has_supported_extension):
3590         (Port._is_test_file):
3591         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3592         (PortTest.test_find_no_paths_specified):
3593         (PortTest.test_find_one_test):
3594         (PortTest.test_find_glob):
3595         (PortTest.test_find_with_skipped_directories):
3596         (PortTest.test_find_with_skipped_directories_2):
3597         (PortTest.test_is_test_file):
3598         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3599         (_default_tests_paths):
3600         (ChromiumGpuLinuxPort.tests):
3601         (ChromiumGpuCgMacPort.tests):
3602         (ChromiumGpuMacPort.tests):
3603         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3604         (ChromiumGpuTest.test_default_tests_paths.test_paths):
3605         (ChromiumGpuTest.test_default_tests_paths):
3606         (ChromiumGpuTest.test_test_files.test_paths):
3607         (ChromiumGpuTest):
3608         (ChromiumGpuTest.test_test_files):
3609         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3610         (get_tests_run.RecordingTestDriver.run_test):
3611         * Scripts/webkitpy/tool/commands/rebaseline.py:
3612         (OptimizeBaselines._optimize_baseline):
3613         (OptimizeBaselines.execute):
3614         (AnalyzeBaselines._analyze_baseline):
3615         (AnalyzeBaselines.execute):
3616
3617 2011-12-01  Hajime Morrita  <morrita@chromium.org>
3618
3619         JS_INLINE and WTF_INLINE should be visible from WebCore
3620         https://bugs.webkit.org/show_bug.cgi?id=73191
3621
3622         Reviewed by Kevin Ollivier.
3623
3624         Removed macro definitions which is now provided by Platform.h
3625
3626         * DumpRenderTree/chromium/config.h:
3627         * DumpRenderTree/config.h:
3628         * TestWebKitAPI/config.h:
3629         * WebKitTestRunner/config.h:
3630
3631 2011-12-01  Hayato Ito  <hayato@chromium.org>
3632
3633         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
3634         https://bugs.webkit.org/show_bug.cgi?id=73406
3635
3636         Reviewed by Ryosuke Niwa.
3637
3638         WebKitPort's image_diff uses tolerance='0.1' in default.
3639         When reftests fail, we should use tolerace=0 when diff-ing images.
3640
3641         Since ImageDiff on chromium port doesn't use tolerance value as of now,
3642         this change doesn't affect chromium port's behavior.
3643
3644         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3645         (write_test_result):
3646         * Scripts/webkitpy/layout_tests/port/base.py:
3647         (Port.diff_image):
3648         * Scripts/webkitpy/layout_tests/port/chromium.py:
3649         (ChromiumPort.diff_image):
3650         * Scripts/webkitpy/layout_tests/port/test.py:
3651         (TestPort.diff_image):
3652         * Scripts/webkitpy/layout_tests/port/webkit.py: