1 2013-09-18 Alex Christensen <achristensen@webkit.org>
3 Improved WinLauncher's URL handling.
4 https://bugs.webkit.org/show_bug.cgi?id=121535
6 Reviewed by Brent Fulgham.
8 * WinLauncher/WinLauncher.cpp:
10 Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
12 Prepend "http://" to URLs with no scheme.
14 2013-09-18 Filip Pizlo <fpizlo@apple.com>
16 DFG should support Int52 for local variables
17 https://bugs.webkit.org/show_bug.cgi?id=121064
19 Reviewed by Oliver Hunt.
21 * Scripts/run-jsc-stress-tests:
23 2013-09-18 peavo@outlook.com <peavo@outlook.com>
25 [Win] TestWebKitAPI does not compile.
26 https://bugs.webkit.org/show_bug.cgi?id=121485
28 Reviewed by Brent Fulgham.
30 It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
31 Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
32 to return null, which is the case we want to test.
34 * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
35 (TestWebKitAPI::TEST):
37 2013-09-18 Mario Sanchez Prada <mario.prada@samsung.com>
39 [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
40 https://bugs.webkit.org/show_bug.cgi?id=121495
42 Reviewed by Chris Fleizach.
44 Adapted DRT and WKTR to deal with the new names for the ATK object
45 attributes being exposed for 'aria-haspopup' and 'aria-sort'.
47 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
48 (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
49 (AccessibilityUIElement::stringAttributeValue): Ditto.
50 (AccessibilityUIElement::hasPopup): Ditto.
51 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
52 (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
53 (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
54 (WTR::AccessibilityUIElement::hasPopup): Ditto.
56 2013-09-18 Commit Queue <commit-queue@webkit.org>
58 Unreviewed, rolling out r156019 and r156020.
59 http://trac.webkit.org/changeset/156019
60 http://trac.webkit.org/changeset/156020
61 https://bugs.webkit.org/show_bug.cgi?id=121540
63 Broke tests (Requested by ap on #webkit).
65 * Scripts/run-jsc-stress-tests:
67 2013-09-17 Gwang Yoon Hwang <ryumiel@company100.net>
69 Unreviewed. Add myself as a committer.
71 * Scripts/webkitpy/common/config/contributors.json:
73 2013-09-17 Jae Hyun Park <jae.park@company100.net>
75 Unreviewed. Add myself as a committer.
77 * Scripts/webkitpy/common/config/contributors.json:
79 2013-09-17 Filip Pizlo <fpizlo@apple.com>
81 DFG should support Int52 for local variables
82 https://bugs.webkit.org/show_bug.cgi?id=121064
84 Reviewed by Oliver Hunt.
86 * Scripts/run-jsc-stress-tests:
88 2013-09-17 Alex Christensen <alex.christensen@flexsim.com>
90 Added back and forward buttons to WinLauncher.
91 https://bugs.webkit.org/show_bug.cgi?id=121212
93 Reviewed by Brent Fulgham.
95 * WinLauncher/WinLauncher.cpp:
97 Move new back and forward buttons to correct positions before URL bar.
98 (dllLauncherEntryPoint):
99 Store the default button window procedure and replace with my button procedures.
100 (EditProc): Updated style and renamed from MyEditProc.
101 (BackButtonProc): Added.
102 (ForwardButtonProc): Added.
104 2013-09-17 Michael Saboff <msaboff@apple.com>
106 Unreviewed typo fix after r155999
108 Changed en_US.UTB-8 to en_US.UTF-8
110 * Scripts/run-javascriptcore-tests:
112 2013-09-17 Michael Saboff <msaboff@apple.com>
114 run-jsc-stress-tests fails with ruby version 2
115 https://bugs.webkit.org/show_bug.cgi?id=121521
117 Reviewed by Jessie Berlin.
119 Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
121 * Scripts/run-javascriptcore-tests:
123 2013-09-17 Brent Fulgham <bfulgham@apple.com>
125 [Windows] Unreviewed build fix after r155963.
127 * DumpRenderTree/win/TestRunnerWin.cpp:
128 (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
130 2013-09-17 Anders Carlsson <andersca@apple.com>
134 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
135 (TestWebKitAPI::TEST):
137 2013-09-16 Anders Carlsson <andersca@apple.com>
139 HashMap should work with move-only keys
140 https://bugs.webkit.org/show_bug.cgi?id=121310
142 Reviewed by Darin Adler.
144 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
145 (TestWebKitAPI::TEST):
148 2013-09-17 YuTeh Shen <shenyute@hotmail.com>
150 BrowserMarshal.h build fail
151 https://bugs.webkit.org/show_bug.cgi?id=102938
153 Reviewed by Carlos Garcia Campos.
157 * MiniBrowser/gtk/GNUmakefile.am:
159 2013-09-16 Brent Fulgham <bfulgham@apple.com>
161 [Windows] Clean up WinLauncher by using smart pointers
162 https://bugs.webkit.org/show_bug.cgi?id=121467
164 Reviewed by Anders Carlsson.
166 * WinLauncher/PrintWebUIDelegate.cpp:
167 (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
168 * WinLauncher/WinLauncher.cpp:
169 (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
170 (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
171 (showLastVisitedSites): Smart pointer updates.
172 (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
173 (setToDefaultPreferences): Ditto.
174 (dllLauncherEntryPoint): Ditto.
176 (LaunchInspector): Ditto.
177 (NavigateToHistory): Ditto.
181 2013-09-16 Brent Fulgham <bfulgham@apple.com>
183 [Windows] Add rudimentary history to WinLauncher.
184 https://bugs.webkit.org/show_bug.cgi?id=121463
186 Reviewed by Anders Carlsson.
188 * WinLauncher/WinLauncher.cpp:
189 (updateMenuItemForHistoryItem): Added
190 (showLastVisitedSites): Added
191 (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
192 a new page has been visited.
193 (dllLauncherEntryPoint): Deallocate history on exit.
194 (NavigateToHistory): Added
195 (WndProc): Add handler for history entries
196 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
197 up to 10 history slots.
198 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
199 Windows utility library to allow use of _bstr_t type.
200 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
201 to hold up to 10 history slots.
202 * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
204 2013-09-16 Gustavo Noronha Silva <gns@gnome.org>
206 [GTK] Make symbol export filter more strict, and disable for dev/test builds
207 https://bugs.webkit.org/show_bug.cgi?id=120586
209 Reviewed by Martin Robinson.
211 * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
212 makefiles, so they can be included unconditionally.
213 * GtkLauncher/GNUmakefile.am: added.
214 * Scripts/webkitdirs.pm:
215 (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
216 to configure, since we consider builds done through build-webkit to be development
218 * gtk/GNUmakefile.am: added.
219 * gtk/common.py: do not use the Scripts directory as a reference to the top path;
220 it's not necessary and it will not work now that the Scripts directory is not
221 shipped in the tarball.
223 2013-09-16 Anders Carlsson <andersca@apple.com>
225 WTF::Deque should work with move only types
226 https://bugs.webkit.org/show_bug.cgi?id=121446
228 Reviewed by Andreas Kling.
230 * TestWebKitAPI/Tests/WTF/Deque.cpp:
231 (TestWebKitAPI::TEST):
234 2013-09-16 Wojciech Bielawski <w.bielawski@samsung.com>
236 [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
237 https://bugs.webkit.org/show_bug.cgi?id=98410
239 Reviewed by Darin Adler.
241 Add implementation of click() method of objects returned by eventSender.contextClick().
243 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
244 (MenuItemPrivateData):
245 (WTR::menuItemClickCallback):
246 (WTR::getMenuItemTitleCallback):
247 (WTR::staticMenuItemFinalize):
248 (WTR::getMenuItemClass):
249 (WTR::EventSendingController::contextClick):
251 2013-09-15 Zan Dobersek <zdobersek@igalia.com>
253 Make the GDB webkit.py script compatible with Python v3
254 https://bugs.webkit.org/show_bug.cgi?id=121395
256 Reviewed by Ryosuke Niwa.
258 GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
259 uses of xrange() in the script are replaced with range(), and the print statements are changed into
260 the print() function invocations.
263 (guess_string_length):
266 (WTFCStringPrinter.to_string):
267 (PrintPathToRootCommand.invoke):
269 2013-09-15 Zan Dobersek <zdobersek@igalia.com>
271 [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
272 https://bugs.webkit.org/show_bug.cgi?id=119631
274 Reviewed by Ryosuke Niwa.
276 The perf profiler is attached to the test runner after the test runner has been launched,
277 but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
278 UIProcess, meaning that WebProcess operations will not be profiled.
280 To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
281 This is done in the scope of already present support for wrapper scripts (such as valgrind)
282 that are settable through the --wrapper option. This causes the perf profiler to correctly
283 continue profiling the WebProcess after it was spawned.
285 When the profiler is launched, a wait process is launched with the profiler's pid as the
286 argument. This ensures we can check that the profiler exited normally. If it did not, its
287 output can be corrupted and can cause problems when that output is examined. The after-exit
288 report is avoided in that case.
290 * Scripts/webkitpy/common/system/profiler.py:
291 (Profiler.wrapper_arguments): The method returns an empty list by default.
292 (Perf.__init__): Remove unnecessary member variables.
293 (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
294 (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
295 the method returns a list of arguments that should be used as a wrapper for the test runner.
296 The arguments specify the 'perf record' command, with the output file and the instruction to
297 construct the call graph given as well.
298 (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
299 whitespace in the profile lines.
300 (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
301 running. If it is running even after that, or if the profiler process produced a non-zero exit
302 code, the method reports the profiling failure and returns. Otherwise it continues on reporting
303 the top 10 lines of the profile and how to examine the profile further.
304 * Scripts/webkitpy/port/driver.py:
305 (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
306 as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
307 or an empty list otherwise.
309 * Scripts/webkitpy/port/driver_unittest.py:
310 (DriverTest.make_port): Adjusted so mock host or options objects can be specified
311 for the testing-specific Port object.
312 (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
313 as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
315 (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
316 when profiling on the Linux platform with the perf profiler.
318 2013-09-14 Dan Bernstein <mitz@apple.com>
320 [mac] Check For Framework Include Consistency build phase checks the wrong framework
321 https://bugs.webkit.org/show_bug.cgi?id=121215
323 Reviewed by Mark Rowe.
325 * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
326 WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
327 public and private headers folder paths. Also tweaked the error messages’ format to make
328 Xcode recognize them as errors.
330 2013-09-14 Alberto Garcia <berto@igalia.com>
332 [GTK] Fails to compile if the build directory is in a different partition
333 https://bugs.webkit.org/show_bug.cgi?id=121296
335 Reviewed by Martin Robinson.
337 Instead of using os.symlink() to install the gtk-doc templates,
338 use os.link() first and fall back to os.symlink() if it fails.
341 (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
343 2013-09-14 Alberto Garcia <berto@igalia.com>
345 [GTK] WebKitGTK+ is linking against libxslt in too many places
346 https://bugs.webkit.org/show_bug.cgi?id=121356
348 Reviewed by Martin Robinson.
350 TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
351 so we don't need to link against it.
353 * MiniBrowser/gtk/GNUmakefile.am:
354 * TestWebKitAPI/GNUmakefile.am:
355 * WebKitTestRunner/GNUmakefile.am:
357 2013-09-14 Ross Burton <ross.burton@intel.com>
359 Uses gtk-doc tools even when --disable-gtk-doc passed
360 https://bugs.webkit.org/show_bug.cgi?id=91239
362 Reviewed by Martin Robinson.
364 Don't run generate-gtkdoc on install if gtk-doc is disabled.
368 2013-09-14 Alberto Garcia <berto@igalia.com>
370 [GTK] Fails to compile if the build directory is in a different partition
371 https://bugs.webkit.org/show_bug.cgi?id=121296
373 Reviewed by Carlos Garcia Campos.
375 Use symlinks instead of hard links to support building on a
376 different file system.
379 (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
381 2013-09-13 Darin Adler <darin@apple.com>
383 Use a better name than m_invertibleCTM
384 https://bugs.webkit.org/show_bug.cgi?id=121341
386 Reviewed by Andreas Kling.
388 * Scripts/do-webcore-rename: Updated to do this replace as we do.
390 2013-09-13 Anders Carlsson <andersca@apple.com>
392 Pick the correct overload when a const reference is passed to appendSlowCase.
393 https://bugs.webkit.org/show_bug.cgi?id=121326
395 Reviewed by Darin Adler.
397 * TestWebKitAPI/Tests/WTF/Vector.cpp:
398 (TestWebKitAPI::TEST):
400 2013-09-13 Darin Adler <darin@apple.com>
402 Rename confusingly named "runtimeObject" functions
403 https://bugs.webkit.org/show_bug.cgi?id=121339
405 Reviewed by Sam Weinig.
407 * Scripts/do-webcore-rename: Updated to do this replace as usual.
409 2013-09-13 Filip Pizlo <fpizlo@apple.com>
411 DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
412 https://bugs.webkit.org/show_bug.cgi?id=121330
414 Reviewed by Mark Hahnenberg and Oliver Hunt.
416 We should run tests even if they don't have expected files yet.
418 * Scripts/run-layout-jsc:
420 2013-09-13 Anders Carlsson <andersca@apple.com>
422 Use nullptr instead of 0 in calls to HashMap::add
423 https://bugs.webkit.org/show_bug.cgi?id=121322
425 Reviewed by Sam Weinig.
427 * DumpRenderTree/mac/TestRunnerMac.mm:
428 (TestRunner::evaluateScriptInIsolatedWorld):
429 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
430 (WTR::TestRunner::evaluateScriptInIsolatedWorld):
432 2013-09-13 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
434 [GTK] Move to the new web inspector
435 https://bugs.webkit.org/show_bug.cgi?id=120647
437 Reviewed by Carlos Garcia Campos.
439 * GtkLauncher/main.c:
440 (main): no longer set WEBKIT_INSPECTOR_PATH.
441 * MiniBrowser/gtk/main.c:
443 * Scripts/old-run-webkit-tests:
444 (openDumpTool): ditto.
445 * Scripts/run-gtk-tests: ditto.
446 * Scripts/webkitpy/port/gtk.py:
447 (GtkPort.setup_environ_for_server): ditto.
449 2013-09-13 Allan Sandfeld Jensen <allan.jensen@digia.com>
451 [Qt] REGRESSION(r154444): xss-DENIED test results changed
452 https://bugs.webkit.org/show_bug.cgi?id=120595
454 Reviewed by Jocelyn Turcotte.
456 Avoid overwriting Qt meta properties, which we identify by them being undeletable.
458 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
459 (DumpRenderTree::initJSObjects):
461 2013-09-13 Darin Adler <darin@apple.com>
463 Give actions in Range class NON_SHOUTING_NAMES
464 https://bugs.webkit.org/show_bug.cgi?id=121280
466 Reviewed by Andreas Kling.
468 * Scripts/do-webcore-rename: Updated to do this replace, keeping with
469 the tradition of checking in the last one we did, along with other
470 rename ideas for the future.
472 2013-09-12 Lucas Forschler <lforschler@apple.com>
474 Create short build logs for errors and warnings.
475 https://bugs.webkit.org/show_bug.cgi?id=120614
477 Reviewed by Ryosuke Niwa.
479 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
481 (CompileWebKit.createSummary):
482 -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
484 2013-09-12 Roger Fong <roger_fong@apple.com>
486 Update cygwin downloader to search for packages in the right location.
488 * CygwinDownloader/cygwin-downloader.py:
489 * CygwinDownloader/cygwin-downloader.zip:
491 2013-09-12 Anders Carlsson <andersca@apple.com>
493 Add rudimentary support for move-only types as values in HashMap
494 https://bugs.webkit.org/show_bug.cgi?id=121226
496 Reviewed by Andreas Kling.
498 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
499 (TestWebKitAPI::TEST):
500 Add a HashMap<unsigned, MoveOnly> test.
502 2013-09-12 Gabor Abraham <abrhm@inf.u-szeged.hu>
504 Auto GDB backtrace generation for EFL/GTK/Qt bots.
505 https://bugs.webkit.org/show_bug.cgi?id=119338
507 Reviewed by Csaba Osztrogonác.
509 * Scripts/webkitpy/port/efl.py:
510 (EflPort.check_sys_deps):
512 (EflPort._get_crash_log):
513 * Scripts/webkitpy/port/efl_unittest.py:
514 (EflPortTest.test_show_results_html_file):
516 (EflPortTest.test_get_crash_log):
517 * Scripts/webkitpy/port/gtk.py:
518 (GtkPort._get_crash_log):
519 * Scripts/webkitpy/port/gtk_unittest.py:
520 (GtkPortTest.test_get_crash_log):
521 * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
522 (GDBCrashLogGenerator):
523 (GDBCrashLogGenerator.__init__):
524 (GDBCrashLogGenerator._get_gdb_output):
525 (GDBCrashLogGenerator.generate_crash_log):
526 (GDBCrashLogGenerator.generate_crash_log.match_filename):
527 * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
528 (GDBCrashLogGeneratorTest):
529 (GDBCrashLogGeneratorTest.test_generate_crash_log):
531 * Scripts/webkitpy/port/qt.py:
532 (QtPort.default_child_processes):
534 (QtPort._get_crash_log):
535 * Scripts/webkitpy/port/qt_unittest.py:
536 (QtPortTest.test_check_sys_deps):
538 (QtPortTest.test_get_crash_log):
540 2013-09-12 Peter Gal <galpeter@inf.u-szeged.hu>
542 Unreviewed. Moving myself to the commiters list.
544 * Scripts/webkitpy/common/config/contributors.json:
546 2013-09-12 ChangSeok Oh <changseok.oh@collabora.com>
548 [GTK] Add jhbuild-wayland.modules
549 https://bugs.webkit.org/show_bug.cgi?id=120455
551 Reviewed by Gustavo Noronha Silva.
553 Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
554 With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
555 WEBKIT_EXTRA_MODULESETS.
557 * gtk/jhbuild-wayland.modules: Added.
559 2013-09-12 Mario Sanchez Prada <mario.prada@samsung.com>
561 [GTK][WK2] a11y tests unconditionally launching a11y daemons
562 https://bugs.webkit.org/show_bug.cgi?id=120299
564 Reviewed by Carlos Garcia Campos.
566 Use the right variable name to store a reference to the at-spi2
567 bus launcher process, so we can be sure we are terminating it when
568 calling _tear_down_testing_environment().
570 * Scripts/run-gtk-tests:
571 (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
572 instead of _ally_bus_launcher.
574 2013-09-12 Carlos Garcia Campos <cgarcia@igalia.com>
576 [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
577 https://bugs.webkit.org/show_bug.cgi?id=121218
579 Reviewed by Philippe Normand.
581 Skipping the entire suite was added to skip tests when they can't
582 be run because of the environment, for example to skip the a11y
583 tests when the at-spi daemons fail to start. This is no longer
584 true for all the cases, so we can disable the tests that are
585 impossible to run instead of skipping them.
587 * Scripts/run-gtk-tests:
588 (TestRunner.__init__): Initialize the skipped tests list.
589 (TestRunner._setup_testing_environment): Add
590 TestWebKitAccessibility path to the list of disabled tests when
591 at-spi daemon fail to start.
592 (TestRunner._should_run_test_program): Check first if the test
593 program is disabled and then whether it's skipped honoring the
594 skipped command line option.
596 2013-09-12 Samuel White <samuel_white@apple.com>
598 <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
599 https://bugs.webkit.org/show_bug.cgi?id=117651
601 Reviewed by Mario Sanchez Prada.
603 Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
605 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
606 (AccessibilityUIElement::valueDescription):
607 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
608 (WTR::AccessibilityUIElement::valueDescription):
610 2013-09-12 Denis Nomiyama <d.nomiyama@samsung.com>
612 REGRESSION(r154781): accessibility/notification-listeners.html is failing
613 https://bugs.webkit.org/show_bug.cgi?id=120669
615 Reviewed by Chris Fleizach.
617 Fixed 4 problems that were causing notification-listeners.html to fail.
619 Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
620 implemented in axObjectEventListener().
622 A notification for AXFocusedUIElementChanged was incorrectly sent when
623 the element lost focus.
625 Global notification was not dispatched if an element notification was
626 present in the HashMap.
628 connectAccessibilityCallbacks() was connecting signals to callbacks
629 multiple times because it was not checking if
630 disconnectAccessibilityCallbacks() had an early return if there were
633 * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
634 disconnectAccessibilityCallbacks() to inform if the callbacks were
635 successfully disconnected.
636 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
637 (axObjectEventListener): Implemented notifications for
638 AXFocusedUIElementChanged and AXValueChanged. Fixed the global
639 notification, which was not dispatched if an element notification
640 existed. Fixed the notification for AXFocusedUIElementChanged that was
641 incorrectly sent when the element lost focus. In addition, fixed a typo
642 where TRUE should be true.
643 (connectAccessibilityCallbacks): Added early return if
644 disconnectAccessibilityCallbacks() did not disconnect the callbacks.
645 (disconnectAccessibilityCallbacks): Added a return value to inform if
646 callbacks were successfully disconnected.
648 2013-09-11 Anders Carlsson <andersca@apple.com>
650 Try to fix GCC builds.
652 * TestWebKitAPI/Tests/WTF/MoveOnly.h:
654 2013-09-11 Anders Carlsson <andersca@apple.com>
656 Try to fix the build.
658 Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
659 file in the Tests/ directory in the first place.
661 * TestWebKitAPI/CMakeLists.txt:
662 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
663 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
664 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
665 * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
667 2013-09-11 Brent Fulgham <bfulgham@apple.com>
669 [Windows] Build fix for MoveOnly
671 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
672 Tests to include search path.
673 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
676 2013-09-11 Anders Carlsson <andersca@apple.com>
679 https://bugs.webkit.org/show_bug.cgi?id=121192
681 Reviewed by Darin Adler.
683 Add a test for HashSet::take.
685 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
686 (TestWebKitAPI::TEST):
688 2013-09-11 Anders Carlsson <andersca@apple.com>
690 HashSet should work with move only types
691 https://bugs.webkit.org/show_bug.cgi?id=121188
693 Reviewed by Geoffrey Garen.
695 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
696 * TestWebKitAPI/Tests/MoveOnly.h: Added.
697 Move the MoveOnly class from Vector out into its own header.
699 * TestWebKitAPI/Tests/WTF/HashSet.cpp:
700 (TestWebKitAPI::TEST):
701 Add aHashSet<MoveOnly> test.
703 * TestWebKitAPI/Tests/WTF/Vector.cpp:
706 2013-09-11 Brent Fulgham <bfulgham@apple.com>
708 [Windows] Avoid converting from IntSize->SIZE->IntSize
709 https://bugs.webkit.org/show_bug.cgi?id=121180
711 Reviewed by Anders Carlsson.
713 * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
714 (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
716 2013-09-11 Dan Bernstein <mitz@apple.com>
718 REGRESSION (r155561): extract-localizable-strings can miss strings
719 https://bugs.webkit.org/show_bug.cgi?id=121184
721 Reviewed by Darin Adler.
723 * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
724 parenthesis or bracket.
726 2013-09-11 Dan Bernstein <mitz@apple.com>
728 update-webkit-localizable-strings is at least 5.8x slower than it should be
729 https://bugs.webkit.org/show_bug.cgi?id=121178
731 Reviewed by Darin Adler.
733 * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
734 Note that this does not change functionality, because the script already does not understand
735 the line continuation sequence (backslash followed by a newline).
737 2013-09-11 Anders Carlsson <andersca@apple.com>
739 Vector::append doesn't work if element type has overloaded operator&
740 https://bugs.webkit.org/show_bug.cgi?id=121175
742 Reviewed by Brent Fulgham.
746 * TestWebKitAPI/Tests/WTF/Vector.cpp:
747 (TestWebKitAPI::TEST):
749 2013-09-11 Anders Carlsson <andersca@apple.com>
751 Implement Vector::append for move-only types
752 https://bugs.webkit.org/show_bug.cgi?id=120805
754 Reviewed by Sam Weinig.
756 Add a test for Vector<MoveOnly>::append.
758 * TestWebKitAPI/Tests/WTF/Vector.cpp:
759 (TestWebKitAPI::TEST):
761 2013-09-11 Csaba Osztrogonác <ossy@webkit.org>
763 Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
765 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
766 (RunAndUploadPerfTests):
767 (RunAndUploadPerfTests.start):
768 (RunAndUploadPerfTests.getText2):
770 2013-09-11 Anders Carlsson <andersca@apple.com>
772 The style checker shouldn't complain about returning or passing OwnPtr
773 https://bugs.webkit.org/show_bug.cgi?id=121163
775 Reviewed by Antti Koivisto.
777 * Scripts/webkitpy/style/checkers/cpp.py:
778 (check_function_definition_and_pass_ptr):
779 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
780 (PassPtrTest.test_pass_ref_ptr_return_value):
781 (PassPtrTest.test_own_ptr_parameter_value):
783 2013-09-11 Mario Sanchez Prada <mario.prada@samsung.com>
785 [GTK] Remove Gail dependency from build system for GTK3
786 https://bugs.webkit.org/show_bug.cgi?id=119673
788 Reviewed by Gustavo Noronha Silva.
790 * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
791 * Scripts/webkitpy/port/gtk.py:
792 (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
793 * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
795 2013-09-11 Gabor Abraham <abrhm@inf.u-szeged.hu>
797 Performance tester bots should report the number of failing tests
798 https://bugs.webkit.org/show_bug.cgi?id=120462
800 Reviewed by Csaba Osztrogonác.
802 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
803 (RunAndUploadPerfTests.start.getText):
804 (RunAndUploadPerfTests.start):
805 (RunAndUploadPerfTests):
806 (RunAndUploadPerfTests.start.getText2):
808 2013-09-11 Krzysztof Czech <k.czech@samsung.com>
810 [ATK] Adds mapping MenuItemRadioRole to ATK
811 https://bugs.webkit.org/show_bug.cgi?id=121149
813 Reviewed by Mario Sanchez Prada.
815 Adds mapping MenuItemRadioRole to ATK.
817 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
819 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
822 2013-09-10 Csaba Osztrogonác <ossy@webkit.org>
824 Unreviewed fix after the unreviewed r155498 to unbreak the failure
825 counter of run-javascriptcore-tests build step on build.webkit.org.
827 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
828 (RunJavaScriptCoreTests.commandComplete):
829 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
831 2013-09-10 Filip Pizlo <fpizlo@apple.com>
833 Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
834 got a bit overlooked from the fast/js->js refactoring.
836 * Scripts/run-javascriptcore-tests:
838 2013-09-10 Daniel Bates <dabates@apple.com>
840 [iOS] Upstream text autosizing
841 https://bugs.webkit.org/show_bug.cgi?id=121111
843 Reviewed by Andy Estes and Sam Weinig.
845 Implement infrastructure to test the iOS text autosizing code.
847 * DumpRenderTree/TestRunner.cpp:
848 (setTextAutosizingEnabledCallback): Added.
849 (TestRunner::staticFunctions):
850 * DumpRenderTree/TestRunner.h:
851 * DumpRenderTree/mac/DumpRenderTree.mm:
852 (resetDefaultsToConsistentValues):
853 * DumpRenderTree/mac/TestRunnerMac.mm:
854 (TestRunner::setTextAutosizingEnabled): Added.
856 2013-09-10 Mark Hahnenberg <mhahnenberg@apple.com>
858 run-jsc-stress-tests should have a mode for always running the copy phase
859 https://bugs.webkit.org/show_bug.cgi?id=121128
861 Reviewed by Geoffrey Garen.
863 This will increase test coverage of the copying phase, which might not always get
864 triggered normally with our default parameters for required Heap/CopiedBlock utilization.
866 * Scripts/run-jsc-stress-tests:
868 2013-09-10 Sergio Correia <sergio.correia@openbossa.org>
870 [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
871 https://bugs.webkit.org/show_bug.cgi?id=121114
873 Reviewed by Christophe Dumez.
875 Use a tarball for libseccomp instead of git to avoid network issues on
876 the buildbots while checking out the git repo. Using tarballs has the
877 advantage of them being cached if the checksum matches, in which case
878 there will be no need to download them again.
880 * efl/jhbuild.modules:
882 2013-09-10 Mark Lam <mark.lam@apple.com>
884 Replace remaining "fast js" names in scripts.
885 https://bugs.webkit.org/show_bug.cgi?id=120899.
887 Rubber stamped by Filip Pizlo.
889 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
890 (test_layout_failure_new_output):
891 (test_layout_crash_new_output):
892 (test_mozilla_and_layout_failure_new_output):
893 * Scripts/run-fast-jsc: Removed.
894 * Scripts/run-javascriptcore-tests:
895 * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
897 2013-09-10 Zan Dobersek <zdobersek@igalia.com>
899 Enable JSC stress tests for the rest of non-Windows platforms
900 https://bugs.webkit.org/show_bug.cgi?id=121021
902 Reviewed by Filip Pizlo.
904 The JSC stress tests can already be enabled on Linux-based ports.
906 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
907 (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
908 JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
909 complete output, with the number of failing or crashing tests properly extracted.
910 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
911 output in other unit tests testing the parsing of the output in the new format.
912 (test_jsc_stress_failure_new_output):
913 (test_fast_js_crashes_and_jsc_stress_failures_new_output):
914 * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
915 * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
916 variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
917 of available CPUs so the stress tests can be run in parallel.
919 2013-09-10 Chris Fleizach <cfleizach@apple.com>
921 AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
922 https://bugs.webkit.org/show_bug.cgi?id=120552
924 Unreviewed build fix.
926 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
927 (AccessibilityUIElement::classList):
929 2013-09-10 Chris Fleizach <cfleizach@apple.com>
931 AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
932 https://bugs.webkit.org/show_bug.cgi?id=120552
934 Reviewed by Darin Adler.
936 * DumpRenderTree/AccessibilityUIElement.cpp:
937 (getClassListCallback):
938 (AccessibilityUIElement::getJSClass):
939 * DumpRenderTree/AccessibilityUIElement.h:
940 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
941 (AccessibilityUIElement::classList):
942 * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
943 (AccessibilityUIElement::classList):
944 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
945 (AccessibilityUIElement::classList):
946 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
947 (AccessibilityUIElement::classList):
948 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
949 (WTR::AccessibilityUIElement::classList):
950 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
951 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
952 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
953 (WTR::AccessibilityUIElement::classList):
954 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
955 (WTR::AccessibilityUIElement::classList):
957 2013-09-10 Denis Nomiyama <d.nomiyama@samsung.com>
959 [GTK] accessibility/loading-iframe-sends-notification.html is failing
960 https://bugs.webkit.org/show_bug.cgi?id=98370
962 Reviewed by Chris Fleizach.
964 Added AXLayoutComplete for the GTK platform.
966 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
967 (axObjectEventListener): Added notification AXLayoutComplete for
968 layout-complete signal.
970 2013-09-09 Brent Fulgham <bfulgham@apple.com>
972 [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
973 https://bugs.webkit.org/show_bug.cgi?id=120778
975 Reviewed by Anders Carlsson.
977 * DumpRenderTree/win/PixelDumpSupportWin.cpp:
978 (createBitmapContextFromWebView): Use GDIObject.
979 * Scripts/webkitpy/style/checkers/cpp.py:
980 (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
981 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
982 (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
983 (LeakyPatternTest.test_create_compatible_dc): Ditto.
985 2013-09-10 Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
987 Unreviewed. Add myself as a committer.
989 * Scripts/webkitpy/common/config/contributors.json:
991 2013-09-10 Mark Lam <mark.lam@apple.com>
993 Move LayoutTests/fast/js to LayoutTests/js.
994 https://bugs.webkit.org/show_bug.cgi?id=120899.
996 Rubber stamped by Filip Pizlo.
998 Changed scripts to reflect the path change.
1000 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1001 (RunJavaScriptCoreTests.commandComplete):
1002 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1003 (test_fast_js_failure_new_output):
1004 (test_fast_js_crash_new_output):
1005 (test_mozilla_and_fast_js_failure_new_output):
1006 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1007 (BlackBerry::WebKit::DumpRenderTree::runTests):
1008 * Scripts/make-script-test-wrappers:
1009 (findTemplateFiles):
1010 * Scripts/run-fast-jsc:
1011 * Scripts/run-javascriptcore-tests:
1012 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1015 2013-09-10 Denis Nomiyama <d.nomiyama@samsung.com>
1017 [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
1018 https://bugs.webkit.org/show_bug.cgi?id=70606
1020 Reviewed by Mario Sanchez Prada.
1022 Implemented the global notification listener for
1023 AccessibilityController. The signal is generated by
1024 AXObjectCache::postPlatformNotification() and received by
1025 axObjectEventListener(). axObjectEventListener will then invoke
1026 JSObjectCallAsFunction() with the respective callback function.
1028 There is no additional test for this patch since its implementation will
1029 be tested by a11y layout tests that are currently skipped (e.g. bug
1032 * DumpRenderTree/AccessibilityController.h: Added a global notification
1034 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1035 (AccessibilityController::AccessibilityController): Initializes the
1036 global handler with 0.
1037 (AccessibilityController::addNotificationListener): Creates the
1038 notification handler and sets the notification function callback.
1039 (AccessibilityController::removeNotificationListener): Removes the
1042 2013-09-10 Krzysztof Czech <k.czech@samsung.com>
1044 [ATK] Incorrect type for holding float value
1045 https://bugs.webkit.org/show_bug.cgi?id=121091
1047 Reviewed by Mario Sanchez Prada.
1049 Variable is not set properly, because of it's type.
1051 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1052 (WTR::alterCurrentValue):
1054 2013-09-10 Allan Sandfeld Jensen <allan.jensen@digia.com>
1056 [Qt] make use of qtHaveModule()
1057 https://bugs.webkit.org/show_bug.cgi?id=121090
1059 Reviewed by Jocelyn Turcotte.
1060 Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
1062 Use qtHaveModule instead of our own haveQtModule.
1064 * QtTestBrowser/QtTestBrowser.pro:
1065 * qmake/mkspecs/features/configure.prf:
1066 * qmake/mkspecs/features/features.prf:
1067 * qmake/mkspecs/features/functions.prf:
1069 2013-09-10 Michał Pakuła vel Rutka <m.pakula@samsung.com>
1071 Unreviewed. Add myself as a committer.
1073 * Scripts/webkitpy/common/config/contributors.json:
1075 2013-09-10 Radu Stavila <stavila@adobe.com>
1077 Unreviewed. Added myself as a committer.
1079 * Scripts/webkitpy/common/config/contributors.json:
1081 2013-09-10 Mario Sanchez Prada <mario.prada@samsung.com>
1083 [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
1084 https://bugs.webkit.org/show_bug.cgi?id=105538
1086 Reviewed by Chris Fleizach.
1088 Unskip passing test getTextInParagraphAndBodyModerate.
1090 * Scripts/run-gtk-tests:
1091 (TestRunner): Unskip pasing test.
1093 2013-09-09 Mark Lam <mark.lam@apple.com>
1095 Remove more references to the deleted js-test-style.css.
1096 https://bugs.webkit.org/show_bug.cgi?id=120899.
1098 Reviewed by Ryosuke Niwa.
1100 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1101 (translate_includes):
1103 2013-09-09 Mark Lam <mark.lam@apple.com>
1105 Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
1106 https://bugs.webkit.org/show_bug.cgi?id=120899.
1110 The webkitpy test failure that resulted in the rollout is due to
1111 update_webgl_conformance_tests_unittest.py referencing js-test-style.css
1112 which is to be deleted. Deleting that line fixes the issue.
1114 * Scripts/make-new-script-test:
1115 (makePathToSharedSources):
1116 * Scripts/run-fast-jsc:
1117 * Scripts/webkitperl/httpd.pm:
1118 (getDefaultConfigForTestDirectory):
1119 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1120 (LayoutTestApacheHttpd.__init__):
1121 * Scripts/webkitpy/layout_tests/servers/http_server.py:
1122 (Lighttpd.__init__):
1123 * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1124 (BaseTest.integration_test_port_and_root):
1125 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1126 (TestHttpServer.test_start_cmd):
1127 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1128 (translate_includes):
1129 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1130 (TestTranslation.test_include_rewriting):
1132 2013-09-09 Mark Lam <mark.lam@apple.com>
1134 Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
1135 https://bugs.webkit.org/show_bug.cgi?id=120899.
1139 * Scripts/make-new-script-test:
1140 (makePathToSharedSources):
1141 * Scripts/run-fast-jsc:
1142 * Scripts/webkitperl/httpd.pm:
1143 (getDefaultConfigForTestDirectory):
1144 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1145 (LayoutTestApacheHttpd.__init__):
1146 * Scripts/webkitpy/layout_tests/servers/http_server.py:
1147 (Lighttpd.__init__):
1148 * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1149 (BaseTest.integration_test_port_and_root):
1150 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1151 (TestHttpServer.test_start_cmd):
1152 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1153 (translate_includes):
1154 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1155 (TestTranslation.test_include_rewriting):
1157 2013-09-09 Mark Lam <mark.lam@apple.com>
1159 Point Tools scripts to LayoutTests/resources.
1160 https://bugs.webkit.org/show_bug.cgi?id=120899.
1162 Reviewed by Ryosuke Niwa.
1164 * Scripts/make-new-script-test:
1165 (makePathToSharedSources):
1166 * Scripts/run-fast-jsc:
1167 * Scripts/webkitperl/httpd.pm:
1168 (getDefaultConfigForTestDirectory):
1169 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1170 (LayoutTestApacheHttpd.__init__):
1171 * Scripts/webkitpy/layout_tests/servers/http_server.py:
1172 (Lighttpd.__init__):
1173 * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
1174 (BaseTest.integration_test_port_and_root):
1175 * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1176 (TestHttpServer.test_start_cmd):
1177 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1178 (translate_includes):
1179 * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1180 (TestTranslation.test_include_rewriting):
1182 2013-09-09 Roger Fong <roger_fong@apple.com>
1184 Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
1186 * CygwinDownloader/cygwin-downloader.py:
1187 * CygwinDownloader/cygwin-downloader.zip:
1189 2013-09-09 Filip Pizlo <fpizlo@apple.com>
1191 Unreviewed, fix Ruby exception handling.
1193 * Scripts/run-jsc-stress-tests:
1195 2013-09-09 Filip Pizlo <fpizlo@apple.com>
1197 Stress tests should test the jsc profiler (-p)
1198 https://bugs.webkit.org/show_bug.cgi?id=121043
1200 Reviewed by Mark Hahnenberg.
1202 Add a runProfiler command that all tests could use. This requires profiler-test-helper,
1203 which first runs the JS test and then tries the output with display-profiler-output.
1204 But if any of the things required for this to work aren't present, we just do a simpler
1205 test that just uses "-p".
1207 Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
1208 to create test collections using a yaml file that specifies the test path and the
1211 * Scripts/jsc-stress-test-helpers: Added.
1212 * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
1213 * Scripts/run-javascriptcore-tests:
1214 * Scripts/run-jsc-stress-tests:
1216 2013-09-09 Zan Dobersek <zdobersek@igalia.com>
1218 [webkitpy] Remove the DeprecatedPort class
1219 https://bugs.webkit.org/show_bug.cgi?id=121030
1221 Reviewed by Ryosuke Niwa.
1223 Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
1225 The various methods returning commands are moved from the DeprecatedPort class into the Port class,
1226 with the Port subclasses overriding specific methods as required.
1228 * Scripts/webkitpy/common/config/ports.py: Removed.
1229 * Scripts/webkitpy/common/config/ports_mock.py: Removed.
1230 * Scripts/webkitpy/common/config/ports_unittest.py: Removed.
1231 * Scripts/webkitpy/port/base.py:
1232 (Port.tooling_flag): This method returns the command line argument that corresponds to the type of the port.
1233 It's formatted as '--port=port_name', where port_name is the port's name that's additionally appended the '-wk2'
1234 string if the port instance represents the WK2 variation of the port.
1235 (Port.script_shell_command): Moved here from the DeprecatedPort interface.
1236 (Port.make_args): Ditto.
1237 (Port.update_webkit_command): Ditto.
1238 (Port.check_webkit_style_command): Ditto.
1239 (Port.prepare_changelog_command): Ditto.
1240 (Port.build_webkit_command): Ditto.
1241 (Port.run_javascriptcore_tests_command): Ditto.
1242 (Port.run_webkit_unit_tests_command): Ditto.
1243 (Port.run_webkit_tests_command): Ditto.
1244 (Port.run_python_unittests_command): Ditto.
1245 (Port.run_perl_unittests_command): Ditto.
1246 (Port.run_bindings_tests_command): Ditto.
1247 * Scripts/webkitpy/port/base_unittest.py:
1248 (PortTest.test_build_webkit_command): Add a test for the Port.build_webkit_command() method that tests correct
1249 return value with different build types passed to the method.
1250 * Scripts/webkitpy/port/efl.py:
1251 (EflPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
1252 to the command line.
1253 * Scripts/webkitpy/port/efl_unittest.py:
1254 (EflPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
1255 variations of the EflPort class.
1256 * Scripts/webkitpy/port/gtk.py:
1257 (GtkPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
1258 to the command line.
1259 (GtkPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
1260 * Scripts/webkitpy/port/gtk_unittest.py:
1261 (GtkPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1
1262 and WK2 variations of the GtkPort class.
1263 * Scripts/webkitpy/port/mac_unittest.py:
1264 (MacTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
1265 variations of the MacPort class.
1266 * Scripts/webkitpy/port/qt.py:
1267 (QtPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
1268 to the command line.
1269 (QtPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
1270 * Scripts/webkitpy/port/qt_unittest.py:
1271 (QtPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
1272 variations of the QtPort class.
1273 * Scripts/webkitpy/port/test.py:
1274 (TestPort.make_args): Return a mock value that's intended for testing.
1275 (TestPort.check_webkit_style_command): Return the script's name prepended with 'mock-'.
1276 (TestPort.update_webkit_command): Ditto.
1277 (TestPort.build_webkit_command): Ditto.
1278 (TestPort.prepare_changelog_command): Ditto.
1279 (TestPort.run_python_unittests_command): Ditto.
1280 (TestPort.run_perl_unittests_command): Ditto.
1281 (TestPort.run_javascriptcore_tests_command): Ditto.
1282 (TestPort.run_webkit_unit_tests_command): Ditto.
1283 (TestPort.run_webkit_tests_command): Ditto.
1284 (TestPort.run_bindings_tests_command): Ditto.
1285 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1286 (FlakyTestReporter.__init__): WebKitPatch.port() should be called now.
1287 * Scripts/webkitpy/tool/bot/irc_command.py:
1288 (Rollout._update_working_copy): Ditto.
1289 * Scripts/webkitpy/tool/commands/download_unittest.py:
1290 (DownloadCommandsTest.test_land_cowhand): Fix a typo, javacriptcore -> javascriptcore.
1291 * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1292 (AbstractEarlyWarningSystem.run_command): Use the tooling flag as provided by the Port interface.
1293 * Scripts/webkitpy/tool/commands/queues.py:
1294 (PatchProcessingQueue.begin_work_queue): Remove the use of the DeprecatedPort. Create the port that will be used
1295 by the PatchProcessingQueue through the tool's port factory, and also pass it to the tool, keeping the nasty
1296 abstraction violation.
1297 (CommitQueue.run_command): Use the tooling flag as provided by the Port interface.
1298 * Scripts/webkitpy/tool/main.py:
1299 (WebKitPatch.__init__): self._deprecated_port -> self._port.
1300 (WebKitPatch.port): Replaces the WebKitPatch.deprecated_port() method, returns self._port.
1301 (WebKitPatch.handle_global_options): Create the Port object through the PortFactory.
1302 * Scripts/webkitpy/tool/mocktool.py:
1303 (MockTool.__init__): self._deprecated_port -> self._port. The TestPort object also has its name method overridden
1304 to return 'MockPort', as many output comparisons rely on the MockPort name. These should all be replaced later, in
1306 (MockTool.port): Mimicks WebKitPatch.port().
1307 * Scripts/webkitpy/tool/steps/build.py:
1308 (Build.build): WebKitPatch.port() should be called now.
1309 * Scripts/webkitpy/tool/steps/checkstyle.py:
1310 (CheckStyle.run): Ditto.
1311 * Scripts/webkitpy/tool/steps/commit.py:
1312 (Commit._check_test_expectations): Ditto.
1313 * Scripts/webkitpy/tool/steps/preparechangelog.py:
1314 (PrepareChangeLog.run): Ditto.
1315 * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1316 (PrepareChangeLogForRevert.run): Ditto.
1317 * Scripts/webkitpy/tool/steps/runtests.py:
1318 (RunTests.run): Ditto.
1319 * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1320 (RunTestsTest.test_webkit_run_unit_tests): The unnecessary methods should now be overridden on MockTool._port.
1321 * Scripts/webkitpy/tool/steps/steps_unittest.py:
1322 (StepsTest.test_runtests_args): Remove the MockTool._deprecated_port override, but don't replace it. Rather than
1323 that the expected test output is adjusted to contain the mock-* command names.
1324 * Scripts/webkitpy/tool/steps/update.py:
1325 (Update._update_command): WebKitPatch.port() should be called now.
1326 * Scripts/webkitpy/tool/steps/update_unittest.py:
1327 (UpdateTest.test_update_command_non_interactive): Override the MockTool._port for testing purposes with the port
1328 that corresponds to the removed DeprecatedPort subclasses.
1329 (UpdateTest.test_update_command_interactive): Ditto.
1331 2013-09-09 Zan Dobersek <zdobersek@igalia.com>
1333 [GTK] 32-bit builder should run the JSC tests
1334 https://bugs.webkit.org/show_bug.cgi?id=119215
1336 Reviewed by Philippe Normand.
1338 Rename the TestClass member of the TestFactory and BuildAndTestFactory classes
1339 to a more descriptive name, 'LayoutTestClass'. In these two factory classes, the layout testing-specific
1340 steps are only added if the LayoutTestClass member was not overridden to the value of None in a
1343 Remove the BuildAndAPITestFactory class and replace it with the BuildAndNonLayoutTestFactory class that
1344 is derived from the BuildAndTestFactory class and overrides the LayoutTestClass member to the value of None.
1345 This allows for builders of the BuildAndNonLayoutTest type to run all but the layout tests. This type
1346 is currently used by the GTK 32-bit builder - there's at the moment no interest to have the builder cover
1347 layout testing while other types of testing are still expected to be performed.
1349 * BuildSlaveSupport/build.webkit.org-config/config.json:
1350 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1351 (BuildFactory.__init__):
1353 (TestFactory.__init__):
1354 (BuildAndTestFactory):
1355 (BuildAndTestFactory.__init__):
1356 (BuildAndTestWebKit2Factory):
1357 (BuildAndTestWebKit2OnlyFactory):
1358 (BuildAndNonLayoutTestFactory):
1360 (TestWebKit2Factory):
1362 2013-09-09 Manuel Rego Casasnovas <rego@igalia.com>
1364 Unreviewed. Add myself as a committer.
1366 * Scripts/webkitpy/common/config/contributors.json:
1368 2013-09-09 Krzysztof Czech <k.czech@samsung.com>
1370 [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
1371 https://bugs.webkit.org/show_bug.cgi?id=121023
1373 Reviewed by Mario Sanchez Prada.
1375 Added mappings to ATK's ProgressBar element.
1377 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1379 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1380 (WTR::roleToString):
1382 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1384 run-jsc-stress-tests should be more paranoid about calling make
1385 https://bugs.webkit.org/show_bug.cgi?id=121011
1387 Reviewed by Oliver Hunt.
1389 If it returns with any kind of error then bail out. Also print the command being used
1390 in case we have to debug this, for example on the bots. The extra verbosity isn't a
1393 * Scripts/run-jsc-stress-tests:
1395 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1397 Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
1398 like that. Pass a string instead.
1400 * Scripts/run-jsc-stress-tests:
1402 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1404 run-jsc-stress-tests should run tests in parallel if possible
1405 https://bugs.webkit.org/show_bug.cgi?id=120996
1407 Reviewed by Oliver Hunt.
1409 Run tests in parallel by using Makefile hacks. This lets make take care of all load
1410 balancing. It's a really awesome speed-up for these tests.
1412 This reduces the FTL debug build stress test run time from 8m18s to 2m11s. The
1413 no-FTL debug build stress test time goes from 1m11s to 16s. This patch is pretty
1416 * Scripts/run-jsc-stress-tests:
1418 2013-09-08 Filip Pizlo <fpizlo@apple.com>
1420 run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
1421 https://bugs.webkit.org/show_bug.cgi?id=120994
1423 Reviewed by Geoffrey Garen.
1425 run-jsc-stress-tests accepts a list of directories containing tests. It needs to
1426 come up with names for all of them. Currently it uses the basename of the test
1427 directory. But that means that JSRegress gets called "script-tests", which is
1428 unfortunate since any directory in LayoutTests containing .js files will be
1429 called "script-tests". So, this changes run-jsc-stress-tests to use more than
1430 just the basename if the basename has the word "tests" in it. This causes
1431 JSRegress to be called "regress/script-tests".
1433 * Scripts/run-jsc-stress-tests:
1435 2013-09-08 Sergio Correia <sergio.correia@openbossa.org>
1437 [EFL][JHBUILD] Fix evas build with giflib5
1438 https://bugs.webkit.org/show_bug.cgi?id=120863
1440 Original patch from Doug Newgard, at https://phab.enlightenment.org/D200.
1442 Reviewed by Anders Carlsson.
1444 * efl/jhbuild.modules: Apply patch to fix evas build with giflib5.
1445 * efl/patches/evas-fix-build-with-giflib5.patch: Added.
1447 2013-09-07 Filip Pizlo <fpizlo@apple.com>
1449 Only run FTL tests if we have the FTL
1450 https://bugs.webkit.org/show_bug.cgi?id=120974
1452 Reviewed by Geoffrey Garen.
1454 Pass --ftl-jit down into run-jsc-stress-tests so that it knows what test
1457 * Scripts/build-jsc:
1458 * Scripts/run-javascriptcore-tests:
1459 * Scripts/run-jsc-stress-tests:
1461 2013-09-07 Santosh Mahto <santosh.ma@samsung.com>
1463 removing --dialog-element from build-webkit --help option message
1464 https://bugs.webkit.org/show_bug.cgi?id=120955
1466 Reviewed by Daniel Bates.
1468 --dialog-element option is useless while building as
1469 Dialog Element support has been removed in following changeset.
1470 http://trac.webkit.org/changeset/154835
1471 http://trac.webkit.org/changeset/154870
1473 * Scripts/webkitperl/FeatureList.pm:
1474 Removed --dialog-element option message.
1476 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1478 It should be possible to run-javascriptcore-tests with only a subset of the test suites
1479 https://bugs.webkit.org/show_bug.cgi?id=120918
1481 Reviewed by Dan Bernstein.
1483 * Scripts/run-javascriptcore-tests:
1485 2013-09-06 Commit Queue <commit-queue@webkit.org>
1487 Unreviewed, rolling out r155196.
1488 http://trac.webkit.org/changeset/155196
1489 https://bugs.webkit.org/show_bug.cgi?id=120919
1491 Broke 16 tests on build.webkit.org (Requested by rniwa on
1494 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1495 (Manager._set_up_run):
1497 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1499 The 'failed' file should report collectionName/testName rather than just
1502 Rubber stamped by Mark Hahnenberg.
1504 * Scripts/run-jsc-stress-tests:
1506 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1508 Fix run-jsc-stress-tests to run on bots with old Ruby.
1510 Also make it create a repro file.
1512 Rubber stamped by Mark Hahnenberg.
1514 * Scripts/run-jsc-stress-tests:
1516 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1518 Actually increment $numFailures
1520 Reviewed by Mark Hahnenberg.
1522 * Scripts/run-jsc-stress-tests:
1524 2013-09-06 Filip Pizlo <fpizlo@apple.com>
1526 Fix run-jsc-stress-tests to use Pathname instead of File.realpath.
1528 Also make it uses system() instead of popen(); that means that test output
1529 will go to the console. This reduces error detection flakiness. It's fine
1530 because stress tests don't print() unless they really have to.
1532 Rubber stamped by Mark Hahnenberg.
1534 * Scripts/run-jsc-stress-tests:
1536 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1538 Introduce a way to run benchmarks and JSRegress as stress tests with different jsc command-line options
1539 https://bugs.webkit.org/show_bug.cgi?id=120808
1541 Reviewed by Mark Hahnenberg and rubber stamped by Geoffrey Garen.
1543 Add a script for running stress tests. A stress test is a .js file that is run
1544 through different configurations of JSC. It can control which configurations it
1545 runs by using "//@ <ruby code>" to guide the script.
1547 This script is now run as part of run-javascriptcore-tests, on Mac only.
1549 * Scripts/run-javascriptcore-tests:
1550 * Scripts/run-jsc-stress-tests: Added.
1552 2013-09-06 Mario Sanchez Prada <mario.prada@samsung.com>
1554 [GTK] Desktop proxy settings are ignored inside the internal jhbuild
1555 https://bugs.webkit.org/show_bug.cgi?id=120833
1557 Reviewed by Gustavo Noronha Silva.
1559 Add dconf as an optional module for the internal jhbuild, along
1560 with vala 0.17 as a dependency, and make sure we do not explicitly
1561 set always the 'memory' backend, so we can have an easy way to
1562 allow apps access desktop settings from the jhbuild. This is
1563 useful for example to be able to run apps such as MiniBrowser
1564 inside the jhbuild (by means of run-launcher, for instance) while
1565 working behind a proxy, since those network settings have to be
1566 read from the system global configuration in org.gnome.system.proxy.
1568 * gtk/jhbuild-optional.modules: Added dconf 0.14 and vala 0.17.
1569 * gtk/jhbuildrc: Do not explicitly choose the GSettings memory
1570 backend here, since that will make more difficult to use the dconf
1571 backend from inside the jhbuild if we need to do it so.
1573 2013-09-06 Alexey Proskuryakov <ap@apple.com>
1575 Lots of pixel tests are failing on first run, so tests cannot finish
1576 https://bugs.webkit.org/show_bug.cgi?id=120755
1578 Reviewed by Ryosuke Niwa.
1580 For whatever reason, many reftests are color profile sensitive, and we only set
1581 color profile to a known one for pixel tests, not for reftests.
1583 Pixel testing mode is also enabled when retrying tests, so these failures used to
1584 be essentially hidden - the tests were "flaky", but that was not reported loudly enough.
1585 But now, so many tests fail that it makes run-webkit-tests stop early, and never retry.
1587 This probably shouldn't happen, as reftests should not be color profile sensitive.
1588 The fix is a stopgap measure to unblock EWS until a better fix can be investigated.
1590 * Scripts/webkitpy/layout_tests/controllers/manager.py:
1591 (Manager._set_up_run): Roll out <http://trac.webkit.org/changeset/115601>.
1593 2013-09-06 Denis Nomiyama <d.nomiyama@samsung.com>
1595 [GTK] AccessibilityUIElement::addNotificationListener() crashes on debug build
1596 https://bugs.webkit.org/show_bug.cgi?id=120416
1598 Reviewed by Mario Sanchez Prada.
1600 Fixed crashes when running debug DRT. Simplified loops at AccessibilityCallbackAtk.cpp where the HashMap
1601 iterator was removed inside a loop. Fixed AccessibilityUIElement::addNotificationListener() where
1602 m_notificationHandler expected RefPtr.
1604 The global notification handler was stored in the HashMap with key 0. And this caused an assertion when
1605 HashMap::add() or find() are called. To fix it, moved the global handler to a separated pointer.
1607 * DumpRenderTree/atk/AccessibilityCallbacks.h: Removed the global notification key.
1608 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1609 (axObjectEventListener): Simplified the code by using HashMap::find() and a separate pointer for the
1610 global notification handler.
1611 (addAccessibilityNotificationHandler): Simplified the code by using HashMap::find() and a separate pointer
1612 for the global notification handler.
1613 (removeAccessibilityNotificationHandler): Added the removal for the global notification handler.
1614 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h:
1615 (AccessibilityNotificationHandler::create): Added static function to create
1616 AccessibilityNotificationHandler.
1617 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1618 (AccessibilityUIElement::addNotificationListener): Assigned m_notificationHandler with
1619 AccessibilityNotificationHandler::create().
1621 2013-09-06 Gabor Abraham <abrhm@inf.u-szeged.hu>
1623 [Qt] REGRESSION(r155140) Pixel tests is still broken on Qt with QT_WEBKIT_DISABLE_UIPROCESS_DUMPPIXELS=1
1624 https://bugs.webkit.org/show_bug.cgi?id=120847
1626 Reviewed by Csaba Osztrogonác.
1628 Move the force repaint code back to if (PlatformWebView::windowSnapshotEnabled()) block to support Qt.
1629 Typo fixed: windowShapshotEnabled -> windowSnapshotEnabled.
1630 Add a default PlatformWebView::windowSnapshotEnabled() to the !PLATFORM(QT).
1632 * WebKitTestRunner/PlatformWebView.h:
1633 (WTR::PlatformWebView::windowSnapshotEnabled):
1634 * WebKitTestRunner/TestInvocation.cpp:
1635 (WTR::TestInvocation::dumpResults):
1636 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1637 (WTR::WrapperWindow::handleStatusChanged):
1638 (WTR::PlatformWebView::windowSnapshotEnabled):
1639 * WebKitTestRunner/qt/TestInvocationQt.cpp:
1640 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1642 2013-09-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
1644 REGRESSION(r155140) Broke pixel tests on EFL/GTK/Qt
1645 https://bugs.webkit.org/show_bug.cgi?id=120843
1647 Reviewed by Csaba Osztrogonác.
1649 Call notifyDone like the platform specific forceRepaintDoneCallback methods
1650 it replaced did. The method is empty on the Apple ports.
1652 * WebKitTestRunner/TestInvocation.cpp:
1653 (WTR::TestInvocation::forceRepaintDoneCallback):
1655 2013-09-06 Allan Sandfeld Jensen <allan.jensen@digia.com>
1657 [Qt][WK2] Window used by WebKitTestRunner loses active status
1658 https://bugs.webkit.org/show_bug.cgi?id=120774
1660 Reviewed by Jocelyn Turcotte.
1662 When focusing the PlatformWebView which is done at the start of each test, we should
1663 ensure the host window of PlatformWebView is also made active, otherwise we will
1664 not receive the keyboard events send by EventSenderProxy.
1666 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1667 (WTR::PlatformWebView::focus):
1669 2013-09-05 Seokju Kwon <seokju@webkit.org>
1671 Unreviewed build fix. VectorReverse.cpp was removed after r155151.
1673 * TestWebKitAPI/CMakeLists.txt:
1675 2013-09-05 Anders Carlsson <andersca@apple.com>
1677 Make Vector::uncheckedAppend work with move-only types
1678 https://bugs.webkit.org/show_bug.cgi?id=120799
1680 Reviewed by Andreas Kling.
1682 * TestWebKitAPI/Tests/WTF/Vector.cpp:
1683 (TestWebKitAPI::MoveOnly):
1684 Add a move-only class.
1686 (TestWebKitAPI::TEST):
1687 Add a test for Vector<MoveOnly>::uncheckedAppend.
1689 2013-09-05 Anders Carlsson <andersca@apple.com>
1691 Move all Vector tests into Vector.cpp
1692 https://bugs.webkit.org/show_bug.cgi?id=120797
1694 Reviewed by Andreas Kling.
1696 * TestWebKitAPI/CMakeLists.txt:
1697 * TestWebKitAPI/GNUmakefile.am:
1698 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1699 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1700 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1701 * TestWebKitAPI/Tests/WTF/Vector.cpp:
1702 (TestWebKitAPI::TEST):
1703 * TestWebKitAPI/Tests/WTF/VectorBasic.cpp: Removed.
1704 * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Removed.
1705 * TestWebKitAPI/Tests/WTF/WTF.pro:
1707 2013-09-05 Simon Fraser <simon.fraser@apple.com>
1709 Expected result images are sometimes blank in WKTR
1710 https://bugs.webkit.org/show_bug.cgi?id=120715
1712 Reviewed by Tim Horton.
1714 In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were
1715 sometimes blank if a previous test triggered compositing mode, and the
1716 current test or reference did not require compositing. This happened
1717 because the UI process didn't wait for the web process to complete
1718 its compositing mode switch before snapshotting. Fix by calling
1719 WKPageForceRepaint() before we take the snapshot; this is async,
1720 so we have to spin the runloop for a while.
1722 Remove the Qt/EFL code that does the same thing.
1724 * WebKitTestRunner/TestInvocation.cpp:
1725 (WTR::TestInvocation::forceRepaintDoneCallback):
1726 (WTR::TestInvocation::dumpResults):
1727 * WebKitTestRunner/TestInvocation.h:
1728 * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1729 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1730 * WebKitTestRunner/qt/TestInvocationQt.cpp:
1731 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1733 2013-09-05 Csaba Osztrogonác <ossy@webkit.org>
1735 Make build.webkit.org report the number of failing run-fast-jsc tests
1736 https://bugs.webkit.org/show_bug.cgi?id=120766
1738 Reviewed by Filip Pizlo.
1740 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1741 (RunJavaScriptCoreTests.commandComplete):
1742 (RunJavaScriptCoreTests.getText2):
1743 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1744 (RunJavaScriptCoreTestsTest): Added.
1745 (RunJavaScriptCoreTestsTest.assertResults):
1746 (RunJavaScriptCoreTestsTest.test_no_regressions_old_output):
1747 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
1748 (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output):
1749 (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output):
1750 (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output):
1751 (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output):
1753 2013-09-05 Csaba Osztrogonác <ossy@webkit.org>
1755 Make run-fast-jsc script bash, dash and Darwin's /bin/sh friendly
1756 https://bugs.webkit.org/show_bug.cgi?id=120759
1758 Reviewed by Filip Pizlo.
1760 * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy.
1761 * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows.
1763 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1765 Unreviewed, green the Mac bots by boosting the timeout on JSC tests. One of the
1766 Mozilla tests appears to run for a longer time.
1768 I think we want to continue to allow a few tests here and there to be
1769 longer-running, rather than excluding them. I seem to recall that those tests
1772 * Scripts/run-javascriptcore-tests:
1774 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1776 Unreviewed, don't run fast/js tests in run-javascriptcore-tests on platforms that
1777 can't support it because if non-bourne shells. This fixes part #2 of the Linux
1780 * Scripts/run-javascriptcore-tests:
1782 2013-09-05 Filip Pizlo <fpizlo@apple.com>
1784 Unreviewed, don't rely on File::Slurp. This fixes part #1 of Linux bot breakage.
1786 * Scripts/run-javascriptcore-tests:
1789 2013-09-04 Filip Pizlo <fpizlo@apple.com>
1791 jsc tests should have timeouts
1792 https://bugs.webkit.org/show_bug.cgi?id=120725
1794 Reviewed by Geoffrey Garen.
1796 Set the timeout to 20 seconds per test for now.
1798 * Scripts/run-javascriptcore-tests:
1800 2013-09-04 Filip Pizlo <fpizlo@apple.com>
1802 run-javascriptcore-tests should run-fast-jsc as well
1803 https://bugs.webkit.org/show_bug.cgi?id=120722
1805 Reviewed by Geoffrey Garen.
1807 Makes run-javascriptcore-tests run the fast/js tests via run-fast-jsc tool.
1808 Integrates run-fast-jsc's error reporting into run-javascriptcore-tests.
1810 * Scripts/run-javascriptcore-tests:
1813 2013-09-04 Sergio Correia <sergio.correia@openbossa.org>
1815 [EFL][WK2] Move ShouldGoToBackForwardListItem to the list of passing API tests
1816 https://bugs.webkit.org/show_bug.cgi?id=120646
1818 Reviewed by Gyuyoung Kim.
1820 * TestWebKitAPI/PlatformEfl.cmake: Move ShouldGoToBackForwardListItem to the
1821 list of passing tests, since it started to pass after r154045.
1823 2013-09-04 Krzysztof Czech <k.czech@samsung.com>
1825 [ATK] Adds an accessibility support to access a value of the color control element
1826 https://bugs.webkit.org/show_bug.cgi?id=114354
1828 Reviewed by Mario Sanchez Prada.
1830 Added accessibility role of the color control element.
1832 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1834 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1835 (WTR::roleToString):
1837 2013-09-04 Mario Sanchez Prada <mario.prada@samsung.com>
1839 REGRESSION (r132328): /WebKit2APITests/TestWebKitAccessibility unit test is failing
1840 https://bugs.webkit.org/show_bug.cgi?id=100408
1842 Unreviewed gardening. Unskip TestWebKitAccessibility after
1843 manually checking that it's running properly in the bot.
1845 * Scripts/run-gtk-tests:
1846 (TestRunner): Unskipped TestWebKitAccessibility.
1848 2013-09-04 Zan Dobersek <zdobersek@igalia.com>
1850 [GTK] Add support for the Wayland build target
1851 https://bugs.webkit.org/show_bug.cgi?id=120627
1853 Reviewed by Gustavo Noronha Silva.
1855 * GNUmakefile.am: Define the additional macros also if building the Wayland target.
1857 2013-09-04 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
1859 [GStreamer] cannot play live streams
1860 https://bugs.webkit.org/show_bug.cgi?id=116831
1862 Reviewed by Philippe Normand.
1864 Fix timeout issues with rtspsrc/udpsrc gstreamer elements.
1866 * gtk/jhbuild.modules:
1867 * gtk/patches/rtspsrc-timeout-on-udpsrc-is-in-nanoseconds.patch: Added.
1868 * gtk/patches/udpsrc-improve-timeouts.patch: Added.
1869 Changed gstreamer jhbuild modules to use tarball repos (required to add patches)
1870 and added 2 patches to gst-plugins-good to fix timeout issues with rtsp streams.
1871 Both patches are applied upstream and can be removed once a new gstreamer release
1872 is out (up to 1.0.10 the patches are not included) and we bump the requirements.
1874 2013-09-03 Alexey Proskuryakov <ap@apple.com>
1876 [Mac] WebKitTestRunner still beeps sometimes
1877 https://bugs.webkit.org/show_bug.cgi?id=120652
1879 Reviewed by Tim Horton.
1881 In bug 107251, we disabled beeping in WebProcess, but some of the beeps happen in
1882 UI process (notably, AppKit beeps when handling a key equivalent returns NO).
1884 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
1885 Use the same SPI that we use in DRT and in WebProcess to disable beeping.
1887 2013-09-03 Krzysztof Czech <k.czech@samsung.com>
1889 [AX][ATK] Added support for sort and help attributes
1890 https://bugs.webkit.org/show_bug.cgi?id=120456
1892 Reviewed by Chris Fleizach.
1894 Added missing implementation to AccessibilityUIElement::helpText and support for
1895 aria-sort attribute.
1897 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1898 (coreAttributeToAtkAttribute):
1899 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1900 (WTR::coreAttributeToAtkAttribute):
1901 (WTR::AccessibilityUIElement::helpText):
1903 2013-09-03 Allan Sandfeld Jensen <allan.jensen@digia.com>
1905 [Qt][WK1] PageVisibility tests are flaky
1906 https://bugs.webkit.org/show_bug.cgi?id=120418
1908 Reviewed by Jocelyn Turcotte.
1910 Implement resetPageVisibility so we can reset visibility without
1911 emiting visibility state change events.
1913 * DumpRenderTree/qt/TestRunnerQt.cpp:
1914 (TestRunner::resetPageVisibility):
1916 2013-09-03 ChangSeok Oh <changseok.oh@collabora.com>
1918 [GTK] libsoup upversion to fix a gstreamer issue, bug115354
1919 https://bugs.webkit.org/show_bug.cgi?id=120613
1921 Reviewed by Philippe Normand.
1923 Up version of libsoup to 2.43.90. But the exact version which we'll use is not 2.43.90.
1924 To fix bug115354, we need the Andre's patch for libsoup, but the lastest release
1925 does not contain it. https://bugzilla.gnome.org/show_bug.cgi?id=706338
1926 For the reason, we'll use libsoup git repo directly for a while until the next
1929 * gtk/jhbuild.modules:
1931 2013-09-02 Darin Adler <darin@apple.com>
1933 [Mac] No need for HardAutorelease, which is same as CFBridgingRelease
1934 https://bugs.webkit.org/show_bug.cgi?id=120569
1936 Reviewed by Andy Estes.
1938 * DumpRenderTree/mac/DumpRenderTree.mm:
1939 (dump): Use CFBridgingRelease.
1941 2013-09-02 Anton Obzhirov <a.obzhirov@samsung.com>
1943 <https://webkit.org/b/98350> [GTK] accessibility/aria-invalid.html times out
1945 Reviewed by Mario Sanchez Prada.
1947 Added few mappings in DumpRenderTree and WebKitTestRunner for aria-invalid in order to get the tests run properly.
1949 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1950 (axObjectEventListener):
1951 Added mapping for invalid-entry event parameter.
1952 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1953 (coreAttributeToAtkAttribute):
1954 Added mapping to aria-invalid.
1955 (AccessibilityUIElement::stringAttributeValue):
1956 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1957 (WTR::coreAttributeToAtkAttribute):
1958 Added mapping to aria-invalid.
1960 2013-09-02 Nick Diego Yamane <nick.yamane@openbossa.org>
1962 Save md5 correctly when jhbuildPath doesn't exist yet
1963 https://bugs.webkit.org/show_bug.cgi?id=120548
1965 Reviewed by Gustavo Noronha Silva.
1967 After r152605, Md5 for jhbuild files are saved before the update
1968 process, this prevents the script to restart update from scratch
1969 when initial checkouts fail. However it causes an issue when builddir
1970 (or builddir/Dependencies) doesn't exist yet. In that case the
1971 saveJhbuildMd5 function fails to create md5 files.
1972 This patch adds a checking for the jhbuildPath and creates it if
1973 necessary before trying to open the md5 files.
1975 * Scripts/update-webkit-libs-jhbuild:
1978 2013-09-02 Mario Sanchez Prada <mario.prada@samsung.com>
1980 Unreviewed. Move myself to the reviewers list.
1982 * Scripts/webkitpy/common/config/contributors.json:
1984 2013-09-01 Alexey Proskuryakov <ap@apple.com>
1986 [WK2][Mac] Drag and drop tests interfere with user's UI
1987 https://bugs.webkit.org/show_bug.cgi?id=120538
1989 Reviewed by Dan Bernstein.
1991 This makes running WebKit2 regression tests locally more viable. The patch doesn't
1992 fix drag and drop tests to work as expected, I posted some thought about that in
1993 <https://bugs.webkit.org/show_bug.cgi?id=68552>.
1995 * WebKitTestRunner/EventSenderProxy.h:
1996 (WTR::EventSenderProxy::position):
1997 * WebKitTestRunner/TestController.h:
1998 (WTR::TestController::eventSenderProxy):
1999 Expose a way to get current mouse position from anywhere in WKTR code.
2001 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new files.
2003 * WebKitTestRunner/mac/EventSenderProxy.mm: (WTR::EventSenderProxy::mouseUp):
2004 Copied a FIXME comment from DumpRenderTree.
2006 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2007 (-[TestRunnerWKView dragImage:at:offset:event:pasteboard:source:slideBack:]):
2008 Override drag initiation, using a custom NSDraggingInfo implementation.
2010 * WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformInitialize):
2011 Replace NSEvent with a custom class.
2013 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h: Added.
2014 * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Added.
2015 * WebKitTestRunner/mac/WebKitTestRunnerEvent.h: Added.
2016 * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm: Added.
2017 Largely a copy of DumpRenderTree classes, modified to not use global variables.
2018 We should consider making these variables static in EventSenderProxy though, as
2019 it's strange that mouse state in WKTR is reset between tests without WebKit ever
2020 being told about that.
2022 2013-08-30 Brent Fulgham <bfulgham@apple.com>
2024 [Windows] Unreviewed build fix.
2026 * win/AssembleBuildLogs/AssembleLogs.cmd: Make sure WebInspectorUI build output is reported
2027 from the build machines.
2029 2013-08-30 Gabor Abraham <abrhm@inf.u-szeged.hu>
2031 [Qt] Remove qt-5.0-wk2 from the baseline search paths because the migration of expectations to qt-wk2 is done.
2032 https://bugs.webkit.org/show_bug.cgi?id=120464
2034 Reviewed by Jocelyn Turcotte.
2036 * Scripts/webkitpy/port/qt.py:
2037 (QtPort._search_paths):
2038 * Scripts/webkitpy/port/qt_unittest.py:
2041 2013-08-29 Filip Pizlo <fpizlo@apple.com>
2043 Just linking LLVM into JSC causes all plugin tests to fail
2044 https://bugs.webkit.org/show_bug.cgi?id=113915
2046 Reviewed by Oliver Hunt.
2048 Hide all LLVM symbols. This should prevent us from exporting LLVM's overrides for
2049 raise/abort/__assert_rtn.
2051 * Scripts/configure-llvm:
2053 2013-08-29 Joseph Pecoraro <pecoraro@apple.com>
2055 new-run-webkit-tests does not respect --no-sample-on-timeout switch
2056 https://bugs.webkit.org/show_bug.cgi?id=120491
2058 Reviewed by Darin Adler.
2060 * Scripts/webkitpy/port/server_process.py:
2061 (ServerProcess._handle_timeout):
2063 2013-08-29 Sam Weinig <sam@webkit.org>
2065 Add ENABLE guards for Promises
2066 https://bugs.webkit.org/show_bug.cgi?id=120488
2068 Reviewed by Andreas Kling.
2070 * Scripts/webkitperl/FeatureList.pm:
2071 * qmake/mkspecs/features/features.pri:
2073 2013-08-29 Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk>
2075 [GTK] Should enable WebGL by default on MiniBrowser
2076 https://bugs.webkit.org/show_bug.cgi?id=120420
2078 Reviewed by Gustavo Noronha Silva.
2080 Enable WebGL by default on MiniBrowser.
2082 * MiniBrowser/gtk/main.c:
2085 2013-08-28 Simon Fraser <simon.fraser@apple.com>
2087 Add a Command-R shortcut in MiniBrowser
2088 https://bugs.webkit.org/show_bug.cgi?id=120442
2090 Reviewed by Dean Jackson.
2092 Add a "Reload Page" item to the View menu with a Command-R
2095 * MiniBrowser/mac/MainMenu.xib:
2097 2013-08-29 Alberto Garcia <berto@igalia.com>
2099 [GTK] Update apt dependency list
2100 https://bugs.webkit.org/show_bug.cgi?id=120399
2102 Reviewed by Philippe Normand.
2104 Remove bogus package gail-3.0, add xfonts-utils (needed by
2105 xorg-xserver) and switch to the latest versions of libtiff and
2108 * gtk/install-dependencies:
2110 2013-08-28 Alexey Proskuryakov <ap@apple.com>
2112 [WK2][Mac] WebKitTestRunner doesn't force system appearance
2113 https://bugs.webkit.org/show_bug.cgi?id=120437
2115 Reviewed by Darin Adler.
2117 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2118 (WTR::InjectedBundle::platformInitialize): Set AppleAquaColorVariant,
2119 AppleHighlightColor and AppleOtherHighlightColor to the same values that DRT uses.
2122 2013-08-16 Ryosuke Niwa <rniwa@webkit.org>
2124 <https://webkit.org/b/119806> [Mac] Add a way to easily test attributed string generation
2126 Reviewed by Darin Adler.
2128 Add textInputController.legacyAttributedString to retrieve the attributed string for copy & paste.
2130 We can't use textInputController.attributedSubstringFromRange as it uses WebHTMLConverter's static
2131 editingAttributedStringFromRange function, which doesn't implement the full converter at the moment.
2133 Also NSMutableAttributedString.ranges and WebNSRange so that JavaScript can get a list of all
2134 ranges in a given attributed string.
2136 * DumpRenderTree/mac/TextInputController.m:
2137 (-[WebNSRange initWithNSRange:]):
2138 (-[WebNSRange location]):
2139 (-[WebNSRange length]):
2140 (+[WebNSRange isSelectorExcludedFromWebScript:]):
2141 (+[NSMutableAttributedString isSelectorExcludedFromWebScript:]):
2142 (+[NSMutableAttributedString webScriptNameForSelector:]):
2143 (-[NSMutableAttributedString ranges]): Added.
2144 (+[TextInputController isSelectorExcludedFromWebScript:]):
2145 (+[TextInputController webScriptNameForSelector:]):
2146 (-[TextInputController legacyAttributedString:]):
2148 2013-08-28 Denis Nomiyama <d.nomiyama@samsung.com>
2150 [GTK] accessibility/menu-list-sends-change-notification.html has incorrect expected results
2151 https://bugs.webkit.org/show_bug.cgi?id=120419
2153 Reviewed by Chris Fleizach.
2155 Added a notification for AXFocusedUIElementChanged.
2157 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2158 (axObjectEventListener): Added a notification for AXFocusedUIElementChanged.
2160 2013-08-28 Roger Fong <roger_fong@apple.com>
2162 Decrease number of workers used in NRWT by the Windows port.
2163 https://bugs.webkit.org/show_bug.cgi?id=120435.
2165 Reviewed by Brent Fulgham.
2167 * Scripts/webkitpy/port/win.py:
2168 (WinPort.default_child_processes):
2170 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
2172 Http tests fails on Debian with Apache 2.4
2173 https://bugs.webkit.org/show_bug.cgi?id=120352
2177 Remember to update unit-test expectations and old-run-webkit-tests as well.
2179 * Scripts/webkitperl/httpd.pm:
2180 (getHTTPDConfigPathForTestDirectory):
2181 * Scripts/webkitpy/port/port_testcase.py:
2182 (test_apache_config_file_name_for_platform):
2184 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
2186 Http tests fails on Debian with Apache 2.4
2187 https://bugs.webkit.org/show_bug.cgi?id=120352
2189 Reviewed by Andreas Kling.
2191 Select httpd.conf file for debian based on version, matching Fedora behavior.
2193 * Scripts/webkitpy/port/base.py:
2194 (Port._apache_config_file_name_for_platform):
2196 2013-08-28 Commit Queue <commit-queue@webkit.org>
2198 Unreviewed, rolling out r154593.
2199 http://trac.webkit.org/changeset/154593
2200 https://bugs.webkit.org/show_bug.cgi?id=120403
2202 Caused 50+ flaky tests on WebKit1 bots (Requested by carewolf
2205 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2206 (WebPage::~WebPage):
2208 2013-08-28 Allan Sandfeld Jensen <allan.jensen@digia.com>
2210 [Qt][Wk2] Many tests are flaky on Qt 5.1
2211 https://bugs.webkit.org/show_bug.cgi?id=118232
2213 Reviewed by Jocelyn Turcotte.
2215 We need to set renderToOffscreenBuffer since we won't otherwise get
2216 the paint calls necessary to synchronize UI- and Web-Process. It was
2217 only disabled in Qt 5.0 because it conflicted with setRenderWithoutShowing
2218 which is no longer supported or needed.
2220 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2221 (WTR::WrapperWindow::handleStatusChanged):
2223 2013-08-27 Alexey Proskuryakov <ap@apple.com>
2225 [WK2] Remove USE_WEBPROCESS_EVENT_SIMULATION
2226 https://bugs.webkit.org/show_bug.cgi?id=120379
2228 Reviewed by Darin Adler.
2230 All major platforms have implemented UI process eventSender support, keeping old
2231 web process side code only adds confusion.
2233 * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2234 (WTR::EventSendingController::EventSendingController):
2235 (WTR::EventSendingController::mouseDown):
2236 (WTR::EventSendingController::mouseUp):
2237 (WTR::EventSendingController::mouseMoveTo):
2238 (WTR::EventSendingController::leapForward):
2239 * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2240 * WebKitTestRunner/TestController.cpp:
2241 (WTR::TestController::resetStateToConsistentValues):
2242 (WTR::TestController::didReceiveMessageFromInjectedBundle):
2243 (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2244 * WebKitTestRunner/TestController.h:
2246 2013-08-27 Roger Fong <roger_fong@apple.com>
2248 NRWT on AppleWin port should delete semaphore lock files during cleanup tasks.
2249 https://bugs.webkit.org/show_bug.cgi?id=120370.
2251 Reviewed by Brent Fulgham.
2253 * Scripts/webkitpy/port/win.py:
2254 (WinPort.delete_sem_locks):
2255 (WinPort.setup_test_run):
2257 2013-08-27 Denis Nomiyama <d.nomiyama@samsung.com>
2259 [GTK] Missing DRT AccessibilityUIElement::addNotificationListener implementation
2260 https://bugs.webkit.org/show_bug.cgi?id=119883
2262 Implemented the notification listener for AccessibilityUIElement. The signal is generated
2263 by AXObjectCache::postPlatformNotification() and received by axObjectEventListener().
2264 axObjectEventListener will then invoke JSObjectCallAsFunction() with the respective
2265 callback function. The global callback function and callbacks for specific elements are
2266 stored in a HashMap in AccessibilityCallbacksAtk.cpp.
2268 Reviewed by Chris Fleizach.
2270 * DumpRenderTree/AccessibilityUIElement.h: Added a notification handler for GTK+
2271 * DumpRenderTree/atk/AccessibilityCallbacks.h: Added addAccessibilityNotificationListener()
2272 and removeAccessibilityNotificationListener()
2273 * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2274 (axObjectEventListener): Call JS callback for global notification or for a specific element
2275 (disconnectAccessibilityCallbacks): Only disconnect if logging is off and there is no
2276 notification handler
2277 (addAccessibilityNotificationHandler): Add notification listener to the list
2278 (removeAccessibilityNotificationHandler): Remove notification listener from the list
2279 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2280 (AccessibilityController::setLogAccessibilityEvents): Set logging off before disconnecting
2281 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2282 (AccessibilityNotificationHandler::AccessibilityNotificationHandler): Create handler
2283 (AccessibilityNotificationHandler::~AccessibilityNotificationHandler): Destroy handler.
2284 Remove handler from the list and disconnect callbacks
2285 (AccessibilityNotificationHandler::setNotificationFunctionCallback): Set the notification
2286 callback and connect callbacks to signals
2287 * DumpRenderTree/atk/AccessibilityNotificationHandlerAtk.h: Added.
2288 (AccessibilityNotificationHandler::setPlatformElement): Set platform element
2289 (AccessibilityNotificationHandler::platformElement): Get platform element
2290 (AccessibilityNotificationHandler::notificationFunctionCallback): Get notification callback
2291 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2292 (AccessibilityUIElement::addNotificationListener): Create notification handler, set the
2293 platform element and the notification callback
2294 (AccessibilityUIElement::removeNotificationListener):
2295 * DumpRenderTree/efl/CMakeLists.txt: Added AccessibilityNotificationHandlerAtk.cpp/h
2296 * GNUmakefile.am: Added AccessibilityNotificationHandlerAtk.cpp/h
2298 2013-08-27 Carlos Garcia Campos <cgarcia@igalia.com>
2300 Unreviewed. Fix GTK+ build after r154601.
2302 * TestWebKitAPI/GNUmakefile.am: Remove mac specific file from
2303 compilation added by mistake in r154601.
2305 2013-08-26 Alexey Proskuryakov <ap@apple.com>
2307 WebKitTestRunner needs to protect the user's pasteboard contents while running
2308 https://bugs.webkit.org/show_bug.cgi?id=81419
2309 <rdar://problem/11066794>
2311 Reviewed by Darin Adler.
2313 Mostly a copy/paste of DRT code.
2315 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
2316 doesn't interfere with my clipboard while being run in a loop.
2318 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2319 * WebKitTestRunner/mac/PoseAsClass.h: Added.
2320 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
2321 * WebKitTestRunner/mac/TestControllerMac.mm:
2322 (WTR::TestController::platformInitialize):
2323 (WTR::TestController::platformDestroy):
2324 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
2325 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
2327 2013-08-26 Commit Queue <commit-queue@webkit.org>
2329 Unreviewed, rolling out r154640.
2330 http://trac.webkit.org/changeset/154640
2331 https://bugs.webkit.org/show_bug.cgi?id=120329
2333 Caused flaky crashes on a lot of editing tests (Requested by
2336 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2337 * WebKitTestRunner/mac/PoseAsClass.h: Removed.
2338 * WebKitTestRunner/mac/PoseAsClass.mm: Removed.
2339 * WebKitTestRunner/mac/TestControllerMac.mm:
2340 (WTR::TestController::platformInitialize):
2341 (WTR::TestController::platformDestroy):
2342 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Removed.
2343 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Removed.
2345 2013-08-26 Dan Bernstein <mitz@apple.com>
2347 Automatic bug reports case pain
2348 https://bugs.webkit.org/show_bug.cgi?id=120330
2350 Reviewed by Anders Carlsson.
2352 * Scripts/webkitpy/tool/commands/download.py: Made the following changes to the Description
2353 of bugs filed by the bot: changed “the sheriff-bot” to “webkitbot”, changed “case pain” to
2354 “fail”, and removed “"Only you can prevent forest fires." -- Smokey the Bear”.
2356 2013-08-23 Andy Estes <aestes@apple.com>
2358 Fix issues found by the Clang Static Analyzer
2359 https://bugs.webkit.org/show_bug.cgi?id=120230
2361 Reviewed by Darin Adler.
2363 * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2364 (-[LocalPasteboard initWithName:]): Called [super init] first so that we
2365 don't later use ivars from the wrong self.
2366 * DumpRenderTree/mac/TestRunnerMac.mm:
2367 (-[APITestDelegate initWithCompletionCondition:]): Ditto.
2368 * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2369 (TestWebKitAPI::TEST): Don't leak WKProcessGroups,
2370 WKBrowsingContextGroups, and WKViews.
2372 2013-08-26 Alexey Proskuryakov <ap@apple.com>
2374 WebKitTestRunner needs to protect the user's pasteboard contents while running
2375 https://bugs.webkit.org/show_bug.cgi?id=81419
2376 <rdar://problem/11066794>
2378 Reviewed by Darin Adler.
2380 Mostly a copy/paste of DRT code.
2382 Tested manually by making sure that editing/pasteboard/copy-image-with-alt-text.html
2383 doesn't interfere with my clipboard while being run in a loop.
2385 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2386 * WebKitTestRunner/mac/PoseAsClass.h: Added.
2387 * WebKitTestRunner/mac/PoseAsClass.mm: Added.
2388 * WebKitTestRunner/mac/TestControllerMac.mm:
2389 (WTR::TestController::platformInitialize):
2390 (WTR::TestController::platformDestroy):
2391 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.h: Added.
2392 * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm: Added.
2394 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
2396 [GTK] Include most of the WebKit2 unit tests into the build and testing
2397 https://bugs.webkit.org/show_bug.cgi?id=120307
2399 Reviewed by Philippe Normand.
2401 There are still various unit test source files that are not being included into
2402 the build. This patch includes most of these, only leaving out tests that do not
2403 compile or test features that are not supported by the GTK port.
2405 * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
2407 * TestWebKitAPI/GNUmakefile.am:
2409 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2411 [GTK] Allow to run tests without Xvfb in run-gtk-tests
2412 https://bugs.webkit.org/show_bug.cgi?id=120298
2414 Reviewed by Philippe Normand.
2416 Add --no-xvfb command line option to run tests in the current
2419 * Scripts/run-gtk-tests:
2420 (TestRunner._run_xvfb): Return early if option --no-xvfb has been
2422 (TestRunner._setup_testing_environment): Use helper function
2423 _run_xvfb to start Xvfb if needed.
2424 (TestRunner._tear_down_testing_environment): Check Xvfb is
2425 actually running before trying to terminate it.
2427 2013-08-26 Zoltan Arvai <zarvai@inf.u-szeged.hu>
2429 Adding Gabor Abraham to contributors.json.
2431 Reviewed by Csaba Osztrogonác.
2433 * Scripts/webkitpy/common/config/contributors.json:
2435 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2437 [GTK] Add support for passing test directories to run-gtk-tests
2438 https://bugs.webkit.org/show_bug.cgi?id=120296
2440 Reviewed by Philippe Normand.
2442 * Scripts/run-gtk-tests:
2443 (TestRunner._get_tests_from_dir): Helper function to return all
2444 unit tests found in a given directory.
2445 (TestRunner._get_tests): Check the given tests passed in the
2446 command line, so that if a directory is found the tests contained
2447 in the directory are added to the list of tests to run.
2449 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2451 [GTK] Improve the stop/reload button implementation in MiniBrowser
2452 https://bugs.webkit.org/show_bug.cgi?id=120292
2454 Reviewed by Philippe Normand.
2456 - Use an instance member of BrowserWindow for the button widget
2457 instead of a global variable.
2458 - Use notify::is-loading to monitor the WebView load instead of
2459 the estimated-load-progress property.
2460 - Use webkit_web_view_is_loading() to check whether the view
2461 is loading to change the button icon instead of a string
2462 comparison of the gtk stock icon id.
2463 - Use the right casts to fix compile warning.
2465 * MiniBrowser/gtk/BrowserWindow.c:
2466 (reloadOrStopCallback):
2467 (webViewLoadProgressChanged):
2468 (webViewIsLoadingChanged):
2469 (browser_window_init):
2470 (browserWindowConstructed):
2472 2013-08-26 Arunprasad Rajkumar <arurajku@cisco.com>
2474 [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433)
2475 https://bugs.webkit.org/show_bug.cgi?id=119791
2477 Reviewed by Jocelyn Turcotte.
2479 Load empty url to send onunload event to currently running page. onunload event is
2480 mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
2481 LayoutTests/plugins/geturlnotify-during-document-teardown.html.
2483 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2484 (WebPage::~WebPage):
2486 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
2488 [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
2489 https://bugs.webkit.org/show_bug.cgi?id=120290
2491 Reviewed by Philippe Normand.
2493 * MiniBrowser/gtk/GNUmakefile.am: Add
2494 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
2496 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
2498 [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
2499 https://bugs.webkit.org/show_bug.cgi?id=120288
2501 Reviewed by Carlos Garcia Campos.
2503 * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
2504 into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
2505 These unit tests are at the moment failing in debug configurations, so it would be nice to
2506 have the GTK builds report these failures as well.
2508 2013-08-25 Ryuan Choi <ryuan.choi@samsung.com>
2510 [EFL] EWebLauncher is executed as full screen with device pixel ratio
2511 https://bugs.webkit.org/show_bug.cgi?id=120282
2513 Reviewed by Gyuyoung Kim.
2515 * EWebLauncher/main.c:
2516 Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
2518 2013-08-25 Zan Dobersek <zdobersek@igalia.com>
2520 [gdb] Remove the pretty printer for KURLGooglePrivate
2521 https://bugs.webkit.org/show_bug.cgi?id=120263
2523 Reviewed by Benjamin Poulain.
2525 Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
2526 was usable inside the gdb debugger. The structure was remove from the codebase
2527 along with the GoogleURL backend for KURL.
2530 (JSCJSStringPrinter.to_string):
2531 (add_pretty_printers):
2533 2013-08-24 Filip Pizlo <fpizlo@apple.com>
2535 Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
2536 prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
2537 libraries depend on libgtest anyway.
2539 * Scripts/copy-webkitlibraries-to-product-directory:
2541 2013-08-24 Darin Adler <darin@apple.com>
2543 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
2544 https://bugs.webkit.org/show_bug.cgi?id=120255
2546 Reviewed by Andreas Kling.
2548 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
2550 2013-08-24 Anders Carlsson <andersca@apple.com>
2552 Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
2553 https://bugs.webkit.org/show_bug.cgi?id=120249
2555 Reviewed by Andreas Kling.
2557 * Scripts/extract-localizable-strings:
2559 2013-08-24 Carlos Garcia Campos <cgarcia@igalia.com>
2561 [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
2562 https://bugs.webkit.org/show_bug.cgi?id=119743
2564 Reviewed by Anders Carlsson.
2566 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2567 (WTR::InjectedBundlePage::InjectedBundlePage): Add
2570 2013-08-23 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
2572 Move TestWebKitAPI_LIBRARIES before platform specific cmake include
2573 https://bugs.webkit.org/show_bug.cgi?id=120220
2575 Reviewed by Martin Robinson.
2577 * TestWebKitAPI/CMakeLists.txt:
2579 2013-08-22 Filip Pizlo <fpizlo@apple.com>
2581 build-jsc --ftl-jit should work
2582 https://bugs.webkit.org/show_bug.cgi?id=120194
2584 Reviewed by Oliver Hunt.
2586 * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
2588 2013-08-23 Commit Queue <commit-queue@webkit.org>
2590 Unreviewed, rolling out r153534.
2591 http://trac.webkit.org/changeset/153534
2592 https://bugs.webkit.org/show_bug.cgi?id=120216
2594 Too many tests failing just WinEWS bots (Requested by rfong on
2597 * Scripts/webkitpy/common/config/ews.json:
2599 2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
2601 Unreviewed. Added my webkit.org email address.
2603 * Scripts/webkitpy/common/config/contributors.json:
2605 2013-08-23 Peter Gal <galpeter@inf.u-szeged.hu>
2607 [WTR] Should dump as text when the mimetype is text/plain
2608 https://bugs.webkit.org/show_bug.cgi?id=118306
2610 Reviewed by Christophe Dumez.
2612 Check for the text/plain mimetype and if true then mark it as
2615 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2616 (WTR::InjectedBundlePage::dump):
2618 2013-08-22 Filip Pizlo <fpizlo@apple.com>
2620 Update LLVM binary drops and scripts to the latest version from SVN
2621 https://bugs.webkit.org/show_bug.cgi?id=120184
2623 Reviewed by Mark Hahnenberg.
2625 * ReducedFTL/build.sh:
2626 * Scripts/configure-llvm: Added.
2627 * Scripts/copy-webkitlibraries-to-product-directory:
2628 * Scripts/export-llvm-build:
2630 2013-08-22 Andy Estes <aestes@apple.com>
2632 <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
2634 Reviewed by David Kilzer.
2636 * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
2637 OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
2638 DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
2640 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
2642 NRWT: Add the ability to upload test results to new test results server
2643 https://bugs.webkit.org/show_bug.cgi?id=120146
2645 Reviewed by Andreas Kling.
2647 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
2648 that contains the full summary of the test run including information about passed tests.
2650 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
2653 --results-server-host
2655 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
2656 so we should be able to delete --test-results-server in time.
2658 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2660 (Manager._upload_json_files):
2662 (Manager.upload_results):
2663 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2664 (summarize_results):
2665 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2666 (summarized_results):
2667 (SummarizedResultsTest.test_summarized_results_wontfix):
2668 (SummarizedResultsTest):
2669 (SummarizedResultsTest.test_summarized_results_include_passes):
2670 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2673 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
2675 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
2677 * Scripts/webkitpy/tool/bot/irc_command.py:
2680 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
2682 [Qt] DRT bug revealed/caused by r154300
2683 https://bugs.webkit.org/show_bug.cgi?id=120151
2685 Reviewed by Simon Hausmann.
2687 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
2688 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
2691 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
2692 between native Qt methods and JSC bound methods. This patch changes the check to see if the
2693 property is writable since the Qt methods are ReadOnly.
2695 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2696 (DumpRenderTree::initJSObjects):
2698 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
2700 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
2702 Reviewed by Benjamin Poulain.
2704 WTFString moved the is8bit bit by one in r152201.
2706 * lldb/lldb_webkit.py:
2707 (WTFStringImplProvider.is_8bit):
2709 2013-08-21 Tim Horton <timothy_horton@apple.com>
2711 Revert http://trac.webkit.org/changeset/154022, as it failed to update
2712 a variety of scripts that depended on the old format.
2714 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
2716 * Scripts/prepare-ChangeLog:
2718 (generateNewChangeLogs):
2720 2013-08-21 Brent Fulgham <bfulgham@apple.com>
2722 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
2724 * WinLauncher/WinLauncher.cpp:
2725 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
2727 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
2729 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
2731 Reviewed by Andreas Kling.
2733 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2734 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
2735 (WTR::activateFonts): Ditto.
2737 2013-08-21 Brian Holt <brian.holt@samsung.com>
2739 [GTK] Suppress irrelevant or known leaks for Valgrind
2740 https://bugs.webkit.org/show_bug.cgi?id=119448
2742 Reviewed by Martin Robinson.
2744 Add a suppressions file to suppress known leaks for Valgrind.
2745 Valgrind also takes longer when using suppressions and
2746 times out unless the driver timeout is increased.
2748 * Scripts/valgrind/suppressions.txt: Added.
2749 * Scripts/webkitpy/port/gtk.py:
2750 (GtkPort.driver_stop_timeout):
2751 (GtkPort.setup_environ_for_server):
2753 2013-08-20 Alex Christensen <achristensen@apple.com>
2755 [Windows] Linking fix for Win64.
2757 Rubberstamped by Brent Fulgham.
2759 * win/DLLLauncher/DLLLauncherMain.cpp:
2760 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
2762 2013-08-20 Brent Fulgham <bfulgham@apple.com>
2764 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
2766 Reviewed by Tim Horton.
2768 * win/DLLLauncher/DLLLauncherMain.cpp:
2769 (getLastErrorString): New method to convert GetLastError to text.
2770 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
2772 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
2774 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
2776 Reviewed by Martin Robinson.
2778 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
2779 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
2781 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
2783 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
2785 Reviewed by Martin Robinson.
2787 Added stop button in MiniBrowser
2789 * MiniBrowser/gtk/BrowserWindow.c:
2790 (reloadOrStopCallback): Callback to handle stop or reload button click.
2791 (webViewLoadProgressChanged): Update reload or stop button icon.
2792 (browser_window_init): Save button pointer for further icon updates.
2794 2013-08-20 Simon Pena <simon.pena@samsung.com>
2796 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
2798 Reviewed by Alexey Proskuryakov.
2800 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
2801 printing didFailLoadWithError.
2803 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
2804 DumpRenderTree, printing didFailLoadWithError.
2806 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2807 (webFrameLoadStatusNotified):
2809 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
2811 <https://webkit.org/b/120049> Delete code for Snow Leopard
2813 Reviewed by Benjamin Poulain.
2815 * DumpRenderTree/mac/CheckedMalloc.cpp:
2816 (protectionOfRegion):
2817 (makeLargeMallocFailSilently):
2818 * DumpRenderTree/mac/DumpRenderTree.mm:
2819 (resetDefaultsToConsistentValues):
2820 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2821 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2822 * DumpRenderTree/mac/FrameLoadDelegate.mm:
2824 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2825 * DumpRenderTree/mac/LayoutTestHelper.m:
2826 * DumpRenderTree/mac/TestRunnerMac.mm:
2827 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2828 (WTR::InjectedBundle::platformInitialize):
2829 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
2830 (WTR::testPathFromURL):
2831 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
2833 2013-08-19 Alexey Proskuryakov <ap@apple.com>
2835 https://bugs.webkit.org/show_bug.cgi?id=119915
2836 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
2838 Reviewed by Darin Adler.
2840 The issue was that we ended up having no CFNetwork cache in the testing session due
2841 to an incorrect cache model. There is a number of things not implemented when it
2842 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
2843 the easiest way to get this going is to initialize it to correct value upfront.
2845 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2847 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
2849 REGRESSION(r154275): webkitpy tests failing
2850 https://bugs.webkit.org/show_bug.cgi?id=120010
2852 Reviewed by Jocelyn Turcotte.
2854 Update unit-tests to tests the new search-path structure,
2855 but reverting the architecture search path addition.
2857 * Scripts/webkitpy/port/qt.py:
2860 (QtPort._generate_all_test_configurations):
2861 (QtPort.qt_architecture):
2862 * Scripts/webkitpy/port/qt_unittest.py:
2864 (QtPortTest._assert_search_path):
2865 (QtPortTest._assert_expectations_files):
2866 (QtPortTest._qt_version):
2868 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
2870 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
2872 Unreviewed meta gardening.
2874 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
2876 * Scripts/webkitpy/port/qt.py:
2877 (QtPort._search_paths):
2879 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
2881 Restructure Qt test expectations
2883 Unreviewed meta gardening.
2885 Removed 5.0 name from WK1 and WK2 results and made it possible to set
2886 expectations by both Qt version and mayor architectures.
2888 * Scripts/webkitpy/port/qt.py:
2889 (QtPort._wk2_port_name):
2891 (QtPort.qt_version):
2892 (QtPort.architecture):
2893 (QtPort._search_paths):
2894 (QtPort._port_specific_expectations_files):
2896 2013-08-16 Brent Fulgham <bfulgham@apple.com>
2898 [Windows] DRT is not using the same preferences as the Mac build.
2899 https://bugs.webkit.org/show_bug.cgi?id=119822
2901 Reviewed by Darin Adler.
2903 * DumpRenderTree/win/DumpRenderTree.cpp:
2904 (runTest): Process Windows message queue using CFRunLoop to allow
2905 dispatch routines to run properly.
2906 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
2907 to prevent problems on WinCairo port.
2909 2013-08-16 Brent Fulgham <bfulgham@apple.com>
2911 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
2912 https://bugs.webkit.org/show_bug.cgi?id=119583
2914 Reviewed by Alexey Proskuryakov.
2916 * DumpRenderTree/win/DumpRenderTree.cpp:
2917 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
2918 component if the URL does not contain the expected base URL.
2920 2013-08-16 Pratik Solanki <psolanki@apple.com>
2922 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
2924 Reviewed by Andreas Kling.
2926 m_script is never NULL so we can just return a reference. Also remove some pointless null
2927 checks as a result of doing this.
2929 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2930 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2932 2013-08-15 Alexey Proskuryakov <ap@apple.com>
2934 [WK2] NetworkProcess should use a temporary storage session for test
2935 https://bugs.webkit.org/show_bug.cgi?id=119855
2937 Reviewed by Darin Adler.
2939 Use a new API that takes care of both WebProcess and NetworkProcess.
2941 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2942 (WTR::InjectedBundle::initialize):
2943 * WebKitTestRunner/TestController.cpp:
2944 (WTR::TestController::initialize):
2946 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
2948 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
2950 Reviewed by Dirk Pranke.
2952 This is a port from Blink of
2953 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
2954 originally by Dirk Pranke.
2956 From the original commit:
2958 This gives something like a 15x speedup over compiling and matching
2959 one property at a time and doing multiple passes over the file.
2961 * Scripts/webkitpy/w3c/test_converter.py:
2962 (W3CTestConverter.__init__):
2963 (W3CTestConverter.convert_prefixed_properties):
2964 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2966 2013-08-15 Dan Bernstein <mitz@apple.com>
2968 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
2970 Reviewed by Darin Adler.
2972 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
2973 added a message that points to the source code. Removed some unnecessary repetition of what
2974 is already in the file.
2976 2013-08-15 Andy Estes <aestes@apple.com>
2978 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
2980 Reviewed by Brady Eidson.
2982 Wrote an API test that verifies -[WebView stopLoading:] can be called
2983 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
2985 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2986 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
2987 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
2988 (TestWebKitAPI::TEST):
2990 2013-08-15 Alexey Proskuryakov <ap@apple.com>
2992 Adding Myles Maxfield to contributors.json.
2994 Oops, wrong section, fixing.
2996 * Scripts/webkitpy/common/config/contributors.json:
2998 2013-08-15 Alexey Proskuryakov <ap@apple.com>
3000 Adding Myles Maxfield to contributors.json.
3002 * Scripts/webkitpy/common/config/contributors.json:
3004 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
3006 [Qt] Do not check specifically for version 5.0
3007 https://bugs.webkit.org/show_bug.cgi?id=119846
3009 Reviewed by Jocelyn Turcotte.
3011 For Qt 5.x we should always use both wk1 and wk2 basepath results.
3013 * Scripts/webkitpy/port/qt.py:
3014 (QtPort._search_paths):
3016 2013-08-15 Simon Pena <simon.pena@samsung.com>
3018 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
3020 Reviewed by Gustavo Noronha Silva.
3022 Following a similar approach as in r153977, return a path string
3023 that is relative to main frame URL or just file name if the
3024 resource is not in the same directory subtree, and replace empty
3025 strings with "(null)".
3027 Update pathFromSoupURI so it behaves more closely to the other
3028 ports, and remove the unused code after we no longer print
3029 <unknown> in certain cases. Also move
3030 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
3031 be used both in TestRunnerGtk and in DumpRenderTree.
3033 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3034 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
3035 we can print Soup URIs with the password, since soup_uri_to_string
3036 doesn't preserve them.
3037 (pathFromSoupURI): Updated following EFL implementation in
3038 r153977, and return a WTFString instead of a CString.
3039 (convertSoupMessageToURLPath): Return "(null)" instead of empty
3040 strings, and handle the new return type of pathFromSoupURI.
3041 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
3042 reference, and handle the new return type of pathFromSoupURI.
3043 (descriptionSuitableForTestResult): Remove unused code.
3044 (didFinishLoading): Use convertResourceToURLPath.
3045 (didFailLoadingWithError): Use convertResourceToURLPath.
3046 (authenticationCallback): Display the URL of the authentication
3048 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
3049 soupURIToStringPreservingPassword.
3050 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
3051 soupURIToStringPreservingPassword.
3053 2013-08-14 Tim Horton <timothy_horton@apple.com>
3055 Un-inline dataLog dumpers for IntSize and IntPoint
3056 https://bugs.webkit.org/show_bug.cgi?id=119697
3058 Reviewed by Sam Weinig.
3060 * TestWebKitAPI/GNUmakefile.am:
3062 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
3064 Flakiness dashboard build fix.
3066 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3067 (processTestRunsForBuilder):
3069 2013-08-14 Martin Robinson <mrobinson@igalia.com>
3071 [GTK] [CMake] Add support for building TestWebKitAPI
3072 https://bugs.webkit.org/show_bug.cgi?id=116987
3074 Reviewed by Philippe Normand.
3076 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
3077 platform-specific file, so that GTK+ can override them.
3078 * TestWebKitAPI/PlatformGTK.cmake: Added.
3080 2013-08-14 Brent Fulgham <bfulgham@apple.com>
3082 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
3083 https://bugs.webkit.org/show_bug.cgi?id=119775
3085 This bug updates the WinLauncher program with a few useful menu
3086 options to toggle certain debugging and development features of
3089 Reviewed by Tim Horton.
3091 * WinLauncher/WinLauncher.cpp:
3092 (dllLauncherEntryPoint): Clean up preference objects on exit.
3093 (ToggleMenuItem): New function.
3094 (LaunchInspector): New function.
3095 (WndProc): Add handler for new menu items. Also properly terminate
3096 CFRunLoop operation on program exit.
3097 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
3099 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
3100 resource folder to search path.
3101 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
3104 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
3106 Add a hyperlink from build.webkit.org to the flakiness dashboard.
3108 Rubbers-tamped by Simon Fraser.
3110 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3112 2013-08-14 Benjamin Dupont <bdupont@nds.com>
3114 [Qt] Activate visibility API layout tests
3115 https://bugs.webkit.org/show_bug.cgi?id=119790
3117 Reviewed by Allan Sandfeld Jensen.
3119 * DumpRenderTree/qt/TestRunnerQt.cpp:
3120 (TestRunner::resetPageVisibility):
3121 (TestRunner::setPageVisibility):
3123 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
3125 [GTK] WK does not link properly against libxslt
3126 https://bugs.webkit.org/show_bug.cgi?id=119688
3128 Reviewed by Gustavo Noronha Silva.
3130 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
3132 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
3134 2013-08-13 Alexey Proskuryakov <ap@apple.com>
3136 [Mac] fast/dom/attr-style-too-lazy.html is flaky
3137 https://bugs.webkit.org/show_bug.cgi?id=119763
3139 Reviewed by Darin Adler.
3141 * DumpRenderTree/mac/UIDelegate.mm:
3142 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
3143 a test, it would just semi-randomly leak to the next one.
3144 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
3147 2013-08-13 Tim Horton <timothy_horton@apple.com>
3149 [mac] Give MiniBrowser a reasonable bundle identifier
3150 https://bugs.webkit.org/show_bug.cgi?id=119773
3152 Rubber-stamped by Simon Fraser.
3154 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
3156 * MiniBrowser/mac/Info.plist:
3157 * MiniBrowser/mac/WebBundle/Info.plist:
3159 2013-08-13 Dean Jackson <dino@apple.com>
3161 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
3163 Reviewed by Mark Rowe.
3165 Have prepare-ChangeLog produce webkit.org/b/id style
3166 URLs rather than exposing the inner workings of our
3167 cgi. I was going to use the term "Future Proofing"
3168 but that seems excessive :)
3170 * Scripts/prepare-ChangeLog:
3171 (main): Generate a more human readable form.
3172 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
3174 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3176 [EFL][DRT] Simplify call to reverseFind()
3177 https://bugs.webkit.org/show_bug.cgi?id=119746
3179 Reviewed by Christophe Dumez.
3181 Follow-up to r153977.
3183 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3184 (pathSuitableForTestResult): Instead of defining a static variable
3185 that's only used in a single place, pass '/' to reverseFind() directly.
3187 2013-08-13 Alberto Garcia <berto@igalia.com>
3189 [GTK] Closing inspector window crashes wk
3190 https://bugs.webkit.org/show_bug.cgi?id=110865
3192 Reviewed by Carlos Garcia Campos.
3194 Disconnect all signal handlers if the inspector window is
3197 * GtkLauncher/LauncherInspectorWindow.c:
3198 (inspectorWindowDestroyed):
3199 (launcherInspectorWindowNew):
3201 2013-08-12 Dan Bernstein <mitz@apple.com>
3203 extract-localizable-strings output is not suited for parsing by Xcode
3204 https://bugs.webkit.org/show_bug.cgi?id=119728
3206 Reviewed by Darin Adler.
3208 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
3209 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
3210 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
3213 * Scripts/extract-localizable-strings:
3215 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
3217 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
3218 https://bugs.webkit.org/show_bug.cgi?id=119585
3220 Reviewed by Gyuyoung Kim.
3222 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3223 (pathSuitableForTestResult):
3224 Return path string that's relative to main frame URL, or just file name if
3225 the resource is not in the same directory subtree.
3226 Referenced WebKitTestRunner code in r153852.
3227 (descriptionSuitableForTestResult):
3228 (DumpRenderTreeChrome::onFrameRedirectRequested):
3229 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
3231 2013-08-12 Dan Bernstein <mitz@apple.com>
3233 extract-localizable-strings doesn't know how to verify an existing strings file
3234 https://bugs.webkit.org/show_bug.cgi?id=119704
3236 Reviewed by Darin Adler.
3238 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
3239 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
3240 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
3241 the way directories to skip are specified from prefixing the directory with a “-” to
3242 specifying it with --skip.
3243 Finally, added a --verify option. When specified, the strings file is not written to, but
3244 instead read in and checked for consistency with the comments, keys and values derived from
3245 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
3246 mismatching comments are reported as errors.
3247 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
3248 directories to skip and no exceptions file.
3250 2013-08-12 Alexey Proskuryakov <ap@apple.com>
3252 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
3253 https://bugs.webkit.org/show_bug.cgi?id=85522
3255 Reviewed by Andy Estes.
3257 * DumpRenderTree/mac/UIDelegate.mm:
3258 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
3259 when already done with a test. We already had this check in all UI delegate functions,
3260 except for -webView:addMessageToConsole:withSource: somehow.
3262 2013-08-12 Alexey Proskuryakov <ap@apple.com>
3264 https://bugs.webkit.org/show_bug.cgi?id=119693
3265 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
3266 because of connect-src-websocket-allowed.html
3268 Reviewed by Darin Adler.
3270 Starting a load of about:blank and immediately stopping it cancels outstanding
3271 resource loads, but the page has to transition to committed state to have timers
3272 or WebSockets stopped too.
3274 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
3275 ensure that transition to committed state happens before we start the next test.
3277 2013-08-12 Beth Dakin <bdakin@apple.com>
3279 The LayoutMilestones didLayout callback should only fire for the main frame
3280 https://bugs.webkit.org/show_bug.cgi?id=119457
3282 Reviewed by Sam Weinig.
3284 Now that the didLayout callback only fires for the main frame, we want to make
3285 sure it will fire even when all of the content is in a subframe.
3287 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3288 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
3289 (TestWebKitAPI::didLayout):
3290 (TestWebKitAPI::TEST):
3291 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
3293 2013-08-12 Beth Dakin <bdakin@apple.com>
3295 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
3296 https://bugs.webkit.org/show_bug.cgi?id=119658
3298 Reviewed by Darin Adler.
3300 * MiniBrowser/mac/WK2BrowserWindowController.m:
3301 (-[WK2BrowserWindowController awakeFromNib]):
3302 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3303 (WTR::InjectedBundlePage::InjectedBundlePage):
3304 * WebKitTestRunner/TestController.cpp:
3305 (WTR::TestController::createWebViewWithOptions):
3307 2013-08-12 Seokju Kwon <seokju@webkit.org>
3309 Remove glu's libtest rule from checker.py
3310 https://bugs.webkit.org/show_bug.cgi?id=119674
3312 Reviewed by Darin Adler.
3314 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
3316 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
3318 Unreviewed. Change my primary mail address.
3320 * Scripts/webkitpy/common/config/contributors.json:
3322 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
3324 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
3325 https://bugs.webkit.org/show_bug.cgi?id=115751
3327 Reviewed by Martin Robinson.
3329 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
3332 2013-08-09 Beth Dakin <bdakin@apple.com>
3334 AX: Not able to use arrow keys to read text in a WK2 app
3335 https://bugs.webkit.org/show_bug.cgi?id=119605
3337 <rdar://problem/14281275>
3339 Reviewed by Darin Adler.
3341 New test verifies that didNotHandleKeyEvent will be called when there is nothing
3343 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3344 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
3345 (TestWebKitAPI::didFinishLoadForFrame):
3346 (TestWebKitAPI::didNotHandleKeyEventCallback):
3347 (TestWebKitAPI::TEST):
3349 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
3351 Add support for KeyboardEvent.location attribute
3352 https://bugs.webkit.org/show_bug.cgi?id=119326
3354 Reviewed by Benjamin Poulain.
3356 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
3358 * DumpRenderTree/mac/EventSendingController.mm:
3359 (-[EventSendingController keyDown:withModifiers:withLocation:]):
3360 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
3361 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
3362 (-[EventSendingController handleEvent:]):
3363 (-[EventSendingController fireKeyboardEventsToElement:]):
3365 2013-08-09 Alexey Proskuryakov <ap@apple.com>
3367 <unknown> is often dumped instead of path in test output
3368 https://bugs.webkit.org/show_bug.cgi?id=119590
3370 Reviewed by Anders Carlsson.
3372 There were two reasons for <unknown>:
3373 1. When delegate logging is enabled via a testRunner call, that obviously happens
3374 after main resource load starts, so we don't record its URL.
3375 2. Authentication delegate logging relied on URL recording, but it's only turned on
3376 when enabling resource loading delegate logging, not auth one.
3378 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
3379 landed without posted rationale and unreviewed. Just undoing that change now.
3381 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3382 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3383 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3384 (WTR::InjectedBundlePage::didInitiateLoadForResource):
3386 2013-08-08 Alex Christensen <achristensen@apple.com>
3388 Windows build fixes.
3390 Rubberstamped by Brent Fulgham.
3392 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3393 Removed /SAFESEH link option which doesn't work with x64.
3395 2013-08-08 Daniel Bates <dabates@apple.com>
3397 Add iOS support to run-javascriptcore-tests
3398 https://bugs.webkit.org/show_bug.cgi?id=119602
3400 Reviewed by Joseph Pecoraro.
3402 Make run-javascriptcore-tests work for iOS WebKit.
3404 * Scripts/run-javascriptcore-tests:
3406 2013-08-08 Alexey Proskuryakov <ap@apple.com>
3408 [WK2] loader/go-back-cached-main-resource.html fails
3409 https://bugs.webkit.org/show_bug.cgi?id=116491
3411 Reviewed by Tim Horton.
3413 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3414 * DumpRenderTree/gtk/DumpRenderTree.cpp:
3415 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3416 * DumpRenderTree/win/DumpRenderTree.cpp:
3417 Added FIXMEs about making path printing normalization more compatible.
3419 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
3420 Return last path component in cases where we used to return a full path, which is
3421 never desirable. Added a null check to basePath to prevent potentially getting
3422 an Objective C exception.
3424 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3425 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
3426 for a currently loading one (which is different for tests that use multiple windows).
3427 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
3428 last path component as last fallback.
3429 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
3430 frame URL here, and it was potentially a wrong frame.
3431 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
3432 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
3433 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
3434 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
3435 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
3437 2013-08-08 Alex Christensen <achristensen@apple.com>
3439 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
3440 https://bugs.webkit.org/show_bug.cgi?id=116125
3442 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
3444 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3445 (WTR::pathSuitableForTestResult):
3446 Changed string operations to match _drt_descriptionSuitableForTestResult.
3447 (WTR::dumpRequestDescriptionSuitableForTestResult):
3448 (WTR::dumpResponseDescriptionSuitableForTestResult):
3449 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
3450 (WTR::InjectedBundlePage::didInitiateLoadForResource):
3451 (WTR::InjectedBundlePage::willSendRequestForFrame):
3452 (WTR::InjectedBundlePage::didReceiveResponseForResource):
3453 Pass the main frame's URL to pathSuitableForTestResult.
3454 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3455 Added WKBundlePageRef to willPerformClientRedirectForFrame.
3457 2013-08-07 Simon Fraser <simon.fraser@apple.com>
3459 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
3460 https://bugs.webkit.org/show_bug.cgi?id=119317
3462 Reviewed by Tim Horton.
3464 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
3465 the test to complete, which is not power friendly. Although DRT instances
3466 are generally busy anyway, not sitting in a busy loop should free up some CPU
3467 cycles for other instances of DRT.
3469 Editing tests continue to pass. All Java tests are skipped and were not
3470 tested, but when run fail similarly with and without the patch.
3472 * DumpRenderTree/mac/DumpRenderTree.mm:
3476 2013-08-07 Daniel Bates <dabates@apple.com>
3478 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
3479 <https://bugs.webkit.org/show_bug.cgi?id=119558>
3481 Reviewed by Martin Robinson.
3483 Currently we build the command line to execute jsDriver.pl twice so as to both
3484 print it to standard output and actually execute it. We should only build up
3485 this command line once. Moreover, we should print to standard output the actual
3486 command line that we are going to use including the GTK- and EFL-specific call
3487 to /Tools/jhbuild/jhbuild-wrapper.
3489 * Scripts/run-javascriptcore-tests:
3491 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
3493 [EFL] REGRESSION after r153432: some accessibility tests crash.
3494 https://bugs.webkit.org/show_bug.cgi?id=119333
3496 Reviewed by Darin Adler.
3498 Use a RefPtr to store a reference to the parent element of
3499 an AccessibilityUIElement instead of the raw pointer, so we
3500 never derefence a function from an invalid pointer.
3502 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3503 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
3505 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
3507 Unreviewed. Add myself as a committer.
3509 * Scripts/webkitpy/common/config/contributors.json:
3511 2013-08-04 Sam Weinig <sam@webkit.org>
3513 Remove support for HTML5 MicroData
3514 https://bugs.webkit.org/show_bug.cgi?id=119480
3516 Reviewed by Anders Carlsson.
3518 * Scripts/webkitperl/FeatureList.pm:
3519 * qmake/mkspecs/features/features.pri:
3521 2013-07-23 David Farler <dfarler@apple.com>
3523 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
3524 https://bugs.webkit.org/show_bug.cgi?id=117762
3526 Reviewed by Mark Rowe.
3528 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3529 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3530 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3531 Add ASAN_OTHER_LDFLAGS.
3532 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3533 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3534 * Scripts/check-for-weak-vtables-and-externals:
3535 Ignore ___asan externals, these are populated by compiler-rt.
3536 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3537 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3538 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3539 Add ASAN_OTHER_LDFLAGS.
3540 * WebKitLauncher/Configurations/Base.xcconfig:
3541 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3542 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
3543 Add ASAN_OTHER_LDFLAGS.
3544 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3545 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
3546 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3547 Add ASAN_OTHER_LDFLAGS.
3548 * asan/asan.xcconfig: Added.
3549 * asan/webkit-asan-ignore.txt: Added.
3551 2013-08-05 Brian Holt <brian.holt@samsung.com>
3553 [GTK] Implement leak checking with valgrind
3554 https://bugs.webkit.org/show_bug.cgi?id=118785
3556 Reviewed by Dirk Pranke.
3558 Launch the DRT under Valgrind to generate xml files with details
3561 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3563 * Scripts/webkitpy/port/gtk.py:
3565 (GtkPort.default_timeout_ms): Allow extra time to run under
3567 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
3568 using environment variables.
3570 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
3572 [EFL] REGRESSION after r153432: some accessibility tests crash.
3573 https://bugs.webkit.org/show_bug.cgi?id=119333
3575 Reviewed by Gustavo Noronha Silva.
3577 Add missing null-check to avoid dereferencing a non-existent parent.
3579 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3580 (WTR::attributesOfElement): Ditto.
3582 2013-08-02 Patrick Gansterer <paroga@webkit.org>
3584 Add --rmdir option to git svn dcommit
3585 https://bugs.webkit.org/show_bug.cgi?id=119398
3587 Reviewed by Ryosuke Niwa.
3589 Add this option tells git-svn to remove empty directories
3590 from the svn tree so they do not leave over there.
3592 * Scripts/webkitpy/common/checkout/scm/git.py:
3593 (Git.push_local_commits_to_server):
3595 2013-08-01 Brent Fulgham <bfulgham@apple.com>
3597 [Windows] WebKit1 Fullscreen Video Play is Broken
3598 https://bugs.webkit.org/show_bug.cgi?id=119415
3600 Reviewed by Jer Noble.
3602 * WinLauncher/WinLauncher.cpp:
3603 (dllLauncherEntryPoint): Activate full screen mode via
3604 IWebPreferencesInternal interface.
3606 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
3608 Unreviewed. Add an alternative address to show my affiliation in team.html.
3610 * Scripts/webkitpy/common/config/contributors.json:
3612 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
3614 Duplicate property names can cause test to fail
3615 https://bugs.webkit.org/show_bug.cgi?id=119399
3617 Reviewed by Dirk Pranke.
3619 This problem was noticed when porting the patch for
3620 http://wkb.ug/119357 to Blink: a test would fail because the converted
3621 and test property lists weren't the same length, but they contained
3622 all of the same property names. It looks like this is actually caused
3623 by a bug in converting the HTML, which is being currently rewritten.
3624 In the meantime, as long as this compares the number of unique
3625 properties, it makes the test more robust.
3627 * Scripts/webkitpy/w3c/test_converter_unittest.py:
3628 (verify_prefixed_properties):
3630 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
3632 Unreviewed. Adding my expertise.
3634 * Scripts/webkitpy/common/config/contributors.json:
3636 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
3638 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
3640 * Scripts/webkitpy/common/config/contributors.json:
3642 2013-08-01 Commit Queue <commit-queue@webkit.org>
3644 Unreviewed, rolling out r153518.
3645 http://trac.webkit.org/changeset/153518
3646 https://bugs.webkit.org/show_bug.cgi?id=119386
3648 The Jhbuild dep bump of GTK+ is not actually required by