Unreviewed, add myself as a WebKit committer.
[WebKit-https.git] / Tools / ChangeLog
1 2018-05-18  Basuke Suzuki  <basuke.suzuki@sony.com>
2
3         Unreviewed, add myself as a WebKit committer.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2018-06-15  Chris Dumez  <cdumez@apple.com>
8
9         Add API test coverage for SW RegistrationDatabase destruction and fix issues found by the test
10         https://bugs.webkit.org/show_bug.cgi?id=186681
11
12         Reviewed by Brady Eidson.
13
14        Add API test coverage.
15
16         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
17
18 2018-06-15  Brady Eidson  <beidson@apple.com>
19
20         Crash in both StorageProcess and UIProcess when using custom WKWebsiteDataStores for data management.
21         <rdar://problem/41019893> and https://bugs.webkit.org/show_bug.cgi?id=186682
22
23         Reviewed by Chris Dumez.
24
25         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
26         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
27         (TEST):
28
29 2018-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
30
31         [GTK] Fix adding error in browserperfdash_runner.
32
33         Unreviewed follow-up fix after r232820.
34
35         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
36         (BrowserPerfDashRunner.run):
37
38 2018-06-15  Carlos Alberto Lopez Perez  <clopez@igalia.com>
39
40         [GTK][WKE] Disable memory pressure handling when running layout tests (WTR)
41         https://bugs.webkit.org/show_bug.cgi?id=186663
42
43         Reviewed by Michael Catanzaro.
44
45         Disable memory pressure handling when running tests via WTR by
46         setting WEBKIT_DISABLE_MEMORY_PRESSURE_MONITOR=1 on the environment.
47
48         * WebKitTestRunner/gtk/main.cpp:
49         (main):
50         * WebKitTestRunner/wpe/main.cpp:
51         (main):
52
53 2018-06-15  Jonathan Bedard  <jbedard@apple.com>
54
55         Add iOS 12 and watchOS 5 to webkitpy
56         https://bugs.webkit.org/show_bug.cgi?id=186285
57
58         Reviewed by Aakash Jain.
59
60         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
61         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
62         Trigger the right build queues for iOS 12 on check-in.
63         * Scripts/webkitpy/common/version_name_map.py:
64         (VersionNameMap.__init__): Add iOS 12, tvOS 12 and watchOS 5.
65         * Scripts/webkitpy/common/version_name_map_unittest.py:
66         (VersionMapTestCase.test_ios_name_by_version): Test iOS 12 version-name mapping.
67         * Scripts/webkitpy/port/ios_device_unittest.py:
68         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
69         * Scripts/webkitpy/port/ios_simulator_unittest.py:
70         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
71
72 2018-06-14  Saam Barati  <sbarati@apple.com>
73
74         sun spider compile time benchmark fails in run-jsc-benchmarks with JSC_validateOptions=1
75         https://bugs.webkit.org/show_bug.cgi?id=186647
76
77         Reviewed by Yusuke Suzuki.
78
79         Let's use `unset JSC_useBlah` instead of `export JSC_useBlah=` to clear environment
80         variables. The latter was causing crashes with when JSC_validateOptions was true.
81
82         * Scripts/run-jsc-benchmarks:
83
84 2018-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
85
86         [GTK][buildbot] Raise timeouts for the step benchmark-test on the GTK perf bot
87         https://bugs.webkit.org/show_bug.cgi?id=186635
88
89         Reviewed by Michael Catanzaro.
90
91         The current maximum timeout for a run-benchmark test is 1800 (Motionmark plan),
92         but the buildbot default timeout for the whole step without text output is 1200.
93         That means that a timeout on a single test can cause a whole step abort because
94         the buildbot one will trigger first.
95
96         Set the benchmark-test step timeout to 2000 to avoid this.
97
98         When this benchmark-test was added in r197505 it was already added with a higher
99         timeout than default (1500) due to the above problem, but it seems this has been
100         ignored so far because buildbot won't accept the timeout to be set on the class
101         definition (not even on the class constructor).
102         The new timeout has to be defined in the addStep call itself.
103         I have double-checked that by testing locally with the script run-buildbot-test.py
104         And this upstream issue confirms that https://github.com/buildbot/buildbot/issues/3887
105
106         * BuildSlaveSupport/build.webkit.org-config/factories.py:
107         (BuildAndPerfTestFactory.__init__):
108         (DownloadAndPerfTestFactory.__init__):
109         * BuildSlaveSupport/build.webkit.org-config/steps.py:
110         (RunBenchmarkTests):
111
112 2018-06-14  Roy Reapor  <rreapor@apple.com>
113
114         Use new jQuery file layout
115         https://bugs.webkit.org/show_bug.cgi?id=186636
116
117         Reviewed by Aakash Jain.
118
119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
121         * TestResultServer/static-dashboards/run-embedded-unittests.html:
122
123 2018-06-14  Basuke Suzuki  <Basuke.Suzuki@sony.com>
124
125         [Win][MiniBrowser] Change to use WebKit by default if it's available
126         https://bugs.webkit.org/show_bug.cgi?id=186633
127
128         When MiniBrowser is built with WebKit, use it by default. Also add command
129         line switch for WebKitLegacy.
130
131         Reviewed by Youenn Fablet.
132
133         * MiniBrowser/win/Common.cpp:
134         (parseCommandLine):
135         (dllLauncherEntryPoint): Deleted.
136         * MiniBrowser/win/Common.h:
137         * MiniBrowser/win/WinMain.cpp:
138         (wWinMain):
139         (dllLauncherEntryPoint):
140
141 2018-06-14  Matt Lewis  <jlewis3@apple.com>
142
143         Unreviewed, rolling out r232823.
144
145         This caused both test timeouts and api failures.
146
147         Reverted changeset:
148
149         "[Mail] Use the Mail Viewer width as the base for resolving
150         horizontal viewport units"
151         https://bugs.webkit.org/show_bug.cgi?id=186585
152         https://trac.webkit.org/changeset/232823
153
154 2018-06-14  Youenn Fablet  <youenn@apple.com>
155
156         TestWebKitAPI.WebKit.WKNavigationResponsePDFType fails after r232815
157         https://bugs.webkit.org/show_bug.cgi?id=186631
158
159         Reviewed by Chris Dumez.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
162         (TEST): Update PDF plug-in identifier.
163
164 2018-06-14  Leo Balter  <leonardo.balter@gmail.com>
165
166         [test262-runner] Improve displayed settings, use rel paths
167         https://bugs.webkit.org/show_bug.cgi?id=186626
168
169         Reviewed by Michael Saboff.
170
171         Use relative paths for the information printed in the settings summary after calling the Test262 Runner. This provides a cleaner summary that is easier to read and consume.
172         * Scripts/test262/Runner.pm:
173         (processCLI):
174         (getBuildPath):
175
176 2018-06-14  Leo Balter  <leonardo.balter@gmail.com>
177
178         Test262-Runner: Add more information in the summarized stats
179         https://bugs.webkit.org/show_bug.cgi?id=185749
180
181         Reviewed by Michael Saboff.
182
183         This patch adds extra information in the summarized stats for the given results for each run.
184         This includes a total of files, a total of executed files and a time information per path and feature.
185         * Scripts/test262/Runner.pm:
186         (summarizeResults):
187
188 2018-06-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
189
190         [GTK] Enable tests on the GTK EWS queue
191         https://bugs.webkit.org/show_bug.cgi?id=186559
192
193         Reviewed by Michael Catanzaro.
194
195         Enable testing for the gtk-wk2 EWS queue.
196
197         * Scripts/webkitpy/common/config/ews.json:
198
199 2018-06-14  Valerie R Young  <valerie@bocoup.com>
200
201         [test262-runner] Test output should summarize tests that are
202         unexpectedly passing/failing.
203         https://bugs.webkit.org/show_bug.cgi?id=186527
204
205         Reviewed by Michael Saboff.
206
207         * Scripts/test262/Runner.pm:
208         (main):
209           In verbose mode, a summary of all new failing tests
210           and all new passing tests are printed at the end of
211           the script output.
212
213 2018-06-14  Zan Dobersek  <zdobersek@igalia.com>
214
215         [GTK][WPE] MiniBrowsers should be able to ignore TLS errors
216         https://bugs.webkit.org/show_bug.cgi?id=186557
217
218         Reviewed by Carlos Garcia Campos.
219
220         Add the --ignore-tls-errors flags to the GTK and WPE MiniBrowsers.
221         Enabling the flag enforces ignoring of TLS errors that occur during
222         load. This is primarily useful for loading test cases from the wpt or
223         run-webkit-httpd servers where testing-purpose certificates are used.
224
225         * MiniBrowser/gtk/main.c:
226         (main):
227         * MiniBrowser/wpe/main.cpp:
228         (main):
229
230 2018-06-13  Adrian Perez de Castro  <aperez@igalia.com>
231
232         [WPE] Trying to access the remote inspector hits an assertion in the UIProcess
233         https://bugs.webkit.org/show_bug.cgi?id=186588
234
235         Reviewed by Carlos Garcia Campos.
236
237         Make both the WPE and GTK+ ports use /org/webkit/inspector as base prefix
238         for resource paths, which avoids needing a switcheroo depending on the port.
239
240         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
241         (WTR::TestRunner::inspectorTestStubURL):
242         * glib/generate-inspector-gresource-manifest.py:
243
244 2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
245
246         [GTK] Add a script to upload the data generated with run-benchmark to a browserperfdash server and use it on the gtk perf bot
247         https://bugs.webkit.org/show_bug.cgi?id=166885
248
249         Reviewed by Michael Catanzaro.
250
251         This patch adds a new script that will execute run-benchmark and upload the results it generates to a browserperfdash web app.
252
253         It also modifies the buildbot config file so the GTK performance bot runs this script on the perf-test step.
254
255         * BuildSlaveSupport/build.webkit.org-config/steps.py:
256         (RunBenchmarkTests):
257         * Scripts/browserperfdash-benchmark: Added.
258         * Scripts/webkitpy/browserperfdash/README: Added.
259         * Scripts/webkitpy/browserperfdash/__init__.py: Added.
260         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: Added.
261         (parse_args):
262         (BrowserPerfDashRunner):
263         (BrowserPerfDashRunner.__init__):
264         (BrowserPerfDashRunner._parse_config_file):
265         (BrowserPerfDashRunner._get_test_version_string):
266         (BrowserPerfDashRunner._get_test_data_json_string):
267         (BrowserPerfDashRunner._upload_result):
268         (BrowserPerfDashRunner.run):
269         (format_logger):
270         (main):
271         * Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py: Added.
272         (FakeBenchmarkRunner):
273         (FakeBenchmarkRunner.__init__):
274         (FakeBenchmarkRunner.execute):
275         (BrowserPerfDashRunnerTest):
276         (BrowserPerfDashRunnerTest.test_list_plans_at_least_five):
277         (BrowserPerfDashRunnerTest.test_benchmark_runner_subclasses_at_least_two):
278         (BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):
279         * Scripts/webkitpy/browserperfdash/config-file-example.txt: Added.
280
281 2018-06-13  David Fenton  <david_fenton@apple.com>
282
283         Unreviewed, add myself as a WebKit committer.
284
285         * Scripts/webkitpy/common/config/contributors.json:
286
287 2018-06-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
288
289         [JSCOnly] Add a MIPS32el JSCOnly EWS (follow-up fix)
290         https://bugs.webkit.org/show_bug.cgi?id=186523
291
292         Unreviewed follow-up fix after r232748
293
294         * Scripts/webkitpy/common/config/ports.py:
295         (JscOnlyPort.build_jsc_command): It is needed to pass a --jsc-only argument to the build-jsc script.
296         * Scripts/webkitpy/common/config/ports_unittest.py:
297         (DeprecatedPortTest.test_jsconly_port):
298
299 2018-06-12  Thibault Saunier  <tsaunier@igalia.com>
300
301         webkitpy: Implement coredumpctl support on linux
302         https://bugs.webkit.org/show_bug.cgi?id=184039
303
304         Reviewed by Daniel Bates.
305
306         And start using an Executive to run subprocesses
307         in GDBCrashLogGenerator.
308
309         Unit tests adapted to the new API and still passing.
310
311         * Scripts/webkitpy/port/linux_get_crash_log.py:
312         (GDBCrashLogGenerator):
313         (GDBCrashLogGenerator._get_trace_from_systemd):
314         (GDBCrashLogGenerator.generate_crash_log):
315
316 2018-06-12  Valerie R Young  <valerie@bocoup.com>
317
318         test262/Runner.pm: fix one test (can't find jsc)
319         https://bugs.webkit.org/show_bug.cgi?id=186573
320
321         Reviewed by Michael Saboff.
322
323         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl:
324         fix subtest to use mock JSC
325
326 2018-06-12  Tim Horton  <timothy_horton@apple.com>
327
328         Add a API test for r232601
329         https://bugs.webkit.org/show_bug.cgi?id=186417
330
331         Reviewed by Wenson Hsieh.
332
333         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
334         (immediateSubviewOfClass):
335         (TEST):
336         Ensure that we put the view hierarchy back together (move WKContentView
337         out of the animated resize view) and unhide WKContentView after a
338         resize-with-hidden-content.
339
340 2018-06-12  Valerie R Young  <valerie@bocoup.com>
341
342         test262/Runner.pm: add unit tests
343         https://bugs.webkit.org/show_bug.cgi?id=185783
344
345         Reviewed by Michael Saboff.
346
347         * Scripts/webkitperl/test262_unittest/README: Added.
348         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
349         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
350         * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail-new-error.pl: Added.
351         * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-fail.pl: Added.
352         * Scripts/webkitperl/test262_unittest/fixtures/mock-jsc-pass.pl: Added.
353         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
354         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
355         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
356         (f):
357         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
358         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
359         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
360         (f):
361         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
362
363 2018-06-12  Valerie R Young  <valerie@bocoup.com>
364
365         test262/Runner.pm: minor updates
366         https://bugs.webkit.org/show_bug.cgi?id=186399
367
368         - If harness files cannot be found in a CLI supplied
369         test262 path, then default to webkit's test262 harness files.
370         - Lazily create the test262-results directory (only right before
371         writing to it)
372        - If an expectation file is supplied via the CLI, save to the
373         supplied location instead of the default webkit location
374         (JSTest/test262/expectation.yaml).
375
376         Reviewed by Michael Saboff.
377
378         * Scripts/test262/Runner.pm:
379         (processCLI):
380         (main):
381         (compileTest):
382         (processResult):
383         (getHarness):
384         (summarizeResults):
385
386 2018-06-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
387
388         [JSCOnly] Add a MIPS32el JSCOnly EWS
389         https://bugs.webkit.org/show_bug.cgi?id=186523
390
391         Reviewed by Michael Catanzaro.
392
393         Add a new jsc-mips-ews queue that will execute build-jsc for the jsc-only (Linux) port.
394         The worker(s) on this queue should be pre-configured to cross-build JSC for MIPS32el.
395
396         * QueueStatusServer/config/queues.py:
397         * QueueStatusServer/model/queues.py:
398         (Queue.display_name):
399         * Scripts/webkitpy/common/config/ews.json:
400         * Scripts/webkitpy/common/config/ports.py:
401         (DeprecatedPort.port):
402         (WpePort.run_webkit_tests_command):
403         (JscOnlyPort):
404         (JscOnlyPort.build_jsc_command):
405         * Scripts/webkitpy/common/config/ports_unittest.py:
406         (DeprecatedPortTest.test_wincairo_port):
407         (DeprecatedPortTest):
408         (DeprecatedPortTest.test_jsconly_port):
409         * Scripts/webkitpy/port/factory.py:
410         (PortFactory):
411         * Scripts/webkitpy/port/jsc_only.py: Added. Add a basic port definition. Required by the EWS tooling.
412         (JscOnlyPort):
413         (JscOnlyPort.__init__):
414         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
415         (test_ews_name):
416
417 2018-06-12  Zan Dobersek  <zdobersek@igalia.com>
418
419         Add run-web-platform-tests script
420         https://bugs.webkit.org/show_bug.cgi?id=183356
421
422         Reviewed by Carlos Alberto Lopez Perez.
423
424         Add the run-web-platform-tests script that allows running WebKit builds
425         against the external web-platform-tests project.
426
427         The script sets up all the port-specific information, including the
428         display driver. If no web-platform-tests repository location is
429         specified, the TestDownloader utility is used to clone the repository,
430         and path to that clone is leveraged instead.
431
432         Port-specific TestManifest.ini and TestExpectations.json file paths are
433         then constructed, bailing if any of the files is missing. The JSON file
434         is then used to construct the metadata file tree, creating an .ini file
435         for each test that is disabled, has a certain expectation, or has
436         subtests that themselves have certain expectations. This metadata tree
437         is built under the build directory, and is purged and reconstructed for
438         each separate run.
439
440         Lastly, the WPT python module is imported from the web-platform-tests
441         source location, and wpt.main() is invoked along with all the necessary
442         arguments that set up a web-platform-tests suite run using the WebKit
443         product.
444
445         * Scripts/run-web-platform-tests: Added.
446         * Scripts/webkitpy/common/config/ports_mock.py:
447         (MockPort.run_bindings_tests_command):
448         (MockPort):
449         (MockPort.wpt_metadata_directory):
450         (MockPort.wpt_manifest_file):
451         * Scripts/webkitpy/port/base.py:
452         (Port.wpt_metadata_directory):
453         (Port):
454         (Port.wpt_manifest_file):
455         * Scripts/webkitpy/w3c/common.py:
456         (is_file_exportable):
457         (WPTPaths):
458         (WPTPaths.checkout_directory):
459         (WPTPaths.wpt_checkout_path):
460         * Scripts/webkitpy/w3c/test_downloader.py:
461         (TestDownloader.clone_tests):
462         (TestDownloader):
463         (TestDownloader.download_tests):
464         * Scripts/webkitpy/w3c/test_exporter.py:
465         (WebPlatformTestExporter.__init__):
466         * Scripts/webkitpy/w3c/wpt_runner.py: Added.
467         (main):
468         (parse_args):
469         (create_webdriver):
470         (spawn_wpt):
471         (WPTRunner):
472         (WPTRunner.__init__):
473         (WPTRunner._prepare_wpt_checkout):
474         (WPTRunner._generate_metadata_directory):
475         (WPTRunner.run):
476         * Scripts/webkitpy/w3c/wpt_runner_unittest.py: Added.
477         (WPTRunnerTest):
478         (WPTRunnerTest.MockTestDownloader):
479         (WPTRunnerTest.MockTestDownloader.default_options):
480         (WPTRunnerTest.MockTestDownloader.__init__):
481         (WPTRunnerTest.MockTestDownloader.clone_tests):
482         (WPTRunnerTest.MockWebDriver):
483         (WPTRunnerTest.MockWebDriver.create):
484         (WPTRunnerTest.MockWebDriver.binary_path):
485         (WPTRunnerTest.MockWebDriver.browser_path):
486         (WPTRunnerTest.MockWebDriver.browser_args):
487         (WPTRunnerTest.MockSpawnWPT):
488         (WPTRunnerTest.MockSpawnWPT.__init__):
489         (WPTRunnerTest.MockSpawnWPT.__call__):
490         (WPTRunnerTest.TestInstance):
491         (WPTRunnerTest.TestInstance.__init__):
492         (WPTRunnerTest.TestInstance.prepare_mock_files_for_run):
493         (WPTRunnerTest.test_prepare_wpt_checkout):
494         (WPTRunnerTest.test_prepare_wpt_checkout_specified_path):
495         (WPTRunnerTest.test_generate_metadata_directory):
496         (WPTRunnerTest.test_run):
497         (WPTRunnerTest.test_run_with_specified_options):
498         (WPTRunnerTest.test_run_with_args):
499
500 2018-06-11  Mark Lam  <mark.lam@apple.com>
501
502         Add support for webkit-test-runner jscOptions in DumpRenderTree and WebKitTestRunner.
503         https://bugs.webkit.org/show_bug.cgi?id=186451
504         <rdar://problem/40875792>
505
506         Reviewed by Tim Horton.
507
508         This jscOptions option can be used by a layout test to specify some JSC runtime
509         options needed by the test e.g. by adding something like this to the top of the
510         html file after the DOCTYPE tag:
511             <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true ] -->
512
513         If more than one option is needed, the options can be specified as a comma
514         separated string e.g.
515             <!-- webkit-test-runner [ jscOptions=--useIntlPluralRules=true,--useZombieMode=true ] -->
516
517         This only works with JSC options that can be changed at runtime.  Not all JSC
518         options can be changed this way as some options are only checked and set once at
519         VM / process initialization time: changing this type of options may have no
520         effect.  It's the test writer's responsibility to determine which options are
521         appropriate for with this webkit-test-runner jscOptions option.
522
523         This implementation is a workaround until we can change the run-webkit-tests
524         scripts to parse the option and apply it to a new launch of DRT or WKTR:
525         https://bugs.webkit.org/show_bug.cgi?id=186452
526
527         * DumpRenderTree/TestOptions.cpp:
528         (TestOptions::TestOptions):
529         (TestOptions::webViewIsCompatibleWithOptions const):
530         * DumpRenderTree/TestOptions.h:
531         * DumpRenderTree/mac/DumpRenderTree.mm:
532         (setJSCOptions):
533         (resetWebViewToConsistentStateBeforeTesting):
534         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
535         (WTR::InjectedBundle::didReceiveMessageToPage):
536         * WebKitTestRunner/TestController.cpp:
537         (WTR::TestController::resetStateToConsistentValues):
538         (WTR::updateTestOptionsFromTestHeader):
539         * WebKitTestRunner/TestOptions.h:
540         (WTR::TestOptions::hasSameInitializationOptions const):
541
542 2018-06-11  Brady Eidson  <beidson@apple.com>
543
544         Add a command line default to force WebKitTestRunner to turn on process swap on navigation.
545         https://bugs.webkit.org/show_bug.cgi?id=186534
546
547         Reviewed by Chris Dumez.
548
549         Right now Process Swap On Navigation is enabled on a per-test basis.
550         The future is to enable it by default.
551
552         Adding a 'defaults write' helps us get to that future.
553
554         * WebKitTestRunner/TestController.cpp:
555         (WTR::TestController::testOptionsForTest const):
556         (WTR::TestController::platformAddTestOptions const):
557         * WebKitTestRunner/TestController.h:
558         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
559         (WTR::TestController::platformAddTestOptions const):
560
561 2018-06-11  Chris Dumez  <cdumez@apple.com>
562
563         Allow enabling PSON in layout tests without window.open support
564         https://bugs.webkit.org/show_bug.cgi?id=186537
565
566         Reviewed by Geoffrey Garen.
567
568         Allow enabling PSON in layout tests without window.open support since window.open support
569         is far from being ready and we plan to enable PSON in layout tests soon.
570
571         * WebKitTestRunner/TestController.cpp:
572         (WTR::TestController::createWebViewWithOptions):
573         (WTR::updateTestOptionsFromTestHeader):
574         * WebKitTestRunner/TestOptions.h:
575         (WTR::TestOptions::hasSameInitializationOptions const):
576
577 2018-06-11  Brady Eidson  <beidson@apple.com>
578
579         Followup to [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
580         https://bugs.webkit.org/show_bug.cgi?id=186436
581
582         Patch by Darin Adler
583         Reviewed by Brady Eidson.
584
585         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
586         (TestWebKitAPI::TEST):
587
588 2018-06-11  Mark Lam  <mark.lam@apple.com>
589
590         Gardening: skip BigInt tests on iOS until the feature is stable.
591         <rdar://problem/40331121>
592
593         Not reviewed.
594
595         * Scripts/run-jsc-stress-tests:
596
597 2018-06-11  Fujii Hironori  <Hironori.Fujii@sony.com>
598
599         [Win][MiniBrowser] Add WebKitBrowserWindow class for modern WebKit API
600         https://bugs.webkit.org/show_bug.cgi?id=186478
601
602         Reviewed by Alex Christensen.
603
604         Added "New WebKit Window" and "New WebKitLegacy Window" menu
605         items. Disabled the menu item "New WebKit Window" if
606         !ENABLE(WEBKIT).
607
608         * MiniBrowser/win/CMakeLists.txt: Added WebKitBrowserWindow.cpp
609         source file and ENABLE_WEBKIT macro if ENABLE_WEBKIT.
610         * MiniBrowser/win/MainWindow.cpp:
611         (MainWindow::MainWindow):
612         (MainWindow::create):
613         (MainWindow::init):
614         (MainWindow::WndProc):
615         * MiniBrowser/win/MainWindow.h:
616         * MiniBrowser/win/MiniBrowserLib.rc:
617         * MiniBrowser/win/MiniBrowserLibResource.h:
618         * MiniBrowser/win/PrintWebUIDelegate.cpp:
619         (PrintWebUIDelegate::createWebViewWithRequest):
620         * MiniBrowser/win/WebKitBrowserWindow.cpp: Added.
621         (createString):
622         (toUtf8):
623         (createWKString):
624         (createWKURL):
625         (WebKitBrowserWindow::create):
626         (WebKitBrowserWindow::WebKitBrowserWindow):
627         (WebKitBrowserWindow::init):
628         (WebKitBrowserWindow::hwnd):
629         (WebKitBrowserWindow::loadURL):
630         (WebKitBrowserWindow::loadHTMLString):
631         (WebKitBrowserWindow::navigateForwardOrBackward):
632         (WebKitBrowserWindow::navigateToHistory):
633         (WebKitBrowserWindow::setPreference):
634         (WebKitBrowserWindow::print):
635         (WebKitBrowserWindow::launchInspector):
636         (WebKitBrowserWindow::setUserAgent):
637         (WebKitBrowserWindow::userAgent):
638         (WebKitBrowserWindow::showLayerTree):
639         (WebKitBrowserWindow::updateStatistics):
640         (WebKitBrowserWindow::resetZoom):
641         (WebKitBrowserWindow::zoomIn):
642         (WebKitBrowserWindow::zoomOut):
643         (toWebKitBrowserWindow):
644         (WebKitBrowserWindow::didReceiveTitleForFrame):
645         (WebKitBrowserWindow::didCommitLoadForFrame):
646         * MiniBrowser/win/WebKitBrowserWindow.h:
647         * MiniBrowser/win/WinMain.cpp:
648         (wWinMain):
649
650 2018-06-11  Keith Miller  <keith_miller@apple.com>
651
652         Add missing whitespace to run-jsc command
653         https://bugs.webkit.org/show_bug.cgi?id=186528
654
655         Reviewed by Mark Lam.
656
657         * Scripts/run-jsc:
658
659 2018-06-11  Philippe Normand  <pnormand@igalia.com>
660
661         [webkitpy] PHP7.2 support on Debian platforms
662         https://bugs.webkit.org/show_bug.cgi?id=186521
663
664         Reviewed by Michael Catanzaro.
665
666         * Scripts/webkitpy/port/base.py:
667         (Port._debian_php_version): Refactor and add PHP 7.2 version support.
668
669 2018-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
670
671         Unreviewed. Fix WPE API and layout tests after r232670.
672
673         Now that dyz is not installed, there's not -default.so symlink for the WPE backend, so we need to use
674         WPE_BACKEND_LIBRARY environment variable to ensure tests are run with fdo backend.
675
676         * Scripts/run-wpe-tests:
677         (WPETestRunner.__init__):
678         (WPETestRunner):
679         (WPETestRunner.setup_testing_environment):
680         * Scripts/webkitpy/port/wpe.py:
681         (WPEPort.setup_environ_for_server):
682         * glib/api_test_runner.py:
683         (TestRunner.setup_testing_environment):
684         (TestRunner.run_tests):
685         (TestRunner._setup_testing_environment): Deleted.
686
687 2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>
688
689         [GTK][WPE] Add API run run javascript from a WebKitWebView in an isolated world
690         https://bugs.webkit.org/show_bug.cgi?id=186192
691
692         Reviewed by Michael Catanzaro.
693
694         Add tests cases for the new API.
695
696         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
697         (testWebViewRunJavaScript):
698         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
699         (methodCallCallback):
700         (webkit_web_extension_initialize_with_user_data):
701         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
702         (runJavaScriptInWorldReadyCallback):
703         (WebViewTest::runJavaScriptFromGResourceAndWaitUntilFinished):
704         (WebViewTest::runJavaScriptInWorldAndWaitUntilFinished):
705         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
706
707 2018-06-10  Carlos Garcia Campos  <cgarcia@igalia.com>
708
709         [WPE] Add a MiniBrowser and use it to run WebDriver tests
710         https://bugs.webkit.org/show_bug.cgi?id=186345
711
712         Reviewed by Žan Doberšek.
713
714         Most of the code is based on dyz and gtk MiniBrowser. This patch adds a new internal library WPEToolingBackends,
715         including the headless view backend and a new window backend to be used by the MiniBrowser. MiniBrowser can also
716         run in headless mode, by using the headless backend instead of the window one, which will allow us to run the
717         WebDriver tests in the bots.
718
719         * CMakeLists.txt:
720         * MiniBrowser/wpe/CMakeLists.txt: Added.
721         * MiniBrowser/wpe/main.cpp: Added.
722         (automationStartedCallback):
723         (createViewBackend):
724         (main):
725         * Scripts/run-minibrowser: Remove WPE specific code.
726         * Scripts/run-webdriver-tests: Add headless display-server option.
727         * Scripts/webkitdirs.pm:
728         (launcherName): Remove WPE specific code.
729         * Scripts/webkitpy/webdriver_tests/webdriver_driver_wpe.py:
730         (WebDriverWPE.browser_name): Return MiniBrowser.
731         (WebDriverWPE.browser_path): Return the path to the MiniBrowser in build dir.
732         (WebDriverWPE.browser_args): Add --headless when running in headless mode.
733         (WebDriverWPE.capabilities): Use the full browser path.
734         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
735         (WebDriverTestRunnerSelenium.collect_tests): Fix early return value.
736         * TestWebKitAPI/PlatformWPE.cmake: Use WPEToolingBackends instead of HeadlessViewBackend.
737         * TestWebKitAPI/PlatformWebView.h: Ditto.
738         * TestWebKitAPI/glib/PlatformWPE.cmake: Ditto
739         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
740         (Test::createWebViewBackend): Ditto.
741         * TestWebKitAPI/wpe/PlatformWebViewWPE.cpp:
742         (TestWebKitAPI::PlatformWebView::initialize): Ditto.
743         * WebKitTestRunner/PlatformWPE.cmake: Ditto.
744         * WebKitTestRunner/PlatformWebView.h: Ditto.
745         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp:
746         (WTR::PlatformWebView::PlatformWebView): Ditto.
747         * wpe/HeadlessViewBackend/CMakeLists.txt: Removed.
748         * wpe/backends/CMakeLists.txt: Added.
749         * wpe/backends/HeadlessViewBackend.cpp: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.cpp.
750         (WPEToolingBackends::getEGLDisplay):
751         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
752         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
753         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
754         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
755         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
756         * wpe/backends/HeadlessViewBackend.h: Renamed from Tools/wpe/HeadlessViewBackend/HeadlessViewBackend.h.
757         * wpe/backends/ViewBackend.cpp: Added.
758         (WPEToolingBackends::ViewBackend::ViewBackend):
759         (WPEToolingBackends::ViewBackend::~ViewBackend):
760         (WPEToolingBackends::ViewBackend::initialize):
761         (WPEToolingBackends::ViewBackend::setInputClient):
762         (WPEToolingBackends::ViewBackend::backend const):
763         (WPEToolingBackends::ViewBackend::dispatchInputPointerEvent):
764         (WPEToolingBackends::ViewBackend::dispatchInputAxisEvent):
765         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
766         * wpe/backends/ViewBackend.h: Added.
767         * wpe/backends/WindowViewBackend.cpp: Added.
768         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
769         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
770         (WPEToolingBackends::WindowViewBackend::displayBuffer):
771         (WPEToolingBackends::WindowViewBackend::handleKeyEvent):
772         * wpe/backends/WindowViewBackend.h: Added.
773         * wpe/jhbuild.modules: Remove dyz and add wayland-protocols.
774
775 2018-06-10  Fujii Hironori  <Hironori.Fujii@sony.com>
776
777         [Win][MiniBrowser] MiniBrowser class should be renamed to WebKitLegacyBrowserWindow
778         https://bugs.webkit.org/show_bug.cgi?id=186427
779
780         Reviewed by Ryosuke Niwa.
781
782         * MiniBrowser/win/AccessibilityDelegate.cpp:
783         * MiniBrowser/win/AccessibilityDelegate.h:
784         (AccessibilityDelegate::AccessibilityDelegate):
785         * MiniBrowser/win/CMakeLists.txt: Removed MiniBrowser.cpp. Added WebKitLegacyBrowserWindow.cpp.
786         * MiniBrowser/win/Common.h:
787         * MiniBrowser/win/MainWindow.cpp:
788         (MainWindow::init):
789         * MiniBrowser/win/MainWindow.h:
790         * MiniBrowser/win/MiniBrowserWebHost.cpp:
791         * MiniBrowser/win/MiniBrowserWebHost.h:
792         (MiniBrowserWebHost::MiniBrowserWebHost):
793         * MiniBrowser/win/PageLoadTestClient.cpp:
794         (PageLoadTestClient::PageLoadTestClient):
795         * MiniBrowser/win/PageLoadTestClient.h:
796         * MiniBrowser/win/PrintWebUIDelegate.cpp:
797         (PrintWebUIDelegate::createWebViewWithRequest):
798         * MiniBrowser/win/PrintWebUIDelegate.h:
799         (PrintWebUIDelegate::PrintWebUIDelegate):
800         * MiniBrowser/win/ResourceLoadDelegate.cpp:
801         * MiniBrowser/win/ResourceLoadDelegate.h:
802         (ResourceLoadDelegate::ResourceLoadDelegate):
803         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp: Renamed from Tools/MiniBrowser/win/MiniBrowser.cpp.
804         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Renamed from Tools/MiniBrowser/win/MiniBrowser.h.
805         * MiniBrowser/win/WebDownloadDelegate.cpp:
806         (WebDownloadDelegate::WebDownloadDelegate):
807         * MiniBrowser/win/WebDownloadDelegate.h:
808
809 2018-06-10  Chris Dumez  <cdumez@apple.com>
810
811         Reload the Web view in case of crash if the client does not implement webViewWebContentProcessDidTerminate delegate
812         https://bugs.webkit.org/show_bug.cgi?id=186468
813
814         Reviewed by Geoffrey Garen.
815
816         Add API test coverage.
817
818         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
819         (-[BasicNavigationDelegateWithoutCrashHandler webView:didStartProvisionalNavigation:]):
820         (-[BasicNavigationDelegateWithoutCrashHandler webView:didFinishNavigation:]):
821         (TEST):
822
823 2018-06-10  Michael Catanzaro  <mcatanzaro@igalia.com>
824
825         [WPE][GTK] paypal.com requires user agent quirk
826         https://bugs.webkit.org/show_bug.cgi?id=186466
827
828         Reviewed by Carlos Garcia Campos.
829
830         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
831         (TestWebKitAPI::TEST):
832
833 2018-06-09  Dan Bernstein  <mitz@apple.com>
834
835         [Xcode] Clean up and modernize some build setting definitions
836         https://bugs.webkit.org/show_bug.cgi?id=186463
837
838         Reviewed by Sam Weinig.
839
840         * DumpRenderTree/mac/Configurations/Base.xcconfig: Removed definition for macOS 10.11.
841           Simplified the definition of WK_PRIVATE_FRAMEWORK_STUBS_DIR now that
842           WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all supported Xcode versions.
843         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Removed definition for macOS
844           10.11.
845         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
846         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
847         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
848         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
849         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Simplified the definitions of
850           ENABLE_APPLE_PAY and ENABLE_VIDEO_PRESENTATION_MODE now macOS 10.12 is the earliest
851           supported version.
852         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig: Removed definitions for
853           macOS 10.11.
854         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also simplified the definition of
855           WK_PRIVATE_FRAMEWORK_STUBS_DIR now that WK_XCODE_SUPPORTS_TEXT_BASED_STUBS is true for all
856           supported Xcode versions
857         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Removed definition for macOS 10.11.
858
859 2018-06-09  Dan Bernstein  <mitz@apple.com>
860
861         Added missing file references to the Configuration group.
862
863         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
864
865 2018-06-08  Darin Adler  <darin@apple.com>
866
867         [Cocoa] Remove all uses of NSAutoreleasePool as part of preparation for ARC
868         https://bugs.webkit.org/show_bug.cgi?id=186436
869
870         Reviewed by Anders Carlsson.
871
872         * TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsTest.mm:
873         (TestWebKitAPI::WebKit2CustomProtocolsTest_ProcessPoolDestroyedDuringLoading):
874         Use @autoreleasepool.
875         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
876         (TestWebKitAPI::buildAndPerformTest): Ditto.
877         * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm:
878         (TestWebKitAPI::WebKitLegacy_StopLoadingFromDidFinishLoading): Ditto.
879
880 2018-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
881
882         [WebKit on watchOS] Upstream watchOS source additions to OpenSource (Part 1)
883         https://bugs.webkit.org/show_bug.cgi?id=186442
884         <rdar://problem/40879364>
885
886         Reviewed by Tim Horton.
887
888         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
889
890 2018-06-08  Alicia Boya García  <aboya@igalia.com>
891
892         [GTK] Update to libva-2.1.0 in jhbuild
893         https://bugs.webkit.org/show_bug.cgi?id=186434
894
895         Reviewed by Philippe Normand.
896
897         * gstreamer/jhbuild.modules:
898
899 2018-06-07  Yusuke Suzuki  <utatane.tea@gmail.com>
900
901         [WTF] Add WorkerPool
902         https://bugs.webkit.org/show_bug.cgi?id=174569
903
904         Reviewed by Carlos Garcia Campos.
905
906         * TestWebKitAPI/CMakeLists.txt:
907         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
908         * TestWebKitAPI/Tests/WTF/WorkerPool.cpp: Added.
909         (TestWebKitAPI::TEST):
910
911 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
912
913         [Win][MiniBrowser] Add a new BrowserWindow interface to abstract WK1 and WK2 BrowserWindow
914         https://bugs.webkit.org/show_bug.cgi?id=186421
915
916         Reviewed by Ryosuke Niwa.
917
918         This is the core patch to make MiniBrowser to support WK1 and WK2
919         windows (Bug 184770).
920
921         I will rename MiniBrowser class to WK1BrowserWindow in a follow-up
922         patch (Bug 184770 Comment 12).
923
924         * MiniBrowser/win/BrowserWindow.h: Added.
925         * MiniBrowser/win/MainWindow.cpp:
926         (MainWindow::WndProc):
927         * MiniBrowser/win/MainWindow.h:
928         (MainWindow::browserWindow const):
929         * MiniBrowser/win/MiniBrowser.cpp:
930         (MiniBrowser::create):
931         (MiniBrowser::navigateForwardOrBackward): Removed the unsed first argument hWnd.
932         (MiniBrowser::navigateToHistory): Ditto.
933         * MiniBrowser/win/MiniBrowser.h: Inherit BrowserWindow interface.
934         Make all other methods private and make delegates classes friends.
935         * MiniBrowser/win/PrintWebUIDelegate.cpp:
936         (PrintWebUIDelegate::createWebViewWithRequest):
937
938 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
939
940         [Win][MiniBrowser] MiniBrowser::updateDeviceScaleFactor should be a MainWindow's method
941         https://bugs.webkit.org/show_bug.cgi?id=186387
942
943         Reviewed by Ryosuke Niwa.
944
945         MiniBrowser::updateDeviceScaleFactor does nothing for MiniBrowser.
946         It should be a MainWindow's method.
947
948         * MiniBrowser/win/MainWindow.cpp:
949         (MainWindow::init): Call MainWindow::updateDeviceScaleFactor.
950         (MainWindow::resizeSubViews): Do not set a font every time window size is changed.
951         (MainWindow::WndProc): Call MainWindow::updateDeviceScaleFactor on WM_DPICHANGED.
952         (MainWindow::updateDeviceScaleFactor): Converted from
953         MiniBrowser::updateDeviceScaleFactor and
954         MiniBrowser::generateFontForScaleFactor. Set a URL bar's font if DPI is changed.
955         * MiniBrowser/win/MainWindow.h:
956         * MiniBrowser/win/MiniBrowser.cpp:
957         (MiniBrowser::init):
958         (MiniBrowser::generateFontForScaleFactor): Deleted.
959         (MiniBrowser::updateDeviceScaleFactor): Deleted.
960         * MiniBrowser/win/MiniBrowser.h:
961         (MiniBrowser::deviceScaleFactor): Deleted.
962         (MiniBrowser::urlBarFont): Deleted.
963
964 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
965
966         [webkitpy] Treat svn versions as Version objects
967         https://bugs.webkit.org/show_bug.cgi?id=186403
968         <rdar://problem/40904860>
969
970         Reviewed by Dan Bernstein.
971
972         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
973         * Scripts/webkitpy/common/checkout/scm/svn.py:
974         (SVN.svn_version): Return Version object instead of string.
975         (SVN._status_regexp): Convert version string to Version object.
976         (SVN.add_list): Ditto.
977
978 2018-06-07  Tadeu Zagallo  <tzagallo@apple.com>
979
980         Don't try to allocate JIT memory if we don't have the JIT entitlement
981         https://bugs.webkit.org/show_bug.cgi?id=182605
982         <rdar://problem/38271229>
983
984         Reviewed by Mark Lam.
985
986         Add the Security framework to the TestWTF target, since it's required by the new function to check the entitlements.
987
988         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
989
990 2018-06-07  Mark Lam  <mark.lam@apple.com>
991
992         Enhance run-jsc-stress-tests to allow a test to specify test specific options required for it to run.
993         https://bugs.webkit.org/show_bug.cgi?id=186409
994         <rdar://problem/40909007>
995
996         Reviewed by Saam Barati.
997
998         This is needed because some tests are written with specific features in mind, and
999         we may not necessarily want to enable that option for all tests.
1000
1001         We can now specify something like this at the top of a test file:
1002             //@ requireOptions("--useIntlPluralRules=true")
1003
1004         ... and ensure that that test will be run with the --useIntlPluralRules=true
1005         option for all test configurations that run the test.
1006
1007         * Scripts/run-jsc-stress-tests:
1008
1009 2018-06-07  Tim Horton  <timothy_horton@apple.com>
1010
1011         REGRESSION (r232544): [iOS] TestWebKitAPI.WebKit.OverrideLayoutSizeChangesDuringAnimatedResizeSucceed is failing
1012         https://bugs.webkit.org/show_bug.cgi?id=186395
1013         <rdar://problem/40902427>
1014
1015         Reviewed by Wenson Hsieh.
1016
1017         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1018         (TEST):
1019         endAnimatedResize no longer synchronizes, so we have to wait for the next presentation update.
1020
1021 2018-06-07  Thibault Saunier  <tsaunier@igalia.com>
1022
1023         [GTK][WPE] Start implementing MediaStream API
1024         https://bugs.webkit.org/show_bug.cgi?id=185787
1025
1026         Reviewed by Philippe Normand.
1027
1028         * Scripts/webkitpy/style/checker.py: Apply special formatting rules for new GObject subclasses.
1029         * gstreamer/jhbuild.modules: Added a patch for the gst-plugins-base.
1030         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch:
1031         Added this fix to gst-plugings-base to fix the decodebin3. Merged as 89d0e9cc92a86aa0227ee87406737b6d31670aea
1032
1033 2018-06-07  Brendan McLoughlin  <brendan@bocoup.com>
1034
1035         Update web-platform-tests github location in webkitpy.w3c.test_importer
1036         https://bugs.webkit.org/show_bug.cgi?id=186392
1037
1038         Reviewed by Youenn Fablet.
1039
1040         * Scripts/webkitpy/w3c/test_importer.py:
1041         (TestImporter.write_import_log):
1042
1043 2018-06-07  Jonathan Bedard  <jbedard@apple.com>
1044
1045         webkitperl: Generalize .internal SDK suffix
1046         https://bugs.webkit.org/show_bug.cgi?id=186352
1047         <rdar://problem/40853947>
1048
1049         Reviewed by Alexey Proskuryakov.
1050
1051         * Scripts/build-webkit:
1052         * Scripts/package-root:
1053         (usage):
1054         * Scripts/webkitdirs.pm:
1055         (parseAvailableXcodeSDKS): Parse 'xcodebuild -showsdks' output.
1056         (availableXcodeSDKS): Generate a list of all available Xcode SDKs on this machine.
1057         (determineXcodeSDK): Always prefer .internal SDKs if available.
1058         * Scripts/webkitperl/webkitdirs_unittest/availableXcodeSDKS.pl:
1059
1060 2018-06-07  Fujii Hironori  <Hironori.Fujii@sony.com>
1061
1062         [Win][MiniBrowser] Support multiple windows properly
1063         https://bugs.webkit.org/show_bug.cgi?id=186263
1064
1065         Reviewed by Ryosuke Niwa.
1066
1067         The current implementation of
1068         PrintWebUIDelegate::createWebViewWithRequest is wrong. It is using
1069         CreateProcess to open a new window, and doesn't return the new
1070         instance of IWebView. As the result, for example, window.close
1071         doesn't work as expected.
1072
1073         In this change, a new MainWindow is created and return the
1074         IWebView in PrintWebUIDelegate::createWebViewWithRequest.
1075
1076         In addition to it, this change unifies the lifetime of MiniBrowser
1077         and its delegates AccessibilityDelegate, PrintWebUIDelegate,
1078         ResourceLoadDelegate and WebDownloadDelegate in order to keep
1079         MiniBrowser alive as long as the delegates live. Because the
1080         window of webview keeps references of such delegates and accesses
1081         those after MiniBrowser destruction.
1082
1083         * MiniBrowser/win/MainWindow.h: Added s_numInstances class member
1084         to count the number of instance to close the application. Do not
1085         use unique_ptr for m_browserWindow because it has ref count now.
1086         * MiniBrowser/win/MainWindow.cpp:
1087         (MainWindow::MainWindow): Increment s_numInstances.
1088         (MainWindow::~MainWindow): Decrement s_numInstances.
1089         (MainWindow::create):
1090         (MainWindow::init):
1091         (MainWindow::WndProc): Rename thiz to thisWindow. Keep this
1092         instance alive during this function by using RefPtr<MainWindow>.
1093         Deref the MainWindow instance on WM_DESTROY. Quit the application
1094         when the last MainWindow is closed.
1095         (MainWindow::cachesDialogProc): Rename thiz to thisWindow.
1096         (MainWindow::customUserAgentDialogProc): Ditto.
1097         * MiniBrowser/win/MiniBrowser.h: Added declarations AddRef and Release.
1098         * MiniBrowser/win/MiniBrowser.cpp:
1099         (MiniBrowser::create):
1100         (MiniBrowser::AddRef):
1101         (MiniBrowser::Release):
1102         (MiniBrowser::init): Passes this to the constructors of delegates.
1103         * MiniBrowser/win/AccessibilityDelegate.cpp:
1104         (AccessibilityDelegate::AddRef): Delegate to MiniBrowser.
1105         (AccessibilityDelegate::Release): Ditto.
1106         * MiniBrowser/win/AccessibilityDelegate.h: Removed m_refCount.
1107         (AccessibilityDelegate::AccessibilityDelegate):
1108         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1109         (MiniBrowserWebHost::AddRef): Delegate to MiniBrowser.
1110         (MiniBrowserWebHost::Release): Ditto.
1111         * MiniBrowser/win/MiniBrowserWebHost.h: Removed m_refCount.
1112         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1113         (PrintWebUIDelegate::createWebViewWithRequest): Create a new
1114         MainWindow and return the IWebView.
1115         (PrintWebUIDelegate::AddRef): Delegate to MiniBrowser.
1116         (PrintWebUIDelegate::Release): Ditto.
1117         * MiniBrowser/win/PrintWebUIDelegate.h: Removed m_refCount.
1118         (PrintWebUIDelegate::PrintWebUIDelegate):
1119         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1120         (ResourceLoadDelegate::AddRef): Delegate to MiniBrowser.
1121         (ResourceLoadDelegate::Release): Ditto.
1122         * MiniBrowser/win/ResourceLoadDelegate.h: Removed m_refCount.
1123         * MiniBrowser/win/WebDownloadDelegate.cpp:
1124         (WebDownloadDelegate::WebDownloadDelegate):
1125         (WebDownloadDelegate::AddRef): Delegate to MiniBrowser.
1126         (WebDownloadDelegate::Release): Ditto.
1127         * MiniBrowser/win/WebDownloadDelegate.h: Removed m_refCount.
1128
1129 2018-06-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1130
1131         [Win][MiniBrowser] Remove gMainWindow global variable
1132         https://bugs.webkit.org/show_bug.cgi?id=186378
1133
1134         Reviewed by Ryosuke Niwa.
1135
1136         I'm going to support multiple MainWindow in Bug 186263. It should
1137         not be assumed that MainWindow has only one instance. gMainWindow
1138         is used only in DisplayAuthDialog.
1139
1140         * MiniBrowser/win/Common.cpp:
1141         (authDialogProc): Use DWLP_USER to store the dialog data.
1142         (displayAuthDialog): Moved and renamed from
1143         MainWindow::displayAuthDialog. Use DialogBoxParam instead of
1144         DialogBox to pass a data pointer. Do not return S_OK if
1145         DialogBoxParam returns -1. Take a HWND argument as the parent
1146         window.
1147         (DisplayAuthDialog): Deleted.
1148         * MiniBrowser/win/Common.h:
1149         * MiniBrowser/win/MainWindow.cpp:
1150         (authDialogProc): Moved to Common.cpp.
1151         (MainWindow::displayAuthDialog): Ditto.
1152         * MiniBrowser/win/MainWindow.h:
1153         * MiniBrowser/win/ResourceLoadDelegate.cpp:
1154         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1155         * MiniBrowser/win/WinMain.cpp:
1156         (wWinMain): Added a local variable mainWindow instead of using
1157         gMainWindow.
1158
1159 2018-06-06  Dan Bernstein  <mitz@apple.com>
1160
1161         [Xcode] Opt out of the New Build System
1162         https://bugs.webkit.org/show_bug.cgi?id=186380
1163
1164         Reviewed by Alexey Proskuryakov.
1165
1166         * Scripts/webkitdirs.pm:
1167         (XcodeOptions): Have -UseNewBuildSystem=NO passed to xcodebuild.
1168
1169 2018-06-06  Antoine Quint  <graouts@apple.com>
1170
1171         Rename color-filter to -apple-color-filter and do not expose it to Web content
1172         https://bugs.webkit.org/show_bug.cgi?id=186306
1173         <rdar://problem/39874167>
1174
1175         Reviewed by Simon Fraser.
1176
1177         Adding an option to turn support for the -apple-color-filter property on via an HTML comment.
1178
1179         * DumpRenderTree/TestOptions.cpp:
1180         (TestOptions::TestOptions):
1181         * DumpRenderTree/TestOptions.h:
1182         * DumpRenderTree/mac/DumpRenderTree.mm:
1183         (setWebPreferencesForTestOptions):
1184         * WebKitTestRunner/TestController.cpp:
1185         (WTR::TestController::resetPreferencesToConsistentValues):
1186         (WTR::updateTestOptionsFromTestHeader):
1187         * WebKitTestRunner/TestOptions.h:
1188         (WTR::TestOptions::hasSameInitializationOptions const):
1189         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1190         (WTR::TestController::platformCreateWebView):
1191
1192 2018-06-06  Brent Fulgham  <bfulgham@apple.com>
1193
1194         Adjust compile and runtime flags to match shippable state of features (Part 2)
1195         https://bugs.webkit.org/show_bug.cgi?id=186319
1196         <rdar://problem/40352045>
1197
1198         Unreviewed test fix.
1199
1200         TestWebKitAPI was timing out because 'color' input types are no longer support. I also discovered that the
1201         ASSERT_STREQ macro returns on error, which causes tests to time out whenever a 'done = true' call (needed to
1202         end the test) is done after ASSERT_STREQ, which might fail and return early, preventing the flag from being
1203         set.
1204
1205         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm:
1206         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]): Make testing of
1207         the 'color' input type conditional on the feature being part of the build.
1208         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1209         (-[AutoFillDelegate _webView:didClickAutoFillButtonWithUserInfo:]): Set the 'done=true' state before performing
1210         string equality assertions, since they do an early return and bypass the end state of the test.
1211         (-[DidResignInputElementStrongPasswordAppearanceDelegate _webView:didResignInputElementStrongPasswordAppearanceWithUserInfo:]): Ditto.
1212         (-[AutoFillAvailableDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
1213         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Ditto.
1214
1215 2018-06-05  Chris Dumez  <cdumez@apple.com>
1216
1217         Regression(r232082): Websites get loaded inside of Messages App chat transcript
1218         https://bugs.webkit.org/show_bug.cgi?id=186331
1219         <rdar://problem/40735446>
1220
1221         Reviewed by Darin Adler.
1222
1223         Add API test coverage.
1224
1225         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm:
1226         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1227         (-[NoDecidePolicyForNavigationActionDecisionDelegate webView:didStartProvisionalLoadForFrame:]):
1228         (TestWebKitAPI::TEST):
1229         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): Deleted.
1230         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]): Deleted.
1231         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]): Deleted.
1232
1233 2018-06-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1234
1235         DataInteractionTests ContentEditableToTextarea and ContentEditableToContentEditable are failing on recent iOS 12
1236         https://bugs.webkit.org/show_bug.cgi?id=186325
1237         <rdar://problem/40527850>
1238
1239         Reviewed by Tim Horton.
1240
1241         Tweak these API tests so that they're robust against changes to how NSAttributedStrings are serialized in item
1242         providers ("public.rtf" vs. "com.apple.flat-rtfd"). Across all versions of iOS, just verify that either rich
1243         text type is present in the list of dragged type identifiers, and that the rich text type is placed at a higher
1244         fidelity than plain text.
1245
1246         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1247         (checkRichTextTypePrecedesPlainTextType):
1248         (TestWebKitAPI::TEST):
1249         (checkTypeIdentifierPrecedesOtherTypeIdentifier): Deleted.
1250
1251 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1252
1253         Adjust compile and runtime flags to match shippable state of features
1254         https://bugs.webkit.org/show_bug.cgi?id=186319
1255         <rdar://problem/40352045>
1256
1257         Reviewed by Maciej Stachowiak, Jon Lee, and others.
1258
1259         This patch revises the compile time and runtime state for various features to match their
1260         suitability for end-user releases.
1261
1262         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Update to match WebKit definition of
1263         WK_RELOCATABLE_FRAMEWORKS so that ENABLE(EXPERIMENTAL_FEATURES) is defined properly for
1264         Cocoa builds.
1265         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Don't build ENABLE_INPUT_TYPE_COLOR
1266         or ENABLE_INPUT_TYPE_COLOR_POPOVER.
1267
1268 2018-06-05  Saam Barati  <sbarati@apple.com>
1269
1270         run-testmem should have a dry run option and an option to parse the stdout of executing the dry run
1271         https://bugs.webkit.org/show_bug.cgi?id=186293
1272
1273         Reviewed by Mark Lam.
1274
1275         This makes it easier to execute run-testmem on a device that doesn't have ruby
1276         on it. run-testmem now has a --dry option that will output commands to execute
1277         in bash. To run on a device that doesn't have ruby, just put its output into
1278         a bash script, and copy the PerformanceTests/testmem directory onto that device,
1279         and execute the bash script. Running that bash script will give you raw output.
1280         Make a file with that output and pass it into run-testmem using the --parse option.
1281         run-testmem will parse the raw output and compute the benchmark score.
1282
1283         * Scripts/run-testmem:
1284
1285 2018-06-05  Youenn Fablet  <youenn@apple.com>
1286
1287         ServiceWorker registration should store any script fetched through importScripts
1288         https://bugs.webkit.org/show_bug.cgi?id=182444
1289         <rdar://problem/37164835>
1290
1291         Reviewed by Chris Dumez.
1292
1293         Add support to crash the storage process from Internals.
1294
1295         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1296         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1297         (WTR::TestRunner::terminateStorageProcess):
1298         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1299         * WebKitTestRunner/TestController.cpp:
1300         (WTR::TestController::terminateStorageProcess):
1301         * WebKitTestRunner/TestController.h:
1302         * WebKitTestRunner/TestInvocation.cpp:
1303         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1304
1305 2018-06-05  Brent Fulgham  <bfulgham@apple.com>
1306
1307         Revise DEFAULT_EXPERIMENTAL_FEATURES_ENABLED to work properly on Apple builds
1308         https://bugs.webkit.org/show_bug.cgi?id=186286
1309         <rdar://problem/40782992>
1310
1311         Reviewed by Dan Bernstein.
1312
1313         Use the WK_RELOCATABLE_FRAMEWORKS flag (which is always defined for non-production builds)
1314         to define ENABLE(EXPERIMENTAL_FEATURES) so that we do not need to manually
1315         change this flag when preparing for a production release.
1316
1317         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Use WK_RELOCATABLE_FRAMEWORKS to
1318         determine whether experimental features should be enabled, and use it to properly define
1319         the feature flag.
1320
1321 2018-06-05  Robin Morisset  <rmorisset@apple.com>
1322
1323         Add a grammar (in antlr4 format) to the WSL spec.
1324         https://bugs.webkit.org/show_bug.cgi?id=186310
1325
1326         Rubberstamped by Filip Pizlo
1327
1328         It is just the raw rules, without much comments and no typesetting.
1329         Compiles to any of Java/JS/C++/etc.. with antlr4 (requires a JDK)
1330
1331         It does not exactly match the parser of the current js implementation of WSL, it:
1332         - Accepts negative literals
1333         - Reserves keywords fallthrough/auto
1334         - Refuses '_' as a valid identifier
1335         - Accepts several capitalizations for Null/True/False
1336         - Accepts variable declarations at the top-level
1337         - Correctly parses ternary expressions
1338         - Forbids empty extension list for protocols
1339         - Does not allow a space between '[' and ']' in type suffixes
1340         - Correctly parses nested generics
1341         - Accepts a 'fallthrough;' statement (for switches)
1342         - Refuses chained relational operator (e.g. x < y < z)
1343         - Generally a completely different structure for parsing effectful expressions, although it probably accepts about the same language
1344         - Currently only accepts literals and identifiers as constexpr (while the js parser accepts way too much, including '(x += 42)')
1345         There are probably more differences that I missed. The js parser will probably have to be mostly rewritten to follow the spec more closely (and fix all the bugs).
1346         I will try to see if it can be automatically derived from the antlr4 grammar.
1347
1348         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Added.
1349
1350 2018-06-04  Frederic Wang  <fwang@igalia.com>
1351
1352         import-w3c-tests should rely on <meta name="flags"> to detect CSS manual tests
1353         https://bugs.webkit.org/show_bug.cgi?id=186261
1354
1355         Reviewed by Youenn Fablet.
1356
1357         * Scripts/webkitpy/w3c/test_parser.py:
1358         (TestParser.is_wpt_manualtest): Add code to detect whether a file is a manual test
1359         from its <meta name="flags"> tags. This is based on SourceFile::content_is_css_manual from
1360         the WPT repository.
1361         * Scripts/webkitpy/w3c/test_parser_unittest.py: Add a test to verify whether files with
1362         <meta name="flags"> are manual or non-manual according to CSS WG rules.
1363
1364 2018-06-04  Dan Bernstein  <mitz@apple.com>
1365
1366         Fixed building ImageDiff with the default build system in the Xcode 10 developer beta.
1367
1368         * ImageDiff/cg/Configurations/Base.xcconfig: Use #include? to include
1369           HaveInternalSDK.xcconfig, since it may not be preent.
1370
1371 2018-06-04  Dan Bernstein  <mitz@apple.com>
1372
1373         Fixed building TestWebKitAPI with a shared build directory with XCBuild, which is the
1374         default build system in the Xcode 10 developer beta.
1375
1376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Changed the reference to the
1377           built libWTF.a to be relative to the built products directory.
1378
1379 2018-06-04  Chris Dumez  <cdumez@apple.com>
1380
1381         Rename "Cross-Origin-Options" HTTP header to "Cross-Origin-Window-Policy"
1382         https://bugs.webkit.org/show_bug.cgi?id=186287
1383         <rdar://problem/40783352>
1384
1385         Reviewed by Youenn Fablet.
1386
1387         * DumpRenderTree/mac/DumpRenderTree.mm:
1388         (enableExperimentalFeatures):
1389         * DumpRenderTree/win/DumpRenderTree.cpp:
1390         (enableExperimentalFeatures):
1391
1392 2018-06-04  Daniel Bates  <dabates@apple.com>
1393
1394         Typo in MockBugzillaQueries.fetch_attachment_ids_from_review_queue()
1395         https://bugs.webkit.org/show_bug.cgi?id=186290
1396
1397         Reviewed by Aakash Jain.
1398
1399         Although the usefulness of the code in MockBugzillaQueries.fetch_attachment_ids_from_review_queue() is
1400         questionable we should fix a typo when calling this mocked function with argument since.
1401
1402         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1403         (MockBugzillaQueries.fetch_attachment_ids_from_review_queue):
1404
1405 2018-06-04  Dan Bernstein  <mitz@apple.com>
1406
1407         Fixed building with the macOS Mojave seed SDK.
1408
1409         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1410
1411 2018-06-04  Alexey Proskuryakov  <ap@apple.com>
1412
1413         Add Mojave support to WebKit tools
1414         https://bugs.webkit.org/show_bug.cgi?id=186282
1415
1416         Reviewed by Daniel Bates.
1417
1418         Nightly build support will be added separately.
1419
1420         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave.png: Added.
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mojave@2x.png: Added.
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1423         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1424         Added dashboard support.
1425
1426         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1427         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1428         Trigger the right build queues on check-in.
1429
1430         * Scripts/webkitpy/common/version_name_map.py:
1431         * Scripts/webkitpy/common/version_name_map_unittest.py:
1432         The main version mapping class updated.
1433
1434         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1435         * Scripts/webkitpy/port/mac_unittest.py:
1436         Updated for more platforms in unit tests.
1437
1438         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1439         Added the new platform to flakiness dashboard.
1440
1441 2018-06-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1442
1443         [WebKit on watchOS] Remove all uses of the EXTRA_ZOOM_MODE compiler flag
1444         https://bugs.webkit.org/show_bug.cgi?id=186279
1445
1446         Reviewed by Tim Horton.
1447
1448         Replaces uses of ENABLE(EXTRA_ZOOM_MODE) with PLATFORM(WATCHOS).
1449
1450         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1451
1452 2018-06-03  Fujii Hironori  <Hironori.Fujii@sony.com>
1453
1454         [Win][MiniBrowser] Remove gMiniBrowser global variable
1455         https://bugs.webkit.org/show_bug.cgi?id=186134
1456
1457         Reviewed by Brent Fulgham.
1458
1459         It should not be assumed there is only one main window and one browser
1460         window to support multiple windows properly. gMainWindow and
1461         gMiniBrowser global variables should be removed. This change
1462         removes gMiniBrowser.
1463
1464         * MiniBrowser/win/Common.cpp: Removed gMiniBrowser global variable.
1465         * MiniBrowser/win/Common.h: Ditto.
1466         * MiniBrowser/win/MainWindow.cpp:
1467         (MainWindow::init):
1468         (MainWindow::WndProc):
1469         (EditProc): Post WM_COMMAND if the enter key is pressed in URL bar.
1470         (MainWindow::cachesDialogProc): Renamed from Caches.
1471         (MainWindow::customUserAgentDialogProc): Renamed from CustomUserAgent.
1472         (MainWindow::onURLBarEnter): Extracted from EditProc.
1473         (BackButtonProc): Deleted.
1474         (ForwardButtonProc): Deleted.
1475         (Caches): Renamed to MainWindow::cachesDialogProc.
1476         (CustomUserAgent): Renamed to MainWindow::customUserAgentDialogProc.
1477         * MiniBrowser/win/MainWindow.h: Convert hCacheWnd global variable to a member variable of MainWindow.
1478         * MiniBrowser/win/MiniBrowserLibResource.h:
1479         * MiniBrowser/win/WinMain.cpp:
1480         (wWinMain):
1481
1482 2018-06-02  Darin Adler  <darin@apple.com>
1483
1484         [Cocoa] Update some code to be more ARC-compatible to prepare for future ARC adoption
1485         https://bugs.webkit.org/show_bug.cgi?id=186227
1486
1487         Reviewed by Dan Bernstein.
1488
1489         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
1490         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1491         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1492
1493         * DumpRenderTree/mac/AccessibilityControllerMac.mm: Add a missing include.
1494
1495         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1496         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1497         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1498         (AccessibilityTextMarker::isEqual): Ditto.
1499         (AccessibilityTextMarkerRange::isEqual): Ditto.
1500
1501         * DumpRenderTree/mac/DumpRenderTree.mm:
1502         (-[DumpRenderTree _waitForWebThread]): Use @autoreleasepool instead of NSAutoreleasePool.
1503         (DumpRenderTreeMain): Ditto.
1504         (WebThreadLockAfterDelegateCallbacksHaveCompleted): Ditto.
1505         (runTest): Ditto.
1506
1507         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1508         (copyFile): Use a std::pair to return both a URL and an error rather than using an
1509         out argument for the NSError.
1510         (-[DumpRenderTreeFilePromiseReceiver receivePromisedFilesAtDestination:options:operationQueue:reader:]):
1511         Updated for the above change.
1512
1513         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1514         (-[DumpRenderTreeWindow _addToOpenWindows]): Add __bridge to a bridging typecast.
1515         (-[DumpRenderTreeWindow close]): Ditto.
1516         * DumpRenderTree/mac/LayoutTestHelper.m:
1517         (setDisplayColorProfile): Ditto.
1518
1519         * DumpRenderTree/mac/PolicyDelegate.mm: Add a missing include.
1520
1521         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1522         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1523         Add __bridge to a bridging typecast.
1524         * DumpRenderTree/mac/TestRunnerMac.mm:
1525         (-[APITestDelegateIPhone initWithTestRunner:utf8Data:baseURL:]): Ditto.
1526         (TestRunner::apiTestNewWindowDataLoadBaseURL): Use @autoreleasepool instead of NSAutoreleasePool.
1527
1528         * DumpRenderTree/mac/TextInputControllerMac.m: Fix a comment.
1529
1530         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1531         (WTR::UIScriptController::replaceTextAtRange): Add __bridge to a bridging typecast.
1532         (WTR::UIScriptController::contentsOfUserInterfaceItem const): Ditto.
1533         (WTR::UIScriptController::overridePreference): Ditto.
1534         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1535         (LoadItem::invoke const): Ditto.
1536         (LoadHTMLStringItem::invoke const): Ditto.
1537         (ScriptItem::invoke const): Ditto.
1538
1539         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1540         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1541         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1542
1543         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
1544         (+[NSString stringWithJSStringRef:]): Use CFBridgingRelease instead of autorelease.
1545         (-[NSString createJSStringRef]): Add __bridge to a bridging typecast.
1546
1547         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
1548         (WTR::AccessibilityController::accessibleElementById): Add __bridge to a bridging typecast.
1549         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1550         (-[NSString createJSStringRef]): Ditto.
1551         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm:
1552         (WTR::AccessibilityTextMarker::isEqual): Ditto.
1553         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm:
1554         (WTR::AccessibilityTextMarkerRange::isEqual): Ditto.
1555         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1556         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange): Ditto.
1557         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker): Ditto.
1558         (WTR::AccessibilityUIElement::textMarkerRangeLength): Ditto.
1559         (WTR::AccessibilityUIElement::previousTextMarker): Ditto.
1560         (WTR::AccessibilityUIElement::nextTextMarker): Ditto.
1561         (WTR::AccessibilityUIElement::stringForTextMarkerRange): Ditto.
1562         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers): Ditto.
1563         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange): Ditto.
1564         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange): Ditto.
1565         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker): Ditto.
1566         (WTR::createJSStringRef): Ditto.
1567         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
1568         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
1569         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute): Ditto.
1570         (WTR::AccessibilityUIElement::indexForTextMarker): Ditto.
1571         (WTR::AccessibilityUIElement::isTextMarkerValid): Ditto.
1572         (WTR::AccessibilityUIElement::leftWordTextMarkerRangeForTextMarker): Ditto.
1573         (WTR::AccessibilityUIElement::rightWordTextMarkerRangeForTextMarker): Ditto.
1574         (WTR::AccessibilityUIElement::previousWordStartTextMarkerForTextMarker): Ditto.
1575         (WTR::AccessibilityUIElement::nextWordEndTextMarkerForTextMarker): Ditto.
1576         (WTR::AccessibilityUIElement::paragraphTextMarkerRangeForTextMarker): Ditto.
1577         (WTR::AccessibilityUIElement::previousParagraphStartTextMarkerForTextMarker): Ditto.
1578         (WTR::AccessibilityUIElement::nextParagraphEndTextMarkerForTextMarker): Ditto.
1579         (WTR::AccessibilityUIElement::sentenceTextMarkerRangeForTextMarker): Ditto.
1580         (WTR::AccessibilityUIElement::previousSentenceStartTextMarkerForTextMarker): Ditto.
1581         (WTR::AccessibilityUIElement::nextSentenceEndTextMarkerForTextMarker): Ditto.
1582         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1583         (WTR::initializeWebViewConfiguration): Ditto.
1584         (WTR::TestController::platformContext): Ditto.
1585         (WTR::TestController::platformPreferences): Ditto.
1586         (WTR::TestController::platformAdjustContext): Ditto.
1587         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1588         (WTR::PlatformWebView::PlatformWebView): Ditto.
1589         * WebKitTestRunner/mac/TestControllerMac.mm:
1590         (WTR::TestController::initializeInjectedBundlePath): Ditto.
1591         (WTR::TestController::initializeTestPluginDirectory): Ditto.
1592         (WTR::TestController::platformConfigureViewForTest): Ditto.
1593
1594         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1595         (WTR::nsString): Use CFBridgingRelease instead of autorelease.
1596         (WTR::UIScriptController::platformPlayBackEventStream): Add __bridge to a bridging
1597         typecast.
1598
1599         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm: Add a missing include.
1600
1601         * WebKitTestRunner/mac/WebKitTestRunnerPasteboard.mm:
1602         (-[LocalPasteboard setPropertyList:forType:]): Add _bridge to a bridging typecast.
1603         (-[LocalPasteboard setString:forType:]): Ditto.
1604
1605         * WebKitTestRunner/mac/main.mm:
1606         (main): Use @autoreleasepool instead of NSAutoreleasePool.
1607
1608 2018-06-02  Keith Miller  <keith_miller@apple.com>
1609
1610         run-jsc should pass the option to use dollar vm by default
1611         https://bugs.webkit.org/show_bug.cgi?id=186170
1612
1613         Reviewed by Yusuke Suzuki.
1614
1615         * Scripts/run-jsc:
1616
1617 2018-06-02  Commit Queue  <commit-queue@webkit.org>
1618
1619         Unreviewed, rolling out r232421.
1620         https://bugs.webkit.org/show_bug.cgi?id=186240
1621
1622         Breaks webkitpy tests (Requested by aakashjain on #webkit).
1623
1624         Reverted changeset:
1625
1626         "Add some tests for lldb_webkit.py"
1627         https://bugs.webkit.org/show_bug.cgi?id=183744
1628         https://trac.webkit.org/changeset/232421
1629
1630 2018-06-01  Daniel Bates  <dabates@apple.com>
1631
1632         Add some tests for lldb_webkit.py
1633         https://bugs.webkit.org/show_bug.cgi?id=183744
1634
1635         Reviewed by Alexey Proskuryakov.
1636
1637         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
1638         and WTF::String objects.
1639
1640         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
1641         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
1642         on Mac.
1643
1644         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
1645         * Scripts/build-lldbwebkittester: Added.
1646         (buildProjectOrDie):
1647         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
1648         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
1649         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
1650         the file and take advantage of Python's default error semantics to throw an exception
1651         if the import fails instead of handling it ourself. This has the side effect that we
1652         now always import the LLDB Python module even if this script is invoked with --help.
1653         If this turns out to be a significant annoyance then we can look to dynamically import
1654         the module as we did before this change.
1655         (webkit_build_dir):
1656         (main):
1657         (developer_dir): Deleted.
1658         (import_lldb): Deleted.
1659         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
1660         that fact that test-webkitpy does not support class and module fixtures. This is because
1661         test-webkitpy currently implements parallelism by breaking down existing test classes
1662         into individual test methods itself and having each worker run exactly one test method (via
1663         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
1664         setUpModule()/setUpClass() are called for each test method as opposed to once per test
1665         class/test module.
1666         (remove_dir): Ditto.
1667         * Scripts/webkitpy/common/system/systemhost.py:
1668         (SystemHost):
1669         (SystemHost.path_to_lldb_python_directory): Added.
1670         * Scripts/webkitpy/test/main.py:
1671         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
1672         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
1673         lldbWebKitTester on Mac.
1674         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
1675         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
1676         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
1677         If we will run these tests then build lldbWebKitTester if it has not already been built as the
1678         unit tests depend on this program.
1679         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
1680         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
1681         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
1682         * lldb/lldbWebKitTester/Makefile: Added.
1683         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
1684         * lldb/lldbWebKitTester/main.cpp: Added.
1685         (breakForTestingSummaryProviders):
1686         (utf16String):
1687         (testSummaryProviders):
1688         (main):
1689         * lldb/lldb_webkit_unittest.py: Added.
1690         (destroy_cached_debug_session):
1691         (LLDBDebugSession):
1692         (LLDBDebugSession.setup):
1693         (LLDBDebugSession.tearDown):
1694         (TestSummaryProviders):
1695         (TestSummaryProviders.setUpClass):
1696         (TestSummaryProviders._sbFrame):
1697         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
1698         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
1699         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
1700         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
1701         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
1702         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
1703         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
1704         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
1705
1706 2018-06-01  Frederic Wang  <fwang@igalia.com>
1707
1708         export-w3c-test-changes cannot apply patches when some w3c-import.log files are changed
1709         https://bugs.webkit.org/show_bug.cgi?id=186133
1710
1711         Reviewed by Youenn Fablet.
1712
1713         * Scripts/webkitpy/w3c/test_exporter.py: Exclude w3c-import.log from the diff.
1714         * Scripts/webkitpy/w3c/test_exporter_unittest.py: Add unit test.
1715
1716 2018-05-31  Frederic Wang  <fwang@igalia.com>
1717
1718         export-w3c-test-changes should use the new location & name of the WPT repo
1719         https://bugs.webkit.org/show_bug.cgi?id=186135
1720
1721         Reviewed by Youenn Fablet.
1722
1723         Web platform tests have been moved to GitHub's web-platform-tests/wpt. This patch updates the
1724         corresponding variables to use the new organization and repository name. It also refactors a
1725         bit the code to reduce the amount of hardcoded strings.
1726
1727         * Scripts/webkitpy/w3c/common.py: Use org web-platform-tests, repo name wpt. Also removes the
1728         final slash to WPT_GH_URL, so it can be used for repo URL too.
1729         * Scripts/webkitpy/w3c/test_exporter.py: Import more symbols and define WPT_PR_URL from
1730         WPT_GH_URL.
1731         (WebPlatformTestExporter._wpt_fork_branch_github_url): Use WPT_GH_REPO_NAME.
1732         (WebPlatformTestExporter._wpt_fork_push_url): Use WPT_GH_REPO_NAME.
1733         (WebPlatformTestExporter._git): Use  WPT_GH_URL.
1734         (WebPlatformTestExporter._ensure_username_and_token): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
1735         (WebPlatformTestExporter.make_pull_request): Use WPT_GH_ORG, WPT_GH_REPO_NAME.
1736         (parse_args): Use WPT_GH_REPO_NAME, WPT_GH_URL.
1737         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1738         (TestExporterTest.test_export): Update organization and repository names for the remote
1739         branch and pull request.
1740         (TestExporterTest.test_export_with_specific_branch): Update repository name.
1741
1742 2018-05-31  Ryan Haddad  <ryanhaddad@apple.com>
1743
1744         Update expected results for BuildStepsConstructorTest
1745         https://bugs.webkit.org/show_bug.cgi?id=186119
1746
1747         Reviewed by Alex Christensen.
1748
1749         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Add missing entries for 'WinCairo 64-bit' bots.
1750
1751 2018-05-31  Sihui Liu  <sihui_liu@apple.com>
1752
1753         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool fails because cookies use different files with/without processpool
1754         https://bugs.webkit.org/show_bug.cgi?id=185831
1755         <rdar://problem/40468716>
1756
1757         Reviewed by David Kilzer.
1758
1759         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
1760         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1761         (TEST):
1762
1763 2018-05-31  Chris Dumez  <cdumez@apple.com>
1764
1765         [iOS] API test ScrollViewInsetTests.InnerHeightWithLargeTopContentInset is a flaky failure
1766         https://bugs.webkit.org/show_bug.cgi?id=184893
1767         <rdar://problem/39747271>
1768
1769         Reviewed by Wenson Hsieh.
1770
1771         Update test to wait until the view is the expected height instead of
1772         calling waitForNextPresentationUpdate once and expect the view to
1773         have the right height. This fixes the flakiness.
1774
1775         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1776         (TestWebKitAPI::waitUntilInnerHeightIs):
1777         (TestWebKitAPI::TEST):
1778
1779 2018-05-31  Leo Balter  <leonardo.balter@gmail.com>
1780
1781         test262-runner should run in verbose mode in automation
1782         https://bugs.webkit.org/show_bug.cgi?id=186115
1783
1784         Reviewed by Yusuke Suzuki.
1785
1786         This patch toggles the verbose mode in the build bot and reports every test file
1787         in order to avoid the '1200 seconds without output' issue.
1788         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1789         (RunTest262Tests):
1790         * Scripts/test262/Runner.pm:
1791         (processResult):
1792
1793 2018-05-30  Fujii Hironori  <Hironori.Fujii@sony.com>
1794
1795         [Win][MiniBrowser] Move MainWindow related code from Common.cpp to MainWindow.cpp
1796         https://bugs.webkit.org/show_bug.cgi?id=186079
1797
1798         Reviewed by Alex Christensen.
1799
1800         This is a sub task of Bug 184770.
1801
1802         This change is partial. I'm going to remove global variables
1803         gMainWindow and gMiniBrowser and convert more functions to
1804         MainWindow's methods in follow-up patches.
1805
1806         * MiniBrowser/win/CMakeLists.txt: Added Common.cpp
1807         * MiniBrowser/win/Common.cpp:
1808         (menuItemIsChecked): Moved to MainWindow.cpp.
1809         (turnOffOtherUserAgents): Ditto.
1810         (EditProc): Ditto.
1811         (BackButtonProc): Ditto.
1812         (ForwardButtonProc): Ditto.
1813         (About): Ditto.
1814         (Caches): Ditto.
1815         (CustomUserAgent): Ditto.
1816         (AuthDialogProc): Ditto.
1817         (DisplayAuthDialog): Converted to MainWindow's method.
1818         (ToggleMenuItem): Ditto.
1819         (loadURL): Ditto.
1820         * MiniBrowser/win/Common.h:
1821         * MiniBrowser/win/MainWindow.cpp:
1822         (MainWindow::init): Call SetFocus at the end of the construction.
1823         (MainWindow::WndProc):
1824         (menuItemIsChecked): Moved from Common.cpp.
1825         (turnOffOtherUserAgents): Ditto.
1826         (EditProc): Ditto.
1827         (BackButtonProc): Ditto.
1828         (ForwardButtonProc): Ditto.
1829         (About): Ditto.
1830         (Caches): Ditto.
1831         (CustomUserAgent): Ditto.
1832         (authDialogProc): Ditto.
1833         (MainWindow::displayAuthDialog): Converted from a function of Common.cpp.
1834         (MainWindow::toggleMenuItem): Ditto.
1835         (MainWindow::loadURL): Ditto.
1836         * MiniBrowser/win/MainWindow.h: Added method declarations.
1837         * MiniBrowser/win/MiniBrowser.h: Added pragma once.
1838         * MiniBrowser/win/WinMain.cpp:
1839         (wWinMain): Include Common.h instead of Common.cpp.
1840
1841 2018-05-30  Brady Eidson  <beidson@apple.com>
1842
1843         REGRESSION (r224684): User-agent seen by page does not change when modified by the develop menu options after reloading.
1844         <rdar://problem/34918109> and https://bugs.webkit.org/show_bug.cgi?id=186111
1845
1846         Reviewed by Andy Estes.
1847
1848         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1850         (WTR::TestRunner::setCustomUserAgent):
1851         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1852         * WebKitTestRunner/TestController.cpp:
1853         (WTR::TestController::resetStateToConsistentValues):
1854         * WebKitTestRunner/TestInvocation.cpp:
1855         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1856
1857 2018-05-30  Youenn Fablet  <youenn@apple.com>
1858
1859         Rename CrossOriginResourcePolicy same to same-origin
1860         https://bugs.webkit.org/show_bug.cgi?id=186080
1861
1862         Reviewed by Chris Dumez.
1863
1864         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1865         (TestWebKitAPI::TEST):
1866
1867 2018-05-30  Ms2ger  <Ms2ger@igalia.com>
1868
1869         [GTK] Unreviewed test gardening
1870         https://bugs.webkit.org/show_bug.cgi?id=186098
1871
1872         Unreviewed gardening.
1873
1874         * TestWebKitAPI/glib/TestExpectations.json: update expectations.
1875
1876 2018-05-29  Youenn Fablet  <youenn@apple.com>
1877
1878         Add a consistency check between URL and CFURL
1879         https://bugs.webkit.org/show_bug.cgi?id=182444
1880         <rdar://problem/37164835>
1881
1882         Reviewed by Geoff Garen.
1883
1884         DRT code expected a non null URL which is no longer the case now.
1885         Updated DRT to remove that assumption.
1886
1887         * DumpRenderTree/TestRunner.cpp:
1888         (TestRunner::redirectionDestinationForURL):
1889         * DumpRenderTree/TestRunner.h:
1890         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1891         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1892
1893 2018-05-29  Brendan McLoughlin  <brendan@bocoup.com>
1894
1895         Export changes to web-platform-test as part of the webkit-patch upload workflow
1896         https://bugs.webkit.org/show_bug.cgi?id=184914
1897
1898         Reviewed by Youenn Fablet.
1899
1900         * Scripts/webkitpy/tool/commands/upload.py:
1901         (Upload):
1902         (CreateBug.execute):
1903         (WPTChangeExport):
1904         * Scripts/webkitpy/tool/steps/__init__.py:
1905         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
1906         (WPTChangeExport):
1907         (WPTChangeExport.options):
1908         (WPTChangeExport.run):
1909         * Scripts/webkitpy/w3c/common.py:
1910         * Scripts/webkitpy/w3c/test_exporter.py:
1911         (WebPlatformTestExporter):
1912         (WebPlatformTestExporter.__init__):
1913         (WebPlatformTestExporter.username):
1914         (WebPlatformTestExporter.token):
1915         (WebPlatformTestExporter._github):
1916         (WebPlatformTestExporter._wpt_fork_branch_github_url):
1917         (WebPlatformTestExporter._wpt_fork_remote):
1918         (WebPlatformTestExporter._wpt_fork_push_url):
1919         (WebPlatformTestExporter._git):
1920         (WebPlatformTestExporter._branch_name):
1921         (WebPlatformTestExporter._public_branch_name):
1922         (WebPlatformTestExporter._wpt_patch):
1923         (WebPlatformTestExporter.has_wpt_changes):
1924         (WebPlatformTestExporter._find_filename):
1925         (WebPlatformTestExporter._is_ignored_file):
1926         (WebPlatformTestExporter._strip_ignored_files_from_diff):
1927         (WebPlatformTestExporter.write_git_patch_file):
1928         (WebPlatformTestExporter._prompt_for_token):
1929         (WebPlatformTestExporter._prompt_for_username):
1930         (WebPlatformTestExporter._ensure_username_and_token):
1931         (WebPlatformTestExporter._validate_and_save_token):
1932         (WebPlatformTestExporter.create_branch_with_patch):
1933         (WebPlatformTestExporter.push_to_wpt_fork):
1934         (WebPlatformTestExporter.make_pull_request):
1935         (WebPlatformTestExporter.delete_local_branch):
1936         (WebPlatformTestExporter.create_upload_remote_if_needed):
1937         (WebPlatformTestExporter.do_export):
1938         (parse_args):
1939         (TestExporter): Deleted.
1940         (TestExporter.__init__): Deleted.
1941         (TestExporter._ensure_wpt_repository): Deleted.
1942         (TestExporter._fetch_wpt_repository): Deleted.
1943         (TestExporter._ensure_new_branch_name): Deleted.
1944         (TestExporter.download_and_commit_patch): Deleted.
1945         (TestExporter.clean): Deleted.
1946         (TestExporter.create_branch_with_patch): Deleted.
1947         (TestExporter.push_to_wpt_fork): Deleted.
1948         (TestExporter.make_pull_request): Deleted.
1949         (TestExporter.create_wpt_pull_request): Deleted.
1950         (TestExporter.delete_local_branch): Deleted.
1951         (TestExporter.create_git_patch): Deleted.
1952         (TestExporter.create_upload_remote): Deleted.
1953         (TestExporter.do_export): Deleted.
1954         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
1955         (TestExporterTest.MockGit):
1956         (TestExporterTest.MockGit.create_patch):
1957         (TestExporterTest.test_export):
1958         (TestExporterTest.test_export_with_specific_branch):
1959         (TestExporterTest):
1960         (TestExporterTest.test_export_interactive_mode):
1961         (TestExporterTest.test_export_invalid_token):
1962         (TestExporterTest.test_export_wrong_token):
1963         (TestExporterTest.test_has_wpt_changes):
1964         (TestExporterTest.test_has_no_wpt_changes_for_no_diff):
1965         (TestExporterTest.test_ignore_changes_to_expected_file):
1966
1967 2018-05-29  Fujii Hironori  <Hironori.Fujii@sony.com>
1968
1969         [Win][MiniBrowser] Move WK1 specific code from Common.cpp to MiniBrowser.cpp
1970         https://bugs.webkit.org/show_bug.cgi?id=186029
1971
1972         Reviewed by Alex Christensen.
1973
1974         This is a sub task of Bug 184770.
1975
1976         * MiniBrowser/win/Common.cpp:
1977         (ToggleMenuItem): Extracted WK1 specific code to MiniBrowser::setPreference.
1978         (Caches): Call MiniBrowser::updateStatistics instead of updateStatistics.
1979         (AbortProc): Moved to MiniBrowser.cpp.
1980         (getPrinterDC): Ditto.
1981         (initDocStruct): Ditto.
1982         (PrintView): Ditto.
1983         (ToggleMenuFlag): Ditto.
1984         (setWindowText): Ditto.
1985         (updateStatistics): Ditto.
1986         * MiniBrowser/win/MainWindow.cpp:
1987         (MainWindow::WndProc): Call MiniBrowser::print instead of PrintView.
1988         * MiniBrowser/win/MiniBrowser.cpp:
1989         (AbortProc): Moved from Common.cpp.
1990         (getPrinterDC): Moved from Common.cpp.
1991         (initDocStruct): Moved from Common.cpp.
1992         (setWindowText): Moved from Common.cpp.
1993         (MiniBrowser::print): Renamed from PrintView of Common.cpp.
1994         (MiniBrowser::updateStatistics): Renamed from updateStatistics of Common.cpp.
1995         (MiniBrowser::setPreference): Extracted from ToggleMenuItem of Common.cpp.
1996         * MiniBrowser/win/MiniBrowser.h: Add method declarations.
1997         * MiniBrowser/win/MiniBrowserWebHost.cpp: Removed duplicated IWebFramePtr typedef.
1998
1999 2018-05-29  Saam Barati  <sbarati@apple.com>
2000
2001         JSC should put bmalloc's scavenger into mini mode
2002         https://bugs.webkit.org/show_bug.cgi?id=185988
2003
2004         Reviewed by Michael Saboff.
2005
2006         This patch makes it so that we turn off the JIT when running run-testmem
2007         that way we make JSC use its mini mode.
2008
2009         * Scripts/run-testmem:
2010
2011 2018-05-29  Sihui Liu  <sihui_liu@apple.com>
2012
2013         Unable to remove IndexedDB Databases with Cocoa API removeDataOfTypes
2014         https://bugs.webkit.org/show_bug.cgi?id=185835
2015         <rdar://problem/39142257>
2016
2017         Reviewed by Chris Dumez.
2018
2019         Add API test coverage.
2020
2021         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2022         (TEST):
2023
2024 2018-05-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2025
2026         [Extra zoom mode] "Significant area painted" rendering progress event is rarely fired
2027         https://bugs.webkit.org/show_bug.cgi?id=186042
2028         <rdar://problem/40604182>
2029
2030         Reviewed by Tim Horton.
2031
2032         Adds a new API test to check that the "significant area painting" rendering milestone is dispatched when a
2033         significant portion of the page has been painted before document load is finished.
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2036         * TestWebKitAPI/Tests/WebKitCocoa/paint-significant-area-milestone.html: Added.
2037         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm: Added.
2038         (-[MissingResourceSchemeHandler webView:stopURLSchemeTask:]):
2039         (-[MissingResourceSchemeHandler webView:startURLSchemeTask:]):
2040         (-[RenderingProgressHandler initWithHandler:]):
2041         (-[RenderingProgressHandler _webView:renderingProgressDidChange:]):
2042         (TEST):
2043
2044 2018-05-29  Thibault Saunier  <tsaunier@igalia.com>
2045
2046         [GStreamer] Update "qtdemux: Clarify field name about stream-encryption-system" patch
2047         https://bugs.webkit.org/show_bug.cgi?id=186040
2048
2049         The patch we merge contained a type and was merged in upstream GStreamer fixing that
2050         (s/avalaible/available/).
2051
2052         Reviewed by Xabier Rodriguez-Calvar.
2053
2054         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch:
2055
2056 2018-05-28  Sihui Liu  <sihui_liu@apple.com>
2057
2058         Add an API test to check process privilege when using Cookie API
2059         https://bugs.webkit.org/show_bug.cgi?id=185406
2060
2061         Reviewed by Geoffrey Garen.
2062
2063         Add API test coverage.
2064
2065         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2066         (TEST):
2067
2068 2018-05-28  Thibault Saunier  <tsaunier@igalia.com>
2069
2070         [GStreamer] Handle changes in the "drm-preferred-decryption-system-id" NEED_CONTEXT message.
2071         https://bugs.webkit.org/show_bug.cgi?id=185948
2072
2073         Reviewed by Xabier Rodriguez-Calvar.
2074
2075         When the patch introducing gst_protection_filter_systems_by_available_decryptors was merged, we changed sensibly its behaviour
2076         concerning the way empty results is represented (now returning NULL instead of an array of 1(NULL) element) and this change was not
2077         properly taken into account in the qtdemux patch that uses it and got upstreamed. Those 3 new patches fixe that and change the
2078         NEED_CONTEXT field names to clarify the meaning of "stream-encryption-systems".
2079
2080         * gstreamer/jhbuild.modules:
2081         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Added. Merged upstream as 3e063703b3a51b8aaa7f75f36c4660c583a60e93
2082         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Added. Merged upstream as 43a540b1cd9f162d3dae5d50e36703dfaf558a3e
2083         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Added.
2084
2085 2018-05-27  Dan Bernstein  <mitz@apple.com>
2086
2087         Reverted the changes made for https://webkit.org/b/186016
2088
2089         They broke the USE(APPLE_INTERNAL_SDK) Sierra build.
2090
2091 2018-05-27  Dan Bernstein  <mitz@apple.com>
2092
2093         [Cocoa] Avoid importing directly from subumbrella frameworks
2094         https://bugs.webkit.org/show_bug.cgi?id=186016
2095
2096         Reviewed by Sam Weinig.
2097
2098         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2099           LaunchServices header.
2100         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2101           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2102         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2103           when using SDKs earlier than 10.13.
2104         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2105           and OTHER_CPLUSPLUSFLAGS.
2106         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm: Import Carbon.h instead of an
2107           HIToolbox header.
2108         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2109           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2110         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2111           LaunchServices header.
2112
2113 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2114
2115         [Win][MiniBrowser] Add MainWindow class
2116         https://bugs.webkit.org/show_bug.cgi?id=185814
2117
2118         Reviewed by Per Arne Vollan.
2119
2120         This is a sub task of Bug 184770. Added a new class MainWindow to
2121         represent the main window which will be shared among WK1 and WK2.
2122
2123         This change is partial so that it's easy to review this patch.
2124         I'll move more functions into MainWindow.cpp, and remove more
2125         global variables in forthcoming patches.
2126
2127         * MiniBrowser/win/CMakeLists.txt: Added MainWindow.cpp.
2128         * MiniBrowser/win/Common.cpp: Removed MainWindow related global
2129         variables hMainWnd, hURLBarWnd, hBackButtonWnd and
2130         hForwardButtonWnd. Added a new global variable gMainWindow.
2131         (WndProc): Moved to MainWindow.cpp.
2132         (resizeSubViews): Ditto.
2133         (ToggleMenuFlag): Removed static to be called from MainWindow.cpp.
2134         (ToggleMenuItem): Ditto.
2135         (CustomUserAgent): Follow the global variables removal.
2136         (DisplayAuthDialog): Ditto.
2137         (loadURL): Ditto.
2138         (WndProc): Renamed to MainWindow::WndProc.
2139         * MiniBrowser/win/MainWindow.cpp: Added.
2140         (MainWindow::registerClass): Renamed from MyRegisterClass of WinMain.cpp.
2141         (MainWindow::init): Extracted MainWindow initialization code from wWinMain.
2142         (MainWindow::resizeSubViews): Moved from Common.cpp.
2143         (MainWindow::WndProc): Ditto.
2144         * MiniBrowser/win/MainWindow.h: Added.
2145         (MainWindow::hwnd):
2146         (MainWindow::browserWindow):
2147         * MiniBrowser/win/MiniBrowser.cpp:
2148         (MiniBrowser::init):
2149         (MiniBrowser::prepareViews): Extract some code into MiniBrowser::loadDefaultHTML.
2150         (MiniBrowser::loadDefaultHTML): Extracted from MiniBrowser::prepareViews.
2151         * MiniBrowser/win/MiniBrowser.h:
2152         * MiniBrowser/win/WinMain.cpp:
2153         (wWinMain): Extracted MainWindow initialization code into MainWindow::init.
2154         (MyRegisterClass): Moved to MainWindow.cpp.
2155
2156 2018-05-27  Fujii Hironori  <Hironori.Fujii@sony.com>
2157
2158         [Win][MiniBrowser] Remove URL argument of MiniBrowser::init
2159         https://bugs.webkit.org/show_bug.cgi?id=185969
2160
2161         Reviewed by Alex Christensen.
2162
2163         MiniBrowser::init takes URL argument, but it's used only for
2164         loading default HTML if URL is not given.
2165
2166         - Add a new method MiniBrowser::loadHTMLString
2167         - Remove loadHTMLString process from MiniBrowser::prepareViews
2168
2169         * MiniBrowser/win/MiniBrowser.cpp:
2170         (MiniBrowser::init): Removed `requestedURL` argument.
2171         (MiniBrowser::prepareViews): Ditto.
2172         (MiniBrowser::loadHTMLString): New.
2173         (MiniBrowser::loadURL): Return E_INVALIDARG if passedURL is null instead of calling loadHTMLString.
2174         * MiniBrowser/win/MiniBrowser.h: Removed URL argument. Added loadHTMLString.
2175         * MiniBrowser/win/WinMain.cpp:
2176         (wWinMain): Call MiniBrowser::loadHTMLString if URL is not given.
2177
2178 2018-05-27  David Kilzer  <ddkilzer@apple.com>
2179
2180         svn-apply fails when a patch has an empty file
2181         <https://webkit.org/b/29684>
2182
2183         Reviewed by Daniel Bates.
2184
2185         Prior to this change, applying the following patches resulted in:
2186         - svn: add empty file     (failure)
2187         - svn: delete empty file  (failure)
2188         - svn: rename empty file  (failure)
2189         - git: add empty file     (false-positive success)
2190         - git: delete empty file  (success)
2191         - git: rename empty file  (failure)
2192
2193         * Scripts/VCSUtils.pm:
2194         (parseSvnDiffHeader): Handle the case when there is no patch
2195         following the header.  If the file exists and is empty, that
2196         means it's a deletion.  If the file does not exist, that means
2197         it's an addition. Everything else is a fatal error.
2198         * Scripts/svn-apply:
2199         (patch):
2200         - Only apply a patch for deletion if it has one or more text
2201           chunks.
2202         - Add a case to handle adding an empty file (an addition with no
2203           text chunks), and verify the file doesn't exist yet.
2204         - Any unhandled patch is a fatal error.
2205         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2206         Add tests for adding an empty file and deleting an empty file.
2207         * Scripts/webkitperl/VCSUtils_unittest/resources/empty.txt: Add.
2208         Used by parseSvnDiffHeader.pl unit test for "add an empty file"
2209         test case.
2210
2211 2018-05-25  Aakash Jain  <aakash_jain@apple.com>
2212
2213         Display detailed error logs when a script fails in EWS
2214         https://bugs.webkit.org/show_bug.cgi?id=175696
2215         <rdar://problem/34841885>
2216
2217         Reviewed by Darin Adler.
2218
2219         * Scripts/webkitpy/tool/bot/queueengine.py: Set output_limit to 5000 characters instead of default 500 characters.
2220         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py: Ditto.
2221         * Scripts/webkitpy/tool/commands/download.py: Ditto.
2222         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: Ditto.
2223         * Scripts/webkitpy/tool/commands/queues.py: Ditto.
2224         * Scripts/webkitpy/tool/commands/stepsequence.py: Ditto.
2225
2226 2018-05-25  Daniel Bates  <dabates@apple.com>
2227
2228         test-webkitpy messages logged using __main__ logger are not displayed
2229         https://bugs.webkit.org/show_bug.cgi?id=185823
2230
2231         Rubber-stamped by Aakash Jain.
2232
2233         Configure the logger for __main__ so that messages that are logged before it parses its
2234         command line arguments are printed to standard error.
2235
2236         Currently test-webkitpy creates a named logger (__main__) for its logging. However it does
2237         not configure a stream to use for printing until after it parses its command line arguments
2238         via webkitpy.test.printer.Printer.configure(). Messages logged until then are never written
2239         to the console. We explicitly configure the __main__ logger instead of calling webkitpy.test.printer.Printer.configure()
2240         earlier because the latter both configures a stream and filters logged messages based on
2241         the specified verbosity. Logged messaged from code in __main__ should not be subject to
2242         such filtering. So, we explicitly configure the __main__ logger.
2243
2244         * Scripts/webkitpy/test/main.py:
2245         (main):
2246
2247 2018-05-25  Saam Barati  <sbarati@apple.com>
2248
2249         Make JSC have a mini mode that kicks in when the JIT is disabled
2250         https://bugs.webkit.org/show_bug.cgi?id=185931
2251
2252         Reviewed by Mark Lam.
2253
2254         This renames a variable for clarity.
2255
2256         * Scripts/run-testmem:
2257
2258 2018-05-25  Alex Christensen  <achristensen@webkit.org>
2259
2260         URL::host should return a StringView to reduce allocations
2261         https://bugs.webkit.org/show_bug.cgi?id=185986
2262
2263         Reviewed by Geoff Garen.
2264
2265         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2266         (TestWebKitAPI::TEST_F):
2267         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2268         (TestWebKitAPI::eq):
2269         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
2270         (TestWebKitAPI::SSLKeyGeneratorTest::TearDown):
2271
2272 2018-05-25  Ms2ger  <Ms2ger@igalia.com>
2273
2274         Minor improvements to wpt exporter.
2275         https://bugs.webkit.org/show_bug.cgi?id=185978
2276
2277         Reviewed by Youenn Fablet.
2278
2279         * Scripts/webkitpy/w3c/test_exporter.py:
2280         (TestExporter.push_to_wpt_fork): Update call to create_upload_remote().
2281         (TestExporter.make_pull_request): Improve the description of the created PR.
2282         (TestExporter.create_upload_remote): Always update the remote to override any obsolete state.
2283
2284 2018-05-25  Saam Barati  <sbarati@apple.com>
2285
2286         Have a memory test where we can validate JSCs mini memory mode
2287         https://bugs.webkit.org/show_bug.cgi?id=185932
2288
2289         Reviewed by Mark Lam.
2290
2291         This patch adds the run-testmem script. This runs the new testmem
2292         CLI against the contents in the testmem benchmark. The contents of testmem
2293         contain tests from ARES-6, Sunspider, Octane, and JetStream.
2294         
2295         One iteration of the benchmark comprises of running each testmem test for
2296         a certain number of iterations. We collect the peak memory usage, the memory
2297         usage after running all the iterations, and the time it takes to run all the
2298         iterations. We then run the entire benchmark 3 times over. For each test, we
2299         compute the arithmetic mean over each iteration for time, peak memory, and
2300         end memory. The benchmark then computes a time score and memory score.
2301         
2302         peak memory score = geomean({peak memory of each individual test})
2303         end memory score = geomean({end memory of each individual test})
2304         memory score = geomean({peak memory score, end memory score})
2305         time score = geomean({time score of each individual test})
2306         
2307         We want the memory score to weigh improvements to peak memory usage and
2308         memory usage at the end equally.
2309         
2310         We plan to tune this benchmark in JSC's mini mode by improving the memory
2311         score while ensuring the time score is not more than 10-15% regressed.
2312
2313         * Scripts/run-testmem: Added.
2314
2315 2018-05-25  Sihui Liu  <sihui_liu@apple.com>
2316
2317         [WKHTTPCookieStore getAllCookies] returns inconsistent creation time
2318         https://bugs.webkit.org/show_bug.cgi?id=185041
2319         <rdar://problem/34684214>
2320
2321         Reviewed by Geoffrey Garen.
2322
2323         Add API test coverage.
2324
2325         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2326         (TEST):
2327
2328 2018-05-24  Chris Dumez  <cdumez@apple.com>
2329
2330         Reduce copying of FontCascadeDescription objects by moving them around
2331         https://bugs.webkit.org/show_bug.cgi?id=185963
2332
2333         Reviewed by Simon Fraser.
2334
2335         Reduce copying of FontCascadeDescription objects by moving them around when possible.
2336
2337         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2338         (TestWebKitAPI::TEST_F):
2339
2340 2018-05-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2341
2342         WebDriver: implement maximize, minimize and fullscreen window commands
2343         https://bugs.webkit.org/show_bug.cgi?id=180398
2344
2345         Reviewed by Brian Burg.
2346
2347         * Scripts/webkitpy/port/xvfbdriver.py:
2348         (XvfbDriver._setup_environ_for_test): Set UNDER_XVFB environment variable when running under Xvfb.
2349
2350 2018-05-24  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2351
2352         [GStreamer] Save some time disabling some compile options in the dependencies
2353         https://bugs.webkit.org/show_bug.cgi?id=185909
2354
2355         Reviewed by Philippe Normand.
2356
2357         * gstreamer/jhbuild.modules: Added  --disable-tests to gstreamer
2358         and --disable-examples --disable-gtk-doc to gstreamer-vaapi.
2359
2360 2018-05-23  Roy Reapor  <rreapor@apple.com>
2361
2362         Use Helvetica on build.webkit.org webpages
2363         https://bugs.webkit.org/show_bug.cgi?id=185894
2364
2365         Reviewed by Aakash Jain.
2366
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
2370
2371 2018-05-23  Aakash Jain  <aakash_jain@apple.com>
2372
2373         Add Buildbot configuration for Opensource EWS
2374         https://bugs.webkit.org/show_bug.cgi?id=185484
2375
2376         Rubber-stamped by Alexey Proskuryakov.
2377
2378         * BuildSlaveSupport/ews-build/config.json: Added, config file.
2379         * BuildSlaveSupport/ews-build/factories.py: Added, basic template for factories.
2380         * BuildSlaveSupport/ews-build/loadConfig.py: Added.
2381         (loadBuilderConfig): Loads the configuration.
2382         (checkValidWorker): Checks if the worker is valid.
2383         (checkValidBuilder): Checks if the builder is valid.
2384         (checkWorkersAndBuildersForConsistency): Check if workers and builders are consistent.
2385         (checkWorkersAndBuildersForConsistency._find_worker_with_name):
2386         (getBlackListedTags): Returns a list of keywords which should not be listed as tags.
2387         (getValidTags): Returns a list of valid tags.
2388         (getTagsForBuilder): Return a list of tags for given builder.
2389         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: unit-tests for loadConfig.py.
2390         * BuildSlaveSupport/ews-build/master.cfg: Configuration for buildbot.
2391
2392 2018-05-23  Michael Catanzaro  <mcatanzaro@igalia.com>
2393
2394         [GTK] Silence GCC 8 warnings
2395         https://bugs.webkit.org/show_bug.cgi?id=185556
2396
2397         Reviewed by Žan Doberšek.
2398
2399         GCC is complaining about this strncpy. It's guaranteed to be safe, because the length of
2400         source and destination are always identical. But switching to snprintf avoids the warning.
2401
2402         * DumpRenderTree/TestNetscapePlugIn/Tests/FormValue.cpp:
2403         (FormValue::NPP_GetValue):
2404
2405 2018-05-23  Ryan Haddad  <ryanhaddad@apple.com>
2406
2407         Unreviewed, rolling out r232112.
2408
2409         The tests added with this change  are failing on the bots.
2410
2411         Reverted changeset:
2412
2413         "test262/Runner.pm: add unit tests"
2414         https://bugs.webkit.org/show_bug.cgi?id=185783
2415         https://trac.webkit.org/changeset/232112
2416
2417 2018-05-23  Valerie R Young  <valerie@bocoup.com>
2418
2419         test262/Runner.pm: add unit tests
2420         https://bugs.webkit.org/show_bug.cgi?id=185783
2421
2422         Reviewed by Aakash Jain.
2423
2424         Add unit tests to be run by test-webkitperl
2425
2426         * Scripts/test262/Runner.pm:
2427         (main):
2428          - If harness files cannot be found in a custom, supplies test262 path,
2429            then sure the webkit test262 harness files.
2430          - Lazily create the test262-results directory.
2431          - If an expectation file is supplied via command line, save to the
2432            supplied location instead of the detault webkit location.
2433         (compileTest):
2434         (processResult):
2435         (getHarness):
2436         * Scripts/webkitperl/test262_unittest/README: Added.
2437         * Scripts/webkitperl/test262_unittest/fixtures/expectations-compare.yaml: Added.
2438         * Scripts/webkitperl/test262_unittest/fixtures/expectations.yaml: Added.
2439         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing-with-new-error.js: Added.
2440         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-failing.js: Added.
2441         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-fail-now-passing.js: Added.
2442         (f):
2443         * Scripts/webkitperl/test262_unittest/fixtures/test/expected-to-pass-now-failing.js: Added.
2444         * Scripts/webkitperl/test262_unittest/fixtures/test/fail.js: Added.
2445         * Scripts/webkitperl/test262_unittest/fixtures/test/pass.js: Added.
2446         (f):
2447         * Scripts/webkitperl/test262_unittest/test262-runner-tests.pl: Added.
2448
2449 2018-05-22  Roy Reapor  <rreapor@apple.com>
2450
2451         Test infrastructure websites should use jQuery and jQuery UI hosted on webkit.org
2452         https://bugs.webkit.org/show_bug.cgi?id=185788
2453
2454         Reviewed by Aakash Jain.
2455
2456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
2458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
2459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html:
2461         * TestResultServer/static-dashboards/run-embedded-unittests.html:
2462         * TestResultServer/static-dashboards/run-unittests.html:
2463
2464 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2465
2466         [iOS] TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPool is crashing with reason: 'Completion handler passed to -[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:] was not called'
2467         https://bugs.webkit.org/show_bug.cgi?id=185831
2468
2469         Reviewed by Chris Dumez.
2470
2471         Updated the test to prevent crash after assertion fails.
2472
2473         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2474         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2475
2476 2018-05-22  Chris Dumez  <cdumez@apple.com>
2477
2478         Regression(AsyncPolicyDelegates): Box.app login Window is blank
2479         https://bugs.webkit.org/show_bug.cgi?id=185832
2480         <rdar://problem/40307871>
2481
2482         Reviewed by Geoffrey Garen.
2483
2484         Add API test coverage.
2485
2486         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2487         * TestWebKitAPI/Tests/WebKit/cocoa/WeakObjCPtr.mm:
2488         * TestWebKitAPI/Tests/mac/NoPolicyDelegateResponse.mm: Added.
2489         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2490         (-[NoPolicyDelegateDecisionDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
2491         (-[NoPolicyDelegateDecisionDelegate webView:didFinishLoadForFrame:]):
2492         (TestWebKitAPI::TEST):
2493         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2494         (-[WKWebView _isBackground]):
2495
2496 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2497
2498         Conversion between SecurityOriginData and DatabaseIdentifier is asymmetric when port is null
2499         https://bugs.webkit.org/show_bug.cgi?id=185715
2500
2501         Reviewed by Geoffrey Garen.
2502
2503         Add API test coverage.
2504
2505         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2506         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Added.
2507         (-[LocalStorageUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2508         (TEST):
2509
2510 2018-05-22  Sihui Liu  <sihui_liu@apple.com>
2511
2512         Unreviewed, added myself as a WebKit committer.
2513
2514         * Scripts/webkitpy/common/config/contributors.json:
2515
2516 2018-05-22  Ryan Haddad  <ryanhaddad@apple.com>
2517
2518         Unreviewed, rolling out r232052.
2519
2520         Breaks internal builds.
2521
2522         Reverted changeset:
2523
2524         "Use more C++17"
2525         https://bugs.webkit.org/show_bug.cgi?id=185176
2526         https://trac.webkit.org/changeset/232052
2527
2528 2018-05-22  Thibault Saunier  <tsaunier@igalia.com>
2529
2530         [GStreamer] Update to GStreamer 1.14.1 in jhbuild
2531         https://bugs.webkit.org/show_bug.cgi?id=185689
2532
2533         Reviewed by Philippe Normand.
2534
2535         And update the patches, removing the ones that have been merged upstream.
2536
2537         * gstreamer/jhbuild.modules:
2538         * gstreamer/patches/gst-plugins-good-0001-gstgdkpixbufdec-stop-pretending-to-decode-gifs.patch: Removed.
2539         * gstreamer/patches/gst-plugins-good-0001-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed. Not needed anymore and closed as OBSELETE upstream.
2540         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch
2541         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
2542         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
2543         This patch has now been merged in GStreamer master and will be there in GStreamer 1.16.
2544         * gstreamer/patches/gst-plugins-good-0009-qtdemux-fix-assert-when-moof-contains-one-sample.patch: Removed.
2545         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
2546
2547 2018-05-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2548
2549         Use more C++17
2550         https://bugs.webkit.org/show_bug.cgi?id=185176
2551
2552         Reviewed by JF Bastien.
2553
2554         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2555         * ImageDiff/cg/Configurations/Base.xcconfig:
2556         * MiniBrowser/Configurations/Base.xcconfig:
2557         * MobileMiniBrowser/Configurations/Base.xcconfig:
2558         * TestWebKitAPI/Configurations/Base.xcconfig:
2559         * WebKitTestRunner/Configurations/Base.xcconfig:
2560
2561 2018-05-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2562
2563         [WinCairo] Enable WebKit build by default
2564         https://bugs.webkit.org/show_bug.cgi?id=185141
2565
2566         Reviewed by Per Arne Vollan.
2567
2568         TestWTF, TestWebCore and TestWebKitLegacy need a dependency to
2569         WebKitForwardingHeaders because config.h includes a header of WK2.
2570
2571         * TestWebKitAPI/PlatformWin.cmake: Make TestWTFLib, TestWebCoreLib and TestWebKitLegacyLib depend on WebKitForwardingHeaders.
2572         * TestWebKitAPI/config.h: Use PLATFORM(WIN_CAIRO) instead of BUILDING_WIN_CAIRO_WEBKIT.
2573
2574 2018-05-21  Jer Noble  <jer.noble@apple.com>
2575
2576         Complete fix for enabling modern EME by default
2577         https://bugs.webkit.org/show_bug.cgi?id=185770
2578         <rdar://problem/40368220>
2579
2580         Reviewed by Eric Carlson.
2581
2582         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2583
2584 2018-05-18  Christopher Reid  <chris.reid@sony.com>
2585
2586         Unreviewed, add myself as a WebKit committer.
2587
2588         * Scripts/webkitpy/common/config/contributors.json:
2589
2590 2018-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2591
2592         Unreviewed, rolling out r222967.
2593
2594         It's not ready yet
2595
2596         Reverted changeset:
2597
2598         "[GTK][WPE] Add API to configure and enable resource load
2599         statistics"
2600         https://bugs.webkit.org/show_bug.cgi?id=177943
2601         https://trac.webkit.org/changeset/222967
2602
2603 2018-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2604
2605         [GTK] MiniBrowser crashes when loading twice quickly
2606         https://bugs.webkit.org/show_bug.cgi?id=185763
2607
2608         Reviewed by Michael Catanzaro.
2609
2610         This is very difficult to reproduce manually, but it happens when running WebDriver tests where loads are very
2611         fast and multiple loads are done quickly. The problem is that we use an idle to reset the progress bar, but we
2612         don't reset it when a new load starts. We always reset the last idle on destroy, but if there's another one
2613         leaked, it will crash when scheduled if the window has already been destroyed.
2614
2615         * MiniBrowser/gtk/BrowserWindow.c:
2616         (webViewLoadProgressChanged): Stop any pending reset task when progress != 1.
2617
2618 2018-05-19  Sihui Liu  <sihui_liu@apple.com>
2619
2620         Flaky API test WebKit.WKHTTPCookieStoreWithoutProcessPool: incorrect order of cookies
2621         https://bugs.webkit.org/show_bug.cgi?id=185624
2622         <rdar://problem/39111626>
2623
2624         Reviewed by Chris Dumez.
2625
2626         Modified expectation to make test more robust as cookies can be returned in different orders.
2627
2628         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2629         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2630         (TEST):
2631
2632 2018-05-18  Commit Queue  <commit-queue@webkit.org>
2633
2634         Unreviewed, rolling out r231982.
2635         https://bugs.webkit.org/show_bug.cgi?id=185793
2636
2637         Caused layout test failures (Requested by realdawei on
2638         #webkit).
2639
2640         Reverted changeset:
2641
2642         "Complete fix for enabling modern EME by default"
2643         https://bugs.webkit.org/show_bug.cgi?id=185770
2644         https://trac.webkit.org/changeset/231982
2645
2646 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
2647
2648         Handle failure to extend sandbox gracefully
2649         https://bugs.webkit.org/show_bug.cgi?id=185779
2650         <rdar://problem/40316349>
2651
2652         Unreviewed, fix test results.
2653
2654         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2655         (TEST_F):
2656
2657 2018-05-18  Jer Noble  <jer.noble@apple.com>
2658
2659         Complete fix for enabling modern EME by default
2660         https://bugs.webkit.org/show_bug.cgi?id=185770
2661         <rdar://problem/40368220>
2662
2663         Reviewed by Eric Carlson.
2664
2665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2666
2667 2018-05-18  Eric Carlson  <eric.carlson@apple.com>
2668
2669         Handle failure to extend sandbox gracefully
2670         https://bugs.webkit.org/show_bug.cgi?id=185779
2671         <rdar://problem/40316349>
2672
2673         Reviewed by Brent Fulgham.
2674
2675         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2676         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm: Added.
2677         (-[SimulateFailedSandboxMessageHandler userContentController:didReceiveScriptMessage:]):
2678         (-[SimulateFailedSandboxUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2679         (-[SimulateFailedSandboxUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2680         (MediaCaptureSimulateFailedSandbox::SetUp):
2681         (MediaCaptureSimulateFailedSandbox::loadTestAndWaitForMessage):
2682         (TEST_F):
2683         * TestWebKitAPI/Tests/WebKitCocoa/disableGetUserMedia.html:
2684
2685 2018-05-18  Daniel Bates  <dabates@apple.com>
2686
2687         "debug-safari --ios-simulator" creates lldb target to launch Mac Safari
2688         https://bugs.webkit.org/show_bug.cgi?id=185774
2689
2690         Reviewed by Andy Estes.
2691
2692         For now, the script debug-safari is not supported for WebKit for iOS. To
2693         fix this we differentiate between the Apple Mac port and Apple embedded
2694         ports.
2695
2696         * Scripts/webkitdirs.pm:
2697         (safariPath): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2698         (isAppleMacWebKit): Added.
2699         (isAppleCocoaWebKit): Write in terms of isAppleMacWebKit() and isEmbeddedWebKit().
2700         (launcherName): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2701         (mobileSafariBundle): Substitute isIOSWebKit() for isAppleCocoaWebKit().
2702         (debugSafari): Substitute isAppleMacWebKit() for isAppleCocoaWebKit().
2703         (runSafari): Ditto.
2704         (runMiniBrowser): Ditto.
2705         (debugMiniBrowser): Ditto.
2706         (runWebKitTestRunner): Ditto.
2707         (debugWebKitTestRunner): Ditto.
2708
2709 2018-05-18  Antoine Quint  <graouts@apple.com>
2710
2711         [Web Animations] Turn Web Animations with CSS integration on for test runners
2712         https://bugs.webkit.org/show_bug.cgi?id=184819
2713         <rdar://problem/39597337>
2714
2715         Unreviewed. Rolling out the patch for this bug, it caused some flaky timeouts for animation suspension tests.
2716
2717         * DumpRenderTree/TestOptions.cpp:
2718         (TestOptions::TestOptions):
2719         * DumpRenderTree/TestOptions.h:
2720         * DumpRenderTree/mac/DumpRenderTree.mm:
2721         (runTest):
2722         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference): Deleted.
2723         * WebKitTestRunner/TestController.cpp:
2724         (WTR::TestController::resetPreferencesToConsistentValues):
2725         (WTR::updateTestOptionsFromTestHeader):
2726         * WebKitTestRunner/TestOptions.cpp:
2727         (WTR::TestOptions::TestOptions):
2728         (WTR::isLegacyAnimationEngineTestPath): Deleted.
2729         * WebKitTestRunner/TestOptions.h:
2730
2731 2018-05-18  Fujii Hironori  <Hironori.Fujii@sony.com>
2732
2733         [Win][MiniBrowser] Create MainWindow even in transparent mode
2734         https://bugs.webkit.org/show_bug.cgi?id=185597
2735
2736         Reviewed by Per Arne Vollan.
2737
2738         The current implementations doesn't create the MainWindow in
2739         transparent mode. The screenshot is in Bug 58300.
2740
2741         There were three problems:
2742         - Can't control the WebView. ie. going backward and forward.
2743         - Can't quit the program.
2744         - It makes implementation complicated.
2745
2746         * MiniBrowser/win/Common.cpp (resizeSubViews): Resize sub views
2747         even in the transparent mode.
2748         * MiniBrowser/win/WinMain.cpp:
2749         (wWinMain): Create the main window even in the transparent mode.
2750
2751 2018-05-18  Antoine Quint  <graouts@apple.com>
2752
2753         [Web Animations] Turn Web Animations with CSS integration on for test runners
2754         https://bugs.webkit.org/show_bug.cgi?id=184819
2755         <rdar://problem/39597337>
2756
2757         Reviewed by Jon Lee.
2758
2759         Make the test runners turn both the main Web Animations flag and the Web Animations CSS
2760         integration flag on.
2761
2762         We also remove the ability to toggle the Web Animations CSS integration flag using an HTML
2763         comment directly at the top of the file since test runners now set the flag on by default
2764         and a dedicated directory exists for tests that need to run with this flag off.
2765
2766         * DumpRenderTree/TestOptions.cpp:
2767         (TestOptions::TestOptions):
2768         * DumpRenderTree/TestOptions.h:
2769         * DumpRenderTree/mac/DumpRenderTree.mm:
2770         (shouldOverrideAndDisableWebAnimationsCSSIntegrationPreference):
2771         (runTest):
2772         * WebKitTestRunner/TestController.cpp:
2773         (WTR::TestController::resetPreferencesToConsistentValues):
2774         (WTR::updateTestOptionsFromTestHeader):
2775         * WebKitTestRunner/TestOptions.cpp:
2776         (WTR::isLegacyAnimationEngineTestPath):
2777         (WTR::TestOptions::TestOptions):
2778         * WebKitTestRunner/TestOptions.h:
2779
2780 2018-05-17  Nan Wang  <n_wang@apple.com>
2781
2782         AX: [macOS] Expose the primary screen height through AX API
2783         https://bugs.webkit.org/show_bug.cgi?id=185742
2784
2785         Reviewed by Chris Fleizach.
2786
2787         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2788         (attributesOfElement):
2789         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2790         (WTR::attributesOfElement):
2791
2792 2018-05-17  Commit Queue  <commit-queue@webkit.org>
2793
2794         Unreviewed, rolling out r231912.
2795         https://bugs.webkit.org/show_bug.cgi?id=185750
2796
2797         It is prompting the user when there is no WPT changes
2798         (Requested by bmac on #webkit).
2799
2800         Reverted changeset:
2801
2802         "Export changes to web-platform-test as part of the webkit-
2803         patch upload workflow"
2804         https://bugs.webkit.org/show_bug.cgi?id=184914
2805         https://trac.webkit.org/changeset/231912
2806
2807 2018-05-17  Valerie R Young  <valerie@bocoup.com>
2808
2809         test262/Runner.pm: expand $INC to find webkitdirs.pm
2810         https://bugs.webkit.org/show_bug.cgi?id=185739
2811
2812         Reviewed by Michael Saboff.
2813
2814         * Scripts/test262/Runner.pm:
2815         (getBuildPath):
2816
2817 2018-05-17  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2818
2819         [WPE] Implement and enable FULLSCREEN_API
2820         https://bugs.webkit.org/show_bug.cgi?id=185676
2821
2822         Reviewed by Žan Doberšek.
2823
2824         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
2825         (testWebViewFullScreen):
2826
2827 2018-05-17  Brendan McLoughlin  <brendan@bocoup.com>
2828
2829         Export changes to web-platform-test as part of the webkit-patch upload workflow
2830         https://bugs.webkit.org/show_bug.cgi?id=184914
2831
2832         Reviewed by Youenn Fablet.
2833
2834         * Scripts/webkitpy/tool/commands/upload.py:
2835         (Upload):
2836         (CreateBug.execute):
2837         (WPTChangeExport):
2838         * Scripts/webkitpy/tool/steps/__init__.py:
2839         * Scripts/webkitpy/tool/steps/wptchangeexport.py: Added.
2840         (WPTChangeExport):
2841         (WPTChangeExport.options):
2842         (WPTChangeExport.run):
2843         * Scripts/webkitpy/w3c/common.py:
2844         * Scripts/webkitpy/w3c/test_exporter.py:
2845         (WebPlatformTestExporter):
2846         (WebPlatformTestExporter.__init__):
2847         (WebPlatformTestExporter.username):
2848         (WebPlatformTestExporter.token):
2849         (WebPlatformTestExporter._github):
2850         (WebPlatformTestExporter._wpt_fork_branch_github_url):
2851         (WebPlatformTestExporter._wpt_fork_remote):
2852         (WebPlatformTestExporter._wpt_fork_push_url):
2853         (WebPlatformTestExporter._git):
2854         (WebPlatformTestExporter._branch_name):
2855         (WebPlatformTestExporter._public_branch_name):
2856         (WebPlatformTestExporter.has_wpt_changes):
2857         (WebPlatformTestExporter._create_patch):
2858         (WebPlatformTestExporter.create_git_patch):
2859         (WebPlatformTestExporter._prompt_for_token):
2860         (WebPlatformTestExporter._prompt_for_username):
2861         (WebPlatformTestExporter._ensure_username_and_token):
2862         (WebPlatformTestExporter._validate_and_save_token):
2863         (WebPlatformTestExporter.push_to_wpt_fork):
2864         (WebPlatformTestExporter.make_pull_request):
2865         (WebPlatformTestExporter.delete_local_branch):
2866         (parse_args):
2867         (TestExporter): Deleted.
2868         (TestExporter.__init__): Deleted.
2869         (TestExporter._ensure_wpt_repository): Deleted.
2870         (TestExporter._fetch_wpt_repository): Deleted.
2871         (TestExporter._ensure_new_branch_name): Deleted.
2872         (TestExporter.download_and_commit_patch): Deleted.
2873         (TestExporter.clean): Deleted.
2874         (TestExporter.create_branch_with_patch): Deleted.
2875         (TestExporter.push_to_wpt_fork): Deleted.
2876         (TestExporter.make_pull_request): Deleted.
2877         (TestExporter.create_wpt_pull_request): Deleted.
2878         (TestExporter.delete_local_branch): Deleted.
2879         (TestExporter.create_git_patch): Deleted.
2880         (TestExporter.create_upload_remote_if_needed): Deleted.
2881         (TestExporter.do_export): Deleted.
2882         * Scripts/webkitpy/w3c/test_exporter_unittest.py:
2883         (TestExporterTest.test_export):
2884         (TestExporterTest.test_export_with_specific_branch):
2885         (TestExporterTest):
2886         (TestExporterTest.test_export_interactive_mode):
2887         (TestExporterTest.test_export_invalid_token):
2888         (TestExporterTest.test_export_wrong_token):
2889
2890 2018-05-17  Valerie R Young  <valerie@bocoup.com>
2891
2892         test262/Runner.pm: look for jsc in path if cannot call webkit-build-directory
2893         https://bugs.webkit.org/show_bug.cgi?id=185650
2894
2895         Reviewed by Michael Saboff.
2896
2897         First, use jsc from CLI arg, then try to use webkit-build-directory,
2898         if that doesn't work, look for jsc in the $PATH
2899
2900         * Scripts/test262/Runner.pm:
2901         (processCLI):
2902         (getBuildPath):
2903         (runTest):
2904
2905 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
2906
2907         Test262-Runner: Adds a --timeout option
2908         https://bugs.webkit.org/show_bug.cgi?id=185696
2909
2910         Reviewed by Michael Saboff.
2911
2912         The timeout option is used to set a timeout execution in ms for each test run in JSC.
2913         The passed value - if defined - will be used as the value for the JSC --watchdog arg.
2914         * Scripts/test262/Runner.pm:
2915         (processCLI):
2916         (runTest):
2917
2918 2018-05-16  Leo Balter  <leonardo.balter@gmail.com>
2919
2920         Test262-Runner: Set timer for each test run
2921         https://bugs.webkit.org/show_bug.cgi?id=185692
2922
2923         Reviewed by Michael Saboff.
2924
2925         Sets a high resolution timer for each execution call of JSC, reporting
2926         the time in the results report to allow identifying slow tests.
2927         * Scripts/test262/Runner.pm:
2928         (main):
2929         (processFile):
2930         (runTest):
2931         (processResult):
2932
2933 2018-05-16  Andy VanWagoner  <andy@vanwagoner.family>
2934
2935         Add support for Intl NumberFormat formatToParts
2936         https://bugs.webkit.org/show_bug.cgi?id=185375
2937
2938         Reviewed by Yusuke Suzuki.
2939
2940         Add flag for NumberFormat formatToParts.
2941
2942         * Scripts/webkitperl/FeatureList.pm:
2943         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2944
2945 2018-05-14  Yusuke Suzuki  <utatane.tea@gmail.com>
2946
2947         [Win] Use C++17 in MSVC
2948         https://bugs.webkit.org/show_bug.cgi?id=185232
2949
2950         Reviewed by Alex Christensen.
2951
2952         Do not use `using namespace std;`. In C++17, we have std::byte. This "byte"
2953         conflicts with ::byte defined in Windows' header.
2954
2955         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
2956         (WindowedPluginTest::WindowedPluginTest):
2957         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2958         (logEventProc):
2959         (stringEvent):
2960         (AccessibilityController::winNotificationReceived):
2961         * DumpRenderTree/win/TextInputController.cpp:
2962         (markedRangeCallback):
2963         (firstRectForCharacterRangeCallback):
2964         (selectedRangeCallback):
2965         * DumpRenderTree/win/TextInputController.h:
2966         * DumpRenderTree/win/TextInputControllerWin.cpp:
2967         (TextInputController::markedRange):
2968         (TextInputController::firstRectForCharacterRange):
2969         (TextInputController::selectedRange):
2970
2971 2018-05-16  Sihui Liu  <sihui_liu@apple.com>
2972
2973         Session cookies aren't reliably set when using default WKWebSiteDataStore
2974         https://bugs.webkit.org/show_bug.cgi?id=185624
2975         <rdar://problem/39111626>
2976
2977         Reviewed by Geoffrey Garen.
2978
2979         Modified and enabled WebKit.WKHTTPCookieStoreWithoutProcessPool.
2980
2981         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2982         (-[CookieUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2983         (TEST):
2984
2985 2018-05-16  Valerie R Young  <valerie@bocoup.com>
2986
2987         test262/Runner.pm: save to supplied expectation file if supplied
2988         https://bugs.webkit.org/show_bug.cgi?id=185660
2989
2990         Reviewed by Michael Saboff.
2991
2992         * Scripts/test262/Runner.pm:
2993         (processCLI):
2994         (main):
2995
2996 2018-05-15  Ryan Haddad  <ryanhaddad@apple.com>
2997
2998         Unreviewed, rolling out r231763.
2999
3000         The test added with this change is failing an assertion.
3001
3002         Reverted changeset:
3003
3004         "NSEvent event trackers don't work from WebKitTestRunner"
3005         https://bugs.webkit.org/show_bug.cgi?id=185383
3006         https://trac.webkit.org/changeset/231763
3007
3008 2018-05-15  David Kilzer  <ddkilzer@apple.com>
3009
3010         TestWebKitAPI: Fix warnings found by new clang compiler
3011         <https://webkit.org/b/185631>
3012
3013         Reviewed by Michael Catanzaro.
3014
3015         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp:
3016         (TestWebKitAPI::TEST):
3017         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3018         (TestWebKitAPI::TEST):
3019         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
3020         (TestWebKitAPI::TEST):
3021         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
3022         (TestWebKitAPI::TEST):
3023         - Add #pragma statements to ignore the new
3024           -Wself-assign-overloaded warning and to ignore
3025           this as an unknown warning on older clang versions.  We want
3026           to keep these self assigments as this code is designed to test
3027           that use case.
3028
3029         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3030         (TestWebKitAPI::didFindStringMatches):
3031         - Replace the "rect = rect;" statement that was used to avoid an
3032           unused variable warning with two expectations.
3033
3034         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3035         (-[PinnedStateObserver observeValueForKeyPath:ofObject:change:context:]):
3036         - Switch from -integerValue to -unsignedIntegerValue when
3037           comparing against _WKRectEdgeAll since it's an enum declared
3038           as an NSUInteger.
3039
3040 2018-05-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3041
3042         Unreviewed, rolling out r230749
3043
3044         This did not work as desired.
3045
3046         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3047         (TestWebKitAPI::TEST):
3048
3049 2018-05-15  Antoine Quint  <graouts@apple.com>
3050
3051         [Web Animations] Expose Web Animations CSS integration as an experimental feature
3052         https://bugs.webkit.org/show_bug.cgi?id=185647
3053
3054         Reviewed by Dean Jackson.
3055
3056         Rename the Web Animations CSS integration flag.
3057
3058         * DumpRenderTree/TestOptions.cpp:
3059         (TestOptions::TestOptions):
3060         * DumpRenderTree/TestOptions.h:
3061         * DumpRenderTree/mac/DumpRenderTree.mm:
3062         (setWebPreferencesForTestOptions):
3063         * WebKitTestRunner/TestController.cpp:
3064         (WTR::TestController::resetPreferencesToConsistentValues):
3065         (WTR::updateTestOptionsFromTestHeader):
3066         * WebKitTestRunner/TestOptions.h:
3067         (WTR::TestOptions::hasSameInitializationOptions const):
3068
3069 2018-05-14  Brady Eidson  <beidson@apple.com>
3070
3071         Add an API test to guard against regressions while re-entering setDefersLoading:.
3072         <rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630
3073
3074         Reviewed by Chris Dumez.
3075
3076         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3077         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.
3078         (-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
3079         (-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
3080         (-[DefersScheme initWithBytes:]):
3081         (-[DefersScheme webView:startURLSchemeTask:]):
3082         (-[DefersScheme webView:stopURLSchemeTask:]):
3083         * TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.
3084         (-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3085         (-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
3086         (-[DoubleDefersLoadingPlugIn dealloc]):
3087
3088 2018-05-14  Daniel Bates  <dabates@apple.com>
3089
3090         [iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
3091         https://bugs.webkit.org/show_bug.cgi?id=185599
3092         <rdar://problem/22493890>
3093
3094         Reviewed by Simon Fraser.
3095
3096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3097         * TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.
3098         (-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
3099         (-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
3100         (-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
3101         (TestWebKitAPI::TEST):
3102         * TestWebKitAPI/ios/set-timeout-function.html: Added.
3103
3104 2018-05-14  Valerie R Young  <valerie@bocoup.com>
3105
3106         test262/Runner.pm: small bugs in CLI and error codes
3107         https://bugs.webkit.org/show_bug.cgi?id=185629
3108
3109         Reviewed by Michael Saboff.
3110
3111         Fix two commandline args with use '-f', correct
3112         error code of failures.
3113
3114         * Scripts/test262/Runner.pm:
3115         (processCLI):
3116         (main):
3117
3118 2018-05-14  Ryan Haddad  <ryanhaddad@apple.com>
3119
3120         Disable API tests that time out after pointer poisioning was disabled.
3121         https://bugs.webkit.org/show_bug.cgi?id=185586
3122
3123         Unreviewed test gardening.
3124
3125         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
3126         (TestWebKitAPI::TEST):
3127         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
3128         (TestWebKitAPI::TEST):
3129         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
3130         (TestWebKitAPI::TEST):
3131         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
3132         (TestWebKitAPI::TEST):
3133
3134 2018-05-14  Leo Balter  <leonardo.balter@gmail.com>
3135
3136         Test262-Runner: Fix RegExp for capturing tests metadata"
3137         https://bugs.webkit.org/show_bug.cgi?id=185622
3138
3139         Reviewed by Michael Saboff.
3140
3141         This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
3142         both LF and CRLF forms.
3143
3144         The fix also allows the runner to capture the proper results from two specific files using CR and
3145         CRLF line terminators. They are updated in the expectations file.
3146         * Scripts/test262/Runner.pm:
3147         (parseData):
3148
3149 2018-05-14  Jeremy Jones  <jeremyj@apple.com>
3150
3151         NSEvent event trackers don't work from WebKitTestRunner
3152         https://bugs.webkit.org/show_bug.cgi?id=185383
3153         rdar://problem/40025045
3154
3155         Reviewed by Simon Fraser.
3156
3157         Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
3158         NSEvent swipe tracking is used for webkit swipe navigation.
3159
3160         * WebKitTestRunner/mac/EventSenderProxy.mm:
3161         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3162
3163 2018-05-11  Leo Balter  <leonardo.balter@gmail.com>
3164
3165         Test262 Runner should search for the Debug JSC by default
3166         https://bugs.webkit.org/show_bug.cgi?id=185562
3167
3168         Reviewed by Michael Saboff.
3169
3170         The Test262 Runner is now searching for the Debug build of JSC by
3171         default, not the Release build.
3172
3173         This fix allows a similar call from the previous runner, making
3174         it compatible with the current build bot configuration parameters.
3175
3176         This patch also adds some minor improvements the verbose mode output.
3177
3178         * Scripts/test262/Runner.pm:
3179         (processCLI):
3180         (main):
3181         (getBuildPath):
3182         (processResult):
3183
3184 2018-05-11  Charles Vazac  <cvazac@gmail.com>
3185
3186         Runtime feature flag for Server-Timing
3187         https://bugs.webkit.org/show_bug.cgi?id=184758
3188
3189         Reviewed by Youenn Fablet.
3190
3191         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
3192         * DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing
3193
3194 2018-05-11  Fujii Hironori  <Hironori.Fujii@sony.com>
3195
3196         [Win][MiniBrowser] Move WK1 related code into MiniBrowser
3197         https://bugs.webkit.org/show_bug.cgi?id=185418
3198
3199         Reviewed by Alex Christensen.
3200
3201         All WK1 related code should be moved into MiniBrowser for the preparation
3202         of Bug 184770.
3203
3204         This change moves the initilization code of MiniBrowse into MiniBrowser::init().
3205
3206         * MiniBrowser/win/Common.cpp:
3207         (getAppDataFolder): Removed `static` keyword to be called from MiniBrowser.cpp.
3208         (setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.
3209         * MiniBrowser/win/Common.h: Added.
3210         * MiniBrowser/win/MiniBrowser.cpp:
3211         (MiniBrowser::init): Moved the initilization code from wWinMain.
3212         (MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.
3213         * MiniBrowser/win/MiniBrowser.h:
3214         (MiniBrowser::setCacheFolder): Changed to a private method.
3215         (MiniBrowser::subclassForLayeredWindow): Changed to a private method.
3216         * MiniBrowser/win/WinMain.cpp:
3217         (wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.
3218
3219 2018-05-11  Brady Eidson  <beidson@apple.com>
3220
3221         Make sure history navigations reuse the existing process when necessary.
3222         <rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532
3223
3224         Reviewed by Ryosuke Niwa.
3225
3226         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3227
3228 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3229
3230         [JSC][GLIB] Add introspectable alternatives to functions using vargars
3231         https://bugs.webkit.org/show_bug.cgi?id=185508
3232
3233         Reviewed by Michael Catanzaro.
3234
3235         Add test cases for the new API.
3236
3237         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3238         (testJSCFunction):
3239         (testJSCObject):
3240
3241 2018-05-10  Leo Balter  <leonardo.balter@gmail.com>
3242
3243         [Build Bot] Restore configuration options to the Test262 Runner
3244
3245         During the switch from the previous Test262 runner to the new one,
3246         a call for an extra configurations options got removed.
3247
3248         This call is important to inform the script to find the debug or
3249         release build of JSC. It's being restored in this patch.
3250
3251         https://bugs.webkit.org/show_bug.cgi?id=185513
3252
3253         Reviewed by Yusuke Suzuki.
3254
3255         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3256         (RunTest262Tests):
3257
3258 2018-05-10  Jonathan Bedard  <jbedard@apple.com>
3259
3260         REGRESSION (r230998): Cannot stream API test output
3261         https://bugs.webkit.org/show_bug.cgi?id=185090
3262
3263         Reviewed by Ryosuke Niwa.
3264
3265         Change run-api-tests so that the stdout and stderr of a test will be printed
3266         before it's result. If -v is passed, the output of single test runs will be
3267         streamed. 
3268
3269         * Scripts/webkitpy/api_tests/run_api_tests.py:
3270         (run): Use print_timestamps flag.
3271         (parse_args): Add timestamps option to print timestamps in the log.
3272         * Scripts/webkitpy/api_tests/runner.py:
3273         (Runner): Add running status.
3274         (Runner.__init__): Add number of workers and a flag to detect if a newline
3275         is needed at the beginning of a log line.
3276         (Runner.run): Turn off most logging coming from server process since it is
3277         not constructive for API tests.
3278         (Runner.handle): Add new log message to stream stdout and stderr instead of
3279         caching values until the test run finished.
3280         (_Worker._run_single_test): Log stdout and stderr in real time.
3281         (_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
3282         the test.
3283         (_Worker.post): Provide a post with explicitly enumerated argument names.
3284         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3285         (MeteredStream.__init__): Differentiate verbose logging and logging with timestamps.
3286         (MeteredStream.write): Allow for verbose logging without timestamps.
3287         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
3288         (RegularTest): Add print_timestamps flag.
3289         (RegularTest.setUp):
3290         (RegularTest.test_logging_not_included):
3291         (VerboseTest.test_log_args):
3292         (VerboseWithOutTimestamp):
3293         (VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.
3294
3295 2018-05-10  Ryosuke Niwa  <rniwa@webkit.org>
3296
3297         build-webkit can erroneously warn about Xcode being too old
3298         https://bugs.webkit.org/show_bug.cgi?id=185533
3299
3300         Reviewed by Dan Bernstein.
3301
3302         Don't assume the version number is always a single digit.
3303
3304         * Scripts/webkitdirs.pm:
3305         (determineXcodeVersion):
3306
3307 2018-05-10  Ross Kirsling  <ross.kirsling@sony.com>
3308
3309         [WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
3310         https://bugs.webkit.org/show_bug.cgi?id=185528
3311
3312         Reviewed by Lucas Forschler.
3313
3314         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3315         (TestFactory.__init__):
3316         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3317         (InstallWinCairoDependencies):
3318
3319 2018-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3320
3321         Fix some -Wstring-op-truncation warnings
3322         https://bugs.webkit.org/show_bug.cgi?id=185496
3323
3324         Reviewed by Alex Christensen.
3325
3326         We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
3327         the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
3328         set the last bucket to NUL.
3329
3330         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
3331         (TestWebKitAPI::testAtomicStringNumber):
3332         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3333         (TestWebKitAPI::testStringNumberFixedPrecision):
3334         (TestWebKitAPI::testStringNumberFixedWidth):
3335         (TestWebKitAPI::testStringNumber):
3336
3337 2018-05-10  Fujii Hironori  <Hironori.Fujii@sony.com>
3338
3339         [Win][MiniBrowser] Add a separate WndProc for the layered window
3340         https://bugs.webkit.org/show_bug.cgi?id=185460
3341
3342         Reviewed by Brent Fulgham.
3343
3344         All WK1 related code should be moved into MiniBrowser for the
3345         preparation of Bug 184770.
3346
3347         The layered window was using WndProc of the main window. The
3348         layered window is specific only for WK1. the main window will be
3349         shared among WK1 and WK2.
3350
3351         This change add a new WndProc for the layer window.
3352
3353         * MiniBrowser/win/Common.cpp:
3354         (WndProc): Removed code for the layered windows.
3355         (subclassForLayeredWindow): Moved into MiniBrowser.cpp.
3356         * MiniBrowser/win/MiniBrowser.cpp:
3357         (MiniBrowser::prepareViews): Removed the fourth argument `viewHwnd`.
3358         (viewWndProc): New WndProc for the layered windows.
3359         (MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.
3360         * MiniBrowser/win/MiniBrowser.h:
3361         (MiniBrowser::hwnd):
3362         * MiniBrowser/win/WinMain.cpp:
3363         (wWinMain): Added m_viewWnd.
3364
3365 2018-05-10  Stephan Szabo  <stephan.szabo@sony.com>
3366
3367         Support --verbose in run-javascriptcore-tests
3368         https://bugs.webkit.org/show_bug.cgi?id=185492
3369
3370         Reviewed by Daniel Bates.
3371
3372         * Scripts/run-javascriptcore-tests:
3373         (runJSCStressTests):
3374
3375 2018-05-10  Valerie R Young  <valerie@bocoup.com>
3376
3377         test262/Runner.pm: --failing-files uses results file not expectations
3378         https://bugs.webkit.org/show_bug.cgi?id=185395
3379
3380         Reviewed by Michael Saboff.
3381
3382         --failing-files arg now uses results file to find failing tests
3383         to rerun. It will look in the test262-results directory from whereever
3384         the script is run, or a results.yaml file can be supplied via command
3385         line argument.
3386         --expectations arg added for suppling expectation file.
3387
3388         * Scripts/test262/Runner.pm:
3389         (processCLI):
3390         (main):
3391         (loadImportFile):
3392         (findAllFailing):
3393
3394 2018-05-10  Carlos Garcia Campos  <cgarcia@igalia.com>
3395
3396         [GTK] Add support for settings cookies policy and storage type in MiniBrowser
3397         https://bugs.webkit.org/show_bug.cgi?id=185506
3398
3399         Reviewed by Philippe Normand.
3400
3401         Useful for testing and debugging.
3402
3403         * MiniBrowser/gtk/main.c:
3404         (main):
3405
3406 2018-05-09  Chris Dumez  <cdumez@apple.com>
3407
3408         Unreviewed Windows build fix after r231622.
3409
3410         * DumpRenderTree/win/DumpRenderTree.cpp:
3411         (enableExperimentalFeatures):
3412
3413 2018-05-09  Sihui Liu  <sihui_liu@apple.com>
3414
3415         Update WebKit.WebsiteDataStoreCustomPaths after r231536
3416         https://bugs.webkit.org/show_bug.cgi?id=185486
3417         <rdar://problem/37214391>
3418
3419         Reviewed by Chris Dumez.
3420
3421         Update WebKit.WebsiteDataStoreCustomPaths as _syncNetworkProcessCookies is async now.
3422
3423         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3424         (TEST):
3425
3426 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
3427
3428         Test262-Runner: Improve the verbose output
3429         https://bugs.webkit.org/show_bug.cgi?id=185491
3430
3431         Reviewed by Michael Saboff.
3432
3433         * Scripts/test262/Import.pm:
3434         (transferFiles):
3435         * Scripts/test262/Runner.pm:
3436         (processResult):
3437
3438 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
3439
3440         Fix Test262 Runner to have DYLD_FRAMEWORK_PATH always set
3441         https://bugs.webkit.org/show_bug.cgi?id=185488
3442
3443         Reviewed by Michael Saboff.
3444
3445         * Scripts/test262/Runner.pm:
3446         (processCLI):
3447         (getBuildPath):
3448         (runTest):
3449
3450 2018-05-09  Richard Houle  <rhoule@apple.com>
3451
3452         [Cocoa] Some fields are not identified as [WKWebProcessPlugInNodeHandle isTextField]
3453         https://bugs.webkit.org/show_bug.cgi?id=185260
3454         <rdar://problem/39290394>
3455
3456         Reviewed by Tim Horton.
3457
3458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3459         * TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsTextField.mm: Added.
3460         (-[InjectedBundleNodeHandleIsTextField isTextFieldForHTMLInputType:document:jsContext:]):
3461         (-[InjectedBundleNodeHandleIsTextField webProcessPlugIn:didCreateBrowserContextController:]):
3462         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3463         (-[InjectedBundleNodeHandleIsTextFieldDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3464
3465 2018-05-09  Thibault Saunier  <tsaunier@igalia.com>
3466
3467         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
3468         https://bugs.webkit.org/show_bug.cgi?id=185481
3469
3470         Reviewed by Philippe Normand.
3471
3472         [tests][GStreamer]: Pass USE_PLAYBIN3 to the tests subprocess
3473
3474         * Scripts/webkitpy/port/gtk.py:
3475         (GtkPort.setup_environ_for_server):
3476
3477 2018-05-09  Leo Balter  <leonardo.balter@gmail.com>
3478
3479         Set build.webkit.org to use the new Test262-runner
3480         https://bugs.webkit.org/show_bug.cgi?id=184933
3481
3482         Reviewed by Aakash Jain.
3483
3484         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3485         (RunTest262Tests):
3486         (RunTest262Tests.countFailures):
3487         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3488
3489 2018-05-09  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3490
3491         [GTK][JHBuild] LLVM 3.7.0 build is broken with GCC 8.1
3492         https://bugs.webkit.org/show_bug.cgi?id=185461
3493
3494         Reviewed by Michael Catanzaro.
3495
3496         JHBuild now compiles LLVM 6 and Mesa 18.0.3.
3497
3498         * gtk/jhbuild.modules:
3499
3500 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3501
3502         Unreviewed. Update OptionsWPE.cmake and NEWS for 2.21.1 release.
3503
3504         * wpe/manifest.txt.in: Distribute the NEWS.
3505
3506 2018-05-09  Michael Catanzaro  <mcatanzaro@igalia.com>
3507
3508         [WPE] Build cleanly with GCC 8 and ICU 60
3509         https://bugs.webkit.org/show_bug.cgi?id=185462
3510
3511         Reviewed by Carlos Alberto Lopez Perez.
3512
3513         * TestWebKitAPI/CMakeLists.txt: Fix weird build failure, we were missing a directory. Not
3514         sure why this was never noticed until now or why the bots are OK.
3515         * gtk/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
3516         * gtk/patches/glib-cast-function-type.patch: Added.
3517         * wpe/jhbuild.modules: Add upstream patch to avoid warnings inside G_DEFINE_TYPE.
3518         * wpe/patches/glib-cast-function-type.patch: Added.
3519
3520 2018-05-06  Yusuke Suzuki  <utatane.tea@gmail.com>
3521
3522         [JSC][GTK][JSCONLY] Use capstone disassembler
3523         https://bugs.webkit.org/show_bug.cgi?id=185283
3524
3525         Reviewed by Michael Catanzaro.
3526
3527         * gtk/manifest.txt.in:
3528         * wpe/manifest.txt.in:
3529
3530 2018-05-09  Antti Koivisto  <antti@apple.com>
3531
3532         Add OptionSet::operator& and operator bool
3533         https://bugs.webkit.org/show_bug.cgi?id=185306
3534
3535         Reviewed by Anders Carlsson.
3536
3537         * TestWebKitAPI/Tests/WTF/OptionSet.cpp:
3538         (TestWebKitAPI::TEST):
3539
3540 2018-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
3541
3542         Consolidate WebContentReaderIOS and WebContentReaderMac into WebContentReaderCocoa
3543         https://bugs.webkit.org/show_bug.cgi?id=185340
3544
3545         Reviewed by Tim Horton.
3546
3547         Adds a new API test to verify that URLs written using -[NSPasteboard writeObjects:] are pasted as anchors with
3548         non-empty text in a contenteditable.
3549
3550         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3551         (TestWebKitAPI::TEST):
3552
3553 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3554
3555         test262/Runner.pm: create results dir for results of test262 run
3556         https://bugs.webkit.org/show_bug.cgi?id=185392
3557
3558         Reviewed by Michael Saboff.
3559
3560         New directory test262-results created from where ever script is
3561         called.
3562
3563         * Scripts/test262/Runner.pm:
3564         (processCLI):
3565
3566 2018-05-08  Valerie R Young  <valerie@bocoup.com>
3567
3568         test262/Runner.pm: lower number of processes per core
3569         https://bugs.webkit.org/show_bug.cgi?id=185426
3570
3571         Reviewed by Michael Saboff.
3572
3573         * Scripts/test262/Runner.pm:
3574         (getProcesses):
3575
3576 2018-05-08  Leo Balter  <leonardo.balter@gmail.com>
3577
3578         Test262-Runner: Add base Perl UnicodeData
3579         https://bugs.webkit.org/show_bug.cgi?id=185444
3580
3581         Reviewed by Michael Saboff.
3582
3583         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/SpacePer.pl: Added.
3584         * Scripts/test262/local/lib/perl5/unicore/lib/gc_sc/Word.pl: Added.
3585
3586 2018-05-08  Daniel Bates  <dabates@apple.com>
3587
3588         Add tests to ensure that the Strong Password appearance is removed on form reset
3589         https://bugs.webkit.org/show_bug.cgi?id=185440
3590
3591         Reviewed by Ryosuke Niwa.
3592
3593         * TestWebKitAPI/Tests/WebKitCocoa/DidResignInputElementStrongPasswordAppearance.mm:
3594         (-[DidResignInputElementStrongPasswordAppearance webProcessPlugIn:didCreateBrowserContextController:]):
3595         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3596         (TEST):
3597
3598 2018-05-08  Daniel Bates  <dabates@apple.com>
3599
3600         Resign Strong Password appearance when text field value changes
3601         https://bugs.webkit.org/show_bug.cgi?id=185433
3602         <rdar://problem/39958508>
3603