1 2013-08-26 Carlos Garcia Campos <cgarcia@igalia.com>
3 [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations
4 https://bugs.webkit.org/show_bug.cgi?id=120290
6 Reviewed by Philippe Normand.
8 * MiniBrowser/gtk/GNUmakefile.am: Add
9 -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
11 2013-08-26 Zan Dobersek <zdobersek@igalia.com>
13 [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program
14 https://bugs.webkit.org/show_bug.cgi?id=120288
16 Reviewed by Carlos Garcia Campos.
18 * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
19 into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
20 These unit tests are at the moment failing in debug configurations, so it would be nice to
21 have the GTK builds report these failures as well.
23 2013-08-25 Ryuan Choi <ryuan.choi@samsung.com>
25 [EFL] EWebLauncher is executed as full screen with device pixel ratio
26 https://bugs.webkit.org/show_bug.cgi?id=120282
28 Reviewed by Gyuyoung Kim.
30 * EWebLauncher/main.c:
31 Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
33 2013-08-25 Zan Dobersek <zdobersek@igalia.com>
35 [gdb] Remove the pretty printer for KURLGooglePrivate
36 https://bugs.webkit.org/show_bug.cgi?id=120263
38 Reviewed by Benjamin Poulain.
40 Remove the pretty printer for the WebCore::KURLGooglePrivate structure that
41 was usable inside the gdb debugger. The structure was remove from the codebase
42 along with the GoogleURL backend for KURL.
45 (JSCJSStringPrinter.to_string):
46 (add_pretty_printers):
48 2013-08-24 Filip Pizlo <fpizlo@apple.com>
50 Unreviewed, fix build-webkit --ftl-jit in the case that you have your own llvm directory. We need to
51 prune 'libgtest' and friends from the llvm build, since WebKit builds its own and none of the llvm
52 libraries depend on libgtest anyway.
54 * Scripts/copy-webkitlibraries-to-product-directory:
56 2013-08-24 Darin Adler <darin@apple.com>
58 RetainPtr lacks move constructor for case when argument is a RetainPtr of a different type
59 https://bugs.webkit.org/show_bug.cgi?id=120255
61 Reviewed by Andreas Kling.
63 * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added four tests covering move assignment and construction.
65 2013-08-24 Anders Carlsson <andersca@apple.com>
67 Don't treat NSLocalizedDescriptionKey and NSLocalizedRecoverySuggestionErrorKey as NSLocalized macros
68 https://bugs.webkit.org/show_bug.cgi?id=120249
70 Reviewed by Andreas Kling.
72 * Scripts/extract-localizable-strings:
74 2013-08-24 Carlos Garcia Campos <cgarcia@igalia.com>
76 [GTK] Expose WebKitFrame in WebKit2GTK+ web extensions API
77 https://bugs.webkit.org/show_bug.cgi?id=119743
79 Reviewed by Anders Carlsson.
81 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
82 (WTR::InjectedBundlePage::InjectedBundlePage): Add
85 2013-08-23 Thiago de Barros Lacerda <thiago.lacerda@openbossa.org>
87 Move TestWebKitAPI_LIBRARIES before platform specific cmake include
88 https://bugs.webkit.org/show_bug.cgi?id=120220
90 Reviewed by Martin Robinson.
92 * TestWebKitAPI/CMakeLists.txt:
94 2013-08-22 Filip Pizlo <fpizlo@apple.com>
96 build-jsc --ftl-jit should work
97 https://bugs.webkit.org/show_bug.cgi?id=120194
99 Reviewed by Oliver Hunt.
101 * Scripts/build-jsc: Need to pass the feature flag to xcodebuild
103 2013-08-23 Commit Queue <commit-queue@webkit.org>
105 Unreviewed, rolling out r153534.
106 http://trac.webkit.org/changeset/153534
107 https://bugs.webkit.org/show_bug.cgi?id=120216
109 Too many tests failing just WinEWS bots (Requested by rfong on
112 * Scripts/webkitpy/common/config/ews.json:
114 2013-08-23 Alex Christensen <alex.christensen@flexsim.com>
116 Unreviewed. Added my webkit.org email address.
118 * Scripts/webkitpy/common/config/contributors.json:
120 2013-08-23 Peter Gal <galpeter@inf.u-szeged.hu>
122 [WTR] Should dump as text when the mimetype is text/plain
123 https://bugs.webkit.org/show_bug.cgi?id=118306
125 Reviewed by Christophe Dumez.
127 Check for the text/plain mimetype and if true then mark it as
130 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
131 (WTR::InjectedBundlePage::dump):
133 2013-08-22 Filip Pizlo <fpizlo@apple.com>
135 Update LLVM binary drops and scripts to the latest version from SVN
136 https://bugs.webkit.org/show_bug.cgi?id=120184
138 Reviewed by Mark Hahnenberg.
140 * ReducedFTL/build.sh:
141 * Scripts/configure-llvm: Added.
142 * Scripts/copy-webkitlibraries-to-product-directory:
143 * Scripts/export-llvm-build:
145 2013-08-22 Andy Estes <aestes@apple.com>
147 <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files
149 Reviewed by David Kilzer.
151 * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
152 OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
153 DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
155 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
157 NRWT: Add the ability to upload test results to new test results server
158 https://bugs.webkit.org/show_bug.cgi?id=120146
160 Reviewed by Andreas Kling.
162 For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
163 that contains the full summary of the test run including information about passed tests.
165 Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
168 --results-server-host
170 The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
171 so we should be able to delete --test-results-server in time.
173 * Scripts/webkitpy/layout_tests/controllers/manager.py:
175 (Manager._upload_json_files):
177 (Manager.upload_results):
178 * Scripts/webkitpy/layout_tests/models/test_run_results.py:
180 * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
181 (summarized_results):
182 (SummarizedResultsTest.test_summarized_results_wontfix):
183 (SummarizedResultsTest):
184 (SummarizedResultsTest.test_summarized_results_include_passes):
185 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
188 2013-08-22 Ryosuke Niwa <rniwa@webkit.org>
190 WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that.
192 * Scripts/webkitpy/tool/bot/irc_command.py:
195 2013-08-22 Allan Sandfeld Jensen <allan.jensen@digia.com>
197 [Qt] DRT bug revealed/caused by r154300
198 https://bugs.webkit.org/show_bug.cgi?id=120151
200 Reviewed by Simon Hausmann.
202 Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
203 the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
206 DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
207 between native Qt methods and JSC bound methods. This patch changes the check to see if the
208 property is writable since the Qt methods are ReadOnly.
210 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
211 (DumpRenderTree::initJSObjects):
213 2013-08-21 Joseph Pecoraro <pecoraro@apple.com>
215 <https://webkit.org/b/120134> [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
217 Reviewed by Benjamin Poulain.
219 WTFString moved the is8bit bit by one in r152201.
221 * lldb/lldb_webkit.py:
222 (WTFStringImplProvider.is_8bit):
224 2013-08-21 Tim Horton <timothy_horton@apple.com>
226 Revert http://trac.webkit.org/changeset/154022, as it failed to update
227 a variety of scripts that depended on the old format.
229 See https://bugs.webkit.org/show_bug.cgi?id=120131 for one such example.
231 * Scripts/prepare-ChangeLog:
233 (generateNewChangeLogs):
235 2013-08-21 Brent Fulgham <bfulgham@apple.com>
237 [Windows] Unreviewed gardening: WebInspector should always be enabled for WinLauncher.
239 * WinLauncher/WinLauncher.cpp:
240 (setToDefaultPreferences): Activate Developer Extras on Release (as well as Debug) builds.
242 2013-08-21 Zan Dobersek <zdobersek@igalia.com>
244 <https://webkit.org/b/120116> [GTK] Fix a typo in ActivateFontsGtk.cpp
246 Reviewed by Andreas Kling.
248 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
249 (WTR::initializeFontConfigSetting): Fix a typo - inititialize -> initialize.
250 (WTR::activateFonts): Ditto.
252 2013-08-21 Brian Holt <brian.holt@samsung.com>
254 [GTK] Suppress irrelevant or known leaks for Valgrind
255 https://bugs.webkit.org/show_bug.cgi?id=119448
257 Reviewed by Martin Robinson.
259 Add a suppressions file to suppress known leaks for Valgrind.
260 Valgrind also takes longer when using suppressions and
261 times out unless the driver timeout is increased.
263 * Scripts/valgrind/suppressions.txt: Added.
264 * Scripts/webkitpy/port/gtk.py:
265 (GtkPort.driver_stop_timeout):
266 (GtkPort.setup_environ_for_server):
268 2013-08-20 Alex Christensen <achristensen@apple.com>
270 [Windows] Linking fix for Win64.
272 Rubberstamped by Brent Fulgham.
274 * win/DLLLauncher/DLLLauncherMain.cpp:
275 (wWinMain): Corrected 64-bit linker symbol for dllLauncherEntryPoint.
277 2013-08-20 Brent Fulgham <bfulgham@apple.com>
279 <https://webkit.org/b/120090> Report better error messages from WinLauncher/DRT
281 Reviewed by Tim Horton.
283 * win/DLLLauncher/DLLLauncherMain.cpp:
284 (getLastErrorString): New method to convert GetLastError to text.
285 (wWinMain): Use new error formatter to provide useful diagnostic text to user.
287 2013-08-19 Gustavo Noronha Silva <gns@gnome.org>
289 <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings
291 Reviewed by Martin Robinson.
293 * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
294 from naming/enum_casing rules, since it needs to provide GObject-style APIs.
296 2013-08-20 Anton Obzhirov <a.obzhirov@samsung.com>
298 <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser
300 Reviewed by Martin Robinson.
302 Added stop button in MiniBrowser
304 * MiniBrowser/gtk/BrowserWindow.c:
305 (reloadOrStopCallback): Callback to handle stop or reload button click.
306 (webViewLoadProgressChanged): Update reload or stop button icon.
307 (browser_window_init): Save button pointer for further icon updates.
309 2013-08-20 Simon Pena <simon.pena@samsung.com>
311 <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
313 Reviewed by Alexey Proskuryakov.
315 Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
316 printing didFailLoadWithError.
318 Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
319 DumpRenderTree, printing didFailLoadWithError.
321 * DumpRenderTree/gtk/DumpRenderTree.cpp:
322 (webFrameLoadStatusNotified):
324 2013-08-19 Ryosuke Niwa <rniwa@webkit.org>
326 <https://webkit.org/b/120049> Delete code for Snow Leopard
328 Reviewed by Benjamin Poulain.
330 * DumpRenderTree/mac/CheckedMalloc.cpp:
331 (protectionOfRegion):
332 (makeLargeMallocFailSilently):
333 * DumpRenderTree/mac/DumpRenderTree.mm:
334 (resetDefaultsToConsistentValues):
335 * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
336 (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
337 * DumpRenderTree/mac/FrameLoadDelegate.mm:
339 (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
340 * DumpRenderTree/mac/LayoutTestHelper.m:
341 * DumpRenderTree/mac/TestRunnerMac.mm:
342 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
343 (WTR::InjectedBundle::platformInitialize):
344 * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
345 (WTR::testPathFromURL):
346 (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
348 2013-08-19 Alexey Proskuryakov <ap@apple.com>
350 https://bugs.webkit.org/show_bug.cgi?id=119915
351 REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
353 Reviewed by Darin Adler.
355 The issue was that we ended up having no CFNetwork cache in the testing session due
356 to an incorrect cache model. There is a number of things not implemented when it
357 comes to dynamically changing cache model as attempted by WebKitTestRunner, but
358 the easiest way to get this going is to initialize it to correct value upfront.
360 * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
362 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
364 REGRESSION(r154275): webkitpy tests failing
365 https://bugs.webkit.org/show_bug.cgi?id=120010
367 Reviewed by Jocelyn Turcotte.
369 Update unit-tests to tests the new search-path structure,
370 but reverting the architecture search path addition.
372 * Scripts/webkitpy/port/qt.py:
375 (QtPort._generate_all_test_configurations):
376 (QtPort.qt_architecture):
377 * Scripts/webkitpy/port/qt_unittest.py:
379 (QtPortTest._assert_search_path):
380 (QtPortTest._assert_expectations_files):
381 (QtPortTest._qt_version):
383 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
385 [Qt] Keep the qt-5.0-wk2 search path until the expectation migration is completed
387 Unreviewed meta gardening.
389 We need to keep using the qt-5.0-wk2 path until it is fully migrated.
391 * Scripts/webkitpy/port/qt.py:
392 (QtPort._search_paths):
394 2013-08-19 Allan Sandfeld Jensen <allan.jensen@digia.com>
396 Restructure Qt test expectations
398 Unreviewed meta gardening.
400 Removed 5.0 name from WK1 and WK2 results and made it possible to set
401 expectations by both Qt version and mayor architectures.
403 * Scripts/webkitpy/port/qt.py:
404 (QtPort._wk2_port_name):
407 (QtPort.architecture):
408 (QtPort._search_paths):
409 (QtPort._port_specific_expectations_files):
411 2013-08-16 Brent Fulgham <bfulgham@apple.com>
413 [Windows] DRT is not using the same preferences as the Mac build.
414 https://bugs.webkit.org/show_bug.cgi?id=119822
416 Reviewed by Darin Adler.
418 * DumpRenderTree/win/DumpRenderTree.cpp:
419 (runTest): Process Windows message queue using CFRunLoop to allow
420 dispatch routines to run properly.
421 (dllLauncherEntryPoint): Wrap CG-specific setup code in a macro
422 to prevent problems on WinCairo port.
424 2013-08-16 Brent Fulgham <bfulgham@apple.com>
426 [Windows] URL printing code in DRT doesn't match WTR or Mac DRT
427 https://bugs.webkit.org/show_bug.cgi?id=119583
429 Reviewed by Alexey Proskuryakov.
431 * DumpRenderTree/win/DumpRenderTree.cpp:
432 (urlSuitableForTestResult): Revise URL output to match Mac DRT by emiting last path
433 component if the URL does not contain the expected base URL.
435 2013-08-16 Pratik Solanki <psolanki@apple.com>
437 <https://webkit.org/b/119852> Frame::scriptController() should return a reference
439 Reviewed by Andreas Kling.
441 m_script is never NULL so we can just return a reference. Also remove some pointless null
442 checks as a result of doing this.
444 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
445 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
447 2013-08-15 Alexey Proskuryakov <ap@apple.com>
449 [WK2] NetworkProcess should use a temporary storage session for test
450 https://bugs.webkit.org/show_bug.cgi?id=119855
452 Reviewed by Darin Adler.
454 Use a new API that takes care of both WebProcess and NetworkProcess.
456 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
457 (WTR::InjectedBundle::initialize):
458 * WebKitTestRunner/TestController.cpp:
459 (WTR::TestController::initialize):
461 2013-08-15 Bem Jones-Bey <bjonesbe@adobe.com>
463 <https://webkit.org/b/119850> Speed up test importing by doing all the regex matching in a single pass
465 Reviewed by Dirk Pranke.
467 This is a port from Blink of
468 https://src.chromium.org/viewvc/blink?revision=155647&view=revision
469 originally by Dirk Pranke.
471 From the original commit:
473 This gives something like a 15x speedup over compiling and matching
474 one property at a time and doing multiple passes over the file.
476 * Scripts/webkitpy/w3c/test_converter.py:
477 (W3CTestConverter.__init__):
478 (W3CTestConverter.convert_prefixed_properties):
479 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
481 2013-08-15 Dan Bernstein <mitz@apple.com>
483 <https://webkit.org/b/119856> Improve extract-localizable-strings messages
485 Reviewed by Darin Adler.
487 * Scripts/extract-localizable-strings: When the strings file disagrees with the source code,
488 added a message that points to the source code. Removed some unnecessary repetition of what
489 is already in the file.
491 2013-08-15 Andy Estes <aestes@apple.com>
493 <https://webkit.org/b/119853> REGRESSION (r139343): WebKit crashes when canceling a load inside webView:resource:didFinishLoadingFromDataSource:
495 Reviewed by Brady Eidson.
497 Wrote an API test that verifies -[WebView stopLoading:] can be called
498 inside webView:resource:didFinishLoadingFromDataSource: without crashing.
500 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
501 * TestWebKitAPI/Tests/mac/StopLoadingFromDidFinishLoading.mm: Added.
502 (-[StopLoadingFromDidFinishLoadingDelegate webView:resource:didFinishLoadingFromDataSource:]):
503 (TestWebKitAPI::TEST):
505 2013-08-15 Alexey Proskuryakov <ap@apple.com>
507 Adding Myles Maxfield to contributors.json.
509 Oops, wrong section, fixing.
511 * Scripts/webkitpy/common/config/contributors.json:
513 2013-08-15 Alexey Proskuryakov <ap@apple.com>
515 Adding Myles Maxfield to contributors.json.
517 * Scripts/webkitpy/common/config/contributors.json:
519 2013-08-15 Allan Sandfeld Jensen <allan.jensen@digia.com>
521 [Qt] Do not check specifically for version 5.0
522 https://bugs.webkit.org/show_bug.cgi?id=119846
524 Reviewed by Jocelyn Turcotte.
526 For Qt 5.x we should always use both wk1 and wk2 basepath results.
528 * Scripts/webkitpy/port/qt.py:
529 (QtPort._search_paths):
531 2013-08-15 Simon Pena <simon.pena@samsung.com>
533 <https://webkit.org/b/119584> [Gtk] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
535 Reviewed by Gustavo Noronha Silva.
537 Following a similar approach as in r153977, return a path string
538 that is relative to main frame URL or just file name if the
539 resource is not in the same directory subtree, and replace empty
540 strings with "(null)".
542 Update pathFromSoupURI so it behaves more closely to the other
543 ports, and remove the unused code after we no longer print
544 <unknown> in certain cases. Also move
545 soupURIToStringPreservingPassword to DumpRenderTreeGtk so it can
546 be used both in TestRunnerGtk and in DumpRenderTree.
548 * DumpRenderTree/gtk/DumpRenderTree.cpp:
549 (soupURIToStringPreservingPassword): Moved from TestRunnerGtk so
550 we can print Soup URIs with the password, since soup_uri_to_string
551 doesn't preserve them.
552 (pathFromSoupURI): Updated following EFL implementation in
553 r153977, and return a WTFString instead of a CString.
554 (convertSoupMessageToURLPath): Return "(null)" instead of empty
555 strings, and handle the new return type of pathFromSoupURI.
556 (convertWebResourceToURLPath): Use a GOwnPtr to hold the Soup URI
557 reference, and handle the new return type of pathFromSoupURI.
558 (descriptionSuitableForTestResult): Remove unused code.
559 (didFinishLoading): Use convertResourceToURLPath.
560 (didFailLoadingWithError): Use convertResourceToURLPath.
561 (authenticationCallback): Display the URL of the authentication
563 * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Declare
564 soupURIToStringPreservingPassword.
565 * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove
566 soupURIToStringPreservingPassword.
568 2013-08-14 Tim Horton <timothy_horton@apple.com>
570 Un-inline dataLog dumpers for IntSize and IntPoint
571 https://bugs.webkit.org/show_bug.cgi?id=119697
573 Reviewed by Sam Weinig.
575 * TestWebKitAPI/GNUmakefile.am:
577 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
579 Flakiness dashboard build fix.
581 * TestResultServer/static-dashboards/flakiness_dashboard.js:
582 (processTestRunsForBuilder):
584 2013-08-14 Martin Robinson <mrobinson@igalia.com>
586 [GTK] [CMake] Add support for building TestWebKitAPI
587 https://bugs.webkit.org/show_bug.cgi?id=116987
589 Reviewed by Philippe Normand.
591 * TestWebKitAPI/CMakeLists.txt: Move the library listings to before the inclusion of the
592 platform-specific file, so that GTK+ can override them.
593 * TestWebKitAPI/PlatformGTK.cmake: Added.
595 2013-08-14 Brent Fulgham <bfulgham@apple.com>
597 [Windows] Simplify Setting WebKit Debugging Options in WinLauncher
598 https://bugs.webkit.org/show_bug.cgi?id=119775
600 This bug updates the WinLauncher program with a few useful menu
601 options to toggle certain debugging and development features of
604 Reviewed by Tim Horton.
606 * WinLauncher/WinLauncher.cpp:
607 (dllLauncherEntryPoint): Clean up preference objects on exit.
608 (ToggleMenuItem): New function.
609 (LaunchInspector): New function.
610 (WndProc): Add handler for new menu items. Also properly terminate
611 CFRunLoop operation on program exit.
612 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new
614 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Add
615 resource folder to search path.
616 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Update
619 2013-08-14 Ryosuke Niwa <rniwa@webkit.org>
621 Add a hyperlink from build.webkit.org to the flakiness dashboard.
623 Rubbers-tamped by Simon Fraser.
625 * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
627 2013-08-14 Benjamin Dupont <bdupont@nds.com>
629 [Qt] Activate visibility API layout tests
630 https://bugs.webkit.org/show_bug.cgi?id=119790
632 Reviewed by Allan Sandfeld Jensen.
634 * DumpRenderTree/qt/TestRunnerQt.cpp:
635 (TestRunner::resetPageVisibility):
636 (TestRunner::setPageVisibility):
638 2013-08-13 Xabier Rodriguez Calvar <calvaris@igalia.com>
640 [GTK] WK does not link properly against libxslt
641 https://bugs.webkit.org/show_bug.cgi?id=119688
643 Reviewed by Gustavo Noronha Silva.
645 * MiniBrowser/gtk/GNUmakefile.am: Added LIBXSLT_LIBS to
647 * WebKitTestRunner/GNUmakefile.am: Added LIBXSLT_LIBS to WTR.
649 2013-08-13 Alexey Proskuryakov <ap@apple.com>
651 [Mac] fast/dom/attr-style-too-lazy.html is flaky
652 https://bugs.webkit.org/show_bug.cgi?id=119763
654 Reviewed by Darin Adler.
656 * DumpRenderTree/mac/UIDelegate.mm:
657 (-[UIDelegate webView:setStatusText:]): Don't dump anything when not running
658 a test, it would just semi-randomly leak to the next one.
659 (-[UIDelegate webView:didPressMissingPluginButton:]): Added same check here, just
662 2013-08-13 Tim Horton <timothy_horton@apple.com>
664 [mac] Give MiniBrowser a reasonable bundle identifier
665 https://bugs.webkit.org/show_bug.cgi?id=119773
667 Rubber-stamped by Simon Fraser.
669 Give MiniBrowser the bundle identifier org.webkit.MiniBrowser.
671 * MiniBrowser/mac/Info.plist:
672 * MiniBrowser/mac/WebBundle/Info.plist:
674 2013-08-13 Dean Jackson <dino@apple.com>
676 <https://webkit.org/b/119766> Make bug url more human friendly in ChangeLog
678 Reviewed by Mark Rowe.
680 Have prepare-ChangeLog produce webkit.org/b/id style
681 URLs rather than exposing the inner workings of our
682 cgi. I was going to use the term "Future Proofing"
683 but that seems excessive :)
685 * Scripts/prepare-ChangeLog:
686 (main): Generate a more human readable form.
687 (generateNewChangeLogs): Use it when printing out the ChangeLog entry.
689 2013-08-13 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
691 [EFL][DRT] Simplify call to reverseFind()
692 https://bugs.webkit.org/show_bug.cgi?id=119746
694 Reviewed by Christophe Dumez.
696 Follow-up to r153977.
698 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
699 (pathSuitableForTestResult): Instead of defining a static variable
700 that's only used in a single place, pass '/' to reverseFind() directly.
702 2013-08-13 Alberto Garcia <berto@igalia.com>
704 [GTK] Closing inspector window crashes wk
705 https://bugs.webkit.org/show_bug.cgi?id=110865
707 Reviewed by Carlos Garcia Campos.
709 Disconnect all signal handlers if the inspector window is
712 * GtkLauncher/LauncherInspectorWindow.c:
713 (inspectorWindowDestroyed):
714 (launcherInspectorWindowNew):
716 2013-08-12 Dan Bernstein <mitz@apple.com>
718 extract-localizable-strings output is not suited for parsing by Xcode
719 https://bugs.webkit.org/show_bug.cgi?id=119728
721 Reviewed by Darin Adler.
723 Added spaces where needed after “path:line:” to allow Xcode to recognize the file reference,
724 removed “ERROR” since messages that refer to a line in a file are shown as error by default,
725 added “warning: ” in messages that aren’t errors (i.e. don’t prevent the script from exiting
728 * Scripts/extract-localizable-strings:
730 2013-08-12 Ryuan Choi <ryuan.choi@samsung.com>
732 [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT
733 https://bugs.webkit.org/show_bug.cgi?id=119585
735 Reviewed by Gyuyoung Kim.
737 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
738 (pathSuitableForTestResult):
739 Return path string that's relative to main frame URL, or just file name if
740 the resource is not in the same directory subtree.
741 Referenced WebKitTestRunner code in r153852.
742 (descriptionSuitableForTestResult):
743 (DumpRenderTreeChrome::onFrameRedirectRequested):
744 (DumpRenderTreeChrome::onNewResourceRequest): Followed changes of r153903.
746 2013-08-12 Dan Bernstein <mitz@apple.com>
748 extract-localizable-strings doesn't know how to verify an existing strings file
749 https://bugs.webkit.org/show_bug.cgi?id=119704
751 Reviewed by Darin Adler.
753 * Scripts/extract-localizable-strings: Added an --exceptions option for specifying the
754 exceptions file, changing the way “no exceptions file” is expressed from passing “-” as the
755 exceptions file name to omitting the --exceptions option. Added a --skip option, changing
756 the way directories to skip are specified from prefixing the directory with a “-” to
757 specifying it with --skip.
758 Finally, added a --verify option. When specified, the strings file is not written to, but
759 instead read in and checked for consistency with the comments, keys and values derived from
760 the source files and the exceptions file. Missing keys, unused keys, mismatching values and
761 mismatching comments are reported as errors.
762 * Scripts/update-webkit-localizable-strings: Updated for the new way of specifying
763 directories to skip and no exceptions file.
765 2013-08-12 Alexey Proskuryakov <ap@apple.com>
767 http/tests/security/sandboxed-iframe-invalid.html is flaky on Mac
768 https://bugs.webkit.org/show_bug.cgi?id=85522
770 Reviewed by Andy Estes.
772 * DumpRenderTree/mac/UIDelegate.mm:
773 (-[UIDelegate webView:addMessageToConsole:withSource:]): Don't print console messages
774 when already done with a test. We already had this check in all UI delegate functions,
775 except for -webView:addMessageToConsole:withSource: somehow.
777 2013-08-12 Alexey Proskuryakov <ap@apple.com>
779 https://bugs.webkit.org/show_bug.cgi?id=119693
780 [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
781 because of connect-src-websocket-allowed.html
783 Reviewed by Darin Adler.
785 Starting a load of about:blank and immediately stopping it cancels outstanding
786 resource loads, but the page has to transition to committed state to have timers
787 or WebSockets stopped too.
789 * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
790 ensure that transition to committed state happens before we start the next test.
792 2013-08-12 Beth Dakin <bdakin@apple.com>
794 The LayoutMilestones didLayout callback should only fire for the main frame
795 https://bugs.webkit.org/show_bug.cgi?id=119457
797 Reviewed by Sam Weinig.
799 Now that the didLayout callback only fires for the main frame, we want to make
800 sure it will fire even when all of the content is in a subframe.
802 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
803 * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
804 (TestWebKitAPI::didLayout):
805 (TestWebKitAPI::TEST):
806 * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
808 2013-08-12 Beth Dakin <bdakin@apple.com>
810 Remove didNewFirstVisuallyNonEmptyLayout from WebKit2
811 https://bugs.webkit.org/show_bug.cgi?id=119658
813 Reviewed by Darin Adler.
815 * MiniBrowser/mac/WK2BrowserWindowController.m:
816 (-[WK2BrowserWindowController awakeFromNib]):
817 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
818 (WTR::InjectedBundlePage::InjectedBundlePage):
819 * WebKitTestRunner/TestController.cpp:
820 (WTR::TestController::createWebViewWithOptions):
822 2013-08-12 Seokju Kwon <seokju@webkit.org>
824 Remove glu's libtest rule from checker.py
825 https://bugs.webkit.org/show_bug.cgi?id=119674
827 Reviewed by Darin Adler.
829 * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
831 2013-08-11 ChangSeok Oh <changseok.oh@collabora.com>
833 Unreviewed. Change my primary mail address.
835 * Scripts/webkitpy/common/config/contributors.json:
837 2013-08-09 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
839 [GTK] Misses mod_ssl and php in the list of packages required for tests for yum
840 https://bugs.webkit.org/show_bug.cgi?id=115751
842 Reviewed by Martin Robinson.
844 * gtk/install-dependencies: add mod_ssl and php to the packages installed for tests
847 2013-08-09 Beth Dakin <bdakin@apple.com>
849 AX: Not able to use arrow keys to read text in a WK2 app
850 https://bugs.webkit.org/show_bug.cgi?id=119605
852 <rdar://problem/14281275>
854 Reviewed by Darin Adler.
856 New test verifies that didNotHandleKeyEvent will be called when there is nothing
858 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
859 * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp: Added.
860 (TestWebKitAPI::didFinishLoadForFrame):
861 (TestWebKitAPI::didNotHandleKeyEventCallback):
862 (TestWebKitAPI::TEST):
864 2013-08-09 Christophe Dumez <ch.dumez@sisa.samsung.com>
866 Add support for KeyboardEvent.location attribute
867 https://bugs.webkit.org/show_bug.cgi?id=119326
869 Reviewed by Benjamin Poulain.
871 Rename the deprecated 'keyLocation' to 'location' in Mac's DRT code.
873 * DumpRenderTree/mac/EventSendingController.mm:
874 (-[EventSendingController keyDown:withModifiers:withLocation:]):
875 (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
876 (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
877 (-[EventSendingController handleEvent:]):
878 (-[EventSendingController fireKeyboardEventsToElement:]):
880 2013-08-09 Alexey Proskuryakov <ap@apple.com>
882 <unknown> is often dumped instead of path in test output
883 https://bugs.webkit.org/show_bug.cgi?id=119590
885 Reviewed by Anders Carlsson.
887 There were two reasons for <unknown>:
888 1. When delegate logging is enabled via a testRunner call, that obviously happens
889 after main resource load starts, so we don't record its URL.
890 2. Authentication delegate logging relied on URL recording, but it's only turned on
891 when enabling resource loading delegate logging, not auth one.
893 URL recording was made conditional in <http://trac.webkit.org/r19316>, which was
894 landed without posted rationale and unreviewed. Just undoing that change now.
896 * DumpRenderTree/mac/ResourceLoadDelegate.mm:
897 (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
898 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
899 (WTR::InjectedBundlePage::didInitiateLoadForResource):
901 2013-08-08 Alex Christensen <achristensen@apple.com>
905 Rubberstamped by Brent Fulgham.
907 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
908 Removed /SAFESEH link option which doesn't work with x64.
910 2013-08-08 Daniel Bates <dabates@apple.com>
912 Add iOS support to run-javascriptcore-tests
913 https://bugs.webkit.org/show_bug.cgi?id=119602
915 Reviewed by Joseph Pecoraro.
917 Make run-javascriptcore-tests work for iOS WebKit.
919 * Scripts/run-javascriptcore-tests:
921 2013-08-08 Alexey Proskuryakov <ap@apple.com>
923 [WK2] loader/go-back-cached-main-resource.html fails
924 https://bugs.webkit.org/show_bug.cgi?id=116491
926 Reviewed by Tim Horton.
928 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
929 * DumpRenderTree/gtk/DumpRenderTree.cpp:
930 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
931 * DumpRenderTree/win/DumpRenderTree.cpp:
932 Added FIXMEs about making path printing normalization more compatible.
934 * DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[NSURL _drt_descriptionSuitableForTestResult]):
935 Return last path component in cases where we used to return a full path, which is
936 never desirable. Added a null check to basePath to prevent potentially getting
937 an Objective C exception.
939 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
940 (WTR::pathSuitableForTestResult): Changed to use path for main test window, not
941 for a currently loading one (which is different for tests that use multiple windows).
942 Changed to return "(null)" for empty URLs to match WK1 output. Changed to return
943 last path component as last fallback.
944 (WTR::dumpRequestDescriptionSuitableForTestResult): We no longer need to pass main
945 frame URL here, and it was potentially a wrong frame.
946 (WTR::dumpResponseDescriptionSuitableForTestResult): Ditto.
947 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Ditto.
948 (WTR::InjectedBundlePage::didInitiateLoadForResource): Ditto.
949 (WTR::InjectedBundlePage::willSendRequestForFrame): Ditto.
950 (WTR::InjectedBundlePage::didReceiveResponseForResource): Ditto.
952 2013-08-08 Alex Christensen <achristensen@apple.com>
954 WTR::pathSuitableForTestResult should behave the same as _drt_descriptionSuitableForTestResult so we can unskip tests.
955 https://bugs.webkit.org/show_bug.cgi?id=116125
957 Reviewed by Tim Horton. Tweaked and re-landed by Alexey Proskuryakov.
959 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
960 (WTR::pathSuitableForTestResult):
961 Changed string operations to match _drt_descriptionSuitableForTestResult.
962 (WTR::dumpRequestDescriptionSuitableForTestResult):
963 (WTR::dumpResponseDescriptionSuitableForTestResult):
964 (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
965 (WTR::InjectedBundlePage::didInitiateLoadForResource):
966 (WTR::InjectedBundlePage::willSendRequestForFrame):
967 (WTR::InjectedBundlePage::didReceiveResponseForResource):
968 Pass the main frame's URL to pathSuitableForTestResult.
969 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
970 Added WKBundlePageRef to willPerformClientRedirectForFrame.
972 2013-08-07 Simon Fraser <simon.fraser@apple.com>
974 Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
975 https://bugs.webkit.org/show_bug.cgi?id=119317
977 Reviewed by Tim Horton.
979 The change in r55200 made DumpRenderTree spin a busy-loop while waiting for
980 the test to complete, which is not power friendly. Although DRT instances
981 are generally busy anyway, not sitting in a busy loop should free up some CPU
982 cycles for other instances of DRT.
984 Editing tests continue to pass. All Java tests are skipped and were not
985 tested, but when run fail similarly with and without the patch.
987 * DumpRenderTree/mac/DumpRenderTree.mm:
991 2013-08-07 Daniel Bates <dabates@apple.com>
993 Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl
994 <https://bugs.webkit.org/show_bug.cgi?id=119558>
996 Reviewed by Martin Robinson.
998 Currently we build the command line to execute jsDriver.pl twice so as to both
999 print it to standard output and actually execute it. We should only build up
1000 this command line once. Moreover, we should print to standard output the actual
1001 command line that we are going to use including the GTK- and EFL-specific call
1002 to /Tools/jhbuild/jhbuild-wrapper.
1004 * Scripts/run-javascriptcore-tests:
1006 2013-08-07 Mario Sanchez Prada <mario.prada@samsung.com>
1008 [EFL] REGRESSION after r153432: some accessibility tests crash.
1009 https://bugs.webkit.org/show_bug.cgi?id=119333
1011 Reviewed by Darin Adler.
1013 Use a RefPtr to store a reference to the parent element of
1014 an AccessibilityUIElement instead of the raw pointer, so we
1015 never derefence a function from an invalid pointer.
1017 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1018 (WTR::attributesOfElement): Use a RefPtr instead of a raw pointer.
1020 2013-08-07 Cosmin Truta <ctruta@blackberry.com>
1022 Unreviewed. Add myself as a committer.
1024 * Scripts/webkitpy/common/config/contributors.json:
1026 2013-08-04 Sam Weinig <sam@webkit.org>
1028 Remove support for HTML5 MicroData
1029 https://bugs.webkit.org/show_bug.cgi?id=119480
1031 Reviewed by Anders Carlsson.
1033 * Scripts/webkitperl/FeatureList.pm:
1034 * qmake/mkspecs/features/features.pri:
1036 2013-07-23 David Farler <dfarler@apple.com>
1038 Provide optional OTHER_CFLAGS, OTHER_CPPFLAGS, OTHER_LDFLAGS additions for building with ASAN
1039 https://bugs.webkit.org/show_bug.cgi?id=117762
1041 Reviewed by Mark Rowe.
1043 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1044 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1045 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1046 Add ASAN_OTHER_LDFLAGS.
1047 * MiniBrowser/Configurations/DebugRelease.xcconfig:
1048 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1049 * Scripts/check-for-weak-vtables-and-externals:
1050 Ignore ___asan externals, these are populated by compiler-rt.
1051 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1052 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1053 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1054 Add ASAN_OTHER_LDFLAGS.
1055 * WebKitLauncher/Configurations/Base.xcconfig:
1056 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1057 * WebKitLauncher/Configurations/WebKitNightlyEnabler.xcconfig:
1058 Add ASAN_OTHER_LDFLAGS.
1059 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1060 Add ASAN_OTHER_CFLAGS, CPLUSPLUSFLAGS, LDFLAGS.
1061 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1062 Add ASAN_OTHER_LDFLAGS.
1063 * asan/asan.xcconfig: Added.
1064 * asan/webkit-asan-ignore.txt: Added.
1066 2013-08-05 Brian Holt <brian.holt@samsung.com>
1068 [GTK] Implement leak checking with valgrind
1069 https://bugs.webkit.org/show_bug.cgi?id=118785
1071 Reviewed by Dirk Pranke.
1073 Launch the DRT under Valgrind to generate xml files with details
1076 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1078 * Scripts/webkitpy/port/gtk.py:
1080 (GtkPort.default_timeout_ms): Allow extra time to run under
1082 (GtkPort.setup_environ_for_server): Pass Valgrind instructions
1083 using environment variables.
1085 2013-08-02 Mario Sanchez Prada <mario.prada@samsung.com>
1087 [EFL] REGRESSION after r153432: some accessibility tests crash.
1088 https://bugs.webkit.org/show_bug.cgi?id=119333
1090 Reviewed by Gustavo Noronha Silva.
1092 Add missing null-check to avoid dereferencing a non-existent parent.
1094 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1095 (WTR::attributesOfElement): Ditto.
1097 2013-08-02 Patrick Gansterer <paroga@webkit.org>
1099 Add --rmdir option to git svn dcommit
1100 https://bugs.webkit.org/show_bug.cgi?id=119398
1102 Reviewed by Ryosuke Niwa.
1104 Add this option tells git-svn to remove empty directories
1105 from the svn tree so they do not leave over there.
1107 * Scripts/webkitpy/common/checkout/scm/git.py:
1108 (Git.push_local_commits_to_server):
1110 2013-08-01 Brent Fulgham <bfulgham@apple.com>
1112 [Windows] WebKit1 Fullscreen Video Play is Broken
1113 https://bugs.webkit.org/show_bug.cgi?id=119415
1115 Reviewed by Jer Noble.
1117 * WinLauncher/WinLauncher.cpp:
1118 (dllLauncherEntryPoint): Activate full screen mode via
1119 IWebPreferencesInternal interface.
1121 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
1123 Unreviewed. Add an alternative address to show my affiliation in team.html.
1125 * Scripts/webkitpy/common/config/contributors.json:
1127 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
1129 Duplicate property names can cause test to fail
1130 https://bugs.webkit.org/show_bug.cgi?id=119399
1132 Reviewed by Dirk Pranke.
1134 This problem was noticed when porting the patch for
1135 http://wkb.ug/119357 to Blink: a test would fail because the converted
1136 and test property lists weren't the same length, but they contained
1137 all of the same property names. It looks like this is actually caused
1138 by a bug in converting the HTML, which is being currently rewritten.
1139 In the meantime, as long as this compares the number of unique
1140 properties, it makes the test more robust.
1142 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1143 (verify_prefixed_properties):
1145 2013-08-01 Bem Jones-Bey <bjonesbe@adobe.com>
1147 Unreviewed. Adding my expertise.
1149 * Scripts/webkitpy/common/config/contributors.json:
1151 2013-08-01 ChangSeok Oh <changseok.oh@collabora.com>
1153 Unreviewed. Add myself as a committer. Yoo-hoo! \o/
1155 * Scripts/webkitpy/common/config/contributors.json:
1157 2013-08-01 Commit Queue <commit-queue@webkit.org>
1159 Unreviewed, rolling out r153518.
1160 http://trac.webkit.org/changeset/153518
1161 https://bugs.webkit.org/show_bug.cgi?id=119386
1163 The Jhbuild dep bump of GTK+ is not actually required by
1164 layout testing, is causing pango dep problems (Requested by
1165 zdobersek on #webkit).
1167 * gtk/jhbuild.modules:
1169 2013-08-01 Xabier Rodriguez Calvar <calvaris@igalia.com>
1171 Unreviewed. Add myself as a committer.
1173 * Scripts/webkitpy/common/config/contributors.json:
1175 2013-08-01 Jaehun Lim <ljaehun.lim@samsung.com>
1177 Unreviewed. Add myself as a committer.
1179 * Scripts/webkitpy/common/config/contributors.json:
1181 2013-07-31 Jinwoo Song <jinwoo7.song@samsung.com>
1183 Unreviewed. Add myself as a committer.
1185 * Scripts/webkitpy/common/config/contributors.json:
1187 2013-08-01 Alberto Garcia <berto@igalia.com>
1189 Unreviewed. Add myself as a committer.
1191 * Scripts/webkitpy/common/config/contributors.json:
1193 2013-07-31 Seokju Kwon <seokju@webkit.org>
1195 Unreviewed. Add myself as a committer.
1197 * Scripts/webkitpy/common/config/contributors.json:
1199 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1201 W3C test import script prefixes some properties that it shouldn't
1202 https://bugs.webkit.org/show_bug.cgi?id=119357
1204 Reviewed by Dirk Pranke.
1206 Some prefixed properties also have unprefixed implemetations, but when
1207 the implementations aren't identical, they aren't declared in
1208 CSSPropertyNames.in on the same line. This fixes the import script so
1209 that it catches all instances of prefixed properties that have an
1210 unprefixed variant, and does not add the prefix in those cases.
1212 * Scripts/webkitpy/w3c/test_converter.py:
1213 (W3CTestConverter.read_webkit_prefixed_css_property_list): Read all of
1214 the properties on every line and record if they are prefixed or not.
1215 Use this information to only return prefixed properties that do not
1216 have any unprefixed variant. The prefixed property list has also
1217 changed to not include the '-webkit-' prefix, making it much easier to
1218 do the comparison, and removing the need to remove the prefix later.
1219 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): This no
1220 longer needs to remove the '-webkit-' prefix, but needs to add it in
1221 the case where a property that needs a prefix is found.
1222 * Scripts/webkitpy/w3c/test_converter_unittest.py:
1223 (W3CTestConverterTest.test_read_prefixed_property_list): Remove assert
1224 for '-webkit-' prefix, as it is no longer included in the properties
1225 in the prefixed property list.
1227 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1229 Update location of w3c shapes tests to reflect new import location
1230 https://bugs.webkit.org/show_bug.cgi?id=118156
1232 Reviewed by Dirk Pranke.
1234 Partial imports should not be imported to the same place as the full
1235 import, so this adds an option to allow importing to a different
1236 location than the default. In doing that, I found that imports from
1237 contributor directories didn't seem to be working correctly, so I
1238 updated the import to be smarter about both contributor directories
1239 and the test status directories. It should now be more likely that the
1240 script guesses the root directory properly.
1242 * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
1243 script not working with the full set of contributors, as that is
1244 no longer true, and I didn't see a good way to keep that behavior.
1245 Also update documentation to properly explain what happens when a
1246 contributor dir is imported.
1247 (main): Attempt to find the proper repo dir by looking at the
1248 directory above the "test status" in the given path, this is still
1249 not exactly right, but is less error prone than just trimming.
1250 (parse_args): Add -d option to set the import directory.
1251 (TestImporter.__init__): Stop appending the subdirs to the
1252 destination_directory because it was making things more complex
1253 and isn't really needed.
1254 (TestImporter.update_test_status): Remove hardcoded strings and use
1255 the TEST_STATUS constants instead.
1256 * Scripts/webkitpy/w3c/test_importer_unittest.py:
1257 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
1258 support for new option.
1259 (TestImporterTest.test_import_dir_with_no_tests): Ditto.
1261 2013-07-31 Brent Fulgham <bfulgham@apple.com>
1263 [Windows] Winlauncher shouldn't look for Safari Install Directory
1264 https://bugs.webkit.org/show_bug.cgi?id=119351
1266 Reviewed by Darin Adler.
1268 * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
1269 the Safari install location. Instead, use the proper support
1270 library path for the build architecture.
1272 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1274 Update scripts to reference contributors.json instead of committers.py in messaging
1275 https://bugs.webkit.org/show_bug.cgi?id=119342
1277 Reviewed by Ryosuke Niwa.
1279 Change the scripts to point people to contributors.json instead of
1280 committers.py since the latter no longer contains the list of
1283 * Scripts/webkitpy/common/config/committervalidator.py:
1284 (CommitterValidator._contributors_json_path):
1285 (CommitterValidator._flag_permission_rejection_message):
1286 * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1287 (CommitterValidatorTest.test_flag_permission_rejection_message):
1288 * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1289 (Bugzilla._commit_queue_flag):
1290 * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1291 (WatchListParser._validate):
1292 * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1293 (WatchListParserTest.test_cc_rule_with_invalid_email):
1294 * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1295 * Scripts/webkitpy/tool/commands/queues_unittest.py:
1296 * Scripts/webkitpy/tool/steps/validatereviewer.py:
1297 (ValidateReviewer.run):
1299 2013-07-31 Roger Fong <roger_fong@apple.com>
1301 Unreviewed. Re-enable WinEWS tests following r153527.
1303 * Scripts/webkitpy/common/config/ews.json:
1305 2013-07-31 Bem Jones-Bey <bjonesbe@adobe.com>
1307 Unreviewed: Adding myself to the committers' list.
1309 * Scripts/webkitpy/common/config/contributors.json:
1311 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1313 [Qt] Build WebKit with C++11
1314 https://bugs.webkit.org/show_bug.cgi?id=119337
1316 Reviewed by Csaba Osztrogonác.
1318 Enable building with C++11.
1320 * qmake/mkspecs/features/default_pre.prf:
1321 * qmake/mkspecs/features/unix/default_post.prf:
1322 * qmake/mkspecs/features/unix/default_pre.prf:
1324 2013-07-31 Allan Sandfeld Jensen <allan.jensen@digia.com>
1326 [Qt] ASSERTS trigger in release builds
1327 https://bugs.webkit.org/show_bug.cgi?id=119336
1329 Reviewed by Jocelyn Turcotte.
1331 Ensure the qmake also defaults to release if no configuration is known.
1333 * qmake/mkspecs/features/default_post.prf:
1335 2013-07-31 Zan Dobersek <zdobersek@igalia.com>
1337 [texmap][GStreamer][GTK] composited video shows tearing
1338 https://bugs.webkit.org/show_bug.cgi?id=118253
1340 Reviewed by Martin Robinson.
1342 * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
1343 The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
1344 screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
1346 2013-07-30 Ruth Fong <ruth_fong@apple.com>
1348 Unreviewed: Adding myself to the committers' list.
1350 * Scripts/webkitpy/common/config/contributors.json:
1352 2013-07-30 Christophe Dumez <ch.dumez@sisa.samsung.com>
1354 Unreviewed, add my new email to contributors.json.
1356 * Scripts/webkitpy/common/config/contributors.json:
1358 2013-07-30 Krzysztof Czech <k.czech@samsung.com>
1360 [EFL] REGRESSION after r153439: layout tests do not run.
1361 https://bugs.webkit.org/show_bug.cgi?id=119240
1363 Reviewed by Christophe Dumez.
1365 Changed attribute name from check_xvfb to check_driver.
1367 * Scripts/webkitpy/port/efl.py:
1368 (EflPort.check_sys_deps):
1370 2013-07-29 Commit Queue <commit-queue@webkit.org>
1372 Unreviewed, rolling out r152860.
1373 http://trac.webkit.org/changeset/152860
1374 https://bugs.webkit.org/show_bug.cgi?id=119227
1376 Disable WinEWS tests until tests stop crashing (Requested by
1379 * Scripts/webkitpy/common/config/ews.json:
1381 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1383 [GTK] Add WestonDriver, use it when appropriate
1384 https://bugs.webkit.org/show_bug.cgi?id=119100
1386 Reviewed by Dirk Pranke.
1388 Introduce the WestonDriver, a Driver-implementing class that sets up an instance of Weston, the Wayland compositor,
1389 and sets up an environment that enables the test runner to run inside it.
1391 The design very much mimics the XvfbDriver class. It is currently used by the GTK port when the WAYLAND_DISPLAY
1392 environment variable is set, that is when NRWT is being run under a Wayland display.
1394 * Scripts/webkitpy/port/base.py:
1395 (Port.to.setup_environ_for_server): Also copy the XDG_RUNTIME_DIR env from the original environment for Linux-using ports.
1396 * Scripts/webkitpy/port/gtk.py:
1398 (GtkPort._driver_class): Make the method memoized - the display type is not going to change during the testing, so we
1399 should only check once for the presence of the WAYLAND_DISPLAY env and determine the proper driver class to use based on that.
1400 (GtkPort.check_sys_deps): Call the static check_driver method on the class as returned by the _driver_class method
1401 instead of hard-coding the XvfbDriver class in the check.
1402 * Scripts/webkitpy/port/westondriver.py: Added.
1404 (WestonDriver.check_driver): Similarly to XvfbDriver, this checks for existance of the weston executable.
1405 (WestonDriver.__init__): Again, like in XvfbDriver, we use a small delay between launching the Weston display and launching the driver.
1406 (WestonDriver._start): Sets up the driver-specific temporary directory, launches the Weston display, sets up the environment for the
1407 driver and then launches the driver in said environment, using the driver's Weston display.
1408 (WestonDriver.stop): Cleans up the Weston instance and the temporary directory.
1409 (WestonDriver._ensure_driver_tmpdir_subdirectory): A helper function that creates a subdirectory in the driver's temporary directory
1410 and returns the absolute path to it.
1411 * Scripts/webkitpy/port/xvfbdriver.py:
1412 (XvfbDriver.check_driver): Renamed from check_xvfb.
1413 (XvfbDriver._start): Access the FileSystem object through the Port's Host object, instead of the Port's private member.
1415 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1417 [ATK] Implement attributesOfChildren() for AccessibilityUIElement
1418 https://bugs.webkit.org/show_bug.cgi?id=118967
1420 Reviewed by Gustavo Noronha Silva.
1422 Implemented AccessibilityUIElement::attributesOfChildren() both
1423 in DumpRenderTree and the WebKitTestRunner.
1425 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1426 (AccessibilityUIElement::attributesOfChildren): Implemented.
1428 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1429 (WTR::AccessibilityUIElement::attributesOfChildren): Implemented.
1431 2013-07-29 Mario Sanchez Prada <mario.prada@samsung.com>
1433 [ATK] Implement allAttributes() for AccessibilityUIElement
1434 https://bugs.webkit.org/show_bug.cgi?id=118966
1436 Reviewed by Gustavo Noronha Silva.
1438 Implemented AccessibilityUIElement::allAttributes() both in
1439 DumpRenderTree and the WebKitTestRunner.
1441 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1442 (getAtkAttributeSetAsString): Moved up in the file, and refactored
1443 to use StringBuilder and return a String instead of a gchar*.
1444 (roleToString): Changed not to return the "AXRole: " prefix, so
1445 we can use it as well from attributesOfElement().
1446 (attributesOfElement): New function to dump attributes for an object.
1447 (AccessibilityUIElement::allAttributes): Call attributesOfElement().
1448 (AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1450 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1451 (getAtkAttributeSetAsString): Refactored to use StringBuilder and return
1452 a String instead of a gchar*.
1454 (WTF::roleToString): Changed not to return the "AXRole: " prefix,
1455 so we can use it as well from attributesOfElement().
1456 (WTF::attributesOfElement): New function to dump attributes for an object.
1457 (WTR::AccessibilityUIElement::allAttributes): Call attributesOfElement().
1458 (WTR::AccessibilityUIElement::role): Updated to prefix "AXRole: ".
1460 2013-07-29 Daniel Bates <dabates@apple.com>
1462 Add support infrastructure for iOS WebKit port
1463 https://bugs.webkit.org/show_bug.cgi?id=119168
1465 Reviewed by Ryosuke Niwa.
1467 Implement support infrastructure towards building iOS WebKit.
1469 * Scripts/webkitdirs.pm:
1470 (xcodeSDKPlatformName): Added.
1471 (determineConfigurationProductDir):
1472 (builtDylibPathForName):
1473 (willUseIOSDeviceSDKWhenBuilding): Added.
1474 (willUseIOSSimulatorSDKWhenBuilding): Added.
1475 (isIOSWebKit): Added.
1476 (copyInspectorFrontendFiles):
1478 2013-07-29 Sergio Correia <sergio.correia@openbossa.org>
1480 CoordinatedGraphics: Add API to get and set the active state of a WebView
1481 https://bugs.webkit.org/show_bug.cgi?id=119067
1483 Reviewed by Noam Rosenthal.
1485 Added API tests for WKViewIsActive and WKViewSetIsActive.
1487 * TestWebKitAPI/PlatformEfl.cmake:
1488 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp: Added.
1489 (TestWebKitAPI::didFinishLoadForFrame):
1490 (TestWebKitAPI::webProcessCrashed):
1491 (TestWebKitAPI::webProcessRelaunched):
1492 (TestWebKitAPI::TEST):
1493 * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive_Bundle.cpp:
1494 Bundle added to allow crashing the WebProcess and testing the active state of a view
1495 under such condition.
1496 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::WKViewIsActiveSetIsActiveTest):
1497 (TestWebKitAPI::WKViewIsActiveSetIsActiveTest::didReceiveMessage):
1499 2013-07-29 Zan Dobersek <zdobersek@igalia.com>
1501 [Automake] Remove references to non-existent *_CFLAGS and *_LIBS variables
1502 https://bugs.webkit.org/show_bug.cgi?id=119212
1504 Reviewed by Carlos Garcia Campos.
1506 * GNUmakefile.am: Remove references to GLOBALDEPS_(CFLAGS|LIBS) and CLUTTER_(CFLAGS|LIBS)
1507 variables that are not defined during the configuration process.
1508 * TestWebKitAPI/GNUmakefile.am: Ditto.
1509 * WebKitTestRunner/GNUmakefile.am: Ditto.
1511 2013-07-28 Andy Estes <aestes@apple.com>
1513 Include <stdio.h> to declare perror()
1514 https://bugs.webkit.org/show_bug.cgi?id=119198
1516 Reviewed by Andreas Kling.
1518 Silences an implicit declaration warning.
1520 * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c:
1522 2013-07-27 Ryuan Choi <ryuan.choi@samsung.com>
1524 [EFL] Bump required version of EFL to 1.7
1525 https://bugs.webkit.org/show_bug.cgi?id=119144
1527 Reviewed by Christophe Dumez.
1529 * MiniBrowser/efl/CMakeLists.txt: Bumped EFL to 1.7
1531 2013-07-26 Filip Pizlo <fpizlo@apple.com>
1533 WKTR should know about the JSC extensions to testRunner
1534 https://bugs.webkit.org/show_bug.cgi?id=119154
1536 Reviewed by Mark Hahnenberg and Geoffrey Garen.
1538 This makes some fast/js tests pass.
1540 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1541 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1542 (WTR::TestRunner::numberOfDFGCompiles):
1543 (WTR::TestRunner::neverInlineFunction):
1544 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1546 2013-07-25 Mark Rowe <mrowe@apple.com>
1548 Fix build of DumpRenderTree and WebKitTestRunner when building against an SDK.
1550 * DumpRenderTree/mac/Configurations/Base.xcconfig: Fix framework search path when building against an SDK.
1551 * WebKitTestRunner/Configurations/Base.xcconfig: Ditto. Also fix where our scripts look for WebCore.framework
1552 so they pull the version out of the SDK.
1554 2013-07-25 Anders Carlsson <andersca@apple.com>
1556 Localizable.strings generated by extract-localizable-strings should be UTF-8
1557 https://bugs.webkit.org/show_bug.cgi?id=119106
1559 Reviewed by Mark Rowe.
1561 Output strings as UTF-8.
1563 * Scripts/extract-localizable-strings:
1565 2013-07-25 Sam Weinig <sam@webkit.org>
1567 -[WebHTMLView attributedSubstringForProposedRange:actualRange:] does not include strikethrough attribute in the returned attributed string
1568 https://bugs.webkit.org/show_bug.cgi?id=119099
1569 <rdar://problem/13439291>
1571 Reviewed by Enrica Casucci.
1573 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1574 * TestWebKitAPI/Tests/mac/AttributedString.mm:
1575 (TestWebKitAPI::attributedString):
1576 (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
1577 (TestWebKitAPI::AttributedStringTest_CustomFont::url):
1578 (TestWebKitAPI::AttributedStringTest_CustomFont::runTest):
1579 (TestWebKitAPI::TEST_F):
1580 (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
1581 (TestWebKitAPI::AttributedStringTest_Strikethrough::url):
1582 (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest):
1583 * TestWebKitAPI/Tests/mac/attributedStringStrikethrough.html: Added.
1584 Add tests for attributed strings with strikethrough. Refactor the attributed string tests
1585 to make adding more easier in the future.
1587 2013-07-20 Filip Pizlo <fpizlo@apple.com>
1589 fourthTier: FTL should be able to generate LLVM IR that uses an intrinsic for OSR exit
1590 https://bugs.webkit.org/show_bug.cgi?id=118948
1592 Reviewed by Sam Weinig.
1594 - Make ReducedFTL capable of dealing with code that uses the fake OSR exit intrinsic,
1595 by exporting it as a function.
1597 - Make combineModules.rb idempotent. Sometimes it's convenient to run a file through
1598 it even if you know that you've already done so. See processIRDump.sh.
1600 - Add a script, processIRDump.sh, that takes the output of --dumpLLVMIR=true and
1601 runs it through ReducedFTL automatically. You typically want to say something like:
1603 jsc --dumpLLVMIR=true <program(s)> > jsc-output.txt
1604 ./processIRDump.sh --timing < jsc-output.txt
1606 * ReducedFTL/ReducedFTL.c:
1608 * ReducedFTL/combineModules.rb:
1609 * ReducedFTL/processIRDump.sh: Added.
1611 2013-07-20 Filip Pizlo <fpizlo@apple.com>
1613 fourthTier: We should use the no-asserts build of LLVM if that's what the user configured
1614 https://bugs.webkit.org/show_bug.cgi?id=118947
1616 Reviewed by Dan Bernstein.
1618 * Scripts/copy-webkitlibraries-to-product-directory:
1620 2013-07-16 Filip Pizlo <fpizlo@apple.com>
1622 fourthTier: We should have a reduced FTL LLVM pipeline tool in the repository
1623 https://bugs.webkit.org/show_bug.cgi?id=118647
1625 Rubber stamped by Geoffrey Garen and Mark Hahnenberg.
1627 Add a tool that takes in an LLVM bitcode file and JITs it in exactly the same
1628 way that the FTL would.
1630 Also add a tool that combines multiple LLVM modules generated by FTL into a
1633 * ReducedFTL: Added.
1634 * ReducedFTL/ReducedFTL.c: Added.
1638 (mmAllocateCodeSection):
1639 (mmAllocateDataSection):
1640 (mmApplyPermissions):
1642 (symbolLookupCallback):
1644 * ReducedFTL/build.sh: Added.
1645 * ReducedFTL/combineModules.rb: Added.
1647 2013-06-09 Filip Pizlo <fpizlo@apple.com>
1649 Unreviewed, fix minor goof in profiling output layout. We weren't accounting
1650 for the "/" that is printed between engine counts.
1652 * Scripts/display-profiler-output:
1654 2013-05-28 Filip Pizlo <fpizlo@apple.com>
1656 testRunner should have a way of disabling inlining of functions
1657 https://bugs.webkit.org/show_bug.cgi?id=116875
1659 Reviewed by Mark Hahnenberg.
1661 * DumpRenderTree/TestRunner.cpp:
1662 (neverInlineFunction):
1663 (TestRunner::staticFunctions):
1665 2013-05-27 Filip Pizlo <fpizlo@apple.com>
1667 testRunner should be able to tell you if a function is DFG compiled
1668 https://bugs.webkit.org/show_bug.cgi?id=116847
1670 Reviewed by Mark Hahnenberg.
1672 * DumpRenderTree/TestRunner.cpp:
1673 (numberOfDFGCompiles):
1674 (TestRunner::staticFunctions):
1676 2013-05-21 Filip Pizlo <fpizlo@apple.com>
1678 fourthTier: display-profiler-output should make it even easier to diff the compilation story between two different runs
1679 https://bugs.webkit.org/show_bug.cgi?id=116556
1681 Reviewed by Oliver Hunt.
1683 This adds three new capabilities:
1685 - 'display' now accepts negative compilation indices, and allows specifying
1686 wildcard hashes combined with combination indices. Previously you could say
1687 'display <hash>', 'display <hash>-<index>-<engine>', or 'display *'. The
1688 latter would display every compilation. This improves this so that you can
1689 say 'display *-<index>-<engine>'. It also makes it so that you can give a
1690 negative index, which allows you to say things like 'display blah--1-dfg',
1691 which displays just the last DFG compilation. Also you can say
1692 'display *--1-dfg', which displays the last DFG compilation for each code
1693 block. I realize that this is kind of ugly, but gosh is it practical.
1695 - You can now say 'sort hash', which will henceforth sort all of the output
1696 by code hash rather than by the time when it was compiled. This means that
1697 if you're doing 'dispay *--1-dfg' and then want to diff the results against
1698 something else, you can ensure that this doesn't get confused just by
1699 changes in compilation order.
1701 - You can now say 'counts off', which will henceforth disable the display of
1702 execution counts from 'bytecode' and 'display'. This is also useful for
1703 diffs, since if you're trying to figure out why two compilations are
1704 different, they probably have radically different counts. 'counts off' gets
1705 this out of the output so that it doesn't confuse your diff.
1707 Note that to use this effectively you should also have a script that scrubs
1708 pointers from text so that the diff doesn't get confused by pointers. I'll
1709 post my elimptr script to the bug. Maybe at some point I'll integrate that
1710 into display-profiler-output.
1712 Put together this is pretty awesome. I was able to do the following:
1714 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-serial.profile | elimptr > richards-serial.asm
1715 (echo "counts off" && echo "sort hash" && echo "d *--1-dfg") | Tools/Scripts/display-profiler-output richards-concurrent.profile | elimptr > richards-concurrent.asm
1716 diff -u richards-serial.asm richards-concurrent.asm
1718 And this immediately told me that the reason why richards is slower in the
1719 concurrent compilation case is just that we end up compiling *tons* more
1720 functions, most of which are trivially inlineable. Basically, concurrent
1721 compilation breaks our previous heuristics for delaying compilation of
1722 inlineables just enough that they never trigger compilation. We should fix
1723 that in a separate bug.
1725 * Scripts/display-profiler-output:
1727 2013-04-30 Filip Pizlo <fpizlo@apple.com>
1729 fourthTier: Use hw.availcpu instead of hw.ncpu, and configure LLVM with --enable-zlib=no
1731 Rubber stamped by Mark Rowe.
1733 * Scripts/copy-webkitlibraries-to-product-directory:
1735 2013-07-16 Oliver Hunt <oliver@apple.com>
1737 Merge dfgFourthTier r148853
1739 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1741 fourthTier: tandem WebKit and LLVM builds should ./configure LLVM if needed
1742 https://bugs.webkit.org/show_bug.cgi?id=114933
1744 Reviewed by Andy Estes.
1746 This makes it easy to get set up for tandem LLVM builds.
1748 * Scripts/copy-webkitlibraries-to-product-directory:
1750 2013-07-16 Oliver Hunt <oliver@apple.com>
1752 Merge dfgFourthTier r148850
1754 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1756 fourthTier: WebKit's build system should relink JavaScriptCore if LLVM's libraries changed but its headers didn't
1757 https://bugs.webkit.org/show_bug.cgi?id=114926
1759 Reviewed by Geoffrey Garen.
1761 If the LLVM libraries change, then touch a phony header, which will force relink
1764 * Scripts/copy-webkitlibraries-to-product-directory:
1765 (unpackIfNecessary):
1767 2013-07-16 Oliver Hunt <oliver@apple.com>
1769 Merge dfgFourthTier r148848
1771 2013-04-21 Filip Pizlo <fpizlo@apple.com>
1773 fourthTier: developing LLVM in tandem with WebKit should be fun and easy
1774 https://bugs.webkit.org/show_bug.cgi?id=114925
1776 Reviewed by Geoffrey Garen.
1778 This enables building LLVM along with WebKit, so that build-jsc and build-webkit
1779 will also optionally build LLVM and quickly symlink LLVM's built products into
1782 Most WebKit and JSC hackers will want to rely on the checked-in already-built
1783 versions of LLVM in WebKitLibraries. But developing both systems in tandem is an
1784 increasingly common use-case for me, and it may become a common use case for a
1785 handful of others. Currently, this is really painful: you first have to build
1786 LLVM, then you have to export-llvm-build (which takes a while), and then you
1787 have to make sure that your LLVM_LIBRARY_PACKAGE and LLVM_INCLUDE_PACKAGE
1788 variables are set to point to the thing you exported. The whole process loses
1789 track of dependencies very quickly: making a tiny change in LLVM requires
1790 packaging, and then unpackaging, a large number of potentially large headers and
1791 static libraries. Not only is this slow but it then causes the WebKit build
1792 system to rebuild anything that transitively includes any LLVM header, which is
1793 now quite a few files. While this sort of use pattern is still worthwhile if
1794 you're trying to package a binary drop and test it, it's not great if you're
1795 just trying to do experimental development that involves making small changes
1798 This change fixes this use case while keeping the old use cases intact. You can
1799 do tandem development using one of two modes:
1801 Your own LLVM directory: just set LLVM_SOURCE_PATH to the *absolute* path of
1802 the LLVM directory you're using. Once this is done, any invocation of a WebKit
1803 build via build-jsc or build-webkit will also build LLVM, and then quickly
1804 symlink things into place without perturbing dependency tracking.
1806 Internal LLVM directory: if you check out llvm into a directory called 'llvm'
1807 right off of the WebKit source tree, then the build system will automatically
1810 Here's how this takes care of dependencies:
1812 Headers: the include/llvm and include/llvm-c directories are symlinked into
1813 $productsDir/usr/local/include. And then everything just works.
1815 Libraries: the build system detects, by reading LLVM's Makefile.config, which
1816 mode LLVM is built in (like Release+Asserts or Debug+Asserts) and symlinks
1817 the .a files into $productsDir/<thingy>. It will ranlib those libraries only
1818 if they have changed, by checking both the modification time and also whether
1819 the last time we had a symlink, that symlink was from the same directory.
1820 This helps if you switch to an *older* LLVM build (using LLVM_SOURCE_PATH)
1821 but that build wasn't yet ranlib'd.
1823 One problem that this does not yet solve is that xcodebuild will not relink
1824 JavaScriptCore if the only thing that changed was the libraries. I will work
1825 on this problem separately: https://bugs.webkit.org/show_bug.cgi?id=114926.
1827 * Scripts/copy-webkitlibraries-to-product-directory:
1828 (unpackIfNecessary):
1830 (fileContentsEquals):
1832 2013-04-15 Filip Pizlo <fpizlo@apple.com>
1834 fourthTier: Update LLVM-related build scripts to copy generated headers as well
1835 https://bugs.webkit.org/show_bug.cgi?id=114551
1837 Reviewed by Oliver Hunt.
1839 Also added the ability to use something other than bzip2 compression, since although
1840 it is great for checking things into the tree, it increases turn-around times when
1843 * Scripts/copy-webkitlibraries-to-product-directory:
1844 (unpackIfNecessary):
1845 * Scripts/export-llvm-build:
1847 2013-04-03 Filip Pizlo <fpizlo@apple.com>
1849 fourthTier: Include LLVM headers with surrounding #pragmas instead of using my #define
1850 https://bugs.webkit.org/show_bug.cgi?id=113921
1852 Reviewed by Oliver Hunt.
1854 The LLVM community wants us to continue including all of LLVM's C++ headers. Change
1855 the export script to do this.
1857 * Scripts/export-llvm-build:
1859 2013-03-29 Filip Pizlo <fpizlo@apple.com>
1861 fourthTier: Check in a known-good build of LLVM into WebKitLibraries, and have a story for updating it
1862 https://bugs.webkit.org/show_bug.cgi?id=113452
1864 Rubber stamped by Mark Hahnenberg.
1866 * Scripts/copy-webkitlibraries-to-product-directory:
1867 * Scripts/export-llvm-build:
1869 2013-03-29 Filip Pizlo <fpizlo@apple.com>
1871 fourthTier: FTL JIT should be able run some simple function
1872 https://bugs.webkit.org/show_bug.cgi?id=113481
1874 Reviewed by Geoffrey Garen.
1876 Give the scripts the ability to find an LLVM build and use it.
1878 Also added a script, export-llvm-build, that allows you to take your
1879 own build of LLVM and package it for use by WebKit's build system.
1881 The build system treats a "build" of LLVM as a pair of .tar.bz2's,
1882 one for the library archives and one for the headers. It then unpacks
1883 them into your built products directory in a mannner that is mostly
1884 analogous to how WebKitSystemInterface works.
1886 * Scripts/build-jsc:
1887 * Scripts/copy-webkitlibraries-to-product-directory:
1888 (unpackIfNecessary):
1890 * Scripts/export-llvm-build: Added.
1892 2013-07-24 Anders Carlsson <andersca@apple.com>
1894 Crash when calling WKPageGetProcessIdentifier after aborted process launch
1895 https://bugs.webkit.org/show_bug.cgi?id=119069
1896 <rdar://problem/14494064>
1898 Reviewed by Andreas Kling.
1902 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1903 * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp: Added.
1904 (TestWebKitAPI::didFinishLoadForFrame):
1905 (TestWebKitAPI::TEST):
1907 2013-07-24 Zan Dobersek <zdobersek@igalia.com>
1909 Make KURL::hasPath private
1910 https://bugs.webkit.org/show_bug.cgi?id=118279
1912 Reviewed by Darin Adler.
1914 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
1915 (TestWebKitAPI::TEST_F): Remove references to KURL::hasPath the method is now private and thus not accessible for testing.
1917 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
1919 [GTK] TestInspectorServer unit test is timing out
1920 https://bugs.webkit.org/show_bug.cgi?id=105866
1922 Reviewed by Gustavo Noronha Silva.
1924 * Scripts/run-gtk-tests:
1927 2013-07-24 Anton Obzhirov <a.obzhirov@samsung.com>
1929 [GTK] [WK2] Handle wheel event with delta zero
1930 https://bugs.webkit.org/show_bug.cgi?id=118973
1932 Reviewed by Gustavo Noronha Silva.
1934 Added handling of zero mouse scroll deltas in EventSenderProxy similar
1935 to WK1 and Qt/EFL ports.
1937 fast/events/platform-wheelevent-with-delta-zero-crash.html is no longer
1940 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1941 (WTR::EventSenderProxy::mouseScrollBy):
1943 2013-07-23 Andreas Kling <akling@apple.com>
1945 REGRESSION(r150867): FrameView auto-sizing + delegate denied image load may cause StyleResolver to re-enter itself.
1946 <rdar://problem/14324895>
1947 <http://webkit.org/b/119023>
1949 Reviewed by Simon Fraser.
1951 Add a test for this rather specific problem.
1953 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1954 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm: Added.
1955 (TestWebKitAPI::TEST):
1956 * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp: Added.
1957 (TestWebKitAPI::DenyWillSendRequestTest::DenyWillSendRequestTest):
1958 (TestWebKitAPI::DenyWillSendRequestTest::willSendRequestForFrame):
1959 (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
1961 2013-07-23 Tim Horton <timothy_horton@apple.com>
1963 Add a test for plug-in unavailability indicator obscurity detection
1964 https://bugs.webkit.org/show_bug.cgi?id=119007
1966 Reviewed by Anders Carlsson.
1968 Expose the ability to block plug-ins via pluginLoadPolicy to testRunner.
1970 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1971 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1972 (WTR::TestRunner::setBlockAllPlugins):
1973 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1974 * WebKitTestRunner/TestInvocation.cpp:
1975 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1976 Add testRunner.setBlockAllPlugins function (and corresponding message to
1977 forward it through to TestController).
1979 * WebKitTestRunner/TestController.cpp:
1980 Initialize m_shouldBlockAllPlugins to false (and drive-by initialize m_handlesAuthenticationChallenges).
1982 (WTR::TestController::createWebViewWithOptions):
1983 Register our pluginLoadPolicy callback.
1985 (WTR::TestController::resetStateToConsistentValues):
1986 Reset m_shouldBlockAllPlugins to false.
1988 (WTR::TestController::pluginLoadPolicy):
1989 Return the existing plugin load policy, unless setBlockAllPlugins(true)
1990 was called, in which case we reject all plugins with kWKPluginLoadPolicyBlocked.
1992 * WebKitTestRunner/TestController.h:
1993 (WTR::TestController::setBlockAllPlugins):
1995 2013-07-21 Andreas Kling <akling@apple.com>
1997 KURL creates duplicate strings when completing data: URIs.
1998 <http://webkit.org/b/118952>
1999 <rdar://problem/14504480>
2001 Reviewed by Anders Carlsson.
2003 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2004 (TestWebKitAPI::TEST_F):
2006 2013-07-19 Chris Fleizach <cfleizach@apple.com>
2008 AX: VoiceOver not detecting misspelled words don't work in all cases
2009 https://bugs.webkit.org/show_bug.cgi?id=118924
2011 Reviewed by Tim Horton.
2013 Make the misspelled detection dependent on both types of attributes being present.
2015 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2016 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2017 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2018 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2020 2013-07-19 Alex Christensen <achristensen@apple.com>
2022 Improved code coverage generation.
2023 https://bugs.webkit.org/show_bug.cgi?id=118926
2025 Reviewed by Tim Horton.
2027 * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
2028 * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
2029 (generateReport): Moved report generation to a subroutine.
2031 2013-07-19 Stephanie Lewis <slewis@apple.com>
2033 <rdar://problem/14499595> pagination wk2 api test failing on ML (118928)
2037 Rebaseline pagination test after http://trac.webkit.org/changeset/152911
2039 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2040 (TestWebKitAPI::didLayout):
2042 2013-07-19 Daniel Bates <dabates@apple.com>
2044 Make Perl tools work when using git bisect with Git branch build setup
2045 https://bugs.webkit.org/show_bug.cgi?id=118512
2047 Reviewed by Martin Robinson.
2049 The various Perl tools (run-webkit-app, {debug, run}-safari, et cetera) don't work
2050 during a git bisect session with a Git branch build setup (i.e. git config
2051 core.webKitBranchBuild true). Specifically, the tools cannot find the branch-
2052 specific build of WebKit because they cannot determine the branch Git is on (since
2053 git bisect puts Git into a detached HEAD state). We should teach our tooling to
2054 parse the file .git/BISECT_START (created by git bisect start) for the name of the
2055 branch Git was on when we began a git bisect session. Then the tools can determine
2056 the path to the built WebKit.
2058 * Scripts/VCSUtils.pm:
2059 (gitDirectory): Added.
2060 (gitBisectStartBranch): Added.
2061 (gitBranch): Modified to call gitBisectStartBranch() when we have a detached
2062 HEAD (e.g. running git bisect).
2063 (determineVCSRoot): Modified to call gitDirectory() to determine the path to
2064 the .git directory in the Git checkout.
2066 2013-07-19 Alex Christensen <achristensen@apple.com>
2068 Added x64 configuration to Visual Studio build.
2069 https://bugs.webkit.org/show_bug.cgi?id=118888
2071 Reviewed by Brent Fulgham.
2073 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2074 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
2075 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2076 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2077 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2078 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2079 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2080 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2081 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2082 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2083 * win/record-memory/record-memory.vcxproj:
2085 2013-07-19 Martin Robinson <mrobinson@igalia.com>
2087 Add a couple people to the MathML watchlist
2088 https://bugs.webkit.org/show_bug.cgi?id=118909
2090 Reviewed by Andreas Kling.
2092 Add a couple people to the MathML watchlist and add Kalyan's other
2093 email address to fix style checker warnings about the watchlist
2096 * Scripts/webkitpy/common/config/contributors.json: Add Frédéric to the
2097 list of contributors and add Kalyan's second email address.
2098 * Scripts/webkitpy/common/config/watchlist: Add myself and Frédéric to the MathML
2101 2013-07-19 Simon Pena <simon.pena@samsung.com>
2103 [GTK] Fix regression in DumpRenderTree introduced in r152782 by checking if uri is valid
2104 https://bugs.webkit.org/show_bug.cgi?id=118895
2106 Reviewed by Philippe Normand.
2108 In r152782 an uri is used to create an string representation without checking first if it
2109 is valid. That fails later when the string is used to check for existing redirections. This
2110 patch ensures that the uri is valid before using it.
2112 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2113 (willSendRequestCallback): Ensure an uri is valid before using it.
2115 2013-07-18 Timothy Hatcher <timothy@apple.com>
2117 Add extract-localizable-js-strings and use it for WebInspectorUI.
2119 https://bugs.webkit.org/show_bug.cgi?id=118851
2121 Reviewed by Joseph Pecoraro.
2123 * Scripts/extract-localizable-js-strings: Added.
2124 * Scripts/extract-localizable-strings: Drive-by-fix: disable deprecated warnings about "goto".
2125 * Scripts/update-webkit-localizable-strings: Use extract-localizable-js-strings for
2126 the WebInspectorUI project.
2128 2013-07-18 Brent Fulgham <bfulgham@apple.com>
2130 [Windows] Build correction #2 after r152861.
2132 * WinLauncher/WinLauncher.cpp: Declare proper linkage.
2134 2013-07-18 Brent Fulgham <bfulgham@apple.com>
2136 [Windows] Build correction after r152861.
2138 * WinLauncher/WinLauncher.cpp: Don't reference private header.
2140 2013-07-16 Brent Fulgham <bfulgham@apple.com>
2142 [Win] Support in-band text tracks.
2143 https://bugs.webkit.org/show_bug.cgi?id=103770
2145 Reviewed by Eric Carlson.
2147 Update WinLauncher to run in a CFRunLoop (rather than a hand-written Windows event loop) so that
2148 libdispatch and CFRunLoop elements are services during the run loop.
2150 * WinLauncher/WinLauncher.cpp:
2151 (dllLauncherEntryPoint): Use CFRunLoopRun (rather than a Windows message loop) if running with
2152 a CoreFoundation (or CFLite) support library.
2153 * WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props: Added.
2154 * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props: Added.
2155 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add references to WinLauncherCF.props
2156 and WinLauncherCFLite.props.
2158 2013-07-18 Roger Fong <roger_fong@apple.com>
2160 Unreviewed. Test enabling WinEWS tests now that queue is at a good state and NRWT with multiple processes is enabled.
2162 * Scripts/webkitpy/common/config/ews.json:
2164 2013-07-18 Daniel Bates <dabates@apple.com>
2166 REGRESSION (r132678): Tests that use SSL or port 8080 time out when run using old-run-webkit-tests
2167 https://bugs.webkit.org/show_bug.cgi?id=118854
2168 <rdar://problem/14081339>
2170 Reviewed by David Kilzer.
2172 Following <http://trac.webkit.org/changeset/132678> (https://bugs.webkit.org/show_bug.cgi?id=98602)
2173 Apache no longer listens to ports 8443 (SSL) and 8080. So, tests that use these ports time out when
2174 run using old-run-webkit-tests. We need to update old-run-webkit-tests to explicitly tell Apache to
2175 listen on these ports so that we can run tests that use port 8443 and 8080.
2177 * Scripts/old-run-webkit-tests:
2178 (configureAndOpenHTTPDIfNeeded):
2180 2013-07-17 Tim Horton <timothy_horton@apple.com>
2182 Update blocked/missing plug-in UI
2183 https://bugs.webkit.org/show_bug.cgi?id=118347
2184 <rdar://problem/14209318>
2186 Reviewed by Sam Weinig.
2188 * MiniBrowser/mac/WK2BrowserWindowController.m:
2189 (-[WK2BrowserWindowController awakeFromNib]):
2190 * WebKitTestRunner/TestController.cpp:
2191 (WTR::TestController::createWebViewWithOptions):
2192 Match new WKPageLoaderClient entry.
2194 2013-07-17 Commit Queue <commit-queue@webkit.org>
2196 Unreviewed, rolling out r152701, r152703, r152739, r152754,
2198 http://trac.webkit.org/changeset/152701
2199 http://trac.webkit.org/changeset/152703
2200 http://trac.webkit.org/changeset/152739
2201 http://trac.webkit.org/changeset/152754
2202 http://trac.webkit.org/changeset/152756
2203 https://bugs.webkit.org/show_bug.cgi?id=118821
2205 this was a buggy fix and we're going to try something
2206 different (Requested by thorton on #webkit).
2208 * MiniBrowser/mac/WK2BrowserWindowController.m:
2209 (-[WK2BrowserWindowController awakeFromNib]):
2210 * WebKitTestRunner/TestController.cpp:
2211 (WTR::TestController::createWebViewWithOptions):
2213 2013-07-17 Commit Queue <commit-queue@webkit.org>
2215 Unreviewed, rolling out r151535.
2216 http://trac.webkit.org/changeset/151535
2217 https://bugs.webkit.org/show_bug.cgi?id=118804
2219 Re-disable WinEWS tests (Requested by rfong on #webkit).
2221 * Scripts/webkitpy/common/config/ews.json:
2223 2013-07-17 Simon Pena <simon.pena@samsung.com>
2225 [GTK] Make DRT obbey testRunner's addURLToRedirect
2226 https://bugs.webkit.org/show_bug.cgi?id=118239
2228 Reviewed by Gustavo Noronha Silva.
2230 Support testRunner's addURLToRedirect in GTK's DRT, so it redirects
2231 to the proper URI when indicated.
2233 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2234 (willSendRequestCallback):
2236 2013-07-17 Gabor Abraham <abrhm@inf.u-szeged.hu>
2238 Add a new find-resolved-bugs command to webkit-patch.
2239 https://bugs.webkit.org/show_bug.cgi?id=118060
2241 Reviewed by Csaba Osztrogonác.
2243 * Scripts/webkitpy/tool/commands/queries.py:
2244 (PrintBaselines._platform_for_path):
2246 (FindResolvedBugs.execute):
2248 2013-07-16 Balazs Kelemen <kbalazs@webkit.org>
2250 [CMake] Undefined references should be detected at build time
2251 https://bugs.webkit.org/show_bug.cgi?id=110236
2253 Reviewed by Christophe Dumez.
2255 Add library dependencies that were not defined explicitly before.
2257 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2258 * TestWebKitAPI/CMakeLists.txt:
2259 * WebKitTestRunner/CMakeLists.txt:
2261 2013-07-16 Kwang Yul Seo <skyul@company100.net>
2263 check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
2264 https://bugs.webkit.org/show_bug.cgi?id=118755
2266 Reviewed by Ryosuke Niwa.
2268 Fix r152719 to check "using namespace foo;" only in headers.
2270 * Scripts/webkitpy/style/checkers/cpp.py:
2271 (check_using_namespace):
2273 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2274 (WebKitStyleTest.test_using_namespace):
2276 2013-07-16 Christophe Dumez <ch.dumez@sisa.samsung.com>
2278 Get rid of multiple inheritance support from the bindings generators
2279 https://bugs.webkit.org/show_bug.cgi?id=118353
2281 Reviewed by Kentaro Hara.
2283 Update CodeGeneratorTestRunner.pm to use domInterface->parent instead of
2284 deprecated domInterface->parents.
2286 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2289 2013-07-16 Brian Holt <brian.holt@samsung.com>
2291 check-webkit-style: "using namespace foo;" should be flagged as an error in headers
2292 https://bugs.webkit.org/show_bug.cgi?id=57241
2294 Reviewed by Ryosuke Niwa.
2296 Added check for "using namespace foo" and unit test.
2298 * Scripts/webkitpy/style/checkers/cpp.py:
2299 (check_using_namespace):
2302 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2303 (WebKitStyleTest.test_using_namespace):
2305 2013-07-16 Anton Obzhirov <a.obzhirov@samsung.com>
2307 [GTK] fast/events/platform-wheelevent-with-delta-zero-crash.html is crashing
2308 https://bugs.webkit.org/show_bug.cgi?id=110222
2310 Reviewed by Gustavo Noronha Silva.
2312 Added handling of zero mouse scroll deltas in EventSender.
2314 * DumpRenderTree/gtk/EventSender.cpp:
2315 (mouseScrollByCallback):
2317 2013-07-16 Brian Holt <brian.holt@samsung.com>
2319 webkitpy: replace urllib with urllib2 for downloading additional modules
2320 https://bugs.webkit.org/show_bug.cgi?id=118671
2322 Reviewed by Ryosuke Niwa.
2324 Urllib2 is available whereever urllib is, but has better proxy support.
2326 * Scripts/webkitpy/common/system/autoinstall.py:
2327 (AutoInstaller._download_to_stream):
2329 2013-07-16 Krzysztof Czech <k.czech@samsung.com>
2331 [ATK] Adds support for aria-haspopup property.
2332 https://bugs.webkit.org/show_bug.cgi?id=117834
2334 Reviewed by Christophe Dumez.
2336 Adds implementation for testing aria-haspopup property.
2338 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2339 (getAttributeSetValueForId):
2340 (AccessibilityUIElement::stringAttributeValue):
2341 (AccessibilityUIElement::hasPopup):
2342 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2343 (WTR::getAttributeSetValueForId):
2344 (WTR::AccessibilityUIElement::stringAttributeValue):
2345 (WTR::AccessibilityUIElement::hasPopup):
2347 2013-07-16 Michael Brüning <michael.bruning@digia.com>
2349 [Qt] Replace Nokia references.
2350 https://bugs.webkit.org/show_bug.cgi?id=118728
2352 Reviewed by Simon Hausmann.
2354 * MiniBrowser/qt/MiniBrowserApplication.cpp:
2355 (MiniBrowserApplication::MiniBrowserApplication):
2356 * QtTestBrowser/qttestbrowser.cpp:
2357 (LauncherApplication::LauncherApplication):
2359 2013-07-15 Tim Horton <timothy_horton@apple.com>
2361 Update blocked/missing plug-in UI
2362 https://bugs.webkit.org/show_bug.cgi?id=118347
2363 <rdar://problem/14209318>
2365 Reviewed by Sam Weinig.
2367 * MiniBrowser/mac/WK2BrowserWindowController.m:
2368 (-[WK2BrowserWindowController awakeFromNib]):
2369 * WebKitTestRunner/TestController.cpp:
2370 (WTR::TestController::createWebViewWithOptions):
2371 Match new WKPageLoaderClient entry.
2373 2013-07-15 Chris Fleizach <cfleizach@apple.com>
2375 Update James Craig's email address.
2377 * Scripts/webkitpy/common/config/contributors.json:
2379 2013-07-15 Dong-Gwan Kim <donggwan.kim@samsung.com>
2381 [EFL] Add fallback for TestWebKitAPI if opengl is not available.
2382 https://bugs.webkit.org/show_bug.cgi?id=118583
2384 Reviewed by Christophe Dumez.
2386 There're many fails on efl webkit2 API test if opengl is not available.
2387 So, add fallback to non-opengl evas engine.
2389 * TestWebKitAPI/efl/PlatformWebView.cpp:
2390 (TestWebKitAPI::initEcoreEvas):
2392 2013-07-15 Brian Holt <brian.holt@samsung.com>
2394 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2395 https://bugs.webkit.org/show_bug.cgi?id=118592
2397 Reviewed by Martin Robinson.
2399 Added a suppression for pylint false positives and a unit test.
2401 * Scripts/webkitpy/style/checkers/python.py:
2403 * Scripts/webkitpy/style/checkers/python_unittest.py:
2404 (PythonCheckerTest.test_check):
2405 (PythonCheckerTest):
2406 (PythonCheckerTest.test_pylint_false_positives):
2407 (PythonCheckerTest.test_pylint_false_positives._mock_handle_style_error):
2408 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2411 2013-07-15 Xabier Rodriguez Calvar <calvaris@igalia.com>
2413 [GTK] Increase the JHBuild version of GStreamer to 1.0.7
2414 https://bugs.webkit.org/show_bug.cgi?id=115166
2416 Reviewed by Philippe Normand.
2418 * gtk/jhbuild.modules: Bumping GStreamer version up to 1.0.8.
2420 2013-07-12 Kwang Yul Seo <skyul@company100.net>
2422 Unreviewed. Add an email address and update my domain of experts.
2424 * Scripts/webkitpy/common/config/contributors.json:
2426 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2428 [jhbuild] Avoid restarting from scratch failed initial checkouts
2429 https://bugs.webkit.org/show_bug.cgi?id=118603
2431 Reviewed by Martin Robinson.
2433 If the initial checkout is interrupted midway (eg. because the internet
2434 connection went down) config files do not get generated and that causes
2435 the next checkout to start from scratch (the missing files cause the
2436 script to delete the build root and the downloaded sources).
2438 By generating the files before invoking jhbuild, subsequent runs are able
2439 to start where the previous run left.
2441 * Scripts/update-webkit-libs-jhbuild:
2442 (saveJhbuildMd5): invoke it before runJhbuild().
2444 2013-07-12 Brent Fulgham <bfulgham@apple.com>
2446 [Windows] Remove single-worker restriction on tests.
2448 * Scripts/webkitpy/port/win.py: Remove restriction of one worker.
2450 2013-07-12 Commit Queue <commit-queue@webkit.org>
2452 Unreviewed, rolling out r152599.
2453 http://trac.webkit.org/changeset/152599
2454 https://bugs.webkit.org/show_bug.cgi?id=118612
2456 This patch includes a failing unit test (Requested by
2457 mrobinson on #webkit).
2459 * Scripts/webkitpy/style/checkers/python.py:
2461 * Scripts/webkitpy/style/checkers/python_unittest.py:
2462 (PythonCheckerTest.test_check):
2463 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
2465 2013-07-12 Emanuele Aina <emanuele.aina@collabora.com>
2467 [Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
2468 https://bugs.webkit.org/show_bug.cgi?id=91223
2470 Reviewed by Martin Robinson.
2472 When run on a clean checkout, `build-webkit` complains that no
2473 GNUmakefile exists when trying to detect the previously configured
2474 architecture, but in this case there's no previous configuration so
2475 the warning is pointless.
2477 * Scripts/webkitdirs.pm:
2478 (determineArchitecture): Redirect grep stderr to /dev/null.
2480 2013-07-12 Brian Holt <brian.holt@samsung.com>
2482 check-webkit-style: Ignore false positive: Instance of 'Popen' has no 'pid' member
2483 https://bugs.webkit.org/show_bug.cgi?id=118592
2485 Reviewed by Martin Robinson.
2487 Added a suppression for pylint false positives and a unit test.
2489 * Scripts/webkitpy/style/checkers/python.py:
2491 * Scripts/webkitpy/style/checkers/python_unittest.py:
2492 (PythonCheckerTest.test_check):
2493 (PythonCheckerTest):
2494 (PythonCheckerTest.test_pylint_false_positives):
2495 (PythonCheckerTest.test_pylint_false_positives._mock_handle_pylint_false_positives):
2496 * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Added.
2499 2013-07-11 Arnaud Renevier <a.renevier@samsung.com>
2501 Unreviewed. Add myself as a committer.
2503 * Scripts/webkitpy/common/config/contributors.json:
2505 2013-07-10 Sergio Correia <sergio.correia@openbossa.org>
2507 Handle "load,provisional,failed" with the on_error callback on EFL MiniBrowser
2508 https://bugs.webkit.org/show_bug.cgi?id=118538
2510 Reviewed by Christophe Dumez.
2512 When attempting some odd url such as ``foo'', MiniBrowser will now show an
2513 error message such as "Cannot resolve hostname (foo)".
2515 Previously, it had the following behavior if MiniBrowser was started with
2516 such urls, e.g ``./MiniBrowser foo'':
2519 It wouldt hit WebKit2/Platform/CoreIPC/unix/ConnectionUnix.cpp(460) and crash.
2522 No asserts, naturally, but the view would remain blank, even if we tried to
2523 change to a valid url.
2525 * MiniBrowser/efl/main.c:
2528 2013-07-10 Simon Pena <simon.pena@samsung.com>
2530 [GTK] WebKitTestRunner tries to remove an already deleted event in EventSenderProxy::replaySavedEvents
2531 https://bugs.webkit.org/show_bug.cgi?id=118509
2533 Reviewed by Martin Robinson.
2535 In EventSenderProxy::replaySavedEvents WebKitTestRunner can crash
2536 when trying to remove an event already removed, if another event is
2537 processed in the middle. By using a Deque's takeFirst, we ensure the
2538 element is removed before we dispatch it.
2540 fast/events/mousedown-inside-dragstart-should-not-cause-crash.html no longer
2541 crashes after this fix is added.
2543 * WebKitTestRunner/EventSenderProxy.h: Use a Deque instead of Vector in GTK
2544 * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2545 (WTR::EventSenderProxy::replaySavedEvents): Use takeFirst to retrieve the event
2548 2013-07-09 Ryuan Choi <ryuan.choi@samsung.com>
2550 [EFL] Add ewk_view_device_pixel_ratio_set
2551 https://bugs.webkit.org/show_bug.cgi?id=118521
2553 Reviewed by Gyuyoung Kim.
2555 * EWebLauncher/main.c: Added new option(-r) to test device pixel ratio.
2557 (parseUserArguments):
2559 2013-07-09 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
2561 Unreviewed change of my email addresses.
2562 https://bugs.webkit.org/show_bug.cgi?id=100122
2564 * Scripts/webkitpy/common/config/contributors.json:
2566 2013-07-09 Anders Carlsson <andersca@apple.com>
2568 DumpRenderTree should stop sending unsupported URLs to NSWorkspace
2569 https://bugs.webkit.org/show_bug.cgi?id=118514
2570 <rdar://problem/13686836>
2572 Reviewed by Sam Weinig.
2574 Add a new default policy delegate and override decidePolicyForNavigationAction: to not pass unhandled URLs to NSWorkspace.
2576 * DumpRenderTree/DefaultPolicyDelegate.h: Added.
2577 * DumpRenderTree/DefaultPolicyDelegate.m: Added.
2578 (-[DefaultPolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
2579 * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2580 Add DefaultPolicyDelegate.h and DefaultPolicyDelegate.m.
2582 * DumpRenderTree/mac/DumpRenderTree.mm:
2583 (allocateGlobalControllers):
2584 Allocate a DefaultPolicyDelegate object.
2586 (resetWebViewToConsistentStateBeforeTesting):
2587 Set the policy delegate to the default policy delegate.
2589 * DumpRenderTree/mac/DumpRenderTreeMac.h:
2590 Declare the defaultPolicyDelegate object.
2592 * DumpRenderTree/mac/TestRunnerMac.mm:
2593 (TestRunner::setCustomPolicyDelegate):
2594 Set the policy delegate to the default delegate if setDelegate is false.
2596 2013-07-08 Zan Dobersek <zdobersek@igalia.com>
2598 KURL unit test fixture class should have a meaningful name
2599 https://bugs.webkit.org/show_bug.cgi?id=118467
2601 Reviewed by Sam Weinig.
2603 * TestWebKitAPI/Tests/WebCore/KURL.cpp:
2604 (TestWebKitAPI::TEST_F): Use 'KURLTest' as the name for the KURL unit test's fixture class
2605 instead of the generic and inappropriate 'WebCore' name.
2607 2013-07-08 Antti Koivisto <antti@apple.com>
2609 Add Deque::removeLast
2610 https://bugs.webkit.org/show_bug.cgi?id=118466
2612 Reviewed by Andreas Kling.
2614 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2615 * TestWebKitAPI/Tests/WTF/Deque.cpp: Added.
2616 (TestWebKitAPI::TEST):
2618 2013-07-08 Brian Holt <brian.holt@samsung.com>
2620 [GTK] Leak: GFile* leaking in beginDragWithFilesCallback
2621 https://bugs.webkit.org/show_bug.cgi?id=118412
2623 Reviewed by Martin Robinson.
2625 An adoptRef is required to balance ref and deref calls.
2627 * DumpRenderTree/gtk/EventSender.cpp:
2628 (beginDragWithFilesCallback):
2630 2013-07-06 Sergio Correia <sergio.correia@openbossa.org>
2632 Update list of EFL WK2 API tests
2633 https://bugs.webkit.org/show_bug.cgi?id=118443
2635 Reviewed by Christophe Dumez.
2637 The following tests were included:
2640 - CloseThenTerminate
2641 - DidAssociateFormControls
2642 - PageVisibilityState
2643 - ResponsivenessTimerDoesntFireEarly
2648 - ResizeReversePaginatedWebView
2649 - ScrollPinningBehaviors
2651 This patch also modified ``test_webkit2_api_BINARIES'' list so that it is in
2654 * TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
2655 * TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
2657 2013-07-05 Tim Horton <timothy_horton@apple.com>
2659 Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
2660 https://bugs.webkit.org/show_bug.cgi?id=118439
2661 <rdar://problem/14366120>
2663 Reviewed by Anders Carlsson.
2665 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2666 (TestWebKitAPI::didLayout):
2667 (TestWebKitAPI::TEST):
2668 - Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
2669 - Assert that we got the right number of pages for sanity.
2670 - Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
2671 so much memory that SharedMemory asserts and makes the test time out.
2672 - Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
2673 because paint doesn't fire if the window is offscreen.
2675 2013-07-05 Tim Horton <timothy_horton@apple.com>
2677 [wk2] Add API to lock the scroll position at the top or bottom of the page
2678 https://bugs.webkit.org/show_bug.cgi?id=118429
2679 <rdar://problem/14120323>
2681 Reviewed by Anders Carlsson.
2683 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2684 * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
2685 (TestWebKitAPI::didFinishDocumentLoadForFrame):
2686 (TestWebKitAPI::TEST):
2687 Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
2688 all work correctly in the face of resizing the view and scrolling from JS.
2690 2013-07-05 Michael Pruett <michael@68k.org>
2692 Unreviewed. Add myself as a committer.
2694 * Scripts/webkitpy/common/config/contributors.json:
2696 2013-07-05 Xabier Rodriguez Calvar <calvaris@igalia.com>
2698 [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
2699 https://bugs.webkit.org/show_bug.cgi?id=111434
2701 Reviewed by Carlos Garcia Campos.
2703 * Scripts/run-gtk-tests:
2704 (TestRunner): Unskipped TestWebKitFaviconDatabase tests.
2706 2013-07-04 Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
2708 [EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
2709 https://bugs.webkit.org/show_bug.cgi?id=118370
2711 Reviewed by Christophe Dumez.
2713 Add fallback to software X11 engine if opengl_x11 engine creation fails.
2715 * DumpRenderTree/efl/DumpRenderTree.cpp:
2718 2013-07-04 Brian Holt <brian.holt@samsung.com>
2720 [ATK] Leak: AtkAttributeSet* should be freed
2721 https://bugs.webkit.org/show_bug.cgi?id=118307
2723 Reviewed by Christophe Dumez.
2725 Fixed memory leaks for AtkAttributeSet by calling
2726 atk_attribute_set_free().
2728 * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2729 (AccessibilityController::childElementById):
2730 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2731 (getAtkAttributeSetAsString):
2732 (AccessibilityUIElement::allAttributes):
2733 (AccessibilityUIElement::stringAttributeValue):
2734 * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2735 (WTR::childElementById):
2736 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2737 (WTR::getAtkAttributeSetAsString):
2738 (WTR::AccessibilityUIElement::allAttributes):
2739 (WTR::AccessibilityUIElement::stringAttributeValue):
2741 2013-07-03 David Farler <dfarler@apple.com>
2743 Add Makefile to WebKitLauncher
2744 https://bugs.webkit.org/show_bug.cgi?id=118365
2746 Reviewed by Mark Rowe.
2748 * WebKitLauncher/Makefile: Added.
2750 2013-07-03 Brian Holt <brian.holt@samsung.com>
2752 [ATK] Leak: more leaks in AccessibilityUIElement
2753 https://bugs.webkit.org/show_bug.cgi?id=118362
2755 Reviewed by Christophe Dumez.
2757 Free the memory created by g_strdup_printf.
2759 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2760 (AccessibilityUIElement::language):
2761 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2762 (WTR::AccessibilityUIElement::language):
2764 2013-07-03 Jer Noble <jer.noble@apple.com>
2766 Xcode often gets in a state where the debugger is completely unresponsive
2767 https://bugs.webkit.org/show_bug.cgi?id=118157
2769 The GetPointeeData() operations we use to retrieve strings is extremely expensive.
2770 Rather than pull the character data out of the debugger one byte at a time
2771 through the GetPointeeData() API, retrieve the memory contents of the string through
2772 the ReadMemory() API, and convert the retrieved memory into a python string.
2774 Reviewed by Anders Carlsson.
2776 * lldb/lldb_webkit.py:
2777 (__lldb_init_module.lldb_webkit):
2778 (guess_string_length):
2779 (ustring_to_string):
2780 (lstring_to_string):
2782 2013-07-03 Morten Stenshorne <mstensho@opera.com>
2784 [GTK] Let F5 refresh the page in MiniBrowser
2785 https://bugs.webkit.org/show_bug.cgi?id=117638
2787 Reviewed by Carlos Garcia Campos.
2789 Also use the correct icon for the refresh button that was already there.
2791 * MiniBrowser/gtk/BrowserWindow.c:
2792 (browser_window_init):
2794 2013-07-02 Kondapally Kalyan <kalyan.kondapally@intel.com>
2796 Unreviewed. Add my email to a few watchlists.
2798 * Scripts/webkitpy/common/config/watchlist:
2800 2013-07-02 David Farler <dfarler@apple.com>
2802 Unreviewed. Adding myself to contributors.json.
2804 * Scripts/webkitpy/common/config/contributors.json:
2806 2013-07-02 Brian Holt <brian.holt@samsung.com>
2808 [ATK] Leak: leaks in AccessibilityUIElement
2809 https://bugs.webkit.org/show_bug.cgi?id=118297
2813 Reviewed by Christophe Dumez.
2815 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2816 (AccessibilityUIElement::stringValue):
2818 2013-07-02 Byungwoo Lee <bw80.lee@samsung.com>
2820 Fix WebKitTestRunner crashes.
2821 https://bugs.webkit.org/show_bug.cgi?id=117630
2823 Reviewed by Darin Adler.
2825 Create static function to dump for WebProcess unresponsiveness status,
2826 and use it before calling TestController::runTest().
2828 Accessing TestController::m_currentInvocation before calling
2829 TestController::runTest() can make crash because the invocation
2830 instance will be assigned at the function.
2832 * WebKitTestRunner/TestController.cpp:
2833 (WTR::TestController::run):
2834 * WebKitTestRunner/TestInvocation.cpp:
2835 (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
2836 * WebKitTestRunner/TestInvocation.h:
2838 2013-07-02 Allan Sandfeld Jensen <allan.jensen@digia.com>
2840 [Qt][WK1] Support WebGL with EGL on Linux
2841 https://bugs.webkit.org/show_bug.cgi?id=118251
2843 Reviewed by Kenneth Rohde Christiansen.
2845 * qmake/mkspecs/features/features.prf:
2847 2013-07-01 Nick Diego Yamane <nick.yamane@openbossa.org>
2849 [Efl][Gtk] Look at WEBKIT_OUTPUTDIR instead of WEBKITOUTPUTDIR in jhbuildrc
2850 https://bugs.webkit.org/show_bug.cgi?id=118267
2852 Reviewed by Gyuyoung Kim.
2854 After r152226 (from https://bugs.webkit.org/show_bug.cgi?id=117249)
2855 WEBKIT_OUTPUTDIR should be used instead of WEBKITOUPUTDIR. However
2856 Efl's jhbuildrc is still using the WEBKITOUTPUTDIR environment variable.
2861 2013-07-01 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
2863 [GTK] Remove unsupported AC backends
2864 https://bugs.webkit.org/show_bug.cgi?id=117362
2866 Reviewed by Martin Robinson.
2868 * gtk/jhbuild-optional.modules: no longer needs clutter-gtk, clutter
2869 and cogl, so removed.
2871 2013-07-01 Timothy Hatcher <timothy@apple.com>
2873 Link to WebInspectorUI.framework at build time instead of soft linking.
2875 https://bugs.webkit.org/show_bug.cgi?id=118261
2877 Reviewed by Joseph Pecoraro.
2879 * Scripts/build-webkit: Build WebInspectorUI before WebKit and WebKit2.
2881 2013-07-01 Tim Horton <timothy_horton@apple.com>
2883 Maximum scroll position can be negative in some cases
2884 https://bugs.webkit.org/show_bug.cgi?id=118175
2885 <rdar://problem/14301217>
2887 Reviewed by Anders Carlsson.
2889 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2890 * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp: Added.
2891 (TestWebKitAPI::didRunJavaScript):
2892 (TestWebKitAPI::didLayout):
2893 (TestWebKitAPI::TEST):
2894 * TestWebKitAPI/Tests/WebKit2/lots-of-text-vertical-lr.html: Added.
2895 Add a test that loads a vertical-lr document, paginates it horizontally
2896 from right to left, resizes the view to fit the entire document, and
2897 verifies that the scroll position is negative, as it must be for the
2898 document to be enclosed by the view.
2900 2013-07-01 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
2902 [EFL][GTK] Migrate from WEBKITOUTPUTDIR to WEBKIT_OUTPUTDIR
2903 https://bugs.webkit.org/show_bug.cgi?id=117249
2905 Reviewed by Brent Fulgham.
2907 Finish converting all use cases of WEBKITOUTPUTDIR to
2908 WEBKIT_OUTPUTDIR, which seems to be preferred these days.
2910 * DumpRenderTree/efl/FontManagement.cpp:
2911 (getCustomBuildDir):
2912 (getPlatformFontsPath):
2913 * DumpRenderTree/gtk/DumpRenderTree.cpp:
2915 * Scripts/webkitdirs.pm:
2916 (determineBaseProductDir):
2917 (usesPerConfigurationBuildDirectory):
2918 * Scripts/webkitpy/port/base.py:
2919 (Port.to.setup_environ_for_server):
2920 * Scripts/webkitpy/port/driver.py:
2921 (Driver._setup_environ_for_driver):
2922 * Scripts/webkitpy/port/gtk.py:
2923 (GtkPort.setup_environ_for_server):
2924 * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2925 (WTR::getOutputDir):
2926 * jhbuild/jhbuildutils.py:
2927 (get_dependencies_path):
2929 2013-07-01 Rafael Brandao <rafael.lobo@webkit.org>
2931 Unreviewed change of my email address.
2933 * Scripts/webkitpy/common/config/contributors.json:
2935 2013-06-28 Andreas Kling <akling@apple.com>
2937 Fix Windows builds after deprecatedCharactersWithNullTermination() removal.
2939 * DumpRenderTree/win/DumpRenderTree.cpp:
2940 (addFontFallbackIfPresent):
2941 (removeFontFallbackIfPresent):
2943 2013-06-28 Anders Carlsson <andersca@apple.com>
2945 Remove String::deprecatedCharactersWithNullTermination() and related code
2946 https://bugs.webkit.org/show_bug.cgi?id=118211
2948 Reviewed by Benjamin Poulain.
2950 Remove all hasTerminatingNullCharacter() checks.
2952 * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2953 (TestWebKitAPI::TEST):
2954 * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2955 (TestWebKitAPI::TEST):
2956 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2957 (TestWebKitAPI::TEST):
2959 2013-06-28 Alexey Proskuryakov <ap@apple.com>
2961 [Mac] Crash when loading is stopped from -didReceiveResponse
2962 https://bugs.webkit.org/show_bug.cgi?id=118209
2963 <rdar://problem/14259249>
2965 Reviewed by Brady Eidson.
2967 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2968 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.html: Added.
2969 * TestWebKitAPI/Tests/mac/StopLoadingFromDidReceiveResponse.mm: Added.
2970 (-[StopLoadingFromDidReceiveResponse webView:resource:didReceiveResponse:fromDataSource:]):
2971 (TestWebKitAPI::TEST):
2973 2013-06-28 Andy Estes <aestes@apple.com>
2975 [Mac] Newer versions of clang use a default template instantiation depth that is too small for TestWebKitAPI
2976 https://bugs.webkit.org/show_bug.cgi?id=118208
2978 Reviewed by Mark Rowe.
2980 Newer versions of clang use a default template depth of 128, but this
2981 is too small for Tests/WTF/HashSet.cpp. Use 256 instead, which was the
2984 Clang lowered the default to keep recursive template instantiation
2985 from overflowing the stack (see <rdar://problem/13935016>), but
2986 TestWebKitAPI's C++ files don't trigger a stack overflow even with the
2987 higher limit. If for some reason this starts happening then we can
2988 lower the limit back down.
2990 * TestWebKitAPI/Configurations/Base.xcconfig: Build TestWebKitAPI with -ftemplate-depth=256.
2992 2013-06-28 Nick Diego Yamane <nick.yamane@openbossa.org>
2994 [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath
2995 https://bugs.webkit.org/show_bug.cgi?id=118195
2997 Reviewed by Daniel Bates.
2999 Currently, ports that use jhbuild fail to determine jhbuild directory
3000 when "webKitBranchBuild" git configuration property is enabled. To reproduce
3001 that issue in Efl port, enable that flag in .git/config, switch to a git branch
3002 other than "master" and try to build webkit. The build will fail to
3003 locate dependencies due to lack of pkg-config paths which should be set
3006 For more details about "webKitBranchBuild" option, see:
3007 https://trac.webkit.org/wiki/UsingGitWithWebKit
3009 * Scripts/webkitdirs.pm:
3012 2013-06-28 Jessie Berlin <jberlin@apple.com>
3014 WebKitTestRunner should disable automatic quote and dash substitution like DumpRenderTree does
3015 https://bugs.webkit.org/show_bug.cgi?id=118201
3017 Reviewed by Dean Jackson.
3019 * WebKitTestRunner/mac/main.mm:
3021 Modify NSUserDefaults directly since setAutomaticQuoteSubstitutionEnabled and
3022 setAutomaticDashSubstitutionEnabled are not exposed on WKView.
3024 2013-06-28 David Farler <dfarler@apple.com>
3026 Upstream WebKit Nightly’s WebKitLauncher
3027 https://bugs.webkit.org/show_bug.cgi?id=117418
3029 Reviewed by Mark Rowe.
3031 Literal patch from Nightly's OpenSource repo.
3033 * WebKitLauncher/Configurations/Base.xcconfig:
3034 * WebKitLauncher/Configurations/WebKitLauncher.xcconfig:
3035 * WebKitLauncher/Info.plist:
3036 * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
3037 * WebKitLauncher/WebKitLauncherURLProtocol.m:
3038 (+[WebKitLauncherURLProtocol load]):
3039 (+[WebKitLauncherURLProtocol canInitWithRequest:]):
3040 (-[WebKitLauncherURLProtocol startLoading]):
3041 (-[WebKitLauncherURLProtocol handleWebKitVersionInformation]):
3042 (-[WebKitLauncherURLProtocol resourceNotFound]):
3043 * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
3044 (initializeSparkle):
3045 * WebKitLauncher/main.m:
3046 (determineExecutablePath):
3047 (currentMacOSXVersion):
3049 * WebKitLauncher/start.html:
3051 2013-06-28 Balazs Kelemen <b.kelemen@samsung.com>
3053 [EFL] back/forward keyboard shortcuts are non-intuitive
3054 https://bugs.webkit.org/show_bug.cgi?id=118193
3056 Reviewed by Christophe Dumez.
3058 Changed shortcuts for go-back/go-forward to alt+left and alt+right.
3060 * EWebLauncher/main.c:
3062 * MiniBrowser/efl/main.c:
3065 2013-06-28 Roger Fong <roger_fong@apple.com>
3067 Enable AVFoundation in Web Prefs for WinLauncher and DumpRenderTree on Windows.
3068 https://bugs.webkit.org/show_bug.cgi?id=118194.
3070 Reviewed by Brent Fulgham.
3072 * DumpRenderTree/win/DumpRenderTree.cpp:
3073 (dllLauncherEntryPoint):
3074 * WinLauncher/WinLauncher.cpp:
3075 (dllLauncherEntryPoint):
3077 2013-06-28 Roger Fong <roger_fong@apple.com>
3079 Unreviewed build fix for AppleWin port. Fix some file paths.
3081 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3082 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3084 2013-06-27 Roger Fong <roger_fong@apple.com>
3086 Add IAccessibilityDelegate implementation to WinLauncher for testing purposes.
3087 https://bugs.webkit.org/show_bug.cgi?id=118160.
3089 Reviewed by Brent Fulgham.
3091 * WinLauncher/AccessibilityDelegate.cpp: Added.
3092 (AccessibilityDelegate::QueryInterface):
3093 (AccessibilityDelegate::AddRef):
3094 (AccessibilityDelegate::Release):
3095 (AccessibilityDelegate::fireFrameLoadStartedEvents): Just returns S_OK;
3096 (AccessibilityDelegate::fireFrameLoadFinishedEvents): Ditto.
3097 * WinLauncher/AccessibilityDelegate.h: Added.
3098 (AccessibilityDelegate::AccessibilityDelegate):
3099 * WinLauncher/WinLauncher.cpp:
3100 (dllLauncherEntryPoint):
3101 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3102 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
3104 2013-06-28 Christophe Dumez <ch.dumez@sisa.samsung.com>
3106 Clean up temporary files created by the bindings test script
3107 https://bugs.webkit.org/show_bug.cgi?id=118189
3109 Reviewed by Kentaro Hara.
3111 Remove temporary files created by preprocess-idls.pl script after
3112 the bindings tests are executed.
3114 Based on Blink 153236 by Kentaro Hara <haraken@chromium.org>.
3116 * Scripts/webkitpy/bindings/main.py:
3117 (BindingsTests.main):
3119 2013-06-26 Dean Jackson <dino@apple.com>
3121 [Mac] Add Mavericks system font to Test systems
3122 https://bugs.webkit.org/show_bug.cgi?id=118109
3124 Reviewed by Simon Fraser.
3126 OS X Mavericks uses a different font for system controls. Tell DRT and
3127 WKTR about them otherwise they use a fallback font. Unfortunately the
3128 fonts are hidden (not found in the list of available fonts) so I
3129 had to add them manually.
3131 Even though there is only one at the moment, I implemented this
3132 as a set so it will be easier to add new fonts if necessary.
3134 * DumpRenderTree/mac/DumpRenderTree.mm:
3135 (allowedFontFamilySet): Fixed typo.
3136 (systemHiddenFontFamilySet): New method that returns the system control font.
3137 (drt_NSFontManager_availableFonts): Merge the hidden fonts.
3138 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3139 (WTR::allowedFontFamilySet): Fixed typo.
3140 (WTR::systemHiddenFontFamilySet): As above.
3141 (WTR::wtr_NSFontManager_availableFonts):
3143 2013-06-27 Anders Carlsson <andersca@apple.com>
3145 Get rid of the last uses of deprecatedCharactersWithNullTermination()
3146 https://bugs.webkit.org/show_bug.cgi?id=118159
3148 Reviewed by Andreas Kling.
3150 Replace calls to deprecatedCharactersWithNullTermination() with charactersWithNullTermination().data().
3152 * DumpRenderTree/win/DumpRenderTree.cpp:
3155 2013-06-27 Bem Jones-Bey <bjonesbe@adobe.com>
3157 Sync up w3c import script with changes in Blink
3158 https://bugs.webkit.org/show_bug.cgi?id=118149
3160 Reviewed by Dirk Pranke.
3162 This is a port of the following blink changes:
3164 https://codereview.chromium.org/15366004
3165 https://chromiumcodereview.appspot.com/15592005
3166 https://codereview.chromium.org/16021006
3167 https://codereview.chromium.org/15590004
3168 https://codereview.chromium.org/15901008
3169 https://codereview.chromium.org/16171009
3170 https://codereview.chromium.org/16465007
3171 https://codereview.chromium.org/15981013
3173 * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3175 (test_commit_message_for_this_commit):
3176 * Scripts/webkitpy/port/base.py:
3178 * Scripts/webkitpy/port/test.py:
3179 * Scripts/webkitpy/w3c/test_converter.py:
3180 (W3CTestConverter.__init__):
3181 (W3CTestConverter.read_webkit_prefixed_css_property_list):
3182 (W3CTestConverter.convert_for_webkit):
3183 (W3CTestConverter.convert_css):
3184 (W3CTestConverter.convert_html):
3185 (W3CTestConverter.convert_testharness_paths):
3186 (W3CTestConverter.convert_prefixed_properties):
3187 (W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3188 * Scripts/webkitpy/w3c/test_converter_unittest.py:
3189 * Scripts/webkitpy/w3c/test_importer.py:
3191 (configure_logging):
3192 (configure_logging.LogHandler):
3193 (configure_logging.LogHandler.format):
3195 (TestImporter.__init__):
3196 (TestImporter.find_importable_tests):
3197 (TestImporter.import_tests):
3198 (TestImporter.setup_destination_directory):
3199 (TestImporter.remove_deleted_files):
3200 * Scripts/webkitpy/w3c/test_importer_unittest.py:
3201 (TestImporterTest.test_import_dir_with_no_tests_and_no_hg):
3202 (TestImporterTest.test_import_dir_with_no_tests):
3204 * Scripts/webkitpy/w3c/test_parser.py:
3205 (TestParser.load_file):
3206 (TestParser.analyze_test):
3207 (TestParser.support_files):
3208 * Scripts/webkitpy/w3c/test_parser_unittest.py:
3210 2013-06-27 Csaba Osztrogonác <ossy@webkit.org>
3212 [webkitpy] AbstractPatchSequencingCommand should have _prepare_state
3213 https://bugs.webkit.org/show_bug.cgi?id=118128
3215 Reviewed by Ryosuke Niwa.
3217 It is a preparation for a new webkit-patch command: run-tests-touched-by-attachment
3218 https://bugs.webkit.org/show_bug.cgi?id=117831
3220 * Scripts/webkitpy/tool/commands/download.py:
3221 (AbstractPatchSequencingCommand):
3222 (AbstractPatchSequencingCommand._prepare_to_process): Call _prepare_state before prepare_steps.
3223 (AbstractPatchSequencingCommand._process_patch): Use the same initial state for each patch.
3224 (AbstractPatchSequencingCommand._prepare_state): Added.
3226 2013-06-27 Brendan Long <b.long@cablelabs.com>
3228 [Qt] Build overrides -j when given --makeargs="-sj40"
3229 https://bugs.webkit.org/show_bug.cgi?id=116897
3231 Reviewed by Csaba Osztrogonác.
3233 * Scripts/webkitdirs.pm:
3234 (buildQMakeProjects):
3235 Change regex checking for -j* to also check for -*j*
3237 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3239 Remove [NoInterfaceObject] from WorkerGlobalScope
3240 https://bugs.webkit.org/show_bug.cgi?id=118071
3242 Reviewed by Kentaro Hara.
3244 Update bindings test script to pass 2 additional parameters
3245 now needed by the preprocess-idls.pl script.
3247 * Scripts/webkitpy/bindings/main.py:
3248 (BindingsTests.generate_supplemental_dependency):
3249 (BindingsTests.main):
3251 2013-06-27 Xabier Rodriguez Calvar <calvaris@igalia.com>
3253 Fixing some compiler warnings
3254 https://bugs.webkit.org/show_bug.cgi?id=117791
3256 Reviewed by Martin Robinson.
3258 * GNUmakefile.am: Silenced format warning.
3259 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
3260 (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
3261 Solved warning about uninitialized variable.
3263 2013-06-27 Christophe Dumez <ch.dumez@sisa.samsung.com>
3265 Fix bindings tests after r152080
3266 https://bugs.webkit.org/show_bug.cgi?id=118118
3268 Reviewed by Gyuyoung Kim.
3270 r152080 renamed argument to preprocess-idls.pl from --workerContextConstructorsFile
3271 to --workerGlobalScopeConstructorsFile. This patch updates to bindings test script
3274 * Scripts/webkitpy/bindings/main.py:
3275 (BindingsTests.generate_supplemental_dependency):
3276 (BindingsTests.main):
3278 2013-06-26 Carlos Garcia Campos <cargarcia@blackberry.com>
3280 [BlackBerry] Handle testRunner.setCustomPolicyDelegate()
3281 https://bugs.webkit.org/show_bug.cgi?id=117982
3283 Reviewed by Rob Buis.
3285 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3286 (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree): Initialize
3287 m_policyDelegateIsPermissive.
3288 (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
3289 Reset m_policyDelegateIsPermissive.
3290 (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate): Set
3291 m_policyDelegateIsPermissive.
3292 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3293 (BlackBerry::WebKit::DumpRenderTree::policyDelegateEnabled):
3294 Return whether custom policy is enabled.
3295 (BlackBerry::WebKit::DumpRenderTree::policyDelegateIsPermissive):
3296 Return whether custom policy is permissive.
3298 2013-06-26 Anders Carlsson <andersca@apple.com>
3300 Deprecate StringImpl::charactersWithNullTermination
3301 https://bugs.webkit.org/show_bug.cgi?id=118108
3303 Reviewed by Beth Dakin.
3305 Rename calls to charactersWithNullTermination to deprecatedCharactersWithNullTermination.
3307 * DumpRenderTree/win/DumpRenderTree.cpp:
3309 (addFontFallbackIfPresent):
3310 (removeFontFallbackIfPresent):
3312 2013-06-26 Nico Weber <thakis@chromium.org>
3314 Remove detect-mismached-virtual-const.
3315 https://bugs.webkit.org/show_bug.cgi?id=117999
3317 Reviewed by Anders Carlsson.
3319 Clang warns on mismatched virtual const, so there's no need for this
3322 * Scripts/detect-mismatched-virtual-const: Removed.
3324 2013-06-26 Alex Christensen <achristensen@apple.com>
3326 Added a code coverage report.
3327 https://bugs.webkit.org/show_bug.cgi?id=117941
3329 Reviewed by Joseph Pecoraro.
3331 * CodeCoverage: Added.
3332 * CodeCoverage/results-template.html: Added.
3333 * Scripts/generate-coverage-data: Generate and open the new report.
3335 2013-06-25 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
3337 gdb: Remove the webcore.py pretty printer.
3338 https://bugs.webkit.org/show_bug.cgi?id=117992
3340 Reviewed by Jochen Eisinger.
3342 webcore.py has been only a placeholder for backwards compatibility
3343 for almost 3 years. It should be safe enough to remove it now.
3345 * gdb/webcore.py: Removed.
3347 2013-05-26 Peter Gal <galpeter@inf.u-szeged.hu>
3349 Creating cURL watchlist and adding myself to it.
3351 Reviewed by Csaba Osztrogonác.
3353 * Scripts/webkitpy/common/config/watchlist:
3355 2013-06-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
3357 Unreviewed, change my email address for watch list.
3359 * Scripts/webkitpy/common/config/watchlist:
3361 2013-06-25 Byungwoo Lee <bw80.lee@samsung.com>
3363 [EFL] Add a script to install dependencies.
3364 https://bugs.webkit.org/show_bug.cgi?id=117968
3366 Reviewed by Christophe Dumez.
3368 Add a script which installs basic dependencies for building WebKit EFL.
3370 The dependencies are from the current EFLWebKit wiki page.
3371 After this patch is landed, the wiki page will be updated to use
3374 * efl/install-dependencies: Added.
3376 2013-06-24 Dean Jackson <dino@apple.com>
3378 [Mac] Update font used for Chinese in test systems
3379 https://bugs.webkit.org/show_bug.cgi?id=117970
3381 Reviewed by Alexey Proskuryakov.
3383 Add "Songti TC" and "Songti SC" to the list of allowed fonts
3386 * DumpRenderTree/mac/DumpRenderTree.mm:
3387 (allowedFontFamilySet):
3388 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3389 (WTR::allowedFontFamilySet):
3391 2013-06-24 Tim Horton <timothy_horton@apple.com>
3393 Make MiniBrowser paginated mode work with WebKit1
3394 https://bugs.webkit.org/show_bug.cgi?id=117950
3396 Reviewed by Beth Dakin.
3398 * MiniBrowser/mac/WK1BrowserWindowController.m:
3399 (-[WK1BrowserWindowController isPaginated]):
3400 (-[WK1BrowserWindowController togglePaginationMode:]):
3401 Hook up isPaginated and togglePaginationMode just as for WebKit2.
3403 2013-06-24 David Kilzer <ddkilzer@apple.com>
3405 bisect-builds: improve heuristic for choosing the next build after a broken build
3406 <http://webkit.org/b/117918>
3408 Reviewed by Simon Fraser.
3410 * Scripts/bisect-builds: When a build is broken, use a heuristic
3411 that "bisects" the left side or the right side of the remaining
3412 revisions to pick a revision that's sufficiently different from
3413 the revision of the broken build. This heuristic assumes there
3414 is a sequential range of broken builds whenever one broken build
3417 2013-06-24 Chris Rogers <crogers@google.com>
3419 WaveTable name has changed to PeriodicWave
3420 https://bugs.webkit.org/show_bug.cgi?id=117748
3422 Reviewed by Jer Noble.
3424 * Scripts/do-webcore-rename:
3426 2013-06-22 Santosh Mahto <santosh.ma@samsung.com>
3428 [EFL] Add support for MHTML save/load feature to MiniBrowser
3429 https://bugs.webkit.org/show_bug.cgi?id=106620
3431 Reviewed by Christophe Dumez.
3433 Enable CTRL + S as save page in mhtml and CTRL + L to load any page
3436 * MiniBrowser/efl/CMakeLists.txt:
3437 * MiniBrowser/efl/main.c:
3438 (page_contents_callback):
3440 (show_file_entry_dialog): generic function to show file enrty
3443 2013-06-21 Brent Fulgham <bfulgham@apple.com>
3445 [Windows] Unreviewed crash protection for DRT
3447 * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Check for null elements in routines
3448 to avoid crashing during test runs.
3450 2013-06-21 Christophe Dumez <ch.dumez@sisa.samsung.com>
3452 REGRESSION (r150663): Using webkitAudioContext in Inspector makes it undefined everywhere
3453 https://bugs.webkit.org/show_bug.cgi?id=117825
3455 Reviewed by Kentaro Hara.
3457 DumpRenderTreeSupportEfl::setWebAudioEnabled() now requires an additional view argument.
3459 * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3460 (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3461 * DumpRenderTree/efl/TestRunnerEfl.cpp:
3462 (TestRunner::overridePreference):
3464 2013-06-21 Krzysztof Czech <k.czech@samsung.com>
3466 [ATK] Added support for aria-required attribute.
3467 https://bugs.webkit.org/show_bug.cgi?id=117730
3469 Reviewed by Chris Fleizach.
3471 Added support for testing aria-required attribute.
3473 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3474 (AccessibilityUIElement::isRequired):
3475 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3476 (WTR::AccessibilityUIElement::isRequired):
3478 2013-06-20 Ryuan Choi <ryuan.choi@samsung.com>
3480 [CMAKE][EFL] Enable DOM4 Events Constructor
3481 https://bugs.webkit.org/show_bug.cgi?id=117858
3483 Reviewed by Laszlo Gombos.
3485 * Scripts/webkitperl/FeatureList.pm: Enable the feature for the EFL port.
3487 2013-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
3489 [BlackBerry] Handle testRunner.setWillSendRequestReturnsNull() in DRT
3490 https://bugs.webkit.org/show_bug.cgi?id=117827
3492 Reviewed by Rob Buis.
3494 Reset the passed in request if willSendRequestReturnsNull() is
3495 true or willSendRequestReturnsNullOnRedirect() is true and it's a
3498 * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3499 (BlackBerry::WebKit::DumpRenderTree::willSendRequestForFrame):
3500 * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
3502 2013-06-20 Csaba Osztrogonác <ossy@webkit.org>
3504 Commit queue shouldn't reopen unrelated bugs because of flakiness
3505 https://bugs.webkit.org/show_bug.cgi?id=117503
3507 Reviewed by Ryosuke Niwa.
3509 * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3510 (_follow_duplicate_chain):
3511 (_update_bug_for_flaky_test):
3513 2013-06-19 Brent Fulgham <bfulgham@apple.com>
3515 [Windows] AX: Expand notification support.
3516 https://bugs.webkit.org/show_bug.cgi?id=117761
3518 Reviewed by Anders Carlsson.
3520 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3521 (AccessibilityUIElement::isPressActionSupported): Provide implementation.
3522 (AccessibilityUIElement::press): Provide implementation.
3524 2013-06-19 Benjamin Poulain <bpoulain@apple.com>
3526 Use the PlatformEvent timestamp when creating a DOM Event
3527 https://bugs.webkit.org/show_bug.cgi?id=117179
3529 Reviewed by Darin Adler.
3531 * WebKitTestRunner/mac/EventSenderProxy.mm:
3532 (WTR::EventSenderProxy::mouseDown):
3533 (WTR::EventSenderProxy::mouseUp):
3534 (WTR::EventSenderProxy::mouseMoveTo):
3535 (WTR::EventSenderProxy::keyDown):
3537 2013-06-18 Alex Christensen <achristensen@apple.com>
3539 Working on coverage script, added xml to json data extraction script.
3540 https://bugs.webkit.org/show_bug.cgi?id=117648
3542 This is part of a new test code coverage analysis tool. This compiles WebKit to generate
3543 coverage data, runs the tests, and collects all of the data in json format.
3545 Reviewed by Stephanie Lewis.
3547 * Scripts/generate-coverage-data:
3549 (getFileHitsAndBranches):
3552 * Scripts/webkitpy/tool/gcovr: Added.
3554 2013-06-18 Ryuan Choi <ryuan.choi@samsung.com>
3556 Unreviewed build fix after r151699.
3558 * TestWebKitAPI/CMakeLists.txt:
3559 * WebKitTestRunner/CMakeLists.txt:
3560 Added include dir for InjectedBundleHitTestResultMediaType.h and WKBundleHitTestResult.h
3562 2013-06-18 Roger Fong <roger_fong@apple.com>
3564 Replace tools32 folder with tools and update WebKit Windows solution accordingly.
3565 <rdar://problem/14118143>.
3567 Rubberstamped by Brent Fulgham.
3569 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
3570 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props:
3571 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
3572 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
3573 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props:
3574 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props:
3575 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
3576 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props:
3577 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
3578 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
3579 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
3580 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props:
3581 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props:
3582 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
3583 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props:
3584 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props:
3585 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
3586 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props:
3587 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
3588 * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props:
3589 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
3590 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props:
3591 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props:
3592 * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
3593 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3594 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebug.props:
3595 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
3596 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props:
3597 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
3598 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
3599 * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
3600 * WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props:
3601 * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
3602 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props:
3603 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props:
3604 * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
3605 * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props:
3606 * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
3607 * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
3608 * win/record-memory/record-memory.vcxproj:
3609 * win/record-memory/record-memoryDebug.props:
3610 * win/record-memory/record-memoryDebugWinCairo.props:
3611 * win/record-memory/record-memoryProduction.props:
3612 * win/record-memory/record-memoryRelease.props:
3613 * win/record-memory/record-memoryReleaseWinCairo.props:
3615 2013-06-17 Kangil Han <kangil.han@samsung.com>
3617 Unreviewed. Add my email to a DOM watchlist.
3619 * Scripts/webkitpy/common/config/watchlist:
3621 2013-06-17 Zan Dobersek <zdobersek@igalia.com>
3623 Unreviewed GTK gardening.
3625 * Scripts/run-gtk-tests:
3626 (TestRunner): Skip three WebKit2APITests suites that are currently timing out.
3628 2013-06-15 Bruno de Oliveira Abinader <brunoabinader@gmail.com>
3630 Unreviewed. Reorder my email addresses.
3631 https://bugs.webkit.org/show_bug.cgi?id=100122
3633 * Scripts/webkitpy/common/config/contributors.json:
3635 2013-06-14 Enrica Casucci <enrica@apple.com>
3637 WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.
3638 https://bugs.webkit.org/show_bug.cgi?id=117647
3639 <rdar://problem/13881024>
3641 Reviewed by Darin Adler.
3643 The test now uses content with a selection and tests both
3644 forwards and backward find as well as the case of a find
3645 that has no matches after the user selection.
3647 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3648 * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
3649 (TestWebKitAPI::didFindStringMatches):
3650 * TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
3652 2013-06-14 Tor Arne Vestbø <tor.arne.vestbo@digia.com>
3654 Remove myself from Qt build system watchlist
3656 Reviewed by Simon Hausmann.
3658 * Scripts/webkitpy/common/config/watchlist:
3660 2013-06-13 Michael Brüning <michael.bruning@digia.com>
3662 [Qt][Mac] Disable QTKit video on OS X.
3663 https://bugs.webkit.org/show_bug.cgi?id=117591
3665 Reviewed by Tor Arne Vestbø.
3667 Deployment of Qt binaries to different Mac OS X
3668 platform version makes it impossible to link against
3669 the correct version of the WebKitSystemInterface library,
3670 so we need to disable QTKit for media elements.
3672 * qmake/mkspecs/features/features.prf:
3674 2013-06-13 Michał Pakuła vel Rutka <m.pakula@samsung.com>
3676 [EFL][WK2] Wrong context menu and popup menu positions when scroll is applied
3677 https://bugs.webkit.org/show_bug.cgi?id=116610
3679 Reviewed by Noam Rosenthal.
3681 Remove unnecessary code adjusting context menu position to webview position.
3682 Now position is calculcated in EwkView.
3684 * MiniBrowser/efl/main.c:
3685 (on_context_menu_show):
3687 2013-06-12 Roger Fong <roger_fong@apple.com>
3689 Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.
3691 * Scripts/webkitpy/common/config/ews.json:
3693 2013-06-12 Eduardo Lima Mitev <elima@igalia.com>
3695 [atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree
3696 https://bugs.webkit.org/show_bug.cgi?id=115647
3698 Reviewed by Martin Robinson.
3700 Locale resolution is moved to WebKitAccessibleWrapperAtk using
3701 AtkObject::get_object_locale() API. Now, implementation of
3702 AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
3703 be leveraged to get_object_locale() of AtkObject.
3705 Apart from improving encapsulation, this avoids calling deprecated get_document_locale()
3708 No new functionality, no new tests.
3710 * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3711 (AccessibilityUIElement::language): Leverage locale resolution to
3712 AtkObject::get_object_locale().
3713 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3714 (WTR::AccessibilityUIElement::language): Leverage locale resolution to
3715 AtkObject::get_object_locale().
3717 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
3719 Remove last bits of GYP from build-webkit and update-webkit scripts
3720 https://bugs.webkit.org/show_bug.cgi?id=117557
3722 Reviewed by Ryosuke Niwa.
3724 * Scripts/build-webkit:
3725 * Scripts/update-webkit:
3727 2013-06-12 Hugo Parente Lima <hugo.lima@openbossa.org>
3729 Remove forgotten unused Tools/Script/make-gypi script
3730 https://bugs.webkit.org/show_bug.cgi?id=117558
3732 Reviewed by Ryosuke Niwa.
3734 This script isn't used since the GYP removal from WebKit.
3736 * Scripts/make-gypi: Removed.
3738 2013-06-12 Andres Gomez <agomez@igalia.com>
3740 [GTK] MiniBrowser to automatically download "non-showable" documents when left click in link
3741 https://bugs.webkit.org/show_bug.cgi?id=117533
3743 Reviewed by Carlos Garcia Campos.
3745 MiniBrowser now starts automatically the download of the documents
3746 that cannot be shown just by WebKit itself on link left clicking.
3748 * MiniBrowser/gtk/BrowserWindow.c:
3749 (webViewDecidePolicy): handled the
3750 WEBKIT_POLICY_DECISION_TYPE_RESPONSE decision type too.
3752 2013-06-12 Zan Dobersek <zdobersek@igalia.com>
3754 [GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them
3755 https://bugs.webkit.org/show_bug.cgi?id=116723
3757 Reviewed by Carlos Garcia Campos.
3759 * TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,
3760 remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
3761 and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
3762 not expensive and produces a working archive without problems even on incremental builds.
3764 2013-06-11 Santosh Mahto <santosh.ma@samsung.com>
3766 [EFL] Window resize should close the popupmenu
3767 https://bugs.webkit.org/show_bug.cgi?id=117391
3769 Reviewed by Christophe Dumez.
3771 Added the code to close the popup when main window is resized.
3773 * MiniBrowser/efl/main.c:
3776 2013-06-11 Alex Christensen <achristensen@apple.com>
3778 Removed old broken code coverage tool.
3779 https://bugs.webkit.org/show_bug.cgi?id=117520
3781 Reviewed by Sam Weinig.
3783 * CodeCoverage: Removed.
3784 * CodeCoverage/README: Removed.
3785 * CodeCoverage/amber.png: Removed.
3786 * CodeCoverage/cov.py: Removed.
3787 * CodeCoverage/emerald.png: Removed.
3788 * CodeCoverage/gcov.css: Removed.
3789 * CodeCoverage/glass.png: Removed.
3790 * CodeCoverage/regenerate-coverage-display: Removed.
3791 * CodeCoverage/ruby.png: Removed.
3792 * CodeCoverage/run-generate-coverage-data: Removed.
3793 * CodeCoverage/snow.png: Removed.
3795 2013-06-11 Timothy Hatcher <timothy@apple.com>
3797 Have build-webkit build the WebInspectorUI project.
3799 * Scripts/build-webkit:
3801 2013-06-11 Ryosuke Niwa <rniwa@webkit.org>
3803 Add an option to run-webkit-tests to skip java dependency check
3804 https://bugs.webkit.org/show_bug.cgi?id=117516
3806 Reviewed by Andreas Kling.
3808 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3810 * Scripts/webkitpy/port/mac.py:
3811 (MacPort._check_port_build):
3813 2013-06-11 Alex Christensen <achristensen@apple.com>
3815 https://bugs.webkit.org/show_bug.cgi?id=117514
3816 Removed extra Xcode code coverage flags.
3818 Reviewed by Sam Weinig.
3820 * Scripts/webkitdirs.pm:
3821 (XcodeCoverageSupportOptions):
3823 2013-06-11 Brent Fulgham <bfulgham@apple.com>
3825 [Windows] Implement 'attributeValue' accessor to support testing
3826 https://bugs.webkit.org/show_bug.cgi?id=117513
3828 Reviewed by Anders Carlsson.
3830 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3831 (comparableObject): Move earlier in file.
3832 (findAccessibleObjectById): New implemenation.
3833 (AccessibilityController::accessibleElementById): New implementation.
3835 2013-06-11 Csaba Osztrogonác <ossy@webkit.org>
3837 Make WTR use its own temporary directory for application cache
3838 https://bugs.webkit.org/show_bug.cgi?id=117143
3840 Reviewed by Alexey Proskuryakov.
3842 * WebKitTestRunner/TestController.cpp:
3843 (WTR::TestController::initialize):
3845 2013-06-10 Alexey Proskuryakov <ap@apple.com>
3847 https://bugs.webkit.org/show_bug.cgi?id=117449
3848 Remove dead code for storing fonts in __DATA section
3850 Reviewed by Dan Bernstein.
3852 * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
3853 Don't copy font resources to __DATA, as we don't have any code that reads them
3854 from there (previously removed due to being under "defined(BUILDING_ON_LEOPARD)").
3856 * DumpRenderTree/mac/DumpRenderTree.mm: (activateTestingFonts):
3857 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm: (WTR::activateFonts):
3858 Removed comments suggesting that we want to restore the old solution.
3860 2013-06-10 Bear Travis <betravis@adobe.com>
3862 [CSS Shapes][CSS Exclusions] Split CSS Exclusions and CSS Shapes code
3863 https://bugs.webkit.org/show_bug.cgi?id=117162
3865 Reviewed by Alexandru Chiculita.
3867 Adding the WebCore/rendering/shapes directory to the include list.
3869 * DumpRenderTree/efl/CMakeLists.txt:
3871 2013-06-09 Brent Fulgham <bfulgham@apple.com>
3873 [Windows] Unreviewed test correction: Prevent DumpRenderTree crashes
3874 * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3875 (AccessibilityUIElement::role): Prevent crashes when m_element is null. This
3876 happends in some of the 'accessibility' test cases.
3878 2013-06-08 peavo@outlook.com <peavo@outlook.com>
3880 [WinCairo] TestWebKitAPI fails to link.
3881 https://bugs.webkit.org/show_bug.cgi?id=117345
3883 Reviewed by Brent Fulgham.
3885 Need to link with WTF.lib.
3887 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Link with WTF.lib.
3889 2013-06-07 Roger Fong <roger_fong@apple.com>
3891 Get rid of not very helpful test that fails only on some machines because xcrun is not installed.
3893 Rubberstamped by Ryousuke Niwa.
3895 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3896 (RunTest.test_build_check):
3898 2013-06-07 Hugo Parente Lima <hugo.lima@openbossa.org>
3900 [Qt] Remove Qt bits from Scripts/webkitperl/FeatureList.pm
3901 https://bugs.webkit.org/show_bug.cgi?id=117315
3903 Reviewed by Benjamin Poulain.
3905 Qt doesn't use the default values specified on FeatureList since r44681,
3906 this patch just remove a bit of noise.
3908 * Scripts/webkitperl/FeatureList.pm:
3910 2013-06-07 Jungsik Tae <davidtlay88@gmail.com>
3912 [EFL] Implement colorpicker for HTML5 input type color on Minibrowser
3913 https://bugs.webkit.org/show_bug.cgi?id=115890
3915 Reviewed by Christophe Dumez.
3917 When user clicks HTML5 input type color,
3918 color selector window is created on browser object by using elm_colorchooser_add().
3919 It can listen a signal dismissing colorpicker by calling the ewk_color_picker_color_set().
3920 The evas_object_color_set() sets a color value returning to browser.
3922 * MiniBrowser/efl/main.c:
3923 (window_free): When we delete parent window, deleting the colorpicker object.
3924 (on_color_changed): Change color of rectangle to show color selected by user.
3925 (on_color_item_selected): Change color of rectangle when clicked color palettes offered by elm_color_chooser().
3926 (on_color_picker_ok_clicked): Call on_colorpicker_dismiss() and set the color.
3927 (on_color_picker_cancel_clicked): Get a preexisting color and call ewk_color_picker_color_set().
3928 (on_color_picker_dismiss): Delete colorpicker object.
3929 (on_color_picker_request): Create colorpicker window object.
3932 2013-06-06 Yuki Sekiguchi <yuki.sekiguchi@access-company.com>
3934 svn-apply cannot apply patches which is generated by git to files that contain space characters in their path
3935 https://bugs.webkit.org/show_bug.cgi?id=111066
3937 Reviewed by Daniel Bates.
3939 Fixes an issue where parseGitDiffHeader() would extract the wrong substring of the diff --git line as the target file path when the source file path contains a space character.
3941 ParseGitDiffHeader() should support the path which line has space characters.
3942 To support this, I changed parsing algorithm like the following:
3943 - When the diff have prefix, we consider next characters after "b/" as part of a file path.
3944 - When the diff have no prefix, we assume that both path have same directory prefix, and we split the diff line using the prefix.
3946 We only support --src-prefix and --dst-prefix don't contain a non-word character (\W) and end with '/' because we cannot distinguish the prefix from directory path.
3948 If the path has a tab, the patch(1) command thinks file path is characters before the tab.
3949 I added a dummy tab and revision when we convert git diff to svn diff.
3951 * Scripts/VCSUtils.pm:
3952 (parseGitDiffHeader):
3953 * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Update expectations for dummy revision.
3954 * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Ditto.
3955 * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl: Ditto.
3956 - Added test case for files which have space in their path and --src-prefix and --dst-prefix option.
3958 2013-06-06 Simon Fraser <simon.fraser@apple.com>
3960 Add a menu item to MiniBrowser to toggle Transparent windows
3961 https://bugs.webkit.org/show_bug.cgi?id=117316
3963 Reviewed by Anders Carlsson.
3965 Add a menu item that toggles "Transparent window" mode, which is exposed
3966 via private WebKit API and WebKit2 API.
3968 * MiniBrowser/mac/BrowserWindowController.h:
3969 * MiniBrowser/mac/MainMenu.xib:
3970 * MiniBrowser/mac/MiniBrowser_Prefix.pch:
3971 * MiniBrowser/mac/WK1BrowserWindowController.m:
3972 (-[WK1BrowserWindowController validateMenuItem:]):
3973 (-[WK1BrowserWindowController toggleTransparentWindow:]):
3974 * MiniBrowser/mac/WK2BrowserWindowController.m:
3975 (-[WK2BrowserWindowController validateMenuItem:]):
3976 (-[WK2BrowserWindowController toggleTransparentWindow:]):
3977 (-[WK2BrowserWindowController dumpSourceToConsole:]): Fix a crash that was seen
3980 2013-06-06 Roger Fong <roger_fong@apple.com>
3982 Stop copying AAS binaries into build folder.
3983 https://bugs.webkit.org/show_bug.cgi?id=117319.
3985 Rubberstamped by Darin Adler.
3987 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd:
3989 2013-06-06 Hugo Parente Lima <hugo.lima@openbossa.org>
3991 Aligning build-webkit command line switch names to the WebKit flag names
3992 https://bugs.webkit.org/show_bug.cgi?id=117254
3994 Reviewed by Laszlo Gombos.
3996 * Scripts/webkitperl/FeatureList.pm: Rename some command line switches.
3998 2013-06-06 Chris Fleizach <cfleizach@apple.com>
4000 AX: iOS ignores ARIA progressbar elements
4001 https://bugs.webkit.org/show_bug.cgi?id=116727
4003 Reviewed by David Kilzer.
4005 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4006 (AccessibilityUIElement::minValue):
4007 (AccessibilityUIElement::maxValue):
4009 2013-06-06 peavo@outlook.com <peavo@outlook.com>
4011 [WinCairo] Fix build-webkit to build WinCairo under VS2010.
4012 https://bugs.webkit.org/show_bug.cgi?id=117255
4014 Reviewed by Daniel Bates.
4016 Need to update configuration names according to solution file.
4018 * Scripts/webkitdirs.pm:
4019 (determineConfiguration):
4020 (determinePassedConfiguration):
4022 2013-06-06 Ryosuke Niwa <rniwa@webkit.org>
4024 Remove run-performance-tests
4025 https://bugs.webkit.org/show_bug.cgi?id=117285
4027 Reviewed by Andreas Kling.
4029 Remove the script since it's not used anywhere.
4031 * BuildSlaveSupport/run-performance-tests: Removed.
4033 2013-06-05 Bear Travis <betravis@adobe.com>
4035 [CSS Exclusions][CSS Shapes] Split CSS Exclusions & Shapes compile & runtime flags
4036 https://bugs.webkit.org/show_bug.cgi?id=117172
4038 Reviewed by Alexandru Chiculita.
4040 Adding the CSS_SHAPES compile flag.
4042 * Scripts/webkitperl/FeatureList.pm:
4043 * qmake/mkspecs/features/features.pri:
4045 2013-06-05 Brent Fulgham <bfulgham@apple.com>
4047 [Windows] Unreviewed build fix. Add CRLF eol-style for DOS shell scripts; if they accidentally change
4048 to UNIX-style they will not execute properly.
4050 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added property svn:eol-style.
4051 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added property svn:eol-style.
4053 2013-06-05 Roger Fong <roger_fong@apple.com>
4055 Unreviewed build fix. Don't pass in --use-remote-links argument on Windows now that we use NRWT.
4057 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4058 (RunWebKitTests.start):
4060 2013-06-05 Brent Fulgham <bfulgham@apple.com>
4062 [Windows] Switch to NRWT
4063 https://bugs.webkit.org/show_bug.cgi?id=117200
4065 Reviewed by Anders Carlsson.
4067 * Scripts/run-webkit-tests:
4068 (useNewRunWebKitTests): No longer use old-run-webkit-tests for Windows port.
4070 2013-06-05 Dominik Röttsches <dominik.rottsches@intel.com>
4072 Unreviewed name fix after r150662
4074 My firstname got duplicated when fixing bug 116737.
4076 * Scripts/webkitpy/common/config/contributors.json:
4078 2013-06-05 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
4080 Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
4081 https://bugs.webkit.org/show_bug.cgi?id=117244
4083 Reviewed by Daniel Bates.
4085 Fixed a regression introduced by r151196: not only does webkit.org
4086 still mention WEBKITOUTPUTDIR instead of WEBKIT_OUTPUTDIR, but the
4087 infrastructure used by ports such as GTK+ and EFL also use on it for
4088 things such as jhbuild.
4090 While everything is not fully transitioned to WEBKIT_OUTPUTDIR, read
4091 both environment variables.
4093 * Scripts/webkitdirs.pm:
4094 (determineBaseProductDir):
4096 2013-06-05 Wojciech Bielawski <w.bielawski@samsung.com>
4098 [GTK] Forwarding headers not generated for incremental build
4099 https://bugs.webkit.org/show_bug.cgi?id=117198
4101 Reviewed by Carlos Garcia Campos.
4103 * WebKitTestRunner/GNUmakefile.am: libTestRunnerInjectedBundle added to dependencies.
4105 2013-06-05 Andras Becsi <andras.becsi@digia.com>
4107 [Qt][WK2] Fix layout testing with Qt 5.1
4108 https://bugs.webkit.org/show_bug.cgi?id=117203
4110 Reviewed by Jocelyn Turcotte.
4112 With Qt 5.1 synchronous requests via QNetworkAccessManager do not
4113 go into loading state but directly call handler functions for
4114 finished state instead of relying on a connection.
4115 Our wrapper QQuickView uses a data URI scheme to create the root
4116 item for testing which results in a synchronous request when loading
4117 the QML data, therefore the state of the QQuickWindow immediately
4119 Since the final initialization of the root item depended on the
4120 emission of QQuickView::statusChanged(QQuickView::Ready) we ended
4121 up with a partially initialized wrapper window, thus most of our
4122 layout tests were failing.
4123 For compatibility with pre-5.1 Qt versions keep the old behaviour
4124 in case the WrapperWindow is not ready in the constructor yet.
4126 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4127 (WTR::WrapperWindow::WrapperWindow):
4128 * TestWebKitAPI/qt/PlatformWebViewQt.cpp:
4129 (TestWebKitAPI::WrapperWindow::WrapperWindow):
4131 2013-06-05 Dariusz Frankiewicz <d.frankiewic@samsung.com>
4133 Bad value in tests counter at new-run-webkit-tests
4134 in --debug-rwt-logging mode
4135 https://bugs.webkit.org/show_bug.cgi?id=116858
4137 Reviewed by Dirk Pranke.
4139 Fix by moving counter incrementation, from after printing line,
4140 to before printing. Also changed variable name.
4142 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4143 (LayoutTestRunner.run_tests):
4144 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
4146 * Scripts/webkitpy/layout_tests/views/printing.py:
4148 (Printer._test_status_line):
4149 (Printer.print_started_test):
4150 (Printer.print_finished_test):
4151 * Scripts/webkitpy/test/printer.py:
4153 (Printer.print_finished_test):
4154 (Printer._test_line):
4155 (Printer.print_result):
4157 2013-06-05 Zan Dobersek <zdobersek@igalia.com>
4159 Move MemoryInfo under window.internals
4160 https://bugs.webkit.org/show_bug.cgi?id=117197
4162 Reviewed by Ryosuke Niwa.
4164 * GNUmakefile.am: Add the testing/MemoryInfo.(h|idl) files and the generated targets to
4166 * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: List the
4167 testing/MemoryInfo.idl file instead of page/MemoryInfo.idl.
4169 2013-06-03 Roger Fong <roger_fong@apple.com>
4171 Remove uses of VS2005 scripts, executables and associated environment variables from scripts.
4172 <rdar://problem/14042021>.
4174 Reviewed by Brent Fulgham.
4176 * Scripts/build-api-tests:
4177 * Scripts/build-dumprendertree:
4178 * Scripts/build-webkit:
4179 * Scripts/update-webkit-dependency:
4180 * Scripts/update-webkit-support-libs:
4181 * Scripts/webkitdirs.pm:
4182 (determineBaseProductDir):
4186 2013-06-04 Brent Fulgham <bfulgham@apple.com>
4188 [Windows] NRWT is not putting crash logs in proper place (corrections)
4189 https://bugs.webkit.org/show_bug.cgi?id=117212
4191 Reviewed by Dirk Pranke.
4193 * Scripts/webkitpy/common/system/crashlogs.py:
4194 (CrashLogs.__init__): Accept a result directory argument in constructor.
4195 (CrashLogs.find_newest_log): Don't require 'port' argument anymore.
4196 (CrashLogs._find_newest_log_win): No longer use 'port' argument.
4197 * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4198 (CrashLogsTest.test_find_log_win): Simplify test.
4199 * Scripts/webkitpy/common/system/executive.py:
4200 (Executive.running_pids): Handle "win32" case separately from "cygwin" case.
4201 * Scripts/webkitpy/port/win.py:
4202 (WinPort._get_crash_log): No longer require 'port' argument.
4204 2013-06-04 Ryosuke Niwa <rniwa@webkit.org>
4206 Build fix after r150592. We need to disable \2 shouldn't be treated as an escape character.
4208 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4210 2013-06-04 Greg Hughes <ghughes@apple.com>
4212 Add "VisibleOnly" key to search predicate
4213 https://bugs.webkit.org/show_bug.cgi?id=115491
4215 Reviewed by Chris Fleizach.
4217 Added support for accessibility clients to use the search predicate to find only visible elements
4219 * DumpRenderTree/AccessibilityUIElement.cpp:
4220 (uiElementForSearchPredicateCallback):
4221 * DumpRenderTree/AccessibilityUIElement.h:
4222 (AccessibilityUIElement):
4223 * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
4224 (AccessibilityUIElement::uiElementForSearchPredicate):
4225 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4226 (AccessibilityUIElement::uiElementForSearchPredicate):
4227 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4228 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4229 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4230 (AccessibilityUIElement):
4231 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4232 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4233 (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
4235 2013-06-04 Brent Fulgham <bfulgham@apple.com>
4237 [Windows] Unreviewed build fix. The last check-in lost CR/LF endings on the batch file,
4238 causing build failure.
4240 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Revert to
4241 DOS-style CR/LF endings.
4243 2013-06-04 Brent Fulgham <bfulgham@apple.com>
4245 [Windows] Unreviewed test correction.
4247 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Also copy the
4248 QuartzCore dll's, which are needed by TestWebKitAPI.
4249 * TestWebKitAPI/win/main.cpp: Declare proper manfifest dependencies to ensure TestWebKitAPI built
4250 with VS2010 will run when linked against VS2005 support libraries.
4252 2013-06-04 Christophe Dumez <ch.dumez@sisa.samsung.com>
4254 Automatically generate WorkerContext constructor attributes
4255 https://bugs.webkit.org/show_bug.cgi?id=117183
4257 Reviewed by Kentaro Hara.
4259 Pass new --workerContextConstructorsFile to preprocess-idl.pl for bindings
4262 * Scripts/webkitpy/bindings/main.py:
4263 (BindingsTests.generate_supplemental_dependency):
4264 (BindingsTests.main):
4266 2013-06-04 Ryuan Choi <ryuan.choi@samsung.com>
4268 [EFL] File dialog of MiniBrowser have broken background.
4269 https://bugs.webkit.org/show_bug.cgi?id=117189
4271 Reviewed by Christophe Dumez.
4273 * MiniBrowser/efl/main.c:
4274 (on_file_chooser_request): Added elm_bg for elm_win of file chooser.
4276 2013-06-04 Christophe Dumez <ch.dumez@sisa.samsung.com>
4278 [WKTR][WTK] Undefined symbols in libTestRunnerInjectedBundle.so after r151124
4279 https://bugs.webkit.org/show_bug.cgi?id=117184
4281 Reviewed by Gyuyoung Kim.
4283 Add ATK stubs for mathPostscriptsDescription() and mathPrescriptsDescription() so
4284 that we don't have undefined symbols in libTestRunnerInjectedBundle.so.
4286 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4287 (WTR::AccessibilityUIElement::mathPostscriptsDescription):
4288 (WTR::AccessibilityUIElement::mathPrescriptsDescription):
4290 2013-06-03 Simon Pena <simon.pena@samsung.com>
4292 validate-committer-lists script is now outdated and does not work
4293 https://bugs.webkit.org/show_bug.cgi?id=115860
4295 Reviewed by Brent Fulgham.
4297 The script validate-committer-lists was outdated, still using the deprecated log
4298 system and having the old addresses for the mailing lists, as well as still referring
4299 to committers.py, after this was renamed to contributors.json. This patch fixes that
4300 so it can be used again.
4302 * Scripts/validate-committer-lists: Replace calls to log and error with the
4303 new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
4304 to committers.py, which should be contributors.json.
4305 (CommitterListFromMailingList):
4306 (CommitterListFromMailingList.check_for_emails_missing_from_list):
4307 (CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
4308 (CommitterListFromGit._fill_in_emails_for_old_logins):
4309 (CommitterListFromGit.print_committers_missing_from_committer_list):
4311 2013-06-03 Dirk Pranke <dpranke@chromium.org>
4313 add a script to dump the tests run most recently by a given worker
4314 https://bugs.webkit.org/show_bug.cgi?id=116571
4316 Reviewed by Brent Fulgham.
4318 The tests_run*.txt results files in layout-test-results/ were removed
4319 in r137356, in favor of collecting more data about how the tests were
4320 run and compressing it and storing it in stats.json. However, it was
4321 nice to just be able to look at a flat text file.
4323 This script will extract the tests run by a given worker from a
4324 given stats.json file, and should help to address that.
4326 * Scripts/dump-webkit-tests-run: Added.
4328 (convert_trie_to_flat_paths):
4330 2013-06-03 Brent Fulgham <bfulgham@apple.com>
4332 [Windows] NRWT is not putting crash logs in proper place
4333 https://bugs.webkit.org/show_bug.cgi?id=117098
4335 Reviewed by Ryosuke Niwa.
4337 Provide windows-specific overloads for various Port features needed to create and capture
4338 crash logs. This change makes it possible to view crash logs (when created) as part of the
4339 summary report at the end of the NRWT run.