2011-02-08 Hayato Ito <hayato@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-02-08  Hayato Ito  <hayato@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         [NRWT] Pull up rebaseline code from compare_output() function defined
6         in text_diff.py and image_diff.py into a SingleTestRunner.
7
8         This patch is a first step for eliminating test_type/* classes.
9
10         https://bugs.webkit.org/show_bug.cgi?id=53071
11
12         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
13         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
14         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
15         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
16
17 2011-02-07  Ojan Vafai  <ojan@chromium.org>
18
19         Reviewed by Mihai Parparita.
20
21         stop generating results.json files
22         https://bugs.webkit.org/show_bug.cgi?id=53977
23
24         We've only used incremental_results.json for a while now
25         and there are plans to start generating a results.json file that matches
26         the format of unexpected_results.json.
27
28         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
29         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
30         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
31         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
32         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
33
34 2011-02-08  Sailesh Agrawal  <sail@chromium.org>
35
36         Reviewed by Kenneth Russell.
37
38         Invalidate rect doesn't work for windowless plugins on Chromium
39         https://bugs.webkit.org/show_bug.cgi?id=53117
40
41         Added two new utility methods.
42         - layoutTestController.displayInvalidatedRegion() does a paint of any area that has been invalidated. This is different from layoutTestController.display() which explicitly invalidates the entire page then paints.
43         - plugin.invalidateRect(left, top, right, bottom) - invalidates the given rect
44         This is used to test that invalidating a rect correctly causes a repaint of the plugin.
45
46         * DumpRenderTree/LayoutTestController.cpp:
47         (displayInvalidatedRegionCallback):
48         (LayoutTestController::staticFunctions):
49         * DumpRenderTree/LayoutTestController.h:
50         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
51         (invalidateRect):
52         (pluginInvoke):
53         * DumpRenderTree/chromium/LayoutTestController.cpp:
54         (LayoutTestController::LayoutTestController):
55         (LayoutTestController::displayInvalidatedRegion):
56         * DumpRenderTree/chromium/LayoutTestController.h:
57         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
58
59 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
60
61         Reviewed by Tony Chang.
62
63         new-run-webkit-tests: move the logic that starts and stops the
64         servers from dump_render_tree_thread into single_test_runner
65         so that we can reuse it in the new multiprocessing worker class
66         as well.
67
68         https://bugs.webkit.org/show_bug.cgi?id=53840
69
70         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
71         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
72  
73 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
74
75         Reviewed by Mihai Parparita.
76
77         new-run-webkit-tests: split out thread stack logging code into a sharable module
78
79         This patch splits out the code used to find and log thread
80         stacks from NRWT-specific packages to something generic and
81         shareable by other python modules. It will be shared in the near
82         future by the manager_worker_broker module, for example.
83
84         https://bugs.webkit.org/show_bug.cgi?id=53656
85
86         * Scripts/webkitpy/common/system/stack_utils.py: Added.
87         * Scripts/webkitpy/common/system/stack_utils_unittest.py: Added.
88         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
89         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
90
91 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
92
93         Reviewed by Tony Chang.
94
95         new-run-webkit-tests: move a bunch of testing logic out of
96         dump_render_tree_thread and into single_test_runner so that we
97         will be able to reuse it in the new multiprocessing worker class as well.
98
99         https://bugs.webkit.org/show_bug.cgi?id=53838
100
101         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
102         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
103
104         
105 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
106
107         Reviewed by Ojan Vafai.
108
109         new-run-webkit-tests: remove no longer needed WatchableThread
110         class.
111
112         https://bugs.webkit.org/show_bug.cgi?id=53839
113
114         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
115
116 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
117
118         Reviewed by Tony Chang.
119
120         new-run-webkit-tests: add stubs for the Manager objects that
121         will abstract the concurrency implementation (inline / threads /
122         processes). These classes do nothing yet and are not wired up to
123         anything.
124
125         https://bugs.webkit.org/show_bug.cgi?id=53477
126
127         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Added.
128         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Added.
129
130 2011-02-08  Dirk Pranke  <dpranke@chromium.org>
131
132         Reviewed by Tony Chang.
133
134         new-run-webkit-tests: add simplified message broker for new-style
135         messaging. This change adds a very simple message broker that
136         will be used to shuttle messages between the TestRunner2 manager
137         thread and the Worker threads. For now the class is not used by
138         anything, but the eventual usage can be seen in the patches
139         attached to bug 49566.
140
141         https://bugs.webkit.org/show_bug.cgi?id=53158
142
143         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Added.
144         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Added.
145
146 2011-02-08  Adam Barth  <abarth@webkit.org>
147
148         Reviewed by Dimitri Glazkov.
149
150         chromium-win builder shouldn't run python or perl tests
151         https://bugs.webkit.org/show_bug.cgi?id=54032
152
153         These tests don't pass on this builder because the builder isn't
154         running in cygwin.  There isn't really any point in running them and
155         making the bot red forever.
156
157         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
158
159 2011-02-08  Brady Eidson  <beidson@apple.com>
160
161         Reviewed by Darin Adler.
162
163         <rdar://problem/8972913> and https://bugs.webkit.org/show_bug.cgi?id=54036
164         didChangeBackForwardList should include some context about what changed
165
166         * MiniBrowser/mac/BrowserWindowController.m:
167         (didChangeBackForwardList):
168
169 2011-02-08  Sam Weinig  <sam@webkit.org>
170
171         Reviewed by Anders Carlsson.
172
173         WK2: Add ability to pass context to policy delegate methods
174         https://bugs.webkit.org/show_bug.cgi?id=54031
175
176         * MiniBrowser/mac/BrowserWindowController.m:
177         (decidePolicyForNavigationAction):
178         (decidePolicyForNewWindowAction):
179         (decidePolicyForMIMEType):
180         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
181         (TestWebKitAPI::decidePolicyForNavigationAction):
182         (TestWebKitAPI::decidePolicyForNewWindowAction):
183         (TestWebKitAPI::decidePolicyForMIMEType):
184         Update policy client for new API.
185
186 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
187
188         Reviewed by Xan Lopez.
189
190         [GTK] DRT needs an implementation of LayoutTestController.setIconDatabaseEnabled
191         https://bugs.webkit.org/show_bug.cgi?id=54033
192
193         Add an implementation of LayoutTestController.setIconDatabaseEnabled that just
194         call DumpRenderTreeSupportGtk. Turn off the icon database between tests.
195
196         * DumpRenderTree/gtk/DumpRenderTree.cpp:
197         (resetDefaultsToConsistentValues): Turn off the icon database.
198         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
199         (LayoutTestController::setIconDatabaseEnabled): Call the appropriate DumpRenderTreeSupportGtk
200         method.
201
202 2011-02-08  Kundu Suchismita  <suchi.kundu@nokia.com>
203
204         Reviewed by Laszlo Gombos.
205
206         Local Storage settings can be enable/disable from "Develop" menu
207         https://bugs.webkit.org/show_bug.cgi?id=52296
208
209         * QtTestBrowser/launcherwindow.cpp:
210         (LauncherWindow::createChrome):
211         (LauncherWindow::toggleLocalStorage):
212         (LauncherWindow::toggleOfflineStorageDatabase):
213         (LauncherWindow::toggleOfflineWebApplicationCache):
214         (LauncherWindow::setOfflineStorageDefaultQuota):
215         * QtTestBrowser/launcherwindow.h:
216         (WindowOptions::WindowOptions):
217         * QtTestBrowser/main.cpp:
218         (LauncherApplication::handleUserOptions):
219
220 2011-02-08  Martin Robinson  <mrobinson@igalia.com>
221
222         Reviewed by Eric Seidel.
223
224         [GTK] EventSender.keyDown does not support non-array modifier arguments
225         https://bugs.webkit.org/show_bug.cgi?id=53962
226
227         Support handling either an array or a string for the modifier argument
228         to EventSender.keyDown.
229
230         * DumpRenderTree/gtk/EventSender.cpp:
231         (gdkModifierFromJSValue): Added this helper which factors out the
232         string comparison bits.
233         (gdkModifersFromJSValue): Test up front whether the value is a string,
234         to handle it specially.
235
236 2011-02-08  Benjamin Poulain  <ikipou@gmail.com>
237
238         Reviewed by Csaba Osztrogonác.
239
240         openDatabaseSync() stop responding after too many call
241         https://bugs.webkit.org/show_bug.cgi?id=53945
242
243         Reset the database quota to a known state between each test.
244
245         Define a quota for the known origins at each test run and delete
246         all the databases.
247         This way, the database related test do not depend on previous
248         allocations.
249
250         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
251         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
252         (WebCore::DumpRenderTree::dumpDatabaseQuota):
253         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
254         (LayoutTestController::reset):
255
256 2011-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
257
258         Reviewed by Martin Robinson.
259
260         [GTK] DRT's TextInputController is unimplemented on GTK
261         https://bugs.webkit.org/show_bug.cgi?id=52997
262
263         Initial implementation of TextInputController for GTK port.
264
265         * DumpRenderTree/gtk/DumpRenderTree.cpp:
266         (webViewWindowObjectCleared):
267         * DumpRenderTree/gtk/TextInputController.cpp: Added.
268         (setMarkedTextCallback):
269         (insertTextCallback):
270         (unmarkTextCallback):
271         (firstRectForCharacterRangeCallback):
272         (selectedRangeCallback):
273         (getClass):
274         (makeTextInputController):
275         * DumpRenderTree/gtk/TextInputController.h: Added.
276         * GNUmakefile.am:
277
278 2011-02-07  Tony Chang  <tony@chromium.org>
279
280         Reviewed by Adam Barth.
281
282         clean up python imports
283         https://bugs.webkit.org/show_bug.cgi?id=53966
284
285         Convert "import A.B.C.D as D" to "from A.B.C import D" and
286         make some imports absolute as required by PEP-8
287
288         * Scripts/webkitpy/common/checkout/scm.py:
289         * Scripts/webkitpy/common/net/irc/ircbot.py:
290         * Scripts/webkitpy/common/system/logutils.py:
291         * Scripts/webkitpy/common/system/logutils_unittest.py:
292         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
293         * Scripts/webkitpy/layout_tests/port/chromium.py:
294         * Scripts/webkitpy/layout_tests/port/mac.py: Remove some unused imports
295         * Scripts/webkitpy/layout_tests/port/webkit.py:
296         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
297         * Scripts/webkitpy/tool/bot/irc_command.py:
298         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
299         * Scripts/webkitpy/tool/commands/download.py:
300         * Scripts/webkitpy/tool/commands/prettydiff.py:
301         * Scripts/webkitpy/tool/commands/queries.py:
302         * Scripts/webkitpy/tool/commands/roll.py:
303         * Scripts/webkitpy/tool/commands/stepsequence.py:
304         * Scripts/webkitpy/tool/commands/upload.py:
305         * Scripts/webkitpy/tool/main.py:
306
307 2011-02-07  James Robinson  <jamesr@chromium.org>
308
309         Reviewed by Adam Barth.
310
311         Teach do-webcore-rename about the WebKit move to Source/
312         https://bugs.webkit.org/show_bug.cgi?id=53967
313
314         * Scripts/do-webcore-rename:
315
316 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
317
318         Reviewed by Dan Bernstein.
319
320         Add resource load client for injected bundle and move willSendRequest there
321         https://bugs.webkit.org/show_bug.cgi?id=53972
322
323         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
324         (didCreatePage):
325         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
326         (WTR::InjectedBundlePage::InjectedBundlePage):
327         (WTR::InjectedBundlePage::didInitiateLoadForResource):
328         (WTR::InjectedBundlePage::didReceiveResponseForResource):
329         (WTR::InjectedBundlePage::didReceiveContentLengthForResource):
330         (WTR::InjectedBundlePage::didFinishLoadForResource):
331         (WTR::InjectedBundlePage::didFailLoadForResource):
332         (WTR::InjectedBundlePage::willSendRequestForFrame):
333         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
334
335 2011-02-07  Adam Barth  <abarth@webkit.org>
336
337         Add Leopard Debug back to the core builders.
338
339         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
340         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
341
342 2011-02-07  Adam Klein  <adamk@chromium.org>
343
344         Reviewed by Jian Li.
345
346         [chromium] Remove deprecated method WebNotification::dir
347         https://bugs.webkit.org/show_bug.cgi?id=53735
348
349         * DumpRenderTree/chromium/NotificationPresenter.cpp:
350         (NotificationPresenter::show):
351
352 2011-02-07  Adam Barth  <abarth@webkit.org>
353
354         Reviewed by Eric Seidel.
355
356         Remove Leopard Debug as a core builder
357         https://bugs.webkit.org/show_bug.cgi?id=53971
358
359         The Leopard Debug builder has been failing to compile for several days.
360         My understanding is that folks are working on fixing the build, but for
361         the time being we should probably remove it from the list of core
362         builders so that the core waterfall can be green.  We can certainly add
363         it back once the build is fixed.
364
365         Also, I've removed the Tiger builders because those no longer appear to
366         be attached to the buildbot master.
367
368         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
369         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
370
371 2011-02-01  Ojan Vafai  <ojan@chromium.org>
372
373         Reviewed by Adam Roben.
374
375         include svn revisions in git diffs for the code review tool to use
376         https://bugs.webkit.org/show_bug.cgi?id=53569
377
378         * Scripts/webkitpy/common/checkout/scm.py:
379         * Scripts/webkitpy/common/checkout/scm_unittest.py:
380
381 2011-02-03  MORITA Hajime  <morrita@google.com>
382
383         Reviewed by Darin Fisher.
384
385         [Chromium] Should implement EditorClientImpl::requestCheckingOfString()
386         https://bugs.webkit.org/show_bug.cgi?id=51013
387
388         Gave DRT implementation for requestTextCheck().
389
390         * DumpRenderTree/chromium/LayoutTestController.cpp:
391         (LayoutTestController::setAsynchronousSpellCheckingEnabled): Implemented.
392         * DumpRenderTree/chromium/WebViewHost.cpp:
393         (invokeFinishLastTextCheck): Added.
394         (WebViewHost::requestTextCheck): Added.
395         (WebViewHost::finishLastTextCheck): Added.
396         * DumpRenderTree/chromium/WebViewHost.h:
397
398 2011-02-07  Joone Hur  <joone.hur@collabora.co.uk>
399
400         Reviewed by Martin Robinson.
401
402         [Gtk] Implement layoutTestController.findString
403         https://bugs.webkit.org/show_bug.cgi?id=50237
404
405         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
406         (LayoutTestController::findString):
407
408 2011-02-07  Chang Shu  <chang.shu@nokia.com>
409
410         Reviewed by Darin Adler.
411
412         We should disable spatial navigation explicitly during the initialization
413         of DumpRenderTree.
414         https://bugs.webkit.org/show_bug.cgi?id=53928
415
416         * DumpRenderTree/mac/DumpRenderTree.mm:
417         (resetDefaultsToConsistentValues):
418
419 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
420
421         Not reviewed.
422
423         Fix WebKitTestRunner build on the SL bot.
424
425         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
426         of ICU headers.
427
428 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
429
430         Unreviewed.
431
432         [Qt][WK2] Buildfix after r77794.
433
434        WebKitTestRunner does not block remote resources or complain about them
435        https://bugs.webkit.org/show_bug.cgi?id=42139
436        <rdar://problem/8183942>
437
438         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
439
440 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
441
442         Not reviewed.
443
444         More bot appeasement.
445
446         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
447
448 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
449
450         Not reviewed.
451
452         Remove accidental references to directories on my laptop.
453
454         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
455
456 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
457
458         Reviewed by Antti Koivisto.
459
460         WebKitTestRunner does not block remote resources or complain about them
461         https://bugs.webkit.org/show_bug.cgi?id=42139
462         <rdar://problem/8183942>
463
464         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
465         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
466         checks (using KURL, to avoid need to invent a whole URL API).
467         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
468         directly to get at KURL symbols.
469
470 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
471
472         Reviewed by Daniel Bates.
473
474         Add WebKit2 bot to list of expected builders in Python regression test results.
475         https://bugs.webkit.org/show_bug.cgi?id=53905
476
477         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
478
479 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
480
481         Reviewed by Ryosuke Niwa.
482
483         Update test expectations for new core builder
484         https://bugs.webkit.org/show_bug.cgi?id=53904
485
486         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
487
488 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
489
490         Reviewed by David Levin.
491
492         Add WebKit2 test bot to core builders
493         https://bugs.webkit.org/show_bug.cgi?id=53901
494
495         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
496
497 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
498
499         Another unreviewed Chromium build fix.
500
501         * DumpRenderTree/chromium/LayoutTestController.cpp:
502         (LayoutTestController::pathToLocalResource):
503
504 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
505
506         Unreviewed Chromium build fix.
507
508         * DumpRenderTree/chromium/LayoutTestController.cpp:
509         (LayoutTestController::pathToLocalResource):
510
511 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
512
513         Reviewed by Darin Adler.
514
515         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
516         https://bugs.webkit.org/show_bug.cgi?id=52867
517
518         * DumpRenderTree/chromium/ImageDiff.cpp:
519         (Image::craeteFromStdin): Call adoptArrayPtr.
520
521 2011-02-06  James Kozianski  <koz@chromium.org>
522
523         Reviewed by Ojan Vafai.
524
525         Add classes for representing test outputs.
526         https://bugs.webkit.org/show_bug.cgi?id=52136
527
528         These classes will make it easier to write scripts that deal with test
529         outputs such as rebaselining and deduping scripts. The intent is that
530         eventually we will be have buildbot return TestOutputs for a
531         particular build which can be compared with TestOutputs derived from a
532         local LayoutTests directory.
533
534         * Scripts/webkitpy/common/net/testoutput.py: Added.
535         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
536         * Scripts/webkitpy/common/net/testoutputset.py: Added.
537         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
538         * Scripts/webkitpy/common/system/zip_mock.py: Added.
539
540 2011-02-06  Robert Hogan  <robert@webkit.org>
541
542         Reviewed by Andreas Kling.
543
544         [Qt] Clear page's groupName even when not in DRT
545         https://bugs.webkit.org/show_bug.cgi?id=53874
546
547         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
548         (WebCore::DumpRenderTree::windowCloseRequested):
549
550 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
551
552         Reviewed by Andreas Kling.
553
554         [CMake] Add dependencies for Visual Studio projects
555         https://bugs.webkit.org/show_bug.cgi?id=53773
556
557         Add a WebKit dependecy to WinCELauncher, so CMake can 
558         generate the correct build order for the solution.
559
560         * CMakeListsWinCE.txt:
561
562 2011-02-06  Andreas Kling  <kling@webkit.org>
563
564         Reviewed by Antonio Gomes.
565
566         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
567         https://bugs.webkit.org/show_bug.cgi?id=53869
568
569         * MiniBrowser/qt/BrowserView.cpp:
570         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
571         * MiniBrowser/qt/BrowserWindow.cpp:
572         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
573         * MiniBrowser/qt/BrowserWindow.h:
574
575 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
576
577         Reviewed by Dan Bernstein.
578
579         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
580         https://bugs.webkit.org/show_bug.cgi?id=42690
581         <rdar://problem/8213851>
582
583         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
584         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
585         (WTR::InjectedBundlePage::willSendRequestForFrame):
586         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
587         (WTR::LayoutTestController::LayoutTestController):
588         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
589         (WTR::LayoutTestController::willSendRequestReturnsNull):
590         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
591
592 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
593
594         Unreviewed, rolling out r77720.
595         http://trac.webkit.org/changeset/77720
596         https://bugs.webkit.org/show_bug.cgi?id=53854
597
598         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
599         #webkit).
600
601         * Scripts/webkitpy/common/system/executive.py:
602
603 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
604
605         Unreviewed, rolling out r77725.
606         http://trac.webkit.org/changeset/77725
607         https://bugs.webkit.org/show_bug.cgi?id=53844
608
609         It broke Qt minimal build (Requested by Ossy_ on #webkit).
610
611         * QtTestBrowser/launcherwindow.cpp:
612         (LauncherWindow::createChrome):
613         * QtTestBrowser/launcherwindow.h:
614         (WindowOptions::WindowOptions):
615         * QtTestBrowser/main.cpp:
616         (LauncherApplication::handleUserOptions):
617
618 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
619
620         Reviewed by Adam Barth.
621
622         [GTK] plugins/plugin-document-back-forward.html fails
623         https://bugs.webkit.org/show_bug.cgi?id=53833
624
625         Add the new "alert on load" functionality for the Unix version of the
626         test plugin. This functionality was originally introduced in r77706.
627
628         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
629         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
630
631 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
632
633         Reviewed by Andreas Kling.
634
635         Local Storage settings can be enable/disable from "Develop" menu
636         https://bugs.webkit.org/show_bug.cgi?id=52296
637
638         * QtTestBrowser/launcherwindow.cpp:
639         (LauncherWindow::createChrome):
640         (LauncherWindow::toggleLocalStorage):
641         (LauncherWindow::toggleOfflineStorageDatabase):
642         (LauncherWindow::toggleOfflineWebApplicationCache):
643         (LauncherWindow::setOfflineStorageDefaultQuota):
644         * QtTestBrowser/launcherwindow.h:
645         (WindowOptions::WindowOptions):
646         * QtTestBrowser/main.cpp:
647         (LauncherApplication::handleUserOptions):
648
649 2011-02-04  Tony Chang  <tony@chromium.org>
650
651         Reviewed by Eric Seidel.
652
653         get test-webkitpy running on win32 python
654         https://bugs.webkit.org/show_bug.cgi?id=53822
655
656         The test harness crashes with a WindowsError because it can't find
657         'svn' when using subprocess.Popen.  This gets us past the error
658         so we can see the failing tests on the Chromium Win Release Tests
659         bot.
660
661         * Scripts/webkitpy/common/system/executive.py:
662
663 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
664
665         Reviewed by Gustavo Noronha Silva.
666
667         [GTK] fast/events/pagehide-timeout.html fails
668         https://bugs.webkit.org/show_bug.cgi?id=53771
669
670         Add knowledge of the document browser cache model the DRT. When resetting
671         WebKit settings to consistent values between tests, default to the document
672         browser cache model.
673
674         * DumpRenderTree/gtk/DumpRenderTree.cpp:
675         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
676         cache model between tests.
677         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
678         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
679         document browser cache model.
680
681 2011-02-04  Adam Barth  <abarth@webkit.org>
682
683         Reviewed by Eric Seidel.
684
685         PluginDocuments don't create widgets for plugins on back/forward
686         https://bugs.webkit.org/show_bug.cgi?id=53474
687
688         Teach the test plugin how to call alert on load.
689
690         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
691         (NPP_New):
692
693 2011-02-04  Adam Roben  <aroben@apple.com>
694
695         Add a test case for encode/decode of FormData/FormDataElement
696
697         If the fix made in r77401 is broken, this new test will crash.
698
699         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
700
701         Reviewed by Sam Weinig.
702
703         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
704         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
705
706         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
707         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
708         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
709         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
710         form, an return the session state data.
711         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
712         and restore it into another WKPage.
713
714         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
718         * TestWebKitAPI/win/copy-resources.cmd:
719         Added new files.
720
721 2011-02-04  Adam Roben  <aroben@apple.com>
722
723         Move code to run JavaScript tests into its own files
724
725         This will allow other tests to use this mechanism.
726
727         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
728         world
729
730         Reviewed by Sam Weinig.
731
732         * TestWebKitAPI/JavaScriptTest.cpp: Added.
733         * TestWebKitAPI/JavaScriptTest.h: Added.
734         Moved code here...
735
736         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
737
738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
739         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
740         Added the new files.
741
742 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
743
744         Reviewed by Mihai Parparita.
745
746         merge test expectations for chromium, chromium-gpu. The
747         chromium-gpu port will no longer maintain its own
748         test expectations file.
749
750         Also add in a graphics_type() call on the port object to
751         determine what graphics type to use in the test configuration,
752         and log the configuration as a config setting.
753
754         https://bugs.webkit.org/show_bug.cgi?id=53562
755
756         * Scripts/webkitpy/layout_tests/port/base.py:
757         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
758         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
759         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
760
761 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
762
763         Reviewed by Pavel Feldman.
764
765         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
766         https://bugs.webkit.org/show_bug.cgi?id=53781
767
768         * Scripts/check-inspector-strings:
769
770 2011-02-04  Adam Roben  <aroben@apple.com>
771
772         Include the crashing function in the link to a crash log on Mac
773
774         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
775         function that crashed on Mac
776
777         Reviewed by David Kilzer.
778
779         * Scripts/old-run-webkit-tests:
780         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
781         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
782         the crash log.
783
784 2011-02-04  Adam Roben  <aroben@apple.com>
785
786         Link to Mac crash logs from results.html
787
788         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
789         results.html
790
791         Reviewed by David Kilzer.
792
793         * Scripts/old-run-webkit-tests:
794         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
795         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
796
797 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
798
799         Reviewed by Dan Bernstein.
800
801         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
802         https://bugs.webkit.org/show_bug.cgi?id=52897
803         <rdar://problem/8898294>
804
805         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
806         (WTR::InjectedBundlePage::InjectedBundlePage):
807         (WTR::InjectedBundlePage::willSendRequestForFrame):
808         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
809
810 2011-02-03  Ivan Krstić  <ike@apple.com>
811
812         Unreviewed.
813
814         Adding myself to committers.py.
815
816         * Scripts/webkitpy/common/config/committers.py:
817
818 2011-02-03  James Kozianski  <koz@chromium.org>
819
820         Reviewed by Dimitri Glazkov.
821
822         Add navigator.registerProtocolHandler behind a flag.
823         https://bugs.webkit.org/show_bug.cgi?id=52609
824
825         * Scripts/build-webkit:
826
827 2011-02-03  Hayato Ito  <hayato@chromium.org>
828
829         Reviewed by Eric Seidel.
830
831         [NRWT] Remove TestArgs class, which is wrongly used.
832
833         https://bugs.webkit.org/show_bug.cgi?id=53063
834
835         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
836         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
837         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
838         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
839         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
840         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
841
842 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
843
844         Reviewed by Kenneth Russell.
845
846         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
847         https://bugs.webkit.org/show_bug.cgi?id=53714
848
849         * Scripts/build-webkit: change --3d-canvas build option
850           to set ENABLE_WEBGL
851
852 2011-02-03  Hayato Ito  <hayato@chromium.org>
853
854         Reviewed by Tony Chang.
855
856         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
857         move _run_single_test() and _process_output() functions from
858         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
859
860         This is clean up and acts as a preparation for elimination of test_types/*
861         classes. These classes will move to the single_test_runner module introduced
862         in this patch.
863
864         https://bugs.webkit.org/show_bug.cgi?id=53004
865
866         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
867         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
868         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
869         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
870         * Scripts/webkitpy/layout_tests/port/base.py:
871         * Scripts/webkitpy/layout_tests/port/chromium.py:
872         * Scripts/webkitpy/layout_tests/port/dryrun.py:
873         * Scripts/webkitpy/layout_tests/port/test.py:
874         * Scripts/webkitpy/layout_tests/port/webkit.py:
875         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
876         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
877         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
878
879 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
880
881         Unreviewed, build fix.
882
883         Delete a line that was accidentally missed in r77586; without it
884         there is still a race between the two threads.
885
886         https://bugs.webkit.org/show_bug.cgi?id=51572
887
888         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
889
890 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
891
892         Reviewed by Tony Chang.
893
894         nrwt: handle "broken pipe" notifications from DRT more cleanly.
895
896         https://bugs.webkit.org/show_bug.cgi?id=52927
897
898         * Scripts/webkitpy/layout_tests/port/server_process.py:
899         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
900
901 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
902
903         Reviewed by Kenneth Russell.
904
905         Update, resubmit change to bug 51572. I think the race that was
906         fixed in r76703 caused the hang that caused us to roll this
907         patch out before, so I'd like to try again.
908
909         https://bugs.webkit.org/show_bug.cgi?id=51572
910
911         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
912         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
913
914 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
915
916         Unreviewed.
917
918         Adding myself to committers.py.
919
920         * Scripts/webkitpy/common/config/committers.py:
921
922 2011-02-03  Adam Roben  <aroben@apple.com>
923
924         Include the crashing function in the link to a crash log
925
926         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
927         function that crashed
928
929         Reviewed by David Kilzer.
930
931         * Scripts/old-run-webkit-tests:
932         (crashLocation): Added. Returns the location of the crash.
933         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
934         could be determined.
935
936 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
937
938         Unreviewed, build fix.
939
940         Actually make the changes suggested by Mihai in his review
941         of bug 53720 :(
942
943         https://bugs.webkit.org/show_bug.cgi?id=53720
944
945         * Scripts/webkitpy/layout_tests/port/test_files.py:
946         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
947
948 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
949
950         Reviewed by Mihai Parparita.
951
952         new-run-webkit-tests: Fix bug introduced in r77434 that was
953         causing us to run the canvas GPU tests on the Mac GPU port. This
954         bug revealed that we were not setting the port.name() field
955         properly in many cases, so I've cleaned up all of that code, and
956         removed a few comments about "version-specific" GPU ports that
957         don't exist and just confused things.
958
959         Testing also revealed that port.abspath_for_test() wasn't
960         normalizing paths on Windows properly, so I fixed that as well.
961
962         https://bugs.webkit.org/show_bug.cgi?id=53719
963
964         * Scripts/webkitpy/layout_tests/port/base.py:
965         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
966         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
967
968 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
969
970         Reviewed by Mihai Parparita.
971
972         new-run-webkit-tests: fix normalization of paths on windows when gathering files
973
974         r77434 introduced a bug that was causing the test expectations
975         for the GPU ports to not be treated properly. It turns out that
976         when we gathered the list of test files on Windows, we would
977         return paths of the form "c:\LayoutTests/fast/canvas", and the
978         mixture of backslashes and forward slashes was confusing things.
979
980         This patch normalizes all of the filenames returned from
981         test_files.find(), and adds better tests for this (fixing a
982         couple of other bugs found in the meantime).
983
984         https://bugs.webkit.org/show_bug.cgi?id=53720
985
986         * Scripts/webkitpy/layout_tests/port/test.py:
987         * Scripts/webkitpy/layout_tests/port/test_files.py:
988         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
989
990 2011-02-03  Adam Roben  <aroben@apple.com>
991
992         Add links to Windows crash logs in results.html
993
994         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
995         results.html
996
997         Reviewed by David Kilzer.
998
999         * Scripts/old-run-webkit-tests:
1000         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
1001         createDebuggerCommandFile).
1002         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
1003         tool has exited.
1004         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
1005         it into the test results directory tree. Only implemented for Cygwin currently.
1006         (findNewestFileMatchingGlob): Added. Does what it says.
1007         (htmlForResultsSection): Only link to files that exist.
1008         (linksForErrorTest): Add a link to the crash log.
1009         (deleteExpectedAndActualResults): Delete any old crash log for this test.
1010         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
1011         hardcoding it here.
1012
1013 2011-02-03  Adam Roben  <aroben@apple.com>
1014
1015         Tell the debugger the path to the WebKit source tree when saving a crash log
1016
1017         This allows the debugger to include the crashing line of code in the log.
1018
1019         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
1020         of code
1021
1022         Reviewed by Sam Weinig.
1023
1024         * Scripts/old-run-webkit-tests:
1025         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
1026         file and returns the path to that file. The commands we pass came from
1027         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
1028         WebKit source code lives.
1029         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
1030         line using -c, save them to a file and specify the path to that file using -cf. This works
1031         around what is presumably a bug in Windows's command line parsing, where having multiple
1032         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
1033         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
1034         together to make them easier to modify in the future.
1035
1036 2011-02-02  Sam Weinig  <sam@webkit.org>
1037
1038         Reviewed by Anders Carlsson.
1039
1040         Add notification of the end of a rubber band.
1041         <rdar://problem/8940648>
1042
1043         * MiniBrowser/mac/BrowserWindowController.m:
1044         (-[BrowserWindowController awakeFromNib]):
1045         * WebKitTestRunner/TestController.cpp:
1046         (WTR::TestController::createOtherPage):
1047         (WTR::TestController::initialize):
1048         Stub out the new WKUIClient function.
1049
1050 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
1051
1052         Unreviewed.
1053
1054         Adding myself to committers.py.
1055
1056         * Scripts/webkitpy/common/config/committers.py:
1057
1058 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
1059
1060         Reviewed by Csaba Osztrogonác.
1061
1062         [Qt][WK2] MiniBrowser's window size should be 800x600
1063         https://bugs.webkit.org/show_bug.cgi?id=53670
1064
1065         Make layout test failure debugging easier.
1066         * MiniBrowser/qt/BrowserWindow.cpp:
1067         (BrowserWindow::BrowserWindow):
1068
1069 2011-02-02  Andy Estes  <aestes@apple.com>
1070
1071         Reviewed by Mark Rowe.
1072
1073         'update-webkit' should handle OpenSource and Internal using different
1074         VCSs.
1075
1076         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
1077         Internal directory.
1078
1079 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1080
1081         Reviewed by Mihai Parparita.
1082
1083         new-run-webkit-tests: hardcode the directories to scan for tests
1084         for GPU bots instead of SKIPping them. See bug 53562 for some
1085         context, but we will now hard-code the list of directories to
1086         use by default instead of skipping over directories in the
1087         expectations file. We do this so that we will be able to merge
1088         the expectations files without getting conflicting SKIP
1089         directives. Note that this change will reduce the # of tests
1090         being run on the Mac GPU bots, because we're accidentally
1091         including some today.
1092
1093         https://bugs.webkit.org/show_bug.cgi?id=53631
1094
1095         * Scripts/webkitpy/layout_tests/port/base.py:
1096         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1097         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1098
1099 2011-02-02  Sam Weinig  <sam@webkit.org>
1100
1101         Reviewed by Beth Dakin.
1102
1103         Add ChromeClient function to paint custom overhang areas.
1104         https://bugs.webkit.org/show_bug.cgi?id=53639
1105
1106         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1107         (WTR::InjectedBundlePage::InjectedBundlePage):
1108         Stub out new callback.
1109
1110 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
1111
1112         Reviewed by Tony Chang.
1113
1114         new-run-webkit-tests: support chromium code paths in mock_drt
1115
1116         https://bugs.webkit.org/show_bug.cgi?id=53471
1117
1118         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1119         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1120
1121 2011-02-02  Adam Klein  <adamk@chromium.org>
1122
1123         Reviewed by Tony Chang.
1124
1125         Update new-run-webkit-tests --chromium to put output under Source/...
1126         https://bugs.webkit.org/show_bug.cgi?id=53612
1127
1128         * BuildSlaveSupport/test-result-archive:
1129         * Scripts/webkitpy/layout_tests/port/chromium.py:
1130
1131 2011-01-28  Tony Chang  <tony@chromium.org>
1132
1133         Reviewed by Eric Seidel.
1134
1135         [chromium] remove --use-test-shell from NRWT
1136         https://bugs.webkit.org/show_bug.cgi?id=53346
1137
1138         I've already started removing some of the bindings like eventSender so
1139         this already doesn't work isn't useful.  Also updated some comments to
1140         refer to DRT instead of test_shell.
1141
1142         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1143         * Scripts/webkitpy/layout_tests/port/chromium.py:
1144         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1145         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1146         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1147         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1149         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1150
1151 2011-02-02  Steve Lacey  <sjl@chromium.org>
1152
1153         Reviewed by Eric Carlson.
1154
1155         Implement basic media statistics on media elements.
1156         https://bugs.webkit.org/show_bug.cgi?id=53322
1157
1158         * Scripts/build-webkit:
1159
1160 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
1161
1162         [wx] Build fixes for wxWebKit.
1163
1164         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1165         (LayoutTestController::setSerializeHTTPLoads):
1166         * wx/browser/wscript:
1167         * wx/build/build_utils.py:
1168         * wx/build/settings.py:
1169
1170 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1171
1172         Reviewed by Mihai Parparita.
1173
1174         new-run-webkit-tests: stop skipping so many tests
1175
1176         r77163 introduced a regression where we weren't resetting test
1177         expectations properly and were skipping too many tests as a
1178         result. This patch fixes that and adds a test for it.
1179
1180         https://bugs.webkit.org/show_bug.cgi?id=53551
1181
1182         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1183         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1184
1185 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
1186
1187         Reviewed by Tony Chang.
1188
1189         new-run-webkit-tests: add first stub of test_runner2. This
1190         will add support for the 'inline', 'threads', and 'processes'
1191         flags to --worker-model, but for now the implementatios just
1192         fall back on the old ones.
1193
1194         https://bugs.webkit.org/show_bug.cgi?id=53157
1195
1196         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1197         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1198
1199 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
1200
1201         Reviewed by James Robinson.
1202
1203         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
1204         https://bugs.webkit.org/show_bug.cgi?id=53522
1205
1206         * Scripts/run-chromium-webkit-unit-tests:
1207
1208 2011-02-01  Adam Barth  <abarth@webkit.org>
1209
1210         Reviewed by Mihai Parparita.
1211
1212         Using Control-C to cancel webkit-patch or other python tools causes
1213         unpleasant traceback console spew
1214         https://bugs.webkit.org/show_bug.cgi?id=53462
1215
1216         Catch the exception and don't print the stack trace.
1217
1218         * Scripts/webkit-patch:
1219
1220 2011-02-01  Scott Cameron  <sccameron@rim.com>
1221
1222         Reviewed by Daniel Bates.
1223
1224         Use Windows format for MinGW HTTPD path.
1225         https://bugs.webkit.org/show_bug.cgi?id=53503
1226
1227         * Scripts/webkitperl/httpd.pm:
1228           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
1229             so that we don't have to escape the space characters in the path. Also,
1230             changed path to Windows-style path and removed FIXME comment.
1231
1232 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
1233
1234         Reviewed by Andreas Kling.
1235
1236         [Qt][WK2] Add a way to use shared process model in MiniBrowser
1237         https://bugs.webkit.org/show_bug.cgi?id=53090
1238
1239         * MiniBrowser/qt/BrowserView.cpp:
1240         (BrowserView::BrowserView): Removed the m_context member.
1241         From now the context is guaranteed to be non-null and we
1242         don't need to store that in the object.
1243         * MiniBrowser/qt/BrowserView.h:
1244         * MiniBrowser/qt/BrowserWindow.cpp:
1245         Added static bool to determine that new windows need to be
1246         created with their own context or not. Use the same context
1247         and web process by default to be inilne with the other ports.
1248         (BrowserWindow::BrowserWindow):
1249         (BrowserWindow::newWindow):
1250         * MiniBrowser/qt/BrowserWindow.h:
1251         * MiniBrowser/qt/main.cpp:
1252         (main): Added command line switch to be able to use the
1253         non-shared process model. Simplify the handling of the command line
1254         switches a little bit.
1255
1256 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1257
1258         Reviewed by Andreas Kling.
1259
1260         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
1261         https://bugs.webkit.org/show_bug.cgi?id=53491
1262
1263         * MiniBrowser/qt/BrowserWindow.cpp:
1264         (BrowserWindow::BrowserWindow):
1265         (BrowserWindow::toggleFullScreenMode):
1266         * MiniBrowser/qt/BrowserWindow.h:
1267
1268 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
1269
1270         Reviewed by Andreas Kling.
1271
1272         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
1273         https://bugs.webkit.org/show_bug.cgi?id=53489
1274
1275         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
1276         to Settings menu.
1277
1278         * MiniBrowser/qt/BrowserWindow.cpp:
1279         (BrowserWindow::BrowserWindow):
1280         (BrowserWindow::toggleFrameFlattening):
1281         (BrowserWindow::toggleDisableJavaScript):
1282         (BrowserWindow::toggleAutoLoadImages):
1283         * MiniBrowser/qt/BrowserWindow.h:
1284
1285 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
1286
1287         Reviewed by Tony Chang.
1288
1289         [Chromium] Switch chromium-mac to use ChromiumDriver
1290         https://bugs.webkit.org/show_bug.cgi?id=53461
1291         
1292         For the sake of consistency with the other Chromium platforms (and so
1293         that chromium-mac picks up special flags like --enable-hardware-gpu),
1294         switch chromium-mac from the WebKitDriver to ChromiumDriver.
1295
1296         * Scripts/webkitpy/layout_tests/port/chromium.py:
1297
1298 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
1299
1300         Reviewed by Mihai Parparita.
1301
1302         The current modifier parsing code in test_expectations is
1303         fragile and hard-coded, so it's not easy to understand the logic
1304         or easily add new types of modifiers (like GPU vs. CPU testing
1305         for graphics tests, or 32-bit vs. 64-bit differences).
1306
1307         This is the first of two patches that will add in more generic
1308         support and then eliminate the GPU-specific test expectations
1309         files for Chromium.
1310
1311         This patch adds two standalone objects for handling modifiers. The
1312         rules for interpreting modifiers, precedence, and conflicts are
1313         given in the docstring to the ModifierMatcher class, which
1314         returns ModifierMatchResult objects.
1315         
1316         This patch also adds routines to the Port interface and a
1317         default set of values in the base object, in order to obtain the
1318         values needed on a given test run. These values are then passed
1319         to the expectation parser. This also allows us to clean up the
1320         logic used to lint all of the different configurations in a
1321         single test_expectations.txt file.
1322
1323         The next patch will merge in the separate GPU expectations file.
1324
1325         https://bugs.webkit.org/show_bug.cgi?id=51222
1326
1327         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1328         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1329         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1330         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1331         * Scripts/webkitpy/layout_tests/port/base.py:
1332         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1333         * Scripts/webkitpy/layout_tests/port/chromium.py:
1334         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1335         * Scripts/webkitpy/layout_tests/port/test.py:
1336         * Scripts/webkitpy/layout_tests/port/webkit.py:
1337         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1338         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1339         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1340         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
1341         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1342
1343 2011-01-31  Scott Cameron  <sccameron@rim.com>
1344
1345         Reviewed by Daniel Bates.
1346
1347         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
1348         https://bugs.webkit.org/show_bug.cgi?id=50036
1349
1350         This will add an Apache2.2 configuration file and modifies scripts to allow
1351         running an httpd server in an MSYS environment.
1352
1353         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
1354         in order to allow for simple installation/execution.  Simply install the latest
1355         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
1356         be able to execute run-webkit-httpd.
1357         
1358
1359         * Scripts/run-webkit-httpd:
1360         * Scripts/webkitperl/httpd.pm:
1361
1362 2011-01-31  Tony Chang  <tony@chromium.org>
1363
1364         Reviewed by Eric Seidel.
1365
1366         mac DRT should report RTL scroll offset relative to top right corner
1367         https://bugs.webkit.org/show_bug.cgi?id=53324
1368
1369         * DumpRenderTree/mac/DumpRenderTree.mm:
1370         (dumpFrameScrollPosition):
1371
1372 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
1373
1374         Reviewed by Andreas Kling.
1375
1376         [Qt] Add Take Screen Shot action to MiniBrowser
1377         https://bugs.webkit.org/show_bug.cgi?id=53422
1378
1379         Add Take Screen Shot action to MiniBrowser's view menu.
1380
1381         * MiniBrowser/qt/BrowserWindow.cpp:
1382         (BrowserWindow::BrowserWindow):
1383         (BrowserWindow::screenshot):
1384         * MiniBrowser/qt/BrowserWindow.h:
1385
1386 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1387
1388         Reviewed by Xan Lopez.
1389
1390         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
1391         https://bugs.webkit.org/show_bug.cgi?id=53379
1392
1393         Remove left over #ifdef's. I thought all of the conditional code
1394         had been freed from the condition, but I forgot to check DRT.
1395
1396         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1397         (resetDefaultsToConsistentValues):
1398         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1399         (LayoutTestController::setAlwaysAcceptCookies):
1400
1401 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1402
1403         Unreviewed, build fix.
1404
1405         Fix regression introduced in r77093 - path.rsplit() doesn't
1406         take keyword arguments.
1407
1408         https://bugs.webkit.org/show_bug.cgi?id=53326
1409
1410         * Scripts/webkitpy/common/system/filesystem_mock.py:
1411
1412 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1413
1414         Reviewed by Mihai Parparita.
1415
1416         Add more unit tests for rebaseline-chromium-webkit-tests. This
1417         change involves restructuring a bunch of r-c-w-t code to make it
1418         more testable as well. We also add wrapper classes for handling
1419         testing zip files and fetching URLs.
1420
1421         https://bugs.webkit.org/show_bug.cgi?id=53040
1422
1423         * Scripts/webkitpy/common/system/urlfetcher.py:
1424         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
1425         * Scripts/webkitpy/common/system/zipfileset_mock.py:
1426         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1427         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1428         * Scripts/webkitpy/tool/mocktool.py:
1429
1430 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1431
1432         Reviewed by Eric Seidel.
1433
1434         Clean up of the filesystem-related modules used in webkitpy.
1435         I've added relpath() to the filesystem interface, modified
1436         ospath.relpath() so that it could work with the filesystem
1437         interface, and modified the fileset* routines to use the
1438         filesystem interface consistently.
1439
1440         This patch also adds a close() routine to the fileset routines
1441         to indicate that the caller is done with the fileset. This
1442         allows zipfileset to clean up after itself when it creates
1443         tempfiles to store downloads.
1444
1445         https://bugs.webkit.org/show_bug.cgi?id=53326
1446
1447         * Scripts/webkitpy/common/system/directoryfileset.py:
1448         * Scripts/webkitpy/common/system/fileset.py:
1449         * Scripts/webkitpy/common/system/filesystem.py:
1450         * Scripts/webkitpy/common/system/filesystem_mock.py:
1451         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1452         * Scripts/webkitpy/common/system/ospath.py:
1453         * Scripts/webkitpy/common/system/zipfileset.py:
1454         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1455
1456 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1457
1458         Reviewed by Csaba Osztrogonác.
1459
1460         [Qt][WK2]REGRESSION (r76991): Fix build errors
1461         https://bugs.webkit.org/show_bug.cgi?id=53400
1462
1463         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1464         and remove WebKit2Prefix.h from the build.
1465         * MiniBrowser/qt/MiniBrowser.pro:
1466
1467 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1468
1469         Unreviewed.
1470
1471         [Qt][WK2] Buildfix.
1472
1473         * MiniBrowser/qt/MiniBrowser.pro:
1474
1475 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1476
1477         Reviewed by Adam Roben.
1478         
1479         define NOMINMAX when building ImageDiff, as we do elsewhere.
1480
1481         Add various clampToInt() methods to MathExtras.h
1482         https://bugs.webkit.org/show_bug.cgi?id=52910
1483
1484         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1485
1486 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1487
1488         Reviewed by Darin Adler.
1489
1490         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1491         https://bugs.webkit.org/show_bug.cgi?id=42682
1492
1493         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1494         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1495         (WTR::InjectedBundle::resetLocalSettings):
1496         (WTR::InjectedBundle::didReceiveMessage):
1497         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1498         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1499         (WTR::LayoutTestController::setPOSIXLocale):
1500         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1501
1502 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1503  
1504          Reviewed by Mihai Parparita.
1505  
1506          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1507  
1508          This patch re-enables this test and changes it to
1509          handle all of the mac platform versions, not just the one
1510          it is running on.
1511  
1512          https://bugs.webkit.org/show_bug.cgi?id=53356
1513  
1514          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1515  
1516 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1517
1518         Unreviewed, build fix.
1519
1520         Take two. The fix in 77023 didn't work, because we were
1521         still calling path.abspath_to_uri, which calls _cygpath under
1522         the covers, and it appears the cygpath on the bots does
1523         something different than it does on my machine. This patch
1524         removes the calls to path.abspath_to_uri, so it should be safe.
1525         If it doesn't work, I'll roll it out along with r76982 and 77023.
1526
1527         https://bugs.webkit.org/show_bug.cgi?id=53126
1528
1529         * Scripts/webkitpy/layout_tests/port/test.py:
1530
1531 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1532
1533         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1534         <http://webkit.org/b/53353>
1535
1536         Reviewed by Mark Rowe.
1537
1538         * Scripts/webkitdirs.pm:
1539         (checkRequiredSystemConfig): Check the Xcode marketing version
1540         in addition to the DevCoreTools build version before complaining
1541         about an old version of Xcode.  Also make the Mac OS X version
1542         check use Perl's built-in version string comparitor.
1543
1544 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1545
1546         Unreviewed, build fix.
1547
1548         Work around breakage on Win 7 Release bot caused by r76982
1549         and the fact that windows ports use "file:////" instead of
1550         "file:///". Ideally the test code should be isolated from
1551         this, but it isn't yet. Will fix properly in a bit.
1552
1553         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1554
1555 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1556
1557         Reviewed by Tony Chang.
1558
1559         new-run-webkit-tests: change worker model values to
1560         "old-inline", "old-threads" in preparation for test_runner2 /
1561         multiprocessing changes.
1562
1563         https://bugs.webkit.org/show_bug.cgi?id=53156
1564
1565         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1566         * Scripts/webkitpy/layout_tests/port/base.py:
1567         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1568         * Scripts/webkitpy/layout_tests/port/mac.py:
1569         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1570
1571 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1572
1573         Reviewed by Tony Chang.
1574
1575         committers.py - add an IRC nickname for dpranke
1576         https://bugs.webkit.org/show_bug.cgi?id=53335
1577
1578         * Scripts/webkitpy/common/config/committers.py:
1579
1580 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1581
1582         Reviewed by Tony Chang.
1583
1584         new-run-webkit-tests: add a "mock DRT" port implementation
1585         and a separate class that emulates what we expect the
1586         DumpRenderTree behavior to be.
1587
1588         This will eventually replace port/dryrun.py and allow us to get
1589         better test coverage of the new-run-webkit-tests code as well as
1590         a reference for what new-run-webkit-tests expects from DRT.
1591
1592         This is the first attempt at this, and it is pretty bare-boned. It
1593         really only has been tested on the 'mac' port (and a little on
1594         the 'chromium-mac' port.
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=53126
1597
1598         * Scripts/webkitpy/common/system/filesystem_mock.py:
1599         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1600         * Scripts/webkitpy/layout_tests/port/factory.py:
1601         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1602         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1603         * Scripts/webkitpy/layout_tests/port/test.py:
1604
1605 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1606
1607         Unreviewed. Removing .swp file checked in by mistake.
1608
1609         * Scripts/.webkitdirs.pm.swp: Removed.
1610
1611 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1612
1613         Reviewed by David Kilzer.
1614
1615         Space not necessary for undefined feature
1616         https://bugs.webkit.org/show_bug.cgi?id=53317
1617
1618         * Scripts/build-webkit:
1619
1620 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1621
1622         Reviewed by Andreas Kling.
1623
1624         Reset NetworkAccessManager to clean up credentials from previous tests.
1625         This change causes no performance overhead either.
1626         https://bugs.webkit.org/show_bug.cgi?id=36688
1627
1628         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1629         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1630         (WebCore::DumpRenderTree::open):
1631         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1632
1633 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1634
1635         Reviewed by Andreas Kling.
1636
1637         [Qt] Add Zoom Text Only action to MiniBrowser
1638         https://bugs.webkit.org/show_bug.cgi?id=53297
1639
1640         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1641
1642         * MiniBrowser/qt/BrowserWindow.cpp:
1643         (BrowserWindow::BrowserWindow):
1644         (BrowserWindow::zoomIn):
1645         (BrowserWindow::zoomOut):
1646         (BrowserWindow::resetZoom):
1647         (BrowserWindow::toggleZoomTextOnly):
1648         (BrowserWindow::applyZoom):
1649         * MiniBrowser/qt/BrowserWindow.h:
1650
1651 2011-01-28  Adam Barth  <abarth@webkit.org>
1652
1653         Reviewed by Eric Seidel.
1654
1655         Add webkit-patch roll-chromium-deps
1656         https://bugs.webkit.org/show_bug.cgi?id=53288
1657
1658         This command updates the Source/WebKit/chromium/DEPS file with the
1659         last-known good revision of Chromium (or a revision specified on the
1660         command line).  I'd eventually like to turn this into a SheriffBot
1661         command, but this is the first step.
1662
1663         This patch somewhat sprawled because I needed to move a bunch of code
1664         out of ChangeLog that should never have been there in the first place.
1665         Also, I had to fix a bug in MockUser in order to test the new command.
1666
1667         * Scripts/webkitpy/common/checkout/api.py:
1668         * Scripts/webkitpy/common/checkout/changelog.py:
1669         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1670         * Scripts/webkitpy/common/checkout/deps.py: Added.
1671         * Scripts/webkitpy/common/config/urls.py:
1672         * Scripts/webkitpy/tool/commands/__init__.py:
1673         * Scripts/webkitpy/tool/commands/download_unittest.py:
1674         * Scripts/webkitpy/tool/commands/roll.py: Added.
1675         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1676         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1677         * Scripts/webkitpy/tool/mocktool.py:
1678         * Scripts/webkitpy/tool/steps/__init__.py:
1679         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1680         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1681         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1682         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1683         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1684         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1685
1686 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1687
1688         Reviewed by Laszlo Gombos.
1689
1690         Get rid of prefix header dependency for WebKit2 build system
1691         https://bugs.webkit.org/show_bug.cgi?id=50174
1692
1693         Change the style checker so that it enforces config.h include for
1694         WebKit2.
1695
1696         * Scripts/webkitpy/style/checker.py:
1697
1698 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1699
1700         Reviewed by Darin Adler.
1701
1702         execCommand("Paste") doesn't work in WebKitTestRunner
1703         https://bugs.webkit.org/show_bug.cgi?id=52785
1704
1705         Enable both of the settings needed to allow paste.
1706         
1707         * WebKitTestRunner/TestController.cpp:
1708         (WTR::TestController::resetStateToConsistentValues):
1709
1710 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1711
1712         Reviewed by Andreas Kling.
1713
1714         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1715         https://bugs.webkit.org/show_bug.cgi?id=48440
1716
1717         Preserve user input when toggling use of QGraphicsView
1718
1719         * QtTestBrowser/launcherwindow.cpp:
1720         (LauncherWindow::initializeView):
1721         (LauncherWindow::loadFinished):
1722         * QtTestBrowser/launcherwindow.h:
1723         * QtTestBrowser/mainwindow.cpp:
1724         (MainWindow::addressUrl):
1725         * QtTestBrowser/mainwindow.h:
1726
1727 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1728
1729         Reviewed by Mihai Parparita.
1730
1731         new-run-webkit-tests: turn off pixel tests correctly by default
1732         for webkit-based ports. r70013 (bug 47510) used
1733         port.set_option_default() to attempt to set default values, but
1734         that didn't work correctly. I have removed set_option_default
1735         for now since it was only being used in two places and in three
1736         useless unit tests. There is a separate bug open to fix the
1737         option parsing (48095), so this workaround is fine for now.
1738
1739         https://bugs.webkit.org/show_bug.cgi?id=53217
1740
1741         * Scripts/webkitpy/layout_tests/port/webkit.py:
1742         * Scripts/webkitpy/layout_tests/port/base.py:
1743         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1744
1745 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1746
1747         Rubber-stamped by Ariya Hidayat.
1748
1749         Trivial crash fix in WTR.
1750
1751         * WebKitTestRunner/TestController.cpp:
1752         (WTR::TestController::initialize): Increase the size
1753         of the vector by one to be able to store the null character.
1754
1755 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1756
1757         Reviewed by Csaba Osztrogonác.
1758
1759         [Qt][WK2] WTR should be initialized in the same way as DRT
1760         https://bugs.webkit.org/show_bug.cgi?id=53240
1761
1762         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1763         (WTR::activateFonts): Added missing initialization steps.
1764
1765 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1766
1767         Unreviewed. 
1768
1769         Adding myself to committers.py.
1770
1771         * Scripts/webkitpy/common/config/committers.py:
1772
1773 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1774
1775         Reviewed by Csaba Osztrogonác.
1776
1777         [Qt] [Symbian] Move project files into Source
1778         https://bugs.webkit.org/show_bug.cgi?id=52891
1779
1780         Fix the Symbian build after the project files
1781         are moved to Source directory. On Symbian qmake
1782         needs to run in the same directory where the main
1783         pro files (WebKit.pro, Tools.pro) are located.
1784
1785         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1786         is located before running qmake for Symbian. Qmake on Symbian
1787         does not properly honor the "-o" option, work it around by setting
1788         the name of the Makefile to bld.inf.
1789
1790 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1791
1792         Reviewed by Andreas Kling.
1793
1794         [Qt] Add simple zooming features to MiniBrowser
1795         https://bugs.webkit.org/show_bug.cgi?id=53231
1796
1797         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1798
1799         * MiniBrowser/qt/BrowserWindow.cpp:
1800         (BrowserWindow::BrowserWindow):
1801         (BrowserWindow::zoomIn):
1802         (BrowserWindow::zoomOut):
1803         (BrowserWindow::resetZoom):
1804         (BrowserWindow::updateUserAgentList):
1805         (BrowserWindow::applyZoom):
1806         * MiniBrowser/qt/BrowserWindow.h:
1807
1808 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1809
1810         Reviewed by Dan Bernstein.
1811
1812         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1813         https://bugs.webkit.org/show_bug.cgi?id=42319
1814         
1815         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1816
1817         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1818         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1819         (WTR::LayoutTestController::showWebInspector):
1820         (WTR::LayoutTestController::closeWebInspector):
1821         (WTR::LayoutTestController::evaluateInWebInspector):
1822         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1823         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1824         * WebKitTestRunner/TestInvocation.cpp:
1825         (WTR::shouldOpenWebInspector):
1826         (WTR::TestInvocation::invoke):
1827         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1828
1829 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1830
1831         Reviewed by Xan Lopez.
1832
1833         [GTK] Pixel dumps do not include scrollbars in output images
1834         https://bugs.webkit.org/show_bug.cgi?id=53216
1835
1836         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1837         that have scrollbars.
1838
1839         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1840         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1841         instead of the web view itself.
1842
1843 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1844
1845         Reviewed by Mihai Parparita.
1846
1847         Fix regression introduced in r76322 ... new-run-webkit-tests
1848         was attempting to save the image diff output as a UTF-8-encoded
1849         file.
1850
1851         https://bugs.webkit.org/show_bug.cgi?id=53210
1852
1853         * Scripts/webkitpy/layout_tests/port/webkit.py:
1854
1855 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1856
1857         Unreviewed, rolling out r76709.
1858         http://trac.webkit.org/changeset/76709
1859         https://bugs.webkit.org/show_bug.cgi?id=53194
1860
1861         "broke python tests on non-snowleopard platforms" (Requested
1862         by dpranke on #webkit).
1863
1864         * Scripts/webkitpy/layout_tests/port/factory.py:
1865         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1866         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1867
1868 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1869
1870         Reviewed by Tony Chang.
1871
1872         new-run-webkit-tests: add a "mock DRT" port implementation
1873         and a separate class that emulates what we expect the
1874         DumpRenderTree behavior to be.
1875
1876         This will eventually replace port/dryrun.py and allow us to get
1877         better test coverage of the new-run-webkit-tests code as well as
1878         a reference for what new-run-webkit-tests expects from DRT.
1879
1880         This is the first attempt at this, and it is pretty bare-boned. It
1881         really only has been tested on the 'mac' port (and a little on
1882         the 'chromium-mac' port.
1883
1884         https://bugs.webkit.org/show_bug.cgi?id=53126
1885
1886         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1887         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1888         * Scripts/webkitpy/layout_tests/port/factory.py:
1889
1890 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1891
1892         Reviewed by Tony Chang.
1893
1894         Add '--no-timeout' option to Chromium DRT to ease debugging.
1895         https://bugs.webkit.org/show_bug.cgi?id=52873
1896
1897         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1898         (main):
1899
1900 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1901
1902         Reviewed by Andreas Kling.
1903
1904         [Qt] Fix qt_minimal build
1905         https://bugs.webkit.org/show_bug.cgi?id=53172
1906
1907         * QtTestBrowser/locationedit.h:
1908
1909 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1910
1911         Reviewed by Antonio Gomes.
1912
1913         QtTestBrowser should have a UI Setting to disable plugins
1914         https://bugs.webkit.org/show_bug.cgi?id=52408
1915         
1916         Added a new action item named "Disable Plugins"
1917         under the "Settings" menu. 
1918
1919         * QtTestBrowser/launcherwindow.cpp:
1920         (LauncherWindow::createChrome):
1921         (LauncherWindow::togglePlugins):
1922         * QtTestBrowser/launcherwindow.h:
1923
1924 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1925
1926         Reviewed by Adam Barth.
1927
1928         Move main CMakeLists.txt into Source directory
1929         https://bugs.webkit.org/show_bug.cgi?id=52888
1930
1931         * Scripts/webkitdirs.pm:
1932
1933 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1934
1935         Reviewed by Eric Seidel.
1936
1937         Improve label text in submit-to-ews
1938         https://bugs.webkit.org/show_bug.cgi?id=53130
1939
1940         * QueueStatusServer/templates/submittoews.html:
1941
1942 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1943
1944         Reviewed by Antonio Gomes.
1945
1946         QtTestBrowser should have a UI Settings to prevent loading images
1947         https://bugs.webkit.org/show_bug.cgi?id=52409
1948         
1949         Added a new action item named "DisableAutoLoadImages"
1950         under the "Settings" menu 
1951
1952         * QtTestBrowser/launcherwindow.cpp:
1953         (LauncherWindow::createChrome):
1954         (LauncherWindow::toggleAutoLoadImages):
1955         * QtTestBrowser/launcherwindow.h:
1956
1957 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1958
1959         Reviewed by Tony Chang.
1960
1961         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1962         classes, test_expectations.py. This change adds "test-win" and
1963         "test-mac" variants to the test port so that we can better test
1964         rebaselining, and adds a MockUser() object for reuse in testing.
1965
1966         https://bugs.webkit.org/show_bug.cgi?id=53036
1967
1968         * Scripts/webkitpy/common/system/filesystem.py:
1969         * Scripts/webkitpy/common/system/filesystem_mock.py:
1970         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1971         * Scripts/webkitpy/layout_tests/port/factory.py:
1972         * Scripts/webkitpy/layout_tests/port/base.py:
1973         * Scripts/webkitpy/layout_tests/port/test.py:
1974         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1975         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1976         * Scripts/webkitpy/tool/mocktool.py:
1977
1978 2011-01-25  Tony Chang  <tony@chromium.org>
1979
1980         Reviewed by Dimitri Glazkov.
1981
1982         [chromium] remove unused layoutTestController callback
1983         https://bugs.webkit.org/show_bug.cgi?id=53103
1984
1985         This method is used by a test_shell_test, but not needed by DRT.
1986
1987         * DumpRenderTree/chromium/LayoutTestController.cpp:
1988         (LayoutTestController::LayoutTestController):
1989         * DumpRenderTree/chromium/LayoutTestController.h:
1990
1991 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1992
1993         Reviewed by Andreas Kling.
1994
1995         [GTK] Remove 64 bits release bot from the buildbot master
1996         https://bugs.webkit.org/show_bug.cgi?id=52899
1997
1998         Removes the 64 bits release slave from the buildbot configuration,
1999         so that we can use it as an EWS.
2000
2001         * BuildSlaveSupport/build.webkit.org-config/config.json:
2002
2003 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2004
2005         Reviewed by Dan Bernstein.
2006
2007         Implement database quota callback to fix storage tests on WebKit2 bot
2008         https://bugs.webkit.org/show_bug.cgi?id=53064
2009
2010         * WebKitTestRunner/TestController.cpp:
2011         (WTR::exceededDatabaseQuota):
2012         (WTR::TestController::createOtherPage):
2013         (WTR::TestController::initialize):
2014
2015 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2016
2017         Reviewed by Anders Carlsson.
2018
2019         Use designated temp directory for the database for WebKit2
2020         https://bugs.webkit.org/show_bug.cgi?id=53052
2021         
2022         Adopt the new WK2 API for this.
2023
2024         * WebKitTestRunner/TestController.cpp:
2025         (WTR::TestController::libraryPathForTesting):
2026         (WTR::TestController::initialize):
2027         * WebKitTestRunner/TestController.h:
2028         * WebKitTestRunner/mac/TestControllerMac.mm:
2029         (WTR::TestController::platformLibraryPathForTesting):
2030         * WebKitTestRunner/qt/TestControllerQt.cpp:
2031         (WTR::TestController::platformLibraryPathForTesting):
2032         * WebKitTestRunner/win/TestControllerWin.cpp:
2033         (WTR::TestController::platformLibraryPathForTesting):
2034
2035 2011-01-24  Lucas Forschler  <lforschler@apple.com>
2036
2037         Reviewed by Stephanie Lewis.
2038
2039         Add a new Leopard test bot.
2040
2041         * BuildSlaveSupport/build.webkit.org-config/config.json:
2042
2043 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2044
2045         Reviewed by Adam Barth.
2046
2047         Add EFL Builder to core waterfall
2048         https://bugs.webkit.org/show_bug.cgi?id=52704
2049
2050         Add EFL Builder to the core waterfall again.
2051
2052         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2053         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2054
2055 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
2056
2057         Reviewed by Tony Chang.
2058
2059         new-run-webkit-tests fails to start HTTP server if there are proxy settings
2060         https://bugs.webkit.org/show_bug.cgi?id=52872
2061
2062         Force disabling proxy to resolve the problem.
2063
2064         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
2065         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
2066
2067 2011-01-24  Andreas Kling  <kling@webkit.org>
2068
2069         Reviewed by Darin Adler.
2070
2071         check-webkit-style: Update exemptions following Source/ move.
2072         https://bugs.webkit.org/show_bug.cgi?id=53017
2073
2074         * Scripts/webkitpy/style/checker.py:
2075         * Scripts/webkitpy/style/checker_unittest.py:
2076
2077 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2078
2079         Rubber-stamped by Csaba Osztrogonác.
2080
2081         [Qt] Move project files into Source
2082         https://bugs.webkit.org/show_bug.cgi?id=52891
2083
2084         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
2085
2086 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
2087
2088         Reviewed by Yury Semikhatsky.
2089
2090         Web Inspector: Find duplicate strings in localizedStrings.js
2091
2092         https://bugs.webkit.org/show_bug.cgi?id=53005
2093
2094         * Scripts/check-inspector-strings:
2095
2096 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
2097
2098         Reviewed by Andreas Kling.
2099
2100         [Qt] Regroup MiniBrowser's menubar and add open file action
2101         https://bugs.webkit.org/show_bug.cgi?id=53000
2102
2103         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
2104
2105         * MiniBrowser/qt/BrowserWindow.cpp:
2106         (BrowserWindow::BrowserWindow):
2107         (BrowserWindow::openFile):
2108         (BrowserWindow::~BrowserWindow):
2109         * MiniBrowser/qt/BrowserWindow.h:
2110
2111 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
2112
2113         Unreviewed fix after r76496
2114
2115         [Qt] Move project files into Source
2116         https://bugs.webkit.org/show_bug.cgi?id=52891
2117
2118         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
2119         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
2120         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
2121
2122 2011-01-24  Andras Becsi  <abecsi@webkit.org>
2123
2124         Reviewed by Csaba Osztrogonác.
2125
2126         [Qt] Move project files into Source
2127         https://bugs.webkit.org/show_bug.cgi?id=52891
2128
2129         * DerivedSources.pro: Renamed from DerivedSources.pro.
2130         * DumpRenderTree/qt/DumpRenderTree.pro:
2131         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2132         * MiniBrowser/DerivedSources.pro:
2133         * MiniBrowser/qt/MiniBrowser.pro:
2134         * QtTestBrowser/QtTestBrowser.pro:
2135         * Scripts/webkitdirs.pm:
2136         * Tools.pro: Added.
2137         * WebKitTestRunner/DerivedSources.pro:
2138         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2139         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2140
2141 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2142
2143         Reviewed by Dan Bernstein.
2144
2145         Beefed up --threaded mode to catch even more kinds of errors.
2146         https://bugs.webkit.org/show_bug.cgi?id=52971
2147
2148         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
2149         context group to force JSC to mark multiple threads. (This used to be
2150         the default, but it changed in SnowLeopard.)
2151         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
2152         to give threading mistakes more chances to show themselves.
2153         (startJavaScriptThreads):
2154         (stopJavaScriptThreads):
2155
2156 2011-01-22  Robert Hogan  <robert@webkit.org>
2157
2158         Reviewed by Andreas Kling.
2159
2160         [Qt] Support layoutTestController.addURLToRedirect()
2161         https://bugs.webkit.org/show_bug.cgi?id=52956
2162
2163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2164         (LayoutTestController::addURLToRedirect):
2165         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2166
2167 2011-01-22  Robert Hogan  <robert@webkit.org>
2168
2169         Reviewed by Kenneth Rohde Christiansen.
2170
2171         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
2172         https://bugs.webkit.org/show_bug.cgi?id=49802
2173
2174         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2175         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2176         (WebCore::DumpRenderTree::open):
2177
2178 2011-01-21  Adam Barth  <abarth@webkit.org>
2179
2180         Reviewed by Maciej Stachowiak.
2181
2182         Disable mac_unittest.py that fails on some of the Mac bots
2183         https://bugs.webkit.org/show_bug.cgi?id=52947
2184
2185         As noted in the comment, this test does not appear to be correct
2186         because the function this test is testing returns different results
2187         depending on which flavor of Mac the test is run on.  This patch
2188         disable the test.  Hopefully we can re-enable the test once we've
2189         probably insulated the test from its environment.
2190
2191         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2192
2193 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2194
2195         Reviewed by Mihai Parparita.
2196
2197         Fix bug introduced in r76322 that caused NRWT to not actually
2198         read the Skipped files properly.
2199
2200         https://bugs.webkit.org/show_bug.cgi?id=52771
2201
2202         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2203         * Scripts/webkitpy/layout_tests/port/webkit.py:
2204         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2205
2206 2011-01-21  Sam Weinig  <sam@webkit.org>
2207
2208         Reviewed by Geoffrey Sean Garen and Mark Rowe.
2209
2210         WebKitTestRunner needs the HOME environment variable to be set.
2211         <rdar://problem/8896573>
2212
2213         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
2214         it exists.
2215
2216 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2217
2218         Reviewed by Eric Seidel.
2219
2220         Suppress a few remaining integration tests so that none of the
2221         layout_test unit tests ever read from the filesystem or launch
2222         subprocesses that aren't part of the unit tests.
2223
2224         Also fix a minor bug in the printing unit tests that was
2225         incorrectly relying on sys.argv.
2226
2227         https://bugs.webkit.org/show_bug.cgi?id=52863
2228
2229         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2230         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2231         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2232
2233 2011-01-21  Darin Adler  <darin@apple.com>
2234
2235        Fix Mac build.
2236
2237         * MiniBrowser/mac/BrowserWindowController.m:
2238         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
2239
2240 2011-01-20  Darin Adler  <darin@apple.com>
2241
2242         Reviewed by Dan Bernstein.
2243
2244         WebKit2: Implement showModalDialog
2245         https://bugs.webkit.org/show_bug.cgi?id=52855
2246
2247         This fixes WebKitTestRunner to compile, but more work is probably
2248         needed to get it to pass the tests.
2249
2250         * WebKitTestRunner/TestController.cpp:
2251         (WTR::TestController::runModal): Added. Calls through to the
2252         platform-specific version of runModal.
2253         (WTR::TestController::createOtherPage): Changed to be a private
2254         static member function so it can refer to runModal, which is
2255         a private static member function.
2256         (WTR::TestController::initialize): Pass 0 for the runModal
2257         function since we don't need to run the main window modal.
2258         I suspect this is wrong and will need to change.
2259         * WebKitTestRunner/TestController.h: Added declarations for
2260         the functions added above.
2261         * WebKitTestRunner/mac/TestControllerMac.mm:
2262         (WTR::TestController::runModal): Added. Untested implementation.
2263         * WebKitTestRunner/qt/TestControllerQt.cpp:
2264         (WTR::TestController::runModal): Added.
2265         * WebKitTestRunner/win/TestControllerWin.cpp:
2266         (WTR::TestController::runModal): Added.
2267
2268 2011-01-21  Eric Seidel  <eric@webkit.org>
2269
2270         Reviewed by Adam Barth.
2271
2272         Split Host object off from WebKitPatch for easier re-use
2273         https://bugs.webkit.org/show_bug.cgi?id=52284
2274
2275         new-run-webkit-tests and other tools are eventually going to want one of these.
2276         Basically you need to inherit from this class if you want to pretend to be a
2277         self.tool object for Steps/Commands.
2278
2279         * Scripts/webkitpy/common/host.py: Added.
2280         * Scripts/webkitpy/tool/main.py:
2281
2282 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2283
2284         Reviewed by Adam Barth.
2285
2286         Disable the tests that start and stop the http server and web
2287         server, so that we don't have to worry about port collisions on
2288         the bots.
2289
2290         https://bugs.webkit.org/show_bug.cgi?id=52861
2291
2292         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2293
2294 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2295
2296         Reviewed by Eric Seidel.
2297
2298         nrwt: rewrite google_chrome_unittest to use mock filesystem.
2299         
2300         https://bugs.webkit.org/show_bug.cgi?id=52772
2301         
2302         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2303
2304 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2305
2306         Reviewed by Eric Siedel.
2307
2308         nrwt: clean up almost all remaining port references, remove
2309         unnecessary import clauses. The only remaining references are
2310         in places where a mock filesystem makes no sense or can't be
2311         used, and in one routine in port/google_chrome_unittest that
2312         I'll rewrite in a separate patch.
2313
2314         https://bugs.webkit.org/show_bug.cgi?id=52771
2315
2316         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2317         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2318         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2319         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2320         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2321         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2322         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2323         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2324         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2325         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2326         * Scripts/webkitpy/layout_tests/port/gtk.py:
2327         * Scripts/webkitpy/layout_tests/port/mac.py:
2328         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2329         * Scripts/webkitpy/layout_tests/port/qt.py:
2330         * Scripts/webkitpy/layout_tests/port/webkit.py:
2331         * Scripts/webkitpy/layout_tests/port/win.py:
2332         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2333
2334 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2335
2336         Reviewed by Mihai Parparita.
2337
2338         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
2339
2340         https://bugs.webkit.org/show_bug.cgi?id=52762
2341
2342         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2343         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2344
2345 2011-01-20  Tony Chang  <tony@chromium.org>
2346
2347         Reviewed by Ojan Vafai.
2348
2349         [chromium] fix the paths used for the rebaseline tool
2350         https://bugs.webkit.org/show_bug.cgi?id=52857
2351
2352         Some of the bots were renamed so the path to grab the results zip
2353         file has changed.
2354
2355         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2356
2357 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2358
2359         Reviewed by Tony Chang.
2360
2361         Fix bug introduced in r72688 / bug 52768 that broke the
2362         generation of the output filename links in the results.html
2363         output. Apparently none of the unit tests actually checked to
2364         make sure the generated links were correct :(
2365
2366         https://bugs.webkit.org/show_bug.cgi?id=52854
2367
2368         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2369         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2370
2371 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
2372
2373         Reviewed by Darin Adler.
2374
2375         https://bugs.webkit.org/show_bug.cgi?id=52849
2376         Make window.print work with WebKit2
2377
2378         * MiniBrowser/mac/BrowserWindowController.m:
2379         (-[BrowserWindowController awakeFromNib]):
2380         * WebKitTestRunner/TestController.cpp:
2381         (WTR::createOtherPage):
2382         (WTR::TestController::initialize):
2383         Added zeroes to WKPageUIClient structures to avoid build failures.
2384
2385 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2386
2387         Reviewed by Eric Seidel.
2388
2389         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
2390
2391         https://bugs.webkit.org/show_bug.cgi?id=52756
2392
2393         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2394         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2395         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2396         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2397         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2398         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2399
2400 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
2401
2402         Reviewed by Antonio Gomes.
2403
2404         QtTestBrowser should have a seperate menu for Settings
2405         https://bugs.webkit.org/show_bug.cgi?id=52817
2406         
2407         Added a new menu item named "Settings"
2408         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
2409
2410         * QtTestBrowser/launcherwindow.cpp:
2411         (LauncherWindow::createChrome):
2412
2413 2011-01-20  Sam Weinig  <sam@webkit.org>
2414
2415         Reviewed by John Sullivan.
2416
2417         Update update-webkit-localizable-strings with new path to WebKit.
2418
2419         * Scripts/update-webkit-localizable-strings:
2420
2421 2011-01-20  James Robinson  <jamesr@chromium.org>
2422
2423         Reviewed by Darin Fisher.
2424
2425         Implement mozilla's requestAnimationFrame API
2426         https://bugs.webkit.org/show_bug.cgi?id=51218
2427
2428         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2429
2430         * DumpRenderTree/chromium/WebViewHost.cpp:
2431         (invokeScheduleComposite):
2432         (WebViewHost::scheduleAnimation):
2433         (WebViewHost::paintInvalidatedRegion):
2434         * DumpRenderTree/chromium/WebViewHost.h:
2435
2436 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
2437
2438         Reviewed by Adam Roben.
2439
2440         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
2441         https://bugs.webkit.org/show_bug.cgi?id=42327
2442
2443         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
2444         for methods that take their normal arguments but also a JSContextRef.
2445         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
2446         for evaluateScriptInIsolatedWorld.
2447         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2448         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
2449         this call is for an isolated world.
2450         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2451         (WTR::worldMap): Helper to create a world map.
2452         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
2453         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
2454         added LayoutTestController API.
2455         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2456
2457 2011-01-19  Adam Roben  <aroben@apple.com>
2458
2459         Convert paths in environment variables back to msys-style inside commit-log-editor
2460
2461         When this script gets run from inside git commit, msys-style paths in the environment will
2462         have been turned into Windows-style paths with forward slashes. This screws up functions
2463         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2464         the paths back to msys-style before doing anything else.
2465
2466         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2467         using msysgit's Perl and multiple ChangeLogs have been edited
2468
2469         Reviewed by David Kilzer.
2470
2471         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2472         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2473         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2474
2475 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2476
2477         [Win] Unreviewed build fix after r76248.
2478
2479         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2480
2481 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2482
2483         Reviewed by Csaba Osztrogonác.
2484
2485         Refactoring of the custom allocation framework
2486         https://bugs.webkit.org/show_bug.cgi?id=49897
2487
2488         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2489         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2490         equivalent macro implementation at the necessary places.
2491 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2492
2493         Unreviewed. 
2494
2495         Adding myself to committers.py.
2496
2497         * Scripts/webkitpy/common/config/committers.py:
2498
2499 2011-01-20  Adam Barth  <abarth@webkit.org>
2500
2501         Reviewed by Tony Chang.
2502
2503         Chromium builders don't delete unversioned directories when DEPS change
2504         https://bugs.webkit.org/show_bug.cgi?id=52745
2505
2506         If we pass this option to gclient sync, gclient will delete directories
2507         that are no longer part of DEPS instead of leaving them around to
2508         confuse us later.  Apparently, the downstream buildbots use this option
2509         already.
2510
2511         * Scripts/update-webkit-chromium:
2512
2513 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2514
2515         Unreviewed, build fix - I pulled this patch in to fix an issue
2516         revealed by r76195 running on some new bots). Also fix a couple
2517         of other issues revealed in testing.
2518
2519         nrwt: remove fs refs from layout_package/json*
2520
2521         https://bugs.webkit.org/show_bug.cgi?id=52754
2522
2523         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2524         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2525         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2526         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2527         * Scripts/webkitpy/layout_tests/port/base.py:
2528
2529 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2530
2531         Unreviewed, build fix.
2532
2533         Fix a couple of minor bugs discovered while bringing up new bots
2534         for testing.
2535
2536         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2538
2539 2011-01-19  James Robinson  <jamesr@chromium.org>
2540
2541         Unreviewed, rolling out r76194.
2542         http://trac.webkit.org/changeset/76194
2543         https://bugs.webkit.org/show_bug.cgi?id=51218
2544
2545         Caused mysterious compile failure on the chromium win
2546         build.webkit.org bots
2547
2548         * DumpRenderTree/chromium/WebViewHost.cpp:
2549         (WebViewHost::paintInvalidatedRegion):
2550         * DumpRenderTree/chromium/WebViewHost.h:
2551
2552 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2553
2554         Reviewed by Mihai Parparita.
2555
2556         remove fs refs from test_runner, dump_render_tree_thread
2557
2558         https://bugs.webkit.org/show_bug.cgi?id=52753
2559
2560         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2561         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2562         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2563         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2564
2565 2011-01-19  James Robinson  <jamesr@chromium.org>
2566
2567         Reviewed by Darin Fisher.
2568
2569         Implement mozilla's requestAnimationFrame API
2570         https://bugs.webkit.org/show_bug.cgi?id=51218
2571
2572         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2573
2574         * DumpRenderTree/chromium/WebViewHost.cpp:
2575         (invokeScheduleComposite):
2576         (WebViewHost::scheduleAnimation):
2577         (WebViewHost::paintInvalidatedRegion):
2578         * DumpRenderTree/chromium/WebViewHost.h:
2579
2580 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2581
2582         Unreviewed, build fix.
2583
2584         Fix a few incorrect "self._filesystem" references introduced in
2585         r76184.
2586
2587         * Scripts/webkitpy/layout_tests/port/chromium.py:
2588         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2589
2590 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2591
2592         Reviewed by Mihai Parparita.
2593
2594         add a .sep property, abspath(), isabs(), mtime(), and
2595         open_text_file_for_writing() to filesystem modules. Some of
2596         these properties are not needed in this patch but will be needed
2597         in subsequent patches (I'm doing this to avoid having to track
2598         multiple versions of a single file).
2599
2600         Also, change most of the port/* modules to use the filesystem
2601         objects instead of referencing the filesystem directly.
2602
2603         https://bugs.webkit.org/show_bug.cgi?id=52748
2604
2605         * Scripts/webkitpy/common/system/filesystem.py:
2606         * Scripts/webkitpy/common/system/filesystem_mock.py:
2607         * Scripts/webkitpy/layout_tests/port/__init__.py:
2608         * Scripts/webkitpy/layout_tests/port/base.py:
2609         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2610         * Scripts/webkitpy/layout_tests/port/chromium.py:
2611         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2612         * Scripts/webkitpy/layout_tests/port/config.py:
2613         * Scripts/webkitpy/layout_tests/port/test.py:
2614         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2615
2616 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2617
2618         Reviewed by Anders Carlsson.
2619
2620         If resetting between tests times out, treat it as a WebProcess crash
2621         https://bugs.webkit.org/show_bug.cgi?id=52757
2622
2623         * WebKitTestRunner/TestController.cpp:
2624         (WTR::TestController::runTest):
2625
2626 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2627
2628         Reviewed by Darin Adler.
2629
2630         https://bugs.webkit.org/show_bug.cgi?id=52739
2631         Make it possible for a WebKit2 client to print headers and footers
2632
2633         Added dummy implementations for new printing UIClient calls.
2634
2635         * MiniBrowser/mac/BrowserWindowController.m:
2636         (-[BrowserWindowController awakeFromNib]):
2637         * WebKitTestRunner/TestController.cpp:
2638         (WTR::createOtherPage):
2639         (WTR::TestController::initialize):
2640
2641 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2642
2643         Reviewed by Ojan Vafai.
2644
2645         Change webkitpy/layout_tests/port/test.py to use the
2646         in-memory filesystem for cleaner unit testing. This
2647         change allows us to kill a lot of code that was
2648         specific to the test port, at the cost of being a
2649         little less clear about how things would work if
2650         you didn't have a filesystem.
2651
2652         https://bugs.webkit.org/show_bug.cgi?id=52605
2653
2654         * Scripts/webkitpy/layout_tests/port/test.py:
2655
2656 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2657
2658         Unreviewed, build fix.
2659
2660         Fix test failure caused by committing attachment 79368 instead
2661         of attachment 79461 on bug 52604.
2662
2663         * Scripts/webkitpy/common/system/filesystem_mock.py:
2664
2665 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2666
2667         Reviewed by Mihai Parparita.
2668
2669         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2670         unit testing. os.walk() is too much of a hassle to implement on
2671         top of the in-memory mock filesystem and adding the necessary
2672         interface to files_under() gives clients a cleaner API anyway
2673         (for this particular usage model).
2674
2675         https://bugs.webkit.org/show_bug.cgi?id=52691
2676
2677         * Scripts/webkitpy/common/system/filesystem.py:
2678         * Scripts/webkitpy/common/system/filesystem_mock.py:
2679         * Scripts/webkitpy/layout_tests/port/test_files.py:
2680         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2681
2682 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2683
2684         Reviewed by Tony Chang.
2685
2686         Change more modules in the layout-tests code to use the
2687         filesystem wrapper for cleaner unit testing.
2688
2689         This patch also adds the glob() wrapper to the filesystem
2690         abstraction.
2691         
2692         https://bugs.webkit.org/show_bug.cgi?id=52604
2693
2694         * Scripts/webkitpy/layout_tests/port/test_files.py:
2695         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2696         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2697         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2698         * Scripts/webkitpy/common/system/filesystem.py:
2699         * Scripts/webkitpy/common/system/filesystem_mock.py:
2700
2701 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2702
2703         Unreviewed.
2704
2705         Updating my email addresses and irc nick.
2706
2707         * Scripts/webkitpy/common/config/committers.py:
2708
2709 2011-01-19  Tony Chang  <tony@chromium.org>
2710
2711         Reviewed by Mihai Parparita.
2712
2713         [chromium] [linux] if check-sys-deps fails, output the failure reason
2714         https://bugs.webkit.org/show_bug.cgi?id=52671
2715
2716         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2717             error handler functions.
2718         * Scripts/webkitpy/layout_tests/port/chromium.py:
2719             output the error text from --check-sys-deps
2720         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2721
2722 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2723
2724         Reviewed by Andreas Kling.
2725
2726         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2727         https://bugs.webkit.org/show_bug.cgi?id=52554
2728         
2729         QtNetworkAccessManager is created in a thread and set as
2730         member variable in QWebPage. When the thread is destroyed
2731         the object is still used. So fix will set the object to
2732         NULL once the thread is destroyed.
2733
2734         * QtTestBrowser/launcherwindow.cpp:
2735         (LauncherWindow::~LauncherWindow):
2736
2737 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2738
2739         Rubber stamped by Csaba Osztrogonac
2740
2741         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2742
2743 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2744
2745         Reviewed by Tony Chang.
2746
2747         new-run-webkit-tests: add a --build-directory command line argument
2748
2749         Official Google Chrome builds use a non-standard build directory
2750         location. This patch adds a --build-directory argument that
2751         allows that location to be specified on the command line. Only
2752         Chromium-based builds will use this flag for now, but anyone can
2753         in the future.
2754
2755         There are no unit tests for this since it's difficult to test
2756         until mock filesystems are fully supported in the code. This was
2757         tested by hand for now.
2758
2759         https://bugs.webkit.org/show_bug.cgi?id=52694
2760
2761         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2762         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2763         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2764         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2765
2766 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2767
2768         Not reviewed. Bot fix.
2769
2770         Remove an inadvertently committed debugging print.
2771
2772         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2773         (LayoutTestController::notifyDone):
2774
2775 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2776
2777         Reviewed by Sam Weinig.
2778
2779         WebKitTestRunner should track loading more like DumpRenderTree
2780         https://bugs.webkit.org/show_bug.cgi?id=52692
2781
2782         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2783         This makes some tests that call notifyDone multiple times pass.
2784         
2785         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2786         (WTR::InjectedBundle::InjectedBundle):
2787         (WTR::InjectedBundle::done):
2788         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2789         (WTR::InjectedBundle::topLoadingFrame):
2790         (WTR::InjectedBundle::setTopLoadingFrame):
2791         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2792         (WTR::InjectedBundlePage::InjectedBundlePage):
2793         (WTR::InjectedBundlePage::stopLoading):
2794         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2795         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2796         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2797         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2798         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2799         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2800         (WTR::LayoutTestController::notifyDone):
2801         * WebKitTestRunner/TestController.cpp:
2802         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2803
2804 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2805
2806         Reviewed by Kent Tamura.
2807
2808         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2809         https://bugs.webkit.org/show_bug.cgi?id=52678
2810         
2811         Update path now that WebKit is inside Source.
2812
2813         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2814
2815 2011-01-18  Robert Hogan  <robert@webkit.org>
2816
2817         Reviewed by Simon Hausmann.
2818
2819         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2820         https://bugs.webkit.org/show_bug.cgi?id=44282
2821
2822         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2823         (WebCore::DumpRenderTree::dump):
2824
2825 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2826
2827         Reviewed by Mihai Parparita.
2828
2829         Fix a small race condition that could cause the unit tests for
2830         new-run-webkit-tests to fail in a multithreaded environment.
2831         There was a small window in the code where one thread would
2832         check to see if a thread had raised an exception, do something,
2833         and then check to see if the thread was alive. If the other
2834         thread raised an exception and exited in between these two
2835         steps, the exception would be lost. Flipping the order of the
2836         two checks fixes the race, since we will now always check for an
2837         exception on the thread before exiting.
2838
2839         https://bugs.webkit.org/show_bug.cgi?id=51579
2840
2841         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2842
2843 2011-01-18  Eric Seidel  <eric@webkit.org>
2844
2845         Reviewed by Adam Barth.
2846
2847         commit-queue dies when test archiving fails
2848         https://bugs.webkit.org/show_bug.cgi?id=52617
2849
2850         I looked at the machine and it had 10 archives already
2851         thus find_unused_name was returning None.  I've upped
2852         the limit to 100 (per bug) and tested the case where
2853         find_unused_name returns None (making archive return None).
2854
2855         * Scripts/webkitpy/common/system/workspace.py:
2856         * Scripts/webkitpy/common/system/workspace_unittest.py:
2857         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2858         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2859         * Scripts/webkitpy/tool/commands/queues.py:
2860
2861 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2862
2863         Reviewed by Ojan Vafai.
2864
2865         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2866         filesystem. Also fix a couple of "with" statements missed by
2867         r76050.
2868
2869         https://bugs.webkit.org/show_bug.cgi?id=52487
2870
2871         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2872
2873 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2874
2875         Reviewed by Martin Robinson.
2876
2877         [Gtk] Build fixes for gtk3 build
2878         https://bugs.webkit.org/show_bug.cgi?id=52648
2879
2880         * DumpRenderTree/gtk/EventSender.cpp:
2881         (beginDragWithFilesCallback):
2882
2883 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2884
2885         Reviewed by Mihai Parparita.
2886
2887         Update rebaseline-chromium-webkit-tests to use filesystem objects
2888         instead of direct references to os.path, shutil, tempfile, etc.
2889
2890         This patch doesn't change anything, but will allow subsequent
2891         patches to change the unit tests to no longer use the real
2892         filesystem.
2893
2894         This patch adds a bunch more methods to the filesystem object as
2895         well.
2896
2897         https://bugs.webkit.org/show_bug.cgi?id=52482
2898
2899         * Scripts/webkitpy/common/system/filesystem.py:
2900         * Scripts/webkitpy/common/system/filesystem_mock.py:
2901         * Scripts/webkitpy/tool/commands/queues.py:
2902         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2903         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2904
2905 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2906
2907         Reviewed by Mihai Parparita.
2908
2909         new-run-webkit-tests shouldn't crash when you try to run a
2910         directory containing only skipped files.
2911
2912         https://bugs.webkit.org/show_bug.cgi?id=52478
2913         
2914         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2915         * Scripts/webkitpy/layout_tests/port/test.py:
2916         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2917
2918 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2919
2920         Reviewed by Gustavo Noronha Silva.
2921
2922         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2923         https://bugs.webkit.org/show_bug.cgi?id=40833
2924
2925         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2926         GTK+ event sender.
2927         (dragWithFilesDragDataGetCallback): Added.
2928         (dragWithFilesDragEndCallback): Added.
2929         (beginDragWithFilesCallback): Added.
2930
2931 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2932
2933         Reviewed by Adam Barth.
2934
2935         ews: Add additional watcher to efl ews
2936         https://bugs.webkit.org/show_bug.cgi?id=52613
2937
2938         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2939
2940         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2941
2942 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2943
2944         Reviewed by Alexey Proskuryakov.
2945
2946         Fix some headers with missing or misspelled #ifndef guards
2947         https://bugs.webkit.org/show_bug.cgi?id=52545
2948
2949         * DumpRenderTree/chromium/TestEventPrinter.h:
2950         * DumpRenderTree/chromium/WebPreferences.h:
2951
2952 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2953
2954         Reviewed by Anders Carlsson.
2955
2956         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2957         navigating back to an unreachable URL
2958         https://bugs.webkit.org/show_bug.cgi?id=52388
2959
2960         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2961
2962         * DumpRenderTree/LayoutTestController.cpp:
2963         (queueLoadHTMLStringCallback):
2964         (LayoutTestController::queueLoadHTMLString):
2965         (LayoutTestController::queueLoadAlternateHTMLString):
2966         * DumpRenderTree/LayoutTestController.h:
2967
2968         * DumpRenderTree/WorkQueueItem.h:
2969         (LoadHTMLStringItem::LoadHTMLStringItem):
2970
2971         * DumpRenderTree/chromium/LayoutTestController.cpp:
2972         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2973         (WorkItemLoadHTMLString::run):
2974         (LayoutTestController::queueLoadHTMLString):
2975
2976         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2977         (LoadHTMLStringItem::invoke):
2978         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2979         (LoadHTMLStringItem::invoke):
2980         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2981         (LoadHTMLStringItem::invoke):
2982
2983 2011-01-17  Dan Bernstein  <mitz@apple.com>
2984
2985         Rubber-stamped by Mark Rowe.
2986
2987         Update xcodeproj svn:ignore to include xcuserdata.
2988
2989         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2990         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2991         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2992         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2993         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2994
2995 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2996
2997         Unreviewed fix after r75908.
2998
2999         Move WebKit into Source
3000         https://bugs.webkit.org/show_bug.cgi?id=52530
3001
3002         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
3003
3004 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
3005
3006         Unreviewed.
3007
3008         Remove accidentally committed debug printing after r75908.
3009
3010         * Scripts/webkitdirs.pm:
3011
3012 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3013
3014         Unreviewed.
3015
3016         Add myself to committers list
3017         https://bugs.webkit.org/show_bug.cgi?id=52566
3018
3019         * Scripts/webkitpy/common/config/committers.py:
3020
3021 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
3022
3023         Reviewed by Jeremy Orlow.
3024
3025         GeolocationController should call stopUpdating on destruction
3026         https://bugs.webkit.org/show_bug.cgi?id=52216
3027
3028         fast/dom/Geolocation/window-close-crash.html requires that a
3029         Geolocation watch be started in a secondary window. Consequently,
3030         we need to allow geolocation permission and provide a mock
3031         geolocation position for the secondary window's
3032         GeolocationClientMock.
3033
3034         * DumpRenderTree/chromium/LayoutTestController.cpp:
3035         (LayoutTestController::setGeolocationPermission):
3036         (LayoutTestController::setMockGeolocationPosition):
3037         (LayoutTestController::setMockGeolocationError):
3038         * DumpRenderTree/chromium/TestShell.h:
3039         (TestShell::windowList):
3040
3041 2011-01-16  Adam Barth  <abarth@webkit.org>
3042
3043         Update more include paths to reflect WebKit move.
3044
3045         * DumpRenderTree/chromium/EventSender.cpp:
3046         (EventSender::keyDown):
3047         (EventSender::needsShiftModifier):
3048         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3049         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3050
3051 2011-01-16  Kent Tamura  <tkent@chromium.org>
3052
3053         Unreviewed, Chromium build fix.
3054
3055         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
3056
3057 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
3058
3059         Build fix for GTK+ after source directory movement.
3060
3061         * GNUmakefile.am: Correct include paths.
3062
3063 2011-01-16  Adam Barth  <abarth@webkit.org>
3064
3065         Teach svn-apply about WebKit move.
3066
3067         * Scripts/VCSUtils.pm:
3068
3069 2011-01-16  Adam Barth  <abarth@webkit.org>
3070
3071         Rubber-stamped by Eric Seidel.
3072
3073         Move WebKit into Source
3074         https://bugs.webkit.org/show_bug.cgi?id=52530
3075
3076         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3077         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3078         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3079         * DumpRenderTree/qt/GCControllerQt.cpp:
3080         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3081         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
3082         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3083         * DumpRenderTree/wscript:
3084         * QtTestBrowser/launcherwindow.h:
3085         * Scripts/build-webkit:
3086         * Scripts/webkitdirs.pm:
3087
3088 2011-01-15  Adam Barth  <abarth@webkit.org>
3089
3090         Teach svn-apply about WebKit2 move.
3091
3092         * Scripts/VCSUtils.pm:
3093
3094 2011-01-15  Adam Barth  <abarth@webkit.org>
3095
3096         Rubber-stamped by Eric Seidel.
3097
3098         Move WebKit2 into Source
3099         https://bugs.webkit.org/show_bug.cgi?id=52438
3100
3101         * MiniBrowser/qt/MiniBrowser.pro:
3102         * Scripts/build-webkit:
3103         * Scripts/do-file-rename:
3104         * Scripts/do-webcore-rename:
3105         * Scripts/test-webkitpy:
3106         * Scripts/webkitdirs.pm:
3107         * Scripts/webkitpy/style/checker.py:
3108         * WebKitTestRunner/DerivedSources.pro:
3109         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3110         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3111
3112 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
3113
3114         Reviewed by David Levin.
3115
3116         [chromium] remove obsolete createView method
3117         https://bugs.webkit.org/show_bug.cgi?id=52437
3118
3119         * DumpRenderTree/chromium/WebViewHost.cpp:
3120         (WebViewHost::createView):
3121         * DumpRenderTree/chromium/WebViewHost.h:
3122
3123 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
3124
3125         Reviewed by Geoff Garen.
3126
3127         ShouldLoadResourceForFrame should use strings, not URLs.
3128         https://bugs.webkit.org/show_bug.cgi?id=52476
3129
3130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3131         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
3132         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3133
3134 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
3135
3136         Reviewed by David Levin.
3137
3138         Add Tony Gentilcore as a reviewer
3139         https://bugs.webkit.org/show_bug.cgi?id=52480
3140
3141         * Scripts/webkitpy/common/config/committers.py:
3142
3143 2011-01-14  David Levin  <levin@chromium.org>
3144
3145         Reviewed by Eric Seidel.
3146
3147         check-webkit-style: _FunctionState should keep track of where the function name starts.
3148         https://bugs.webkit.org/show_bug.cgi?id=52454
3149
3150         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
3151         _FunctionState and logic for setting it correctly.
3152         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
3153
3154 2011-01-14  Vincent Scheib  <scheib@chromium.org>
3155
3156         Reviewed by David Levin.
3157
3158         Add support to DumpRenderTree to use the GPU rather than software renderer
3159         https://bugs.webkit.org/show_bug.cgi?id=52333
3160
3161         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3162         (main):
3163         * Scripts/webkitpy/layout_tests/port/chromium.py:
3164         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3165
3166 2011-01-14  Tony Chang  <tony@chromium.org>
3167
3168         Reviewed by Kent Tamura.
3169
3170         [chromium] update fonts.conf to fix 6 linux tests in drt
3171         https://bugs.webkit.org/show_bug.cgi?id=52411
3172
3173         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
3174             chromium's src/webkit/tools/test_shell/resources/fonts.conf
3175
3176 2011-01-14  Eric Seidel  <eric@webkit.org>
3177
3178         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
3179
3180         Reviewed by Adam Barth.
3181
3182         Fix when running Tools/Scripts/check-webkit-style without arguments.
3183         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
3184
3185         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
3186         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3187
3188 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
3189
3190         Reviewed by David Levin.
3191
3192         Store the tempdir object in a variable so it doesn't get deleted too early.
3193         https://bugs.webkit.org/show_bug.cgi?id=51875
3194
3195         * Scripts/update-webkit-auxiliary-libs:
3196         * Scripts/update-webkit-support-libs:
3197
3198 2011-01-14  Eric Seidel  <eric@webkit.org>
3199
3200         Unreviewed.  Make it work in python 2.5.
3201
3202         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3203         https://bugs.webkit.org/show_bug.cgi?id=49158
3204
3205         * Scripts/webkitpy/common/checkout/api_unittest.py:
3206
3207 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3208
3209         Unreviewed, rolling out r75774.
3210         http://trac.webkit.org/changeset/75774
3211         https://bugs.webkit.org/show_bug.cgi?id=52431
3212
3213         gtk builds were broken (Requested by loislo2 on #webkit).
3214
3215         * Scripts/webkitpy/common/checkout/scm.py:
3216
3217 2011-01-14  David Levin  <levin@chromium.org>
3218
3219         Reviewed by Shinichiro Hamaji.
3220
3221         check-webkit-style: _FunctionState should detect pure functions.
3222         https://bugs.webkit.org/show_bug.cgi?id=52428
3223
3224         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
3225         is a pure virtual function.
3226         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
3227         virtual functions are correctly detected.
3228
3229 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
3230
3231         Reviewed by Yury Semikhatsky.
3232
3233         Just small fix for problem with check-webkit-style.
3234         It just didn't work for this patch.
3235         Old code can't concatenate a list of strings with None.
3236
3237         * Scripts/webkitpy/common/checkout/scm.py:
3238
3239 2011-01-13  David Levin  <levin@chromium.org>
3240
3241         Reviewed by Shinichiro Hamaji.
3242
3243         check-webkit-style: _FunctionState should use Position to know where items are.
3244         https://bugs.webkit.org/show_bug.cgi?id=52424
3245
3246         * Scripts/webkitpy/style/checkers/cpp.py:
3247         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
3248         (detect_functions): Changed to pass Position's to _FunctionState.begin and
3249         did some minor clean-up.
3250         (*): Other changes are simply about converting to use the Position's in_FunctionState
3251         instead of line numbers.
3252         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
3253         to verify the positions stored in _FunctionState.
3254
3255 2011-01-13  Eric Seidel  <eric@webkit.org>
3256
3257         Reviewed by David Levin.
3258
3259         webkit-patch suggest-reviewers dies when ChangeLogs are missing
3260         https://bugs.webkit.org/show_bug.cgi?id=49158
3261
3262         This is not the most elegant, but it is a very safe fix to this bug.
3263         One advantage of catching ScriptError like this instead of adding a
3264         new added_or_modified_files or fixing all changed_files callers
3265         to use a more specific change_files variant, is that we catch
3266         all kinds of ScriptErrors which might cause our (non-essential)
3267         suggest-reviewers code to fail out.  This should make passing
3268         --suggest-reviewers to webkit-patch upload much more robust
3269         and may even make it possible for us to make it default.
3270
3271         The root of the problem here is that SCM.changed_files includes
3272         deleted ChangeLog paths (from moves, etc) which then when we ask
3273         SVN/Git for the contents of the file at that revision, the command
3274         errors out and Executive.run_command raises a ScriptError.
3275
3276         In the future we might fix this differently by making all current
3277         callers of chagned_files use a more specific method for requesting
3278         what types of changes they're interested in (adds, modifies, deletes, etc.)
3279
3280         * Scripts/webkitpy/common/checkout/api.py:
3281         * Scripts/webkitpy/common/checkout/api_unittest.py:
3282
3283 2011-01-13  Dan Bernstein  <mitz@apple.com>
3284
3285         Reviewed by Alexey Proskuryakov.
3286
3287         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
3288         https://bugs.webkit.org/show_bug.cgi?id=52419
3289
3290         Allow to further control the behavior of the willSendRequest delegate callback by making it
3291         set a different URL in the new request.
3292
3293         * DumpRenderTree/LayoutTestController.cpp:
3294         (addURLToRedirectCallback): Added.
3295         (LayoutTestController::staticFunctions): Added addURLToRedirect.
3296         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
3297         (LayoutTestController::redirectionDestinationForURL): Added this getter.
3298         * DumpRenderTree/LayoutTestController.h:
3299         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3300         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
3301         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
3302         change the URL in the new request to the redirect destination.
3303
3304 2011-01-13  Eric Seidel  <eric@webkit.org>
3305
3306         Reviewed by Mihai Parparita.
3307
3308         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
3309         https://bugs.webkit.org/show_bug.cgi?id=52416
3310
3311         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
3312         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
3313
3314         I also added FIXMEs about the changed_files returning deleted files problem
3315         which is causing the other most common exception for suggest-reviewers
3316         (and is probably breaking sheriff-bots blame detection).
3317
3318         * Scripts/webkitpy/common/checkout/api.py:
3319         * Scripts/webkitpy/common/checkout/api_unittest.py:
3320         * Scripts/webkitpy/common/checkout/scm.py:
3321
3322 2011-01-13  Eric Seidel  <eric@webkit.org>
3323
3324         Reviewed by Adam Barth.
3325
3326         results archives from commit-queue are too large to upload
3327         https://bugs.webkit.org/show_bug.cgi?id=52405
3328
3329         * Scripts/webkitpy/common/system/filesystem.py:
3330         * Scripts/webkitpy/common/system/filesystem_mock.py:
3331         * Scripts/webkitpy/tool/commands/queues.py:
3332
3333 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
3334
3335         Reviewed by Martin Robinson.
3336
3337         [gtk] Zero-sized font does not yet work
3338         https://bugs.webkit.org/show_bug.cgi?id=49793
3339
3340         Set minimum-font-size to 0 for the DRT.
3341
3342         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3343         (resetDefaultsToConsistentValues):
3344
3345 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3346
3347         Reviewed by Darin Adler.
3348
3349         Make old-run-webkit-tests more robust on buildbots
3350         https://bugs.webkit.org/show_bug.cgi?id=52364
3351
3352         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
3353
3354 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
3355
3356         Reviewed by Darin Adler.
3357
3358         Make old-run-webkit-tests more robust on buildbots
3359         https://bugs.webkit.org/show_bug.cgi?id=52364
3360
3361         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
3362
3363 2011-01-13  Tony Chang  <tony@chromium.org>
3364
3365         Reviewed by Kent Tamura.
3366
3367         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
3368         https://bugs.webkit.org/show_bug.cgi?id=52332
3369
3370         Forked Info.plist is not longer needed.
3371
3372         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
3373
3374 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
3375
3376         Reviewed by Timothy Hatcher.
3377
3378         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
3379         to be passed directly to WebInspector.UIString
3380
3381         https://bugs.webkit.org/show_bug.cgi?id=52365
3382
3383         * Scripts/check-inspector-strings:
3384
3385 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
3386
3387         Unreviewed, rolling out r74881.
3388         http://trac.webkit.org/changeset/74881
3389         https://bugs.webkit.org/show_bug.cgi?id=52357
3390
3391         The EFL builder has been red for days (Requested by abarth on
3392         #webkit).
3393
3394         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3395         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3396
3397 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3398
3399         Reviewed by David Levin.
3400
3401         Add beforeunload support to WebKitTestRunner
3402         https://bugs.webkit.org/show_bug.cgi?id=52353
3403         
3404         This makes a number of currently failing tests pass.
3405
3406         * WebKitTestRunner/TestController.cpp:
3407         (WTR::runBeforeUnloadConfirmPanel):
3408         (WTR::createOtherPage):
3409         (WTR::TestController::initialize):
3410
3411 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3412
3413         Reviewed by Sam Weinig.
3414
3415         Detect, identify and recover from WebProcess crashes in run-webkit-tests
3416         https://bugs.webkit.org/show_bug.cgi?id=52330
3417
3418         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
3419         a web process crash.
3420         * WebKitTestRunner/TestController.cpp:
3421         (WTR::TestController::initialize): Set up a processDidCrash
3422         callback.
3423         (WTR::TestController::processDidCrash): Report that the Web process
3424         crashed.
3425         * WebKitTestRunner/TestController.h:
3426
3427 2011-01-12  David Levin  <levin@chromium.org>
3428
3429         Reviewed by Shinichiro Hamaji.
3430
3431         check-webkit-style -- close_expression function doesn't work correctly.
3432         https://bugs.webkit.org/show_bug.cgi?id=52272
3433
3434         * Scripts/webkitpy/style/checkers/cpp.py:
3435         (Position.__str__): Added a way to convert it to a string which is useful in tests.
3436         (Position.__cmp__): Added a way to compare Position which is useful in tests and
3437         generally useful (for upcoming code changes).
3438         (close_expression): Changed to use Position for input and output.
3439         Also, fixed many bugs such as only working correctly for parenthesis,
3440         not working correctly if given an offset in a line and not finding
3441         the real closing element if there were multiple closing elements in
3442         the same line.
3443         (detect_functions): Adjusted due to the change in arguments for
3444         close_expression.
3445         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3446         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
3447         two positions are the same.
3448         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
3449         (CppStyleTest.test_close_expression): Added tests to catch the issues
3450         that were fixed.
3451
3452 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3453
3454         Unreviewed, rolling out r75576.
3455         http://trac.webkit.org/changeset/75576
3456         https://bugs.webkit.org/show_bug.cgi?id=52304
3457
3458         broke rebaseline-chromium-webkit-test (Requested by thakis on
3459         #webkit).
3460
3461         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3462         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3463         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3464         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3465         * Scripts/webkitpy/layout_tests/port/base.py:
3466         * Scripts/webkitpy/layout_tests/port/chromium.py:
3467         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3468         * Scripts/webkitpy/layout_tests/port/test.py:
3469         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3470         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3471         * Scripts/webkitpy/style/checkers/test_expectations.py:
3472         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3473
3474 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3475
3476         Reviewed by Darin Adler.
3477
3478         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3479         https://bugs.webkit.org/show_bug.cgi?id=52307
3480
3481         * Scripts/old-run-webkit-tests:
3482
3483 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3484
3485         Reviewed by Martin Robinson.
3486
3487         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3488         https://bugs.webkit.org/show_bug.cgi?id=50867
3489
3490         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3491         TestNetscapePlugin.cpp 
3492
3493         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3494         * Scripts/webkitdirs.pm:
3495
3496 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3497
3498         Reviewed by Pavel Feldman.
3499
3500         Add check-inspector-strings script.
3501
3502         https://bugs.webkit.org/show_bug.cgi?id=52295
3503
3504         * Scripts/check-inspector-strings: Added.
3505
3506 2011-01-12  Adam Roben  <aroben@apple.com>
3507
3508         Advertise the .testnetscape file extension on Windows
3509
3510         Fixes <http://webkit.org/b/52298>
3511         plugins/no-mime-with-valid-extension.html fails on Windows
3512
3513         Reviewed by Dan Bernstein.
3514
3515         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3516         FileExtents field to map the .testnetscape file extension to the
3517         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3518
3519 2011-01-12  Adam Barth  <abarth@webkit.org>
3520
3521         Reviewed by Eric Seidel.
3522
3523         Make webkit-patch support subdirectories for SVN checkouts
3524         https://bugs.webkit.org/show_bug.cgi?id=52261
3525
3526         os.relpath does not exist on Python 2.5, so we need to call our version
3527         of the API.
3528
3529         * Scripts/webkitpy/common/checkout/scm.py:
3530
3531 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3532
3533         Reviewed by Eric Seidel.
3534
3535         Close additional pages opened during a test once the test completes.
3536         https://bugs.webkit.org/show_bug.cgi?id=52276
3537
3538         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3539         (WTR::InjectedBundle::done):
3540
3541 2011-01-11  David Levin  <levin@chromium.org>
3542
3543         Reviewed by Eric Seidel.
3544
3545         Errors should be separated from the command line in bot messages.
3546         https://bugs.webkit.org/show_bug.cgi?id=52275
3547
3548         * Scripts/webkitpy/common/system/executive.py:
3549         (ScriptError.message_with_output): Added a newline to separate the command
3550         line from the errors.
3551         * Scripts/webkitpy/common/system/executive_unittest.py:
3552         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3553         paths in message_with_output.
3554
3555 2011-01-11  Eric Seidel  <eric@webkit.org>
3556
3557         Unreviewed.
3558
3559         commit-queue should know how to upload archived results (for test flakes or general failures)
3560         https://bugs.webkit.org/show_bug.cgi?id=52048
3561
3562         The zips are mostly empty due to forgetting -r.
3563         Expected diffs were not being pulled from the archive due
3564         to the archive having longer paths than I realized.
3565
3566         * Scripts/webkitpy/common/system/workspace.py:
3567         * Scripts/webkitpy/common/system/workspace_unittest.py:
3568         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3569         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3570
3571 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3572
3573         Reviewed by Ojan Vafai.
3574
3575         The current modifier parsing code in test_expectations is
3576         fragile and hard-coded, so it's not easy to understand the logic
3577         or easily add new types of modifiers (like GPU vs. CPU testing
3578         for graphics tests, or 32-bit vs. 64-bit differences).
3579
3580         This is the first of two patches that will add in more generic
3581         support and then eliminate the GPU-specific test expectations
3582         files for Chromium.
3583
3584         This patch adds two standalone objects for handling modifiers. The
3585         rules for interpreting modifiers, precedence, and conflicts are
3586         given in the docstring to the ModifierMatcher class, which
3587         returns ModifierMatchResult objects.
3588         
3589         This patch also adds routines to the Port interface and a
3590         default set of values in the base object, in order to obtain the
3591         values needed on a given test run. These values are then passed
3592         to the expectation parser. This also allows us to clean up the
3593         logic used to lint all of the different configurations in a
3594         single test_expectations.txt file.
3595
3596         The next patch will merge in the separate GPU expectations file.
3597
3598         https://bugs.webkit.org/show_bug.cgi?id=51222
3599
3600         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3601         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3602         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3603         * Scripts/webkitpy/layout_tests/port/base.py:
3604         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3605         * Scripts/webkitpy/layout_tests/port/chromium.py:
3606         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3607         * Scripts/webkitpy/layout_tests/port/test.py:
3608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3609         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3610
3611 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3612
3613         Reviewed by Adam Barth.
3614
3615         Make webkit-patch support subdirectories for SVN checkouts
3616         https://bugs.webkit.org/show_bug.cgi?id=52261
3617
3618         * Scripts/webkitpy/common/checkout/scm.py:
3619         * Scripts/webkitpy/style_references.py:
3620         * Scripts/webkitpy/tool/main.py:
3621         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3622
3623 2011-01-11  Eric Seidel  <eric@webkit.org>
3624
3625         Unreviewed.
3626
3627         commit-queue should know how to upload archived results (for test flakes or general failures)
3628         https://bugs.webkit.org/show_bug.cgi?id=52048
3629
3630         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3631         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3632
3633         * Scripts/webkitpy/common/system/workspace.py:
3634         * Scripts/webkitpy/common/system/workspace_unittest.py:
3635         * Scripts/webkitpy/tool/commands/queues.py:
3636
3637 2011-01-11  Sam Weinig  <sam@webkit.org>
3638
3639         Roll r75474 back in.
3640
3641 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3642
3643         Reviewed by Kenneth Rohde Christiansen.
3644
3645         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3646         https://bugs.webkit.org/show_bug.cgi?id=51204
3647
3648         * QtTestBrowser/webpage.h:
3649         (QtNAMThread::QtNAMThread):
3650         (QtNAMThread::networkAccessManager):
3651         (QtNAMThread::run):
3652
3653 2011-01-11  Peter Varga  <pvarga@webkit.org>
3654
3655         Unreviewed.
3656
3657         Add myself to committers' list.
3658
3659         * Scripts/webkitpy/common/config/committers.py:
3660
3661 2011-01-11  Eric Seidel  <eric@webkit.org>
3662
3663         Reviewed by Adam Barth.
3664
3665         commit-queue should know how to upload archived results (for test flakes or general failures)
3666         https://bugs.webkit.org/show_bug.cgi?id=52048
3667
3668         Now the queue will always upload results.  Either the entire zip, or just
3669         the diffs.txt in the case of text failures.
3670
3671         This should make understanding flakes much easier, and paves the way
3672         for having the EWS run layout tests (and upload failures).
3673
3674         In order to upload .zip files I had to teach bugzilla.py to autodetect
3675         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3676         for .patch files, I have it add one before calling guess_type.
3677
3678         We may find that always uploading the whole zip instead of just the -diffs.txt
3679         file is preferable, but for now I'm keeping the old behavior because it makes
3680         quickly understanding text failures easy.
3681
3682         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3683         * Scripts/webkitpy/common/system/workspace.py: Added.
3684         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3685         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3686         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3687         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3688         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3689         * Scripts/webkitpy/tool/commands/queues.py:
3690         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3691
3692 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3693
3694         Unreviewed, rolling out r75464.
3695         http://trac.webkit.org/changeset/75464
3696         https://bugs.webkit.org/show_bug.cgi?id=52193
3697
3698         Followup rollout for 75474 (Requested by Ossy on #webkit).
3699
3700         * MiniBrowser/mac/BrowserWindowController.m:
3701         (-[BrowserWindowController awakeFromNib]):
3702         * MiniBrowser/win/BrowserView.cpp:
3703         (BrowserView::create):
3704         * WebKitTestRunner/TestController.cpp:
3705         (WTR::createOtherPage):
3706         (WTR::TestController::initialize):
3707
3708 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3709
3710         Reviewed by Csaba Osztrogonác.
3711
3712         [Qt] Baseline qt_minimal configuration