04b2a0fa833ae7a4c2b7927ffbd1ce648c72939e
[WebKit-https.git] / Tools / ChangeLog
1 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         [GTK] Build with network process unconditionally
4         https://bugs.webkit.org/show_bug.cgi?id=126128
5
6         Reviewed by Martin Robinson.
7
8         * Scripts/webkitperl/FeatureList.pm: Remove network-process
9         feature command line option.
10
11 2013-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
12
13         [GTK] run-gtk-tests should always run glib tests with -k option
14         https://bugs.webkit.org/show_bug.cgi?id=126132
15
16         Reviewed by Philippe Normand.
17
18         With -k command line option, gtester continues running all other
19         test cases after a failure.
20
21         * Scripts/run-gtk-tests:
22         (TestRunner._run_test_glib): Use -k option when runing glib tests
23         to not stop on failure.
24
25 2013-12-22  Martin Robinson  <mrobinson@igalia.com>
26
27         [GTK][CMake] Integrate GResource for inspector files (and others?)
28         https://bugs.webkit.org/show_bug.cgi?id=125569
29
30         Reviewed by Gustavo Noronha Silva.
31
32         * gtk/generate-inspector-gresource-manifest.py: Added.
33
34 2013-12-22  Csaba Osztrogonác  <ossy@webkit.org>
35
36         Last URTBF after r160971 to make EFL build happy.
37
38         * TestWebKitAPI/efl/PlatformWebView.cpp:
39         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
40
41 2013-12-21  Carlos Garcia Campos  <cgarcia@igalia.com>
42
43         Unreviewed. Add myself to some more watch lists.
44
45         * Scripts/webkitpy/common/config/watchlist: Watch also soup, gst
46         and binding scripts patches.
47
48 2013-12-20  Commit Queue  <commit-queue@webkit.org>
49
50         Unreviewed, rolling out r160941.
51         http://trac.webkit.org/changeset/160941
52         https://bugs.webkit.org/show_bug.cgi?id=126095
53
54         Doesn't handle subpixel layout being disabled (Requested by
55         smfr on #webkit).
56
57         * gdb/webkit.py:
58         (JSCJSStringPrinter.to_string):
59         (add_pretty_printers):
60         * lldb/lldb_webkit.py:
61         (WTFMediaTime_SummaryProvider):
62         (WTFStringProvider.to_string):
63
64 2013-12-20  Bem Jones-Bey  <bjonesbe@adobe.com>
65
66         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in gdb and lldb
67         https://bugs.webkit.org/show_bug.cgi?id=126080
68
69         Reviewed by Anders Carlsson.
70
71         This changes the output of printing LayoutUnits to be in px, removing
72         the need to divide by 64 manually.
73
74         This will lead to gdb output like:
75
76         m_frameRect = {
77             m_location = LayoutPoint(0px, 0px),
78             m_size = LayoutSize(800px, 585px)
79         }
80
81         And lldb output like:
82
83         (const WebCore::LayoutRect) $0 = {
84           m_location = { x = 744px, y = 1px }
85           m_size = { width = 236px, height = 40px }
86         }
87
88         This patch is based on patch for Blink by cbiesinger@chromium.org.
89
90         * gdb/webkit.py:
91         (WebCoreLayoutUnitPrinter):
92         (WebCoreLayoutUnitPrinter.__init__):
93         (WebCoreLayoutUnitPrinter.to_string):
94         (WebCoreLayoutSizePrinter):
95         (WebCoreLayoutSizePrinter.__init__):
96         (WebCoreLayoutSizePrinter.to_string):
97         (WebCoreLayoutPointPrinter):
98         (WebCoreLayoutPointPrinter.__init__):
99         (WebCoreLayoutPointPrinter.to_string):
100         (add_pretty_printers):
101         * lldb/lldb_webkit.py:
102         (__lldb_init_module):
103         (WebCoreLayoutUnit_SummaryProvider):
104         (WebCoreLayoutSize_SummaryProvider):
105         (WebCoreLayoutPoint_SummaryProvider):
106         (WebCoreLayoutUnitProvider):
107         (WebCoreLayoutUnitProvider.__init__):
108         (WebCoreLayoutUnitProvider.to_string):
109         (WebCoreLayoutSizeProvider):
110         (WebCoreLayoutSizeProvider.__init__):
111         (WebCoreLayoutSizeProvider.get_width):
112         (WebCoreLayoutSizeProvider.get_height):
113         (WebCoreLayoutPointProvider):
114         (WebCoreLayoutPointProvider.__init__):
115         (WebCoreLayoutPointProvider.get_x):
116         (WebCoreLayoutPointProvider.get_y):
117
118 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
119
120         [GTK] [CMake] Add support for building ImageDiff
121         https://bugs.webkit.org/show_bug.cgi?id=125960
122
123         Reviewed by Gustavo Noronha Silva.
124
125         * CMakeLists.txt: Build ImageDiff for GTK+.
126         * ImageDiff/PlatformGTK.cmake: Added.
127
128 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
129
130         [GTK] [CMake] Add support for building DumpRenderTree
131         https://bugs.webkit.org/show_bug.cgi?id=125767
132
133         Reviewed by Gustavo Noronha Silva.
134
135         * CMakeLists.txt: Load the DumpRenderTree cmake file for GTK+ when WebKit1 is enabled.
136         * DumpRenderTree/PlatformGTK.cmake: Added.
137
138 2013-12-20  Martin Robinson  <mrobinson@igalia.com>
139
140         [GTK] [CMake] Add support for building WebKitTestRunner
141         https://bugs.webkit.org/show_bug.cgi?id=125768
142
143         Reviewed by Gustavo Noronha Silva.
144
145         * CMakeLists.txt: Compile WebKitTestRunner for GTK+ when WebKit2 is enabled.
146         * WebKitTestRunner/CMakeLists.txt: Remove some EFL specific flags from the common
147         build file.
148         * WebKitTestRunner/PlatformEfl.cmake: Move the flags here.
149         * WebKitTestRunner/PlatformGTK.cmake: Added.
150
151 2013-12-20  Myles C. Maxfield  <mmaxfield@apple.com>
152
153         Myles C. Maxfield is a committer now
154
155         Unreviewed.
156
157         * Scripts/webkitpy/common/config/contributors.json:
158
159 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
160
161         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
162         https://bugs.webkit.org/show_bug.cgi?id=125854
163
164         Reviewed by Chris Fleizach.
165
166         Ensure we don't ever create instances of AccessibilityUIElement
167         wrapping invalid platform-specific accessibility objects in DRT,
168         both for consistency with what WKTR does (so we avoid situations
169         where some tests fail in WK2 and not in WK1) and also to avoid
170         overlooking tests that might not be checking the right thing.
171
172         * DumpRenderTree/AccessibilityUIElement.cpp:
173         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
174         nullPtr if the platformUIElement() is not a valid one.
175         * DumpRenderTree/AccessibilityUIElement.h:
176         (AccessibilityUIElement::platformUIElement): Added const modifier.
177
178 2013-12-20  Mario Sanchez Prada  <mario.prada@samsung.com>
179
180         Programmatically-inserted children lack accessibility events
181         https://bugs.webkit.org/show_bug.cgi?id=100275
182
183         Reviewed by Chris Fleizach.
184
185         Update DRT and WebKitTestRunner to handle the children-changed
186         signal properly, considering the detail and optional parameters.
187
188         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
189         (axObjectEventListener):
190         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
191
192 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
193
194         Removed unused BUILDER_BASE_URL.
195         https://bugs.webkit.org/show_bug.cgi?id=125442
196
197         Reviewed by Csaba Osztrogonác.
198
199         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
200         (JSONGeneratorTest._test_json_generation): Trivial test fix after r160900.
201
202 2013-12-20  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
203
204         Removed unused BUILDER_BASE_URL.
205         https://bugs.webkit.org/show_bug.cgi?id=125442
206
207         Reviewed by Csaba Osztrogonác.
208
209         The string constant BUILDER_BASE_URL is passed around several times,
210         but we don't use it anywhere. It is a leftover from Chromium, cleaned it up.
211
212         * Scripts/webkitpy/layout_tests/controllers/manager.py:
213         (Manager._upload_json_files):
214         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
215         (JSONLayoutResultsGenerator.__init__):
216         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
217         (JSONResultsGenerator.__init__):
218
219 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
220
221         check-webkit-style mistakenly flags assigning to a dereferenced pointer
222         https://bugs.webkit.org/show_bug.cgi?id=126041
223
224         Reviewed by Ryosuke Niwa.
225
226         When checking for lines like "Foo *bar;", check-webkit-style doesn't make
227         sure that there is a declaration. This patch makes sure that there is a
228         declaration in order to flag spacing around asterisks.
229
230         * Scripts/webkitpy/style/checkers/cpp.py:
231         (check_spacing):
232         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
233         (CppStyleTest.test_pointer_reference_marker_location):
234
235 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
236
237         check-webkit-style marks rvalue references as violations
238         https://bugs.webkit.org/show_bug.cgi?id=126000
239
240         Reviewed by Ryosuke Niwa.
241
242         Previously, check-webkit-style was making sure that any line with "&&" had
243         spaces around it. However, we can now legitimately use "&&" without a previous
244         space when declaring an rvalue reference. This patch relaxes this check.
245
246         * Scripts/webkitpy/style/checkers/cpp.py:
247         (check_spacing):
248         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
249         (CppStyleTest.test_spacing_for_binary_ops):
250
251 2013-12-19  Myles C. Maxfield  <mmaxfield@apple.com>
252
253         check-webkit-style marks auto return types for functions as violations
254         https://bugs.webkit.org/show_bug.cgi?id=125999
255
256         Reviewed by Ryosuke Niwa.
257
258         If a function declaration ends with a "->" followed by a non whitespace
259         string, don't mark as an invalid "{" on its own line
260
261         * Scripts/webkitpy/style/checkers/cpp.py:
262         (check_braces):
263         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
264         (CppStyleTest.test_brace_at_begin_of_line):
265
266 2013-12-19  Alex Christensen  <achristensen@webkit.org>
267
268         [WinCairo] More GStreamer preparations.
269
270         Unreviewed.
271
272         * WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props:
273         Include FeatureDefinesCairo and WinCairo to compile the GLib part of WinLauncher.
274
275 2013-12-19  Lucas Forschler  <lforschler@apple.com>
276
277         Add Apple Mavericks perf bot.
278         
279         Unreviewed.
280
281         * BuildSlaveSupport/build.webkit.org-config/config.json:
282
283 2013-12-19  Commit Queue  <commit-queue@webkit.org>
284
285         Unreviewed, rolling out r160842.
286         http://trac.webkit.org/changeset/160842
287         https://bugs.webkit.org/show_bug.cgi?id=126003
288
289         broke accessibility/loading-iframe-updates-axtree.html
290         (Requested by ap on #webkit).
291
292         * DumpRenderTree/AccessibilityUIElement.cpp:
293         (AccessibilityUIElement::makeJSAccessibilityUIElement):
294         * DumpRenderTree/AccessibilityUIElement.h:
295         (AccessibilityUIElement::platformUIElement):
296
297 2013-12-19  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
298
299         get_test_baseline should get Host from test_config
300         https://bugs.webkit.org/show_bug.cgi?id=125989
301
302         Reviewed by Ryosuke Niwa.
303
304         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
305         (TestConfig.__init__):
306         (RebaselineServer._prepare_config):
307         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
308         (get_test_baselines):
309         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
310         (get_test_config):
311
312 2013-12-19  Roger Fong  <roger_fong@apple.com>
313
314         Don't check VSINSTALLDIR when looking for Visual Studio install directory.
315         https://bugs.webkit.org/show_bug.cgi?id=125998.
316
317         Reviewed by Alexey Proskuryakov.
318
319         * Scripts/webkitdirs.pm:
320         (visualStudioInstallDir):
321         Get rid of the VSINSTALLDIR check. We can't build on anything besides VS2013 now anyways.
322
323 2013-12-19  Mario Sanchez Prada  <mario.prada@samsung.com>
324
325         [ATK] [WK2] platform/gtk/accessibility/roles-exposed.html is failing
326         https://bugs.webkit.org/show_bug.cgi?id=125854
327
328         Reviewed by Chris Fleizach.
329
330         Ensure we don't ever create instances of AccessibilityUIElement
331         wrapping invalid platform-specific accessibility objects in DRT,
332         both for consistency with what WKTR does (so we avoid situations
333         where some tests fail in WK2 and not in WK1) and also to avoid
334         overlooking tests that might not be checking the right thing.
335
336         * DumpRenderTree/AccessibilityUIElement.cpp:
337         (AccessibilityUIElement::makeJSAccessibilityUIElement): Return a
338         nullPtr if the platformUIElement() is not a valid one.
339         * DumpRenderTree/AccessibilityUIElement.h:
340         (AccessibilityUIElement::platformUIElement): Added const modifier.
341
342 2013-12-18  Anders Carlsson  <andersca@apple.com>
343
344         Deprecate some WKMutableDictionary functions
345         https://bugs.webkit.org/show_bug.cgi?id=125962
346
347         Reviewed by Tim Horton.
348
349         * TestWebKitAPI/PlatformUtilities.cpp:
350         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
351         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
352         (TestWebKitAPI::didAssociateFormControls):
353         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
354         (TestWebKitAPI::WillLoadTest::willLoadURLRequest):
355         (TestWebKitAPI::WillLoadTest::willLoadDataRequest):
356         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
357         (WTR::createMouseMessageBody):
358         (WTR::EventSendingController::mouseMoveTo):
359         (WTR::EventSendingController::leapForward):
360         (WTR::createKeyDownMessageBody):
361         (WTR::EventSendingController::mouseScrollBy):
362         (WTR::EventSendingController::continuousMouseScrollBy):
363         (WTR::EventSendingController::addTouchPoint):
364         (WTR::EventSendingController::updateTouchPoint):
365         (WTR::EventSendingController::setTouchModifier):
366         (WTR::EventSendingController::setTouchPointRadius):
367         (WTR::EventSendingController::touchStart):
368         (WTR::EventSendingController::touchMove):
369         (WTR::EventSendingController::touchEnd):
370         (WTR::EventSendingController::touchCancel):
371         (WTR::EventSendingController::clearTouchPoints):
372         (WTR::EventSendingController::releaseTouchPoint):
373         (WTR::EventSendingController::cancelTouchPoint):
374         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
375         (WTR::InjectedBundle::done):
376         (WTR::InjectedBundle::setMockGeolocationPosition):
377         (WTR::InjectedBundle::setCustomPolicyDelegate):
378         (WTR::InjectedBundle::setVisibilityState):
379         (WTR::InjectedBundle::queueLoad):
380         (WTR::InjectedBundle::queueLoadHTMLString):
381         * WebKitTestRunner/TestController.cpp:
382         (WTR::TestController::initialize):
383         (WTR::TestController::resetStateToConsistentValues):
384         * WebKitTestRunner/TestInvocation.cpp:
385         (WTR::updateThreadedScrollingForCurrentTest):
386         (WTR::updateLayoutType):
387         (WTR::TestInvocation::invoke):
388
389 2013-12-18  Martin Robinson  <mrobinson@igalia.com>
390
391         [GTK] [CMake] Add support for building GtkLauncher
392         https://bugs.webkit.org/show_bug.cgi?id=125766
393
394         Reviewed by Gustavo Noronha Silva.
395
396         * CMakeLists.txt: Add the GtkLauncher subdirectory for the GTK port.
397         * GtkLauncher/CMakeLists.txt: Added.
398         * GtkLauncher/main.c: Support including the CMake config file.
399
400 2013-12-18  Alex Christensen  <achristensen@webkit.org>
401
402         [WinCairo] Preparation for GStreamer on Windows.
403         https://bugs.webkit.org/show_bug.cgi?id=125946
404
405         Reviewed by Brent Fulgham.
406
407         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
408         Use new GStreamer property sheets for WinCairo.
409         * win/DLLLauncher/DLLLauncherMain.cpp:
410         (modifyPath):
411         (wWinMain):
412         Prepend GStreamer bin directory to path if it exists.
413
414 2013-12-18  Anders Carlsson  <andersca@apple.com>
415
416         Remove now useless test.
417
418         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
419         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm: Removed.
420         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm: Removed.
421         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h: Removed.
422
423 2013-12-18  Gavin Barraclough  <barraclough@apple.com>
424
425         Fix page visibility api test, initialization in WebKit2
426         https://bugs.webkit.org/show_bug.cgi?id=125933
427
428         Reviewed by Anders Carlsson.
429
430         The API test for page visibility is broken, fix this. This revealed a recent regression in WebKit2
431         (introduced in https://bugs.webkit.org/show_bug.cgi?id=123379), caused by a typo removing a '!'.
432
433         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
434         (TestWebKitAPI::TEST_F):
435             - Running a test on WebKit1 twice is not the same as running it on WebKit2!
436
437 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
438
439         Should not have identifiers with underscores in them, especially not leading underscores.
440         https://bugs.webkit.org/show_bug.cgi?id=125847
441
442         Reviewed by Darin Adler.
443
444         * Scripts/webkitpy/style/checkers/cpp.py:
445         (check_identifier_name_in_declaration):
446         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
447         (CppStyleTest.test_runtime_selfinit):
448         (WebKitStyleTest.test_names):
449
450 2013-12-18  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
451
452         False webkit-check-style warnings on *.
453         https://bugs.webkit.org/show_bug.cgi?id=125915
454
455         Reviewed by Darin Adler.
456
457         * Scripts/webkitpy/style/checkers/cpp.py:
458         (check_spacing):
459         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
460         (CppStyleTest.test_pointer_reference_marker_location):
461
462 2013-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
463
464         prepare-ChangeLog doesn't handle templates properly
465         https://bugs.webkit.org/show_bug.cgi?id=125853
466
467         Reviewed by Daniel Bates.
468
469         * Scripts/prepare-ChangeLog:
470         (get_function_line_ranges_for_cpp):
471         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
472         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
473         (Class110<TemplateClass>::func36):
474
475 2013-12-18  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
476
477         Move expectation parsing out of the constructor of TestExpectations
478         https://bugs.webkit.org/show_bug.cgi?id=125439
479
480         Reviewed by Csaba Osztrogonác.
481
482         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
483         (LayoutTestRunnerTests._run_tests):
484         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
485         (LayoutTestRunnerTests.test_update_summary_with_result):
486         * Scripts/webkitpy/layout_tests/controllers/manager.py:
487         (Manager.run):
488         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
489         (ManagerTest.test_look_for_new_crash_logs):
490         * Scripts/webkitpy/layout_tests/lint_test_expectations.py:
491         (lint):
492         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
493         (TestExpectations.suffixes_for_expectations):
494         (TestExpectations.__init__):
495         (TestExpectations):
496         (TestExpectations.parse_generic_expectations):
497         (TestExpectations.parse_default_port_expectations):
498         (TestExpectations.parse_override_expectations):
499         (TestExpectations.parse_all_expectations):
500         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
501         (parse_exp):
502         (SkippedTests.check):
503         (SkippedTests.test_skipped_entry_dont_exist):
504         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
505         (run_results):
506         * Scripts/webkitpy/tool/commands/queries.py:
507         (PrintExpectations._model):
508         * Scripts/webkitpy/tool/commands/rebaseline.py:
509         (RebaselineTest._update_expectations_file):
510         (RebaselineExpectations._update_expectations_files):
511         (RebaselineExpectations._tests_to_rebaseline):
512
513 2013-12-17  Jer Noble  <jer.noble@apple.com>
514
515         Fix TimeRanges::intersectWith
516         https://bugs.webkit.org/show_bug.cgi?id=118802
517
518         Reviewed by Eric Carlson.
519
520         Add unit tests for WebCore/TimeRanges.
521
522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
523         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: Added.
524         (TestWebKitAPI::ToString):
525         (TestWebKitAPI::TEST):
526
527 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
528
529         Botwatcher's dashboard ceases to update itself after a while
530         https://bugs.webkit.org/show_bug.cgi?id=125885
531
532         Reviewed by Timothy Hatcher.
533
534         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
535         Removed code that checked for the view being hidden. It's none of model's business.
536
537         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
538         (BuildbotQueueView): Find out what platform the view is for. Initlialize update timer.
539         (BuildbotQueueView.prototype._updateHiddenState): Start or stop update timer as appropriate.
540         We now stop the timer for hidden views.
541         (BuildbotQueueView.prototype._updateQueues): Removed the logic for ignoring some updates.
542
543 2013-12-17  Anders Carlsson  <andersca@apple.com>
544
545         Fix the 32-bit build.
546
547         * MiniBrowser/MiniBrowserWebProcessPlugIn.h:
548         * MiniBrowser/MiniBrowserWebProcessPlugIn.m:
549
550 2013-12-17  Anders Carlsson  <andersca@apple.com>
551
552         Give the MiniBrowser a bundle
553         https://bugs.webkit.org/show_bug.cgi?id=125882
554
555         Reviewed by Sam Weinig.
556
557         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Added.
558         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
559         * MiniBrowser/MiniBrowserWebProcessPlugIn.h: Added.
560         * MiniBrowser/MiniBrowserWebProcessPlugIn.m: Added.
561         (-[MiniBrowserWebProcessPlugIn webProcessPlugIn:initializeWithObject:]):
562         * MiniBrowser/mac/AppDelegate.m:
563         (-[BrowserAppDelegate init]):
564         * MiniBrowser/mac/Bundle/Info.plist: Added.
565         * MiniBrowser/mac/Bundle/MiniBrowserBundle_Prefix.pch: Added.
566
567 2013-12-17  Gavin Barraclough  <barraclough@apple.com>
568
569         Remove PageVisibilityStateUnloaded
570         https://bugs.webkit.org/show_bug.cgi?id=125869
571
572         Reviewed by Anders Carlsson.
573
574         This is not currently supported by WebKit, remove this enum value.
575         We can always add this back later if/when we add support for this state.
576
577         * DumpRenderTree/mac/TestRunnerMac.mm:
578         (TestRunner::setPageVisibility):
579         * TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
580         (TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
581         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
582         (WTR::TestRunner::setPageVisibility):
583             - remove test for visibility state "unloaded"; this is no longer supported (it never really was).
584
585 2013-12-12  Martin Robinson  <mrobinson@igalia.com>
586
587         [GTK] [CMake] Build the plugin process against GTK+ 2
588         https://bugs.webkit.org/show_bug.cgi?id=116374
589
590         Reviewed by Gustavo Noronha Silva.
591
592         * TestWebKitAPI/PlatformGTK.cmake: Add WebCorePlatformGTK to the list of
593         libraries required for WebCore unit tests.
594
595 2013-12-17  Brent Fulgham  <bfulgham@apple.com>
596
597         [Win] Revise filter-build-webkit to deal with Windows build logs
598         https://bugs.webkit.org/show_bug.cgi?id=125866
599
600         Reviewed by David Kilzer.
601
602         Enhance the script to accept a 'platform' argument. When platform
603         'win' is provided, use processing for the Windows build file format.
604         Otherwise, process the files as normal.
605
606         * Scripts/filter-build-webkit:
607         (usageAndExit): Add a 'platform' argument
608         (shouldIgnoreLine): When platform == 'win' use the new Windows
609         rules for processing the build file.
610
611 2013-12-17  Alexey Proskuryakov  <ap@apple.com>
612
613         Update style checker now that ENUM_CLASS is gone
614         https://bugs.webkit.org/show_bug.cgi?id=125864
615
616         Reviewed by Anders Carlsson.
617
618         * Scripts/webkitpy/style/checkers/cpp.py:
619         (_EnumState.process_clean_line):
620         (check_braces):
621         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
622         (NoNonVirtualDestructorsTest.test_enum_casing.Foo):
623         (NoNonVirtualDestructorsTest.test_enum_casing):
624         (NoNonVirtualDestructorsTest.test_enum_casing.Enum123):
625         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.CPP11EnumClass):
626         (NoNonVirtualDestructorsTest.test_enum_trailing_semicolon.MyEnum):
627         (WebKitStyleTest.test_braces.CPP11EnumClass):
628
629 2013-12-17  Mario Sanchez Prada  <mario.prada@samsung.com>
630
631         [ATK] Expose accessibility objects for <dl>, <dt> and <dd>
632         https://bugs.webkit.org/show_bug.cgi?id=125857
633
634         Reviewed by Chris Fleizach.
635
636         Add mappings to DRT & WKTR for the newly exposed roles, and
637         increase the version of ATK used by the internal jhbuild.
638
639         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
640         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
641         * gtk/jhbuild.modules: Raise version of ATK up to 2.11.4.
642
643 2013-12-17  Alex Christensen  <achristensen@webkit.org>
644
645         [WinCairo] Adding support for GStreamer and GLib.
646         https://bugs.webkit.org/show_bug.cgi?id=124867
647
648         Reviewed by Philippe Normand.
649
650         * WinLauncher/WinLauncher.cpp:
651         (wWinMain):
652         Added g_main_context_iteration in main event loop.
653
654 2013-12-17  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
655
656         Fix for C++ should have the & or * beside the type not the variable name check.
657         https://bugs.webkit.org/show_bug.cgi?id=125846
658
659         Reviewed by Darin Adler.
660
661         * Scripts/webkitpy/style/checkers/cpp.py:
662         (check_spacing):
663         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
664         (CppStyleTest.test_pointer_reference_marker_location):
665
666 2013-12-16  Rob Buis  <rob.buis@samsung.com>
667
668         Add my Samsung email address.
669
670         Unreviewed.
671
672         * Scripts/webkitpy/common/config/contributors.json:
673
674 2013-12-16  Oliver Hunt  <oliver@apple.com>
675
676         Cache getters and custom accessors on the prototype chain
677         https://bugs.webkit.org/show_bug.cgi?id=125602
678
679         Reviewed by Michael Saboff.
680
681         Make sure bencher scripts also make noInline exist
682
683         * Scripts/bencher:
684
685 2013-12-16  Anders Carlsson  <andersca@apple.com>
686
687         Fix crash when trying to load a null HTML string
688         https://bugs.webkit.org/show_bug.cgi?id=125801
689
690         Reviewed by Dan Bernstein.
691
692         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
693         (TestWebKitAPI::TEST_F):
694         Update test results.
695
696 2013-12-16  Alex Christensen  <achristensen@webkit.org>
697
698         Fixed Win64 build on VS2013.
699         https://bugs.webkit.org/show_bug.cgi?id=125753
700
701         Reviewed by Brent Fulgham.
702
703         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
704         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
705         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
706         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
707         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
708         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
709         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
710         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
711         * win/record-memory/record-memory.vcxproj:
712         Added correct PlatformToolset for 64-bit builds.
713
714 2013-12-16  Simon Fraser  <simon.fraser@apple.com>
715
716         Add a menu option to MiniBrowser to enable UI-side compositing
717         https://bugs.webkit.org/show_bug.cgi?id=125793
718
719         Reviewed by Anders Carlsson.
720         
721         Make it possible to test UI-side compositing in MiniBrowser WK2 windows.
722
723         * MiniBrowser/mac/BrowserWindowController.h: Add optional protocol method
724         to toggle UI-side compositing.
725         * MiniBrowser/mac/MainMenu.xib: Add menu item to Debug menu.
726         * MiniBrowser/mac/WK2BrowserWindowController.m:
727         (-[WK2BrowserWindowController validateMenuItem:]):
728         (-[WK2BrowserWindowController isUISideCompositingEnabled]):
729         (-[WK2BrowserWindowController toggleUISideCompositing:]):
730         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
731         Adjust the window title to indicate whether the window is using UI-side compositing.
732
733 2013-12-16  Commit Queue  <commit-queue@webkit.org>
734
735         Unreviewed, rolling out r160645.
736         http://trac.webkit.org/changeset/160645
737         https://bugs.webkit.org/show_bug.cgi?id=125787
738
739         Change breaks test-webkitpy (Requested by bfulgham on
740         #webkit).
741
742         * Scripts/prepare-ChangeLog:
743         (get_selector_line_ranges_for_css):
744
745 2013-12-16  David Farler  <dfarler@apple.com>
746
747         [ASAN] WebKitLauncher: Include libasancrashreporter.dylib in DYLD_INSERT_LIBRARIES if it exists
748         https://bugs.webkit.org/show_bug.cgi?id=124610
749
750         Reviewed by Mark Rowe.
751
752         * WebKitLauncher/WebKitNightlyEnabler.m:
753         (enableWebKitNightlyBehaviour):
754         Add libasancrashreporter.dylib to DYLD_INSERT_LIBRARIES.
755         * WebKitLauncher/main.m:
756         (main):
757         Include both libasancrashreporter and the nightly enabler to
758         the list of libraries to insert.
759
760 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
761
762         Resolve inconsistant style warning caused by r160319.
763         https://bugs.webkit.org/show_bug.cgi?id=125772
764
765         Reviewed by Darin Adler.
766
767         * Scripts/webkitpy/style/checkers/cpp.py:
768         (check_for_extra_new_line_at_eof):
769         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
770         (CppStyleTest.test_newline_at_eof):
771         (CppStyleTest.test_extra_newlines_at_eof):
772
773 2013-12-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
774
775         Remove mock_drt.py: parse_options() - --test-shell and --pixel-tests=<path>
776         https://bugs.webkit.org/show_bug.cgi?id=125780
777
778         Reviewed by Darin Adler.
779
780         * Scripts/webkitpy/port/mock_drt.py:
781         (main):
782         (parse_options):
783         (MockDRT.write_test_output):
784         * Scripts/webkitpy/port/mock_drt_unittest.py:
785         (MockDRTTest.assertTest):
786         (MockDRTTest.test_reftest_mismatch):
787
788 2013-12-16  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
789
790         prepare-Changelog treats CSS keyframes as mismatched parentheses.
791         https://bugs.webkit.org/show_bug.cgi?id=125435
792
793         Reviewed by Darin Adler.
794
795         * Scripts/prepare-ChangeLog:
796         (get_selector_line_ranges_for_css):
797
798 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
799
800         [ATK] Expose accessibility objects for more WAI-ARIA roles
801         https://bugs.webkit.org/show_bug.cgi?id=125596
802
803         Reviewed by Chris Fleizach.
804
805         Add mappings to DRT & WKTR for the newly exposed roles.
806
807         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
808         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
809
810 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
811
812         [ATK] Expose accessibility objects with ATK_ROLE_CHECK_MENU_ITEM
813         https://bugs.webkit.org/show_bug.cgi?id=125594
814
815         Reviewed by Chris Fleizach.
816
817         Add mappings to DRT & WKTR for checkmenuitem role.
818
819         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
820         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
821
822 2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
823
824         [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
825         https://bugs.webkit.org/show_bug.cgi?id=125587
826
827         Reviewed by Chris Fleizach.
828
829         Add mappings to DRT & WKTR for article roles.
830
831         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
832         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
833
834 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
835
836         [FTL] Allow EFL to build FTL with the build-jsc script.
837         https://bugs.webkit.org/show_bug.cgi?id=125774
838
839         Reviewed by Zoltan Herczeg.
840
841         * Scripts/build-jsc:
842
843 2013-12-16  Krzysztof Czech  <k.czech@samsung.com>
844
845         Add myself as a committer
846
847         Unreviewed.
848
849         * Scripts/webkitpy/common/config/contributors.json:
850
851 2013-12-15  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
852
853         Refactor option handling in WebKitTestRunner.
854         https://bugs.webkit.org/show_bug.cgi?id=123185
855
856         Reviewed by Darin Adler.
857
858         Option handling is refactored (according to the FIXME) that allows
859         to automatically generate the help message.
860
861         * WebKitTestRunner/CMakeLists.txt:
862         * WebKitTestRunner/GNUmakefile.am:
863         * WebKitTestRunner/Options.cpp: Added.
864         (WTR::Options::Options):
865         (WTR::handleOptionTimeout):
866         (WTR::handleOptionNoTimeout):
867         (WTR::handleOptionNoTimeoutAtAll):
868         (WTR::handleOptionVerbose):
869         (WTR::handleOptionGcBetweenTests):
870         (WTR::handleOptionPixelTests):
871         (WTR::handleOptionPrintSupportedFeatures):
872         (WTR::handleOptionComplexText):
873         (WTR::handleOptionAcceleratedDrawing):
874         (WTR::handleOptionRemoteLayerTree):
875         (WTR::handleOptionUnmatched):
876         (WTR::OptionsHandler::OptionsHandler):
877         (WTR::Option::Option):
878         (WTR::Option::matches):
879         (WTR::OptionsHandler::parse):
880         (WTR::OptionsHandler::printHelp):
881         * WebKitTestRunner/Options.h: Added.
882         * WebKitTestRunner/TestController.cpp:
883         (WTR::TestController::initialize):
884         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
885
886 2013-12-15  Dan Bernstein  <mitz@apple.com>
887
888         32-bit build fix.
889
890         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.h:
891         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
892
893 2013-12-14  Tim Horton  <timothy_horton@apple.com>
894
895         stylebot should warn when FeatureDefines differ
896         https://bugs.webkit.org/show_bug.cgi?id=125748
897
898         Reviewed by Dan Bernstein.
899
900         Add a stylebot checker that ensures that FeatureDefines.xcconfig files
901         are always exactly equal (and warns people adding new FeatureDefines.xcconfig files,
902         an unlikely occurrance, to add them to the list).
903
904         It's a bit nontraditional for stylebot because it will warn on existing errors in the tree,
905         but that is the most straightforward way to implement it (and we're at zero diffs right now).
906
907         * Scripts/webkitpy/style/checker.py:
908         (_all_categories):
909         (FileType):
910         (CheckerDispatcher._file_type):
911         (CheckerDispatcher._create_checker):
912         * Scripts/webkitpy/style/checkers/featuredefines.py: Added.
913         (FeatureDefinesChecker):
914         (FeatureDefinesChecker.__init__):
915         (FeatureDefinesChecker.check):
916
917 2013-12-13  Sam Weinig  <sam@webkit.org>
918
919         Fix API tests.
920
921         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
922         (TestWebKitAPI::TEST_F):
923
924 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
925
926         [Win] Remove Pre-VS2013 support code.
927         https://bugs.webkit.org/show_bug.cgi?id=125693
928
929         Reviewed by Darin Adler.
930
931         * DumpRenderTree/cg/ImageDiffCG.cpp: Remove strtof stub now supplied by
932         the math library.
933         * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
934
935 2013-12-13  Lucas Forschler  <lforschler@apple.com>
936
937         Update Webkit bots.
938         
939         Unreviewed.
940         
941         * BuildSlaveSupport/build.webkit.org-config/config.json:
942
943 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
944
945         [Win] Unreviewed build fix after r160548
946
947         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Specify
948         we are using vs12_xp target for Makefile-based projects.
949
950 2013-12-13  Lucas Forschler  <lforschler@apple.com>
951
952         Update Apple Webkit Bots
953         
954         Unreviewed.
955
956         * BuildSlaveSupport/build.webkit.org-config/config.json:
957
958 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
959
960         Unreviewed build fix after r160548.
961
962         * Scripts/webkitdirs.pm:
963         (setupCygwinEnv): VCExpress.exe is now called WDExpress.exe.
964
965 2013-12-13  Lucas Forschler  <lforschler@apple.com>
966
967         Update Apple bots.
968         
969         Unreviewed.
970
971         * BuildSlaveSupport/build.webkit.org-config/config.json:
972
973 2013-12-13  Brent Fulgham  <bfulgham@apple.com>
974
975         [Win] Switch WebKit solution to Visual Studio 2013
976         https://bugs.webkit.org/show_bug.cgi?id=125192
977
978         Reviewed by Anders Carlsson.
979
980         Project files must reference vs12_xp for 32-bit builds. 
981
982         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
983         Update for VS2013
984         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
985         Ditto
986         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
987         Ditto
988         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
989         Ditto
990         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
991         Ditto
992         * Scripts/webkitdirs.pm:
993         (visualStudioInstallDir): Specify VS2013
994         (visualStudioVersion): Ditto.
995         (setupAppleWinEnv): Use VS2013 in messages
996         (setupCygwinEnv): Ditto
997         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
998         Update for VS2013
999         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
1000         Ditto
1001         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1002         Ditto
1003         * win/record-memory/record-memory.vcxproj:
1004         Ditto
1005
1006 2013-12-11  Martin Robinson  <mrobinson@igalia.com> and Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
1007
1008         Adding a .ycm_extra_conf file for webkitGtk
1009         https://bugs.webkit.org/show_bug.cgi?id=119618
1010
1011         Reviewed by Gustavo Noronha Silva.
1012
1013         Added a YouCompleteMe flag discovery script for Vim and the GTK+ port. The script
1014         read the GTK+ build files to determine dynamically what flags to compile a source
1015         file with. This allows Vim to provide auto-complete for C++/C language. See
1016         https://github.com/Valloric/YouCompleteMe for how to use this file.
1017
1018         * gtk/common.py:
1019         (get_build_path): Added a fatal argument to build_path to avoid crashing YCM on failure.
1020         * gtk/ycm_extra_conf.py: Added.
1021
1022 2013-12-12  Tim Horton  <timothy_horton@apple.com>
1023
1024         [wk2] Handle pinch-to-zoom gesture
1025         https://bugs.webkit.org/show_bug.cgi?id=125604
1026
1027         Reviewed by Simon Fraser.
1028
1029         * MiniBrowser/mac/WK2BrowserWindowController.m:
1030         (-[WK2BrowserWindowController awakeFromNib]):
1031         Enable handling of the magnification gesture in Minibrowser WebKit2 windows.
1032
1033 2013-12-12  Eunmi Lee  <eunmi15.lee@samsung.com>
1034
1035         Unreviewed. Add myself as a committer.
1036
1037         * Scripts/webkitpy/common/config/contributors.json:
1038
1039 2013-12-12  Lucas Forschler  <lforschler@apple.com>
1040
1041         Update hardware for Apple bots.
1042         
1043         Unreviewed.
1044
1045         * BuildSlaveSupport/build.webkit.org-config/config.json:
1046
1047 2013-12-12  Lucas Forschler  <lforschler@apple.com>
1048
1049         Remove unused Apple Bots.
1050         
1051         Unreviewed.
1052
1053         * BuildSlaveSupport/build.webkit.org-config/config.json:
1054
1055 2013-12-12  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1056
1057         Unreviewed. Add myself as a committer.
1058
1059         * Scripts/webkitpy/common/config/contributors.json:
1060
1061 2013-12-12  Joseph Pecoraro  <pecoraro@apple.com>
1062
1063         Test new JSContext name APIs
1064         https://bugs.webkit.org/show_bug.cgi?id=125607
1065
1066         Reviewed by Darin Adler.
1067
1068         * Scripts/run-javascriptcore-tests:
1069         Remove trailing whitespace.
1070
1071 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
1072
1073         [Autotools] Prepend the WebCore layer archives' names with 'lib'
1074         https://bugs.webkit.org/show_bug.cgi?id=125627
1075
1076         Reviewed by Martin Robinson.
1077
1078         * TestWebKitAPI/GNUmakefile.am: Libtool can complain about the WebCore layer archives not being prepended
1079         with 'lib' when they are used during linking, so the prefix is now added to avoid such issues.
1080
1081 2013-12-12  Commit Queue  <commit-queue@webkit.org>
1082
1083         Unreviewed, rolling out r160446.
1084         http://trac.webkit.org/changeset/160446
1085         https://bugs.webkit.org/show_bug.cgi?id=125630
1086
1087         The upower-glib-based implementation is using API that was
1088         recently removed (Requested by zdobersek1 on #webkit).
1089
1090         * Scripts/webkitperl/FeatureList.pm:
1091
1092 2013-12-12  Commit Queue  <commit-queue@webkit.org>
1093
1094         Unreviewed, rolling out r160417.
1095         http://trac.webkit.org/changeset/160417
1096         https://bugs.webkit.org/show_bug.cgi?id=125629
1097
1098         The patch is causing crashes (Requested by zdobersek1 on
1099         #webkit).
1100
1101         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
1102         (axObjectEventListener):
1103         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1104
1105 2013-12-12  Zan Dobersek  <zdobersek@igalia.com>
1106
1107         Use of ar T option not supported by older binutils
1108         https://bugs.webkit.org/show_bug.cgi?id=118732
1109
1110         Reviewed by Gustavo Noronha Silva.
1111
1112         * TestWebKitAPI/GNUmakefile.am: To support non-thin archives when generating the WebCoreLayer archive,
1113         switch to using the AR_FLAGS variable (which can be overridden) for providing the ar flags for the
1114         new archive. Non-thin archives also pose the problem as their members are only noted by the basename
1115         of the member's object file, and not the full path to it. To work around that, all the object files
1116         under the build directory are listed by their relative paths. The members of various archives then have
1117         the basenames of their paths grepped against that list, with the found path correlating to the member
1118         finally added as the new member of the WebCoreLayer archive.
1119
1120 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
1121
1122         check-webkit-style shouldn't check spacing in #if preprocessor lines
1123         https://bugs.webkit.org/show_bug.cgi?id=125534
1124
1125         Reviewed by Ryosuke Niwa.
1126
1127         Preprocessor lines that start with #if shouldn't have to adhere to
1128         the same spacing requirements that regular code does
1129
1130         * Scripts/webkitpy/style/checkers/cpp.py:
1131         (check_spacing):
1132         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1133         (CppStyleTest.test_spacing_for_binary_ops):
1134         (WebKitStyleTest.test_line_breaking):
1135
1136 2013-12-11  Myles C. Maxfield  <mmaxfield@apple.com>
1137
1138         check-webkit-style can't determine if a comma is part of an initialization list
1139         https://bugs.webkit.org/show_bug.cgi?id=125537
1140
1141         Reviewed by Darin Adler.
1142
1143         The original check to make sure that initialization list lines start with
1144         a comma didn't distinguish between commas that belong to the initialization
1145         list and commas that are part of function calls. Because we don't want to
1146         match parentheses with regular expressions, we should weaken this check to
1147         only check for commas at the end of initialization list lines.
1148
1149         * Scripts/webkitpy/style/checkers/cpp.py:
1150         (check_member_initialization_list):
1151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1152         (WebKitStyleTest.test_member_initialization_list):
1153
1154 2013-12-11  Tim Horton  <timothy_horton@apple.com>
1155
1156         Make it possible to compare layout test results between various configurations of WebKit
1157         https://bugs.webkit.org/show_bug.cgi?id=125212
1158         <rdar://problem/15199108>
1159
1160         Reviewed by Darin Adler.
1161
1162         * Scripts/compare-webkit-configurations: Added.
1163         Add a script that allows comparison between the "normal" WebKit configuration
1164         used for testing and a different configuration (e.g. with accelerated drawing
1165         turned on, with the remote layer tree enabled, or WebKit1 vs WebKit2), like so:
1166
1167         compare-webkit-configurations -2 --comparison=accelerated-drawing compositing/background-color
1168
1169         This script runs the tests once in the default configuration, ignoring
1170         all test expectations, writing the results out to a temporary directory.
1171
1172         It then runs the tests again in the modified configuration, against the
1173         just-written temporary results.
1174
1175         Ref tests are treated as pixel tests, with their pixel output dumped to disk.
1176
1177         * DumpRenderTree/mac/DumpRenderTree.mm:
1178         (resetWebPreferencesToConsistentValues):
1179         (initializeGlobalsFromCommandLineOptions):
1180         Enable accelerated drawing if requested.
1181
1182         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1183         (parse_args):
1184         Add --accelerated-drawing and --remote-layer-tree feature switches, which
1185         are forwarded on to the test drivers.
1186         Move those two and --complex-text into their own "feature switches" section.
1187         Drive-by change "Mac OS X" to "OS X".
1188         Add --treat-ref-tests-as-pixel-tests option, which treats ref tests
1189         as traditional pixel tests (with PNGs dumped on disk), and
1190         ignores e.g. -expected.html files.
1191
1192         * Scripts/webkitpy/port/base.py:
1193         (Port.reference_files):
1194         Pretend that there are no ref tests.
1195         Since is_reference_html_file is intact, our mechanism to ignore
1196         the expected files will continue working in this case.
1197
1198         * Scripts/webkitpy/port/driver.py:
1199         (Driver.cmd_line):
1200         Forward --accelerated-drawing and --remote-layer-tree to DRT/WKTR.
1201
1202         * WebKitTestRunner/TestController.cpp:
1203         (WTR::TestController::TestController):
1204         (WTR::TestController::initialize):
1205         (WTR::TestController::resetPreferencesToConsistentValues):
1206         * WebKitTestRunner/TestController.h:
1207         (WTR::TestController::shouldUseRemoteLayerTree):
1208         * WebKitTestRunner/TestInvocation.cpp:
1209         (WTR::updateThreadedScrollingForCurrentTest):
1210         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1211         (WTR::PlatformWebView::PlatformWebView):
1212         Parse and implement the three feature switches.
1213
1214 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1215
1216         [ATK] Expose accessibility objects WAI-ARIA landmark roles
1217         https://bugs.webkit.org/show_bug.cgi?id=125584
1218
1219         Reviewed by Chris Fleizach.
1220
1221         Add mappings to DRT & WKTR for landmark roles.
1222
1223         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1224         (AccessibilityUIElement::role):
1225         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1226         (WTR::AccessibilityUIElement::role):
1227         * gtk/jhbuild.modules:
1228
1229 2013-12-11  Alejandro G. Castro  <alex@igalia.com>
1230
1231         [GTK] Avoid double quotations when passing parameters to valgrind in gtk.py
1232         https://bugs.webkit.org/show_bug.cgi?id=125441
1233
1234         Reviewed by Martin Robinson.
1235
1236         Just avoid the double quotations when building the parameter
1237         because some versions of valgrind are not handling it correctly.
1238
1239         * Scripts/webkitpy/port/gtk.py:
1240         (GtkPort.setup_environ_for_server):
1241
1242 2013-12-11  Zan Dobersek  <zdobersek@igalia.com>
1243
1244         [GTK] Enable Battery Status API
1245         https://bugs.webkit.org/show_bug.cgi?id=125453
1246
1247         Reviewed by Martin Robinson.
1248
1249         * Scripts/webkitperl/FeatureList.pm: Enable the Battery Status API feature for the GTK port.
1250
1251 2013-12-11  José Dapena Paz  <jdapena@igalia.com> and Zan Dobersek  <zdobersek@igalia.com>
1252
1253         [GTK][WK2] Add the WebKitBatteryProvider class
1254         https://bugs.webkit.org/show_bug.cgi?id=115720
1255
1256         Reviewed by Martin Robinson.
1257
1258         * gtk/generate-gtkdoc:
1259         (get_webkit2_options): Ignore the WebKitBatteryProvider source files when generating the documentation.
1260
1261 2013-12-11  Mark Rowe  <mrowe@apple.com>
1262
1263         <https://webkit.org/b/125563> Remove the DumpRenderTree Perl Support module
1264
1265         Now that old-run-webkit-tests is not used on OS X it's not worth the time and effort
1266         to build and maintain this custom Perl module.
1267
1268         Reviewed by Anders Carlsson.
1269
1270         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove the target.
1271         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport.c: Removed.
1272         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Removed.
1273         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Removed.
1274         * DumpRenderTree/mac/PerlSupport/Makefile: Removed.
1275         * Scripts/old-run-webkit-tests: Update a comment that referred to DumpRenderTreeSupport as a reason to
1276         build DumpRenderTree.
1277         (dumpToolDidCrash): Stop importing and using the module.
1278         * Scripts/webkitpy/port/base.py:
1279         (Port._build_driver): Update a comment in the same manner as in old-run-webkit-tests.
1280
1281 2013-12-11  Brendan Long  <b.long@cablelabs.com>
1282
1283         [GTK] Add "enable-mediasource" property to WebKitWebSettings
1284         https://bugs.webkit.org/show_bug.cgi?id=125566
1285
1286         Reviewed by Philippe Normand.
1287
1288         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1289         (resetDefaultsToConsistentValues): Turn MediaSource on by default for easier testing.
1290         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1291         (TestRunner::overridePreference): Allow overriding WebKitMediaSourceEnabled.
1292
1293 2013-12-11  Dan Bernstein  <mitz@apple.com>
1294
1295         [Mac] Observe the activeURL property to keep the MiniBrowser URL field up to date
1296         https://bugs.webkit.org/show_bug.cgi?id=125579
1297
1298         Reviewed by Anders Carlsson.
1299
1300         * MiniBrowser/mac/WK2BrowserWindowController.m:
1301         (-[WK2BrowserWindowController dealloc]): Stop observing the activeURL property.
1302         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): When the
1303         activeURL property changes, update the URL field with its value.
1304         (-[WK2BrowserWindowController awakeFromNib]): Start observing the activeURL property.
1305         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]): Just log.
1306         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1307         Ditto.
1308         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]):
1309         Ditto.
1310         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1311         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1312
1313 2013-12-11  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1314
1315         Fixed test-wepkitpy logging for buildslaves
1316         https://bugs.webkit.org/show_bug.cgi?id=125445
1317
1318         Reviewed by Csaba Osztrogonác.
1319
1320         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1321         (RunPythonTests):
1322
1323 2013-12-11  Mario Sanchez Prada  <mario.prada@samsung.com>
1324
1325         Programmatically-inserted children lack accessibility events
1326         https://bugs.webkit.org/show_bug.cgi?id=100275
1327
1328         Reviewed by Chris Fleizach.
1329
1330         Update DRT and WebKitTestRunner to handle the children-changed
1331         signal properly, considering the detail and optional parameters.
1332
1333         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp: Updated.
1334         (axObjectEventListener):
1335         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Updated.
1336
1337 2013-12-03  Mark Rowe  <mrowe@apple.com>
1338
1339         <https://webkit.org/b/125139> Modernize the WebKit API headers
1340         <rdar://problem/15540175>
1341
1342         Reviewed by Anders Carlsson.
1343
1344         * DumpRenderTree/mac/TestRunnerMac.mm:
1345         (TestRunner::setCacheModel): Cast to the enum type.
1346
1347 2013-12-10  Filip Pizlo  <fpizlo@apple.com>
1348
1349         Get rid of forward exit on DoubleAsInt32
1350         https://bugs.webkit.org/show_bug.cgi?id=125552
1351
1352         Reviewed by Oliver Hunt.
1353         
1354         Add some support for testing the generic (non-X86) paths on X86 by disabling
1355         architecture-specific optimizations (ASO's).
1356
1357         * Scripts/run-javascriptcore-tests:
1358         * Scripts/run-jsc-stress-tests:
1359
1360 2013-12-10  Ryuan Choi  <ryuan.choi@samsung.com>
1361
1362         Unreviewed EFL build fix attempt
1363
1364         * TestWebKitAPI/CMakeLists.txt: Added ${WEBKIT2_DIR}/Platform/CoreIPC to include lists.
1365         * WebKitTestRunner/CMakeLists.txt: Ditto.
1366
1367 2013-12-10  Anders Carlsson  <andersca@apple.com>
1368
1369         Add a HashMap constructor that takes an initializer list
1370         https://bugs.webkit.org/show_bug.cgi?id=125551
1371
1372         Reviewed by Dan Bernstein.
1373
1374         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1375         (TestWebKitAPI::TEST):
1376
1377 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1378
1379         Use std::array when computing MD5 checksum
1380         https://bugs.webkit.org/show_bug.cgi?id=125509
1381
1382         Reviewed by Anders Carlsson.
1383
1384         Use MD5::Digest type and MD5::hashSize when computing MD5 checksum.
1385
1386         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
1387         (computeMD5HashStringForBitmapContext):
1388         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
1389         (computeMD5HashStringForBitmapContext):
1390         * TestWebKitAPI/Tests/WTF/MD5.cpp:
1391         (TestWebKitAPI::expectMD5):
1392         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1393         (WTR::computeMD5HashStringForCairoSurface):
1394         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1395         (WTR::computeMD5HashStringForContext):
1396
1397 2013-12-10  Mario Sanchez Prada  <mario.prada@samsung.com>
1398
1399         [ATK] Expose splitter elements with ATK_ROLE_SEPARATOR
1400         https://bugs.webkit.org/show_bug.cgi?id=125522
1401
1402         Reviewed by Chris Fleizach.
1403
1404         Update strings representing ATK_ROLE_SEPARATOR for layout tests.
1405
1406         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1407         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1408
1409 2013-12-10  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1410
1411         Add --makeargs option to build-jsc
1412         https://bugs.webkit.org/show_bug.cgi?id=125344
1413
1414         Reviewed by Filip Pizlo.
1415
1416         * Scripts/build-jsc: Handle and pass makefile arguments in jsc build.
1417
1418 2013-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
1419
1420         AX: [ATK] Convert the get_text atktest.c unit tests to layout tests
1421         https://bugs.webkit.org/show_bug.cgi?id=125497
1422
1423         Reviewed by Mario Sanchez Prada.
1424
1425         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1426         (AccessibilityUIElement::stringForRange): Implemented.
1427         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1428         (WTR::AccessibilityUIElement::stringForRange): Implemented.
1429
1430 2013-12-10  Martin Robinson  <mrobinson@igalia.com>
1431
1432         Various fixes for the CMake GTK+ build
1433
1434         Reviewed by Gustavo Noronha.
1435
1436         * MiniBrowser/gtk/CMakeLists.txt: Update source list and correct the name of BrowserMarshal.h.
1437         * TestWebKitAPI/PlatformGTK.cmake: Add GTK+ libraries to the test program. They're required.
1438
1439 2013-12-10  László Langó  <lango@inf.u-szeged.hu>
1440
1441         --cloop option does not work in Tools/Scripts/build-jsc.
1442         https://bugs.webkit.org/show_bug.cgi?id=125214
1443
1444         Reviewed by Csaba Osztrogonác.
1445
1446         * Scripts/build-jsc:
1447
1448 2013-12-10  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1449
1450         Merge mark_for_landing and mark_for_commit_queue into one argument
1451         https://bugs.webkit.org/show_bug.cgi?id=125448
1452
1453         Reviewed by Ryosuke Niwa.
1454
1455         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1456         (CommitQueueFlag):
1457         (Bugzilla._commit_queue_flag):
1458         (Bugzilla._fill_attachment_form):
1459         (Bugzilla.add_patch_to_bug):
1460         (Bugzilla.create_bug):
1461         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1462         (test_commit_queue_flag.assert_commit_queue_flag):
1463         (test_commit_queue_flag):
1464
1465 2013-12-09  Tim Horton  <timothy_horton@apple.com>
1466
1467         Remove dead extract_reference_link.py (and the reftests module)
1468         https://bugs.webkit.org/show_bug.cgi?id=125116
1469
1470         Reviewed by Ryosuke Niwa.
1471
1472         This code doesn't seem to have ever been used.
1473
1474         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Removed.
1475         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Removed.
1476         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Removed.
1477
1478 2013-12-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1479
1480         [ATK] Translate ATK_ROLE_SECTION into "AXSection" in DRT/WKTR
1481         https://bugs.webkit.org/show_bug.cgi?id=125456
1482
1483         Reviewed by Chris Fleizach.
1484
1485         Return 'AXSection' for section roles instead of 'AXDiv'.
1486
1487         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1488         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1489
1490 2013-12-09  Brian J. Burg  <burg@cs.washington.edu>
1491
1492         check-webkit-style should check for extra newlines at EOF
1493         https://bugs.webkit.org/show_bug.cgi?id=125424
1494
1495         Reviewed by Darin Adler.
1496
1497         Report a style violation if extraneous newlines are added
1498         to the end of a C++ file. There should only be one newline at EOF.
1499
1500         * Scripts/webkitpy/style/checkers/cpp.py:
1501         (check_for_missing_new_line_at_eof): Renamed from check_for_new_line_at_eof.
1502         (check_for_extra_new_line_at_eof): Added.
1503         (_process_lines): Added new check and renamed existing EOF check.
1504         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1505         (CppStyleTest.test_extra_newlines_at_eof): Added.
1506         (CppStyleTest.test_extra_newlines_at_eof.do_test): Added.
1507
1508 2013-12-09  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1509
1510         check-webkit-style: ternary operator in macro call identified as initialization list
1511         https://bugs.webkit.org/show_bug.cgi?id=125443
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         Do not match initialization list when questionmark is placed before :
1516
1517         * Scripts/webkitpy/style/checkers/cpp.py:
1518         (check_member_initialization_list):
1519
1520 2013-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
1521
1522         AX: [ATK] Convert the get_{string,text}_at_offset atktest.c unit tests to layout tests
1523         https://bugs.webkit.org/show_bug.cgi?id=125451
1524
1525         Reviewed by Mario Sanchez Prada.
1526
1527         Create the needed callbacks for DRT and WKTR.
1528
1529         * DumpRenderTree/AccessibilityUIElement.cpp:
1530         (characterAtOffsetCallback): added
1531         (wordAtOffsetCallback): added
1532         (lineAtOffsetCallback): added
1533         (sentenceAtOffsetCallback): added
1534         (AccessibilityUIElement::getJSClass):
1535         * DumpRenderTree/AccessibilityUIElement.h:
1536         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1537         (stringAtOffset): added
1538         (AccessibilityUIElement::characterAtOffset): added
1539         (AccessibilityUIElement::wordAtOffset): added
1540         (AccessibilityUIElement::lineAtOffset): added
1541         (AccessibilityUIElement::sentenceAtOffset): added
1542         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1543         (WTR::AccessibilityUIElement::characterAtOffset): added
1544         (WTR::AccessibilityUIElement::wordAtOffset): added
1545         (WTR::AccessibilityUIElement::lineAtOffset): added
1546         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1547         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1548         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1550         (WTR::stringAtOffset): added
1551         (WTR::AccessibilityUIElement::characterAtOffset): added
1552         (WTR::AccessibilityUIElement::wordAtOffset): added
1553         (WTR::AccessibilityUIElement::lineAtOffset): added
1554         (WTR::AccessibilityUIElement::sentenceAtOffset): added
1555
1556 2013-12-08  Sam Weinig  <sam@webkit.org>
1557
1558         32-bit MiniBrowser doesn't build
1559         https://bugs.webkit.org/show_bug.cgi?id=125420
1560
1561         Reviewed by Dan Bernstein.
1562
1563         * MiniBrowser/mac/AppDelegate.h:
1564         * MiniBrowser/mac/AppDelegate.m:
1565         (-[BrowserAppDelegate init]):
1566         (-[BrowserAppDelegate applicationWillTerminate:]):
1567
1568 2013-12-08  Brian Holt  <brian.holt@samsung.com>
1569
1570         [WK2] Add ENABLE_NETWORK_PROCESS flag
1571         https://bugs.webkit.org/show_bug.cgi?id=125421
1572
1573         Add support to build with the Network Process enabled.
1574
1575         Reviewed by Martin Robinson.
1576
1577         * Scripts/webkitperl/FeatureList.pm:
1578
1579 2013-12-07  Filip Pizlo  <fpizlo@apple.com>
1580
1581         Fold typedArray.length if typedArray is constant
1582         https://bugs.webkit.org/show_bug.cgi?id=125252
1583
1584         Reviewed by Sam Weinig.
1585         
1586         Add Source/JavaScriptCore/tests/stress to the set of JS tests. This is where you
1587         should put tests that run just like JSRegress but don't run as part of LayoutTests.
1588         Currently I'm using it for tests that require some surgical support from jsc.cpp.
1589
1590         * Scripts/run-javascriptcore-tests:
1591
1592 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1593
1594         [gdb] Update printers for WTF::CString, JSC::JSString
1595         https://bugs.webkit.org/show_bug.cgi?id=124600
1596
1597         Reviewed by Gustavo Noronha Silva.
1598
1599         Update the two printers after they fell behind the changes in implementation.
1600
1601         * gdb/webkit.py:
1602         (WTFCStringPrinter.to_string):
1603         (JSCJSStringPrinter.to_string):
1604
1605 2013-12-08  Zan Dobersek  <zdobersek@igalia.com>
1606
1607         [webkitpy] Add a WestonDriver unit test
1608         https://bugs.webkit.org/show_bug.cgi?id=125408
1609
1610         Reviewed by Gustavo Noronha Silva.
1611
1612         Add a webkitpy unit test for the Weston driver.
1613
1614         * Scripts/webkitpy/port/westondriver_unittest.py: Added.
1615         (WestonDriverTest):
1616         (WestonDriverTest.make_driver): Sets up a new WestonDriver instance for testing purposes.
1617         (WestonDriverTest.test_start): Check that the Weston compositor is launched properly and that
1618         the server environment contains proper WAYLAND and GDK_BACKEND entries.
1619         (WestonDriverTest.test_stop): Check that the Weston compositor is terminated properly and that
1620         the driver cleans up the temporary directory.
1621         (WestonDriverTest.test_stop.FakeWestonProcess): A helper class that logs the expected termination.
1622         (WestonDriverTest.test_stop.FakeWestonProcess.terminate):
1623
1624 2013-12-08  Brendan Long  <b.long@cablelabs.com>
1625
1626         [Gtk] install-dependencies doesn't install libgtk-3-dev
1627         https://bugs.webkit.org/show_bug.cgi?id=125320
1628
1629         Reviewed by Gustavo Noronha Silva.
1630
1631         * gtk/install-dependencies: Add libgtk-3-dev, libsoup2.4 and subversion
1632
1633 2013-12-07  Sam Weinig  <sam@webkit.org>
1634
1635         [Cocoa] Convert a few more parts of MiniBrowser over to the Objective-C API
1636         https://bugs.webkit.org/show_bug.cgi?id=125401
1637
1638         Reviewed by Dan Bernstein.
1639
1640         * MiniBrowser/mac/WK2BrowserWindowController.m:
1641         (-[WK2BrowserWindowController fetch:]):
1642         (-[WK2BrowserWindowController reload:]):
1643         (-[WK2BrowserWindowController goBack:]):
1644         (-[WK2BrowserWindowController goForward:]):
1645         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1646         (-[WK2BrowserWindowController currentZoomFactor]):
1647         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1648         (-[WK2BrowserWindowController zoomIn:]):
1649         (-[WK2BrowserWindowController zoomOut:]):
1650         (-[WK2BrowserWindowController canResetZoom]):
1651         (-[WK2BrowserWindowController resetZoom:]):
1652         (-[WK2BrowserWindowController toggleZoomMode:]):
1653         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
1654
1655 2013-12-07  Sam Weinig  <sam@webkit.org>
1656
1657         Convert MiniBrowser to use WKProcessGroup and WKBrowsingContextGroup
1658         https://bugs.webkit.org/show_bug.cgi?id=125400
1659
1660         Reviewed by Dan Bernstein.
1661
1662         * MiniBrowser/mac/AppDelegate.h:
1663         * MiniBrowser/mac/AppDelegate.m:
1664         * MiniBrowser/mac/WK2BrowserWindowController.h:
1665         * MiniBrowser/mac/WK2BrowserWindowController.m:
1666         (-[WK2BrowserWindowController initWithProcessGroup:browsingContextGroup:]):
1667         (-[WK2BrowserWindowController dealloc]):
1668         (createNewPage):
1669         (-[WK2BrowserWindowController awakeFromNib]):
1670         (-[WK2BrowserWindowController browsingContextController:didNavigateWithNavigationData:]):
1671         (-[WK2BrowserWindowController browsingContextController:didPerformClientRedirectFromURL:toURL:]):
1672         (-[WK2BrowserWindowController browsingContextController:didPerformServerRedirectFromURL:toURL:]):
1673         (-[WK2BrowserWindowController browsingContextController:didUpdateHistoryTitle:forURL:]):
1674         Replace global WKContextRef and WKPageGroupRef with WKProcessGroup and WKBrowsingContextGroup. Also
1675         replace context based WKContextHistoryClient with WKBrowsingContextController based WKBrowsingContextHistoryDelegate
1676
1677 2013-12-07  Gustavo Noronha Silva  <gns@gnome.org>
1678
1679         [GTK] Run each gtest subtest separately instead of in one go
1680         https://bugs.webkit.org/show_bug.cgi?id=125386
1681
1682         Reviewed by Martin Robinson.
1683
1684         This is what other ports are doing (except they build each test as a separate binary)
1685         and will help with the timeouts we sometimes hit because it applies to the full test
1686         run.
1687
1688         * Scripts/run-gtk-tests:
1689         (TestRunner._get_tests_from_google_test_suite): get a list of available sub-tests.
1690         (TestRunner._run_google_test): run a single subtest from a gtest binary.
1691         (TestRunner._run_google_test_suite): call the binary once per subtest.
1692
1693 2013-12-07  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1694
1695         Move PrettyPatch related code to prettypatch.py
1696         https://bugs.webkit.org/show_bug.cgi?id=124937
1697
1698         Reviewed by Ryosuke Niwa.
1699
1700         This code seems to have a better place here than in Port, since PrettyPatch already knows
1701         pretty_patch_path, and this also unifies the usage of PrettyPatch
1702
1703         * Scripts/webkitpy/common/prettypatch.py:
1704         (PrettyPatch.__init__):
1705         (PrettyPatch.pretty_diff):
1706         (PrettyPatch):
1707         (PrettyPatch.pretty_patch_available):
1708         (PrettyPatch.check_pretty_patch):
1709         (PrettyPatch.pretty_patch_text):
1710         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1711         (TestResultWriter.create_text_diff_and_write_result):
1712         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1713         (summarize_results):
1714         * Scripts/webkitpy/port/base.py:
1715         (Port.__init__):
1716         (Port.wdiff_available):
1717         (Port.check_image_diff):
1718         (Port.wdiff_text):
1719         * Scripts/webkitpy/port/base_unittest.py:
1720         (PortTest.test_pretty_patch_os_error):
1721         (PortTest.test_pretty_patch_script_error):
1722
1723 2013-12-06  Dan Bernstein  <mitz@apple.com>
1724
1725         [Mac] MiniBrowser Debug builds are compiled with -Os
1726         https://bugs.webkit.org/show_bug.cgi?id=125376
1727
1728         Reviewed by Tim Horton.
1729
1730         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Set GCC_OPTIMIZATION_LEVEL to 0 for
1731         the Debug configuration at the project level.
1732
1733 2013-12-06  Jer Noble  <jer.noble@apple.com>
1734
1735         [MSE] Add a runtime-setting for the MediaSource constructor.
1736         https://bugs.webkit.org/show_bug.cgi?id=125336
1737
1738         Reviewed by Eric Carlson.
1739
1740         Enable MediaSource in DRT and WKTR.
1741
1742         * DumpRenderTree/mac/DumpRenderTree.mm:
1743         (resetWebPreferencesToConsistentValues):
1744         * WebKitTestRunner/TestController.cpp:
1745         (WTR::TestController::resetPreferencesToConsistentValues):
1746
1747 2013-12-06  Jer Noble  <jer.noble@apple.com>
1748
1749         Strip out extraneous logging from AppleGVA in media tests.
1750         https://bugs.webkit.org/show_bug.cgi?id=125357
1751
1752         Reviewed by Simon Fraser.
1753
1754         Add a mechanism for stripping out abritrary regular expressions from test input and output.
1755
1756         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1757         (SingleTestRunner._run_compare_test): Strip out logging
1758         * Scripts/webkitpy/port/base.py:
1759         (Port.logging_patterns_to_strip): Return an empty list by default.
1760         * Scripts/webkitpy/port/driver.py:
1761         (DriverOutput.strip_patterns): Apply the port specific patterns to the text.
1762         * Scripts/webkitpy/port/mac.py:
1763         (MacPort.logging_patterns_to_strip): Return a complete list.
1764
1765 2013-12-06  Dean Jackson  <dino@apple.com>
1766
1767         Updating ANGLE should point to instructions
1768         https://bugs.webkit.org/show_bug.cgi?id=125361
1769
1770         Reviewed by Eric Carlson.
1771
1772         Point to https://trac.webkit.org/wiki/UpdatingANGLE when
1773         someone wants to patch ANGLE.
1774
1775         * Scripts/webkitpy/common/config/watchlist:
1776
1777 2013-12-06  Dan Bernstein  <mitz@apple.com>
1778
1779         [Mac] Transition MiniBrowser to the Cocoa API: load delegate
1780         https://bugs.webkit.org/show_bug.cgi?id=125334
1781
1782         Reviewed by Darin Adler.
1783
1784         * MiniBrowser/mac/WK2BrowserWindowController.m:
1785         (-[WK2BrowserWindowController dealloc]): Nil out the load delegate and stop observing the
1786         title property.
1787         (-[WK2BrowserWindowController isPaginated]): Changed to use Cocoa SPI.
1788         (-[WK2BrowserWindowController togglePaginationMode:]): Ditto.
1789         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]): Update the
1790         window title with the title property changes.
1791         (-[WK2BrowserWindowController awakeFromNib]): Start observing the title property. Changed to
1792         set the load delegate instead of the load client.
1793         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Changed to use Cocoa types.
1794         (-[WK2BrowserWindowController updateProvisionalURL]): Removed frame parameter.
1795         (-[WK2BrowserWindowController updateCommittedURL]): Ditto.
1796         (-[WK2BrowserWindowController browsingContextControllerDidStartProvisionalLoad:]):
1797         Implemented this load delegate method.
1798         (-[WK2BrowserWindowController browsingContextControllerDidReceiveServerRedirectForProvisionalLoad:]):
1799         Ditto.
1800         (-[WK2BrowserWindowController browsingContextController:didFailProvisionalLoadWithError:]): Ditto.
1801         (-[WK2BrowserWindowController browsingContextControllerDidCommitLoad:]): Ditto.
1802         (-[WK2BrowserWindowController browsingContextControllerDidFinishLoad:]): Ditto.
1803         (-[WK2BrowserWindowController browsingContextController:didFailLoadWithError:]): Ditto.
1804         (-[WK2BrowserWindowController browsingContextControllerDidChangeBackForwardList:addedItem:removedItems:]):
1805         Ditto.
1806         (-[WK2BrowserWindowController browsingContextController:canAuthenticateAgainstProtectionSpace:]):
1807         Ditto.
1808         (-[WK2BrowserWindowController browsingContextController:didReceiveAuthenticationChallenge:]): Ditto.
1809
1810 2013-12-06  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1811
1812         Remove function from style/checkers/cpp.py.
1813         https://bugs.webkit.org/show_bug.cgi?id=125341
1814
1815         Reviewed by Darin Adler.
1816
1817         Corrects a FIXME: by removing a function from cpp.py.
1818
1819         * Scripts/webkitpy/style/checkers/cpp.py:
1820         (CppChecker.__init__):
1821         (CppChecker.check):
1822         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1823         (CppStyleTestBase.process_file_data):
1824
1825 2013-12-06  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
1826
1827         check-webkit-style: false positive warning for indentation of #ifdef code.
1828         https://bugs.webkit.org/show_bug.cgi?id=125254
1829
1830         Reviewed by Darin Adler.
1831
1832         * Scripts/webkitpy/style/checkers/cpp.py:
1833         (check_member_initialization_list):
1834         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1835         (WebKitStyleTest.test_member_initialization_list):
1836
1837 2013-12-06  Chris Fleizach  <cfleizach@apple.com>
1838
1839         Fix spelling error in style checker: beggining
1840         https://bugs.webkit.org/show_bug.cgi?id=125347
1841
1842         Reviewed by Anders Carlsson.
1843
1844         * Scripts/webkitpy/style/checkers/cpp.py:
1845         (check_member_initialization_list):
1846         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1847         (WebKitStyleTest.test_member_initialization_list):
1848
1849 2013-12-06  Lukasz Gajowy  <l.gajowy@samsung.com>
1850
1851         [ATK] Missing aria roles mappings
1852         https://bugs.webkit.org/show_bug.cgi?id=117729
1853
1854         Reviewed by Mario Sanchez Prada.
1855
1856         Added new mappings to AccessibilityUIElementAtk.cpp.
1857
1858         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1859         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1860
1861 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1862
1863         Typo fix after r160218.
1864
1865         * Scripts/webkitpy/test/main.py:
1866         (main):
1867
1868 2013-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1869
1870         Unreviewed fix after r160206.
1871
1872         * Scripts/webkitpy/test/main.py:
1873         (main): sys.platform can be win32 or cygwin too on Windows.
1874
1875 2013-12-05  Csaba Osztrogonác  <ossy@webkit.org>
1876
1877         Disable WebKit2 webkitpy unittests on Windows
1878         https://bugs.webkit.org/show_bug.cgi?id=125318
1879
1880         Reviewed by Ryosuke Niwa.
1881
1882         * Scripts/webkitpy/test/main.py:
1883         (main):
1884
1885 2013-12-05  Anders Carlsson  <andersca@apple.com>
1886
1887         Tweak WeakObjCPtr
1888         https://bugs.webkit.org/show_bug.cgi?id=125311
1889
1890         Reviewed by Darin Adler.
1891
1892         Split up tests into more logical groups. Add new tests for new functionality.
1893
1894         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm:
1895
1896 2013-12-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1897
1898         [GTK] Fix gtk-doc warnings when generating DOM bindings API docs
1899         https://bugs.webkit.org/show_bug.cgi?id=125302
1900
1901         Reviewed by Philippe Normand.
1902
1903         * gtk/generate-webkitdom-doc-files:
1904         (WebKitDOMDocGeneratorSections.write_footer): Add a new section
1905         containing a private subsection for WEBKIT_API, WEBKIT_DEPRECATED
1906         and WEBKIT_DEPRECATED_FOR macros.
1907
1908 2013-12-05  Laszlo Vidacs  <lac@inf.u-szeged.hu>
1909
1910         Fix cross compilation on x86
1911         https://bugs.webkit.org/show_bug.cgi?id=125295
1912
1913         Reviewed by Zoltan Herczeg.
1914
1915         Certain compiler flags should not be added when cross compilation is enabled.
1916
1917         * Scripts/webkitdirs.pm:
1918         (runAutogenForAutotoolsProjectIfNecessary):
1919         (generateBuildSystemFromCMakeProject):
1920
1921 2013-12-05  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
1922
1923         Remove duplicated/dead code from cpp style checker unit tests.
1924         https://bugs.webkit.org/show_bug.cgi?id=125226
1925
1926         Reviewed by Ryosuke Niwa.
1927
1928         Remove the first definition of OrderOfIncludesTest class as it is
1929         overwritten by the second. Remove a duplicated assert statement
1930         from the second class.
1931
1932         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1933         (OrderOfIncludesTest.setUp):
1934         (OrderOfIncludesTest.test_try_drop_common_suffixes):
1935           The last assert was duplicated.
1936
1937 2013-12-05  László Langó  <lango@inf.u-szeged.hu>
1938
1939         Remove Scripts/generate-qt-inspector-resource.
1940         https://bugs.webkit.org/show_bug.cgi?id=125288
1941
1942         Reviewed by Andreas Kling.
1943
1944         * Scripts/generate-qt-inspector-resource: Removed. There is no QT anymore.
1945         We don't need this file.
1946
1947 2013-12-05  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
1948
1949         Remove certain methods from TestExpectations and use TestExpectationsModel instead of them
1950         https://bugs.webkit.org/show_bug.cgi?id=125218
1951
1952         Reviewed by Ryosuke Niwa.
1953
1954         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1955         (LayoutTestFinder.skip_tests):
1956         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1957         (LayoutTestRunner.run_tests):
1958         (LayoutTestRunner._update_summary_with_result):
1959         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1960         (Manager._test_is_slow):
1961         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1962         (JSONLayoutResultsGenerator._insert_failure_summaries):
1963         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1964         (TestExpectations.get_rebaselining_failures):
1965         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1966         (assert_exp):
1967         (MiscTests.test_multiple_results):
1968         (MiscTests.test_category_expectations):
1969         (MiscTests.test_get_modifiers):
1970         (MiscTests.test_get_expectations_string):
1971         (MiscTests.test_expectation_to_string):
1972         (MiscTests.test_get_test_set):
1973         (MiscTests.test_more_specific_override_resets_skip):
1974         (SkippedTests.check):
1975         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1976         (TestRunResults.__init__):
1977         (summarize_results):
1978         * Scripts/webkitpy/tool/commands/rebaseline.py:
1979         (RebaselineExpectations._tests_to_rebaseline):
1980
1981 2013-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1982
1983         Enable HTMLTemplateElement by default
1984         https://bugs.webkit.org/show_bug.cgi?id=123851
1985
1986         Reviewed by Antti Koivisto.
1987
1988         * Scripts/webkitperl/FeatureList.pm:
1989
1990 2013-12-04  Jozsef Berta  <jberta@inf.u-szeged.hu>
1991
1992         [EFL] Bumping GStreamer version to 1.2.1
1993         https://bugs.webkit.org/show_bug.cgi?id=125155
1994
1995         Reviewed by Gyuyoung Kim.
1996
1997         * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
1998
1999
2000 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2001
2002         Update jhbuild revision.
2003         https://bugs.webkit.org/show_bug.cgi?id=124966
2004         
2005         Reviewed by Gyuyoung Kim.
2006
2007         Used version of Jhbuild failed to create directories and caused
2008         update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
2009
2010         * jhbuild/jhbuild-wrapper:
2011
2012 2013-12-04  Anders Carlsson  <andersca@apple.com>
2013
2014         Add a WeakObjCPtr class
2015         https://bugs.webkit.org/show_bug.cgi?id=125267
2016
2017         Reviewed by Geoffrey Garen.
2018
2019         Add API tests for WeakObjCPtr.
2020
2021         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2022         * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
2023         (TEST):
2024
2025 2013-12-04  Anders Carlsson  <andersca@apple.com>
2026
2027         Make the estimatedProgress property observable using KVO
2028         https://bugs.webkit.org/show_bug.cgi?id=125259
2029
2030         Reviewed by Dan Bernstein.
2031
2032         Bind the progress indicator value to the "estimatedProgress" property.
2033
2034         * MiniBrowser/mac/WK2BrowserWindowController.m:
2035         (-[WK2BrowserWindowController dealloc]):
2036         (-[WK2BrowserWindowController awakeFromNib]):
2037
2038 2013-12-04  Anders Carlsson  <andersca@apple.com>
2039
2040         Add a loading property to WKBrowsingContextController
2041         https://bugs.webkit.org/show_bug.cgi?id=125256
2042
2043         Reviewed by Dan Bernstein.
2044
2045         Bind the progress indicator visibility to the "loading" property.
2046
2047         * MiniBrowser/mac/WK2BrowserWindowController.m:
2048         (-[WK2BrowserWindowController dealloc]):
2049         (-[WK2BrowserWindowController awakeFromNib]):
2050         (-[WK2BrowserWindowController didStartProgress]):
2051         (-[WK2BrowserWindowController didFinishProgress]):
2052
2053 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2054
2055         [EFL][WK2] Buildfix after r160104
2056         https://bugs.webkit.org/show_bug.cgi?id=125231
2057
2058         Reviewed by Anders Carlsson.
2059
2060         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2061         (TestWebKitAPI::TEST): reinterpret_cast<WKFooClientBase*>(&client) -> &client.base
2062         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2063         (TestWebKitAPI::setViewClient): Ditto.
2064
2065 2013-12-04  Myles C. Maxfield  <mmaxfield@apple.com>
2066
2067         check-webkit-style detected some ternary statements as initialization lists
2068         https://bugs.webkit.org/show_bug.cgi?id=125246
2069
2070         Reviewed by Dean Jackson.
2071
2072         The regular expression that check-webkit-tests uses to detect initialization
2073         lists was too broad, resulting in false positives. This patch makes the
2074         regex more specific
2075
2076         * Scripts/webkitpy/style/checkers/cpp.py:
2077         (check_member_initialization_list):
2078         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2079         (WebKitStyleTest.test_member_initialization_list):
2080
2081 2013-12-04  Mark Hahnenberg  <mhahnenberg@apple.com>
2082
2083         run-jsc-stress-tests can only run locally
2084         https://bugs.webkit.org/show_bug.cgi?id=124551
2085
2086         Reviewed by Filip Pizlo.
2087
2088         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Fixed a couple issues. One was if the script was
2089         killed before the lock directory was removed, future executions wouldn't make any progress. Also 
2090         added a couple more signals to handle gracefully at shutdown. 
2091         * Scripts/run-javascriptcore-tests: Pass through the --remote argument to run-jsc-stress-tests.
2092         * Scripts/run-jsc-stress-tests: Added support for the --remote flag. It accepts a hostname, user, and port.
2093         The script then generates the test bundle, tars it up, and copies it to the remote host via ssh where
2094         it then untars the bundle and executes the shell-based test runner. Also refactored some of the logic
2095         toward the end of the script to make it easier to tell which of the various modes do what.
2096
2097 2013-12-04  Csaba Osztrogonác  <ossy@webkit.org>
2098
2099         [EFL][WK2] Buildfix after r160104
2100         https://bugs.webkit.org/show_bug.cgi?id=125233
2101
2102         Reviewed by Anders Carlsson.
2103
2104         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2105         (TestWebKitAPI::TEST):
2106         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2107         (TestWebKitAPI::setPageLoaderClient):
2108
2109 2013-12-03  Anders Carlsson  <andersca@apple.com>
2110
2111         Deprecate all unversioned client structs in favor of having explicit versioned structs
2112         https://bugs.webkit.org/show_bug.cgi?id=125203
2113
2114         Reviewed by Dan Bernstein.
2115
2116         Update for WebKit2 API changes.
2117
2118         * MiniBrowser/mac/AppDelegate.m:
2119         (-[BrowserAppDelegate init]):
2120         * MiniBrowser/mac/WK2BrowserWindowController.m:
2121         (-[WK2BrowserWindowController awakeFromNib]):
2122         * TestWebKitAPI/InjectedBundleController.cpp:
2123         (TestWebKitAPI::InjectedBundleController::initialize):
2124         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2125         (TestWebKitAPI::TEST):
2126         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2127         (TestWebKitAPI::setInjectedBundleClient):
2128         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2129         (TestWebKitAPI::TEST):
2130         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2131         (TestWebKitAPI::TEST):
2132         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2133         (TestWebKitAPI::TEST):
2134         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2135         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
2136         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2137         (TestWebKitAPI::TEST):
2138         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2139         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
2140         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2141         (TestWebKitAPI::setInjectedBundleClient):
2142         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2143         (TestWebKitAPI::DidAssociateFormControlsTest::didCreatePage):
2144         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2145         (TestWebKitAPI::TEST):
2146         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2147         (TestWebKitAPI::TEST):
2148         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2149         (TestWebKitAPI::setContextDownloadClient):
2150         (TestWebKitAPI::setPagePolicyClient):
2151         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2152         (TestWebKitAPI::TEST):
2153         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2154         (TestWebKitAPI::TEST):
2155         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2156         (TestWebKitAPI::TEST):
2157         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2158         (TestWebKitAPI::TEST):
2159         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2160         (TestWebKitAPI::TEST):
2161         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2162         (TestWebKitAPI::TEST):
2163         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2164         (TestWebKitAPI::setupGeolocationProvider):
2165         (TestWebKitAPI::setupView):
2166         (TestWebKitAPI::TEST):
2167         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2168         (TestWebKitAPI::TEST):
2169         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2170         (TestWebKitAPI::setPageLoaderClient):
2171         (TestWebKitAPI::setInjectedBundleClient):
2172         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2173         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2174         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2175         (TestWebKitAPI::TEST):
2176         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2177         (TestWebKitAPI::setInjectedBundleClient):
2178         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2179         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
2180         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2181         (TestWebKitAPI::TEST):
2182         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2183         (TestWebKitAPI::TEST):
2184         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2185         (TestWebKitAPI::TEST):
2186         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2187         (TestWebKitAPI::TEST):
2188         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2189         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage):
2190         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2191         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
2192         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2193         (TestWebKitAPI::setPageLoaderClient):
2194         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2195         (TestWebKitAPI::setPageLoaderClient):
2196         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2197         (TestWebKitAPI::setPageLoaderClient):
2198         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2199         (TestWebKitAPI::setPageLoaderClient):
2200         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2201         (TestWebKitAPI::setPageLoaderClient):
2202         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2203         (TestWebKitAPI::TEST):
2204         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2205         (TestWebKitAPI::TEST):
2206         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2207         (TestWebKitAPI::setInjectedBundleClient):
2208         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2209         (TestWebKitAPI::ParentFrameTest::didCreatePage):
2210         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2211         (TestWebKitAPI::setInjectedBundleClient):
2212         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2213         (TestWebKitAPI::PasteboardNotificationsTest::didCreatePage):
2214         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2215         (TestWebKitAPI::TEST):
2216         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2217         (TestWebKitAPI::TEST):
2218         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2219         (TestWebKitAPI::TEST):
2220         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2221         (TestWebKitAPI::TEST):
2222         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2223         (TestWebKitAPI::setInjectedBundleClient):
2224         (TestWebKitAPI::setPageLoaderClient):
2225         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2226         (TestWebKitAPI::setPageLoaderClient):
2227         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2228         (TestWebKitAPI::TEST):
2229         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2230         (TestWebKitAPI::setPageLoaderClient):
2231         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2232         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
2233         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2234         (TestWebKitAPI::TEST):
2235         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2236         (TestWebKitAPI::TEST):
2237         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2238         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
2239         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
2240         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp:
2241         (TestWebKitAPI::TEST):
2242         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp:
2243         (TestWebKitAPI::WKConnectionTest::initialize):
2244         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2245         (TestWebKitAPI::setPageLoaderClient):
2246         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2247         (TestWebKitAPI::setInjectedBundleClient):
2248         (TestWebKitAPI::TEST):
2249         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2250         (TestWebKitAPI::WebKit2WillLoadTest::setInjectedBundleClient):
2251         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2252         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2253         (TestWebKitAPI::setInjectedBundleClient):
2254         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2255         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
2256         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
2257         (TestWebKitAPI::TEST):
2258         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
2259         (TestWebKitAPI::setInjectedBundleClient):
2260         * TestWebKitAPI/Tests/WebKit2/mac/GetPIDAfterAbortedProcessLaunch.cpp:
2261         (TestWebKitAPI::TEST):
2262         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2263         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2264         (TestWebKitAPI::DenyWillSendRequestTest::didCreatePage):
2265         * TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:
2266         (TestWebKitAPI::didCreateConnection):
2267         (TestWebKitAPI::TEST):
2268         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2269         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2270         * TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:
2271         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2272         (TestWebKitAPI::setPageLoaderClient):
2273         * WebKitTestRunner/GeolocationProviderMock.cpp:
2274         (WTR::GeolocationProviderMock::GeolocationProviderMock):
2275         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2276         (WTR::InjectedBundle::initialize):
2277         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2278         (WTR::InjectedBundlePage::InjectedBundlePage):
2279         * WebKitTestRunner/TestController.cpp:
2280         (WTR::TestController::createOtherPage):
2281         (WTR::TestController::initialize):
2282         (WTR::TestController::createWebViewWithOptions):
2283
2284 2013-12-04  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2285
2286         Style checker for .messages.in files (WTF:: prefix)
2287         https://bugs.webkit.org/show_bug.cgi?id=125142
2288
2289         Reviewed by Anders Carlsson.
2290
2291         A new style checker for .messages.in files, that checks for the use of WTF::
2292         prefix in these files. (Also checks for tabs as these files were previously
2293         handled as text files.)
2294
2295         * Scripts/webkitpy/style/checker.py:
2296         (CheckerDispatcher._create_checker):
2297           New checker is returned for .messages.in files.
2298         * Scripts/webkitpy/style/checkers/messagesin.py: Added.
2299           The new style checker class.
2300         (MessagesInChecker):
2301         (MessagesInChecker.__init__):
2302         (MessagesInChecker.check):
2303         (MessagesInChecker.check_WTF_prefix):
2304         * Scripts/webkitpy/style/checkers/messagesin_unittest.py: Added.
2305           Unit test for the new style  checker class.
2306         (MessagesInCheckerStyleTestCase):
2307         (test_checker):
2308         (test_checker.error_handler_for_test):
2309         (MessagesInCheckerTestCase):
2310         (MessagesInCheckerTestCase.test_init):
2311         (MessagesInCheckerTestCase.test_init.error_handler_for_test):
2312
2313 2013-12-04  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2314
2315         Style checker requires alphabetical ordering in cmake lists even it contains variable.
2316         https://bugs.webkit.org/show_bug.cgi?id=124918
2317
2318         Reviewed by Csaba Osztrogonác.
2319
2320         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2321         (CMakeCheckerTest.test_check):
2322         * Scripts/webkitpy/style/checkers/cmake.py:
2323         (CMakeChecker._check_list_order):
2324         This will ignore lines with variable substitution.
2325
2326 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2327
2328         check-webkit-style is wrong about expected format parameter pack rvalue reference arguments
2329         https://bugs.webkit.org/show_bug.cgi?id=124731
2330
2331         Reviewed by Zoltan Herczeg.
2332
2333         * Scripts/webkitpy/style/checkers/cpp.py:
2334         (check_spacing):
2335         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2336         (Cpp11StyleTest.test_rvaule_reference_in_parameter_pack):
2337
2338 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2339
2340         Remove codecs and os dependencies from filereader.py in webkitpy/style.
2341         https://bugs.webkit.org/show_bug.cgi?id=124719
2342
2343         Although TextFileReader requires a FileSystem it circumvents it in two places!
2344         We should use the FileSystem only and remove codecs and os imports.
2345
2346         Reviewed by Zoltan Herczeg.
2347
2348         * Scripts/webkitpy/common/system/filesystem.py:
2349         (FileSystem.open_stdin): Moved from TextFileReader
2350         * Scripts/webkitpy/style/filereader.py:
2351         (TextFileReader._read_lines): use FileSystem instead of calling codecs.open directly
2352         (TextFileReader._process_directory): use FileSystem instead of calling os.walk directly
2353
2354 2013-12-04  László Langó  <lango@inf.u-szeged.hu>
2355
2356         check-webkit-style should check member initialization indentation.
2357         https://bugs.webkit.org/show_bug.cgi?id=124820
2358
2359         Reviewed by Zoltan Herczeg.
2360
2361         check-webkit-style should check member initialization indentation
2362         belongs to webkit coding style:
2363         http://www.webkit.org/coding/coding-style.html#punctuation-member-init
2364
2365         * Scripts/webkitpy/style/checkers/cpp.py:
2366         (check_member_initialization_list): Add new method to check member
2367         initialization list.
2368         (check_style): Add the call of the new method.
2369         (check_language): Move self initialization checking into the new method.
2370         (CppChecker): Add a new category for initialization list.
2371         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2372         (CppStyleTest.test_runtime_selfinit):
2373         (CppStyleTest.test_deprecated_cast):
2374         (WebKitStyleTest.test_member_initialization_list): Add new testcases for
2375         the new feature.
2376
2377 2013-12-04  Tamas Gergely  <gertom@inf.u-szeged.hu>
2378
2379         style-bot should reject Committer additions to committers.py
2380         https://bugs.webkit.org/show_bug.cgi?id=107574
2381
2382         Reviewed by Zoltan Herczeg.
2383
2384         The style check when executed in non-interactive mode (probably by a
2385         bot) will raise an additional error if the contributors.json file is
2386         modified. Non-interactive mode information is propagated to the
2387         Dispatcher, which creates a special JSON checker for the
2388         contributors.json file.
2389
2390         * Scripts/webkitpy/style/checker.py:
2391         (check_webkit_style_configuration):
2392         (CheckerDispatcher._create_checker):
2393         (CheckerDispatcher.dispatch):
2394         (StyleProcessorConfiguration.__init__):
2395         (StyleProcessor.process):
2396         * Scripts/webkitpy/style/checker_unittest.py:
2397         (CheckerDispatcherSkipTest._assert_should_skip_without_warning):
2398         (CheckerDispatcherDispatchTest.dispatch):
2399         (StyleProcessorConfigurationTest._style_checker_configuration):
2400         (StyleProcessor_EndToEndTest.test_init):
2401         (StyleProcessor_EndToEndTest.test_process):
2402         (StyleProcessor_CodeCoverageTest.MockDispatcher.dispatch):
2403         (StyleProcessor_CodeCoverageTest.setUp):
2404         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2405         (JSONChecker.line_number_from_json_exception):
2406         (JSONContributorsChecker):
2407         (JSONContributorsChecker.check):
2408         * Scripts/webkitpy/style/error_handlers_unittest.py:
2409         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2410         * Scripts/webkitpy/style/optparser.py:
2411         (CommandOptionValues.__init__):
2412         (ArgumentParser._create_option_parser):
2413         (ArgumentParser.parse):
2414         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2415         (test_post):
2416         (test_upload):
2417         * Scripts/webkitpy/tool/steps/checkstyle.py:
2418         (CheckStyle.run):
2419
2420 2013-12-04  Nick Diego Yamane  <nick.yamane@openbossa.org>
2421
2422         [EFL][WK2] Fix build after API::Client changes
2423         https://bugs.webkit.org/show_bug.cgi?id=125206
2424
2425         Reviewed by Csaba Osztrogonác.
2426
2427         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewIsActiveSetIsActive.cpp:
2428         (TestWebKitAPI::TEST):
2429         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
2430         (TestWebKitAPI::setViewClient):
2431
2432 2013-12-03  Dan Bernstein  <mitz@apple.com>
2433
2434         Fixed a test timing out after r160040.
2435
2436         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
2437         (-[SimpleLoadFailDelegate browsingContextController:didFailProvisionalLoadWithError:]):
2438         Updated for the delegate method rename.
2439
2440 2013-12-03  Filip Pizlo  <fpizlo@apple.com>
2441
2442         REGRESSION: repro scripts disappear when you rerun tests
2443         https://bugs.webkit.org/show_bug.cgi?id=125184
2444
2445         Reviewed by Mark Hahnenberg.
2446         
2447         This bug made it difficult to quickly see if a test that recently failed is still
2448         failing while also running a new batch of tests.
2449
2450         Repro scripts are supposed to stay around until you delete them explicitly. This
2451         patch accomplishes that.
2452
2453         * Scripts/run-jsc-stress-tests:
2454
2455 2013-12-03  peavo@outlook.com  <peavo@outlook.com>
2456
2457         [Win] run-jsc-stress-tests has a great number of failures (2026/7606) on Windows
2458         https://bugs.webkit.org/show_bug.cgi?id=125111
2459
2460         Reviewed by Filip Pizlo.
2461
2462         Almost all errors seem to be caused by differences in line ending when diffing test output with expected output.
2463
2464         * Scripts/run-javascriptcore-tests: Enable api test and stress test for WinCairo.
2465         * Scripts/run-jsc-stress-tests: Ignore carriage return when diffing test output with expected output.
2466
2467 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2468
2469         Add a script to automatically configure a git clone
2470         https://bugs.webkit.org/show_bug.cgi?id=110073
2471
2472         Revert the change to use https for now since git.webkit.org is setup with http.
2473
2474         * Scripts/webkitpy/tool/commands/setupgitclone.py:
2475         (SetupGitClone.execute):
2476
2477 2013-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2478
2479         Add a script to automatically configure a git clone
2480         https://bugs.webkit.org/show_bug.cgi?id=110073
2481
2482         Reviewed by Benjamin Poulain.
2483
2484         Added "webkit-patch setup-git-clone" to setup a brand new Git clone.
2485
2486         This command runs various commands listed on http://trac.webkit.org/wiki/UsingGitWithWebKit
2487
2488         * Scripts/webkitpy/tool/commands/__init__.py:
2489         * Scripts/webkitpy/tool/commands/setupgitclone.py: Added.
2490         (SetupGitClone):
2491         (SetupGitClone.execute):
2492
2493 2013-12-03  Anders Carlsson  <andersca@apple.com>
2494
2495         Deprecate WKNotificationProvider
2496         https://bugs.webkit.org/show_bug.cgi?id=125178
2497
2498         Reviewed by Sam Weinig.
2499
2500         Update for WebKit2 changes.
2501
2502         * WebKitTestRunner/TestController.cpp:
2503         (WTR::TestController::initialize):
2504         * WebKitTestRunner/WebNotificationProvider.cpp:
2505         (WTR::WebNotificationProvider::provider):
2506         * WebKitTestRunner/WebNotificationProvider.h:
2507
2508 2013-12-03  Brent Fulgham  <bfulgham@apple.com>
2509
2510         [Win] Support 64-bit Application Support Libraries Location 
2511         https://bugs.webkit.org/show_bug.cgi?id=125179
2512
2513         Reviewed by Tim Horton.
2514
2515         Enable the user to specify a location for 64-bit support libraries (such as libxml2, ICU, etc.)
2516         on Windows until an official distribution is available that properly creates registry settings
2517         to specify these locations.
2518
2519         * Scripts/webkitdirs.pm:
2520         (setupAppleWinEnv): Notify user to set WEBKIT_64_SUPPORT environment variable if needed.
2521         (setupCygwinEnv): Report WEWBKIT_64_SUPPORT path when running 64-bit builds.
2522         (appleApplicationSupportPath): Add WEBKIT_64_SUPPORT location to runtime environment when
2523         running 64-bit builds.
2524
2525 2013-12-03  Mark Hahnenberg  <mhahnenberg@apple.com>
2526
2527         run-jsc-stress-tests only supports host environments that have make installed
2528         https://bugs.webkit.org/show_bug.cgi?id=124550
2529
2530         Reviewed by Darin Adler.
2531
2532         This might not be the case for all hosts, so this patch implements an alternate "backend" 
2533         for run-jsc-stress-tests to use normal shell commands rather than Makefiles. To remain at 
2534         least somewhat competitive with the make-based test runner, the shell backend uses subshells
2535         run in the background to allow tests to run in parallel. Since the concurrency primitives 
2536         in shell scripting are rather coarse, the overhead of this parallelism is higher than that 
2537         of the make-based runner.
2538
2539         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added. This is the runner that is copied into
2540         the bundle and controls all of the parallel aspects of the shell-based test runner.
2541         * Scripts/run-jsc-stress-tests:
2542
2543 2013-12-03  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2544
2545         Remove function from TextChecker
2546         https://bugs.webkit.org/show_bug.cgi?id=125148
2547
2548         Reviewed by Darin Adler.
2549
2550         The process_file_data is used only from the unit tests, so it is simply moved there.
2551
2552         * Scripts/webkitpy/style/checkers/text.py:
2553         (TextChecker.check):
2554         * Scripts/webkitpy/style/checkers/text_unittest.py:
2555         (TextStyleTestCase.process_file_data):
2556         (TextStyleTestCase.assertNoError):
2557         (TextStyleTestCase.assertError):
2558
2559 2013-12-03  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2560
2561         Remove get_test() and reference test names directly instead.
2562         https://bugs.webkit.org/show_bug.cgi?id=124962
2563
2564         Reviewed by Csaba Osztrogonác.
2565
2566         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2567         (Base.__init__):
2568         (Base.get_basic_tests):
2569         (assert_exp):
2570         (MiscTests.test_multiple_results):
2571         (MiscTests.test_category_expectations):
2572         (MiscTests.test_get_modifiers):
2573         (MiscTests.test_get_expectations_string):
2574         (MiscTests.test_get_test_set):
2575         (MiscTests.test_parse_warning):
2576         (MiscTests.test_pixel_tests_flag.match):
2577
2578 2013-12-03  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2579
2580         Style Checker false pass.
2581         https://bugs.webkit.org/show_bug.cgi?id=112456
2582
2583         Reviewed by Csaba Osztrogonác.
2584
2585         * Scripts/webkitpy/style/checkers/changelog.py:
2586         (ChangeLogChecker.check_entry):
2587         simple regex fix to check "No new tests (...)."
2588         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2589         (ChangeLogCheckerTest.test_no_new_tests):
2590
2591 2013-12-02  Filip Pizlo  <fpizlo@apple.com>
2592
2593         run-jsc-stress-tests should allow for tests that have a directory containing .js files nested within a directory containing the data
2594         https://bugs.webkit.org/show_bug.cgi?id=125130
2595
2596         Reviewed by Geoffrey Garen.
2597
2598         * Scripts/run-jsc-stress-tests:
2599
2600 2013-12-02  Samuel White  <samuel_white@apple.com>
2601
2602         AX: Add AXUIElementCountForSearchPredicate parameterized attribute.
2603         https://bugs.webkit.org/show_bug.cgi?id=124561
2604
2605         Reviewed by Chris Fleizach.
2606
2607         Added function to verify that NSAccessibilityUIElementCountForSearchPredicateParameterizedAttribute works as it should.
2608
2609         * DumpRenderTree/AccessibilityUIElement.cpp:
2610         (uiElementCountForSearchPredicateCallback):
2611         (uiElementForSearchPredicateCallback):
2612         (AccessibilityUIElement::getJSClass):
2613         * DumpRenderTree/AccessibilityUIElement.h:
2614         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2615         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2616         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2617         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2618         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2619         (searchPredicateParameterizedAttributeForSearchCriteria):
2620         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2621         (AccessibilityUIElement::uiElementForSearchPredicate):
2622         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2623         (AccessibilityUIElement::uiElementCountForSearchPredicate):
2624         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2625         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2626         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2627         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2628         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2629         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2630         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2631         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2632         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2633         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2634
2635 2013-12-02  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2636
2637         Instead of a large 'if' block, each failure class should write it's own result in test_result_writer.py
2638         https://bugs.webkit.org/show_bug.cgi?id=124714
2639
2640         Reviewed by Ryosuke Niwa.
2641
2642         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2643         (write_test_result):
2644         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2645         (TestFailure.write_failure):
2646         (FailureText):
2647         (FailureText.write_failure):
2648         (FailureAudio):
2649         (FailureAudio.write_failure):
2650         (FailureCrash.write_failure):
2651         (FailureMissingResult):
2652         (FailureTextMismatch):
2653         (FailureMissingImageHash.write_failure):
2654         (FailureMissingImage.write_failure):
2655         (FailureImageHashMismatch.write_failure):
2656         (FailureReftestMismatch.write_failure):
2657         (FailureReftestMismatchDidNotOccur.write_failure):
2658         (FailureMissingAudio):
2659         (FailureAudioMismatch):
2660
2661 2013-12-02  László Langó  <lango@inf.u-szeged.hu>
2662
2663         Remove the stderr_write attribute from StyleProcessorConfiguration
2664         https://bugs.webkit.org/show_bug.cgi?id=124703
2665
2666         Reviewed by Ryosuke Niwa.
2667
2668         Remove the stderr_write attribute from this class in checker and
2669         replace its use with calls to a logging module logger. We Should 
2670         use logging module instead of writing to stderr directly.
2671
2672         * Scripts/webkitpy/style/checker.py: Change stderr_write attribute to logging module logger.
2673         (check_webkit_style_configuration):
2674         (CheckerDispatcher.dispatch): Remove FIXME comment.
2675         (StyleProcessorConfiguration):
2676         (StyleProcessorConfiguration.__init__):
2677         (StyleProcessorConfiguration.write_style_error):
2678         * Scripts/webkitpy/style/checker_unittest.py: Update test to the modification.
2679         There is an "ERROR" prefix in log messiges from now.
2680         (StyleProcessorConfigurationTest):
2681         (StyleProcessorConfigurationTest._style_checker_configuration):
2682         (StyleProcessorConfigurationTest.test_init):
2683         (StyleProcessorConfigurationTest.test_write_style_error_emacs):
2684         (StyleProcessorConfigurationTest.test_write_style_error_vs7):
2685         (StyleProcessor_EndToEndTest.with):
2686         (StyleProcessor_EndToEndTest.test_init):
2687         (StyleProcessor_EndToEndTest.test_process):
2688         (StyleProcessor_CodeCoverageTest.setUp):
2689         * Scripts/webkitpy/style/error_handlers.py: Remove stderr_write usage and replace with logging module logger.
2690         (DefaultStyleErrorHandler.__call__):
2691         * Scripts/webkitpy/style/error_handlers_unittest.py: Update test to the modification.
2692         There is an "ERROR" prefix in log messiges from now.
2693         (DefaultStyleErrorHandlerTest):
2694         (DefaultStyleErrorHandlerTest.setUp):
2695         (DefaultStyleErrorHandlerTest._mock_increment_error_count):
2696         (DefaultStyleErrorHandlerTest._style_checker_configuration):
2697         (DefaultStyleErrorHandlerTest._check_initialized):
2698         (DefaultStyleErrorHandlerTest.test_non_reportable_error):
2699         (DefaultStyleErrorHandlerTest.test_max_reports_per_category):
2700         (DefaultStyleErrorHandlerTest.test_line_numbers):
2701
2702 2013-12-02  Brian J. Burg  <burg@cs.washington.edu>
2703
2704         Add JavaScript style checker and teach checker.py about .js files
2705         https://bugs.webkit.org/show_bug.cgi?id=125049
2706
2707         Reviewed by Joseph Pecoraro.
2708
2709         Add a JavaScript file type, extension, and checker (JSChecker).
2710         Use TextChecker for JavaScript tests, libraries, website resources,
2711         etc. and use JSChecker for files within WebInspectorUI/UserInterface.
2712
2713         Amended tests for TextChecker to reflect the rule above.
2714
2715         * Scripts/webkitpy/style/checker.py:
2716         (_all_categories): Add categories defined by JSChecker.
2717         (FileType): Add file type for JS and re-number the enum.
2718         (CheckerDispatcher._file_type): Detect .js files as JavaScript.
2719         (CheckerDispatcher._create_checker):
2720         Create a JSChecker or TextChecker depending on the file's path.
2721
2722         * Scripts/webkitpy/style/checker_unittest.py:
2723         (CheckerDispatcherDispatchTest.assert_checker_js): Added.
2724         (CheckerDispatcherDispatchTest.test_js_paths): Added.
2725         (CheckerDispatcherDispatchTest.test_text_paths): Add new test paths
2726         that end in .js but should be checked with TextChecker.
2727         * Scripts/webkitpy/style/checkers/js.py: Added.
2728         (JSChecker):
2729         (JSChecker.__init__):
2730         (JSChecker.check):
2731         * Scripts/webkitpy/style/checkers/js_unittest.py: Added.
2732         (JSTestCase):
2733         (JSTestCase.assertNoError):
2734         (JSTestCase.assertNoError.error_for_test):
2735         (JSTestCase.assertError):
2736         (JSTestCase.assertError.error_for_test):
2737         (JSTestCase.test_no_error):
2738         (JSTestCase.test_error):
2739
2740 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2741
2742         run-jsc-stress-tests always copies the VM
2743         https://bugs.webkit.org/show_bug.cgi?id=125092
2744
2745         Reviewed by Filip Pizlo.
2746
2747         This can be slow, especially with full debug builds. It should just symlink the VM into the 
2748         bundle by default and do a full copy only when asked.
2749
2750         * Scripts/run-jsc-stress-tests:
2751
2752 2013-12-02  Brent Fulgham  <bfulgham@apple.com>
2753
2754         [Win] Port run-jsc-stress-tests
2755         https://bugs.webkit.org/show_bug.cgi?id=124801
2756
2757         Reviewed by Filip Pizlo.
2758
2759         * Scripts/run-jsc-stress-tests: Gracefully handle lack of sysctl
2760         command on Windows so that stress tests can run.
2761
2762 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2763
2764         Build fix after r159955
2765
2766         * Scripts/run-jsc-stress-tests:
2767
2768 2013-12-02  Mark Hahnenberg  <mhahnenberg@apple.com>
2769
2770         run-jsc-stress-tests should be able to package its tests and move them places
2771         https://bugs.webkit.org/show_bug.cgi?id=124549
2772
2773         Reviewed by Filip Pizlo.
2774
2775         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation
2776         of grep -i -q
2777         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
2778         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory.
2779         We now also copy whatever VM was specified, along with its associated framework, into this directory.
2780         All of the generated scripts now are completely relative within the results directory. This allows
2781         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a
2782         tarball of the generated results directory. Also refactored several portions of the script into
2783         separate functions to make it easier to run them conditionally depending on which mode we're running in. 
2784
2785 2013-12-02  Andrzej Badowski  <a.badowski@samsung.com>
2786
2787         [ATK] Support active state for listbox elements.
2788         https://bugs.webkit.org/show_bug.cgi?id=125009
2789
2790         Reviewed by Chris Fleizach.
2791
2792         Supplement WebKitTestRunner and DumpRenderTree to support isSelectedOptionActive.
2793
2794         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2795         (AccessibilityUIElement::isSelectedOptionActive):
2796         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2797         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2798         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2799         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2800         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2801         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2802         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2803         (WTR::AccessibilityUIElement::isSelectedOptionActive):
2804
2805 2013-12-02  Zan Dobersek  <zdobersek@igalia.com>
2806
2807         Unreviewed GTK gardening.
2808
2809         * Scripts/run-gtk-tests:
2810         (TestRunner): Skip two unit tests that are causing the subsequent test to crash.
2811
2812 2013-12-01  Dan Bernstein  <mitz@apple.com>
2813
2814         [Mac] Transition MiniBrowser to the Cocoa API: policy delegate   
2815         https://bugs.webkit.org/show_bug.cgi?id=125046
2816
2817         Reviewed by Sam Weinig.
2818
2819         * MiniBrowser/mac/AppDelegate.m:
2820         (-[BrowserAppDelegate newWindow:]): Added WK_API_ENABLED guards.
2821         (-[BrowserAppDelegate openDocument:]): Ditto.
2822         * MiniBrowser/mac/WK2BrowserWindowController.h: Ditto. Also moved ivar declarations from the
2823         interface to the implementation.
2824         * MiniBrowser/mac/WK2BrowserWindowController.m:
2825         (-[WK2BrowserWindowController awakeFromNib]): Changed to set the policy delegate instead of
2826         the policy client.
2827         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2828         Moved policy client implementation into this delegate method.
2829         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNewWindowAction:decisionHandler:]):
2830         Ditto.
2831         (-[WK2BrowserWindowController browsingContextController:decidePolicyForResponseAction:decisionHandler:]):
2832         Ditto.
2833
2834 2013-12-01  Dan Bernstein  <mitz@apple.com>
2835
2836         [Mac] Remove the MiniBrowser injected bundle
2837         https://bugs.webkit.org/show_bug.cgi?id=125041
2838
2839         Reviewed by Anders Carlsson.
2840
2841         It had no ops!
2842
2843         * MiniBrowser/Configurations/WebBundle.xcconfig: Removed.
2844         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2845         * MiniBrowser/mac/AppDelegate.m:
2846         (-[BrowserAppDelegate init]):
2847         * MiniBrowser/mac/WebBundle/Info.plist: Removed.
2848         * MiniBrowser/mac/WebBundle/WebBundleMain.m: Removed.
2849
2850 2013-11-29  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2851
2852         check-webkit-style should check for extraneous newline between config.h and primary header.
2853         https://bugs.webkit.org/show_bug.cgi?id=124821
2854
2855         Reviewed by Csaba Osztrogonác.
2856
2857         * Scripts/webkitpy/style/checkers/cpp.py:
2858         (check_include_line):
2859         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2860         (OrderOfIncludesTest.test_check_line_break_after_own_header):
2861         (OrderOfIncludesTest):
2862         (OrderOfIncludesTest.test_check_line_break_before_own_header):
2863
2864 2013-11-29  Jozsef Berta  <jberta@inf.u-szeged.hu>
2865
2866         test-webkit-scripts should show the failing tests and use an appropriate exit code
2867         https://bugs.webkit.org/show_bug.cgi?id=124840
2868
2869         Reviewed by Ryosuke Niwa.
2870
2871         A fixme in test-webkit-scripts asked that the script should display success or failiure
2872         and exit with a 0 or 1 value accordingly after all of the tests have completed.
2873
2874         * Scripts/test-webkit-scripts:
2875         (ScriptsTester.run_test_script):
2876         The outcome of the currently run script is returned to the main as a boolean value. A boolean is returned,
2877         because at this point we don't need to pass on more information other than success or failiure.
2878         (ScriptsTester.main):
2879         The return values are now stored for each script and when all tests have completed successfully,
2880         the script indicates success and returns 0. Otherwise it will display the name(s) of the failing script(s) and return 1.
2881
2882 2013-11-29  Krzysztof Czech  <k.czech@samsung.com>
2883
2884         [ATK] Added support for isAttributeSettable in AccessibilityUIElementAtk
2885         https://bugs.webkit.org/show_bug.cgi?id=124923
2886
2887         Reviewed by Mario Sanchez Prada.
2888
2889         Added missing implementation of isAttributeSettable. Using
2890         ATK_STATE_EDITABLE for checking whether attribute is settable.
2891
2892         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2893         (AccessibilityUIElement::isAttributeSettable):
2894         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2895         (WTR::AccessibilityUIElement::isAttributeSettable):
2896
2897 2013-11-28  Commit Queue  <commit-queue@webkit.org>
2898
2899         Unreviewed, rolling out r159839.
2900         http://trac.webkit.org/changeset/159839
2901         https://bugs.webkit.org/show_bug.cgi?id=124974
2902
2903         run-webkit-tests doesn't generate pretty diff (Requested by
2904         Ossy on #webkit).
2905
2906         * Scripts/webkitpy/common/prettypatch.py:
2907         (PrettyPatch.__init__):
2908         (PrettyPatch.pretty_diff):
2909         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2910         (TestResultWriter.create_text_diff_and_write_result):
2911         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2912         (summarize_results):
2913         * Scripts/webkitpy/port/base.py:
2914         (Port.__init__):
2915         (Port.pretty_patch_available):
2916         (Port.check_pretty_patch):
2917         (Port.variable):
2918         (Port.variable.pretty_patch_text):
2919         * Scripts/webkitpy/port/base_unittest.py:
2920         (PortTest.test_pretty_patch_os_error):
2921         (PortTest.test_pretty_patch_script_error):
2922
2923 2013-11-28  Antti Koivisto  <antti@apple.com>
2924
2925         Remove feature: CSS variables
2926         https://bugs.webkit.org/show_bug.cgi?id=114119
2927
2928         Reviewed by Andreas Kling.
2929
2930         * Scripts/webkitperl/FeatureList.pm:
2931
2932 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2933
2934         Move PrettyPatch related code to prettypatch.py
2935         https://bugs.webkit.org/show_bug.cgi?id=124937
2936
2937         Reviewed by Ryosuke Niwa.
2938
2939         This code seems to have a better place here than in Port, since PrettyPatch already knows
2940         pretty_patch_path, and this also unifies the usage of PrettyPatch
2941
2942         * Scripts/webkitpy/common/prettypatch.py:
2943         (PrettyPatch.__init__):
2944         (PrettyPatch.pretty_diff):
2945         (PrettyPatch):
2946         (PrettyPatch.pretty_patch_available):
2947         (PrettyPatch.check_pretty_patch):
2948         (PrettyPatch.pretty_patch_text):
2949         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2950         (TestResultWriter.create_text_diff_and_write_result):
2951         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2952         (summarize_results):
2953         * Scripts/webkitpy/port/base.py:
2954         (Port.__init__):
2955         (Port.wdiff_available):
2956         (Port.check_image_diff):
2957         (Port.wdiff_text):
2958         * Scripts/webkitpy/port/base_unittest.py:
2959         (PortTest.test_pretty_patch_os_error):
2960         (PortTest.test_pretty_patch_script_error):
2961
2962 2013-11-28  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
2963
2964         Checkout should own the scm object in Host
2965         https://bugs.webkit.org/show_bug.cgi?id=124943
2966
2967         Reviewed by Ryosuke Niwa.
2968
2969         * Scripts/webkitpy/common/host.py:
2970         (Host.__init__):
2971         (Host.initialize_scm):
2972         (Host.scm):
2973
2974 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
2975
2976         Do bytecode validation as part of testing
2977         https://bugs.webkit.org/show_bug.cgi?id=124913
2978
2979         Reviewed by Oliver Hunt.
2980
2981         * Scripts/run-jsc-stress-tests:
2982
2983 2013-11-27  Andres Gomez  <agomez@igalia.com>
2984
2985         [GTK] Tools/Scripts/update-webkitgtk-libs fails due to missing fontutils dependencies for building the "xserver" module
2986         https://bugs.webkit.org/show_bug.cgi?id=124940
2987
2988         Reviewed by Martin Robinson.
2989
2990         xserver-font-utils is needed for building gtk port dependencies
2991         with jhbuild.
2992
2993         * gtk/install-dependencies: Added xserver-font-utils to jhbuild
2994         dependecies.
2995
2996 2013-11-27  Andres Gomez  <agomez@igalia.com>
2997
2998         [GTK] Tools/Scripts/update-webkitgtk-libs unsorted and fails because of missing "git"
2999         https://bugs.webkit.org/show_bug.cgi?id=124938
3000
3001         Reviewed by Philippe Normand.
3002
3003         Added needed git dependency for building the gtk port with
3004         jhbuild. Also, the dependencies needed for building the gtk port
3005         are now sorted alphabetically.
3006
3007         * gtk/install-dependencies: Added git as jhbuild dependency and
3008         sorted dependencies alphabetically.
3009
3010 2013-11-27  Jozsef Berta  <jberta@inf.u-szeged.hu>
3011
3012         run_webkit_tests.py: error: no such option: --wincairo
3013         https://bugs.webkit.org/show_bug.cgi?id=124927
3014
3015         Reviewed by Ryosuke Niwa.
3016
3017         * BuildSlaveSupport/build.webkit.org-config/config.json: The run_webkit_tests.py doesn't supports
3018         the layout testing on wincairo, so it is turned off.
3019
3020 2013-11-26  Marcelo Lira  <marcelo.lira@openbossa.org>
3021
3022         Nix upstreaming - Adding build files and supporting scripts
3023         https://bugs.webkit.org/show_bug.cgi?id=118367
3024
3025         Reviewed by Ryosuke Niwa.
3026
3027         * Scripts/build-webkit:
3028         * Scripts/run-nix-tests: Added.
3029         * Scripts/run-webkit-tests:
3030         * Scripts/update-webkit-libs-jhbuild:
3031         * Scripts/update-webkitnix-libs: Added.
3032         * Scripts/webkitdirs.pm:
3033         (determineArchitecture):
3034         (argumentsForConfiguration):
3035         (jscProductDir):
3036         (builtDylibPathForName):
3037         (determineIsNix):
3038         (isNix):
3039         (isAppleWebKit):
3040         (launcherPath):
3041         (launcherName):
3042         (checkRequiredSystemConfig):
3043         (copyInspectorFrontendFiles):
3044         (jhbuildWrapperPrefixIfNeeded):
3045         (buildCMakeProjectOrExit):
3046         (cmakeBasedPortName):
3047         * Scripts/webkitpy/common/config/ports.py:
3048         (DeprecatedPort.port):
3049         (EflWK2Port.build_webkit_command):
3050         (NixPort):
3051         (NixPort.build_webkit_command):
3052         * Scripts/webkitpy/port/factory.py:
3053         (platform_options):
3054         (PortFactory):
3055         * Scripts/webkitpy/port/nix.py: Added.
3056         (NixPort):
3057         (NixPort._wk2_port_name):
3058         (NixPort.determine_full_port_name):
3059         (NixPort.__init__):
3060         (NixPort._port_flag_for_scripts):
3061         (NixPort.setup_test_run):
3062         (NixPort.setup_environ_for_server):
3063         (NixPort.default_timeout_ms):
3064         (NixPort.clean_up_test_run):
3065         (NixPort._generate_all_test_configurations):
3066         (NixPort._path_to_driver):
3067         (NixPort._path_to_image_diff):
3068         (NixPort._image_diff_command):
3069         (NixPort._search_paths):
3070         (NixPort.show_results_html_file):
3071         (NixPort._port_specific_expectations_files):
3072         (NixPort.default_baseline_search_path):
3073         * Scripts/webkitpy/port/nix_unittest.py: Added.
3074         (NixPortTest):
3075         (NixPortTest._assert_search_path):
3076         (NixPortTest._assert_expectations_files):
3077         (NixPortTest.test_baseline_search_path):
3078         (NixPortTest.test_expectations_files):
3079         (NixPortTest.test_default_timeout_ms):
3080         * jhbuild/jhbuild-wrapper:
3081         (determine_platform):
3082         * nix/common.py: Added.
3083         (script_path):
3084         (top_level_path):
3085         * nix/jhbuild.modules: Added.
3086         * nix/jhbuildrc: Added.
3087
3088 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3089
3090         Record subtest values in Dromaeo tests
3091         https://bugs.webkit.org/show_bug.cgi?id=124498
3092
3093         Reviewed by Andreas Kling.
3094
3095         Supported parsing subtest results.
3096
3097         * Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of
3098         which contains a dictionary with its name and an ordered list of subtest's metrics.
3099         (PerfTest.__init__): Initialize _metrics as a list.
3100         (PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
3101         (PerfTest._run_with_driver):
3102         (PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.
3103
3104         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3105         (TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
3106         (TestPerfTest.test_parse_output): Ditto.
3107         (TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
3108         assertions to ensure subtest results are parsed properly.
3109         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
3110         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.
3111
3112         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3113         (_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
3114         incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
3115         adding new results.
3116
3117         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
3118         (TestWithSubtestsData): Added.
3119         (TestDriver.run_test):
3120         (MainTest.test_run_test_with_subtests): Added.
3121
3122 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3123
3124         Enable HTML template element on Windows ports
3125         https://bugs.webkit.org/show_bug.cgi?id=124758
3126
3127         Reviewed by Andreas Kling.
3128
3129         * Scripts/webkitperl/FeatureList.pm:
3130
3131 2013-11-26  Ryosuke Niwa  <rniwa@webkit.org>
3132
3133         Remove replay performance tests as it's not actively maintained
3134         https://bugs.webkit.org/show_bug.cgi?id=124764
3135
3136         Reviewed by Andreas Kling.
3137
3138         Removed the feature.
3139
3140         * Scripts/webkitpy/performance_tests/perftest.py:
3141         (SingleProcessPerfTest.__init__):
3142         (PerfTestFactory):
3143         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3144         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3145         (PerfTestsRunner._parse_args):
3146         (PerfTestsRunner._collect_tests):
3147         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3148         (MainTest.test_collect_tests_with_ignored_skipped_list):
3149         (MainTest.test_default_args):
3150         * Scripts/webkitpy/thirdparty/__init__.py:
3151         (AutoinstallImportHook.find_module):
3152         (AutoinstallImportHook._install_unittest2):
3153         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3154         (ThirdpartyTest.test_imports):
3155
3156 2013-11-26  Filip Pizlo  <fpizlo@apple.com>
3157
3158         Enable aggressive DFG validation in testing
3159         https://bugs.webkit.org/show_bug.cgi?id=124911
3160
3161         Rubber stamped by Ryosuke Niwa.
3162         
3163         This enables validation testing in non-concurrent-JIT runs.
3164
3165         * Scripts/run-jsc-stress-tests:
3166
3167 2013-11-26  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3168
3169         Moved methods which belong to Checkout into checkout.py
3170         https://bugs.webkit.org/show_bug.cgi?id=124889
3171
3172         Reviewed by Ryosuke Niwa.
3173
3174         * Scripts/webkitpy/common/checkout/checkout.py:
3175         (Checkout.scripts_directory):
3176         (Checkout):
3177         (Checkout.script_path):
3178         (Checkout.commit_message_for_this_commit):
3179         (Checkout.apply_patch):
3180         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3181         (test_commit_message_for_this_commit):
3182         (CheckoutTest.test_apply_patch):
3183         * Scripts/webkitpy/common/checkout/scm/scm.py:
3184         (SCM.absolute_path):
3185         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3186         (SCMTest._setup_webkittools_scripts_symlink):
3187         * Scripts/webkitpy/common/checkout/scm/svn.py:
3188         (SVN.create_patch):
3189
3190 2013-11-25  Ryuan Choi  <ryuan.choi@samsung.com>
3191
3192         [EFL] Use Config mode of find_package for EFL 1.8
3193         https://bugs.webkit.org/show_bug.cgi?id=124555
3194
3195         Reviewed by Gyuyoung Kim.
3196
3197         * MiniBrowser/efl/CMakeLists.txt:
3198         Added optional config mode and made version requirement optional.
3199
3200 2013-11-25  Andres Gomez  <agomez@igalia.com>
3201
3202         [GTK] Search functionality in MiniBrowser provides feedback on search fail
3203         https://bugs.webkit.org/show_bug.cgi?id=122681
3204
3205         Reviewed by Mario Sanchez Prada.
3206
3207         When using the search functionality in MiniBrowser, if the search
3208         fails, the entry background color gets red to report the user
3209         about the failing condition. When the entry is cleaned or the
3210         search is again succesful the background turns back to its
3211         original color.
3212
3213         * MiniBrowser/gtk/BrowserSearchBar.c:
3214         (setFailedStyleForEntry): Added.
3215         (doSearch): Sets the entry's background to its original style if
3216         there is no text to search.
3217         (findControllerFailedToFindTextCallback): Added.
3218         (findControllerFoundTextCallback): Added.
3219         (browser_search_bar_init): Creates and adds a new CSS provider to
3220         the text entry so we can change its style based on the success
3221         condition of the search.
3222         (browserSearchBarFinalize): Frees the new CSS provider.
3223         (browser_search_bar_new): Connects the two new handlers to the
3224         "failed-to-find-text" and "found-text" signals emitted by the
3225         WebKitFindController.
3226
3227 2013-11-25  Dan Bernstein  <mitz@apple.com>
3228
3229         [Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
3230         https://bugs.webkit.org/show_bug.cgi?id=124850
3231
3232         Reviewed by Brady Eidson.
3233
3234         Added #if WK_API_ENABLED guards around tests that use the Objective-C API.
3235
3236         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3237         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3238         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
3239         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
3240         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
3241         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
3242         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
3243
3244 2013-11-25  Commit Queue  <commit-queue@webkit.org>
3245
3246         Unreviewed, rolling out r159752 and r159754.
3247         http://trac.webkit.org/changeset/159752
3248         http://trac.webkit.org/changeset/159754
3249         https://bugs.webkit.org/show_bug.cgi?id=124847
3250
3251         Broke linux test bots. (Requested by mhahnenberg on #webkit).
3252
3253         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
3254         * Scripts/run-javascriptcore-tests:
3255         * Scripts/run-jsc-stress-tests:
3256
3257 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3258
3259         Followup fix after r159752
3260
3261         * Scripts/run-jsc-stress-tests: We need to handle Release builds too.
3262
3263 2013-11-25  Mark Hahnenberg  <mhahnenberg@apple.com>
3264
3265         run-jsc-stress-tests should be able to package its tests and move them places
3266         https://bugs.webkit.org/show_bug.cgi?id=124549
3267
3268         Reviewed by Filip Pizlo.
3269
3270         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Removed. Was just a ruby reimplementation 
3271         of grep -i -q
3272         * Scripts/run-javascriptcore-tests: Pass through the --tarball flag.
3273         * Scripts/run-jsc-stress-tests: Changed to create a bundle of tests inside the results directory. 
3274         We now also copy whatever VM was specified, along with its associated framework, into this directory. 
3275         All of the generated scripts now are completely relative within the results directory. This allows 
3276         run-jsc-stress-tests to execute a bundle from anywhere. Also added a --tarball flag which creates a 
3277         tarball of the generated results directory. Also refactored several portions of the script into 
3278         separate functions to make it easier to run them conditionally depending on which mode we're running in.
3279
3280 2013-11-25  László Langó  <lango@inf.u-szeged.hu>
3281
3282         EWS creates 0 byte sized log files
3283         https://bugs.webkit.org/show_bug.cgi?id=107606
3284
3285         Reviewed by Ryosuke Niwa.
3286
3287         There was a modification in r138264, that tried to make less log,
3288         because some of the messeges were duplicated. After this the EWS
3289         created the log file (with the same name as the bugID) but doesn't
3290         write anything into it, even if there were errors during the build.
3291         From now only creates the log file only if there is some error.
3292
3293         * Scripts/webkitpy/tool/bot/queueengine.py:
3294         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3295         there is nothing to log. Open the log file only if a ScriptError was raised to
3296         avoid to make empty log files for bugs.
3297         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3298         because of changes in r138264. Teeing is used for locally testing purposes and
3299         this feature is not used anymore.
3300         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output
3301         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3302         change.
3303         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3304         (LoggingDelegate): The order of the callbacks was changed by this patch.
3305         (QueueEngineTest.test_trivial): Won't create log file if the queue was terminated,
3306         so we have to update this test.
3307         (QueueEngineTest.test_unexpected_error): The order of the callbacks was changed by
3308         this patch.
3309         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3310         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3311         to be able to handle it in QueueEngine.run. Without this change, the existing
3312         exception handler never run (the process_work_item method never raise ScriptError)
3313         We can get the error message only from the ScriptError at this point.
3314
3315 2013-11-22  Dean Jackson  <dino@apple.com>
3316
3317         Speculative Mountain Lion build fix.
3318
3319         * MiniBrowser/mac/AppDelegate.m:
3320         (-[BrowserAppDelegate openDocument:]):
3321
3322 2013-11-22  Anders Carlsson  <andersca@apple.com>
3323
3324         Fix Mountain Lion bug.
3325
3326         * MiniBrowser/mac/AppDelegate.m:
3327         (-[BrowserAppDelegate openDocument:]):
3328
3329 2013-11-22  Anders Carlsson  <andersca@apple.com>
3330
3331         MiniBrowser should use the blocks-based NSOpenPanel API
3332         https://bugs.webkit.org/show_bug.cgi?id=124786
3333
3334         Reviewed by Simon Fraser.
3335
3336         * MiniBrowser/mac/AppDelegate.m:
3337         (-[BrowserAppDelegate frontmostBrowserWindowController]):
3338         Account for windows that don't have a BrowserWindowController.
3339
3340         (-[BrowserAppDelegate openDocument:]):
3341
3342 2013-11-22  Commit Queue  <commit-queue@webkit.org>
3343
3344         Unreviewed, rolling out r159690.
3345         http://trac.webkit.org/changeset/159690
3346         https://bugs.webkit.org/show_bug.cgi?id=124782
3347
3348         Broke webkitpy tests (Requested by ap on #webkit).
3349
3350         * Scripts/webkitpy/tool/bot/queueengine.py:
3351         (QueueEngine.run):
3352         (QueueEngine._open_work_log):
3353         (QueueEngine._ensure_work_log_closed):
3354         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3355         (AbstractEarlyWarningSystem.review_patch):
3356
3357 2013-11-22  László Langó  <lango@inf.u-szeged.hu>
3358
3359         EWS creates 0 byte sized log files
3360         https://bugs.webkit.org/show_bug.cgi?id=107606
3361
3362         Reviewed by Ryosuke Niwa.
3363
3364         There was a modification in r138264, that tried to make less log, 
3365         because some of the messeges were duplicated. After this the EWS 
3366         created the log file (with the same name as the bugID) but doesn't 
3367         write anything into it, even if there were errors during the build. 
3368         From now only creates the log file only if there is some error.
3369
3370         * Scripts/webkitpy/tool/bot/queueengine.py:
3371         (QueueEngine.run): If the build and tests pass, there is no ScriptError raised,
3372         there is nothing to log. Open the log file only if a ScriptError was raised to
3373         avoid to make empty log files for bugs.
3374         (QueueEngine._open_work_log): Does not need to tee STDOUT to log file anymore,
3375         because of changes in r138264. Teeing is used for locally testing purposes and
3376         this feature is not used anymore.
3377         (QueueEngine._ensure_work_log_closed): Close the logfile. We don't use output 
3378         teeing anymore. It is a necessary change because of QueueEngine._open_work_log
3379         change.
3380         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3381         (AbstractEarlyWarningSystem.review_patch): Raise again the captured ScriptError
3382         to be able to handle it in QueueEngine.run. Without this change, the existing
3383         exception handler never run (the process_work_item method never raise ScriptError)
3384         We can get the error message only from the ScriptError at this point.
3385
3386 2013-11-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
3387
3388         Remove ENABLE_WORKERS
3389         https://bugs.webkit.org/show_bug.cgi?id=105784
3390
3391         Reviewed by Darin Adler.
3392
3393         * Scripts/webkitperl/FeatureList.pm:
3394
3395 2013-11-21  Darin Adler  <darin@apple.com>
3396
3397         Try to fix buildbot Dashboard for people who have not hidden anything.
3398
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3400         Add a null check for hidden platforms.
3401
3402 2013-11-21  Peter Szanka  <h868064@stud.u-szeged.hu>
3403
3404         Remove chrome/chromium related things from webkitpy.
3405         https://bugs.webkit.org/show_bug.cgi?id=124493
3406
3407         Reviewed by Darin Adler.
3408
3409         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3410         (PortTest.assert_mock_port_works):
3411         * Scripts/webkitpy/port/base.py:
3412         (Port.to.setup_environ_for_server):
3413         * Scripts/webkitpy/port/mac_unittest.py:
3414         (test_tests_for_other_platforms):
3415         * Scripts/webkitpy/port/mock_drt.py:
3416         (MockTestShell.output_for_test):
3417         * Scripts/webkitpy/tool/bot/irc_command.py:
3418         (Restart.execute):
3419         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3420         (IRCBotTest.test_help):
3421
3422 2013-11-21  Dániel Bátyai  <Batyai.Daniel@stud.u-szeged.hu>
3423
3424         In filereader.py, process_file() should throw instead of exiting directly when the file doesn't exist
3425         https://bugs.webkit.org/show_bug.cgi?id=124717
3426
3427         Reviewed by Ryosuke Niwa.
3428
3429         * Scripts/webkitpy/style/filereader.py:
3430         (TextFileReader.process_file):
3431         * Scripts/webkitpy/style/filereader_unittest.py:
3432         (TextFileReaderTest.test_process_file__does_not_exist):
3433
3434 2013-11-21  Mark Rowe  <mrowe@apple.com>
3435
3436         <https://webkit.org/b/124702> Stop overriding VALID_ARCHS.
3437
3438         All modern versions of Xcode set it appropriately for our needs.
3439
3440         Reviewed by Alexey Proskuryakov.
3441
3442         * MiniBrowser/Configurations/Base.xcconfig:
3443         * WebKitTestRunner/Configurations/Base.xcconfig:
3444
3445 2013-11-21  Nick Diego Yamane  <nick.yamane@openbossa.org>
3446
3447         webkitdirs::checkForArgumentAndRemoveFromArrayRef() removed wrong element
3448         https://bugs.webkit.org/show_bug.cgi?id=124676
3449
3450         Reviewed by Daniel Bates.
3451
3452         checkForArgumentAndRemoveFromArrayRef functions was removing wrong
3453         elements when there were more then one occurrence of that argument.
3454         E.g: Checking for 'a' in {a, b, a, c}, the resulting array would be
3455         {b, a}, when it should be {b, c}.
3456
3457         * Scripts/webkitdirs.pm:
3458         (checkForArgumentAndRemoveFromArrayRef): bugfix mentioned above.
3459         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
3460         Added; Unit tests for webkitdirs::checkForArgumentAndRemoveFromArrayRef function.
3461
3462 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3463
3464         Update build-webkit after r159550.
3465
3466         * Scripts/webkitperl/FeatureList.pm:
3467
3468 2013-11-21  Lucas Forschler  <lforschler@apple.com>
3469
3470         Bring a new bot online, replacing the previous ones.
3471         
3472         Unreviewed.
3473
3474         * BuildSlaveSupport/build.webkit.org-config/config.json:
3475
3476 2013-11-21  Dean Jackson  <dino@apple.com>
3477
3478         Don't fetch hidden platforms on build.webkit.org/dashboard
3479         https://bugs.webkit.org/show_bug.cgi?id=124750
3480
3481         Reviewed by Tim Horton.
3482
3483         If a platform is hidden, don't fetch its data. If it
3484         becomes unhidden, try to fetch immediately (unless
3485         you've recently fetched).
3486
3487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3489
3490 2013-11-21  Commit Queue  <commit-queue@webkit.org>
3491
3492         Unreviewed, rolling out r159633.
3493         http://trac.webkit.org/changeset/159633
3494         https://bugs.webkit.org/show_bug.cgi?id=124726
3495
3496         it broke 10 webkitpy tests (Requested by dino_ on #webkit).
3497
3498         * Scripts/webkitpy/style/checker.py:
3499         (check_webkit_style_configuration):
3500         (CheckerDispatcher.dispatch):
3501         (StyleProcessorConfiguration):
3502         (StyleProcessorConfiguration.__init__):
3503         (StyleProcessorConfiguration.write_style_error):
3504
3505 2013-11-21  László Langó  <lango@inf.u-szeged.hu>
3506
3507         Remove the stderr_write attribute from StyleProcessorConfiguration.
3508         https://bugs.webkit.org/show_bug.cgi?id=124703
3509
3510         Reviewed by Brent Fulgham.
3511
3512         * Scripts/webkitpy/style/checker.py:
3513         (check_webkit_style_configuration):
3514         (CheckerDispatcher.dispatch):
3515         (StyleProcessorConfiguration):
3516         (StyleProcessorConfiguration.__init__):
3517         (StyleProcessorConfiguration.write_style_error):
3518
3519 2013-11-21  Ryosuke Niwa  <rniwa@webkit.org>
3520
3521         PerfTestRunner._generate_results_dict shouldn't depend on test objects
3522         https://bugs.webkit.org/show_bug.cgi?id=124623
3523
3524         Removed the dependency on test objects from results JSON generation.
3525         This allows single test.run to return metrics for multiple tests
3526
3527         Reviewed by Antti Koivisto.
3528
3529         * Scripts/webkitpy/performance_tests/perftest.py:
3530         (PerfTestMetric.__init__): Takes the test path and test name.
3531         (PerfTestMetric.path): Added.
3532         (PerfTestMetric.test_file_name): Added.
3533         (PerfTest.run): Accumulate PerfTestMetric objects instead of raw values.
3534         (PerfTest._ensure_metrics): Instantiate PerfTestMetric with the test path and test name.
3535         The path is going to have the names of subtests at the end once we support them.
3536
3537         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3538         (TestPerfTestMetric.test_init_set_missing_unit): Specify the test path and test name.
3539         (TestPerfTestMetric.test_init_set_time_metric): Ditto.
3540         (TestPerfTestMetric.test_has_values): Ditto.
3541         (TestPerfTestMetric.test_append): Ditto.
3542
3543         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3544         (_generate_results_dict): Only use metrics.
3545         (_run_tests_set): Accumulate metrics as supposed to (test, metrics) pairs.
3546
3547 2013-11-21  Manuel Rego Casasnovas  <rego@igalia.com>
3548
3549         REGRESSION(r159599): webkitdirs.pm spits out warnings at lines 851 and 852
3550         https://bugs.webkit.org/show_bug.cgi?id=124697
3551
3552         Reviewed by Ryosuke Niwa.
3553
3554         * Scripts/webkitdirs.pm:
3555         (checkForArgumentAndRemoveFromARGVGettingValue): Fix check of array size
3556         before trying to access to the first element.
3557
3558 2013-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         [GTK] Mark all deprecated symbols in GObject DOM bindings
3561         https://bugs.webkit.org/show_bug.cgi?id=124406
3562
3563         Reviewed by Gustavo Noronha Silva.
3564
3565         * Scripts/webkitpy/style/checker.py: Add special case for
3566         WebKitDOMDeprecated.
3567         * gtk/generate-gtkdoc:
3568         (get_webkit2_options): Use the prefix of the methods as namespace,
3569         since this is what gtkdoc expects to sort the index.
3570         (get_webkit1_options): Ditto.
3571         (get_webkitdom_options): Ditto.
3572         * gtk/generate-webkitdom-doc-files:
3573         (WebKitDOMDocGenerator): Add a global list of deleted objects.
3574         (WebKitDOMDocGenerator.write_deleted_classes): New method to write
3575         the documentation for classes that are deprecated because they
3576         have been removed.
3577         (WebKitDOMDocGeneratorDocs.write_deleted_classes): Add sections
3578         for deleted classes too.
3579         (WebKitDOMDocGeneratorSections.__init__): Build a list of
3580         deprecated symbols using the given symbols file.
3581         (WebKitDOMDocGeneratorSections._deleted_class): Returns the
3582         deleted class corresponding to the given function.
3583         (WebKitDOMDocGeneratorSections._deprecated_symbols): Builds a
3584         dictionary of deprecated symbols for every class.
3585         (WebKitDOMDocGeneratorSections.write_section): Add also the
3586         deprecated symbols in every section.
3587         (WebKitDOMDocGeneratorSections.write_deleted_classes): Add
3588         sections for deleted classes too.
3589
3590 2013-11-20  László Langó  <lango@inf.u-szeged.hu>
3591
3592         check-webkit-style should support C++11 rvalue references.
3593         https://bugs.webkit.org/show_bug.cgi?id=123406
3594
3595         Reviewed by Brent Fulgham.
3596
3597         * Scripts/webkitpy/style/checkers/cpp.py:
3598         (check_style):
3599         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3600         (Cpp11StyleTest):
3601         (Cpp11StyleTest.test_rvaule_reference_at_end_of_line):
3602
3603 2013-11-20  Dean Jackson  <dino@apple.com>
3604
3605         Allow settings to be shown/hidden on build.webkit.org/dashboard
3606         https://bugs.webkit.org/show_bug.cgi?id=124694
3607
3608         Reviewed by Tim Horton.
3609
3610         In preparation for more options/buttons, allow the page to
3611         show or hide all the interactive things using a little gear icon
3612         in the top left corner.
3613
3614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
3615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
3616         (Settings.prototype.toggleSettingsDisplay):
3617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3618         (div.cellButton.hide):
3619         (div.cellButton.unhide):
3620         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide):
3621         (.settings):
3622         (.settings:hover):
3623         (.settings-visible .settings):
3624
3625 2013-11-20  Dean Jackson  <dino@apple.com>
3626
3627         No need to base64 SVG on build.webkit.org/dashboard
3628         https://bugs.webkit.org/show_bug.cgi?id=124687
3629
3630         Reviewed by Tim Horton.
3631
3632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3633         (.status-line.good .bubble.pictogram):
3634
3635 2013-11-20  Dean Jackson  <dino@apple.com>
3636
3637         Make links look more like links on build.webkit.org/dashboard
3638         https://bugs.webkit.org/show_bug.cgi?id=124686
3639
3640         Reviewed by Tim Horton.
3641
3642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css:
3643         (.queue-view .queueLabel:hover):
3644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3645         (.status-line.linked .label:hover):
3646
3647 2013-11-20  Nick Diego Yamane  <nick.yamane@openbossa.org>
3648
3649         Modify webkitdirs to reuse checkForArgumentAndRemoveFromARGV
3650         https://bugs.webkit.org/show_bug.cgi?id=124581
3651
3652         Reviewed by Daniel Bates.
3653
3654         Some subroutines are replicating code from checkForArgument**
3655         functions instead of reusing them as is being done by all other functions.
3656
3657         * Scripts/webkitdirs.pm:
3658         (determineXcodeSDK): Added.
3659         (determinePassedConfiguration): Added.
3660         (determinePassedArchitecture): Added.
3661         (checkForArgumentAndRemoveFromARGV): Added.
3662         (checkForArgumentAndRemoveFromARGVGettingValue): Added.
3663
3664 2013-11-20