04a25f01f50180aef713abe5247952f65692539e
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
2
3         [GTK] atk/textChangedNotifications API test fails
4         https://bugs.webkit.org/show_bug.cgi?id=84010
5
6         Unreviewed, unskipping test after bug being fixed by r114311.
7
8         * Scripts/run-gtk-tests:
9         (TestRunner): Unskip now passing test.
10
11 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
12
13         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
14         https://bugs.webkit.org/show_bug.cgi?id=84199
15
16         Reviewed by George Staikos.
17
18         Revert a part of the change master_32/SHA:fa0f8ee9 and use
19         WebPage::setUserScalable instead.
20
21         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
22         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
23
24 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
25
26         build-webkit: make ninja work with chromium linux
27         https://bugs.webkit.org/show_bug.cgi?id=84213
28
29         Reviewed by Eric Seidel.
30
31         Fix typos so that build-webkit will use ninja to
32         build chromium if a build.ninja file exists and is up-to-date.
33
34         * Scripts/webkitdirs.pm:
35         (determineIsChromiumNinja):
36
37 2012-04-17  Ojan Vafai  <ojan@chromium.org>
38
39         Add caching to the flakiness dashboard json files
40         https://bugs.webkit.org/show_bug.cgi?id=84198
41
42         Reviewed by Dirk Pranke.
43
44         * TestResultServer/handlers/testfilehandler.py:
45         (GetFile._get_file_list):
46         (GetFile._get_file_content):
47         (GetFile._get_file_content_from_key):
48         (GetFile._get_test_list_json):
49         (GetFile._serve_json):
50         Add a Last-Modified header and handle If-Modified-Since headers.
51         (GetFile.get):
52
53 2012-04-17  Anders Carlsson  <andersca@apple.com>
54
55         Need a client callback for when the user tries to interact with an already unresponsive page
56         https://bugs.webkit.org/show_bug.cgi?id=84201
57         <rdar://problem/11140862>
58
59         Reviewed by Andreas Kling.
60
61         Add new client functions.
62
63         * MiniBrowser/mac/BrowserWindowController.m:
64         (-[BrowserWindowController awakeFromNib]):
65         * WebKitTestRunner/TestController.cpp:
66         (WTR::TestController::initialize):
67
68 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
69
70         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
71         https://bugs.webkit.org/show_bug.cgi?id=84190
72
73         Reviewed by Ojan Vafai.
74
75         LayoutTestHelper would exit when the user typed ctrl-c, but we
76         would attempt to write to it to shut it down, generating an
77         IOError.
78
79         * Scripts/webkitpy/layout_tests/port/chromium.py:
80         (ChromiumPort.stop_helper):
81
82 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
83
84         rename --experimental-fully-parallel
85         https://bugs.webkit.org/show_bug.cgi?id=84188
86
87         Reviewed by Ojan Vafai.
88
89         I thought this was done long ago; rename
90         --experimental-fully-parallel to just --fully-parallel and
91         remove the --no- switch that AFAIK no one uses.
92
93         * Scripts/webkitpy/layout_tests/controllers/manager.py:
94         (Manager._run_tests):
95         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
96         (parse_args):
97
98 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
99
100         EFL's LayoutTestController does not implement callShouldCloseOnWebView
101         https://bugs.webkit.org/show_bug.cgi?id=82301
102
103         Reviewed by Martin Robinson.
104
105         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
106         calling shouldClose() on the FrameLoader, allowing the related test
107         to be removed from the skip list.
108
109         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
110         (LayoutTestController::callShouldCloseOnWebView):
111
112 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
113
114         [EFL] Add setting API to enable/disable XSSAuditor
115         https://bugs.webkit.org/show_bug.cgi?id=83281
116
117         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
118         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal 
119         'xss,detected' in DRT to enable a test, which is expecting a line containing
120         'didDetectXSS' in the output when reflected XSS is encountered in the page.
121
122         Reviewed by Antonio Gomes.
123
124         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
125         (DumpRenderTreeChrome::createView):
126         (DumpRenderTreeChrome::onFrameCreated):
127         (DumpRenderTreeChrome::onDidDetectXSS):
128         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
129         (DumpRenderTreeChrome):
130         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
131         (LayoutTestController::setXSSAuditorEnabled):
132
133 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
134
135         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
136         https://bugs.webkit.org/show_bug.cgi?id=77533
137
138         Reviewed by Simon Hausmann.
139
140         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
141         the corresponding parameter to the buildQMakeProjects function.
142
143         * Scripts/build-jsc:
144
145 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
146
147         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
148         https://bugs.webkit.org/show_bug.cgi?id=83030
149
150         Reviewed by Antonio Gomes.
151
152         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
153         in EFL's DumpRenderTree. Make use of the new frame argument passed to
154         the "load,started" and "load,finished" signals.
155
156         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
157         (DumpRenderTreeChrome::createView):
158         (DumpRenderTreeChrome::onLoadStarted):
159         (DumpRenderTreeChrome::processWork):
160         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
161         (DumpRenderTreeChrome::onWebViewOnloadEvent):
162         (DumpRenderTreeChrome::onInsecureContentRun):
163         (DumpRenderTreeChrome::onInsecureContentDisplayed):
164         (DumpRenderTreeChrome::onFrameCreated):
165         (DumpRenderTreeChrome::onFrameProvisionalLoad):
166         (DumpRenderTreeChrome::onFrameLoadCommitted):
167         (DumpRenderTreeChrome::onFrameLoadFinished):
168         (DumpRenderTreeChrome::onFrameLoadError):
169         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
170         (DumpRenderTreeChrome):
171
172 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
173
174         Unreviewed, rolling out r114376.
175         http://trac.webkit.org/changeset/114376
176         https://bugs.webkit.org/show_bug.cgi?id=84155
177
178         Wrong patch version committed, asked by the patch author.
179         (Requested by rakuco on #webkit).
180
181         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
182         (DumpRenderTreeChrome::createView):
183         (DumpRenderTreeChrome::processWork):
184         (DumpRenderTreeChrome::onLoadFinished):
185         (DumpRenderTreeChrome::onWillSendRequest):
186         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
187         (DumpRenderTreeChrome):
188
189 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
190
191         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
192         https://bugs.webkit.org/show_bug.cgi?id=83030
193
194         Reviewed by Antonio Gomes.
195
196         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
197         in EFL's DumpRenderTree.
198
199         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
200         (DumpRenderTreeChrome::createView):
201         (DumpRenderTreeChrome::processWork):
202         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
203         (DumpRenderTreeChrome::onWebViewOnloadEvent):
204         (DumpRenderTreeChrome::onInsecureContentRun):
205         (DumpRenderTreeChrome::onInsecureContentDisplayed):
206         (DumpRenderTreeChrome::onFrameCreated):
207         (DumpRenderTreeChrome::onFrameProvisionalLoad):
208         (DumpRenderTreeChrome::onFrameLoadCommitted):
209         (DumpRenderTreeChrome::onFrameLoadFinished):
210         (DumpRenderTreeChrome::onFrameLoadError):
211         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
212         (DumpRenderTreeChrome):
213
214 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
215
216         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
217         https://bugs.webkit.org/show_bug.cgi?id=83035
218
219         Reviewed by Simon Hausmann.
220
221         The force_static_libs_as_shared feature for the Qt port will remove
222         hide_symbols from Qt's CONFIG in order to make them visible to other
223         libraries again.
224
225         Due to an evaluation order problem in qmake, the flags for the C++ compiler
226         that are set by adding hide_symbols to the CONFIG variables get applied
227         to qmake's C++ compiler flags directly and hence trying to remove these
228         later will not work and cause build failures when using the force_static_libs_as_shared
229         feature of the Qt port.
230
231         This is fixed by removing the flags that hide the exports from the compiler flags directly.
232
233         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
234
235 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
236
237         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
238         https://bugs.webkit.org/show_bug.cgi?id=84068
239
240         Reviewed by Eric Seidel.
241
242         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
243         automatically creates the build directory if needed.
244
245         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
246         (DownloadAndPerfTestFactory.__init__):
247         (DownloadAndPerfTestWebKit2Factory.__init__):
248
249 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
250
251         [GTK] Use configure instead of autogen.sh for gtk+
252         https://bugs.webkit.org/show_bug.cgi?id=84112
253
254         Rubber-stamped by Martin Robinson.
255
256         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
257         we don't want to depend on that for now, so run configure instead - we
258         can, since we are using a tarball
259
260 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
261
262         Unreviewed, rolling out r114322.
263         http://trac.webkit.org/changeset/114322
264         https://bugs.webkit.org/show_bug.cgi?id=84096
265
266         Didn't make the debug bot happy, so back out
267
268         * gtk/jhbuild.modules:
269
270 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
271
272         [GTK] Try to fix debug bot by adding gobject-introspection to the build
273         https://bugs.webkit.org/show_bug.cgi?id=84096
274
275         Unreviewed speculative build fix.
276
277         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
278         an up-to-date introspection m4 for running autogen.
279
280 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
281
282         [GTK] Add pango to jhbuild
283         https://bugs.webkit.org/show_bug.cgi?id=84086
284
285         Unreviewed build fix.
286
287         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
288         jhbuild environment. It's required for latest stable GTK+ and some
289         systems may lack it.
290
291 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
292
293         [GTK] fonts jhbuild module needs an empty clean target
294         https://bugs.webkit.org/show_bug.cgi?id=84085
295
296         Rubber-stamped by Martin Robinson.
297
298         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
299         includes a phony clean target that should make warnings and errors go
300         away.
301
302 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
303
304         [GTK] Bump dependency on GTK+ 3.x to match reality
305         https://bugs.webkit.org/show_bug.cgi?id=84060
306
307         Rubber-stamped by Martin Robinson.
308
309         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
310         to their GNOME 3.4 versions.
311         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
312         is applied upstream.
313
314 2012-04-16  Vincent Scheib  <scheib@chromium.org>
315
316         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
317
318         Unreviewed.
319
320         * Scripts/webkitpy/common/config/committers.py:
321
322 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
323
324         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
325         https://bugs.webkit.org/show_bug.cgi?id=84031
326
327         Reviewed by Rob Buis.
328
329         Implemented interface function didReceiveAuthenticationChallenge in class
330         DumpRenderTree.
331
332         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
333         (drtCredentialDescription):
334         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
335         (WebKit):
336         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
337         (WebCore):
338         (DumpRenderTree):
339
340 2012-04-16  Philippe Normand  <pnormand@igalia.com>
341
342         build-webkit --gtk --no-webkit2 builds WK2
343         https://bugs.webkit.org/show_bug.cgi?id=83977
344
345         Reviewed by Martin Robinson.
346
347         * Scripts/build-webkit: Fixup ./configure option to disable
348         WebKit2 build.
349
350 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
351
352         [EFL] [DRT] Feeding key events with invalid keyName
353         https://bugs.webkit.org/show_bug.cgi?id=83797
354
355         Keep the keyName valid within scope of KeyEventInfo to avoid
356         feeding key events with invalid keyName.
357
358         Reviewed by Philippe Normand.
359
360         * DumpRenderTree/efl/EventSender.cpp:
361         (KeyEventInfo::KeyEventInfo):
362         (KeyEventInfo):
363         (keyPadNameFromJSValue):
364         (keyNameFromJSValue):
365         (createKeyEventInfo):
366         (sendKeyDown):
367
368 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
369
370         [Qt] Replace QtXmlPatterns usage with libxslt dependency
371         <https://bugs.webkit.org/show_bug.cgi?id=76820>
372
373         Reviewed by Simon Hausmann.
374
375         The features.prf file was modified, in order to use libxml and libxslt by default.
376         This modification only work at Qt5.
377
378         * qmake/config.tests/libxml2/libxml2.cpp: Added.
379         (main):
380         * qmake/config.tests/libxml2/libxml2.pro: Added.
381         * qmake/config.tests/libxslt/libxslt.cpp: Added.
382         (main):
383         * qmake/config.tests/libxslt/libxslt.pro: Added.
384         * qmake/mkspecs/features/features.prf:
385         * qmake/sync.profile:
386
387 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
388
389         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
390         https://bugs.webkit.org/show_bug.cgi?id=83862
391
392         Reviewed by Kenneth Rohde Christiansen.
393
394         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
395         It doesn't work properly because of wrong parameter order in function call.
396
397         * EWebLauncher/main.c:
398
399 2012-04-16  Philippe Normand  <pnormand@igalia.com>
400
401         Unreviewed, GTK gardening.
402
403         * Scripts/run-gtk-tests:
404         (TestRunner): Skip /webkit/atk/textChangedNotifications.
405
406 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
407
408         Chromium perf bots should not build
409         https://bugs.webkit.org/show_bug.cgi?id=83641
410
411         Reviewed by Eric Seidel.
412
413         Don't build on perf bots to improve the cycle time.
414
415         * BuildSlaveSupport/build.webkit.org-config/config.json:
416
417 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
418
419         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
420         https://bugs.webkit.org/show_bug.cgi?id=81945
421
422         Reviewed by Dan Bernstein.
423
424         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
425         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
426         PageCache to be functional.
427
428         * WebKitTestRunner/TestController.cpp:
429         (WTR::TestController::resetStateToConsistentValues):
430
431 2012-04-11  James Robinson  <jamesr@chromium.org>
432
433         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
434         https://bugs.webkit.org/show_bug.cgi?id=83733
435
436         Reviewed by Adrienne Walker.
437
438         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
439
440         * DumpRenderTree/chromium/DumpRenderTree.cpp:
441         (main):
442         * DumpRenderTree/chromium/TestShell.cpp:
443         (TestShell::TestShell):
444         (TestShell::resetWebSettings):
445         * DumpRenderTree/chromium/TestShell.h:
446         (TestShell):
447         * DumpRenderTree/chromium/WebPreferences.cpp:
448         (WebPreferences::reset):
449         (WebPreferences::applyTo):
450         * DumpRenderTree/chromium/WebPreferences.h:
451         (WebPreferences):
452
453 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
454
455         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
456         and also rebaseline the test results since we ignore the first run now.
457
458         * Scripts/webkitpy/performance_tests/perftest.py:
459         (PageLoadingPerfTest.run):
460         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
461         (TestPageLoadingPerfTest.test_run):
462
463 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
464
465         Enable SVG page loading performance tests
466         https://bugs.webkit.org/show_bug.cgi?id=83861
467
468         Reviewed by Adam Barth.
469
470         Add support for page loading tests. These are tests without any test running harnesses, and we use
471         DriverOutput's test_timeout to measure the loading time.
472
473         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
474
475         * Scripts/webkitpy/performance_tests/perftest.py:
476         (PerfTest.run):
477         (PerfTest):
478         (PerfTest.run_failed):
479         (PerfTest.parse_output):
480         (PerfTest.output_statistics):
481         (ChromiumStylePerfTest.parse_output):
482         (PageLoadingPerfTest): Added.
483         (PageLoadingPerfTest.__init__):
484         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
485         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
486         (MockPrinter):
487         (MockPrinter.__init__):
488         (MockPrinter.write):
489         (MainTest):
490         (MainTest.test_parse_output):
491         (MainTest.test_parse_output_with_failing_line):
492         (TestPageLoadingPerfTest):
493         (TestPageLoadingPerfTest.assertWritten):
494         (TestPageLoadingPerfTest.MockDriver):
495         (TestPageLoadingPerfTest.MockDriver.__init__):
496         (TestPageLoadingPerfTest.MockDriver.run_test):
497         (TestPageLoadingPerfTest.test_run):
498         (TestPageLoadingPerfTest.test_run_with_bad_output):
499         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
500         (PerfTestsRunner):
501         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
502         (PerfTestsRunner._collect_tests):
503         (PerfTestsRunner._run_tests_set):
504         (PerfTestsRunner._run_single_test):
505         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
506         (test_collect_tests_with_page_load_svg):
507         (test_collect_tests_with_page_load_svg.add_file):
508
509 2012-04-10  Brady Eidson  <beidson@apple.com>
510
511         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
512         Need WebKit2 API to notify whether history loads are in the page cache
513
514         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
515         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
516
517         Reviewed by Darin Adler.
518
519         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
520         (TestWebKitAPI::didFinishLoadForFrame):
521         (TestWebKitAPI::willGoToBackForwardListItem):
522         (TestWebKitAPI::setPageLoaderClient):
523         (TestWebKitAPI::TEST):
524         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
525         (ShouldGoToBackForwardListItemTest):
526         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
527         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
528         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
530
531         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
532         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
533
534 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
535
536         Group EFL bots into a category on the buildbot master
537         https://bugs.webkit.org/show_bug.cgi?id=82712
538
539         Reviewed by Adam Roben.
540
541         Creating a new category definition on the buildbot frontend.
542
543         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
544         (loadBuilderConfig): Determine category for EFL bots
545         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
546
547 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
548
549         Unreviewed, rolling out r113714.
550         http://trac.webkit.org/changeset/113714
551         https://bugs.webkit.org/show_bug.cgi?id=83887
552
553         It is behaving strange on the bots and needs more
554         investigation. (Requested by jeez_ on #webkit).
555
556         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
557         (WTR::PlatformWebView::PlatformWebView):
558
559 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
560
561         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
562         https://bugs.webkit.org/show_bug.cgi?id=83690
563
564         Reviewed by Tor Arne Vestbø.
565
566         Typing part of an email and pressing <TAB> will bash-complete it using the list in
567         Tools/Scripts/webkitpy/common/config/committers.py
568
569         * Scripts/webkit-tools-completion.sh:
570
571 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
572
573         [EFL] Add API for color chooser
574         https://bugs.webkit.org/show_bug.cgi?id=83692
575
576         Enables INPUT_TYPE_COLOR by default on the EFL port.
577
578         Reviewed by Kenneth Rohde Christiansen.
579
580         * Scripts/build-webkit:
581
582 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
583
584         Extract PerfTest class from PerfTestRunner
585         https://bugs.webkit.org/show_bug.cgi?id=83847
586
587         Reviewed by Hajime Morita.
588
589         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
590         that was previously represented by a tuple.
591
592         Also moved the logic to determine whether a given test is chromium style or not from run() to
593         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
594         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
595         add new types of tests more easily.
596
597         * Scripts/webkitpy/performance_tests/perftest.py: Added.
598         (PerfTest):
599         (PerfTest.__init__):
600         (PerfTest.test_name):
601         (PerfTest.dirname):
602         (PerfTest.path_or_url):
603         (PerfTest._should_ignore_line_in_parser_test_result):
604         (PerfTest.parse_output):
605         (ChromiumStylePerfTest):
606         (ChromiumStylePerfTest.__init__):
607         (ChromiumStylePerfTest.parse_output):
608         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
609         (PerfTestsRunner._collect_tests):
610         (PerfTestsRunner.run):
611         (PerfTestsRunner._run_tests_set):
612         (PerfTestsRunner._run_single_test):
613         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
614         (run_test):
615         (_tests_for_runner):
616         (test_run_test_set_with_json_output):
617         (test_run_test_set_with_json_source):
618         (test_run_test_set_with_multiple_repositories):
619         (_collect_tests_and_sort_test_name):
620         (test_collect_tests):
621         (test_collect_tests_with_skipped_list):
622
623 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
624
625         [Qt] Fix WebKit1 build with V8
626         https://bugs.webkit.org/show_bug.cgi?id=83322
627
628         Reviewed by Adam Barth.
629
630         * DumpRenderTree/qt/DumpRenderTree.pro:
631         * qmake/mkspecs/features/default_post.prf:
632         * qmake/mkspecs/features/default_pre.prf:
633         * qmake/mkspecs/features/features.prf:
634
635 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
636
637         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
638         https://bugs.webkit.org/show_bug.cgi?id=83583
639
640         Reviewed by Philippe Normand
641
642         Updated the unit test to ignore the hours and minutes of the
643         localtime for time(0), since we can't easily guarantee which
644         timezone we're in or what timezone rules were in effect on
645         1/1/1970; this should be mostly fine since we can trust that
646         time.localtime() will work, although there is the possibility
647         that we'll screw up the time formatting of which field is the
648         hours and which is the minutes.
649
650         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
651         (VerboseTest):
652         (VerboseTest.test_basic):
653         (VerboseTest.test_log_after_update):
654
655 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
656
657         Add an EFL Debug Buildbot to the master configuration
658         https://bugs.webkit.org/show_bug.cgi?id=82711
659
660         Forgot to add EFL Linux Debug to scheduler.
661
662         Reviewed by Philippe Normand.
663
664         * BuildSlaveSupport/build.webkit.org-config/config.json:
665
666 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
667
668         Add an EFL Debug Buildbot to the master configuration
669         https://bugs.webkit.org/show_bug.cgi?id=82711
670
671         Reviewed by Philippe Normand.
672
673         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
674
675         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
676
677 2012-04-12  George Staikos  <staikos@webkit.org>
678
679         Enable the fullscreen API for BlackBerry.
680         https://bugs.webkit.org/show_bug.cgi?id=83757
681
682         Reviewed by Antonio Gomes.
683
684         * Scripts/build-webkit:
685
686 2012-04-12  Simon Pena  <spena@igalia.com>
687
688         [GTK] Test runner crashes without recent versions of pulseaudio-utils
689         https://bugs.webkit.org/show_bug.cgi?id=83774
690
691         Reviewed by Philippe Normand.
692
693         Besides checking that pactl is available, check also that its output
694         is the expected one, and handle gracefully when it isn't, when
695         trying to unload pulseaudio modules.
696
697         * Scripts/webkitpy/layout_tests/port/gtk.py:
698         (GtkPort._unload_pulseaudio_module):
699         (GtkPort._restore_pulseaudio_module):
700
701 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
702
703         [Qt] Use QRawFont when building with Qt 5
704         https://bugs.webkit.org/show_bug.cgi?id=78001
705
706         Flip the QRawFont switch for Qt 5.
707
708         Reviewed by Simon Hausmann.
709
710         * qmake/mkspecs/features/features.prf:
711
712 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
713
714         Web Inspector: Disabling Inspector causes build failure on Windows
715         https://bugs.webkit.org/show_bug.cgi?id=83557
716
717         Reviewed by Pavel Feldman.
718
719         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
720         This change brings all such API calls under the guard.
721
722         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
723         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
724         (WTR):
725         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
726         (LayoutTestController):
727         * WebKitTestRunner/TestInvocation.cpp:
728         (WTR::TestInvocation::invoke):
729
730 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
731
732         Fix regression introduced in r113927.
733
734         Unreviewed, build fix.
735
736         I failed to rename skipped_tests() to skipped_layout_tests()
737         everywhere it needed to be renamed. The unit tests didn't catch
738         this because the TestPort was one of the places that didn't get
739         renamed :(.
740
741         * Scripts/webkitpy/layout_tests/controllers/manager.py:
742         (Manager.parse_expectations):
743         * Scripts/webkitpy/layout_tests/port/test.py:
744         (TestPort.skipped_layout_tests):
745         * Scripts/webkitpy/tool/commands/queries.py:
746         (PrintExpectations._model):
747
748 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
749
750         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
751         https://bugs.webkit.org/show_bug.cgi?id=47528
752
753         Reviewed by Adam Barth.
754
755         The skipped-ports command has been replaced by 'webkit-patch
756         print-expectations', which offers the equivalent functionality
757         via 'webkit-patch print-expectations --platform \* -t skip'
758         (and other features, of course).
759         
760         This also allows me to fix a nasty layering violation where the
761         chromium port had to know about the TestExpectations objects in
762         order to implement the command properly.
763
764         Lastly, this allows me to rename skipped_tests() to
765         skipped_layout_tests() to more consistent with
766         skipped_perf_tests().
767         
768         This patch removes skips_layout_test() from the Port interface,
769         because that can't be implemented without the port knowing about
770         Expectations objects (and skipped-ports was the only thing using it).
771
772         * Scripts/webkitpy/layout_tests/port/base.py:
773         (Port.skipped_layout_tests):
774         (Port.skipped_perf_tests):
775         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
776         (PortTest.test_default_configuration_notfound):
777         * Scripts/webkitpy/layout_tests/port/chromium.py:
778         (ChromiumPort.test_expectations_overrides):
779         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
780         (ChromiumPortTest.test_path_to_image_diff):
781         * Scripts/webkitpy/layout_tests/port/webkit.py:
782         (WebKitPort.skipped_layout_tests):
783         * Scripts/webkitpy/tool/commands/queries.py:
784         (execute):
785         * Scripts/webkitpy/tool/commands/queries_unittest.py:
786         (QueryCommandsTest.test_tree_status):
787
788 2012-04-11  Mark Rowe  <mrowe@apple.com>
789
790         Remove a fprintf from LayoutTestController.
791
792         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
793         It was added for no apparent reason by Ryosuke in r113651.
794
795         * DumpRenderTree/LayoutTestController.cpp:
796         (LayoutTestController::redirectionDestinationForURL):
797
798 2012-04-11  Nico Weber  <thakis@chromium.org>
799
800         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
801         https://bugs.webkit.org/show_bug.cgi?id=83709
802
803         Reviewed by Anders Carlsson.
804
805         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
806         (handleEventCarbon):
807
808 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
809
810         Adding myself to committers.py
811         https://bugs.webkit.org/show_bug.cgi?id=83711
812
813         Unreviewed update to committers.py.
814
815         * Scripts/webkitpy/common/config/committers.py:
816
817 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
818
819         [EFL] LayoutTestController needs implementation of pageProperty
820         https://bugs.webkit.org/show_bug.cgi?id=82449
821
822         Add missing implementation pageProperty to EFL's LayoutTestController
823         in order to unskip printing/page-rule-selection.html
824
825         Reviewed by Antonio Gomes.
826
827         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
828         (LayoutTestController::pageProperty):
829
830 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
831
832         Unreviewed, rolling out r113836.
833         http://trac.webkit.org/changeset/113836
834         https://bugs.webkit.org/show_bug.cgi?id=83705
835
836         Broke all the WebKit2 inspector tests (Requested by andersca
837         on #webkit).
838
839         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
840         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
841         (WTR::LayoutTestController::showWebInspector):
842         (WTR::LayoutTestController::closeWebInspector):
843         (WTR::LayoutTestController::evaluateInWebInspector):
844         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
845         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
846         (LayoutTestController):
847         * WebKitTestRunner/TestInvocation.cpp:
848         (WTR::TestInvocation::invoke):
849
850 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
851
852         Web Inspector: Disabling Inspector causes build failure on Windows
853         https://bugs.webkit.org/show_bug.cgi?id=83557
854
855         Reviewed by Pavel Feldman.
856
857         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
858         This change brings all such API calls under the guard.
859
860         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
861         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
862         (WTR):
863         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
864         (LayoutTestController):
865         * WebKitTestRunner/TestInvocation.cpp:
866         (WTR::TestInvocation::invoke):
867
868 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
869
870         [Qt][WK2] Manage graphics buffers in the web process
871         https://bugs.webkit.org/show_bug.cgi?id=78675
872  
873         Make graphics surface available only for Qt 5, attempting to fix
874         the Qt-mac build.
875
876         Unreviewed build fix.
877
878         * qmake/mkspecs/features/features.prf:
879
880 2012-04-11  Philippe Normand  <pnormand@igalia.com>
881
882         Unreviewed, GTK NRWT follow-up fix after r113849.
883
884         * Scripts/webkitpy/layout_tests/port/gtk.py:
885         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
886
887 2012-04-11  Simon Pena  <spena@igalia.com>
888
889         [GTK] media/event-attributes.html fails
890         https://bugs.webkit.org/show_bug.cgi?id=71662
891
892         Reviewed by Philippe Normand.
893
894         PulseAudio's module "module-stream-restore" allows saving the volume
895         of a stream, restoring it the next time it runs.
896         This affects the tests, since DumpRenderTree's volume settings are
897         saved between test runs, and tests relying on specific volume values
898         would miss some volumeChange events (or get additional ones).
899
900         This patch hooks on the existing GtkPort setup_test_run method and
901         creates a new clean_up_test_run method, so PulseAudio's module is
902         unloaded (if found) before running the tests, and restored (if it
903         was there previously) after they finished, ensuring the tests run in
904         the right environment.
905
906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
907         (Manager._clean_up_run): Invoke the port implementation of
908         clean_up_test_run.
909         * Scripts/webkitpy/layout_tests/port/base.py:
910         (Port.clean_up_test_run): Add an empty implementation of
911         clean_up_test_run.
912         * Scripts/webkitpy/layout_tests/port/gtk.py:
913         (GtkPort._unload_pulseaudio_module): Unloads the offending
914         pulseaudio module, if found.
915         (GtkPort):
916         (GtkPort._restore_pulseaudio_module): Restores the offending
917         pulseaudio module, if it was there previously.
918         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
919         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
920
921 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
922
923         Fix the build with gcc 4.7.0
924         https://bugs.webkit.org/show_bug.cgi?id=83584
925
926         Reviewed by Alexey Proskuryakov.
927
928         * qmake/mkspecs/features/unix/default_post.prf:
929         The -fuse-ld=gold option is not supported with upstream gcc.
930
931 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
932
933         Refactor PerfTestRunner to include file extensions in test names
934         https://bugs.webkit.org/show_bug.cgi?id=83677
935
936         Reviewed by Hajime Morita.
937
938         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
939
940         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
941         (PerfTestsRunner._collect_tests):
942         (PerfTestsRunner._run_tests_set):
943         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
944         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
945         (PerfTestsRunner._run_single_test):
946         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
947         (run_test):
948         (_tests_for_runner):
949         (test_run_test_set):
950         (test_run_test_set_kills_drt_per_run):
951         (test_run_test_pause_before_testing):
952         (test_run_test_set_for_parser_tests):
953         (test_collect_tests):
954         (test_collect_tests_with_skipped_list):
955
956 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
957
958         Web Inspector: Disabling Inspector causes build failure on Windows
959         https://bugs.webkit.org/show_bug.cgi?id=83557
960
961         Reviewed by Pavel Feldman.
962
963         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
964         This change brings all such API calls under the guard.
965
966         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
967         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
968         (WTR):
969         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
970         (LayoutTestController):
971         * WebKitTestRunner/TestInvocation.cpp:
972         (WTR::TestInvocation::invoke):
973
974 2012-04-10  Kent Tamura  <tkent@chromium.org>
975
976         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
977
978         * Scripts/webkitpy/common/config/watchlist:
979         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
980
981 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
982
983         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
984         https://bugs.webkit.org/show_bug.cgi?id=82799
985
986         Reviewed by Ojan Vafai.
987
988         The tests we were skipping in _mark_interrupted_tests_as_skipped
989         had incorrectly-constructed TestResults, and so they were not
990         being treated as failures. The JSON generator doesn't record
991         tests that are passed or skiped in incremental_results, so you
992         couldn't tell these tests were being skipped at all.
993
994         This change changes _mark_interrupted_tests_as_skipped() to
995         treat the skipped tests as failures; this is arguably still
996         incorrect but is minimally invasive for now. We probably need to
997         revisit how we are uploading information about tests that are
998         skipped and passed altogether in a separate change.
999
1000         This change also cleans up a couple of other nits that were
1001         unnecessary or broken in this same code path.
1002
1003         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1004         (Manager._mark_interrupted_tests_as_skipped):
1005         (Manager._upload_json_files): Deletes the check for
1006         chromium-mac-leopard (as it is no longer necessary).
1007         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1008         (JSONLayoutResultsGenerator.__init__): Here we were
1009         recalculating the failure type unnecessarily.
1010         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1011         (determine_result_type):
1012         (FailureEarlyExit): Adds a new failure type so we can tell what
1013         happened.
1014         (FailureEarlyExit.message):
1015         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1016         (MainTest.test_exit_after_n_failures_upload): Add more checks to
1017         ensure that we are recording the SKIP correctly; this is less
1018         than ideal, because we can't actually test the contents of
1019         incremental_results.json. We should fix that at some point.
1020
1021 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1022
1023         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
1024         https://bugs.webkit.org/show_bug.cgi?id=83401
1025
1026         Reviewed by Adam Barth.
1027
1028         Last patch in the series - no longer look in mac-leopard,
1029         mac-snowleopard, or mac-lion.
1030
1031         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1032         (ChromiumMacPort):
1033         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1034
1035 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1036
1037         webkit-patch: add a print-expectations command
1038         https://bugs.webkit.org/show_bug.cgi?id=83347
1039
1040         Reviewed by Adam Barth.
1041
1042         This command will print the expected results for a given set of
1043         tests on a given set of ports matching a given set of keywords.
1044
1045         Example output (printing all the tests not expected to pass, and their
1046         expected results, on a Mac):
1047
1048         $ webkit-patch print-expectations -x pass fast/html
1049         // For mac-snowleopard
1050         fast/html/details-open4.html = TEXT
1051         fast/html/details-open2.html = TEXT
1052         fast/html/details-no-summary4.html = TEXT
1053         fast/html/details-open-javascript.html = TEXT
1054         $
1055
1056         You can also print full test-expectatons.txt lines using --full and a
1057         CSV-style report (which can be useful for post-processing) using --csv.
1058
1059         It will replace the 'skipped-files' command (which will be
1060         removed in a subsequent patch) and is a more general (and
1061         cleaner and properly layered) solution.
1062
1063         Also add an update() command to MockOptions() to make overriding keywords easier.
1064
1065         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1066         (TestExpectationSerializer.to_string):
1067         (TestExpectationSerializer):
1068         (TestExpectationSerializer.to_csv):
1069         (TestExpectationSerializer._format_result):
1070         (TestExpectationLine.create_passing_expectation):
1071         (TestExpectationsModel.get_test_set_for_keyword):
1072         (TestExpectationsModel.has_keyword):
1073         (TestExpectations.model):
1074         * Scripts/webkitpy/tool/commands/queries.py:
1075         (execute):
1076         (PrintExpectations):
1077         (PrintExpectations.__init__):
1078         (PrintExpectations.execute):
1079         (PrintExpectations._filter_tests):
1080         (PrintExpectations._format_lines):
1081         (PrintExpectations._model):
1082         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1083         (TestPrintExpectations): Added.
1084         * Scripts/webkitpy/tool/mocktool.py:
1085         (MockOptions):
1086         (MockOptions.__init__):
1087         (MockOptions.update): Added.
1088
1089 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1090
1091         webkitpy: refactor handling of --platform and related options
1092         https://bugs.webkit.org/show_bug.cgi?id=83525
1093
1094         Reviewed by Adam Barth.
1095
1096         This change moves to centralize handling of --platform, --debug,
1097         --gtk, and other similar flags into a central place next to the
1098         code that actually uses those flags in PortFactory to get the
1099         right Port object.
1100
1101         * Scripts/webkitpy/layout_tests/port/__init__.py:
1102         * Scripts/webkitpy/layout_tests/port/factory.py:
1103         (port_options):
1104         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1105         (parse_args):
1106         * Scripts/webkitpy/tool/commands/queries.py:
1107         (PrintBaselines.__init__):
1108
1109 2012-04-10  Ojan Vafai  <ojan@chromium.org>
1110
1111         Add a chromeless view to the individual tests view
1112         https://bugs.webkit.org/show_bug.cgi?id=83541
1113
1114         Reviewed by Daniel Bates.
1115
1116         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
1117
1118         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1119         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
1120         (testHtmlForIndividualTestOnAllBuilders):
1121         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
1122         (testHtmlForIndividualTestOnAllBuildersWithChrome):
1123         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
1124         (testHtmlForIndividualTests):
1125         (htmlEscape):
1126         (runTests):
1127
1128 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
1129
1130         remove 'win' from chromium-win, chromium-linux fallback paths
1131         https://bugs.webkit.org/show_bug.cgi?id=83613
1132
1133         Reviewed by Ojan Vafai.
1134
1135         The chromium ports no longer need to look at the apple 'win'
1136         directory for baseline results.
1137
1138         Also remove the old '-gpu-' entries from the flakiness dashboard
1139         map since I'm touching lines nearby.
1140
1141         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1142         (ChromiumLinuxPort):
1143         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1144         (ChromiumWinPort):
1145         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1146
1147 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
1148
1149         [Qt][WK2] Manage graphics buffers in the web process
1150         https://bugs.webkit.org/show_bug.cgi?id=78675
1151
1152         Enable graphics surfaces on Mac for Qt.
1153
1154         Reviewed by Kenneth Rohde Christiansen.
1155
1156         * qmake/mkspecs/features/features.prf:
1157
1158 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1159
1160         [CMake] Enable USE_FOLDERS property
1161         https://bugs.webkit.org/show_bug.cgi?id=83571
1162
1163         Reviewed by Daniel Bates.
1164
1165         Setting the FOLDER property on targets gives more structure
1166         to the generated Visual Studio solutions.
1167         This does not affect other CMake generators.
1168
1169         * DumpRenderTree/efl/CMakeLists.txt:
1170         * EWebLauncher/CMakeLists.txt:
1171         * WinCELauncher/CMakeLists.txt:
1172
1173 2012-04-10  David Dorwin  <ddorwin@chromium.org>
1174
1175         Add Encrypted Media Extensions methods to HTMLMediaElement
1176         https://bugs.webkit.org/show_bug.cgi?id=82971
1177
1178         Reviewed by Adam Barth.
1179
1180         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
1181         Implementation is based on v0.1 of the draft proposal at
1182         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
1183
1184         * DumpRenderTree/chromium/TestShell.cpp:
1185         (TestShell::TestShell):
1186
1187 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1188
1189         [EFL][DRT] Catch the "title,changed" signal
1190         https://bugs.webkit.org/show_bug.cgi?id=82174
1191
1192         Reviewed by Gustavo Noronha Silva.
1193
1194         EFL's DumpRenderTree now catches the "title,changed" signal, and
1195         prints out the needed information.
1196
1197         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1198         (DumpRenderTreeChrome::onTitleChanged):
1199
1200 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
1201
1202         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
1203         https://bugs.webkit.org/show_bug.cgi?id=82443
1204
1205         Reviewed by Philippe Normand.
1206
1207         EFL's DRT needs to support LayoutTestController's
1208         willSendRequestReturnsNull() and return NULL when expected. This
1209         allows for several tests to be removed from the skip list.
1210
1211         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1212         (DumpRenderTreeChrome::onWillSendRequest):
1213
1214 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1215
1216         [EFL] LayoutTestController needs implementation of addUserStyleSheet
1217         https://bugs.webkit.org/show_bug.cgi?id=82446
1218
1219         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController 
1220         so that we can unskip related tests from the skip list. 
1221
1222         Reviewed by Antonio Gomes.
1223
1224         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1225         (LayoutTestController::addUserStyleSheet): Implemented.
1226
1227 2012-04-10  Philip Rogers  <pdr@google.com>
1228
1229         Adding myself to committers.py!
1230
1231         Unreviewed update to committers.py.
1232
1233         * Scripts/webkitpy/common/config/committers.py:
1234
1235 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
1236
1237         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
1238         https://bugs.webkit.org/show_bug.cgi?id=82483
1239
1240         Reviewed by Kenneth Rohde Christiansen.
1241
1242         Set window title to default if there is no page title.
1243
1244         * MiniBrowser/qt/BrowserWindow.cpp:
1245         (BrowserWindow::BrowserWindow):
1246         (BrowserWindow::onTitleChanged):
1247         * MiniBrowser/qt/BrowserWindow.h:
1248         (BrowserWindow):
1249
1250 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1251
1252         [Qt][WK2] Implement PageClient::isViewWindowActive()
1253         https://bugs.webkit.org/show_bug.cgi?id=81143
1254
1255         Reviewed by Kenneth Rohde Christiansen.
1256
1257         Fix the WrapperWindow from our PlatformWebView
1258         so it correctly creates the platform related
1259         stuff for QWindow, which is not created unless
1260         QWindow::setVisible() or QWindow::show() are called.
1261
1262         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1263         (WTR::PlatformWebView::PlatformWebView):
1264
1265 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
1266
1267         [Qt][WK2] TestNetscapePlugin is broken
1268         https://bugs.webkit.org/show_bug.cgi?id=83024
1269
1270         Reviewed by Csaba Osztrogonác.
1271
1272         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1273         Fix X11 availability check. embedded is always true with QPA.
1274         * Tools.pro:
1275         Build the test plugin if plugins are enabled for WebKit2.
1276         * qmake/mkspecs/features/features.prf:
1277         * qmake/mkspecs/features/functions.prf:
1278         Added a convenience function to determine availability
1279         of X11 libraries.
1280
1281 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
1282
1283         [WIN] Fix build without precompiled header.
1284
1285         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
1286
1287 2012-04-10  Arko Saha  <arko@motorola.com>
1288
1289         Unreviewed: adding myself to committers.py.
1290
1291         * Scripts/webkitpy/common/config/committers.py:
1292
1293 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1294
1295         Unreviewed: adding myself to committers.py.
1296
1297         * Scripts/webkitpy/common/config/committers.py:
1298
1299 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
1300
1301         Unreviewed, rolling out r113656.
1302         http://trac.webkit.org/changeset/113656
1303         https://bugs.webkit.org/show_bug.cgi?id=83542
1304
1305         test is broken on chromium-win (Requested by simonjam on
1306         #webkit).
1307
1308         * DumpRenderTree/chromium/WebViewHost.cpp:
1309         (WebViewHost::dispatchIntent):
1310
1311 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
1312
1313         Update pywebsocket to 0.7.4.
1314         https://bugs.webkit.org/show_bug.cgi?id=83461
1315
1316         Reviewed by Kent Tamura.
1317
1318         This version supports TLS by using ssl in addition to pyOpenSSL.
1319         Other functional difrerences from 0.7.2 are:
1320          - strict Sec-WebSocket-Key validation conforming RFC 4648
1321          - compression ratio logging in debug
1322
1323         * Scripts/webkitpy/thirdparty/__init__.py:
1324         (AutoinstallImportHook._install_pywebsocket):
1325
1326 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1327
1328         add a webkit-patch print-baselines command
1329         https://bugs.webkit.org/show_bug.cgi?id=83348
1330
1331         Reviewed by Adam Barth.
1332
1333         This adds a simple 'print-baselines' command to webkit-patch
1334         that can be used in one of two forms: to print where the
1335         baselines for a given test (or set of tests) on a single port
1336         will be found, or to generate a report for multiple ports.
1337
1338         Example of the former:
1339
1340         $ webkit-patch print-baselines fast/html/keygen.html
1341         // For mac-snowleopard
1342         platform/mac/fast/html/keygen-expected.txt
1343         platform/mac/fast/html/keygen-expected.png
1344         $
1345
1346         The latter is most useful for finding out which fallback dirs are
1347         used by which ports for which tests, for example,
1348         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
1349         No example output is given because the reports are pretty wordy :).
1350
1351         * Scripts/webkitpy/layout_tests/port/base.py:
1352         (Port.baseline_extensions): Added.
1353         (Port.expected_baseline_dict): Added.
1354         * Scripts/webkitpy/tool/commands/queries.py:
1355         (PrintBaselines):
1356         (PrintBaselines.__init__):
1357         (PrintBaselines.execute):
1358         (PrintBaselines._print_baselines):
1359         (PrintBaselines._platform_for_path):
1360
1361 2012-04-09  Florin Malita  <fmalita@chromium.org>
1362
1363         Unreviewed: adding myself to committers.py.
1364
1365         * Scripts/webkitpy/common/config/committers.py:
1366
1367 2012-04-09  Ming Xie  <mxie@rim.com>
1368
1369         [BlackBerry] Allow simulator to use GLES2 acceleration
1370         https://bugs.webkit.org/show_bug.cgi?id=81672
1371
1372         Reviewed by Rob Buis.
1373
1374         * Scripts/webkitdirs.pm:
1375         (blackberryCMakeArguments):
1376
1377 2012-04-09  Dana Jansens  <danakj@chromium.org>
1378
1379         Mark myself as a committer
1380         https://bugs.webkit.org/show_bug.cgi?id=83510
1381
1382         Reviewed by Adrienne Walker.
1383
1384         * Scripts/webkitpy/common/config/committers.py:
1385
1386 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1387
1388         nrwt is failing to upload test results on the chromium-mac-leopard bots
1389         https://bugs.webkit.org/show_bug.cgi?id=83230
1390
1391         Unreviewed, build fix.
1392
1393         It looks like the change in r113399 to use the per-request
1394         timeout variable didn't actually work, so I am removing the
1395         timeout code altogether and counting on the idea that upload
1396         just isn't likely to take that long and the timeouts and
1397         retransmits are largely unused and largely unnecessary. We'll
1398         see if this breaks anywhere else.
1399
1400         * Scripts/webkitpy/common/net/file_uploader.py:
1401         (FileUploader.__init__):
1402         (FileUploader._upload_data.callback):
1403         (FileUploader):
1404
1405 2012-04-09  Rob Buis  <rbuis@rim.com>
1406
1407         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
1408         https://bugs.webkit.org/show_bug.cgi?id=83469
1409
1410         Reviewed by Dirk Schulze.
1411
1412         Remove WTF:: prefixes and fix a warning with the length variable.
1413
1414         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1415         (jsStringRefToWebCoreString):
1416         (LayoutTestController::execCommand):
1417         (LayoutTestController::isCommandEnabled):
1418         (LayoutTestController::setUserStyleSheetLocation):
1419         (LayoutTestController::counterValueForElementById):
1420         (LayoutTestController::overridePreference):
1421         (LayoutTestController::setMockGeolocationError):
1422         (LayoutTestController::findString):
1423
1424 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
1425
1426         Build fix for WinCE after r113570.
1427
1428         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
1429
1430 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
1431
1432         Subscribe eric.carlson@apple.com to Media-related changes
1433         https://bugs.webkit.org/show_bug.cgi?id=83421
1434
1435         Reviewed by Dan Bernstein.
1436
1437         * Scripts/webkitpy/common/config/watchlist:
1438
1439 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
1440
1441         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
1442         https://bugs.webkit.org/show_bug.cgi?id=83412
1443
1444         Reviewed by David Levin.
1445
1446         Accept NULL as an argument for gtk_style_context_get_style, because it's
1447         used as a sentinel in a variable argument list. 
1448
1449         * Scripts/webkitpy/style/checkers/cpp.py:
1450         (check_for_null): Add an exception.
1451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1452         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
1453
1454 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
1455
1456         webkitpy: use the filesystem object properly in fileuploader
1457         https://bugs.webkit.org/show_bug.cgi?id=83326
1458
1459         Reviewed by Adam Barth.
1460
1461         We should be using the filesystem object rather than the codecs
1462         object.
1463
1464         * Scripts/webkitpy/common/net/file_uploader.py:
1465         (FileUploader.upload_as_multipart_form_data):
1466
1467 2012-04-09  Eric Seidel  <eric@webkit.org>
1468
1469         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1470         https://bugs.webkit.org/show_bug.cgi?id=83329
1471
1472         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
1473
1474         line 62, in _create_unit_test_results
1475          return UnitTestResults.results_from_string(results_xml)
1476          NameError: global name 'UnitTestResults' is not defined
1477
1478         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1479         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1480         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1481
1482 2012-04-08  Adam Barth  <abarth@webkit.org>
1483
1484         The port object is missing unit_tests_results_path
1485         https://bugs.webkit.org/show_bug.cgi?id=83448
1486
1487         Unreviewed.
1488
1489         This is causing the cr-linux-ews to throw an exception.
1490
1491         * Scripts/webkitpy/common/config/ports.py:
1492         (DeprecatedPort.unit_tests_results_path):
1493
1494 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
1495
1496         [CMake] Cleanup WTF include directories
1497         https://bugs.webkit.org/show_bug.cgi?id=82716
1498
1499         Reviewed by Eric Seidel.
1500
1501         * DumpRenderTree/efl/CMakeLists.txt:
1502         * WinCELauncher/CMakeLists.txt:
1503
1504 2012-04-07  Rob Buis  <rbuis@rim.com>
1505
1506         [BlackBerry] Add Battery Status API support
1507         https://bugs.webkit.org/show_bug.cgi?id=82615
1508
1509         Reviewed by George Staikos.
1510
1511         Enable BATTERY_STATUS.
1512
1513         * Scripts/build-webkit:
1514
1515 2012-04-06  Ami Fischman  <fischman@chromium.org>
1516
1517         Subscribe feature-media-reviews@c.o to Media-related changes.
1518         https://bugs.webkit.org/show_bug.cgi?id=83397
1519
1520         Reviewed by David Levin.
1521
1522         * Scripts/webkitpy/common/config/committers.py:
1523         * Scripts/webkitpy/common/config/watchlist:
1524
1525 2012-04-06  Adrienne Walker  <enne@google.com>
1526
1527         [chromium] Add virtual test suite for threaded compositing
1528         https://bugs.webkit.org/show_bug.cgi?id=82263
1529
1530         Reviewed by James Robinson.
1531
1532         Add compositing/visibility as a virtual test suites to test threaded
1533         compositing with. This is a reasonable smoke test of 9 tests, none of
1534         which have any expectations in the non-threaded case.
1535
1536         To fix many of the remaining tests in this virtual test suite, there
1537         will need to be some serious refactoring to merge the conflict between
1538         the way CCScheduler wants to draw frames and the way DRT also wants to
1539         control things. So, in the short term, enable a few simple tests that
1540         are known to be passing.
1541
1542         * Scripts/webkitpy/layout_tests/port/chromium.py:
1543         (ChromiumPort.virtual_test_suites):
1544
1545 2012-04-06  Enrica Casucci  <enrica@apple.com>
1546
1547         Provide Obj-C private API to simplify markup.
1548         https://bugs.webkit.org/show_bug.cgi?id=83334
1549         <rdar://problem/11033861>
1550
1551         Reviewed by Sam Weinig.
1552
1553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1554         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
1555         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
1556         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
1557
1558 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
1559
1560         new-run-webkit-tests: fix bugs in 'mock' drt implementation
1561         https://bugs.webkit.org/show_bug.cgi?id=83341
1562
1563         Reviewed by Eric Seidel.
1564
1565         The current implementation crashed in some circumstances for
1566         reference tests and files that were missing expected results.
1567         This patch fixes those cases and adds more unit tests; it is a
1568         precursor to adding unit tests each port that actually uses this
1569         code, in order to get better coverage of the port/*
1570         implementations.
1571
1572         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1573         (parse_options):
1574         (MockDRT.input_from_line):
1575         (MockDRT.output_for_test):
1576         (MockDRT.run_one_test):
1577         (MockChromiumDRT.input_from_line):
1578         (MockChromiumDRT.output_for_test):
1579         (MockChromiumDRT.run_one_test):
1580         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1581         (MockDRTTest.make_input_output):
1582         (MockDRTTest.expected_output):
1583         (MockDRTTest):
1584         (MockDRTTest.assertTest):
1585         (MockDRTTest.test_missing_image):
1586         (MockDRTTest.test_missing_text):
1587         (MockDRTTest.test_reftest_match):
1588         (MockDRTTest.test_reftest_mismatch):
1589         (MockChromiumDRTTest.expected_output):
1590
1591 2012-04-06  James Robinson  <jamesr@chromium.org>
1592
1593         Enable webkit_unit_tests for commit queue and EWS while tracking failures
1594         https://bugs.webkit.org/show_bug.cgi?id=83329
1595
1596         Reviewed by Adam Barth.
1597
1598         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
1599         the commit queue and EWS can reject patches that cause regressions.
1600
1601         * Scripts/webkitpy/common/config/ports.py:
1602         (ChromiumPort.run_webkit_unit_tests_command):
1603         * Scripts/webkitpy/common/config/ports_mock.py:
1604         (MockPort.unit_tests_results_path):
1605         * Scripts/webkitpy/common/net/layouttestresults.py:
1606         (LayoutTestResults.__init__):
1607         (LayoutTestResults.failing_tests):
1608         (LayoutTestResults):
1609         (LayoutTestResults.add_unit_test_failures):
1610         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
1611         (UnitTestResults):
1612         (UnitTestResults.results_from_string):
1613         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
1614         (UnitTestResultsTest):
1615         (UnitTestResultsTest.test_nostring):
1616         (UnitTestResultsTest.test_emptystring):
1617         (UnitTestResultsTest.test_nofailures):
1618         (test_onefailure):
1619         (test_multiple_failures_per_test):
1620         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1621         (MockCommitQueue.test_results):
1622         (MockCommitQueue.archive_last_test_results):
1623         (FailingTestCommitQueue.test_results):
1624         (test_flaky_test_failure):
1625         (test_failed_archive):
1626         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1627         (LayoutTestResultsReader._create_unit_test_results):
1628         (LayoutTestResultsReader.results):
1629         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1630         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1631         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1632         (PatchAnalysisTaskDelegate.test_results):
1633         (PatchAnalysisTaskDelegate.archive_last_test_results):
1634         (PatchAnalysisTask._test):
1635         (PatchAnalysisTask._build_and_test_without_patch):
1636         (PatchAnalysisTask._test_patch):
1637         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1638         (AbstractEarlyWarningSystem.test_results):
1639         (AbstractEarlyWarningSystem.archive_last_test_results):
1640         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1641         (EarlyWarningSytemTest._test_testing_ews):
1642         * Scripts/webkitpy/tool/commands/queues.py:
1643         (CommitQueue.test_results):
1644         (CommitQueue.archive_last_test_results):
1645         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1646         (CommitQueueTest.test_commit_queue):
1647         (test_rollout):
1648         (test_manual_reject_during_processing):
1649         * Scripts/webkitpy/tool/steps/runtests.py:
1650         (RunTests.run):
1651         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1652         (RunTestsTest.test_webkit_run_unit_tests):
1653
1654 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
1655
1656         Enable MediaSource feature for DumpRenderTree so
1657         MediaSource LayoutTests will pass for Chromium.
1658         https://bugs.webkit.org/show_bug.cgi?id=83053
1659
1660         Reviewed by Dimitri Glazkov.
1661
1662         * DumpRenderTree/chromium/TestShell.cpp:
1663         (TestShell::TestShell):
1664
1665 2012-04-06  George Staikos  <staikos@webkit.org>
1666
1667         Turn on vibration support for BlackBerry.
1668
1669         Reviewed by Rob Buis.
1670
1671         * Scripts/build-webkit:
1672
1673 2012-04-06  Dan Bernstein  <mitz@apple.com>
1674
1675         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
1676
1677         Reviewed by Sam Weinig.
1678
1679         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
1680
1681 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
1682
1683         nrwt is failing to upload test results on the chromium-mac-leopard bots
1684         https://bugs.webkit.org/show_bug.cgi?id=83230
1685
1686         Reviewed by Ojan Vafai.
1687
1688         This should fix things properly; FileUploader() was setting the
1689         socket default timeout value, and apparently that doesn't work
1690         properly with urllib. Also, the class had a bad try/finally
1691         block that was causing the exceptions to be swallowed :(.
1692
1693         * Scripts/webkitpy/common/net/file_uploader.py:
1694         (FileUploader.__init__):
1695         (FileUploader._upload_data.callback):
1696         (FileUploader):
1697         (FileUploader._upload_data):
1698         * Scripts/webkitpy/common/net/networktransaction.py:
1699         (NetworkTimeout.__str__):
1700         (NetworkTransaction.run):
1701         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1702         (JSONResultsGeneratorBase.upload_json_files):
1703
1704 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
1705
1706         [Qt] Correct <wtf/*.h> include paths.
1707         https://bugs.webkit.org/show_bug.cgi?id=83270
1708
1709         Reviewed by Eric Seidel.
1710
1711         Modify the #include declerations so that the
1712         wtf types are included using the full path.
1713
1714         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1715
1716 2012-04-05  Philippe Normand  <pnormand@igalia.com>
1717
1718         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1719         https://bugs.webkit.org/show_bug.cgi?id=83176
1720
1721         Reviewed by Tony Chang.
1722
1723         Refactored the test to use os.path.join() to specify the
1724         core_pattern value of the empty crash log mock.
1725
1726         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1727         (GtkPortTest):
1728         (GtkPortTest.assertLinesEqual):
1729         (GtkPortTest.test_get_crash_log):
1730         (_mock_gdb_output):
1731
1732 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
1733
1734         [Qt] Fix includes after QtDeclarative -> QtQML renaming
1735         https://bugs.webkit.org/show_bug.cgi?id=82195
1736
1737         Relanding r112651, because Qt5 is updated everywhere.
1738
1739         * MiniBrowser/qt/BrowserWindow.cpp:
1740         (BrowserWindow::updateVisualMockTouchPoints):
1741         * MiniBrowser/qt/main.cpp:
1742         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1743         (WTR::WrapperWindow::handleStatusChanged):
1744         * qmake/mkspecs/features/unix/default_post.prf:
1745
1746 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
1747
1748         [Qt] WK1/WK2 layout test results are diverging
1749         https://bugs.webkit.org/show_bug.cgi?id=82720
1750
1751         The resolving of default font families was altered in Qt5.
1752         This directly affects the font picked by DRT for layout
1753         tests. Since we want to keep the Qt4 and Qt5 results in line,
1754         we can trick DRT in picking the same font as before for now.
1755
1756         Reviewed by Csaba Osztrogonác.
1757
1758         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1759         (WebKit::initializeTestFonts):
1760
1761 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
1762
1763         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
1764         https://bugs.webkit.org/show_bug.cgi?id=82592
1765
1766         Reviewed by David Levin.
1767
1768         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
1769
1770         * DumpRenderTree/chromium/EventSender.cpp:
1771         (EventSender::beginDragWithFiles):
1772
1773 2012-04-04  Tim Horton  <timothy_horton@apple.com>
1774
1775         [mac] WKTR should always keep its windows offscreen
1776         https://bugs.webkit.org/show_bug.cgi?id=83244
1777         <rdar://problem/11188764>
1778
1779         Reviewed by Simon Fraser.
1780
1781         We don't want to allow windows onto the main display; intercept attempts to
1782         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
1783
1784         Also keep around and respond with a new "fake" origin, in case someone is
1785         expecting it to change (I couldn't find any tests that expected this, however).
1786
1787         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1788         (-[WebKitTestRunnerWindow setFrameOrigin:]):
1789         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
1790         (-[WebKitTestRunnerWindow setFrame:display:]):
1791         (-[WebKitTestRunnerWindow frame]):
1792
1793 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1794
1795         Fix typo introduced in r113271.
1796
1797         Unreviewed, build fix.
1798
1799         * Scripts/webkitpy/common/net/file_uploader.py:
1800         (FileUploader._upload_data.callback):
1801         (FileUploader):
1802
1803 2012-04-04  Scott Graham  <scottmg@google.com>
1804
1805         [Chromium, DRT] Bounds check indices on gamepadController
1806         https://bugs.webkit.org/show_bug.cgi?id=83192
1807
1808         Invalid test data would cause bad array accesses. Add simple checks to
1809         ignore such invalid data.
1810
1811         Reviewed by Kent Tamura.
1812
1813         * DumpRenderTree/chromium/GamepadController.cpp:
1814         (GamepadController::connect):
1815         (GamepadController::disconnect):
1816         (GamepadController::setId):
1817         (GamepadController::setButtonCount):
1818         (GamepadController::setButtonData):
1819         (GamepadController::setAxisCount):
1820         (GamepadController::setAxisData):
1821
1822 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1823
1824         nrwt is failing to upload test results on the chromium-mac-leopard bots
1825         https://bugs.webkit.org/show_bug.cgi?id=83230
1826
1827         Reviewed by Ojan Vafai.
1828
1829         More debugging info and a possible fix - stop messing with the
1830         default network timeout, and don't swallow URLErrors.
1831
1832         * Scripts/webkitpy/common/net/file_uploader.py:
1833         (FileUploader._upload_data):
1834         * Scripts/webkitpy/common/net/networktransaction.py:
1835         (NetworkTransaction.run):
1836         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1837         (JSONResultsGeneratorBase.upload_json_files):
1838
1839 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
1840
1841         nrwt is failing to upload test results on the chromium-mac-leopard bots
1842         https://bugs.webkit.org/show_bug.cgi?id=83230
1843
1844         Reviewed by Ojan Vafai.
1845
1846         * Scripts/webkitpy/common/net/file_uploader.py:
1847         (FileUploader.__init__):
1848         (FileUploader._upload_data.callback):
1849         (FileUploader):
1850         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1851         (Manager._upload_json_files):
1852         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1853         (JSONResultsGeneratorBase.upload_json_files):
1854
1855 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1856
1857         WKTR needs to implement layoutTestController.setPageVisibility()
1858         https://bugs.webkit.org/show_bug.cgi?id=69554
1859
1860         Reviewed by Simon Fraser.
1861
1862         This patch implements the layoutTestController.setPageVisibility
1863         so WKTR supports the Page Visibility API implementation by using InjectedBundle
1864         to set the visibility state directly to Page.
1865
1866         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1867         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1868         (WTR::LayoutTestController::setPageVisibility):
1869         (WTR):
1870         (WTR::LayoutTestController::resetPageVisibility):
1871         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1872         (LayoutTestController):
1873
1874 2012-04-04  Adam Barth  <abarth@webkit.org>
1875
1876         [Chromium] TestWebKitAPI links in WebCore twice
1877         https://bugs.webkit.org/show_bug.cgi?id=83177
1878
1879         Reviewed by Dimitri Glazkov.
1880
1881         This is causing link errors in the Windows component build. This patch
1882         moves the dependencies a bit lower down in the dependency diagram in
1883         the hopes of removing the duplicate symbols.
1884
1885         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1886
1887 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
1888
1889         [EFL][DRT] Catch the "resource,request,willsend" signal
1890         https://bugs.webkit.org/show_bug.cgi?id=82192
1891
1892         Reviewed by Gustavo Noronha Silva.
1893
1894         EFL's DumpRenderTree now catches the "resource,request,willsend"
1895         signal in order to implement the "Blocked access to external URL"
1896         behavior and avoid potential network-related timeouts in the tests.
1897
1898         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1899         (DumpRenderTreeChrome::createView):
1900         (DumpRenderTreeChrome::onWillSendRequest):
1901         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1902         (DumpRenderTreeChrome):
1903
1904 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
1905
1906         [EFL][DRT] Correct <wtf/*.h> include paths.
1907         https://bugs.webkit.org/show_bug.cgi?id=83168
1908
1909         Reviewed by Eric Seidel.
1910
1911         Modify the #include declarations so that the 
1912         wtf types are included using the full path.
1913
1914         * DumpRenderTree/efl/DumpRenderTree.cpp:
1915
1916 2012-04-04  Philippe Normand  <pnormand@igalia.com>
1917
1918         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
1919         https://bugs.webkit.org/show_bug.cgi?id=83176
1920
1921         Reviewed by Tony Chang.
1922
1923         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1924         (test_get_crash_log): Skip the test on non-linux platforms.
1925
1926 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1927
1928         [EFL] DRT support for computedStyleIncludingVisitedInfo
1929         https://bugs.webkit.org/show_bug.cgi?id=82190
1930
1931         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
1932         LayoutTestController so that we can unskip related tests from the skip list.
1933
1934         Reviewed by Antonio Gomes.
1935
1936         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1937         (LayoutTestController::computedStyleIncludingVisitedInfo):
1938
1939 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
1940
1941         Unreviewed; update my email address once again in the committers
1942         and watch list.
1943
1944         * Scripts/webkitpy/common/config/committers.py: Prefer my
1945         webkit.org email over my FreeBSD.org one.
1946         * Scripts/webkitpy/common/config/watchlist: Ditto.
1947
1948 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1949
1950         [Qt][WK2] QtWebKit2 should support Page Visibility API
1951         https://bugs.webkit.org/show_bug.cgi?id=81164
1952
1953         Reviewed by Kenneth Rohde Christiansen.
1954
1955         Enabling Page Visiblity API for Qt WebKit2.
1956
1957         * qmake/mkspecs/features/features.prf:
1958
1959 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
1960
1961         [Qt][WK2] Make the WebView a subclass of Flickable
1962         https://bugs.webkit.org/show_bug.cgi?id=83033
1963
1964         Reviewed by Kenneth Rohde Christiansen.
1965
1966         Remove workaround in MiniBrowser and the ScrollIndicator
1967         now that the WebView is a Flickable.
1968
1969         * MiniBrowser/qt/MiniBrowser.pro:
1970         * MiniBrowser/qt/qml/BrowserWindow.qml:
1971         * MiniBrowser/qt/qml/ScrollIndicator.qml:
1972         * WebKitTestRunner/Target.pri:
1973
1974 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
1975
1976         REGRESSION(r113144): It made run-webkit-tests always fail
1977         https://bugs.webkit.org/show_bug.cgi?id=83142
1978
1979         Unreviewed trivial fix after r113144.
1980
1981         * Scripts/run-webkit-tests:
1982
1983 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
1984
1985         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
1986         double quotations on Windows. Use system instead.
1987
1988         Hopefully, this won't break anything.
1989
1990         * Scripts/run-webkit-tests:
1991
1992 2012-04-03  Keishi Hattori  <keishi@webkit.org>
1993
1994         Disable ENABLE_DATALIST for now
1995         https://bugs.webkit.org/show_bug.cgi?id=82871
1996
1997         Reviewed by Kent Tamura.
1998
1999         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
2000
2001 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2002
2003         Sigh... this isn't going well. I can't even reproduce this issue locally.
2004         Another speculative fix.
2005
2006         * Scripts/run-webkit-tests:
2007
2008 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2009
2010         I don't know why I'm so sloppy today. Another build fix.
2011
2012         * Scripts/run-webkit-tests:
2013
2014 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2015
2016         Hopefully the last build fix for Chromium Windows.
2017
2018         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
2019
2020         * Scripts/run-webkit-tests:
2021
2022 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
2023
2024         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
2025         https://bugs.webkit.org/show_bug.cgi?id=83076
2026
2027         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
2028
2029         Add logic to the apple mac and chromium mac code to not use
2030         too many workers; it looks like the xserves (and possibly mac
2031         pros) count hyperthreaded cores when they really shouldn't and
2032         we end up using too many workers at a time; this leads to tests
2033         thrashing and timing out.
2034
2035         This change is a temporary fix to make the bots happy while I
2036         look into more profiling and other fixes.
2037
2038         * Scripts/webkitpy/layout_tests/port/mac.py:
2039         (ChromiumMacPort.default_child_processes):
2040
2041         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2042         (ChromiumMacPort.default_child_processes):
2043
2044 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2045
2046         WebKitTestRunner's EventSender is leaky
2047         https://bugs.webkit.org/show_bug.cgi?id=83099
2048
2049         Reviewed by Beth Dakin.
2050         
2051         Fix leaks of WKNumbers by using the adoptWK idiom, and make
2052         all the code consistent.
2053
2054         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2055         (WTR::EventSendingController::mouseDown):
2056         (WTR::EventSendingController::mouseUp):
2057         (WTR::EventSendingController::mouseMoveTo):
2058         (WTR::EventSendingController::leapForward):
2059         (WTR::EventSendingController::keyDown):
2060         (WTR::EventSendingController::mouseScrollBy):
2061         (WTR::EventSendingController::addTouchPoint):
2062         (WTR::EventSendingController::updateTouchPoint):
2063         (WTR::EventSendingController::setTouchModifier):
2064         (WTR::EventSendingController::releaseTouchPoint):
2065         (WTR::EventSendingController::cancelTouchPoint):
2066
2067 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2068
2069         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
2070
2071         * Scripts/run-webkit-tests:
2072         (useNewRunWebKitTests):
2073
2074 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2075
2076         kill-old-processes should kill apache2 and httpd
2077         https://bugs.webkit.org/show_bug.cgi?id=83065
2078
2079         Reviewed by Tony Chang.
2080
2081         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
2082
2083         * BuildSlaveSupport/kill-old-processes:
2084
2085 2012-04-03  Tony Chang  <tony@chromium.org>
2086
2087         run the same test steps on test only bots as on build-and-test bots
2088         https://bugs.webkit.org/show_bug.cgi?id=83090
2089
2090         Reviewed by Ryosuke Niwa.
2091
2092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2093         (TestFactory.__init__):
2094
2095 2012-04-03  Ami Fischman  <fischman@chromium.org>
2096
2097         Add a Media watchlist.
2098         https://bugs.webkit.org/show_bug.cgi?id=83071
2099
2100         Reviewed by David Levin.
2101
2102         * Scripts/webkitpy/common/config/watchlist:
2103
2104 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
2105
2106         Fix large leak in WebKitTestRunner
2107         https://bugs.webkit.org/show_bug.cgi?id=83084
2108
2109         Reviewed by Beth Dakin.
2110         
2111         Fix a leak of the bimap backing store created when doing pixel and
2112         ref tests. This leak was causing serious thrash on the test bots.
2113         
2114         We don't need to allocate memory for CGBitmapContextCreate(); if we
2115         pass NULL, it will allocate and manage its own backing store.
2116
2117         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2118         (WTR::createCGContextFromImage):
2119
2120 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2121
2122         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
2123
2124         * BuildSlaveSupport/built-product-archive:
2125         (unzipArchive):
2126
2127 2012-04-03  Ojan Vafai  <ojan@chromium.org>
2128
2129         Give more human friendly error message when builders fail to load or have stale data.
2130         https://bugs.webkit.org/show_bug.cgi?id=83058
2131
2132         Reviewed by Eric Seidel.
2133
2134         * TestResultServer/static-dashboards/dashboard_base.js:
2135         (addError):
2136         (addBuilderLoadErrors):
2137         (handleLocationChange):
2138         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2139
2140 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2141
2142         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
2143
2144         * BuildSlaveSupport/built-product-archive:
2145         (extractBuiltProduct):
2146
2147 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2148
2149         Yet another build fix after r113067. Don't trigger Chromium testers right away
2150         since they're now triggered by builders.
2151
2152         * BuildSlaveSupport/build.webkit.org-config/config.json:
2153
2154 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2155
2156         Another build fix after r113067 for Mac port.
2157         It turned out that archiving the entire build directory doesn't work.
2158
2159         * BuildSlaveSupport/built-product-archive:
2160         (createZipManually):
2161         (createZip):
2162         (archiveBuiltProduct):
2163
2164 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
2165
2166         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
2167         https://bugs.webkit.org/show_bug.cgi?id=82643
2168
2169         Update LayoutTestController to accomodate the new find API.
2170         It now provides caseSensitive functionality to DRT.
2171
2172         Internal Review by Andy Chen.
2173
2174         Reviewed by Rob Buis.
2175
2176         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2177         (LayoutTestController::findString):
2178
2179 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2180
2181         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
2182         because download-built-product creates the build directory as needed.
2183
2184         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
2185
2186         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2187         (TestFactory.__init__):
2188
2189 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
2190
2191         Build fix after r113067. Don't delete the build directory.
2192
2193         * BuildSlaveSupport/built-product-archive:
2194         (extractBuiltProduct):
2195
2196 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2197
2198         Load all builder lists from the buildbot json
2199         https://bugs.webkit.org/show_bug.cgi?id=82998
2200
2201         Reviewed by Adam Barth.
2202
2203         Also, remove an unnecessary list of test types. Now we don't hard-code
2204         builder names anywhere and we only have a single hard-coded list of
2205         test types.
2206
2207         * TestResultServer/static-dashboards/builders.js:
2208         (BuilderMaster.prototype.logPath):
2209         (BuilderMaster.prototype.builderJsonPath):
2210         (requestBuilderList.xhr.onload):
2211         (requestBuilderList.xhr.onerror):
2212         (isChromiumDepsFyiGpuTestRunner):
2213         (isChromiumTipOfTreeGpuTestRunner):
2214         (isChromiumDepsGTestRunner):
2215         (isChromiumDepsCrosGTestRunner):
2216         (isChromiumTipOfTreeGTestRunner):
2217         (onBuilderListLoad):
2218         (loadBuildersList):
2219         * TestResultServer/static-dashboards/dashboard_base.js:
2220         (parseCrossDashboardParameters):
2221         (currentBuilderGroupCategory):
2222         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2223         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2224         (testHtmlForTestsWithExpectationsButNoFailures):
2225         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
2226         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
2227         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
2228         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
2229         * TestResultServer/static-dashboards/timeline_explorer.html:
2230
2231 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2232
2233         Chromium testers should extract builds instead of building on their own
2234         https://bugs.webkit.org/show_bug.cgi?id=82996
2235
2236         Reviewed by Tony Chang.
2237
2238         Make Chromium builders triggger Chromium testers and make testers download and extract builds
2239         from the buildbot master instead of building binaries on their own.
2240
2241         Add download-built-product to wrap curl used in the download-built-product step since Windows
2242         does not provide "curl" natively.
2243
2244         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
2245         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
2246         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2247         (DownloadBuiltProduct): Call download-built-product instead of curl.
2248         * BuildSlaveSupport/built-product-archive:
2249         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
2250         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
2251         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
2252         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
2253         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
2254         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
2255
2256 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
2257
2258         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
2259         https://bugs.webkit.org/show_bug.cgi?id=82473
2260
2261         Reviewed by Philippe Normand.
2262
2263         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
2264         was ever run.
2265
2266         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
2267         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
2268
2269 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2270
2271         [EFL] DRT support for setInteractiveFormValidationEnabled
2272         https://bugs.webkit.org/show_bug.cgi?id=82050
2273
2274         Enable interactive form validation and unskip tests from the
2275         skip list.
2276
2277         Reviewed by Antonio Gomes.
2278
2279         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2280         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2281
2282 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2283
2284         Unreviewed, another test-webkitpy fix-up after r113037.
2285
2286         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
2287         crash dump depending on current environment.
2288
2289 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2290
2291         Unreviewed, test-webkitpy build fix after r113037.
2292
2293         * Scripts/webkitpy/layout_tests/port/gtk.py:
2294         (GtkPort._get_crash_log):
2295
2296 2012-04-03  Philippe Normand  <pnormand@igalia.com>
2297
2298         [GTK] crash log reports support
2299         https://bugs.webkit.org/show_bug.cgi?id=81659
2300
2301         Reviewed by Martin Robinson.
2302
2303         Removed the daemontools crashmon/xvfb scripts and implemented the crash
2304         log reporting in the NRWT Gtk port. To get proper crash logs one
2305         needs to set the core pattern like this:
2306         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
2307         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
2308         environment variable.
2309
2310         * BuildSlaveSupport/gtk/README:
2311         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
2312         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
2313         * BuildSlaveSupport/gtk/crashmon/run: Removed.
2314         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2315         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
2316         * BuildSlaveSupport/gtk/xvfb/run: Removed.
2317         * Scripts/new-run-webkit-tests:
2318         * Scripts/webkitpy/layout_tests/port/gtk.py:
2319         (GtkDriver.stop):
2320         (GtkPort.show_results_html_file):
2321         (GtkPort):
2322         (GtkPort._get_gdb_output):
2323         (GtkPort._get_crash_log):
2324         (GtkPort._get_crash_log.match_filename):
2325         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2326         (GtkPortTest):
2327         (test_show_results_html_file):
2328         (assertLinesEqual):
2329         (_mock_gdb_output):
2330         (test_get_crash_log):
2331
2332 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2333
2334         Enable and connect the WebInspectorServer with WebKit2 pages.
2335         https://bugs.webkit.org/show_bug.cgi?id=73094
2336
2337         Reviewed by Simon Hausmann.
2338
2339         Enable developer extras on pages in MiniBrowser for Qt.
2340
2341         * MiniBrowser/qt/qml/BrowserWindow.qml:
2342
2343 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
2344
2345         [EFL] LayoutTestController needs implementation of setDefersLoading
2346         https://bugs.webkit.org/show_bug.cgi?id=82890
2347
2348         Reviewed by Philippe Normand.
2349
2350         Implement setDefersLoading() in EFL's LayoutTestController so that the
2351         corresponding test case can be removed from the skip list.
2352
2353         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2354         (LayoutTestController::setDefersLoading):
2355
2356 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
2357
2358         [EFL] LayoutTestController needs implementation of goBack
2359         https://bugs.webkit.org/show_bug.cgi?id=81914
2360
2361         Reviewed by Philippe Normand.
2362
2363         Implement goBack() in EFL's LayoutTestController by calling
2364         ewk_frame_back().
2365
2366         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2367         (LayoutTestController::goBack):
2368
2369 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
2370
2371         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
2372         https://bugs.webkit.org/show_bug.cgi?id=82589
2373
2374         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
2375         in order to unskip printing/page-format-data.html
2376
2377         Reviewed by Philippe Normand.
2378
2379         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2380         (LayoutTestController::pageSizeAndMarginsInPixels):
2381
2382 2012-04-03  Simon Pena  <spena@igalia.com>
2383
2384         [GTK] DRT missing didRunInsecureContent notification
2385         https://bugs.webkit.org/show_bug.cgi?id=59367
2386
2387         Reviewed by Philippe Normand.
2388
2389         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
2390         the main WebFrame or any other WebFrame created later. Added
2391         "didRunInsecureContent" notification in the callback in order to
2392         get the LayoutTests passing.
2393
2394         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
2395         to WebFrame's "insecure-content-run" signal and add
2396         didRunInsecureContent notification in the callback to get the
2397         LayoutTests passing.
2398         (didRunInsecureContent):
2399         (createWebView):
2400
2401 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2402
2403         rebaseline-server: Make it possible to not launch a browser with the server.
2404         https://bugs.webkit.org/show_bug.cgi?id=82999
2405
2406         Reviewed by Adam Barth.
2407
2408         Add the `--no-show-results' option, which lets one decide not to
2409         launch a web browser when running the rebaseline server.  This is
2410         especially useful if the default browser is not the wanted one, or
2411         if the rebaseline server page is already open.
2412
2413         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
2414         (AbstractLocalServerCommand.__init__):
2415         (AbstractLocalServerCommand.execute):
2416
2417 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2418
2419         EFL's LayoutTestController disableImageLoading implementation.
2420         https://bugs.webkit.org/show_bug.cgi?id=82848
2421
2422         Reviewed by Hajime Morita.
2423
2424         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2425         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2426         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2427         (LayoutTestController::disableImageLoading):
2428
2429 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
2430
2431         [EFL] LayoutTestController needs implementation of isPageBoxVisible
2432         https://bugs.webkit.org/show_bug.cgi?id=82591
2433
2434         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
2435         in order to unskip printing/page-format-data.html
2436
2437         Reviewed by Hajime Morita.
2438
2439         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2440         (LayoutTestController::isPageBoxVisible):
2441
2442 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
2443
2444         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
2445         https://bugs.webkit.org/show_bug.cgi?id=82962
2446
2447         Reviewed by Dirk Pranke.
2448
2449         Ensure that _build_path() returns an absolute path.
2450
2451         Eric Seidel also had to deploy MockConfig in a bunch of places
2452         in order to correct previous testing errors where we were
2453         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
2454         was a real path.  The real Config object calls run_command("webkit-build-directory")
2455         to read the WebKit build directory from the webkitdirs.pm perl code.
2456         MockConfig abstracts this away and always returns "/mock-build" during
2457         testing.  This change is much larger than one would think necessary
2458         because of needing to deploy this MockConfig class.
2459
2460         * Scripts/webkitpy/layout_tests/port/webkit.py:
2461         (WebKitPort._build_path):
2462
2463 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2464
2465         Fix snafu in r112971. We were never calling parseParameter for builder.
2466
2467         * TestResultServer/static-dashboards/dashboard_base.js:
2468
2469 2012-04-02  Ojan Vafai  <ojan@chromium.org>
2470
2471         Generate the lists of all layout test builders from the buildbot json
2472         https://bugs.webkit.org/show_bug.cgi?id=82924
2473
2474         Reviewed by Mihai Parparita.
2475
2476         In order to make this work, cleaned up a lot of existing technical debt.
2477         -Got rid of expectations builder. This concept is outdated and just dead code.
2478         -Split hash parameter parsing into two functions. One for dashboard_base
2479         (crossDashboardParameters) and one for the specific dashboard html file
2480         (dashboardSpecificParameters). In the old world, parseParameters needed to
2481         be called twice and depended on it's own output the first time through.
2482         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
2483         doesn't depend on the output of crossDashboardParameters.
2484         -Lots of variable/method renames due to the above.
2485         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
2486         for that dashboard.
2487
2488         * TestResultServer/static-dashboards/aggregate_results.html:
2489         * TestResultServer/static-dashboards/builders.js:
2490         (BuilderGroup):
2491         (BuilderGroup.prototype.setup):
2492         (jsonRequest.xhr.onload):
2493         (jsonRequest.xhr.onerror):
2494         (isWebkitTestRunner):
2495         (isChromiumWebkitTipOfTreeTestRunner):
2496         (isChromiumWebkitDepsTestRunner):
2497         (generateBuildersFromBuilderList):
2498         (onLayoutTestBuilderListLoad):
2499         (onErrorLoadingBuilderList):
2500         (loadBuildersList):
2501         * TestResultServer/static-dashboards/dashboard_base.js:
2502         (handleValidHashParameterWrapper):
2503         (queryHashAsMap):
2504         (parseParameter):
2505         (parseCrossDashboardParameters):
2506         (parseDashboardSpecificParameters):
2507         (parseParameters):
2508         (diffStates):
2509         (defaultValue):
2510         (isLayoutTestResults):
2511         (isGPUTestResults):
2512         (currentBuilderGroupCategory):
2513         (currentBuilderGroup):
2514         (initBuilders):
2515         Now that we've split parameter parseing, these methods no longer need
2516         to take an optional state. They can always just use the global cross-dashboard state.
2517
2518         (pathToBuilderResultsFile):
2519         (appendJSONScriptElementFor):
2520         (appendJSONScriptElements):
2521         (handleResourceLoadError):
2522         (haveJsonFilesLoaded):
2523         (combinedDashboardState):
2524         (setQueryParameter):
2525         (permaLinkURLHash):
2526         (toggleQueryParameter):
2527         (queryParameterValue):
2528         (selectHTML):
2529         (htmlForTestTypeSwitcher):
2530         (g_handleBuildersListLoaded):
2531         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2532         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2533         (testPlatformAndBuildType):
2534         (testSubstringList):
2535         (testHtmlForTestTypeSwitcherGroup):
2536         (testLookupVirtualTestSuite):
2537         (testBaseTest):
2538         (generateBuildersFromBuilderListHelper):
2539         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
2540         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
2541         (assertObjectsDeepEqual):
2542         (testQueryHashAsMap):
2543         (testDiffStates):
2544         * TestResultServer/static-dashboards/timeline_explorer.html:
2545         * TestResultServer/static-dashboards/treemap.html:
2546
2547 2012-04-02  Tony Chang  <tony@chromium.org>
2548
2549         check-webkit-style errors when removing .png files
2550         https://bugs.webkit.org/show_bug.cgi?id=82933
2551
2552         Reviewed by David Levin.
2553
2554         * Scripts/webkitpy/style/patchreader.py:
2555         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
2556         * Scripts/webkitpy/style/patchreader_unittest.py:
2557         (test_check_patch_with_png_deletion):
2558
2559 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2560
2561         Unreviewed, rolling out r112948.
2562         http://trac.webkit.org/changeset/112948
2563         https://bugs.webkit.org/show_bug.cgi?id=82961
2564
2565         Someone else already checked in a similar change (Requested by
2566         sundiamonde on #webkit).
2567
2568         * Scripts/webkitpy/layout_tests/port/webkit.py:
2569         (WebKitDriver._start):
2570
2571 2012-04-02  Adam Barth  <abarth@webkit.org>
2572
2573         garden-o-matic isn't able to rebaseline audio failures
2574         https://bugs.webkit.org/show_bug.cgi?id=82957
2575
2576         Reviewed by Chris Rogers.
2577
2578         This patch just adds "wav" to the list of test suffixes and updates the
2579         unit tests to show that we're rebaselining audio tests results now too.
2580
2581         * Scripts/webkitpy/tool/commands/rebaseline.py:
2582         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2583         (test_rebaseline_updates_expectations_file):
2584
2585 2012-04-02  Adam Barth  <abarth@webkit.org>
2586
2587         garden-o-matic should let you listen to audio failures
2588         https://bugs.webkit.org/show_bug.cgi?id=82953
2589
2590         Reviewed by Chris Rogers.
2591
2592         Now that we've actually got an audio failure on the bots, we can clean
2593         up the last stray bugs.  This patch doesn't have any tests because I'm
2594         lame.
2595
2596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2599         (.):
2600
2601 2012-04-02  Stephanie Lewis  <slewis@apple.com>
2602
2603         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
2604         https://bugs.webkit.org/show_bug.cgi?id=82552
2605
2606         Reviewed by Dirk Pranke.
2607
2608         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
2609
2610         * Scripts/webkitpy/layout_tests/port/webkit.py:
2611         (WebKitDriver._start):
2612
2613 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
2614
2615         NRWT is not printing out the builder it's uploading JSON files for
2616         https://bugs.webkit.org/show_bug.cgi?id=82834
2617
2618         Reviewed by Ojan Vafai.
2619
2620         Handle log messages of the form log.info("%s", arg) properly ...
2621         I didn't even know you could do that :).
2622
2623         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2624         (_LogHandler.emit):
2625         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2626         (RegularTest.test_log_args):
2627         (VerboseTest.test_log_args):
2628
2629 2012-04-02  Tim Horton  <timothy_horton@apple.com>
2630
2631         [mac] LayoutTestHelper crashes if there is no main display
2632         https://bugs.webkit.org/show_bug.cgi?id=82944
2633         <rdar://problem/11162954>
2634
2635         Reviewed by Simon Fraser.
2636
2637         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
2638         a null dictionary, so we shouldn't go ahead and try to read from it.
2639
2640         * DumpRenderTree/mac/LayoutTestHelper.m:
2641         (installLayoutTestColorProfile):
2642
2643 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2644
2645         [Qt][WK2] Set up plugin process on Unix
2646         https://bugs.webkit.org/show_bug.cgi?id=72121
2647
2648         Reviewed by Simon Hausmann.
2649
2650         * qmake/mkspecs/features/features.prf: Reenable plugins
2651         and turn on plugin process.
2652
2653 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2654
2655         Unreviewed, rolling out r112868, r112879, and r112881.
2656         http://trac.webkit.org/changeset/112868
2657         http://trac.webkit.org/changeset/112879
2658         http://trac.webkit.org/changeset/112881
2659         https://bugs.webkit.org/show_bug.cgi?id=82901
2660
2661         "Build fail on bots." (Requested by kbalazs on #webkit).
2662
2663         * MiniBrowser/gtk/GNUmakefile.am:
2664         * qmake/mkspecs/features/features.prf:
2665
2666 2012-04-02  Philippe Normand  <pnormand@igalia.com>
2667
2668         [GTK] Enable shadow-dom in build-webkit.
2669
2670         Rubber-stamped by Gustavo Noronha Silva.
2671
2672         * Scripts/build-webkit: Enable shadow-dom build, this is need to
2673         have a working build currently.
2674
2675 2012-04-02  Andreas Kling  <kling@webkit.org>
2676
2677         Adding Zalan Bujtas to committers list.
2678
2679         * Scripts/webkitpy/common/config/committers.py:
2680
2681 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
2682
2683         [Qt][WK2] Set up plugin process on Unix
2684         https://bugs.webkit.org/show_bug.cgi?id=72121
2685
2686         Reviewed by Simon Hausmann.
2687
2688         * qmake/mkspecs/features/features.prf: Reenable plugins
2689         and turn on plugin process.
2690
2691 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2692
2693         Unreviewed, rolling out r112651.
2694         http://trac.webkit.org/changeset/112651
2695         https://bugs.webkit.org/show_bug.cgi?id=82887
2696
2697         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
2698
2699         * MiniBrowser/qt/BrowserWindow.cpp:
2700         (BrowserWindow::updateVisualMockTouchPoints):
2701         * MiniBrowser/qt/main.cpp:
2702         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2703         (WTR::WrapperWindow::handleStatusChanged):
2704         * qmake/mkspecs/features/unix/default_post.prf:
2705
2706 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2707
2708         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
2709         https://bugs.webkit.org/show_bug.cgi?id=82877
2710
2711         Reviewed by Philippe Normand.
2712
2713         * Scripts/run-gtk-tests:
2714         (TestRunner.run_tests): Use replace instead of lstrip to remove
2715         the programs_path from the full path of unit tests.
2716
2717 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2718
2719         Unreviewed. Skip flaky unit tests.
2720
2721         * Scripts/run-gtk-tests:
2722         (TestRunner):
2723
2724 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
2725
2726         webkitpy rebaseline.
2727
2728         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2729         (test_run_test_set_with_json_output):
2730         (test_run_test_set_with_json_source):
2731
2732 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
2733
2734         perf-o-matic should store test results' units
2735         https://bugs.webkit.org/show_bug.cgi?id=82852
2736
2737         Reviewed by Kentaro Hara.
2738
2739         Include units in the results JSON.
2740
2741         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2742         (PerfTestsRunner._process_chromium_style_test_result):
2743         (PerfTestsRunner._process_parser_test_result):
2744
2745 2012-04-01  Tony Tseung  <tseung@apple.com>
2746
2747         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
2748         composite fonts from existing physical fonts.
2749         <rdar://problem/10717370>
2750         https://bugs.webkit.org/show_bug.cgi?id=82810
2751             
2752         A new test font of this kind as been added to the test tools for running the webkit-tests
2753
2754         Reviewed by Dan Bernstein.
2755
2756         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2757         Added new dependency SampleFont.sfont
2758         
2759         * DumpRenderTree/fonts/SampleFont.sfont: Added.
2760         
2761         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2762         * DumpRenderTree/mac/DumpRenderTree.mm:
2763         (allowedFontFamilySet):
2764         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2765         
2766         (activateTestingFonts):
2767         Added the registration of the Composite Font Referene sample font
2768         
2769         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2770         (WTR::allowedFontFamilySet):
2771         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
2772
2773         (WTR::activateFonts):
2774         Added the registration of the Composite Font Referene sample font
2775
2776         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2777         Added new dependency SampleFont.sfont
2778
2779         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
2780
2781 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2782
2783         Support the Network Information API
2784         https://bugs.webkit.org/show_bug.cgi?id=73528
2785
2786         Reviewed by Adam Barth.
2787
2788         Add network information API feature to build script.
2789
2790         * Scripts/build-webkit:
2791
2792 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2793
2794         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
2795         https://bugs.webkit.org/show_bug.cgi?id=82839
2796
2797         Reviewed by Adam Barth.
2798
2799         Also, update various hard-coded lists for WIN7 and Lion ports.
2800         This is necessary since the new list of builders grabbed off the
2801         buildbot includes Lion.
2802
2803         * TestResultServer/static-dashboards/builders.js:
2804         (generateWebkitBuildersFromBuilderList):
2805         (xhr.onreadystatechange):
2806         Don't use dashboard_base's request method to avoid layering violation.
2807
2808         * TestResultServer/static-dashboards/dashboard_base.js:
2809         (parseParameters):
2810         (initBuilders):
2811         (haveJsonFilesLoaded):
2812         (g_handleBuildersListLoaded):
2813         Block loading the JSON files for each builder until we actually have a list of builders.
2814
2815         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2816         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2817         (testPlatformAndBuildType):
2818         (testGenerateWebkitBuildersFromBuilderList):
2819         * TestResultServer/static-dashboards/timeline_explorer.html:
2820         * TestResultServer/static-dashboards/treemap.html:
2821         Delay generating the page until the builder list has loaded.
2822
2823 2012-03-31  Ojan Vafai  <ojan@chromium.org>
2824
2825         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
2826         https://bugs.webkit.org/show_bug.cgi?id=82799
2827
2828         Reviewed by Eric Seidel.
2829
2830         If we don't run a test, mark it as skipped.
2831
2832         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2833         (Manager._mark_interrupted_tests_as_skipped):
2834         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
2835         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2836         (ManagerTest.test_interrupt_if_at_failure_limits):
2837
2838 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2839
2840         One more build fix after r112781 for Chromium Windows.
2841         Don't copy zip .idb files.
2842
2843         * BuildSlaveSupport/built-product-archive:
2844         (copyBuildFiles):
2845
2846 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2847
2848         Yet another build fix after r112781 for Chromium Windows.
2849         Run webkit-build-directory by perl explicitly.
2850
2851         * BuildSlaveSupport/built-product-archive:
2852         (determineWebKitBuildDirectory):
2853
2854 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2855
2856         Fix the syntax error in master.cfg after r112734.
2857
2858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2859         (unitTestsSupported):
2860
2861 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2862
2863         Another build fix after r112781.
2864
2865         * BuildSlaveSupport/built-product-archive:
2866         (createZip):
2867
2868 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
2869
2870         Build fix after r112781.
2871
2872         * BuildSlaveSupport/built-product-archive:
2873         (createZipManually):
2874         (createZip):
2875
2876 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
2877
2878         Chromium bots should upload archived built files
2879         https://bugs.webkit.org/show_bug.cgi?id=82666
2880
2881         Reviewed by Tony Chang.
2882
2883         * BuildSlaveSupport/build.webkit.org-config/config.json:
2884         * BuildSlaveSupport/built-product-archive:
2885         (main):
2886         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
2887         call out to webkit-build-directory.
2888         (removeDirectoryIfExists): Extracted.
2889         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
2890         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
2891         (createZipManually.addToArchive):
2892         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
2893         (archiveBuiltProduct): Add support for Chromium port.
2894         * Scripts/webkit-build-directory: Add support for --platform options.
2895
2896 2012-03-30  Dan Bernstein  <mitz@apple.com>
2897
2898         Reverted r112767, because it caused many vertical text tests to fail.
2899
2900         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2901         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
2902         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2903         * DumpRenderTree/mac/DumpRenderTree.mm:
2904         (allowedFontFamilySet):
2905         (activateTestingFonts):
2906         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2907         (WTR::allowedFontFamilySet):
2908         (WTR::activateFonts):
2909         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2910         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
2911
2912 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
2913
2914         [wx] Move wxWebKit API into WebKit namespace.
2915         https://bugs.webkit.org/show_bug.cgi?id=82740
2916
2917         Reviewed by Kevin Ollivier.
2918
2919         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2920         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
2921         (LayoutWebViewEventHandler::bindEvents):
2922         (LayoutWebViewEventHandler::OnLoadEvent):
2923         (LayoutWebViewEventHandler::OnAlertEvent):
2924         (LayoutWebViewEventHandler::OnConfirmEvent):
2925         (LayoutWebViewEventHandler::OnPromptEvent):
2926         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
2927         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
2928         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
2929         (LayoutWebViewEventHandler):
2930         (dumpFramesAsText):
2931         (dump):
2932         (MyApp::OnInit):
2933         * wx/browser/browser.cpp:
2934         (MyApp::OnInit):
2935
2936 2012-03-30  Eli Fidler  <efidler@rim.com>
2937
2938         Enable OpenType Sanitizer for BlackBerry port.
2939         https://bugs.webkit.org/show_bug.cgi?id=82782
2940
2941         Reviewed by Eric Seidel.
2942
2943         * Scripts/webkitdirs.pm:
2944         (blackberryCMakeArguments): add OTS to include path
2945
2946 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2947
2948         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
2949         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
2950         is found.
2951
2952         <rdar://problem/11158581>
2953         
2954         Reviewed by Mark Rowe.
2955
2956         * Scripts/webkitpy/layout_tests/port/webkit.py:
2957         (WebKitDriver._start):
2958
2959 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
2960
2961         Disable run-api-tests on release mac builds
2962         https://bugs.webkit.org/show_bug.cgi?id=82788
2963
2964         Reviewed by Ryosuke Niwa.
2965         
2966         TestWebKitAPI crashes every time in release builds currently
2967         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
2968         run-api-tests on mac release builders.
2969
2970         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2971         (unitTestsSupported):
2972
2973 2012-03-30  Chang Shu  <cshu@webkit.org>
2974
2975         Unreviewed. Update my email.
2976
2977         * Scripts/webkitpy/common/config/committers.py:
2978
2979 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
2980
2981         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
2982         https://bugs.webkit.org/show_bug.cgi?id=82745
2983
2984         Reviewed by Simon Fraser.
2985
2986         * DumpRenderTree/AccessibilityUIElement.cpp:
2987         (rangeForPositionCallback):
2988         (AccessibilityUIElement::rangeForPosition):
2989         (AccessibilityUIElement::getJSClass):
2990         * DumpRenderTree/AccessibilityUIElement.h:
2991         (AccessibilityUIElement):
2992         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2993         (AccessibilityUIElement::rangeForPosition):
2994         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2995         (WTR::AccessibilityUIElement::rangeForPosition):
2996         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2997         (AccessibilityUIElement):
2998         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2999         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3000         (WTR::AccessibilityUIElement::rangeForPosition):
3001         (WTR):
3002
3003 2012-03-30  David Barr  <davidbarr@chromium.org>
3004
3005         Split up top-level .gitignore and .gitattributes
3006         https://bugs.webkit.org/show_bug.cgi?id=82687
3007
3008         Reviewed by Tor Arne Vestbø.
3009
3010         * .gitattributes: Added.
3011         * .gitignore: Added.
3012         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
3013         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
3014
3015 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
3016
3017         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
3018
3019         * TestResultServer/static-dashboards/builders.js:
3020
3021 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
3022
3023         Update ChromiumOS bot names in builders.js to reflect changes made by
3024         http://crrev.com/129835
3025         
3026         Also removes the ChromiumOS GTK builder, which was removed by
3027         http://crrev.com/129835
3028
3029         * TestResultServer/static-dashboards/builders.js:
3030
3031 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
3032
3033         [GTK] Disable introspection build in the at-spi2-core module.
3034         https://bugs.webkit.org/show_bug.cgi?id=82729
3035
3036         Reviewed by Philippe Normand.
3037
3038         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
3039
3040         * gtk/jhbuild.modules: Disable introspection.
3041
3042 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
3043
3044         Add a "preview" state to Page Visibility API implementation
3045         https://bugs.webkit.org/show_bug.cgi?id=81355
3046
3047         Reviewed by Adam Barth.
3048
3049         Updating the Page Visibility API implementation to the current spec version.
3050
3051         * DumpRenderTree/chromium/LayoutTestController.cpp:
3052         (LayoutTestController::setPageVisibility):
3053
3054 2012-03-30  Keishi Hattori  <keishi@webkit.org>
3055
3056         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
3057         https://bugs.webkit.org/show_bug.cgi?id=80972
3058
3059         Reviewed by Kent Tamura.
3060
3061         * Scripts/build-webkit:
3062         * qmake/mkspecs/features/features.prf:
3063
3064 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
3065
3066         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
3067         https://bugs.webkit.org/show_bug.cgi?id=82195
3068
3069         Reviewed by Simon Hausmann.
3070
3071         * MiniBrowser/qt/BrowserWindow.cpp:
3072         (BrowserWindow::updateVisualMockTouchPoints):
3073         * MiniBrowser/qt/main.cpp:
3074         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3075         (WTR::WrapperWindow::handleStatusChanged):
3076         * qmake/mkspecs/features/unix/default_post.prf:
3077
3078 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3079
3080         [EFL] Implement LayoutTestController::setMinimumTimerInterval
3081         https://bugs.webkit.org/show_bug.cgi?id=81220
3082
3083         Add missing implementation setMinimumTimerInterval to EFL's
3084         LayoutTestController so that we can unskip related tests from the skip list.
3085
3086         Reviewed by Philippe Normand.
3087
3088         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3089         (LayoutTestController::setMinimumTimerInterval):
3090
3091 2012-03-29  Dan Bernstein  <mitz@apple.com>
3092
3093         Removed “Intel” from the Lion builders’ names.
3094
3095         Rubber-stamped by Mark Rowe.
3096
3097         * BuildSlaveSupport/build.webkit.org-config/config.json:
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3099         (LeaksViewer._displayURLPrompt):
3100
3101 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
3102
3103         [Chromium] Add sharded ChromiumOS debug bots to builders.js
3104         https://bugs.webkit.org/show_bug.cgi?id=82639
3105
3106         Reviewed by Eric Seidel.
3107
3108         The bots were sharded by http://crrev.com/129613, update builders.js
3109         to reflect this.
3110
3111         * TestResultServer/static-dashboards/builders.js:
3112
3113 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3114
3115         remove support for junit-style xml output from test-webkitpy
3116         https://bugs.webkit.org/show_bug.cgi?id=82279
3117
3118         Reviewed by Eric Seidel.
3119
3120         This was added when we were looking into integrating w/ Jenkins
3121         rather than buildbot, but I believe that project got shelved, so
3122         this is unused. We can always add it back in later as necessary.
3123
3124         * Scripts/webkitpy/test/main.py:
3125         (Tester._parse_args):
3126         (Tester._run_tests):
3127         * Scritps/webkitpy/thirdparty/__init__.py:
3128
3129 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3130
3131         new-run-webkit-tests: crashes when it fails to decode a stack trace
3132         https://bugs.webkit.org/show_bug.cgi?id=82673
3133
3134         Unreviewed, build fix.
3135
3136         We are assuming the stdout/stderr output from the driver is utf-8
3137         encoded when we get stack traces; this may not be a valid
3138         assumption generally, but if we do get strings that aren't valid
3139         utf-8, we would crash. Now we will ignore any decoding errors.
3140
3141         * Scripts/webkitpy/layout_tests/port/base.py:
3142         (Port._get_crash_log):
3143         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3144         (PortTestCase.test_get_crash_log):
3145
3146 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
3147
3148         Scripts fail to detect when a tool crashes
3149         https://bugs.webkit.org/show_bug.cgi?id=82659
3150
3151         Reviewed by Mark Rowe.
3152         
3153         Have exitStatus() detect when the process fail to exit cleanly
3154         (possibly because of a crash), and return a non-zero exit code
3155         in that case.
3156
3157         * Scripts/VCSUtils.pm:
3158         (exitStatus):
3159
3160 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3161
3162         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
3163         https://bugs.webkit.org/show_bug.cgi?id=82581
3164
3165         Reviewed by Martin Robinson.
3166
3167         Running Javascriptcore tests through jhbuild
3168         for consistency with run-webkit-tests and in order to
3169         avoid confusing libraries when facing regressions.
3170
3171         * Scripts/run-javascriptcore-tests:
3172
3173 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
3174
3175         test-webkitpy: add --timing
3176         https://bugs.webkit.org/show_bug.cgi?id=82550
3177
3178         Reviewed by Eric Seidel.
3179
3180         This patch adds a --timing option that will display the time
3181         each test takes. It also removes the --silent option, since
3182         probably no one ever used it, and cleans up the logging
3183         option parsing code to be easier to follow.
3184
3185         * Scripts/webkitpy/test/main.py:
3186         (Tester._parse_args):
3187         (Tester._configure):
3188         * Scripts/webkitpy/test/runner.py:
3189         (TestRunner.write_result):
3190         * Scripts/webkitpy/test/runner_unittest.py:
3191         (RunnerTest.test_regular):
3192         (RunnerTest.test_verbose):
3193         (RunnerTest):
3194         (RunnerTest.test_timing):
3195
3196 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3197
3198         HashMap<>::add should return a more descriptive object
3199         https://bugs.webkit.org/show_bug.cgi?id=71063
3200
3201         Reviewed by Ryosuke Niwa.
3202
3203         Update code to use AddResult instead of a pair.
3204
3205         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3206         (LayoutTestController::evaluateScriptInIsolatedWorld):
3207         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3208         (LayoutTestController::evaluateScriptInIsolatedWorld):
3209         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3210         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
3211
3212 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
3213
3214         Web Inspector: chromium: DRT --no-timeout option doesn't work.
3215         https://bugs.webkit.org/show_bug.cgi?id=82608
3216
3217         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
3218         This was broken by r112354 and the sequence became opposite.
3219
3220         Reviewed by Yury Semikhatsky.
3221
3222         * DumpRenderTree/chromium/TestShell.cpp:
3223         (TestShell::TestShell):
3224         (TestShell::initialize):
3225
3226 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
3227
3228         Remove custom bindings form Internals.idl of attribute type Array.
3229         https://bugs.webkit.org/show_bug.cgi?id=82319
3230
3231         Reviewed by Kentaro Hara.
3232
3233         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
3234
3235         * GNUmakefile.am:
3236
3237 2012-03-28  Mark Rowe  <mrowe@apple.com>
3238
3239         Fix --no-saved-state.
3240
3241         Ignore the flag before Lion, rather than making it specific to Lion.
3242
3243         Rubber-stamped by Dan Bernstein.
3244
3245         * Scripts/webkitdirs.pm:
3246         (argumentsForRunAndDebugMacWebKitApp):
3247
3248 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
3249
3250         Add dtharp to contributors list
3251         https://bugs.webkit.org/show_bug.cgi?id=82545
3252
3253         Reviewed by Adam Barth.
3254
3255         Adding dtharp as Contributor.
3256
3257         * Scripts/webkitpy/common/config/committers.py:
3258
3259 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
3260
3261         build-webkit : the word "pass" is spelled incorrectly as "passs"
3262         https://bugs.webkit.org/show_bug.cgi?id=82532
3263
3264         Reviewed by Julien Chaffraix.
3265
3266         Corrected spelling of the word "pass" in build-webkit.
3267
3268         * Scripts/build-webkit:
3269
3270 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3271
3272         new-run-webkit-tests doesn't log correctly after retrying failures
3273         https://bugs.webkit.org/show_bug.cgi?id=82541
3274
3275         Unreviewed, build fix.
3276
3277         r112189 introduced a regression where we would accidentally
3278         delete the log handler after we retried any failing tests - that
3279         meant that any log messages around uploading the results got
3280         dropped.
3281
3282         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3283         (Manager._run_tests):
3284
3285 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
3286
3287         [wx] Unreviewed. Build fix, move WTF back into JSCore target
3288         until issues with JSCore not linking in all WTF symbols are resolved.
3289
3290         * waf/build/settings.py:
3291
3292 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
3293
3294         download-built-product build step should detect 404 errors
3295         https://bugs.webkit.org/show_bug.cgi?id=82491
3296
3297         Reviewed by Ryosuke Niwa.
3298         
3299         Pass --fail to curl so that it reports 404 errors.
3300
3301         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3302         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
3303         * BuildSlaveSupport/built-product-archive:
3304         (extractBuiltProduct): Remove trailing whitespace.
3305
3306 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3307
3308         flakiness dashboard should only keep the last 500 runs
3309         https://bugs.webkit.org/show_bug.cgi?id=82530
3310
3311         Reviewed by Ojan Vafai.
3312
3313         If a bot has an overly large amount of failing tests, then
3314         storing 750 runs' worth takes a lot of memory and CPU time to
3315         process and we end up getting killed by AppEngine; this cases
3316         data corruption and confusion down the road when we have to
3317         retry the upload of the data and the tests show up as multiple
3318         runs.
3319
3320         * TestResultServer/model/jsonresults.py:
3321         (JsonResults.update_file):
3322
3323 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3324
3325         extract-built-product build step should fail if unzipping fails
3326         https://bugs.webkit.org/show_bug.cgi?id=82493
3327
3328         Reviewed by Simon Fraser.
3329
3330         Forward non-zero exit code from subprocesses so that the master can detect any failures
3331         and bail out early.
3332
3333         * BuildSlaveSupport/built-product-archive:
3334         (main):
3335
3336 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
3337
3338         test-webkitpy should support files, directories, and packages as command line args
3339         https://bugs.webkit.org/show_bug.cgi?id=76765
3340
3341         Reviewed by Adam Barth.
3342
3343         This patch adds support for specifying files, directories, and
3344         packages to test-webkitpy along with the already existing
3345         support for modules, test classes, and individual test names.
3346
3347         Also, fix a bug in filesystem_mock where we wouldn't normalize a
3348         path containing a reference to the current directory properly,
3349         for example, '/foo/./bar.py'.
3350
3351         * Scripts/webkitpy/common/system/filesystem_mock.py:
3352         (MockFileSystem.normpath):
3353         * Scripts/webkitpy/test/main.py:
3354         (Tester._configure_logging):
3355         (Tester._run_tests):
3356         * Scripts/webkitpy/test/test_finder.py:
3357         (TestDirectoryTree.find_modules):
3358         (TestDirectoryTree.subpath):
3359         (TestFinder.is_dotted_name):
3360         (TestFinder.find_names):
3361         (TestFinder):
3362         (TestFinder._find_names_for_arg):
3363         (TestFinder._find_in_trees):
3364         (TestFinder._default_names):
3365         * Scripts/webkitpy/test/test_finder_unittest.py:
3366         (TestFinderTest.setUp):
3367         (TestFinderTest.tearDown):
3368         (TestFinderTest.check_names):
3369         (TestFinderTest.test_default_names):
3370         (TestFinderTest):
3371         (TestFinderTest.test_paths):
3372
3373 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
3374
3375         Fix inspector tests when running in internal builds.
3376
3377         <rdar://problem/11050694>
3378
3379         Reviewed by Tim Hatcher.
3380
3381         * DumpRenderTree/mac/DumpRenderTree.mm:
3382         (resetDefaultsToConsistentValues):
3383         * WebKitTestRunner/TestController.cpp:
3384         (WTR::TestController::resetStateToConsistentValues):
3385
3386 2012-03-28  David Kilzer  <ddkilzer@apple.com>
3387
3388         Use xcrun to find nm and ranlib on OS X builds
3389         <http://webkit.org/b/82466>
3390
3391         Reviewed by Dan Bernstein.
3392
3393         * Scripts/build-webkit: Use xcrun to find ranlib.
3394         * Scripts/webkitdirs.pm:
3395         (determineNmPath): Added.  Use xcrun to find nm on OS X.
3396         (nmPath): Added.
3397         * Scripts/webkitperl/features.pm:
3398         (libraryContainsSymbol): Use nmPath().
3399
3400 2012-03-28  Ojan Vafai  <ojan@chromium.org>
3401
3402         Add history navigation to garden-o-matic
3403         https://bugs.webkit.org/show_bug.cgi?id=82495
3404
3405         Reviewed by Dimitri Glazkov.
3406
3407         Also, maintain scroll offsets when returning to a tab. This makes addressing
3408         expected failures considerably easier when dealing with below-the-fold tests.
3409
3410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3411         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
3412         switching.
3413         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
3414         from a file URL and Chrome puts each different file URL in it's own origin.
3415
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3417         Remove the href so that clicking on the accordion item does not modify window.location.hash.
3418
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3421
3422 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3423
3424         [GTK] generate-gtk-doc doesn't cope with custom build directory
3425         https://bugs.webkit.org/show_bug.cgi?id=82448
3426
3427         Reviewed by Martin Robinson.
3428
3429         Pass the product directory in generate-gtkdoc arguments from
3430         build-webkit.
3431
3432         * Scripts/webkitdirs.pm:
3433         (buildAutotoolsProject):
3434         * gtk/common.py:
3435         (get_build_path):
3436
3437 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3438
3439         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
3440         https://bugs.webkit.org/show_bug.cgi?id=82341
3441
3442         Reviewed by Martin Robinson.
3443
3444         Add --skipped=skip|ignore|only command line option.
3445
3446         * Scripts/run-gtk-tests:
3447         (TestRunner._test_cases_to_skip): Return the list of test cases
3448         to skip for the given test depending on the skipped action.
3449         (TestRunner._should_run_test): Decide whether to run the test or
3450         not depending on the skipped action.
3451         (TestRunner.run_tests): Only show the list of skipped tests when
3452         skipped action is 'skip'.
3453
3454 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3455
3456         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
3457         https://bugs.webkit.org/show_bug.cgi?id=82333
3458
3459         Reviewed by Martin Robinson.
3460
3461         * Scripts/run-gtk-tests:
3462         (TestRunner.SkippedTest): Add SkippedTest class to store more
3463         information about skipped tests.
3464         (TestRunner._setup_testing_environment): Use SkippedTest to add
3465         TestWebKitAccessibility to the skipped list.
3466         (TestRunner._find_skipped_test): Return the SkippedTest object for
3467         a given test path.
3468         (TestRunner._test_cases_to_skip): Returns the list of test cases
3469         that should be skipped for a given test path.
3470         (TestRunner._should_run_test): Helper funtion to decide whether
3471         the given test path should be run or not. Tests in the skipped
3472         list that don't have a list of failing test cases are not run at
3473         all. Tests in the skipped list that contain a list of test cases
3474         are run with gtester -s to skip the individual test cases.
3475         (TestRunner._run_test): Helper funtion to run a given test.
3476         (TestRunner.run_tests): Build the list of tests to run based on
3477         _should_run_test() and use helper function _run_test() to run
3478         every test.
3479
3480 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3481
3482         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
3483         https://bugs.webkit.org/show_bug.cgi?id=52810
3484
3485         Reviewed by Simon Hausmann.
3486
3487         Use SSE2 floating point math on 32 bit instead of the default
3488         387 to make layout test result same on 32 and on 64 bit builds.
3489
3490         * qmake/mkspecs/features/unix/default_post.prf:
3491
3492 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
3493
3494         [Soup] DNS prefetching spams resolver, shoots self in the foot
3495         https://bugs.webkit.org/show_bug.cgi?id=41630
3496
3497         Reviewed by Martin Robinson.
3498
3499         Bump libsoup and glib dependencies.
3500
3501         * efl/jhbuild.modules:
3502         * gtk/jhbuild.modules:
3503
3504 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
3505
3506         [GTK] Disable introspection for jhbuild modules
3507         https://bugs.webkit.org/show_bug.cgi?id=82395
3508
3509         Reviewed by Philippe Normand.
3510
3511         * efl/jhbuild.modules: add --disable-introspection to all modules
3512         that support it
3513         * gtk/jhbuild.modules: ditto.
3514
3515 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3516
3517         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
3518
3519         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3520         (BuildAndTestFactory.__init__):
3521
3522 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3523
3524         [Qt] Unreviewed typo fix after r112383.
3525
3526         * Scripts/run-qtwebkit-tests:
3527         (Main.check_crash_occurences):
3528
3529 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
3530
3531         [Qt] run-qtwebkit-tests should report crashes
3532         https://bugs.webkit.org/show_bug.cgi?id=76905
3533
3534         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
3535         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
3536
3537         Reviewed by Csaba Osztrogonác.
3538
3539         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3540         (RunQtAPITests.commandComplete):
3541         (RunQtAPITests.evaluateCommand):
3542         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3543         (RunQtAPITestsTest):
3544         (test_failure):
3545         (test_crash):
3546         * Scripts/run-qtwebkit-tests:
3547         (Main.announce_results_html):
3548         (Main):
3549         (Main.check_crash_occurences):
3550         (Main.convert_to_stdout):
3551         (Main.convert_to_html):
3552
3553 2012-03-28  Kwonjin Jeong  <gram@company100.net>
3554
3555         Add support for Intel compiler on Linux QT port.
3556         https://bugs.webkit.org/show_bug.cgi?id=81077
3557
3558         Reviewed by Tor Arne Vestbø.
3559
3560         * qmake/mkspecs/features/default_post.prf:
3561         Don't hide symbols when building with Intel compiler.
3562         The symbols are needed when building QtWebKit tests.
3563
3564         * qmake/mkspecs/features/unix/icc.prf:
3565         Added to ignore icc-specific warnings.
3566         This feature is used with command-line arguments for build-webkit script.
3567
3568 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3569
3570         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
3571
3572         * Scripts/update-webkitgtk-libs: This script is written in
3573         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
3574
3575 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
3576
3577         kill-old-processes doesn't do anything on linux
3578         https://bugs.webkit.org/show_bug.cgi?id=82388
3579
3580         Reviewed by Tony Chang.
3581
3582         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
3583         This should help stabilizing Chromium linux bots.
3584
3585         * BuildSlaveSupport/kill-old-processes:
3586
3587 2012-03-28  Philippe Normand  <pnormand@igalia.com>
3588
3589         [GTK] jhbuild wrongly tricked into clean-up
3590         https://bugs.webkit.org/show_bug.cgi?id=82216
3591
3592         Reviewed by Gustavo Noronha Silva.
3593
3594         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
3595         build tree. Also when checking if the jhbuild configuration
3596         changed use absolute md5sum paths.
3597
3598         * Scripts/webkitdirs.pm:
3599         (runAutogenForAutotoolsProjectIfNecessary):
3600         (jhbuildConfigurationChanged):
3601         (buildAutotoolsProject):
3602
3603 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
3604
3605         kill-old-processes doesn't do anything on linux
3606         https://bugs.webkit.org/show_bug.cgi?id=82388
3607
3608         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
3609
3610         The platform in Factory comes from config.json, accordingly platform is fullplatform,
3611         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
3612
3613         Reviewed by Ryosuke Niwa.
3614
3615         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3616         (Factory.__init__):
3617
3618 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
3619
3620         Make Chromium port for Android use hardware gpu path default.
3621         https://bugs.webkit.org/show_bug.cgi?id=82033
3622
3623         Reviewed by Dirk Pranke.
3624
3625         Skip canvas tests, which are run in virtual gpu test suites.
3626
3627         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3628         (ChromiumAndroidPort.__init__):
3629         (ChromiumAndroidPort.skipped_tests):
3630
3631 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3632
3633         kill-old-processes doesn't do anything on linux
3634         https://bugs.webkit.org/show_bug.cgi?id=82388
3635
3636         Disable kill-old-processes on the Qt bots not to kill each others.
3637
3638         Reviewed by Ryosuke Niwa.
3639
3640         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3641         (Factory.__init__):
3642
3643 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
3644
3645         Handle DRT crash caused by Android OOM.
3646         https://bugs.webkit.org/show_bug.cgi?id=82310
3647
3648         Reviewed by Tony Chang.
3649
3650         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
3651         is stopped silently and regarded as crashed. Re-run the test for
3652         such crash.
3653
3654         Add some debug log to NRWT.
3655
3656         * Scripts/webkitpy/layout_tests/port/chromium.py:
3657         (ChromiumDriver.run_test):
3658         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3659         (ChromiumAndroidPort.__init__):
3660         (ChromiumAndroidPort.get_last_stacktrace):
3661         (ChromiumAndroidDriver.__init__):
3662         (ChromiumAndroidDriver._start):
3663         (ChromiumAndroidDriver.run_test):
3664         (ChromiumAndroidDriver._get_drt_return_value):
3665
3666 2012-03-27  Ojan Vafai  <ojan@chromium.org>
3667
3668         Fix expected results for some unittest failures.
3669
3670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3671
3672 2012-03-27  Adrienne Walker  <enne@google.com>
3673
3674         [chromium] Fix --enabled-threaded-compositing flag in DRT
3675         https://bugs.webkit.org/show_bug.cgi?id=82405
3676
3677         Reviewed by James Robinson.
3678
3679         --enable-threaded-compositing wasn't working because there was no way
3680         to set the value before it was used in the TestShell constructor.
3681
3682         To avoid adding yet another boolean parameter to TestShell's
3683         constructor, add an explicit initialize function that can operate on
3684         any boolean settings that are set post-constructor.
3685
3686         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3687         (main):
3688         * DumpRenderTree/chromium/TestShell.cpp:
3689         (TestShell::TestShell):
3690         (TestShell::initialize):
3691         * DumpRenderTree/chromium/TestShell.h:
3692         (TestShell):
3693         (TestShell::setTestShellMode):
3694
3695 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3696
3697         new-run-webkit-tests: suppress debug output from run-safari on results file
3698         https://bugs.webkit.org/show_bug.cgi?id=82400
3699
3700         Reviewed by Ryosuke Niwa.
3701
3702         Send the run-safari output to /dev/null rather than the console.
3703
3704         * Scripts/webkitpy/layout_tests/port/mac.py:
3705         (MacPort.show_results_html_file):
3706
3707 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
3708
3709         Improve error reporting in run-javascriptcore-tests
3710         https://bugs.webkit.org/show_bug.cgi?id=82379
3711
3712         Reviewed by Jessie Berlin.
3713         
3714         When the script dies, have it print out the reason for dying.
3715
3716         * Scripts/run-javascriptcore-tests:
3717
3718 2012-03-27  Eric Seidel  <eric@webkit.org>
3719
3720         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
3721         https://bugs.webkit.org/show_bug.cgi?id=82373
3722
3723         Reviewed by Ryosuke Niwa.
3724
3725         Dave's committer-status in in-progress, so until then
3726         list him as a Contributor so at least I can more easily CC him on bugs.
3727
3728         * Scripts/webkitpy/common/config/committers.py:
3729
3730 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3731
3732         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
3733         https://bugs.webkit.org/show_bug.cgi?id=82252
3734
3735         Reviewed by Gustavo Noronha Silva.
3736
3737         Appending the directory containing common.py may be problematic if
3738         another path in sys.path also contains either a common.py or a
3739         common/ module, so prepend to select our version instead. This is
3740         the case with fail2ban, which has a common/ directory which may
3741         end up being in Python's default path.
3742
3743         * efl/jhbuildrc:
3744         * gtk/jhbuildrc:
3745
3746 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
3747
3748         test-webkitpy: prepare for better test run output
3749         https://bugs.webkit.org/show_bug.cgi?id=82290
3750
3751         Reviewed by Adam Barth.
3752
3753         This code basically re-implements the output of the TextTestRunner default
3754         runner code from unittest, although the implementation is quite
3755         different, in preparation for changing the test output to be
3756         metered and possibly running in parallel.
3757
3758         The output is almost identical to before, except that instead of
3759         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
3760         "webkitpy.main.RunnerTest.test_regular passed". It has always
3761         annoyed me that they invert the names to be harder to read and
3762         so that you can't copy & paste back to the input for
3763         test-webkitpy.
3764
3765         This patch is provided to add a skeleton for unit tests and for
3766         comparison to an upcoming patch that will actually add new
3767         functionality.
3768
3769         * Scripts/webkitpy/test/main.py:
3770         (Tester.__init__):
3771         (Tester._configure_logging):
3772         (Tester._run_tests):
3773         * Scripts/webkitpy/test/runner.py: Added.
3774         (TestRunner):
3775         (TestRunner.__init__):
3776         (TestRunner.test_name):
3777         (TestRunner.all_test_names):
3778         (TestRunner.run):
3779         (TestRunner.write_result):
3780         (TestRunner.write_summary):
3781         * Scripts/webkitpy/test/runner_unittest.py: Added.
3782         (FakeModuleSuite):
3783         (FakeModuleSuite.__init__):
3784         (FakeModuleSuite.__str__):
3785         (FakeModuleSuite.run):
3786         (FakeTopSuite):
3787         (FakeTopSuite.__init__):
3788         (FakeLoader):
3789         (FakeLoader.__init__):
3790         (FakeLoader.top_suite):
3791         (FakeLoader.loadTestsFromName):
3792         (RunnerTest):
3793         (RunnerTest.test_regular):
3794         (RunnerTest.test_verbose):
3795
3796 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
3797
3798         [GTK] Build gnutls without p11-kit support
3799         https://bugs.webkit.org/show_bug.cgi?id=82212
3800
3801         Reviewed by Martin Robinson.
3802
3803         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
3804         configure, to avoid requiring that dependency, which is not used
3805         by libsoup and WebKit anyway
3806
3807 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
3808
3809         [Qt] Make debug build work on 32 bit
3810         https://bugs.webkit.org/show_bug.cgi?id=82331
3811
3812         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
3813         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
3814
3815         Reviewed by Tor Arne Vestbø.
3816
3817         * qmake/mkspecs/features/unix/default_post.prf:
3818         * qmake/mkspecs/features/unix/default_pre.prf:
3819
3820 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
3821
3822         Add png checking to check-webkit-style
3823         https://bugs.webkit.org/show_bug.cgi?id=75824
3824
3825         Reviewed by NOBODY Tony Chang.
3826
3827         * Scripts/webkitpy/style/checker.py:
3828         (_all_categories):
3829         (FileType):
3830         (CheckerDispatcher._should_skip_file_path):
3831         (CheckerDispatcher._file_type):
3832         (CheckerDispatcher._create_checker):
3833         * Scripts/webkitpy/style/checker_unittest.py:
3834         (CheckerDispatcherDispatchTest.test_none_paths):
3835         * Scripts/webkitpy/style/checkers/png.py: Added.
3836         (PNGChecker):
3837         (PNGChecker.__init__):
3838         (PNGChecker.check):
3839         (PNGChecker._config_file_path):
3840         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
3841         (MockSCMDetector):
3842         (MockSCMDetector.__init__):
3843         (MockSCMDetector.display_name):
3844         (MockSCMDetector.propget):
3845         (PNGCheckerTest):
3846         (PNGCheckerTest.test_init):
3847         (PNGCheckerTest.test_init.mock_handle_style_error):
3848         (PNGCheckerTest.test_check):
3849         (PNGCheckerTest.test_check.mock_handle_style_error):
3850         * Scripts/webkitpy/style/patchreader.py:
3851         (PatchReader.check):
3852
3853 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3854
3855         Unreviewed. Skip GTK+ unit tests that fail in the bots
3856
3857         * Scripts/run-gtk-tests:
3858         (TestRunner): Add failing tests to the skipped list.
3859
3860 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3861
3862         Unreviewed. Unskip all GTK+ unit test.
3863
3864         Currently, skipped tests contains the list of unit tests that have
3865         failed in one or more bots. In this moment it's not possible to
3866         skip just the test cases that fail, so the complete unit test is
3867         skipped when a single test case fails. For that reason, we don't
3868         know which test cases are actually failing for every skipped
3869         test. We are planning to land a patch to allow skipping individual
3870         test cases, but first we need to know which test cases are
3871         currently failing in the bots to skip them. So, this patch simply
3872         unskips all unit tests in order to watch the bots and get the list
3873         of test cases failing. Failing tests will be skipped again as soon
3874         as we have the new list of failing test cases.
3875
3876         * Scripts/run-gtk-tests:
3877         (TestRunner): Reset the list of skipped tests.
3878
3879 2012-03-26  Scott Byer  <scottbyer@chromium.org>
3880
3881         Enable layout testing of the scroll animator.
3882         https://bugs.webkit.org/show_bug.cgi?id=81858
3883         Add a call to the InternalSettings that layout tests can use to
3884         turn on scroll animation. Enable animation updates for the
3885         Chromium platform DRT when scroll animation has been turned on in
3886         a test. This should be a no-op for all current layout tests.
3887
3888         Reviewed by James Robinson.
3889
3890         * DumpRenderTree/chromium/WebViewHost.cpp:
3891         (WebViewHost::serviceAnimation):
3892         (WebViewHost::scheduleAnimation):
3893         * DumpRenderTree/chromium/WebViewHost.h:
3894         (WebViewHost):
3895
3896 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
3897
3898         [Qt][WK2] Support multi-file upload
3899         https://bugs.webkit.org/show_bug.cgi?id=81589
3900
3901         Reviewed by Simon Hausmann.
3902
3903         Modified filePicker to support multi-file upload.
3904
3905         * MiniBrowser/qt/MiniBrowser.qrc:
3906         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
3907         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
3908         * MiniBrowser/qt/js/MultiSelect.js: Added.
3909         (values):
3910         (isSelected):
3911         (removeValue):
3912         * MiniBrowser/qt/qml/CheckBox.qml: Added.
3913         * MiniBrowser/qt/qml/FilePicker.qml:
3914
3915 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3916
3917         Retry crashing tests serially at the end of NRWT on Apple Mac
3918         https://bugs.webkit.org/show_bug.cgi?id=82233
3919
3920         Reviewed by Dirk Pranke.
3921
3922         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3923         (Manager.run):
3924         * Scripts/webkitpy/layout_tests/port/base.py:
3925         (Port.should_retry_crashes):
3926         * Scripts/webkitpy/layout_tests/port/mac.py:
3927         (MacPort.should_retry_crashes):
3928
3929 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3930
3931         NRWT should retry failures serially
3932         https://bugs.webkit.org/show_bug.cgi?id=82241
3933
3934         Reviewed by Dirk Pranke.
3935
3936         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3937         (Manager._run_tests): Add another parameter to specify the number of workers to use.
3938         (Manager.run): Run the failures serially.
3939
3940 2012-03-26  Adrienne Walker  <enne@google.com>
3941
3942         Allow expectations on directories in virtual test suites
3943         https://bugs.webkit.org/show_bug.cgi?id=82250
3944
3945         Reviewed by Dirk Pranke.
3946
3947         lookup_virtual_test_base was only returning valid results for files
3948         and not directories. Fix by falling back to the virtual test suite
3949         mapping if possible.
3950
3951         * Scripts/webkitpy/layout_tests/port/base.py:
3952         (Port.lookup_virtual_test_base):
3953         * Scripts/webkitpy/layout_tests/port/test.py:
3954         (TestPort.skipped_tests):
3955         (TestPort.virtual_test_suites):
3956
3957 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3958
3959         Fix duplicated ChangeLog entry from r112171.
3960
3961         Unreviewed, build fix.
3962
3963 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
3964
3965         nrwt: remove --worker-model flag
3966         https://bugs.webkit.org/show_bug.cgi?id=82112
3967
3968         Reviewed by Adam Barth.
3969
3970         The --worker-model=inline flag is basically redundant with the
3971         --child-processes=1 flag (technically, you could one run child
3972         process, but this is only useful for testing); this patch
3973         removes this flag, which simplifies things and enables more
3974         cleanup down the road.
3975
3976         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3977         (Manager._run_tests):
3978         (Manager.print_config):
3979         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3980         (get):
3981         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3982         (make_broker):
3983         (FunctionTests.test_get__inline):
3984         (FunctionTests.test_get__processes):
3985         (_TestsMixin.setUp):
3986         (_TestsMixin.make_broker):
3987         (InlineBrokerTests.setUp):
3988         (MultiProcessBrokerTests.setUp):
3989         * Scripts/webkitpy/layout_tests/port/base.py:
3990         (Port.default_child_processes):
3991         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3992         (ChromiumAndroidPort.check_sys_deps):
3993         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3994         (ChromiumAndroidPortTest):
3995         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3996         (MockDRTPortTest.make_port):
3997         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3998         (PortTestCase):
3999         (PortTestCase.make_port):
4000         * Scripts/webkitpy/layout_tests/port/test.py:
4001         (TestPort.default_child_processes):
4002         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4003         (_set_up_derived_options):
4004         (parse_args):
4005         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4006         (parse_args):
4007         (MainTest.test_batch_size):
4008         (MainTest.test_child_processes_2):
4009         (MainTest.test_child_processes_min):
4010         (MainTest.test_exception_raised):
4011         (MainTest.test_keyboard_interrupt):
4012         (MainTest.test_exit_after_n_crashes):
4013         (MainTest.assert_run_order):
4014         (MainTest.test_run_order__inline):
4015         (MainTest.test_virtual):
4016
4017 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
4018
4019         test-webkitpy: split test-finding code into a different module
4020         https://bugs.webkit.org/show_bug.cgi?id=82253
4021
4022         Reviewed by Adam Barth.
4023
4024         Per suggestion from abarth, this change splits all the
4025         filesystem-crawling, test-finding code in test-webkitpy out into
4026         a separate module and switches to using a FileSystem object.
4027         This makes things much more testable, so we also add tests :).
4028
4029         We also add a realpath() method to the Filesystem object, since
4030         test-webkitpy needs that in order to be able to resolve symlinks
4031         properly to determine whether a file is under a particular tree
4032         or not.
4033
4034         * Scripts/webkitpy/common/system/filesystem.py:
4035         (FileSystem.realpath):
4036         * Scripts/webkitpy/common/system/filesystem_mock.py:
4037         (MockFileSystem.realpath):
4038         * Scripts/webkitpy/test/main.py:
4039         (Tester.__init__):
4040         (Tester.add_tree):
4041         (Tester.run):
4042         (Tester._run_tests):
4043         (Tester._log_exception):
4044         * Scripts/webkitpy/test/test_finder.py: Added.
4045         (TestDirectoryTree):
4046         (TestDirectoryTree.__init__):
4047         (TestDirectoryTree.find_modules):
4048         (TestDirectoryTree.find_modules.file_filter):
4049         (TestDirectoryTree.to_module):
4050         (TestDirectoryTree.clean):
4051         (TestFinder):
4052         (TestFinder.__init__):
4053         (TestFinder.add_tree):
4054         (TestFinder.additional_paths):
4055         (TestFinder.clean_trees):
4056         (TestFinder.is_module):
4057         (TestFinder.to_module):
4058         (TestFinder.find_names):
4059         (TestFinder._exclude):
4060         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
4061         (TestFinderTest):
4062         (TestFinderTest.setUp):
4063         (TestFinderTest.tearDown):
4064         (TestFinderTest.test_additional_system_paths):
4065         (TestFinderTest.test_is_module):
4066         (TestFinderTest.test_to_module):
4067         (TestFinderTest.test_clean):
4068         (TestFinderTest.test_find_names):
4069
4070 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
4071
4072         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
4073         https://bugs.webkit.org/show_bug.cgi?id=82209
4074
4075         Reviewed by Martin Robinson.
4076
4077         Respecting the $MAKE environment variable when it is defined makes
4078         building jhbuild more portable, as some platforms may have GNU
4079         make as gmake, for example.
4080
4081         * jhbuild/jhbuild-wrapper:
4082         (install_jhbuild):
4083
4084 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
4085
4086         add a Tree abstraction to test-webkitpy to better encapsulate things
4087         https://bugs.webkit.org/show_bug.cgi?id=82158
4088
4089         Reviewed by Adam Barth.
4090
4091         There are no functional changes in this patch, but adding a
4092         basic abstraction for the trees we are looking in for python
4093         tests will allow me to add some features later on more easily
4094         (like ignoring certain directories like webkitpy/thirdparty),
4095         and it makes things slightly less hard-coded.
4096
4097         * Scripts/test-webkitpy:
4098         * Scripts/webkitpy/test/main.py:
4099         (Tester.__init__):
4100         (Tester):
4101         (Tester.add_tree):
4102         (Tester._parse_args):
4103         (Tester._configure):
4104         (Tester.run):
4105         (Tester._find_modules):
4106         (Tester._run_tests):
4107         (Tester._is_module):
4108         (Tester._log_exception):
4109         (TestDirectoryTree):
4110         (TestDirectoryTree.__init__):
4111         (TestDirectoryTree.find_modules):
4112         (TestDirectoryTree.clean):
4113
4114 2012-03-26  Ojan Vafai  <ojan@chromium.org>
4115
4116         garden-o-matic should special case reftests
4117         https://bugs.webkit.org/show_bug.cgi?id=81812
4118
4119         Reviewed by Adam Barth.
4120
4121         On the examine page, don't show a rebaseline button for reftests.
4122         We still show it on the failure summary page because tests are grouped
4123         together. Long-term, we should make sure webkit-patch rebaseline-test
4124         never tries to rebaseline reftests.
4125
4126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
4129
4130 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
4131
4132         clean up NRWT logging/metering, be less verbose
4133         https://bugs.webkit.org/show_bug.cgi?id=73846
4134
4135         Reviewed by Ojan Vafai.
4136
4137         Re-land r112014 with a build fix for Python 2.6 compatibility.
4138
4139         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4140         (ManagerTest.test_http_locking):
4141         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
4142         (AbstractWorker.run):
4143         * Scripts/webkitpy/layout_tests/controllers/worker.py:
4144         (Worker.__init__):
4145         (Worker._set_up_logging):
4146         (Worker):
4147         (Worker._set_up_host_and_port):
4148         (Worker.run):
4149         (Worker.cleanup):
4150         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
4151         (WorkerTest.test_default_platform_in_worker):
4152         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4153         (run):
4154         (main):
4155         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4156         (MeteredStream):
4157         (MeteredStream.implements):
4158         (MeteredStream._erasure):
4159         (MeteredStream._ensure_newline):
4160         (MeteredStream.__init__):
4161         (MeteredStream.__del__):
4162         (MeteredStream.cleanup):
4163         (MeteredStream.write_throttled_update):
4164         (MeteredStream.write_update):
4165         (MeteredStream.write):
4166         (MeteredStream.writeln):
4167         (MeteredStream._erase_last_partial_line):
4168         (_LogHandler):
4169         (_LogHandler.__init__):
4170         (_LogHandler.emit):
4171         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4172         (RegularTest):
4173         (RegularTest.setUp):
4174         (RegularTest.tearDown):
4175         (RegularTest.time_fn):
4176         (RegularTest.test_logging_not_included):
4177         (RegularTest._basic):
4178         (RegularTest.test_basic):
4179         (RegularTest._log_after_update):
4180         (RegularTest.test_log_after_update):
4181         (TtyTest):
4182         (TtyTest.test_basic):
4183         (TtyTest.test_log_after_update):
4184         (VerboseTest):
4185         (VerboseTest.test_basic):
4186         (VerboseTest.test_log_after_update):
4187         * Scripts/webkitpy/layout_tests/views/printing.py:
4188         (parse_print_options):
4189         (Printer.__init__):
4190         (Printer.cleanup):
4191         (Printer.print_progress):
4192         (Printer.print_update):
4193         (Printer._write):
4194         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4195         (Testprinter.get_printer):
4196         (Testprinter.test_print_progress):
4197         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4198         (PerfTestsRunner.__init__):
4199         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4200         (test_run_test_pause_before_testing):
4201
4202 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
4203
4204         [jhbuild] Revert $MAKE environment hack introduced in r101929.
4205         https://bugs.webkit.org/show_bug.cgi?id=82234
4206
4207         Reviewed by Martin Robinson.
4208
4209         The problem it was supposedly fixing was fixed in jhbuild itself
4210         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
4211         can remove the workaround added to the script.
4212
4213         * jhbuild/jhbuild-wrapper:
4214         (install_jhbuild):
4215
4216 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
4217
4218         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
4219         https://bugs.webkit.org/show_bug.cgi?id=82157
4220
4221         Reviewed by Rob Buis.
4222
4223         * Scripts/build-webkit:
4224         Make ENABLE_FILE_SYSTEM default on for blackberry.
4225
4226 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
4227
4228         [jhbuild] Explicitly disable DTrace when building glib.
4229         https://bugs.webkit.org/show_bug.cgi?id=82145
4230
4231         Reviewed by Gustavo Noronha Silva.
4232
4233         DTrace support is not really needed by WebKit, so disabling it
4234         helps avoid some build errors on more exotic platforms (such as
4235         FreeBSD).
4236
4237         * efl/jhbuild.modules:
4238         * gtk/jhbuild.modules:
4239
4240 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
4241
4242         Unreviewed, rolling out r111993.
4243         http://trac.webkit.org/changeset/111993
4244         https://bugs.webkit.org/show_bug.cgi?id=82184
4245
4246         It broke layout and API tests and made WTR crash (Requested by
4247         Ossy on #webkit).
4248
4249         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4250         (WTR::PlatformWebView::PlatformWebView):
4251
4252 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
4253
4254         [wx] Unreviewed build fix. Move WTF to its own static lib build.
4255
4256         * waf/build/settings.py:
4257         (common_configure):
4258
4259 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
4260
4261         AX: Support solution to handle invalid ax text marker
4262         https://bugs.webkit.org/show_bug.cgi?id=82023
4263
4264         Reviewed by Oliver Hunt.
4265
4266         * DumpRenderTree/AccessibilityUIElement.cpp:
4267         (indexForTextMarkerCallback):
4268         (isTextMarkerValidCallback):
4269         (textMarkerForIndexCallback):
4270         (AccessibilityUIElement::indexForTextMarker):
4271         (AccessibilityUIElement::isTextMarkerValid):
4272         (AccessibilityUIElement::textMarkerForIndex):
4273         (AccessibilityUIElement::getJSClass):
4274         * DumpRenderTree/AccessibilityUIElement.h:
4275         (AccessibilityUIElement):
4276         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4277         (AccessibilityUIElement::indexForTextMarker):
4278         (AccessibilityUIElement::textMarkerForIndex):
4279         (AccessibilityUIElement::isTextMarkerValid):
4280         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4281         (WTR::AccessibilityUIElement::indexForTextMarker):
4282         (WTR::AccessibilityUIElement::isTextMarkerValid):
4283         (WTR::AccessibilityUIElement::textMarkerForIndex):
4284         (WTR):
4285         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4286         (AccessibilityUIElement):
4287         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
4288         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4289         (WTR):
4290         (WTR::AccessibilityUIElement::indexForTextMarker):
4291         (WTR::AccessibilityUIElement::isTextMarkerValid):
4292         (WTR::AccessibilityUIElement::textMarkerForIndex):
4293
4294 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4295
4296         Unreviewed, rolling out r112014.
4297         http://trac.webkit.org/changeset/112014
4298         https://bugs.webkit.org/show_bug.cgi?id=82138
4299
4300         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
4301         #webkit).
4302
4303         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4304         (ManagerTest.test_http_locking):
4305         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
4306         (AbstractWorker.run):
4307         * Scripts/webkitpy/layout_tests/controllers/worker.py:
4308         (Worker.__init__):
4309         (Worker.safe_init):
4310         (Worker.run):
4311         (Worker.cleanup):
4312         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
4313         (WorkerTest.test_default_platform_in_worker):
4314         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4315         (run):
4316         (main):
4317         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
4318         (MeteredStream):
4319         (MeteredStream.is):
4320         (MeteredStream.__init__):
4321         (MeteredStream.write):
4322         (MeteredStream.update):
4323         (MeteredStream._overwrite):
4324         (MeteredStream._reset):
4325         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
4326         (TestMeteredStream):
4327         (TestMeteredStream.test_regular):
4328         * Scripts/webkitpy/layout_tests/views/printing.py:
4329         (_configure_logging):
4330         (_restore_logging):
4331         (Printer.__init__):
4332         (Printer.cleanup):
4333         (Printer.print_progress):
4334         (Printer.print_update):
4335         (Printer._write):
4336         (Printer):
4337         (Printer._update):
4338         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4339         (TestUtilityFunctions.assertEmpty):
4340         (TestUtilityFunctions):
4341         (TestUtilityFunctions.assertNotEmpty):
4342         (TestUtilityFunctions.assertWritten):
4343         (TestUtilityFunctions.test_configure_logging):
4344         (Testprinter.get_printer):
4345         (Testprinter.test_print_progress):
4346         (Testprinter.test_print_progress.mock_time):
4347         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4348         (PerfTestsRunner.__init__):
4349         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
4350         (test_run_test_pause_before_testing):
4351
4352 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
4353
4354         [wx] Unreviewed. Fix the build after WTF move.
4355
4356         * waf/build/build_utils.py:
4357         (get_excludes):
4358         (get_excludes_in_dirs):
4359         * waf/build/settings.py:
4360         (get_port_excludes):
4361         (common_configure):
4362
4363 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
4364
4365         clean up NRWT logging/metering, be less verbose
4366         https://bugs.webkit.org/show_bug.cgi?id=73846
4367
4368         Reviewed by Ojan Vafai.
4369
4370         This patch totally rewrites the metered_stream module and
4371         changes the way it and the printing module now interact with the
4372         logging subsystem.
4373
4374         The printing module becomes a dumb layout_tests-specific wrapper around
4375         the metered stream. All of the intelligence of how and when to
4376         actually write (or erase) lines and how things interact with
4377         logging moves into the metered stream.
4378
4379         As of now, anything written to the metered stream *bypasses the
4380         logging system*. If a logger is passed to the meter constructor,
4381         the metered stream will also attach a log handler so that all
4382         messages fed to the logger will also be written to the metered
4383         stream. This detangles the logic that used to exist where
4384         sometimes the meter would write to the logger and sometimes the
4385         logger would write to the meter.
4386
4387         All of this makes the logic generic and reusable for
4388         test-webkitpy (coming in another patch). It also helps clarify
4389         what the mysterious "configure_logging" parameter to the printer
4390         constructor used to do (that parameter itself is gone now, and
4391         by default the printer and metered_stream will not ever touch
4392         the logging system; this makes a bunch of tests less fragile).
4393
4394         All of the above should produce no user-visible changes.
4395
4396         However, to also fix the bug in question, we change the message
4397        &nbs