1 2012-10-11 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
3 [Qt] Make sure that -Wno-c++0x-compat is set even with production_build
5 Reviewed by Simon Hausmann.
7 This makes sure that QtWebKit can be built inside Qt without nullptr
8 and narrowing warnings producing noise during compilation.
10 * qmake/mkspecs/features/unix/default_post.prf:
12 2012-10-11 Jinwoo Song <jinwoo7.song@samsung.com>
14 [EFL][WK2] Revisit setting API names and documentation
15 https://bugs.webkit.org/show_bug.cgi?id=98793
17 Reviewed by Kenneth Rohde Christiansen.
19 Make frame flattening setting APIs to be consistent with others.
21 * MiniBrowser/efl/main.c:
24 2012-10-11 Vivek Galatage <vivekgalatage@gmail.com>
26 Fix committers.py for the names of contributors to appear on webkit.org/team.html
27 https://bugs.webkit.org/show_bug.cgi?id=99004
29 Reviewed by Yuta Kitamura
31 Some of the nicknames in the committers.py file are using the single quotes (')
32 but while parsing these, JSON throws an error: Single quotes (') are not allowed in JSON
33 Hence coverting these single quotes to (") so as the contributor names appear properly
34 on http://www.webkit.org/team.html
36 * Scripts/webkitpy/common/config/committers.py:
38 2012-10-10 Lucas Forschler <lforschler@apple.com>
40 Remove Apple Mac Snow Leopard bots.
42 * BuildSlaveSupport/build.webkit.org-config/config.json:
44 2012-10-10 Christophe Dumez <christophe.dumez@intel.com>
46 [EFL][WK2] Add toolbar buttons to MiniBrowser
47 https://bugs.webkit.org/show_bug.cgi?id=98883
49 Reviewed by Kenneth Rohde Christiansen.
51 Add toolbar buttons to MiniBrowser to support
52 navigation back / forward, refresh and go
55 * MiniBrowser/efl/main.c:
57 (on_back_forward_list_changed):
58 (on_back_button_clicked):
59 (on_forward_button_clicked):
60 (on_refresh_button_clicked):
61 (on_home_button_clicked):
62 (create_toolbar_button):
65 2012-10-10 Andy Estes <aestes@apple.com>
67 Fix the Lion build after r130948.
69 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
71 2012-10-10 Andy Estes <aestes@apple.com>
73 Speculative build fix for Snow Leopard after r130948.
75 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Pull the
76 declaration of backgroundColorQuery out of a block to appease GCC.
78 2012-10-10 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
80 [WK2][WTR] WebKitTestRunner UI process should be aware of Custom Policy Delegate
81 https://bugs.webkit.org/show_bug.cgi?id=95974
83 Reviewed by Kenneth Rohde Christiansen.
85 Added TestController::decidePolicyForNavigationAction() function as a 'decidePolicyForNavigationAction' WKPagePolicyClient callback
86 for WTR UI process. WTR bundle client notifies UI process about Custom Policy Delegate via newly added message,
87 so that TestController is aware of whether Custom Policy Delegate as enabled and
88 permissive. This data is used then in TestController::decidePolicyForNavigationAction for making policy decision.
90 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
91 (WTR::InjectedBundle::setCustomPolicyDelegate):
93 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
95 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
96 (WTR::TestRunner::setCustomPolicyDelegate):
97 * WebKitTestRunner/TestController.cpp:
98 (WTR::TestController::TestController):
99 (WTR::TestController::initialize):
100 (WTR::TestController::resetStateToConsistentValues):
101 (WTR::TestController::setCustomPolicyDelegate):
103 (WTR::TestController::decidePolicyForNavigationAction):
104 * WebKitTestRunner/TestController.h:
106 * WebKitTestRunner/TestInvocation.cpp:
107 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
109 2012-10-10 Zoltan Horvath <zoltan@webkit.org>
111 Pageload tests should measure memory usage
112 https://bugs.webkit.org/show_bug.cgi?id=93958
114 Reviewed by Ryosuke Niwa.
116 Add JS Heap and Heap memory measurement to PageLoad tests.
118 * DumpRenderTree/mac/DumpRenderTree.mm:
119 (dump): Print memory results with DRT.
120 * Scripts/old-run-webkit-tests:
121 (readFromDumpToolWithTimer): Hadle memory results.
122 * Scripts/webkitpy/layout_tests/port/driver.py:
123 (DriverOutput.__init__): Add new parameter for the results.
124 (Driver.__init__): Initialize the new parameter.
126 (Driver._read_first_block): Add support for the new headers.
127 (Driver._process_stdout_line):
128 (ContentBlock.__init__):
129 * Scripts/webkitpy/performance_tests/perftest.py:
130 (PageLoadingPerfTest.calculate_statistics): Move statistics calculation into a function.
131 (PageLoadingPerfTest.run): Handle the new memory results.
132 (PageLoadingPerfTest.run.in):
133 (PageLoadingPerfTest):
134 * Scripts/webkitpy/performance_tests/perftest_unittest.py: Add test for memory results of pageloadtests.
135 (TestPageLoadingPerfTest.MockDriver.__init__):
136 (TestPageLoadingPerfTest.MockDriver.run_test):
137 (TestPageLoadingPerfTest.test_run_with_memory_output):
139 2012-10-04 Andy Estes <aestes@apple.com>
141 [WebKit2] Create an API for adding and removing user stylesheets from a page group
142 https://bugs.webkit.org/show_bug.cgi?id=98432
144 Reviewed by Sam Weinig.
146 Add three new API tests:
148 - Test adding a user stylesheet before a page is created. This tests
149 the code path where the sheet is sent to the web process as part of
150 the new page's WebPageCreationParameters.
151 - Test adding a user stylesheet after a page is created. This tests the
152 code patch where the sheet is sent as a separate message to all
153 processes containing the given page group.
154 - Test removing all user stylesheets.
156 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
157 * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm: Added.
158 (-[UserContentTestLoadDelegate initWithBlockToRunOnLoad:]):
159 (-[UserContentTestLoadDelegate browsingContextControllerDidFinishLoad:]):
161 * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
163 2012-10-10 Dan Bernstein <mitz@apple.com>
165 Changed debug-safari, debug-minibrowser and debug-test-runner to use LLDB by default when
166 using Xcode 4.5 or later.
168 Reviewed by Anders Carlsson.
170 * Scripts/webkitdirs.pm:
171 (determineDebugger): Changed the default debugger from GDB to LLDB when the Xcode version
172 is 4.5 or later. Added a --use-gdb switch for overriding this.
173 (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Updated to mention --use-gdb and the
174 how the default debugger choice depends on the Xcode version. Also changed the description
175 of --no-saved-state to use the same terminology Xcode’s scheme editor uses to describe this
176 option, and clarified to which OS X versions it applies.
178 2012-10-10 Antonio Gomes <agomes@rim.com>
180 Unreviewed watch list addition.
182 * Scripts/webkitpy/common/config/watchlist:
184 2012-10-10 Dirk Pranke <dpranke@chromium.org>
186 NRWT crashes on too many timeouts
187 https://bugs.webkit.org/show_bug.cgi?id=97047
189 Reviewed by Tony Chang.
191 Apparently if you kill a subprocess directly python doesn't
192 auto-close the file descriptors.
194 * Scripts/webkitpy/layout_tests/port/server_process.py:
195 (ServerProcess._reset):
196 * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
198 2012-10-10 Zan Dobersek <zandobersek@gmail.com>
200 [TestResultServer] Enable CORS for test files
201 https://bugs.webkit.org/show_bug.cgi?id=98918
203 Reviewed by Dirk Pranke.
205 Serve the JSON test files with the Access-Control-Allow-Origin
206 response header to enable cross-origin sharing of these files.
207 This eases up hacking on TestResultServer.
209 * TestResultServer/handlers/testfilehandler.py:
210 (GetFile._serve_json):
212 2012-10-10 Andreas Kling <kling@webkit.org>
214 Future-proof the WTF.DoubleHashCollisions test.
215 <http://webkit.org/b/98853>
217 Reviewed by Anders Carlsson.
219 Add a check that the two keys that are supposed to clobber each other actually end up
220 in the same bucket with the DefaultHash<double> hash function.
222 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
223 (TestWebKitAPI::bucketForKey):
225 (TestWebKitAPI::TEST):
227 2012-10-10 Balazs Kelemen <kbalazs@webkit.org>
229 [Qt] Test drivers should handle repaint rects
230 https://bugs.webkit.org/show_bug.cgi?id=68870
232 Reviewed by Zoltan Herczeg.
234 Implemented masking the area not covered by repaint rects.
235 This is equivalent with the implementation for Mac.
237 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
238 (WebCore::DumpRenderTree::dump):
239 * DumpRenderTree/qt/TestRunnerQt.cpp:
240 (TestRunner::display):
241 * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
242 * WebKitTestRunner/qt/TestInvocationQt.cpp:
243 (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
245 2012-10-10 Vivek Galatage <vivekgalatage@gmail.com>
247 [Qt]QtTestBrowser should have default url(google.com) when no command line args
248 https://bugs.webkit.org/show_bug.cgi?id=98880
250 Reviewed by Simon Hausmann.
252 Making QtTestBrowser use www.google.com as default url when no arguments are passed
254 * QtTestBrowser/qttestbrowser.cpp:
257 2012-10-10 Christophe Dumez <christophe.dumez@intel.com>
259 [EFL][WK2] Port MiniBrowser to Elementary
260 https://bugs.webkit.org/show_bug.cgi?id=98748
262 Reviewed by Kenneth Rohde Christiansen.
264 Port MiniBrowser to Elementary to simplify the
265 code and make future improvements easier. The
266 URL bar is now an Elementary Entry widget and
267 supports additional functionality like copy /
271 * EWebLauncher/url_bar.c:
272 (on_urlbar_key_down): Remove WK2-specific code
273 now that this file is no longer used by MiniBrowser.
274 * MiniBrowser/efl/CMakeLists.txt:
275 * MiniBrowser/efl/main.c:
287 (on_url_bar_activated):
288 (on_url_bar_clicked):
289 (on_window_deletion):
292 * efl/jhbuild.modules: Add Elementary to jhbuild and bump
293 EFL dependencies to 1.7.
295 2012-10-10 Christophe Dumez <christophe.dumez@intel.com>
297 [WK2][SOUP] ResourceError.isCancellation() is not carried over IPC
298 https://bugs.webkit.org/show_bug.cgi?id=98882
300 Reviewed by Kenneth Rohde Christiansen.
302 Do not display the error page in MiniBrowser if the loading
303 error corresponds to a cancellation.
305 * MiniBrowser/efl/main.c:
308 2012-10-09 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
310 [Qt] WTR: Fix an assert triggered by EventSenderProxy::touchEnd
311 https://bugs.webkit.org/show_bug.cgi?id=98735
313 Reviewed by Kenneth Rohde Christiansen.
315 ASSERT: "itemForTouchPointId.isEmpty()" in file qt5/qtdeclarative/src/quick/items/qquickwindow.cpp, line 1563
316 This assert is caused by QQuickWindow not registering our TouchPointReleased
317 since it expects QTouchEvent::touchPointStates() to be filled by the event's sender.
319 This patch calculates the touchPointStates like QQuickWindowPrivate::touchEventWithPoints does.
321 * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
322 (WTR::EventSenderProxy::sendTouchEvent):
324 2012-10-10 Allan Sandfeld Jensen <allan.jensen@digia.com>
326 [Qt] DumpRenderTree needs a beginDragWithFiles implementation
327 https://bugs.webkit.org/show_bug.cgi?id=50902
329 Reviewed by Simon Hausmann.
331 Implement support for beginDragWithFiles. This function similates dragging without going
332 though regular event handling. Which allows us to test effects of dropping files on
335 * DumpRenderTree/qt/EventSenderQt.cpp:
336 (EventSender::EventSender):
337 (EventSender::mouseUp):
338 (EventSender::mouseMoveTo):
339 (EventSender::beginDragWithFiles):
340 * DumpRenderTree/qt/EventSenderQt.h:
343 2012-10-10 KwangYong Choi <ky0.choi@samsung.com>
345 [EFL][WTR][CMake] Add a missing TestNetscapePlugin file
346 https://bugs.webkit.org/show_bug.cgi?id=98637
348 Reviewed by Kenneth Rohde Christiansen.
350 PluginScriptableObjectOverridesAllProperties.cpp is used during
351 plugins/npruntime/overrides-all-properties.html test introduced by r123936.
353 * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
355 2012-10-10 Kenichi Ishibashi <bashi@chromium.org>
357 Update pywebsocket to 0.7.7
358 https://bugs.webkit.org/show_bug.cgi?id=98872
360 Reviewed by Yuta Kitamura.
362 This version contains server-side permessage-compress extension support.
363 We need this version to add tests for permessage-compress extension.
365 I confirmed all tests under http/tests/websocket passed.
367 * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py:
368 * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py:
369 * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py:
371 (FragmentedFrameBuilder.__init__):
372 (FragmentedFrameBuilder.build):
373 (create_closing_handshake_body):
374 (StreamOptions.__init__):
376 (Stream._receive_frame._receive_bytes):
377 (Stream._receive_frame):
378 (Stream.receive_filtered_frame):
379 (Stream.send_message):
380 (Stream._get_message_from_frame):
382 (Stream._process_close_message):
383 (Stream._process_ping_message):
384 (Stream._process_pong_message):
385 (Stream.receive_message):
386 (Stream._send_closing_handshake):
387 (Stream.get_last_received_opcode):
388 * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py:
389 * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py:
390 (Dispatcher.transfer_data):
391 * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py:
392 (ExtensionProcessorInterface.name):
393 (DeflateStreamExtensionProcessor):
394 (DeflateStreamExtensionProcessor.name):
395 (_log_compression_ratio):
396 (_log_decompression_ratio):
397 (DeflateFrameExtensionProcessor):
398 (DeflateFrameExtensionProcessor.name):
399 (DeflateFrameExtensionProcessor._outgoing_filter):
400 (DeflateFrameExtensionProcessor._incoming_filter):
401 (CompressionExtensionProcessorBase):
402 (CompressionExtensionProcessorBase.for):
403 (CompressionExtensionProcessorBase.__init__):
404 (CompressionExtensionProcessorBase.name):
405 (CompressionExtensionProcessorBase._get_compression_processor_response):
406 (CompressionExtensionProcessorBase.set_compression_processor_hook):
407 (PerFrameCompressionExtensionProcessor):
408 (PerFrameCompressionExtensionProcessor.__init__):
409 (PerFrameCompressionExtensionProcessor.name):
410 (PerFrameCompressionExtensionProcessor._lookup_compression_processor):
411 (DeflateMessageProcessor):
412 (DeflateMessageProcessor.__init__):
413 (DeflateMessageProcessor.name):
414 (DeflateMessageProcessor.get_extension_response):
415 (DeflateMessageProcessor.setup_stream_options):
416 (DeflateMessageProcessor.setup_stream_options._OutgoingMessageFilter):
417 (DeflateMessageProcessor.setup_stream_options._OutgoingMessageFilter.__init__):
418 (DeflateMessageProcessor.setup_stream_options._OutgoingMessageFilter.filter):
419 (DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter):
420 (DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter.__init__):
421 (DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter.decompress_next_message):
422 (DeflateMessageProcessor.setup_stream_options._IncomingMessageFilter.filter):
423 (DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter):
424 (DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter.__init__):
425 (DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter.set_compression_bit):
426 (DeflateMessageProcessor.setup_stream_options._OutgoingFrameFilter.filter):
427 (DeflateMessageProcessor.setup_stream_options._IncomingFrameFilter):
428 (DeflateMessageProcessor.setup_stream_options._IncomingFrameFilter.__init__):
429 (DeflateMessageProcessor.setup_stream_options._IncomingFrameFilter.filter):
430 (DeflateMessageProcessor.set_c2s_max_window_bits):
431 (DeflateMessageProcessor.set_c2s_no_context_takeover):
432 (DeflateMessageProcessor.enable_outgoing_compression):
433 (DeflateMessageProcessor.disable_outgoing_compression):
434 (DeflateMessageProcessor._process_incoming_message):
435 (DeflateMessageProcessor._process_outgoing_message):
436 (DeflateMessageProcessor._process_incoming_frame):
437 (DeflateMessageProcessor._process_outgoing_frame):
438 (PerMessageCompressionExtensionProcessor):
439 (PerMessageCompressionExtensionProcessor.__init__):
440 (PerMessageCompressionExtensionProcessor.name):
441 (PerMessageCompressionExtensionProcessor._lookup_compression_processor):
442 (MuxExtensionProcessor):
443 (MuxExtensionProcessor.__init__):
444 (MuxExtensionProcessor.name):
445 (MuxExtensionProcessor.get_extension_response):
446 (MuxExtensionProcessor.setup_stream_options):
447 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py:
449 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py:
450 (validate_subprotocol):
451 (check_request_line):
452 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Removed.
453 * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py:
454 (Handshaker.do_handshake):
455 (Handshaker._set_protocol):
456 (Handshaker._create_stream):
458 (Handshaker._create_handshake_response):
459 (Handshaker._send_handshake):
460 * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py:
461 * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py:
463 * Scripts/webkitpy/thirdparty/mod_pywebsocket/mux.py: Added.
464 (MuxUnexpectedException):
465 (MuxNotImplementedException):
466 (LogicalConnectionClosedException):
467 (PhysicalConnectionError):
468 (PhysicalConnectionError.__init__):
469 (LogicalChannelError):
470 (LogicalChannelError.__init__):
471 (_encode_channel_id):
473 (_create_add_channel_response):
474 (_create_drop_channel):
475 (_create_flow_control):
476 (_create_new_channel_slot):
477 (_create_fallback_new_channel_slot):
478 (_parse_request_text):
480 (_ControlBlock.__init__):
481 (_MuxFramePayloadParser):
482 (_MuxFramePayloadParser.that):
483 (_MuxFramePayloadParser.__init__):
484 (_MuxFramePayloadParser.read_channel_id):
485 (_MuxFramePayloadParser.read_inner_frame):
486 (_MuxFramePayloadParser._read_number):
487 (_MuxFramePayloadParser._read_size_and_contents):
488 (_MuxFramePayloadParser._read_add_channel_request):
489 (_MuxFramePayloadParser._read_add_channel_response):
490 (_MuxFramePayloadParser._read_flow_control):
491 (_MuxFramePayloadParser._read_drop_channel):
492 (_MuxFramePayloadParser._read_new_channel_slot):
493 (_MuxFramePayloadParser.read_control_blocks):
494 (_MuxFramePayloadParser.remaining_data):
496 (_LogicalRequest.__init__):
497 (_LogicalRequest.is_https):
498 (_LogicalConnection):
499 (_LogicalConnection.__init__):
500 (_LogicalConnection.get_local_addr):
501 (_LogicalConnection.get_remote_addr):
502 (_LogicalConnection.get_memorized_lines):
503 (_LogicalConnection.write):
504 (_LogicalConnection.write_control_data):
505 (_LogicalConnection.notify_write_done):
506 (_LogicalConnection.append_frame_data):
507 (_LogicalConnection.read):
508 (_LogicalConnection.set_read_state):
510 (_LogicalStream.interprets):
511 (_LogicalStream.__init__):
512 (_LogicalStream._create_inner_frame):
513 (_LogicalStream._write_inner_frame):
514 (_LogicalStream.replenish_send_quota):
515 (_LogicalStream.consume_receive_quota):
516 (_LogicalStream.send_message):
517 (_LogicalStream._receive_frame):
518 (_LogicalStream.receive_message):
519 (_LogicalStream._send_closing_handshake):
520 (_LogicalStream.send_ping):
521 (_LogicalStream._send_pong):
522 (_LogicalStream.close_connection):
523 (_LogicalStream._drain_received_data):
525 (_OutgoingData.__init__):
526 (_PhysicalConnectionWriter):
527 (_PhysicalConnectionWriter.__init__):
528 (_PhysicalConnectionWriter.put_outgoing_data):
529 (_PhysicalConnectionWriter._write_data):
530 (_PhysicalConnectionWriter.run):
531 (_PhysicalConnectionWriter.stop):
532 (_PhysicalConnectionReader):
533 (_PhysicalConnectionReader.__init__):
534 (_PhysicalConnectionReader.run):
539 (_MuxHandshaker.__init__):
540 (_MuxHandshaker._create_stream):
541 (_MuxHandshaker._create_handshake_response):
542 (_MuxHandshaker._send_handshake):
543 (_LogicalChannelData):
544 (_LogicalChannelData.__init__):
545 (_HandshakeDeltaBase):
546 (_HandshakeDeltaBase.that):
547 (_HandshakeDeltaBase.__init__):
548 (_HandshakeDeltaBase.create_headers):
551 (_MuxHandler.__init__):
553 (_MuxHandler.add_channel_slots):
554 (_MuxHandler.wait_until_done):
555 (_MuxHandler.notify_write_done):
556 (_MuxHandler.send_control_data):
557 (_MuxHandler.send_data):
558 (_MuxHandler._send_drop_channel):
559 (_MuxHandler._send_error_add_channel_response):
560 (_MuxHandler._create_logical_request):
561 (_MuxHandler._do_handshake_for_logical_request):
562 (_MuxHandler._add_logical_channel):
563 (_MuxHandler._process_add_channel_request):
564 (_MuxHandler._process_flow_control):
565 (_MuxHandler._process_drop_channel):
566 (_MuxHandler._process_control_blocks):
567 (_MuxHandler._process_logical_frame):
568 (_MuxHandler.dispatch_message):
569 (_MuxHandler.notify_worker_done):
570 (_MuxHandler.notify_reader_done):
571 (_MuxHandler.fail_physical_connection):
572 (_MuxHandler.fail_logical_channel):
575 * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py:
576 (_StandaloneRequest.get_protocol):
577 (_StandaloneRequest):
579 (WebSocketServer.__init__):
580 (WebSocketServer._create_sockets):
581 (WebSocketServer.server_bind):
582 (WebSocketServer.server_activate):
583 (WebSocketRequestHandler.parse_request):
584 (_configure_logging):
585 (_build_option_parser):
588 * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py:
589 * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py:
590 (_Deflater.compress):
591 (_RFC1979Deflater.filter):
593 2012-10-09 Damian Kaleta <dkaleta@apple.com>
595 extract-localizable-strings script should be able to handle paths to files containing whitespaces.
596 https://bugs.webkit.org/show_bug.cgi?id=98844
598 Reviewed by Dan Bernstein.
600 * Scripts/extract-localizable-strings: Added ability to handle whitespace.
602 2012-10-09 Sudarsana Nagineni <sudarsana.nagineni@intel.com>
604 [Cairo] Bump Cairo to fix more canvas/philip tests
605 https://bugs.webkit.org/show_bug.cgi?id=97658
607 Reviewed by Martin Robinson.
609 Bumping cairo to version 1.12.4 which fixes more canvas/philip tests.
611 * efl/jhbuild.modules:
612 * gtk/jhbuild.modules:
614 2012-10-09 Julien Chaffraix <jchaffraix@webkit.org>
616 Unreviewed Chromium Windows build fix after r130823.
618 * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
619 (roleToString): Re-added the 'default' label as some cases are not handled.
621 2012-10-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
623 [chromium] Add drop event for plugins.
624 https://bugs.webkit.org/show_bug.cgi?id=98827
626 Reviewed by Adam Barth.
628 Update the test plugin to receive drop events.
630 * DumpRenderTree/chromium/TestWebPlugin.cpp:
631 (TestWebPlugin::handleDragStatusUpdate):
633 2012-10-09 Dominic Mazzoni <dmazzoni@google.com>
635 AX: 5 accessibility tests just need minor tweaks to pass on chromium
636 https://bugs.webkit.org/show_bug.cgi?id=98311
638 Reviewed by Chris Fleizach.
640 Update roleToString on Chromium to include all missing roles,
641 which enables some layout tests to pass.
643 * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
646 2012-10-09 Dirk Pranke <dpranke@chromium.org>
648 webkit-patch rebaseline-expectations doesn't work w/o failures specified
649 https://bugs.webkit.org/show_bug.cgi?id=98810
651 Reviewed by Ojan Vafai.
653 If you try to mark a test as foo.html [ Rebaseline ] it wasn't
654 getting picked up for rebaselining; we needed to think the test
657 * Scripts/webkitpy/layout_tests/models/test_expectations.py:
658 (TestExpectations.get_rebaselining_failures):
659 * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
660 (RebaseliningTest.test_get_rebaselining_failures):
662 2012-10-09 Daniel Bates <dbates@webkit.org>
664 VCSUtils.pm doesn't support SVN 1.7 diff files
665 <https://bugs.webkit.org/show_bug.cgi?id=80762>
667 Reviewed by Eric Seidel.
669 Implement support for the SVN 1.7 diff format.
671 * Scripts/VCSUtils.pm:
672 (parseChunkRange): Modified to support parsing an SVN 1.7 chunk range
673 that begins and ends with "##" (e.g. ## -0,0 +1,7 ##). For comparison,
674 earlier versions of SVN parsed chunk ranges of the form "@@ -0,0 +1,7 @@".
676 (parseSvnDiffHeader): Modified to parse an SVN 1.7 binary diff; SVN 1.7
677 has an unusual display format for a binary diff. It repeats the first
678 two lines of the diff header.
680 (parseSvnProperty): Modified to ignore both an SVN 1.7 chunk range and
681 lines of the form "\ No newline at end of property". SVN 1.7 emits the latter
682 message after a property value that doesn't end in a newline.
684 (parseSvnPropertyValue): Stop parsing an SVN property value when we encounter
685 a line of the form "\ No newline at end of property" (emitted by svn diff as of
688 * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
689 - Added the following unit tests:
691 "New line count is 1"
693 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
694 - Added the following unit tests:
695 "svn:executable followed by custom property using SVN 1.7 syntax"
696 "svn:executable followed by custom property without newline using SVN 1.7 syntax"
698 * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
699 - Updated test results for test "binary file".
700 - Added unit test "binary file using SVN 1.7 syntax".
702 * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
703 - Added the following unit tests:
704 "simple: add svn:executable using SVN 1.7 syntax"
705 "simple: delete svn:executable using SVN 1.7 syntax"
706 "add svn:mime-type and add svn:executable using SVN 1.7 syntax"
708 * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
709 - Added the following unit tests:
710 "singe-line '+' change using SVN 1.7 syntax"
711 "single-line '-' change using SVN 1.7 syntax"
713 2012-10-09 James Robinson <jamesr@chromium.org>
715 Unreviewed, rolling out r128488.
716 http://trac.webkit.org/changeset/128488
717 https://bugs.webkit.org/show_bug.cgi?id=96678
721 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
724 2012-10-09 Zan Dobersek <zandobersek@gmail.com>
726 XvfbDriver unit test is flaky on Linux builders
727 https://bugs.webkit.org/show_bug.cgi?id=98346
729 Reviewed by Adam Barth.
731 Temporarily skip the XvfbDriver test case that tests
732 the display number of the next free display. The test
733 is flaky on Linux builders.
735 * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
736 (XvfbDriverTest.disabled_test_next_free_display):
738 2012-10-09 Ojan Vafai <ojan@chromium.org>
740 Don't duplicated build numbers when merging flakiness dashboard JSON
741 https://bugs.webkit.org/show_bug.cgi?id=98812
743 Reviewed by Dirk Pranke.
745 In general, build numbers are not unique, but we should basically never
746 get the same build number uploaded twice in a row. This is a workaround
747 for https://bugs.webkit.org/show_bug.cgi?id=97643, which frequently hits this
748 because we update results_small.json and timeout updating results.json and then
749 we retry the whole request.
751 * TestResultServer/model/jsonresults.py:
753 * TestResultServer/model/jsonresults_unittest.py:
754 (JsonResultsTest.test_merge_duplicate_build_number):
756 2012-10-09 Alexis Menard <alexis@webkit.org>
758 [GTK] Shadow builds are not working anymore.
759 https://bugs.webkit.org/show_bug.cgi?id=98785
761 Reviewed by Martin Robinson.
763 When setting WEBKITOUTPUTDIR the build was failing with a python
764 error : the os.execve expect three arguments. Also the condition
765 to check whether we build the GTK port with jhbuild or not was buggy
766 as it was always assuming an in source build. We can use now jhbuildutils
767 which has a convenient function to locate the directory where
768 the dependencies built with jhbuild are and take into account WEBKITOUTPUTDIR.
769 If the Dependencies path does not exist then the build was not done using
770 jhbuild so we can fallback to a regular build against system libraries.
772 * gtk/run-with-jhbuild:
774 2012-10-08 Simon Fraser <simon.fraser@apple.com>
776 Remove DRT/WTR implementations of layerTreeAsText
777 https://bugs.webkit.org/show_bug.cgi?id=98697
779 Reviewed by Tim Horton, James Robinson, Alexey Proskuryakov.
781 Remove code related to layerTreeAsText(), which is now on window.internals.
783 * DumpRenderTree/TestRunner.cpp:
784 (TestRunner::staticFunctions):
785 * DumpRenderTree/TestRunner.h:
787 * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
788 * DumpRenderTree/chromium/DRTTestRunner.cpp:
789 (DRTTestRunner::DRTTestRunner):
790 * DumpRenderTree/chromium/DRTTestRunner.h:
792 * DumpRenderTree/efl/TestRunnerEfl.cpp:
793 * DumpRenderTree/gtk/TestRunnerGtk.cpp:
794 * DumpRenderTree/mac/TestRunnerMac.mm:
795 * DumpRenderTree/qt/TestRunnerQt.cpp:
796 * DumpRenderTree/qt/TestRunnerQt.h:
798 * DumpRenderTree/win/TestRunnerWin.cpp:
799 * DumpRenderTree/wx/TestRunnerWx.cpp:
800 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
801 * WebKitTestRunner/InjectedBundle/TestRunner.h:
803 2012-10-09 Zoltan Horvath <zoltan@webkit.org>
805 Unreviewed. Remove myself from QtWebKit2 subscriptions.
807 * Scripts/webkitpy/common/config/watchlist:
809 2012-10-09 Harald Alvestrand <hta@google.com>
811 Change PeerConnection getStats function to single value local / remote
812 elements in RTCStatsReport.
813 https://bugs.webkit.org/show_bug.cgi?id=98753
815 Reviewed by Adam Barth.
817 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
818 (MockWebRTCPeerConnectionHandler::getStats):
820 2012-10-09 Sadrul Habib Chowdhury <sadrul@chromium.org>
822 [chromium] Make sure events are transformed correctly for plugins.
823 https://bugs.webkit.org/show_bug.cgi?id=89250
825 Reviewed by Tony Chang.
827 Update the test plugin to print event details for mouse and gesture events.
829 * DumpRenderTree/chromium/TestWebPlugin.cpp:
832 2012-10-09 Simon Hausmann <simon.hausmann@digia.com>
834 Unreviewed trivial Qt build fix: Remove stray closing braces from r130758.
836 * qmake/mkspecs/features/features.prf:
838 2012-10-09 Simon Hausmann <simon.hausmann@digia.com>
840 [Qt] Clean up Qt module detection
842 Reviewed by Tor Arne Vestbø.
844 Replace the use of MOBILITY_CONFIG (not supported anymore) with modern use of haveQtModule.
846 * qmake/mkspecs/features/features.prf:
848 2012-10-09 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
850 [GTK] Respect WEBKITOUTPUTDIR in run-with-jhbuild.
851 https://bugs.webkit.org/show_bug.cgi?id=98732
853 Reviewed by Gustavo Noronha Silva.
855 Follow-up to r113066: if the WEBKITOUTPUTDIR environment variable
856 was used when running update-webkitgtk-libs,
857 WebKitBuild/Dependencies will not exist, so we now check its
858 contents first and then fall back to WebKitBuild/.
860 * gtk/run-with-jhbuild:
862 2012-10-09 Zan Dobersek <zandobersek@gmail.com>
864 Unreviewed GTK gardening.
866 Skipping the accept-policy test in TestCookieManager API test that's
867 currently failing. The test failure is covered by
868 https://bugs.webkit.org/show_bug.cgi?id=98738.
870 * Scripts/run-gtk-tests:
873 2012-10-09 Laszlo Gombos <l.gombos@samsung.com>
875 [Qt] Remove redundant JAVASCRIPTCORE_JIT variable
876 https://bugs.webkit.org/show_bug.cgi?id=50000
878 Reviewed by Simon Hausmann.
880 Use ENABLE_JIT instead.
882 * qmake/mkspecs/features/valgrind.prf:
884 2012-10-08 Kiran Muppala <cmuppala@apple.com>
886 Throttle DOM timers on hidden pages.
887 https://bugs.webkit.org/show_bug.cgi?id=98474
889 Reviewed by Maciej Stachowiak.
891 Implement testRunner.setPageVisibility on mac for testing throttling
892 of timers on hidden pages using DumpRenderTree.
894 * DumpRenderTree/mac/Configurations/Base.xcconfig:
895 Fix build error on mac-ews bot. Add JSC copy of ICU headers to search path.
897 * DumpRenderTree/mac/TestRunnerMac.mm:
898 (TestRunner::resetPageVisibility):
899 (TestRunner::setPageVisibility):
901 2012-10-08 Dirk Pranke <dpranke@chromium.org>
903 results.html and garden-o-matic are ignoring IMAGE failures when expected to FAIL
904 https://bugs.webkit.org/show_bug.cgi?id=98706
906 Reviewed by Ojan Vafai.
908 FAIL is supposed to map onto Failure which is supposed to map
909 onto the old [ TEXT, IMAGE_PLUS_TEXT, AUDIO ] mapping.
910 results.html was including IMAGE in this and garden-o-matic was
911 including CRASH and TIMEOUT as well :(.
913 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
914 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
916 2012-10-08 Ryuan Choi <ryuan.choi@samsung.com>
918 [EFL] Build ControlTheme only when necessary
919 https://bugs.webkit.org/show_bug.cgi?id=98519
921 Reviewed by Eric Seidel.
923 * EWebLauncher/ControlTheme/CMakeLists.txt:
924 Added custom command keyword not to build ControlTheme every time.
925 In addition, removed `ALL` keyword because targets, which use ControlTheme,
926 already have dependency.
928 2012-10-08 Peter Rybin <peter.rybin@gmail.com>
930 Do not swallow fatal messages in qt/DumpRenderTree
931 https://bugs.webkit.org/show_bug.cgi?id=98211
933 Reviewed by Eric Seidel.
935 Fix condition in message type filtering.
937 * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
940 2012-10-08 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
942 Unreviewed. Moving myself from Committer to Reviewer list.
943 http://lists.webkit.org/pipermail/webkit-dev/2012-October/022460.html
945 * Scripts/webkitpy/common/config/committers.py:
947 2012-10-08 Dirk Pranke <dpranke@chromium.org>
949 nrwt: [chromium] run http tests in parallel on bigger machines
950 https://bugs.webkit.org/show_bug.cgi?id=98562
952 Reviewed by Eric Seidel.
954 The "locked tests" shard (which includes the http tests and the
955 perf tests) is the long pole on machines where we have 4 or more
956 workers, so we should start making sure that
957 we can run http tests in parallel, following the normal sharding
958 rules (all tests in the same directory are in the same shard by
959 default). We should still probably limit the number of workers
960 hitting the web server in parallel where we can; a heuristic of
961 no more than 25% of them seems okay for a start. This will
962 likely only affect developer workstations and a couple of bots
963 at first, so should be low risk and a good reward.
965 * Scripts/webkitpy/layout_tests/port/base.py:
966 (Port.default_max_locked_shards):
967 * Scripts/webkitpy/layout_tests/port/chromium.py:
968 (ChromiumPort.default_max_locked_shards):
969 * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
970 (ChromiumPortTestCase.test_default_max_locked_shards):
971 * Scripts/webkitpy/layout_tests/port/port_testcase.py:
972 (PortTestCase.test_default_max_locked_shards):
973 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
974 (_set_up_derived_options):
976 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
977 (MainTest.test_max_locked_shards):
979 2012-10-08 Zan Dobersek <zandobersek@gmail.com>
981 GTK port should warn if bug modifier is missing in TestExpectations
982 https://bugs.webkit.org/show_bug.cgi?id=98678
984 Reviewed by Dirk Pranke.
986 Reimplement the warn_if_bug_missing_in_test_expectations method in
987 GtkPort, returning True for producing a warning in such cases.
989 * Scripts/webkitpy/layout_tests/port/gtk.py:
990 (GtkPort.warn_if_bug_missing_in_test_expectations):
992 2012-10-08 Ryuan Choi <ryuan.choi@samsung.com>
994 [EFL][DRT] Switch default backing store to single
995 https://bugs.webkit.org/show_bug.cgi?id=98591
997 Reviewed by Eric Seidel.
999 There are two backing stores for WebKit/Efl, Single Backing Store(SBS) and
1000 Tiled Backing Store(TBS), and DRT/Efl has used TBS.
1001 But, TBS is not suitable to run pixel tests because it does not have a good way
1002 to render mock scrollbars well.
1004 So, this patch changes the default backing store to SBS.
1005 In addition, this changes the environment variable from DRT_USE_SINGLE_BACKING_STORE
1006 to DRT_USE_TILED_BACKING_STORE.
1008 * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1009 (shouldUseTiledBackingStore):
1010 (chooseAndInitializeAppropriateSmartClass):
1012 2012-10-08 Sudarsana Nagineni <sudarsana.nagineni@intel.com>
1014 [WK2][WTR] WebKitTestRunner needs testRunner.dispatchPendingLoadRequests
1015 https://bugs.webkit.org/show_bug.cgi?id=98638
1017 Reviewed by Eric Seidel.
1019 Add implementation for testRunner.dispatchPendingLoadRequests in
1022 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1023 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1024 (WTR::TestRunner::dispatchPendingLoadRequests):
1026 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1029 2012-10-08 Christophe Dumez <christophe.dumez@intel.com>
1031 [EFL][WK2] Add support for window.close in Minibrowser
1032 https://bugs.webkit.org/show_bug.cgi?id=98667
1034 Reviewed by Laszlo Gombos.
1036 When calling window.close() from JavaScript, MiniBrowser
1037 now closes the given window.
1039 * MiniBrowser/efl/main.c:
1041 (on_ecore_evas_delete):
1045 2012-10-08 Ojan Vafai <ojan@chromium.org>
1047 Properly strip new tests from the test results json if they are pass/nodata/skip.
1048 https://bugs.webkit.org/show_bug.cgi?id=98669
1050 Reviewed by Eric Seidel.
1052 In _merge_json, we had a codepath that didn't call _normalize_results_json
1053 for tests that aren't already in the aggregated results.
1054 Instead, now do all the merging first and then normalize the aggregated results.
1056 * TestResultServer/model/jsonresults.py:
1057 (JsonResults._merge_json):
1058 (JsonResults._merge_tests):
1059 (JsonResults._normalize_results):
1061 (JsonResults._should_delete_leaf):
1062 * TestResultServer/model/jsonresults_unittest.py:
1063 Removed test_merge_build_directory_hierarchy_old_version since there is
1064 no longer any version 3 json to support.
1065 (JsonResultsTest.test_merge_remove_new_test):
1066 (JsonResultsTest.test_merge_prune_extra_results_with_new_result_of_same_type):
1068 2012-10-08 Christophe Dumez <christophe.dumez@intel.com>
1070 [EFL][WK2] Simplify frame flattening support in MiniBrowser
1071 https://bugs.webkit.org/show_bug.cgi?id=98657
1073 Reviewed by Kenneth Rohde Christiansen.
1075 Simplify frame flattening support code in MiniBrowser to
1076 avoid passing the setting around to window_create()
1079 * MiniBrowser/efl/main.c:
1085 2012-10-08 Christophe Dumez <christophe.dumez@intel.com>
1087 [EFL] Use Ctrl+n shortcut to create a new window in MiniBrowser / EWebLauncher
1088 https://bugs.webkit.org/show_bug.cgi?id=98655
1090 Reviewed by Kenneth Rohde Christiansen.
1092 Use "Ctrl+n" shortcut instead of "F9" to open a new window in
1093 MiniBrowser and EWebLauncher. This is the shortcut that is
1094 commonly used for this action.
1096 * EWebLauncher/main.c:
1098 * MiniBrowser/efl/main.c:
1101 2012-10-08 Christophe Dumez <christophe.dumez@intel.com>
1103 [EFL][WK2] Add support for window.create in Minibrowser
1104 https://bugs.webkit.org/show_bug.cgi?id=98649
1106 Reviewed by Kenneth Rohde Christiansen.
1108 Calling window.create() from JavaScript now creates a
1109 new window in Minibrowser, as directed.
1111 * MiniBrowser/efl/main.c:
1115 2012-10-08 Andreas Kling <kling@webkit.org>
1117 Using float/double as WTF hash table key is unreliable.
1118 <http://webkit.org/b/98627>
1120 Reviewed by Geoffrey Garen.
1122 Add a test case checking that using double as the hash table key type won't
1123 have problems distinguishing between keys that are considered equal by operator==
1124 but have different binary representations.
1126 * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1127 (TestDoubleHashTraits):
1129 2012-10-08 Christophe Dumez <christophe.dumez@intel.com>
1131 [EFL][WK2] Use URL instead of URI in the API
1132 https://bugs.webkit.org/show_bug.cgi?id=98643
1134 Reviewed by Kenneth Rohde Christiansen.
1136 Update Minibrowser to reflect API changes. We now
1137 use URL instead of URI in WK2 EFL API.
1139 * EWebLauncher/url_bar.c:
1140 (on_urlbar_key_down):
1141 * MiniBrowser/efl/CMakeLists.txt:
1142 * MiniBrowser/efl/main.c:
1146 2012-10-08 Balazs Kelemen <kbalazs@webkit.org>
1148 [Qt] Reenable plugin tests
1149 https://bugs.webkit.org/show_bug.cgi?id=98528
1151 Reviewed by Csaba Osztrogonác.
1153 Uncomment this function so we can pick up the test plugin.
1154 It was commented out because of https://bugs.webkit.org/show_bug.cgi?id=86620
1155 and that bug seems to be fixed now.
1157 * WebKitTestRunner/qt/TestControllerQt.cpp:
1158 (WTR::TestController::initializeTestPluginDirectory):
1160 2012-10-08 Jinwoo Song <jinwoo7.song@samsung.com>
1162 [EFL][WK2] Support multiple window creation for MiniBrowser
1163 https://bugs.webkit.org/show_bug.cgi?id=97884
1165 Reviewed by Kenneth Rohde Christiansen.
1167 Implement the multiple window creation for MiniBrowser and bind the 'F9' key for opening a new window.
1168 Also, refactored MiniBrowser codes according to EFL coding style.
1170 * MiniBrowser/efl/main.c:
1174 (on_ecore_evas_delete):
1175 (on_ecore_evas_resize):
1183 2012-10-07 Seokju Kwon <seokju.kwon@samsung.com>
1185 [EFL] Add Web Inspector to EWebLauncher
1186 https://bugs.webkit.org/show_bug.cgi?id=91718
1188 Reviewed by Gyuyoung Kim.
1190 Implementation of Web Inspector in EWebLauncher.
1191 The Web Inspector can be opened or closed by pressing ctrl+i on web page.
1193 * EWebLauncher/main.c:
1194 (on_browser_ecore_evas_resize):
1195 (on_web_inspector_ecore_evas_resize):
1197 (on_web_inspector_view_create):
1198 (on_web_inspector_view_close):
1199 (on_web_inspector_view_destroyed):
1201 (webInspectorCreate):
1205 (parseUserArguments):
1207 2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
1209 Rename first/second to key/value in HashMap iterators
1210 https://bugs.webkit.org/show_bug.cgi?id=82784
1212 Reviewed by Eric Seidel.
1214 * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
1215 (MockWebSpeechInputController::addMockRecognitionResult):
1216 * DumpRenderTree/chromium/NotificationPresenter.cpp:
1217 (NotificationPresenter::simulateClick):
1218 (NotificationPresenter::show):
1219 * DumpRenderTree/chromium/TestRunner/CppBoundClass.cpp:
1220 (CppBoundClass::~CppBoundClass):
1221 (CppBoundClass::invoke):
1222 (CppBoundClass::getProperty):
1223 (CppBoundClass::setProperty):
1224 (CppBoundClass::bindCallback):
1225 (CppBoundClass::bindProperty):
1226 * DumpRenderTree/chromium/WebPreferences.cpp:
1228 * DumpRenderTree/chromium/WebViewHost.cpp:
1229 (WebViewHost::printResourceDescription):
1230 * DumpRenderTree/mac/TestRunnerMac.mm:
1232 (TestRunner::evaluateScriptInIsolatedWorld):
1233 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1234 (AccessibilityController::~AccessibilityController):
1235 (AccessibilityController::winNotificationReceived):
1236 * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1237 (ResourceLoadDelegate::descriptionSuitableForTestResult):
1238 * DumpRenderTree/win/TestRunnerWin.cpp:
1240 (TestRunner::evaluateScriptInIsolatedWorld):
1241 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
1242 (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
1243 * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
1244 (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
1245 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1246 (WTR::TestRunner::worldIDForWorld):
1247 (WTR::TestRunner::evaluateScriptInIsolatedWorld):
1249 2012-10-07 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1251 Unreviewed, rolling out r130596.
1252 http://trac.webkit.org/changeset/130596
1253 https://bugs.webkit.org/show_bug.cgi?id=98616
1255 Broke build bots without IPV6 support
1257 * Scripts/webkitpy/common/system/platforminfo_mock.py:
1258 (MockPlatformInfo.is_cygwin):
1259 * Scripts/webkitpy/layout_tests/port/base.py:
1260 (Port.baseline_version_dir):
1261 (Port.to.start_websocket_server):
1262 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1263 (PortTest.test_operating_system):
1264 (PortTest.test_build_path):
1265 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1266 (LayoutTestApacheHttpd):
1267 (LayoutTestApacheHttpd.__init__):
1269 2012-10-07 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1271 webkitpy: Pass the `Listen' Apache directive from Apache, not the httpd.conf files.
1272 https://bugs.webkit.org/show_bug.cgi?id=98602
1274 Reviewed by Eric Seidel.
1276 Unify all the different `Listen' directives present in the several
1277 httpd.conf files we have in LayoutTests/http/conf. For one, we
1278 were already passing `Listen 127.0.0.1:8000' via webkitpy before,
1279 and opening the other ports from the conf files.
1281 The configuration files differed mostly in the way they handled
1282 IPV6 ports. Some of them did not listen to IPV6 ports because the
1283 systems which used them sometimes did not have IPV6 support. The
1284 `http_server_supports_ipv6' method has been added to Port to
1285 address that. cygwin, on its turn, still seems to use Apache 1.3,
1286 which does not support IPV6 at all; the newly-added method has a
1287 special case for that.
1289 * Scripts/webkitpy/common/system/platforminfo_mock.py:
1290 (MockPlatformInfo.is_cygwin):
1291 * Scripts/webkitpy/layout_tests/port/base.py:
1292 (Port.baseline_version_dir):
1293 (Port.to.start_websocket_server):
1295 (Port.to.http_server_supports_ipv6):
1296 * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1297 (PortTest.test_http_server_supports_ipv6):
1298 (PortTest.test_build_path):
1299 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1300 (LayoutTestApacheHttpd):
1301 (LayoutTestApacheHttpd.__init__):
1303 2012-10-05 Simon Fraser <simon.fraser@apple.com>
1305 Attempt to fix the SnowLeopard build to making the implementation of
1306 -isPaginated come before its use.
1308 * MiniBrowser/mac/WK1BrowserWindowController.m:
1309 (-[WK1BrowserWindowController reload:]):
1310 (-[WK1BrowserWindowController forceRepaint:]):
1311 (-[WK1BrowserWindowController goBack:]):
1312 (-[WK1BrowserWindowController goForward:]):
1313 (-[WK1BrowserWindowController isPaginated]):
1315 2012-10-05 Simon Fraser <simon.fraser@apple.com>
1317 Provide a way to run WebKit1
1318 https://bugs.webkit.org/show_bug.cgi?id=98568
1320 Reviewed by Tim Horton.
1322 Make it possible to create both WebKit1 and WebKit2 windows in MiniBrowser.
1324 Turn BrowserWindowController into a base class; subclassed by
1325 WK1BrowserWindowController and WK2BrowserWindowController, each of
1326 which implement the BrowserController protocol.
1328 Use Command-N to get a WebKit1 window, and Command-Option-N to
1329 get a WK2 window. Also add "Open Location" to focus the URL bar,
1330 and code to add an http:// if missing.
1332 Hook up window title callbacks; append " [WK1/2]" to window title
1335 * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1336 * MiniBrowser/mac/AppDelegate.m:
1337 (-[BrowserAppDelegate newWindow:]):
1338 (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
1339 * MiniBrowser/mac/BrowserWindowController.h:
1340 * MiniBrowser/mac/BrowserWindowController.m:
1341 (-[BrowserWindowController initWithWindow:]):
1342 (-[BrowserWindowController windowDidLoad]):
1343 (-[BrowserWindowController openLocation:]):
1344 (-[BrowserWindowController loadURLString:]):
1345 (-[BrowserWindowController applicationTerminating]):
1346 (-[BrowserWindowController addProtocolIfNecessary:]):
1347 * MiniBrowser/mac/MainMenu.xib:
1348 * MiniBrowser/mac/WK1BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
1350 * MiniBrowser/mac/WK1BrowserWindowController.m: Added.
1351 (-[WK1BrowserWindowController awakeFromNib]):
1352 (-[WK1BrowserWindowController dealloc]):
1353 (-[WK1BrowserWindowController loadURLString:]):
1354 (-[WK1BrowserWindowController fetch:]):
1355 (-[WK1BrowserWindowController showHideWebView:]):
1356 (-[WK1BrowserWindowController removeReinsertWebView:]):
1357 (-[WK1BrowserWindowController validateMenuItem:]):
1358 (-[WK1BrowserWindowController reload:]):
1359 (-[WK1BrowserWindowController forceRepaint:]):
1360 (-[WK1BrowserWindowController goBack:]):
1361 (-[WK1BrowserWindowController goForward:]):
1362 (-[WK1BrowserWindowController validateUserInterfaceItem:]):
1363 (-[WK1BrowserWindowController validateToolbar]):
1364 (-[WK1BrowserWindowController windowShouldClose:]):
1365 (-[WK1BrowserWindowController windowWillClose:]):
1366 (-[WK1BrowserWindowController applicationTerminating]):
1367 (-[WK1BrowserWindowController currentZoomFactor]):
1368 (-[WK1BrowserWindowController canZoomIn]):
1369 (-[WK1BrowserWindowController zoomIn:]):
1370 (-[WK1BrowserWindowController canZoomOut]):
1371 (-[WK1BrowserWindowController zoomOut:]):
1372 (-[WK1BrowserWindowController canResetZoom]):
1373 (-[WK1BrowserWindowController resetZoom:]):
1374 (-[WK1BrowserWindowController toggleZoomMode:]):
1375 (-[WK1BrowserWindowController isPaginated]):
1376 (-[WK1BrowserWindowController togglePaginationMode:]):
1377 (-[WK1BrowserWindowController find:]):
1378 (-[WK1BrowserWindowController dumpSourceToConsole:]):
1379 (-[WK1BrowserWindowController webView:didStartProvisionalLoadForFrame:]):
1380 (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1381 * MiniBrowser/mac/WK2BrowserWindowController.h: Copied from Tools/MiniBrowser/mac/BrowserWindowController.h.
1382 * MiniBrowser/mac/WK2BrowserWindowController.m: Copied from Tools/MiniBrowser/mac/BrowserWindowController.m.
1383 (-[WK2BrowserWindowController initWithContext:pageGroup:]):
1384 (-[WK2BrowserWindowController dealloc]):
1385 (-[WK2BrowserWindowController fetch:]):
1386 (-[WK2BrowserWindowController showHideWebView:]):
1387 (-[WK2BrowserWindowController removeReinsertWebView:]):
1388 (-[WK2BrowserWindowController validateMenuItem:]):
1389 (-[WK2BrowserWindowController reload:]):
1390 (-[WK2BrowserWindowController forceRepaint:]):
1391 (-[WK2BrowserWindowController goBack:]):
1392 (-[WK2BrowserWindowController goForward:]):
1393 (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1394 (-[WK2BrowserWindowController validateToolbar]):
1395 (-[WK2BrowserWindowController windowShouldClose:]):
1396 (-[WK2BrowserWindowController windowWillClose:]):
1397 (-[WK2BrowserWindowController applicationTerminating]):
1398 (-[WK2BrowserWindowController currentZoomFactor]):
1399 (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1400 (-[WK2BrowserWindowController canZoomIn]):
1401 (-[WK2BrowserWindowController zoomIn:]):
1402 (-[WK2BrowserWindowController canZoomOut]):
1403 (-[WK2BrowserWindowController zoomOut:]):
1404 (-[WK2BrowserWindowController canResetZoom]):
1405 (-[WK2BrowserWindowController resetZoom:]):
1406 (-[WK2BrowserWindowController toggleZoomMode:]):
1407 (-[WK2BrowserWindowController isPaginated]):
1408 (-[WK2BrowserWindowController togglePaginationMode:]):
1409 (-[WK2BrowserWindowController dumpSourceToConsole:]):
1410 (didStartProvisionalLoadForFrame):
1411 (didReceiveServerRedirectForProvisionalLoadForFrame):
1412 (didFailProvisionalLoadWithErrorForFrame):
1413 (didCommitLoadForFrame):
1414 (didFinishDocumentLoadForFrame):
1415 (didFinishLoadForFrame):
1416 (didFailLoadWithErrorForFrame):
1417 (didSameDocumentNavigationForFrame):
1418 (didReceiveTitleForFrame):
1419 (didFirstLayoutForFrame):
1420 (didFirstVisuallyNonEmptyLayoutForFrame):
1421 (didRemoveFrameFromHierarchy):
1422 (didDisplayInsecureContentForFrame):
1423 (didRunInsecureContentForFrame):
1424 (didDetectXSSForFrame):
1426 (didChangeProgress):
1427 (didFinishProgress):
1428 (didBecomeUnresponsive):
1429 (didBecomeResponsive):
1431 (didChangeBackForwardList):
1432 (decidePolicyForNavigationAction):
1433 (decidePolicyForNewWindowAction):
1434 (decidePolicyForResponse):
1438 (runJavaScriptAlert):
1439 (runJavaScriptConfirm):
1440 (runJavaScriptPrompt):
1442 (mouseDidMoveOverElement):
1445 (runBeforeUnloadConfirmPanel):
1447 (-[WK2BrowserWindowController awakeFromNib]):
1448 (-[WK2BrowserWindowController didStartProgress]):
1449 (-[WK2BrowserWindowController didChangeProgress:]):
1450 (-[WK2BrowserWindowController didFinishProgress]):
1451 (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
1452 (-[WK2BrowserWindowController didStartProvisionalLoadForFrame:]):
1453 (-[WK2BrowserWindowController didReceiveServerRedirectForProvisionalLoadForFrame:]):
1454 (-[WK2BrowserWindowController didFailProvisionalLoadWithErrorForFrame:]):
1455 (-[WK2BrowserWindowController didFailLoadWithErrorForFrame:]):
1456 (-[WK2BrowserWindowController didSameDocumentNavigationForFrame:]):
1457 (-[WK2BrowserWindowController didCommitLoadForFrame:]):
1458 (-[WK2BrowserWindowController loadURLString:]):
1459 (-[WK2BrowserWindowController performFindPanelAction:]):
1460 (-[WK2BrowserWindowController find:]):
1462 2012-10-05 Sudarsana Nagineni <sudarsana.nagineni@intel.com>
1464 [WK2][WTR] WebKitTestRunner needs testRunner.setSerializeHTTPLoads
1465 https://bugs.webkit.org/show_bug.cgi?id=98524
1467 Reviewed by Alexey Proskuryakov.
1469 Add implementation for testRunner.setSerializeHTTPLoads in
1472 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1473 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1474 (WTR::InjectedBundle::beginTesting):
1475 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1476 (WTR::TestRunner::setSerializeHTTPLoads):
1478 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1481 2012-10-05 Richard Larocque <rlarocque@chromium.org>
1483 TestResultsServer does not display sync_integration_tests results
1484 https://bugs.webkit.org/show_bug.cgi?id=98551
1486 Reviewed by Ojan Vafai.
1488 Allow builders whose name contains "Sync" to pass through the
1489 isChromiumWebkitDepsTestRunner filter.
1491 The test expectations in flakiness_dashboard_unittests.js have been
1492 updated to match the new behaviour.
1494 * TestResultServer/static-dashboards/builders.js:
1495 (isChromiumDepsGTestRunner):
1497 2012-10-05 Roger Fong <roger_fong@apple.com>
1499 Tests in webkitpy involving child processes are flaky.
1500 Skipping run_webkit_tests_integrationtest.py.
1501 https://bugs.webkit.org/show_bug.cgi?id=98559
1503 Reviewed by Dirk Pranke.
1505 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1506 (MainTest.test_verbose_in_child_processes):
1508 2012-10-05 Zan Dobersek <zandobersek@gmail.com>
1510 [Gtk] fast/xsl/xslt-missing-namespace-in-xslt.xml is failing on the 64-bit Debug builder
1511 https://bugs.webkit.org/show_bug.cgi?id=91009
1513 Reviewed by Martin Robinson.
1515 Include libxml2 into the jhbuild module. Version 2.8.0 introduces
1516 a more correct (but not completely correct) behavior in the
1517 fast/xsl/xslt-missing-namespace-in-xslt.html test.
1519 * gtk/jhbuild.modules:
1521 2012-10-05 Rob Buis <rbuis@rim.com>
1523 [BlackBerry] Implement TestRunner.setMockDeviceOrientation
1524 https://bugs.webkit.org/show_bug.cgi?id=98542
1526 Reviewed by Antonio Gomes.
1530 This fixes tests in fast/dom/DeviceOrientation.
1532 * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1533 (TestRunner::setMockDeviceOrientation):
1535 2012-10-05 Christophe Dumez <christophe.dumez@intel.com>
1537 [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
1538 https://bugs.webkit.org/show_bug.cgi?id=98256
1540 Reviewed by Kenneth Rohde Christiansen.
1542 Implement UIClient's focus callbacks for the main page in
1545 * WebKitTestRunner/TestController.cpp:
1547 (WTR::TestController::initialize):
1549 2012-10-05 Mark Hahnenberg <mhahnenberg@apple.com>
1551 JSC should have a way to gather and log Heap memory use and pause times
1552 https://bugs.webkit.org/show_bug.cgi?id=98431
1554 Reviewed by Geoffrey Garen.
1556 * DumpRenderTree/mac/DumpRenderTree.mm:
1557 (main): Added a check as to whether we should dump our JSC Heap statistics on exit.
1559 2012-10-05 Christophe Dumez <christophe.dumez@intel.com>
1561 [EFL][WK2] Fix mktemp() compilation warning in Minibrowser
1562 https://bugs.webkit.org/show_bug.cgi?id=98493
1564 Reviewed by Kenneth Rohde Christiansen.
1566 Fix wrong mktemp usage causing a compilation warning
1569 * MiniBrowser/efl/main.c:
1570 (on_download_request):
1572 2012-10-05 Christophe Dumez <christophe.dumez@intel.com>
1574 [WK2][WKTR] Avoid duplication of UIClient callbacks for main page and other pages
1575 https://bugs.webkit.org/show_bug.cgi?id=98503
1577 Reviewed by Kenneth Rohde Christiansen.
1579 Avoid the need for duplicating UIClient callbacks for main page
1580 and other pages by passing the view as clientInfo
1581 for those callbacks.
1583 Previously, callbacks for the main page were passed the
1584 TestController as clientInfo while the callbacks for other pages
1585 were passed the PlatformWebView as clientInfo. This was error prone
1586 and leads to useless code duplication.
1588 * WebKitTestRunner/TestController.cpp:
1589 (WTR::getWindowFrame):
1590 (WTR::setWindowFrame):
1591 (WTR::runBeforeUnloadConfirmPanel):
1592 (WTR::TestController::createOtherPage):
1593 (WTR::TestController::initialize):
1594 (WTR::TestController::decidePolicyForNotificationPermissionRequest):
1596 2012-10-05 Sadrul Habib Chowdhury <sadrul@chromium.org>
1598 [chromium] Allow dragging into plugins.
1599 https://bugs.webkit.org/show_bug.cgi?id=98277
1601 Reviewed by Tony Chang.
1603 Update the TestWebPlugin to receive drag events and print them out.
1605 * DumpRenderTree/chromium/TestWebPlugin.cpp:
1606 (TestWebPlugin::handleDragStatusUpdate):
1607 * DumpRenderTree/chromium/TestWebPlugin.h:
1610 2012-10-05 Jongseok Yang <js45.yang@samsung.com>
1612 [EFL][WK2] Remove "web" word from ewk_web_error APIs
1613 https://bugs.webkit.org/show_bug.cgi?id=97886
1615 Reviewed by Gyuyoung Kim.
1617 Remove "web" word from ewk_web_error APIs.
1618 "web" word was redundant because "ewk" means "EFL WebKit" and WK APIs for error does not have "web" word.
1620 * MiniBrowser/efl/main.c:
1623 2012-10-05 Csaba Osztrogonác <ossy@webkit.org>
1625 [Qt] Enable CSS compositing by default
1626 https://bugs.webkit.org/show_bug.cgi?id=98490
1628 Reviewed by Simon Hausmann.
1630 * qmake/mkspecs/features/features.pri:
1632 2012-10-05 Sheriff Bot <webkit.review.bot@gmail.com>
1634 Unreviewed, rolling out r130466.
1635 http://trac.webkit.org/changeset/130466
1636 https://bugs.webkit.org/show_bug.cgi?id=98495
1638 It made 12 tests crash on Qt-WK2 (Requested by Ossy on
1641 * WebKitTestRunner/TestController.cpp:
1643 (WTR::TestController::initialize):
1645 2012-10-05 Christophe Dumez <christophe.dumez@intel.com>
1647 [EFL] Fix window resizing / moving in WK1 and WKTR
1648 https://bugs.webkit.org/show_bug.cgi?id=98486
1650 Reviewed by Gyuyoung Kim.
1652 Fix PlatformWebView::windowFrame() and
1653 PlatformWebView::setWindowFrame() in EFL's WKTR so
1654 that it resizes / moves the window, not the view.
1656 The new code matches the implementation in EwkView's
1659 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1660 (WTR::PlatformWebView::windowFrame):
1661 (WTR::PlatformWebView::setWindowFrame):
1663 2012-10-04 KyungTae Kim <ktf.kim@samsung.com>
1665 [EFL][WK2] Fix destination path when download with suggested filename on the Minibrowser
1666 https://bugs.webkit.org/show_bug.cgi?id=98334
1668 Reviewed by Gyuyoung Kim.
1670 Add callback functions for download requests to Minibrowser to set the destination path for download.
1671 Set the destination path with suggested file name as (destination folder) + (suggested file name).
1672 The 'destination folder' should be a specific folder user selected, but is set to '/tmp' for now.
1674 Additionally, for printing out the download status,
1675 use the info macro and set the verbose variable to 1 to enable it.
1677 * MiniBrowser/efl/main.c:
1678 (on_download_request):
1679 (on_download_finished):
1680 (on_download_failed):
1683 2012-10-04 Christophe Dumez <christophe.dumez@intel.com>
1685 [WK2][WKTR] Implement UIClient focus callbacks in WebKitTestRunner
1686 https://bugs.webkit.org/show_bug.cgi?id=98256
1688 Reviewed by Kenneth Rohde Christiansen.
1690 Implement UIClient's focus callbacks in WebKitTestRunner.
1692 * WebKitTestRunner/TestController.cpp:
1694 (WTR::TestController::initialize):
1696 2012-10-04 Rik Cabanier <cabanier@adobe.com>
1698 Turn Compositing on by default in WebKit build
1699 https://bugs.webkit.org/show_bug.cgi?id=98315
1701 Reviewed by Simon Fraser.
1703 enable -webkit-blend-mode on trunk.
1705 * Scripts/webkitperl/FeatureList.pm:
1707 2012-10-04 Ryuan Choi <ryuan.choi@samsung.com>
1709 [EFL][WK2] Add APIs to get/set the frame flattening.
1710 https://bugs.webkit.org/show_bug.cgi?id=95982
1712 Reviewed by Gyuyoung Kim.
1714 * MiniBrowser/efl/main.c: Added frame flattening option to test.
1718 2012-10-04 Christophe Dumez <christophe.dumez@intel.com>
1720 [EFL] Add libxml 2.8.0 to jhbuild
1721 https://bugs.webkit.org/show_bug.cgi?id=98418
1723 Reviewed by Laszlo Gombos.
1725 Add libxml 2.8.0 to EFL's jhbuild for consistency.
1727 * efl/jhbuild.modules:
1729 2012-10-03 Benjamin Poulain <bpoulain@apple.com>
1731 [WK2] Support all attributes of GeolocationPosition
1732 https://bugs.webkit.org/show_bug.cgi?id=98212
1734 Reviewed by Sam Weinig.
1736 Expand WebKitTestRunner and DumpRenderTree to test all the attributes
1737 of GeolocationPosition.
1739 * DumpRenderTree/TestRunner.cpp:
1740 (setMockGeolocationPositionCallback):
1741 * DumpRenderTree/TestRunner.h:
1743 * DumpRenderTree/efl/TestRunnerEfl.cpp:
1744 (TestRunner::setMockGeolocationPosition):
1745 * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1746 (TestRunner::setMockGeolocationPosition):
1747 * DumpRenderTree/mac/TestRunnerMac.mm:
1748 (TestRunner::setMockGeolocationPosition):
1749 * DumpRenderTree/win/TestRunnerWin.cpp:
1750 (TestRunner::setMockGeolocationPosition):
1751 * DumpRenderTree/wx/TestRunnerWx.cpp:
1752 (TestRunner::setMockGeolocationPosition):
1753 * WebKitTestRunner/GeolocationProviderMock.cpp:
1754 (WTR::GeolocationProviderMock::setPosition):
1755 * WebKitTestRunner/GeolocationProviderMock.h:
1756 (GeolocationProviderMock):
1757 * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
1758 (_platformTypeVariableDeclaration):
1759 Use a proper constructor for the JSValueRef, it is an opaque type, we are not supposed
1760 to build the pointer outself.
1761 This is necessary to support optional JSValueRef properly.
1763 * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1764 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1765 (WTR::InjectedBundle::setMockGeolocationPosition):
1766 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1768 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1769 (WTR::TestRunner::setMockGeolocationPosition):
1770 * WebKitTestRunner/InjectedBundle/TestRunner.h:
1772 * WebKitTestRunner/TestController.cpp:
1773 (WTR::TestController::setMockGeolocationPosition):
1774 * WebKitTestRunner/TestController.h:
1776 * WebKitTestRunner/TestInvocation.cpp:
1777 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1779 2012-10-04 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1781 Make the Xvfb driver recognize `X' as a valid X server binary.
1782 https://bugs.webkit.org/show_bug.cgi?id=98434
1784 Reviewed by Dirk Pranke.
1786 The X server binary can also be called `X', so account for that
1787 possibility in the _next_free_display regexp.
1789 Additionally, make the regular expression require at least one
1790 space character after the `ps comm' part.
1792 * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1793 (XvfbDriver._next_free_display):
1794 * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1795 (XvfbDriverTest.test_next_free_display):
1797 2012-10-04 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1799 webkitpy: Accept WEBKITOUTPUTDIR in Port._setup_environ_for_server.
1800 https://bugs.webkit.org/show_bug.cgi?id=98436
1802 Reviewed by Dirk Pranke.
1804 The Xvfb driver (ab)uses Port._setup_environ_for_server() to set
1805 the environment for the server process, and the WEBKITOUTPUTDIR
1806 environment variable was not being passed through, causing the
1807 build directory to be wrongfully set to WebKitBuild/ all the time.
1809 * Scripts/webkitpy/layout_tests/port/base.py:
1810 (Port.to.setup_environ_for_server):
1812 2012-10-04 Christophe Dumez <christophe.dumez@intel.com>
1814 [EFL][WK2] Add setting to allow file access from file:// URLs
1815 https://bugs.webkit.org/show_bug.cgi?id=98121
1817 Reviewed by Laszlo Gombos.
1819 Allow file access from file:// URLs by default in Minibrowser
1820 to facilitate testing.
1822 * MiniBrowser/efl/main.c:
1825 2012-10-04 Christophe Dumez <christophe.dumez@intel.com>
1827 [EFL] Run unit tests with Xvfb
1828 https://bugs.webkit.org/show_bug.cgi?id=98389
1830 Reviewed by Laszlo Gombos.
1832 Run EFL unit tests with Xvfb, similarly to GTK port.
1834 * Scripts/run-efl-tests:
1836 2012-10-04 Adrian Perez de Castro <aperez@igalia.com>
1838 [GTK] Enable inspector by default in GtkLauncher/MiniBrowser
1839 https://bugs.webkit.org/show_bug.cgi?id=98333
1841 Reviewed by Xan Lopez.
1843 Both MiniBrowser and GtkLauncher are tools for testing, so in
1844 the end every time we want to test the inspector we have to
1845 manually enable enable the “developer extras” setting when using
1846 them. It make sense to have this setting enabled by default.
1848 * GtkLauncher/main.c:
1850 * MiniBrowser/gtk/main.c:
1853 2012-10-04 Harald Alvestrand <hta@google.com>
1855 Change RTCPeerConnection GetStats to use Date timestamp format
1856 https://bugs.webkit.org/show_bug.cgi?id=98263
1858 Reviewed by Yury Semikhatsky.
1860 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1861 (MockWebRTCPeerConnectionHandler::getStats):
1863 2012-10-04 Dirk Pranke <dpranke@chromium.org>
1865 [NRWT] --skipped option is ignored when --test-list is used
1866 https://bugs.webkit.org/show_bug.cgi?id=98260
1868 Reviewed by Ojan Vafai.
1870 Adds a --skipped=always flag that will skip any tests listed in
1871 TestExpectations even if they're listed explicitly on the
1874 This is most useful if you are using --test-list to specify a
1875 long list of files but you still want to skip some of them
1876 depending on what's in TestExpectations.
1878 * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1879 (LayoutTestFinder.skip_tests):
1880 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1882 * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1883 (MainTest.test_skipped_flag):
1885 2012-10-04 Sheriff Bot <webkit.review.bot@gmail.com>
1887 Unreviewed, rolling out r130377.
1888 http://trac.webkit.org/changeset/130377
1889 https://bugs.webkit.org/show_bug.cgi?id=98392
1891 Chromium Win compilation is broken (Requested by yurys on
1894 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1895 (MockWebRTCPeerConnectionHandler::getStats):
1897 2012-10-04 Harald Alvestrand <hta@google.com>
1899 Change RTCPeerConnection GetStats to use Date timestamp format
1900 https://bugs.webkit.org/show_bug.cgi?id=98263
1902 Reviewed by Adam Barth.
1904 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
1905 (MockWebRTCPeerConnectionHandler::getStats):
1907 2012-10-04 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
1909 Unreviewed, remove unused $legacyWebKitBlobBuilderSupport variable after r130343.
1911 * Scripts/webkitperl/FeatureList.pm:
1913 2012-10-03 Philip Rogers <pdr@google.com>
1915 Force GC between PageLoad tests.
1916 https://bugs.webkit.org/show_bug.cgi?id=98203
1918 Reviewed by Ryosuke Niwa.
1920 Previously, our PageLoad PerfTests had multi-modal distributions,
1921 typically with a small cluster at 1-2x the median. This turned out
1922 to be caused by not garbage collecting between tests!
1924 This patch adds a new file, force-gc.html, and loads this file between
1925 PageLoad tests to force a GC. I manually verified that this cleans up
1926 our perf test outliers.
1928 * Scripts/webkitpy/performance_tests/perftest.py:
1929 (PageLoadingPerfTest.__init__):
1930 (PageLoadingPerfTest):
1931 (PageLoadingPerfTest.run_single):
1933 This function now loads two pages: one to force a gc and
1934 then the test to run.
1936 * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1938 Modified several existing tests to show that the force-gc file
1942 (MockPort.__init__):
1943 (MockPort.perf_tests_dir):
1944 (TestPageLoadingPerfTest.MockDriver.__init__):
1945 (TestPageLoadingPerfTest.MockDriver.run_test):
1946 (TestPageLoadingPerfTest.test_run):
1947 (TestPageLoadingPerfTest.test_run_with_bad_output):
1948 (TestReplayPerfTest.ReplayTestPort):
1949 (TestReplayPerfTest.ReplayTestPort.__init__):
1950 (TestReplayPerfTest.test_run_single.run_test):
1951 (TestReplayPerfTest.test_run_single):
1952 (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1953 (TestPerfTestFactory.test_regular_test):
1954 (TestPerfTestFactory.test_inspector_test):
1955 (TestPerfTestFactory.test_page_loading_test):
1957 2012-10-03 Christophe Dumez <christophe.dumez@intel.com>
1959 [EFL] Enable use of X11 in DumpRenderTree / WebKitTestRunner
1960 https://bugs.webkit.org/show_bug.cgi?id=98231
1962 Reviewed by Gyuyoung Kim.
1964 Enable use of X11 in DumpRenderTree / WebKitTestRunner.
1965 Call ecore_evas_new() instead of ecore_evas_buffer_new()
1966 in EFL's DumpRenderTree and WebKitTestRunner.
1967 It is safe to do this now that we are using XvfbDriver
1968 for the layout tests.
1970 * DumpRenderTree/efl/DumpRenderTree.cpp:
1971 (parseCommandLineOptions):
1973 * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1974 (WTR::initEcoreEvas):
1975 * WebKitTestRunner/efl/main.cpp:
1978 2012-10-03 Dirk Pranke <dpranke@chromium.org>
1980 run-webkit-tests tests on win32 after r127302
1981 https://bugs.webkit.org/show_bug.cgi?id=98323
1983 Reviewed by Eric Seidel.
1985 run-webkit-tests tests on win32 after r127302
1986 https://bugs.webkit.org/show_bug.cgi?id=98323
1988 Reviewed by Eric Seidel.
1990 Looks like when we converted the json-building logic to use scm
1991 to try and get the svn revision, we missed a win32-ism and
1992 didn't check to make sure had initialized the scm subsystem.
1994 This change fixes that and renames _initialize_scm to be a public method.
1996 * Scripts/webkitpy/common/host.py:
1997 (Host.initialize_scm):
1998 * Scripts/webkitpy/common/host_mock.py:
1999 (MockHost.__init__):
2000 (MockHost.initialize_scm):
2001 * Scripts/webkitpy/layout_tests/controllers/manager.py:
2002 (summarize_results):
2003 * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2004 (JSONResultsGeneratorBase.get_json):
2005 (JSONResultsGeneratorBase._get_result_char):
2006 (JSONResultsGeneratorBase._get_svn_revision):
2007 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2008 (PerfTestsRunner.__init__):
2009 * Scripts/webkitpy/style/checkers/test_expectations.py:
2010 (TestExpectationsChecker.__init__):
2011 * Scripts/webkitpy/style/main.py:
2012 (CheckWebKitStyle.main):
2013 * Scripts/webkitpy/tool/main.py:
2014 (WebKitPatch.handle_global_options):
2015 * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2016 (get_test_baselines):
2018 2012-10-03 Adrian Perez de Castro <aperez@igalia.com>
2020 [GTK] Make inspector directly useable in GtkLauncher/MiniBrowser
2021 https://bugs.webkit.org/show_bug.cgi?id=98310
2023 Reviewed by Martin Robinson.
2025 Make MiniBrowser/GtkLauncher define the path to the inspector
2026 resources by setting the WEBKIT_INSPECTOR_PATH environment
2027 variable pointing to the copy of the inspector resources in
2028 the build directory. If the environment variable is already
2029 defined, its value is not overwritten. The path is derived
2030 from the WEBKIT_EXEC_PATH macro defined in the makefiles.
2033 * GtkLauncher/main.c:
2035 * MiniBrowser/gtk/main.c:
2038 2012-10-03 Benjamin Poulain <bpoulain@apple.com>
2040 Fix Geolocation/window-close-crash.html and harden WebKitTestRunner for Geolocation
2041 https://bugs.webkit.org/show_bug.cgi?id=97608
2043 Reviewed by Sam Weinig.
2045 The test fast/dom/Geolocation/window-close-crash.html was crashing because
2046 handleGeolocationPermissionRequest() was executed on the wrong pointer. Depending on how
2047 the page was created, the void* clientInfo can either be a PlatformWebView or
2050 Using the global TestController fixes the issue.
2052 * WebKitTestRunner/GeolocationProviderMock.cpp:
2053 (WTR::GeolocationProviderMock::setPosition):
2054 (WTR::GeolocationProviderMock::setPositionUnavailableError):
2055 To be reliable, the test fast/dom/Geolocation/maximum-age.html needs the setting the position
2056 to clear the error and vice versa.
2057 This is the same behavior as GeolocationClientMock and MockGeolocationProvider of WebKit1.
2059 (WTR::GeolocationProviderMock::sendPositionIfNeeded):
2060 (WTR::GeolocationProviderMock::sendErrorIfNeeded):
2061 Some tests expect the position/error cant be sent multiple time,
2062 just keep the position after sending.
2064 * WebKitTestRunner/TestController.cpp:
2065 (WTR::decidePolicyForGeolocationPermissionRequest):
2066 (WTR::TestController::decidePolicyForGeolocationPermissionRequestIfPossible):
2067 * WebKitTestRunner/TestController.h:
2068 Let's play as if we did not know what is in GeolocationPermissionRequestManagerProxy like a real
2069 client would have to do.
2071 2012-10-03 Otto Derek Cheung <otcheung@rim.com>
2073 [BlackBerry] Implementing the NetworkInfo API for BB port
2074 https://bugs.webkit.org/show_bug.cgi?id=98273
2076 Reviewed by Rob Buis.
2078 Enabling NetworkInfo API for the BlackBerry port.
2080 * Scripts/webkitperl/FeatureList.pm:
2082 2012-10-03 Anders Carlsson <andersca@apple.com>
2084 Exception thrown when running accessibility/container-node-delete-causes-crash.html test
2085 https://bugs.webkit.org/show_bug.cgi?id=98291
2087 Reviewed by Andreas Kling.
2089 The accessibility/container-node-delete-causes-crash.html test will cause a full accessibility tree
2090 to be created by trying to look up an element with a non-existent ID. This caused an exception to be thrown
2091 when trying to access the children of an element that didn't have any children. Fix this by adding
2092 BEGIN_AX_OBJC_EXCEPTIONS/END_AX_OBJC_EXCEPTIONS around the call to get the children.
2094 * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2095 (findAccessibleObjectById):
2097 2012-10-03 Ojan Vafai <ojan@chromium.org>
2099 Make partytime work when loading garden-o-matic from trac.webkit.org
2100 https://bugs.webkit.org/show_bug.cgi?id=98283
2102 Reviewed by Adam Barth.
2104 CSP was blocking the reqest for partytime.gif because 'self' wasn't on the img-src directive.
2105 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2107 2012-10-03 Roger Fong <roger_fong@apple.com>
2109 Unreviewed. Adding sys.platform check to skip a failing assert on the Apple Windows platform.
2110 https://bugs.webkit.org/show_bug.cgi?id=98288
2112 * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2113 (ChromiumAndroidDriverTest.test_command_from_driver_input):
2115 2012-10-03 Ojan Vafai <ojan@chromium.org>
2117 Get rid of warning about non-existant platform name when loading garden-o-matic
2118 https://bugs.webkit.org/show_bug.cgi?id=98282
2120 Reviewed by Adam Barth.
2122 If you loaded without a platform query parameter we'd return "null" as the platform name
2124 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2125 * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2127 2012-10-03 Balazs Kelemen <kbalazs@webkit.org>
2129 [Qt] Enable mock scrollbars
2130 https://bugs.webkit.org/show_bug.cgi?id=98011
2132 Reviewed by Csaba Osztrogonác.
2134 Enable mock scrollbars for the Qt port. This patch will require a huge rebaseline.
2136 * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2137 (WebCore::DumpRenderTree::DumpRenderTree):
2138 * WebKitTestRunner/TestController.cpp:
2139 (WTR::TestController::resetStateToConsistentValues):
2141 2012-10-03 Alberto Garcia <agarcia@igalia.com>
2143 [GTK] [WK2] Add favicon support to the MiniBrowser
2144 https://bugs.webkit.org/show_bug.cgi?id=98063
2146 Reviewed by Carlos Garcia Campos.
2148 Set the icon in the URI text entry using the favicon property of
2151 * MiniBrowser/gtk/BrowserWindow.c:
2153 (updateUriEntryIcon):
2154 (uriEntryTextChanged):
2156 (browserWindowFinalize):
2157 (browser_window_init):
2158 (browserWindowConstructed):
2160 2012-10-03 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
2162 [Qt][DRT] Add support for overriding the "WebKitDisplayImagesKey" preference.
2163 https://bugs.webkit.org/show_bug.cgi?id=98200
2165 Reviewed by Csaba Osztrogonác.
2167 * DumpRenderTree/qt/TestRunnerQt.cpp:
2168 (TestRunner::overridePreference):
2170 2012-10-03 Zoltan Arvai <zarvai@inf.u-szeged.hu>
2172 [Qt][WRT] Fix build error with MSVC on Windows.
2173 https://bugs.webkit.org/show_bug.cgi?id=97697
2175 Reviewed by Simon Hausmann.
2177 WTR build is failing when WebKit directory is located on a longer path.
2178 This seems to caused by source files that has the same name in
2179 WTR and DRT directories. The solution is removing referencies
2180 from Target.pri to DRT directory and adding an alternate version of
2181 the required files to WTR. Those files simply include the real ones from DRT.
2183 * WebKitTestRunner/InjectedBundle/Target.pri:
2184 * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Added.
2185 * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Added.
2187 2012-10-03 Christophe Dumez <christophe.dumez@intel.com>
2189 [WK2][WKTR] TestRunner.setAlwaysAcceptCookies() causes flakiness
2190 https://bugs.webkit.org/show_bug.cgi?id=98238
2192 Reviewed by Csaba Osztrogonác.
2194 Reset AlwaysAcceptCookies setting between tests to avoid
2195 flakiness due to TestRunner.setAlwaysAcceptCookies().
2197 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2198 (WTR::InjectedBundle::beginTesting):
2200 2012-10-03 Harald Alvestrand <hta@google.com>
2202 Add data passing to the GetStats interface of RTCPeerConnection
2203 https://bugs.webkit.org/show_bug.cgi?id=98003
2205 Reviewed by Adam Barth.
2207 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2208 (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
2209 (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
2210 (MockWebRTCPeerConnectionHandler::addStream):
2211 (MockWebRTCPeerConnectionHandler::removeStream):
2212 (MockWebRTCPeerConnectionHandler::getStats):
2213 * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2214 (MockWebRTCPeerConnectionHandler):
2216 == Rolled over to ChangeLog-2012-10-02 ==