03cbb5e713d338ff3dbfda7f6dc0b98fbc20dcf9
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-24  Mark Rowe  <mrowe@apple.com>
2
3         Remove references to OS X 10.7 from Xcode configuration settings.
4
5         Now that we're not building for OS X 10.7 they're no longer needed.
6
7         Reviewed by Anders Carlsson.
8
9         * DumpRenderTree/mac/Configurations/Base.xcconfig:
10         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
11         * MiniBrowser/Configurations/Base.xcconfig:
12         * MiniBrowser/Configurations/DebugRelease.xcconfig:
13         * TestWebKitAPI/Configurations/Base.xcconfig:
14         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
15         * WebKitLauncher/Configurations/Base.xcconfig:
16         * WebKitTestRunner/Configurations/Base.xcconfig:
17         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
18
19 2013-10-24  Mark Rowe  <mrowe@apple.com>
20
21         <rdar://problem/15312643> Prepare for the mysterious future.
22
23         Reviewed by David Kilzer.
24
25         * DumpRenderTree/mac/Configurations/Base.xcconfig:
26         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
27         * MiniBrowser/Configurations/Base.xcconfig:
28         * MiniBrowser/Configurations/DebugRelease.xcconfig:
29         * TestWebKitAPI/Configurations/Base.xcconfig:
30         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
31         * WebKitLauncher/Configurations/Base.xcconfig:
32         * WebKitTestRunner/Configurations/Base.xcconfig:
33         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
34
35 2013-10-24  Daniel Bates  <dabates@apple.com>
36
37         Crash in WebCore::NavigationScheduler::startTimer()
38         https://bugs.webkit.org/show_bug.cgi?id=123288
39         <rdar://problem/14055644>
40
41         Reviewed by Alexey Proskuryakov.
42
43         Add API test.
44
45         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.html: Added.
47         * TestWebKitAPI/Tests/mac/WillPerformClientRedirectToURLCrash.mm: Added.
48
49 2013-10-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
50
51         [GTK] Disable css-image-orientation
52         https://bugs.webkit.org/show_bug.cgi?id=123257
53
54         Reviewed by Martin Robinson.
55
56         CSS image orientation isn't stable yet. So, test regression happen since r157909.
57         This feature should be enabled again after it is stable.
58
59         * Scripts/webkitperl/FeatureList.pm:
60
61 2013-10-24  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
62
63         Fix argument passing for jhbuild.
64         https://bugs.webkit.org/show_bug.cgi?id=123253
65
66         Reviewed by Gustavo Noronha Silva.
67
68         The update-webkit-libs-jhbuild previously didn't allowed
69         extra arguments to be passed to jhbuild.
70
71         * Scripts/update-webkit-libs-jhbuild:
72         (runJhbuild):
73         * Scripts/update-webkitefl-libs:
74
75 2013-10-24  Sanghyup Lee  <sh53.lee@samsung.com>
76
77         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
78         https://bugs.webkit.org/show_bug.cgi?id=123251
79
80         Reviewed by Csaba Osztrogonác.
81
82         Replace %llu by PRIu64 macro to print an uint64_t value and silent a
83         compilation warning on 64-Bit.
84
85         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
86         (onExceededDatabaseQuota):
87
88 2013-10-24  Ryuan Choi  <ryuan.choi@samsung.com>
89
90         [EFL] Build break with latest EFL 1.8 libraries.
91         https://bugs.webkit.org/show_bug.cgi?id=123245
92
93         Reviewed by Gyuyoung Kim.
94
95         After fixed build break on EFL 1.8 at r138326, EFL libraries are changed
96         Eo typedef and splitted header files which contain version macro.
97
98         * TestWebKitAPI/PlatformWebView.h: Changed Eo typedef.
99         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
100         * WebKitTestRunner/PlatformWebView.h: Ditto.
101
102 2013-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
103
104         [GObject bindings] Make EventTarget interface introspectable
105         https://bugs.webkit.org/show_bug.cgi?id=77835
106
107         Reviewed by Gustavo Noronha Silva.
108
109         * Scripts/webkitpy/style/checker.py: Add exceptions for custom
110         GObject DOM bindings headers.
111
112 2013-10-23  Lucas Forschler  <lforschler@apple.com>
113
114         Add two more mac bots to the Mavericks Test Queue.
115         
116         Unreviewed.
117         
118         * BuildSlaveSupport/build.webkit.org-config/config.json:
119
120 2013-10-23  Filip Pizlo  <fpizlo@apple.com>
121
122         Have a way of dealing with slow tests in run-jsc-stress-tests
123         https://bugs.webkit.org/show_bug.cgi?id=123221
124
125         Reviewed by Mark Hahnenberg.
126         
127         If you add the slow! command to //@ then all subsequent plans are prepended to the run list
128         rather than appended to it. This means that slow tests get queued up first and are less likely
129         to block completion.
130
131         * Scripts/run-jsc-stress-tests:
132
133 2013-10-23  Alex Christensen  <achristensen@webkit.org>
134
135         Explicitly build Win32 or x64 configuration on Windows.
136         https://bugs.webkit.org/show_bug.cgi?id=123206
137
138         Reviewed by Brent Fulgham.
139
140         * Scripts/webkitdirs.pm:
141         (jscPath):
142         (determineConfigurationForVisualStudio):
143         (determinePassedConfiguration):
144         Add |Win32 to the end of 32-bit Visual Studio build configurations.
145         (safariPath):
146         * Scripts/build-webkit:
147         * Scripts/old-run-webkit-tests:
148         * Scripts/run-api-tests:
149         (testToolPath):
150         * Scripts/run-javascriptcore-tests:
151         (testapiPath):
152         * Scripts/run-regexp-tests:
153         (testapiPath):
154         * Scripts/sunspider-compare-results:
155         (pathToBuiltJSC):
156         Use configuration instead of configurationForVisualStudio, which are now always different.
157
158 2013-10-23  Mark Lam  <mark.lam@apple.com>
159
160         Re-instate ProposedDatabases needed by detailsForNameAndOrigin().
161         https://bugs.webkit.org/show_bug.cgi?id=123131.
162
163         Reviewed by Geoffrey Garen.
164
165         Updated these files to allow database quotas to grow within a limit for
166         testing purposes.
167
168         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
169         (BlackBerry::WebKit::DumpRenderTree::exceededDatabaseQuota):
170         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
171         (onExceededDatabaseQuota):
172         * DumpRenderTree/mac/UIDelegate.mm:
173         (-[UIDelegate webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]):
174         * DumpRenderTree/win/UIDelegate.cpp:
175         (UIDelegate::exceededDatabaseQuota):
176         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
177         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
178         * WebKitTestRunner/TestController.cpp:
179         (WTR::exceededDatabaseQuota):
180
181 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
182
183         It's valid to have a build ID of 0.
184
185         Reviewed by Tim Hatcher.
186
187         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
188         (BuildbotIteration):
189
190 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
191
192         Remove Lion bots from the Dashboard.
193
194         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
195         (WebKitBuildbot):
196
197 2013-10-23  Mario Sanchez Prada  <mario.prada@samsung.com>
198
199         [GTK] Expose image links properly
200         https://bugs.webkit.org/show_bug.cgi?id=84044
201
202         Reviewed by Chris Fleizach.
203
204         Expose the accessible URL if present, as yet another attribute
205         for the AccessibilityUIElement wrapper. For coherence with what
206         the Mac port does (and what you would expect as the output of
207         the layout test), we strip the absolute URL path for relative
208         references, if it's the case, leaving the base of the URL path
209         out of the exposed string.
210
211         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
212         (attributesOfElement): Print the AXURL, if available.
213         (AccessibilityUIElement::url): Expose the URL if present. That
214         is, if the wrapped AtkObject implements AtkHyperlinkImpl.
215         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
216         (attributesOfElement): Print the AXURL, if available.
217         (WTR::AccessibilityUIElement::url): Expose the URL if present.
218         That is, if the wrapped AtkObject implements AtkHyperlinkImpl.
219
220 2013-10-23  Simon Fraser  <simon.fraser@apple.com>
221
222         Remove Lion bots.
223
224         * BuildSlaveSupport/build.webkit.org-config/config.json:
225
226 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
227
228         Dashboard repaints constantly
229         https://bugs.webkit.org/show_bug.cgi?id=122133
230
231         Reviewed by Tim Horton.
232         
233         Pulsing shadows are really bad for battery life.
234
235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
236         (.status-line.bad .bubble):
237         (.status-line.bad .message):
238
239 2013-10-22  Commit Queue  <commit-queue@webkit.org>
240
241         Unreviewed, rolling out r157835.
242         http://trac.webkit.org/changeset/157835
243         https://bugs.webkit.org/show_bug.cgi?id=123192
244
245         broke 32-bit builds (Requested by smfr on #webkit).
246
247         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
248         (TestWebKitAPI::TEST):
249
250 2013-10-22  Jer Noble  <jer.noble@apple.com>
251
252         [WTF] Add a multiplication operator (and a few others) to MediaTime
253         https://bugs.webkit.org/show_bug.cgi?id=123137
254
255         Reviewed by Eric Carlson.
256
257         Add tests for new MediaTime operators.
258
259         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
260         (TestWebKitAPI::TEST):
261
262 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
263
264         Educate webkitpy about Mavericks.
265
266         Reviewed by Ryosuke Niwa.
267
268         * Scripts/webkitpy/common/system/platforminfo.py:
269         (PlatformInfo._determine_mac_version):
270         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
271         (TestPlatformInfo.test_os_version):
272         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
273         (TestExpectationParser):
274         * Scripts/webkitpy/port/builders.py:
275         * Scripts/webkitpy/port/mac.py:
276         (MacPort):
277         * Scripts/webkitpy/port/mac_unittest.py:
278         (test_versions):
279         (test_baseline_search_path):
280         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
281         (TestRebaselineTest.test_baseline_directory):
282         (TestRebaselineExpectations.test_rebaseline_expectations):
283
284 2013-10-22  Stephanie Lewis  <slewis@apple.com>
285
286         Update the build trigger list for Mavericks.
287
288         Unreviewed.
289
290         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
291         (_should_file_trigger_build):
292
293 2013-10-22  Simon Fraser  <simon.fraser@apple.com>
294
295         Add Mavericks bots to the dashboard.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
298         (WebKitBuildbot):
299
300 2013-10-22  Samuel White  <samuel_white@apple.com>
301
302         AX: Add paramAttrs to fetch start and end text markers in a given rect.
303         https://bugs.webkit.org/show_bug.cgi?id=122164
304
305         Reviewed by Chris Fleizach.
306
307         Added accessibility element hooks to test endTextMarkerForBounds and startTextMarkerForBounds.
308
309         * DumpRenderTree/AccessibilityUIElement.cpp:
310         (endTextMarkerForBoundsCallback):
311         (startTextMarkerForBoundsCallback):
312         (AccessibilityUIElement::endTextMarkerForBounds):
313         (AccessibilityUIElement::startTextMarkerForBounds):
314         (AccessibilityUIElement::getJSClass):
315         * DumpRenderTree/AccessibilityUIElement.h:
316         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
317         (AccessibilityUIElement::endTextMarkerForBounds):
318         (AccessibilityUIElement::startTextMarkerForBounds):
319         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
320         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
321         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
322         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
323         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
324         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
325         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
326         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
327         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
328         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
329         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
330
331 2013-10-22  Ryosuke Niwa  <rniwa@webkit.org>
332
333         There should be a way to specify additional repository paths in NRWT
334         https://bugs.webkit.org/show_bug.cgi?id=123135
335
336         Reviewed by Alexey Proskuryakov.
337
338         Added --additional-repository-name and --additional-repository-path options to NRWT.
339         These options allow us to submit addtional repository information, such as of Safari's
340         to the new flakiness dashboard.
341
342         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
343         (parse_args):
344         * Scripts/webkitpy/port/base.py:
345         (Port.repository_paths):
346
347 2013-10-22  Commit Queue  <commit-queue@webkit.org>
348
349         Unreviewed, rolling out r157774.
350         http://trac.webkit.org/changeset/157774
351         https://bugs.webkit.org/show_bug.cgi?id=123167
352
353         causes python test to fail (Requested by smfr on #webkit).
354
355         * Scripts/webkitpy/layout_tests/controllers/manager.py:
356         (Manager.run):
357         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
358         (TestExpectations.__init__):
359         (TestExpectations._add_expectations):
360         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
361         (parse_args):
362         (_set_up_derived_options):
363
364 2013-10-22  Lucas Forschler  <lforschler@apple.com>
365
366         Prepare WebKit Buildbot master for Mavericks.
367         This adds the following bot configurations:
368             Mavericks Release/Debug builders
369             Mavericks Release/Debug WK1 Testers
370             Mavericks Release/Debug WK2 Testers
371
372         Unreviewed.
373         
374         * BuildSlaveSupport/build.webkit.org-config/config.json:
375
376 2013-10-21  Tamas Gergely  <gertom@inf.u-szeged.hu>
377
378         Run tests as if they are expected to pass when --force is given.
379         https://bugs.webkit.org/show_bug.cgi?id=112890
380
381         Reviewed by Ryosuke Niwa.
382
383         The --force switch of new-run-webkit-tests is now forces all tests to
384         be run with 'PASS' as expected result.
385
386         * Scripts/webkitpy/layout_tests/controllers/manager.py:
387         (Manager.run):
388         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
389         (TestExpectations.__init__):
390         (TestExpectations._add_expectations):
391         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
392         (parse_args):
393         (_set_up_derived_options):
394
395 2013-10-21  Mark Rowe  <mrowe@apple.com>
396
397         Add a version of WebKitSystemInterface for Mavericks.
398
399         Reviewed by Ryosuke Niwa.
400
401         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
402         * Scripts/copy-webkitlibraries-to-product-directory:
403         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
404
405 2013-10-21  Anders Carlsson  <andersca@apple.com>
406
407         Navigation policy callback not called when performing the same fragment navigation twice
408         https://bugs.webkit.org/show_bug.cgi?id=123121
409         <rdar://problem/15230466>
410
411         Reviewed by Beth Dakin.
412
413         Add a test.
414
415         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
416         * TestWebKitAPI/Tests/mac/FragmentNavigation.html: Added.
417         * TestWebKitAPI/Tests/mac/FragmentNavigation.mm: Added.
418         (+[WebKit1FragmentNavigationTestDelegate shared]):
419         (-[WebKit1FragmentNavigationTestDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
420         (-[WebKit1FragmentNavigationTestDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
421         (-[WebKit1FragmentNavigationTestDelegate webView:didFinishLoadForFrame:]):
422         (-[WebKit1FragmentNavigationTestDelegate _runNextTestWithWebView:]):
423         (TestWebKitAPI::TEST):
424
425 2013-10-21  Dan Bernstein  <mitz@apple.com>
426
427         Style checker should allow a space after the @property keyword
428         https://bugs.webkit.org/show_bug.cgi?id=123117
429
430         Reviewed by Anders Carlsson.
431
432         * Scripts/webkitpy/style/checkers/cpp.py:
433         (check_spacing_for_function_call): Allow a space between @property and the following (
434         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
435         (CppStyleTest.test_spacing_for_fncall): Added a test case.
436
437 2013-10-21  peavo@outlook.com  <peavo@outlook.com>
438
439         [WinCairo] Build does not start.
440         https://bugs.webkit.org/show_bug.cgi?id=123059
441
442         Reviewed by Csaba Osztrogonác.
443
444         The function isAppleWinWebKit() does no longer return true for WinCairo, need to add isWinCairo() checks instead.
445
446         * Scripts/build-webkit:
447
448 2013-10-21  Zan Dobersek  <zdobersek@igalia.com>
449
450         [Jhbuild] Bump the required Jhbuild revision
451         https://bugs.webkit.org/show_bug.cgi?id=123089
452
453         Reviewed by Carlos Garcia Campos.
454
455         * jhbuild/jhbuild-wrapper: Latest versions of the gnome-common tools produce failures when configuring Jhbuild
456         due to the configure.ac script using both IT_PROG_INTLTOOL and AM_GNU_GETTEXT macros. This is already fixed
457         in the Jhbuild source so a more recent revision of it should be used.
458
459 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
460
461         Mac build fix.
462
463         * DumpRenderTree/mac/DumpRenderTree.mm: Cast the length for %lu specifier.
464
465 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
466
467         Enable webaudio/ tests on DRT/Mac
468         https://bugs.webkit.org/show_bug.cgi?id=86914
469
470         Reviewed by Darin Adler.
471
472         * DumpRenderTree/ForwardingHeaders/runtime/ArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/ArrayBufferView.h.
473         * DumpRenderTree/ForwardingHeaders/runtime/JSArrayBufferView.h: Copied from Source/WebCore/ForwardingHeaders/runtime/JSArrayBufferView.h.
474         * DumpRenderTree/ForwardingHeaders/runtime/TypedArrayInlines.h: Copied from Source/WebCore/ForwardingHeaders/runtime/TypedArrayInlines.h.
475         There is no way to efficiently get TypedArray buffer using API, so we need some internal headers.
476
477         * DumpRenderTree/TestRunner.cpp:
478         (setAudioResultCallback): 
479         (TestRunner::staticFunctions):
480         * DumpRenderTree/TestRunner.h:
481         (TestRunner::audioResult):
482         (TestRunner::setAudioResult):
483         The function has a different name and argument type now, updated accordingly.
484         Changed buffer from std::string to std::vector<char>, because it's more idiomatic.
485
486         * DumpRenderTree/mac/DumpRenderTree.mm:
487         (dumpAudio): Updated for the new name of audioResult accessor.
488         (dump): Print the result in the format webkitpy currently expects.
489
490         * WebKitTestRunner/TestInvocation.cpp:
491         (WTR::TestInvocation::dumpAudio): fwrite the whole block at once, splitting into
492         chunks made no sense.
493
494         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
495         (WTR::TestRunner::setAudioResult): Added a FIXME about getting off WKBundle SPI.
496
497         * DumpRenderTree/CMakeLists.txt: Added JavaScriptCore/parser to include search list,
498         so that "SourceProvider.h" can be found.
499
500 2013-10-19  Ryosuke Niwa  <rniwa@webkit.org>
501
502         run-webkit-tests should submit time and modifiers to the new flakiness dashboard
503         https://bugs.webkit.org/show_bug.cgi?id=123070
504
505         Reviewed by Alexey Proskuryakov.
506
507         * Scripts/webkitpy/layout_tests/controllers/manager.py:
508         (Manager.run):
509         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
510         (summarize_results): Added include_time_and_modifiers. Report test_run_time and modifiers
511         in the test expectations when this argument is set to true.
512
513 2013-10-19  Alexey Proskuryakov  <ap@apple.com>
514
515         Mac DumpRenderTree builds without NDEBUG even in release mode
516         https://bugs.webkit.org/show_bug.cgi?id=123066
517
518         Reviewed by Dan Bernstein.
519
520         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
521         * DumpRenderTree/mac/Configurations/Base.xcconfig:
522         Use the same pattern as WebCore and WebKitTestRunner.
523
524 2013-10-19  Zan Dobersek  <zdobersek@igalia.com>
525
526         REGRESSION(r155373): Mac WK2 EWS bots is actually Mac WK1 debug
527         https://bugs.webkit.org/show_bug.cgi?id=123064
528
529         Reviewed by Ryosuke Niwa.
530
531         Revert r155373 as it is causing incorrect port/platform deduction for the Mac EWS systems.
532
533         * Scripts/webkitpy/common/config/ports.py: Added.
534         (DeprecatedPort):
535         (DeprecatedPort.name):
536         (DeprecatedPort.flag):
537         (DeprecatedPort.script_path):
538         (DeprecatedPort.script_shell_command):
539         (DeprecatedPort.port):
540         (DeprecatedPort.makeArgs):
541         (DeprecatedPort.update_webkit_command):
542         (DeprecatedPort.check_webkit_style_command):
543         (DeprecatedPort.prepare_changelog_command):
544         (DeprecatedPort.build_webkit_command):
545         (DeprecatedPort.run_javascriptcore_tests_command):
546         (DeprecatedPort.run_webkit_unit_tests_command):
547         (DeprecatedPort.run_webkit_tests_command):
548         (DeprecatedPort.run_python_unittests_command):
549         (DeprecatedPort.run_perl_unittests_command):
550         (DeprecatedPort.run_bindings_tests_command):
551         (MacPort):
552         (MacWK2Port):
553         (MacWK2Port.run_webkit_tests_command):
554         (WinPort):
555         (WinPort.run_bindings_tests_command):
556         (GtkPort):
557         (GtkPort.build_webkit_command):
558         (GtkPort.run_webkit_tests_command):
559         (GtkWK2Port):
560         (GtkWK2Port.build_webkit_command):
561         (GtkWK2Port.run_webkit_tests_command):
562         (QtPort):
563         (QtPort.build_webkit_command):
564         (QtPort.run_webkit_tests_command):
565         (QtWK2Port):
566         (QtWK2Port.build_webkit_command):
567         (QtWK2Port.run_webkit_tests_command):
568         (EflPort):
569         (EflPort.build_webkit_command):
570         (EflWK2Port):
571         (EflWK2Port.build_webkit_command):
572         * Scripts/webkitpy/common/config/ports_mock.py: Added.
573         (MockPort):
574         (MockPort.name):
575         (MockPort.check_webkit_style_command):
576         (MockPort.update_webkit_command):
577         (MockPort.build_webkit_command):
578         (MockPort.prepare_changelog_command):
579         (MockPort.run_python_unittests_command):
580         (MockPort.run_perl_unittests_command):
581         (MockPort.run_javascriptcore_tests_command):
582         (MockPort.run_webkit_unit_tests_command):
583         (MockPort.run_webkit_tests_command):
584         (MockPort.run_bindings_tests_command):
585         * Scripts/webkitpy/common/config/ports_unittest.py: Added.
586         (DeprecatedPortTest):
587         (DeprecatedPortTest.test_mac_port):
588         (DeprecatedPortTest.test_gtk_port):
589         (DeprecatedPortTest.test_gtk_wk2_port):
590         (DeprecatedPortTest.test_efl_port):
591         (DeprecatedPortTest.test_qt_port):
592         (DeprecatedPortTest.test_qt_wk2_port):
593         * Scripts/webkitpy/port/base.py:
594         (Port._port_flag_for_scripts):
595         (Port._wk2_port_name):
596         * Scripts/webkitpy/port/base_unittest.py:
597         (PortTest.test_build_path):
598         * Scripts/webkitpy/port/efl_unittest.py:
599         (EflPortTest.test_show_results_html_file):
600         * Scripts/webkitpy/port/gtk_unittest.py:
601         (GtkPortTest.test_get_crash_log):
602         * Scripts/webkitpy/port/mac_unittest.py:
603         (test_64bit):
604         * Scripts/webkitpy/port/test.py:
605         (TestPort.virtual_test_suites):
606         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
607         (FlakyTestReporter.__init__):
608         * Scripts/webkitpy/tool/bot/irc_command.py:
609         (Rollout._update_working_copy):
610         * Scripts/webkitpy/tool/commands/download_unittest.py:
611         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
612         (AbstractEarlyWarningSystem.run_command):
613         * Scripts/webkitpy/tool/commands/queues.py:
614         (PatchProcessingQueue.begin_work_queue):
615         (CommitQueue.run_command):
616         * Scripts/webkitpy/tool/main.py:
617         (WebKitPatch.__init__):
618         (WebKitPatch.deprecated_port):
619         (WebKitPatch.handle_global_options):
620         * Scripts/webkitpy/tool/mocktool.py:
621         (MockTool.__init__):
622         (MockTool.deprecated_port):
623         * Scripts/webkitpy/tool/steps/build.py:
624         (Build.build):
625         * Scripts/webkitpy/tool/steps/checkstyle.py:
626         (CheckStyle.run):
627         * Scripts/webkitpy/tool/steps/commit.py:
628         (Commit._check_test_expectations):
629         * Scripts/webkitpy/tool/steps/preparechangelog.py:
630         (PrepareChangeLog.run):
631         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
632         (PrepareChangeLogForRevert.run):
633         * Scripts/webkitpy/tool/steps/runtests.py:
634         (RunTests.run):
635         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
636         (RunTestsTest.test_webkit_run_unit_tests):
637         * Scripts/webkitpy/tool/steps/steps_unittest.py:
638         (StepsTest.test_runtests_args):
639         * Scripts/webkitpy/tool/steps/update.py:
640         (Update._update_command):
641         * Scripts/webkitpy/tool/steps/update_unittest.py:
642         (UpdateTest.test_update_command_non_interactive):
643         (UpdateTest.test_update_command_interactive):
644
645 2013-10-19  Andreas Kling  <akling@apple.com>
646
647         RefPtr::releaseNonNull() incorrectly increments the refcount.
648         <https://webkit.org/b/123063>
649
650         Add an API test to verify that no extra refs are added when calling
651         RefPtr::releaseNonNull().
652
653         Reviewed by Anders Carlsson.
654
655 2013-10-18  Rik Cabanier <cabanier@adobe.com>
656         Add Rik Cabanier to list of committers
657         https://bugs.webkit.org/show_bug.cgi?id=123031
658
659         reviewed by Dirk Schulze.
660
661         * Tools/Scripts/webkitpy/common/config/contributors.json: Added name.
662
663 2013-10-18  Denis Nomiyama  <d.nomiyama@samsung.com>
664
665         [ATK] Fix invalid signal to set objects to an unknown state "layout-complete"
666         https://bugs.webkit.org/show_bug.cgi?id=122970
667
668         Reviewed by Mario Sanchez Prada.
669
670         Removed an invalid signal to set an object state to layout-complete
671         that does not exist. It was replaced by ATK:AtkDocument:load-complete.
672
673         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
674         (axObjectEventListener): Replaced layout-complete with load-complete.
675         (connectAccessibilityCallbacks): Connect callback to new listener for
676         ATK:AtkDocument:load-complete.
677         (disconnectAccessibilityCallbacks): Disconnect callback to new listener
678         for ATK:AtkDocument:load-complete.
679         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
680         (axObjectEventListener): Replaced layout-complete with load-complete.
681         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
682         Connect callback to new listener for ATK:AtkDocument:load-complete.
683         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
684         Disconnect callback to new listener for ATK:AtkDocument:load-complete.
685
686 2013-10-18  Carlos Garcia Campos  <cgarcia@igalia.com>
687
688         [GTK] Generate API documentation for GObject DOM bindings
689         https://bugs.webkit.org/show_bug.cgi?id=121538
690
691         Reviewed by Gustavo Noronha Silva.
692
693         The .symbols file that is now generated for checking GObject DOM
694         bindings API compatibility while building can also be used to
695         generate the files needed to produce the gtk-doc
696         documentation. The new script generate-webkitdom-doc-files can
697         generate the docs.sgml and sections.txt files from the given list
698         of .symbols files.
699
700         * gtk/GNUmakefile.am: Add rules to generate webkitdomgtk-docs.sgml
701         and webkitdomgtk-sections.txt as well as rules to install the
702         generated WebKitDOMGTK documentation.
703         * gtk/generate-gtkdoc:
704         (webkitdom_docs_html_path): New helper function that returns the
705         path where the DOM API documentation has been generated.
706         (get_webkit2_options): Include DOM API docs to the list of xref
707         dependencies.
708         (get_webkit1_options): Ditto.
709         (get_webkitdom_options): Return the gtk-doc options to generate
710         the DOM API docs.
711         (get_webkitdom_options.derived_sources_path):
712         (get_webkitdom_options.src_path):
713         * gtk/generate-webkitdom-doc-files: Added.
714         (WebKitDOMDocGenerator):
715         (WebKitDOMDocGenerator.write_header):
716         (WebKitDOMDocGenerator.write_section):
717         (WebKitDOMDocGenerator.write_footer):
718         (WebKitDOMDocGeneratorDocs):
719         (WebKitDOMDocGeneratorDocs.write_header):
720         (write_section):
721         (write_footer):
722         (WebKitDOMDocGeneratorSections):
723         (WebKitDOMDocGeneratorSections.__init__):
724         (WebKitDOMDocGeneratorSections._dom_class):
725         (WebKitDOMDocGeneratorSections._dom_class_decamelize):
726         (WebKitDOMDocGeneratorSections._symbol_list):
727         (WebKitDOMDocGeneratorSections.write_section):
728
729 2013-10-17  Alex Christensen  <achristensen@webkit.org>
730
731         Run JavaScriptCore tests again on Windows.
732         https://bugs.webkit.org/show_bug.cgi?id=122787
733
734         Reviewed by Tim Horton.
735
736         * Scripts/build-jsc:
737         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
738         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
739         * Scripts/webkitdirs.pm:
740         (determineConfigurationForVisualStudio):
741         (determineConfigurationProductDir):
742         Build directory should end with bin64 and configuration should end with |x64 on Win64.
743         (isAppleWinWebKit):
744         (copyInspectorFrontendFiles):
745         (setPathForRunningWebKitApp):
746         Separated WinCairo directories and options from AppleWin.
747
748 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
749
750         Unreviewed. Add myself as a reviewer.
751
752         * Scripts/webkitpy/common/config/contributors.json:
753
754 2013-10-17  Andreas Kling  <akling@apple.com>
755
756         Make it possible to assign a PassRef to a RefPtr.
757         <https://webkit.org/b/122943>
758
759         Added a small API test for RefPtr=(PassRef) so we know this code
760         will compile (and work.)
761
762         Reviewed by Antti Koivisto.
763
764 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
765
766         We need test coverage for just the Baseline JIT
767         https://bugs.webkit.org/show_bug.cgi?id=122929
768
769         Reviewed by Sam Weinig.
770         
771         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
772         variant.
773
774         * Scripts/run-jsc-stress-tests:
775
776 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
777
778         Support multiple repositories in submitting results to --results-server-host
779         https://bugs.webkit.org/show_bug.cgi?id=122935
780
781         Reviewed by Anders Carlsson.
782
783         Remoevd --got-revision and added the logic to extract revision information
784         from multiple repositories as done in run-perf-tests.
785
786         * Scripts/webkitpy/layout_tests/controllers/manager.py:
787         (Manager.upload_results):
788         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
789         (parse_args):
790
791 2013-10-16  Darin Adler  <darin@apple.com>
792
793         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
794         https://bugs.webkit.org/show_bug.cgi?id=122904
795
796         Reviewed by Anders Carlsson.
797
798         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
799
800 2013-10-16  Darin Adler  <darin@apple.com>
801
802         Need tests for RefPtr self-assignment and self-move-assignment.
803
804         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
805
806 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
807
808         [EFL] Minibrowser can't load child window's location
809         https://bugs.webkit.org/show_bug.cgi?id=122485
810
811         Reviewed by Gyuyoung Kim.
812
813         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
814             followed by an explicit call to ewk_view_url_set() where appropriate.
815         (on_key_down):
816         (on_window_create):
817         (window_create):
818         (elm_main):
819
820 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
821
822         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
823         https://bugs.webkit.org/show_bug.cgi?id=122872
824
825         Reviewed by Anders Carlsson.
826
827         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
828         failing.
829
830 2013-10-15  Dean Jackson  <dino@apple.com>
831
832         Add ENABLE_WEB_ANIMATIONS flag
833         https://bugs.webkit.org/show_bug.cgi?id=122871
834
835         Reviewed by Tim Horton.
836
837         Eventually might be http://dev.w3.org/fxtf/web-animations/
838         but this is just engine-internal work at the moment.
839
840         * Scripts/webkitperl/FeatureList.pm:
841
842 2013-10-15  Darin Adler  <darin@apple.com>
843
844         Add some API tests for Vector, RefPtr, and Ref
845         https://bugs.webkit.org/show_bug.cgi?id=122840
846
847         Reviewed by Andreas Kling.
848
849         * TestWebKitAPI/CMakeLists.txt: Added new files.
850         * TestWebKitAPI/GNUmakefile.am: Ditto.
851         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
852         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
853         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
854
855         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
856         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
857         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
858         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
859
860 2013-10-14  Roger Fong  <roger_fong@apple.com>
861
862         Adding myself to CC list for some components.
863
864         * Scripts/webkitpy/common/config/watchlist:
865
866 2013-10-13  Darin Adler  <darin@apple.com>
867
868         Deprecate or remove deleteAllValues functions; there are only a few call sites left
869         https://bugs.webkit.org/show_bug.cgi?id=122738
870
871         Reviewed by Anders Carlsson.
872
873         * DumpRenderTree/win/DRTDataObject.cpp:
874         (DRTDataObject::~DRTDataObject):
875         * DumpRenderTree/win/UIDelegate.cpp:
876         (DRTUndoStack::~DRTUndoStack):
877         (DRTUndoStack::clear):
878         Renamed deleteAllValues to deprecatedDeleteAllValues.
879
880         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
881
882 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
883
884         build.webkit.org/dashboard incorrectly shows interrupted builds as green
885         https://bugs.webkit.org/show_bug.cgi?id=122732
886
887         Reviewed by Tim Hatcher.
888
889         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
890         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
891         I don't see it occur any time in recent history, but judging from what happens for
892         status 5 (RETRY), we can just finish this function normally.
893         Record overall text description for iteration as BuildbotIteration.text.
894
895         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
896         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
897         but no tests failed, make it yellow, and use buildbot-provided description for it.
898
899 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
900
901         Remove Chromium specific code from flakiness dashboard
902         https://bugs.webkit.org/show_bug.cgi?id=122714
903
904         Reviewed by Sam Weinig.
905
906         Also removed code related to GPU tests and virtual suites.
907         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
908
909         * TestResultServer/model/jsonresults_unittest.py:
910         * TestResultServer/static-dashboards/builders.js:
911         * TestResultServer/static-dashboards/dashboard_base.js:
912         * TestResultServer/static-dashboards/flakiness_dashboard.html:
913         * TestResultServer/static-dashboards/flakiness_dashboard.js:
914         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
915         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
916         * TestResultServer/static-dashboards/history.js:
917         * TestResultServer/static-dashboards/loader.js:
918         * TestResultServer/static-dashboards/ui.js:
919         * TestResultServer/templates/uploadform.html:
920
921 2013-10-11  Timothy Hatcher  <timothy@apple.com>
922
923         Remove preference support for picking the old Web Inspector.
924         https://bugs.webkit.org/show_bug.cgi?id=122655
925
926         Reviewed by Alexey Proskuryakov.
927
928         * WebKitTestRunner/TestController.cpp:
929         (WTR::TestController::resetStateToConsistentValues):
930
931 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
932
933         Fix 64-bit build on everything but Windows.
934
935         Rubber stamped by Brent Fulgham.
936
937         * Scripts/webkitdirs.pm:
938         (argumentsForConfiguration):
939
940 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
941
942         Touch a file to see how auto-update works.
943
944         Rubber-stamped by Tim Hatcher.
945
946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
947
948 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
949
950         LeaksViewer fails to present recent results list if current build is still updating svn
951         https://bugs.webkit.org/show_bug.cgi?id=122670
952
953         Fixed an obvious mistake in the previous patch.
954
955         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
956         (RecentBuildsLoader.prototype.start):
957
958 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
959
960         LeaksViewer fails to present recent results list if current build is still updating svn
961         https://bugs.webkit.org/show_bug.cgi?id=122670
962
963         Reviewed by Adam Roben.
964
965         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
966         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
967
968 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
969
970         Unreviewed build fix for --64-bit target.
971
972         * Scripts/webkitdirs.pm:
973         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
974         been removed by this point.
975         (hasArgument): Remove unused temporary.
976
977 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
978
979         webkit-patch failure-reason has a quite low limit for 'too many failures'
980         https://bugs.webkit.org/show_bug.cgi?id=122556
981
982         Reviewed by Darin Adler.
983
984         * Scripts/webkitpy/tool/commands/queries.py:
985         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
986         to match what the layout test runners use these days.
987
988 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
989
990         webkit-patch failure-reason should allow specifying failures one is interested in
991         https://bugs.webkit.org/show_bug.cgi?id=122554
992
993         Reviewed by Darin Adler.
994
995         * Scripts/webkitpy/tool/commands/queries.py:
996         (FailureReason):
997         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
998         loop if the ones we're interested in been explained.
999         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
1000         (FailureReason.execute): initialize failures to explain and the explained set.
1001
1002 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1003
1004         Make sure that DataTypes.h is in the binary drop.
1005
1006         Rubber stamped by Michael Saboff.
1007
1008         * Scripts/export-llvm-build:
1009
1010 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
1011
1012         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
1013         https://bugs.webkit.org/show_bug.cgi?id=122566
1014
1015         Reviewed by Mark Rowe.
1016
1017         * Scripts/configure-llvm:
1018
1019 2013-10-10  Mark Rowe  <mrowe@apple.com>
1020
1021         <rdar://problem/13341666> WebKit should always build against an SDK.
1022
1023         Have all projects default to building against the OS X Internal SDK for the Production
1024         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
1025         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
1026
1027         Reviewed by Dan Bernstein.
1028
1029         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1030         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1031         * MiniBrowser/Configurations/Base.xcconfig:
1032         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1033         * TestWebKitAPI/Configurations/Base.xcconfig:
1034         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1035         * WebKitTestRunner/Configurations/Base.xcconfig:
1036         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1037
1038 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
1039
1040         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
1041
1042         * Scripts/run-gtk-tests:
1043         (TestRunner): skip TestInspectorServer.
1044
1045 2013-10-10  Andres Gomez  <agomez@igalia.com>
1046
1047         [GTK] Provide search functionality to MiniBrowser
1048         https://bugs.webkit.org/show_bug.cgi?id=117631
1049
1050         Reviewed by Carlos Garcia Campos.
1051
1052         Adds a search bar to MiniBrowser with the minimum functionality
1053         and a new button to the toolbar for showing the new search
1054         bar. Typical keyboard shortcuts are also added.
1055
1056         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
1057         (doSearch):
1058         (searchNext):
1059         (searchPrevious):
1060         (searchCloseButtonClickedCallback):
1061         (searchEntryMenuIconPressedCallback):
1062         (searchEntryClearIconReleasedCallback):
1063         (searchEntryChangedCallback):
1064         (searchEntryActivatedCallback):
1065         (searchPrevButtonClickedCallback):
1066         (searchNextButtonClickedCallback):
1067         (searchMenuCheckButtonToggledCallback):
1068         (browser_search_bar_init):
1069         (browserSearchBarFinalize):
1070         (browser_search_bar_class_init):
1071         (browser_search_bar_new):
1072         (browser_search_bar_add_accelerators):
1073         (browser_search_bar_open):
1074         (browser_search_bar_close):
1075         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
1076         * MiniBrowser/gtk/BrowserWindow.c:
1077         (webViewEnterFullScreen): Closes new search bar.
1078         (webViewLeaveFullScreen): Opens new search bar if previously
1079         visible.
1080         (searchCallback): Added. Shows and hides the new search bar.
1081         (browser_window_init): Added search button to the toolbar.
1082         (browserWindowConstructed): Creates the new search bar.
1083         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
1084
1085 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1086
1087         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
1088         https://bugs.webkit.org/show_bug.cgi?id=122552
1089
1090         Reviewed by Darin Adler.
1091
1092         * Scripts/webkitpy/common/checkout/commitinfo.py:
1093         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
1094         will cause UnicodeDecodeError for non-ascii characters.
1095
1096 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1097
1098         Would like a link to dashboard from build.webkit.org main page
1099         https://bugs.webkit.org/show_bug.cgi?id=122577
1100
1101         Reviewed by Tim Hatcher.
1102
1103         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
1104
1105 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
1106
1107         [Win] Check for MathML fonts and warn user if they are missing.
1108         https://bugs.webkit.org/show_bug.cgi?id=122568
1109
1110         Reviewed by Tim Horton.
1111
1112         * Scripts/webkitdirs.pm:
1113         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
1114         Windows-specific code I added previously.
1115         (fontExists): Added
1116         (checkInstalledTools): Add check for MathML fonts.
1117
1118 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1119
1120         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
1121         https://bugs.webkit.org/show_bug.cgi?id=122471
1122
1123         Reviewed by Tim Hatcher.
1124
1125         Added links to webkitpy, webkitperl and bindings-tests results.
1126
1127         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1128         (Buildbot.prototype.apiTestResultsURLForIteration):
1129         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
1130         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
1131         (Buildbot.prototype.bindingsTestResultsURLForIteration):
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1133         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1134
1135 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1136
1137         Move some functions from WebKitBuildbot to Buildbot class.
1138
1139         Suggested by Tim Hatcher.
1140
1141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1142         (Buildbot.prototype.javascriptTestResultsURLForIteration):
1143         (Buildbot.prototype.apiTestResultsURLForIteration):
1144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1145         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1146
1147 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1148
1149         Add API tests to the Dashbord page.
1150
1151         https://bugs.webkit.org/show_bug.cgi?id=122283
1152
1153         Reviewed by Timothy Hatcher.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1156         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1158         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
1159
1160 2013-10-09  Timothy Hatcher  <timothy@apple.com>
1161
1162         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
1163
1164         https://bugs.webkit.org/show_bug.cgi?id=122515
1165
1166         Reviewed by Alexey Proskuryakov.
1167
1168         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1169         (BuildbotIteration.prototype.update):
1170
1171 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1172
1173         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
1174         https://bugs.webkit.org/show_bug.cgi?id=122573
1175
1176         Reviewed by Tim Hatcher.
1177
1178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1179         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
1180
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1182         (Buildbot.prototype.buildPageURLForIteration): Added.
1183
1184 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
1185
1186         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
1187         https://bugs.webkit.org/show_bug.cgi?id=122569
1188
1189         Reviewed by Tim Hatcher.
1190
1191         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1192         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
1193         to be produced by the old Mozilla test harness that we don't use any more.
1194
1195 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1196
1197         Add GTK 64 bits release to the buildbot dashboard
1198         https://bugs.webkit.org/show_bug.cgi?id=122548
1199
1200         Reviewed by Darin Adler.
1201
1202         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1204         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1206         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
1207
1208 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
1209
1210         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
1211         https://bugs.webkit.org/show_bug.cgi?id=120638
1212
1213         Reviewed by Gustavo Noronha Silva.
1214
1215         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
1216         can check both the old and new APIs to retrieve text at a given offset.
1217
1218 2013-10-08  Alex Christensen  <achristensen@webkit.org>
1219
1220         Improved WinLauncher.
1221         https://bugs.webkit.org/show_bug.cgi?id=122536
1222
1223         Reviewed by Brent Fulgham.
1224
1225         * WinLauncher/PrintWebUIDelegate.cpp:
1226         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
1227         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
1228         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
1229         * WinLauncher/WinLauncher.cpp:
1230         (createCrashReport): Use the executable name instead of "WinLauncher".
1231         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
1232         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
1233         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
1234
1235 2013-10-08  Mark Lam  <mark.lam@apple.com>
1236
1237         Fix ruby LoadError when running run-javascriptcore-tests.
1238         https://bugs.webkit.org/show_bug.cgi?id=122519.
1239
1240         Reviewed by Mark Hahnenberg.
1241
1242         The scripts needed to explicitly require 'rubygems' for older versions of ruby
1243         (versions before 1.9).
1244
1245         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
1246         * Scripts/run-jsc-stress-tests:
1247
1248 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
1249
1250         Unreviewed, add my new email to contributors.json.
1251
1252         * Scripts/webkitpy/common/config/contributors.json:
1253
1254 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
1255
1256         Unreviewed build correction.
1257
1258         * Scripts/webkitpy/port/win.py:
1259         (WinPort.write_registry_value): Use string representation of error message to avoid
1260         format conversion problem.
1261
1262 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
1263
1264         [Win] Add checks for proper build and test environment
1265         https://bugs.webkit.org/show_bug.cgi?id=122466
1266
1267         Reviewed by Darin Adler.
1268
1269         This patch makes two changes:
1270         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
1271            error messages so that people know what to fix to get things working.
1272         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
1273            the various environment settings are properly configured for our test environment.
1274
1275         * Scripts/webkitdirs.pm:
1276         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
1277         caused problems in the past.
1278         (setupAppleWinEnv):
1279         * Scripts/webkitpy/port/win.py:
1280         (WinPort):
1281         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
1282         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
1283         DWORD, etc.)
1284         (WinPort.write_registry_string): Revise to call new generic registry write function.
1285         (WinPort.setup_crash_log_saving): Revise for new API
1286         (WinPort.restore_crash_log_saving): Ditto
1287         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
1288         servers from running.
1289         (WinPort.allow_error_dialogs): Ditto.
1290         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
1291         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
1292
1293 2013-10-08  Philippe Normand  <pnormand@igalia.com>
1294
1295         [GStreamer] enable v4l2 plugin
1296         https://bugs.webkit.org/show_bug.cgi?id=122503
1297
1298         Reviewed by Martin Robinson.
1299
1300         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
1301         we updated our GStreamer version to 1.0.8.
1302
1303 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
1304
1305         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
1306         https://bugs.webkit.org/show_bug.cgi?id=122104
1307
1308         Reviewed by Chris Fleizach.
1309
1310         Updated stringAttributeValue to double check that the exposure of
1311         aria-invalid as a state is consistent with its exposure as a text
1312         attribute as well, when it applies (implementations of AtkText).
1313
1314         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1315         (AccessibilityUIElement::stringAttributeValue): Add double check.
1316         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1317         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1318
1319 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
1320
1321         run-jsc-stress-tests progress meter should update more quickly on older Rubies
1322         https://bugs.webkit.org/show_bug.cgi?id=122459
1323
1324         Reviewed by Darin Adler.
1325
1326         * Scripts/run-jsc-stress-tests:
1327
1328 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1329
1330         [buildbot] parse tests that are reported as crashed correctly for GTK+
1331         https://bugs.webkit.org/show_bug.cgi?id=122476
1332
1333         Reviewed by Martin Robinson.
1334
1335         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1336         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
1337         as a failure of the API tests.
1338
1339 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1340
1341         Unreviewed. Skipping API test that is causing the next one to crash,
1342         see https://bugs.webkit.org/show_bug.cgi?id=121970.
1343
1344         * Scripts/run-gtk-tests:
1345         (TestRunner):
1346
1347 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1348
1349         [GTK] run-gtk-tests does not distinguish between failure and crashes
1350         https://bugs.webkit.org/show_bug.cgi?id=122135
1351
1352         Reviewed by Martin Robinson.
1353
1354         The GTK+ API test runner does not distinguish between failures and crashes. This change
1355         makes it do that, so it's easier for us to spot the more important/higher priority crash
1356         case.
1357
1358         * Scripts/run-gtk-tests:
1359         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
1360         so we have more information on how the process ended.
1361         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
1362         (TestRunner.run_tests): report crashes.
1363
1364 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
1365
1366         [GTK] Missing packages for APT on install-dependencies
1367         https://bugs.webkit.org/show_bug.cgi?id=121555
1368
1369         Reviewed by Martin Robinson.
1370
1371         * gtk/install-dependencies: add packages that are needed for
1372         building WebKit itself and the jhbuild dependencies.
1373
1374 2013-10-07  Anders Carlsson  <andersca@apple.com>
1375
1376         Fix test failures.
1377
1378         * Scripts/webkitpy/port/base.py:
1379         (Port.to.start_helper):
1380         * Scripts/webkitpy/port/mock_drt.py:
1381         (MockDRTPort.start_helper):
1382
1383 2013-10-07  Anders Carlsson  <andersca@apple.com>
1384
1385         Always force discrete mode when running layout tests
1386         https://bugs.webkit.org/show_bug.cgi?id=122465
1387
1388         Reviewed by Tim Horton.
1389
1390         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
1391         
1392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1393         Link with IOKit.
1394
1395         * DumpRenderTree/mac/LayoutTestHelper.m:
1396         (installLayoutTestColorProfile):
1397         Check installColorProfile.
1398
1399         (restoreUserColorProfile):
1400         Check installColorProfile.
1401
1402         (lockDownDiscreteGraphics):
1403         New function to force discrete graphics.
1404
1405         (main):
1406         Add '--install-color-profile' option.
1407
1408         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1409         (Manager._set_up_run):
1410         Always start the helper, but pass self._options.pixel_tests to it.
1411
1412         * Scripts/webkitpy/port/mac.py:
1413         (MacPort.start_helper):
1414         Pass --install-color-profile' to the helper if pixel_tests is true.
1415
1416 2013-10-07  Timothy Hatcher  <timothy@apple.com>
1417
1418         Properly count binding test failures as failures.
1419
1420         Fix the total for multiple failures in different steps too by avoiding undefined.
1421
1422         https://bugs.webkit.org/show_bug.cgi?id=122232
1423
1424         Reviewed by Alexey Proskuryakov.
1425
1426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1427         (BuildbotTestResults):
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1429         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1430
1431 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1432
1433         [GTK] Fails to build with jhbuild with newer system glib
1434         https://bugs.webkit.org/show_bug.cgi?id=122132
1435
1436         Reviewed by Martin Robinson.
1437
1438         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
1439         started relying on. glib is not a dependency that should change test results, and is provided in
1440         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
1441         should not be an issue.
1442
1443         * gtk/jhbuild.modules:
1444
1445 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1446
1447         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
1448         https://bugs.webkit.org/show_bug.cgi?id=122437
1449
1450         Reviewed by Antoine Quint.
1451
1452         * Scripts/run-jsc-stress-tests:
1453
1454 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1455
1456         Unreviewed, fix build on old Rubies.
1457
1458         * Scripts/run-jsc-stress-tests:
1459
1460 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
1461
1462         Unified test infrastructure via the jsc shell
1463         https://bugs.webkit.org/show_bug.cgi?id=120696
1464
1465         Reviewed by Oliver Hunt.
1466         
1467         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
1468         output (silent or noisy) and different styles of test failure (just bad exit code,
1469         text diff, filtering for some magical text, etc.). This allows me to get rid of the
1470         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
1471         running in run-jsc-stress-tests.
1472         
1473         Also removes all of the code paths that defended against not having shellwords. Just
1474         install the shellwords gem if you want to run tests.
1475         
1476         Also removes the non-parallel test running code. No reason for it to exist anymore.
1477         
1478         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
1479         as part of this patch, and left three more as new bugzillas.
1480
1481         * Scripts/create-mozilla-js-test-list: Added.
1482         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
1483         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
1484         * Scripts/run-javascriptcore-tests:
1485         * Scripts/run-jsc-stress-tests:
1486
1487 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1488
1489         run-jsc-stress-tests should be less verbose
1490         https://bugs.webkit.org/show_bug.cgi?id=122397
1491
1492         Reviewed by Sam Weinig.
1493         
1494         It now just prints something like:
1495         
1496          965/1831 ....
1497         
1498         Where the first number is the number of tests that completed, the second number is the
1499         number of tests total, and the dots are the number of tests running right now - which is
1500         useful towards the end when you're waiting for the last slow tests to finish.
1501         
1502         It will also print out the output from failing tests and it will print a line for skipped
1503         tests (to annoy you into getting them into a shape where they can be unskipped). For
1504         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
1505
1506         * Scripts/run-jsc-stress-tests:
1507
1508 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1509
1510         Allow skipping of run-jsc-stress-tests that are configured using yaml files
1511         https://bugs.webkit.org/show_bug.cgi?id=122385
1512
1513         Reviewed by Sam Wieinig.
1514         
1515         Make tests run via YAML be able to do the parse-for-commands trick that allows
1516         us to skip tests and do other custom per-test stuff.
1517
1518         * Scripts/jsc-stress-test-helpers/layout-test-helper:
1519         * Scripts/run-jsc-stress-tests:
1520
1521 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
1522
1523         Unreviewed, fix tests on older Rubies.
1524
1525         * Scripts/run-jsc-stress-tests:
1526
1527 2013-10-05  Anders Carlsson  <andersca@apple.com>
1528
1529         Don't filter the weak symbols.
1530
1531         * Scripts/check-for-weak-vtables-and-externals:
1532
1533 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1534
1535         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
1536         https://bugs.webkit.org/show_bug.cgi?id=122376
1537
1538         Reviewed by Mark Hahnenberg.
1539
1540         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
1541         * Scripts/run-javascriptcore-tests:
1542         (printThingsFound):
1543         * Scripts/run-jsc-stress-tests:
1544
1545 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
1546
1547         It should be even easier to run and debug a failing JSC stress test
1548         https://bugs.webkit.org/show_bug.cgi?id=122337
1549
1550         Reviewed by Oliver Hunt.
1551         
1552         If a test fails, you can now just say:
1553
1554         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
1555
1556         and get the reproduction. You don't have to set any environment variables like before.
1557         Also if you want to debug the failing test you can now just say:
1558
1559         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
1560
1561         Broadly, any arguments passed to the reproduction script are prepended to the command to
1562         run the test. This is sort of quirky and won't work for some tests (for example the
1563         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
1564         them and that's good enough for now.
1565
1566         * Scripts/run-jsc-stress-tests:
1567
1568 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1569
1570         [Windows] Correct run-path when using 64-bit binaries.
1571
1572         Reviewed by David Kilzer.
1573
1574         * Scripts/webkitdirs.pm:
1575         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
1576         directory. Otherwise use the existing 'bin32' directory.
1577
1578 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1579
1580         Teach webkitdirs.pm to honor the --64-bit flag
1581         https://bugs.webkit.org/show_bug.cgi?id=122357
1582
1583         Reviewed by David Kilzer.
1584
1585         * Scripts/webkitdirs.pm:
1586         (argumentsForConfiguration): Modify to check if --64-bit is supplied
1587         by the user.
1588         (findMatchingArguments): Added.
1589         (hasArgument): Added.
1590         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
1591         findMatchingArguments subroutine.
1592
1593 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1594
1595         Update svn-config for new Visual Studio extensions
1596         https://bugs.webkit.org/show_bug.cgi?id=122344
1597
1598         Reviewed by Brent Fulgham.
1599
1600         * svn-config: Add new Visual Studio extensions.
1601
1602 2013-10-04  Alex Christensen  <achristensen@webkit.org>
1603
1604         Made WinLauncher have better error handling, crash reporting, and modifiability.
1605         https://bugs.webkit.org/show_bug.cgi?id=122319
1606
1607         Reviewed by Brent Fulgham.
1608
1609         * WinLauncher/WinLauncher.cpp:
1610         (WinLauncherWebHost::didFailProvisionalLoadWithError):
1611         Don't display the numerous "Cancelled" messages that are obviously from the user.
1612         (createCrashReport): Added.
1613         (dllLauncherEntryPoint):
1614         Made main loop back into while loop and write a crash report if it crashes.
1615         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
1616         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
1617         Added WinLauncherReplace.h.
1618         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
1619         Added linking to DbgHelp.lib.
1620         * WinLauncher/WinLauncherReplace.h:
1621         Added to make modifying WinLauncher behaviour and appearance easy.
1622         (processCrashDump): Added.
1623
1624 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
1625
1626         remove dpranke from webkitpy watchlist
1627         https://bugs.webkit.org/show_bug.cgi?id=122331
1628
1629         Reviewed by Brent Fulgham.
1630
1631         * Scripts/webkitpy/common/config/watchlist:
1632
1633 2013-10-04  Tim Horton  <timothy_horton@apple.com>
1634
1635         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1636         https://bugs.webkit.org/show_bug.cgi?id=122299
1637
1638         Reviewed by Beth Dakin.
1639
1640         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1641         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1642         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
1643
1644 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
1645
1646         Watchlist is broken after <http://trac.webkit.org/r156880>
1647
1648         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
1649
1650 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
1651
1652         Remove Qt features from build and test tools
1653         https://bugs.webkit.org/show_bug.cgi?id=122312
1654
1655         Reviewed by Anders Carlsson.
1656
1657         * Scripts/build-dumprendertree:
1658         * Scripts/build-jsc:
1659         * Scripts/build-webkit:
1660         * Scripts/build-webkittestrunner:
1661         * Scripts/old-run-webkit-tests:
1662         (openDumpTool):
1663         (buildPlatformResultHierarchy):
1664         (buildPlatformTestHierarchy):
1665         (readSkippedFiles):
1666         * Scripts/run-launcher:
1667         * Scripts/run-qtwebkit-tests: Removed.
1668         * Scripts/run-webkit-tests:
1669         (useNewRunWebKitTests):
1670         * Scripts/update-webkit:
1671         * Scripts/webkit-build-directory:
1672         * Scripts/webkitdirs.pm:
1673         (argumentsForConfiguration):
1674         (jscProductDir):
1675         (builtDylibPathForName):
1676         (isAppleWebKit):
1677         (launcherPath):
1678         (launcherName):
1679         (checkRequiredSystemConfig):
1680         (setupCygwinEnv):
1681         (copyInspectorFrontendFiles):
1682         (setPathForRunningWebKitApp):
1683         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1684         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1685         (BaselineOptimizerTest.test_mac_future):
1686         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1687         (BaselineOptimizerTest.test_common_directory_includes_root):
1688         (BaselineOptimizerTest.test_virtual_ports_filtered):
1689         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1690         (test_parse_reviewer_text):
1691         * Scripts/webkitpy/common/config/watchlist:
1692         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1693         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
1694         * Scripts/webkitpy/port/base.py:
1695         (Port.__init__):
1696         (Port._port_flag_for_scripts):
1697         (Port._wk2_port_name):
1698         * Scripts/webkitpy/port/builders.py:
1699         * Scripts/webkitpy/port/factory.py:
1700         (platform_options):
1701         (PortFactory):
1702         (PortFactory._default_port):
1703         * Scripts/webkitpy/port/factory_unittest.py:
1704         (FactoryTest.test_gtk):
1705         * Scripts/webkitpy/port/qt.py: Removed.
1706         * Scripts/webkitpy/port/qt_unittest.py: Removed.
1707         * Scripts/webkitpy/style/checker.py:
1708         * Scripts/webkitpy/style/checker_unittest.py:
1709         (GlobalVariablesTest.test_path_rules_specifier):
1710         * Scripts/webkitpy/style/checkers/cmake.py:
1711         (CMakeChecker):
1712         * Scripts/webkitpy/style/checkers/cpp.py:
1713         (_classify_include):
1714         (check_include_line):
1715         (check_identifier_name_in_declaration):
1716         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1717         (OrderOfIncludesTest.test_classify_include):
1718         (WebKitStyleTest.test_names):
1719         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1720         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1721         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1722         (TestRebaselineTest.test_baseline_directory):
1723         * Scripts/webkitpy/tool/main.py:
1724         (WebKitPatch):
1725
1726 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1727
1728         Unreviewed. Add myself to some watchlists.
1729
1730         * Scripts/webkitpy/common/config/watchlist:
1731
1732 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1733
1734         Remove Qt builders from the flakiness dashboard.
1735
1736         * TestResultServer/static-dashboards/builders.jsonp:
1737         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1738         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1739         * TestResultServer/static-dashboards/loader_unittests.js:
1740
1741 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1742
1743         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1744         https://bugs.webkit.org/show_bug.cgi?id=122299
1745
1746         Reviewed by Beth Dakin.
1747
1748         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1749         Disable threaded scrolling.
1750
1751         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1752         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1753         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1754
1755 2013-10-03  Anders Carlsson  <andersca@apple.com>
1756
1757         Use numeric strings in the OS version dictionary
1758         https://bugs.webkit.org/show_bug.cgi?id=122300
1759
1760         Reviewed by Mark Rowe.
1761
1762         * Scripts/webkitpy/common/system/platforminfo.py:
1763         (PlatformInfo._determine_mac_version):
1764
1765 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1766
1767         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1768
1769         Rubber-stamped by Tim Horton.
1770
1771         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1772         (LeaksViewer._displayURLPrompt):
1773
1774 2013-10-03  Dan Bernstein  <mitz@apple.com>
1775
1776         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1777         https://bugs.webkit.org/show_bug.cgi?id=122260
1778
1779         Reviewed by Alexey Proskuryakov.
1780
1781         For the API to work, the tests need to be compiled with a newer version of the LLVM
1782         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1783
1784         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1785
1786 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1787
1788         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1789         https://bugs.webkit.org/show_bug.cgi?id=122015
1790
1791         Reviewed by Chris Fleizach.
1792
1793         Adapted DRT and WKTR to check the exposure of the aria-invalid
1794         attribute as a text attribute, instead of an object attribute.
1795
1796         Also, done some refactoring of the code to try to keep things
1797         simpler and more coherent, by defining new helper functions,
1798         simplifying code, moving static variables and functions into
1799         unnammed namespaces and so on, without altering the logic other
1800         than for checking the text attribute for aria-invalid.
1801
1802         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1803         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1804         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1805         Also, never return an empty string if not falling through any of
1806         the cases checked here, and return the original attribute instead.
1807         (atkAttributeValueToCoreAttributeValue): New helper function to
1808         match the attributes values returned by the ATK wrapper with the
1809         values expected by the layout tests. Moved the mappings for the
1810         values of AXSortDirection here as well.
1811         (getAttributeSet): New helper function to retrieve a list of
1812         attributes (an AtkAttributeSet) from an AtkObject using the right
1813         API depending on whether we want the object attributes or the text
1814         attributes (in case the object implements AtkText).
1815         (getAttributeSetValueForId): Simplified by using getAttributeSet
1816         and atkAttributeValueToCoreAttributeValue. Also, added a new
1817         parameter to indicater whether we are interested in object
1818         attributes or text attributes.
1819         (getAtkAttributeSetAsString): Ditto.
1820         (attributesOfElement): Updated to pass the new required parameter
1821         to getAtkAttributeSetAsString, indicating that we want the object
1822         attributes in this case, for backwards compatibility.
1823         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1824         (alterCurrentValue): Ditto.
1825         (AccessibilityUIElement::stringAttributeValue): After moving most
1826         of the code here to the new helper functions, simplified it by
1827         just checking whether the required attribute is provided as an
1828         object attribute or, if that's not the case, as a text attribute.
1829         (AccessibilityUIElement::isAttributeSupported): Ditto.
1830         (AccessibilityUIElement::intValue): Updated to pass the new
1831         required parameter to getAttributeSetValueForId, indicating that
1832         we want the object attributes in this case.
1833         (AccessibilityUIElement::hasPopup): Ditto.
1834
1835         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1836         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1837         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1838         (WTR::getAttributeSet): Ditto.
1839         (WTR::getAttributeSetValueForId): Ditto.
1840         (WTR::getAtkAttributeSetAsString): Ditto.
1841         (WTR::attributesOfElement): Ditto.
1842         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1843         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1844         (WTR::AccessibilityUIElement::intValue): Ditto.
1845         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1846
1847 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1848
1849         EWS build fix after the Qt EWS removal.
1850
1851         * QueueStatusServer/model/attachment.py:
1852         (Attachment._calculate_queue_positions):
1853
1854 2013-10-02  Anders Carlsson  <andersca@apple.com>
1855
1856         Remove Qt code from Tools/
1857         https://bugs.webkit.org/show_bug.cgi?id=122227
1858
1859         Reviewed by Andreas Kling.
1860
1861         * DumpRenderTree/WorkQueue.cpp:
1862         * DumpRenderTree/blackberry/src.pro: Removed.
1863         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1864         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1865         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1866         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1867         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1868         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1869         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1870         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1871         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1872         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1873         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1874         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1875         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1876         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1877         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1878         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1879         * DumpRenderTree/qt/resources/user.css: Removed.
1880         * DumpRenderTree/qt/testplugin.cpp: Removed.
1881         * DumpRenderTree/qt/testplugin.h: Removed.
1882         * ImageDiff/ImageDiff.pro: Removed.
1883         * ImageDiff/qt/ImageDiff.cpp: Removed.
1884         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1885         * MiniBrowser/qt/BrowserWindow.h: Removed.
1886         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1887         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1888         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1889         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1890         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1891         * MiniBrowser/qt/UrlLoader.h: Removed.
1892         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1893         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1894         * MiniBrowser/qt/icons/contents_width.png: Removed.
1895         * MiniBrowser/qt/icons/favicon.png: Removed.
1896         * MiniBrowser/qt/icons/find.png: Removed.
1897         * MiniBrowser/qt/icons/folder.png: Removed.
1898         * MiniBrowser/qt/icons/info.png: Removed.
1899         * MiniBrowser/qt/icons/next.png: Removed.
1900         * MiniBrowser/qt/icons/plus.png: Removed.
1901         * MiniBrowser/qt/icons/previous.png: Removed.
1902         * MiniBrowser/qt/icons/refresh.png: Removed.
1903         * MiniBrowser/qt/icons/stop.png: Removed.
1904         * MiniBrowser/qt/icons/titlebar.png: Removed.
1905         * MiniBrowser/qt/icons/touch.png: Removed.
1906         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1907         * MiniBrowser/qt/icons/up.png: Removed.
1908         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1909         * MiniBrowser/qt/main.cpp: Removed.
1910         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1911         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1912         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1913         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1914         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1915         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1916         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1917         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1918         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1919         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1920         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1921         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1922         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1923         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1924         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1925         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1926         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1927         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1928         * MiniBrowser/qt/raw/Target.pri: Removed.
1929         * MiniBrowser/qt/raw/View.cpp: Removed.
1930         * MiniBrowser/qt/raw/View.h: Removed.
1931         * MiniBrowser/qt/utils.cpp: Removed.
1932         * MiniBrowser/qt/utils.h: Removed.
1933         * QtTestBrowser/QtTestBrowser.pro: Removed.
1934         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1935         * QtTestBrowser/cookiejar.cpp: Removed.
1936         * QtTestBrowser/cookiejar.h: Removed.
1937         * QtTestBrowser/favicon.png: Removed.
1938         * QtTestBrowser/fpstimer.cpp: Removed.
1939         * QtTestBrowser/fpstimer.h: Removed.
1940         * QtTestBrowser/launcherwindow.cpp: Removed.
1941         * QtTestBrowser/launcherwindow.h: Removed.
1942         * QtTestBrowser/locationedit.cpp: Removed.
1943         * QtTestBrowser/locationedit.h: Removed.
1944         * QtTestBrowser/mainwindow.cpp: Removed.
1945         * QtTestBrowser/mainwindow.h: Removed.
1946         * QtTestBrowser/qttestbrowser.cpp: Removed.
1947         * QtTestBrowser/urlloader.cpp: Removed.
1948         * QtTestBrowser/urlloader.h: Removed.
1949         * QtTestBrowser/useragentlist.txt: Removed.
1950         * QtTestBrowser/utils.cpp: Removed.
1951         * QtTestBrowser/utils.h: Removed.
1952         * QtTestBrowser/webinspector.h: Removed.
1953         * QtTestBrowser/webpage.cpp: Removed.
1954         * QtTestBrowser/webpage.h: Removed.
1955         * QtTestBrowser/webview.cpp: Removed.
1956         * QtTestBrowser/webview.h: Removed.
1957         * TestWebKitAPI/DerivedSources.pri: Removed.
1958         * TestWebKitAPI/InjectedBundle.pri: Removed.
1959         * TestWebKitAPI/PlatformWebView.h:
1960         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1961         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1962         * TestWebKitAPI/Tests.pri: Removed.
1963         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1964         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1965         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1966         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1967         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1968         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1969         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1970         * TestWebKitAPI/qt/main.cpp: Removed.
1971         * Tools.pro: Removed.
1972         * WebKitTestRunner/DerivedSources.pri: Removed.
1973         * WebKitTestRunner/EventSenderProxy.h:
1974         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1975         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1976         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1977         (WTR::InjectedBundlePage::resetAfterTest):
1978         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1979         (WTR::InjectedBundlePage::didClearWindowForFrame):
1980         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1981         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1982         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1983         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1984         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1985         * WebKitTestRunner/PlatformWebView.h:
1986         * WebKitTestRunner/Target.pri: Removed.
1987         * WebKitTestRunner/TestController.cpp:
1988         (WTR::TestController::resetStateToConsistentValues):
1989         * WebKitTestRunner/TestController.h:
1990         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1991         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1992         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1993         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1994         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1995         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1996         * WebKitTestRunner/qt/main.cpp: Removed.
1997         * WebKitTestRunner/qt/resources/user.css: Removed.
1998         * qmake/.qmake.cache: Removed.
1999         * qmake/.qmake.conf: Removed.
2000         * qmake/README: Removed.
2001         * qmake/config.tests/README: Removed.
2002         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
2003         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
2004         * qmake/config.tests/gccdepends/empty.cpp: Removed.
2005         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
2006         * qmake/config.tests/glx/glx.cpp: Removed.
2007         * qmake/config.tests/glx/glx.pro: Removed.
2008         * qmake/config.tests/gnuld/gnuld.pro: Removed.
2009         * qmake/config.tests/gnuld/main.cpp: Removed.
2010         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
2011         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
2012         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
2013         * qmake/config.tests/libXrender/libXrender.pro: Removed.
2014         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
2015         * qmake/config.tests/libwebp/libwebp.pro: Removed.
2016         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
2017         * qmake/config.tests/libxml2/libxml2.pro: Removed.
2018         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
2019         * qmake/config.tests/libxslt/libxslt.pro: Removed.
2020         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
2021         * qmake/config.tests/libzlib/libzlib.pro: Removed.
2022         * qmake/dump-features.pl: Removed.
2023         * qmake/mkspecs/features/configure.prf: Removed.
2024         * qmake/mkspecs/features/default_post.prf: Removed.
2025         * qmake/mkspecs/features/default_pre.prf: Removed.
2026         * qmake/mkspecs/features/features.prf: Removed.
2027         * qmake/mkspecs/features/features.pri: Removed.
2028         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
2029         * qmake/mkspecs/features/functions.prf: Removed.
2030         * qmake/mkspecs/features/gprof.prf: Removed.
2031         * qmake/mkspecs/features/mac/default_post.prf: Removed.
2032         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
2033         * qmake/mkspecs/features/minimal_qt.prf: Removed.
2034         * qmake/mkspecs/features/production_build.prf: Removed.
2035         * qmake/mkspecs/features/rpath.prf: Removed.
2036         * qmake/mkspecs/features/unix/default_post.prf: Removed.
2037         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
2038         * qmake/mkspecs/features/unix/icc.prf: Removed.
2039         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
2040         * qmake/mkspecs/features/valgrind.prf: Removed.
2041         * qmake/mkspecs/features/webkit_modules.prf: Removed.
2042         * qmake/mkspecs/features/win32/default_post.prf: Removed.
2043         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
2044         * qmake/mkspecs/modules/angle.prf: Removed.
2045         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
2046         * qmake/mkspecs/modules/webcore.prf: Removed.
2047         * qmake/mkspecs/modules/webkit1.prf: Removed.
2048         * qmake/mkspecs/modules/webkit2.prf: Removed.
2049         * qmake/mkspecs/modules/wtf.prf: Removed.
2050
2051 2013-10-02  Tim Horton  <timothy_horton@apple.com>
2052
2053         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
2054         https://bugs.webkit.org/show_bug.cgi?id=121859
2055         <rdar://problem/15069359>
2056
2057         Reviewed by Anders Carlsson.
2058
2059         * WebKitTestRunner/TestInvocation.cpp:
2060         (WTR::shouldUseThreadedScrolling):
2061         (WTR::updateThreadedScrollingForCurrentTest):
2062         (WTR::TestInvocation::invoke):
2063         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2064         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
2065         (WTR::PlatformWebView::PlatformWebView):
2066         (WTR::PlatformWebView::viewSupportsOptions):
2067         Rename the tiled drawing switch to threaded scrolling, since that's really
2068         all it switches now that we use tiled drawing everywhere.
2069
2070         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
2071         and to more closely match the case we're interested in testing.
2072
2073 2013-10-02  Anders Carlsson  <andersca@apple.com>
2074
2075         Move AHEM____.TTF from qt/fonts/ to fonts/.
2076
2077         Rubber-stamped by Andreas Kling.
2078
2079         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2080         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
2081
2082 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2083
2084         Remove Qt bots and EWS from trunk.
2085         https://bugs.webkit.org/show_bug.cgi?id=122210.
2086
2087         Reviewed by Allan Sandfeld Jensen.
2088
2089         Remove Qt buil dbots.
2090
2091         * BuildSlaveSupport/build.webkit.org-config/config.json:
2092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2093         (appendCustomBuildFlags):
2094         (RunGtkAPITests.getText2):
2095         (Factory.__init__):
2096         (TestFactory.__init__):
2097         (BuildAndTestFactory.__init__):
2098         (loadBuilderConfig):
2099         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2100
2101 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
2102
2103         Remove Qt bots and EWS from trunk.
2104         https://bugs.webkit.org/show_bug.cgi?id=122210.
2105
2106         Reviewed by Allan Sandfeld Jensen.
2107
2108         Remove Qt EWS bots.
2109
2110         * QueueStatusServer/config/queues.py:
2111         * Scripts/webkitpy/common/config/ews.json:
2112
2113 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2114
2115         Fix singular labels for test failures.
2116
2117         https://bugs.webkit.org/show_bug.cgi?id=122200
2118
2119         Reviewed by Joseph Pecoraro.
2120
2121         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2122         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2123
2124 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2125
2126         Don't keep appending iterations each time the queue updates.
2127
2128         https://bugs.webkit.org/show_bug.cgi?id=122198
2129
2130         Reviewed by Joseph Pecoraro.
2131
2132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2133         (BuildbotQueue.prototype.update):
2134
2135 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2136
2137         Properly sort iterations in the Dashboard by revision for out-of-order queues.
2138
2139         https://bugs.webkit.org/show_bug.cgi?id=122196
2140
2141         Reviewed by Brent Fulgham.
2142
2143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2144         (BuildbotIteration):
2145         (BuildbotIteration.prototype.update):
2146         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2147         (BuildbotQueue.prototype.update):
2148         (BuildbotQueue.prototype.sortIterations):
2149
2150 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2151
2152         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
2153
2154         Also fix some URLs to not have extras slashes and add a page title.
2155
2156         https://bugs.webkit.org/show_bug.cgi?id=122192
2157
2158         Reviewed by Joseph Pecoraro.
2159
2160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2161         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2163         (WebKitBuildbot.prototype.buildLogURLForIteration):
2164         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
2165         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
2166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2167
2168 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
2169
2170         [Mac] Set NSApplication current event while sending events directly to views
2171         https://bugs.webkit.org/show_bug.cgi?id=122179
2172
2173         Reviewed by Darin Adler.
2174
2175         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
2176         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
2177         use the current event.
2178
2179         * DumpRenderTree/mac/EventSendingController.mm:
2180         (-[EventSendingController mouseDown:withModifiers:]):
2181         (-[EventSendingController mouseUp:withModifiers:]):
2182         (-[EventSendingController mouseMoveToX:Y:]):
2183         (-[EventSendingController mouseScrollByX:andY:continuously:]):
2184         (-[EventSendingController contextClick]):
2185         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2186         * WebKitTestRunner/mac/EventSenderProxy.mm:
2187         (WTR::EventSenderProxy::mouseDown):
2188         (WTR::EventSenderProxy::mouseUp):
2189         (WTR::EventSenderProxy::mouseMoveTo):
2190         (WTR::EventSenderProxy::keyDown):
2191         (WTR::EventSenderProxy::mouseScrollBy):
2192         Update the current event. We were already using the SPI in WebKit.
2193
2194 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
2195
2196         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
2197         https://bugs.webkit.org/show_bug.cgi?id=122183
2198
2199         Reviewed by Timothy Hatcher.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2202         (BuildbotIteration.prototype.update):
2203
2204 2013-10-01  Timothy Hatcher  <timothy@apple.com>
2205
2206         Tweaks to the Buildbot Dashboard
2207
2208         https://bugs.webkit.org/show_bug.cgi?id=122169
2209
2210         Reviewed by Alexey Proskuryakov.
2211
2212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2213         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2215         (BuildbotQueueView.prototype.revisionLinksForIteration):
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2217         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
2219         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2221         (WebKitBuildbot.prototype.buildLogURLForIteration):
2222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
2223
2224 2013-10-01  Commit Queue  <commit-queue@webkit.org>
2225
2226         Unreviewed, rolling out r156725.
2227         http://trac.webkit.org/changeset/156725
2228         https://bugs.webkit.org/show_bug.cgi?id=122176
2229
2230         broke all the mismatch tests again (Requested by thorton on
2231         #webkit).
2232
2233         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2234         (WTR::PlatformWebView::PlatformWebView):
2235
2236 2013-10-01  Alex Christensen  <achristensen@webkit.org>
2237
2238         Implemented createWebViewWithRequest in WinLauncher.
2239         https://bugs.webkit.org/show_bug.cgi?id=122069
2240
2241         Reviewed by Brent Fulgham.
2242
2243         * WinLauncher/PrintWebUIDelegate.cpp:
2244         (PrintWebUIDelegate::createWebViewWithRequest): Added.
2245         * WinLauncher/PrintWebUIDelegate.h:
2246         Removed createWebViewWithRequest stub.
2247
2248 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2249
2250         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2251         https://bugs.webkit.org/show_bug.cgi?id=122006
2252         <rdar://problem/15095197>
2253
2254         Reviewed by Dean Jackson.
2255
2256         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2257         (WTR::PlatformWebView::PlatformWebView):
2258         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2259         where the window server snapshot API returns blank snapshots.
2260
2261         Re-landing after r156724, this should not break everything now.
2262
2263 2013-10-01  Tim Horton  <timothy_horton@apple.com>
2264
2265         [mac] 1x emulation on Retina hardware shouldn't use SPI
2266         https://bugs.webkit.org/show_bug.cgi?id=122152
2267         <rdar://problem/15119384>
2268
2269         Reviewed by Anders Carlsson.
2270
2271         * DumpRenderTree/mac/DumpRenderTree.mm:
2272         (createWebViewAndOffscreenWindow):
2273         (main):
2274         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2275         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2276         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2277         (WTR::PlatformWebView::PlatformWebView):
2278         * WebKitTestRunner/mac/main.mm:
2279         (main):
2280         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
2281
2282 2013-09-30  Sam Weinig  <sam@webkit.org>
2283
2284         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
2285         https://bugs.webkit.org/show_bug.cgi?id=116474
2286
2287         Reviewed by Ryosuke Niwa.
2288
2289         * Scripts/webkitpy/style/checkers/cpp.py:
2290         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2291
2292 2013-09-30  Sam Weinig  <sam@webkit.org>
2293
2294         Remove support for DOMFileSystem
2295         https://bugs.webkit.org/show_bug.cgi?id=122137
2296
2297         Reviewed by Anders Carlsson.
2298
2299         * Scripts/webkitperl/FeatureList.pm:
2300         * Scripts/webkitpy/style/checkers/cpp.py:
2301         (check_spacing):
2302         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2303         (CppStyleTest.test_spacing_for_binary_ops):
2304         * qmake/mkspecs/features/features.pri:
2305
2306 2013-09-30  Mark Rowe  <mrowe@apple.com>
2307
2308         More build fixage for builds with SDKs.
2309
2310         * WebKitTestRunner/Configurations/Base.xcconfig:
2311         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2312
2313 2013-09-30  Timothy Hatcher  <timothy@apple.com>
2314
2315         Add initial version of a new Buildbot dashboard view.
2316
2317         https://bugs.webkit.org/show_bug.cgi?id=122131
2318
2319         Reviewed by Alexey Proskuryakov.
2320
2321         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
2322         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
2323         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
2324         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
2325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
2326         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
2327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
2328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
2329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
2330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
2331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
2334         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
2335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
2336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
2339         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
2340         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
2341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
2342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
2343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
2344         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
2345         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
2346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
2352         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
2353
2354 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
2355
2356         Remove the code guarded by STYLE_SCOPED
2357         https://bugs.webkit.org/show_bug.cgi?id=122123
2358
2359         Reviewed by Anders Carlsson.
2360
2361         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2362         (resetDefaultsToConsistentValues):
2363         * Scripts/webkitperl/FeatureList.pm:
2364         * qmake/mkspecs/features/features.pri:
2365
2366 2013-09-30  Mark Rowe  <mrowe@apple.com>
2367
2368         Fix the build when building against an SDK.
2369
2370         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
2371         the compiler command lines. It can't know to do this for the system framework search paths
2372         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
2373
2374         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2375         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2376
2377 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
2378
2379         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
2380
2381         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
2382         it to be double-freed.
2383
2384         * WinLauncher/WinLauncher.cpp:
2385         (EditProc): Be explicit about type passed to loadURL.
2386         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
2387         that reallocating the BSTR is done with the knowledge of the smart pointer.
2388
2389 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2390
2391         [Qt] Fix force_static_libs_as_shared in WebKit2
2392         https://bugs.webkit.org/show_bug.cgi?id=121961
2393
2394         Reviewed by Csaba Osztrogonác.
2395
2396         Get rid of the unused WebKit2QML library
2397
2398         * qmake/mkspecs/features/webkit_modules.prf:
2399         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
2400
2401 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
2402
2403         [EFL] Fix incorrect click counting in EventSenderProxy
2404         https://bugs.webkit.org/show_bug.cgi?id=122098
2405
2406         Reviewed by Gyuyoung Kim.
2407
2408         Previously used two types of recording time, which conflicted with each other.
2409
2410         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2411         (WTR::EventSenderProxy::mouseUp):
2412
2413 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
2414
2415         [webkitpy] Make the Xvfb screen depth overridable
2416         https://bugs.webkit.org/show_bug.cgi?id=122089
2417
2418         Reviewed by Gyuyoung Kim.
2419
2420         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
2421         was set. The default value that's used if the variable wasn't set is 24.
2422
2423         * Scripts/webkitpy/port/xvfbdriver.py:
2424         (XvfbDriver._xvfb_screen_depth):
2425         (XvfbDriver._start):
2426         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2427         (XvfbDriverTest.make_driver):
2428         (XvfbDriverTest.test_start_no_pixel_tests):
2429         (XvfbDriverTest.test_start_pixel_tests):
2430         (XvfbDriverTest.test_start_arbitrary_worker_number):
2431         (XvfbDriverTest.test_next_free_display):
2432         (XvfbDriverTest.test_start_next_worker):
2433
2434 2013-09-29  Mark Rowe  <mrowe@apple.com>
2435
2436         Fix the Lion build.
2437
2438         Ensure that C++ and Objective-C++ files build with the right compiler flags.
2439
2440         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
2441         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
2442
2443 2013-09-28  Mark Rowe  <mrowe@apple.com>
2444
2445         Fix some failures with newer versions of clang.
2446
2447         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
2448         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
2449         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
2450         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
2451         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
2452
2453         Reviewed by Dan Bernstein.
2454
2455         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2456         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2457         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2458         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2459         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2460         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2461         * WebKitTestRunner/Configurations/Base.xcconfig:
2462         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
2463         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2464         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2465         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2466
2467 2013-09-27  Commit Queue  <commit-queue@webkit.org>
2468
2469         Unreviewed, rolling out r156569.
2470         http://trac.webkit.org/changeset/156569
2471         https://bugs.webkit.org/show_bug.cgi?id=122035
2472
2473         broke a lot of mismatch tests (Requested by thorton on
2474         #webkit).
2475
2476         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2477         (WTR::PlatformWebView::PlatformWebView):
2478
2479 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2480
2481         Don't retry failures on Apple MountainLion Release WK1 tester
2482         https://bugs.webkit.org/show_bug.cgi?id=122026
2483
2484         Reviewed by Mark Rowe.
2485
2486         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
2487         on this bot.
2488
2489 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
2490
2491         Don't hardcode builder specific configuration in buildbot master.cfg
2492         https://bugs.webkit.org/show_bug.cgi?id=122023
2493
2494         Reviewed by Mark Rowe.
2495
2496         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
2497         property to Qt Mountain Lion Release, making it run pixel tests.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2500         (RunWebKitTests.start): Use additionalArguments.
2501         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
2502
2503 2013-09-27  Tim Horton  <timothy_horton@apple.com>
2504
2505         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
2506         https://bugs.webkit.org/show_bug.cgi?id=122006
2507         <rdar://problem/15095197>
2508
2509         Reviewed by Dean Jackson.
2510
2511         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2512         (WTR::PlatformWebView::PlatformWebView):
2513         Layer-back the root view in WebKitTestRunner's window, to work around a bug
2514         where the window server snapshot API returns blank snapshots.
2515
2516 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2517
2518         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
2519         https://bugs.webkit.org/show_bug.cgi?id=106924
2520
2521         Reviewed by Chris Fleizach.
2522
2523         Consider headings levels as values to be returned in intValue()
2524         both in DRT and WKTR, so we can share more tests with other ports.
2525
2526         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2527         (AccessibilityUIElement::intValue): Consider headings too.
2528         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2529         (WTR::AccessibilityUIElement::intValue): Ditto.
2530
2531 2013-09-26  Darin Adler  <darin@apple.com>
2532
2533         rename KURL to URL
2534         https://bugs.webkit.org/show_bug.cgi?id=16214
2535
2536         Reviewed by Andreas Kling.
2537
2538         * many files: Renamed, using script.
2539
2540 2013-09-27  Darin Adler  <darin@apple.com>
2541
2542         Fix Python scripts test failures.
2543
2544         * Scripts/webkitpy/style/checkers/cpp.py:
2545         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
2546         now, not by the checker itself.
2547
2548 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
2549
2550         [GTK][WK2] Logging of accessibility events is not disabled between tests
2551         https://bugs.webkit.org/show_bug.cgi?id=121957
2552
2553         Reviewed by Mario Sanchez Prada.
2554
2555         Fixed an issue in AccessibilityNotificationHandler where the destructor
2556         was not disconnecting accessibility event callbacks if logging was on.
2557         The decision of disconnecting events can solely rely on the existence of
2558         notification handlers because logging uses the global notification
2559         handler.
2560
2561         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2562         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
2563         disconnection when logging is on.
2564
2565 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
2566
2567         Add general CMakeLists.txt for DRT
2568         https://bugs.webkit.org/show_bug.cgi?id=119268
2569
2570         Reviewed by Gyuyoung Kim.
2571
2572         The new file allows better sharing between ports.
2573
2574         * CMakeLists.txt:
2575         * DumpRenderTree/CMakeLists.txt: Added.
2576         * DumpRenderTree/PlatformEfl.cmake: Added.
2577         * DumpRenderTree/efl/CMakeLists.txt: Removed.
2578
2579 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2580
2581         [Qt] Fix force_static_libs_as_shared in WebKit2
2582         https://bugs.webkit.org/show_bug.cgi?id=121961
2583
2584         Reviewed by Csaba Osztrogonác.
2585
2586         Reenable force_static_libs_as_shared when building WebKit2.
2587
2588         * qmake/mkspecs/features/default_post.prf:
2589
2590 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2591
2592         [Qt] Mock implementations of positioning and orientation not used
2593         https://bugs.webkit.org/show_bug.cgi?id=121956
2594
2595         Reviewed by Csaba Osztrogonác.
2596
2597         Move production_build checks to sanitizeFeatures where its value is actually known.
2598
2599         * qmake/mkspecs/features/features.prf:
2600         * qmake/mkspecs/features/features.pri:
2601
2602 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2603
2604         [ATK] Normalize checks in entry points for DRT and WKTR
2605         https://bugs.webkit.org/show_bug.cgi?id=121959
2606
2607         Reviewed by Chris Fleizach.
2608
2609         Always check if we have a proper instance of AtkObject,
2610         implementing the interfaces that we might need for each case, at
2611         the entry point of every method of AccessibilityUIElement for ATK,
2612         and do those checks in an uniform way across DRT and WKTR, to
2613         avoid confusion and issues when modifying these files in the future.
2614
2615         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2616         (AccessibilityUIElement::getChildren): Use normalized checks.
2617         (AccessibilityUIElement::getChildrenWithRange): Ditto.
2618         (AccessibilityUIElement::rowCount): Ditto.
2619         (AccessibilityUIElement::columnCount): Ditto.
2620         (AccessibilityUIElement::childrenCount): Ditto.
2621         (AccessibilityUIElement::elementAtPoint): Ditto.
2622         (AccessibilityUIElement::getChildAtIndex): Ditto.
2623         (AccessibilityUIElement::allAttributes): Ditto.
2624         (AccessibilityUIElement::titleUIElement): Ditto.
2625         (AccessibilityUIElement::parentElement): Ditto.
2626         (AccessibilityUIElement::attributesOfChildren): Ditto.
2627         (AccessibilityUIElement::role): Ditto.
2628         (AccessibilityUIElement::title): Ditto.
2629         (AccessibilityUIElement::description): Ditto.
2630         (AccessibilityUIElement::stringValue): Ditto.
2631         (AccessibilityUIElement::language): Ditto.
2632         (AccessibilityUIElement::x): Ditto.
2633         (AccessibilityUIElement::y): Ditto.
2634         (AccessibilityUIElement::width): Ditto.
2635         (AccessibilityUIElement::height): Ditto.
2636         (AccessibilityUIElement::orientation): Ditto.
2637         (AccessibilityUIElement::intValue): Ditto.
2638         (AccessibilityUIElement::minValue): Ditto.
2639         (AccessibilityUIElement::maxValue): Ditto.
2640         (indexRangeInTable): Ditto.
2641         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
2642         (AccessibilityUIElement::stringAttributeValue): Ditto.
2643         (alterCurrentValue): Ditto.
2644         (AccessibilityUIElement::press): Ditto.
2645         (AccessibilityUIElement::documentEncoding): Ditto.
2646         (AccessibilityUIElement::documentURI): Ditto.
2647         (AccessibilityUIElement::hasPopup): Ditto.
2648
2649         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2650         (WTR::indexRangeInTable): Use normalized checks.
2651         (WTR::alterCurrentValue): Ditto.
2652         (WTR::AccessibilityUIElement::getChildren): Ditto.
2653         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
2654         (WTR::AccessibilityUIElement::childrenCount): Ditto.
2655         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
2656         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
2657         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
2658         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
2659         (WTR::AccessibilityUIElement::parentElement): Ditto.
2660         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2661         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2662         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2663         (WTR::AccessibilityUIElement::role): Ditto.
2664         (WTR::AccessibilityUIElement::title): Ditto.
2665         (WTR::AccessibilityUIElement::description): Ditto.
2666         (WTR::AccessibilityUIElement::orientation): Ditto.
2667         (WTR::AccessibilityUIElement::stringValue): Ditto.
2668         (WTR::AccessibilityUIElement::language): Ditto.
2669         (WTR::AccessibilityUIElement::x): Ditto.
2670         (WTR::AccessibilityUIElement::y): Ditto.
2671         (WTR::AccessibilityUIElement::width): Ditto.
2672         (WTR::AccessibilityUIElement::height): Ditto.
2673         (WTR::AccessibilityUIElement::intValue): Ditto.
2674         (WTR::AccessibilityUIElement::minValue): Ditto.
2675         (WTR::AccessibilityUIElement::maxValue): Ditto.
2676         (WTR::AccessibilityUIElement::rowCount): Ditto.
2677         (WTR::AccessibilityUIElement::columnCount): Ditto.
2678         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
2679         (WTR::AccessibilityUIElement::press): Ditto.
2680         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2681         (WTR::AccessibilityUIElement::documentURI): Ditto.
2682         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2683
2684 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
2685
2686         [ATK] accessibility/aria-sort.html is failing after r156409
2687         https://bugs.webkit.org/show_bug.cgi?id=121947
2688
2689         Reviewed by Chris Fleizach.
2690
2691         Implement AccessibilityUIElement::isSupported for the ATK
2692         platforms, just by checking whether we have an associated object
2693         attribute exposed for the wrapper object matching the required
2694         attribute in the layout test (e.g "AXSortDirection" -> "sort").
2695
2696         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2697         (AccessibilityUIElement::isAttributeSupported): Implemented.
2698         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2699         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
2700
2701 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
2702
2703         [MediaStream] make MediaStream testable
2704         https://bugs.webkit.org/show_bug.cgi?id=121967
2705
2706         Reviewed by Dean Jackson.
2707
2708         * DumpRenderTree/mac/UIDelegate.mm:
2709         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
2710             user media request policy delegate.
2711
2712 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
2713
2714         build-webkit --inspector-frontend should copy WebInspectorUI files
2715         https://bugs.webkit.org/show_bug.cgi?id=117851
2716
2717         Reviewed by Joseph Pecoraro.
2718
2719         Change the --inspector-frontend build option to additionally build/copy 
2720         WebInspectorUI by setting it as the only project that needs to be built.
2721
2722         * Scripts/build-webkit:
2723
2724 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2725
2726         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2727         https://bugs.webkit.org/show_bug.cgi?id=121951
2728
2729         Reviewed by Carlos Garcia Campos.
2730
2731         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2732         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2733         500 layout tests that trigger accelerated compositing to be used.
2734
2735         * Scripts/webkitpy/port/xvfbdriver.py:
2736         (XvfbDriver._start):
2737         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2738         (XvfbDriverTest.test_start_no_pixel_tests):
2739         (XvfbDriverTest.test_start_pixel_tests):
2740         (XvfbDriverTest.test_start_arbitrary_worker_number):
2741         (XvfbDriverTest.test_next_free_display):
2742         (XvfbDriverTest.test_start_next_worker):
2743
2744 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2745
2746         Tiled drawing should not imply threaded scrolling
2747         https://bugs.webkit.org/show_bug.cgi?id=121874
2748         <rdar://problem/15071494>
2749
2750         Reviewed by Sam Weinig.
2751
2752         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2753         (WTR::PlatformWebView::PlatformWebView):
2754         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2755
2756 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2757
2758         Unreviewed, rolling out r156457.
2759         http://trac.webkit.org/changeset/156457
2760         https://bugs.webkit.org/show_bug.cgi?id=121960
2761
2762         Broke webkitpy tests. (Requested by kling on #webkit).
2763
2764         * Scripts/webkitpy/port/xvfbdriver.py:
2765         (XvfbDriver._start):
2766
2767 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2768
2769         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2770         https://bugs.webkit.org/show_bug.cgi?id=121951
2771
2772         Reviewed by Carlos Garcia Campos.
2773
2774         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2775         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2776         500 layout tests that trigger accelerated compositing to be used.
2777
2778         * Scripts/webkitpy/port/xvfbdriver.py:
2779         (XvfbDriver._start):
2780
2781 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2782
2783         Removed check for Apple Application Support directory in WinCairo port.
2784         https://bugs.webkit.org/show_bug.cgi?id=121869
2785
2786         Reviewed by Brent Fulgham.
2787
2788         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2789         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2790         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2791         Use DLLLauncherWinCairo.props for WinCairo ports.
2792         * win/DLLLauncher/DLLLauncherMain.cpp:
2793         (wWinMain):
2794         Don't call modifyPath to check for AAS in the WinCairo port.
2795         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2796
2797 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2798
2799         Enabled AssembleBuildLogs on WinCairo port.
2800         https://bugs.webkit.org/show_bug.cgi?id=121923
2801
2802         Reviewed by Brent Fulgham.
2803
2804         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2805         Fixed reference to README, added WinCairo configurations.
2806         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2807         Fixed reference to README.
2808         * win/AssembleBuildLogs/AssembleLogs.cmd:
2809         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2810         * win/AssembleBuildLogs/README: Fixed spelling.
2811
2812 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2813
2814         [WIN] Fix MSVC C4146 compiler warning
2815         https://bugs.webkit.org/show_bug.cgi?id=121838
2816
2817         Reviewed by Brent Fulgham.
2818
2819         Fix some variables from unsinged to int to fix the compiler warning
2820         "unary minus operator applied to unsigned type, result still unsigned".
2821
2822         * DumpRenderTree/WorkQueueItem.h:
2823         (BackItem::BackItem):
2824         (ForwardItem::ForwardItem):
2825         * DumpRenderTree/win/DumpRenderTree.cpp:
2826         (createWebViewAndOffscreenWindow):
2827
2828 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2829
2830         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2831         https://bugs.webkit.org/show_bug.cgi?id=121256
2832
2833         Reviewed by Martin Robinson.
2834
2835         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2836         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2837
2838         * BuildSlaveSupport/build.webkit.org-config/config.json:
2839
2840 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2841
2842         Add style checker for CMake lists
2843         https://bugs.webkit.org/show_bug.cgi?id=121764
2844
2845         Reviewed by Ryosuke Niwa.
2846
2847         Add an additional check to make sure that list of files are sorted.
2848         Exclude lists of include directories for now, since the order
2849         can be importent for compilation of some files.
2850
2851         * Scripts/webkitpy/style/checkers/cmake.py:
2852         (CMakeChecker.check):
2853         (CMakeChecker._check_indent):
2854         (CMakeChecker):
2855         (CMakeChecker._check_list_order):
2856         (CMakeChecker._list_item_path):
2857         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2858         (CMakeCheckerTest.test_check):
2859
2860 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2861
2862         CMakeChecker takes unusually long time to run
2863         https://bugs.webkit.org/show_bug.cgi?id=105662
2864
2865         Reviewed by Ryosuke Niwa.
2866
2867         Move the caching mechanism for regular expression of the C++ checker into
2868         a common file and use it for the CMake and ChangeLog checkers too.
2869
2870         * Scripts/webkitpy/style/checkers/changelog.py:
2871         (ChangeLogChecker.check_entry):
2872         * Scripts/webkitpy/style/checkers/cmake.py:
2873         (CMakeChecker._process_line):
2874         (CMakeChecker._check_no_space_cmds):
2875         (CMakeChecker._check_one_space_cmds):
2876         (CMakeChecker._check_non_lowercase_cmd):
2877         * Scripts/webkitpy/style/checkers/common.py:
2878         (match):
2879         (search):
2880         (searchIgnorecase):
2881         (sub):
2882         (subn):
2883         * Scripts/webkitpy/style/checkers/cpp.py:
2884
2885 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2886
2887         [Qt] Fix build with Qt 5.2 QtPosition module
2888         https://bugs.webkit.org/show_bug.cgi?id=121089
2889
2890         Reviewed by Simon Hausmann.
2891
2892         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2893         that might depend on them.
2894
2895         * qmake/mkspecs/features/default_pre.prf:
2896         * qmake/mkspecs/features/features.prf:
2897
2898 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2899
2900         [ATK] Fix style issues in AccessibilityUIElementAtk
2901         https://bugs.webkit.org/show_bug.cgi?id=121898
2902
2903         Reviewed by Chris Fleizach.
2904
2905         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2906         instead of { 0, { { 0 } } } to initialize a GValue.
2907
2908         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2909         (AccessibilityUIElement::clickPointX): Remove suffix.
2910         (AccessibilityUIElement::clickPointY): Ditto.
2911         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2912         (AccessibilityUIElement::minValue): Ditto.
2913         (AccessibilityUIElement::maxValue): Ditto.
2914         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2915         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2916         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2917         (WTR::AccessibilityUIElement::x): Ditto.
2918         (WTR::AccessibilityUIElement::y): Ditto.
2919         (WTR::AccessibilityUIElement::width): Ditto.
2920         (WTR::AccessibilityUIElement::height): Ditto.
2921         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2922         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2923         (WTR::AccessibilityUIElement::intValue): Ditto.
2924         (WTR::AccessibilityUIElement::minValue): Ditto.
2925         (WTR::AccessibilityUIElement::maxValue): Ditto.
2926
2927 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2928
2929         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2930         https://bugs.webkit.org/show_bug.cgi?id=112003
2931
2932         Reviewed by Mario Sanchez Prada.
2933
2934         Enabled addNotificationListener and removeNotificationListener for EFL port.
2935
2936         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2937         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2938         (WTR::AccessibilityController::removeNotificationListener):
2939
2940 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2941
2942         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2943         https://bugs.webkit.org/show_bug.cgi?id=121844
2944
2945         Reviewed by Mark Hahnenberg.
2946
2947         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2948
2949 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2950
2951         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2952         https://bugs.webkit.org/show_bug.cgi?id=121854
2953
2954         Reviewed by Anders Carlsson.
2955
2956         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2957         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2958         settings in underlying frameworks.
2959
2960 2013-09-24  Mark Rowe  <mrowe@apple.com>
2961
2962         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2963
2964         Reviewed by Dan Bernstein.
2965
2966         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2967         * MiniBrowser/Configurations/Base.xcconfig:
2968         * TestWebKitAPI/Configurations/Base.xcconfig:
2969         * WebKitLauncher/Configurations/Base.xcconfig:
2970         * WebKitTestRunner/Configurations/Base.xcconfig:
2971
2972 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2973
2974         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2975         https://bugs.webkit.org/show_bug.cgi?id=121674
2976
2977         Reviewed by Mario Sanchez Prada.
2978
2979         Implemented the global notification listener for
2980         AccessibilityController. The signal is generated by
2981         AXObjectCache::postPlatformNotification() and received by
2982         axObjectEventListener(). axObjectEventListener will then invoke
2983         JSObjectCallAsFunction() with the respective callback function.
2984
2985         There is no additional test for this patch since its implementation will
2986         be tested by an accessibility layout test that is currently failing
2987         (accessibility/loading-iframe-sends-notification.html).
2988
2989         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2990         stub implementations of addNotificationListener and
2991         removeNotificationListener for the GTK port.
2992         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2993         (WTR::AccessibilityController::addNotificationListener): Creates the
2994         notification handler and sets the notification function callback.
2995         (WTR::AccessibilityController::removeNotificationListener): Removes the
2996         global handler.
2997
2998 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2999
3000         [GTK] fast/images/exif-orientation-composited.html is failing
3001         https://bugs.webkit.org/show_bug.cgi?id=119731
3002
3003         Reviewed by Carlos Garcia Campos.
3004
3005         Add handling respect image orientation property in DRT.
3006
3007         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3008         (TestRunner::overridePreference):
3009
3010 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
3011
3012         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
3013         https://bugs.webkit.org/show_bug.cgi?id=121787
3014
3015         Reviewed by Gustavo Noronha Silva.
3016
3017         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
3018         with the Wayland target enabled to version 3.10.0.
3019
3020 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
3021
3022         use NOMINMAX instead of #define min min
3023         https://bugs.webkit.org/show_bug.cgi?id=73563
3024
3025         Reviewed by Brent Fulgham.
3026
3027         Use NOMINMAX instead of #define min/max as a cleaner
3028         way of ensuring that Windows system header files don't
3029         define min/max as macro in the first place.
3030
3031         * DumpRenderTree/DumpRenderTreePrefix.h:
3032         * DumpRenderTree/cg/ImageDiffCG.cpp:
3033         * DumpRenderTree/config.h:
3034         * DumpRenderTree/win/ImageDiffCairo.cpp:
3035         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3036         * WebKitTestRunner/config.h:
3037
3038 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3039
3040         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3041         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3042
3043         Reviewed by Alexey Proskuryakov.
3044
3045         Previously, initalizing a WebPreference would change the cache model
3046         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3047         preference file on disk.
3048
3049         This patch fixes the tests by resetting the default, and using the proper
3050         default values after initializing WebPreference.
3051
3052         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3053         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3054         to the previous runs.
3055
3056         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3057         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
3058         cache model to the one required.
3059
3060         * TestWebKitAPI/ios/mainIOS.mm:
3061         (main): Reset the preferences before testing.
3062         * TestWebKitAPI/mac/mainMac.mm:
3063         (main): Ditto.
3064
3065 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
3066
3067         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
3068         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
3069
3070         Reviewed by Alexey Proskuryakov.
3071
3072         Previously, initalizing a WebPreference would change the cache model
3073         to WebCacheModelDocumentBrowser. That behavior was due to a stale
3074         preference file on disk.
3075
3076         This patch fixes the tests by resetting the default, and using the proper
3077         default values after initializing WebPreference.
3078
3079         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3080         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
3081         to the previous runs.
3082
3083         * TestWebKitAPI/ios/mainIOS.mm:
3084         (main): Reset the preferences before testing.
3085         * TestWebKitAPI/mac/mainMac.mm:
3086         (main): Ditto.
3087
3088 2013-09-23  Anders Carlsson  <andersca@apple.com>
3089
3090         ListHashSet should work with move-only types
3091         https://bugs.webkit.org/show_bug.cgi?id=121802
3092
3093         Reviewed by Andreas Kling.
3094
3095         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3096         (TestWebKitAPI::TEST):
3097         Add a test for move-only types.
3098
3099 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
3100
3101         Added --64-bit option for Windows build.
3102         https://bugs.webkit.org/show_bug.cgi?id=121799
3103
3104         Reviewed by Brent Fulgham.
3105
3106         * Scripts/webkitdirs.pm:
3107         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
3108         (isWin64): Added.
3109         (determineIsWin64): Added.
3110
3111 2013-09-23  Anders Carlsson  <andersca@apple.com>
3112
3113         ListHashSet should use std::reverse_iterator for reverse iterators
3114         https://bugs.webkit.org/show_bug.cgi?id=121795
3115
3116         Reviewed by Antti Koivisto.
3117
3118         Add test for reverse iterators.
3119
3120         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3121         (TestWebKitAPI::TEST):
3122
3123 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
3124
3125         [EFL] accessibility/aria-invalid is failing
3126         https://bugs.webkit.org/show_bug.cgi?id=111986
3127
3128         Reviewed by Mario Sanchez Prada.
3129
3130         Adds possibility to retrieve JS context.
3131         This is part of the implementation of AccessibilityUIElement::addNotificationListener
3132         from 119883 and 120421.
3133
3134         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3135         (axObjectEventListener):
3136         (addAccessibilityNotificationHandler):
3137         (removeAccessibilityNotificationHandler):
3138         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3139         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3140         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3141
3142 2013-09-20  Mark Rowe  <mrowe@apple.com>
3143
3144         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
3145
3146         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
3147
3148         Reviewed by David Kilzer.
3149
3150         * Scripts/webkitdirs.pm:
3151         (checkRequiredSystemConfig):
3152
3153 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3154
3155         [ATK] Do not expose aria-help in ATK based platforms
3156         https://bugs.webkit.org/show_bug.cgi?id=121675
3157
3158         Reviewed by Chris Fleizach.
3159
3160         Remove the implementations for AccessibilityUIElement::helpText()
3161         from DRT and WKTR for GTK and EFL, since they are based on the
3162         AccessibilityObject::helpText() method and the 'aria-help'
3163         attributes, which is wrong since they should not depend on that
3164         but in ATK specific API (see also http://webkit.org/b/121684).
3165
3166         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3167         (AccessibilityUIElement::helpText): Added a new and empty
3168         implementation, now that we are no longer using this in ATK.
3169         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
3170         as the only function provided here was helpText().
3171         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
3172         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
3173         removed from the list of sources to compile.
3174         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
3175         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3176         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
3177         based in DumpRenderTreeSupportGtk with an empty one.
3178
3179 2013-09-20  Dan Bernstein  <mitz@apple.com>
3180
3181         Make extract-localizable-strings available to WebCore clients
3182         https://bugs.webkit.org/show_bug.cgi?id=121699
3183
3184         Reviewed by Darin Adler.
3185
3186         * Scripts/extract-localizable-strings: Copied to
3187         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
3188         executes the script from its new location. This is a temporary measure until certain code
3189         that is external to WebKit is adapted to the new location.
3190         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
3191         from its new location.
3192
3193 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
3194
3195         Nuke remaining VS2005 tools from the tree.
3196         https://bugs.webkit.org/show_bug.cgi?id=121691
3197
3198         Reviewed by Brent Fulgham.
3199
3200         * CLWrapper/CLWrapper.cpp: Removed.
3201         * CLWrapper/CLWrapper.sln: Removed.
3202         * CLWrapper/CLWrapper.vcproj: Removed.
3203         * MIDLWrapper/MIDLWrapper.cpp: Removed.
3204         * MIDLWrapper/MIDLWrapper.sln: Removed.
3205         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
3206         * Scripts/parallelcl: Removed.
3207         * vcbin/cl.exe: Removed.
3208         * vcbin/midl.exe: Removed.
3209
3210 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
3211
3212         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
3213         https://bugs.webkit.org/show_bug.cgi?id=121294
3214
3215         Reviewed by Martin Robinson.
3216
3217         Provide a new patch to deal with the issue in the GTK+ module from
3218         the internal jhbuild environment. This issue has been reported
3219         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
3220
3221         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
3222         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
3223
3224 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3225
3226         [ATK][WTR] accessibility/aria-invalid.html times out
3227         https://bugs.webkit.org/show_bug.cgi?id=121668
3228
3229         Reviewed by Mario Sanchez Prada.
3230
3231         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
3232         false in case of aria-invalid event with empty value.
3233
3234         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3235         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
3236         case of aria-invalid event with empty value.
3237
3238 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
3239
3240         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
3241         https://bugs.webkit.org/show_bug.cgi?id=120421
3242
3243         Reviewed by Mario Sanchez Prada.
3244
3245         Implemented the notification listener for AccessibilityUIElement for
3246         WebKitTestRunner. The signal is generated by
3247         AXObjectCache::postPlatformNotification() and received by
3248         axObjectEventListener(). axObjectEventListener() will then invoke
3249         JSObjectCallAsFunction() with the respective callback function. The
3250         notification handlers are stored in HashMap in
3251         AccessibilityNotificationHandlerAtk.cpp.
3252
3253         Moved ATK signal handling (printAccessibilityEvent and
3254         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
3255
3256         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
3257         include path.
3258         * WebKitTestRunner/GNUmakefile.am:
3259         Added AccessibilityNotificationHandlerAtk.cpp/h.
3260         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
3261         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3262         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
3263         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
3264         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
3265         notification handler for GTK+ and EFL.
3266         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3267         Moved printAccessibilityEvent and axObjectEventListener to
3268         AccessibilityNotificationHandlerAtk.cpp.
3269         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
3270         IDs to AccessibilityNotificationHandlerAtk.cpp.
3271         (WTR::AccessibilityController::resetToConsistentState): Moved listener
3272         IDs to AccessibilityNotificationHandlerAtk.cpp.
3273         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
3274         (WTR::printAccessibilityEvent): Prints accessibility events. This
3275         function was moved from AccessibilityControllerAtk.cpp.
3276         (WTR::axObjectEventListener): Callback for signals. This function was
3277         moved from AccessibilityControllerAtk.cpp.
3278         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
3279         Initialize element and function callback.
3280         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
3281         Removes handler from HashMap and disconnects callbacks if necessary.
3282         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
3283         logging mode and connects callbacks.
3284         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3285         Sets the notification callback and connects callback to signals.
3286         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3287         Removes the notification callback from HashMap.
3288         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3289         Connects axObjectEventListener to ATK signals.
3290         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3291         Disconnects callback.
3292         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
3293         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
3294         of AccessibilityNotificationHandler.
3295         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
3296         element.
3297         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
3298         element.
3299         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
3300         Gets the notification callback.
3301         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3302         (WTR::AccessibilityUIElement::addNotificationListener): Creates
3303         notification handler, set the platform element and the notification
3304         callback.
3305         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
3306         notification handler.
3307         * WebKitTestRunner/PlatformEfl.cmake:
3308         Added AccessibilityNotificationHandlerAtk.cpp.
3309
3310 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3311
3312         Update features.pri
3313         https://bugs.webkit.org/show_bug.cgi?id=121670
3314
3315         Reviewed by Jocelyn Turcotte.
3316
3317         Remove feature flags that no longer exists and new ones added to FeatureList.pm
3318
3319         * qmake/mkspecs/features/features.pri:
3320
3321 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
3322
3323         [GTK][WK2] accessibility/selection-states.html is failing
3324         https://bugs.webkit.org/show_bug.cgi?id=116972
3325
3326         Reviewed by Mario Sanchez Prada.
3327
3328         isSelectable() was not exposed in Accessibility.
3329
3330         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3331
3332 2013-09-19  Dan Bernstein  <mitz@apple.com>
3333
3334         Attempted build fix after r156114.
3335
3336         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
3337
3338 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
3339
3340         REGRESSION (r129451): run-safari --no-saved-state is broken
3341         https://bugs.webkit.org/show_bug.cgi?id=121566
3342
3343         Undo a last minute change that doesn't actually work.
3344
3345         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
3346         via command line, <rdar://problem/15032886>.
3347
3348 2013-09-19  Dan Bernstein  <mitz@apple.com>
3349
3350         Add a style guideline regarding spacing in range-based for loops
3351         https://bugs.webkit.org/show_bug.cgi?id=121620
3352
3353         Reviewed by Anders Carlsson.
3354
3355         * Scripts/webkitpy/style/checkers/cpp.py:
3356         (check_spacing): Added checking that there are spaces around the colon in a range-based for
3357         loop.
3358         (CppChecker): Added whitespace/colon to the categories set.
3359         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3360         (WebKitStyleTest.test_spacing): Added two tests for the new check.
3361
3362 2013-09-18  Sam Weinig  <sam@webkit.org>
3363
3364         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
3365         https://bugs.webkit.org/show_bug.cgi?id=121588
3366
3367         Reviewed by Anders Carlsson.
3368
3369         * DumpRenderTree/TestRunner.cpp:
3370         * ImageDiff/efl/ImageDiff.cpp:
3371         * TestWebKitAPI/JavaScriptTest.cpp:
3372         * TestWebKitAPI/PlatformUtilities.cpp:
3373         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3374         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3375         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3376         * WebKitTestRunner/StringFunctions.h:
3377         * WebKitTestRunner/TestInvocation.cpp:
3378         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3379         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3380
3381 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
3382
3383         W3C Test Import script reformats test HTML
3384         https://bugs.webkit.org/show_bug.cgi?id=119159
3385
3386         Reviewed by Dirk Pranke.
3387
3388         Completely rewrite the test conversion process to minimize
3389         reformatting when adding prefixes, etc. This isn't 100% perfect, there
3390         are still places where it will end up changing the formatting, but it
3391         is much better than before. Most notably, the public interface to the
3392         test converter has changed: now one calls a method instead of creating
3393         an instance of the test converter class. This is because the test
3394         converter class now has state, so one really needs a new instance for
3395         each test.
3396
3397         Note that this also lays some simple groundwork for being able to use
3398         a MockHost in the tests.
3399
3400         * Scripts/webkitpy/w3c/test_converter.py:
3401         (convert_for_webkit):
3402         (_W3CTestConverter):
3403         (_W3CTestConverter.__init__):
3404         (_W3CTestConverter.output):
3405         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
3406         (_W3CTestConverter.convert_style_data):
3407         (_W3CTestConverter.convert_attributes_if_needed):
3408         (_W3CTestConverter.handle_starttag):
3409         (_W3CTestConverter.handle_endtag):
3410         (_W3CTestConverter.handle_startendtag):
3411         (_W3CTestConverter.handle_data):
3412         (_W3CTestConverter.handle_entityref):
3413         (_W3CTestConverter.handle_charref):
3414         (_W3CTestConverter.handle_comment):
3415         (_W3CTestConverter.handle_decl):
3416         (_W3CTestConverter.handle_pi):
3417         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3418         (W3CTestConverterTest):
3419         (W3CTestConverterTest.fake_dir_path):
3420         (W3CTestConverterTest.test_read_prefixed_property_list):
3421         (verify_no_conversion_happened):
3422         * Scripts/webkitpy/w3c/test_importer.py:
3423         (TestImporter.import_tests):
3424
3425 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3426
3427         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
3428         https://bugs.webkit.org/show_bug.cgi?id=121578
3429
3430         Rubber stamped by Geoffrey Garen.
3431
3432         * Scripts/run-layout-jsc:
3433
3434 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3435
3436         Unreviewed, fix for Ruby 1.8.
3437
3438         * Scripts/run-jsc-stress-tests:
3439
3440 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3441
3442         run-jsc-stress-tests should make it easier to look at error spew from tests
3443         https://bugs.webkit.org/show_bug.cgi?id=121531
3444
3445         Reviewed by Mark Hahnenberg.
3446         
3447         This makes two changes:
3448         
3449         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
3450         
3451         - The same spew also goes to the console but is prefixed by the test's name.
3452         
3453         This required some tee and awk hacks, and then some sh hacks to work around the fact
3454         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
3455         operator will only see a failure of bar failed. So to pass output to tee and awk, I
3456         needed to do weird things.
3457
3458         * Scripts/run-jsc-stress-tests:
3459
3460 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
3461
3462         REGRESSION (r129451): run-safari --no-saved-state is broken
3463         https://bugs.webkit.org/show_bug.cgi?id=121566
3464
3465         Reviewed by Mark Rowe.
3466
3467         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
3468         Check arguments, not the newly created empty array. Pass a value that silences warnings.
3469         While at it, removed a check for Snow Leopard.
3470
3471 2013-09-18  Alex Christensen  <achristensen@webkit.org>
3472
3473         Improved WinLauncher's URL handling.
3474         https://bugs.webkit.org/show_bug.cgi?id=121535
3475
3476         Reviewed by Brent Fulgham.
3477
3478         * WinLauncher/WinLauncher.cpp:
3479         (EditProc):
3480         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
3481         (loadURL):
3482         Prepend "http://" to URLs with no scheme.
3483
3484 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
3485
3486         DFG should support Int52 for local variables
3487         https://bugs.webkit.org/show_bug.cgi?id=121064
3488
3489         Reviewed by Oliver Hunt.
3490
3491         * Scripts/run-jsc-stress-tests:
3492
3493 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
3494
3495         [Win] TestWebKitAPI does not compile.
3496         https://bugs.webkit.org/show_bug.cgi?id=121485
3497
3498         Reviewed by Brent Fulgham.
3499
3500         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
3501         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
3502         to return null, which is the case we want to test.
3503
3504         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3505         (TestWebKitAPI::TEST):
3506
3507 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
3508
3509         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
3510         https://bugs.webkit.org/show_bug.cgi?id=121495
3511
3512         Reviewed by Chris Fleizach.
3513
3514         Adapted DRT and WKTR to deal with the new names for the ATK object
3515         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
3516
3517         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3518         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
3519         (AccessibilityUIElement::stringAttributeValue): Ditto.
3520         (AccessibilityUIElement::hasPopup): Ditto.
3521         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3522         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
3523         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
3524         (WTR::AccessibilityUIElement::hasPopup): Ditto.
3525
3526 2013-09-18  Commit Queue  <commit-queue@webkit.org>
3527
3528         Unreviewed, rolling out r156019 and r156020.
3529         http://trac.webkit.org/changeset/156019
3530         http://trac.webkit.org/changeset/156020
3531         https://bugs.webkit.org/show_bug.cgi?id=121540
3532
3533         Broke tests (Requested by ap on #webkit).
3534
3535         * Scripts/run-jsc-stress-tests:
3536
3537 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
3538
3539         Unreviewed. Add myself as a committer.
3540
3541         * Scripts/webkitpy/common/config/contributors.json:
3542
3543 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
3544
3545         Unreviewed. Add myself as a committer.
3546
3547         * Scripts/webkitpy/common/config/contributors.json:
3548
3549 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
3550
3551         DFG should support Int52 for local variables
3552         https://bugs.webkit.org/show_bug.cgi?id=121064
3553
3554         Reviewed by Oliver Hunt.
3555
3556         * Scripts/run-jsc-stress-tests:
3557
3558 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
3559
3560         Added back and forward buttons to WinLauncher.
3561         https://bugs.webkit.org/show_bug.cgi?id=121212
3562
3563         Reviewed by Brent Fulgham.
3564
3565         * WinLauncher/WinLauncher.cpp:
3566         (resizeSubViews):
3567         Move new back and forward buttons to correct positions before URL bar.
3568         (dllLauncherEntryPoint): 
3569         Store the default button window procedure and replace with my button procedures.
3570         (EditProc): Updated style and renamed from MyEditProc.
3571         (BackButtonProc): Added.
3572         (ForwardButtonProc): Added.
3573
3574 2013-09-17  Michael Saboff  <msaboff@apple.com>
3575
3576         Unreviewed typo fix after r155999
3577
3578         Changed en_US.UTB-8 to en_US.UTF-8
3579
3580         * Scripts/run-javascriptcore-tests:
3581
3582 2013-09-17  Michael Saboff  <msaboff@apple.com>
3583
3584         run-jsc-stress-tests fails with ruby version 2
3585         https://bugs.webkit.org/show_bug.cgi?id=121521
3586
3587         Reviewed by Jessie Berlin.
3588
3589         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
3590
3591         * Scripts/run-javascriptcore-tests:
3592
3593 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
3594
3595         [Windows] Unreviewed build fix after r155963.
3596
3597         * DumpRenderTree/win/TestRunnerWin.cpp:
3598         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
3599
3600 2013-09-17  Anders Carlsson  <andersca@apple.com>
3601
3602         Fix a typo.
3603
3604         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3605         (TestWebKitAPI::TEST):
3606
3607 2013-09-16  Anders Carlsson  <andersca@apple.com>
3608
3609         HashMap should work with move-only keys
3610         https://bugs.webkit.org/show_bug.cgi?id=121310
3611
3612         Reviewed by Darin Adler.
3613
3614         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3615         (TestWebKitAPI::TEST):
3616         Add test.
3617
3618 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
3619
3620         BrowserMarshal.h build fail
3621         https://bugs.webkit.org/show_bug.cgi?id=102938
3622
3623         Reviewed by Carlos Garcia Campos.
3624
3625         Fix variable name.
3626
3627         * MiniBrowser/gtk/GNUmakefile.am:
3628
3629 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3630
3631         [Windows] Clean up WinLauncher by using smart pointers
3632         https://bugs.webkit.org/show_bug.cgi?id=121467
3633
3634         Reviewed by Anders Carlsson.
3635
3636         * WinLauncher/PrintWebUIDelegate.cpp:
3637         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
3638         * WinLauncher/WinLauncher.cpp:
3639         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
3640         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
3641         (showLastVisitedSites): Smart pointer updates.
3642         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
3643         (setToDefaultPreferences): Ditto.
3644         (dllLauncherEntryPoint): Ditto.
3645         (PrintView): Ditto.
3646         (LaunchInspector): Ditto.
3647         (NavigateToHistory): Ditto.
3648         (MyEditProc): Ditto.
3649         (loadURL): Ditto.
3650
3651 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
3652
3653         [Windows] Add rudimentary history to WinLauncher.
3654         https://bugs.webkit.org/show_bug.cgi?id=121463
3655
3656         Reviewed by Anders Carlsson.
3657
3658         * WinLauncher/WinLauncher.cpp:
3659         (updateMenuItemForHistoryItem): Added
3660         (showLastVisitedSites): Added
3661         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
3662         a new page has been visited.
3663         (dllLauncherEntryPoint): Deallocate history on exit.
3664         (NavigateToHistory): Added
3665         (WndProc): Add handler for history entries
3666         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
3667         up to 10 history slots.
3668         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
3669         Windows utility library to allow use of _bstr_t type.
3670         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
3671         to hold up to 10 history slots.
3672         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
3673
3674 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
3675
3676         [GTK] Make symbol export filter more strict, and disable for dev/test builds
3677         https://bugs.webkit.org/show_bug.cgi?id=120586
3678
3679         Reviewed by Martin Robinson.
3680
3681         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
3682         makefiles, so they can be included unconditionally.
3683         * GtkLauncher/GNUmakefile.am: added.
3684         * Scripts/webkitdirs.pm:
3685         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
3686         to configure, since we consider builds done through build-webkit to be development
3687         and test builds.
3688         * gtk/GNUmakefile.am: added.
3689         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
3690         it's not necessary and it will not work now that the Scripts directory is not
3691         shipped in the tarball.
3692
3693 2013-09-16  Anders Carlsson  <andersca@apple.com>
3694
3695         WTF::Deque should work with move only types
3696         https://bugs.webkit.org/show_bug.cgi?id=121446
3697
3698         Reviewed by Andreas Kling.
3699
3700         * TestWebKitAPI/Tests/WTF/Deque.cpp:
3701         (TestWebKitAPI::TEST):
3702         Add a test.
3703
3704 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
3705
3706         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
3707         https://bugs.webkit.org/show_bug.cgi?id=98410
3708
3709         Reviewed by Darin Adler.
3710
3711         Add implementation of click() method of objects returned by eventSender.contextClick().
3712
3713         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3714         (MenuItemPrivateData):
3715         (WTR::menuItemClickCallback):
3716         (WTR::getMenuItemTitleCallback):
3717         (WTR::staticMenuItemFinalize):
3718         (WTR::getMenuItemClass):
3719         (WTR::EventSendingController::contextClick):
3720
3721 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3722
3723         Make the GDB webkit.py script compatible with Python v3
3724         https://bugs.webkit.org/show_bug.cgi?id=121395
3725
3726         Reviewed by Ryosuke Niwa.
3727
3728         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3729         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3730         the print() function invocations.
3731
3732         * gdb/webkit.py:
3733         (guess_string_length):
3734         (ustring_to_string):
3735         (lstring_to_string):
3736         (WTFCStringPrinter.to_string):
3737         (PrintPathToRootCommand.invoke):
3738
3739 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3740
3741         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3742         https://bugs.webkit.org/show_bug.cgi?id=119631
3743
3744         Reviewed by Ryosuke Niwa.
3745
3746         The perf profiler is attached to the test runner after the test runner has been launched,
3747         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3748         UIProcess, meaning that WebProcess operations will not be profiled.
3749
3750         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3751         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3752         that are settable through the --wrapper option. This causes the perf profiler to correctly
3753         continue profiling the WebProcess after it was spawned.
3754
3755         When the profiler is launched, a wait process is launched with the profiler's pid as the
3756         argument. This ensures we can check that the profiler exited normally. If it did not, its
3757         output can be corrupted and can cause problems when that output is examined. The after-exit
3758         report is avoided in that case.
3759
3760         * Scripts/webkitpy/common/system/profiler.py:
3761         (Profiler.wrapper_arguments): The method returns an empty list by default.
3762         (Perf.__init__): Remove unnecessary member variables.
3763         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3764         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3765         the method returns a list of arguments that should be used as a wrapper for the test runner.
3766         The arguments specify the 'perf record' command, with the output file and the instruction to
3767         construct the call graph given as well.
3768         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3769         whitespace in the profile lines.
3770         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3771         running. If it is running even after that, or if the profiler process produced a non-zero exit
3772         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3773         the top 10 lines of the profile and how to examine the profile further.
3774         * Scripts/webkitpy/port/driver.py:
3775         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3776         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3777         or an empty list otherwise.
3778         (Driver.cmd_line):
3779         * Scripts/webkitpy/port/driver_unittest.py:
3780         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3781         for the testing-specific Port object.
3782         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3783         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3784         a parameter.
3785         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3786         when profiling on the Linux platform with the perf profiler.
3787
3788 2013-09-14  Dan Bernstein  <mitz@apple.com>
3789
3790         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3791         https://bugs.webkit.org/show_bug.cgi?id=121215
3792
3793         Reviewed by Mark Rowe.
3794
3795         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3796         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3797         public and private headers folder paths. Also tweaked the error messages’ format to make
3798         Xcode recognize them as errors.
3799
3800 2013-09-14  Alberto Garcia  <berto@igalia.com>
3801
3802         [GTK] Fails to compile if the build directory is in a different partition
3803         https://bugs.webkit.org/show_bug.cgi?id=121296
3804
3805         Reviewed by Martin Robinson.
3806
3807         Instead of using os.symlink() to install the gtk-doc templates,
3808         use os.link() first and fall back to os.symlink() if it fails.
3809
3810         * gtk/gtkdoc.py:
3811         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3812
3813 2013-09-14  Alberto Garcia  <berto@igalia.com>
3814
3815         [GTK] WebKitGTK+ is linking against libxslt in too many places
3816         https://bugs.webkit.org/show_bug.cgi?id=121356
3817
3818         Reviewed by Martin Robinson.
3819
3820         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3821         so we don't need to link against it.
3822
3823         * MiniBrowser/gtk/GNUmakefile.am:
3824         * TestWebKitAPI/GNUmakefile.am:
3825         * WebKitTestRunner/GNUmakefile.am:
3826
3827 2013-09-14  Ross Burton  <ross.burton@intel.com>
3828
3829         Uses gtk-doc tools even when --disable-gtk-doc passed
3830         https://bugs.webkit.org/show_bug.cgi?id=91239
3831
3832         Reviewed by Martin Robinson.
3833
3834         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3835
3836         * GNUmakefile.am:
3837
3838 2013-09-14  Alberto Garcia  <berto@igalia.com>
3839
3840         [GTK] Fails to compile if the build directory is in a different partition
3841         https://bugs.webkit.org/show_bug.cgi?id=121296
3842
3843         Reviewed by Carlos Garcia Campos.
3844
3845         Use symlinks instead of hard links to support building on a
3846         different file system.
3847
3848         * gtk/gtkdoc.py:
3849         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3850
3851 2013-09-13  Darin Adler  <darin@apple.com>
3852
3853         Use a better name than m_invertibleCTM
3854         https://bugs.webkit.org/show_bug.cgi?id=121341
3855
3856         Reviewed by Andreas Kling.
3857
3858         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3859
3860 2013-09-13  Anders Carlsson  <andersca@apple.com>
3861
3862         Pick the correct overload when a const reference is passed to appendSlowCase.
3863         https://bugs.webkit.org/show_bug.cgi?id=121326
3864
3865         Reviewed by Darin Adler.
3866
3867         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3868         (TestWebKitAPI::TEST):
3869
3870 2013-09-13  Darin Adler  <darin@apple.com>
3871
3872         Rename confusingly named "runtimeObject" functions
3873         https://bugs.webkit.org/show_bug.cgi?id=121339
3874
3875         Reviewed by Sam Weinig.
3876
3877         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3878
3879 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3880
3881         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3882         https://bugs.webkit.org/show_bug.cgi?id=121330
3883
3884         Reviewed by Mark Hahnenberg and Oliver Hunt.
3885
3886         We should run tests even if they don't have expected files yet.
3887         
3888         * Scripts/run-layout-jsc:
3889
3890 2013-09-13  Anders Carlsson  <andersca@apple.com>
3891
3892         Use nullptr instead of 0 in calls to HashMap::add
3893         https://bugs.webkit.org/show_bug.cgi?id=121322
3894
3895         Reviewed by Sam Weinig.
3896
3897         * DumpRenderTree/mac/TestRunnerMac.mm:
3898         (TestRunner::evaluateScriptInIsolatedWorld):
3899         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3900         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3901
3902 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3903
3904         [GTK] Move to the new web inspector
3905         https://bugs.webkit.org/show_bug.cgi?id=120647
3906
3907         Reviewed by Carlos Garcia Campos.
3908
3909         * GtkLauncher/main.c:
3910         (main): no longer set WEBKIT_INSPECTOR_PATH.
3911         * MiniBrowser/gtk/main.c:
3912         (main): ditto.
3913         * Scripts/old-run-webkit-tests:
3914         (openDumpTool): ditto.
3915         * Scripts/run-gtk-tests: ditto.
3916         * Scripts/webkitpy/port/gtk.py:
3917         (GtkPort.setup_environ_for_server): ditto.
3918
3919 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3920
3921         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3922         https://bugs.webkit.org/show_bug.cgi?id=120595
3923
3924         Reviewed by Jocelyn Turcotte.
3925
3926         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3927
3928         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3929         (DumpRenderTree::initJSObjects):
3930
3931 2013-09-13  Darin Adler  <darin@apple.com>
3932
3933         Give actions in Range class NON_SHOUTING_NAMES
3934         https://bugs.webkit.org/show_bug.cgi?id=121280
3935
3936         Reviewed by Andreas Kling.
3937
3938         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3939         the tradition of checking in the last one we did, along with other
3940         rename ideas for the future.
3941
3942 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3943
3944         Create short build logs for errors and warnings.
3945         https://bugs.webkit.org/show_bug.cgi?id=120614
3946
3947         Reviewed by Ryosuke Niwa.
3948
3949         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3950             -include StringIO 
3951         (CompileWebKit.createSummary):
3952             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3953
3954 2013-09-12  Roger Fong  <roger_fong@apple.com>
3955
3956         Update cygwin downloader to search for packages in the right location.
3957
3958         * CygwinDownloader/cygwin-downloader.py:
3959         * CygwinDownloader/cygwin-downloader.zip:
3960
3961 2013-09-12  Anders Carlsson  <andersca@apple.com>
3962
3963         Add rudimentary support for move-only types as values in HashMap
3964         https://bugs.webkit.org/show_bug.cgi?id=121226
3965
3966         Reviewed by Andreas Kling.
3967
3968         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3969         (TestWebKitAPI::TEST):
3970         Add a HashMap<unsigned, MoveOnly> test.
3971
3972 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3973
3974         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3975         https://bugs.webkit.org/show_bug.cgi?id=119338
3976
3977         Reviewed by Csaba Osztrogonác.
3978
3979         * Scripts/webkitpy/port/efl.py:
3980         (EflPort.check_sys_deps):
3981         (EflPort):
3982         (EflPort._get_crash_log):
3983         * Scripts/webkitpy/port/efl_unittest.py:
3984         (EflPortTest.test_show_results_html_file):
3985         (EflPortTest):
3986         (EflPortTest.test_get_crash_log):
3987         * Scripts/webkitpy/port/gtk.py:
3988         (GtkPort._get_crash_log):
3989         * Scripts/webkitpy/port/gtk_unittest.py:
3990         (GtkPortTest.test_get_crash_log):
3991         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
3992         (GDBCrashLogGenerator):
3993         (GDBCrashLogGenerator.__init__):
3994         (GDBCrashLogGenerator._get_gdb_output):
3995         (GDBCrashLogGenerator.generate_crash_log):
3996         (GDBCrashLogGenerator.generate_crash_log.match_filename):
3997         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
3998         (GDBCrashLogGeneratorTest):
3999         (GDBCrashLogGeneratorTest.test_generate_crash_log):
4000         (_mock_gdb_output):
4001         * Scripts/webkitpy/port/qt.py:
4002         (QtPort.default_child_processes):
4003         (QtPort):
4004         (QtPort._get_crash_log):
4005         * Scripts/webkitpy/port/qt_unittest.py:
4006         (QtPortTest.test_check_sys_deps):
4007         (QtPortTest):
4008         (QtPortTest.test_get_crash_log):
4009
4010 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
4011
4012         Unreviewed. Moving myself to the commiters list.
4013
4014         * Scripts/webkitpy/common/config/contributors.json:
4015
4016 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
4017
4018         [GTK] Add jhbuild-wayland.modules
4019         https://bugs.webkit.org/show_bug.cgi?id=120455
4020
4021         Reviewed by Gustavo Noronha Silva.
4022
4023         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
4024         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
4025         WEBKIT_EXTRA_MODULESETS.
4026
4027         * gtk/jhbuild-wayland.modules: Added.
4028
4029 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
4030
4031         [GTK][WK2] a11y tests unconditionally launching a11y daemons
4032         https://bugs.webkit.org/show_bug.cgi?id=120299
4033
4034         Reviewed by Carlos Garcia Campos.
4035
4036         Use the right variable name to store a reference to the at-spi2
4037         bus launcher process, so we can be sure we are terminating it when
4038         calling _tear_down_testing_environment().
4039
4040         * Scripts/run-gtk-tests:
4041         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
4042         instead of _ally_bus_launcher.
4043
4044 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
4045
4046         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
4047         https://bugs.webkit.org/show_bug.cgi?id=121218
4048
4049         Reviewed by Philippe Normand.
4050
4051         Skipping the entire suite was added to skip tests when they can't
4052         be run because of the environment, for example to skip the a11y
4053         tests when the at-spi daemons fail to start. This is no longer
4054         true for all the cases, so we can disable the tests that are
4055         impossible to run instead of skipping them.
4056
4057         * Scripts/run-gtk-tests:
4058         (TestRunner.__init__): Initialize the skipped tests list.
4059         (TestRunner._setup_testing_environment): Add
4060         TestWebKitAccessibility path to the list of disabled tests when
4061         at-spi daemon fail to start.
4062         (TestRunner._should_run_test_program): Check first if the test
4063         program is disabled and then whether it's skipped honoring the
4064         skipped command line option.
4065
4066 2013-09-12  Samuel White  <samuel_white@apple.com>
4067
4068         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
4069         https://bugs.webkit.org/show_bug.cgi?id=117651
4070
4071         Reviewed by Mario Sanchez Prada.
4072
4073         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
4074
4075         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4076         (AccessibilityUIElement::valueDescription):
4077         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
4078         (WTR::AccessibilityUIElement::valueDescription):
4079
4080 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
4081
4082         REGRESSION(r154781): accessibility/notification-listeners.html is failing
4083         https://bugs.webkit.org/show_bug.cgi?id=120669
4084
4085         Reviewed by Chris Fleizach.
4086
4087         Fixed 4 problems that were causing notification-listeners.html to fail.
4088
4089         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
4090         implemented in axObjectEventListener().
4091
4092         A notification for AXFocusedUIElementChanged was incorrectly sent when
4093         the element lost focus.
4094
4095         Global notification was not dispatched if an element notification was
4096         present in the HashMap.
4097
4098         connectAccessibilityCallbacks() was connecting signals to callbacks
4099         multiple times because it was not checking if
4100         disconnectAccessibilityCallbacks() had an early return if there were
4101         active handlers.
4102
4103         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
4104         disconnectAccessibilityCallbacks() to inform if the callbacks were
4105         successfully disconnected.
4106         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
4107         (axObjectEventListener): Implemented notifications for
4108         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
4109         notification, which was not dispatched if an element notification
4110         existed. Fixed the notification for AXFocusedUIElementChanged that was
4111         incorrectly sent when the element lost focus. In addition, fixed a typo
4112         where TRUE should be true.
4113         (connectAccessibilityCallbacks): Added early return if
4114         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
4115         (disconnectAccessibilityCallbacks): Added a return value to inform if
4116         callbacks were successfully disconnected.
4117
4118 2013-09-11  Anders Carlsson  <andersca@apple.com>
4119
4120         Try to fix GCC builds.
4121
4122         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
4123
4124 2013-09-11  Anders Carlsson  <andersca@apple.com>
4125
4126         Try to fix the build.
4127
4128         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
4129         file in the Tests/ directory in the first place.
4130
4131         * TestWebKitAPI/CMakeLists.txt:
4132         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
4133         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
4134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4135         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
4136
4137 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
4138
4139         [Windows] Build fix for MoveOnly
4140
4141         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
4142         Tests to include search path.
4143         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
4144         Ditto.
4145
4146 2013-09-11  Anders Carlsson  <andersca@apple.com>
4147
4148         Add HashSet::take
4149         https://bugs.webkit.org/show_bug.cgi?id=121192
4150
4151         Reviewed by Darin Adler.
4152
4153         Add a test for HashSet::take.
4154
4155         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4156         (TestWebKitAPI::TEST):
4157
4158 2013-09-11  Anders Carlsson  <andersca@apple.com>
4159
4160         HashSet should work with move only types
4161         https://bugs.webkit.org/show_bug.cgi?id=121188
4162
4163         Reviewed by Geoffrey Garen.
4164
4165         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4166         * TestWebKitAPI/Tests/MoveOnly.h: Added.
4167         Move the MoveOnly class from Vector out into its own header.
4168
4169         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4170         (TestWebKitAPI::TEST):
4171         Add aHashSet<MoveOnly> test.
4172
4173         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4174         Include MoveOnly.h.
4175
4176 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
4177
4178         [Windows] Avoid converting from IntSize->SIZE->IntSize
4179         https://bugs.webkit.org/show_bug.cgi?id=121180
4180
4181         Reviewed by Anders Carlsson.
4182
4183         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
4184         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
4185
4186 2013-09-11  Dan Bernstein  <mitz@apple.com>
4187
4188         REGRESSION (r155561): extract-localizable-strings can miss strings
4189         https://bugs.webkit.org/show_bug.cgi?id=121184
4190
4191         Reviewed by Darin Adler.
4192
4193         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
4194         parenthesis or bracket.
4195
4196 2013-09-11  Dan Bernstein  <mitz@apple.com>
4197
4198         update-webkit-localizable-strings is at least 5.8x slower than it should be
4199         https://bugs.webkit.org/show_bug.cgi?id=121178
4200
4201         Reviewed by Darin Adler.
4202
4203         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
4204         Note that this does not change functionality, because the script already does not understand
4205         the line continuation sequence (backslash followed by a newline).
4206
4207 2013-09-11  Anders Carlsson  <andersca@apple.com>
4208
4209         Vector::append doesn't work if element type has overloaded operator&
4210         https://bugs.webkit.org/show_bug.cgi?id=121175
4211
4212         Reviewed by Brent Fulgham.
4213
4214         Add a test case.
4215
4216         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4217         (TestWebKitAPI::TEST):
4218
4219 2013-09-11  Anders Carlsson  <andersca@apple.com>
4220
4221         Implement Vector::append for move-only types
4222         https://bugs.webkit.org/show_bug.cgi?id=120805
4223
4224         Reviewed by Sam Weinig.
4225
4226         Add a test for Vector<MoveOnly>::append.
4227
4228         * TestWebKitAPI/Tests/WTF/Vector.cpp:
4229         (TestWebKitAPI::TEST):
4230
4231 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
4232
4233         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
4234
4235         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4236         (RunAndUploadPerfTests):
4237         (RunAndUploadPerfTests.start):
4238         (RunAndUploadPerfTests.getText2):
4239
4240 2013-09-11  Anders Carlsson  <andersca@apple.com>
4241
4242         The style checker shouldn't complain about returning or passing OwnPtr
4243         https://bugs.webkit.org/show_bug.cgi?id=121163
4244
4245         Reviewed by Antti Koivisto.
4246
4247         * Scripts/webkitpy/style/checkers/cpp.py:
4248         (check_function_definition_and_pass_ptr):
4249         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4250         (PassPtrTest.test_pass_ref_ptr_return_value):
4251         (PassPtrTest.test_own_ptr_parameter_value):
4252
4253 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
4254
4255         [GTK] Remove Gail dependency from build system for GTK3
4256         https://bugs.webkit.org/show_bug.cgi?id=119673
4257
4258         Reviewed by Gustavo Noronha Silva.
4259
4260         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
4261         * Scripts/webkitpy/port/gtk.py:
4262         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
4263         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
4264
4265 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
4266
4267         Performance tester bots should report the number of failing tests
4268         https://bugs.webkit.org/show_bug.cgi?id=120462
4269
4270         Reviewed by Csaba Osztrogonác.
4271
4272         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4273         (RunAndUploadPerfTests.start.getText):
4274         (RunAndUploadPerfTests.start):
4275         (RunAndUploadPerfTests):
4276         (RunAndUploadPerfTests.start.getText2):
4277
4278 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
4279
4280         [ATK] Adds mapping MenuItemRadioRole to ATK
4281         https://bugs.webkit.org/show_bug.cgi?id=121149
4282
4283         Reviewed by Mario Sanchez Prada.
4284
4285         Adds mapping MenuItemRadioRole to ATK.
4286
4287         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4288         (roleToString):
4289         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4290         (WTR::roleToString):
4291
4292 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
4293
4294         Unreviewed fix after the unreviewed r155498 to unbreak the failure
4295         counter of run-javascriptcore-tests build step on build.webkit.org.
4296
4297         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4298         (RunJavaScriptCoreTests.commandComplete):
4299         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4300
4301 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
4302
4303         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
4304       &n