Unreviewed fix.
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2
3         Unreviewed. Adding myself to committers.py.
4
5         * Scripts/webkitpy/common/config/committers.py:
6
7 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
8
9         Reviewed by Xan Lopez.
10
11         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
12         https://bugs.webkit.org/show_bug.cgi?id=51806
13
14         Originally, the $libraryName is 'JavaScriptCore'. When building release 
15         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
16         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
17         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
18         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
19         so make it 'WebKitBuild/Release/.libs'
20
21         * Scripts/webkitdirs.pm: 
22
23 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
24
25         Reviewed by Adam Barth.
26
27         Make EFL a core builder
28         https://bugs.webkit.org/show_bug.cgi?id=51804
29
30         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
31         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
32
33 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
34
35         [Qt] Unreviewed fix after r74855 and r74875.
36
37         * BuildSlaveSupport/built-product-archive:
38          - Create directories explicitly.
39          - Pass shell=True to subprocess.call().
40
41 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
42
43         [Qt] Unreviewed fix after r74855.
44
45         Move JavaScriptCore to Source
46         https://bugs.webkit.org/show_bug.cgi?id=51604
47
48         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
49
50 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
51
52         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
53
54         Move JavaScriptCore to Source
55         https://bugs.webkit.org/show_bug.cgi?id=51604
56
57         * Scripts/webkitdirs.pm:
58
59 2011-01-02  Robert Hogan  <robert@webkit.org>
60
61         Unreviewed, build fix.
62
63         [Qt] Fix DRT build after 74855
64
65         * DumpRenderTree/qt/DumpRenderTree.pro:
66
67 2011-01-01  Adam Barth  <abarth@webkit.org>
68
69         Remove the assumption from the Qt and Gtk builds that every project is
70         in the root directory.
71
72         * Scripts/build-webkit:
73
74 2011-01-01  Adam Barth  <abarth@webkit.org>
75
76         Reviewed by Eric Seidel.
77
78         Teach svn-apply how to apply patches even though JavaScriptCore has moved
79         https://bugs.webkit.org/show_bug.cgi?id=51796
80
81         After this change, svn-apply will magically apply patches to
82         JavaScriptCore/foo to Source/JavaScriptCore/foo.
83
84         * Scripts/VCSUtils.pm:
85
86 2011-01-01  Adam Barth  <abarth@webkit.org>
87
88         Reviewed by Eric Seidel.
89
90         Move JavaScriptCore to Source
91         https://bugs.webkit.org/show_bug.cgi?id=51604
92
93         Update references to JavaScriptCore to point to the new location.
94
95         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
96         * DumpRenderTree/qt/DumpRenderTree.pro:
97         * DumpRenderTree/qt/ImageDiff.pro:
98         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
99         * DumpRenderTree/wscript:
100         * Scripts/build-jsc:
101         * Scripts/build-webkit:
102         * Scripts/do-file-rename:
103         * Scripts/do-webcore-rename:
104         * Scripts/run-javascriptcore-tests:
105         * Scripts/update-javascriptcore-test-results:
106         * Scripts/webkitdirs.pm:
107         * Scripts/webkitpy/common/config/build_unittest.py:
108         * Scripts/webkitpy/style/checker.py:
109         * Scripts/webkitpy/style/checker_unittest.py:
110         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
111         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
112         * WebKitTestRunner/qt/WebKitTestRunner.pro:
113         * wx/build/settings.py:
114
115 2011-01-01  Adam Barth  <abarth@webkit.org>
116
117         Reviewed by Eric Seidel.
118
119         Move Sources to Source
120         https://bugs.webkit.org/show_bug.cgi?id=51794
121
122         Update scripts to point to the new location.
123
124         * Scripts/build-webkit:
125         * Scripts/do-file-rename:
126         * Scripts/do-webcore-rename:
127         * Scripts/webkitpy/common/config/build.py:
128         * Scripts/webkitpy/common/config/build_unittest.py:
129
130 2010-12-31  Kent Tamura  <tkent@chromium.org>
131
132         Reviewed by Eric Seidel.
133
134         [DRT/Chromium] Enable mock spell checker on non-OSX
135         https://bugs.webkit.org/show_bug.cgi?id=51401
136
137         * DumpRenderTree/chromium/WebViewHost.cpp:
138         (WebViewHost::spellCheck):
139
140 2010-12-31  Adam Barth  <abarth@webkit.org>
141
142         Reviewed by Ariya Hidayat.
143
144         Remove Tools/Scripts/wkstyle
145         https://bugs.webkit.org/show_bug.cgi?id=51774
146
147         This script appears to not have been touched in a while and seems to
148         have been replaced by check-webkit-style.
149
150         * Scripts/wkstyle: Removed.
151
152 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
153
154         Unreviewed. Coding style fix.
155
156         * DumpRenderTree/chromium/TestShell.h:
157
158 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
159
160         Reviewed by Pavel Feldman.
161
162         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
163
164         It was a problem with Chromium DRT. DevToolsAgent object instance was
165         attached not only to the inspected page but to the DevTools window too.
166         As result all the inspector files were interpreted as a content of inspected page
167         and were transfered to the DevTools scripts panel for debugging etc.
168
169         https://bugs.webkit.org/show_bug.cgi?id=51735
170
171         * DumpRenderTree/chromium/TestShell.cpp:
172         (TestShell::TestShell):
173         (TestShell::bindJSObjectsToWindow):
174         (TestShell::createNewWindow):
175         * DumpRenderTree/chromium/TestShell.h:
176
177 2010-12-31  Adam Barth  <abarth@webkit.org>
178
179         Rubber-stamped by Eric Seidel.
180
181         Move PageLoadTests to PerformanceTests/PageLoad
182         https://bugs.webkit.org/show_bug.cgi?id=51771
183
184         Update references to PageLoadTests to point to the new location.
185
186         * Scripts/run-pageloadtest:
187         * Scripts/webkitpy/common/config/build.py:
188
189 2010-12-31  Adam Barth  <abarth@webkit.org>
190
191         Rubber-stamped by Eric Seidel.
192
193         Move SunSpider into PerformanceTests
194         https://bugs.webkit.org/show_bug.cgi?id=51769
195
196         Update these scripts to point to the new location.
197
198         * Scripts/run-sunspider:
199         * Scripts/sunspider-compare-results:
200
201 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
202
203         Reviewed by Kent Tamura.
204
205         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
206         https://bugs.webkit.org/show_bug.cgi?id=51728
207         
208         Add implementation of the Mac WebThemeEngine that uses an NSScroller
209         to render top-level scrollbars. This makes them match the Mac port's
210         use of an NSScrollView, which means that we'll be able to share more
211         pixel baselines.
212         
213         The new rendering code will not be activated until the 
214         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
215         ScrollbarThemeChromiumMac.
216
217         * DumpRenderTree/DumpRenderTree.gypi:
218         * DumpRenderTree/chromium/TestShellMac.mm:
219         (platformInit):
220         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
221         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
222         (+[FakeActiveWindow alwaysActiveWindow]):
223         (+[FakeActiveWindow alwaysInactiveWindow]):
224         (-[FakeActiveWindow initWithActiveControls:]):
225         (-[FakeActiveWindow _hasActiveControls]):
226         (WebThemeEngineDRTMac::paintScrollbarThumb):
227         (stateToHIEnableState):
228         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
229         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
230
231 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
232
233         Reviewed by David Kilzer.
234
235         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
236         used
237         https://bugs.webkit.org/show_bug.cgi?id=51672
238
239         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
240         with USE_SYSTEM_MALLOC=1
241         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
242         with USE_SYSTEM_MALLOC=1
243
244 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
245
246         Reviewed by David Kilzer.
247
248         [Qt] [Symbian] Fix build-webkit script for Symbian
249         https://bugs.webkit.org/show_bug.cgi?id=51509
250
251         Set the OUTPUT_DIR for Symbian to be the same as the source
252         directory.
253
254         * Scripts/webkitdirs.pm:
255
256 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
257
258         Reviewed by Darin Adler.
259
260         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
261         https://bugs.webkit.org/show_bug.cgi?id=51758
262
263         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
264
265         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
266         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
267
268 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
269
270         Unreviewed WinCE buildfix.
271
272         * WinCELauncher/main.cpp: Add missing include.
273
274 2010-12-29  Daniel Bates  <dbates@rim.com>
275
276         Reviewed by Darin Adler.
277
278         svn-apply updates date of wrong change log entry for a change log diff that
279         contains two consecutive entries with the same author and date
280         https://bugs.webkit.org/show_bug.cgi?id=46061
281
282         Fixes an issue where the date of the wrong change log entry may be modified.
283         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
284         in a ChangeLog file to the top of the file.
285
286         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
287         diff when it detects that the diff inserts a change log entry earlier in a
288         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
289         change. With the advent of the commit-queue this functionality of bailing out
290         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
291         Instead, we should always move the change log entry to the top of the ChangeLog file.
292
293         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
294         the date line of the correct change log entry in a ChangeLog diff.
295
296         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
297
298         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
299           Updated the following unit tests now that we move entries inserted earlier to the top:
300           - "fixChangeLogPatch: New entry inserted in middle."
301             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
302
303           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
304             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
305
306         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
307
308 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
309
310         Reviewed by Eric Seidel.
311
312         [Qt] Fixed compatibility with gold linker on X11 platforms
313         https://bugs.webkit.org/show_bug.cgi?id=51700
314
315         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
316         Linked TestNetscapePlugin with libX11 on Unix platforms
317
318 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
319
320         Reviewed by Darin Adler.
321
322         Circular dependency in webkitpy.common.checkout.changelog module
323         https://bugs.webkit.org/show_bug.cgi?id=50475
324
325         Remove automatic import of api.Checkout module when any checkout/
326         submodule is imported (e.g.: when checkout.scm.Git is imported).
327
328         * Scripts/webkitpy/common/checkout/__init__.py:
329
330 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
331
332         Reviewed by Ojan Vafai.
333
334         prepare-ChangeLog should support the -g option for specifying the git-commit
335         https://bugs.webkit.org/show_bug.cgi?id=51708
336
337         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
338         webkit-patch, though the exact meaning of the two options remain different.
339
340         * Scripts/prepare-ChangeLog: Add -g.
341
342 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
343
344         Reviewed by Simon Hausmann.
345
346         [Qt] Fix compilation with Qt in namespace
347         https://bugs.webkit.org/show_bug.cgi?id=51701
348
349         * QtTestBrowser/webview.h:
350
351 2010-12-28  Daniel Bates  <dbates@rim.com>
352
353         Reviewed by Sam Weinig.
354
355         Substitute // MARK: for compiler-specific #pragma mark
356         https://bugs.webkit.org/show_bug.cgi?id=51657
357
358         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
359         substituting  "// MARK:" for "#pragma mark", which provides
360         analogous code-bookmarking functionality under Xcode.
361
362         Also, for consistency, we should substitute "// MARK:" for compiler-
363         specific "#pragma mark" in the source files for the Mac port.
364
365         * DumpRenderTree/AccessibilityTextMarker.cpp:
366         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
367         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
368         * DumpRenderTree/mac/ObjCController.m:
369         * MiniBrowser/mac/AppDelegate.m:
370         * MiniBrowser/mac/BrowserWindowController.m:
371
372 2010-12-28  Xan Lopez  <xlopez@igalia.com>
373
374         Reviewed by Eric Seidel.
375
376         Add --no-build option to run-sunspider
377         https://bugs.webkit.org/show_bug.cgi?id=51658
378
379         * Scripts/run-sunspider: add --no-build flag to skip building
380         phase.
381
382 2010-12-27  Daniel Bates  <dbates@rim.com>
383
384         Rubber-stamped by Martin Robinson.
385
386         Append the directory Tools/DumpRenderTree to the list of directories that
387         do-webcore-rename should search so that it can rename DRT files and
388         source code.
389
390         * Scripts/do-webcore-rename:
391
392 2010-12-27  Eric Seidel  <eric@webkit.org>
393
394         Reviewed by Adam Barth.
395
396         build-webkit should detect missing Java SDK and explain how to install it
397         https://bugs.webkit.org/show_bug.cgi?id=51651
398
399         * Scripts/build-webkit:
400
401 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
402
403         Reviewed by Daniel Bates.
404
405         [GTK] Add support for build-jsc
406         https://bugs.webkit.org/show_bug.cgi?id=51625
407
408         Add GTK+ support to build-jsc now that building the jsc executable as
409         a standalone target is easy.
410
411         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
412         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
413         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
414         and pass it along to buildAutotoolsProject.
415
416 2010-12-27  David Levin  <levin@chromium.org>
417
418         Reviewed by Eric Seidel.
419
420         check-webkit-style check for meaningless variable names in function declarations.
421         https://bugs.webkit.org/show_bug.cgi?id=51523
422
423         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
424         from the new check and whitespace/parens because the syntax is unusual and
425         produced a fair number of positives for these checks.
426         * Scripts/webkitpy/style/checkers/cpp.py:
427         (_convert_to_lower_with_underscores): Used as a canonical form for type names
428         and parameter names when determining if the parameter name is useless.
429         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
430         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
431         format.
432         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
433         text or an acronym of it.
434         (check_function_definition): Checks function definitions for meaningless variable names.
435         (process_line): Added call to check_function_definition.
436         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
437         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
438         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
439         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
440         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
441         because when only checking a snippet, there are a lot of bogus functions.
442         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
443         that I put there previously and just noticed.
444         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
445         check_function_definition and process_line.
446
447 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
448
449         Reviewed by Martin Robinson.
450
451         [GTK] Disable flash plugin in GtkLauncher when using gtk3
452         https://bugs.webkit.org/show_bug.cgi?id=51591
453
454         Flash plugin uses gtk2 that is incompatible with gtk3 making
455         webkit crash when it's built with gtk3.
456
457         * GtkLauncher/main.c:
458         (main):
459
460 2010-12-25  Adam Barth  <abarth@webkit.org>
461
462         Reviewed by Eric Seidel.
463
464         Move ANGLE to Sources/ThirdParty
465         https://bugs.webkit.org/show_bug.cgi?id=51605
466
467         * Scripts/build-webkit:
468           - Point to the new ANGLE location.
469
470 2010-12-26  David Levin  <levin@chromium.org>
471
472         Reviewed by Eric Seidel.
473
474         check-webkit-style should be able to parse function declaration parameters.
475         https://bugs.webkit.org/show_bug.cgi?id=51451
476
477         * Scripts/webkitpy/style/checkers/cpp.py:
478         (Position.__init__): Holds simple position information (row, column).
479         (Parameter.__init__): Holds information about a parameter.
480         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
481         (SingleLineView.convert_column_to_row): Returns the original row given a column.
482         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
483         (find_parameter_name_index): Finds where the parameter name is.
484         (parameter_list): Generates the list of parameters for a function.
485         (_FunctionState.begin): Added information to allow determining the parameters
486         on demand.
487         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
488         (detect_functions): Improve function detection for operator functions and
489         determine where the parameters end and pass that to _FunctionState.begin.
490         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
491         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
492         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
493         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
494         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
495         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
496         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
497         (FunctionDetectionTest.perform_function_detection): Added support for verifying
498         the parameters found.
499         (FunctionDetectionTest.test_function_declaration_detection): Added more function
500         detection test to verify that we catch the operator functions.
501         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
502         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
503         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
504         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
505         test_function_length_check_definition_severity1_for_test.
506
507 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
508
509         Unreviewed WinCE buildfix after r74334.
510
511         * CMakeListsWinCE.txt:
512
513 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
514
515         Unreviewed, rolling out r74632.
516         http://trac.webkit.org/changeset/74632
517         https://bugs.webkit.org/show_bug.cgi?id=51600
518
519         makes test-webkitpy hang forever on GTK (Requested by philn-tp
520         on #webkit).
521
522         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
523         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
524
525 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
526
527         Reviewed by Kenneth Rohde Christiansen.
528
529         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
530         https://bugs.webkit.org/show_bug.cgi?id=43528
531
532         Remove on_resize because ewk_view_fixed_layout_size_set should not be
533         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
534         FrameView, rendering was ignored when _ewk_view_smart_calculate was
535         called.
536
537         * EWebLauncher/main.c:
538         (browserCreate):
539
540 2010-12-24  Eric Seidel  <eric@webkit.org>
541
542         Reviewed by Adam Barth.
543
544         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
545         https://bugs.webkit.org/show_bug.cgi?id=28291
546
547         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
548         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
549         to strings with find in the diff.
550         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
551
552         * Scripts/webkitpy/common/checkout/api.py:
553         * Scripts/webkitpy/common/checkout/diff_parser.py:
554         * Scripts/webkitpy/tool/steps/abstractstep.py:
555         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
556         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
557         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
558         * Scripts/webkitpy/tool/steps/validatereviewer.py:
559
560 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
561
562         Reviewed by Kenneth Russell.
563
564         Modify new-run-webkit-tests to shut up and exit when all the threads
565         are wedged so that test runs complete faster and we don't end up
566         w/ enormous log files.
567
568         https://bugs.webkit.org/show_bug.cgi?id=51572
569
570         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
571         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
572
573 2010-12-24  Eric Seidel  <eric@webkit.org>
574
575         Reviewed by David Levin.
576
577         commit-queue should better explain how it will re-open bugs and follow duplicate chains
578         https://bugs.webkit.org/show_bug.cgi?id=51549
579
580         I've had multiple people ask me about the commit-queue's behavior
581         regarding reporting flaky tests.  I figured it would be best to just
582         have the queue explain itself in the bugs it files.
583
584         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
585         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
586
587 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
588
589         Reviewed by Eric Seidel.
590
591         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
592         https://bugs.webkit.org/show_bug.cgi?id=51467
593
594         * Scripts/webkitpy/style/checker.py:
595         * Scripts/webkitpy/style/checker_unittest.py:
596
597 2010-12-23  Adam Barth  <abarth@webkit.org>
598
599         Rubber-stamped by Eric Seidel.
600
601         Move JavaScriptGlue into Sources
602         https://bugs.webkit.org/show_bug.cgi?id=51583
603
604         These tools refer to JavaScriptGlue and need to be updated to its new
605         location.
606
607         * Scripts/build-webkit:
608         * Scripts/do-file-rename:
609         * Scripts/do-webcore-rename:
610         * Scripts/webkitpy/common/config/build.py:
611         * Scripts/webkitpy/common/config/build_unittest.py:
612
613 2010-12-23  Lucas Forschler  <lforschler@apple.com>
614
615         Reviewed by Eric Seidel.
616
617         Bug 51539 - update iexploder scripts to point to new location
618
619         * Scripts/run-iexploder-tests:
620         * Scripts/update-iexploder-cssproperties:
621
622 2010-12-23  Evan Martin  <evan@chromium.org>
623
624         Reviewed by Ryosuke Niwa.
625
626         [chromium] LayoutTestController warning in float->int conversion
627         https://bugs.webkit.org/show_bug.cgi?id=51553
628
629         Rather than reading an int, converting to a float, then getting a compiler
630         warning on passing the float to something that expects an int, instead
631         just pass around ints.
632
633         No tests, fixes a compiler warning.
634
635         * DumpRenderTree/chromium/LayoutTestController.cpp:
636         (parsePageSizeParameters):
637         (LayoutTestController::pageNumberForElementById):
638         (LayoutTestController::numberOfPages):
639
640 2010-12-23  Lucas Forschler  <lforschler@apple.com>
641
642         Reviewed by Darin Adler.
643
644         Bug 51537 - iexploder needs cleanup
645         
646         * iExploder/htdocs: Removed.
647         * iExploder/htdocs/config.rb: Removed.
648         * iExploder/htdocs/cssproperties.in: Removed.
649         * iExploder/htdocs/cssvalues.in: Removed.
650         * iExploder/htdocs/htmlattrs.in: Removed.
651         * iExploder/htdocs/htmltags.in: Removed.
652         * iExploder/htdocs/htmlvalues.in: Removed.
653         * iExploder/htdocs/iexploder.cgi: Removed.
654         * iExploder/htdocs/iexploder.rb: Removed.
655         * iExploder/htdocs/index.html: Removed.
656         * iExploder/htdocs/webserver.rb: Removed.
657         * iExploder/iexploder-1.7.2/output: Removed.
658         * iExploder/tools: Removed.
659         * iExploder/tools/lasthit.rb: Removed.
660         * iExploder/tools/osx_last_crash.rb: Removed.
661         * iExploder/tools/showtest.rb: Removed.
662
663 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
664
665         Reviewed by Kenneth Rohde Christiansen.
666
667         [EFL] Make 'single' the default backing store in EWebLauncher
668         https://bugs.webkit.org/show_bug.cgi?id=51534
669
670         'single' is the simplest backing store and the one intended to be the
671         default in the test browser. By mistake the tiled backing store was
672         left as default in r72617.
673
674         * EWebLauncher/main.c:
675         (browserCreate): ditto.
676
677 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
678
679         Reviewed by Kenneth Rohde Christiansen.
680
681         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
682         https://bugs.webkit.org/show_bug.cgi?id=51533
683
684         There's no point in concatenating env("HOME") with "blah", so remove
685         option from EWebLauncher.
686
687         * EWebLauncher/main.c:
688         (main): ditto.
689
690 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
691
692         Reviewed by Eric Seidel.
693
694         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
695
696         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
697         I just discovered that we have two additional GC runs per each WebViewHost.
698         Test_shell had no such calls.
699         These gc runs eat 15% of cpu time.
700
701         https://bugs.webkit.org/show_bug.cgi?id=51479
702
703         * DumpRenderTree/chromium/WebViewHost.cpp:
704         (WebViewHost::~WebViewHost):
705
706 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
707
708         Reviewed by Ojan Vafai.
709
710         This change splits out the TestRunner class into its own file.
711         When we fork the code for message passing, we will create a new
712         TestRunner, and this change will allow that to be more modular.
713
714         While we're at it, split out TestInput and ResultSummary into
715         their own files, to reduce the size of run_webkit_tests to
716         something more managable.
717
718         https://bugs.webkit.org/show_bug.cgi?id=51092
719
720         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
721         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
722         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
723         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
724         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
726         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
727
728  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
729
730         Reviewed by Ojan Vafai.
731
732         nrwt multiprocessing - start over, prepare to fork the code
733  
734         This code cleans up the signatures and implementation of the
735         TestRunner class so we can easily fork it to run either the
736         stable implementation or the new, unstable message-passing
737         implementation. The two variants will have different
738         implementations of the run_tests() method. We will switch
739         between the two based on the setting for the '--worker-model'
740         switch. We rename the two currently valid values to 'old-inline'
741         and 'old-threads'.
742
743         https://bugs.webkit.org/show_bug.cgi?id=51081
744
745         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
746         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
747
748 2010-12-22  Victor Wang  <victorw@chromium.org>
749
750         Reviewed by Darin Fisher.
751
752         [Chromium] Update chromium archive test result url in rebaseline script.
753
754         https://bugs.webkit.org/show_bug.cgi?id=51503
755
756         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
757
758 2010-12-22  Lucas Forschler  <lforschler@apple.com>
759
760         Reviewed by Alice Liu.
761
762         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
763         Verified on Chrome, Safari, and IE.
764         With this change, we will record memory from a parent browser window and all child processes.
765
766         * record-memory-win/main.cpp:
767         (ProcessArgs):
768         (PrintUsage):
769         (getMemoryInfo):
770         (printProcessInfo):
771         (evalProcesses):
772         (UseImage):
773         (QueryContinuously):
774         (ElapsedTime):
775
776 2010-12-22  Lucas Forschler  <lforschler@apple.com>
777
778         Unreviewed rollout r74489, because it was missing changelog.
779
780         * record-memory-win/main.cpp:
781         
782 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
783
784         Adding myself as a reviewer.
785
786         * Scripts/webkitpy/common/config/committers.py:
787
788 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
789
790         Unreviewed.  Adding myself to committers.py.
791
792         * Scripts/webkitpy/common/config/committers.py:
793
794 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
795
796         Reviewed by Kenneth Rohde Christiansen.
797
798         TestNetscapePlugIn should use #if defined
799         https://bugs.webkit.org/show_bug.cgi?id=51471
800
801         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
802         (NP_Initialize):
803         (NPP_New):
804
805 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
806
807         Reviewed by Yury Semikhatsky.
808
809         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
810
811         DevTools window should be closed explicitly because it has custom deinitialization code.
812
813         https://bugs.webkit.org/show_bug.cgi?id=50722
814
815         * DumpRenderTree/chromium/TestShell.cpp:
816         (TestShell::closeRemainingWindows):
817
818 2010-12-22  David Levin  <levin@chromium.org>
819
820         Reviewed by Shinichiro Hamaji.
821
822         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
823         https://bugs.webkit.org/show_bug.cgi?id=51452
824
825         * Scripts/webkitpy/style/checkers/cpp.py:
826         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
827         Using the file extension if possible but falling back to the file contents if we have a header file.
828         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
829         (_FileState.is_c_or_objective_c):
830         (check_using_std): Changed to using _FileState to determine the file type.
831         (check_max_min_macros): Ditto.
832         (check_for_null): Ditto.
833         (check_style): Changed the parameters to various calls since they now need _FileState
834         to determine the file type.
835         (check_language): Added the file_state parameter so it could be passed
836         to check_identifier_name_in_declaration.
837         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
838         this is an Objective C file.
839         (_process_lines): Added information for the _FileState constructor (and moved the
840         call to a place that had the information).
841         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
842         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
843         its functionality.
844         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
845
846 2010-12-21  Andy Estes  <aestes@apple.com>
847
848         Reviewed by Mark Rowe.
849
850         Do not build non-Intel architectures for WebKit2-related projects.
851         https://bugs.webkit.org/show_bug.cgi?id=51440
852
853         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
854         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
855         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
856
857 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
858
859         Reviewed by Darin Fisher.
860
861         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
862         https://bugs.webkit.org/show_bug.cgi?id=51406 
863         
864         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
865         to WebThemeEngineDRTWin and update references everywhere.
866
867         * DumpRenderTree/DumpRenderTree.gypi:
868         * DumpRenderTree/chromium/TestShellWin.cpp:
869         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
870         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
871         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
872         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
873
874 2010-12-21  Anders Carlsson  <andersca@apple.com>
875
876         Reviewed by John Sullivan.
877
878         Clicking missing plug-in text does not show a sheet
879         https://bugs.webkit.org/show_bug.cgi?id=51403
880
881         Update for changes to the WebPageUIClient.
882
883         * MiniBrowser/mac/BrowserWindowController.m:
884         (-[BrowserWindowController awakeFromNib]):
885         * WebKitTestRunner/TestController.cpp:
886         (WTR::createOtherPage):
887         (WTR::TestController::initialize):
888
889 2010-12-21  Eric Seidel  <eric@webkit.org>
890
891         Reviewed by Adam Barth.
892
893         commit-queue will report constant failures as flaky if other tests flake
894         https://bugs.webkit.org/show_bug.cgi?id=51272
895
896         This patch just removes functionality and adds testing.
897         Previously we attempted to report flaky tests when we had
898         two different tests fail in a row.  However, since we stop
899         running the tests at the first failure, our code was wrong in
900         trying to determine flakiness from the incomplete runs.
901
902         Originally I posted an alternate patch:
903         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
904         which fixed our flaky logic in this case, however it was decided
905         that that patch would be too difficult to maintain, so now
906         I'm just removing the broken logic.
907
908         This will dramatically cut-down on our flaky-test false positives
909         at the (small) cost of the queues being unable to report
910         any flakiness if the tree is very flaky.  (With at least one test
911         flaking on every run, we'll never report failures anymore.)  I think
912         this is a tradeoff worth making.
913
914         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
915         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
916
917 2010-12-20  Eric Seidel  <eric@webkit.org>
918
919         Reviewed by Adam Barth.
920
921         commit-queue wrongly rejects patches when it can't update itself
922         https://bugs.webkit.org/show_bug.cgi?id=46636
923
924         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
925         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
926         * Scripts/webkitpy/tool/commands/queues_unittest.py:
927
928 2010-12-20  Adam Barth  <abarth@webkit.org>
929
930         Move web sites to Websites directory
931         https://bugs.webkit.org/show_bug.cgi?id=51323
932
933         Update references to BugsSite to point to the new location.
934
935         This patch was never officially reviewed (because it was too large to
936         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
937         Rowe gave me the green light.
938
939         * Scripts/old-run-webkit-tests:
940         * Scripts/webkitpy/common/config/build.py:
941         * Scripts/webkitpy/common/config/build_unittest.py:
942         * Scripts/webkitpy/common/prettypatch.py:
943         * Scripts/webkitpy/layout_tests/port/base.py:
944         * Scripts/webkitpy/style/main.py:
945
946 2010-12-20  Adrienne Walker  <enne@google.com>
947
948         Unreviewed. Adding myself to the list of committers.
949
950         * webkitpy/common/config/committers.py:
951
952 2010-12-20  Mark Rowe  <mrowe@apple.com>
953
954         Reviewed by Dan Bernstein.
955
956         <rdar://problem/8757601> Don't install header files in to the Resources directory.
957
958         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
959         Resources directory.
960
961 2010-12-20  Eric Seidel  <eric@webkit.org>
962
963         Reviewed by Adam Barth.
964
965         commit-queue should include bot id when attaching failure diffs
966         https://bugs.webkit.org/show_bug.cgi?id=51280
967
968         This is a tiny change to include the bot id in the name of the attachment.
969         Most of this diff is just changing the unit test expectations
970         now that I hid the comment printing when the comment is None.
971
972         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
973         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
974         * Scripts/webkitpy/tool/commands/upload_unittest.py:
975         * Scripts/webkitpy/tool/mocktool.py:
976
977 2010-12-20  Jeff Miller  <jeffm@apple.com>
978
979         Reviewed by Dan Bernstein.
980
981         Tools/vcbin/midl.exe needs to be rebuilt
982         https://bugs.webkit.org/show_bug.cgi?id=51347
983
984         * vcbin/midl.exe: Rebuilt.
985
986 2010-12-20  David Levin  <levin@chromium.org>
987
988         Reviewed by Ariya Hidayat.
989
990         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
991         https://bugs.webkit.org/show_bug.cgi?id=51343
992
993         Follow up from the WebKitTools -> Tools rename.
994
995         * Scripts/webkit-tools-completion.sh:
996
997 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
998
999         Reviewed by James Robinson.
1000
1001         new-run-webkit-tests ignores trailing EOL differences in text tests
1002         https://bugs.webkit.org/show_bug.cgi?id=36983
1003
1004         Changed the handling of new-line characters within new-run-webkit-tests
1005         to match old-run-webkit-tests.  Differences in leading and trailing empty
1006         lines in text expectation files are no longer ignored.
1007
1008         * Scripts/webkitpy/layout_tests/port/base.py:
1009         * Scripts/webkitpy/layout_tests/port/test.py:
1010         Added unit tests.  Removed old duplicate unit test entries.
1011         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1012
1013 2010-12-20  David Levin  <levin@chromium.org>
1014
1015         Reviewed by Shinichiro Hamaji.
1016
1017         check-webkit-style should detect function declarations (and trivial functions).
1018         https://bugs.webkit.org/show_bug.cgi?id=51303
1019
1020         * Scripts/webkitpy/style/checkers/cpp.py:
1021         (_FunctionState.begin): Add is_declaration and changed the line count
1022         start to begin at -1 (which will keep the results consistent, since
1023         the starting line number passed in is one less in this change).
1024         (detect_functions): changed function detection to now catch trivial
1025         functions and declarations.
1026         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
1027         of the function as this may look at return values (when processing
1028         a declaration).
1029         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1030         (FunctionDetectionTest.perform_function_detection): Basic mechanics
1031         of testing the function detection.
1032         (FunctionDetectionTest.test_basic_function_detection): Test a simple
1033         function.
1034         (FunctionDetectionTest.test_function_declaration_detection): Test a
1035         declaration.
1036         (FunctionDetectionTest.test_non_functions): A test case for a case
1037         that caused the code to fail due to the { being in quotes.
1038         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
1039         cases to help catch false alarms for return values.
1040         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
1041         we don't get false alarms for member variables either.
1042
1043 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
1044
1045         Reviewed by Antonio Gomes.
1046
1047         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
1048         https://bugs.webkit.org/show_bug.cgi?id=51319
1049
1050         * CMakeListsEfl.txt:
1051
1052 2010-12-18  Adam Barth  <abarth@webkit.org>
1053
1054         Reviewed by Sam Weinig.
1055
1056         Move WebKitExamplePlugins to Examples
1057         https://bugs.webkit.org/show_bug.cgi?id=51291
1058
1059         * Scripts/webkitpy/common/config/build.py:
1060
1061 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
1062
1063         Unreviewed Qt buildfix after r74301.
1064
1065         Rename WebKitTools to Tools
1066         https://bugs.webkit.org/show_bug.cgi?id=49861
1067
1068         * MiniBrowser/DerivedSources.pro:
1069         * MiniBrowser/qt/MiniBrowser.pro:
1070
1071 2010-12-17  Dan Bernstein  <mitz@apple.com>
1072
1073         Reviewed by Simon Fraser.
1074
1075         Rename WebKitTools to Tools
1076         https://bugs.webkit.org/show_bug.cgi?id=49861
1077
1078         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1079         * CodeCoverage/README:
1080         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1081         (WebCore::DumpRenderTree::initializeFonts):
1082         * EWSTools/start-commit-queue.sh:
1083         * EWSTools/start-queue.sh:
1084         * GNUmakefile.am:
1085         * MIDLWrapper/MIDLWrapper.cpp:
1086         (wmain):
1087         * MiniBrowser/qt/MiniBrowser.pro:
1088         * Scripts/build-api-tests:
1089         * Scripts/build-dumprendertree:
1090         * Scripts/build-webkit:
1091         * Scripts/build-webkittestrunner:
1092         * Scripts/generate-coverage-data:
1093         * Scripts/old-run-webkit-tests:
1094         * Scripts/run-api-tests:
1095         * Scripts/run-iexploder-tests:
1096         * Scripts/run-javascriptcore-tests:
1097         * Scripts/run-mangleme-tests:
1098         * Scripts/run-sunspider:
1099         * Scripts/run-webkit-websocketserver:
1100         * Scripts/sunspider-compare-results:
1101         * Scripts/test-webkitperl:
1102         * Scripts/test-webkitpy:
1103         * Scripts/update-iexploder-cssproperties:
1104         * Scripts/update-webkit:
1105         * Scripts/update-webkit-localizable-strings:
1106         * Scripts/webkitdirs.pm:
1107         * Scripts/webkitpy/common/checkout/scm.py:
1108         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1109         * Scripts/webkitpy/common/config/committervalidator.py:
1110         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1111         * Scripts/webkitpy/common/config/ports.py:
1112         * Scripts/webkitpy/common/config/ports_unittest.py:
1113         * Scripts/webkitpy/common/system/logutils_unittest.py:
1114         * Scripts/webkitpy/common/system/ospath_unittest.py:
1115         * Scripts/webkitpy/layout_tests/port/chromium.py:
1116         * Scripts/webkitpy/layout_tests/port/config.py:
1117         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
1118         * Scripts/webkitpy/layout_tests/port/http_server.py:
1119         * Scripts/webkitpy/layout_tests/port/test.py:
1120         * Scripts/webkitpy/style/checker.py:
1121         * Scripts/webkitpy/style/checker_unittest.py:
1122         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1123         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1124         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1125         * WebKitTestRunner/DerivedSources.pro:
1126         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1127         (WTR::activateFonts):
1128         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1129         * wx/build/build_utils.py:
1130
1131 2010-12-16  Antonio Gomes  <agomes@rim.com>
1132
1133         Reviewed by Martin Robinson.
1134
1135         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
1136         https://bugs.webkit.org/show_bug.cgi?id=51163
1137
1138         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
1139         GTK+'s DRT should also reset to UNIX after each test execution.
1140
1141         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1142         (resetDefaultsToConsistentValues):
1143
1144 2010-12-17  David Levin  <levin@chromium.org>
1145
1146         Reviewed by Eric Seidel.
1147
1148         check-webkit-style should understand WTF #include guards
1149         https://bugs.webkit.org/show_bug.cgi?id=44911
1150
1151         * Scripts/webkitpy/style/checkers/cpp.py:
1152         (get_header_guard_cpp_variable): modify to suggest the WTF style
1153         of header guard when appropriate.
1154         (check_for_header_guard): handle multiple return values from
1155         get_header_guard_cpp_variable
1156         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1157         (CppStyleTest.test_build_header_guard): Added tests for the WTF
1158         header style.
1159
1160 2010-12-16  David Levin  <levin@chromium.org>
1161
1162         Reviewed by Eric Seidel.
1163
1164         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
1165         https://bugs.webkit.org/show_bug.cgi?id=51210
1166
1167         The error only shows up when using python 2.6 or later.
1168
1169         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
1170         the decprecated field error,message with something equivalent.
1171
1172 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
1173
1174         Reviewed by Eric Seidel.
1175
1176         Add --exit-after-n-failures/crashes to NRWT
1177         https://bugs.webkit.org/show_bug.cgi?id=51160
1178         
1179         Abort test run (in a similar way to how control-C is handled) when
1180         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
1181         that number of unexpected failures/crashes/timeouts.
1182
1183         * Scripts/webkitpy/layout_tests/port/test.py:
1184         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1185         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1186
1187 2010-12-16  David Levin  <levin@chromium.org>
1188
1189         Reviewed by Shinichiro Hamaji.
1190
1191         check-webkit-style unit tests has some duplicate boilerplate code.
1192         https://bugs.webkit.org/show_bug.cgi?id=49519
1193
1194         * Scripts/webkitpy/style/checkers/cpp.py:
1195         (update_include_state): Replaced the "io" parameter with the global
1196         configuration _unit_test_config. This allowed not calling into
1197         functions at a low level and also not plumbing through the injection
1198         information through many levels of code.
1199         (check_for_include_what_you_use): Ditto.
1200         (process_file_data): Added the ability to set up the unit test config
1201         to allow for injection.
1202         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1203         (ErrorCollector.__init__): Added support for having a filter for errors.
1204         (ErrorCollector.__call__): Ditto.
1205         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
1206         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
1207         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
1208         functions in the cpp.py with generic processing and a filter that
1209         indicates what errors should be kept.
1210         (CppStyleTestBase.perform_multi_line_lint): Ditto.
1211         (CppStyleTestBase.perform_language_rules_check): Ditto.
1212         (CppStyleTestBase.perform_function_lengths_check): Ditto.
1213         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
1214         (CppStyleTestBase.perform_include_what_you_use): Ditto.
1215         (CppStyleTest.test_multi_line_comments): Added another
1216         error message which applies to the test case.
1217         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
1218         to not have config.h, since it is processed as a header file.
1219         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
1220         style and indentation in checked code.
1221         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
1222         Fixed line number.
1223         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
1224         Ditto.
1225
1226 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1227
1228         Unreviewed, rolling out r74136.
1229         http://trac.webkit.org/changeset/74136
1230         https://bugs.webkit.org/show_bug.cgi?id=51135
1231
1232         r74136 breaks chromium canary bots because some tests are not
1233         rebaselined correctly to resolve EOL differences (Requested by
1234         jianli on #webkit).
1235
1236         * Scripts/webkitpy/layout_tests/port/base.py:
1237         * Scripts/webkitpy/layout_tests/port/test.py:
1238         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1239
1240 2010-12-15  Adam Roben  <aroben@apple.com>
1241
1242         Teach check-webkit-style to check .vcproj and .vsprops files for XML
1243         syntax errors
1244
1245         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
1246         XML syntax errors in .vcproj/.vsprops files
1247
1248         Reviewed by Dave Levin.
1249
1250         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
1251         that should be treated as XML and that should be allowed to contain
1252         carriage returns. (These lists happen to be identical currently.)
1253         (FileType): Added a new XML type.
1254         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
1255         Just does a simple file extension check.
1256         (CheckerDispatcher._file_type): Added a case for XML files.
1257         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
1258         files (surprise!).
1259         (StyleProcessor.process): Ask the dispatcher whether we should pass the
1260         lines through the carriage checker.
1261
1262         * Scripts/webkitpy/style/checker_unittest.py:
1263         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
1264         Added. Checks a few file names to see if carriage returns are allowed
1265         or not.
1266         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
1267         other assert_checker_* functions.
1268         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1269         test_*_paths functions.
1270         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
1271         test_*_paths functions.
1272         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
1273         file from this test case, as vcproj files now have a type.
1274         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
1275         Added. Similar to the other should_* functions.
1276         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
1277         Added. Checks that carriage returns aren't checked for or stripped for
1278         allowed files.
1279
1280         * Scripts/webkitpy/style/checkers/xml.py: Added.
1281         (XMLChecker.__init__): Simple init method.
1282         (XMLChecker.check): Pass each line through the expat parser, and record
1283         a style error for any errors thrown by the parser.
1284
1285         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
1286         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
1287         produce a style error.
1288         (XMLCheckerTest.assert_error): Checks that the given XML produces an
1289         error of the given category on the given line.
1290         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
1291         checking that the XMLChecker constructor works properly.
1292         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
1293         cause a style error (see, e.g., r73887).
1294         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
1295         cause a style error (see, e.g., r73773).
1296         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
1297         properly.
1298         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
1299         tags cause a style error (see, e.g., r72795).
1300         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
1301         style error.
1302
1303 2010-12-15  Lucas Forschler  <lforschler@apple.com>
1304
1305         Reviewed by Stephanie Lewis.
1306
1307         https://bugs.webkit.org/show_bug.cgi?id=51117
1308         Add a new leopard test bot
1309         really really commit to trunk this time.
1310
1311         * BuildSlaveSupport/build.webkit.org-config/config.json:
1312
1313 2010-12-15  Sam Weinig  <sam@webkit.org>
1314
1315         Reviewed by Anders Carlsson.
1316
1317         WebKit2: Can't add files to an <input type=file>
1318         https://bugs.webkit.org/show_bug.cgi?id=51087
1319
1320         * MiniBrowser/mac/BrowserWindowController.m:
1321         (runOpenPanel):
1322         (-[BrowserWindowController awakeFromNib]):
1323         Add simple implementation of runOpenPanel callback.
1324
1325         * MiniBrowser/win/BrowserView.cpp:
1326         (BrowserView::create):
1327         * WebKitTestRunner/TestController.cpp:
1328         (WTR::createOtherPage):
1329         (WTR::TestController::initialize):
1330         Stub out runOpenPanel callback. 
1331
1332 2010-12-14  Eric Seidel  <eric@webkit.org>
1333
1334         Reviewed by Adam Barth.
1335
1336         commit-queue should upload failure diffs when tests flake
1337         https://bugs.webkit.org/show_bug.cgi?id=51051
1338
1339         To make this testable I needed to pipe FileSystem down onto tool.
1340         We've wanted it there for a long time anyway.
1341
1342         This patch is kinda a big hack.  But we don't have a nice
1343         way to read results.html files.  I think this will need further
1344         revision before this code actually feels clean.
1345
1346         As part of testing this change, I had to make MockBugzilla.create_bug
1347         actually return an id (like it should) which required updating
1348         a few other unit test results (for the better).
1349
1350         The results_matching_keys change in layouttestresults/rebasline
1351         was an alternate path which I decided not to use in the end, but
1352         I left the change as it seemed an improvement.
1353
1354         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1355         * Scripts/webkitpy/common/net/layouttestresults.py:
1356         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1357         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1358         * Scripts/webkitpy/tool/commands/queues.py:
1359         * Scripts/webkitpy/tool/commands/rebaseline.py:
1360         * Scripts/webkitpy/tool/main.py:
1361         * Scripts/webkitpy/tool/mocktool.py:
1362
1363 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
1364
1365         Reviewed by James Robinson.
1366
1367         new-run-webkit-tests ignores trailing EOL differences in text tests
1368         https://bugs.webkit.org/show_bug.cgi?id=36983
1369
1370         Changed the handling of new-line characters within new-run-webkit-tests
1371         to match old-run-webkit-tests.  Differences in leading and trailing empty
1372         lines in text expectation files are no longer ignored.
1373
1374         * Scripts/webkitpy/layout_tests/port/base.py:
1375         * Scripts/webkitpy/layout_tests/port/test.py:
1376         Added unit tests.  Removed old duplicate unit test entries.
1377         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1378
1379 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1380
1381         Reviewed by Adam Barth.
1382
1383         make status-bubble white-space:nowrap so we can measure it's width without wrapping
1384         https://bugs.webkit.org/show_bug.cgi?id=51149
1385
1386         * QueueStatusServer/templates/statusbubble.html:
1387
1388 2010-12-15  Ojan Vafai  <ojan@chromium.org>
1389
1390         Reviewed by Adam Barth.
1391
1392         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
1393         https://bugs.webkit.org/show_bug.cgi?id=51125
1394
1395         * QueueStatusServer/templates/statusbubble.html:
1396
1397 2010-12-15  Darin Adler  <darin@apple.com>
1398
1399         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
1400
1401 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
1402
1403         Unreviewed, rolling out r74117.
1404         http://trac.webkit.org/changeset/74117
1405         https://bugs.webkit.org/show_bug.cgi?id=51113
1406
1407         This broke the GTK1 build. (Requested by mrobinson on
1408         #webkit).
1409
1410         * Scripts/webkitdirs.pm:
1411
1412 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
1413
1414         Reviewed by Martin Robinson.
1415
1416         Change generate-forwarding-headers.pl for GTK port usage 
1417         (https://bugs.webkit.org/show_bug.cgi?id=37369)
1418
1419         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
1420
1421 2010-12-14  Kent Tamura  <tkent@chromium.org>
1422
1423         Reviewed by Jian Li.
1424
1425         [DRT/Chromium] Remove another unnecessary error message
1426         https://bugs.webkit.org/show_bug.cgi?id=51083
1427
1428         * DumpRenderTree/chromium/WebViewHost.cpp:
1429         (WebViewHost::didInvalidateRect):
1430
1431 2010-12-14  Lucas Forschler  <lforschler@apple.com>
1432
1433         Reviewed by Stephanie Lewis.
1434
1435         Add a new Leopard Debug Test WK2 Bot
1436
1437         * BuildSlaveSupport/build.webkit.org-config/config.json:
1438
1439 2010-12-14  Ojan Vafai  <ojan@chromium.org>
1440
1441         Fix python unittests after http://trac.webkit.org/changeset/74070.
1442
1443         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1444
1445 2010-12-14  Kent Tamura  <tkent@chromium.org>
1446
1447         Reviewed by Jian Li.
1448
1449         [DRT/Chromium] Remove a unnecessary error message
1450         https://bugs.webkit.org/show_bug.cgi?id=51069
1451
1452         * DumpRenderTree/chromium/WebViewHost.cpp:
1453         (WebViewHost::paintInvalidatedRegion):
1454
1455 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
1456
1457         Reviewed by Ojan Vafai.
1458
1459         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
1460         https://bugs.webkit.org/show_bug.cgi?id=48926
1461
1462         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1463         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
1464
1465 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1466
1467         Reviewed by Eric Seidel.
1468
1469         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
1470         https://bugs.webkit.org/show_bug.cgi?id=50231
1471
1472         Guard CONFIG+=link_pkgconfig with !symbian.
1473
1474         * DumpRenderTree/qt/DumpRenderTree.pro:
1475         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1476         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1477
1478 2010-12-14  Philippe Normand  <pnormand@igalia.com>
1479
1480         Reviewed by Ojan Vafai.
1481
1482         [new-run-webkit-tests] expectations parsing is slow
1483         https://bugs.webkit.org/show_bug.cgi?id=50635
1484
1485         Avoid expensive iteration of all the tests when checking if a test
1486         file is to be skipped or not.
1487
1488         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1489         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1490         * Scripts/webkitpy/layout_tests/port/test.py:
1491
1492 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
1493
1494         Reviewed by Xan Lopez.
1495
1496         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
1497         https://bugs.webkit.org/show_bug.cgi?id=27048
1498
1499         Add support in DRT for checking whether an accessibility UI
1500         element is focusable and/or focused. Implemented for GTK.
1501
1502         * DumpRenderTree/AccessibilityUIElement.cpp:
1503         (getIsFocusedCallback): New.
1504         (getIsFocusableCallback): New.
1505         (AccessibilityUIElement::getJSClass): Add the new available
1506         callbacks for isFocused and isFocusable.
1507         * DumpRenderTree/AccessibilityUIElement.h:
1508         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1509         (AccessibilityUIElement::isFocused): New, implemented by checking
1510         whether the related AtkState value is in the object's state set.
1511         (AccessibilityUIElement::isFocusable): Ditto.
1512         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1513         (AccessibilityUIElement::isFocused): New, dummy implementation.
1514         (AccessibilityUIElement::isFocusable): Ditto.
1515         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1516         (AccessibilityUIElement::isFocused): Ditto.
1517         (AccessibilityUIElement::isFocusable): Ditto.
1518
1519 2010-12-14  Eric Seidel  <eric@webkit.org>
1520
1521         Reviewed by Ojan Vafai.
1522
1523         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
1524         https://bugs.webkit.org/show_bug.cgi?id=50715
1525
1526         This patch makes webkit-patch print the following:
1527
1528         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
1529         Install a 64-bit git for better performance, see:
1530         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
1531
1532         I wrote this mostly because I have approximately 8 machines that I use
1533         and making sure each one is using a good Git install seemed folly.
1534         webkit-patch makes a lot of git calls, so using a fast git can shave
1535         several seconds in every invocation.  See the webkit-dev thread for more info.
1536
1537         This message will print twice during 'webkit-patch upload',
1538         once from webkit-patch and once from check-webkit-style.
1539
1540         Unfortunately there is no good way to test this due to how machine-dependent
1541         the code is.  I considered writing a test for the log message, but it seemed not worth it.
1542
1543         * Scripts/webkitpy/common/checkout/scm.py:
1544
1545 2010-12-13  Eric Seidel  <eric@webkit.org>
1546
1547         Reviewed by Adam Barth.
1548
1549         FlakyTestReporter doesn't understand bots running from multiple email addresses
1550         https://bugs.webkit.org/show_bug.cgi?id=50960
1551
1552         This explains at least one of the dupes of:
1553         https://bugs.webkit.org/show_bug.cgi?id=50863
1554         that we saw filed by the commit-queue this morning.
1555         I think the other one was explained by my previous fix to result counting code.
1556
1557         Since this is really hard to test with a unit test, instead I
1558         create a new (possibly useful in the future) command
1559         which given a layout test path will return you
1560         the one bug which our tools would assume it the flaky test bug.
1561         If some other script wants to use bug-for-test we'll
1562         need to extend it with some options like --create-if-missing or similar.
1563
1564         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1565         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1566         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1567         * Scripts/webkitpy/tool/commands/__init__.py:
1568         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
1569
1570 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
1571
1572         Reviewed by James Robinson.
1573
1574         Add option to build-webkit to not build WebKit2
1575         https://bugs.webkit.org/show_bug.cgi?id=50988
1576         
1577         Add support for a --no-webkit2 option to build-webkit. It seems to save
1578         ~1 minute from clean builds and ~10 seconds from no-op builds.
1579
1580         * Scripts/build-webkit:
1581
1582 2010-12-13  Lucas Forschler  <lforschler@apple.com>
1583
1584         Reviewed by Dave Kilzer.
1585
1586         Update iexploder from 1.3.2 to 1.7.2
1587         Move 1.3.2 into its own subdir
1588         Add 1.7.2 into its own subdir
1589         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
1590
1591         * Scripts/run-iexploder-tests:
1592         * Scripts/update-iexploder-cssproperties:
1593         * iExploder/CHANGELOG.txt: Removed.
1594         * iExploder/LICENSE.txt: Removed.
1595         * iExploder/README.txt: Removed.
1596         * iExploder/htdocs: Removed.
1597         * iExploder/iexploder-1.3.2: Added.
1598         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
1599         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
1600         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
1601         * iExploder/iexploder-1.3.2/htdocs: Added.
1602         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
1603         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
1604         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
1605         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
1606         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
1607         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
1608         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
1609         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
1610         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
1611         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
1612         * iExploder/iexploder-1.3.2/tools: Added.
1613         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
1614         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
1615         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
1616         * iExploder/iexploder-1.7.2: Added.
1617         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
1618         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
1619         * iExploder/iexploder-1.7.2/README.txt: Added.
1620         * iExploder/iexploder-1.7.2/output: Added.
1621         * iExploder/iexploder-1.7.2/src: Added.
1622         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
1623         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
1624         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
1625         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
1626         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
1627         * iExploder/iexploder-1.7.2/src/css-properties: Added.
1628         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
1629         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
1630         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
1631         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
1632         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
1633         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
1634         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
1635         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
1636         * iExploder/iexploder-1.7.2/src/css-values: Added.
1637         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
1638         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
1639         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
1640         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
1641         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
1642         * iExploder/iexploder-1.7.2/src/headers: Added.
1643         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
1644         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
1645         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
1646         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
1647         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
1648         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
1649         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
1650         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
1651         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
1652         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
1653         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
1654         * iExploder/iexploder-1.7.2/src/html-tags: Added.
1655         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
1656         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
1657         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
1658         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
1659         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
1660         * iExploder/iexploder-1.7.2/src/html-values: Added.
1661         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
1662         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
1663         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
1664         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
1665         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
1666         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
1667         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
1668         * iExploder/iexploder-1.7.2/src/index.html: Added.
1669         * iExploder/iexploder-1.7.2/src/media: Added.
1670         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
1671         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
1672         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
1673         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
1674         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
1675         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
1676         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
1677         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
1678         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
1679         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
1680         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
1681         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
1682         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
1683         * iExploder/iexploder-1.7.2/src/mime-types: Added.
1684         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
1685         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
1686         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
1687         * iExploder/iexploder-1.7.2/src/protocols: Added.
1688         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
1689         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
1690         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
1691         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
1692         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
1693         * iExploder/iexploder-1.7.2/src/version.rb: Added.
1694         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
1695         * iExploder/iexploder-1.7.2/testcases: Added.
1696         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
1697         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
1698         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
1699         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
1700         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
1701         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
1702         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
1703         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
1704         * iExploder/iexploder-1.7.2/tools: Added.
1705         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1706         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1707         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1708         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1709         * iExploder/tools: Removed.
1710
1711 2010-12-13  Sam Weinig  <sam@webkit.org>
1712
1713         Reviewed by Anders Carlsson.
1714
1715         Remove associated page concept from WKView constructor
1716         https://bugs.webkit.org/show_bug.cgi?id=50983
1717
1718         Step 1: Remove associate page constructors from WKView and make
1719         all views use the shared namespace for the context.
1720
1721         * TestWebKitAPI/PlatformWebView.h:
1722         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1723         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1724         * WebKitTestRunner/PlatformWebView.h:
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::createOtherPage):
1727         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1728         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1729         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1730
1731 2010-12-13  Sam Weinig  <sam@webkit.org>
1732
1733         Reviewed by Anders Carlsson.
1734
1735         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1736         https://bugs.webkit.org/show_bug.cgi?id=50898
1737
1738         * MiniBrowser/mac/AppDelegate.h:
1739         * MiniBrowser/mac/AppDelegate.m:
1740         * MiniBrowser/mac/BrowserWindowController.h:
1741         * MiniBrowser/mac/BrowserWindowController.m:
1742         * MiniBrowser/win/BrowserView.cpp:
1743         Convert MiniBrowser to not use PageNamespaces.
1744
1745         * TestWebKitAPI/PlatformWebView.h:
1746         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1747         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1748         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1749         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1750         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1751         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1752         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1753         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1754         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1755         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1756         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1757         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1758         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1759         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1760         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1761         Convert TestWebKitAPI to not use PageNamespaces.
1762
1763         * WebKitTestRunner/PlatformWebView.h:
1764         * WebKitTestRunner/TestController.cpp:
1765         * WebKitTestRunner/TestController.h:
1766         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1767         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1768         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1769         Convert WebKitTestRunner to not use PageNamespaces.
1770
1771 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1772
1773         Reviewed by Eric Seidel.
1774
1775         webkit-patch rollout should be able to do multi-revision rollouts
1776         https://bugs.webkit.org/show_bug.cgi?id=33336
1777
1778         Make it possible to pass more than one revision to webkit-patch.
1779
1780         * Scripts/webkitpy/common/checkout/api.py:
1781         * Scripts/webkitpy/common/checkout/changelog.py:
1782         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1783         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1784         * Scripts/webkitpy/tool/commands/download.py:
1785         * Scripts/webkitpy/tool/commands/download_unittest.py:
1786         * Scripts/webkitpy/tool/mocktool.py:
1787         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1788         * Scripts/webkitpy/tool/steps/revertrevision.py:
1789
1790 2010-12-13  Eric Seidel  <eric@webkit.org>
1791
1792         Unreviewed.
1793
1794         Teach webkit-patch how to search bugzilla
1795         https://bugs.webkit.org/show_bug.cgi?id=50500
1796
1797         webkit-patch bug-search fails when there is only one result.
1798         Turns out we needed a bit more logic in our result count parsing code.
1799
1800         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1801         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1802
1803 2010-12-13  Antti Koivisto  <antti@apple.com>
1804
1805         Reviewed by Alexey Proskuryakov.
1806
1807         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1808         https://bugs.webkit.org/show_bug.cgi?id=50758
1809
1810         * DumpRenderTree/LayoutTestController.cpp:
1811         (setSerializeHTTPLoadsCallback):
1812         (LayoutTestController::staticFunctions):
1813         * DumpRenderTree/LayoutTestController.h:
1814         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1815         (LayoutTestController::setSerializeHTTPLoads):
1816         * DumpRenderTree/mac/DumpRenderTree.mm:
1817         (resetDefaultsToConsistentValues):
1818         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1819         (LayoutTestController::setSerializeHTTPLoads):
1820         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1821         (LayoutTestController::setSerializeHTTPLoads):
1822
1823 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1824
1825         Reviewed by Ojan Vafai.
1826
1827         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1828         https://bugs.webkit.org/show_bug.cgi?id=50936
1829
1830         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1831
1832 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1833
1834         Reviewed by Csaba Osztrogonác.
1835
1836         Add revlink to BuildBot status
1837         https://bugs.webkit.org/show_bug.cgi?id=50914
1838
1839         This adds a hyperlink to trac changeset on the revision numbers. 
1840
1841         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1842
1843 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1844
1845         Reviewed by Csaba Osztrogonác.
1846
1847         [Qt][WK2] Fix build if WebKitTools are not available
1848         https://bugs.webkit.org/show_bug.cgi?id=50242
1849
1850         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1851         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1852         * MiniBrowser/DerivedSources.pro: Added.
1853
1854 2010-12-13  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Adam Barth.
1857
1858         EWS Queues should remove orpahned pyc files before starting
1859         https://bugs.webkit.org/show_bug.cgi?id=50904
1860
1861         A previous check added a platform.py which caused
1862         EWS bots on some platforms to hit an import exception.
1863         The platform.py file was removed in a subsequent commit, but
1864         the EWS bots in question stayed stuck.  This change will
1865         fix those bots once restarted (and prevent this in the future).
1866
1867         I also went ahead and unified start-queue and start-commit-queue
1868         since they were nearly identical.  I also added bot_id support
1869         to both force all EWSes to have bot ids as well as get rid of the one
1870         remaining reason why I had my own copies of these scripts.
1871         Hopefully this will be enough to get all the other bot admins
1872         (ahem, Adam, ahem) to move to using these checked in copies as well.
1873
1874         * EWSTools/start-commit-queue.sh: Removed.
1875         * EWSTools/start-queue.sh:
1876
1877 2010-10-28  MORITA Hajime  <morrita@google.com>
1878
1879         Reviewed by Ojan Vafai.
1880
1881         spellcheck does not check pasted text
1882         https://bugs.webkit.org/show_bug.cgi?id=40092
1883
1884         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1885         to control the setting.
1886
1887         * DumpRenderTree/LayoutTestController.cpp:
1888         (setAsynchronousSpellCheckingEnabledCallback):
1889         (LayoutTestController::staticFunctions):
1890         * DumpRenderTree/LayoutTestController.h:
1891         * DumpRenderTree/chromium/LayoutTestController.h:
1892         * DumpRenderTree/chromium/LayoutTestController.cpp:
1893         (LayoutTestController::LayoutTestController):
1894         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1895         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1896         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1897         * DumpRenderTree/mac/DumpRenderTree.mm:
1898         (resetDefaultsToConsistentValues):
1899         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1900         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1901         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1902         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1903         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1904         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1905         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1906         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1907         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1908
1909 2010-12-12  Sam Weinig  <sam@webkit.org>
1910
1911         Reviewed by Anders Carlsson.
1912
1913         Fix failing API test. It turns out that a pop-state event
1914         is sent before every fragment navigation, so we have to test
1915         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1916
1917         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1918         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1919
1920 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1921
1922         Reviewed by Eric Seidel.
1923
1924         [GTK] Add new-run-webkit-tests support to gtk
1925         https://bugs.webkit.org/show_bug.cgi?id=50681
1926
1927         Adding the basic support to run the new-run-webkit-tests.
1928
1929         * Scripts/webkitpy/layout_tests/port/gtk.py:
1930
1931 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1932
1933         Reviewed by Kenneth Rohde Christiansen.
1934
1935         [Qt] Mock DeviceOrientation client for DRT
1936         https://bugs.webkit.org/show_bug.cgi?id=47490
1937
1938         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1939         (WebCore::DumpRenderTree::DumpRenderTree):
1940         (WebCore::DumpRenderTree::~DumpRenderTree):
1941         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1942         (LayoutTestController::setMockDeviceOrientation):
1943
1944 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1945
1946         Reviewed by Gustavo Noronha Silva.
1947
1948         [GTK] launcher: disable the Mozilla-style fullscreen API
1949         https://bugs.webkit.org/show_bug.cgi?id=50874
1950
1951         Disabling the fullscreen API until its implementation for GTK is
1952         mature enough. The webview setting for it is already FALSE by
1953         default.
1954
1955         * GtkLauncher/main.c:
1956         (createWindow):
1957
1958 2010-12-10  Eric Seidel  <eric@webkit.org>
1959
1960         Reviewed by Adam Barth.
1961
1962         commit-queue flaky test messages show cryptic version information for mac os x
1963         https://bugs.webkit.org/show_bug.cgi?id=50864
1964
1965         Turns out platform.platform() returns kernel version information
1966         which isn't helpful, and just plain confusing on Mac
1967         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1968
1969         So I've updated PlatformInfo.display_name() to special case
1970         mac.  I also found a bad use of sys.platform in the process
1971         and fixed that.  (sys.platform always returns 'darwin' on mac).
1972
1973         * Scripts/webkitpy/common/system/platforminfo.py:
1974         * Scripts/webkitpy/common/system/user.py:
1975         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1976         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1977         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1978
1979 2010-12-10  Eric Seidel  <eric@webkit.org>
1980
1981         Unreviewed.
1982
1983         Exception seen while reporting flaky test with commit-queue.
1984         Just a missing include.
1985
1986         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1987         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1988
1989 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1990
1991         Reviewed by Eric Seidel.
1992
1993         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1994         https://bugs.webkit.org/show_bug.cgi?id=50796
1995
1996         Also updating the test code to use JSONResultsGeneratorBase and
1997         to improve test coverage for incremental cases.
1998
1999         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2000         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2001
2002 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
2003
2004         Reviewed by Darin Adler.
2005
2006         prepare-ChangeLog --help doesn't mention --bug shorthand -b
2007         https://bugs.webkit.org/show_bug.cgi?id=50835
2008
2009         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
2010
2011 2010-12-10  Eric Seidel  <eric@webkit.org>
2012
2013         Reviewed by Adam Barth.
2014
2015         Bugs created by the commit-queue should all block on a master bug
2016         https://bugs.webkit.org/show_bug.cgi?id=50857
2017
2018         This makes all bugs created by the commit-queue block on:
2019         https://bugs.webkit.org/show_bug.cgi?id=50856
2020
2021         In the process of testing this, I found that the existing
2022         create_bug code was wrong.  I also found that existing
2023         unit tests for create-rollout used invalid values
2024         for options.blocks.  I fixed both issues and tested.
2025
2026         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2027         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2028         * Scripts/webkitpy/tool/commands/commandtest.py:
2029         * Scripts/webkitpy/tool/commands/download_unittest.py:
2030         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2031         * Scripts/webkitpy/tool/mocktool.py:
2032         * Scripts/webkitpy/tool/steps/options.py:
2033
2034 2010-12-10  Eric Seidel  <eric@webkit.org>
2035
2036         Reviewed by Adam Barth.
2037
2038         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
2039         https://bugs.webkit.org/show_bug.cgi?id=50853
2040
2041         I also discovered when doing this that the code was posting
2042         the comment on the wrong bug, but that's fixed here too.
2043
2044         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2045         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2046         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2047         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2048         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2049         * Scripts/webkitpy/tool/mocktool.py:
2050
2051 2010-12-10  Anders Carlsson  <andersca@apple.com>
2052
2053         Reviewed by John Sullivan.
2054
2055         Make WKContextGetStatistics gather global statistics
2056         https://bugs.webkit.org/show_bug.cgi?id=50850
2057
2058         Remove the code that gets the statistics and fills in the per context
2059         statistics information for now.
2060
2061         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
2062         (-[BrowserStatisticsWindowController refreshStatistics:]):
2063
2064 2010-12-10  Eric Seidel  <eric@webkit.org>
2065
2066         Unreviewed.
2067
2068         commit-queue should report port/platform information when commenting on flaky test bugs
2069         https://bugs.webkit.org/show_bug.cgi?id=50839
2070
2071         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
2072         which was only used by new run webkit tests (and clearly not unit tested).
2073
2074         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
2075         * Scripts/webkitpy/tool/main.py:
2076         * Scripts/webkitpy/tool/mocktool.py:
2077
2078 2010-12-10  Eric Seidel  <eric@webkit.org>
2079
2080         Reviewed by Tony Chang.
2081
2082         commit-queue should report port/platform information when commenting on flaky test bugs
2083         https://bugs.webkit.org/show_bug.cgi?id=50839
2084
2085         This was a suggestion from Tony Chang this morning.
2086         I added a platform.py class so I could easily mock the platform call,
2087         but that may not be the final solution for this mocking.
2088         We'll try it and see.
2089
2090         * Scripts/webkitpy/common/system/platform.py: Added.
2091         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2092         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2093         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2094         * Scripts/webkitpy/tool/main.py:
2095         * Scripts/webkitpy/tool/mocktool.py:
2096
2097 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
2098
2099         Reviewed by Joseph Pecoraro.
2100
2101         Bug 43455 - [Qt]: Implement Application Cache Quotas
2102         https://bugs.webkit.org/show_bug.cgi?id=43455
2103
2104         Introduce functions to allow new appcache layout test origin-quota.html
2105         to work correctly under Qt.
2106
2107         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2108         (WebCore::DumpRenderTree::DumpRenderTree):
2109         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
2110         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2111
2112         Introduce functions to allow new appcache layout test origin-quota.html
2113         to be successful under qt. Changes required because LayoutTestControllerQt
2114         does not inherit from LayoutController.
2115
2116         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2117         (LayoutTestController::reset):
2118         (LayoutTestController::clearAllApplicationCaches):
2119         (LayoutTestController::setApplicationCacheOriginQuota):
2120         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2121         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
2122         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
2123
2124 2010-12-10  Eric Seidel  <eric@webkit.org>
2125
2126         Reviewed by Adam Barth.
2127
2128         Move buildbot.py into its own module so we can split it out into one-file-per-class
2129         https://bugs.webkit.org/show_bug.cgi?id=50806
2130
2131         We're adding more buildbot logic these days, so it makes sense
2132         to give buildbot its own module.
2133
2134         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
2135         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
2136         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
2137         * Scripts/webkitpy/common/net/failuremap.py:
2138         * Scripts/webkitpy/common/net/regressionwindow.py:
2139         * Scripts/webkitpy/tool/commands/rebaseline.py:
2140
2141 2010-12-10  Tony Chang  <tony@chromium.org>
2142
2143         Reviewed by Eric Seidel.
2144
2145         Use FileSystem::remove when cleaning up http lock files
2146         https://bugs.webkit.org/show_bug.cgi?id=50830
2147
2148         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2149
2150 2010-12-10  Joone Hur  <joone@kldp.org>
2151
2152         Reviewed by Martin Robinson.
2153
2154         [GTK] DRT needs layoutTestController.setCacheModel
2155         https://bugs.webkit.org/show_bug.cgi?id=50705
2156         
2157         webkit_set_cache_mode() is called to set the cache model.
2158         
2159         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2160         (LayoutTestController::setCacheModel): Set the cache model. 
2161
2162 2010-12-10  Tony Chang  <tony@chromium.org>
2163
2164         Reviewed by Ojan Vafai.
2165
2166         [chromium] remove --use-drt and add --use-test-shell
2167         https://bugs.webkit.org/show_bug.cgi?id=50701
2168
2169         * Scripts/webkitpy/common/config/ports.py:
2170         * Scripts/webkitpy/common/config/ports_unittest.py:
2171         * Scripts/webkitpy/layout_tests/port/chromium.py:
2172         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2173         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2174         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2175         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2176         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2177         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2178         * Scripts/webkitpy/layout_tests/port/webkit.py:
2179         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2180         * Scripts/webkitpy/style/checkers/test_expectations.py:
2181         * Scripts/webkitpy/tool/commands/queries.py:
2182
2183 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
2184
2185         Reviewed by Steve Block.
2186
2187         [Chromium] Implement mocks for client-based geolocation
2188         https://bugs.webkit.org/show_bug.cgi?id=46895
2189
2190         * DumpRenderTree/chromium/LayoutTestController.cpp:
2191         (LayoutTestController::setGeolocationPermission):
2192         (LayoutTestController::setMockGeolocationPosition):
2193         (LayoutTestController::setMockGeolocationError):
2194         * DumpRenderTree/chromium/LayoutTestController.h:
2195         * DumpRenderTree/chromium/WebViewHost.cpp:
2196         (WebViewHost::geolocationClient):
2197         (WebViewHost::geolocationClientMock):
2198         (WebViewHost::reset):
2199         * DumpRenderTree/chromium/WebViewHost.h:
2200
2201 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
2202
2203         Reviewed by Martin Robinson.
2204
2205         [GTK] Add hasSpellingMarker support to the DRT
2206         https://bugs.webkit.org/show_bug.cgi?id=50739
2207
2208         Implemented the hasSpellingMarker to support spelling tests.
2209
2210         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2211         (LayoutTestController::hasSpellingMarker):
2212
2213 2010-12-10  Eric Seidel  <eric@webkit.org>
2214
2215         Reviewed by Ojan Vafai.
2216
2217         webkit-patch: not possible to use build-and-test with local commits
2218         https://bugs.webkit.org/show_bug.cgi?id=33378
2219
2220         Make --no-clean not even check if we have local commits.
2221         It's unclear to me why the code was originally written this way.
2222         I was unable to dig up a reason from svn history.
2223
2224         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2225         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2226
2227 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
2228
2229         Reviewed by Martin Robinson.
2230
2231         [GTK] AX: implement isEnabled in DRT
2232         https://bugs.webkit.org/show_bug.cgi?id=50814
2233
2234         Implement AccessibilityUIElement::isEnabled() for GTK.
2235
2236         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2237         (checkElementState): New function to refactor common code.
2238         (AccessibilityUIElement::isEnabled): Implement this by checking
2239         the current state of the AtkObject.
2240         (AccessibilityUIElement::isSelected): Use the new
2241         checkElementState function.
2242
2243 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2244
2245         Reviewed by Kenneth Rohde Christiansen.
2246
2247         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
2248         https://bugs.webkit.org/show_bug.cgi?id=50750
2249
2250         * MiniBrowser/qt/BrowserView.cpp:
2251         (BrowserView::BrowserView):
2252         * MiniBrowser/qt/BrowserView.h:
2253         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2254         (WTR::WebView::WebView):
2255
2256 2010-12-10  Joone Hur  <joone@kldp.org>
2257
2258         Reviewed by Xan Lopez.
2259
2260         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
2261         https://bugs.webkit.org/show_bug.cgi?id=50808
2262
2263         Unskipping the following test cases:
2264         userscripts/mixed-case-stylesheet.html
2265         userscripts/simple-stylesheet.html
2266         userscripts/user-style-all-frames.html
2267
2268         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2269         (LayoutTestController::addUserStyleSheet):
2270
2271 2010-12-10  Joone Hur  <joone@kldp.org>
2272
2273         Reviewed by Eric Seidel.
2274
2275         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
2276         https://bugs.webkit.org/show_bug.cgi?id=50783
2277
2278         This patch allows to unskip the following test cases:
2279         printing/page-rule-selection.html
2280         printing/page-format-data.html
2281
2282         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2283         (LayoutTestController::pageProperty): Added.
2284         (LayoutTestController::isPageBoxVisible): Ditto.
2285         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
2286         (LayoutTestController::addUserStyleSheet): Ditto.
2287
2288 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2289
2290         Reviewed by Kenneth Rohde Christiansen.
2291
2292         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
2293
2294         A menu allows to switch QNAM back to the same thread.
2295
2296         * QtTestBrowser/launcherwindow.cpp:
2297         (LauncherWindow::initializeView):
2298         (LauncherWindow::createChrome):
2299         (LauncherWindow::toggleThreadedQnam):
2300         * QtTestBrowser/launcherwindow.h:
2301         (WindowOptions::WindowOptions):
2302         * QtTestBrowser/webpage.cpp:
2303         (WebPage::WebPage):
2304         (WebPage::setQnamThreaded):
2305         * QtTestBrowser/webpage.h:
2306         (QnamThread::QnamThread):
2307         (QnamThread::~QnamThread):
2308         (QnamThread::networkAccessManager):
2309         (QnamThread::run):
2310
2311 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
2312
2313         Reviewed by Xan Lopez.
2314
2315         [Gtk] style="font-family: courier" makes text disappear
2316         https://bugs.webkit.org/show_bug.cgi?id=47452
2317
2318         Add a test that verifies that fonts without valid charmaps are
2319         never selected.
2320
2321         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2322         (initializeFonts): Initialize DRT with our font (derived from Ahem)
2323         that has no valid charmap.
2324         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
2325         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
2326         settings which may disable selection of bitmap fonts.
2327
2328 2010-12-10  Eric Seidel  <eric@webkit.org>
2329
2330         Unreviewed.
2331
2332         The commit-queue should file bugs about flaky tests it encounters
2333         https://bugs.webkit.org/show_bug.cgi?id=50803
2334
2335         create_bug_for_flaky_test was insufficiently tested, thus buggy.
2336         Now it's tested.
2337
2338         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2339         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2340
2341 2010-12-10  Eric Seidel  <eric@webkit.org>
2342
2343         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
2344
2345         The commit-queue should file bugs about flaky tests it encounters
2346         https://bugs.webkit.org/show_bug.cgi?id=50803
2347
2348         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2349
2350 2010-12-09  Eric Seidel  <eric@webkit.org>
2351
2352         Reviewed by Adam Barth.
2353
2354         The commit-queue should file bugs about flaky tests it encounters
2355         https://bugs.webkit.org/show_bug.cgi?id=50803
2356
2357         This change got a bit big.  I also added a new config.urls file
2358         because I needed to share the view_source_url code with committervalidator.py.
2359
2360         This adds a new class FlakyTestReporter which holds all the logic about
2361         reporting flaky tests to bugzilla.
2362
2363         Right now this code knows how to look up bugs for flaky tests.
2364         If it can't find a bug filed from the commit-queue, it will open a new
2365         one, ccing the relevant people and adding information about the failure.
2366
2367         It is not yet smart enough to chase down duplicate chains, or to include
2368         the actual failure diff.  But those can be added in later iterations.
2369
2370         * Scripts/webkitpy/common/checkout/api.py:
2371         * Scripts/webkitpy/common/checkout/changelog.py:
2372         * Scripts/webkitpy/common/checkout/commitinfo.py:
2373         * Scripts/webkitpy/common/config/committervalidator.py:
2374         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2375         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2376         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
2377         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
2378         * Scripts/webkitpy/tool/bot/irc_command.py:
2379         * Scripts/webkitpy/tool/bot/sheriff.py:
2380         * Scripts/webkitpy/tool/commands/download.py:
2381         * Scripts/webkitpy/tool/commands/queues.py:
2382         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2383         * Scripts/webkitpy/tool/comments.py:
2384         * Scripts/webkitpy/tool/mocktool.py:
2385         * Scripts/webkitpy/tool/steps/commit.py:
2386
2387 2010-12-09  Eric Seidel  <eric@webkit.org>
2388
2389         Reviewed by Adam Barth.
2390
2391         Teach webkit-patch how to search bugzilla
2392         https://bugs.webkit.org/show_bug.cgi?id=50500
2393
2394         This is a step towards teaching webkitpy how to file
2395         new bugs for flaky tests and update them when new flakes occur.
2396
2397         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2398         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2399         * Scripts/webkitpy/tool/commands/__init__.py:
2400         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
2401
2402 2010-12-09  Adam Barth  <abarth@webkit.org>
2403
2404         Reviewed by Ojan Vafai.
2405
2406         commit-queue errors out due to local commits
2407         https://bugs.webkit.org/show_bug.cgi?id=50766
2408
2409         We seem to be tripping over having local commits in the working copy a
2410         lot recently.  I don't quite fully understand what the issue is, but
2411         this patch attempts to solve the problem by adding an explicit clean
2412         step before processing a patch.  Previously, we did the cleaning as
2413         part of the apply-attachment step, so this might not actually fix the
2414         problem.
2415
2416         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2417         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2418         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2419
2420 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
2421
2422         Reviewed by Ojan Vafai.
2423
2424         Make new-run-webkit-tests --lint-test-files log slightly better
2425         messages and return -1 if lint fails. Remove the
2426         'suppress_errors' keyword param to the TestExpectationsFile
2427         class, and clean up logging and exception raising for error
2428         handling. Also add more unit tests and clean up the unit test code a bit.
2429
2430         https://bugs.webkit.org/show_bug.cgi?id=50205
2431
2432         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2433         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2434         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
2435         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
2436         * Scripts/webkitpy/layout_tests/port/chromium.py:
2437         * Scripts/webkitpy/style/checkers/test_expectations.py:
2438         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2439
2440 2010-12-09  Tony Chang  <tony@chromium.org>
2441
2442         Unreviewed, fix for windows code.  We were catching the wrong
2443         exception in Windows.
2444
2445         * Scripts/webkitpy/common/system/filesystem.py:
2446
2447 2010-12-09  Antonio Gomes  <agomes@rim.com>
2448
2449         Reviewed by Martin Robinson.
2450
2451         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
2452         https://bugs.webkit.org/show_bug.cgi?id=48429
2453
2454         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
2455
2456         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2457         (LayoutTestController::workerThreadCount):
2458
2459 2010-12-06  Philippe Normand  <pnormand@igalia.com>
2460
2461         Reviewed by Martin Robinson.
2462
2463         [GTK] Support the Mozilla-style Fullscreen Javascript API
2464         https://bugs.webkit.org/show_bug.cgi?id=50572
2465
2466         Enable the Javascript Fullscreen support in the GtkLauncher. Also
2467         make DRT update the Chrome when the WebView settings have been
2468         reset to consistent values.
2469
2470         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2471         (resetDefaultsToConsistentValues):
2472         * GtkLauncher/main.c:
2473         (create_window):
2474         * Scripts/build-webkit:
2475
2476 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
2477
2478         Reviewed by Tor Arne Vestbø
2479
2480         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
2481         https://bugs.webkit.org/show_bug.cgi?id=50742
2482
2483         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
2484
2485         * Scripts/webkitdirs.pm:
2486
2487 2010-12-09  Joone Hur  <joone@kldp.org>
2488
2489          Reviewed by Martin Robinson.
2490
2491          [GTK] Support for viewport meta tag
2492          https://bugs.webkit.org/show_bug.cgi?id=45443
2493
2494          Add support for testing the viewport properties for WebKitGtk.
2495
2496          * DumpRenderTree/LayoutTestController.cpp:
2497          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
2498          (LayoutTestController::staticFunctions):
2499          * DumpRenderTree/LayoutTestController.h:
2500          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2501          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
2502          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2503          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2504          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2505          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2506          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2507          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2508          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2509          (LayoutTestController::dumpConfigurationForViewport): Ditto.
2510
2511 2010-12-08  William Siegrist <wsiegrist@apple.com>
2512
2513         Reviewed by Eric Seidel.
2514
2515         Migrate buildbot.py from xmlrpc to json.
2516         https://bugs.webkit.org/show_bug.cgi?id=50647
2517
2518         * Scripts/webkitpy/common/net/buildbot.py:
2519
2520 2010-12-08  Tony Chang  <tony@chromium.org>
2521
2522         Reviewed by Eric Seidel.
2523
2524         make starting the websocket server more reliable on windows
2525         https://bugs.webkit.org/show_bug.cgi?id=50712
2526
2527         * Scripts/webkitpy/common/system/filesystem.py:
2528         (remove): Substitute method for os.remove to retry on error on Windows
2529         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2530         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
2531
2532 2010-12-08  Jessie Berlin  <jberlin@apple.com>
2533
2534         Reviewed by Adam Roben.
2535
2536         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
2537         https://bugs.webkit.org/show_bug.cgi?id=50656
2538
2539         * MiniBrowser/mac/BrowserWindowController.m:
2540         (-[BrowserWindowController awakeFromNib]):
2541         Indicate that exceededDatabaseQuota is not implemented.
2542         * MiniBrowser/win/BrowserView.cpp:
2543         (BrowserView::create):
2544         Ditto.
2545         * WebKitTestRunner/TestController.cpp:
2546         (WTR::createOtherPage):
2547         Ditto.
2548         (WTR::TestController::initialize):
2549         Ditto.
2550
2551 2010-12-08  Antonio Gomes  <agomes@rim.com>
2552
2553         Reviewed by Martin Robinson.
2554
2555         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
2556         https://bugs.webkit.org/show_bug.cgi?id=48429
2557
2558         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
2559         * webkit_gc_collect_javascript_objects;
2560         * webkit_gc_collect_javascript_objects_on_alternate_thread;
2561         * webkit_gc_count_javascript_objects;
2562         * webkit_web_frame_layout.
2563
2564         These were all only used by GTK+ DRT.
2565
2566         * DumpRenderTree/gtk/EventSender.cpp:
2567         (dispatchEvent):
2568         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2569         (GCController::collect):
2570         (GCController::collectOnAlternateThread):
2571         (GCController::getJSObjectCount):
2572
2573 2010-12-07  Tony Chang  <tony@chromium.org>
2574
2575         Reviewed by Ojan Vafai.
2576
2577         [chromium] force NRWT to use DRT
2578         https://bugs.webkit.org/show_bug.cgi?id=50359
2579
2580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2581
2582 2010-12-06  Sam Weinig  <sam@webkit.org>
2583
2584         Reviewed by Anders Carlsson.
2585
2586         Generalize didChangeLocationWithinPageForFrame for all same document navigations
2587         https://bugs.webkit.org/show_bug.cgi?id=50584
2588
2589         * MiniBrowser/mac/BrowserWindowController.m:
2590         (didSameDocumentNavigationForFrame):
2591         (-[BrowserWindowController awakeFromNib]):
2592         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
2593         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2594         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2595         (TestWebKitAPI::TEST):
2596         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2597         (WTR::InjectedBundlePage::InjectedBundlePage):
2598         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
2599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2600         * WebKitTestRunner/TestController.cpp:
2601         (WTR::TestController::initialize):
2602
2603 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
2604
2605         Reviewed by Ojan Vafai.
2606
2607         Make TestResultsServer return 404 for non-existing results files.
2608         https://bugs.webkit.org/show_bug.cgi?id=50581
2609
2610         * TestResultServer/handlers/testfilehandler.py:
2611
2612 2010-12-06  Tony Chang  <tony@chromium.org>
2613
2614         Reviewed by Ojan Vafai.
2615
2616         [chromium] fix an assert hit in DRT
2617         https://bugs.webkit.org/show_bug.cgi?id=50575
2618
2619         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
2620         semantics.
2621
2622         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
2623         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
2624         WTF::RefCountedBase::ref()).
2625
2626         * DumpRenderTree/chromium/TestWebWorker.h:
2627         (TestWebWorker::TestWebWorker):
2628
2629 2010-12-02  Ojan Vafai  <ojan@chromium.org>
2630
2631         Reviewed by Eric Seidel.
2632
2633         make webkit-patch command work when the git branch is not synced to the remote svn branch
2634         https://bugs.webkit.org/show_bug.cgi?id=50424
2635
2636         * Scripts/webkitpy/common/checkout/scm.py:
2637         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2638
2639 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
2640
2641         Reviewed by Andreas Kling.
2642
2643         [WINCE] Add build system
2644         https://bugs.webkit.org/show_bug.cgi?id=50522
2645
2646         * CMakeListsWinCE.txt: Added.
2647
2648 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2649
2650         Reviewed by Tony Chang.
2651
2652         Allow the Chromium port to have Leopard-specific baselines
2653         https://bugs.webkit.org/show_bug.cgi?id=50506
2654
2655         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2656
2657 2010-12-03  Tony Chang  <tony@chromium.org>
2658
2659         Reviewed by Kent Tamura.
2660
2661         [chromium] fix 2 bugs with inspector tests in DRT
2662         https://bugs.webkit.org/show_bug.cgi?id=50492
2663
2664         Tasks can outlive the tasklist (even when canceled) so this was
2665         causing a crash when ~WebTask() ran.  Avoid this by unregistering
2666         when a task is canceled.
2667
2668         Also fix an assert when closing devtool windows by copying some
2669         logic from test_shell.
2670
2671         * DumpRenderTree/chromium/Task.cpp:
2672         (WebTask::~WebTask):
2673         (TaskList::revokeAll):
2674         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
2675             the tasklist (since the task can outlive the tasklist).
2676         * DumpRenderTree/chromium/TestShell.h:
2677         (TestShell::devToolsWebView):
2678         * DumpRenderTree/chromium/WebViewHost.cpp:
2679         (WebViewHost::~WebViewHost): Don't load about:blank when closing
2680             a window if the window has devtools loaded.  This avoids an
2681             ASSERT and matches test_shell.
2682
2683 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
2684
2685         Reviewed by Martin Robinson.
2686
2687         [GTK] Fix GtkLauncher.c style, use webkit style
2688         https://bugs.webkit.org/show_bug.cgi?id=50542
2689
2690         * GtkLauncher/main.c:
2691         (activateUriEntryCb):
2692         (updateTitle):
2693         (linkHoverCb):
2694         (notifyTitleCb):
2695         (notifyLoadStatusCb):
2696         (notifyProgressCb):
2697         (destroyCb):
2698         (goBackCb):
2699         (goForwardCb):
2700         (create_webViewCb):
2701         (webViewReadyCb):
2702         (closeWebViewCb):
2703         (createBrowser):
2704         (createStatusbar):
2705         (createToolbar):
2706         (createWindow):
2707         (main):
2708
2709 2010-12-04  Antonio Gomes  <agomes@rim.com>
2710
2711         Reviewed by Martin Robinson.
2712
2713         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2714         https://bugs.webkit.org/show_bug.cgi?id=48429
2715
2716         Moved more private method declared with WEBKIT_API to
2717         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2718
2719         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2720         (resetDefaultsToConsistentValues):
2721         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2722         (LayoutTestController::addOriginAccessWhitelistEntry):
2723         (LayoutTestController::execCommand):
2724         (LayoutTestController::isCommandEnabled):
2725
2726 2010-12-04  Antonio Gomes  <agomes@rim.com>
2727
2728         Reviewed by Andreas Kling.
2729
2730         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2731
2732         Method was removed by http://trac.webkit.org/changeset/71604
2733
2734         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2735
2736 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2737
2738         Reviewed by Xan Lopez.
2739
2740         [GTK] Fix compilation warnings reported by clang
2741         https://bugs.webkit.org/show_bug.cgi?id=50252
2742
2743         * GtkLauncher/main.c:
2744         (create_window): The create_statusbar function does not have
2745         parameters.
2746
2747 2010-12-05  Robert Hogan  <robert@webkit.org>
2748
2749         Reviewed by Andreas Kling.
2750
2751         [Qt] Zero-sized font does not yet work
2752
2753         Fix fast/text/font-size-zero.html
2754
2755         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2756
2757         https://bugs.webkit.org/show_bug.cgi?id=49759
2758
2759         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2760         (WebCore::WebPage::WebPage):
2761
2762 2010-12-04  Sam Weinig  <sam@webkit.org>
2763
2764         Reviewed by Jon Honeycutt.
2765
2766         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2767         https://bugs.webkit.org/show_bug.cgi?id=50511
2768
2769         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2770         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2771
2772         * MiniBrowser/mac/BrowserWindowController.m:
2773         (didChangeLocationWithinPageForFrame):
2774         (-[BrowserWindowController awakeFromNib]):
2775         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2776         * TestWebKitAPI/PlatformUtilities.cpp:
2777         (TestWebKitAPI::Util::toWK):
2778         * TestWebKitAPI/PlatformUtilities.h:
2779         (TestWebKitAPI::Util::adoptWK):
2780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2781         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2782         (TestWebKitAPI::nullJavaScriptCallback):
2783         (TestWebKitAPI::didFinishLoadForFrame):
2784         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2785         (TestWebKitAPI::TEST):
2786         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2787         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2788         * TestWebKitAPI/win/copy-resources.cmd:
2789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2790         (WTR::InjectedBundlePage::InjectedBundlePage):
2791         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2793         * WebKitTestRunner/TestController.cpp:
2794         (WTR::TestController::initialize):
2795
2796 2010-11-08  Antonio Gomes  <agomes@rim.com>
2797
2798         Reviewed by Martin Robinson.
2799
2800         [Gtk] Populate DumpRenderTreeSupportGtk
2801         https://bugs.webkit.org/show_bug.cgi?id=48429
2802
2803         Made the previous calls to webkit_web_frame* functions defined as private
2804         APIs in webkitprivate.h go through DRTSupportGtk.
2805
2806         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2807         (AccessibilityController::focusedElement):
2808         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2809         (dumpFramesAsText):
2810         (resetDefaultsToConsistentValues):
2811         (dump):
2812         (webViewDocumentLoadFinished):
2813         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2814         (LayoutTestController::counterValueForElementById):
2815         (LayoutTestController::pageNumberForElementById):
2816         (LayoutTestController::numberOfPages):
2817         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2818         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2819         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2820         (LayoutTestController::numberOfActiveAnimations):
2821         (LayoutTestController::suspendAnimations):
2822         (LayoutTestController::resumeAnimations):
2823         (LayoutTestController::markerTextForListItem):
2824
2825 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2826
2827         Reviewed by Tony Chang.
2828
2829         Rebaseline server: use pretty text diff output
2830         https://bugs.webkit.org/show_bug.cgi?id=50484
2831         
2832         Serve *-pretty-diff.html for text diff output.
2833
2834         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2835         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2836         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2837         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2838
2839 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2840
2841         Unreviewed, rolling out r73302.
2842         http://trac.webkit.org/changeset/73302
2843         https://bugs.webkit.org/show_bug.cgi?id=50499
2844
2845         Causes crashes in debug LayoutTests (Requested by xan_ on
2846         #webkit).
2847
2848         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2849         (AccessibilityUIElement::AccessibilityUIElement):
2850         (AccessibilityUIElement::parentElementCallback):
2851         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2852         * DumpRenderTree/chromium/CppBoundClass.cpp:
2853         * DumpRenderTree/chromium/CppBoundClass.h:
2854
2855 2010-12-03  Sam Weinig  <sam@webkit.org>
2856
2857         Reviewed by Maciej Stachowiak.
2858
2859         Enable <a ping> for Mac/Windows/WebKit2 builds
2860         <rdar://problem/8504473>
2861         https://bugs.webkit.org/show_bug.cgi?id=50488
2862
2863         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2864         (TestWebKitAPI::TEST): Test that the default value of
2865         WKPreferencesGetHyperlinkAuditingEnabled is true.
2866
2867 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2868
2869         Reviewed by Chris Fleizach.
2870
2871         Include the FrameView widget of a RenderWidget in the accessibility tree.
2872         https://bugs.webkit.org/show_bug.cgi?id=49106
2873
2874         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2875         (AccessibilityUIElement::AccessibilityUIElement):
2876         (AccessibilityUIElement::parentElementCallback):
2877         (AccessibilityUIElement::isEqualCallback):
2878         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2879         * DumpRenderTree/chromium/CppBoundClass.cpp:
2880         (CppBoundClass::getFromCppVariant):
2881         * DumpRenderTree/chromium/CppBoundClass.h:
2882
2883 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2884
2885         Reviewed by Tony Chang.
2886
2887         Rebaseline server: organize tests by state, add dry run mode
2888         https://bugs.webkit.org/show_bug.cgi?id=50473
2889         
2890         Group tests in the menu by state, so that it's easier to see after
2891         processing the queue which failed.
2892         
2893         Add support for the --dry-run flag so that it's easier to test changes
2894         such as this (stubs out filesystem and SCM operations).
2895
2896         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2897         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2898         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2899
2900 2010-12-03  Brady Eidson  <beidson@apple.com>
2901
2902         Reviewed by Anders Carlsson.
2903
2904         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2905         WebKit2 Authentication Support
2906
2907         Keep these builds working:
2908         * MiniBrowser/mac/BrowserWindowController.m:
2909         (-[BrowserWindowController awakeFromNib]):
2910
2911         * WebKitTestRunner/TestController.cpp:
2912         (WTR::TestController::initialize):
2913
2914 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2915
2916         Reviewed by Tony Chang.
2917
2918         Rebaseline server: move existing baselines
2919         https://bugs.webkit.org/show_bug.cgi?id=50421
2920         
2921         Implement moving of existing baselines: move all files that are about
2922         to be overwriten by update baselines.
2923         
2924         Also fix a typo in the UI JS.
2925
2926         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2927         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2928         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2929
2930 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2931
2932         Unreviewed, rolling out r73211.
2933         http://trac.webkit.org/changeset/73211
2934         https://bugs.webkit.org/show_bug.cgi?id=50450
2935
2936         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2937         yutak on #webkit).
2938
2939         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2940
2941 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2942
2943         Unreviewed, rolling out r73222.
2944         http://trac.webkit.org/changeset/73222
2945         https://bugs.webkit.org/show_bug.cgi?id=50449
2946
2947         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2948         (Requested by yutak on #webkit).
2949
2950         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2951         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2952         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2953         * Scripts/webkitpy/layout_tests/port/base.py:
2954         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2955         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2956
2957 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2958
2959         Unreviewed, rolling out r73228.
2960         http://trac.webkit.org/changeset/73228
2961         https://bugs.webkit.org/show_bug.cgi?id=50448
2962
2963         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2964         (Requested by yutak on #webkit).
2965
2966         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2967         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2968         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2969         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2970         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2971
2972 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2973
2974         Unreviewed, rolling out r73231.
2975         http://trac.webkit.org/changeset/73231
2976         https://bugs.webkit.org/show_bug.cgi?id=50443
2977
2978         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2979         (Requested by yutak on #webkit).
2980
2981         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2982         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2983         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2984         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2985
2986 2010-12-03  David Levin  <levin@chromium.org>
2987
2988         Reviewed by Shinichiro Hamaji.
2989
2990         check-webkit-style: false positive reported for #if macro
2991         https://bugs.webkit.org/show_bug.cgi?id=48242
2992
2993         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2994           all preprocessor commands.
2995         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2996
2997 2010-12-02  Eric Seidel  <eric@webkit.org>
2998
2999         Reviewed by Adam Barth.
3000
3001         Update the EWSTools scripts to use modern-style git repos
3002         https://bugs.webkit.org/show_bug.cgi?id=50402
3003
3004         * EWSTools/create-webkit-git:
3005         * EWSTools/start-commit-queue.sh:
3006         * EWSTools/start-queue.sh:
3007
3008 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3009
3010         Fix Chromium Linux plugin tests by not logging
3011         unconditionally from the event handling code.
3012
3013         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3014         (handleEventX11):
3015
3016 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3017
3018         Reviewed by Tony Chang.
3019
3020         nrwt multiprocessing - move logic back into run_webkit_tests
3021
3022         This change moves a bunch of logic that I had put into
3023         message_broker back into run_webkit_tests, in a slightly
3024         different format. WorkerMessageBroker needed to become less aware of
3025         the logic the TestRunner class uses, and more generic.
3026         Eventually the MessageBroker will only do generic messaging and
3027         thread/process-pooling, and (almost) all of the
3028         run-webkit-tests-specific logic will be moved to
3029         run_webkit_tests.py and dump_render_tree_thread.py.
3030         
3031         The biggest changes are that the Broker can now start a single
3032         worker, but the responsibility for starting all of them is pushed
3033         back to the TestRunner (Manager), and the logic for checking if
3034         the threads are done or wedged is moved back to TestRunner. We
3035         also remove WorkerMessageBroker.cleanup (not needed) and
3036         cancel_workers (they have to be cancelled individually).
3037         
3038         The  message_broker is now encapsulated inside
3039         TestRunner._run_tests(); it only needs to exist while actually
3040         running the tests.
3041
3042         Also, delete a bunch of tests in message_broker_unittest that no
3043         longer make much sense.
3044
3045         This patch depends on bug 50372.
3046
3047         https://bugs.webkit.org/show_bug.cgi?id=50374
3048
3049         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3050         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3051         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3053         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3054
3055 2010-12-02  Hayato Ito  <hayato@chromium.org>
3056
3057         Reviewed by Eric Seidel.
3058
3059         Refactor test_types's compare_output() method so that it takes a
3060         TestInput object.
3061
3062         compare_output() will need additional information included in a TestInput
3063         object to support reftests. This change is a pre-requirement of that.
3064
3065         https://bugs.webkit.org/show_bug.cgi?id=50362
3066
3067         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3068         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3069         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3070         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
3071         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3072
3073 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
3074
3075         Reviewed by Anders Carlsson.
3076
3077         Add the ability to run script on 'new' and 'paint' in the test plugin
3078         https://bugs.webkit.org/show_bug.cgi?id=50425
3079         
3080         Add "onnew" and "onpaintevent" attributes to the test plugin,
3081         so that tests can run JS at these times.
3082
3083         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3084         (pluginAllocate):
3085         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
3086         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3087         (NPP_New):
3088         (NPP_Destroy):
3089         (handleEventCarbon):
3090         (handleEventCocoa):
3091         (NPP_HandleEvent):
3092
3093 2010-12-02  Sam Weinig  <sam@webkit.org>
3094
3095         Fix Qt build.
3096
3097         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3098         (WTR::PlatformWebView::PlatformWebView):
3099
3100 2010-12-02  Sam Weinig  <sam@webkit.org>
3101
3102         Reviewed by Anders Carlsson.
3103
3104         WebKit2 Preferences should be held off the PageGroup, not the Context
3105         https://bugs.webkit.org/show_bug.cgi?id=50414
3106
3107         Update for API changes.
3108
3109         * WebKitTestRunner/PlatformWebView.h:
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::createOtherPage):
3112         (WTR::TestController::initialize):
3113         (WTR::TestController::resetStateToConsistentValues):
3114         * WebKitTestRunner/TestController.h:
3115         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3116         (WTR::PlatformWebView::PlatformWebView):
3117         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3118         (WTR::PlatformWebView::PlatformWebView):
3119
3120 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3121
3122         Reviewed by Tony Chang.
3123
3124         new-run-webkit-tests: minor cleanup for multiprocessing work
3125
3126         This change:
3127         * moves worker naming into TestShellThread, eliminating a
3128           parameter to the constructor and putting the responsibility in
3129           the correct place.
3130         * eliminates the _WorkerState() class in message_broker, because
3131           it turns out that state really needs to be in run_webkit_tests
3132         * renames the Broker classes to be module-private.
3133         * fixes a bunch of minor commenting and whitespace issues to
3134           make subsequent patches a bit clearer.
3135         * Adds a Port hook for default_worker_model() so that we can
3136           accomodate the potential for different worker models on
3137           different ports.
3138         * merge in the fix from 50420 for the brokenness introduced in
3139           bug 50367.
3140
3141         This patch depends on bug 50367.
3142
3143         https://bugs.webkit.org/show_bug.cgi?id=50372
3144
3145         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3146         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3147         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3148         * Scripts/webkitpy/layout_tests/port/base.py:
3149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3150         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3151
3152 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
3153
3154         Reviewed by Tony Chang.
3155
3156         This change is a bunch of cleanup / refactoring of the file
3157         below. It moves a bunch of free functions to methods on the
3158         TestShellThread class, and restructures other methods to be
3159         closer to the structure we'll need for the multiprocessing
3160         rewrite.
3161
3162         It also makes the logic of --run-singly a *lot* easier to follow
3163         by nestling all of the separate-thread logic into a single
3164         routine.
3165
3166         There should be no semantic changes in this patch, just cleanup.
3167
3168         https://bugs.webkit.org/show_bug.cgi?id=50367
3169
3170         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3171
3172 2010-12-02  Tony Chang  <tony@chromium.org>
3173
3174         Unreviewed, rolling out r73164.
3175         http://trac.webkit.org/changeset/73164
3176         https://bugs.webkit.org/show_bug.cgi?id=50359
3177
3178         broke debugger tests on win
3179
3180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3181
3182 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3183
3184         Reviewed by Tony Chang.
3185
3186         Rebaseline server: add updating of baselines
3187         https://bugs.webkit.org/show_bug.cgi?id=50305
3188         
3189         Implements updating of baselines, where we copy -actual.* files over
3190         the current -expected.* files. To do this, we need a
3191         _get_actual_result_files method to get test results files and a
3192         _rebaseline_test method to actually do the file copy and SCM operation.
3193         _rebaseline_test logs output into a buffer, this is useful for both
3194         showing result in the UI and for unit tests.
3195         
3196         To make passing around of the various test environment properties
3197         (results directory, filesystem, SCM, etc) easier, add a TestConfig
3198         class for them.
3199         
3200         Moving of existing baselines is not implemented yet, this patch is big
3201         enough as it is.
3202
3203         * Scripts/webkitpy/common/system/filesystem.py:
3204         * Scripts/webkitpy/common/system/filesystem_mock.py:
3205         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3206         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3207         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3208         * Scripts/webkitpy/tool/mocktool.py:
3209
3210 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
3211
3212         Unreviewed build fix after vcproj updates.
3213
3214         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
3215         that WIN_CAIRO is defined for this build.
3216         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
3217         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
3218         (these were previously 'Debug_Cairo' and 'Release_Cairo'
3219
3220 2010-12-02  Sam Weinig  <sam@webkit.org>
3221
3222         Reviewed by Anders Carlsson.
3223
3224         WebKit2 needs API to turn on popup blocking
3225         https://bugs.webkit.org/show_bug.cgi?id=50407
3226
3227         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3228         (TestWebKitAPI::TEST):
3229         * WebKitTestRunner/TestController.cpp:
3230         (WTR::TestController::resetStateToConsistentValues):
3231
3232 2010-12-01  Tony Chang  <tony@chromium.org>
3233
3234         Reviewed by Ojan Vafai.
3235
3236         [chromium] force NRWT to use DRT
3237         https://bugs.webkit.org/show_bug.cgi?id=50359
3238
3239         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3240
3241 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
3242
3243         Reviewed by Xan Lopez.
3244
3245         [GTK] DumpRenderTree has two copies of JavaScriptCore
3246         https://bugs.webkit.org/show_bug.cgi?id=49877
3247
3248         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
3249         LDADD list for DumpRenderTree.
3250
3251 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
3252
3253         Unreviewed: Added myself to list of Committers.
3254
3255         * Scripts/webkitpy/common/config/committers.py:
3256
3257 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
3258
3259         Reviewed by Adam Barth.
3260
3261         build-webkit --chromium always updates DEPS and re-generates project files
3262         https://bugs.webkit.org/show_bug.cgi?id=50340
3263         
3264         Make build-webkit --chromium invoke update-webkit-chromium only when
3265         --update-chromium is passed in, so that we don't add 20 seconds to all
3266         builds.
3267         
3268         Making all invocations update was added with r61883, with the goal of
3269         making EWS bots always update. The bots will switch to using this flag
3270         (as will all other webkit-patch build steps) so nothing should change
3271         for them.
3272
3273         * Scripts/webkitdirs.pm:
3274         * Scripts/webkitpy/common/config/ports.py:
3275         * Scripts/webkitpy/common/config/ports_unittest.py:
3276
3277 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
3278
3279         Reviewed by Tony Chang.
3280
3281         new-run-webkit-tests: add a --dry-run / -n flag
3282         https://bugs.webkit.org/show_bug.cgi?id=50045
3283
3284         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3285         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3286
3287 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3288
3289         Reviewed by Adam Roben.
3290
3291         WinCairo build should not use link-time code generation (LTCG)
3292         https://bugs.webkit.org/show_bug.cgi?id=50353
3293
3294         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3295         * DumpRenderTree/win/DumpRenderTree.vcproj:
3296         * DumpRenderTree/win/ImageDiff.vcproj:
3297         * FindSafari/FindSafari.vcproj:
3298         * MiniBrowser/MiniBrowser.vcproj:
3299         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3300         * WebKitAPITest/WebKitAPITest.vcproj:
3301         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3302         * WebKitTestRunner/win/InjectedBundle.vcproj:
3303         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3304         * WinLauncher/WinLauncher.vcproj:
3305         * record-memory-win/record-memory-win.vcproj:
3306
3307 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3308
3309         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
3310         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
3311         adding the file to the sources list was not enough to force the rebuild.
3312
3313         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
3314         Remove an empty line at the end of this file to force a rebuild.
3315
3316 2010-12-01  Sam Weinig  <sam@webkit.org>
3317
3318         Fix windows build.
3319
3320         * MiniBrowser/win/BrowserView.cpp:
3321         (BrowserView::create):
3322
3323 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
3324
3325         Add missing file to the TestNetscapePlugin sources list after r73057.
3326
3327         * GNUmakefile.am: Add missing file.
3328
3329 2010-12-01  Sam Weinig  <sam@webkit.org>
3330
3331         Reviewed by Anders Carlsson.
3332
3333         Add PageGrouping to WebKit2 API
3334         https://bugs.webkit.org/show_bug.cgi?id=50332
3335
3336         - Update testing harnesses to deal with new PageGroup API.
3337
3338         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
3339         (WKBundleInitialize):
3340         * TestWebKitAPI/InjectedBundleController.cpp:
3341         (TestWebKitAPI::InjectedBundleController::initialize):
3342         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
3343         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
3344         * TestWebKitAPI/InjectedBundleController.h:
3345         * TestWebKitAPI/InjectedBundleTest.h:
3346         (TestWebKitAPI::InjectedBundleTest::initialize):
3347         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
3348         * TestWebKitAPI/PlatformUtilities.cpp:
3349         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3350         * TestWebKitAPI/PlatformUtilities.h:
3351         * TestWebKitAPI/PlatformWebView.h:
3352         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3353         (TestWebKitAPI::TEST):
3354         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3355         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3356         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3357         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3358         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3359         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3360         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3361         (WTR::InjectedBundle::didInitializePageGroup):
3362         (WTR::InjectedBundle::initialize):
3363         (WTR::InjectedBundle::beginTesting):
3364         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3365         (WTR::InjectedBundle::pageGroup):
3366         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3367         (WTR::LayoutTestController::addUserScript):
3368         (WTR::LayoutTestController::addUserStyleSheet):
3369         (WTR::LayoutTestController::setXSSAuditorEnabled):
3370         * WebKitTestRunner/TestController.cpp:
3371         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3372         (WTR::PlatformWebView::PlatformWebView):
3373
3374 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3375
3376         Reviewed by Adam Roben.
3377
3378         vcproj changes can't be applied cleanly by the Windows EWS bot
3379         https://bugs.webkit.org/show_bug.cgi?id=50328
3380
3381         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
3382         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
3383         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
3384         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
3385         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
3386         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
3387         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
3388         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
3389         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
3390         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
3391         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
3392         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
3393         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
3394         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
3395         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
3396         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
3397         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
3398         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
3399         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
3400         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
3401         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
3402         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
3403         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
3404         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
3405         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
3406         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
3407         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
3408         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
3409         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
3410         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
3411         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
3412         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
3413         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
3414         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
3415         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
3416         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
3417         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
3418         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
3419         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
3420         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
3421         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
3422         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
3423         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
3424         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
3425         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
3426
3427 2010-12-01  Anders Carlsson  <andersca@apple.com>
3428
3429         Reviewed by Darin Adler.
3430
3431         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
3432         https://bugs.webkit.org/show_bug.cgi?id=50336
3433
3434         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3435         Add new test.
3436
3437         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3438         (PluginTest::NPP_New):
3439         Add default implementation/
3440
3441         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3442         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
3443         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
3444         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
3445         Get the user agent.
3446
3447         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3448         (NPP_New):
3449         Call PluginTest::NPP_New.
3450
3451         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3452         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3453         Add new files.
3454
3455         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3456         (webkit_test_plugin_new_instance):
3457         Call PluginTest::NPP_New.
3458
3459 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
3460
3461         [wx] Build fixes after recent trunk changes.
3462
3463         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3464         (LayoutTestController::findString):
3465         * wx/build/settings.py:
3466
3467 2010-12-01  Dan Bernstein  <mitz@apple.com>
3468
3469         Reviewed by Darin Adler.
3470
3471         WebKitTestRunner needs layoutTestController.findString
3472         https://bugs.webkit.org/show_bug.cgi?id=50238
3473
3474         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
3475         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3476         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
3477         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
3478
3479 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
3480
3481         Try using svn:eol-style native on a vcproj file.
3482
3483         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
3484
3485 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
3486
3487         Reviewed by Adam Roben.
3488
3489         [WINCE] Add WinCELauncher
3490         https://bugs.webkit.org/show_bug.cgi?id=50217
3491
3492         * WinCELauncher/main.cpp: Added.
3493
3494 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
3495
3496         Reviewed by Kenneth Rohde Christiansen.
3497
3498         [Qt] Implement layoutTestController.findString
3499         https://bugs.webkit.org/show_bug.cgi?id=50236
3500
3501         Add the missing function to the LayoutTestController.
3502
3503         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3504         (LayoutTestController::findString):
3505         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3506
3507 2010-11-30  Tony Chang  <tony@chromium.org>
3508
3509         Reviewed by Adam Barth.
3510
3511         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
3512         https://bugs.webkit.org/show_bug.cgi?id=49036
3513
3514         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
3515             for CppVariants.
3516         (LayoutTestController::cppVariantToBool):
3517         (LayoutTestController::cppVariantToInt32):
3518         (LayoutTestController::setDatabaseQuota):
3519         (LayoutTestController::evaluateInWebInspector):
3520         (LayoutTestController::setMockGeolocationError):
3521
3522 2010-11-30  Eric Seidel  <eric@webkit.org>
3523
3524         Reviewed by Tony Chang.
3525
3526         update-webkit should call git fetch before git svn rebase
3527         https://bugs.webkit.org/show_bug.cgi?id=50273
3528
3529         After discussion on webkit-dev, we've decided to move the "default"
3530         git setup to pulling updates from git.webkit.org in preference
3531         to rebuilding the local svn index using git svn fetch every time.
3532
3533         This change should have no effect on people using the "old" git setup
3534         and should dramatically increase the speed of updates for those using
3535         the "new" git setup along with update-webkit.  I'm about to move the
3536         EWS and other queues over to this setup once this lands.
3537
3538         * Scripts/update-webkit:
3539
3540 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
3541
3542         Reviewed by Xan Lopez.
3543
3544         GTK: AX: implement press in DRT
3545         https://bugs.webkit.org/show_bug.cgi?id=36146
3546
3547         Implement AccessibilityUIElement::press() for GTK.
3548
3549         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3550         (AccessibilityUIElement::press): Implemented.
3551
3552 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
3553
3554         Reviewed by Tony Chang.
3555
3556         config.webkit_base_dir returns a path with a trailing slash
3557         https://bugs.webkit.org/show_bug.cgi?id=50197
3558         
3559         config.webkit_base_dir() should return a path without a trailing slash,
3560         like all the other methods that return paths.
3561         
3562         Undoes MockFileSytem changes by r72640, since they're no longer
3563         necessary for GetBaselinesTest to pass.
3564
3565         * Scripts/webkitpy/common/system/filesystem_mock.py:
3566         * Scripts/webkitpy/layout_tests/port/base.py:
3567         * Scripts/webkitpy/layout_tests/port/config.py:
3568         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3569
3570 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
3571
3572         Reviewed by Tony Chang.
3573
3574         Rebaseline server: baseline display tweaks
3575         https://bugs.webkit.org/show_bug.cgi?id=50207
3576         
3577         Determine which baselines were used when running the tests and highlight
3578         them in the UI. Sort platform names alphabetically.
3579         
3580         Also makes the server URL be launched in the user's browser
3581         automatically.
3582
3583         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3584         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3585         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3586         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3587         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
3588
3589 2010-11-30  Dan Bernstein  <mitz@apple.com>
3590
3591         Reviewed by Anders Carlsson.
3592
3593         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
3594         https://bugs.webkit.org/show_bug.cgi?id=50238
3595
3596         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3597         (WTR::LayoutTestController::findString): Added.
3598         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3599
3600 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
3601
3602         Reviewed by Adam Roben.
3603
3604         All projects on Windows should use cmd files for build events
3605         https://bugs.webkit.org/show_bug.cgi?id=50213
3606
3607         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3608         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
3609         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
3610         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3611         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
3612         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
3613         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3614         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
3615         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
3616         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
3617         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3618         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
3619         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
3620         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
3621         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3622         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
3623         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
3624         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3625         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
3626         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
3627         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3628         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3629         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
3630         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
3631         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
3632         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
3633         * WinLauncher/WinLauncherCommon.vsprops:
3634         * WinLauncher/WinLauncherPostBuild.cmd: Added.
3635         * WinLauncher/WinLauncherPreBuild.cmd: Added.