015a4255abc3edec0f8b725328a092ed748cbc24
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
2
3         Unreviewed, update the triggerable name for 'sierra-release-perf-tests'
4
5         * BuildSlaveSupport/build.webkit.org-config/config.json:
6
7 2018-01-18  Dan Bernstein  <mitz@apple.com>
8
9         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
10         https://bugs.webkit.org/show_bug.cgi?id=181803
11
12         Reviewed by Tim Horton.
13
14         * DumpRenderTree/mac/Configurations/Base.xcconfig: Updated.
15         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig: Ditto.
16         * ImageDiff/cg/Configurations/Base.xcconfig: Ditto.
17         * ImageDiff/cg/Configurations/DebugRelease.xcconfig: Ditto.
18         * MiniBrowser/Configurations/Base.xcconfig: Ditto.
19         * MiniBrowser/Configurations/DebugRelease.xcconfig: Ditto.
20         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
21         * TestWebKitAPI/Configurations/DebugRelease.xcconfig: Ditto.
22         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Adopted macOSTargetConditionals
23           helpers.
24         * TestWebKitAPI/Configurations/macOSTargetConditionals.xcconfig: Added. Defines helper build
25           settings useful for defining settings that depend on the target macOS version.
26         * WebKitTestRunner/Configurations/Base.xcconfig: Updated.
27         * WebKitTestRunner/Configurations/DebugRelease.xcconfig: Updated.
28
29 2018-01-18  Ling Ho  <lingcherd_ho@apple.com>
30
31         Remove Opensource El Capitan queues from buildbot
32         https://bugs.webkit.org/show_bug.cgi?id=181712
33
34         Reviewed by Aakash Jain.
35
36         * BuildSlaveSupport/build.webkit.org-config/config.json:
37         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
38         (WebKitBuildbot):
39         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
40
41 2018-01-18  Chris Dumez  <cdumez@apple.com>
42
43         Service Workers restored from persistent storage have 'redundant' state
44         https://bugs.webkit.org/show_bug.cgi?id=181749
45         <rdar://problem/36556486>
46
47         Reviewed by Youenn Fablet.
48
49         Add API test coverage.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
52         (-[SWMessageHandlerForFetchTest userContentController:didReceiveScriptMessage:]):
53
54 2018-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
55
56         [GTK] AX: Two layout tests crash with error 'g_strstr_len: assertion 'haystack != NULL' failed' in Accessibility::UIElement::url
57         https://bugs.webkit.org/show_bug.cgi?id=176796
58
59         Reviewed by Chris Fleizach.
60
61         Add sanity check that we have a URL before calling g_strstr_len().
62
63         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
64         (WTR::AccessibilityUIElement::url):
65
66 2018-01-18  Ryan Haddad  <ryanhaddad@apple.com>
67
68         Add triggers for Sierra test262 and perf queues
69         https://bugs.webkit.org/show_bug.cgi?id=181799
70
71         Reviewed by Aakash Jain.
72
73         * BuildSlaveSupport/build.webkit.org-config/config.json:
74
75 2018-01-18  Wenson Hsieh  <wenson_hsieh@apple.com>
76
77         [iOS] Specify -[NSURL _title] for the associated URL when copying an image element
78         https://bugs.webkit.org/show_bug.cgi?id=181783
79         <rdar://problem/35785445>
80
81         Reviewed by Ryosuke Niwa.
82
83         Augments an existing API test and adds a new test to make sure that the resulting NSItemProvider's NSURL when
84         copying an image contains a relevant title.
85
86         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
87         (TestWebKitAPI::TEST):
88         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
89         * TestWebKitAPI/ios/UIKitSPI.h:
90
91 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
92
93         WebDriver: ignore the driver in selenium test names when getting expectations
94         https://bugs.webkit.org/show_bug.cgi?id=181738
95
96         Reviewed by Carlos Alberto Lopez Perez.
97
98         In selenium tests, the driver is added as a parameter to every test which results in tests names like
99         foo[DriverName] or foo[DriverName-param2] in case of tests using more parameters. We don't want to include the
100         driver name in the test expectations file, so we need to remove it when querying the expectations.
101
102         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
103         (TestExpectationsMarker.__init__): Save the param to ignore.
104         (TestExpectationsMarker._item_name): Return the name of the test without the para to ignore.
105         (TestExpectationsMarker.pytest_collection_modifyitems): Use _item_name().
106         (run): Pass param to ignore to TestExpectationsMarker().
107         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
108         (WebDriverSeleniumExecutor.__init__): Save the driver name.
109         (WebDriverSeleniumExecutor.run): Pass the driver name as param to ignore.
110
111 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
112
113         [GTK][WPE] Show unit tests unexpectedly passing in the bots
114         https://bugs.webkit.org/show_bug.cgi?id=181726
115
116         Reviewed by Michael Catanzaro.
117
118         Now that we have the info, let's show it also in the bots.
119
120         * BuildSlaveSupport/build.webkit.org-config/steps.py:
121         (RunGLibAPITests.commandComplete):
122
123 2018-01-17  Ling Ho  <lingcherd_ho@apple.com>
124
125         Fix broken unittest after r227048
126         https://bugs.webkit.org/show_bug.cgi?id=181760
127
128         Reviewed by Aakash Jain.
129
130
131 2018-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
132
133         WEBKIT_FRAMEWORK should not modify file-global include directories
134         https://bugs.webkit.org/show_bug.cgi?id=181656
135
136         Reviewed by Konstantin Tokarev.
137
138         * TestWebKitAPI/PlatformWPE.cmake:
139         * TestWebKitAPI/glib/CMakeLists.txt:
140
141 2018-01-17  Alicia Boya García  <aboya@igalia.com>
142
143         Unreviewed, mark Alicia as committer in contributors.json
144
145         * Scripts/webkitpy/common/config/contributors.json:
146
147 2018-01-17  Youenn Fablet  <youenn@apple.com>
148
149         Put fetch Request.keepalive behind a runtime flag
150         https://bugs.webkit.org/show_bug.cgi?id=181592
151
152         Reviewed by Chris Dumez.
153
154         * DumpRenderTree/mac/DumpRenderTree.mm:
155         (enableExperimentalFeatures):
156         * DumpRenderTree/win/DumpRenderTree.cpp:
157         (enableExperimentalFeatures):
158         * WebKitTestRunner/TestController.cpp:
159         (WTR::TestController::resetPreferencesToConsistentValues):
160
161 2018-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
162
163         Add injected bundle SPI to replace subresource URLs when dropping or pasting rich content
164         https://bugs.webkit.org/show_bug.cgi?id=181637
165         <rdar://problem/36508471>
166
167         Reviewed by Tim Horton.
168
169         Add 2 new API tests to exercise injected bundle SPI for supplying replacement URLs when pasting an image, and an
170         attributed string containing multiple NSTextAttachments. See WebKit and WebCore ChangeLogs for more detail.
171
172         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
173         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
174         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]):
175
176         Implement the new Objective-C bundle SPI to look up the incoming MIME type in the dictionary supplied via the
177         "MIMETypeToReplacementURLMap" bundle initialization parameter, and return it.
178
179         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
180         (webViewForTestingAttachments):
181         (-[TestWKWebView tagsInBody]):
182         (-[TestWKWebView expectElementTagsInOrder:]):
183         (-[TestWKWebView expectElementTag:toComeBefore:]):
184
185         Add a test helper to check that the given list of element tags appears in the document body. Also, reimplement
186         the existing -expectElementTag:toComeBefore: as a special case of -expectElementTagsInOrder:.
187
188         (TestWebKitAPI::TEST):
189         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
190         (WTR::InjectedBundlePage::InjectedBundlePage):
191
192 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
193
194         WebDriver: add support for test expectations
195         https://bugs.webkit.org/show_bug.cgi?id=180420
196
197         Reviewed by Carlos Alberto Lopez Perez.
198
199         Add support for parsing test expectations from a JSON file and mark tests on collection accordingly.
200
201         * Scripts/run-webdriver-tests: Get the retval from process_results().
202         * Scripts/webkitpy/thirdparty/__init__.py:
203         (AutoinstallImportHook._install_pytest): Install also py because pytest needs it.
204         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
205         (TestExpectationsMarker): Plugin to mark tests based on given expectations.
206         (TestExpectationsMarker.__init__): Initialize expectations.
207         (TestExpectationsMarker.pytest_collection_modifyitems): Mark tests if needed,
208         (run): Create and use TestExpectationsMarker plugin.
209         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
210         (WebDriverSeleniumExecutor.run): Pass expectations to pytest_runner.
211         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:
212         (WebDriverTestRunner.__init__): Create a TestExpectations and pass it to the runners.
213         (WebDriverTestRunner.run): Do not count results here.
214         (WebDriverTestRunner.process_results): Rename print_results() as process_results() since it now returns the
215         amount of failures. Printing the test summary while processing results will be made optional in a follow up
216         patch.
217         (WebDriverTestRunner.process_results.report): Return the amount of failures.
218         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
219         (WebDriverTestRunnerSelenium.__init__): Initialize _expectations.
220         (WebDriverTestRunnerSelenium.collect_tests): Do not include skipped tests.
221         (WebDriverTestRunnerSelenium.run): Stop returning the tests count.
222         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
223         (WebDriverTestRunnerW3C.__init__): Initialize _expectations.
224         (WebDriverTestRunnerW3C.collect_tests): Do not include skipped tests.
225         (WebDriverTestRunnerW3C._scan_directory): Ditto.
226         (WebDriverTestRunnerW3C.run): Stop returning the tests count.
227         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_executor.py:
228         (WebDriverW3CExecutor.run): Pass expectations to pytest_runner.
229
230 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
231
232         Unreviewed WPE gardening. Mark some known unit test failures.
233
234         * TestWebKitAPI/glib/TestExpectations.json:
235
236 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
237
238         [GTK][WPE] Use the same subtest names in GTK and WPE unit tests
239         https://bugs.webkit.org/show_bug.cgi?id=181724
240
241         Reviewed by Philippe Normand.
242
243         We currently use /webkit2/foo/bar for GTK and /wpe/foo/bar for WPE. Many of the tests are common, so there's no
244         reason to use different names. This way we can refer to the same test names for both and we can share the
245         expectations in the TestExpectations.json file.
246
247         * TestWebKitAPI/glib/TestExpectations.json:
248         * TestWebKitAPI/glib/WebKitGLib/TestMain.h: Use /webkit/foo/bar in GTK and WPE.
249
250 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
251
252         Unreviewed. Increase the slow timeout of GTK and WPE unit tests.
253
254         We are using now a lower default timeout, so multiplying by 5 is no longer enough for some of the WTF
255         tests. Multiply by 10 so that we get the same slow timeout as before, 50.
256
257         * glib/api_test_runner.py:
258         (TestRunner._run_test_glib):
259         (TestRunner._run_google_test):
260
261 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
262
263         [GTK] Duplicated symbols in libjavascriptcoregtk and libwebkit2gtk can cause crashes in production builds
264         https://bugs.webkit.org/show_bug.cgi?id=179914
265
266         Reviewed by Žan Doberšek.
267
268         Add two scripts to be run by dist-check step when releasing. One is to detect symbols duplicated in
269         libjavascriptcoregtk and libwebkit2gtk that should be included to the version script. The other one is to ensure
270         all symbols listed in the script are present in the library.
271
272         * Scripts/check-for-global-bss-symbols-in-webkigtk-libs: Added.
273         (bss_symbols):
274         * Scripts/check-for-invalid-symbols-in-version-script: Added.
275         (script_symbols):
276         * Scripts/make-dist:
277         (Distcheck.build):
278         (Distcheck):
279         (Distcheck.check_symbols):
280         (Distcheck.check):
281
282 2018-01-17  Carlos Garcia Campos  <cgarcia@igalia.com>
283
284         [GTK][WPE] Propagate the parameters when restarting glib api tests after a crash
285         https://bugs.webkit.org/show_bug.cgi?id=181722
286
287         Reviewed by Žan Doberšek.
288
289         I forgot to pass the parameters to run() when restarting.
290
291         * glib/glib_test_runner.py:
292         (GLibTestRunner.run):
293
294 2018-01-16  Fujii Hironori  <Hironori.Fujii@sony.com>
295
296         [CMake] Remove WebCoreDerivedSources library target
297         https://bugs.webkit.org/show_bug.cgi?id=181664
298
299         Reviewed by Carlos Garcia Campos.
300
301         * TestWebKitAPI/PlatformWPE.cmake: Do not link WebCoreDerivedSources.
302         * TestWebKitAPI/PlatformWin.cmake: Ditto.
303
304 2018-01-16  Ling Ho  <lingcherd_ho@apple.com>
305
306         Move Debug Test262, Release Test262 and Performance queues to Sierra
307         https://bugs.webkit.org/show_bug.cgi?id=181692
308
309         Unreviewed
310
311 2018-01-16  Zach Li  <zachli@apple.com>
312
313         Add pop-up policy support in website policies.
314         https://bugs.webkit.org/show_bug.cgi?id=181544.
315         rdar://problem/30521400.
316
317         Reviewed by Alex Christensen.
318
319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
320         Added pop-up-check.html.
321
322         * TestWebKitAPI/Tests/WebKit/pop-up-check.html: Added.
323
324         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
325         (-[PopUpPoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
326         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
327         (-[PopUpPoliciesDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
328         (TEST):
329
330 2018-01-16  Wenson Hsieh  <wenson_hsieh@apple.com>
331
332         [Attachment Support] Provide the `src` of an attachment to the UI delegate when an attachment is inserted
333         https://bugs.webkit.org/show_bug.cgi?id=181638
334         <rdar://problem/36508702>
335
336         Reviewed by Dan Bernstein.
337
338         Tweak an existing API test to check that the `src` of an attachment element inserted via script matches the
339         `source` provided to the UI delegate via -[WKUIDelegate _webView:didInsertAttachment:withSource:].
340
341         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
342         (-[AttachmentUpdateObserver init]):
343         (-[AttachmentUpdateObserver sourceForIdentifier:]):
344         (-[AttachmentUpdateObserver _webView:didInsertAttachment:withSource:]):
345         (TestWebKitAPI::ObserveAttachmentUpdatesForScope::expectSourceForIdentifier):
346         (TestWebKitAPI::TEST):
347         (-[AttachmentUpdateObserver _webView:didInsertAttachment:]): Deleted.
348
349 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
350
351         Unreviewed. Fix GTK unit tests execution in the bots after r226967.
352
353         I forgot to pass the environment to the GLibTestRunner and Xvfb was not used in the bots.
354
355         * glib/api_test_runner.py:
356         (TestRunner._run_test_glib): Pass env to GLibTestRunner.
357         * glib/glib_test_runner.py:
358         (GLibTestRunner.run): Use given env.
359
360 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
361
362         [GTK][WPE] Stop passing --verbose to run-api-tests from the bots
363         https://bugs.webkit.org/show_bug.cgi?id=181676
364
365         Reviewed by Carlos Alberto Lopez Perez.
366
367         The option was removed in r226967.
368
369         * BuildSlaveSupport/build.webkit.org-config/steps.py:
370         (RunGtkAPITests):
371         (RunWPEAPITests):
372
373 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
374
375         Unreviewed. Temporarily bring back --verbose option of api_test_runner.py.
376
377         The bots are still passing that option and the step is failing because it was removed in r226967.
378
379         * glib/api_test_runner.py:
380         (add_options):
381
382 2018-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         [GTK][WPE] Improve the way glib tests are run
385         https://bugs.webkit.org/show_bug.cgi?id=181674
386
387         Reviewed by Žan Doberšek.
388
389         Stop using gtester external program and use our own tester from python directly. This way we no longer need to
390         parse the tests output to get the results which is causing problems in WPE bot. We can now differentiate between
391         tests failing due to an expected assert in the test and unexpected crashes.
392         This also fixes a bug in previous code where we failed to properly detect tests timing out, because gtester was
393         not showing the subtest name in stdout in case of timeouts.
394         I've lowered the default timeout from 10 to 5, since we are now properly handling the timeout for every test
395         case. I've also removed the verbose option, since it was only used by gtester and we now always show the result
396         of every test case.
397
398         * glib/api_test_runner.py:
399         (TestRunner._run_test_glib): Use GLibTestRunner.
400         (TestRunner._run_google_test): Wrote tests timing out to stdout too.
401         (add_options):
402         * glib/glib_test_runner.py: Added.
403         (TestTimeout):
404         (Message):
405         (Message.__init__):
406         (Message.create):
407         (Message.create.read_unsigned):
408         (Message.create.read_double):
409         (Message.create.read_string):
410         (GLibTestRunner):
411         (GLibTestRunner.__init__):
412         (GLibTestRunner._process_data):
413         (GLibTestRunner._process_message):
414         (GLibTestRunner._read_from_pipe):
415         (GLibTestRunner._read_from_stderr):
416         (GLibTestRunner._start_timeout):
417         (GLibTestRunner._start_timeout._alarm_handler):
418         (GLibTestRunner._stop_timeout):
419         (GLibTestRunner._subtest_start):
420         (GLibTestRunner._subtest_message):
421         (GLibTestRunner._subtest_stderr):
422         (GLibTestRunner._subtest_end):
423         (GLibTestRunner.run):
424
425 2018-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
426
427         Unreviewed, add Thibault to contributors.json
428
429         It's a bit weird to add someone here before their first contribution, but this affects
430         Bugzilla autocomplete, and that is serious business.
431
432         * Scripts/webkitpy/common/config/contributors.json:
433
434 2018-01-15  JF Bastien  <jfbastien@apple.com>
435
436         Remove makePoisonedUnique
437         https://bugs.webkit.org/show_bug.cgi?id=181630
438         <rdar://problem/36498623>
439
440         Reviewed by Mark Lam.
441
442         Update tests.
443
444         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
445         (TestWebKitAPI::TEST):
446         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
447         (TestWebKitAPI::TEST):
448
449 2018-01-15  Adrian Perez de Castro  <aperez@igalia.com>
450
451         [GTK][JHBuild] Tools/gtk/install-dependencies: Package libxfont does not exist anymore in Arch Linux
452         https://bugs.webkit.org/show_bug.cgi?id=181476
453
454         Reviewed by Michael Catanzaro.
455
456         Update to xorg-server 1.19.6 which depends on libxfont2, and change
457         the lists of packages to install libxfont2-devel (or equivalent).
458
459         * gtk/install-dependencies:
460         * gtk/jhbuild.modules:
461
462 2018-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         [GTK][WPE] Add support for unit test expectations
465         https://bugs.webkit.org/show_bug.cgi?id=181589
466
467         Reviewed by Michael Catanzaro.
468
469         We currently have a way to skip tests by annotating them in the api test runner script. The main problem of this
470         approach is that we skip tests when they fail in the bots and we never notice if they stop failing, keeping the
471         tests skipped forever. This is indeed the case of several WebKit2 C API tests. Annotating skipped tests in the
472         script itself is not a good idea either.
473
474         This patch adds a generic TestExpectations class for simple tests based on tests with subtests, like our unit
475         tests, but also WebDriver tests. It parses a json file with the tests and subtests expectations and provides
476         convenient methods to query them.
477
478         * Scripts/run-gtk-tests:
479         (GtkTestRunner): Remove all Skipped and Slow tests marked here.
480         * Scripts/run-wpe-tests:
481         (WPETestRunner): Ditto.
482         * Scripts/webkitpy/common/test_expectations.py: Added.
483         (TestExpectations):
484         (TestExpectations.__init__):
485         (TestExpectations._port_name_for_expected):
486         (TestExpectations._expected_value):
487         (TestExpectations.skipped_tests):
488         (TestExpectations.skipped_subtests):
489         (TestExpectations._expectation_value):
490         (TestExpectations.is_slow):
491         (TestExpectations.get_expectation):
492         * Scripts/webkitpy/common/test_expectations_unittest.py: Added.
493         (MockTestExpectations):
494         (MockTestExpectations.__init__):
495         (MockTestExpectations.is_skip):
496         (ExpectationsTest):
497         (assert_exp):
498         (assert_not_exp):
499         (assert_bad_exp):
500         (assert_skip):
501         (test_basic):
502         (test_skip):
503         (test_flaky):
504         (test_build_type):
505         * TestWebKitAPI/glib/TestExpectations.json: Added.
506         * glib/api_test_runner.py:
507         (TestRunner): Remove SkippedTest implementation.
508         (TestRunner.__init__): Create a TestExpectations.
509         (TestRunner._test_cases_to_skip): Use TestExpectations to check skipped tests.
510         (TestRunner._should_run_test_program): Ditto.
511         (TestRunner._run_test_glib): Use TestExpectations to check if test suite is slow.
512         (TestRunner._run_test_glib.parse_line.set_test_result): Register also tests passing.
513         (TestRunner._run_google_test): Use TestExpectations to check if test cases is slow and register tests passing.
514         (TestRunner.run_tests): Check if actual result is the expected one and register also unexpected passes.
515         (TestRunner.run_tests.report): Helper to write report to stdout.
516
517 2018-01-13  Mark Lam  <mark.lam@apple.com>
518
519         Replace all use of ConstExprPoisoned with Poisoned.
520         https://bugs.webkit.org/show_bug.cgi?id=181542
521         <rdar://problem/36442138>
522
523         Reviewed by JF Bastien.
524
525         1. Converted tests to using new uintptr_t& poison type.
526         2. Added tests for Poisoned comparison operators.
527
528         * TestWebKitAPI/CMakeLists.txt:
529         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
530         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp: Removed.
531         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
532         (TestWebKitAPI::TEST):
533         (TestWebKitAPI::initializeTestPoison): Deleted.
534         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
535         (TestWebKitAPI::TEST):
536         (TestWebKitAPI::passWithRef):
537         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp:
538         (TestWebKitAPI::TEST):
539         (TestWebKitAPI::f1):
540         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
541         (TestWebKitAPI::TEST):
542         (TestWebKitAPI::poisonedPtrFoo):
543         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:
544         (TestWebKitAPI::TEST):
545         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
546         (TestWebKitAPI::TEST):
547
548 2018-01-13  David Kilzer  <ddkilzer@apple.com>
549
550         check-webkit-style: false positive for [whitespace/braces] with os_log format string
551         <https://webkit.org/b/181606>
552
553         Reviewed by Darin Adler.
554
555         * Scripts/webkitpy/style/checkers/cpp.py:
556         (check_spacing): Modify regular expression to ignore
557         os_log format strings like '%{public}'.
558         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
559         (CppStyleTest.test_spacing_before_braces): Add os_log
560         format string test.
561
562 2018-01-12  Wenson Hsieh  <wenson_hsieh@apple.com>
563
564         [macOS] API tests ChangeAttachmentDataUpdatesWithInPlaceDisplay and InPlaceVideoAttachmentInsertionWithinList are failing
565         https://bugs.webkit.org/show_bug.cgi?id=181626
566
567         Reviewed by Joseph Pecoraro.
568
569         Make the web view for WKAttachmentTests slightly bigger to avoid size clamping behavior introduced in r226915.
570         Additionally, write a new API test covering the change in r226915.
571
572         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
573         (webViewForTestingAttachments):
574         (TestWebKitAPI::TEST):
575
576 2018-01-12  Alex Christensen  <achristensen@webkit.org>
577
578         History state should be updated during client redirects with asynchronous policy decisions
579         https://bugs.webkit.org/show_bug.cgi?id=181358
580         <rdar://problem/35547689>
581
582         Reviewed by Andy Estes.
583
584         * TestWebKitAPI/Tests/WebKit/WKBackForwardList.mm:
585         (-[AsyncPolicyDecisionDelegate webView:didFinishNavigation:]):
586         (-[AsyncPolicyDecisionDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
587         (TEST):
588
589 2018-01-12  Jonathan Bedard  <jbedard@apple.com>
590
591         webkitpy: Refactor simulator code (Part 4)
592         https://bugs.webkit.org/show_bug.cgi?id=180555
593         <rdar://problem/36131381>
594
595         Reviewed by Aakash Jain.
596
597         Move new_simulated_device.py to simulated_device.py.
598
599         * Scripts/webkitpy/port/ios_simulator.py: Update import statement.
600         * Scripts/webkitpy/xcode/new_simulated_device.py: Removed.
601         * Scripts/webkitpy/xcode/new_simulated_device_unittest.py: Removed.
602         * Scripts/webkitpy/xcode/simulated_device.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device.py.
603         * Scripts/webkitpy/xcode/simulated_device_unittest.py: Copied from Tools/Scripts/webkitpy/xcode/new_simulated_device_unittest.py.
604
605 2018-01-12  Alex Christensen  <achristensen@webkit.org>
606
607         REGRESSION (r226818): API test WebKitLegacy.LoadInvalidURLRequest is failing
608         https://bugs.webkit.org/show_bug.cgi?id=181595
609
610         This test was testing behavior of an invalid URL that WebCore parses but NSURL does not.
611         It was using example.com<> but after r226479 < and > are considered invalid by WebCore.
612         I change the < and > to $ to make this test pass and continue to test what it used to.
613
614         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.html:
615         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
616         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
617
618 2018-01-11  Keith Miller  <keith_miller@apple.com>
619
620         Rename ENABLE_ASYNC_ITERATION to ENABLE_JS_ASYNC_ITERATION
621         https://bugs.webkit.org/show_bug.cgi?id=181573
622
623         Reviewed by Simon Fraser.
624
625         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
626
627 2018-01-11  Jiewen Tan  <jiewen_tan@apple.com>
628
629         [WebAuthN] Import a CBOR coder from Chromium
630         https://bugs.webkit.org/show_bug.cgi?id=181522
631         <rdar://problem/36055729>
632
633         Reviewed by Brent Fulgham.
634
635         This patch also imports all unit tests into our API tests to ensure all
636         workarounds and modification against the original codebase doesn't change
637         any original functionalities.
638
639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
640         * TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp: Added.
641         (TestWebKitAPI::TEST):
642         * TestWebKitAPI/Tests/WebCore/CBORValueTest.cpp: Added.
643         (TestWebKitAPI::TEST):
644         * TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp: Added.
645         (TestWebKitAPI::eq):
646         Workarounds applied.
647         (TestWebKitAPI::TEST):
648
649 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
650
651         webkitpy: Use partially disambiguated type in SimulatedDeviceManager._disambiguate_device_type
652         https://bugs.webkit.org/show_bug.cgi?id=181538
653         <rdar://problem/36440580>
654
655         Reviewed by Aakash Jain.
656
657         When disambiguating a device type, it is possible that the provided device type is sufficiently
658         ambiguous that the comparisons against complete device types without a disambiguated hardware_family
659         will result in a failure to disambiguate the type.
660
661         * Scripts/webkitpy/xcode/new_simulated_device.py:
662         (SimulatedDeviceManager._disambiguate_device_type):
663
664 2018-01-11  Brent Fulgham  <bfulgham@apple.com>
665
666         REGRESSION(r219530): ResourceLoadStatisticsPersistentStorage should be read-only in ephemeral sessions
667         https://bugs.webkit.org/show_bug.cgi?id=181136
668         <rdar://problem/36116604>
669
670         Reviewed by Chris Dumez.
671
672         Add a new API test to confirm that ResourceLoadStatistics can be turned on safely for ephemeral
673         browsing sessions.
674
675         * Scripts/run-gtk-tests:
676         (GtkTestRunner): Unskip test now that it passes.
677         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
678         (TEST): Add new WebsiteDataStoreEphemeral test.
679
680 2018-01-11  Ryan Haddad  <ryanhaddad@apple.com>
681
682         Unreviewed, rolling out r226816.
683
684         This change broke LayoutTests on the bots.
685
686         Reverted changeset:
687
688         "run-webkit-tests fails when there is a curly brace in Xcode
689         build output"
690         https://bugs.webkit.org/show_bug.cgi?id=181254
691         https://trac.webkit.org/changeset/226816
692
693 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
694
695         webkitpy: Fix flakey webserver tests
696         https://bugs.webkit.org/show_bug.cgi?id=181555
697         <rdar://problem/36448273>
698
699         Reviewed by Aakash Jain.
700
701         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
702         (LayoutTestRunnerTests.test_servers_started): Add and bind custom checks to
703         determine if a specific server is running.
704
705 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
706
707         Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
708         https://bugs.webkit.org/show_bug.cgi?id=181561
709         <rdar://problem/36452652>
710
711         Reviewed by Aakash Jain.
712
713         BeautifulSoup.find may return None, this case should be gracefully handled.
714
715         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
716         (BugzillaQueries._parse_result_count):
717         (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
718
719 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
720
721         run-webkit-tests fails when there is a curly brace in Xcode build output
722         https://bugs.webkit.org/show_bug.cgi?id=181254
723
724         Reviewed by Daniel Bates.
725
726         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
727         (MeteredStream.write):
728
729 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
730
731         webkitpy: Reimplement simulator code (Part 3)
732         https://bugs.webkit.org/show_bug.cgi?id=180555
733         <rdar://problem/36131381>
734
735         Reviewed by Aakash Jain.
736
737         Remove old simulator code.
738
739         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
740         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
741         * Scripts/webkitpy/xcode/simulator.py: Removed.
742         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
743
744 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
745
746         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
747         https://bugs.webkit.org/show_bug.cgi?id=181337
748         <rdar://problem/36324813>
749
750         Reviewed by Tim Horton.
751
752         Add 3 new API tests for attachment element dragging.
753
754         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
755         (-[TestWKWebView expectElementTag:toComeBefore:]):
756         (-[NSItemProvider expectType:withData:]):
757         (TestWebKitAPI::TEST):
758
759 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
760
761         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
762         https://bugs.webkit.org/show_bug.cgi?id=179621
763         <rdar://problem/35589585>
764
765         Unreviewed infrastructure fix.
766
767         * Scripts/webkitpy/port/mac.py:
768         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
769         list if we are the VERSION_MAX, which usually corresponds with future.
770
771 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
772
773         CodeBlocks should be in IsoSubspaces
774         https://bugs.webkit.org/show_bug.cgi?id=180884
775
776         Reviewed by Saam Barati.
777         
778         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
779         shouldn't take a long time due to benchmarks we don't optimize for.
780         
781         * Scripts/run-jsc-benchmarks:
782
783 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
784
785         Test gardening for GTK.
786         https://bugs.webkit.org/show_bug.cgi?id=181477
787
788         Unreviewed test gardening.
789
790         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
791         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
792
793 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
794
795         Add the new JSCOnly bot to the scheduler.
796         https://bugs.webkit.org/show_bug.cgi?id=181487
797
798         Unreviewed follow-up patch after r226729
799
800         On r226729 I missed to add the new JSCOnly bot the default scheduler.
801         This is needed to make the bot automatically pick each commit for testing.
802
803         * BuildSlaveSupport/build.webkit.org-config/config.json:
804
805 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
806
807         [Attachment Support] Support dragging attachment elements out as files on iOS
808         https://bugs.webkit.org/show_bug.cgi?id=181199
809         <rdar://problem/36299316>
810
811         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
812
813         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
814         attachment API tests.
815
816         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
817         (-[NSItemProvider expectType:withData:]):
818         (TestWebKitAPI::TEST):
819
820         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
821         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
822         -expectType:withData: helper to inspect the item providers created from the drag source.
823
824         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
825         (TestWebKitAPI::TEST):
826         * TestWebKitAPI/ios/DataInteractionSimulator.h:
827         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
828         (-[MockDragSession localContext]):
829         (-[MockDragSession setLocalContext:]):
830         (-[DataInteractionSimulator _resetSimulatedState]):
831         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
832         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
833         (-[DataInteractionSimulator _advanceProgress]):
834         (-[DataInteractionSimulator endDataTransfer]):
835
836         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
837         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
838         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
839         MockDragSession to hold on to a localContext.
840
841 2018-01-11  Ali Juma  <ajuma@chromium.org>
842
843         Unreviewed. Add Ali Juma as contributor
844
845         * Scripts/webkitpy/common/config/contributors.json:
846
847 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
848
849         Unreviewed. Update Selenium WebDriver imported tests.
850
851         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
852         environment variables.
853
854         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
855         (collect): Reorder the arguments to make pytest happy.
856         (run): Ditto.
857         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
858         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
859
860 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
861
862         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
863         https://bugs.webkit.org/show_bug.cgi?id=181492
864         <rdar://problem/36359679>
865
866         Reviewed by Alexey Proskuryakov. 
867
868 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
869
870         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
871         https://bugs.webkit.org/show_bug.cgi?id=181475
872
873         Reviewed by Michael Catanzaro.
874
875         * gtk/install-dependencies: Update package list for Arch Linux, extend
876         message shown at end of installation with additional tips.
877
878 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
879
880         REGRESSION(r222507): Composition highlight doesn't render when using IME
881         https://bugs.webkit.org/show_bug.cgi?id=181485
882         <rdar://problem/35896516>
883
884         Reviewed by Ryosuke Niwa.
885
886         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
887         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
888         allow rendering composition backgrounds (see InlineTextBox::paint).
889
890         * DumpRenderTree/ios/TextInputControllerIOS.m:
891         (+[TextInputController isSelectorExcludedFromWebScript:]):
892         (+[TextInputController webScriptNameForSelector:]):
893         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
894         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
895         * DumpRenderTree/mac/TextInputControllerMac.m:
896         (+[TextInputController isSelectorExcludedFromWebScript:]):
897         (+[TextInputController webScriptNameForSelector:]):
898         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
899         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
900         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
901         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
902         (WTR::TextInputController::setMarkedText):
903         * WebKitTestRunner/InjectedBundle/TextInputController.h:
904
905 2018-01-10  JF Bastien  <jfbastien@apple.com>
906
907         Poison small JSObject derivatives which only contain pointers
908         https://bugs.webkit.org/show_bug.cgi?id=181483
909         <rdar://problem/36407127>
910
911         Reviewed by Mark Lam.
912
913         Test the new move-assign and move-copy from unique_ptr, as well as
914         nullptr_t ctors.
915
916         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
917         (TestWebKitAPI::TEST):
918         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
919         (TestWebKitAPI::TEST):
920         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
921         (TestWebKitAPI::TEST):
922
923 2018-01-10  Chris Dumez  <cdumez@apple.com>
924
925         Multiple http/wpt/beacon/contentextensions/ test are flaky.
926         https://bugs.webkit.org/show_bug.cgi?id=179256
927         <rdar://problem/35401978>
928
929         Reviewed by Alex Christensen.
930
931         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
932         instance gets its own folder to avoid conflicts and flakiness.
933
934         * WebKitTestRunner/mac/TestControllerMac.mm:
935         (WTR::TestController::platformConfigureViewForTest):
936
937 2018-01-10  Tim Horton  <timothy_horton@apple.com>
938
939         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
940         https://bugs.webkit.org/show_bug.cgi?id=181269
941         <rdar://problem/35110344>
942
943         Reviewed by Simon Fraser.
944
945         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
946         (WTR::UIScriptController::beginBackSwipe):
947         (WTR::UIScriptController::completeBackSwipe):
948         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
949         (WTR::UIScriptController::beginBackSwipe):
950         (WTR::UIScriptController::completeBackSwipe):
951         (WTR::UIScriptController::overridePreference):
952         (WTR::UIScriptController::replaceTextAtRange):
953         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
954         (WTR::PlatformWebView::setNavigationGesturesEnabled):
955         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
956         (WTR::UIScriptController::beginBackSwipe):
957         (WTR::UIScriptController::completeBackSwipe):
958         Implement beginBackSwipe and completeBackSwipe on iOS (they already
959         exist on Mac) in terms of the new WKWebView testing SPI.
960
961 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
962
963         REGRESSION (r226715): ignore WARNING output in linter tests
964         https://bugs.webkit.org/show_bug.cgi?id=181486
965         <rdar://problem/36408847>
966
967         Reviewed by Aakash Jain.
968
969         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
970
971         * Scripts/webkitpy/common/system/outputcapture.py:
972         (OutputCapture.__init__): Pass logging level to be captured.
973         * Scripts/webkitpy/style/main_unittest.py:
974         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
975         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
976         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
977         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
978         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
979         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
980         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
981         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
982
983 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
984
985         Add a JSCOnly MIPS buildbot
986         https://bugs.webkit.org/show_bug.cgi?id=181487
987
988         Reviewed by Michael Catanzaro.
989
990         Add the new bot configs definitions for the master and update the unit tests.
991
992         * BuildSlaveSupport/build.webkit.org-config/config.json:
993         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
994
995 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
996
997         REGRESSION (r226715): don't re-check number of simulators in child processes
998         https://bugs.webkit.org/show_bug.cgi?id=181484
999         <rdar://problem/36407151>
1000
1001         Reviewed by Aakash Jain.
1002
1003         * Scripts/webkitpy/port/ios_simulator.py:
1004         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
1005         are already initialized.
1006
1007 2018-01-10  Commit Queue  <commit-queue@webkit.org>
1008
1009         Unreviewed, rolling out r226667 and r226673.
1010         https://bugs.webkit.org/show_bug.cgi?id=181488
1011
1012         This caused a flaky crash. (Requested by mlewis13 on #webkit).
1013
1014         Reverted changesets:
1015
1016         "CodeBlocks should be in IsoSubspaces"
1017         https://bugs.webkit.org/show_bug.cgi?id=180884
1018         https://trac.webkit.org/changeset/226667
1019
1020         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
1021         https://bugs.webkit.org/show_bug.cgi?id=180884
1022         https://trac.webkit.org/changeset/226673
1023
1024 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1025
1026         Follow-up fix to r226715
1027         https://bugs.webkit.org/show_bug.cgi?id=180555
1028         <rdar://problem/36131381>
1029
1030         Unreviewed infrastructure fix.
1031
1032         * Scripts/webkitpy/xcode/new_simulated_device.py:
1033         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
1034         of delete.
1035
1036 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
1037
1038         webkitpy: Refactor simulator code (Part 2)
1039         https://bugs.webkit.org/show_bug.cgi?id=180555
1040         <rdar://problem/36131381>
1041
1042         Reviewed by Aakash Jain.
1043
1044         The patch leverages the SimulatedDeviceManager when running layout tests.
1045         This patch is primarily code removal, since much of the IOSSimulatorPort
1046         was dedicated to managing simulators. The removed code is either now owned by the
1047         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
1048         boot multiple simulators which was made obsolete in Xcode 9.
1049
1050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1051         (Manager._custom_device_for_test.in): Device names now have spaces in them,
1052         strip those spaces.
1053         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1054         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
1055         * Scripts/webkitpy/port/ios.py:
1056         (IOSPort.__init__): The _current_device idiom is no longer required since the
1057         SimulatedDeviceManager keeps track of any previously booted devices.
1058         (IOSPort.target_host): Even when only a single device is used, it will be accessed
1059         through the array of managed devices.
1060         (IOSPort.using_multiple_devices): Deleted.
1061         * Scripts/webkitpy/port/ios_device.py:
1062         (IOSDevicePort.using_multiple_devices): Deleted.
1063         * Scripts/webkitpy/port/ios_simulator.py:
1064         (IOSSimulatorPort): Remove constants required to manage simulators, change device
1065         class strings so they can be parsed by the DeviceType class.
1066         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
1067         the number of simulators currently booted, the number of child processes specified
1068         and the maximum number of simulators supported by this system.
1069         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
1070         devices owned by the SimulatedDeviceManager.
1071         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
1072         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
1073         the maximum number of supported simulators on this system.
1074         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
1075         request for each child process and send this list to the SimulatedDeviceManager to
1076         initialize the devices.
1077         (IOSSimulatorPort.clean_up_test_run):
1078         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
1079         specified version of iOS.
1080         (IOSSimulatorPort.reset_preferences):
1081         (IOSSimulatorPort.simulator_runtime): Deleted.
1082         (IOSSimulatorPort.simulator_device_type): Deleted.
1083         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
1084         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
1085         (IOSSimulatorPort._create_simulators): Deleted.
1086         (IOSSimulatorPort._quit_ios_simulator): Deleted.
1087         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
1088         (IOSSimulatorPort.using_multiple_devices): Deleted.
1089         (IOSSimulatorPort._create_device): Deleted.
1090         (IOSSimulatorPort.get_simulator_path): Deleted.
1091         (IOSSimulatorPort._createSimulatorApps): Deleted.
1092         (IOSSimulatorPort._createSimulatorApp): Deleted.
1093         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1094         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
1095         maximum number of simulators run on this system.
1096         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
1097         * Scripts/webkitpy/xcode/new_simulated_device.py:
1098         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
1099
1100 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
1101
1102         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
1103         https://bugs.webkit.org/show_bug.cgi?id=181474
1104
1105         Reviewed by Carlos Alberto Lopez Perez.
1106
1107         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
1108         name as the name.
1109
1110         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1111         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
1112         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
1113
1114 2018-01-09  Andy Estes  <aestes@apple.com>
1115
1116         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
1117         https://bugs.webkit.org/show_bug.cgi?id=181459
1118
1119         Reviewed by Dan Bernstein.
1120
1121         * ImageDiff/cg/Configurations/Base.xcconfig:
1122
1123 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
1124
1125         font-display:fallback can cause a visual flash (which is supposed to be impossible)
1126         https://bugs.webkit.org/show_bug.cgi?id=181374
1127
1128         Reviewed by Simon Fraser.
1129
1130         The test requires Palatino.
1131
1132         * DumpRenderTree/mac/DumpRenderTree.mm:
1133         (allowedFontFamilySet):
1134         * WebKitTestRunner/mac/TestControllerMac.mm:
1135         (WTR::allowedFontFamilySet):
1136
1137 2018-01-09  Saam Barati  <sbarati@apple.com>
1138
1139         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
1140         https://bugs.webkit.org/show_bug.cgi?id=181449
1141
1142         Reviewed by JF Bastien.
1143
1144         This allows me to Cmd+f in my terminal to search for things without
1145         having the results become misaligned.
1146
1147         * Scripts/display-profiler-output:
1148
1149 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1150
1151         [webkitpy] PlatformInfo should have default argument for casual use
1152         https://bugs.webkit.org/show_bug.cgi?id=180827
1153
1154         Reviewed by David Kilzer.
1155
1156         PlatformInfo should be the only way to check platform specific thing instead
1157         of sys.platform or other various checks. If there is something you want to check,
1158         it should be placed in PlatformInfo.
1159
1160         Currently to instantiate PlatformInfo, it requires arguments, which is usually
1161         sys, platform and Executive(). They are straight forward and should be handled
1162         by default arguments. Then we can instantiate PlatformInfo more casual.
1163
1164         * Scripts/webkitpy/common/system/platforminfo.py:
1165         (PlatformInfo): Use relative module path import
1166         (PlatformInfo.__init__):
1167         (PlatformInfo.executive): Lazy instantiation of Executive()
1168         (PlatformInfo.total_bytes_memory): Accessing via above property
1169         (PlatformInfo.xcode_sdk_version): Ditto
1170         (PlatformInfo.xcode_simctl_list): Ditto
1171         (PlatformInfo.xcode_version): Ditto
1172         (PlatformInfo._win_version_str): Ditto
1173         * Scripts/webkitpy/common/system/systemhost.py:
1174         (SystemHost.__init__):
1175         * Scripts/webkitpy/common/system/user.py:
1176         (User.__init__):
1177
1178 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1179
1180         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
1181         https://bugs.webkit.org/show_bug.cgi?id=176443
1182
1183         Reviewed by Darin Adler.
1184
1185         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
1186         (TEST):
1187
1188 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
1189
1190         check-webkit-style: Verify syntax for WK_API_AVAILABLE
1191         https://bugs.webkit.org/show_bug.cgi?id=181394
1192
1193         Reviewed by Darin Adler.
1194
1195         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
1196         as the second parameter instead of ios(WK_IOS_TBA). This generally
1197         builds for iOS on EWS but not when using the public SDK. See r224057,
1198         r223207 and r226211 for example. This patch adds a basic style check
1199         for that macro to prevent this kind of mistake.
1200
1201         * Scripts/webkitpy/style/checkers/cpp.py:
1202         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
1203         (check_style): Run new style check.
1204         (CppChecker): Add build type for the new style check.
1205         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1206         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
1207
1208 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1209
1210         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
1211         https://bugs.webkit.org/show_bug.cgi?id=181420
1212         <rdar://problem/36365827>
1213
1214         Reviewed by Alex Christensen.
1215
1216         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
1217         of corresponding _WKAttachments.
1218
1219         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1220         (TestWebKitAPI::TEST):
1221
1222 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1223
1224         Add WKNavigationDelegate SPI exposing WebProcess crash reason
1225         https://bugs.webkit.org/show_bug.cgi?id=181410
1226         <rdar://problem/36167199>
1227
1228         Reviewed by Wenson Hsieh.
1229
1230         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1231         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
1232         (TEST):
1233
1234 2018-01-08  Alex Christensen  <achristensen@webkit.org>
1235
1236         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
1237         https://bugs.webkit.org/show_bug.cgi?id=181408
1238         <rdar://problem/35884960>
1239
1240         Reviewed by Tim Horton.
1241
1242         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
1243         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
1244
1245 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1246
1247         [Attachment Support] Expose file name and content type of WKAttachment
1248         https://bugs.webkit.org/show_bug.cgi?id=181390
1249         <rdar://problem/36336837>
1250
1251         Reviewed by Tim Horton.
1252
1253         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
1254
1255         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1256         (-[_WKAttachment synchronouslyRequestInfo:]):
1257         (-[_WKAttachment synchronouslyRequestData:]):
1258
1259         Reimplement this in terms of -synchronouslyRequestInfo:.
1260
1261         (-[_WKAttachment expectRequestedDataToBe:]):
1262         (TestWebKitAPI::TEST):
1263
1264 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1265
1266         Copying, pasting, and then deleting an attachment element breaks attachment data requests
1267         https://bugs.webkit.org/show_bug.cgi?id=181365
1268         <rdar://problem/36340647>
1269
1270         Reviewed by Tim Horton.
1271
1272         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
1273         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
1274         detail.
1275
1276         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1277         (TestWebKitAPI::TEST):
1278
1279 2018-01-08  Youenn Fablet  <youenn@apple.com>
1280
1281         navigator.onLine does not work inside service workers
1282         https://bugs.webkit.org/show_bug.cgi?id=181079
1283         <rdar://problem/36178606>
1284
1285         Reviewed by Darin Adler.
1286
1287         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1288         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
1289
1290 2018-01-07  Saam Barati  <sbarati@apple.com>
1291
1292         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
1293         https://bugs.webkit.org/show_bug.cgi?id=181372
1294
1295         Reviewed by Filip Pizlo.
1296
1297         Adding these sorting modes makes it easier to analyze functions
1298         that recompile a lot and exit a lot.
1299
1300         * Scripts/display-profiler-output:
1301
1302 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
1303
1304         Unreviewed, remove my Cisco email from contributors.json
1305
1306         * Scripts/webkitpy/common/config/contributors.json:
1307
1308 2018-01-05  JF Bastien  <jfbastien@apple.com>
1309
1310         WebAssembly: poison JS object's secrets
1311         https://bugs.webkit.org/show_bug.cgi?id=181339
1312         <rdar://problem/36325001>
1313
1314         Reviewed by Mark Lam.
1315
1316         Update tests for swap(Poisoned<k, T>, T*)
1317
1318         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
1319         (TestWebKitAPI::TEST):
1320         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
1321         (TestWebKitAPI::TEST):
1322         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
1323         (TestWebKitAPI::TEST):
1324
1325 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1326
1327         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
1328         https://bugs.webkit.org/show_bug.cgi?id=181359
1329
1330         Reviewed by Tim Horton.
1331
1332         Ensure that these tests still pass using older SDKs.
1333
1334         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1335         (TestWebKitAPI::TEST):
1336
1337 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1338
1339         Rebase API test after r226469
1340         https://bugs.webkit.org/show_bug.cgi?id=181308
1341
1342         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
1343         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
1344         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
1345
1346 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1347
1348         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
1349         https://bugs.webkit.org/show_bug.cgi?id=181217
1350
1351         Reviewed by Tim Horton.
1352
1353         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1354         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1355         (TEST):
1356
1357 2018-01-05  Alex Christensen  <achristensen@webkit.org>
1358
1359         Add WKBundleFrameCreateFrameHandle
1360         https://bugs.webkit.org/show_bug.cgi?id=181232
1361         <rdar://problem/35926696>
1362
1363         Reviewed by Tim Horton.
1364
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
1367         (mouseDidMoveOverElement):
1368         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
1369         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1370         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
1371         (TEST):
1372
1373 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
1374
1375         iOS: Build fix after r226432.
1376         
1377         Unreviewed. Stop duplicating speakAs symbols for iOS.
1378
1379         * DumpRenderTree/AccessibilityUIElement.cpp:
1380         (AccessibilityUIElement::speakAs):
1381
1382 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
1383
1384         Unreviewed, added myself as WebKit reviewer
1385
1386         * Scripts/webkitpy/common/config/contributors.json:
1387
1388 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
1389
1390         WPE: Build fix after r226432.
1391
1392         Unreviewed. Rename ::speak() to ::speakAs().
1393         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1394         (WTR::AccessibilityUIElement::speakAs):
1395         (WTR::AccessibilityUIElement::speak): Deleted.
1396
1397 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
1398
1399         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
1400         https://bugs.webkit.org/show_bug.cgi?id=180361
1401
1402         Reviewed by Zalan Bujtas.
1403
1404         * DumpRenderTree/AccessibilityUIElement.cpp:
1405         (speakAsCallback):
1406         (AccessibilityUIElement::speakAs):
1407         (AccessibilityUIElement::getJSClass):
1408         (speakCallback): Deleted.
1409         (AccessibilityUIElement::speak): Deleted.
1410         * DumpRenderTree/AccessibilityUIElement.h:
1411         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1412         (AccessibilityUIElement::speakAs):
1413         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1414         (AccessibilityUIElement::speakAs):
1415         (AccessibilityUIElement::speak): Deleted.
1416         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1417         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1418         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1419         (WTR::AccessibilityUIElement::speakAs):
1420         (WTR::AccessibilityUIElement::speak): Deleted.
1421         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1422         (WTR::AccessibilityUIElement::speakAs):
1423         (WTR::AccessibilityUIElement::speak): Deleted.
1424
1425 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
1426
1427         REGRESSION (r226395): test-webkitperl test expectations incorrect
1428         https://bugs.webkit.org/show_bug.cgi?id=181307
1429         <rdar://problem/36306558>
1430
1431         Rubber-stamped by Aakash Jain.
1432
1433         r226395 added two lines towards the beginning of
1434         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
1435         numbers in the test expectations need to update.
1436
1437         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
1438
1439 2018-01-04  Tim Horton  <timothy_horton@apple.com>
1440
1441         WKWebView loses minimum layout size overrides that happen while the process is terminated
1442         https://bugs.webkit.org/show_bug.cgi?id=181306
1443         <rdar://problem/34398288>
1444
1445         Reviewed by Dan Bernstein.
1446
1447         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1448         (TEST):
1449         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
1450         while the process is terminated results in the page getting the correct
1451         minimum layout size.
1452
1453 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
1454
1455         [MediaStream] Add Mock screen capture source
1456         https://bugs.webkit.org/show_bug.cgi?id=181291
1457         <rdar://problem/36298164>
1458
1459         Reviewed by Dean Jackson.
1460
1461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
1462         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
1463         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
1464
1465 2018-01-04  Lucas Forschler  <lforschler@apple.com>
1466
1467         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
1468
1469         Reviewed by Ling Ho.
1470
1471         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1472
1473 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
1474
1475         [Attachment Support] Create attachment elements when dropping files on iOS
1476         https://bugs.webkit.org/show_bug.cgi?id=181192
1477         <rdar://problem/36280945>
1478
1479         Reviewed by Tim Horton.
1480
1481         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
1482         switch is enabled. See below for more details.
1483
1484         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1485         (-[NSItemProvider registerData:type:]):
1486         (platformCopyPNG):
1487         (TestWebKitAPI::TEST):
1488         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1489
1490         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
1491         source item provider when dragging rich text *without* attachments, so this should have been a check for just
1492         kUTTypeRTF instead.
1493
1494         (TestWebKitAPI::TEST):
1495
1496         Tests a few cases of inserting attachment elements via drop:
1497         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
1498             Instead of inserting the contents as inline web content, this should generate attachment elements.
1499         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
1500             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
1501             back to inserting the content as an attachment.
1502         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
1503             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
1504             or at the end).
1505
1506         * TestWebKitAPI/cocoa/TestWKWebView.h:
1507         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1508         (-[TestWKWebView objectByEvaluatingJavaScript:]):
1509
1510         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
1511         -stringByEvaluatingJavaScript to just turn around and call this.
1512
1513         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1514
1515 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
1516
1517         Replace hard-coded paths in shebangs with #!/usr/bin/env
1518         https://bugs.webkit.org/show_bug.cgi?id=181040
1519
1520         Reviewed by Alex Christensen.
1521
1522         * BuildSlaveSupport/build-launcher-app:
1523         * BuildSlaveSupport/build-launcher-dmg:
1524         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1525         * BuildSlaveSupport/built-product-archive:
1526         * BuildSlaveSupport/clean-build:
1527         * BuildSlaveSupport/delete-stale-build-files:
1528         * BuildSlaveSupport/download-built-product:
1529         * BuildSlaveSupport/gtk/buildbot/log/run:
1530         * BuildSlaveSupport/gtk/buildbot/run:
1531         * BuildSlaveSupport/gtk/pulseaudio/run:
1532         * BuildSlaveSupport/kill-old-processes:
1533         * BuildSlaveSupport/test-result-archive:
1534         * BuildSlaveSupport/win/kill-old-processes:
1535         * Scripts/SpacingHeuristics.pm:
1536         * Scripts/add-include:
1537         * Scripts/build-api-tests:
1538         * Scripts/build-dumprendertree:
1539         * Scripts/build-imagediff:
1540         * Scripts/build-jsc:
1541         * Scripts/build-webkit:
1542         * Scripts/build-webkittestrunner:
1543         * Scripts/check-Xcode-source-file-types:
1544         * Scripts/check-dom-results:
1545         * Scripts/check-for-exit-time-destructors:
1546         * Scripts/check-for-global-initializers:
1547         * Scripts/check-for-inappropriate-objc-class-names:
1548         * Scripts/check-for-weak-vtables-and-externals:
1549         * Scripts/clean-header-guards:
1550         * Scripts/compare-timing-files:
1551         * Scripts/configure-xcode-for-ios-development:
1552         * Scripts/copy-webkitlibraries-to-product-directory:
1553         * Scripts/create-exports:
1554         * Scripts/debug-minibrowser:
1555         * Scripts/debug-safari:
1556         * Scripts/debug-test-runner:
1557         * Scripts/do-file-rename:
1558         * Scripts/do-webcore-rename:
1559         * Scripts/dump-webkit-tests-run:
1560         * Scripts/ensure-valid-python:
1561         * Scripts/execAppWithEnv:
1562         * Scripts/extract-localizable-js-strings:
1563         * Scripts/filter-build-webkit:
1564         * Scripts/find-extra-includes:
1565         * Scripts/fix-blink-patch:
1566         * Scripts/generate-coverage-data:
1567         * Scripts/git-add-reviewer:
1568         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
1569         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
1570         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
1571         * Scripts/make-new-script-test:
1572         * Scripts/make-script-test-wrappers:
1573         * Scripts/package-root:
1574         * Scripts/parse-malloc-history:
1575         * Scripts/report-include-statistics:
1576         * Scripts/resolve-ChangeLogs:
1577         * Scripts/run-api-tests:
1578         * Scripts/run-bindings-tests:
1579         * Scripts/run-content-extension-tester:
1580         * Scripts/run-iexploder-tests:
1581         * Scripts/run-javascriptcore-tests:
1582         * Scripts/run-jsc:
1583         * Scripts/run-leaks:
1584         * Scripts/run-mangleme-tests:
1585         * Scripts/run-minibrowser:
1586         * Scripts/run-pageloadtest:
1587         * Scripts/run-regexp-tests:
1588         * Scripts/run-safari:
1589         * Scripts/run-sunspider:
1590         * Scripts/run-test-runner:
1591         * Scripts/run-webkit-app:
1592         * Scripts/run-webkit-httpd:
1593         * Scripts/run-webkit-websocketserver:
1594         * Scripts/set-webkit-configuration:
1595         * Scripts/show-pretty-diff:
1596         * Scripts/sort-Xcode-project-file:
1597         * Scripts/split-file-by-class:
1598         * Scripts/sunspider-compare-results:
1599         * Scripts/svn-apply:
1600         * Scripts/svn-unapply:
1601         * Scripts/test-webkit-scripts:
1602         * Scripts/test-webkitperl:
1603         * Scripts/update-iexploder-cssproperties:
1604         * Scripts/update-javascriptcore-test-results:
1605         * Scripts/update-webkit:
1606         * Scripts/update-webkit-auxiliary-libs:
1607         * Scripts/update-webkit-dependency:
1608         * Scripts/update-webkit-libs-jhbuild:
1609         * Scripts/update-webkit-localizable-strings:
1610         * Scripts/update-webkit-support-libs:
1611         * Scripts/update-webkitgtk-libs:
1612         * Scripts/update-webkitwpe-libs:
1613         * Scripts/webkit-build-directory:
1614         * Scripts/webkitperl/LoadAsModule.pm:
1615         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
1616         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1617         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
1618         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
1619         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
1620         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
1621         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1622         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
1623         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1624         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1625         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
1626         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
1627         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
1628         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1629         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1630         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1631         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1632         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
1633         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
1634         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
1635         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
1636         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
1637         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
1638         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
1639         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
1640         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
1641         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
1642         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
1643         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1644         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1645         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
1646         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1647         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
1648         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
1649         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
1650         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
1651         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
1652         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
1653         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
1654         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1655         * ccache/ccache-clang:
1656         * ccache/ccache-clang++:
1657         * ccache/ccache-wrapper:
1658         * gtk/install-dependencies:
1659         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
1660         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
1661         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
1662         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
1663         * iExploder/iexploder-1.3.2/tools/showtest.rb:
1664         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
1665         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
1666         * iExploder/iexploder-1.7.2/src/webserver.rb:
1667         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
1668         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
1669         * wpe/install-dependencies:
1670
1671 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
1672
1673         filter-build-webkit filters out useful compiler error lines
1674         https://bugs.webkit.org/show_bug.cgi?id=179864
1675
1676         Reviewed by Tim Horton.
1677
1678         Don't filter out lines that contain information about build errors by always showing lines
1679         after a line that contains "note:" or "error:".
1680
1681         * Scripts/filter-build-webkit:
1682         (shouldShowSubsequentLine):
1683         (shouldIgnoreLine):
1684
1685 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1686
1687         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
1688         https://bugs.webkit.org/show_bug.cgi?id=173915
1689
1690         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
1691         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
1692         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
1693         empty string in this case.
1694
1695         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1696         (emitFormSubmissionEvent):
1697
1698 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1699
1700         [GTK] Add web process API to detect when form is submitted via JavaScript
1701         https://bugs.webkit.org/show_bug.cgi?id=173915
1702
1703         Reviewed by Carlos Garcia Campos.
1704
1705         Test it.
1706
1707         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1708         (FormSubmissionTest::FormSubmissionTest):
1709         (FormSubmissionTest::~FormSubmissionTest):
1710         (FormSubmissionTest::testFormSubmissionResult):
1711         (FormSubmissionTest::willSendDOMEventCallback):
1712         (FormSubmissionTest::willCompleteCallback):
1713         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
1714         (testWebExtensionFormSubmissionSteps):
1715         (beforeAll):
1716         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1717         (DelayedSignal::DelayedSignal):
1718         (emitFormSubmissionEvent):
1719         (handleFormSubmissionCallback):
1720         (willSubmitFormCallback):
1721         (pageCreatedCallback):
1722
1723 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1724
1725         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1726         https://bugs.webkit.org/show_bug.cgi?id=181251
1727
1728         * Scripts/run-gtk-tests:
1729         (GtkTestRunner):
1730
1731 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1732
1733         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1734         https://bugs.webkit.org/show_bug.cgi?id=181136
1735
1736         * Scripts/run-gtk-tests:
1737         (GtkTestRunner):
1738
1739 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1740
1741         [macOS, iOS] Adopt new secure coding APIs in WebKit
1742         https://bugs.webkit.org/show_bug.cgi?id=181085
1743         <rdar://problem/34837397>
1744
1745         Reviewed by Tim Horton.
1746
1747         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1748         capable of supporting NSSecureCoding, so pass through the current coding routines.
1749
1750         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1751         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1752         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1753         routines if necessary.
1754         (TEST): Updated for NSSecureCoding.
1755         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1756         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1757
1758 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1759
1760         Remove std::chrono completely
1761         https://bugs.webkit.org/show_bug.cgi?id=181186
1762
1763         Reviewed by Alex Christensen.
1764
1765         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1766         (WTR::TestController::platformRunUntil):
1767
1768 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1769
1770         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1771         https://bugs.webkit.org/show_bug.cgi?id=181231
1772
1773         Reviewed by Alex Christensen.
1774
1775         Implement TestController APIs needed by ResourceLoadStatistics tests.
1776
1777         * WebKitTestRunner/TestController.cpp:
1778         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1779         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1780
1781 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1782
1783         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1784         https://bugs.webkit.org/show_bug.cgi?id=181219
1785
1786         Reviewed by Wenson Hsieh.
1787
1788         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1789
1790 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1791
1792         Add a WebAuthentication runtime feature flag
1793         https://bugs.webkit.org/show_bug.cgi?id=181220
1794         <rdar://problem/36055305>
1795
1796         Reviewed by Brent Fulgham.
1797
1798         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1799
1800         * DumpRenderTree/TestOptions.h:
1801         * DumpRenderTree/TestOptions.mm:
1802         (TestOptions::TestOptions):
1803         * DumpRenderTree/mac/DumpRenderTree.mm:
1804         (enableExperimentalFeatures):
1805         (setWebPreferencesForTestOptions):
1806         * WebKitTestRunner/TestController.cpp:
1807         (WTR::TestController::resetPreferencesToConsistentValues):
1808         (WTR::updateTestOptionsFromTestHeader):
1809         * WebKitTestRunner/TestOptions.h:
1810         (WTR::TestOptions::hasSameInitializationOptions const):
1811
1812 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1813
1814         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1815         https://bugs.webkit.org/show_bug.cgi?id=181143
1816         <rdar://problem/36200381>
1817
1818         Reviewed by Tim Horton.
1819
1820         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1821         attachment elements are enabled.
1822
1823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1824         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1825         (TestWebKitAPI::TEST):
1826
1827 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1828
1829         Update Credential Management API for WebAuthentication
1830         https://bugs.webkit.org/show_bug.cgi?id=181082
1831         <rdar://problem/36055239>
1832
1833         Reviewed by Brent Fulgham.
1834
1835         Enable Credential Management API for testing.
1836
1837         * DumpRenderTree/TestOptions.h:
1838         * WebKitTestRunner/TestOptions.h:
1839
1840 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1841
1842         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1843         https://bugs.webkit.org/show_bug.cgi?id=168194
1844
1845         Reviewed by Carlos Garcia Campos.
1846
1847         Fix an assertion and unskip the test. The order that form controls are associated is not
1848         guaranteed.
1849
1850         * Scripts/run-gtk-tests:
1851         (GtkTestRunner):
1852         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1853         (didAssociateFormControlsCallback):
1854
1855 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1856
1857         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1858         https://bugs.webkit.org/show_bug.cgi?id=180897
1859         <rdar://problem/35535328>
1860
1861         Reviewed by Brent Fulgham.
1862
1863         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1864
1865         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1866         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1867         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1868         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1869         (websiteDataStoreTestWebView):
1870         (TEST):
1871
1872 == Rolled over to ChangeLog-2018-01-01 ==