00cf7492ad744f10e77a1a38affe38e285500df3
[WebKit-https.git] / Tools / ChangeLog
1 2013-10-17  Alex Christensen  <achristensen@webkit.org>
2
3         Run JavaScriptCore tests again on Windows.
4         https://bugs.webkit.org/show_bug.cgi?id=122787
5
6         Reviewed by Tim Horton.
7
8         * Scripts/build-jsc:
9         (buildMyProject): Use JavaScriptCore.sln to build JavaScriptCore and WTF.
10         * Scripts/run-javascriptcore-tests: Don't run stress tests on WinCairo.
11         * Scripts/webkitdirs.pm:
12         (determineConfigurationForVisualStudio):
13         (determineConfigurationProductDir):
14         Build directory should end with bin64 and configuration should end with |x64 on Win64.
15         (isAppleWinWebKit):
16         (copyInspectorFrontendFiles):
17         (setPathForRunningWebKitApp):
18         Separated WinCairo directories and options from AppleWin.
19
20 2013-10-17  Mihnea Ovidenie  <mihnea@adobe.com>
21
22         Unreviewed. Add myself as a reviewer.
23
24         * Scripts/webkitpy/common/config/contributors.json:
25
26 2013-10-17  Andreas Kling  <akling@apple.com>
27
28         Make it possible to assign a PassRef to a RefPtr.
29         <https://webkit.org/b/122943>
30
31         Added a small API test for RefPtr=(PassRef) so we know this code
32         will compile (and work.)
33
34         Reviewed by Antti Koivisto.
35
36 2013-10-16  Filip Pizlo  <fpizlo@apple.com>
37
38         We need test coverage for just the Baseline JIT
39         https://bugs.webkit.org/show_bug.cgi?id=122929
40
41         Reviewed by Sam Weinig.
42         
43         Adds no-LLInt versions of all tests. For the Mozilla tests, also add a BaselineJIT-only
44         variant.
45
46         * Scripts/run-jsc-stress-tests:
47
48 2013-10-16  Ryosuke Niwa  <rniwa@webkit.org>
49
50         Support multiple repositories in submitting results to --results-server-host
51         https://bugs.webkit.org/show_bug.cgi?id=122935
52
53         Reviewed by Anders Carlsson.
54
55         Remoevd --got-revision and added the logic to extract revision information
56         from multiple repositories as done in run-perf-tests.
57
58         * Scripts/webkitpy/layout_tests/controllers/manager.py:
59         (Manager.upload_results):
60         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
61         (parse_args):
62
63 2013-10-16  Darin Adler  <darin@apple.com>
64
65         Add PassRef and createRefCounted so we can improve creation of RefCounted objects
66         https://bugs.webkit.org/show_bug.cgi?id=122904
67
68         Reviewed by Anders Carlsson.
69
70         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added some basic tests for adoptRef and PassRef.
71
72 2013-10-16  Darin Adler  <darin@apple.com>
73
74         Need tests for RefPtr self-assignment and self-move-assignment.
75
76         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added tests.
77
78 2013-10-16  Robert Plociennik  <r.plociennik@samsung.com>
79
80         [EFL] Minibrowser can't load child window's location
81         https://bugs.webkit.org/show_bug.cgi?id=122485
82
83         Reviewed by Gyuyoung Kim.
84
85         * MiniBrowser/efl/main.c: Now calling window_create() without the url parameter
86             followed by an explicit call to ewk_view_url_set() where appropriate.
87         (on_key_down):
88         (on_window_create):
89         (window_create):
90         (elm_main):
91
92 2013-10-15  Sergio Correia  <sergio.correia@openbossa.org>
93
94         [EFL][WK2] Make SeccompFilters build again after r156349 and r156353
95         https://bugs.webkit.org/show_bug.cgi?id=122872
96
97         Reviewed by Anders Carlsson.
98
99         * TestWebKitAPI/PlatformEfl.cmake: Mark SeccompFilters API test as
100         failing.
101
102 2013-10-15  Dean Jackson  <dino@apple.com>
103
104         Add ENABLE_WEB_ANIMATIONS flag
105         https://bugs.webkit.org/show_bug.cgi?id=122871
106
107         Reviewed by Tim Horton.
108
109         Eventually might be http://dev.w3.org/fxtf/web-animations/
110         but this is just engine-internal work at the moment.
111
112         * Scripts/webkitperl/FeatureList.pm:
113
114 2013-10-15  Darin Adler  <darin@apple.com>
115
116         Add some API tests for Vector, RefPtr, and Ref
117         https://bugs.webkit.org/show_bug.cgi?id=122840
118
119         Reviewed by Andreas Kling.
120
121         * TestWebKitAPI/CMakeLists.txt: Added new files.
122         * TestWebKitAPI/GNUmakefile.am: Ditto.
123         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
124         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
126
127         * TestWebKitAPI/Tests/WTF/Ref.cpp: Added.
128         * TestWebKitAPI/Tests/WTF/RefLogger.h: Added.
129         * TestWebKitAPI/Tests/WTF/RefPtr.cpp: Added.
130         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added move-only insert tests.
131
132 2013-10-14  Roger Fong  <roger_fong@apple.com>
133
134         Adding myself to CC list for some components.
135
136         * Scripts/webkitpy/common/config/watchlist:
137
138 2013-10-13  Darin Adler  <darin@apple.com>
139
140         Deprecate or remove deleteAllValues functions; there are only a few call sites left
141         https://bugs.webkit.org/show_bug.cgi?id=122738
142
143         Reviewed by Anders Carlsson.
144
145         * DumpRenderTree/win/DRTDataObject.cpp:
146         (DRTDataObject::~DRTDataObject):
147         * DumpRenderTree/win/UIDelegate.cpp:
148         (DRTUndoStack::~DRTUndoStack):
149         (DRTUndoStack::clear):
150         Renamed deleteAllValues to deprecatedDeleteAllValues.
151
152         * Scripts/do-webcore-rename: Updated to perform this rename, as is traditional.
153
154 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
155
156         build.webkit.org/dashboard incorrectly shows interrupted builds as green
157         https://bugs.webkit.org/show_bug.cgi?id=122732
158
159         Reviewed by Tim Hatcher.
160
161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
162         (BuildbotIteration.prototype.update): Removed a special case for status 4 (EXCEPTION).
163         I don't see it occur any time in recent history, but judging from what happens for
164         status 5 (RETRY), we can just finish this function normally.
165         Record overall text description for iteration as BuildbotIteration.text.
166
167         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
168         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): If an iteration is a failure,
169         but no tests failed, make it yellow, and use buildbot-provided description for it.
170
171 2013-10-13  Alexey Proskuryakov  <ap@apple.com>
172
173         Remove Chromium specific code from flakiness dashboard
174         https://bugs.webkit.org/show_bug.cgi?id=122714
175
176         Reviewed by Sam Weinig.
177
178         Also removed code related to GPU tests and virtual suites.
179         "Fallbacks map" was chromium only too, not sure why they needed special handling there.
180
181         * TestResultServer/model/jsonresults_unittest.py:
182         * TestResultServer/static-dashboards/builders.js:
183         * TestResultServer/static-dashboards/dashboard_base.js:
184         * TestResultServer/static-dashboards/flakiness_dashboard.html:
185         * TestResultServer/static-dashboards/flakiness_dashboard.js:
186         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
187         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
188         * TestResultServer/static-dashboards/history.js:
189         * TestResultServer/static-dashboards/loader.js:
190         * TestResultServer/static-dashboards/ui.js:
191         * TestResultServer/templates/uploadform.html:
192
193 2013-10-11  Timothy Hatcher  <timothy@apple.com>
194
195         Remove preference support for picking the old Web Inspector.
196         https://bugs.webkit.org/show_bug.cgi?id=122655
197
198         Reviewed by Alexey Proskuryakov.
199
200         * WebKitTestRunner/TestController.cpp:
201         (WTR::TestController::resetStateToConsistentValues):
202
203 2013-10-11  Filip Pizlo  <fpizlo@apple.com>
204
205         Fix 64-bit build on everything but Windows.
206
207         Rubber stamped by Brent Fulgham.
208
209         * Scripts/webkitdirs.pm:
210         (argumentsForConfiguration):
211
212 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
213
214         Touch a file to see how auto-update works.
215
216         Rubber-stamped by Tim Hatcher.
217
218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
219
220 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
221
222         LeaksViewer fails to present recent results list if current build is still updating svn
223         https://bugs.webkit.org/show_bug.cgi?id=122670
224
225         Fixed an obvious mistake in the previous patch.
226
227         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
228         (RecentBuildsLoader.prototype.start):
229
230 2013-10-11  Alexey Proskuryakov  <ap@apple.com>
231
232         LeaksViewer fails to present recent results list if current build is still updating svn
233         https://bugs.webkit.org/show_bug.cgi?id=122670
234
235         Reviewed by Adam Roben.
236
237         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
238         (RecentBuildsLoader.prototype.start): Skip builds that don't have an svn revision yet.
239
240 2013-10-11  Brent Fulgham  <bfulgham@apple.com>
241
242         Unreviewed build fix for --64-bit target.
243
244         * Scripts/webkitdirs.pm:
245         (argumentsForConfiguration): Use 'isWin64' test, since @ARGV value may have
246         been removed by this point.
247         (hasArgument): Remove unused temporary.
248
249 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
250
251         webkit-patch failure-reason has a quite low limit for 'too many failures'
252         https://bugs.webkit.org/show_bug.cgi?id=122556
253
254         Reviewed by Darin Adler.
255
256         * Scripts/webkitpy/tool/commands/queries.py:
257         (FailureReason._explain_failures_for_builder): adjust the number of too many failures
258         to match what the layout test runners use these days.
259
260 2013-10-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
261
262         webkit-patch failure-reason should allow specifying failures one is interested in
263         https://bugs.webkit.org/show_bug.cgi?id=122554
264
265         Reviewed by Darin Adler.
266
267         * Scripts/webkitpy/tool/commands/queries.py:
268         (FailureReason):
269         (FailureReason._explain_failures_for_builder): keep track of explained failures and drop out of the
270         loop if the ones we're interested in been explained.
271         (FailureReason._done_explaining): check the failures we're interested in have been explained, if any.
272         (FailureReason.execute): initialize failures to explain and the explained set.
273
274 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
275
276         Make sure that DataTypes.h is in the binary drop.
277
278         Rubber stamped by Michael Saboff.
279
280         * Scripts/export-llvm-build:
281
282 2013-10-10  Filip Pizlo  <fpizlo@apple.com>
283
284         FTL: Soft-link LLVM as a workaround for LLVM's static initializers and exit-time destructors
285         https://bugs.webkit.org/show_bug.cgi?id=122566
286
287         Reviewed by Mark Rowe.
288
289         * Scripts/configure-llvm:
290
291 2013-10-10  Mark Rowe  <mrowe@apple.com>
292
293         <rdar://problem/13341666> WebKit should always build against an SDK.
294
295         Have all projects default to building against the OS X Internal SDK for the Production
296         configuration. For the Debug and Release configurations, look for UseInternalSDK.xcconfig
297         to determine whether the OS X Internal SDK should be used. If not, use the normal OS X SDK.
298
299         Reviewed by Dan Bernstein.
300
301         * DumpRenderTree/mac/Configurations/Base.xcconfig:
302         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
303         * MiniBrowser/Configurations/Base.xcconfig:
304         * MiniBrowser/Configurations/DebugRelease.xcconfig:
305         * TestWebKitAPI/Configurations/Base.xcconfig:
306         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
307         * WebKitTestRunner/Configurations/Base.xcconfig:
308         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
309
310 2013-10-10  Gustavo Noronha Silva  <gns@gnome.org>
311
312         Unreviewed gardening, the inspector protocol timeouts are also affecting TestInspectorServer.
313
314         * Scripts/run-gtk-tests:
315         (TestRunner): skip TestInspectorServer.
316
317 2013-10-10  Andres Gomez  <agomez@igalia.com>
318
319         [GTK] Provide search functionality to MiniBrowser
320         https://bugs.webkit.org/show_bug.cgi?id=117631
321
322         Reviewed by Carlos Garcia Campos.
323
324         Adds a search bar to MiniBrowser with the minimum functionality
325         and a new button to the toolbar for showing the new search
326         bar. Typical keyboard shortcuts are also added.
327
328         * MiniBrowser/gtk/BrowserSearchBar.c: Added.
329         (doSearch):
330         (searchNext):
331         (searchPrevious):
332         (searchCloseButtonClickedCallback):
333         (searchEntryMenuIconPressedCallback):
334         (searchEntryClearIconReleasedCallback):
335         (searchEntryChangedCallback):
336         (searchEntryActivatedCallback):
337         (searchPrevButtonClickedCallback):
338         (searchNextButtonClickedCallback):
339         (searchMenuCheckButtonToggledCallback):
340         (browser_search_bar_init):
341         (browserSearchBarFinalize):
342         (browser_search_bar_class_init):
343         (browser_search_bar_new):
344         (browser_search_bar_add_accelerators):
345         (browser_search_bar_open):
346         (browser_search_bar_close):
347         * MiniBrowser/gtk/BrowserSearchBar.h: Added.
348         * MiniBrowser/gtk/BrowserWindow.c:
349         (webViewEnterFullScreen): Closes new search bar.
350         (webViewLeaveFullScreen): Opens new search bar if previously
351         visible.
352         (searchCallback): Added. Shows and hides the new search bar.
353         (browser_window_init): Added search button to the toolbar.
354         (browserWindowConstructed): Creates the new search bar.
355         * MiniBrowser/gtk/GNUmakefile.am: Added new files to compilation.
356
357 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
358
359         webkit-patch failure-reason fails with UnicodeDecodeError when name has non-ascii characters
360         https://bugs.webkit.org/show_bug.cgi?id=122552
361
362         Reviewed by Darin Adler.
363
364         * Scripts/webkitpy/common/checkout/commitinfo.py:
365         (CommitInfo.blame_string): ensure objects are made into unicode strings, not regular ones that
366         will cause UnicodeDecodeError for non-ascii characters.
367
368 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
369
370         Would like a link to dashboard from build.webkit.org main page
371         https://bugs.webkit.org/show_bug.cgi?id=122577
372
373         Reviewed by Tim Hatcher.
374
375         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added.
376
377 2013-10-09  Brent Fulgham  <bfulgham@apple.com>
378
379         [Win] Check for MathML fonts and warn user if they are missing.
380         https://bugs.webkit.org/show_bug.cgi?id=122568
381
382         Reviewed by Tim Horton.
383
384         * Scripts/webkitdirs.pm:
385         (checkRequiredSystemConfig): Use common gperf/bison/flex tests, rather than
386         Windows-specific code I added previously.
387         (fontExists): Added
388         (checkInstalledTools): Add check for MathML fonts.
389
390 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
391
392         http://build.webkit.org/dashboard/ doesn't link to webkitpy failures
393         https://bugs.webkit.org/show_bug.cgi?id=122471
394
395         Reviewed by Tim Hatcher.
396
397         Added links to webkitpy, webkitperl and bindings-tests results.
398
399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
400         (Buildbot.prototype.apiTestResultsURLForIteration):
401         (Buildbot.prototype.webkitpyTestResultsURLForIteration):
402         (Buildbot.prototype.webkitperlTestResultsURLForIteration):
403         (Buildbot.prototype.bindingsTestResultsURLForIteration):
404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
405         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
406
407 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
408
409         Move some functions from WebKitBuildbot to Buildbot class.
410
411         Suggested by Tim Hatcher.
412
413         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
414         (Buildbot.prototype.javascriptTestResultsURLForIteration):
415         (Buildbot.prototype.apiTestResultsURLForIteration):
416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
417         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
418
419 2013-10-09  Timothy Hatcher  <timothy@apple.com>
420
421         Add API tests to the Dashbord page.
422
423         https://bugs.webkit.org/show_bug.cgi?id=122283
424
425         Reviewed by Timothy Hatcher.
426
427         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
428         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
430         (WebKitBuildbot.prototype.apiTestResultsURLForIteration):
431
432 2013-10-09  Timothy Hatcher  <timothy@apple.com>
433
434         Attempt to fix faulty Dashboard iteration updating by always rebuilding test result objects.
435
436         https://bugs.webkit.org/show_bug.cgi?id=122515
437
438         Reviewed by Alexey Proskuryakov.
439
440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
441         (BuildbotIteration.prototype.update):
442
443 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
444
445         build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
446         https://bugs.webkit.org/show_bug.cgi?id=122573
447
448         Reviewed by Tim Hatcher.
449
450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
451         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
452
453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
454         (Buildbot.prototype.buildPageURLForIteration): Added.
455
456 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
457
458         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
459         https://bugs.webkit.org/show_bug.cgi?id=122569
460
461         Reviewed by Tim Hatcher.
462
463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
464         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration): "actual.html" used
465         to be produced by the old Mozilla test harness that we don't use any more.
466
467 2013-10-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
468
469         Add GTK 64 bits release to the buildbot dashboard
470         https://bugs.webkit.org/show_bug.cgi?id=122548
471
472         Reviewed by Darin Adler.
473
474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/GTK.png: Added.
475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
476         (WebKitBuildbot): add 64 bits release wk2 and wk1 testers.
477         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
478         (table.queue-grid tr.platform.linux-gtk img.logo): use the GTK+ logo in its dashboard line.
479
480 2013-10-09  Mario Sanchez Prada  <mario.prada@samsung.com>
481
482         [ATK] Implement new API in AtkText: atk_text_get_string_at_offset()
483         https://bugs.webkit.org/show_bug.cgi?id=120638
484
485         Reviewed by Gustavo Noronha Silva.
486
487         * gtk/jhbuild.modules: Raised ATK and AT-SPI versions to 2.10.0, so we
488         can check both the old and new APIs to retrieve text at a given offset.
489
490 2013-10-08  Alex Christensen  <achristensen@webkit.org>
491
492         Improved WinLauncher.
493         https://bugs.webkit.org/show_bug.cgi?id=122536
494
495         Reviewed by Brent Fulgham.
496
497         * WinLauncher/PrintWebUIDelegate.cpp:
498         (PrintWebUIDelegate::runJavaScriptAlertPanelWithMessage): Added.
499         (PrintWebUIDelegate::runJavaScriptConfirmPanelWithMessage): Added.
500         * WinLauncher/PrintWebUIDelegate.h: Removed stubs.
501         * WinLauncher/WinLauncher.cpp:
502         (createCrashReport): Use the executable name instead of "WinLauncher".
503         * WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Removed.
504         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link to Wininet.lib.
505         * win/DLLLauncher/DLLLauncherMain.cpp: Remove VS2005 dependency for WinCairo.
506
507 2013-10-08  Mark Lam  <mark.lam@apple.com>
508
509         Fix ruby LoadError when running run-javascriptcore-tests.
510         https://bugs.webkit.org/show_bug.cgi?id=122519.
511
512         Reviewed by Mark Hahnenberg.
513
514         The scripts needed to explicitly require 'rubygems' for older versions of ruby
515         (versions before 1.9).
516
517         * Scripts/jsc-stress-test-helpers/profiler-test-helper:
518         * Scripts/run-jsc-stress-tests:
519
520 2013-10-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
521
522         Unreviewed, add my new email to contributors.json.
523
524         * Scripts/webkitpy/common/config/contributors.json:
525
526 2013-10-08  Brent Fulgham  <bfulgham@apple.com>
527
528         Unreviewed build correction.
529
530         * Scripts/webkitpy/port/win.py:
531         (WinPort.write_registry_value): Use string representation of error message to avoid
532         format conversion problem.
533
534 2013-10-07  Brent Fulgham  <bfulgham@apple.com>
535
536         [Win] Add checks for proper build and test environment
537         https://bugs.webkit.org/show_bug.cgi?id=122466
538
539         Reviewed by Darin Adler.
540
541         This patch makes two changes:
542         1. Update webkitdirs.pm to check for some common misconfigurations and provide helpful warnings or
543            error messages so that people know what to fix to get things working.
544         2. Modify the win.py port to handle the 32-bit and 64-bit test environments, as well as making sure
545            the various environment settings are properly configured for our test environment.
546
547         * Scripts/webkitdirs.pm:
548         (checkInstalledTools): Add checks for some common Cygwin configuration problems that have
549         caused problems in the past.
550         (setupAppleWinEnv):
551         * Scripts/webkitpy/port/win.py:
552         (WinPort):
553         (WinPort.read_registry_string): Parameterize for run architecture and registry root.
554         (WinPort.write_registry_value): Parameterize registry writing by data type (string versus
555         DWORD, etc.)
556         (WinPort.write_registry_string): Revise to call new generic registry write function.
557         (WinPort.setup_crash_log_saving): Revise for new API
558         (WinPort.restore_crash_log_saving): Ditto
559         (WinPort.prevent_error_dialogs): Add new methods to prevent Windows dialogs that block our test
560         servers from running.
561         (WinPort.allow_error_dialogs): Ditto.
562         (WinPort.setup_test_run): Call new API to turn off user input dialogs on program failure.
563         (WinPort.clean_up_test_run): Call new API to reactivatea user input dialogs after test run finished.
564
565 2013-10-08  Philippe Normand  <pnormand@igalia.com>
566
567         [GStreamer] enable v4l2 plugin
568         https://bugs.webkit.org/show_bug.cgi?id=122503
569
570         Reviewed by Martin Robinson.
571
572         * gtk/jhbuild.modules: Enable the plugin, it now builds fine since
573         we updated our GStreamer version to 1.0.8.
574
575 2013-10-08  Mario Sanchez Prada  <mario.prada@samsung.com>
576
577         [ATK] Expose state of aria-invalid as ATK_STATE_INVALID_ENTRY
578         https://bugs.webkit.org/show_bug.cgi?id=122104
579
580         Reviewed by Chris Fleizach.
581
582         Updated stringAttributeValue to double check that the exposure of
583         aria-invalid as a state is consistent with its exposure as a text
584         attribute as well, when it applies (implementations of AtkText).
585
586         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
587         (AccessibilityUIElement::stringAttributeValue): Add double check.
588         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
589         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
590
591 2013-10-07  Filip Pizlo  <fpizlo@apple.com>
592
593         run-jsc-stress-tests progress meter should update more quickly on older Rubies
594         https://bugs.webkit.org/show_bug.cgi?id=122459
595
596         Reviewed by Darin Adler.
597
598         * Scripts/run-jsc-stress-tests:
599
600 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
601
602         [buildbot] parse tests that are reported as crashed correctly for GTK+
603         https://bugs.webkit.org/show_bug.cgi?id=122476
604
605         Reviewed by Martin Robinson.
606
607         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
608         (RunGtkAPITests.commandComplete): parse the crashed tests output so that is reported
609         as a failure of the API tests.
610
611 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
612
613         Unreviewed. Skipping API test that is causing the next one to crash,
614         see https://bugs.webkit.org/show_bug.cgi?id=121970.
615
616         * Scripts/run-gtk-tests:
617         (TestRunner):
618
619 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
620
621         [GTK] run-gtk-tests does not distinguish between failure and crashes
622         https://bugs.webkit.org/show_bug.cgi?id=122135
623
624         Reviewed by Martin Robinson.
625
626         The GTK+ API test runner does not distinguish between failures and crashes. This change
627         makes it do that, so it's easier for us to spot the more important/higher priority crash
628         case.
629
630         * Scripts/run-gtk-tests:
631         (TestRunner._run_test_command): return the exit code instead of a boolean true/false,
632         so we have more information on how the process ended.
633         (TestRunner._run_test): check the exit code to distinguish between crashes and failures.
634         (TestRunner.run_tests): report crashes.
635
636 2013-10-07  Gustavo Noronha Silva  <gns@gnome.org>
637
638         [GTK] Missing packages for APT on install-dependencies
639         https://bugs.webkit.org/show_bug.cgi?id=121555
640
641         Reviewed by Martin Robinson.
642
643         * gtk/install-dependencies: add packages that are needed for
644         building WebKit itself and the jhbuild dependencies.
645
646 2013-10-07  Anders Carlsson  <andersca@apple.com>
647
648         Fix test failures.
649
650         * Scripts/webkitpy/port/base.py:
651         (Port.to.start_helper):
652         * Scripts/webkitpy/port/mock_drt.py:
653         (MockDRTPort.start_helper):
654
655 2013-10-07  Anders Carlsson  <andersca@apple.com>
656
657         Always force discrete mode when running layout tests
658         https://bugs.webkit.org/show_bug.cgi?id=122465
659
660         Reviewed by Tim Horton.
661
662         This should speed up WebGL tests and hopefully prevent race conditions that may cause window server crashes from happening.
663         
664         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
665         Link with IOKit.
666
667         * DumpRenderTree/mac/LayoutTestHelper.m:
668         (installLayoutTestColorProfile):
669         Check installColorProfile.
670
671         (restoreUserColorProfile):
672         Check installColorProfile.
673
674         (lockDownDiscreteGraphics):
675         New function to force discrete graphics.
676
677         (main):
678         Add '--install-color-profile' option.
679
680         * Scripts/webkitpy/layout_tests/controllers/manager.py:
681         (Manager._set_up_run):
682         Always start the helper, but pass self._options.pixel_tests to it.
683
684         * Scripts/webkitpy/port/mac.py:
685         (MacPort.start_helper):
686         Pass --install-color-profile' to the helper if pixel_tests is true.
687
688 2013-10-07  Timothy Hatcher  <timothy@apple.com>
689
690         Properly count binding test failures as failures.
691
692         Fix the total for multiple failures in different steps too by avoiding undefined.
693
694         https://bugs.webkit.org/show_bug.cgi?id=122232
695
696         Reviewed by Alexey Proskuryakov.
697
698         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
699         (BuildbotTestResults):
700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
701         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
702
703 2013-10-07  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
704
705         [GTK] Fails to build with jhbuild with newer system glib
706         https://bugs.webkit.org/show_bug.cgi?id=122132
707
708         Reviewed by Martin Robinson.
709
710         Newer glib includes new symbols that some system libraries which we depend on, such as pango, have
711         started relying on. glib is not a dependency that should change test results, and is provided in
712         jhbuild with the intention of supporting the other bits that do, so using a newer stable release
713         should not be an issue.
714
715         * gtk/jhbuild.modules:
716
717 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
718
719         run-jsc-stress-tests shouldn't print its goofy progress meter when running on the bots
720         https://bugs.webkit.org/show_bug.cgi?id=122437
721
722         Reviewed by Antoine Quint.
723
724         * Scripts/run-jsc-stress-tests:
725
726 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
727
728         Unreviewed, fix build on old Rubies.
729
730         * Scripts/run-jsc-stress-tests:
731
732 2013-10-06  Filip Pizlo  <fpizlo@apple.com>
733
734         Unified test infrastructure via the jsc shell
735         https://bugs.webkit.org/show_bug.cgi?id=120696
736
737         Reviewed by Oliver Hunt.
738         
739         Make run-jsc-stress-tests smart enough to be able to handle different styles of test
740         output (silent or noisy) and different styles of test failure (just bad exit code,
741         text diff, filtering for some magical text, etc.). This allows me to get rid of the
742         layout-test-helper. It also allows me to switch all of the old Mozilla tests to
743         running in run-jsc-stress-tests.
744         
745         Also removes all of the code paths that defended against not having shellwords. Just
746         install the shellwords gem if you want to run tests.
747         
748         Also removes the non-parallel test running code. No reason for it to exist anymore.
749         
750         This is a massive increase in test coverage. It uncovered bugs. I fixed two of them
751         as part of this patch, and left three more as new bugzillas.
752
753         * Scripts/create-mozilla-js-test-list: Added.
754         * Scripts/jsc-stress-test-helpers/check-mozilla-failure: Added.
755         * Scripts/jsc-stress-test-helpers/layout-test-helper: Removed.
756         * Scripts/run-javascriptcore-tests:
757         * Scripts/run-jsc-stress-tests:
758
759 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
760
761         run-jsc-stress-tests should be less verbose
762         https://bugs.webkit.org/show_bug.cgi?id=122397
763
764         Reviewed by Sam Weinig.
765         
766         It now just prints something like:
767         
768          965/1831 ....
769         
770         Where the first number is the number of tests that completed, the second number is the
771         number of tests total, and the dots are the number of tests running right now - which is
772         useful towards the end when you're waiting for the last slow tests to finish.
773         
774         It will also print out the output from failing tests and it will print a line for skipped
775         tests (to annoy you into getting them into a shape where they can be unskipped). For
776         example, for LayoutTests, it will print just the diff, if the test fails. It's cool.
777
778         * Scripts/run-jsc-stress-tests:
779
780 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
781
782         Allow skipping of run-jsc-stress-tests that are configured using yaml files
783         https://bugs.webkit.org/show_bug.cgi?id=122385
784
785         Reviewed by Sam Wieinig.
786         
787         Make tests run via YAML be able to do the parse-for-commands trick that allows
788         us to skip tests and do other custom per-test stuff.
789
790         * Scripts/jsc-stress-test-helpers/layout-test-helper:
791         * Scripts/run-jsc-stress-tests:
792
793 2013-10-05  Filip Pizlo  <fpizlo@apple.com>
794
795         Unreviewed, fix tests on older Rubies.
796
797         * Scripts/run-jsc-stress-tests:
798
799 2013-10-05  Anders Carlsson  <andersca@apple.com>
800
801         Don't filter the weak symbols.
802
803         * Scripts/check-for-weak-vtables-and-externals:
804
805 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
806
807         Have run-javascriptcore-tests run JS LayoutTests using run-jsc-stress-tests so that it runs in parallel
808         https://bugs.webkit.org/show_bug.cgi?id=122376
809
810         Reviewed by Mark Hahnenberg.
811
812         * Scripts/jsc-stress-test-helpers/layout-test-helper: Added.
813         * Scripts/run-javascriptcore-tests:
814         (printThingsFound):
815         * Scripts/run-jsc-stress-tests:
816
817 2013-10-04  Filip Pizlo  <fpizlo@apple.com>
818
819         It should be even easier to run and debug a failing JSC stress test
820         https://bugs.webkit.org/show_bug.cgi?id=122337
821
822         Reviewed by Oliver Hunt.
823         
824         If a test fails, you can now just say:
825
826         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit
827
828         and get the reproduction. You don't have to set any environment variables like before.
829         Also if you want to debug the failing test you can now just say:
830
831         sh WebKitBuild/Debug/jsc-stress-results/regress/script-tests/emscripten-cube2hash.js.ftl-eager-no-cjit lldb --
832
833         Broadly, any arguments passed to the reproduction script are prepended to the command to
834         run the test. This is sort of quirky and won't work for some tests (for example the
835         profiler tests run a ruby script that runs some other stuff) but it'll work for most of
836         them and that's good enough for now.
837
838         * Scripts/run-jsc-stress-tests:
839
840 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
841
842         [Windows] Correct run-path when using 64-bit binaries.
843
844         Reviewed by David Kilzer.
845
846         * Scripts/webkitdirs.pm:
847         (determineConfigurationProductDir): If running in 64-bit mode, use the 'bin64'
848         directory. Otherwise use the existing 'bin32' directory.
849
850 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
851
852         Teach webkitdirs.pm to honor the --64-bit flag
853         https://bugs.webkit.org/show_bug.cgi?id=122357
854
855         Reviewed by David Kilzer.
856
857         * Scripts/webkitdirs.pm:
858         (argumentsForConfiguration): Modify to check if --64-bit is supplied
859         by the user.
860         (findMatchingArguments): Added.
861         (hasArgument): Added.
862         (checkForArgumentAndRemoveFromArrayRef): Refactor to use the new
863         findMatchingArguments subroutine.
864
865 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
866
867         Update svn-config for new Visual Studio extensions
868         https://bugs.webkit.org/show_bug.cgi?id=122344
869
870         Reviewed by Brent Fulgham.
871
872         * svn-config: Add new Visual Studio extensions.
873
874 2013-10-04  Alex Christensen  <achristensen@webkit.org>
875
876         Made WinLauncher have better error handling, crash reporting, and modifiability.
877         https://bugs.webkit.org/show_bug.cgi?id=122319
878
879         Reviewed by Brent Fulgham.
880
881         * WinLauncher/WinLauncher.cpp:
882         (WinLauncherWebHost::didFailProvisionalLoadWithError):
883         Don't display the numerous "Cancelled" messages that are obviously from the user.
884         (createCrashReport): Added.
885         (dllLauncherEntryPoint):
886         Made main loop back into while loop and write a crash report if it crashes.
887         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
888         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
889         Added WinLauncherReplace.h.
890         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props:
891         Added linking to DbgHelp.lib.
892         * WinLauncher/WinLauncherReplace.h:
893         Added to make modifying WinLauncher behaviour and appearance easy.
894         (processCrashDump): Added.
895
896 2013-10-04  Dirk Pranke  <dpranke@chromium.org>
897
898         remove dpranke from webkitpy watchlist
899         https://bugs.webkit.org/show_bug.cgi?id=122331
900
901         Reviewed by Brent Fulgham.
902
903         * Scripts/webkitpy/common/config/watchlist:
904
905 2013-10-04  Tim Horton  <timothy_horton@apple.com>
906
907         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
908         https://bugs.webkit.org/show_bug.cgi?id=122299
909
910         Reviewed by Beth Dakin.
911
912         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
913         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
914         The last fix didn't work; instead of trying to block, turn off threaded scrolling for all three tests.
915
916 2013-10-04  Alexey Proskuryakov  <ap@apple.com>
917
918         Watchlist is broken after <http://trac.webkit.org/r156880>
919
920         * Scripts/webkitpy/common/config/watchlist: Remove an incorrect change.
921
922 2013-10-04  Brent Fulgham  <bfulgham@apple.com>
923
924         Remove Qt features from build and test tools
925         https://bugs.webkit.org/show_bug.cgi?id=122312
926
927         Reviewed by Anders Carlsson.
928
929         * Scripts/build-dumprendertree:
930         * Scripts/build-jsc:
931         * Scripts/build-webkit:
932         * Scripts/build-webkittestrunner:
933         * Scripts/old-run-webkit-tests:
934         (openDumpTool):
935         (buildPlatformResultHierarchy):
936         (buildPlatformTestHierarchy):
937         (readSkippedFiles):
938         * Scripts/run-launcher:
939         * Scripts/run-qtwebkit-tests: Removed.
940         * Scripts/run-webkit-tests:
941         (useNewRunWebKitTests):
942         * Scripts/update-webkit:
943         * Scripts/webkit-build-directory:
944         * Scripts/webkitdirs.pm:
945         (argumentsForConfiguration):
946         (jscProductDir):
947         (builtDylibPathForName):
948         (isAppleWebKit):
949         (launcherPath):
950         (launcherName):
951         (checkRequiredSystemConfig):
952         (setupCygwinEnv):
953         (copyInspectorFrontendFiles):
954         (setPathForRunningWebKitApp):
955         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
956         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
957         (BaselineOptimizerTest.test_mac_future):
958         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
959         (BaselineOptimizerTest.test_common_directory_includes_root):
960         (BaselineOptimizerTest.test_virtual_ports_filtered):
961         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
962         (test_parse_reviewer_text):
963         * Scripts/webkitpy/common/config/watchlist:
964         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
965         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
966         * Scripts/webkitpy/port/base.py:
967         (Port.__init__):
968         (Port._port_flag_for_scripts):
969         (Port._wk2_port_name):
970         * Scripts/webkitpy/port/builders.py:
971         * Scripts/webkitpy/port/factory.py:
972         (platform_options):
973         (PortFactory):
974         (PortFactory._default_port):
975         * Scripts/webkitpy/port/factory_unittest.py:
976         (FactoryTest.test_gtk):
977         * Scripts/webkitpy/port/qt.py: Removed.
978         * Scripts/webkitpy/port/qt_unittest.py: Removed.
979         * Scripts/webkitpy/style/checker.py:
980         * Scripts/webkitpy/style/checker_unittest.py:
981         (GlobalVariablesTest.test_path_rules_specifier):
982         * Scripts/webkitpy/style/checkers/cmake.py:
983         (CMakeChecker):
984         * Scripts/webkitpy/style/checkers/cpp.py:
985         (_classify_include):
986         (check_include_line):
987         (check_identifier_name_in_declaration):
988         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
989         (OrderOfIncludesTest.test_classify_include):
990         (WebKitStyleTest.test_names):
991         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
992         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
993         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
994         (TestRebaselineTest.test_baseline_directory):
995         * Scripts/webkitpy/tool/main.py:
996         (WebKitPatch):
997
998 2013-10-03  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
999
1000         Unreviewed. Add myself to some watchlists.
1001
1002         * Scripts/webkitpy/common/config/watchlist:
1003
1004 2013-10-03  Ryosuke Niwa  <rniwa@webkit.org>
1005
1006         Remove Qt builders from the flakiness dashboard.
1007
1008         * TestResultServer/static-dashboards/builders.jsonp:
1009         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1010         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1011         * TestResultServer/static-dashboards/loader_unittests.js:
1012
1013 2013-10-03  Tim Horton  <timothy_horton@apple.com>
1014
1015         [mac][wk2] ScrollPinningBehaviors, SpacebarScrolling, and ScrollByLineCommands fail after r156793
1016         https://bugs.webkit.org/show_bug.cgi?id=122299
1017
1018         Reviewed by Beth Dakin.
1019
1020         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1021         Disable threaded scrolling.
1022
1023         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1024         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm:
1025         Synchronously wait for the scrolling thread to inform the main thread of the new scroll position.
1026
1027 2013-10-03  Anders Carlsson  <andersca@apple.com>
1028
1029         Use numeric strings in the OS version dictionary
1030         https://bugs.webkit.org/show_bug.cgi?id=122300
1031
1032         Reviewed by Mark Rowe.
1033
1034         * Scripts/webkitpy/common/system/platforminfo.py:
1035         (PlatformInfo._determine_mac_version):
1036
1037 2013-10-03  Alexey Proskuryakov  <ap@apple.com>
1038
1039         Fix LeaksViewer to load leaks results from MountainLion, not Lion.
1040
1041         Rubber-stamped by Tim Horton.
1042
1043         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1044         (LeaksViewer._displayURLPrompt):
1045
1046 2013-10-03  Dan Bernstein  <mitz@apple.com>
1047
1048         REGRESSION (r156811): Objective-C JavaScriptCore API test failing on Mountain Lion bots
1049         https://bugs.webkit.org/show_bug.cgi?id=122260
1050
1051         Reviewed by Alexey Proskuryakov.
1052
1053         For the API to work, the tests need to be compiled with a newer version of the LLVM
1054         compiler. Until the bots are updated to that version, disable the tests on 10.8.
1055
1056         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1057
1058 2013-10-02  Mario Sanchez Prada  <mario.prada@samsung.com>
1059
1060         [ATK] Expose aria-invalid as a text attribute (not object attribute)
1061         https://bugs.webkit.org/show_bug.cgi?id=122015
1062
1063         Reviewed by Chris Fleizach.
1064
1065         Adapted DRT and WKTR to check the exposure of the aria-invalid
1066         attribute as a text attribute, instead of an object attribute.
1067
1068         Also, done some refactoring of the code to try to keep things
1069         simpler and more coherent, by defining new helper functions,
1070         simplifying code, moving static variables and functions into
1071         unnammed namespaces and so on, without altering the logic other
1072         than for checking the text attribute for aria-invalid.
1073
1074         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1075         (coreAttributeToAtkAttribute): Consider 'invalid' as the name of
1076         the attribute exposed by the ATK wrapper, not 'aria-invalid'.
1077         Also, never return an empty string if not falling through any of
1078         the cases checked here, and return the original attribute instead.
1079         (atkAttributeValueToCoreAttributeValue): New helper function to
1080         match the attributes values returned by the ATK wrapper with the
1081         values expected by the layout tests. Moved the mappings for the
1082         values of AXSortDirection here as well.
1083         (getAttributeSet): New helper function to retrieve a list of
1084         attributes (an AtkAttributeSet) from an AtkObject using the right
1085         API depending on whether we want the object attributes or the text
1086         attributes (in case the object implements AtkText).
1087         (getAttributeSetValueForId): Simplified by using getAttributeSet
1088         and atkAttributeValueToCoreAttributeValue. Also, added a new
1089         parameter to indicater whether we are interested in object
1090         attributes or text attributes.
1091         (getAtkAttributeSetAsString): Ditto.
1092         (attributesOfElement): Updated to pass the new required parameter
1093         to getAtkAttributeSetAsString, indicating that we want the object
1094         attributes in this case, for backwards compatibility.
1095         (indexRangeInTable): Moved up in the file into the unnammed namespace.
1096         (alterCurrentValue): Ditto.
1097         (AccessibilityUIElement::stringAttributeValue): After moving most
1098         of the code here to the new helper functions, simplified it by
1099         just checking whether the required attribute is provided as an
1100         object attribute or, if that's not the case, as a text attribute.
1101         (AccessibilityUIElement::isAttributeSupported): Ditto.
1102         (AccessibilityUIElement::intValue): Updated to pass the new
1103         required parameter to getAttributeSetValueForId, indicating that
1104         we want the object attributes in this case.
1105         (AccessibilityUIElement::hasPopup): Ditto.
1106
1107         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1108         (WTR::coreAttributeToAtkAttribute): Same changes than for DRT.
1109         (WTR::atkAttributeValueToCoreAttributeValue): Ditto.
1110         (WTR::getAttributeSet): Ditto.
1111         (WTR::getAttributeSetValueForId): Ditto.
1112         (WTR::getAtkAttributeSetAsString): Ditto.
1113         (WTR::attributesOfElement): Ditto.
1114         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1115         (WTR::AccessibilityUIElement::isAttributeSupported): Ditto.
1116         (WTR::AccessibilityUIElement::intValue): Ditto.
1117         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1118
1119 2013-10-02  Ryosuke Niwa  <rniwa@webkit.org>
1120
1121         EWS build fix after the Qt EWS removal.
1122
1123         * QueueStatusServer/model/attachment.py:
1124         (Attachment._calculate_queue_positions):
1125
1126 2013-10-02  Anders Carlsson  <andersca@apple.com>
1127
1128         Remove Qt code from Tools/
1129         https://bugs.webkit.org/show_bug.cgi?id=122227
1130
1131         Reviewed by Andreas Kling.
1132
1133         * DumpRenderTree/WorkQueue.cpp:
1134         * DumpRenderTree/blackberry/src.pro: Removed.
1135         * DumpRenderTree/qt/DumpRenderTree.pro: Removed.
1136         * DumpRenderTree/qt/DumpRenderTree.qrc: Removed.
1137         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Removed.
1138         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Removed.
1139         * DumpRenderTree/qt/DumpRenderTreeQt.h: Removed.
1140         * DumpRenderTree/qt/EventSenderQt.cpp: Removed.
1141         * DumpRenderTree/qt/EventSenderQt.h: Removed.
1142         * DumpRenderTree/qt/GCControllerQt.cpp: Removed.
1143         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Removed.
1144         * DumpRenderTree/qt/TestRunnerQt.cpp: Removed.
1145         * DumpRenderTree/qt/TestRunnerQt.h: Removed.
1146         * DumpRenderTree/qt/TextInputControllerQt.cpp: Removed.
1147         * DumpRenderTree/qt/TextInputControllerQt.h: Removed.
1148         * DumpRenderTree/qt/WorkQueueItemQt.cpp: Removed.
1149         * DumpRenderTree/qt/WorkQueueItemQt.h: Removed.
1150         * DumpRenderTree/qt/fonts/AHEM____.TTF: Removed.
1151         * DumpRenderTree/qt/resources/user.css: Removed.
1152         * DumpRenderTree/qt/testplugin.cpp: Removed.
1153         * DumpRenderTree/qt/testplugin.h: Removed.
1154         * ImageDiff/ImageDiff.pro: Removed.
1155         * ImageDiff/qt/ImageDiff.cpp: Removed.
1156         * MiniBrowser/qt/BrowserWindow.cpp: Removed.
1157         * MiniBrowser/qt/BrowserWindow.h: Removed.
1158         * MiniBrowser/qt/MiniBrowser.pro: Removed.
1159         * MiniBrowser/qt/MiniBrowser.qrc: Removed.
1160         * MiniBrowser/qt/MiniBrowserApplication.cpp: Removed.
1161         * MiniBrowser/qt/MiniBrowserApplication.h: Removed.
1162         * MiniBrowser/qt/UrlLoader.cpp: Removed.
1163         * MiniBrowser/qt/UrlLoader.h: Removed.
1164         * MiniBrowser/qt/icons/checkbox_checked.png: Removed.
1165         * MiniBrowser/qt/icons/checkbox_unchecked.png: Removed.
1166         * MiniBrowser/qt/icons/contents_width.png: Removed.
1167         * MiniBrowser/qt/icons/favicon.png: Removed.
1168         * MiniBrowser/qt/icons/find.png: Removed.
1169         * MiniBrowser/qt/icons/folder.png: Removed.
1170         * MiniBrowser/qt/icons/info.png: Removed.
1171         * MiniBrowser/qt/icons/next.png: Removed.
1172         * MiniBrowser/qt/icons/plus.png: Removed.
1173         * MiniBrowser/qt/icons/previous.png: Removed.
1174         * MiniBrowser/qt/icons/refresh.png: Removed.
1175         * MiniBrowser/qt/icons/stop.png: Removed.
1176         * MiniBrowser/qt/icons/titlebar.png: Removed.
1177         * MiniBrowser/qt/icons/touch.png: Removed.
1178         * MiniBrowser/qt/icons/touchpoint.png: Removed.
1179         * MiniBrowser/qt/icons/up.png: Removed.
1180         * MiniBrowser/qt/js/MultiSelect.js: Removed.
1181         * MiniBrowser/qt/main.cpp: Removed.
1182         * MiniBrowser/qt/qml/AlertDialog.qml: Removed.
1183         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Removed.
1184         * MiniBrowser/qt/qml/BrowserWindow.qml: Removed.
1185         * MiniBrowser/qt/qml/CheckBox.qml: Removed.
1186         * MiniBrowser/qt/qml/ColorChooser.qml: Removed.
1187         * MiniBrowser/qt/qml/ConfirmDialog.qml: Removed.
1188         * MiniBrowser/qt/qml/Dialog.qml: Removed.
1189         * MiniBrowser/qt/qml/DialogButton.qml: Removed.
1190         * MiniBrowser/qt/qml/DialogLineInput.qml: Removed.
1191         * MiniBrowser/qt/qml/FilePicker.qml: Removed.
1192         * MiniBrowser/qt/qml/ItemSelector.qml: Removed.
1193         * MiniBrowser/qt/qml/MockTouchPoint.qml: Removed.
1194         * MiniBrowser/qt/qml/PromptDialog.qml: Removed.
1195         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Removed.
1196         * MiniBrowser/qt/qml/ScrollIndicator.qml: Removed.
1197         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Removed.
1198         * MiniBrowser/qt/raw/DerivedSources.pri: Removed.
1199         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Removed.
1200         * MiniBrowser/qt/raw/Target.pri: Removed.
1201         * MiniBrowser/qt/raw/View.cpp: Removed.
1202         * MiniBrowser/qt/raw/View.h: Removed.
1203         * MiniBrowser/qt/utils.cpp: Removed.
1204         * MiniBrowser/qt/utils.h: Removed.
1205         * QtTestBrowser/QtTestBrowser.pro: Removed.
1206         * QtTestBrowser/QtTestBrowser.qrc: Removed.
1207         * QtTestBrowser/cookiejar.cpp: Removed.
1208         * QtTestBrowser/cookiejar.h: Removed.
1209         * QtTestBrowser/favicon.png: Removed.
1210         * QtTestBrowser/fpstimer.cpp: Removed.
1211         * QtTestBrowser/fpstimer.h: Removed.
1212         * QtTestBrowser/launcherwindow.cpp: Removed.
1213         * QtTestBrowser/launcherwindow.h: Removed.
1214         * QtTestBrowser/locationedit.cpp: Removed.
1215         * QtTestBrowser/locationedit.h: Removed.
1216         * QtTestBrowser/mainwindow.cpp: Removed.
1217         * QtTestBrowser/mainwindow.h: Removed.
1218         * QtTestBrowser/qttestbrowser.cpp: Removed.
1219         * QtTestBrowser/urlloader.cpp: Removed.
1220         * QtTestBrowser/urlloader.h: Removed.
1221         * QtTestBrowser/useragentlist.txt: Removed.
1222         * QtTestBrowser/utils.cpp: Removed.
1223         * QtTestBrowser/utils.h: Removed.
1224         * QtTestBrowser/webinspector.h: Removed.
1225         * QtTestBrowser/webpage.cpp: Removed.
1226         * QtTestBrowser/webpage.h: Removed.
1227         * QtTestBrowser/webview.cpp: Removed.
1228         * QtTestBrowser/webview.h: Removed.
1229         * TestWebKitAPI/DerivedSources.pri: Removed.
1230         * TestWebKitAPI/InjectedBundle.pri: Removed.
1231         * TestWebKitAPI/PlatformWebView.h:
1232         * TestWebKitAPI/TestWebKitAPI.pri: Removed.
1233         * TestWebKitAPI/TestWebKitAPI.pro: Removed.
1234         * TestWebKitAPI/Tests.pri: Removed.
1235         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Removed.
1236         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
1237         * TestWebKitAPI/Tests/WTF/WTF.pro: Removed.
1238         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Removed.
1239         * TestWebKitAPI/qt/InjectedBundleControllerQt.cpp: Removed.
1240         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp: Removed.
1241         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Removed.
1242         * TestWebKitAPI/qt/main.cpp: Removed.
1243         * Tools.pro: Removed.
1244         * WebKitTestRunner/DerivedSources.pri: Removed.
1245         * WebKitTestRunner/EventSenderProxy.h:
1246         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Removed.
1247         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Removed.
1248         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1249         (WTR::InjectedBundlePage::resetAfterTest):
1250         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1251         (WTR::InjectedBundlePage::didClearWindowForFrame):
1252         * WebKitTestRunner/InjectedBundle/Target.pri: Removed.
1253         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1254         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp: Removed.
1255         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Removed.
1256         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Removed.
1257         * WebKitTestRunner/PlatformWebView.h:
1258         * WebKitTestRunner/Target.pri: Removed.
1259         * WebKitTestRunner/TestController.cpp:
1260         (WTR::TestController::resetStateToConsistentValues):
1261         * WebKitTestRunner/TestController.h:
1262         * WebKitTestRunner/WebKitTestRunner.pro: Removed.
1263         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Removed.
1264         * WebKitTestRunner/qt/PlatformWebViewQt.cpp: Removed.
1265         * WebKitTestRunner/qt/TestControllerQt.cpp: Removed.
1266         * WebKitTestRunner/qt/TestInvocationQt.cpp: Removed.
1267         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Removed.
1268         * WebKitTestRunner/qt/main.cpp: Removed.
1269         * WebKitTestRunner/qt/resources/user.css: Removed.
1270         * qmake/.qmake.cache: Removed.
1271         * qmake/.qmake.conf: Removed.
1272         * qmake/README: Removed.
1273         * qmake/config.tests/README: Removed.
1274         * qmake/config.tests/fontconfig/fontconfig.cpp: Removed.
1275         * qmake/config.tests/fontconfig/fontconfig.pro: Removed.
1276         * qmake/config.tests/gccdepends/empty.cpp: Removed.
1277         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
1278         * qmake/config.tests/glx/glx.cpp: Removed.
1279         * qmake/config.tests/glx/glx.pro: Removed.
1280         * qmake/config.tests/gnuld/gnuld.pro: Removed.
1281         * qmake/config.tests/gnuld/main.cpp: Removed.
1282         * qmake/config.tests/libXcomposite/libXcomposite.cpp: Removed.
1283         * qmake/config.tests/libXcomposite/libXcomposite.pro: Removed.
1284         * qmake/config.tests/libXrender/libXrender.cpp: Removed.
1285         * qmake/config.tests/libXrender/libXrender.pro: Removed.
1286         * qmake/config.tests/libwebp/libwebp.cpp: Removed.
1287         * qmake/config.tests/libwebp/libwebp.pro: Removed.
1288         * qmake/config.tests/libxml2/libxml2.cpp: Removed.
1289         * qmake/config.tests/libxml2/libxml2.pro: Removed.
1290         * qmake/config.tests/libxslt/libxslt.cpp: Removed.
1291         * qmake/config.tests/libxslt/libxslt.pro: Removed.
1292         * qmake/config.tests/libzlib/libzlib.cpp: Removed.
1293         * qmake/config.tests/libzlib/libzlib.pro: Removed.
1294         * qmake/dump-features.pl: Removed.
1295         * qmake/mkspecs/features/configure.prf: Removed.
1296         * qmake/mkspecs/features/default_post.prf: Removed.
1297         * qmake/mkspecs/features/default_pre.prf: Removed.
1298         * qmake/mkspecs/features/features.prf: Removed.
1299         * qmake/mkspecs/features/features.pri: Removed.
1300         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Removed.
1301         * qmake/mkspecs/features/functions.prf: Removed.
1302         * qmake/mkspecs/features/gprof.prf: Removed.
1303         * qmake/mkspecs/features/mac/default_post.prf: Removed.
1304         * qmake/mkspecs/features/mac/default_pre.prf: Removed.
1305         * qmake/mkspecs/features/minimal_qt.prf: Removed.
1306         * qmake/mkspecs/features/production_build.prf: Removed.
1307         * qmake/mkspecs/features/rpath.prf: Removed.
1308         * qmake/mkspecs/features/unix/default_post.prf: Removed.
1309         * qmake/mkspecs/features/unix/default_pre.prf: Removed.
1310         * qmake/mkspecs/features/unix/icc.prf: Removed.
1311         * qmake/mkspecs/features/use_all_in_one_files.prf: Removed.
1312         * qmake/mkspecs/features/valgrind.prf: Removed.
1313         * qmake/mkspecs/features/webkit_modules.prf: Removed.
1314         * qmake/mkspecs/features/win32/default_post.prf: Removed.
1315         * qmake/mkspecs/features/win32/default_pre.prf: Removed.
1316         * qmake/mkspecs/modules/angle.prf: Removed.
1317         * qmake/mkspecs/modules/javascriptcore.prf: Removed.
1318         * qmake/mkspecs/modules/webcore.prf: Removed.
1319         * qmake/mkspecs/modules/webkit1.prf: Removed.
1320         * qmake/mkspecs/modules/webkit2.prf: Removed.
1321         * qmake/mkspecs/modules/wtf.prf: Removed.
1322
1323 2013-10-02  Tim Horton  <timothy_horton@apple.com>
1324
1325         [mac] Stop using DrawingAreaImpl on PLATFORM(MAC) 
1326         https://bugs.webkit.org/show_bug.cgi?id=121859
1327         <rdar://problem/15069359>
1328
1329         Reviewed by Anders Carlsson.
1330
1331         * WebKitTestRunner/TestInvocation.cpp:
1332         (WTR::shouldUseThreadedScrolling):
1333         (WTR::updateThreadedScrollingForCurrentTest):
1334         (WTR::TestInvocation::invoke):
1335         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1336         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useThreadedScrolling:]):
1337         (WTR::PlatformWebView::PlatformWebView):
1338         (WTR::PlatformWebView::viewSupportsOptions):
1339         Rename the tiled drawing switch to threaded scrolling, since that's really
1340         all it switches now that we use tiled drawing everywhere.
1341
1342         Use an unbuffered window, as well, to avoid snapshotting issues on some platforms
1343         and to more closely match the case we're interested in testing.
1344
1345 2013-10-02  Anders Carlsson  <andersca@apple.com>
1346
1347         Move AHEM____.TTF from qt/fonts/ to fonts/.
1348
1349         Rubber-stamped by Andreas Kling.
1350
1351         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1352         * DumpRenderTree/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/qt/fonts/AHEM____.TTF.
1353
1354 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1355
1356         Remove Qt bots and EWS from trunk.
1357         https://bugs.webkit.org/show_bug.cgi?id=122210.
1358
1359         Reviewed by Allan Sandfeld Jensen.
1360
1361         Remove Qt buil dbots.
1362
1363         * BuildSlaveSupport/build.webkit.org-config/config.json:
1364         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1365         (appendCustomBuildFlags):
1366         (RunGtkAPITests.getText2):
1367         (Factory.__init__):
1368         (TestFactory.__init__):
1369         (BuildAndTestFactory.__init__):
1370         (loadBuilderConfig):
1371         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1372
1373 2013-10-02  Ádám Kallai  <kadam@inf.u-szeged.hu>
1374
1375         Remove Qt bots and EWS from trunk.
1376         https://bugs.webkit.org/show_bug.cgi?id=122210.
1377
1378         Reviewed by Allan Sandfeld Jensen.
1379
1380         Remove Qt EWS bots.
1381
1382         * QueueStatusServer/config/queues.py:
1383         * Scripts/webkitpy/common/config/ews.json:
1384
1385 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1386
1387         Fix singular labels for test failures.
1388
1389         https://bugs.webkit.org/show_bug.cgi?id=122200
1390
1391         Reviewed by Joseph Pecoraro.
1392
1393         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1394         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1395
1396 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1397
1398         Don't keep appending iterations each time the queue updates.
1399
1400         https://bugs.webkit.org/show_bug.cgi?id=122198
1401
1402         Reviewed by Joseph Pecoraro.
1403
1404         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1405         (BuildbotQueue.prototype.update):
1406
1407 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1408
1409         Properly sort iterations in the Dashboard by revision for out-of-order queues.
1410
1411         https://bugs.webkit.org/show_bug.cgi?id=122196
1412
1413         Reviewed by Brent Fulgham.
1414
1415         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1416         (BuildbotIteration):
1417         (BuildbotIteration.prototype.update):
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1419         (BuildbotQueue.prototype.update):
1420         (BuildbotQueue.prototype.sortIterations):
1421
1422 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1423
1424         Fix some exceptions seen in the Buildbot Dashboard when looking at unloaded iterations.
1425
1426         Also fix some URLs to not have extras slashes and add a page title.
1427
1428         https://bugs.webkit.org/show_bug.cgi?id=122192
1429
1430         Reviewed by Joseph Pecoraro.
1431
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1433         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1435         (WebKitBuildbot.prototype.buildLogURLForIteration):
1436         (WebKitBuildbot.prototype.layoutTestResultsURLForIteration):
1437         (WebKitBuildbot.prototype.javascriptTestResultsURLForIteration):
1438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1439
1440 2013-10-01  Alexey Proskuryakov  <ap@apple.com>
1441
1442         [Mac] Set NSApplication current event while sending events directly to views
1443         https://bugs.webkit.org/show_bug.cgi?id=122179
1444
1445         Reviewed by Darin Adler.
1446
1447         DumpRenderTree and WebKitTestRunner send events directly to WebHMTLView or WKView,
1448         which doesn't update [NSApp currentEvent]. But there are many places in WebKit that
1449         use the current event.
1450
1451         * DumpRenderTree/mac/EventSendingController.mm:
1452         (-[EventSendingController mouseDown:withModifiers:]):
1453         (-[EventSendingController mouseUp:withModifiers:]):
1454         (-[EventSendingController mouseMoveToX:Y:]):
1455         (-[EventSendingController mouseScrollByX:andY:continuously:]):
1456         (-[EventSendingController contextClick]):
1457         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1458         * WebKitTestRunner/mac/EventSenderProxy.mm:
1459         (WTR::EventSenderProxy::mouseDown):
1460         (WTR::EventSenderProxy::mouseUp):
1461         (WTR::EventSenderProxy::mouseMoveTo):
1462         (WTR::EventSenderProxy::keyDown):
1463         (WTR::EventSenderProxy::mouseScrollBy):
1464         Update the current event. We were already using the SPI in WebKit.
1465
1466 2013-10-01  Joseph Pecoraro  <pecoraro@apple.com>
1467
1468         Buildbot Dashboard: Fix JSHint issue: 'perlTestResults' used out of scope.
1469         https://bugs.webkit.org/show_bug.cgi?id=122183
1470
1471         Reviewed by Timothy Hatcher.
1472
1473         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1474         (BuildbotIteration.prototype.update):
1475
1476 2013-10-01  Timothy Hatcher  <timothy@apple.com>
1477
1478         Tweaks to the Buildbot Dashboard
1479
1480         https://bugs.webkit.org/show_bug.cgi?id=122169
1481
1482         Reviewed by Alexey Proskuryakov.
1483
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1485         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
1486         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1487         (BuildbotQueueView.prototype.revisionLinksForIteration):
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1489         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1490         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Added.
1491         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1492         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1493         (WebKitBuildbot.prototype.buildLogURLForIteration):
1494         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1495
1496 2013-10-01  Commit Queue  <commit-queue@webkit.org>
1497
1498         Unreviewed, rolling out r156725.
1499         http://trac.webkit.org/changeset/156725
1500         https://bugs.webkit.org/show_bug.cgi?id=122176
1501
1502         broke all the mismatch tests again (Requested by thorton on
1503         #webkit).
1504
1505         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1506         (WTR::PlatformWebView::PlatformWebView):
1507
1508 2013-10-01  Alex Christensen  <achristensen@webkit.org>
1509
1510         Implemented createWebViewWithRequest in WinLauncher.
1511         https://bugs.webkit.org/show_bug.cgi?id=122069
1512
1513         Reviewed by Brent Fulgham.
1514
1515         * WinLauncher/PrintWebUIDelegate.cpp:
1516         (PrintWebUIDelegate::createWebViewWithRequest): Added.
1517         * WinLauncher/PrintWebUIDelegate.h:
1518         Removed createWebViewWithRequest stub.
1519
1520 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1521
1522         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1523         https://bugs.webkit.org/show_bug.cgi?id=122006
1524         <rdar://problem/15095197>
1525
1526         Reviewed by Dean Jackson.
1527
1528         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1529         (WTR::PlatformWebView::PlatformWebView):
1530         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1531         where the window server snapshot API returns blank snapshots.
1532
1533         Re-landing after r156724, this should not break everything now.
1534
1535 2013-10-01  Tim Horton  <timothy_horton@apple.com>
1536
1537         [mac] 1x emulation on Retina hardware shouldn't use SPI
1538         https://bugs.webkit.org/show_bug.cgi?id=122152
1539         <rdar://problem/15119384>
1540
1541         Reviewed by Anders Carlsson.
1542
1543         * DumpRenderTree/mac/DumpRenderTree.mm:
1544         (createWebViewAndOffscreenWindow):
1545         (main):
1546         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1547         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1548         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1549         (WTR::PlatformWebView::PlatformWebView):
1550         * WebKitTestRunner/mac/main.mm:
1551         (main):
1552         Register for AppleMagnifiedMode instead of using _setWindowResolution:displayIfChanged:.
1553
1554 2013-09-30  Sam Weinig  <sam@webkit.org>
1555
1556         check-webkit-style should not warn about use of C++11 “>>”  instead of “> >"
1557         https://bugs.webkit.org/show_bug.cgi?id=116474
1558
1559         Reviewed by Ryosuke Niwa.
1560
1561         * Scripts/webkitpy/style/checkers/cpp.py:
1562         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1563
1564 2013-09-30  Sam Weinig  <sam@webkit.org>
1565
1566         Remove support for DOMFileSystem
1567         https://bugs.webkit.org/show_bug.cgi?id=122137
1568
1569         Reviewed by Anders Carlsson.
1570
1571         * Scripts/webkitperl/FeatureList.pm:
1572         * Scripts/webkitpy/style/checkers/cpp.py:
1573         (check_spacing):
1574         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1575         (CppStyleTest.test_spacing_for_binary_ops):
1576         * qmake/mkspecs/features/features.pri:
1577
1578 2013-09-30  Mark Rowe  <mrowe@apple.com>
1579
1580         More build fixage for builds with SDKs.
1581
1582         * WebKitTestRunner/Configurations/Base.xcconfig:
1583         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1584
1585 2013-09-30  Timothy Hatcher  <timothy@apple.com>
1586
1587         Add initial version of a new Buildbot dashboard view.
1588
1589         https://bugs.webkit.org/show_bug.cgi?id=122131
1590
1591         Reviewed by Alexey Proskuryakov.
1592
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Added.
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Added.
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks.png: Added.
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Mavericks@2x.png: Added.
1597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Added.
1598         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Added.
1599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing.png: Added.
1600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/PlatformRing@2x.png: Added.
1601         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7.png: Added.
1602         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows7@2x.png: Added.
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8.png: Added.
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Windows8@2x.png: Added.
1605         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP.png: Added.
1606         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/WindowsXP@2x.png: Added.
1607         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BaseObject.js: Added.
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js: Added.
1609         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js: Added.
1610         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Added.
1611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js: Added.
1612         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js: Added.
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js: Added.
1614         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js: Added.
1615         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Added.
1616         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js: Added.
1617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js: Added.
1618         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js: Added.
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotBuilderQueueView.css: Added.
1620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotQueueView.css: Added.
1621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/BuildbotTesterQueueView.css: Added.
1622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Added.
1623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css: Added.
1624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added.
1625
1626 2013-09-30  Benjamin Poulain  <benjamin@webkit.org>
1627
1628         Remove the code guarded by STYLE_SCOPED
1629         https://bugs.webkit.org/show_bug.cgi?id=122123
1630
1631         Reviewed by Anders Carlsson.
1632
1633         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1634         (resetDefaultsToConsistentValues):
1635         * Scripts/webkitperl/FeatureList.pm:
1636         * qmake/mkspecs/features/features.pri:
1637
1638 2013-09-30  Mark Rowe  <mrowe@apple.com>
1639
1640         Fix the build when building against an SDK.
1641
1642         Xcode helpfully prepends $(SDKROOT) to the paths in FRAMEWORK_SEARCH_PATHS when generating
1643         the compiler command lines. It can't know to do this for the system framework search paths
1644         we add manually via OTHER_CFLAGS though, so we need to prefix them with $(SDKROOT) ourself.
1645
1646         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
1647         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1648
1649 2013-09-30  Brent Fulgham  <bfulgham@apple.com>
1650
1651         [Windows] Unreviewed test fix. Prevent crash when changing URL paths during testing.
1652
1653         A shared BSTR value (_bstr_t) was being reallocated outside the smart pointer, causing
1654         it to be double-freed.
1655
1656         * WinLauncher/WinLauncher.cpp:
1657         (EditProc): Be explicit about type passed to loadURL.
1658         (loadURL): Create a shallow copy of the BSTR so we only allocate memory if needed. Use _bstr_t so
1659         that reallocating the BSTR is done with the knowledge of the smart pointer.
1660
1661 2013-09-30  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1662
1663         [Qt] Fix force_static_libs_as_shared in WebKit2
1664         https://bugs.webkit.org/show_bug.cgi?id=121961
1665
1666         Reviewed by Csaba Osztrogonác.
1667
1668         Get rid of the unused WebKit2QML library
1669
1670         * qmake/mkspecs/features/webkit_modules.prf:
1671         * qmake/mkspecs/modules/webkit2qml.prf: Removed.
1672
1673 2013-09-30  Krzysztof Wolanski  <k.wolanski@samsung.com>
1674
1675         [EFL] Fix incorrect click counting in EventSenderProxy
1676         https://bugs.webkit.org/show_bug.cgi?id=122098
1677
1678         Reviewed by Gyuyoung Kim.
1679
1680         Previously used two types of recording time, which conflicted with each other.
1681
1682         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
1683         (WTR::EventSenderProxy::mouseUp):
1684
1685 2013-09-30  Zan Dobersek  <zdobersek@igalia.com>
1686
1687         [webkitpy] Make the Xvfb screen depth overridable
1688         https://bugs.webkit.org/show_bug.cgi?id=122089
1689
1690         Reviewed by Gyuyoung Kim.
1691
1692         Make the Xvfb screen depth overridable by checking if the XVFB_SCREEN_DEPTH environment variable
1693         was set. The default value that's used if the variable wasn't set is 24.
1694
1695         * Scripts/webkitpy/port/xvfbdriver.py:
1696         (XvfbDriver._xvfb_screen_depth):
1697         (XvfbDriver._start):
1698         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1699         (XvfbDriverTest.make_driver):
1700         (XvfbDriverTest.test_start_no_pixel_tests):
1701         (XvfbDriverTest.test_start_pixel_tests):
1702         (XvfbDriverTest.test_start_arbitrary_worker_number):
1703         (XvfbDriverTest.test_next_free_display):
1704         (XvfbDriverTest.test_start_next_worker):
1705
1706 2013-09-29  Mark Rowe  <mrowe@apple.com>
1707
1708         Fix the Lion build.
1709
1710         Ensure that C++ and Objective-C++ files build with the right compiler flags.
1711
1712         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig:
1713         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1714
1715 2013-09-28  Mark Rowe  <mrowe@apple.com>
1716
1717         Fix some failures with newer versions of clang.
1718
1719         Some CoreGraphics headers generate warnings under newer versions of clang. Since they're system headers the warnings would
1720         usually be suppressed, but we're adding the frameworks to the non-system framework search path so they're no longer treated
1721         as system headers. We address this by removing the system paths from FRAMEWORK_SEARCH_PATHS and using the -iframework compiler
1722         flag in OTHER_CFLAGS to add the paths to the system framework search path. We have to set OTHER_CFLAGS at the target level
1723         in order for it to coexist with the ASAN-related OTHER_CFLAGS that's set in DebugRelease.xcconfig.
1724
1725         Reviewed by Dan Bernstein.
1726
1727         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1728         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
1729         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1730         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1731         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
1732         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1733         * WebKitTestRunner/Configurations/Base.xcconfig:
1734         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: A new .xcconfig file that's included by all target-specific .xcconfig files.
1735         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1736         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1737         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1738
1739 2013-09-27  Commit Queue  <commit-queue@webkit.org>
1740
1741         Unreviewed, rolling out r156569.
1742         http://trac.webkit.org/changeset/156569
1743         https://bugs.webkit.org/show_bug.cgi?id=122035
1744
1745         broke a lot of mismatch tests (Requested by thorton on
1746         #webkit).
1747
1748         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1749         (WTR::PlatformWebView::PlatformWebView):
1750
1751 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
1752
1753         Don't retry failures on Apple MountainLion Release WK1 tester
1754         https://bugs.webkit.org/show_bug.cgi?id=122026
1755
1756         Reviewed by Mark Rowe.
1757
1758         * BuildSlaveSupport/build.webkit.org-config/config.json: Added --no-retry-failures
1759         on this bot.
1760
1761 2013-09-27  Alexey Proskuryakov  <ap@apple.com>
1762
1763         Don't hardcode builder specific configuration in buildbot master.cfg
1764         https://bugs.webkit.org/show_bug.cgi?id=122023
1765
1766         Reviewed by Mark Rowe.
1767
1768         * BuildSlaveSupport/build.webkit.org-config/config.json: Added an additionalArguments
1769         property to Qt Mountain Lion Release, making it run pixel tests.
1770
1771         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1772         (RunWebKitTests.start): Use additionalArguments.
1773         (RunWebKit2Tests.start): Don't hardcode individual bot behavior here.
1774
1775 2013-09-27  Tim Horton  <timothy_horton@apple.com>
1776
1777         [wk2] WebKitTestRunner's window snapshots are blank with tiled drawing
1778         https://bugs.webkit.org/show_bug.cgi?id=122006
1779         <rdar://problem/15095197>
1780
1781         Reviewed by Dean Jackson.
1782
1783         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1784         (WTR::PlatformWebView::PlatformWebView):
1785         Layer-back the root view in WebKitTestRunner's window, to work around a bug
1786         where the window server snapshot API returns blank snapshots.
1787
1788 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1789
1790         [GTK] GTK does not expose heading level correctly. Was: accessibility/heading-level.html is failing
1791         https://bugs.webkit.org/show_bug.cgi?id=106924
1792
1793         Reviewed by Chris Fleizach.
1794
1795         Consider headings levels as values to be returned in intValue()
1796         both in DRT and WKTR, so we can share more tests with other ports.
1797
1798         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1799         (AccessibilityUIElement::intValue): Consider headings too.
1800         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1801         (WTR::AccessibilityUIElement::intValue): Ditto.
1802
1803 2013-09-26  Darin Adler  <darin@apple.com>
1804
1805         rename KURL to URL
1806         https://bugs.webkit.org/show_bug.cgi?id=16214
1807
1808         Reviewed by Andreas Kling.
1809
1810         * many files: Renamed, using script.
1811
1812 2013-09-27  Darin Adler  <darin@apple.com>
1813
1814         Fix Python scripts test failures.
1815
1816         * Scripts/webkitpy/style/checkers/cpp.py:
1817         (_FunctionState.modifiers_and_return_type): Added this back. Used only by tests
1818         now, not by the checker itself.
1819
1820 2013-09-27  Denis Nomiyama  <d.nomiyama@samsung.com>
1821
1822         [GTK][WK2] Logging of accessibility events is not disabled between tests
1823         https://bugs.webkit.org/show_bug.cgi?id=121957
1824
1825         Reviewed by Mario Sanchez Prada.
1826
1827         Fixed an issue in AccessibilityNotificationHandler where the destructor
1828         was not disconnecting accessibility event callbacks if logging was on.
1829         The decision of disconnecting events can solely rely on the existence of
1830         notification handlers because logging uses the global notification
1831         handler.
1832
1833         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1834         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks): Fixed
1835         disconnection when logging is on.
1836
1837 2013-09-27  Patrick Gansterer  <paroga@webkit.org>
1838
1839         Add general CMakeLists.txt for DRT
1840         https://bugs.webkit.org/show_bug.cgi?id=119268
1841
1842         Reviewed by Gyuyoung Kim.
1843
1844         The new file allows better sharing between ports.
1845
1846         * CMakeLists.txt:
1847         * DumpRenderTree/CMakeLists.txt: Added.
1848         * DumpRenderTree/PlatformEfl.cmake: Added.
1849         * DumpRenderTree/efl/CMakeLists.txt: Removed.
1850
1851 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1852
1853         [Qt] Fix force_static_libs_as_shared in WebKit2
1854         https://bugs.webkit.org/show_bug.cgi?id=121961
1855
1856         Reviewed by Csaba Osztrogonác.
1857
1858         Reenable force_static_libs_as_shared when building WebKit2.
1859
1860         * qmake/mkspecs/features/default_post.prf:
1861
1862 2013-09-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1863
1864         [Qt] Mock implementations of positioning and orientation not used
1865         https://bugs.webkit.org/show_bug.cgi?id=121956
1866
1867         Reviewed by Csaba Osztrogonác.
1868
1869         Move production_build checks to sanitizeFeatures where its value is actually known.
1870
1871         * qmake/mkspecs/features/features.prf:
1872         * qmake/mkspecs/features/features.pri:
1873
1874 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1875
1876         [ATK] Normalize checks in entry points for DRT and WKTR
1877         https://bugs.webkit.org/show_bug.cgi?id=121959
1878
1879         Reviewed by Chris Fleizach.
1880
1881         Always check if we have a proper instance of AtkObject,
1882         implementing the interfaces that we might need for each case, at
1883         the entry point of every method of AccessibilityUIElement for ATK,
1884         and do those checks in an uniform way across DRT and WKTR, to
1885         avoid confusion and issues when modifying these files in the future.
1886
1887         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1888         (AccessibilityUIElement::getChildren): Use normalized checks.
1889         (AccessibilityUIElement::getChildrenWithRange): Ditto.
1890         (AccessibilityUIElement::rowCount): Ditto.
1891         (AccessibilityUIElement::columnCount): Ditto.
1892         (AccessibilityUIElement::childrenCount): Ditto.
1893         (AccessibilityUIElement::elementAtPoint): Ditto.
1894         (AccessibilityUIElement::getChildAtIndex): Ditto.
1895         (AccessibilityUIElement::allAttributes): Ditto.
1896         (AccessibilityUIElement::titleUIElement): Ditto.
1897         (AccessibilityUIElement::parentElement): Ditto.
1898         (AccessibilityUIElement::attributesOfChildren): Ditto.
1899         (AccessibilityUIElement::role): Ditto.
1900         (AccessibilityUIElement::title): Ditto.
1901         (AccessibilityUIElement::description): Ditto.
1902         (AccessibilityUIElement::stringValue): Ditto.
1903         (AccessibilityUIElement::language): Ditto.
1904         (AccessibilityUIElement::x): Ditto.
1905         (AccessibilityUIElement::y): Ditto.
1906         (AccessibilityUIElement::width): Ditto.
1907         (AccessibilityUIElement::height): Ditto.
1908         (AccessibilityUIElement::orientation): Ditto.
1909         (AccessibilityUIElement::intValue): Ditto.
1910         (AccessibilityUIElement::minValue): Ditto.
1911         (AccessibilityUIElement::maxValue): Ditto.
1912         (indexRangeInTable): Ditto.
1913         (AccessibilityUIElement::cellForColumnAndRow): Ditto.
1914         (AccessibilityUIElement::stringAttributeValue): Ditto.
1915         (alterCurrentValue): Ditto.
1916         (AccessibilityUIElement::press): Ditto.
1917         (AccessibilityUIElement::documentEncoding): Ditto.
1918         (AccessibilityUIElement::documentURI): Ditto.
1919         (AccessibilityUIElement::hasPopup): Ditto.
1920
1921         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1922         (WTR::indexRangeInTable): Use normalized checks.
1923         (WTR::alterCurrentValue): Ditto.
1924         (WTR::AccessibilityUIElement::getChildren): Ditto.
1925         (WTR::AccessibilityUIElement::getChildrenWithRange): Ditto.
1926         (WTR::AccessibilityUIElement::childrenCount): Ditto.
1927         (WTR::AccessibilityUIElement::elementAtPoint): Ditto.
1928         (WTR::AccessibilityUIElement::indexOfChild): Ditto.
1929         (WTR::AccessibilityUIElement::childAtIndex): Ditto.
1930         (WTR::AccessibilityUIElement::titleUIElement): Ditto.
1931         (WTR::AccessibilityUIElement::parentElement): Ditto.
1932         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
1933         (WTR::AccessibilityUIElement::allAttributes): Ditto.
1934         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
1935         (WTR::AccessibilityUIElement::role): Ditto.
1936         (WTR::AccessibilityUIElement::title): Ditto.
1937         (WTR::AccessibilityUIElement::description): Ditto.
1938         (WTR::AccessibilityUIElement::orientation): Ditto.
1939         (WTR::AccessibilityUIElement::stringValue): Ditto.
1940         (WTR::AccessibilityUIElement::language): Ditto.
1941         (WTR::AccessibilityUIElement::x): Ditto.
1942         (WTR::AccessibilityUIElement::y): Ditto.
1943         (WTR::AccessibilityUIElement::width): Ditto.
1944         (WTR::AccessibilityUIElement::height): Ditto.
1945         (WTR::AccessibilityUIElement::intValue): Ditto.
1946         (WTR::AccessibilityUIElement::minValue): Ditto.
1947         (WTR::AccessibilityUIElement::maxValue): Ditto.
1948         (WTR::AccessibilityUIElement::rowCount): Ditto.
1949         (WTR::AccessibilityUIElement::columnCount): Ditto.
1950         (WTR::AccessibilityUIElement::cellForColumnAndRow): Ditto.
1951         (WTR::AccessibilityUIElement::press): Ditto.
1952         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
1953         (WTR::AccessibilityUIElement::documentURI): Ditto.
1954         (WTR::AccessibilityUIElement::hasPopup): Ditto.
1955
1956 2013-09-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1957
1958         [ATK] accessibility/aria-sort.html is failing after r156409
1959         https://bugs.webkit.org/show_bug.cgi?id=121947
1960
1961         Reviewed by Chris Fleizach.
1962
1963         Implement AccessibilityUIElement::isSupported for the ATK
1964         platforms, just by checking whether we have an associated object
1965         attribute exposed for the wrapper object matching the required
1966         attribute in the layout test (e.g "AXSortDirection" -> "sort").
1967
1968         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1969         (AccessibilityUIElement::isAttributeSupported): Implemented.
1970         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1971         (WTR::AccessibilityUIElement::isAttributeSupported): Implemented.
1972
1973 2013-09-26  Eric Carlson  <eric.carlson@apple.com>
1974
1975         [MediaStream] make MediaStream testable
1976         https://bugs.webkit.org/show_bug.cgi?id=121967
1977
1978         Reviewed by Dean Jackson.
1979
1980         * DumpRenderTree/mac/UIDelegate.mm:
1981         (-[UIDelegate webView:decidePolicyForUserMediaRequestFromOrigin:listener:]): Add a very permissive
1982             user media request policy delegate.
1983
1984 2013-09-26  Brian J. Burg  <burg@cs.washington.edu>
1985
1986         build-webkit --inspector-frontend should copy WebInspectorUI files
1987         https://bugs.webkit.org/show_bug.cgi?id=117851
1988
1989         Reviewed by Joseph Pecoraro.
1990
1991         Change the --inspector-frontend build option to additionally build/copy 
1992         WebInspectorUI by setting it as the only project that needs to be built.
1993
1994         * Scripts/build-webkit:
1995
1996 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
1997
1998         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
1999         https://bugs.webkit.org/show_bug.cgi?id=121951
2000
2001         Reviewed by Carlos Garcia Campos.
2002
2003         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2004         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2005         500 layout tests that trigger accelerated compositing to be used.
2006
2007         * Scripts/webkitpy/port/xvfbdriver.py:
2008         (XvfbDriver._start):
2009         * Scripts/webkitpy/port/xvfbdriver_unittest.py: Update unit test baselines.
2010         (XvfbDriverTest.test_start_no_pixel_tests):
2011         (XvfbDriverTest.test_start_pixel_tests):
2012         (XvfbDriverTest.test_start_arbitrary_worker_number):
2013         (XvfbDriverTest.test_next_free_display):
2014         (XvfbDriverTest.test_start_next_worker):
2015
2016 2013-09-26  Tim Horton  <timothy_horton@apple.com>
2017
2018         Tiled drawing should not imply threaded scrolling
2019         https://bugs.webkit.org/show_bug.cgi?id=121874
2020         <rdar://problem/15071494>
2021
2022         Reviewed by Sam Weinig.
2023
2024         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2025         (WTR::PlatformWebView::PlatformWebView):
2026         The existing tiled-drawing layout tests require threaded scrolling to be enabled.
2027
2028 2013-09-26  Commit Queue  <commit-queue@webkit.org>
2029
2030         Unreviewed, rolling out r156457.
2031         http://trac.webkit.org/changeset/156457
2032         https://bugs.webkit.org/show_bug.cgi?id=121960
2033
2034         Broke webkitpy tests. (Requested by kling on #webkit).
2035
2036         * Scripts/webkitpy/port/xvfbdriver.py:
2037         (XvfbDriver._start):
2038
2039 2013-09-26  Zan Dobersek  <zdobersek@igalia.com>
2040
2041         XvfbDriver should set up Xvfb instances providing screens of 8-bit depth
2042         https://bugs.webkit.org/show_bug.cgi?id=121951
2043
2044         Reviewed by Carlos Garcia Campos.
2045
2046         Screens with 24-bit depth are causing problems as it doesn't seem to be possible to fall back to
2047         software rendering successfully on the GTK 64-bit release builder, resulting in crashes in almost
2048         500 layout tests that trigger accelerated compositing to be used.
2049
2050         * Scripts/webkitpy/port/xvfbdriver.py:
2051         (XvfbDriver._start):
2052
2053 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2054
2055         Removed check for Apple Application Support directory in WinCairo port.
2056         https://bugs.webkit.org/show_bug.cgi?id=121869
2057
2058         Reviewed by Brent Fulgham.
2059
2060         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2061         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2062         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2063         Use DLLLauncherWinCairo.props for WinCairo ports.
2064         * win/DLLLauncher/DLLLauncherMain.cpp:
2065         (wWinMain):
2066         Don't call modifyPath to check for AAS in the WinCairo port.
2067         * win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
2068
2069 2013-09-25  Alex Christensen  <achristensen@webkit.org>
2070
2071         Enabled AssembleBuildLogs on WinCairo port.
2072         https://bugs.webkit.org/show_bug.cgi?id=121923
2073
2074         Reviewed by Brent Fulgham.
2075
2076         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
2077         Fixed reference to README, added WinCairo configurations.
2078         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
2079         Fixed reference to README.
2080         * win/AssembleBuildLogs/AssembleLogs.cmd:
2081         Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
2082         * win/AssembleBuildLogs/README: Fixed spelling.
2083
2084 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2085
2086         [WIN] Fix MSVC C4146 compiler warning
2087         https://bugs.webkit.org/show_bug.cgi?id=121838
2088
2089         Reviewed by Brent Fulgham.
2090
2091         Fix some variables from unsinged to int to fix the compiler warning
2092         "unary minus operator applied to unsigned type, result still unsigned".
2093
2094         * DumpRenderTree/WorkQueueItem.h:
2095         (BackItem::BackItem):
2096         (ForwardItem::ForwardItem):
2097         * DumpRenderTree/win/DumpRenderTree.cpp:
2098         (createWebViewAndOffscreenWindow):
2099
2100 2013-09-25  Zan Dobersek  <zdobersek@igalia.com>
2101
2102         [GTK] Switch the 64-bit Release builder to testing layout tests under WK2
2103         https://bugs.webkit.org/show_bug.cgi?id=121256
2104
2105         Reviewed by Martin Robinson.
2106
2107         Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
2108         The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
2109
2110         * BuildSlaveSupport/build.webkit.org-config/config.json:
2111
2112 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2113
2114         Add style checker for CMake lists
2115         https://bugs.webkit.org/show_bug.cgi?id=121764
2116
2117         Reviewed by Ryosuke Niwa.
2118
2119         Add an additional check to make sure that list of files are sorted.
2120         Exclude lists of include directories for now, since the order
2121         can be importent for compilation of some files.
2122
2123         * Scripts/webkitpy/style/checkers/cmake.py:
2124         (CMakeChecker.check):
2125         (CMakeChecker._check_indent):
2126         (CMakeChecker):
2127         (CMakeChecker._check_list_order):
2128         (CMakeChecker._list_item_path):
2129         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2130         (CMakeCheckerTest.test_check):
2131
2132 2013-09-25  Patrick Gansterer  <paroga@webkit.org>
2133
2134         CMakeChecker takes unusually long time to run
2135         https://bugs.webkit.org/show_bug.cgi?id=105662
2136
2137         Reviewed by Ryosuke Niwa.
2138
2139         Move the caching mechanism for regular expression of the C++ checker into
2140         a common file and use it for the CMake and ChangeLog checkers too.
2141
2142         * Scripts/webkitpy/style/checkers/changelog.py:
2143         (ChangeLogChecker.check_entry):
2144         * Scripts/webkitpy/style/checkers/cmake.py:
2145         (CMakeChecker._process_line):
2146         (CMakeChecker._check_no_space_cmds):
2147         (CMakeChecker._check_one_space_cmds):
2148         (CMakeChecker._check_non_lowercase_cmd):
2149         * Scripts/webkitpy/style/checkers/common.py:
2150         (match):
2151         (search):
2152         (searchIgnorecase):
2153         (sub):
2154         (subn):
2155         * Scripts/webkitpy/style/checkers/cpp.py:
2156
2157 2013-09-25  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2158
2159         [Qt] Fix build with Qt 5.2 QtPosition module
2160         https://bugs.webkit.org/show_bug.cgi?id=121089
2161
2162         Reviewed by Simon Hausmann.
2163
2164         QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
2165         that might depend on them.
2166
2167         * qmake/mkspecs/features/default_pre.prf:
2168         * qmake/mkspecs/features/features.prf:
2169
2170 2013-09-25  Mario Sanchez Prada  <mario.prada@samsung.com>
2171
2172         [ATK] Fix style issues in AccessibilityUIElementAtk
2173         https://bugs.webkit.org/show_bug.cgi?id=121898
2174
2175         Reviewed by Chris Fleizach.
2176
2177         Avoid the '.f' suffix for float literals and use G_VALUE_INIT
2178         instead of { 0, { { 0 } } } to initialize a GValue.
2179
2180         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2181         (AccessibilityUIElement::clickPointX): Remove suffix.
2182         (AccessibilityUIElement::clickPointY): Ditto.
2183         (AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
2184         (AccessibilityUIElement::minValue): Ditto.
2185         (AccessibilityUIElement::maxValue): Ditto.
2186         (AccessibilityUIElement::numberAttributeValue): Remove suffix.
2187         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2188         (WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
2189         (WTR::AccessibilityUIElement::x): Ditto.
2190         (WTR::AccessibilityUIElement::y): Ditto.
2191         (WTR::AccessibilityUIElement::width): Ditto.
2192         (WTR::AccessibilityUIElement::height): Ditto.
2193         (WTR::AccessibilityUIElement::clickPointX): Ditto.
2194         (WTR::AccessibilityUIElement::clickPointY): Ditto.
2195         (WTR::AccessibilityUIElement::intValue): Ditto.
2196         (WTR::AccessibilityUIElement::minValue): Ditto.
2197         (WTR::AccessibilityUIElement::maxValue): Ditto.
2198
2199 2013-09-25  Krzysztof Czech  <k.czech@samsung.com>
2200
2201         [EFL] accessibility/loading-iframe-sends-notification.html is failing
2202         https://bugs.webkit.org/show_bug.cgi?id=112003
2203
2204         Reviewed by Mario Sanchez Prada.
2205
2206         Enabled addNotificationListener and removeNotificationListener for EFL port.
2207
2208         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2209         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2210         (WTR::AccessibilityController::removeNotificationListener):
2211
2212 2013-09-24  Filip Pizlo  <fpizlo@apple.com>
2213
2214         Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
2215         https://bugs.webkit.org/show_bug.cgi?id=121844
2216
2217         Reviewed by Mark Hahnenberg.
2218
2219         * Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
2220
2221 2013-09-24  Alexey Proskuryakov  <ap@apple.com>
2222
2223         [Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
2224         https://bugs.webkit.org/show_bug.cgi?id=121854
2225
2226         Reviewed by Anders Carlsson.
2227
2228         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2229         (WTR::InjectedBundle::platformInitialize): Post a notification to update cached
2230         settings in underlying frameworks.
2231
2232 2013-09-24  Mark Rowe  <mrowe@apple.com>
2233
2234         <rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
2235
2236         Reviewed by Dan Bernstein.
2237
2238         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2239         * MiniBrowser/Configurations/Base.xcconfig:
2240         * TestWebKitAPI/Configurations/Base.xcconfig:
2241         * WebKitLauncher/Configurations/Base.xcconfig:
2242         * WebKitTestRunner/Configurations/Base.xcconfig:
2243
2244 2013-09-24  Denis Nomiyama  <d.nomiyama@samsung.com>
2245
2246         [ATK] Missing WTR AccessibilityController::addNotificationListener implementation
2247         https://bugs.webkit.org/show_bug.cgi?id=121674
2248
2249         Reviewed by Mario Sanchez Prada.
2250
2251         Implemented the global notification listener for
2252         AccessibilityController. The signal is generated by
2253         AXObjectCache::postPlatformNotification() and received by
2254         axObjectEventListener(). axObjectEventListener will then invoke
2255         JSObjectCallAsFunction() with the respective callback function.
2256
2257         There is no additional test for this patch since its implementation will
2258         be tested by an accessibility layout test that is currently failing
2259         (accessibility/loading-iframe-sends-notification.html).
2260
2261         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
2262         stub implementations of addNotificationListener and
2263         removeNotificationListener for the GTK port.
2264         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2265         (WTR::AccessibilityController::addNotificationListener): Creates the
2266         notification handler and sets the notification function callback.
2267         (WTR::AccessibilityController::removeNotificationListener): Removes the
2268         global handler.
2269
2270 2013-09-24  Anton Obzhirov  <a.obzhirov@samsung.com>
2271
2272         [GTK] fast/images/exif-orientation-composited.html is failing
2273         https://bugs.webkit.org/show_bug.cgi?id=119731
2274
2275         Reviewed by Carlos Garcia Campos.
2276
2277         Add handling respect image orientation property in DRT.
2278
2279         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2280         (TestRunner::overridePreference):
2281
2282 2013-09-24  Zan Dobersek  <zdobersek@igalia.com>
2283
2284         [GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
2285         https://bugs.webkit.org/show_bug.cgi?id=121787
2286
2287         Reviewed by Gustavo Noronha Silva.
2288
2289         * gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
2290         with the Wayland target enabled to version 3.10.0.
2291
2292 2013-09-23  Patrick Gansterer  <paroga@webkit.org>
2293
2294         use NOMINMAX instead of #define min min
2295         https://bugs.webkit.org/show_bug.cgi?id=73563
2296
2297         Reviewed by Brent Fulgham.
2298
2299         Use NOMINMAX instead of #define min/max as a cleaner
2300         way of ensuring that Windows system header files don't
2301         define min/max as macro in the first place.
2302
2303         * DumpRenderTree/DumpRenderTreePrefix.h:
2304         * DumpRenderTree/cg/ImageDiffCG.cpp:
2305         * DumpRenderTree/config.h:
2306         * DumpRenderTree/win/ImageDiffCairo.cpp:
2307         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2308         * WebKitTestRunner/config.h:
2309
2310 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2311
2312         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2313         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2314
2315         Reviewed by Alexey Proskuryakov.
2316
2317         Previously, initalizing a WebPreference would change the cache model
2318         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2319         preference file on disk.
2320
2321         This patch fixes the tests by resetting the default, and using the proper
2322         default values after initializing WebPreference.
2323
2324         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2325         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2326         to the previous runs.
2327
2328         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2329         (TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
2330         cache model to the one required.
2331
2332         * TestWebKitAPI/ios/mainIOS.mm:
2333         (main): Reset the preferences before testing.
2334         * TestWebKitAPI/mac/mainMac.mm:
2335         (main): Ditto.
2336
2337 2013-09-23  Benjamin Poulain  <benjamin@webkit.org>
2338
2339         Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
2340         https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
2341
2342         Reviewed by Alexey Proskuryakov.
2343
2344         Previously, initalizing a WebPreference would change the cache model
2345         to WebCacheModelDocumentBrowser. That behavior was due to a stale
2346         preference file on disk.
2347
2348         This patch fixes the tests by resetting the default, and using the proper
2349         default values after initializing WebPreference.
2350
2351         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2352         (TestWebKitAPI::TEST): Use the proper initial value, unrelated
2353         to the previous runs.
2354
2355         * TestWebKitAPI/ios/mainIOS.mm:
2356         (main): Reset the preferences before testing.
2357         * TestWebKitAPI/mac/mainMac.mm:
2358         (main): Ditto.
2359
2360 2013-09-23  Anders Carlsson  <andersca@apple.com>
2361
2362         ListHashSet should work with move-only types
2363         https://bugs.webkit.org/show_bug.cgi?id=121802
2364
2365         Reviewed by Andreas Kling.
2366
2367         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2368         (TestWebKitAPI::TEST):
2369         Add a test for move-only types.
2370
2371 2013-09-23  Alex Christensen  <alex.christensen@flexsim.com>
2372
2373         Added --64-bit option for Windows build.
2374         https://bugs.webkit.org/show_bug.cgi?id=121799
2375
2376         Reviewed by Brent Fulgham.
2377
2378         * Scripts/webkitdirs.pm:
2379         (determinePassedConfiguration): Add "|x64" for 64-bit configuration.
2380         (isWin64): Added.
2381         (determineIsWin64): Added.
2382
2383 2013-09-23  Anders Carlsson  <andersca@apple.com>
2384
2385         ListHashSet should use std::reverse_iterator for reverse iterators
2386         https://bugs.webkit.org/show_bug.cgi?id=121795
2387
2388         Reviewed by Antti Koivisto.
2389
2390         Add test for reverse iterators.
2391
2392         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2393         (TestWebKitAPI::TEST):
2394
2395 2013-09-23  Krzysztof Czech  <k.czech@samsung.com>
2396
2397         [EFL] accessibility/aria-invalid is failing
2398         https://bugs.webkit.org/show_bug.cgi?id=111986
2399
2400         Reviewed by Mario Sanchez Prada.
2401
2402         Adds possibility to retrieve JS context.
2403         This is part of the implementation of AccessibilityUIElement::addNotificationListener
2404         from 119883 and 120421.
2405
2406         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2407         (axObjectEventListener):
2408         (addAccessibilityNotificationHandler):
2409         (removeAccessibilityNotificationHandler):
2410         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2411         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2412         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2413
2414 2013-09-20  Mark Rowe  <mrowe@apple.com>
2415
2416         <https://webkit.org/b/90090> build-webkit should verify that your tools are up-to-date
2417
2418         Enforce a minimum OS version of 10.7.5 and Xcode version of 4.6.
2419
2420         Reviewed by David Kilzer.
2421
2422         * Scripts/webkitdirs.pm:
2423         (checkRequiredSystemConfig):
2424
2425 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2426
2427         [ATK] Do not expose aria-help in ATK based platforms
2428         https://bugs.webkit.org/show_bug.cgi?id=121675
2429
2430         Reviewed by Chris Fleizach.
2431
2432         Remove the implementations for AccessibilityUIElement::helpText()
2433         from DRT and WKTR for GTK and EFL, since they are based on the
2434         AccessibilityObject::helpText() method and the 'aria-help'
2435         attributes, which is wrong since they should not depend on that
2436         but in ATK specific API (see also http://webkit.org/b/121684).
2437
2438         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2439         (AccessibilityUIElement::helpText): Added a new and empty
2440         implementation, now that we are no longer using this in ATK.
2441         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Removed file
2442         as the only function provided here was helpText().
2443         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Ditto.
2444         * DumpRenderTree/efl/CMakeLists.txt: AccessibilityUIElementEfl.cpp
2445         removed from the list of sources to compile.
2446         * GNUmakefile.am: Likewise, but for AccessibilityUIElementGtk.cpp.
2447         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2448         (WTR::AccessibilityUIElement::helpText): Replaced old implementation
2449         based in DumpRenderTreeSupportGtk with an empty one.
2450
2451 2013-09-20  Dan Bernstein  <mitz@apple.com>
2452
2453         Make extract-localizable-strings available to WebCore clients
2454         https://bugs.webkit.org/show_bug.cgi?id=121699
2455
2456         Reviewed by Darin Adler.
2457
2458         * Scripts/extract-localizable-strings: Copied to
2459         Soure/WebCore/extract-localizaebl-strings.pl, and changed this into a shell script that
2460         executes the script from its new location. This is a temporary measure until certain code
2461         that is external to WebKit is adapted to the new location.
2462         * Scripts/update-webkit-localizable-strings: Changed to call extract-localizable-strings.pl
2463         from its new location.
2464
2465 2013-09-20  Patrick Gansterer  <paroga@webkit.org>
2466
2467         Nuke remaining VS2005 tools from the tree.
2468         https://bugs.webkit.org/show_bug.cgi?id=121691
2469
2470         Reviewed by Brent Fulgham.
2471
2472         * CLWrapper/CLWrapper.cpp: Removed.
2473         * CLWrapper/CLWrapper.sln: Removed.
2474         * CLWrapper/CLWrapper.vcproj: Removed.
2475         * MIDLWrapper/MIDLWrapper.cpp: Removed.
2476         * MIDLWrapper/MIDLWrapper.sln: Removed.
2477         * MIDLWrapper/MIDLWrapper.vcproj: Removed.
2478         * Scripts/parallelcl: Removed.
2479         * vcbin/cl.exe: Removed.
2480         * vcbin/midl.exe: Removed.
2481
2482 2013-09-20  Mario Sanchez Prada  <mario.prada@samsung.com>
2483
2484         [GTK] socket_embed_hook hitting NULL-check assertion running TestWebKit2
2485         https://bugs.webkit.org/show_bug.cgi?id=121294
2486
2487         Reviewed by Martin Robinson.
2488
2489         Provide a new patch to deal with the issue in the GTK+ module from
2490         the internal jhbuild environment. This issue has been reported
2491         upstream (see https://bugzilla.gnome.org/show_bug.cgi?id=708024).
2492
2493         * gtk/jhbuild.modules: Apply the new patch to the GTK+ module.
2494         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Added.
2495
2496 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2497
2498         [ATK][WTR] accessibility/aria-invalid.html times out
2499         https://bugs.webkit.org/show_bug.cgi?id=121668
2500
2501         Reviewed by Mario Sanchez Prada.
2502
2503         Fixed WTR::AccessibilityUIElement::stringAttributeValue() to return
2504         false in case of aria-invalid event with empty value.
2505
2506         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2507         (WTR::AccessibilityUIElement::stringAttributeValue): Returns false in
2508         case of aria-invalid event with empty value.
2509
2510 2013-09-20  Denis Nomiyama  <d.nomiyama@samsung.com>
2511
2512         [ATK] Missing WTR AccessibilityUIElement::addNotificationListener implementation
2513         https://bugs.webkit.org/show_bug.cgi?id=120421
2514
2515         Reviewed by Mario Sanchez Prada.
2516
2517         Implemented the notification listener for AccessibilityUIElement for
2518         WebKitTestRunner. The signal is generated by
2519         AXObjectCache::postPlatformNotification() and received by
2520         axObjectEventListener(). axObjectEventListener() will then invoke
2521         JSObjectCallAsFunction() with the respective callback function. The
2522         notification handlers are stored in HashMap in
2523         AccessibilityNotificationHandlerAtk.cpp.
2524
2525         Moved ATK signal handling (printAccessibilityEvent and
2526         axObjectEventListener) to AccessibilityNotificationHandlerAtk.cpp.
2527
2528         * WebKitTestRunner/CMakeLists.txt: Added InjectedBundle/atk to the
2529         include path.
2530         * WebKitTestRunner/GNUmakefile.am:
2531         Added AccessibilityNotificationHandlerAtk.cpp/h.
2532         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Moved
2533         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2534         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Moved
2535         listener IDs to AccessibilityNotificationHandlerAtk.cpp.
2536         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added a
2537         notification handler for GTK+ and EFL.
2538         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2539         Moved printAccessibilityEvent and axObjectEventListener to
2540         AccessibilityNotificationHandlerAtk.cpp.
2541         (WTR::AccessibilityController::logAccessibilityEvents): Moved listener
2542         IDs to AccessibilityNotificationHandlerAtk.cpp.
2543         (WTR::AccessibilityController::resetToConsistentState): Moved listener
2544         IDs to AccessibilityNotificationHandlerAtk.cpp.
2545         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp: Added.
2546         (WTR::printAccessibilityEvent): Prints accessibility events. This
2547         function was moved from AccessibilityControllerAtk.cpp.
2548         (WTR::axObjectEventListener): Callback for signals. This function was
2549         moved from AccessibilityControllerAtk.cpp.
2550         (WTR::AccessibilityNotificationHandler::AccessibilityNotificationHandler):
2551         Initialize element and function callback.
2552         (WTR::AccessibilityNotificationHandler::~AccessibilityNotificationHandler):
2553         Removes handler from HashMap and disconnects callbacks if necessary.
2554         (WTR::AccessibilityNotificationHandler::logAccessibilityEvents): Sets
2555         logging mode and connects callbacks.
2556         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
2557         Sets the notification callback and connects callback to signals.
2558         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
2559         Removes the notification callback from HashMap.
2560         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2561         Connects axObjectEventListener to ATK signals.
2562         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
2563         Disconnects callback.
2564         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h: Added.
2565         (WTR::AccessibilityNotificationHandler::create): Creates a new instance
2566         of AccessibilityNotificationHandler.
2567         (WTR::AccessibilityNotificationHandler::setPlatformElement): Sets the
2568         element.
2569         (WTR::AccessibilityNotificationHandler::platformElement): Gets the
2570         element.
2571         (WTR::AccessibilityNotificationHandler::notificationFunctionCallback):
2572         Gets the notification callback.
2573         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2574         (WTR::AccessibilityUIElement::addNotificationListener): Creates
2575         notification handler, set the platform element and the notification
2576         callback.
2577         (WTR::AccessibilityUIElement::removeNotificationListener): Deletes the
2578         notification handler.
2579         * WebKitTestRunner/PlatformEfl.cmake:
2580         Added AccessibilityNotificationHandlerAtk.cpp.
2581
2582 2013-09-20  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2583
2584         Update features.pri
2585         https://bugs.webkit.org/show_bug.cgi?id=121670
2586
2587         Reviewed by Jocelyn Turcotte.
2588
2589         Remove feature flags that no longer exists and new ones added to FeatureList.pm
2590
2591         * qmake/mkspecs/features/features.pri:
2592
2593 2013-09-20  Krzysztof Czech  <k.czech@samsung.com>
2594
2595         [GTK][WK2] accessibility/selection-states.html is failing
2596         https://bugs.webkit.org/show_bug.cgi?id=116972
2597
2598         Reviewed by Mario Sanchez Prada.
2599
2600         isSelectable() was not exposed in Accessibility.
2601
2602         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2603
2604 2013-09-19  Dan Bernstein  <mitz@apple.com>
2605
2606         Attempted build fix after r156114.
2607
2608         * Scripts/copy-webkitlibraries-to-product-directory: Removed references to WebCoreSQLite3.
2609
2610 2013-09-19  Alexey Proskuryakov  <ap@apple.com>
2611
2612         REGRESSION (r129451): run-safari --no-saved-state is broken
2613         https://bugs.webkit.org/show_bug.cgi?id=121566
2614
2615         Undo a last minute change that doesn't actually work.
2616
2617         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): "-1" cannot be passed
2618         via command line, <rdar://problem/15032886>.
2619
2620 2013-09-19  Dan Bernstein  <mitz@apple.com>
2621
2622         Add a style guideline regarding spacing in range-based for loops
2623         https://bugs.webkit.org/show_bug.cgi?id=121620
2624
2625         Reviewed by Anders Carlsson.
2626
2627         * Scripts/webkitpy/style/checkers/cpp.py:
2628         (check_spacing): Added checking that there are spaces around the colon in a range-based for
2629         loop.
2630         (CppChecker): Added whitespace/colon to the categories set.
2631         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2632         (WebKitStyleTest.test_spacing): Added two tests for the new check.
2633
2634 2013-09-18  Sam Weinig  <sam@webkit.org>
2635
2636         Replace use of OwnArrayPtr<Foo> with std::unique_ptr<Foo[]> in Tools
2637         https://bugs.webkit.org/show_bug.cgi?id=121588
2638
2639         Reviewed by Anders Carlsson.
2640
2641         * DumpRenderTree/TestRunner.cpp:
2642         * ImageDiff/efl/ImageDiff.cpp:
2643         * TestWebKitAPI/JavaScriptTest.cpp:
2644         * TestWebKitAPI/PlatformUtilities.cpp:
2645         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2646         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2647         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2648         * WebKitTestRunner/StringFunctions.h:
2649         * WebKitTestRunner/TestInvocation.cpp:
2650         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
2651         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2652
2653 2013-09-18  Bem Jones-Bey  <bjonesbe@adobe.com>
2654
2655         W3C Test Import script reformats test HTML
2656         https://bugs.webkit.org/show_bug.cgi?id=119159
2657
2658         Reviewed by Dirk Pranke.
2659
2660         Completely rewrite the test conversion process to minimize
2661         reformatting when adding prefixes, etc. This isn't 100% perfect, there
2662         are still places where it will end up changing the formatting, but it
2663         is much better than before. Most notably, the public interface to the
2664         test converter has changed: now one calls a method instead of creating
2665         an instance of the test converter class. This is because the test
2666         converter class now has state, so one really needs a new instance for
2667         each test.
2668
2669         Note that this also lays some simple groundwork for being able to use
2670         a MockHost in the tests.
2671
2672         * Scripts/webkitpy/w3c/test_converter.py:
2673         (convert_for_webkit):
2674         (_W3CTestConverter):
2675         (_W3CTestConverter.__init__):
2676         (_W3CTestConverter.output):
2677         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties):
2678         (_W3CTestConverter.convert_style_data):
2679         (_W3CTestConverter.convert_attributes_if_needed):
2680         (_W3CTestConverter.handle_starttag):
2681         (_W3CTestConverter.handle_endtag):
2682         (_W3CTestConverter.handle_startendtag):
2683         (_W3CTestConverter.handle_data):
2684         (_W3CTestConverter.handle_entityref):
2685         (_W3CTestConverter.handle_charref):
2686         (_W3CTestConverter.handle_comment):
2687         (_W3CTestConverter.handle_decl):
2688         (_W3CTestConverter.handle_pi):
2689         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2690         (W3CTestConverterTest):
2691         (W3CTestConverterTest.fake_dir_path):
2692         (W3CTestConverterTest.test_read_prefixed_property_list):
2693         (verify_no_conversion_happened):
2694         * Scripts/webkitpy/w3c/test_importer.py:
2695         (TestImporter.import_tests):
2696
2697 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
2698
2699         Get rid of the jsc-test-list by moving all not-jsc-capable tests into js/dom
2700         https://bugs.webkit.org/show_bug.cgi?id=121578
2701
2702         Rubber stamped by Geoffrey Garen.
2703
2704         * Scripts/run-layout-jsc:
2705
2706 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
2707
2708         Unreviewed, fix for Ruby 1.8.
2709
2710         * Scripts/run-jsc-stress-tests:
2711
2712 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
2713
2714         run-jsc-stress-tests should make it easier to look at error spew from tests
2715         https://bugs.webkit.org/show_bug.cgi?id=121531
2716
2717         Reviewed by Mark Hahnenberg.
2718         
2719         This makes two changes:
2720         
2721         - The out/err spew from each test is now saved to a .out file in jsc-stress-results.
2722         
2723         - The same spew also goes to the console but is prefixed by the test's name.
2724         
2725         This required some tee and awk hacks, and then some sh hacks to work around the fact
2726         that if you do "(foo | bar) || baz", and foo fails, then baz won't run - the ||
2727         operator will only see a failure of bar failed. So to pass output to tee and awk, I
2728         needed to do weird things.
2729
2730         * Scripts/run-jsc-stress-tests:
2731
2732 2013-09-18  Alexey Proskuryakov  <ap@apple.com>
2733
2734         REGRESSION (r129451): run-safari --no-saved-state is broken
2735         https://bugs.webkit.org/show_bug.cgi?id=121566
2736
2737         Reviewed by Mark Rowe.
2738
2739         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp):
2740         Check arguments, not the newly created empty array. Pass a value that silences warnings.
2741         While at it, removed a check for Snow Leopard.
2742
2743 2013-09-18  Alex Christensen  <achristensen@webkit.org>
2744
2745         Improved WinLauncher's URL handling.
2746         https://bugs.webkit.org/show_bug.cgi?id=121535
2747
2748         Reviewed by Brent Fulgham.
2749
2750         * WinLauncher/WinLauncher.cpp:
2751         (EditProc):
2752         Use INTERNET_MAX_URL_LENGTH instead of our MAX_URL_LENGTH.
2753         (loadURL):
2754         Prepend "http://" to URLs with no scheme.
2755
2756 2013-09-18  Filip Pizlo  <fpizlo@apple.com>
2757
2758         DFG should support Int52 for local variables
2759         https://bugs.webkit.org/show_bug.cgi?id=121064
2760
2761         Reviewed by Oliver Hunt.
2762
2763         * Scripts/run-jsc-stress-tests:
2764
2765 2013-09-18  peavo@outlook.com  <peavo@outlook.com>
2766
2767         [Win] TestWebKitAPI does not compile.
2768         https://bugs.webkit.org/show_bug.cgi?id=121485
2769
2770         Reviewed by Brent Fulgham.
2771
2772         It is no longer possible to inherit from WebCore::BitmapImage, which the test relies on.
2773         Instead, load a bitmap, then destroy the decoded data, which will cause WebCore::frameAtIndex()
2774         to return null, which is the case we want to test.
2775
2776         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2777         (TestWebKitAPI::TEST):
2778
2779 2013-09-18  Mario Sanchez Prada  <mario.prada@samsung.com>
2780
2781         [ATK] Expose aria-haspopup and aria-sort without the 'aria-' prefix
2782         https://bugs.webkit.org/show_bug.cgi?id=121495
2783
2784         Reviewed by Chris Fleizach.
2785
2786         Adapted DRT and WKTR to deal with the new names for the ATK object
2787         attributes being exposed for 'aria-haspopup' and 'aria-sort'.
2788
2789         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2790         (coreAttributeToAtkAttribute): Updated translation between ATK and DRT.
2791         (AccessibilityUIElement::stringAttributeValue): Ditto.
2792         (AccessibilityUIElement::hasPopup): Ditto.
2793         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2794         (WTR::coreAttributeToAtkAttribute): Updated translation between ATK and WKTR.
2795         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2796         (WTR::AccessibilityUIElement::hasPopup): Ditto.
2797
2798 2013-09-18  Commit Queue  <commit-queue@webkit.org>
2799
2800         Unreviewed, rolling out r156019 and r156020.
2801         http://trac.webkit.org/changeset/156019
2802         http://trac.webkit.org/changeset/156020
2803         https://bugs.webkit.org/show_bug.cgi?id=121540
2804
2805         Broke tests (Requested by ap on #webkit).
2806
2807         * Scripts/run-jsc-stress-tests:
2808
2809 2013-09-17  Gwang Yoon Hwang  <ryumiel@company100.net>
2810
2811         Unreviewed. Add myself as a committer.
2812
2813         * Scripts/webkitpy/common/config/contributors.json:
2814
2815 2013-09-17  Jae Hyun Park  <jae.park@company100.net>
2816
2817         Unreviewed. Add myself as a committer.
2818
2819         * Scripts/webkitpy/common/config/contributors.json:
2820
2821 2013-09-17  Filip Pizlo  <fpizlo@apple.com>
2822
2823         DFG should support Int52 for local variables
2824         https://bugs.webkit.org/show_bug.cgi?id=121064
2825
2826         Reviewed by Oliver Hunt.
2827
2828         * Scripts/run-jsc-stress-tests:
2829
2830 2013-09-17  Alex Christensen  <alex.christensen@flexsim.com>
2831
2832         Added back and forward buttons to WinLauncher.
2833         https://bugs.webkit.org/show_bug.cgi?id=121212
2834
2835         Reviewed by Brent Fulgham.
2836
2837         * WinLauncher/WinLauncher.cpp:
2838         (resizeSubViews):
2839         Move new back and forward buttons to correct positions before URL bar.
2840         (dllLauncherEntryPoint): 
2841         Store the default button window procedure and replace with my button procedures.
2842         (EditProc): Updated style and renamed from MyEditProc.
2843         (BackButtonProc): Added.
2844         (ForwardButtonProc): Added.
2845
2846 2013-09-17  Michael Saboff  <msaboff@apple.com>
2847
2848         Unreviewed typo fix after r155999
2849
2850         Changed en_US.UTB-8 to en_US.UTF-8
2851
2852         * Scripts/run-javascriptcore-tests:
2853
2854 2013-09-17  Michael Saboff  <msaboff@apple.com>
2855
2856         run-jsc-stress-tests fails with ruby version 2
2857         https://bugs.webkit.org/show_bug.cgi?id=121521
2858
2859         Reviewed by Jessie Berlin.
2860
2861         Explicitly set LANG to en_US.UTB-8 before starting run-jsc-stress-tests.
2862
2863         * Scripts/run-javascriptcore-tests:
2864
2865 2013-09-17  Brent Fulgham  <bfulgham@apple.com>
2866
2867         [Windows] Unreviewed build fix after r155963.
2868
2869         * DumpRenderTree/win/TestRunnerWin.cpp:
2870         (TestRunner::evaluateScriptInIsolatedWorld): Pass nullptr rather than 0.
2871
2872 2013-09-17  Anders Carlsson  <andersca@apple.com>
2873
2874         Fix a typo.
2875
2876         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2877         (TestWebKitAPI::TEST):
2878
2879 2013-09-16  Anders Carlsson  <andersca@apple.com>
2880
2881         HashMap should work with move-only keys
2882         https://bugs.webkit.org/show_bug.cgi?id=121310
2883
2884         Reviewed by Darin Adler.
2885
2886         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2887         (TestWebKitAPI::TEST):
2888         Add test.
2889
2890 2013-09-17  YuTeh Shen  <shenyute@hotmail.com>
2891
2892         BrowserMarshal.h build fail
2893         https://bugs.webkit.org/show_bug.cgi?id=102938
2894
2895         Reviewed by Carlos Garcia Campos.
2896
2897         Fix variable name.
2898
2899         * MiniBrowser/gtk/GNUmakefile.am:
2900
2901 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
2902
2903         [Windows] Clean up WinLauncher by using smart pointers
2904         https://bugs.webkit.org/show_bug.cgi?id=121467
2905
2906         Reviewed by Anders Carlsson.
2907
2908         * WinLauncher/PrintWebUIDelegate.cpp:
2909         (PrintWebUIDelegate::webViewPrintingMarginRect): Switch to smart pointers.
2910         * WinLauncher/WinLauncher.cpp:
2911         (WinLauncherWebHost::updateAddressBar): Use _bstr_t and smart pointers.
2912         (WinLauncherWebHost::didFailProvisionalLoadWithError): Ditto.
2913         (showLastVisitedSites): Smart pointer updates.
2914         (WinLauncherWebHost::didFinishLoadForFrame): Ditto.
2915         (setToDefaultPreferences): Ditto.
2916         (dllLauncherEntryPoint): Ditto.
2917         (PrintView): Ditto.
2918         (LaunchInspector): Ditto.
2919         (NavigateToHistory): Ditto.
2920         (MyEditProc): Ditto.
2921         (loadURL): Ditto.
2922
2923 2013-09-16  Brent Fulgham  <bfulgham@apple.com>
2924
2925         [Windows] Add rudimentary history to WinLauncher.
2926         https://bugs.webkit.org/show_bug.cgi?id=121463
2927
2928         Reviewed by Anders Carlsson.
2929
2930         * WinLauncher/WinLauncher.cpp:
2931         (updateMenuItemForHistoryItem): Added
2932         (showLastVisitedSites): Added
2933         (WinLauncherWebHost::didFinishLoadForFrame): Add history item once
2934         a new page has been visited.
2935         (dllLauncherEntryPoint): Deallocate history on exit.
2936         (NavigateToHistory): Added
2937         (WndProc): Add handler for history entries
2938         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add menu items to hold
2939         up to 10 history slots.
2940         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props: Link against
2941         Windows utility library to allow use of _bstr_t type.
2942         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h: Add menu items
2943         to hold up to 10 history slots.
2944         * WinLauncher/stdafx.h: Add <comutil.h> to precompiled headers.
2945
2946 2013-09-16  Gustavo Noronha Silva  <gns@gnome.org>
2947
2948         [GTK] Make symbol export filter more strict, and disable for dev/test builds
2949         https://bugs.webkit.org/show_bug.cgi?id=120586
2950
2951         Reviewed by Martin Robinson.
2952
2953         * GNUmakefile.am: moved GtkLauncher and documentation builds to their own
2954         makefiles, so they can be included unconditionally.
2955         * GtkLauncher/GNUmakefile.am: added.
2956         * Scripts/webkitdirs.pm:
2957         (runAutogenForAutotoolsProjectIfNecessary): always pass --enable-developer-mode
2958         to configure, since we consider builds done through build-webkit to be development
2959         and test builds.
2960         * gtk/GNUmakefile.am: added.
2961         * gtk/common.py: do not use the Scripts directory as a reference to the top path;
2962         it's not necessary and it will not work now that the Scripts directory is not
2963         shipped in the tarball.
2964
2965 2013-09-16  Anders Carlsson  <andersca@apple.com>
2966
2967         WTF::Deque should work with move only types
2968         https://bugs.webkit.org/show_bug.cgi?id=121446
2969
2970         Reviewed by Andreas Kling.
2971
2972         * TestWebKitAPI/Tests/WTF/Deque.cpp:
2973         (TestWebKitAPI::TEST):
2974         Add a test.
2975
2976 2013-09-16  Wojciech Bielawski  <w.bielawski@samsung.com>
2977
2978         [WKTR] WebKitTestRunner's eventSender.contextClick() returns objects without implemented click() method.
2979         https://bugs.webkit.org/show_bug.cgi?id=98410
2980
2981         Reviewed by Darin Adler.
2982
2983         Add implementation of click() method of objects returned by eventSender.contextClick().
2984
2985         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2986         (MenuItemPrivateData):
2987         (WTR::menuItemClickCallback):
2988         (WTR::getMenuItemTitleCallback):
2989         (WTR::staticMenuItemFinalize):
2990         (WTR::getMenuItemClass):
2991         (WTR::EventSendingController::contextClick):
2992
2993 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
2994
2995         Make the GDB webkit.py script compatible with Python v3
2996         https://bugs.webkit.org/show_bug.cgi?id=121395
2997
2998         Reviewed by Ryosuke Niwa.
2999
3000         GDB fails to load the printing helpers from the webkit.py script if Python v3 is used. To avoid that,
3001         uses of xrange() in the script are replaced with range(), and the print statements are changed into
3002         the print() function invocations.
3003
3004         * gdb/webkit.py:
3005         (guess_string_length):
3006         (ustring_to_string):
3007         (lstring_to_string):
3008         (WTFCStringPrinter.to_string):
3009         (PrintPathToRootCommand.invoke):
3010
3011 2013-09-15  Zan Dobersek  <zdobersek@igalia.com>
3012
3013         [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched
3014         https://bugs.webkit.org/show_bug.cgi?id=119631
3015
3016         Reviewed by Ryosuke Niwa.
3017
3018         The perf profiler is attached to the test runner after the test runner has been launched,
3019         but in the case of WebKitTestRunner, this is done after the WebProcess was spawned by the
3020         UIProcess, meaning that WebProcess operations will not be profiled.
3021
3022         To avoid that, the perf profiler is changed to provide a wrapper command for the test runner.
3023         This is done in the scope of already present support for wrapper scripts (such as valgrind)
3024         that are settable through the --wrapper option. This causes the perf profiler to correctly
3025         continue profiling the WebProcess after it was spawned.
3026
3027         When the profiler is launched, a wait process is launched with the profiler's pid as the
3028         argument. This ensures we can check that the profiler exited normally. If it did not, its
3029         output can be corrupted and can cause problems when that output is examined. The after-exit
3030         report is avoided in that case.
3031
3032         * Scripts/webkitpy/common/system/profiler.py:
3033         (Profiler.wrapper_arguments): The method returns an empty list by default.
3034         (Perf.__init__): Remove unnecessary member variables.
3035         (Perf.attach_to_pid): Launch the wait process with the profiler's pid as the argument.
3036         (Perf.wrapper_arguments): Used instead of attaching the profiler to the profiled process' pid,
3037         the method returns a list of arguments that should be used as a wrapper for the test runner.
3038         The arguments specify the 'perf record' command, with the output file and the instruction to
3039         construct the call graph given as well.
3040         (Perf._first_ten_lines_of_profile): Prettify the output by avoiding the unnecessary trailing
3041         whitespace in the profile lines.
3042         (Perf.profile_after_exit): Kill the profiler process through its pid if the wait process is still
3043         running. If it is running even after that, or if the profiler process produced a non-zero exit
3044         code, the method reports the profiling failure and returns. Otherwise it continues on reporting
3045         the top 10 lines of the profile and how to examine the profile further.
3046         * Scripts/webkitpy/port/driver.py:
3047         (Driver._command_wrapper): The method is now a member of the Driver class, returning the wrapper
3048         as specified by the --wrapper option if given, or the profiler wrapper if the profiler is present,
3049         or an empty list otherwise.
3050         (Driver.cmd_line):
3051         * Scripts/webkitpy/port/driver_unittest.py:
3052         (DriverTest.make_port): Adjusted so mock host or options objects can be specified
3053         for the testing-specific Port object.
3054         (DriverTest._assert_wrapper): Pass a MockOptions object with the wrapper value to the make_port method,
3055         as the Driver._command_wrapper now operates on the option's value directly rather than accepting it through
3056         a parameter.
3057         (DriverTest.test_profiler_as_wrapper): Provide a test case to check the correct profiler wrapper is used
3058         when profiling on the Linux platform with the perf profiler.
3059
3060 2013-09-14  Dan Bernstein  <mitz@apple.com>
3061
3062         [mac] Check For Framework Include Consistency build phase checks the wrong framework
3063         https://bugs.webkit.org/show_bug.cgi?id=121215
3064
3065         Reviewed by Mark Rowe.
3066
3067         * Scripts/check-for-webkit-framework-include-consistency: Replaced hard-coded paths to
3068         WebKit.framework’s Headers and PrivateHeaders directories with the current target’s
3069         public and private headers folder paths. Also tweaked the error messages’ format to make
3070         Xcode recognize them as errors.
3071
3072 2013-09-14  Alberto Garcia  <berto@igalia.com>
3073
3074         [GTK] Fails to compile if the build directory is in a different partition
3075         https://bugs.webkit.org/show_bug.cgi?id=121296
3076
3077         Reviewed by Martin Robinson.
3078
3079         Instead of using os.symlink() to install the gtk-doc templates,
3080         use os.link() first and fall back to os.symlink() if it fails.
3081
3082         * gtk/gtkdoc.py:
3083         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3084
3085 2013-09-14  Alberto Garcia  <berto@igalia.com>
3086
3087         [GTK] WebKitGTK+ is linking against libxslt in too many places
3088         https://bugs.webkit.org/show_bug.cgi?id=121356
3089
3090         Reviewed by Martin Robinson.
3091
3092         TestWebCore, WebKitTestRunner and MiniBrowser don't use libxslt,
3093         so we don't need to link against it.
3094
3095         * MiniBrowser/gtk/GNUmakefile.am:
3096         * TestWebKitAPI/GNUmakefile.am:
3097         * WebKitTestRunner/GNUmakefile.am:
3098
3099 2013-09-14  Ross Burton  <ross.burton@intel.com>
3100
3101         Uses gtk-doc tools even when --disable-gtk-doc passed
3102         https://bugs.webkit.org/show_bug.cgi?id=91239
3103
3104         Reviewed by Martin Robinson.
3105
3106         Don't run generate-gtkdoc on install if gtk-doc is disabled.
3107
3108         * GNUmakefile.am:
3109
3110 2013-09-14  Alberto Garcia  <berto@igalia.com>
3111
3112         [GTK] Fails to compile if the build directory is in a different partition
3113         https://bugs.webkit.org/show_bug.cgi?id=121296
3114
3115         Reviewed by Carlos Garcia Campos.
3116
3117         Use symlinks instead of hard links to support building on a
3118         different file system.
3119
3120         * gtk/gtkdoc.py:
3121         (GTKDoc._copy_doc_files_to_output_dir.copy_file_replacing_existing):
3122
3123 2013-09-13  Darin Adler  <darin@apple.com>
3124
3125         Use a better name than m_invertibleCTM
3126         https://bugs.webkit.org/show_bug.cgi?id=121341
3127
3128         Reviewed by Andreas Kling.
3129
3130         * Scripts/do-webcore-rename: Updated to do this replace as we do.
3131
3132 2013-09-13  Anders Carlsson  <andersca@apple.com>
3133
3134         Pick the correct overload when a const reference is passed to appendSlowCase.
3135         https://bugs.webkit.org/show_bug.cgi?id=121326
3136
3137         Reviewed by Darin Adler.
3138
3139         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3140         (TestWebKitAPI::TEST):
3141
3142 2013-09-13  Darin Adler  <darin@apple.com>
3143
3144         Rename confusingly named "runtimeObject" functions
3145         https://bugs.webkit.org/show_bug.cgi?id=121339
3146
3147         Reviewed by Sam Weinig.
3148
3149         * Scripts/do-webcore-rename: Updated to do this replace as usual.
3150
3151 2013-09-13  Filip Pizlo  <fpizlo@apple.com>
3152
3153         DFG AI assumes that ToThis can never return non-object if it is passed an object, and operationToThis will get the wrong value of isStrictMode() if there's inlining
3154         https://bugs.webkit.org/show_bug.cgi?id=121330
3155
3156         Reviewed by Mark Hahnenberg and Oliver Hunt.
3157
3158         We should run tests even if they don't have expected files yet.
3159         
3160         * Scripts/run-layout-jsc:
3161
3162 2013-09-13  Anders Carlsson  <andersca@apple.com>
3163
3164         Use nullptr instead of 0 in calls to HashMap::add
3165         https://bugs.webkit.org/show_bug.cgi?id=121322
3166
3167         Reviewed by Sam Weinig.
3168
3169         * DumpRenderTree/mac/TestRunnerMac.mm:
3170         (TestRunner::evaluateScriptInIsolatedWorld):
3171         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3172         (WTR::TestRunner::evaluateScriptInIsolatedWorld):
3173
3174 2013-09-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
3175
3176         [GTK] Move to the new web inspector
3177         https://bugs.webkit.org/show_bug.cgi?id=120647
3178
3179         Reviewed by Carlos Garcia Campos.
3180
3181         * GtkLauncher/main.c:
3182         (main): no longer set WEBKIT_INSPECTOR_PATH.
3183         * MiniBrowser/gtk/main.c:
3184         (main): ditto.
3185         * Scripts/old-run-webkit-tests:
3186         (openDumpTool): ditto.
3187         * Scripts/run-gtk-tests: ditto.
3188         * Scripts/webkitpy/port/gtk.py:
3189         (GtkPort.setup_environ_for_server): ditto.
3190
3191 2013-09-13  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3192
3193         [Qt] REGRESSION(r154444): xss-DENIED test results changed
3194         https://bugs.webkit.org/show_bug.cgi?id=120595
3195
3196         Reviewed by Jocelyn Turcotte.
3197
3198         Avoid overwriting Qt meta properties, which we identify by them being undeletable.
3199
3200         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3201         (DumpRenderTree::initJSObjects):
3202
3203 2013-09-13  Darin Adler  <darin@apple.com>
3204
3205         Give actions in Range class NON_SHOUTING_NAMES
3206         https://bugs.webkit.org/show_bug.cgi?id=121280
3207
3208         Reviewed by Andreas Kling.
3209
3210         * Scripts/do-webcore-rename: Updated to do this replace, keeping with
3211         the tradition of checking in the last one we did, along with other
3212         rename ideas for the future.
3213
3214 2013-09-12  Lucas Forschler  <lforschler@apple.com>
3215
3216         Create short build logs for errors and warnings.
3217         https://bugs.webkit.org/show_bug.cgi?id=120614
3218
3219         Reviewed by Ryosuke Niwa.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3222             -include StringIO 
3223         (CompileWebKit.createSummary):
3224             -add a createSummary function which will parse out errors and warnings into a concise log file for quick viewing
3225
3226 2013-09-12  Roger Fong  <roger_fong@apple.com>
3227
3228         Update cygwin downloader to search for packages in the right location.
3229
3230         * CygwinDownloader/cygwin-downloader.py:
3231         * CygwinDownloader/cygwin-downloader.zip:
3232
3233 2013-09-12  Anders Carlsson  <andersca@apple.com>
3234
3235         Add rudimentary support for move-only types as values in HashMap
3236         https://bugs.webkit.org/show_bug.cgi?id=121226
3237
3238         Reviewed by Andreas Kling.
3239
3240         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3241         (TestWebKitAPI::TEST):
3242         Add a HashMap<unsigned, MoveOnly> test.
3243
3244 2013-09-12  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3245
3246         Auto GDB backtrace generation for EFL/GTK/Qt bots.
3247         https://bugs.webkit.org/show_bug.cgi?id=119338
3248
3249         Reviewed by Csaba Osztrogonác.
3250
3251         * Scripts/webkitpy/port/efl.py:
3252         (EflPort.check_sys_deps):
3253         (EflPort):
3254         (EflPort._get_crash_log):
3255         * Scripts/webkitpy/port/efl_unittest.py:
3256         (EflPortTest.test_show_results_html_file):
3257         (EflPortTest):
3258         (EflPortTest.test_get_crash_log):
3259         * Scripts/webkitpy/port/gtk.py:
3260         (GtkPort._get_crash_log):
3261         * Scripts/webkitpy/port/gtk_unittest.py:
3262         (GtkPortTest.test_get_crash_log):
3263         * Scripts/webkitpy/port/linux_get_crash_log.py: Added.
3264         (GDBCrashLogGenerator):
3265         (GDBCrashLogGenerator.__init__):
3266         (GDBCrashLogGenerator._get_gdb_output):
3267         (GDBCrashLogGenerator.generate_crash_log):
3268         (GDBCrashLogGenerator.generate_crash_log.match_filename):
3269         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py: Added.
3270         (GDBCrashLogGeneratorTest):
3271         (GDBCrashLogGeneratorTest.test_generate_crash_log):
3272         (_mock_gdb_output):
3273         * Scripts/webkitpy/port/qt.py:
3274         (QtPort.default_child_processes):
3275         (QtPort):
3276         (QtPort._get_crash_log):
3277         * Scripts/webkitpy/port/qt_unittest.py:
3278         (QtPortTest.test_check_sys_deps):
3279         (QtPortTest):
3280         (QtPortTest.test_get_crash_log):
3281
3282 2013-09-12  Peter Gal  <galpeter@inf.u-szeged.hu>
3283
3284         Unreviewed. Moving myself to the commiters list.
3285
3286         * Scripts/webkitpy/common/config/contributors.json:
3287
3288 2013-09-12  ChangSeok Oh  <changseok.oh@collabora.com>
3289
3290         [GTK] Add jhbuild-wayland.modules
3291         https://bugs.webkit.org/show_bug.cgi?id=120455
3292
3293         Reviewed by Gustavo Noronha Silva.
3294
3295         Current versions of gtk+, gdk-pixbuf and glib don't fit the requirement for wayland support.
3296         With this patch, you can build extra gtk+, gdk-pixbuf and glib through jhbuild with exporting
3297         WEBKIT_EXTRA_MODULESETS.
3298
3299         * gtk/jhbuild-wayland.modules: Added.
3300
3301 2013-09-12  Mario Sanchez Prada  <mario.prada@samsung.com>
3302
3303         [GTK][WK2] a11y tests unconditionally launching a11y daemons
3304         https://bugs.webkit.org/show_bug.cgi?id=120299
3305
3306         Reviewed by Carlos Garcia Campos.
3307
3308         Use the right variable name to store a reference to the at-spi2
3309         bus launcher process, so we can be sure we are terminating it when
3310         calling _tear_down_testing_environment().
3311
3312         * Scripts/run-gtk-tests:
3313         (TestRunner._start_accessibility_daemons): Use _spi_bus_launcher
3314         instead of _ally_bus_launcher.
3315
3316 2013-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3317
3318         [GTK] run-gtk-tests option --skipped=ignore doesn't work when the entire suite is skipped
3319         https://bugs.webkit.org/show_bug.cgi?id=121218
3320
3321         Reviewed by Philippe Normand.
3322
3323         Skipping the entire suite was added to skip tests when they can't
3324         be run because of the environment, for example to skip the a11y
3325         tests when the at-spi daemons fail to start. This is no longer
3326         true for all the cases, so we can disable the tests that are
3327         impossible to run instead of skipping them.
3328
3329         * Scripts/run-gtk-tests:
3330         (TestRunner.__init__): Initialize the skipped tests list.
3331         (TestRunner._setup_testing_environment): Add
3332         TestWebKitAccessibility path to the list of disabled tests when
3333         at-spi daemon fail to start.
3334         (TestRunner._should_run_test_program): Check first if the test
3335         program is disabled and then whether it's skipped honoring the
3336         skipped command line option.
3337
3338 2013-09-12  Samuel White  <samuel_white@apple.com>
3339
3340         <meter> element text value exposed as AXTitle; should be exposing AXValueDescription
3341         https://bugs.webkit.org/show_bug.cgi?id=117651
3342
3343         Reviewed by Mario Sanchez Prada.
3344
3345         Prepended 'AXValueDescription: ' to valueDescription output and updated impacted tests.
3346
3347         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3348         (AccessibilityUIElement::valueDescription):
3349         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3350         (WTR::AccessibilityUIElement::valueDescription):
3351
3352 2013-09-12  Denis Nomiyama  <d.nomiyama@samsung.com>
3353
3354         REGRESSION(r154781): accessibility/notification-listeners.html is failing
3355         https://bugs.webkit.org/show_bug.cgi?id=120669
3356
3357         Reviewed by Chris Fleizach.
3358
3359         Fixed 4 problems that were causing notification-listeners.html to fail.
3360
3361         Notifications for AXFocusedUIElementChanged and AXValueChanged had to be
3362         implemented in axObjectEventListener().
3363
3364         A notification for AXFocusedUIElementChanged was incorrectly sent when
3365         the element lost focus.
3366
3367         Global notification was not dispatched if an element notification was
3368         present in the HashMap.
3369
3370         connectAccessibilityCallbacks() was connecting signals to callbacks
3371         multiple times because it was not checking if
3372         disconnectAccessibilityCallbacks() had an early return if there were
3373         active handlers.
3374
3375         * DumpRenderTree/atk/AccessibilityCallbacks.h: Modified
3376         disconnectAccessibilityCallbacks() to inform if the callbacks were
3377         successfully disconnected.
3378         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3379         (axObjectEventListener): Implemented notifications for
3380         AXFocusedUIElementChanged and AXValueChanged. Fixed the global
3381         notification, which was not dispatched if an element notification
3382         existed. Fixed the notification for AXFocusedUIElementChanged that was
3383         incorrectly sent when the element lost focus. In addition, fixed a typo
3384         where TRUE should be true.
3385         (connectAccessibilityCallbacks): Added early return if
3386         disconnectAccessibilityCallbacks() did not disconnect the callbacks.
3387         (disconnectAccessibilityCallbacks): Added a return value to inform if
3388         callbacks were successfully disconnected.
3389
3390 2013-09-11  Anders Carlsson  <andersca@apple.com>
3391
3392         Try to fix GCC builds.
3393
3394         * TestWebKitAPI/Tests/WTF/MoveOnly.h:
3395
3396 2013-09-11  Anders Carlsson  <andersca@apple.com>
3397
3398         Try to fix the build.
3399
3400         Move MoveOnly.h to Tests/WTF and fix the broken Xcode project that caused me to add the header
3401         file in the Tests/ directory in the first place.
3402
3403         * TestWebKitAPI/CMakeLists.txt:
3404         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
3405         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3406         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3407         * TestWebKitAPI/Tests/WTF/MoveOnly.h: Renamed from Tools/TestWebKitAPI/Tests/MoveOnly.h.
3408
3409 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3410
3411         [Windows] Build fix for MoveOnly
3412
3413         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props: Add
3414         Tests to include search path.
3415         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
3416         Ditto.
3417
3418 2013-09-11  Anders Carlsson  <andersca@apple.com>
3419
3420         Add HashSet::take
3421         https://bugs.webkit.org/show_bug.cgi?id=121192
3422
3423         Reviewed by Darin Adler.
3424
3425         Add a test for HashSet::take.
3426
3427         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3428         (TestWebKitAPI::TEST):
3429
3430 2013-09-11  Anders Carlsson  <andersca@apple.com>
3431
3432         HashSet should work with move only types
3433         https://bugs.webkit.org/show_bug.cgi?id=121188
3434
3435         Reviewed by Geoffrey Garen.
3436
3437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3438         * TestWebKitAPI/Tests/MoveOnly.h: Added.
3439         Move the MoveOnly class from Vector out into its own header.
3440
3441         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3442         (TestWebKitAPI::TEST):
3443         Add aHashSet<MoveOnly> test.
3444
3445         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3446         Include MoveOnly.h.
3447
3448 2013-09-11  Brent Fulgham  <bfulgham@apple.com>
3449
3450         [Windows] Avoid converting from IntSize->SIZE->IntSize
3451         https://bugs.webkit.org/show_bug.cgi?id=121180
3452
3453         Reviewed by Anders Carlsson.
3454
3455         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3456         (TestWebKitAPI::TEST): Use IntSize instead of SIZE struct.
3457
3458 2013-09-11  Dan Bernstein  <mitz@apple.com>
3459
3460         REGRESSION (r155561): extract-localizable-strings can miss strings
3461         https://bugs.webkit.org/show_bug.cgi?id=121184
3462
3463         Reviewed by Darin Adler.
3464
3465         * Scripts/extract-localizable-strings: Don’t discard lines if we are waiting for a closing
3466         parenthesis or bracket.
3467
3468 2013-09-11  Dan Bernstein  <mitz@apple.com>
3469
3470         update-webkit-localizable-strings is at least 5.8x slower than it should be
3471         https://bugs.webkit.org/show_bug.cgi?id=121178
3472
3473         Reviewed by Darin Adler.
3474
3475         * Scripts/extract-localizable-strings: Quickly skip over lines that contain neither " nor /*.
3476         Note that this does not change functionality, because the script already does not understand
3477         the line continuation sequence (backslash followed by a newline).
3478
3479 2013-09-11  Anders Carlsson  <andersca@apple.com>
3480
3481         Vector::append doesn't work if element type has overloaded operator&
3482         https://bugs.webkit.org/show_bug.cgi?id=121175
3483
3484         Reviewed by Brent Fulgham.
3485
3486         Add a test case.
3487
3488         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3489         (TestWebKitAPI::TEST):
3490
3491 2013-09-11  Anders Carlsson  <andersca@apple.com>
3492
3493         Implement Vector::append for move-only types
3494         https://bugs.webkit.org/show_bug.cgi?id=120805
3495
3496         Reviewed by Sam Weinig.
3497
3498         Add a test for Vector<MoveOnly>::append.
3499
3500         * TestWebKitAPI/Tests/WTF/Vector.cpp:
3501         (TestWebKitAPI::TEST):
3502
3503 2013-09-11  Csaba Osztrogonác  <ossy@webkit.org>
3504
3505         Unreviewed. Fix the indentation after r105848. Typo fix after r155523.
3506
3507         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3508         (RunAndUploadPerfTests):
3509         (RunAndUploadPerfTests.start):
3510         (RunAndUploadPerfTests.getText2):
3511
3512 2013-09-11  Anders Carlsson  <andersca@apple.com>
3513
3514         The style checker shouldn't complain about returning or passing OwnPtr
3515         https://bugs.webkit.org/show_bug.cgi?id=121163
3516
3517         Reviewed by Antti Koivisto.
3518
3519         * Scripts/webkitpy/style/checkers/cpp.py:
3520         (check_function_definition_and_pass_ptr):
3521         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3522         (PassPtrTest.test_pass_ref_ptr_return_value):
3523         (PassPtrTest.test_own_ptr_parameter_value):
3524
3525 2013-09-11  Mario Sanchez Prada  <mario.prada@samsung.com>
3526
3527         [GTK] Remove Gail dependency from build system for GTK3
3528         https://bugs.webkit.org/show_bug.cgi?id=119673
3529
3530         Reviewed by Gustavo Noronha Silva.
3531
3532         * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
3533         * Scripts/webkitpy/port/gtk.py:
3534         (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
3535         * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
3536
3537 2013-09-11  Gabor Abraham  <abrhm@inf.u-szeged.hu>
3538
3539         Performance tester bots should report the number of failing tests
3540         https://bugs.webkit.org/show_bug.cgi?id=120462
3541
3542         Reviewed by Csaba Osztrogonác.
3543
3544         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3545         (RunAndUploadPerfTests.start.getText):
3546         (RunAndUploadPerfTests.start):
3547         (RunAndUploadPerfTests):
3548         (RunAndUploadPerfTests.start.getText2):
3549
3550 2013-09-11  Krzysztof Czech  <k.czech@samsung.com>
3551
3552         [ATK] Adds mapping MenuItemRadioRole to ATK
3553         https://bugs.webkit.org/show_bug.cgi?id=121149
3554
3555         Reviewed by Mario Sanchez Prada.
3556
3557         Adds mapping MenuItemRadioRole to ATK.
3558
3559         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3560         (roleToString):
3561         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3562         (WTR::roleToString):
3563
3564 2013-09-10  Csaba Osztrogonác  <ossy@webkit.org>
3565
3566         Unreviewed fix after the unreviewed r155498 to unbreak the failure
3567         counter of run-javascriptcore-tests build step on build.webkit.org.
3568
3569         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3570         (RunJavaScriptCoreTests.commandComplete):
3571         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3572
3573 2013-09-10  Filip Pizlo  <fpizlo@apple.com>
3574
3575         Unreviewed, be a bit more clear about what we mean by 'js' tests. I think this
3576         got a bit overlooked from the fast/js->js refactoring.
3577
3578         * Scripts/run-javascriptcore-tests:
3579
3580 2013-09-10  Daniel Bates  <dabates@apple.com>
3581
3582         [iOS] Upstream text autosizing
3583         https://bugs.webkit.org/show_bug.cgi?id=121111
3584
3585         Reviewed by Andy Estes and Sam Weinig.
3586
3587         Implement infrastructure to test the iOS text autosizing code.
3588
3589         * DumpRenderTree/TestRunner.cpp:
3590         (setTextAutosizingEnabledCallback): Added.
3591         (TestRunner::staticFunctions):
3592         * DumpRenderTree/TestRunner.h:
3593         * DumpRenderTree/mac/DumpRenderTree.mm:
3594         (resetDefaultsToConsistentValues):
3595         * DumpRenderTree/mac/TestRunnerMac.mm:
3596         (TestRunner::setTextAutosizingEnabled): Added.
3597
3598 2013-09-10  Mark Hahnenberg  <mhahnenberg@apple.com>
3599
3600         run-jsc-stress-tests should have a mode for always running the copy phase
3601         https://bugs.webkit.org/show_bug.cgi?id=121128
3602
3603         Reviewed by Geoffrey Garen.
3604
3605         This will increase test coverage of the copying phase, which might not always get 
3606         triggered normally with our default parameters for required Heap/CopiedBlock utilization.
3607
3608         * Scripts/run-jsc-stress-tests:
3609
3610 2013-09-10  Sergio Correia  <sergio.correia@openbossa.org>
3611
3612         [EFL][JHBUILD] Use a tarball for libseccomp, instead of git
3613         https://bugs.webkit.org/show_bug.cgi?id=121114
3614
3615         Reviewed by Christophe Dumez.
3616
3617         Use a tarball for libseccomp instead of git to avoid network issues on
3618         the buildbots while checking out the git repo. Using tarballs has the
3619         advantage of them being cached if the checksum matches, in which case
3620         there will be no need to download them again.
3621
3622         * efl/jhbuild.modules:
3623
3624 2013-09-10  Mark Lam  <mark.lam@apple.com>
3625
3626         Replace remaining "fast js" names in scripts.
3627         https://bugs.webkit.org/show_bug.cgi?id=120899.
3628
3629         Rubber stamped by Filip Pizlo.
3630
3631         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3632         (test_layout_failure_new_output):
3633         (test_layout_crash_new_output):
3634         (test_mozilla_and_layout_failure_new_output):
3635         * Scripts/run-fast-jsc: Removed.
3636         * Scripts/run-javascriptcore-tests:
3637         * Scripts/run-layout-jsc: Copied from Tools/Scripts/run-fast-jsc.
3638
3639 2013-09-10  Zan Dobersek  <zdobersek@igalia.com>
3640
3641         Enable JSC stress tests for the rest of non-Windows platforms
3642         https://bugs.webkit.org/show_bug.cgi?id=121021
3643
3644         Reviewed by Filip Pizlo.
3645
3646         The JSC stress tests can already be enabled on Linux-based ports.
3647
3648         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3649         (RunJavaScriptCoreTests.commandComplete): Reformulate the regular expressions used to find the number of regressed
3650         JSC tests of various test suites. The expressions now look for the suite-specific report compartment over the
3651         complete output, with the number of failing or crashing tests properly extracted.
3652         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a couple of unit tests and expand the tested
3653         output in other unit tests testing the parsing of the output in the new format.
3654         (test_jsc_stress_failure_new_output):
3655         (test_fast_js_crashes_and_jsc_stress_failures_new_output):
3656         * Scripts/run-javascriptcore-tests: Enable the JSC stress tests on all but the Apple Win port.
3657         * Scripts/run-jsc-stress-tests: `sysctl -n hw.availcpu` doesn't work on Linux-based ports but the numProcesses
3658         variable is still gracefully assigned a zero value. In that case, try running `nproc --all` to gather the number
3659         of available CPUs so the stress tests can be run in parallel.
3660
3661 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
3662
3663         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
3664         https://bugs.webkit.org/show_bug.cgi?id=120552
3665
3666         Unreviewed build fix.
3667
3668         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3669         (AccessibilityUIElement::classList):
3670
3671 2013-09-10  Chris Fleizach  <cfleizach@apple.com>
3672
3673         AX: Expose DOM ID and ClassList to AX APIs for automation and AT element hashes
3674         https://bugs.webkit.org/show_bug.cgi?id=120552
3675
3676         Reviewed by Darin Adler.
3677
3678         * DumpRenderTree/AccessibilityUIElement.cpp:
3679         (getClassListCallback):
3680         (AccessibilityUIElement::getJSClass):
3681         * DumpRenderTree/AccessibilityUIElement.h:
3682         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3683         (AccessibilityUIElement::classList):
3684         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
3685         (AccessibilityUIElement::classList):
3686         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3687         (AccessibilityUIElement::classList):
3688         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3689         (AccessibilityUIElement::classList):
3690         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3691         (WTR::AccessibilityUIElement::classList):
3692         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3693         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3694         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3695         (WTR::AccessibilityUIElement::classList):
3696         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3697         (WTR::AccessibilityUIElement::classList):
3698
3699 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
3700
3701         [GTK] accessibility/loading-iframe-sends-notification.html is failing
3702         https://bugs.webkit.org/show_bug.cgi?id=98370
3703
3704         Reviewed by Chris Fleizach.
3705
3706         Added AXLayoutComplete for the GTK platform.
3707
3708         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
3709         (axObjectEventListener): Added notification AXLayoutComplete for
3710         layout-complete signal.
3711
3712 2013-09-09  Brent Fulgham  <bfulgham@apple.com>
3713
3714         [Windows] Change from using OwnPtr<GDI Stuff> to new GDIObject.
3715         https://bugs.webkit.org/show_bug.cgi?id=120778
3716
3717         Reviewed by Anders Carlsson.
3718
3719         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
3720         (createBitmapContextFromWebView): Use GDIObject.
3721         * Scripts/webkitpy/style/checkers/cpp.py:
3722         (check_for_leaky_patterns): Update for GDIObject instead of adoptPtr and OwnPtr.
3723         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3724         (LeakyPatternTest.test_create_dc): Update for GDIObject instead of adoptPtr/OwnPtr.
3725         (LeakyPatternTest.test_create_compatible_dc): Ditto.
3726
3727 2013-09-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3728
3729         Unreviewed. Add myself as a committer.
3730
3731         * Scripts/webkitpy/common/config/contributors.json:
3732
3733 2013-09-10  Mark Lam  <mark.lam@apple.com>
3734
3735         Move LayoutTests/fast/js to LayoutTests/js.
3736         https://bugs.webkit.org/show_bug.cgi?id=120899.
3737
3738         Rubber stamped by Filip Pizlo.
3739
3740         Changed scripts to reflect the path change.
3741
3742         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3743         (RunJavaScriptCoreTests.commandComplete):
3744         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3745         (test_fast_js_failure_new_output):
3746         (test_fast_js_crash_new_output):
3747         (test_mozilla_and_fast_js_failure_new_output):
3748         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3749         (BlackBerry::WebKit::DumpRenderTree::runTests):
3750         * Scripts/make-script-test-wrappers:
3751         (findTemplateFiles):
3752         * Scripts/run-fast-jsc:
3753         * Scripts/run-javascriptcore-tests:
3754         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3755         (TestExpectations):
3756
3757 2013-09-10  Denis Nomiyama  <d.nomiyama@samsung.com>
3758
3759         [GTK] Missing DRT AccessibilityController::addNotificationListener implementation
3760         https://bugs.webkit.org/show_bug.cgi?id=70606
3761
3762         Reviewed by Mario Sanchez Prada.
3763
3764         Implemented the global notification listener for
3765         AccessibilityController. The signal is generated by
3766         AXObjectCache::postPlatformNotification() and received by
3767         axObjectEventListener(). axObjectEventListener will then invoke
3768         JSObjectCallAsFunction() with the respective callback function.
3769
3770         There is no additional test for this patch since its implementation will
3771         be tested by a11y layout tests that are currently skipped (e.g. bug
3772         98370).
3773
3774         * DumpRenderTree/AccessibilityController.h: Added a global notification
3775         handler for GTK+.
3776         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
3777         (AccessibilityController::AccessibilityController): Initializes the
3778         global handler with 0.
3779         (AccessibilityController::addNotificationListener): Creates the
3780         notification handler and sets the notification function callback.
3781         (AccessibilityController::removeNotificationListener): Removes the
3782         global handler.
3783
3784 2013-09-10  Krzysztof Czech  <k.czech@samsung.com>
3785
3786         [ATK] Incorrect type for holding float value
3787         https://bugs.webkit.org/show_bug.cgi?id=121091
3788
3789         Reviewed by Mario Sanchez Prada.
3790
3791         Variable is not set properly, because of it's type.
3792
3793         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3794         (WTR::alterCurrentValue):
3795
3796 2013-09-10  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3797
3798         [Qt] make use of qtHaveModule() 
3799         https://bugs.webkit.org/show_bug.cgi?id=121090
3800
3801         Reviewed by Jocelyn Turcotte.
3802         Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com>
3803
3804         Use qtHaveModule instead of our own haveQtModule.
3805
3806         * QtTestBrowser/QtTestBrowser.pro:
3807         * qmake/mkspecs/features/configure.prf:
3808         * qmake/mkspecs/features/features.prf:
3809         * qmake/mkspecs/features/functions.prf:
3810
3811 2013-09-10  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3812
3813         Unreviewed. Add myself as a committer.
3814
3815         * Scripts/webkitpy/common/config/contributors.json:
3816
3817 2013-09-10  Radu Stavila  <stavila@adobe.com>
3818
3819         Unreviewed. Added myself as a committer.
3820
3821         * Scripts/webkitpy/common/config/contributors.json:
3822
3823 2013-09-10  Mario Sanchez Prada  <mario.prada@samsung.com>
3824
3825         [GTK] Test /webkit/atk/getTextInParagraphAndBodyModerate fails
3826         https://bugs.webkit.org/show_bug.cgi?id=105538
3827
3828         Reviewed by Chris Fleizach.
3829
3830         Unskip passing test getTextInParagraphAndBodyModerate.
3831
3832         * Scripts/run-gtk-tests:
3833         (TestRunner): Unskip pasing test.
3834
3835 2013-09-09  Mark Lam  <mark.lam@apple.com>
3836
3837         Remove more references to the deleted js-test-style.css.
3838         https://bugs.webkit.org/show_bug.cgi?id=120899.
3839
3840         Reviewed by Ryosuke Niwa.
3841
3842         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3843         (translate_includes):
3844
3845 2013-09-09  Mark Lam  <mark.lam@apple.com>
3846
3847         Re-landing r155392 (Point Tools scripts to LayoutTests/resources).
3848         https://bugs.webkit.org/show_bug.cgi?id=120899.
3849
3850         Not reviewed.
3851
3852         The webkitpy test failure that resulted in the rollout is due to
3853         update_webgl_conformance_tests_unittest.py referencing js-test-style.css
3854         which is to be deleted. Deleting that line fixes the issue.
3855
3856         * Scripts/make-new-script-test:
3857         (makePathToSharedSources):
3858         * Scripts/run-fast-jsc:
3859         * Scripts/webkitperl/httpd.pm:
3860         (getDefaultConfigForTestDirectory):
3861         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3862         (LayoutTestApacheHttpd.__init__):
3863         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3864         (Lighttpd.__init__):
3865         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3866         (BaseTest.integration_test_port_and_root):
3867         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3868         (TestHttpServer.test_start_cmd):
3869         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3870         (translate_includes):
3871         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3872         (TestTranslation.test_include_rewriting):
3873
3874 2013-09-09  Mark Lam  <mark.lam@apple.com>
3875
3876         Rolling out r155392 (Point Tools scripts to LayoutTests/resources): breaks tests.
3877         https://bugs.webkit.org/show_bug.cgi?id=120899.
3878
3879         Not reviewed.
3880
3881         * Scripts/make-new-script-test:
3882         (makePathToSharedSources):
3883         * Scripts/run-fast-jsc:
3884         * Scripts/webkitperl/httpd.pm:
3885         (getDefaultConfigForTestDirectory):
3886         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3887         (LayoutTestApacheHttpd.__init__):
3888         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3889         (Lighttpd.__init__):
3890         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3891         (BaseTest.integration_test_port_and_root):
3892         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3893         (TestHttpServer.test_start_cmd):
3894         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3895         (translate_includes):
3896         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3897         (TestTranslation.test_include_rewriting):
3898
3899 2013-09-09  Mark Lam  <mark.lam@apple.com>
3900
3901         Point Tools scripts to LayoutTests/resources.
3902         https://bugs.webkit.org/show_bug.cgi?id=120899.
3903
3904         Reviewed by Ryosuke Niwa.
3905
3906         * Scripts/make-new-script-test:
3907         (makePathToSharedSources):
3908         * Scripts/run-fast-jsc:
3909         * Scripts/webkitperl/httpd.pm:
3910         (getDefaultConfigForTestDirectory):
3911         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3912         (LayoutTestApacheHttpd.__init__):
3913         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3914         (Lighttpd.__init__):
3915         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
3916         (BaseTest.integration_test_port_and_root):
3917         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3918         (TestHttpServer.test_start_cmd):
3919         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
3920         (translate_includes):
3921         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
3922         (TestTranslation.test_include_rewriting):
3923
3924 2013-09-09  Roger Fong  <roger_fong@apple.com>
3925
3926         Unreviewed. Update Cygwin Downloader to include lighttpd and download setup-x86.exe.
3927
3928         * CygwinDownloader/cygwin-downloader.py:
3929         * CygwinDownloader/cygwin-downloader.zip:
3930
3931 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
3932
3933         Unreviewed, fix Ruby exception handling.
3934
3935         * Scripts/run-jsc-stress-tests:
3936
3937 2013-09-09  Filip Pizlo  <fpizlo@apple.com>
3938
3939         Stress tests should test the jsc profiler (-p)
3940         https://bugs.webkit.org/show_bug.cgi?id=121043
3941
3942         Reviewed by Mark Hahnenberg.
3943         
3944         Add a runProfiler command that all tests could use. This requires profiler-test-helper,
3945         which first runs the JS test and then tries the output with display-profiler-output.
3946         But if any of the things required for this to work aren't present, we just do a simpler
3947         test that just uses "-p".
3948         
3949         Because I didn't want to pollute SunSpider with "//@ runProfiler", I added the ability
3950         to create test collections using a yaml file that specifies the test path and the
3951         command to run.
3952
3953         * Scripts/jsc-stress-test-helpers: Added.
3954         * Scripts/jsc-stress-test-helpers/profiler-test-helper: Added.
3955         * Scripts/run-javascriptcore-tests:
3956         * Scripts/run-jsc-stress-tests:
3957
3958 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
3959
3960         [webkitpy] Remove the DeprecatedPort class
3961         https://bugs.webkit.org/show_bug.cgi?id=121030
3962
3963         Reviewed by Ryosuke Niwa.
3964
3965         Remove the remaining uses of DeprecatedPort, folding its functionality into the Port class.
3966
3967         The various methods returning commands are moved from the DeprecatedPort class into the Port class,
3968         with the Port subclasses overriding specific methods as required.
3969
3970         * Scripts/webkitpy/common/config/ports.py: Removed.
3971         * Scripts/webkitpy/common/config/ports_mock.py: Removed.
3972         * Scripts/webkitpy/common/config/ports_unittest.py: Removed.
3973         * Scripts/webkitpy/port/base.py:
3974         (Port.tooling_flag): This method returns the command line argument that corresponds to the type of the port.
3975         It's formatted as '--port=port_name', where port_name is the port's name that's additionally appended the '-wk2'
3976         string if the port instance represents the WK2 variation of the port.
3977         (Port.script_shell_command): Moved here from the DeprecatedPort interface.
3978         (Port.make_args): Ditto.
3979         (Port.update_webkit_command): Ditto.
3980         (Port.check_webkit_style_command): Ditto.
3981         (Port.prepare_changelog_command): Ditto.
3982         (Port.build_webkit_command): Ditto.
3983         (Port.run_javascriptcore_tests_command): Ditto.
3984         (Port.run_webkit_unit_tests_command): Ditto.
3985         (Port.run_webkit_tests_command): Ditto.
3986         (Port.run_python_unittests_command): Ditto.
3987         (Port.run_perl_unittests_command): Ditto.
3988         (Port.run_bindings_tests_command): Ditto.
3989         * Scripts/webkitpy/port/base_unittest.py:
3990         (PortTest.test_build_webkit_command): Add a test for the Port.build_webkit_command() method that tests correct
3991         return value with different build types passed to the method.
3992         * Scripts/webkitpy/port/efl.py:
3993         (EflPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
3994         to the command line.
3995         * Scripts/webkitpy/port/efl_unittest.py:
3996         (EflPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
3997         variations of the EflPort class.
3998         * Scripts/webkitpy/port/gtk.py:
3999         (GtkPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
4000         to the command line.
4001         (GtkPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
4002         * Scripts/webkitpy/port/gtk_unittest.py:
4003         (GtkPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1
4004         and WK2 variations of the GtkPort class.
4005         * Scripts/webkitpy/port/mac_unittest.py:
4006         (MacTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
4007         variations of the MacPort class.
4008         * Scripts/webkitpy/port/qt.py:
4009         (QtPort.build_webkit_command): Override the Port.build_webkit_command() method, appending the necessary options
4010         to the command line.
4011         (QtPort.run_webkit_tests_command): Ditto for Port.run_webkit_tests_command().
4012         * Scripts/webkitpy/port/qt_unittest.py:
4013         (QtPortTest.test_commands): A thorough test of return values for all the new methods, for both the WK1 and WK2
4014         variations of the QtPort class.
4015         * Scripts/webkitpy/port/test.py:
4016         (TestPort.make_args): Return a mock value that's intended for testing.
4017         (TestPort.check_webkit_style_command): Return the script's name prepended with 'mock-'.
4018         (TestPort.update_webkit_command): Ditto.
4019         (TestPort.build_webkit_command): Ditto.
4020         (TestPort.prepare_changelog_command): Ditto.
4021         (TestPort.run_python_unittests_command): Ditto.
4022         (TestPort.run_perl_unittests_command): Ditto.
4023         (TestPort.run_javascriptcore_tests_command): Ditto.
4024         (TestPort.run_webkit_unit_tests_command): Ditto.
4025         (TestPort.run_webkit_tests_command): Ditto.
4026         (TestPort.run_bindings_tests_command): Ditto.
4027         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4028         (FlakyTestReporter.__init__): WebKitPatch.port() should be called now.
4029         * Scripts/webkitpy/tool/bot/irc_command.py:
4030         (Rollout._update_working_copy): Ditto.
4031         * Scripts/webkitpy/tool/commands/download_unittest.py:
4032         (DownloadCommandsTest.test_land_cowhand): Fix a typo, javacriptcore -> javascriptcore.
4033         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4034         (AbstractEarlyWarningSystem.run_command): Use the tooling flag as provided by the Port interface.
4035         * Scripts/webkitpy/tool/commands/queues.py:
4036         (PatchProcessingQueue.begin_work_queue): Remove the use of the DeprecatedPort. Create the port that will be used
4037         by the PatchProcessingQueue through the tool's port factory, and also pass it to the tool, keeping the nasty
4038         abstraction violation.
4039         (CommitQueue.run_command): Use the tooling flag as provided by the Port interface.
4040         * Scripts/webkitpy/tool/main.py:
4041         (WebKitPatch.__init__): self._deprecated_port -> self._port.
4042         (WebKitPatch.port): Replaces the WebKitPatch.deprecated_port() method, returns self._port.
4043         (WebKitPatch.handle_global_options): Create the Port object through the PortFactory.
4044         * Scripts/webkitpy/tool/mocktool.py:
4045         (MockTool.__init__): self._deprecated_port -> self._port. The TestPort object also has its name method overridden
4046         to return 'MockPort', as many output comparisons rely on the MockPort name. These should all be replaced later, in
4047         a separate patch.
4048         (MockTool.port): Mimicks WebKitPatch.port().
4049         * Scripts/webkitpy/tool/steps/build.py:
4050         (Build.build): WebKitPatch.port() should be called now.
4051         * Scripts/webkitpy/tool/steps/checkstyle.py:
4052         (CheckStyle.run): Ditto.
4053         * Scripts/webkitpy/tool/steps/commit.py:
4054         (Commit._check_test_expectations): Ditto.
4055         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4056         (PrepareChangeLog.run): Ditto.
4057         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4058         (PrepareChangeLogForRevert.run): Ditto.
4059         * Scripts/webkitpy/tool/steps/runtests.py:
4060         (RunTests.run): Ditto.
4061         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4062         (RunTestsTest.test_webkit_run_unit_tests): The unnecessary methods should now be overridden on MockTool._port.
4063         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4064         (StepsTest.test_runtests_args): Remove the MockTool._deprecated_port override, but don't replace it. Rather than
4065         that the expected test output is adjusted to contain the mock-* command names.
4066         * Scripts/webkitpy/tool/steps/update.py:
4067         (Update._update_command): WebKitPatch.port() should be called now.
4068         * Scripts/webkitpy/tool/steps/update_unittest.py:
4069         (UpdateTest.test_update_command_non_interactive): Override the MockTool._port for testing purposes with the port
4070         that corresponds to the removed DeprecatedPort subclasses.
4071         (UpdateTest.test_update_command_interactive): Ditto.
4072
4073 2013-09-09  Zan Dobersek  <zdobersek@igalia.com>
4074
4075         [GTK] 32-bit builder should run the JSC tests
4076         https://bugs.webkit.org/show_bug.cgi?id=119215
4077
4078         Reviewed by Philippe Normand.
4079
4080         Rename the TestClass member of the TestFactory and BuildAndTestFactory classes
4081         to a more descriptive name, 'LayoutTestClass'. In these two factory classes, the layout testing-specific
4082         steps are only added if the LayoutTestClass member was not overridden to the value of None in a
4083         derived class.
4084
4085         Remove the BuildAndAPITestFactory class and replace it with the BuildAndNonLayoutTestFactory class that
4086         is derived from the BuildAndTestFactory class and overrides the LayoutTestClass member to the value of None.
4087         This allows for builders of the BuildAndNonLayoutTest type to run all but the layout tests. This type
4088         is currently used by the GTK 32-bit builder - there's at the moment no interest to have the builder cover
4089         layout testing while other types of testing are still expected to be performed.
4090
4091         * BuildSlaveSupport/build.webkit.org-config/config.json:
4092         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4093         (BuildFactory.__init__):
4094         (TestFactory):
4095         (TestFactory.__init__):
4096         (BuildAndTestFactory):
4097         (BuildAndTestFactory.__init__):
4098         (BuildAndTestWebKit2Factory):
4099         (BuildAndTestWebKit2OnlyFactory):
4100         (BuildAndNonLayoutTestFactory):
4101         (TestLeaksFactory):
4102         (TestWebKit2Factory):
4103
4104 2013-09-09  Manuel Rego Casasnovas  <rego@igalia.com>
4105
4106         Unreviewed. Add myself as a committer.
4107
4108         * Scripts/webkitpy/common/config/contributors.json:
4109
4110 2013-09-09  Krzysztof Czech  <k.czech@samsung.com>
4111
4112         [AX][ATK] AccessibilityObject representing ProgressBar element should be ATK_VALUE type
4113         https://bugs.webkit.org/show_bug.cgi?id=121023
4114
4115         Reviewed by Mario Sanchez Prada.
4116
4117         Added mappings to ATK's ProgressBar element.
4118
4119         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
4120         (roleToString):
4121         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
4122         (WTR::roleToString):
4123
4124 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
4125
4126         run-jsc-stress-tests should be more paranoid about calling make
4127         https://bugs.webkit.org/show_bug.cgi?id=121011
4128
4129         Reviewed by Oliver Hunt.
4130         
4131         If it returns with any kind of error then bail out.  Also print the command being used
4132         in case we have to debug this, for example on the bots.  The extra verbosity isn't a
4133         big deal.
4134
4135         * Scripts/run-jsc-stress-tests:
4136
4137 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
4138
4139         Unreviewed, never pass Pathname to shellescape() as old versions of Ruby don't
4140         like that. Pass a string instead.
4141
4142         * Scripts/run-jsc-stress-tests:
4143
4144 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
4145
4146         run-jsc-stress-tests should run tests in parallel if possible
4147         https://bugs.webkit.org/show_bug.cgi?id=120996
4148
4149         Reviewed by Oliver Hunt.
4150         
4151         Run tests in parallel by using Makefile hacks. This lets make take care of all load
4152         balancing. It's a really awesome speed-up for these tests.
4153         
4154         This reduces the FTL debug build stress test run time from 8m18s to 2m11s. The 
4155         no-FTL debug build stress test time goes from 1m11s to 16s. This patch is pretty
4156         much awesome.
4157
4158         * Scripts/run-jsc-stress-tests:
4159
4160 2013-09-08  Filip Pizlo  <fpizlo@apple.com>
4161
4162         run-jsc-stress-tests should be smart enough to call JSRegress "regress/script-tests" rather than "script-tests"
4163         https://bugs.webkit.org/show_bug.cgi?id=120994
4164
4165         Reviewed by Geoffrey Garen.
4166         
4167         run-jsc-stress-tests accepts a list of directories containing tests.  It needs to
4168         come up with names for all of them.  Currently it uses the basename of the test
4169         directory.  But that means that JSRegress gets called "script-tests", which is
4170         unfortunate since any directory in LayoutTests containing .js files will be
4171         called "script-tests".  So, this changes run-jsc-stress-tests to use more than
4172         just the basename if the basename has the word "tests" in it.  This causes
4173         JSRegress to be called "regress/script-tests".
4174
4175         * Scripts/run-jsc-stress-tests:
4176
4177 2013-09-08  Sergio Correia  <sergio.correia@openbossa.org>
4178
4179         [EFL][JHBUILD] Fix evas build with giflib5
4180         https://bugs.webkit.org/show_bug.cgi?id=120863
4181
4182         Original patch from Doug Newgard, at https://phab.enlightenment.org/D200.
4183
4184         Reviewed by Anders Carlsson.
4185
4186         * efl/jhbuild.modules: Apply patch to fix evas build with giflib5.
4187         * efl/patches/evas-fix-build-with-giflib5.patch: Added.
4188
4189 2013-09-07  Filip Pizlo  <fpizlo@apple.com>
4190
4191         Only run FTL tests if we have the FTL
4192         https://bugs.webkit.org/show_bug.cgi?id=120974
4193
4194         Reviewed by Geoffrey Garen.
4195         
4196         Pass --ftl-jit down into run-jsc-stress-tests so that it knows what test
4197         variants to run.
4198
4199         * Scripts/build-jsc:
4200         * Scripts/run-javascriptcore-tests:
4201         * Scripts/run-jsc-stress-tests:
4202
4203 2013-09-07  Santosh Mahto  <santosh.ma@samsung.com>
4204
4205         removing --dialog-element from build-webkit --help option message
4206         https://bugs.webkit.org/show_bug.cgi?id=120955
4207
4208         Reviewed by Daniel Bates.
4209
4210         --dialog-element option is useless while building as
4211         Dialog Element support has been removed in following changeset.
4212         http://trac.webkit.org/changeset/154835
4213         http://trac.webkit.org/changeset/154870
4214
4215         * Scripts/webkitperl/FeatureList.pm:
4216         Removed --dialog-element option message.
4217
4218 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
4219
4220         It should be possible to run-javascriptcore-tests with only a subset of the test suites
4221         https://bugs.webkit.org/show_bug.cgi?id=120918
4222
4223         Reviewed by Dan Bernstein.
4224
4225         * Scripts/run-javascriptcore-tests:
4226
4227 2013-09-06  Commit Queue  <commit-queue@webkit.org>
4228
4229         Unreviewed, rolling out r155196.
4230         http://trac.webkit.org/changeset/155196
4231         https://bugs.webkit.org/show_bug.cgi?id=120919
4232
4233         Broke 16 tests on build.webkit.org (Requested by rniwa on
4234         #webkit).
4235
4236         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4237         (Manager._set_up_run):
4238
4239 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
4240
4241         The 'failed' file should report collectionName/testName rather than just
4242         testName.
4243
4244         Rubber stamped by Mark Hahnenberg.
4245
4246         * Scripts/run-jsc-stress-tests:
4247
4248 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
4249
4250         Fix run-jsc-stress-tests to run on bots with old Ruby.
4251         
4252         Also make it create a repro file.
4253
4254         Rubber stamped by Mark Hahnenberg.
4255
4256         * Scripts/run-jsc-stress-tests:
4257
4258 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
4259
4260         Actually increment $numFailures
4261
4262         Reviewed by Mark Hahnenberg.
4263
4264         * Scripts/run-jsc-stress-tests:
4265
4266 2013-09-06  Filip Pizlo  <fpizlo@apple.com>
4267
4268         Fix run-jsc-stress-tests to use Pathname instead of File.realpath.
4269         
4270         Also make it uses system() instead of popen(); that means that test output
4271         will go to the console. This reduces error detection flakiness. It's fine
4272         because stress tests don't print() unless they really have to.
4273
4274         Rubber stamped by Mark Hahnenberg.
4275
4276         * Scripts/run-jsc-stress-tests:
4277
4278 2013-09-05  Filip Pizlo  <fpizlo@apple.com>
4279
4280         Introduce a way to run benchmarks and JSRegress as stress tests with different jsc command-line options
4281         https://bugs.webkit.org/show_bug.cgi?id=120808
4282
4283