[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToConte...
[WebKit-https.git] / Tools / ChangeLog
1 2017-08-19  Wenson Hsieh  <wenson_hsieh@apple.com>
2
3         [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
4         https://bugs.webkit.org/show_bug.cgi?id=175509
5         <rdar://problem/33728169>
6
7         Reviewed by Ryosuke Niwa.
8
9         Removes ExternalSourceAttributedStringToContentEditable and adds
10         ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
11         text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
12         original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
13         debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
14         that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
15         other style attribute, such as color, carries over from the NSAttributedString to the DOM.
16
17         Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.
18
19         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
20         (TestWebKitAPI::TEST):
21
22 2017-08-18  Ryan Haddad  <ryanhaddad@apple.com>
23
24         Unreviewed, rolling out r220938.
25
26         The API tests added with this change are failing.
27
28         Reverted changeset:
29
30         "Add WTFLogChannel level to allow runtime log filtering"
31         https://bugs.webkit.org/show_bug.cgi?id=175731
32         http://trac.webkit.org/changeset/220938
33
34 2017-08-18  Devin Rousso  <webkit@devinrousso.com>
35
36         Unreviewed, change my email.
37
38         * Scripts/webkitpy/common/config/contributors.json:
39
40 2017-08-18  Jonathan Bedard  <jbedard@apple.com>
41
42         Fix leak-checking for iOS Simulators
43         https://bugs.webkit.org/show_bug.cgi?id=175735
44
45         Reviewed by Darin Adler.
46
47         If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
48         Simulator (or device) because the process will have already been killed by the time we
49         check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.
50
51         * Scripts/webkitpy/port/server_process.py:
52         (ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
53         (ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
54         and SimulatorProcess.
55         * Scripts/webkitpy/port/simulator_process.py:
56         (SimulatorProcess.stop): Before closing the process, check for leaks.
57
58 2017-08-18  Eric Carlson  <eric.carlson@apple.com>
59
60         Add WTFLogChannel level to allow runtime log filtering
61         https://bugs.webkit.org/show_bug.cgi?id=175731
62         <rdar://problem/33967234>
63
64         Reviewed by Jer Noble.
65
66         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
67         * TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.
68         (TestWebKitAPI::LoggingTest::output):
69         (TestWebKitAPI::TEST_F):
70
71 2017-08-18  Alexey Proskuryakov  <ap@apple.com>
72
73         Add Dean Johnson to contributors.json for Bugzilla autocomplete.
74
75         * Scripts/webkitpy/common/config/contributors.json:
76
77 2017-08-18  Ross Kirsling  <ross.kirsling@sony.com>
78
79         [Tools] Add script to download a GitHub release
80         https://bugs.webkit.org/show_bug.cgi?id=175279
81
82         Reviewed by Brent Fulgham.
83
84         * Scripts/download-latest-github-release.py: Added.
85
86 2017-08-18  Commit Queue  <commit-queue@webkit.org>
87
88         Unreviewed, rolling out r220854.
89         https://bugs.webkit.org/show_bug.cgi?id=175716
90
91         I'm not sure we really need this (Requested by KaL on
92         #webkit).
93
94         Reverted changeset:
95
96         "[GTK][WPE] Add NTLM authentication enabled API"
97         https://bugs.webkit.org/show_bug.cgi?id=122952
98         http://trac.webkit.org/changeset/220854
99
100 2017-08-17  Michael Catanzaro  <mcatanzaro@igalia.com>
101
102         [GTK] Make TestContextMenu work on Fedora
103         https://bugs.webkit.org/show_bug.cgi?id=175708
104
105         Reviewed by Carlos Garcia Campos.
106
107         TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
108         and my student last summer who was trying to work on a context menu API. It's trying to load
109         an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
110         entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
111         don't care to investigate. Let's switch it to WebM so I can move on.
112
113         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
114         (prepareContextMenuTestView):
115         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
116         * TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.
117
118 2017-08-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
119
120         check-webkit-style shouldn't check spacing in #elif preprocessor lines
121         https://bugs.webkit.org/show_bug.cgi?id=175652
122
123         Reviewed by Alex Christensen.
124
125         * Scripts/webkitpy/style/checkers/cpp.py:
126         (check_spacing):
127         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
128         (CppStyleTest.test_spacing_for_binary_ops):
129
130 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
131
132         Fix the build on other platforms after r220865
133         https://bugs.webkit.org/show_bug.cgi?id=175683
134
135         Reviewed by Tim Horton.
136
137         Check __IPHONE_OS_VERSION_MAX_ALLOWED instead of __IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
138         availability is determined by SDK version rather than deployment version.
139
140         * TestWebKitAPI/ios/UIKitSPI.h:
141
142 2017-08-17  Andreas Kling  <akling@apple.com>
143
144         Disable CSS regions at compile time
145         https://bugs.webkit.org/show_bug.cgi?id=175630
146
147         Reviewed by Antti Koivisto.
148
149         * Scripts/webkitperl/FeatureList.pm:
150         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
151
152 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
153
154         Unreviewed, try to fix the internal iOS 10 build after r220865.
155
156         * TestWebKitAPI/ios/UIKitSPI.h:
157
158         On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
159         extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
160         this compiler guard.
161
162 2017-08-17  Wenson Hsieh  <wenson_hsieh@apple.com>
163
164         [iOS] Respect type fidelities when copying image elements to the pasteboard
165         https://bugs.webkit.org/show_bug.cgi?id=175638
166         <rdar://problem/26556043>
167
168         Reviewed by Ryosuke Niwa.
169
170         Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
171         contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
172         used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.
173
174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
175         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
176         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
177         (TestWebKitAPI::TEST):
178         (TestWebKitAPI::presentActionSheetAndChooseAction):
179         (-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.
180         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
181         (checkEstimatedSize):
182         (checkSuggestedNameAndEstimatedSize):
183
184         Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.
185
186         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
187         (TestWebKitAPI::TEST):
188         * TestWebKitAPI/ios/DataInteractionSimulator.h:
189         * TestWebKitAPI/ios/UIKitSPI.h: Added.
190
191 2017-08-17  Jonathan Bedard  <jbedard@apple.com>
192
193         Recursively create resource load statistics folder for testing
194         https://bugs.webkit.org/show_bug.cgi?id=175676
195
196         Reviewed by Brady Eidson.
197
198         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
199         (WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.
200
201 2017-08-17  Carlos Garcia Campos  <cgarcia@igalia.com>
202
203         [GTK][WPE] Add NTLM authentication enabled API
204         https://bugs.webkit.org/show_bug.cgi?id=122952
205
206         Reviewed by Michael Catanzaro.
207
208         Add a test case to check we can enable/disable NTLM.
209
210         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
211         (testWebViewAuthenticationNTLM):
212         (beforeAll):
213
214 2017-08-16  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
215
216         [PAL] Move spi/ios and spi/win directories into PAL
217         https://bugs.webkit.org/show_bug.cgi?id=175171
218
219         Reviewed by Antti Koivisto.
220
221         * DumpRenderTree/mac/EventSendingController.mm:
222
223 2017-08-16  Andy Estes  <aestes@apple.com>
224
225         [Payment Request] Add an ENABLE flag and an experimental feature preference
226         https://bugs.webkit.org/show_bug.cgi?id=175622
227
228         Reviewed by Tim Horton.
229
230         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
231         * WebKitTestRunner/TestController.cpp:
232         (WTR::TestController::resetPreferencesToConsistentValues):
233
234 2017-08-15  Aakash Jain  <aakash_jain@apple.com>
235
236         undefined URL in PopoverTracker for failed step
237         https://bugs.webkit.org/show_bug.cgi?id=175593
238         <rdar://problem/33898769>
239
240         Reviewed by Daniel Bates.
241
242         This fix is a workaround for Buildbot 0.9 bug <https://github.com/buildbot/buildbot/issues/3529> where it
243         does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.
244
245         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
246         (BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
247         (BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.
248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
249         (BuildbotTestResults): Accept URL in constructor.
250
251 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
252
253         Remove Proximity Events and related code
254         https://bugs.webkit.org/show_bug.cgi?id=175545
255
256         Reviewed by Daniel Bates.
257
258         No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
259         and other related code.
260
261         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
262
263 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
264
265         Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
266         https://bugs.webkit.org/show_bug.cgi?id=175504
267
268         Reviewed by Sam Weinig.
269
270         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
271
272 2017-08-14  Simon Fraser  <simon.fraser@apple.com>
273
274         Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
275         https://bugs.webkit.org/show_bug.cgi?id=175557
276
277         Reviewed by Jon Lee.
278         
279         No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.
280
281         * DumpRenderTree/TestRunner.cpp:
282         (TestRunner::staticFunctions):
283         (setViewModeMediaFeatureCallback): Deleted.
284         * DumpRenderTree/TestRunner.h:
285         * DumpRenderTree/mac/TestRunnerMac.mm:
286         (TestRunner::setViewModeMediaFeature): Deleted.
287         * DumpRenderTree/win/TestRunnerWin.cpp:
288         (TestRunner::setViewModeMediaFeature): Deleted.
289         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
290
291 2017-08-14  Andy Estes  <aestes@apple.com>
292
293         REGRESSION (r220456): Crash in PreviewLoader::shouldCreateForMIMEType() when a ResourceResponse has a null MIME type
294         https://bugs.webkit.org/show_bug.cgi?id=175548
295         <rdar://problem/33866206>
296
297         Reviewed by Brady Eidson.
298
299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
300         * TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp: Added.
301         (TestWebKitAPI::TEST): Added an API test for PreviewLoader::shouldCreateForMIMEType().
302
303 2017-08-14  Youenn Fablet  <youenn@apple.com>
304
305         WPT server should be able to do logging even if its output folder is not created at launch time
306         https://bugs.webkit.org/show_bug.cgi?id=175543
307
308         Reviewed by Alexey Proskuryakov.
309
310         Removing no longer used stdout/stderr member variables.
311         Creating if needed the output folder so that we can create WPT server output log folder at WPT server launch time.
312
313         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
314         (WebPlatformTestServer.__init__):
315         (WebPlatformTestServer._prepare_config):
316         (WebPlatformTestServer._spawn_process):
317         (WebPlatformTestServer._stop_running_server):
318
319 2017-08-14  Daniel Bates  <dabates@apple.com>
320
321         webkit-patch: Passing --no-review should submit patch to EWS by default
322         https://bugs.webkit.org/show_bug.cgi?id=148899
323
324         Reviewed by David Kilzer.
325
326         Make "webkit-patch upload --no-review" and "webkit-patch post-commits --no-review" submit
327         the patch(es) for EWS analysis by default. Add a new optional command line argument, --no-ews,
328         to these commands to not submit a non-reviewed patch(es) for EWS analysis.
329
330         Frequently I want to post a draft of a patch without review to have the EWS bots process
331         it to catch build and test breakage before I clean it up and post it for formal review.
332         Currently this requires using "webkit-patch upload --no-review --open-bug" to upload the
333         patch and open the bug in Safari so that I can click the Submit for EWS analysis button.
334         We should teach "webkit-patch upload" and "webkit-patch post-commits" how to do this.
335
336         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
337         (Bugzilla._parse_attachment_id_from_add_patch_to_bug_response): Add helper function to
338         parse the attachment id from the response page after adding an attachment to the bug.
339         (Bugzilla.add_patch_to_bug): Modified to parse and return the attachment id from the
340         HTTP response after uploading the patch.
341         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
342         (MockBugzilla.add_patch_to_bug): Return a dummy attachment id for testing purposes.
343         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
344         (test__parse_attachment_id_from_add_patch_to_bug_response): Added.
345         * Scripts/webkitpy/tool/commands/upload.py:
346         (Upload): Add step SubmitToEWS to the list of steps when uploading a patch. 
347         (PostCommits.__init__): Add --no-ews option to the list of applicable option flags for
348         this command.
349         (PostCommits.execute): Submit the patch to EWS, if applicable.
350         * Scripts/webkitpy/tool/commands/upload_unittest.py:
351         (test_upload): Set options.ews to False as the upload command expects this option
352         to be specified.
353         (test_upload_with_no_review_and_ews): Added.
354         * Scripts/webkitpy/tool/steps/__init__.py: Import module SubmitToEWS.
355         * Scripts/webkitpy/tool/steps/options.py:
356         (Options): Added command line option --no-ews (defaults: False - submit to EWS).
357         * Scripts/webkitpy/tool/steps/postdiff.py:
358         (PostDiff.options): Add --no-ews option to the list of applicable option flags for
359         this command.
360         (PostDiff.run): Submit the patch to EWS, if applicable.
361         * Scripts/webkitpy/tool/steps/submittoews.py: Added.
362         (SubmitToEWS):
363         (SubmitToEWS.options): Return an empty array as we this step does not have any command line options.
364         (SubmitToEWS.run): Submit the specified attachment ids for EWS analysis.
365
366 2017-08-14  Ryan Haddad  <ryanhaddad@apple.com>
367
368         Disable two flaky VideoControlsManager API tests.
369
370         Unreviewed test gardening.
371
372         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
373         (TestWebKitAPI::TEST):
374
375 2017-08-14  Tim Horton  <timothy_horton@apple.com>
376
377         Only create directory and sandbox extension handle for storage directories if they are set
378         https://bugs.webkit.org/show_bug.cgi?id=175522
379
380         Reviewed by Brady Eidson.
381
382         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
383         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDoesNotLogDuringInitialization.mm: Added.
384         (TEST):
385         Add a test that making a WKWebView with an ephemeral WKWebsiteDataStore
386         doesn't log anything to stderr.
387
388 2017-08-14  Jonathan Bedard  <jbedard@apple.com>
389
390         sub-categorize Sandbox violation logs
391         https://bugs.webkit.org/show_bug.cgi?id=175536
392         <rdar://problem/33834416>
393
394         Reviewed by David Kilzer.
395
396         * Scripts/webkitpy/common/system/crashlogs.py:
397         (CrashLogs._parse_darwin_crash_log): Add 'Sandbox-' to the log name if the log is
398         a Sandbox violation.
399         (CrashLogs._find_all_logs_darwin): Update comment.
400         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
401         (make_mock_sandbox_report_darwin): Create a Sandbox violation log for testing. 
402         (CrashLogsTest.create_crash_logs_darwin): Add Sandbox violation to list of crashes.
403         (CrashLogsTest.test_find_all_log_darwin): 8 logs in testing instead of 7.
404         (CrashLogsTest.test_duplicate_log_darwin): Check for Sandbox violation log.
405         * Scripts/webkitpy/port/darwin.py:
406         (DarwinPort._merge_crash_logs): Handle Sandbox violation case.
407
408 2017-08-14  Daniel Bates  <dabates@apple.com>
409
410         Add Automator service to copy permalink to Clipboard
411         https://bugs.webkit.org/show_bug.cgi?id=170978
412
413         Reviewed by Joseph Pecoraro.
414
415         It is helpful to reference using a hyperlink a particular line of code when having
416         a discussion on IRC or in a bug. You can get such a link by navigating to the file
417         in the Trac Browse Source viewer and selecting the line your are interested in.
418         I found myself doing this often enough that I wrote an Automator service to do it
419         for me.
420
421         This Automator service works with Xcode 8 and Xcode 9 beta 5 (9M202q) or later.
422
423         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist: Added.
424         * CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow: Added.
425         * CopyPermalink/README: Added.
426
427 2017-08-14  Chris Dumez  <cdumez@apple.com>
428
429         Address flakiness related to download tests
430         https://bugs.webkit.org/show_bug.cgi?id=175338
431         <rdar://problem/33865119>
432
433         Unreviewed, forgot in r220626 to reset m_shouldLogDownloadCallbacks to false
434         between tests.
435
436         * WebKitTestRunner/TestController.cpp:
437         (WTR::TestController::resetStateToConsistentValues):
438
439 2017-08-11  Ryosuke Niwa  <rniwa@webkit.org>
440
441         Replace DATA_TRANSFER_ITEMS by a runtime flag and add a stub implementation
442         https://bugs.webkit.org/show_bug.cgi?id=175474
443         <rdar://problem/33844628>
444
445         Reviewed by Wenson Hsieh.
446
447         Enable dataTransfer.items by default in DumpRenderTree and WebKitTestRunner for testing purposes.
448
449         * DumpRenderTree/mac/DumpRenderTree.mm:
450         (resetWebPreferencesToConsistentValues):
451         * WebKitTestRunner/TestController.cpp:
452         (WTR::TestController::resetPreferencesToConsistentValues):
453
454 2017-08-12  Chris Dumez  <cdumez@apple.com>
455
456         Address flakiness related to download tests
457         https://bugs.webkit.org/show_bug.cgi?id=175338
458
459         Reviewed by Ryosuke Niwa.
460
461         - Update WKTR so that the flag set by testRunner.waitUntilDownloadFinished()
462           is actually queried when a download completes. Previously, this would be
463           identical to a call to testRunner.waitUntilDone() because any download
464           completion would call testRunner.notifyDone().
465         - Disable logging of download callbacks by default and add a
466           testRunner.setShouldLogDownloadCallbacks(true) API to allow tests to
467           enable such logging.
468
469         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
470         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
471         (WTR::InjectedBundle::didReceiveMessageToPage):
472         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
473         (WTR::TestRunner::setShouldLogDownloadCallbacks):
474         * WebKitTestRunner/InjectedBundle/TestRunner.h:
475         * WebKitTestRunner/TestController.cpp:
476         (WTR::TestController::downloadDidStart):
477         (WTR::TestController::decideDestinationWithSuggestedFilename):
478         (WTR::TestController::downloadDidFinish):
479         (WTR::TestController::downloadDidFail):
480         (WTR::TestController::downloadDidCancel):
481         * WebKitTestRunner/TestController.h:
482         (WTR::TestController::setShouldLogDownloadCallbacks):
483         * WebKitTestRunner/TestInvocation.cpp:
484         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
485
486 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
487
488         Create mock ITP data in testing to prevent grandfathering
489         https://bugs.webkit.org/show_bug.cgi?id=174720
490
491         Unreviewed follow-up fix for r220604.
492
493         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
494         (WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.
495
496 2017-08-11  Jonathan Bedard  <jbedard@apple.com>
497
498         Create mock ITP data in testing to prevent grandfathering
499         https://bugs.webkit.org/show_bug.cgi?id=174720
500         <rdar://problem/33457779>
501
502         Reviewed by Brent Fulgham.
503
504         We don't need to be triggering grandfathering when each test runner starts. On Mac,
505         this may launch plugins which can cause layout tests to fail later if the test
506         runner does not shut-down before the plugins unload.
507
508         * WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
509         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
510         (WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
511         prevent grandfathering from being triggered.
512         * WebKitTestRunner/ios/TestControllerIOS.mm:
513         (WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
514         * WebKitTestRunner/mac/TestControllerMac.mm:
515         (WTR::TestController::platformInitialize): Ditto.
516
517 2017-08-11  Sam Weinig  <sam@webkit.org>
518
519         WTF::Function does not allow for reference / non-default constructible return types
520         https://bugs.webkit.org/show_bug.cgi?id=175244
521         <rdar://problem/33801582>
522
523         Reviewed by Chris Dumez.
524
525         * TestWebKitAPI/Tests/WTF/Function.cpp:
526         (TestWebKitAPI::TEST):
527
528 2017-08-11  Carlos Garcia Campos  <cgarcia@igalia.com>
529
530         [Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
531         https://bugs.webkit.org/show_bug.cgi?id=175378
532
533         Reviewed by Sergio Villar Senin.
534
535         Add two test cases to check proxy authentication.
536
537         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
538         (Tunnel::Tunnel):
539         (Tunnel::~Tunnel):
540         (Tunnel::connect):
541         (Tunnel::connected):
542         (serverCallback):
543         (ProxyAuthenticationTest::ProxyAuthenticationTest):
544         (ProxyAuthenticationTest::~ProxyAuthenticationTest):
545         (ProxyAuthenticationTest::proxyServerPortAsString):
546         (testWebViewAuthenticationProxy):
547         (testWebViewAuthenticationProxyHTTPS):
548         (beforeAll):
549
550 2017-08-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
551
552         [GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
553         https://bugs.webkit.org/show_bug.cgi?id=175428
554
555         Both ports share the GStreamer code as multimedia backend and till
556         not so long they were using different versions. Now they do use
557         the same versions and it does not make any sense anymore (and
558         neither had sense before) to have differences in the modulesets.
559
560         In this patch I created a GStreamer moduleset and referenced it
561         from both GTK+'s and WPE's. GStreamer patches were also moved there.
562
563         Reviewed by Žan Doberšek.
564
565         * gstreamer/jhbuild.modules: Added.
566         * gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
567         * gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
568         * gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
569         * gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
570         * gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
571         * gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
572         * gtk/jhbuild.modules:
573         * wpe/jhbuild.modules:
574         * wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
575         * wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
576         * wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
577         * wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
578         * wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.
579
580 2017-08-10  Don Olmstead  <don.olmstead@sony.com>
581
582         Unreviewed, adding Ross Kirsling to contributors.json
583
584         * Scripts/webkitpy/common/config/contributors.json:
585
586 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
587
588         Unreviewed, attempt to fix build failure with VC2017
589
590         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
591         (TEST):
592
593 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
594
595         Unreviewed, suppress warnings on GCC
596
597         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
598         (TestWebKitAPI::CheckedArithmeticTester::run):
599
600 2017-08-10  Dan Bernstein  <mitz@apple.com>
601
602         [Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
603         https://bugs.webkit.org/show_bug.cgi?id=173223
604
605         Reviewed by Tim Horton.
606
607         The rebuilds were happening due to a difference in the compiler options that the IDE and
608         xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
609         xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
610         INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
611         Advanced when a Custom Absolute path is selected.
612
613         * Scripts/webkitdirs.pm:
614         (determineBaseProductDir):
615
616 2017-08-10  Yusuke Suzuki  <utatane.tea@gmail.com>
617
618         Run more WTF tests
619         https://bugs.webkit.org/show_bug.cgi?id=174970
620
621         Reviewed by Michael Catanzaro.
622
623         Some of WTF tests are not executed in non Apple ports while they are generic ones.
624         This patch adds these tests to non-Apple port TestWebKitAPI.
625         Currently, we do not add Signals.cpp since it depends on signal functionality.
626
627         * TestWebKitAPI/CMakeLists.txt:
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
629         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
630         (isHigherPriority):
631         (TEST):
632         * TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
633         (TEST):
634         * TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
635         (TEST):
636
637 2017-08-10  obinna obike  <oobike@apple.com>
638
639         Remove obsolete link from webkit-queues status page
640         https://bugs.webkit.org/show_bug.cgi?id=175337
641
642         Reviewed by Aakash Jain.
643
644         * QueueStatusServer/templates/recentstatus.html:
645         Removed the link to the ews-watcher server.
646
647 2017-08-10  Brian Burg  <bburg@apple.com>
648
649         WKPreferences should conform to NSCopying
650         https://bugs.webkit.org/show_bug.cgi?id=175303
651         <rdar://problem/33764939>
652
653         Reviewed by Dan Bernstein.
654
655         Add unit test to make sure a WKPreference and its copy are
656         not aliased to each other or affect each other's properties.
657
658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
659         * TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
660         (TEST):
661
662 2017-08-10  Tim Horton  <timothy_horton@apple.com>
663
664         Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
665         https://bugs.webkit.org/show_bug.cgi?id=175436
666         <rdar://problem/33667497>
667
668         Reviewed by Simon Fraser.
669
670         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
671         (TestWebKitAPI::TEST_F):
672
673 2017-08-10  Lucas Forschler  <lforschler@apple.com>
674
675         Fix duplicated code in r220534.
676
677         Unreviewed cleanup.
678
679         * Scripts/bisect-builds:
680
681 2017-08-08  Jiewen Tan  <jiewen_tan@apple.com>
682
683         [WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
684         https://bugs.webkit.org/show_bug.cgi?id=175344
685         <rdar://problem/28507240>
686
687         Reviewed by Alexey Proskuryakov.
688
689         Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
690         Finally enable the existing tests for iOS.
691
692         * TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
693         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
694         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
695         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
696
697 2017-08-10  Lucas Forschler  <lforschler@apple.com>
698
699         Write a tool to bisect WebKit builds
700         https://bugs.webkit.org/show_bug.cgi?id=174596
701
702         Reviewed by Dean Johnson and Kocsen Chung.
703
704         * Scripts/bisect-builds: Added.
705         (bisect_builds): main bisection algorithm
706         (download_archive):download an archive from S3 using existing tools
707         (extract_archive):extract an archive using existing tools
708         (find_le):Find rightmost value less than or equal to x
709         (find_ge):Find leftmost item greater than or equal to x
710         (get_api_url):generate url for the rest api/database
711         (get_indices_from_revisions):convert revisions to list indexes for bisection
712         (get_sorted_revisions):retrieve sorted revision list
713         (get_s3_location_for_revision):calculate the S3 archive storage location
714         (parse_args):parse command line arguments
715         (pick_next_build):compute the next build to bisect
716         (prompt_did_reproduce):prompt user for direction for bisection
717         (set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
718         (test_archive):Platform specific logic to test downloaded archive
719         (minified_platforms):return a list of minified platforms in the database
720         (unminified_platforms):return a list of full platforms in the database
721         (is_supported_platform):check if platform is supported
722         (validate_options):validate command line options
723         (main):
724
725 2017-08-10  Lucas Forschler  <lforschler@apple.com>
726
727         Remove bisect-builds script.
728         https://bugs.webkit.org/show_bug.cgi?id=175433
729         
730         Reviewed by Aakash Jain.
731
732         * Scripts/bisect-builds: Removed.
733
734 2017-08-10  Michael Catanzaro  <mcatanzaro@igalia.com>
735
736         Remove ENABLE_GAMEPAD_DEPRECATED
737         https://bugs.webkit.org/show_bug.cgi?id=175361
738
739         Reviewed by Carlos Garcia Campos.
740
741         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
742
743 2017-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
744
745         REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
746         https://bugs.webkit.org/show_bug.cgi?id=175426
747
748         Reviewed by Carlos Garcia Campos.
749
750         * gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
751
752 2017-08-10  Ms2ger  <Ms2ger@igalia.com>
753
754         Add Ms2ger as contributor.
755         https://bugs.webkit.org/show_bug.cgi?id=175325
756
757         Reviewed by Carlos Alberto Lopez Perez.
758
759         * Scripts/webkitpy/common/config/contributors.json:
760
761 2017-08-09  Dewei Zhu  <dewei_zhu@apple.com>
762
763         Fix run-benchmark after r220483.
764         https://bugs.webkit.org/show_bug.cgi?id=175415
765         <rdar://problem/33803003>
766
767         Reviewed by Ryosuke Niwa.
768
769         Update run-benchmark script to adapt new Timeout implementation introduced in r220483.
770
771         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
772         (WebServerBenchmarkRunner._run_one_test):
773
774 2017-08-09  Chris Dumez  <cdumez@apple.com>
775
776         Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
777         https://bugs.webkit.org/show_bug.cgi?id=175401
778
779         Reviewed by Brady Eidson.
780
781         * DumpRenderTree/mac/DumpRenderTree.mm:
782         (enableExperimentalFeatures):
783
784 2017-08-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
785
786         [PAL] Move spi/cocoa and spi/cg directories into PAL
787         https://bugs.webkit.org/show_bug.cgi?id=175175
788
789         Reviewed by Myles C. Maxfield.
790
791         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
792         * DumpRenderTree/mac/DumpRenderTree.mm:
793         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
794         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
795
796         * Scripts/webkitpy/style/checker.py:
797         * Scripts/webkitpy/style/checker_unittest.py:
798         (GlobalVariablesTest.test_path_rules_specifier):
799
800         Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h
801
802         * Scripts/webkitpy/style/checkers/cpp.py:
803         (check_braces):
804         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
805         (WebKitStyleTest.test_braces.CF_OPTIONS):
806         (WebKitStyleTest.test_braces):
807
808         Prevent CF_OPTIONS() from being handled as funtion definition.
809
810 2017-08-09  Don Olmstead  <don.olmstead@sony.com>
811
812         [WTF] Move TextStream into WTF
813         https://bugs.webkit.org/show_bug.cgi?id=175211
814
815         Reviewed by Myles C. Maxfield.
816
817         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
818
819 2017-08-09  Andy Estes  <aestes@apple.com>
820
821         Part 3 of: Rename DatabaseProcess to StorageProcess
822         https://bugs.webkit.org/show_bug.cgi?id=175034
823
824         Reviewed by Brady Eidson.
825
826         * WebKitTestRunner/TestController.cpp:
827         (WTR::TestController::databaseProcessName): Updated to return
828         "com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.
829
830 2017-08-09  Commit Queue  <commit-queue@webkit.org>
831
832         Unreviewed, rolling out r220466, r220477, and r220487.
833         https://bugs.webkit.org/show_bug.cgi?id=175411
834
835         This change broke existing API tests and follow up fixes did
836         not resolve all the issues. (Requested by ryanhaddad on
837         #webkit).
838
839         Reverted changesets:
840
841         https://bugs.webkit.org/show_bug.cgi?id=175244
842         http://trac.webkit.org/changeset/220466
843
844         "WTF::Function does not allow for reference / non-default
845         constructible return types"
846         https://bugs.webkit.org/show_bug.cgi?id=175244
847         http://trac.webkit.org/changeset/220477
848
849         https://bugs.webkit.org/show_bug.cgi?id=175244
850         http://trac.webkit.org/changeset/220487
851
852 2017-08-09  Sam Weinig  <sam@webkit.org>
853
854         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
855
856         Remove one addition of null Function test.
857
858 2017-08-09  Jonathan Bedard  <jbedard@apple.com>
859
860         Allow nested timeouts in webkitpy
861         https://bugs.webkit.org/show_bug.cgi?id=175390
862         <rdar://problem/33803003>
863
864         Reviewed by David Kilzer.
865
866         We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
867         which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
868         the executive to detect and recover from any issues connecting with devices.
869
870         * Scripts/webkitpy/benchmark_runner/utils.py:
871         (TimeoutError): Deleted.
872         (timeout): Deleted.
873         * Scripts/webkitpy/common/timeout_context.py: Added.
874         (Timeout): A timeout context designed to be nested.
875         (Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
876         (Timeout.TimeoutData.__init__):
877         (Timeout.default_handler): Timeout handler used if none is specified.
878         (Timeout.current): Access data about the most urgent timeout.
879         (Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
880         (Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
881         (Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
882         urgent timeout data.
883         (Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
884         most urgent timeout data, if such data exists.
885         * Scripts/webkitpy/common/timeout_context_unittest.py: Added.
886         (TimeoutContextTests):
887         (TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
888         (TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
889         (TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
890         (TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
891         over a less urgent outer timeout.
892         (TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
893         over a less urgent inner timeout.
894         (TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
895         (TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
896         (TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
897         (TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
898         (TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
899         * Scripts/webkitpy/port/simulator_process.py:
900         (SimulatorProcess._start): Use Timeout class.
901         * Scripts/webkitpy/xcode/simulated_device.py:
902         (SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
903         (SimulatedDevice.launch_app): Ditto.
904         (SimulatedDevice.launch_app._install_timeout): Deleted.
905         * Scripts/webkitpy/xcode/simulator.py:
906         (Simulator.wait_until_device_is_booted):Use Timeout class.
907         (Simulator.wait_until_device_is_in_state): Ditto.
908
909 2017-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
910
911         [iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
912         https://bugs.webkit.org/show_bug.cgi?id=175392
913         <rdar://problem/33783207>
914
915         Reviewed by Tim Horton and Megan Gardner.
916
917         Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
918
919         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
920
921 2017-08-09  Sam Weinig  <sam@webkit.org>
922
923         Update for https://bugs.webkit.org/show_bug.cgi?id=175244.
924
925         * TestWebKitAPI/Tests/WTF/Function.cpp:
926         Remove tests of null Functions, as they are no longer supported.
927
928 2017-08-09  Daniel Bates  <dabates@apple.com>
929
930         REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
931         https://bugs.webkit.org/show_bug.cgi?id=175247
932         <rdar://problem/33679804>
933
934         Reviewed by Brady Eidson.
935
936         Add tests for redirects.
937
938         * TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:
939         (TEST):
940         * TestWebKitAPI/cocoa/TestProtocol.mm:
941         (createRedirectURL):
942         (-[TestProtocol startLoading]):
943
944 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
945
946         Unreviewed, rolling out r220393.
947
948         This patch regresses the performance of WebPage::editorState.
949
950         Reverted changeset:
951
952         "[iOS WK2] WKWebView schedules nonstop layout after pressing
953         cmb+b,i,u inside a contenteditable div"
954         https://bugs.webkit.org/show_bug.cgi?id=175116
955         http://trac.webkit.org/changeset/220393
956
957 2017-08-08  obinna obike  <oobike@apple.com>
958
959         Created Individual EWS Pages
960         https://bugs.webkit.org/show_bug.cgi?id=174477
961
962         Reviewed by Aakash Jain.
963
964         Created individual pages for each EWS. Changed the link within each status bubble
965         to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.
966
967         * QueueStatusServer/handlers/patch.py:
968         (Patch.get): Handles the case for individual ews queue as well as for all EWS queues.
969         * QueueStatusServer/handlers/statusbubble.py:
970         (StatusBubble._build_bubble): Updated url for specific EWS.
971         * QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
972         * QueueStatusServer/templates/patch.html: Added a link to go directly to the page with
973         all ews queues.
974         * QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it
975         takes you directly to the individual ews page.
976
977 2017-08-08  Stephan Szabo  <stephan.szabo@sony.com>
978
979         Separate jsc stress test script writer from run-jsc-stress-tests
980         https://bugs.webkit.org/show_bug.cgi?id=175216
981
982         Reviewed by Mark Lam.
983
984         * Scripts/run-jsc-stress-tests:
985         * Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
986
987 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
988
989         Unreviewed, fix Ubuntu LTS build
990         https://bugs.webkit.org/show_bug.cgi?id=174490
991
992         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
993
994 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
995
996         [Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
997         https://bugs.webkit.org/show_bug.cgi?id=175302
998         <rdar://problem/33762116>
999
1000         Reviewed by Tim Horton.
1001
1002         Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
1003         See WebKit ChangeLog for more details.
1004
1005         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1006         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
1007         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.
1008         (-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
1009         (-[SlowTextInputContext handleEvent:completionHandler:]):
1010         (-[SlowInputWebView inputContext]):
1011         (-[SlowInputWebView _web_superInputContext]):
1012         (TEST):
1013
1014 2017-08-08  John Wilander  <wilander@apple.com>
1015
1016         Resource Load Statistics: Clear web processes' state on history removal
1017         https://bugs.webkit.org/show_bug.cgi?id=175271
1018         <rdar://problem/33756560>
1019
1020         Reviewed by Chris Dumez.
1021
1022         Test infrastructure for asynchronous tests of website data
1023         removal for _WKWebsiteDataTypeResourceLoadStatistics.
1024
1025         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1026         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1027         (WTR::InjectedBundle::didReceiveMessageToPage):
1028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1029         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1030         (WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):
1031         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1032         * WebKitTestRunner/TestController.cpp:
1033         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1034         * WebKitTestRunner/TestController.h:
1035         * WebKitTestRunner/TestInvocation.cpp:
1036         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1037         (WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):
1038         * WebKitTestRunner/TestInvocation.h:
1039         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1040         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
1041
1042 2017-08-08  Alicia Boya García  <aboya@igalia.com>
1043
1044         Add Alicia Boya García as contributor
1045         https://bugs.webkit.org/show_bug.cgi?id=175326
1046
1047         Reviewed by Michael Catanzaro.
1048
1049         * Scripts/webkitpy/common/config/contributors.json:
1050
1051 2017-08-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1052
1053         [CMake] Properly test if compiler supports compiler flags
1054         https://bugs.webkit.org/show_bug.cgi?id=174490
1055
1056         Reviewed by Konstantin Tokarev.
1057
1058         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1059         * MiniBrowser/gtk/CMakeLists.txt:
1060         * TestRunnerShared/Bindings/JSWrapper.cpp:
1061         (WTR::JSWrapper::initialize):
1062         * TestWebKitAPI/CMakeLists.txt:
1063         * TestWebKitAPI/PlatformGTK.cmake:
1064         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1065         (TestWebKitAPI::CheckedArithmeticTester::run):
1066         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1067         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1068         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1069         (formControlsAssociatedCallback):
1070         * TestWebKitAPI/glib/CMakeLists.txt:
1071         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1072         (Test::getResourcesDir):
1073         * WebKitTestRunner/CMakeLists.txt:
1074         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1075         (WTR::menuItemClickCallback):
1076         (WTR::staticConvertMenuItemToType):
1077         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1078         (WTR::TestRunner::setUseDashboardCompatibilityMode):
1079         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1080         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
1081         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1082         (WTR::AccessibilityUIElement::helpText const):
1083         (WTR::AccessibilityUIElement::attributedStringForRange):
1084         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1085         (WTR::EventSenderProxy::updateTouchPoint):
1086         (WTR::EventSenderProxy::releaseTouchPoint):
1087
1088 2017-08-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1089
1090         [iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
1091         https://bugs.webkit.org/show_bug.cgi?id=175116
1092         <rdar://problem/28279301>
1093
1094         Reviewed by Darin Adler and Ryosuke Niwa.
1095
1096         Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
1097         EditorStateTests run on both iOS and Mac.
1098
1099         * TestWebKitAPI/EditingTestHarness.h: Added.
1100         * TestWebKitAPI/EditingTestHarness.mm: Added.
1101
1102         EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
1103         history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
1104         the state of the latest observed EditorState.
1105
1106         (-[EditingTestHarness initWithWebView:]):
1107         (-[EditingTestHarness dealloc]):
1108         (-[EditingTestHarness webView]):
1109         (-[EditingTestHarness latestEditorState]):
1110         (-[EditingTestHarness editorStateHistory]):
1111         (-[EditingTestHarness insertText:andExpectEditorStateWith:]):
1112         (-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
1113         (-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
1114         (-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
1115         (-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
1116         (-[EditingTestHarness toggleBold]):
1117         (-[EditingTestHarness toggleItalic]):
1118         (-[EditingTestHarness toggleUnderline]):
1119         (-[EditingTestHarness setForegroundColor:]):
1120         (-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
1121         (-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
1122         (-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
1123         (-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
1124         (-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
1125         (-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
1126         (-[EditingTestHarness _execCommand:argument:expectEntries:]):
1127
1128         Dispatches an editing command to the web process, and blocks until a response is received. If an expected
1129         entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
1130         keys and values.
1131
1132         (-[EditingTestHarness latestEditorStateContains:]):
1133         (-[EditingTestHarness _webView:editorStateDidChange:]):
1134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1135         * TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.
1136         (TestWebKitAPI::setUpEditorStateTestHarness):
1137         (TestWebKitAPI::TEST):
1138         * TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.
1139
1140 2017-08-04  Brent Fulgham  <bfulgham@apple.com>
1141
1142         Prevent domain from being set to a TLD
1143         https://bugs.webkit.org/show_bug.cgi?id=175226
1144         <rdar://problem/11079948>
1145
1146         Reviewed by Chris Dumez.
1147
1148         Extend the public suffix tests to include cases used by the
1149         Public Domain 'Public Suffix List'.
1150
1151         * TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
1152         (TestWebKitAPI::TEST):
1153
1154 2017-08-07  Stephan Szabo  <stephan.szabo@sony.com>
1155
1156         [XCode] webkit-patch should run sort-Xcode-project-file
1157         https://bugs.webkit.org/show_bug.cgi?id=174036
1158         <rdar://problem/33732709>
1159
1160         Reviewed by Simon Fraser.
1161
1162         * Scripts/webkitpy/common/config/ports.py:
1163         * Scripts/webkitpy/tool/commands/download.py:
1164         * Scripts/webkitpy/tool/commands/download_unittest.py:
1165         * Scripts/webkitpy/tool/commands/upload.py:
1166         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1167         * Scripts/webkitpy/tool/steps/__init__.py:
1168         * Scripts/webkitpy/tool/steps/options.py:
1169         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1170
1171 2017-08-07  Devin Rousso  <drousso@apple.com>
1172
1173         Web Inspector: Preview Canvas path when viewing a recording
1174         https://bugs.webkit.org/show_bug.cgi?id=174967
1175
1176         Reviewed by Brian Burg.
1177
1178         * DumpRenderTree/TestOptions.h:
1179         * DumpRenderTree/TestOptions.mm:
1180         (TestOptions::TestOptions):
1181         * DumpRenderTree/mac/DumpRenderTree.mm:
1182         (setWebPreferencesForTestOptions):
1183         * WebKitTestRunner/TestController.cpp:
1184         (WTR::TestController::resetPreferencesToConsistentValues):
1185         (WTR::updateTestOptionsFromTestHeader):
1186         * WebKitTestRunner/TestOptions.h:
1187         (WTR::TestOptions::hasSameInitializationOptions const):
1188         Add plumbing for new InspectorAdditions runtime flag.
1189
1190 2017-08-07  obinna obike  <oobike@apple.com>
1191
1192         Sorted EWS Queues on Patch page
1193         https://bugs.webkit.org/show_bug.cgi?id=173667
1194
1195         Reviewed by Aakash Jain.
1196
1197         * QueueStatusServer/handlers/patch.py:
1198         (Patch.get): Sorted queue_status.
1199         * QueueStatusServer/templates/patch.html:
1200         Changed queue_status.items to queue_status because it's a list.
1201
1202 2017-08-07  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1203
1204         check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
1205         https://bugs.webkit.org/show_bug.cgi?id=175286
1206
1207         Reviewed by Myles C. Maxfield.
1208
1209         * Scripts/webkitpy/style/checkers/cpp.py:
1210         (check_braces):
1211         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1212         (WebKitStyleTest.test_braces.NS_ERROR_ENUM):
1213         (WebKitStyleTest.test_braces):
1214         (WebKitStyleTest.test_braces.NS_OPTIONS):
1215
1216 2017-08-07  Brian Burg  <bburg@apple.com>
1217
1218         Remove CANVAS_PATH compilation guard
1219         https://bugs.webkit.org/show_bug.cgi?id=175207
1220
1221         Reviewed by Sam Weinig.
1222
1223         * Scripts/webkitperl/FeatureList.pm:
1224         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1225
1226 2017-08-07  Per Arne Vollan  <pvollan@apple.com>
1227
1228         [Win] Use Visual Studio 2017 if installed.
1229         https://bugs.webkit.org/show_bug.cgi?id=175188
1230
1231         Reviewed by Sam Weinig.
1232
1233         If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
1234
1235         * Scripts/webkitdirs.pm:
1236         (visualStudioInstallDir):
1237         (msBuildInstallDir):
1238
1239 2017-08-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1240
1241         [GTK][WPE] Add API to provide browser information required by automation
1242         https://bugs.webkit.org/show_bug.cgi?id=175130
1243
1244         Reviewed by Michael Catanzaro.
1245
1246         * MiniBrowser/gtk/main.c:
1247         (automationStartedCallback): Set browser information when a new automation session is started.
1248         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1249         (testAutomationSessionApplicationInfo):
1250         (beforeAll):
1251
1252 2017-08-06  Ryan Haddad  <ryanhaddad@apple.com>
1253
1254         Unreviewed, rolling out r220295.
1255
1256         This change introduced 4 errors in webkitpy tests.
1257
1258         Reverted changeset:
1259
1260         "[XCode] webkit-patch should run sort-Xcode-project-file"
1261         https://bugs.webkit.org/show_bug.cgi?id=174036
1262         http://trac.webkit.org/changeset/220295
1263
1264 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1265
1266         Disable API test NowPlayingControlsTests.NowPlayingControlsIOS.
1267
1268         Unreviewed test gardening.
1269
1270         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1271         (TestWebKitAPI::TEST):
1272
1273 2017-08-05  Filip Pizlo  <fpizlo@apple.com>
1274
1275         REGRESSION (r219895-219897): Number of leaks on Open Source went from 9240 to 235983 and is now at 302372
1276         https://bugs.webkit.org/show_bug.cgi?id=175083
1277
1278         Reviewed by Oliver Hunt.
1279         
1280         Leaks results are super confusing if leaks runs while some VMs are destructing. This calls a new SPI
1281         to wait for VM destructions to finish before running the next test. This makes it easier to 
1282         understand leaks results from workers tests, and leads to fewer reported leaks.
1283
1284         * DumpRenderTree/mac/DumpRenderTree.mm:
1285         (runTest):
1286
1287 2017-08-05  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
1288
1289         check-webkit-style: fix path-specific rules for WebKit2 rename
1290         https://bugs.webkit.org/show_bug.cgi?id=175182
1291
1292         Reviewed by David Kilzer.
1293
1294         * Scripts/webkitpy/style/checker.py:
1295
1296 2017-08-04  Youenn Fablet  <youenn@apple.com>
1297
1298         [Cache API] Add Cache and CacheStorage IDL definitions
1299         https://bugs.webkit.org/show_bug.cgi?id=175201
1300
1301         Reviewed by Brady Eidson.
1302
1303         * DumpRenderTree/mac/DumpRenderTree.mm:
1304         (enableExperimentalFeatures):
1305         (resetWebPreferencesToConsistentValues):
1306         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1307         (WTR::InjectedBundle::beginTesting):
1308         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1309         (WTR::TestRunner::setCacheAPIEnabled):
1310         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1311
1312 2017-08-04  John Wilander  <wilander@apple.com>
1313
1314         Resource Load Statistics: Report user interaction immediately, but only when needed
1315         https://bugs.webkit.org/show_bug.cgi?id=175090
1316         <rdar://problem/33685546>
1317
1318         Reviewed by Chris Dumez.
1319
1320         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1321         (WTR::InjectedBundle::beginTesting):
1322             Now calls WebCore::ResourceLoadObserver::clearState().
1323
1324 2017-08-04  Tim Horton  <timothy_horton@apple.com>
1325
1326         Add an API test for r220286
1327         https://bugs.webkit.org/show_bug.cgi?id=175206
1328
1329         Reviewed by Simon Fraser.
1330
1331         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
1332         (-[AnimatedResizeWebView _webView:didChangeSafeAreaShouldAffectObscuredInsets:]):
1333         (createAnimatedResizeWebView):
1334         (TEST):
1335         Add a test to ensure that we don't call
1336         _webView:didChangeSafeAreaShouldAffectObscuredInsets: during an
1337         animated resize.
1338
1339 2017-08-04  Stephan Szabo  <stephan.szabo@sony.com>
1340
1341         [XCode] webkit-patch should run sort-Xcode-project-file
1342         https://bugs.webkit.org/show_bug.cgi?id=174036
1343
1344         Reviewed by Simon Fraser.
1345
1346         * Scripts/webkitpy/common/config/ports.py:
1347         * Scripts/webkitpy/tool/commands/download.py:
1348         * Scripts/webkitpy/tool/commands/upload.py:
1349         * Scripts/webkitpy/tool/steps/__init__.py:
1350         * Scripts/webkitpy/tool/steps/options.py:
1351         * Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
1352
1353 2017-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1354
1355         REGRESSION(r219857): run-benchmark --allplans broken
1356         https://bugs.webkit.org/show_bug.cgi?id=175186
1357
1358         Reviewed by Saam Barati.
1359
1360         r219857 forgot to update also the calls to BenchmarkRunner() that
1361         is done when the script is run with --allplans.
1362
1363         To fix this (and avoid future issues like this), let's factorize
1364         the calls to the benchhmark runner in a run_benchmark_plan()
1365         function.
1366
1367         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
1368         (run_benchmark_plan):
1369         (start):
1370
1371 2017-08-04  Aakash Jain  <aakash_jain@apple.com>
1372
1373         Dashboard bubbles sometimes show failure count instead of crash count
1374         https://bugs.webkit.org/show_bug.cgi?id=175157
1375         <rdar://problem/33709009>
1376
1377         Reviewed by Alexey Proskuryakov.
1378
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1380         (BuildbotTestResults.prototype.resultSummarizer): Use the regex for the precise match first.
1381
1382 2017-08-04  Joseph Pecoraro  <pecoraro@apple.com>
1383
1384         Add tests for NeverDestroyed
1385         https://bugs.webkit.org/show_bug.cgi?id=175146
1386
1387         Reviewed by Darin Adler.
1388
1389         * CMakeLists.txt:
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1391         New files and sort.
1392
1393         * TestWebKitAPI/Tests/WTF/Logger.h:
1394         * TestWebKitAPI/Tests/WTF/Logger.cpp:
1395         (TestWebKitAPI::log):
1396         (TestWebKitAPI::takeLogStr):
1397         * TestWebKitAPI/Tests/WTF/RefLogger.h:
1398         * TestWebKitAPI/Tests/WTF/RefLogger.cpp:
1399         (TestWebKitAPI::log): Deleted.
1400         (TestWebKitAPI::takeLogStr): Deleted.
1401         Extract log() / takeLogStr() from RefLogger to a general Logger.h/cpp.
1402
1403         * TestWebKitAPI/Tests/WTF/LifecycleLogger.h:
1404         * TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp: Added.
1405         (TestWebKitAPI::LifecycleLogger::LifecycleLogger):
1406         (TestWebKitAPI::LifecycleLogger::operator=):
1407         (TestWebKitAPI::LifecycleLogger::~LifecycleLogger):
1408         (TestWebKitAPI::LifecycleLogger::setName):
1409         (TestWebKitAPI::TEST):
1410         Add a class that logs construction / assignment / modifications.
1411
1412         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp: Added.
1413         (TestWebKitAPI::TEST):
1414         (TestWebKitAPI::list):
1415         Test construction behavior is as expected both directly and using makeNeverDestroyed.
1416
1417 2017-08-04  Lucas Forschler  <lforschler@apple.com>
1418
1419         minification logic is not implemented for ios builds
1420         <rdar://problem/33726561>
1421
1422         Reviewed by Dean Johnson
1423
1424         * BuildSlaveSupport/built-product-archive:
1425         (minifyDirectory): refactor minifySource -> minifyDirectory
1426         (archiveBuiltProduct): add ios minification logic
1427         (minifySource): Deleted.
1428
1429 2017-08-04  Matt Lewis  <jlewis3@apple.com>
1430
1431         Unreviewed, rolling out r220271.
1432
1433         Rolling out due to Layout Test failing on iOS Simulator.
1434
1435         Reverted changeset:
1436
1437         "Remove STREAMS_API compilation guard"
1438         https://bugs.webkit.org/show_bug.cgi?id=175165
1439         http://trac.webkit.org/changeset/220271
1440
1441 2017-08-04  Ryan Haddad  <ryanhaddad@apple.com>
1442
1443         Unreviewed, rolling out r220268.
1444
1445         This change caused assertion failures on macOS and iOS Debug
1446         WK2.
1447
1448         Reverted changeset:
1449
1450         "Resource Load Statistics: Report user interaction
1451         immediately, but only when needed"
1452         https://bugs.webkit.org/show_bug.cgi?id=175090
1453         http://trac.webkit.org/changeset/220268
1454
1455 2017-08-04  Youenn Fablet  <youenn@apple.com>
1456
1457         Remove STREAMS_API compilation guard
1458         https://bugs.webkit.org/show_bug.cgi?id=175165
1459
1460         Reviewed by Darin Adler.
1461
1462         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1463
1464 2017-08-04  John Wilander  <wilander@apple.com>
1465
1466         Resource Load Statistics: Report user interaction immediately, but only when needed
1467         https://bugs.webkit.org/show_bug.cgi?id=175090
1468         <rdar://problem/33685546>
1469
1470         Reviewed by Chris Dumez.
1471
1472         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1473         (WTR::InjectedBundle::beginTesting):
1474             Now calls WebCore::ResourceLoadObserver::clearState().
1475
1476 2017-08-03  Brian Burg  <bburg@apple.com>
1477
1478         Remove ENABLE(WEB_SOCKET) guards
1479         https://bugs.webkit.org/show_bug.cgi?id=167044
1480
1481         Reviewed by Joseph Pecoraro.
1482
1483         * Scripts/webkitperl/FeatureList.pm:
1484         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1485
1486 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1487
1488         REGRESSION(r219850): run-benchmark script broken on Linux
1489         https://bugs.webkit.org/show_bug.cgi?id=175126
1490
1491         Reviewed by Stephanie Lewis.
1492
1493         The run-benchmark script dynamically generates the list of supported
1494         browsers and platforms (currently Linux and OSX) by loading all
1495         python files from Tools/Scripts/webkitpy/benchmark_runner/browser_driver
1496         and getting the browser_name and platform variables from the
1497         classes defined there.
1498
1499         This means that this classes should not raise an exception when
1500         loaded on other platforms or otherwise they will broke the whole
1501         script. Its fine if they raise an exception when executing any of
1502         the methods they implement, but not when just loading/importing
1503         the class.
1504
1505         Move the argument variable definitions that call on the platform
1506         specific OSXBrowserDriver._screen_size() function from beeing
1507         variables that are evaluated when loading the file, to be functions
1508         that are only evaluated when the actual functionality needs to be
1509         executed.
1510
1511         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1512         (OSXChromeDriver.launch_url):
1513         (OSXChromeCanaryDriver.launch_url):
1514         (create_args):
1515         (create_chrome_options):
1516         (create_window_size_arg):
1517         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1518         (OSXFirefoxDriver.launch_url):
1519         (OSXFirefoxNightlyDriver.launch_url):
1520         (OSXFirefoxNightlyDriver.launch_driver):
1521         (create_args):
1522
1523 2017-08-03  Yoshiaki Jitsukawa  <jitsu@rd.scei.sony.co.jp>
1524
1525         [PAL] Move spi/cf directory into PAL
1526         https://bugs.webkit.org/show_bug.cgi?id=175057
1527
1528         Reviewed by Antti Koivisto.
1529
1530         * Scripts/webkitpy/style/checker.py:
1531         * Scripts/webkitpy/style/checker_unittest.py:
1532         (GlobalVariablesTest.test_path_rules_specifier):
1533
1534         Ignore "readability/naming/underscores" style errors for sources
1535         under the WebCore/PAL/pal/spi directory.
1536
1537         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1538
1539 2017-08-03  Youenn Fablet  <youenn@apple.com>
1540
1541         Remove FETCH_API compilation guard
1542         https://bugs.webkit.org/show_bug.cgi?id=175154
1543
1544         Reviewed by Chris Dumez.
1545
1546         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1547
1548 2017-08-03  Lucas Forschler  <lforschler@apple.com>
1549
1550         Enable archive minification on iOS builds
1551         https://bugs.webkit.org/show_bug.cgi?id=174718
1552         
1553         Reviewed by Aakash Jain.
1554
1555         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1556         (BuildFactory.__init__):
1557
1558 2017-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1559
1560         [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
1561         https://bugs.webkit.org/show_bug.cgi?id=175140
1562
1563         Reviewed by Alexey Proskuryakov.
1564
1565         We are having lately issues with JSC tests causing problems on
1566         the GTK+ and WPE bots due to the high amount of memory some tests
1567         need to run.
1568
1569         The best thing we can do now is to workaround this by disabling
1570         all the tests marked as memoryLimited on the GTK and WPE bots.
1571         We may revise this on the future.
1572
1573         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1574         (RunJavaScriptCoreTests.start):
1575
1576 2017-08-03  Brady Eidson  <beidson@apple.com>
1577
1578         Add SW IDLs and stub out basic functionality.
1579         https://bugs.webkit.org/show_bug.cgi?id=175115
1580
1581         Reviewed by Chris Dumez.
1582
1583         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1584
1585         * Scripts/webkitpy/bindings/main.py:
1586
1587 2017-08-03  Per Arne Vollan  <pvollan@apple.com>
1588
1589         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
1590         https://bugs.webkit.org/show_bug.cgi?id=159510
1591
1592         Reviewed by Daniel Bates.
1593
1594         Allow any https certificate when running tests.
1595
1596         * DumpRenderTree/win/DumpRenderTree.cpp:
1597         (runTest):
1598
1599 2017-08-02  Youenn Fablet  <youenn@apple.com>
1600
1601         HTTP tests with 'https' suffix are only run over HTTPS for WK2, not WK1
1602         https://bugs.webkit.org/show_bug.cgi?id=175089
1603
1604         Reviewed by Chris Dumez.
1605
1606         * DumpRenderTree/TestOptions.mm:
1607         (TestOptions::TestOptions): Using absolutePath if available.
1608         * DumpRenderTree/mac/DumpRenderTree.mm:
1609         (computeTestURL): Removing http/tests/ specific URL computation.
1610         * Scripts/webkitpy/port/driver.py:
1611         (Driver._command_from_driver_input): Making webkitpy passing HTTP urls for HTTP served tests to all test runners, including WK1.
1612
1613 2017-08-02  Lucas Forschler  <lforschler@apple.com>
1614
1615         download-built-product should allow for a proxy option
1616         https://bugs.webkit.org/show_bug.cgi?id=174875
1617
1618         Reviewed by Aakash Jain, Alexey Proskuryakov, Dean Johnson
1619
1620         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1621         (DownloadBuiltProduct.start): Teach buildbot to pass along proxy for Apple bots
1622         
1623
1624 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1625
1626         check-webkit-style: deleting lines in a file runs the linter on the whole file
1627         https://bugs.webkit.org/show_bug.cgi?id=175078
1628
1629         Reviewed by David Kilzer.
1630
1631         Deleting lines in a file should not cause linter errors to be blamed on the patch.
1632         <https://bugs.webkit.org/show_bug.cgi?id=86142> is an example of this happening.
1633
1634         * Scripts/webkitpy/style/checkers/test_expectations.py:
1635         (TestExpectationsChecker._should_log_linter_warning): Do not log a linter error if the file it is associated with only has deleted lines
1636         * Scripts/webkitpy/style/main_unittest.py:
1637         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Added files should have every line number in the file when processing.
1638         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Test case where the file with the linter errors only contained deletes.
1639         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Added files should have every line number in the file when processing.
1640
1641 2017-08-02  Jonathan Bedard  <jbedard@apple.com>
1642
1643         webkitpy: Allow caller to specify response to unicode encode/decode error in filesystem
1644         https://bugs.webkit.org/show_bug.cgi?id=175075
1645
1646         Reviewed by David Kilzer.
1647
1648         We have no way of handling text files with illegal unicode characters. Allow the callers of
1649         filesystem.read_text_file to specify one of Python 2.7's supported responses ('strict', 'ignore', or
1650         'replace'). See https://docs.python.org/2/howto/unicode.html for details on these responses.
1651
1652         * Scripts/webkitpy/common/system/filesystem.py:
1653         (FileSystem.read_text_file): Allow caller to specify unicode error handling.
1654         (FileSystem.write_text_file): Ditto.
1655         * Scripts/webkitpy/common/system/filesystem_mock.py:
1656         (MockFileSystem.read_text_file): Allow caller to specify unicode error handling.
1657         (MockFileSystem.write_text_file): Ditto.
1658         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1659         (RealFileSystemTest.test_read_text_file_unicode_decode_error): Test reading a file with illegal unicode content.
1660         (RealFileSystemTest.test_write_text_file_unicode_encode_error): Test writing illegal unicode content to a file.
1661
1662 2017-08-02  Aakash Jain  <aakash_jain@apple.com>
1663
1664         Intermittent exception in buildPageURLForIteration for Buildbot 0.9 dashboard
1665         https://bugs.webkit.org/show_bug.cgi?id=175072
1666
1667         Reviewed by Alexey Proskuryakov.
1668
1669         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1670         (Buildbot): Make sure this._builderNameToIDMap is always defined for Buildbot 0.9.
1671
1672 2017-08-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1673
1674         [CMake] Remove obsolete code in TestWebKitAPI/CMakeLists.txt
1675         https://bugs.webkit.org/show_bug.cgi?id=175019
1676
1677         Reviewed by Darin Adler.
1678
1679         * TestWebKitAPI/CMakeLists.txt:
1680
1681 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1682
1683         Enabling uploading archives to S3
1684         https://bugs.webkit.org/show_bug.cgi?id=174198
1685
1686         Unreviewed unit test fix after r219235.
1687
1688         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1689
1690 2017-08-01  Csaba Osztrogonác  <ossy@webkit.org>
1691
1692         Fix JSCOnly ARM buildbots after r220047
1693         https://bugs.webkit.org/show_bug.cgi?id=174993
1694
1695         Unreviewed fix after r220087.
1696
1697         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1698         (BuildAndRemoteJSCTestsFactory.__init__):
1699
1700 2017-08-01  Chris Dumez  <cdumez@apple.com>
1701
1702         Add initial support for navigator.sendBeacon
1703         https://bugs.webkit.org/show_bug.cgi?id=175007
1704         <rdar://problem/33547728>
1705
1706         Reviewed by Sam Weinig.
1707
1708         Enable the Beacon API at runtime in the context of layout tests since the
1709         feature is currently disabled by default.
1710
1711         * DumpRenderTree/mac/DumpRenderTree.mm:
1712         (enableExperimentalFeatures):
1713         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1714         (WTR::InjectedBundle::beginTesting):
1715         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1716         (WTR::TestRunner::setModernMediaControlsEnabled):
1717         (WTR::TestRunner::setBeaconAPIEnabled):
1718         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1719
1720 2017-08-01  Aakash Jain  <aakash_jain@apple.com>
1721
1722         Update Bot Watcher's Dashboard for Buildbot 0.9
1723         https://bugs.webkit.org/show_bug.cgi?id=174777
1724
1725         Reviewed by Daniel Bates.
1726
1727         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1728         (Buildbot): Check if USE_BUILDBOT_VERSION_LESS_THAN_09 is passed.
1729         (Buildbot.prototype._computeBuilderNameToIDMap): Fetch the builder name to ID mapping from buidbot and store
1730         in a dictionary.
1731         (Buildbot.prototype.buildPageURLForIteration): Updated URL as per Buildbot 0.9 format. Buildbot 0.9 currently does not support
1732         builder name in the build url. See <https://github.com/buildbot/buildbot/issues/3465>.
1733         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1734         (isMultiCodebaseGotRevisionProperty): Adapting to new data format.
1735         (parseRevisionProperty): Ditto.
1736         (BuildbotIteration.prototype.failureLogURL): Return the URL to build page if precise failure url is not available. For
1737         Buildbot 0.9, build page URL would be appropriate in most cases as per the new UI.
1738         (BuildbotIteration.prototype._parseData): Parsing the data as per new data format. Many variable names and data types
1739         have changed in Buildbot 0.9.
1740         (BuildbotIteration.prototype._adjustBuildDataForBuildbot09): Adjust the Buildbot 0.8 data to new format.
1741         (BuildbotIteration.prototype._updateIfDataAvailable): Update method for Buildbot 0.9 data. We are performing two API calls, 
1742         one for build information, another for step information of that build. We need to wait until data from both REST API calls are available.
1743         (BuildbotIteration.prototype._deprecatedUpdateWithData): Renamed from _updateWithData, used for Buildbot 0.8 data.
1744         (BuildbotIteration.prototype.get buildURL): URL to fetch build information from Buildbot. Also fetches got_revision property.
1745         (BuildbotIteration.prototype.get buildStepsURL): URL to fetch the steps information from Buildbot.
1746         (BuildbotIteration.prototype.urlFailedToLoad): Callback method to be used when URL fails to load. Made it a separate function now.
1747         (BuildbotIteration.prototype.update): Modified to support both Buildbot 0.9 and 0.8 data format.
1748         (BuildbotIteration.prototype.actualUpdate): Update method for Buildbot 0.9 data.
1749         (BuildbotIteration.prototype.deprecatedUpdate): Update method for Buildbot 0.8 data.
1750         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1751         (BuildbotQueue.prototype.get baseURL): Updated URL as per Buildbot 0.9 format.
1752         (BuildbotQueue.prototype.get allIterationsURL): Ditto.
1753         (BuildbotQueue.prototype.get overviewURL): Ditto.
1754         (BuildbotQueue.prototype.get buildsURL): URL to fetch builds data in Buildbot 0.9.
1755         (BuildbotQueue.prototype.get buildsInfoURL): Returns the appropriate URL to use to fetch builds information from
1756         Buildbot 0.8 or 0.9.
1757         (BuildbotQueue.prototype.getBuilds): Method compatible with both Buildbot 0.8 and 0.9 to get build information from data
1758         fetched from Buildbot. Also, reversing the Buildbot 0.8 data to make it similar to 0.9 data format.
1759         (BuildbotQueue.prototype.isBuildComplete): Method compatible with both Buildbot 0.8 and 0.9 to check if the build has completed.
1760         (BuildbotQueue.prototype.getIterationID):  Method compatible with both Buildbot 0.8 and 0.9 to get the Iteration ID.
1761         (BuildbotQueue.prototype.update): Supports both Buildbot 0.8 and 0.9. Buildbot 0.9 REST API doesn't have cachedBuilds and currentBuilds. 
1762         Therefore we are fetching information for fixed number of build. 
1763         Also iterating the loop incrementally since the build data is already reverse sorted.
1764         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1765         (BuildbotTestResults.prototype._parseResults): Updated as per Buildbot 0.9 format. Note that we do not
1766         need to worry about 0.8 or 0.9 data format here, since the data is already converted to 0.9 format.
1767         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1768         (WebKitBuildbot): Pass the USE_BUILDBOT_VERSION_LESS_THAN_09 flag.
1769
1770 2017-08-01  Devin Rousso  <drousso@apple.com>
1771
1772         Web Inspector: simplify WebInspector with WI
1773         https://bugs.webkit.org/show_bug.cgi?id=175058
1774
1775         Reviewed by Joseph Pecoraro.
1776
1777         * Scripts/check-inspector-strings:
1778         (extract_ui_strings):
1779         * Scripts/extract-localizable-js-strings:
1780
1781 2017-08-01  Youenn Fablet  <youenn@apple.com>
1782
1783         Layout tests with 'https' suffix should be run over HTTPS
1784         https://bugs.webkit.org/show_bug.cgi?id=174992
1785
1786         Reviewed by Chris Dumez.
1787
1788         Updating the test-name <-> uri conversion routines to use https when test names contain ".https." in them.
1789         This covers WPT tests, WPT WebKit tests and HTTP layout tests.
1790         Covered by corresponding unit tests.
1791
1792         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
1793         (run_server):
1794         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1795         (base_http_url):
1796         (base_https_url):
1797         (base_url): Deleted.
1798         * Scripts/webkitpy/port/base.py:
1799         (Port.to.web_platform_test_server_base_http_url):
1800         (Port.to):
1801         (Port.to.web_platform_test_server_base_https_url):
1802         (Port.to.web_platform_test_server_base_url): Deleted.
1803         * Scripts/webkitpy/port/driver.py:
1804         (Driver.__init__):
1805         (Driver.wpt_test_path_to_uri):
1806         (Driver):
1807         (Driver.http_test_path_to_uri):
1808         (Driver.test_to_uri):
1809         (Driver.uri_to_test):
1810         * Scripts/webkitpy/port/driver_unittest.py:
1811         (DriverTest.test_test_to_uri):
1812         (DriverTest.test_uri_to_test):
1813
1814 2017-07-26  Jiewen Tan  <jiewen_tan@apple.com>
1815
1816         Add tests to detect mistakes in backward compatibility when the structured clone algorithm is changed in the future
1817         https://bugs.webkit.org/show_bug.cgi?id=173998
1818
1819         Reviewed by Darin Adler.
1820
1821         Since the structured clone algorithm is used for data stored in persistent databases, we need tests to help us
1822         detect mistakes in backward compatibility in the future when we change it.
1823
1824         The way it works is to read from a pre-baked database and see if all the values are matched with the expectations.
1825         Surprisedly, some of structured clonable objects cannot be stored into the indexedDB. Those are FileList,
1826         ObjectReference, MessagePortReference, ArrayBufferView, ArrayBufferTransfer, NonMapProperties, NonSetProperties,
1827         SharedArrayBuffer, WasmModule, DOMPointReadOnly, DOMPoint, DOMRectReadOnly, DOMRect, DOMMatrixReadOnly, DOMMatrix,
1828         DOMQuad and Error. CryptoKey objects are not included as well as they need new API for encrypting/decrypting the
1829         internal key data slot.
1830
1831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1832         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.mm: Added.
1833         (-[IndexedDBStructuredCloneBackwardCompatibilityMessageHandler userContentController:didReceiveScriptMessage:]):
1834         (getNextMessage):
1835         (TEST):
1836         Here is the API test that moves the pre-baked database to the location where TestWebKitAPI can read from.
1837         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3: Added.
1838         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-shm: Added.
1839         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibility.sqlite3-wal: Added.
1840         These are the pre-baked databases.
1841         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityRead.html: Added.
1842         This is the actual test that do all the reads and comparisons.
1843         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBStructuredCloneBackwardCompatibilityWrite.html: Added.
1844         This is the page that bakes the database. It never runs automatically. It is for someone who needs to teach
1845         IndexedDB new stuffs. Then it can be used to bake the database again.
1846
1847 2017-08-01  Brady Eidson  <beidson@apple.com>
1848
1849         API test URLSchemeHandler.Exceptions is Exiting out early on macOS Debug..
1850         https://bugs.webkit.org/show_bug.cgi?id=175030
1851
1852         Reviewed by Andy Estes.
1853
1854         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1855         (-[TaskSchemeHandler webView:startURLSchemeTask:]): Stop calling an invalid NSError constructor.
1856
1857 2017-08-01  Brady Eidson  <beidson@apple.com>
1858
1859         Part 2 of: Rename DatabaseProcess to StorageProcess.
1860         https://bugs.webkit.org/show_bug.cgi?id=174880
1861
1862         Reviewed by Andy Estes.
1863
1864         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
1865         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
1866         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
1867         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1868         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
1869         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
1870         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
1871         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
1872
1873 2017-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1874
1875         Fix JSCOnly ARM buildbots after r220047
1876         https://bugs.webkit.org/show_bug.cgi?id=174993
1877
1878         Reviewed by Saam Barati.
1879
1880         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1881         (BuildAndRemoteJSCTestsFactory.__init__):
1882
1883 2017-07-30  Yusuke Suzuki  <utatane.tea@gmail.com>
1884
1885         [WTF] Introduce Private Symbols
1886         https://bugs.webkit.org/show_bug.cgi?id=174935
1887
1888         Reviewed by Darin Adler.
1889
1890         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1891         (TestWebKitAPI::TEST):
1892
1893 2017-07-30  Darin Adler  <darin@apple.com>
1894
1895         Remove code in HTMLObjectElement attribute parsing that forces style resolution and layout
1896         https://bugs.webkit.org/show_bug.cgi?id=130653
1897
1898         Reviewed by Antti Koivisto.
1899
1900         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1901         (WTR::InjectedBundlePage::didFinishLoadForFrame): Omit now-unneeded "shouldDump" argument
1902         when calling frameDidChangeLocation.
1903         (WTR::InjectedBundlePage::frameDidChangeLocation): Removed "shouldDump" argument. This was
1904         causing WebKitTestRunner to not dump anything in cases where DumpRenderTree will dump, and
1905         thus causing mysterious failures of a couple of tests. There are two remaining issues:
1906         1) WebKitTestRunner won't run its dump code if there is no "page", and there is no such
1907         consideration in DumpRenderTree and 2) Both DumpRenderTree and WebKitTestRunner share the
1908         same logic flaw that causes "top loading frame" to get set to one of the subframes in
1909         tests where  the following sequence occurs: test calls waitUntilDone, main frame finishes
1910         loading, subframe starts loading. It would be good to clean that up some day, but for now
1911         this patch makes the two work identically rather than changing both.
1912         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for change above.
1913
1914 2017-07-30  Wenson Hsieh  <wenson_hsieh@apple.com>
1915
1916         [WK2] Replace RetainPtr<> with auto when adopting allocated ObjC objects in DataInteractionTests
1917         https://bugs.webkit.org/show_bug.cgi?id=174963
1918
1919         Reviewed by Darin Adler.
1920
1921         Replaces several uses of RetainPtr<>s with auto. Some test cases in this file use auto, while other test cases declare using
1922         RetainPtr<>. This patch changes them to all use auto.
1923
1924         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
1925         (TestWebKitAPI::TEST):
1926
1927 2017-07-30  Brady Eidson  <beidson@apple.com>
1928
1929         Add URLSchemeHandler API tests that verify the lack of URLSchemeTask object leaks.
1930         https://bugs.webkit.org/show_bug.cgi?id=174958
1931
1932         Reviewed by Darin Adler.
1933
1934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1935         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-leaks.mm: Added.
1936         (-[LeakSchemeHandler webView:startURLSchemeTask:]):
1937         (-[LeakSchemeHandler webView:stopURLSchemeTask:]):
1938         (runUntilTasksInFlight):
1939         (TEST):
1940
1941 2017-07-28  Commit Queue  <commit-queue@webkit.org>
1942
1943         Unreviewed, rolling out r219990.
1944         https://bugs.webkit.org/show_bug.cgi?id=174961
1945
1946         "broke PLT on iOS (rdar://problem/33602751)" (Requested by
1947         estes on #webkit).
1948
1949         Reverted changeset:
1950
1951         "Part 2 of: Rename DatabaseProcess to StorageProcess."
1952         https://bugs.webkit.org/show_bug.cgi?id=174880
1953         http://trac.webkit.org/changeset/219990
1954
1955 2017-07-28  Brady Eidson  <beidson@apple.com>
1956
1957         API tests that use URLSchemeHandler are failing.
1958         https://bugs.webkit.org/show_bug.cgi?id=174950
1959
1960         Reviewed by Alex Christensen.
1961
1962         Fix the NoMIMEType test to be correct.
1963
1964         * TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
1965         (-[SchemeHandler initWithData:mimeType:]):
1966         (-[SchemeHandler webView:startURLSchemeTask:]):
1967         (TEST):
1968
1969 2017-07-28  Daniel Bates  <dabates@apple.com>
1970
1971         prepare-ChangeLog should not list added layout tests in PAL ChangeLog
1972         https://bugs.webkit.org/show_bug.cgi?id=174876
1973
1974         Reviewed by Alex Christensen.
1975
1976         Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
1977         to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
1978         they provide a more direct way to test the platform abstraction.
1979
1980         As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
1981
1982         * Scripts/prepare-ChangeLog:
1983         (generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
1984         of the current working directory.
1985
1986 2017-07-28  Jonathan Bedard  <jbedard@apple.com>
1987
1988         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
1989         https://bugs.webkit.org/show_bug.cgi?id=174930
1990
1991         Unreviewed test fix.
1992
1993         We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog. 
1994
1995         * Scripts/prepare-ChangeLog:
1996         (get_function_line_ranges_for_cpp):
1997
1998 2017-07-28  JF Bastien  <jfbastien@apple.com>
1999
2000         Using "auto <function()> -> returnType" breaks prepare-ChangeLog
2001         https://bugs.webkit.org/show_bug.cgi?id=174930
2002
2003         Reviewed by Daniel Bates.
2004
2005         Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
2006         here also teach it about const and volatile overloads. I didn't do
2007         reference and rvalue reference overloads because we don't really
2008         use them, and the current parser throws away those characters and
2009         it doesn't seem worth making it more complex.
2010
2011         * Scripts/prepare-ChangeLog:
2012         (get_function_line_ranges_for_cpp):
2013         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
2014         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
2015         (Foo::Arrow::arrow):
2016         (Foo::Arrow::otherArrow):
2017         (Foo::Arrow::otherArrow const):
2018         (Foo::Arrow::otherArrow volatile):
2019         (Foo::Arrow::otherArrow const volatile):
2020
2021 2017-07-28  Adrian Perez de Castro  <aperez@igalia.com>
2022
2023         [GTK] Building with ENABLE_VIDEO=OFF fails
2024         https://bugs.webkit.org/show_bug.cgi?id=174940
2025
2026         Reviewed by Alex Christensen.
2027
2028         When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
2029         This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
2030
2031         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
2032         (methodCallCallback): Add missing USE(GSTREAMER) guard.
2033
2034 2017-07-28  Claudio Saavedra  <csaavedra@igalia.com>
2035
2036         [WPE] Implement EventSenderProxy in WTR
2037         https://bugs.webkit.org/show_bug.cgi?id=173419
2038
2039         Reviewed by Žan Doberšek.
2040
2041         Add the implementation of EventSenderProxy to the WTR. This
2042         allows us to extend the coverage of the test suite in WKWPE.
2043
2044         * WebKitTestRunner/EventSenderProxy.h:
2045         * WebKitTestRunner/PlatformWPE.cmake: Add dependency on
2046         libxkbcommon needed to deal with key events.
2047         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2048         (WTR::EventSenderProxy::EventSenderProxy):
2049         (WTR::senderButtonToWPEButton):
2050         (WTR::EventSenderProxy::mouseDown):
2051         (WTR::EventSenderProxy::mouseUp):
2052         (WTR::EventSenderProxy::mouseMoveTo):
2053         (WTR::EventSenderProxy::mouseScrollBy):
2054         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
2055         (WTR::EventSenderProxy::leapForward):
2056         (WTR::wkEventModifiersToWPE):
2057         (WTR::getXKBKeySymForKeyRef):
2058         (WTR::EventSenderProxy::keyDown):
2059         (WTR::EventSenderProxy::addTouchPoint):
2060         (WTR::EventSenderProxy::updateTouchPoint):
2061         (WTR::EventSenderProxy::setTouchModifier):
2062         (WTR::EventSenderProxy::setTouchPointRadius):
2063         (WTR::EventSenderProxy::getUpdatedTouchEvents):
2064         (WTR::EventSenderProxy::removeUpdatedTouchEvents):
2065         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2066         (WTR::EventSenderProxy::touchStart):
2067         (WTR::EventSenderProxy::touchMove):
2068         (WTR::EventSenderProxy::touchEnd):
2069         (WTR::EventSenderProxy::touchCancel):
2070         (WTR::EventSenderProxy::clearTouchPoints):
2071         (WTR::EventSenderProxy::releaseTouchPoint):
2072         (WTR::EventSenderProxy::cancelTouchPoint):
2073
2074 2017-07-27  Brady Eidson  <beidson@apple.com>
2075
2076         Part 2 of: Rename DatabaseProcess to StorageProcess.
2077         https://bugs.webkit.org/show_bug.cgi?id=174880
2078
2079         Reviewed by Andy Estes.
2080
2081         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2082         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
2083         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2084         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2085         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2086         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2087         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2088         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2089
2090 2017-07-26  Mark Lam  <mark.lam@apple.com>
2091
2092         Add ability to only run specific tests in run-javascriptcore-tests.
2093         https://bugs.webkit.org/show_bug.cgi?id=174884
2094
2095         Reviewed by Saam Barati.
2096
2097         For example, if we only want to run testapi, we can do so as follows:
2098             $ run-javascriptcore-tests --testapi
2099
2100         Previously, specifying --testapi effectively does nothing because we run all tests
2101         by default.  Only --no-testapi had the effect of disabling the test set.  This
2102         old behavior for --testapi is not very useful or meaningful.  We're now changing
2103         it to mean that we will only run that test.
2104
2105         With this change, we can also run more than one set of tests.  For example, if we
2106         only want to run testmasm and testair, we can do so as follows:
2107             $ run-javascriptcore-tests --testmasm --testair
2108
2109         By default, if no specific test option is specified, run-javascriptcore-tests will
2110         run all tests.
2111
2112         Note that the jsc stress tests (--jsc-stress) are a different set of tests than
2113         the mozilla tests (--mozilla-tests) even though both are run via the lower level
2114         run-jsc-stress-tests test harness.  Hence, if you only specify one of the tests,
2115         the other set will not run.  For example, the following only runs the mozilla tests:
2116             $ run-javascriptcore-tests --mozilla-tests
2117
2118         Note also that --jit-stress-tests is not for choosing a different set of tests.
2119         Instead, it is used for determining whether we run JIT'ed test configurations
2120         on the jsc stress tests and mozilla tests.  As a result, specifying
2121         --jit-stress-tests will not omit other tests.  For example, the following still
2122         runs all tests:
2123             $ run-javascriptcore-tests --jit-stress-tests
2124
2125         * Scripts/run-javascriptcore-tests:
2126         (defaultStringForTestState):
2127         (enableTestOrNot):
2128         (runJSCStressTests):
2129
2130 2017-07-26  Mark Lam  <mark.lam@apple.com>
2131
2132         Make run-javascriptcore-test run testair, testb3, and testmasm.
2133         https://bugs.webkit.org/show_bug.cgi?id=174837
2134         <rdar://problem/33522927>
2135
2136         Reviewed by Saam Barati and Filip Pizlo.
2137
2138         1. Refactors code for running testapi so that we can use it to run other tests.
2139         2. Added running of testmasm, testair, testb3.
2140
2141         Note: the existing testapi invocation code does not support remote invocation of
2142         the tests (e.g. on a ARM device).  Hence, the new additions of testmasm, testair,
2143         and testb3 also do not support remote invocation.  If we wish to add remote
2144         invocation support, we should do that in a separate patch.
2145
2146         * Scripts/run-javascriptcore-tests:
2147         (testPath):
2148         (runTest):
2149         (testapiPath): Deleted.
2150
2151 2017-07-26  Aakash Jain  <aakash_jain@apple.com>
2152
2153         Remove duplicate code from Buildbot.js in dashboard
2154         https://bugs.webkit.org/show_bug.cgi?id=174870
2155
2156         Reviewed by Daniel Bates.
2157
2158         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2159         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
2160         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
2161         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
2162         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
2163
2164 2017-07-26  Brady Eidson  <beidson@apple.com>
2165
2166         Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
2167         https://bugs.webkit.org/show_bug.cgi?id=174851
2168
2169         Reviewed by Chris Dumez.
2170
2171         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
2172         (TEST):
2173
2174 2017-07-26  Brian Burg  <bburg@apple.com>
2175
2176         Remove WEB_TIMING feature flag
2177         https://bugs.webkit.org/show_bug.cgi?id=174795
2178
2179         Reviewed by Alex Christensen.
2180
2181         * Scripts/webkitperl/FeatureList.pm:
2182         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2183
2184 2017-07-26  Chris Dumez  <cdumez@apple.com>
2185
2186         Pressing the Escape key should not be a valid user gesture to enter fullscreen
2187         https://bugs.webkit.org/show_bug.cgi?id=174864
2188         <rdar://problem/33009088>
2189
2190         Reviewed by Geoffrey Garen.
2191
2192         Add support for eventSender.keyDown('escape') in DRT to match the behavior of
2193         WKTR.
2194
2195         * DumpRenderTree/mac/EventSendingController.mm:
2196         (-[EventSendingController keyDown:withModifiers:withLocation:]):
2197
2198 2017-07-26  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2199
2200         Unreviewed, added Romain Bellessort to contributors.json.
2201
2202         * Scripts/webkitpy/common/config/contributors.json:
2203
2204 2017-07-26  Zan Dobersek  <zdobersek@igalia.com>
2205
2206         [WPE] WebGL2 support
2207         https://bugs.webkit.org/show_bug.cgi?id=174249
2208
2209         Reviewed by Alex Christensen.
2210
2211         * Scripts/webkitperl/FeatureList.pm:
2212         Enable WebGL2 for WPE when building through build-webkit.
2213
2214 2017-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
2215
2216         Unreviewed. Fix GTK distcheck.
2217
2218         * gtk/make-dist.py:
2219         (ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
2220
2221 2017-07-25  Brady Eidson  <beidson@apple.com>
2222
2223         ResourceLoadStatistics grandfathering happens much too often.
2224         <rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
2225
2226         Reviewed by Chris Dumez.
2227
2228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2229         * TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
2230         * TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
2231         (TEST):
2232
2233 2017-07-25  Matthew Stewart  <matthew_r_stewart@apple.com>
2234
2235         Fix autoinstaller failing on autoinstall_everything
2236         https://bugs.webkit.org/show_bug.cgi?id=174830
2237
2238         Reviewed by Joseph Pecoraro.
2239
2240         * Scripts/webkitpy/thirdparty/__init__.py:
2241         (AutoinstallImportHook.find_module):
2242         (AutoinstallImportHook.install_chromedriver):
2243         (AutoinstallImportHook.install_geckodriver):
2244         (AutoinstallImportHook._install_chromedriver): Deleted.
2245         (AutoinstallImportHook._install_geckodriver): Deleted.
2246
2247 2017-07-25  Jonathan Bedard  <jbedard@apple.com>
2248
2249         Replace --runtime with something for both ios-simulator and ios-device
2250         https://bugs.webkit.org/show_bug.cgi?id=173775
2251         <rdar://problem/32952164>
2252
2253         Reviewed by Aakash Jain.
2254
2255         Add --version flag for both iOS simulator and iOS device.
2256
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2258         (parse_args): Add --version flag and move --no-install.
2259         * Scripts/webkitpy/port/factory.py:
2260         (platform_options): Move --no-intall to run_webkit_tests.py.
2261         * Scripts/webkitpy/port/ios.py:
2262         (IOSPort):
2263         (IOSPort._is_valid_ios_version): Check that the provided version string is legal.
2264         (IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
2265         * Scripts/webkitpy/port/ios_device.py:
2266         (IOSDevicePort.ios_version): Consult --version flag before checking connected
2267         devices for iOS version.
2268         * Scripts/webkitpy/port/ios_device_unittest.py:
2269         (IOSDeviceTest.make_port): Set --version option so that we can generate test
2270         expectation paths without devices connected.
2271         (IOSDeviceTest.test_additional_platform_directory): Deleted.
2272         (IOSDeviceTest.test_baseline_searchpath): Deleted.
2273         (IOSDeviceTest.test_expectations_ordering): Deleted.
2274         * Scripts/webkitpy/port/ios_simulator.py:
2275         (IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
2276         flag to specify a runtime.
2277         (IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
2278         flag and then use the default runtime.
2279
2280 2017-07-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2281
2282         [GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
2283         https://bugs.webkit.org/show_bug.cgi?id=174815
2284
2285         Reviewed by Carlos Alberto Lopez Perez.
2286
2287         Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
2288         ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
2289         use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
2290         TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
2291         think), probably because of a newer CMake version.
2292
2293         * CMakeLists.txt:
2294         * TestWebKitAPI/CMakeLists.txt:
2295         * TestWebKitAPI/PlatformGTK.cmake:
2296
2297 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2298
2299         Fix BenchmarkRunner to only import selenium when needed
2300         https://bugs.webkit.org/show_bug.cgi?id=174808
2301
2302         Reviewed by Stephanie Lewis.
2303
2304         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2305         (LinuxChromeDriver.launch_driver):
2306         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2307         (LinuxFirefoxDriver.launch_driver):
2308         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2309         (OSXChromeDriver.launch_driver):
2310         (OSXChromeCanaryDriver.launch_driver):
2311         (create_chrome_options):
2312         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2313         (OSXFirefoxDriver.launch_driver):
2314         (OSXFirefoxNightlyDriver.launch_driver):
2315         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2316         (OSXSafariDriver.launch_driver):
2317         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2318         (WebDriverBenchmarkRunner._run_one_test):
2319
2320 2017-07-23  Darin Adler  <darin@apple.com>
2321
2322         More NeverDestroyed and related cleanup
2323         https://bugs.webkit.org/show_bug.cgi?id=174745
2324
2325         Reviewed by Alex Christensen.
2326
2327         * DumpRenderTree/JavaScriptThreading.cpp:
2328         (javaScriptThreadsMutex): Use NeverDestroyed instead of
2329         DEPRECATED_DEFINE_STATIC_LOCAL.
2330         (javaScriptThreads): Ditto.
2331
2332 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2333
2334         Subclass Benchmark Runner script for WebDriver support
2335         https://bugs.webkit.org/show_bug.cgi?id=174390
2336
2337         Reviewed by Dewei Zhu, Stephanie Lewis.
2338
2339         Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
2340
2341         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2342         (BenchmarkBuilder.__init__):
2343         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2344         (BenchmarkRunner.__init__):
2345         (BenchmarkRunner._find_plan_file):
2346         (BenchmarkRunner._run_one_test.and):
2347         (BenchmarkRunner.execute):
2348         (BenchmarkRunner._get_result): Deleted.
2349         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2350         (parse_args):
2351         (start):
2352         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
2353         (WebDriverBenchmarkRunner):
2354         (WebDriverBenchmarkRunner._get_result):
2355         (WebDriverBenchmarkRunner._run_one_test):
2356         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
2357         (WebServerBenchmarkRunner):
2358         (WebServerBenchmarkRunner.__init__):
2359         (WebServerBenchmarkRunner._get_result):
2360         (WebServerBenchmarkRunner._run_one_test):
2361
2362 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2363
2364         Add BenchmarkRunner patches with WebDriver support for each testing plan
2365         https://bugs.webkit.org/show_bug.cgi?id=174443
2366
2367         Reviewed by Dewei Zhu, Stephanie Lewis.
2368
2369         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2370         (BenchmarkBuilder.__enter__):
2371         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
2372         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
2373         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
2374         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
2375         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
2376         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
2377         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
2378         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
2379         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
2380         * Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
2381         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
2382         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
2383         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
2384         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
2385         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
2386         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
2387         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
2388         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2389         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
2390         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
2391         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
2392         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2393         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2394         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
2395         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
2396         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
2397         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2398         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
2399         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
2400         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
2401         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
2402         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
2403         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
2404
2405 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2406
2407         Add functions to autoinstaller needed for Benchmark Runner script
2408         https://bugs.webkit.org/show_bug.cgi?id=174331
2409
2410         Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
2411
2412         Adds autoinstaller functions to install selenium and webdriver binaries
2413         which will be used by the browser driver part of Benchmark Runner.
2414
2415         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2416         (BrowserDriver.restore_env):
2417         (BrowserDriver):
2418         (BrowserDriver.get_webdriver_binary_path):
2419         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2420         (LinuxChromeDriver.launch_driver):
2421         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2422         (LinuxFirefoxDriver.launch_driver):
2423         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2424         (OSXChromeDriver.launch_driver):
2425         (OSXChromeCanaryDriver.launch_driver):
2426         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2427         (OSXFirefoxDriver.launch_driver):
2428         (OSXFirefoxNightlyDriver.launch_driver):
2429         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2430         * Scripts/webkitpy/benchmark_runner/utils.py:
2431         (get_driver_binary_path):
2432         * Scripts/webkitpy/common/system/autoinstall.py:
2433         (AutoInstaller._unzip):
2434         * Scripts/webkitpy/thirdparty/__init__.py:
2435         (AutoinstallImportHook.find_module):
2436         (AutoinstallImportHook._install_selenium):
2437         (AutoinstallImportHook):
2438         (AutoinstallImportHook._install_chromedriver):
2439         (AutoinstallImportHook._install_geckodriver):
2440         (AutoinstallImportHook.get_latest_pypi_url):
2441         (AutoinstallImportHook.install_binary):
2442         (autoinstall_everything):
2443         (get_driver_filename):
2444         (get_os_info):
2445
2446 2017-07-24  Matthew Stewart  <matthew_r_stewart@apple.com>
2447
2448         Add WebDriver support in browser driver part of BenchmarkRunner
2449         https://bugs.webkit.org/show_bug.cgi?id=174445
2450
2451         Reviewed by Stephanie Lewis.
2452
2453         Adds a launch_driver function to each BrowserDriver subclass. This
2454         function sets up the arguments for the webdriver and launches the
2455         webdriver specific to that browser.
2456
2457         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2458         (BrowserDriver.launch_webdriver):
2459         (BrowserDriver):
2460         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2461         (LinuxBrowserDriver.launch_webdriver):
2462         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
2463         (LinuxChromeDriver.launch_url):
2464         (LinuxChromeDriver):
2465         (LinuxChromeDriver.launch_driver):
2466         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
2467         (EpiphanyBrowserDriver.launch_url):
2468         (EpiphanyBrowserDriver):
2469         (EpiphanyBrowserDriver.launch_driver):
2470         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
2471         (LinuxFirefoxDriver):
2472         (LinuxFirefoxDriver.launch_url):
2473         (LinuxFirefoxDriver.launch_driver):
2474         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
2475         (GTKMiniBrowserDriver.launch_url):
2476         (GTKMiniBrowserDriver):
2477         (GTKMiniBrowserDriver.launch_driver):
2478         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2479         (OSXBrowserDriver._launch_webdriver):
2480         (OSXBrowserDriver):
2481         (OSXBrowserDriver._screen_size):
2482         (OSXBrowserDriver._insert_url):
2483         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2484         (OSXChromeDriver):
2485         (OSXChromeDriver.launch_url):
2486         (OSXChromeDriver.launch_driver):
2487         (OSXChromeCanaryDriver):
2488         (OSXChromeCanaryDriver.launch_url):
2489         (OSXChromeCanaryDriver.launch_driver):
2490         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2491         (OSXFirefoxDriver):
2492         (OSXFirefoxDriver.launch_url):
2493         (OSXFirefoxDriver.launch_driver):
2494         (OSXFirefoxNightlyDriver):
2495         (OSXFirefoxNightlyDriver.launch_url):
2496         (OSXFirefoxNightlyDriver.launch_driver):
2497         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2498         (OSXSafariDriver.launch_driver):
2499
2500 2017-07-24  Wenson Hsieh  <wenson_hsieh@apple.com>
2501
2502         [Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
2503         https://bugs.webkit.org/show_bug.cgi?id=174793
2504
2505         Reviewed by Tim Horton.
2506
2507         Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
2508         down. Without r219765, this test will dereference null and crash.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
2512         * TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
2513         (TEST):
2514
2515 2017-07-24  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2516
2517         [Win] Implement Authentication dialog in MiniBrowser
2518         https://bugs.webkit.org/show_bug.cgi?id=174662
2519
2520         Reviewed by Alex Christensen.
2521
2522         * MiniBrowser/win/Common.cpp:
2523         (CustomUserAgent):
2524         (DisplayAuthDialog):
2525         (AuthDialogProc):
2526         * MiniBrowser/win/MiniBrowserLib.rc:
2527         * MiniBrowser/win/MiniBrowserLibResource.h:
2528         * MiniBrowser/win/ResourceLoadDelegate.cpp:
2529         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2530
2531 2017-07-24  Jonathan Bedard  <jbedard@apple.com>
2532
2533         Handle case where line_numbers is None instead of an array of line numbers
2534         https://bugs.webkit.org/show_bug.cgi?id=174775
2535
2536         Reviewed by Aakash Jain.
2537
2538         Added files set line_numbers to None in process_file.
2539
2540         * Scripts/webkitpy/style/filereader.py:
2541         (TextFileReader.process_file): Handle case where line_number is set to None.
2542         * Scripts/webkitpy/style/main_unittest.py:
2543         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
2544
2545 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2546
2547         [WPE] Add libepoxy to the Jhbuild moduleset
2548         https://bugs.webkit.org/show_bug.cgi?id=174711
2549
2550         Reviewed by Carlos Alberto Lopez Perez.
2551
2552         * wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
2553
2554 2017-07-24  Zan Dobersek  <zdobersek@igalia.com>
2555
2556         [WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
2557         https://bugs.webkit.org/show_bug.cgi?id=174780
2558
2559         Reviewed by Carlos Garcia Campos.
2560
2561         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2562         Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
2563         in case the eglplatform.h header doesn't provide that macro. This replicates
2564         the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
2565
2566 2017-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2567
2568         [iOS WK2] Remove _WKDraggableElementInfo and fold PositionInformationTests into WKRequestActivatedElementInfo
2569         https://bugs.webkit.org/show_bug.cgi?id=174758
2570
2571         Reviewed by Dan Bernstein.
2572
2573         Migrate position-information-related unit tests from the PositionInformationTests suite to
2574         WKRequestActivatedElementInfo as 2 new unit tests. See WebKit2 ChangeLog for more details.
2575
2576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2577         * TestWebKitAPI/Tests/WebKit2Cocoa/WKRequestActivatedElementInfo.mm:
2578         (TestWebKitAPI::checkElementTypeAndBoundingRect):
2579         (TestWebKitAPI::TEST):
2580         * TestWebKitAPI/Tests/ios/PositionInformationTests.mm: Removed.
2581         * TestWebKitAPI/cocoa/TestWKWebView.h:
2582         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2583         (-[TestWKWebView activatedElementAtPosition:]):
2584
2585 2017-07-22  Chris Dumez  <cdumez@apple.com>
2586
2587         REGRESSION(r204565): WKObject is broken
2588         https://bugs.webkit.org/show_bug.cgi?id=174736
2589         <rdar://problem/33246169>
2590
2591         Reviewed by Dan Bernstein.
2592
2593         Add API test that used to crash.
2594
2595         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2596         (TestWebKitAPI::TEST):
2597
2598 2017-07-22  Yusuke Suzuki  <utatane.tea@gmail.com>
2599
2600         [WTF] Extend ThreadGroup::add results from bool to ThreadGroupAddResult
2601         https://bugs.webkit.org/show_bug.cgi?id=174705
2602
2603         Reviewed by Mark Lam.
2604
2605         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2606         (TestWebKitAPI::testThreadGroup):
2607         (TestWebKitAPI::TEST):
2608
2609 2017-07-21  Jonathan Bedard  <jbedard@apple.com>
2610
2611         Fail gracefully when xcrun fails in IOSSimulatorPort constructor
2612         https://bugs.webkit.org/show_bug.cgi?id=174724
2613
2614         Reviewed by Aakash Jain.
2615
2616         * Scripts/webkitpy/port/ios_simulator.py:
2617         (IOSSimulatorPort.__init__): Ignore any errors when attempting to find a running
2618         simulator. Errors here should be treated the same as no simulators found.
2619
2620 2017-07-21  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
2621
2622         [CMake] Add an option to stop build after generating project files
2623         https://bugs.webkit.org/show_bug.cgi?id=174664
2624
2625         Reviewed by Konstantin Tokarev.
2626
2627         Add "--generate-project-only" to stop build after generating project files.
2628
2629         * Scripts/build-webkit: Add '--generate-project-only' option and a checker to stop build.
2630         * Scripts/webkitdirs.pm: Add a function to check '--generate-project-only' option and the same checker as the above
2631         (buildCMakeProjectOrExit): Add a cheker to stop build stop build after generating project files.
2632         (determineIsGenerateProjectOnly): Check if '--generate-project-only' option is specified
2633         (isGenerateProjectOnly): ditto
2634
2635 2017-07-21  Yusuke Suzuki  <utatane.tea@gmail.com>
2636
2637         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
2638         https://bugs.webkit.org/show_bug.cgi?id=174501
2639
2640         Reviewed by Darin Adler.
2641
2642         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2643         (TestWebKitAPI::TEST):
2644
2645 2017-07-20  David Quesada  <david_quesada@apple.com>
2646
2647         Add SPI to notify WKNavigationDelegate about client redirects
2648         https://bugs.webkit.org/show_bug.cgi?id=174680
2649         rdar://problem/33184886
2650
2651         Reviewed by Brady Eidson.
2652
2653         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2654         (-[DidPerformClientRedirectNavigationDelegate _webView:didPerformClientRedirectForNavigation:]):
2655         (TEST):
2656         Add API test for -[id<WKNavigationDelegatePrivate> _webView:didPerformClientRedirectForNavigation:].
2657
2658 2017-07-20  Brady Eidson  <beidson@apple.com>
2659
2660         Test WebKit2CustomProtocolsTest.ProcessPoolDestroyedDuringLoading added in r219664 fails on El Capitan.
2661         https://bugs.webkit.org/show_bug.cgi?id=174685
2662
2663         Reviewed by Andy Estes.
2664
2665         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2666         (TestWebKitAPI::TEST): Use a scoped AutodrainedPool instead of a RetainPtr<NSAutoreleasePool>.
2667
2668 2017-07-20  Brady Eidson  <beidson@apple.com>
2669
2670         Deprecate WebIconDatabase in WebKitLegacy/mac.
2671         https://bugs.webkit.org/show_bug.cgi?id=174607
2672
2673         Reviewed by Alex Christensen.
2674
2675         * DumpRenderTree/mac/TestRunnerMac.mm:
2676
2677 2017-07-20  Jonathan Bedard  <jbedard@apple.com>
2678
2679         lint-test-expectations should be run during style checking
2680         https://bugs.webkit.org/show_bug.cgi?id=173559
2681         <rdar://problem/32854941>
2682
2683         Reviewed by Aakash Jain.
2684
2685         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2686         (TestExpectationsModel._already_seen_better_match): Append returns 'None' when successful,
2687         prevents identifying errors on specific lines in a file.
2688         * Scripts/webkitpy/style/main_unittest.py:
2689         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Test for the
2690         case where a linter error is in the file modified, but the line modified is not related to
2691         the linter error.
2692
2693 2017-07-20  Brady Eidson  <beidson@apple.com>
2694
2695         Remove WebIconDatabase from WebKitLegacy/win.
2696         https://bugs.webkit.org/show_bug.cgi?id=174608
2697
2698         Reviewed by Alex Christensen.
2699
2700         * DumpRenderTree/win/DumpRenderTree.cpp:
2701         (main):
2702         * DumpRenderTree/win/TestRunnerWin.cpp:
2703         (TestRunner::setIconDatabaseEnabled):
2704
2705 2017-07-20  Zan Dobersek  <zdobersek@igalia.com>
2706
2707         [WPE] Adjust priority of GSource used in WKTR's HeadlessViewBackend
2708         https://bugs.webkit.org/show_bug.cgi?id=174671
2709
2710         Reviewed by Carlos Garcia Campos.
2711
2712         * WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
2713         (HeadlessViewBackend::HeadlessViewBackend): Use the RunLoopDispatcher
2714         priority for this source in order to have it dispatched on the same
2715         priority as the other WebKit-controlled GSource objects.
2716
2717 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2718
2719         lint-test-expectations should be run during style checking
2720         https://bugs.webkit.org/show_bug.cgi?id=173559
2721         <rdar://problem/32854941>
2722
2723         Reviewed by Daniel Bates.
2724
2725         Follow up fix addressing style and a few minor bugs.
2726
2727         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2728         (TestExpectationParser.__init__): Use lambda x: x instead of str
2729         (TestExpectationsModel.__init__): Make lambda x: x the default argument.
2730         (TestExpectationsModel._already_seen_better_match): Use a temporary variable to
2731         reduce the calls of _shorten_filename, fix minor bug in appending the current
2732         expectation's line number instead of the previous ones, clarify treatment of None
2733         in file-to-line-number mapping.
2734         (TestExpectations._report_warnings): Collapse call.
2735         * Scripts/webkitpy/style/checkers/test_expectations.py:
2736         (TestExpectationsChecker.lint_test_expectations):
2737         * Scripts/webkitpy/style/filereader.py: Re-write comment.
2738         (TextFileReader.process_file): Add comment explaining treatment of None in
2739         file-to-line-number mapping.
2740         (TextFileReader.delete_file): Collapse call.
2741
2742 2017-07-19  Chris Dumez  <cdumez@apple.com>
2743
2744         Unreviewed attempt to fix API test failure after r219663.
2745
2746         The test was hard-coding an exception string and the string has changed slightly
2747         in r219663.
2748
2749         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
2750         (TEST):
2751
2752 2017-07-19  Megan Gardner  <megan_gardner@apple.com>
2753
2754         Don't write file URLs to iOS Pasteboard
2755         https://bugs.webkit.org/show_bug.cgi?id=174647
2756         <rdar://problem/33199730>
2757
2758         Reviewed by Wenson Hsieh.
2759
2760         Updating tests to reflect the lack of file URLs for images.
2761
2762         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2763         (checkTypeIdentifierAndIsNotOtherTypeIdentifier):
2764         (checkEstimatedSize):
2765         (TestWebKitAPI::TEST):
2766
2767 2017-07-19  Brady Eidson  <beidson@apple.com>
2768
2769         iBooks sometimes crashes when closing a book.
2770         <rdar://problem/31180331> and https://bugs.webkit.org/show_bug.cgi?id=174658
2771
2772         Reviewed by Oliver Hunt.
2773
2774         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2775         (-[ProcessPoolDestroyedDuringLoadingProtocol startLoading]):
2776         (-[ProcessPoolDestroyedDuringLoadingProtocol finishTheLoad]):
2777         (-[ProcessPoolDestroyedDuringLoadingProtocol stopLoading]):
2778         (TestWebKitAPI::TEST):
2779
2780         Add a "spin the runloop X number of times" utility:
2781         * TestWebKitAPI/Utilities.h:
2782         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
2783         (TestWebKitAPI::Util::spinRunLoop):
2784
2785 2017-07-19  Jonathan Bedard  <jbedard@apple.com>
2786
2787         lint-test-expectations should be run during style checking
2788         https://bugs.webkit.org/show_bug.cgi?id=173559
2789         <rdar://problem/32854941>
2790
2791         Reviewed by David Kilzer.
2792
2793         Running the test expectation linter requires reading both files and lines not in the
2794         patch because, for example, deletion of a test can cause a lint failure even though
2795         no test expectations where modified. This means that the linter will occasionally warn
2796         about lines which were not changed in a given patch but whose error is related to a
2797         change made in that patch.
2798
2799         * Scripts/webkitpy/common/system/filesystem_mock.py:
2800         (MockFileSystem.open_text_file_for_reading): Add 'errors' argument to mimic filesystem.
2801         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2802         (TestExpectationWarning): Added class to pass warnings as an object instead of a string.
2803         (TestExpectationWarning.__init__): Construct warning with file name, line number, line
2804         content, description of the error and the name of the associated test.
2805         (TestExpectationWarning.__str__): Convert to string so that existing printing code works.
2806         (TestExpectationParser.__init__): Pass shorten_filename function to
2807         TestExpectationsParser to add a deleted file to the related_files dictionary.
2808         (TestExpectationParser._check_test_exists): If the test does not exist, add the
2809         missing path to the related_files dictionary.
2810         (TestExpectationLine.__init__): Add related_files dictionary, which tracks
2811         files and line numbers related to this test expectation line. This will allow
2812         tracking linter errors in the style checker occurring across multiple files.
2813         (TestExpectationsModel._already_seen_better_match): Add redundant expectation
2814         lines to related_files dictionary.
2815         (TestExpectations.__init__): Pass self._shorten_filename to TestExpectationParser.
2816         (TestExpectations._report_warnings): Construct warning object instead of string
2817         when adding to warnings list.
2818         * Scripts/webkitpy/port/win.py: Changed logging level form warning to debug to
2819         clean-up log.
2820         * Scripts/webkitpy/style/checker.py:
2821         (ProcessorBase.do_association_check): Add required function for processor classes.
2822         (StyleProcessor):
2823         (StyleProcessor.do_association_check): Run the TestExpectations linter when
2824         checking for errors between associated files.
2825         * Scripts/webkitpy/style/checkers/test_expectations.py:
2826         (TestExpectationsChecker.check_test_expectations): Reflect changed import statements.
2827         (TestExpectationsChecker):
2828         (TestExpectationsChecker._should_log_linter_warning): Given a warning, a dictionary
2829         of modified files, the current working directory and the host, determine if the linter
2830         warning is associated with the changes.
2831         (TestExpectationsChecker.lint_test_expectations): Lint test expectations for the
2832         style checker.
2833         * Scripts/webkitpy/style/filereader.py:
2834         (TextFileReader):
2835         (TextFileReader.__init__): Track modified files in dictionary instead of a counter.
2836         (TextFileReader.file_count): Use dictionary to determine the number of modified files.
2837         (TextFileReader.process_file): Track both the number of files changed and which lines
2838         in those files were changed.
2839         (TextFileReader.do_association_check): Run the processor's association check on all
2840         modified or deleted files processed by TextFileReader.
2841         (TextFileReader.delete_file): Track deleted files in _files dictionary.
2842         (TextFileReader.count_delete_only_file): Deleted.
2843         * Scripts/webkitpy/style/filereader_unittest.py:
2844         (TextFileReaderTest.test_delete_file): Renamed function to reflect new function name.
2845         (TextFileReaderTest.test_count_delete_only_file): Moved to test_delete_file.
2846         * Scripts/webkitpy/style/main.py:
2847         (CheckWebKitStyle.main): When running the style checker on a specific list of files,
2848         explicitly run the association check on the file reader.
2849         * Scripts/webkitpy/style/main_unittest.py:
2850         (ExpectationLinterInStyleCheckerTest): Added to test the TestExpectationLinter now
2851         embedded in the style checker.
2852         (ExpectationLinterInStyleCheckerTest.setUp): Set up the style checker configuration.
2853         (ExpectationLinterInStyleCheckerTest._generate_file_reader): Given a filesystem object,
2854         construct the TextFileReader object with a StyleProcessor used to run style checks on
2855         specific files.
2856         (ExpectationLinterInStyleCheckerTest._generate_testing_host): Generate a host used for
2857         testing the test expectation linter inside the style checker. This host must contain a
2858         mock file system with the basic structure of test expectations.
2859         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors):
2860         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line):
2861         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit):
2862         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file):
2863         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit):
2864         * Scripts/webkitpy/style/patchreader.py:
2865         (PatchReader.check): Specify which file was deleted, run the association check.
2866         * Scripts/webkitpy/style/patchreader_unittest.py:
2867         (PatchReaderTest.MockTextFileReader.delete_file): Renamed count_delete_only_file.
2868         (PatchReaderTest.MockTextFileReader.do_association_check): Added.
2869         (PatchReaderTest.MockTextFileReader.count_delete_only_file): Renamed delete_file.
2870
2871 2017-07-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2872
2873         [WTF] Implement WTF::ThreadGroup
2874         https://bugs.webkit.org/show_bug.cgi?id=174081
2875
2876         Reviewed by Mark Lam.
2877
2878         Add WTF::ThreadGroup tests.
2879
2880         * TestWebKitAPI/CMakeLists.txt:
2881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2882         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp: Added.
2883         (TestWebKitAPI::testThreadGroup):
2884         (TestWebKitAPI::TEST):
2885
2886 2017-07-18  Andy Estes  <aestes@apple.com>
2887
2888         [Xcode] Enable CLANG_WARN_RANGE_LOOP_ANALYSIS
2889         https://bugs.webkit.org/show_bug.cgi?id=174631
2890
2891         Reviewed by Tim Horton.
2892
2893         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2894         * MiniBrowser/Configurations/Base.xcconfig:
2895         * MobileMiniBrowser/Configurations/Base.xcconfig:
2896         * TestWebKitAPI/Configurations/Base.xcconfig:
2897         * WebKitTestRunner/Configurations/Base.xcconfig:
2898
2899 2017-07-18  Andy Estes  <aestes@apple.com>
2900
2901         [Xcode] Enable CLANG_WARN_OBJC_LITERAL_CONVERSION
2902         https://bugs.webkit.org/show_bug.cgi?id=174631
2903
2904         Reviewed by Sam Weinig.
2905
2906         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2907         * MiniBrowser/Configurations/Base.xcconfig:
2908         * MobileMiniBrowser/Configurations/Base.xcconfig:
2909         * TestWebKitAPI/Configurations/Base.xcconfig:
2910         * WebKitTestRunner/Configurations/Base.xcconfig:
2911
2912 2017-07-18  Daniel Bates  <dabates@apple.com>
2913
2914         lldb: Add type summary for StringView
2915         https://bugs.webkit.org/show_bug.cgi?id=174637
2916
2917         Reviewed by Sam Weinig.
2918
2919         For debugging convenience, adds a pretty-print type summary for StringView. Evaluating a
2920         StringView object will print output that has the form:
2921
2922             (WTF::StringView) $4 = { length = 2, contents = 'li' } {
2923               m_characters = 0x000000011b57abb5 "eeeeeefjh0n"
2924               m_length = 2
2925               m_is8Bit = true
2926               m_underlyingString = 0x0000614000000a90
2927             }
2928
2929         * lldb/lldb_webkit.py:
2930         (__lldb_init_module): Use WTFStringView_SummaryProvider to format StringView types.
2931         (WTFStringView_SummaryProvider):
2932         (WTFStringViewProvider):
2933         (WTFStringViewProvider.__init__):
2934         (WTFStringViewProvider.is_8bit): Access field StringView.m_is8Bit.
2935         (WTFStringViewProvider.get_length): Access field StringView.m_length.
2936         (WTFStringViewProvider.get_characters): Access field StringView.m_characters.
2937         (WTFStringViewProvider.to_string): Returns the string represented by the StringView.
2938
2939 2017-07-18  Andy Estes  <aestes@apple.com>
2940
2941         [Xcode] Enable CLANG_WARN_NON_LITERAL_NULL_CONVERSION
2942         https://bugs.webkit.org/show_bug.cgi?id=174631
2943
2944         Reviewed by Dan Bernstein.
2945
2946         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2947         * MiniBrowser/Configurations/Base.xcconfig:
2948         * MobileMiniBrowser/Configurations/Base.xcconfig:
2949         * TestWebKitAPI/Configurations/Base.xcconfig:
2950         * WebKitTestRunner/Configurations/Base.xcconfig:
2951
2952 2017-07-18  Devin Rousso  <drousso@apple.com>
2953
2954         Web Inspector: Add memoryCost to Inspector Protocol objects
2955         https://bugs.webkit.org/show_bug.cgi?id=174478
2956
2957         Reviewed by Joseph Pecoraro.
2958
2959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2960         * TestWebKitAPI/Tests/JavaScriptCore/InspectorValue.cpp: Added.
2961         (TestWebKitAPI::TEST(InspectorValue, MemoryCostNull)):
2962         (TestWebKitAPI::TEST(InspectorValue, MemoryCostBoolean)):
2963         (TestWebKitAPI::TEST(InspectorValue, MemoryCostDouble)):
2964         (TestWebKitAPI::TEST(InspectorValue, MemoryCostInteger)):
2965         (TestWebKitAPI::TEST(InspectorValue, MemoryCostString)):
2966         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringEmpty)):
2967         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringNull)):
2968         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringGrowing)):
2969         (TestWebKitAPI::TEST(InspectorValue, MemoryCostStringUnicode)):
2970         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObject)):
2971         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectEmpty)):
2972         (TestWebKitAPI::TEST(InspectorValue, MemoryCostObjectGrowing)):
2973         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArray)):
2974         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayEmpty)):
2975         (TestWebKitAPI::TEST(InspectorValue, MemoryCostArrayGrowing)):
2976
2977 2017-07-18  Andy Estes  <aestes@apple.com>
2978
2979         [Xcode] Enable CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING
2980         https://bugs.webkit.org/show_bug.cgi?id=174631
2981
2982         Reviewed by Darin Adler.
2983
2984         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2985         * MiniBrowser/Configurations/Base.xcconfig:
2986         * MobileMiniBrowser/Configurations/Base.xcconfig:
2987         * TestWebKitAPI/Configurations/Base.xcconfig:
2988         * WebKitTestRunner/Configurations/Base.xcconfig:
2989
2990 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2991
2992         Unreviewed, fix the iOS build.
2993
2994         I missed a spot when renaming -synchronouslyLoadHTML: to -synchronouslyLoadHTMLString:.
2995
2996         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
2997         (TestWebKitAPI::TEST):
2998
2999 2017-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3000
3001         [iOS DnD] Web process uses too much memory when beginning a drag on a very large image
3002         https://bugs.webkit.org/show_bug.cgi?id=174585
3003         <rdar://problem/33302541>
3004
3005         Reviewed by Tim Horton.
3006
3007         Adds a new test verifying that we don't try to allocate any image buffer equal to the true size of the image
3008         being dragged when initiating a drag.
3009
3010         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3011         * TestWebKitAPI/Tests/WebKit2Cocoa/enormous.svg: Added.
3012         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3013         (TestWebKitAPI::TEST):
3014         * TestWebKitAPI/cocoa/TestWKWebView.h:
3015
3016         Add a new -synchronouslyLoadHTMLString: helper that works like -synchronouslyLoadTestPage:, but takes markup.
3017
3018         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3019         (-[TestWKWebView synchronouslyLoadHTMLString:]):
3020
3021 2017-07-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3022
3023         [CMake] Macros in WebKitMacros.cmake should be prefixed with WEBKIT_ namespace
3024         https://bugs.webkit.org/show_bug.cgi?id=174547
3025
3026         Reviewed by Alex Christensen.
3027
3028         * DumpRenderTree/PlatformWin.cmake:
3029         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3030
3031 2017-07-17  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
3032
3033         Update style checker to deal with "final"
3034         https://bugs.webkit.org/show_bug.cgi?id=174528
3035
3036         Reviewed by Alex Christensen.
3037         
3038         check-webkit-style shouldn't complain about an open brace to start a
3039         line after a function definition with "final" or "const final".
3040
3041         * Scripts/webkitpy/style/checkers/cpp.py:
3042         (check_braces):
3043         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3044         (CppStyleTest.test_brace_at_begin_of_line):
3045
3046 2017-07-17  Alex Christensen  <achristensen@webkit.org>
3047
3048         Modernize content extension code
3049         https://bugs.webkit.org/show_bug.cgi?id=174588
3050
3051         Reviewed by Sam Weinig.
3052
3053         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3054         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3055         (TestWebKitAPI::testRequest):
3056         (TestWebKitAPI::makeBackend):
3057         (TestWebKitAPI::TEST_F):
3058
3059 2017-07-17  Brady Eidson  <beidson@apple.com>
3060
3061         WKHTTPCookieStore observing only works on the default cookie store.
3062         <rdar://problem/33330724> and https://bugs.webkit.org/show_bug.cgi?id=174580
3063
3064         Reviewed by Sam Weinig.
3065
3066         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3067         (runTestWithWebsiteDataStore): Refactor the cookie observing test out so it can be
3068           called for the default store, a non-persistent store, and a custom store.
3069         (TEST):
3070
3071 2017-07-16  Sam Weinig  <sam@webkit.org>
3072
3073         [Scripts] Fix missing variable warnings from svn-create-patch when there are untracked files
3074         https://bugs.webkit.org/show_bug.cgi?id=174575
3075
3076         Reviewed by Brady Eidson.
3077
3078         * Scripts/svn-create-patch:
3079         (findModificationType):
3080         Add support for more status codes. C -> conflicted, ? -> untracked, ! -> missing. Give a
3081         default value of "unknown".
3082
3083         (generateFileList):
3084         Handle all the new modification types. Abort on conflicted, missing, and unknown. Log
3085         for untracked, which matches our old behavior.
3086
3087 2017-07-17  Charlie Turner  <cturner@igalia.com>
3088
3089         Add some missing build dependencies on Fedora
3090         https://bugs.webkit.org/show_bug.cgi?id=174578
3091
3092         Unreviewed dependency update.
3093
3094         * gtk/install-dependencies:
3095
3096 2017-07-16  Brady Eidson  <beidson@apple.com>
3097
3098         Crash when a WKHTTPCookieStore outlives its owning WKWebsiteDataStore.
3099         <rdar://problem/33341730> and https://bugs.webkit.org/show_bug.cgi?id=174574
3100
3101         Reviewed by Tim Horton.
3102
3103         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3104         (-[CookieNavigationDelegate webView:didFinishNavigation:]):
3105         (TEST):
3106
3107 2017-07-16  Bernhard M. Wiedemann  <bwiedemann@suse.de>
3108
3109         [GTK] Sort inspector GResource manifest to ensure reproducible builds
3110         https://bugs.webkit.org/show_bug.cgi?id=174540
3111
3112         Reviewed by Michael Catanzaro.
3113
3114         * gtk/generate-inspector-gresource-manifest.py:
3115         (get_filenames): sort list of input files
3116
3117 2017-07-15  Brady Eidson  <beidson@apple.com>
3118
3119         Make sure all CFHTTPCookieStorageRefs we create are scheduled.
3120         <rdar://problem/33221110> and https://bugs.webkit.org/show_bug.cgi?id=174513
3121
3122         Reviewed by Tim Horton.
3123
3124         * TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
3125         (TEST): Make this test more reliable by clearing everything beforehand.
3126
3127 2017-07-15  David Kilzer  <ddkilzer@apple.com>
3128
3129         Make it possible to extend check-webkit-style with Apple-internal checkers
3130         <https://webkit.org/b/174464>
3131         <rdar://problem/25564402>
3132
3133         Reviewed by Darin Adler.
3134
3135         * Scripts/webkitpy/style/checker.py: Import apple_additions.
3136         (_all_categories): Add categories from apple_additions() if it
3137         exists.
3138         (CheckerDispatcher._create_checker): Create python checker
3139         from apple_additions() if it exists.
3140
3141 2017-07-15  Wenson Hsieh  <wenson_hsieh@apple.com>
3142
3143         [iOS WK2] Presenting an action sheet on an image map prevents selection UI from updating
3144         https://bugs.webkit.org/show_bug.cgi?id=174539
3145         <rdar://problem/33307395>
3146
3147         Reviewed by Darin Adler.
3148
3149         Adds a new unit test suite to cover action sheet popover presentation.
3150
3151         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3152         * TestWebKitAPI/Tests/WebKit2Cocoa/image-map.html: Added.
3153         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm: Added.
3154         (-[ActionSheetObserver waitForActionSheetAfterBlock:]):
3155
3156         Runs the given block and waits until the UI process has indicated that it will present an action sheet.
3157
3158         (-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
3159         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
3160
3161         Helper class to alter the behavior of [[UIDevice currentDevice] userInterfaceIdiom] for testing.
3162
3163         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
3164         (TestWebKitAPI::TEST):
3165
3166 2017-07-15  Sam Weinig  <sam@webkit.org>
3167
3168         [Scripts] Make svn-create-patch work better when called in sub directories
3169         https://bugs.webkit.org/show_bug.cgi?id=174551
3170
3171         Reviewed by Darin Adler.
3172
3173         - Fixes manufacturePatchForAdditionWithHistory to use the correct path
3174           by ensuring that the prefix is applied as is done in generateDiff.
3175         - Silence output of explanatory lines from svn stat (" > move to ...")
3176           that show up in STDERR when running svn-create-patch.
3177         - Add verbose logging that I found useful while debugging this issue.
3178
3179         * Scripts/svn-create-patch:
3180         (findBaseUrl):
3181         (findMimeType):
3182         (findSourceFileAndRevision):
3183         (generateDiff):
3184         (generateFileList):
3185         (manufacturePatchForAdditionWithHistory):
3186
3187 2017-07-15  Jonathan Bedard  <jbedard@apple.com>
3188
3189         Unreviewed build fix after r219537.
3190
3191         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3192
3193 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3194
3195         Add iOS 11 SPI
3196         https://bugs.webkit.org/show_bug.cgi?id=174430
3197         <rdar://problem/33269288>
3198
3199         Reviewed by Tim Horton.
3200
3201         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Define drag-and-drop API required for testing.
3202         * TestWebKitAPI/ios/DataInteractionSimulator.h: Ditto.
3203         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Ditto.
3204
3205 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3206
3207         Failing to install on iPad simulators
3208         https://bugs.webkit.org/show_bug.cgi?id=174532
3209         <rdar://problem/33328347>
3210
3211         Reviewed by Stephanie Lewis.
3212
3213         * Scripts/webkitpy/xcode/simulated_device.py:
3214         (SimulatedDevice.install_app): Place install command in retry try-except block.
3215
3216 2017-07-14  Jeff Miller  <jeffm@apple.com>
3217
3218         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3219         https://bugs.webkit.org/show_bug.cgi?id=174524
3220
3221         Reviewed by Sam Weinig.
3222
3223         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParameters.mm:
3224         (TEST):
3225         Renamed TestParameter to TestParameter1.
3226         Add test for -[WKProcessPool _setObjectsForBundleParametersWithDictionary:].
3227
3228         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3229         (-[BundleParametersPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3230         Observe changes for two bundle parameters.
3231
3232         (-[BundleParametersPlugIn dealloc]):
3233         Remove observers for two bundle parameters.
3234
3235 2017-07-14  Commit Queue  <commit-queue@webkit.org>
3236
3237         Unreviewed, rolling out r219510.
3238         https://bugs.webkit.org/show_bug.cgi?id=174525
3239
3240         Need to revert length() == 0 check for null string (Requested
3241         by yusukesuzuki on #webkit).
3242
3243         Reverted changeset:
3244
3245         "[WTF] Newly added AtomicStringImpl should use BufferInternal
3246         static string if StringImpl is static"
3247         https://bugs.webkit.org/show_bug.cgi?id=174501
3248         http://trac.webkit.org/changeset/219510
3249
3250 2017-07-14  Jer Noble  <jer.noble@apple.com>
3251
3252         [MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
3253         https://bugs.webkit.org/show_bug.cgi?id=174514
3254
3255         Reviewed by Sam Weinig.
3256
3257         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp:
3258         (TestWebKitAPI::TEST_F):
3259
3260 2017-07-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3261
3262         [WTF] Newly added AtomicStringImpl should use BufferInternal static string if StringImpl is static
3263         https://bugs.webkit.org/show_bug.cgi?id=174501
3264
3265         Reviewed by Darin Adler.
3266
3267         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3268         (TestWebKitAPI::TEST):
3269
3270 2017-07-14  Jonathan Bedard  <jbedard@apple.com>
3271
3272         Bring mac expectations in-line with other platforms
3273         https://bugs.webkit.org/show_bug.cgi?id=174472
3274         <rdar://problem/33297388>
3275
3276         Reviewed by David Kilzer.
3277
3278         The override order for Mac test expectations does not conform to the pattern used by iOS,
3279         GTK, Windows and WPE. Before this change, El Capitan's baseline search path looks like this:
3280
3281             platform/mac-wk2
3282             platform/wk2
3283             platform/mac-elcapitan
3284             platform/mac-sierra
3285             generic
3286
3287         After this change, El Capitan's baseline search path looks like this:
3288
3289             platform/mac-sierra-wk2
3290             platform/mac-sierra
3291             platform/mac-wk2
3292             platform/wk2
3293             generic
3294
3295         * Scripts/webkitpy/port/mac.py:
3296         (MacPort.__init__): If a specific version is specified in the port name, use that
3297         as the os version.
3298         (MacPort.default_baseline_search_path): Expectation search paths should work the
3299         same way they do on other ports. Port + version overrides port, port overrides generic
3300         and wk1/wk2 should override expectations for the two combined.
3301         * Scripts/webkitpy/port/mac_unittest.py:
3302         (MacTest.test_tests_for_other_platforms): Deleted.
3303         (MacTest._assert_search_path): Deleted.
3304         (MacTest.test_baseline_search_path): Deleted.
3305         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3306         (TestRebaselineTest.test_baseline_directory): Adjust expectations for new over-ride order.
3307         (test_rebaseline_test_and_print_scm_changes): Ditto.
3308         (test_rebaseline_and_copy_test): Ditto.
3309         (test_rebaseline_and_copy_test_no_existing_result): Ditto.
3310         (test_rebaseline_and_copy_test_with_lion_result): Ditto.
3311         (test_rebaseline_and_copy_no_overwrite_test): Ditto.
3312
3313 2017-07-13  Michael Catanzaro  <mcatanzaro@igalia.com>
3314
3315         Fix style checker unit test
3316
3317         Unreviewed WebKit2 => WebKit fixup.
3318
3319         * Scripts/webkitpy/style/checker_unittest.py:
3320         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
3321
3322 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3323
3324         Use the old WebKit/WebKit2 targets for CMake builds. (v2)
3325
3326         Unreviewed build fix.
3327
3328         r219492 missed one hunk from its partial revert of r219489.
3329         This patch reverts that hunk.
3330
3331         * TestWebKitAPI/CMakeLists.txt:
3332
3333 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3334
3335         Use the old WebKit/WebKit2 targets for CMake builds.
3336
3337         Unreviewed build fix.
3338
3339         We can update the target names to match the Framework names in a future patch.
3340         This is a partial revert of r219489.
3341
3342         * TestWebKitAPI/CMakeLists.txt:
3343         WebKitLegacy => WebKit
3344         WebKit => WebKit2
3345
3346 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3347
3348         Fix TestWebKit API.
3349         https://bugs.webkit.org/show_bug.cgi?id=174164
3350         rdar://problem/33137595
3351
3352         Reviewed by Dan Bernstein.
3353
3354         * TestWebKitAPI/CMakeLists.txt:
3355         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3356         * TestWebKitAPI/PlatformGTK.cmake:
3357
3358 2017-07-13  Matthew Hanson  <matthew_hanson@apple.com>
3359
3360         Update tools and configurations after renaming Source/WebKit2 to Source/WebKit.
3361         https://bugs.webkit.org/show_bug.cgi?id=174164
3362         rdar://problem/33137595
3363
3364         Reviewed by Dan Bernstein.
3365
3366         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3367         (ShouldBuildTest):
3368         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3369         * Scripts/build-webkit:
3370         * Scripts/do-file-rename:
3371         * Scripts/do-webcore-rename:
3372         * Scripts/update-webkit-localizable-strings:
3373         * Scripts/webkitpy/common/config/watchlist:
3374         * Scripts/webkitpy/style/checker.py:
3375         * Scripts/webkitpy/style/checkers/featuredefines.py:
3376         * gtk/make-dist.py:
3377         (ensure_version_if_possible):
3378         * gtk/manifest.txt.in:
3379
3380 2017-07-05  Matthew Hanson  <matthew_hanson@apple.com>
3381
3382         Update tools and configurations after renaming Source/WebKit to Source/WebKitLegacy.
3383         https://bugs.webkit.org/show_bug.cgi?id=174162
3384         rdar://problem/33137594
3385
3386         Reviewed by Dan Bernstein.
3387
3388         Mass rename of Source/WebKit to Source/WebKitLegacy in OpenSource tooling.
3389
3390         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3391         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
3392         * EWSTools/configure-clang-linux.sh:
3393         * Scripts/build-webkit:
3394         * Scripts/do-file-rename:
3395         * Scripts/do-webcore-rename:
3396         * Scripts/update-webkit-localizable-strings:
3397         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3398         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
3399         * Scripts/webkitpy/style/checkers/featuredefines.py:
3400         * gtk/manifest.txt.in:
3401
3402 2017-07-13  Jonathan Bedard  <jbedard@apple.com>
3403
3404         Add script to rebase patches during the WebKit2->WebKit/WebKit->WebKitLegacy transition
3405         https://bugs.webkit.org/show_bug.cgi?id=174438
3406         <rdar://problem/33277112>
3407
3408         Reviewed by Aakash Jain.
3409
3410         Given a patch, this will convert the changes from the path to the new directory structure.
3411
3412         * Scripts/rebase-patch-after-webkit-move: Added.
3413         (append_source): Append 'Source' to the provided path.
3414         (is_editable_line): Return true if a line the script expects to modify.
3415         (needs_rebase): Return if a line needs to be rebased based on it's content.
3416         (rebase_line): Rebase the provided line.
3417         (rebase): Rebase a patch given the lines of that patch and a file to output the rebased patch to.
3418         (parse_arguments): Parse the command line arguments and return the patches to be rebased, if they
3419         were provided.
3420
3421 2017-07-12  Nan Wang  <n_wang@apple.com>
3422
3423         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3424         https://bugs.webkit.org/show_bug.cgi?id=174393
3425         <rdar://problem/33248006>
3426
3427         Reviewed by Chris Fleizach.
3428
3429         * DumpRenderTree/AccessibilityUIElement.cpp:
3430         (textMarkerRangeMatchesTextNearMarkersCallback):
3431         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3432         (AccessibilityUIElement::getJSClass):
3433         * DumpRenderTree/AccessibilityUIElement.h:
3434         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3435         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3436         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3437         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3438         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3439         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3440         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3441         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3442
3443 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3444
3445         Unreviewed, rolling out r219409.
3446
3447         The revision caused the Windows builds to fail.
3448
3449         Reverted changeset:
3450
3451         "AX: [iOS] Implement a way to retrieve a text marker range
3452         with desired text that is closest to a position"
3453         https://bugs.webkit.org/show_bug.cgi?id=174393
3454         http://trac.webkit.org/changeset/219409
3455
3456 2017-07-12  Nan Wang  <n_wang@apple.com>
3457
3458         AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
3459         https://bugs.webkit.org/show_bug.cgi?id=174393
3460         <rdar://problem/33248006>
3461
3462         Reviewed by Chris Fleizach.
3463
3464         * DumpRenderTree/AccessibilityUIElement.cpp:
3465         (textMarkerRangeMatchesTextNearMarkersCallback):
3466         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3467         (AccessibilityUIElement::getJSClass):
3468         * DumpRenderTree/AccessibilityUIElement.h:
3469         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3470         (AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3471         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3472         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3473         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3474         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3475         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3476         (WTR::AccessibilityUIElement::textMarkerRangeMatchesTextNearMarkers):
3477
3478 2017-07-12  Emilio Cobos Álvarez  <ecobos@igalia.com>
3479
3480         Make prepare-ChangeLog -g <commit> generate a more standard ChangeLog entry.
3481         https://bugs.webkit.org/show_bug.cgi?id=174197
3482
3483         Reviewed by Darin Adler.
3484
3485         This bit me the first time I tried to submit a patch to WebKit, and still I have
3486         to manually edit the ChangeLog every time I use the script.
3487
3488         This generates a more convenient and standard ChangeLog entry.
3489
3490         * Scripts/prepare-ChangeLog:
3491         (generateNewChangeLogs):
3492
3493 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3494
3495         Unreviewed, rolling out r219401.
3496
3497         This revision rolled out the previous patch, but after talking
3498         with reviewer, a rebaseline is what was needed.Rolling back in
3499         before rebaseline.
3500
3501         Reverted changeset:
3502
3503         "Unreviewed, rolling out r219379."
3504         https://bugs.webkit.org/show_bug.cgi?id=174400
3505         http://trac.webkit.org/changeset/219401
3506
3507 2017-07-12  Matt Lewis  <jlewis3@apple.com>
3508
3509         Unreviewed, rolling out r219379.
3510
3511         This revision caused a consistent failure in the test
3512         fast/dom/Window/property-access-on-cached-window-after-frame-
3513         removed.html.
3514
3515         Reverted changeset:
3516
3517         "Remove NAVIGATOR_HWCONCURRENCY"
3518         https://bugs.webkit.org/show_bug.cgi?id=174400
3519         http://trac.webkit.org/changeset/219379
3520
3521 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3522
3523         [WPE] Use libepoxy
3524         https://bugs.webkit.org/show_bug.cgi?id=172104
3525
3526         Reviewed by Michael Catanzaro.
3527
3528         * WebKitTestRunner/wpe/HeadlessViewBackend.h:
3529         Include the <epoxy/egl.h> header, dropping the EGL and GLES2 inclusions.
3530
3531 2017-07-12  Zan Dobersek  <zdobersek@igalia.com>
3532
3533         [GTK][WPE] Align Jhbuild patches for GStreamer packages
3534         https://bugs.webkit.org/show_bug.cgi?id=174363
3535
3536         Reviewed by Michael Catanzaro.
3537
3538         Align the patches we apply over Jhbuild-managed GStreamer dependency packages
3539         between the GTK+ and WPE port. There's no reason for the two ports to apply
3540         different patches over same versions of GStreamer releases.
3541
3542         This aligns the two ports on this specific issue. Next we'll look into
3543         creating a single GStreamer-specific Jhbuild moduleset that will allow us
3544         to keep these patches in a single place, avoiding duplicate files.
3545
3546         * gtk/jhbuild.modules:
3547         * gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Added.
3548         * gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch.
3549         * gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Added.
3550         * wpe/patches/gstreamer-typefind-Only-push-a-CAPS-event-downstream-if-the-.patch: Removed.
3551
3552 2017-07-11  Dean Jackson  <dino@apple.com>
3553
3554         Remove NAVIGATOR_HWCONCURRENCY
3555         https://bugs.webkit.org/show_bug.cgi?id=174400
3556
3557         Reviewed by Sam Weinig.
3558
3559         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3560
3561 2017-07-11  Ansh Shukla  <ansh_shukla@apple.com>
3562
3563         WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties
3564         https://bugs.webkit.org/show_bug.cgi?id=174239
3565
3566         Reviewed by Brady Eidson.
3567
3568         Create windows with specific features set and make sure those are properly reflected in the
3569         WKWindowFeatures object.
3570
3571         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3572         (resetToConsistentState):
3573         (-[CheckWindowFeaturesUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3574         (TEST):
3575
3576 2017-07-11  Jonathan Bedard  <jbedard@apple.com>
3577
3578         Do not duplicate files when deleting directories with svn 1.9
3579         https://bugs.webkit.org/show_bug.cgi?id=174339
3580         <rdar://problem/33226781>
3581
3582         Reviewed by David Kilzer.
3583
3584         * Scripts/svn-create-patch:
3585         (diffOptionsForFile): No longer pass -N option, since this does not work in SVN 1.9.4.
3586         (generateFileList): Determine which files are deleted because they are part of a
3587         directory being deleted.
3588
3589 2017-07-11  Dean Jackson  <dino@apple.com>
3590
3591         Rolling out r219372.
3592
3593         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3594
3595 2017-07-11  Dean Jackson  <dino@apple.com>
3596
3597         Remove NAVIGATOR_HWCONCURRENCY
3598         https://bugs.webkit.org/show_bug.cgi?id=174400
3599
3600         Reviewed by Sam Weinig.
3601
3602         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3603
3604 2017-07-11  Lucas Forschler  <lforschler@apple.com>
3605
3606         Teach build workers to fetch archives from S3.
3607         https://bugs.webkit.org/show_bug.cgi?id=174384